[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065056#comment-15065056 ] Wei Zheng commented on HIVE-12685: -- There's a new mismatch from the last run of ptest: {code} org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testAddPartitions {code} But the test passes locally on my laptop. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch, HIVE-12685.4.patch, HIVE-12685.5.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061725#comment-15061725 ] Hive QA commented on HIVE-12685: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12778134/HIVE-12685.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 17 failed/errored test(s), 9949 tests executed *Failed tests:* {noformat} TestCliDriver-authorization_create_table_owner_privs.q-create_func1.q-partition_wise_fileformat.q-and-12-more - did not produce a TEST-*.xml file TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_order2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union9 org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles org.apache.hive.spark.client.TestSparkClient.testCounters org.apache.hive.spark.client.TestSparkClient.testErrorJob org.apache.hive.spark.client.TestSparkClient.testJobSubmission org.apache.hive.spark.client.TestSparkClient.testMetricsCollection org.apache.hive.spark.client.TestSparkClient.testRemoteClient org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob org.apache.hive.spark.client.TestSparkClient.testSyncRpc {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6378/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6378/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6378/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 17 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12778134 - PreCommit-HIVE-TRUNK-Build > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062524#comment-15062524 ] Wei Zheng commented on HIVE-12685: -- Test failures are not related > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062703#comment-15062703 ] Mohit Sabharwal commented on HIVE-12685: Thanks, [~wzheng] I think "javax.jdo.option.ConnectionDriverName" cannot be used instead of "test.property1", because that testcase is about using a property only defined in hive-site.xml. But "javax.jdo.option.ConnectionDriverName" is defined in ConfVar, no ? Looks like there are three testcases: 1) Override a property defined in ConfVar in data/conf/hive-site.xml: We can choose a dummy property defined in ConfVar like: {code} // ConfVar overridden in in hive-site.xml checkHadoopConf(ConfVars.HIVETESTMODEDUMMYSTATAGGR.varname, null); checkConfVar(ConfVars.HIVETESTMODEDUMMYSTATAGGR, ""); checkHiveConf(ConfVars.HIVETESTMODEDUMMYSTATAGGR.varname, "test"); {code} And we can override it in data/conf/hive-site.xml: {code} + + hive.test.dummystats.aggregator + test + {code} 2) Property only defined in hive-site (but not in ConfVar or hadoop conf): {code} // Property defined in hive-site.xml only checkHadoopConf("test.property1", null); checkHiveConf("test.property1", "hive-site.xml"); {code} For this, we can move test.property1 from common/src/test/resources/hive-site.xml to data/conf/hive-site.xml 3) Test HiveConf property variable substitution in hive-site.xml For this, we can also move test.var.hiveconf.property from common/src/test/resources/hive-site.xml to data/conf/hive-site.xml as you did in your latest patch. Let me know if this makes sense or I'm missing something. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch, HIVE-12685.4.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062565#comment-15062565 ] Mohit Sabharwal commented on HIVE-12685: Thanks, [~wzheng]. Couple of comments: - Better to reference ConfVars.METASTORE_CONNECTION_DRIVER.varname than use the literal directly. - Seems like the patch removes some unit test functionality in TestHiveConf. {code} // Property defined in hive-site.xml only -checkHadoopConf("test.property1", null); -checkHiveConf("test.property1", "hive-site.xml"); {code} Should we keep the test & move these properties from common/src/test/resources/hive-site.xml to data/conf/hive-site.xml ? Also, looks like patch is no longer testing this scenario {code} -// Test HiveConf property variable substitution in hive-site.xml {code} Perhaps instead of using METASTORE_CONNECTION_DRIVER property for testing, we can use a dummy property like HIVETESTMODEDUMMYSTATAGGR, so that it doesn't affect other unit tests? > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062975#comment-15062975 ] Ashutosh Chauhan commented on HIVE-12685: - +1 LGTM > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch, HIVE-12685.4.patch, HIVE-12685.5.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062891#comment-15062891 ] Mohit Sabharwal commented on HIVE-12685: Thanks, [~wzheng]! LGTM. +1(non-binding) pending test. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch, HIVE-12685.4.patch, HIVE-12685.5.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063654#comment-15063654 ] Hive QA commented on HIVE-12685: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12778345/HIVE-12685.5.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 9965 tests executed *Failed tests:* {noformat} TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_order2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union9 org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testAddPartitions org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testFetchingPartitionsWithDifferentSchemas org.apache.hadoop.hive.metastore.TestHiveMetaStorePartitionSpecs.testGetPartitionSpecs_WithAndWithoutPartitionGrouping org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles org.apache.hive.spark.client.TestSparkClient.testCounters org.apache.hive.spark.client.TestSparkClient.testErrorJob org.apache.hive.spark.client.TestSparkClient.testJobSubmission org.apache.hive.spark.client.TestSparkClient.testMetricsCollection org.apache.hive.spark.client.TestSparkClient.testRemoteClient org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob org.apache.hive.spark.client.TestSparkClient.testSyncRpc {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6392/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6392/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6392/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 19 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12778345 - PreCommit-HIVE-TRUNK-Build > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch, HIVE-12685.4.patch, HIVE-12685.5.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062620#comment-15062620 ] Wei Zheng commented on HIVE-12685: -- [~mohitsabharwal] Thanks for the feedback. The code below is doing the same thing but serve for different purposes, one to uses the varname, the other uses the literal. {code} // ConfVar overridden in in hive-site.xml checkHadoopConf(ConfVars.METASTORE_CONNECTION_DRIVER.varname, null); checkConfVar(ConfVars.METASTORE_CONNECTION_DRIVER, "org.apache.derby.jdbc.EmbeddedDriver"); // Property defined in hive-site.xml only checkHadoopConf("javax.jdo.option.ConnectionDriverName", null); checkHiveConf("javax.jdo.option.ConnectionDriverName", "org.apache.derby.jdbc.EmbeddedDriver"); {code} So basically the second part replaces "test.property1". I agree with you for the last part being removed, I've added that dummy property to data/conf/hive-site.xml. Kindly take a look at patch 4. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061138#comment-15061138 ] Wei Zheng commented on HIVE-12685: -- [~ashutoshc] Can you take a look? > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, > HIVE-12685.3.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061131#comment-15061131 ] Wei Zheng commented on HIVE-12685: -- Currently we have difference versions of hive-site.xml located everywhere {code} wzheng /tmp/hive $ find . -name hive-site.xml ./beeline/src/test/resources/hive-site.xml ./common/src/test/resources/hive-site.xml ./conf/hive-site.xml ./data/conf/hive-site.xml ./data/conf/llap/hive-site.xml ./data/conf/perf-reg/hive-site.xml ./data/conf/spark/standalone/hive-site.xml ./data/conf/spark/yarn-client/hive-site.xml ./data/conf/tez/hive-site.xml ./hcatalog/src/test/e2e/templeton/deployers/config/hive/hive-site.xml {code} The one causing problem of this JIRA is common/src/test/resources/hive-site.xml Instead of maintaining multiple pieces, we should get rid of unnecessary hive-site.xml as much as possible. So we should remove common/src/test/resources/hive-site.xml and just use the default one from data/conf (for TestHiveConf). > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059704#comment-15059704 ] Wei Zheng commented on HIVE-12685: -- I think patch 2 won't work for some cases. We need to somehow fall back to using the hive-site.xml target/tmp/conf directory. This is like an incorrect Maven dependency issue. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059226#comment-15059226 ] Wei Zheng commented on HIVE-12685: -- This issue is exposed by HIVE-12628, which included hive-common as ql dependency. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml
[ https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059554#comment-15059554 ] Mohit Sabharwal commented on HIVE-12685: [~wzheng], FYI I think this invalid property was also causing following tests to fail: TestSessionHooks TestPlainSaslHelper TestSessionGlobalInitFile I filed HIVE-12670 for this. But after removing the property, these tests still fail with other errors. I haven't investigated yet, but I'd be curious to see if these fail after your patch. > Remove invalid property in common/src/test/resources/hive-site.xml > -- > > Key: HIVE-12685 > URL: https://issues.apache.org/jira/browse/HIVE-12685 > Project: Hive > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-12685.1.patch > > > Currently there's such a property as below, which is obviously wrong > {code} > > javax.jdo.option.ConnectionDriverName > hive-site.xml > Override ConfVar defined in HiveConf > > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)