Re: [PR] NIFI-13026 - Add a read only mode to non secured NiFi Registry [nifi]
pvillard31 closed pull request #8630: NIFI-13026 - Add a read only mode to non secured NiFi Registry URL: https://github.com/apache/nifi/pull/8630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13026) Add a read only mode to non secured NiFi Registry
[ https://issues.apache.org/jira/browse/NIFI-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13026: -- Resolution: Won't Do Status: Resolved (was: Patch Available) > Add a read only mode to non secured NiFi Registry > - > > Key: NIFI-13026 > URL: https://issues.apache.org/jira/browse/NIFI-13026 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 50m > Remaining Estimate: 0h > > There are scenarios where NiFi Registry may be deployed in a non secured way. > When doing so, as of now, all users access would be anonymous and all > permissions would be granted. This improvement is to allow for a read-only > mode when NiFi Registry is not secured so that all users can access NiFi > Registry but only perform READ actions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13026 - Add a read only mode to non secured NiFi Registry [nifi]
pvillard31 commented on PR #8630: URL: https://github.com/apache/nifi/pull/8630#issuecomment-2050549928 Closing as this is a very particular edge case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * Replay last event * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Parameter ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) *
[jira] [Created] (NIFI-13029) Download Flow Definition
Rob Fellows created NIFI-13029: -- Summary: Download Flow Definition Key: NIFI-13029 URL: https://issues.apache.org/jira/browse/NIFI-13029 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12890) Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12890: --- Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool > -- > > Key: NIFI-12890 > URL: https://issues.apache.org/jira/browse/NIFI-12890 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > The AbstractDBCPConnectionPool was designed to avoid code duplication within > the DBCP services. It encompasses shared variables and is constructed in a > way that it contains numerous methods which can be overridden if we wish to > subclass from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) [nifi]
turcsanyip commented on PR #8623: URL: https://github.com/apache/nifi/pull/8623#issuecomment-2050431851 Merged to support/nifi-1.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) [nifi]
turcsanyip closed pull request #8623: NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool (1.x version) URL: https://github.com/apache/nifi/pull/8623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12890) Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836344#comment-17836344 ] ASF subversion and git services commented on NIFI-12890: Commit b2842fd00af1728bc479b899fd99b8a092e82884 in nifi's branch refs/heads/support/nifi-1.x from lehelb [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b2842fd00a ] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool This closes #8623. Signed-off-by: Peter Turcsanyi > Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool > -- > > Key: NIFI-12890 > URL: https://issues.apache.org/jira/browse/NIFI-12890 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The AbstractDBCPConnectionPool was designed to avoid code duplication within > the DBCP services. It encompasses shared variables and is constructed in a > way that it contains numerous methods which can be overridden if we wish to > subclass from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12890) Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool
[ https://issues.apache.org/jira/browse/NIFI-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836337#comment-17836337 ] ASF subversion and git services commented on NIFI-12890: Commit 419a9cc73bfe5410c0ff399f4feb8e6350b7609d in nifi's branch refs/heads/main from lehelb [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=419a9cc73b ] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool This closes #8619. Signed-off-by: Peter Turcsanyi > Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool > -- > > Key: NIFI-12890 > URL: https://issues.apache.org/jira/browse/NIFI-12890 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The AbstractDBCPConnectionPool was designed to avoid code duplication within > the DBCP services. It encompasses shared variables and is constructed in a > way that it contains numerous methods which can be overridden if we wish to > subclass from it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool [nifi]
asfgit closed pull request #8619: NIFI-12890: Refactor HadoopDBCPConnectionPool to extend AbstractDBCPConnectionPool URL: https://github.com/apache/nifi/pull/8619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]
EndzeitBegins commented on PR #8620: URL: https://github.com/apache/nifi/pull/8620#issuecomment-2050252510 Makes perfect sense @exceptionfactory. I removed the default implementations for now and might open a separate PR once the documentation adjustments are merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13026 - Add a read only mode to non secured NiFi Registry [nifi]
pvillard31 commented on PR #8630:
URL: https://github.com/apache/nifi/pull/8630#issuecomment-2050213770
Thanks @exceptionfactory! What about the following approach where I have the
DefaultAuthorizer moved to its own class and in authorizers.xml, have something
like:
default-authorizer
org.apache.nifi.registry.security.authorization.DefaultAuthorizer
false
And then instead of
public Authorizer getAuthorizer() throws AuthorizerFactoryException {
if (authorizer == null) {
if (properties.getSslPort() == null) {
// use a default authorizer... only allowable when running
not securely
authorizer = createDefaultAuthorizer();
} else {
I would instantiate the DefaultAuthorizer the same way as the other ones are
instantiated.
Thoughts?
If we think this is not worth it because it is for a very specific use case,
I'll maintain my own version of the NiFi Registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13018) BUG - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
[
https://issues.apache.org/jira/browse/NIFI-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Aslan updated NIFI-13018:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> BUG - Refreshing Node Status History when open for the cluster, makes the
> incorrect backend call
>
>
> Key: NIFI-13018
> URL: https://issues.apache.org/jira/browse/NIFI-13018
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>
> If you open the Node Status History dialog from the global menu and then hit
> the refresh icon in the corner, the API call fails as it is trying to load:
> {code:java}
> http://localhost:4200/nifi-api/flow/processors/undefined/status/history
> {code}
> and gets a 404. It should be calling:
> {code:java}
> http://localhost:4200/nifi-api/controller/status/history
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13023) Right click on canvas while search results open shows browser right-click menu
[ https://issues.apache.org/jira/browse/NIFI-13023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13023: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Right click on canvas while search results open shows browser right-click menu > -- > > Key: NIFI-13023 > URL: https://issues.apache.org/jira/browse/NIFI-13023 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > * If you have the search results panel open and then you go to interact with > components on the flow such as right clicking and so on - you get a generic > response instead of actually talking to the component. If you close the > search panel by clicking out behavior returns as normal -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13024) Support "Enter" to create selected extension type
[ https://issues.apache.org/jira/browse/NIFI-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13024: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Support "Enter" to create selected extension type > - > > Key: NIFI-13024 > URL: https://issues.apache.org/jira/browse/NIFI-13024 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > When typing in to the filter input, the first element in the list should be > selected. If you hit enter it should create that component type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13000) Prevent text selection
[ https://issues.apache.org/jira/browse/NIFI-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13000: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Prevent text selection > -- > > Key: NIFI-13000 > URL: https://issues.apache.org/jira/browse/NIFI-13000 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > > The UI should prevent text selection where appropriate. One notable place is > on the entire canvas and the extension creation component but we should > consider other areas of the UI as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13021) Status History dialog changes size when switching selected metric
[ https://issues.apache.org/jira/browse/NIFI-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13021: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Status History dialog changes size when switching selected metric > - > > Key: NIFI-13021 > URL: https://issues.apache.org/jira/browse/NIFI-13021 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Kapture 2024-04-10 at 10.46.54.gif > > > This appears to be due to the content of the left column getting wider. > Probably needs a max-width set on it or something analogous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13024) Support "Enter" to create selected extension type
[ https://issues.apache.org/jira/browse/NIFI-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836295#comment-17836295 ] ASF subversion and git services commented on NIFI-13024: Commit d78e817fe87c0168be49f71b871da2ef463b17e5 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d78e817fe8 ] General improvements (#8627) * [NIFI-13021] - Fix - Status History dialog changes size when switching selected metric * [NIFI-13018] - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call * [NIFI-13023] - Fix - Right click on canvas while search results open shows browser right-click menu * [NIFI-13024] - Improvement - Support Enter to create selected extension type * [NIFI-13000] - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table. * prettier * color udpates for new theme classes, turn of text selection on the status history charts > Support "Enter" to create selected extension type > - > > Key: NIFI-13024 > URL: https://issues.apache.org/jira/browse/NIFI-13024 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > When typing in to the filter input, the first element in the list should be > selected. If you hit enter it should create that component type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13023) Right click on canvas while search results open shows browser right-click menu
[ https://issues.apache.org/jira/browse/NIFI-13023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836294#comment-17836294 ] ASF subversion and git services commented on NIFI-13023: Commit d78e817fe87c0168be49f71b871da2ef463b17e5 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d78e817fe8 ] General improvements (#8627) * [NIFI-13021] - Fix - Status History dialog changes size when switching selected metric * [NIFI-13018] - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call * [NIFI-13023] - Fix - Right click on canvas while search results open shows browser right-click menu * [NIFI-13024] - Improvement - Support Enter to create selected extension type * [NIFI-13000] - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table. * prettier * color udpates for new theme classes, turn of text selection on the status history charts > Right click on canvas while search results open shows browser right-click menu > -- > > Key: NIFI-13023 > URL: https://issues.apache.org/jira/browse/NIFI-13023 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > * If you have the search results panel open and then you go to interact with > components on the flow such as right clicking and so on - you get a generic > response instead of actually talking to the component. If you close the > search panel by clicking out behavior returns as normal -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13021) Status History dialog changes size when switching selected metric
[ https://issues.apache.org/jira/browse/NIFI-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836292#comment-17836292 ] ASF subversion and git services commented on NIFI-13021: Commit d78e817fe87c0168be49f71b871da2ef463b17e5 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d78e817fe8 ] General improvements (#8627) * [NIFI-13021] - Fix - Status History dialog changes size when switching selected metric * [NIFI-13018] - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call * [NIFI-13023] - Fix - Right click on canvas while search results open shows browser right-click menu * [NIFI-13024] - Improvement - Support Enter to create selected extension type * [NIFI-13000] - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table. * prettier * color udpates for new theme classes, turn of text selection on the status history charts > Status History dialog changes size when switching selected metric > - > > Key: NIFI-13021 > URL: https://issues.apache.org/jira/browse/NIFI-13021 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Kapture 2024-04-10 at 10.46.54.gif > > > This appears to be due to the content of the left column getting wider. > Probably needs a max-width set on it or something analogous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13000) Prevent text selection
[ https://issues.apache.org/jira/browse/NIFI-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836296#comment-17836296 ] ASF subversion and git services commented on NIFI-13000: Commit d78e817fe87c0168be49f71b871da2ef463b17e5 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d78e817fe8 ] General improvements (#8627) * [NIFI-13021] - Fix - Status History dialog changes size when switching selected metric * [NIFI-13018] - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call * [NIFI-13023] - Fix - Right click on canvas while search results open shows browser right-click menu * [NIFI-13024] - Improvement - Support Enter to create selected extension type * [NIFI-13000] - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table. * prettier * color udpates for new theme classes, turn of text selection on the status history charts > Prevent text selection > -- > > Key: NIFI-13000 > URL: https://issues.apache.org/jira/browse/NIFI-13000 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > > The UI should prevent text selection where appropriate. One notable place is > on the entire canvas and the extension creation component but we should > consider other areas of the UI as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13018) BUG - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
[
https://issues.apache.org/jira/browse/NIFI-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836293#comment-17836293
]
ASF subversion and git services commented on NIFI-13018:
Commit d78e817fe87c0168be49f71b871da2ef463b17e5 in nifi's branch
refs/heads/main from Rob Fellows
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d78e817fe8 ]
General improvements (#8627)
* [NIFI-13021] - Fix - Status History dialog changes size when switching
selected metric
* [NIFI-13018] - Fix - Refreshing Node Status History when open for the
cluster, makes the incorrect backend call
* [NIFI-13023] - Fix - Right click on canvas while search results open shows
browser right-click menu
* [NIFI-13024] - Improvement - Support Enter to create selected extension type
* [NIFI-13000] - Improvement - Prevent text selection in header, flow status,
canvas, extension creation dialog table.
* prettier
* color udpates for new theme classes, turn of text selection on the status
history charts
> BUG - Refreshing Node Status History when open for the cluster, makes the
> incorrect backend call
>
>
> Key: NIFI-13018
> URL: https://issues.apache.org/jira/browse/NIFI-13018
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>
> If you open the Node Status History dialog from the global menu and then hit
> the refresh icon in the corner, the API call fails as it is trying to load:
> {code:java}
> http://localhost:4200/nifi-api/flow/processors/undefined/status/history
> {code}
> and gets a 404. It should be calling:
> {code:java}
> http://localhost:4200/nifi-api/controller/status/history
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] General improvements [nifi]
scottyaslan merged PR #8627: URL: https://github.com/apache/nifi/pull/8627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2324) Add an option to the Windows installer whether to start the service after installation
[ https://issues.apache.org/jira/browse/MINIFICPP-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2324. - Resolution: Done > Add an option to the Windows installer whether to start the service after > installation > -- > > Key: MINIFICPP-2324 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2324 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2327) Loki build fails with msbuild on Windows
[
https://issues.apache.org/jira/browse/MINIFICPP-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz resolved MINIFICPP-2327.
-
Resolution: Fixed
> Loki build fails with msbuild on Windows
>
>
> Key: MINIFICPP-2327
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2327
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Loki build fails with the following message on Windows when using msbuild
> generator:
> {code:java}
> 2024-04-09T16:43:23.1251957Z Generating
> ../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.cc,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.h,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.pb.h,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.pb.cc
> 2024-04-09T16:43:23.1255534Z
> '..\..\_deps\grpc-build\third_party\protobuf\protoc.exe' is not recognized as
> an internal or external command,
> 2024-04-09T16:43:23.1256990Z operable program or batch file. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2324) Add an option to the Windows installer whether to start the service after installation
[ https://issues.apache.org/jira/browse/MINIFICPP-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2324: Fix Version/s: 0.16.0 > Add an option to the Windows installer whether to start the service after > installation > -- > > Key: MINIFICPP-2324 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2324 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2282) The user should be able to change the encryption key used for sensitive properties
[
https://issues.apache.org/jira/browse/MINIFICPP-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz resolved MINIFICPP-2282.
-
Resolution: Done
> The user should be able to change the encryption key used for sensitive
> properties
> --
>
> Key: MINIFICPP-2282
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2282
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The encryption key used to encrypt the full flow definition file,
> {{nifi.bootstrap.sensitive.key}}, can be updated using the procedure
> documented here:
> https://cwiki.apache.org/confluence/display/MINIFI/Securing+MiNiFi+configuration+files#SecuringMiNiFiconfigurationfiles-Updatingtheencryptionkey
> A similar mechanism should be available for the encryption key used to
> encrypt individual sensitive properties,
> {{nifi.bootstrap.sensitive.properties.key}}.
> The documentation linked above should be updated, as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2277) Add virtualenv support for python processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2277: Resolution: Done Status: Resolved (was: Patch Available) > Add virtualenv support for python processors > > > Key: MINIFICPP-2277 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2277 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > NiFi python processors are run in python virtual environments, and the user > can define dependency python modules that can be installed in this virtual > environment. We should also support this method for at least the NiFi python > processors, but we could also investigate if that could be possible to > implement for the MiNiFi python processors as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2277) Add virtualenv support for python processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2277: Fix Version/s: 0.16.0 > Add virtualenv support for python processors > > > Key: MINIFICPP-2277 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2277 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > NiFi python processors are run in python virtual environments, and the user > can define dependency python modules that can be installed in this virtual > environment. We should also support this method for at least the NiFi python > processors, but we could also investigate if that could be possible to > implement for the MiNiFi python processors as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2327) Loki build fails with msbuild on Windows
[
https://issues.apache.org/jira/browse/MINIFICPP-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-2327:
Fix Version/s: 0.16.0
> Loki build fails with msbuild on Windows
>
>
> Key: MINIFICPP-2327
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2327
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Loki build fails with the following message on Windows when using msbuild
> generator:
> {code:java}
> 2024-04-09T16:43:23.1251957Z Generating
> ../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.cc,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.grpc.pb.h,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.pb.h,
> ../../grafana-loki-protobuf-generated/grafana-loki-push.pb.cc
> 2024-04-09T16:43:23.1255534Z
> '..\..\_deps\grpc-build\third_party\protobuf\protoc.exe' is not recognized as
> an internal or external command,
> 2024-04-09T16:43:23.1256990Z operable program or batch file. {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2293) Support installing python dependencies defined inline
[ https://issues.apache.org/jira/browse/MINIFICPP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2293: Fix Version/s: 0.16.0 > Support installing python dependencies defined inline > - > > Key: MINIFICPP-2293 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2293 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > Time Spent: 3h > Remaining Estimate: 0h > > In NiFi python processors python dependencies can be defined inside the class > definition in the ProcessorDetails nested class using the dependencies > attribute. The dependencies attribute is a list with the required python > packages the processor depends on. MiNiFi should also support installing the > required packages defined here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2293) Support installing python dependencies defined inline
[ https://issues.apache.org/jira/browse/MINIFICPP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2293: Resolution: Done Status: Resolved (was: Patch Available) > Support installing python dependencies defined inline > - > > Key: MINIFICPP-2293 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2293 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > In NiFi python processors python dependencies can be defined inside the class > definition in the ProcessorDetails nested class using the dependencies > attribute. The dependencies attribute is a list with the required python > packages the processor depends on. MiNiFi should also support installing the > required packages defined here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2282) The user should be able to change the encryption key used for sensitive properties
[
https://issues.apache.org/jira/browse/MINIFICPP-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-2282:
Fix Version/s: 0.16.0
> The user should be able to change the encryption key used for sensitive
> properties
> --
>
> Key: MINIFICPP-2282
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2282
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Fix For: 0.16.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The encryption key used to encrypt the full flow definition file,
> {{nifi.bootstrap.sensitive.key}}, can be updated using the procedure
> documented here:
> https://cwiki.apache.org/confluence/display/MINIFI/Securing+MiNiFi+configuration+files#SecuringMiNiFiconfigurationfiles-Updatingtheencryptionkey
> A similar mechanism should be available for the encryption key used to
> encrypt individual sensitive properties,
> {{nifi.bootstrap.sensitive.properties.key}}.
> The documentation linked above should be updated, as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] MINIFICPP-2327 Fix Loki protobuf code generation on Windows using msbuild [nifi-minifi-cpp]
szaszm closed pull request #1757: MINIFICPP-2327 Fix Loki protobuf code generation on Windows using msbuild URL: https://github.com/apache/nifi-minifi-cpp/pull/1757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2324 Make start after install optional [nifi-minifi-cpp]
szaszm closed pull request #1754: MINIFICPP-2324 Make start after install optional URL: https://github.com/apache/nifi-minifi-cpp/pull/1754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2282 Support re-encryption of sensitive properties [nifi-minifi-cpp]
szaszm closed pull request #1739: MINIFICPP-2282 Support re-encryption of sensitive properties URL: https://github.com/apache/nifi-minifi-cpp/pull/1739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
szaszm closed pull request #1727: MINIFICPP-2293 Support installing python dependencies defined inline URL: https://github.com/apache/nifi-minifi-cpp/pull/1727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
szaszm closed pull request #1721: MINIFICPP-2277 Add virtualenv support for python processors URL: https://github.com/apache/nifi-minifi-cpp/pull/1721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13025 - NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service [nifi]
pvillard31 commented on PR #8629: URL: https://github.com/apache/nifi/pull/8629#issuecomment-2050174902 Thanks @exceptionfactory - I removed the `customValidate` method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
pvillard31 commented on PR #8631: URL: https://github.com/apache/nifi/pull/8631#issuecomment-2050159532 My concern with changing the routing approach is that it'd be a significant breaking change for existing flows. Having a logic that is not managed through properties also means that if a user does want small files (no idea why...) that would not be an option. But yeah I guess having a built-in rate limiter is probably the best option if we don't want to add properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13026 - Add a read only mode to non secured NiFi Registry [nifi]
exceptionfactory commented on code in PR #8630:
URL: https://github.com/apache/nifi/pull/8630#discussion_r1561351573
##
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/AuthorizerFactory.java:
##
@@ -523,6 +523,9 @@ private Authorizer createDefaultAuthorizer() {
return new Authorizer() {
@Override
public AuthorizationResult authorize(final AuthorizationRequest
request) throws AuthorizationAccessException {
+if(properties.isReadOnly() &&
!request.getAction().equals(RequestAction.READ)) {
Review Comment:
Injecting this property check into the default is not an optimal approach
because it requires evaluating the property on every request, as opposed to
configuring a specific authorizer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
exceptionfactory commented on PR #8631: URL: https://github.com/apache/nifi/pull/8631#issuecomment-2050124715 I agree that just logging a warning from any source is not ideal, since it requires some amount of user involvement to see and respond to the warning. Changing the behavior to require a minimum size and then taking some action, like routing to failure or perhaps yielding, in addition to logging, seems like it could be helpful. My concern was logging without any additional behavior change, but introducing some behavior change with logging seems worth considering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
joewitt commented on PR #8631: URL: https://github.com/apache/nifi/pull/8631#issuecomment-2050125108 @pvillard31 I was meaning to say it is good to warn the user about usage not making sense with that processor. But it does not need to be configurable what the size is - we already have too many dials/knobs. Instead the processor should keep some simple state about the rate/avg size of files seen and if over say a 1-5 minute interval the data is on average 'too small' then log a warn/bulletin. The bulletin could certainly advise the user that data to this processor should be batched together and that a component such as MergeContent or MergeRecord can be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
pvillard31 commented on PR #8631: URL: https://github.com/apache/nifi/pull/8631#issuecomment-2050119287 From discussions with Iceberg experts, a good size is 10MB. Problem is that we've seen users using PutIceberg without any kind of Merge operation before (imagine ConsumeKafka (not record based) to PutIceberg) creating thousands of small (hundreds of bytes) files and associated snapshots. This has basically killed the performances and made the query engine on top of the Iceberg tables pretty much unusable. While I do agree that the approach with a specific property sets a precedent that is not great, I don't really see another good approach to make sure the flow designer is aware of this as soon as the designer tries to run the processor to make some tests. I definitely don't think we should go in the direction of adding the Merge capabilities into the processor itself (that is going to be a mess and extremely complicated). The rules engine would be great but you can't be sure that the rule would be set and enforced by users before someone starts designing a flow where Iceberg is a destination. The reason for this change in this case is really because creating so many snapshot files has basically killed the downstream system. Another approach that I can think of: if the processor is processing a flow file that is below the agreed size, then we would yield the processor, and the default yield duration would be set to something like 1 minute. But we would still want to emit a bulletin to explain the behavior or something... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2309 Add JSON flow config examples [nifi-minifi-cpp]
szaszm commented on code in PR #1740:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1740#discussion_r1561318465
##
examples/querydbtable_config.nifi.schema.json:
##
@@ -0,0 +1,245 @@
+{
+"encodingVersion": {
+"majorVersion": 2,
+"minorVersion": 0
+},
+"maxTimerDrivenThreadCount": 1,
+"maxEventDrivenThreadCount": 1,
+"parameterContexts": [],
+"rootGroup": {
+"identifier": "1c2f34d2-ee57-448a-b150-8140f0f7643c",
+"instanceIdentifier": "9af45830-320e-437e-8204-dcd3c2933aa6",
+"name": "root",
+"position": {
+"x": 0.0,
+"y": 0.0
+},
+"processGroups": [],
+"remoteProcessGroups": [],
+"processors": [
+{
+"identifier": "0f469727-71d2-420f-aca5-d51599cb7507",
+"instanceIdentifier": "9e22e432-9a97-4cd9-a7a4-d1ffeca5fbfe",
+"name": "Query users table",
+"comments": "",
+"position": {
+"x": 90.22606801867788,
+"y": 3.5556140585132995
+},
+"type": "org.apache.nifi.minifi.processors.QueryDatabaseTable",
+"bundle": {
+"group": "org.apache.nifi.minifi",
+"artifact": "minifi-sql",
+"version": "0.15.0"
+},
+"properties": {
+"Table Name": "users",
+"Where Clause": "id = 1",
+"DB Controller Service": "ODBCService",
+"Columns to Return": "id,name",
+"Output Format": "JSON",
+"Max Rows Per Flow File": "0"
+},
+"propertyDescriptors": {
+"Table Name": {
+"name": "Table Name",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"Where Clause": {
+"name": "Where Clause",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"DB Controller Service": {
+"name": "DB Controller Service",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"Columns to Return": {
+"name": "Columns to Return",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"Maximum-value Columns": {
+"name": "Maximum-value Columns",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"Output Format": {
+"name": "Output Format",
+"identifiesControllerService": false,
+"sensitive": false
+},
+"Max Rows Per Flow File": {
+"name": "Max Rows Per Flow File",
+"identifiesControllerService": false,
+"sensitive": false
+}
+},
+"style": {},
+"schedulingPeriod": "1 sec",
+"schedulingStrategy": "TIMER_DRIVEN",
+"executionNode": "ALL",
+"penaltyDuration": "3 ms",
+"yieldDuration": "1000 ms",
+"bulletinLevel": "WARN",
+"runDurationMillis": 0,
+"concurrentlySchedulableTaskCount": 1,
+"autoTerminatedRelationships": [],
+"componentType": "PROCESSOR",
+"groupIdentifier": "1c2f34d2-ee57-448a-b150-8140f0f7643c"
+},
+{
+"identifier": "ca0439aa-2454-40f8-90fb-72b792d71bc1",
+"instanceIdentifier": "bb8a7729-d7d4-4b82-9cd0-4e5c28a5d52e",
+"name": "Put files to /tmp/output",
+"comments": "",
+"position": {
+"x": 382.2260680186779,
+"y": 12.5556140585133
+},
+"type": "org.apache.nifi.minifi.processors.PutFile",
+"bundle": {
+"group": "org.apache.nifi.minifi",
+"artifact": "minifi-standard-processors",
+"version": "0.15.0"
+},
+"properties": {
+"Create Missing Directories": "true",
+"Maximum File Count": "-1",
+"Directory": "/tmp/output",
+"Conflict Resolution Strategy": "fail"
+},
+
Re: [PR] NIFI-13005: Cluster State in Component State Dialog [nifi]
rfellows commented on code in PR #8609:
URL: https://github.com/apache/nifi/pull/8609#discussion_r1561313385
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/registry-clients/registry-client-table/registry-client-table.component.html:
##
@@ -101,10 +101,7 @@
@if (canConfigure(item)) {
-
+
Review Comment:
when rebased, this will need to add `primary-color` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
joewitt commented on PR #8631: URL: https://github.com/apache/nifi/pull/8631#issuecomment-2050092291 @exceptionfactory The problem with doing that in the flow with logmessage is that you're putting the onus on the user to do that. And the point is they might not know. @pvillard31 I think this makes sense but to my response to exceptionfactory the whole idea here is to convey information that might not be obvious to the end user. This seems like it could be more thoughtfully done by skipping new properties altogether. Is there a somewhat established "datasets on average going to Iceberg should be X bytes" big? If there is something like that then just have the processor keep a bit of state about this and after a bit of time and set of files go by periodically kick out such guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 clean up version reference [nifi]
joewitt closed pull request #8602: NIFI-12998 clean up version reference URL: https://github.com/apache/nifi/pull/8602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12998 clean up version reference [nifi]
joewitt commented on PR #8602: URL: https://github.com/apache/nifi/pull/8602#issuecomment-2050065258 will restore this once actually stable and builds with parity to current build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]
exceptionfactory commented on PR #8620: URL: https://github.com/apache/nifi/pull/8620#issuecomment-2050053994 Thanks for the helpful reply @EndzeitBegins. I evaluated the current method implementations that align with the proposed default implementations, and it seems like introducing the new default implementation methods could be helpful. However, it probably means that the existing implementations should be removed to avoid confusion. From that perspective, it would be better to consider those changes as a separate PR, keeping this one focused solely on documentation updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] General improvements [nifi]
scottyaslan commented on code in PR #8627:
URL: https://github.com/apache/nifi/pull/8627#discussion_r1561265093
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/extension-creation/extension-creation.component.html:
##
@@ -46,14 +46,27 @@ Add {{ componentType }}
Type
-
-{{ formatType(item) }}
+@if (isSelected(item)) {
+
+Add {{ componentType }}
Type
-
-{{ formatType(item) }}
+@if (isSelected(item)) {
+
+
+{{ formatType(item) }}
+
+} @else {
+
[jira] [Updated] (NIFI-13028) UI - processor color should be based on theme
[ https://issues.apache.org/jira/browse/NIFI-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13028: --- Status: Patch Available (was: In Progress) > UI - processor color should be based on theme > - > > Key: NIFI-13028 > URL: https://issues.apache.org/jira/browse/NIFI-13028 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13022) Disabled button state indistinguishable from enabled state
[ https://issues.apache.org/jira/browse/NIFI-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13022: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Disabled button state indistinguishable from enabled state > -- > > Key: NIFI-13022 > URL: https://issues.apache.org/jira/browse/NIFI-13022 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > It seems that due to some unfortunate "!important" styles, the mat-primary > style is winning over the disabled style for buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13022) Disabled button state indistinguishable from enabled state
[ https://issues.apache.org/jira/browse/NIFI-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836251#comment-17836251 ] ASF subversion and git services commented on NIFI-13022: Commit 44852fb5d5fcdb61491c9349e59ac32b13d6e581 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=44852fb5d5 ] [NIFI-13022] rename semantic color classes to avoid conflict with angular material class names (#8628) * [NIFI-13022] rename semantic color classes to avoid conflict with angular material class names * remove need for !important * rename default material sementic color classes This closes #8628 > Disabled button state indistinguishable from enabled state > -- > > Key: NIFI-13022 > URL: https://issues.apache.org/jira/browse/NIFI-13022 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It seems that due to some unfortunate "!important" styles, the mat-primary > style is winning over the disabled style for buttons. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13022] rename semantic color classes to avoid conflict with angular material class names [nifi]
rfellows merged PR #8628: URL: https://github.com/apache/nifi/pull/8628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] compute if absent needs to be before we reference [nifi]
evankshelton opened a new pull request, #8632: URL: https://github.com/apache/nifi/pull/8632 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] compute if absent needs to be before we reference [nifi]
evankshelton closed pull request #8632: compute if absent needs to be before we reference URL: https://github.com/apache/nifi/pull/8632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * Replay last event * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Parameter ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop
[jira] [Created] (NIFI-13028) UI - processor color should be based on theme
Scott Aslan created NIFI-13028: -- Summary: UI - processor color should be based on theme Key: NIFI-13028 URL: https://issues.apache.org/jira/browse/NIFI-13028 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2314 - Send asset state hash in heartbeat, implement c2 asset sync [nifi-minifi-cpp]
lordgamez commented on code in PR #1751:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1751#discussion_r1560971140
##
conf/minifi.properties:
##
@@ -90,7 +90,7 @@ nifi.content.repository.class.name=DatabaseContentRepository
#nifi.c2.rest.url=
#nifi.c2.rest.url.ack=
#nifi.c2.rest.ssl.context.service=
-nifi.c2.root.classes=DeviceInfoNode,AgentInformation,FlowInformation
+nifi.c2.root.classes=DeviceInfoNode,AgentInformation,FlowInformation,AssetInformation
Review Comment:
I think this should be added to the C2.md documentation as well under Base
Options.
##
extensions/http-curl/tests/C2AssetSyncTest.cpp:
##
Review Comment:
This test seems to be missing from the CMakeLists.txt, so it does not run
with ctest. It needs to be added with add_test
##
extensions/http-curl/tests/C2AssetSyncTest.cpp:
##
@@ -0,0 +1,256 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#undef NDEBUG
+#include
+#include
+#include
+#include
+
+#include "HTTPIntegrationBase.h"
+#include "HTTPHandlers.h"
+#include "utils/IntegrationTestUtils.h"
+#include "utils/file/FileUtils.h"
+#include "utils/file/AssetManager.h"
+
+class FileProvider : public ServerAwareHandler {
+ public:
+ explicit FileProvider(std::string file_content):
file_content_(std::move(file_content)) {}
+
+ bool handleGet(CivetServer* /*server*/, struct mg_connection* conn) override
{
+mg_printf(conn, "HTTP/1.1 200 OK\r\nContent-Type: "
+"text/plain\r\nContent-Length: %lu\r\nConnection:
close\r\n\r\n",
+ file_content_.length());
+mg_printf(conn, "%s", file_content_.c_str());
+return true;
+ }
+
+ private:
+ std::string file_content_;
+};
+
+class C2HeartbeatHandler : public HeartbeatHandler {
+ public:
+ using HeartbeatHandler::HeartbeatHandler;
+ using AssetDescription =
org::apache::nifi::minifi::utils::file::AssetDescription;
+
+ void handleHeartbeat(const rapidjson::Document& root, struct mg_connection*
conn) override {
+std::string hb_str;
+{
+ rapidjson::StringBuffer buffer;
+ rapidjson::Writer writer(buffer);
+ root.Accept(writer);
+
+ hb_str = std::string{buffer.GetString(), buffer.GetSize()};
+}
+auto& asset_info_node = root["assetInfo"];
+auto& asset_hash_node = asset_info_node["hash"];
+std::string asset_hash{asset_hash_node.GetString(),
asset_hash_node.GetStringLength()};
+
+std::vector operations;
+{
+ std::lock_guard guard(asset_mtx_);
+ agent_asset_hash_ = asset_hash;
+ if (asset_hash != assetHash()) {
+std::unordered_map args;
+for (auto& asset : expected_assets_) {
+ args[asset.id + ".path"] = asset.path;
+ args[asset.id + ".url"] = asset.url;
+}
+operations.push_back(C2Operation{
+ .operation = "sync",
+ .operand = "asset",
+ .operation_id = std::to_string(next_op_id_++),
+ .args = std::move(args)
+});
+ }
+}
+sendHeartbeatResponse(operations, conn);
+ }
+
+ void addAsset(std::string id, std::string path, std::string url) {
+std::lock_guard guard(asset_mtx_);
+expected_assets_.insert(AssetDescription{
+ .id = id,
+ .path = path,
+ .url = url
+});
+ }
+
+ void removeAsset(std::string id) {
+std::lock_guard guard{asset_mtx_};
+expected_assets_.erase(AssetDescription{.id = id, .path = {}, .url = {}});
+ }
+
+ std::optional getAgentAssetHash() const {
+std::lock_guard lock(asset_mtx_);
+return agent_asset_hash_;
+ }
+
+ std::string assetHash() const {
Review Comment:
I think this could be renamed to something like `calculateAssetHash` because
having a `getAgentAssetHash` and an `assetHash` is a bit confusing IMO
##
extensions/http-curl/tests/C2AssetSyncTest.cpp:
##
@@ -0,0 +1,256 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
szaszm commented on PR #1753: URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#issuecomment-2049764422 Do you want to fix the clang-tidy warnings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
martinzink commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1561039947
##
libminifi/src/utils/StringUtils.cpp:
##
@@ -538,6 +538,56 @@ nonstd::expected, ParseError>
parseCharacter(std::string_vie
return nonstd::make_unexpected(ParseError{});
}
+std::string replaceEscapedCharacters(std::string_view input) {
+ std::stringstream result;
+ for (size_t i = 0; i < input.size(); ++i) {
+char input_char = input[i];
+if (input_char != '\\' || i == input.size() - 1) {
+ result << input_char;
+ continue;
+}
+char next_char = input[i+1];
+switch (next_char) {
+ case '0':
+result << '\0'; // Null
+++i;
+break;
+ case 'a':
+result << '\a'; // Bell
+++i;
+break;
+ case 'b':
+result << '\b'; // Backspace
+++i;
+break;
+ case 't':
+result << '\t'; // Horizontal Tab
+++i;
+break;
+ case 'n':
+result << '\n'; // Line Feed
+++i;
+break;
+ case 'v':
+result << '\v'; // Vertical Tab
+++i;
+break;
+ case 'f':
+result << '\f'; // Form Feed
+++i;
+break;
+ case 'r':
+result << '\r'; // Carriage Return
+++i;
+break;
+ default:
+result << '\\';
Review Comment:
I think it should be "\s", that means the parseCharacter should throw error
i guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2328 Upgrade OpenSSL to version 3.3.0 [nifi-minifi-cpp]
lordgamez opened a new pull request, #1758: URL: https://github.com/apache/nifi-minifi-cpp/pull/1758 https://issues.apache.org/jira/browse/MINIFICPP-2328 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2328) Upgrade OpenSSL to version 3.3.0
Gábor Gyimesi created MINIFICPP-2328: Summary: Upgrade OpenSSL to version 3.3.0 Key: MINIFICPP-2328 URL: https://issues.apache.org/jira/browse/MINIFICPP-2328 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi A security issue has been found in OpenSSL which is described in the following CVE: [https://openwall.com/lists/oss-security/2024/04/08/5] The issue is fixed in OpenSSL version 3.3.0 and the fix will be ported to version 3.2 and 3.1 lines later. We should upgrade to 3.3.0 which also includes the fix we have as a patch in our repository at the moment. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
fgerlits commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560978544
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -615,6 +615,16 @@ TEST_CASE("string::parseCharacter tests") {
CHECK(string::parseCharacter("") == std::nullopt);
}
+TEST_CASE("string::replaceEscapedCharacters tests") {
+ CHECK(string::replaceEscapedCharacters("a") == "a");
+ CHECK(string::replaceEscapedCharacters(R"(\n)") == "\n");
+ CHECK(string::replaceEscapedCharacters(R"(\t)") == "\t");
+ CHECK(string::replaceEscapedCharacters(R"(\r)") == "\r");
+ CHECK(string::replaceEscapedCharacters(R"(\\s)") == "s");
Review Comment:
I would add
```c++
CHECK(string::replaceEscapedCharacters(R"(\s)") == "\\s");
```
(or
```c++
CHECK(string::replaceEscapedCharacters(R"(\s)") == "s");
```
if we decide to change it)
I would also add the test case
```c++
CHECK(string::replaceEscapedCharacters(R"(\\ foo \)") == " foo \\");
```
(or
```c++
CHECK(string::replaceEscapedCharacters(R"(\\ foo \)") == "\\ foo \\");
```
if we decide to copy the behavior of `parseCharacter`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
fgerlits commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560978544
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -615,6 +615,16 @@ TEST_CASE("string::parseCharacter tests") {
CHECK(string::parseCharacter("") == std::nullopt);
}
+TEST_CASE("string::replaceEscapedCharacters tests") {
+ CHECK(string::replaceEscapedCharacters("a") == "a");
+ CHECK(string::replaceEscapedCharacters(R"(\n)") == "\n");
+ CHECK(string::replaceEscapedCharacters(R"(\t)") == "\t");
+ CHECK(string::replaceEscapedCharacters(R"(\r)") == "\r");
+ CHECK(string::replaceEscapedCharacters(R"(\\s)") == "s");
Review Comment:
I would add
```
CHECK(string::replaceEscapedCharacters(R"(\s)") == "\\s");
```
(or
```
CHECK(string::replaceEscapedCharacters(R"(\s)") == "s");
```
if we decide to change it)
I would also add the test case
```
CHECK(string::replaceEscapedCharacters(R"(\\ foo \)") == " foo \\");
```
(or
```
CHECK(string::replaceEscapedCharacters(R"(\\ foo \)") == "\\ foo \\");
```
if we decide to copy the behavior of `parseCharacter`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
lordgamez commented on code in PR #1727: URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1561007673 ## docker/test/integration/cluster/ImageStore.py: ## @@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self): return self.__build_image(dockerfile) -def __build_minifi_cpp_image_with_nifi_python_processors(self, additional_cmd=""): +def __build_minifi_cpp_image_with_nifi_python_processors(self, python_option): parse_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py" chunk_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py" pip3_install_command = "" +requirements_install_command = "" +additional_cmd = "" +parse_document_sed_cmd = 'sed -i "54d;55d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py && \\' +chunk_document_sed_cmd = 'sed -i "112d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py && \\' Review Comment: Sure, added comment in 01357f3906f22c85246c0853f60927d9129c8cb8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
szaszm commented on code in PR #1727: URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560985716 ## docker/test/integration/cluster/ImageStore.py: ## @@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self): return self.__build_image(dockerfile) -def __build_minifi_cpp_image_with_nifi_python_processors(self, additional_cmd=""): +def __build_minifi_cpp_image_with_nifi_python_processors(self, python_option): parse_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py" chunk_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py" pip3_install_command = "" +requirements_install_command = "" +additional_cmd = "" +parse_document_sed_cmd = 'sed -i "54d;55d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py && \\' +chunk_document_sed_cmd = 'sed -i "112d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py && \\' Review Comment: Could you please add a comment with the description of what each part of the pattern means? Regex is write-only, it's not super obvious what is happening there. You could copy it from my previous comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
fgerlits commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560966829
##
libminifi/src/utils/StringUtils.cpp:
##
@@ -538,6 +538,56 @@ nonstd::expected, ParseError>
parseCharacter(std::string_vie
return nonstd::make_unexpected(ParseError{});
}
+std::string replaceEscapedCharacters(std::string_view input) {
+ std::stringstream result;
+ for (size_t i = 0; i < input.size(); ++i) {
+char input_char = input[i];
+if (input_char != '\\' || i == input.size() - 1) {
+ result << input_char;
+ continue;
+}
+char next_char = input[i+1];
+switch (next_char) {
+ case '0':
+result << '\0'; // Null
+++i;
+break;
+ case 'a':
+result << '\a'; // Bell
+++i;
+break;
+ case 'b':
+result << '\b'; // Backspace
+++i;
+break;
+ case 't':
+result << '\t'; // Horizontal Tab
+++i;
+break;
+ case 'n':
+result << '\n'; // Line Feed
+++i;
+break;
+ case 'v':
+result << '\v'; // Vertical Tab
+++i;
+break;
+ case 'f':
+result << '\f'; // Form Feed
+++i;
+break;
+ case 'r':
+result << '\r'; // Carriage Return
+++i;
+break;
+ default:
+result << '\\';
Review Comment:
This is an interesting question: should `"\s"` expand to `"s"` or `"\s"`?
The old `parseCharacter` function does the first, here you do the second. I
think it's a bit confusing that they are different, but I can be persuaded
either way.
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -615,6 +615,16 @@ TEST_CASE("string::parseCharacter tests") {
CHECK(string::parseCharacter("") == std::nullopt);
}
+TEST_CASE("string::replaceEscapedCharacters tests") {
+ CHECK(string::replaceEscapedCharacters("a") == "a");
+ CHECK(string::replaceEscapedCharacters(R"(\n)") == "\n");
+ CHECK(string::replaceEscapedCharacters(R"(\t)") == "\t");
+ CHECK(string::replaceEscapedCharacters(R"(\r)") == "\r");
+ CHECK(string::replaceEscapedCharacters(R"(\\s)") == "s");
Review Comment:
I would add
```
CHECK(string::replaceEscapedCharacters(R"(\s)") == "\\s");
```
(or
```
CHECK(string::replaceEscapedCharacters(R"(\s)") == "s");
```
if we decide to change it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13027 - Warn users for small files processing in PutIceberg [nifi]
pvillard31 opened a new pull request, #8631: URL: https://github.com/apache/nifi/pull/8631 # Summary [NIFI-13027](https://issues.apache.org/jira/browse/NIFI-13027) - Warn users for small files processing in PutIceberg # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13027) Warn users for small files processing in PutIceberg
[ https://issues.apache.org/jira/browse/NIFI-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13027: -- Status: Patch Available (was: Open) > Warn users for small files processing in PutIceberg > --- > > Key: NIFI-13027 > URL: https://issues.apache.org/jira/browse/NIFI-13027 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > > While it can be a valid use case, it is a very bad idea to send a lot of > small flow files via the PutIceberg processor as it will generate a massive > amount of snapshot files. The recommendation is clearly to use a > MergeContent/MergeRecord processor before the PutIceberg processor to make > sure we limit the amount of individual files being sent to an Iceberg table. > While we can't force a user (this could be a flow analysis rule though) we > should let them know very clearly that what they're doing is likely a bad > idea and let them know what is the recommended way. However if the user is > sure they know what they're doing, they should be able to disable the warning. > This Jira is about adding: > * a property "Warn for small flow files" set to true by default > * a property "Minimum recommended file size" set to 10MB (depending on the > previous property, if set to true) > And if the warning is enabled and a processed flow file is below the limit, > then log a warning with the recommendation of using a Merge processor so that > a bulletin is generated and shown to the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13027) Warn users for small files processing in PutIceberg
Pierre Villard created NIFI-13027: - Summary: Warn users for small files processing in PutIceberg Key: NIFI-13027 URL: https://issues.apache.org/jira/browse/NIFI-13027 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Pierre Villard Assignee: Pierre Villard While it can be a valid use case, it is a very bad idea to send a lot of small flow files via the PutIceberg processor as it will generate a massive amount of snapshot files. The recommendation is clearly to use a MergeContent/MergeRecord processor before the PutIceberg processor to make sure we limit the amount of individual files being sent to an Iceberg table. While we can't force a user (this could be a flow analysis rule though) we should let them know very clearly that what they're doing is likely a bad idea and let them know what is the recommended way. However if the user is sure they know what they're doing, they should be able to disable the warning. This Jira is about adding: * a property "Warn for small flow files" set to true by default * a property "Minimum recommended file size" set to 10MB (depending on the previous property, if set to true) And if the warning is enabled and a processed flow file is below the limit, then log a warning with the recommendation of using a Merge processor so that a bulletin is generated and shown to the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
martinzink commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560901017
##
extensions/standard-processors/processors/ListenTCP.cpp:
##
@@ -28,7 +28,13 @@ void ListenTCP::initialize() {
}
void ListenTCP::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
- startTcpServer(context, SSLContextService, ClientAuth);
+ auto delimiter_str = context.getProperty(MessageDelimiter).value_or("\n");
+ if (delimiter_str.empty()) {
+logger_->log_warn("{} cannot be an empty string", MessageDelimiter.name);
+delimiter_str = "\n";
+ }
Review Comment:
Good idea, but I didnt want to limit this processor to a single char so I've
added a new function `replaceEscapedCharacters` in
https://github.com/apache/nifi-minifi-cpp/pull/1753/commits/0f488acc7ebffe1ac35e1a0924c96b63a15f5eba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
martinzink commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560900290
##
extensions/standard-processors/processors/ListenTCP.cpp:
##
@@ -28,7 +28,13 @@ void ListenTCP::initialize() {
}
void ListenTCP::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
- startTcpServer(context, SSLContextService, ClientAuth);
+ auto delimiter_str = context.getProperty(MessageDelimiter).value_or("\n");
+ if (delimiter_str.empty()) {
+logger_->log_warn("{} cannot be an empty string", MessageDelimiter.name);
Review Comment:
good idea, ive included this in
https://github.com/apache/nifi-minifi-cpp/pull/1753/commits/0f488acc7ebffe1ac35e1a0924c96b63a15f5eba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
lordgamez commented on code in PR #1727: URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560808960 ## docker/test/integration/cluster/ImageStore.py: ## @@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self): return self.__build_image(dockerfile) -def __build_minifi_cpp_image_with_nifi_python_processors(self, additional_cmd=""): +def __build_minifi_cpp_image_with_nifi_python_processors(self, python_option): parse_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py" chunk_document_url = "https://raw.githubusercontent.com/apache/nifi/rel/nifi-; + NifiContainer.NIFI_VERSION + "/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py" pip3_install_command = "" +requirements_install_command = "" +additional_cmd = "" +parse_document_sed_cmd = 'sed -i "54d;55d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py && \\' +chunk_document_sed_cmd = 'sed -i "112d" /opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py && \\' Review Comment: Thanks, this seems to work great! We only need to use it inside the alpine container so it should be okay. Updated in 212f3946a3225b38cae974273acf1fb9122d79bd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13026 - Add a read only mode to non secured NiFi Registry [nifi]
pvillard31 opened a new pull request, #8630: URL: https://github.com/apache/nifi/pull/8630 # Summary [NIFI-13026](https://issues.apache.org/jira/browse/NIFI-13026) - Add a read only mode to non secured NiFi Registry # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13026) Add a read only mode to non secured NiFi Registry
[ https://issues.apache.org/jira/browse/NIFI-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13026: -- Status: Patch Available (was: Open) > Add a read only mode to non secured NiFi Registry > - > > Key: NIFI-13026 > URL: https://issues.apache.org/jira/browse/NIFI-13026 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > > There are scenarios where NiFi Registry may be deployed in a non secured way. > When doing so, as of now, all users access would be anonymous and all > permissions would be granted. This improvement is to allow for a read-only > mode when NiFi Registry is not secured so that all users can access NiFi > Registry but only perform READ actions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13026) Add a read only mode to non secured NiFi Registry
Pierre Villard created NIFI-13026: - Summary: Add a read only mode to non secured NiFi Registry Key: NIFI-13026 URL: https://issues.apache.org/jira/browse/NIFI-13026 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: Pierre Villard Assignee: Pierre Villard There are scenarios where NiFi Registry may be deployed in a non secured way. When doing so, as of now, all users access would be anonymous and all permissions would be granted. This improvement is to allow for a read-only mode when NiFi Registry is not secured so that all users can access NiFi Registry but only perform READ actions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2326 Link lua statically [nifi-minifi-cpp]
fgerlits commented on PR #1756: URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#issuecomment-2049275853 > I think some other files need to be updated as well Yes, good point, thanks! Fixed in 450f397604263c1faafdfffdd3aab7158556720e. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile)
-def __build_minifi_cpp_image_with_nifi_python_processors(self,
additional_cmd=""):
+def __build_minifi_cpp_image_with_nifi_python_processors(self,
python_option):
parse_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py"
chunk_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py"
pip3_install_command = ""
+requirements_install_command = ""
+additional_cmd = ""
+parse_document_sed_cmd = 'sed -i "54d;55d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
+chunk_document_sed_cmd = 'sed -i "112d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py
&& \\'
Review Comment:
```
sed -i '/class ProcessorDetails:/,/^$/{/^\s*dependencies\s*=/,/\]\s*$/d}'
ParseDocument.py
```
`/class ProcessorDetails:/,/^$/`: Do the following between 'class
ProcessorDetails:' and the first empty line (so we don't modify other
PropertyDescriptor blocks below)
`/^\s*dependencies\s*=/,/\]\s*$/`: Do the following between 'dependencies ='
at the start of a line, and ']' at the end of a line
`d`: Delete line
You may need to add ';' before '}' on Mac, I only tested on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile)
-def __build_minifi_cpp_image_with_nifi_python_processors(self,
additional_cmd=""):
+def __build_minifi_cpp_image_with_nifi_python_processors(self,
python_option):
parse_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py"
chunk_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py"
pip3_install_command = ""
+requirements_install_command = ""
+additional_cmd = ""
+parse_document_sed_cmd = 'sed -i "54d;55d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
+chunk_document_sed_cmd = 'sed -i "112d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py
&& \\'
Review Comment:
```
sed -i '/class ProcessorDetails:/,/^$/{/^\s*dependencies\s*=/,/\]\s*$/d}'
ParseDocument.py
```
`/class ProcessorDetails:/,/^$/`: Do the following between 'class
ProcessorDetails:' and the first empty line (so we don't modify other
PropertyDescriptor blocks below)
`/^\s*dependencies\s*=/,/\]\s*$/`: Do the following between 'dependencies ='
at the start of a line, and ']' at the end of a line
`d`: Delete line
You may need to add ';' before '}' on Mac, I didn't test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2293 Support installing python dependencies defined inline [nifi-minifi-cpp]
szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211
##
docker/test/integration/cluster/ImageStore.py:
##
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile)
-def __build_minifi_cpp_image_with_nifi_python_processors(self,
additional_cmd=""):
+def __build_minifi_cpp_image_with_nifi_python_processors(self,
python_option):
parse_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py"
chunk_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py"
pip3_install_command = ""
+requirements_install_command = ""
+additional_cmd = ""
+parse_document_sed_cmd = 'sed -i "54d;55d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
+chunk_document_sed_cmd = 'sed -i "112d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py
&& \\'
Review Comment:
```
sed -i '/class ProcessorDetails:/,/^$/{/^\s*dependencies\s*=/,/\]\s*$/d}'
ParseDocument.py
```
`/class ProcessorDetails:/,/^$/`: Do the following between 'class
ProcessorDetails:' and the first empty line (so we don't modify other
PropertyDescriptor blocks below)
`/^\s*dependencies\s*=/,/\]\s*$/`: Do the following between 'dependencies ='
at the start of a line, and ']' at the end of a line
`d`: Delete line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]
fgerlits commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560580278
##
extensions/standard-processors/processors/ListenTCP.cpp:
##
@@ -28,7 +28,13 @@ void ListenTCP::initialize() {
}
void ListenTCP::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
- startTcpServer(context, SSLContextService, ClientAuth);
+ auto delimiter_str = context.getProperty(MessageDelimiter).value_or("\n");
+ if (delimiter_str.empty()) {
+logger_->log_warn("{} cannot be an empty string", MessageDelimiter.name);
Review Comment:
I think we should tell the user what is happening:
```suggestion
logger_->log_warn("{} cannot be an empty string, using \\n as the
delimiter", MessageDelimiter.name);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13025 - NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service [nifi]
pvillard31 opened a new pull request, #8629: URL: https://github.com/apache/nifi/pull/8629 # Summary [NIFI-13025](https://issues.apache.org/jira/browse/NIFI-13025) - NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13025) NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service
[ https://issues.apache.org/jira/browse/NIFI-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13025: -- Status: Patch Available (was: Open) > NifiRegistryFlowRegistryClient to allow for truststore only SSL Context > Service > --- > > Key: NIFI-13025 > URL: https://issues.apache.org/jira/browse/NIFI-13025 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > > Right now the NifiRegistryFlowRegistryClient Registry Client, when configured > with an SSL Context Service, requires the SSL CS to be configured with both a > keystore and a truststore. However, there are valid deployment scenarios > where only a truststore should be configured in case anonymous access to the > Registry is desired. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13025) NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service
Pierre Villard created NIFI-13025: - Summary: NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service Key: NIFI-13025 URL: https://issues.apache.org/jira/browse/NIFI-13025 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Pierre Villard Assignee: Pierre Villard Right now the NifiRegistryFlowRegistryClient Registry Client, when configured with an SSL Context Service, requires the SSL CS to be configured with both a keystore and a truststore. However, there are valid deployment scenarios where only a truststore should be configured in case anonymous access to the Registry is desired. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13020) Flow update fails when legacy flow is received via C2
[ https://issues.apache.org/jira/browse/NIFI-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis updated NIFI-13020: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Flow update fails when legacy flow is received via C2 > - > > Key: NIFI-13020 > URL: https://issues.apache.org/jira/browse/NIFI-13020 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M2 >Reporter: Ferenc Kis >Assignee: Ferenc Kis >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When legacy flow is received via C2, flow update will fail. > Legacy flows do not have instanceId, so those will need to be generated and > mapped. > Additionally there are some processor properties which are missing those need > to be populated as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
