[GitHub] tz70s commented on a change in pull request #3722: Scala based admin tooling
tz70s commented on a change in pull request #3722: Scala based admin tooling
URL:
https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r193958701
##
File path: core/admin/src/main/scala/whisk/core/cli/Main.scala
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.cli
+
+import java.io.File
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import ch.qos.logback.classic.{Level, LoggerContext}
+import org.rogach.scallop._
+import org.slf4j.LoggerFactory
+import pureconfig.error.ConfigReaderException
+import whisk.common.{AkkaLogging, Logging, TransactionId}
+import whisk.core.database.UserCommand
+
+import scala.concurrent.duration.DurationInt
+import scala.concurrent.{Await, Future}
+import scala.util.{Failure, Success, Try}
+
+class Conf(arguments: Seq[String]) extends ScallopConf(arguments) {
+ banner("OpenWhisk admin command line tool")
+
+ val verbose = tally()
+ val configFile = opt[File](descr = "application.conf path")
Review comment:
Reading `whisk.properties` also works fine, but is there any specific reason
that we can't provide a consistent way? (not only supporting couch)
i.e. once user deploy/re-deploy/change the database, update the config for
them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang opened a new pull request #3735: Adjust offset topic replication factor
ningyougang opened a new pull request #3735: Adjust offset topic replication factor URL: https://github.com/apache/incubator-openwhisk/pull/3735 Current, default.replication.factor and offsets.topic.replication.factor also uses kafka.replicationFactor, it is better to adjust offsets.topic. replication.factor to the number of kafka nodes. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [x] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #898: wskdeploy export doesn't support multiple packages in a single project
pritidesai commented on issue #898: wskdeploy export doesn't support multiple packages in a single project URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/898#issuecomment-395652768 Closing this as its fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #898: wskdeploy export doesn't support multiple packages in a single project
pritidesai closed issue #898: wskdeploy export doesn't support multiple packages in a single project URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/898 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions
pritidesai commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/899#issuecomment-395652519 @brunogirin please try again with the latest build, its working for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh closed pull request #3709: Inlined attachments
chetanmeh closed pull request #3709: Inlined attachments
URL: https://github.com/apache/incubator-openwhisk/pull/3709
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index feaa96095c..dbc70c5fd3 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -114,6 +114,14 @@ whisk {
actions-ddoc = "whisks.v2.1.0"
activations-ddoc = "whisks.v2.1.0"
activations-filter-ddoc = "whisks-filters.v2.1.0"
+
+# Size limit for inlined attachments. Attachments having size less
than this would
+# be inlined with there content encoded in attachmentName
+max-inline-size = 16 k
+
+# Chunk sized for converting source of bytes to ByteString as part of
attachment
+# upload flow
+chunk-size = 8 k
}
# CouchDB related configuration
diff --git
a/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
b/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
index 3750398939..4a70e40c1a 100644
--- a/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
+++ b/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
@@ -137,8 +137,8 @@ trait ArtifactStore[DocumentAbstraction] {
/**
* Retrieves a saved attachment, streaming it into the provided Sink.
*/
- protected[core] def readAttachment[T](doc: DocInfo, name: String, sink:
Sink[ByteString, Future[T]])(
-implicit transid: TransactionId): Future[(ContentType, T)]
+ protected[core] def readAttachment[T](doc: DocInfo, attached: Attached,
sink: Sink[ByteString, Future[T]])(
+implicit transid: TransactionId): Future[T]
/**
* Deletes all attachments linked to given document
diff --git
a/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
b/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
new file mode 100644
index 00..14eb192aa1
--- /dev/null
+++ b/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database
+
+import java.security.MessageDigest
+import java.util.Base64
+
+import akka.NotUsed
+import akka.http.scaladsl.model.Uri
+import akka.stream.Materializer
+import akka.stream.scaladsl.{Concat, Sink, Source}
+import akka.util.{ByteString, ByteStringBuilder}
+import whisk.core.database.AttachmentInliner.MemScheme
+import whisk.core.entity.ByteSize
+
+import scala.collection.immutable
+import scala.concurrent.Future
+
+object AttachmentInliner {
+
+ /**
+ * Scheme name for attachments which are inlined
+ */
+ val MemScheme: String = "mem"
+}
+
+case class InliningConfig(maxInlineSize: ByteSize, chunkSize: ByteSize)
+
+/**
+ * Provides support for inlining small attachments. Inlined attachment
contents are encoded as part of attachment
+ * name itself.
+ */
+trait AttachmentInliner {
+ private val digestAlgo = "SHA-256"
+ private val encodedAlgoName =
digestAlgo.toLowerCase.replaceAllLiterally("-", "")
+
+ /** Materializer required for stream processing */
+ protected[core] implicit val materializer: Materializer
+
+ protected[database] def inlineAndTail(
+docStream: Source[ByteString, _]): Future[(immutable.Seq[Byte],
Source[Byte, _])] = {
+docStream
+ .mapConcat(_.seq)
+ .prefixAndTail(maxInlineSize.toBytes.toInt)
+ .runWith(Sink.head[(immutable.Seq[Byte], Source[Byte, _])])
+ }
+
+ protected[database] def uriOf(bytes: Seq[Byte], path: => String): Uri = {
+//For less than case its definitive that tail source would be empty
+//for equal case it cannot be determined if tail source is empty. Actual
max inline size
+//would be inlineSize - 1
+if (bytes.size < maxInlineSize.toBytes) {
+ Uri.from(scheme = MemScheme, path = encode(bytes))
+} else {
+
[GitHub] pritidesai closed pull request #950: Continue spec. conversion to markdown and add navigation
pritidesai closed pull request #950: Continue spec. conversion to markdown and add navigation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/950 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/specification/README.md b/specification/README.md index f15176c8..74cbdfb0 100644 --- a/specification/README.md +++ b/specification/README.md @@ -54,15 +54,17 @@ The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "S - [Package processing](html/spec_package_processing.md#package-processing) - describes how the developers can use Package Manifests and Deployment files with the ```wskdeploy``` utility. - [Grammar](html/spec_grammar.md#grammar) - describes the YAML grammar the specification builds upon. - Schema + [Schema](html/spec_schema.md#schema) - [Parameter Types](html/spec_parameter_types.md#parameter-types) - supported YAML and OpenWhisk Types. - [Parameters](html/spec_parameters.md#parameters) - grammar, schema and examples for input and output parameters. +- [Maps](html/spec_maps.md#map-schema) - schema for using the Map parameter type. - [Entity Schema](html/spec_shared_entity_schema.md#shared-entity-schema) - keys that are common to all entities in the programming model. -- [Entity Naming & Namespacing](html/spec_entity_naming_and_namespacing.md#naming-and-namespacing) - describes what characters can be used to name Packages, Actions, Triggers and Rules and how to manage them with namespaces. - [Packages](html/spec_packages.md#packages) - grammar, schema and examples for Packages. - [Actions](html/spec_actions.md#actions) - grammar, schema and examples for Actions. -- [Triggers and Rules](html/spec_trigger_rule.md#triggers-and-rules) - grammar, schema and examples for Triggers and Rules. -- [Sequences](html/spec_sequences.md#sequences) - shema to compose multiple Actions into a sequence. +- [Triggers](html/spec_trigger.md#triggers) - grammar, schema and examples for Triggers. +- [Rules](html/spec_rule.md#rules) - grammar, schema and examples for Rules. +- [Sequences](html/spec_sequences.md#sequences) - schema to compose multiple Actions into a single, named Action sequence. +- [Entity Naming & Namespacing](html/spec_entity_naming_and_namespacing.md#naming-and-namespacing) - describes what characters can be used to name Packages, Actions, Triggers and Rules and how to manage them with namespaces. References - [Normative & Non-normative References](html/spec_normative_refs.md) diff --git a/specification/html/spec_actions.md b/specification/html/spec_actions.md index a08f5776..bc74dd93 100644 --- a/specification/html/spec_actions.md +++ b/specification/html/spec_actions.md @@ -19,87 +19,37 @@ ## Actions + Subsections +- [Fields](#fields) +- [Requirements](#requirements) +- [Notes](#notes) +- [Grammar](#grammar) +- [Example](#example) +- [Valid Runtime names](#valid-runtime-names) +- [Recognized File extensions](#recognized-file-extensions) +- [Valid Limit keys](#valid-limit-keys) + The Action entity schema contains the necessary information to deploy an OpenWhisk function and define its deployment configurations, inputs and outputs. ### Fields - - - - Key Name - Required - Value Type - Default - Description - - - version - no - version - N/A - The optional user-controlled version for the Action. - - - function - yes - string - N/A - Required source location (path inclusive) of the Action code either: - - Relative to the Package manifest file. - Relative to the specified Repository. - - - - - runtime - no - string - N/A - The required runtime name (and optional version) that the Action code requires for an execution environment. - Note: May be optional if tooling allowed to make assumptions about file extensions. - - - - inputs - no - list of parameter - N/A - The optional ordered list inputs to the Action. - - - outputs - no - list of parameter - N/A - The optional outputs from the Action. - - - limits - no - map of limit keys and values - N/A - Optional map of limit keys and their values. - See section 'Valid limit keys' below for a listing of recognized keys and values. - - - - feed - no - boolean - false - Optional indicator that the Action supports the required parameters (and operations) to be run as a Feed Action. - - - web-export - no - boolean - false - Optionally, turns the Action into a https://github.com/apache/incubator-openwhisk/blob/master/docs/webactions.md;>web actions - causing it to return HTTP content without use of an API Gateway. - - - - +| Key Name | Required | Value Type | Default | Description | +|:---|:---|:---|:---|:---| +| version | no |
[GitHub] chetanmeh commented on a change in pull request #3722: Scala based admin tooling
chetanmeh commented on a change in pull request #3722: Scala based admin tooling
URL:
https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r193949023
##
File path: core/admin/src/main/scala/whisk/core/cli/Main.scala
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.cli
+
+import java.io.File
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import ch.qos.logback.classic.{Level, LoggerContext}
+import org.rogach.scallop._
+import org.slf4j.LoggerFactory
+import pureconfig.error.ConfigReaderException
+import whisk.common.{AkkaLogging, Logging, TransactionId}
+import whisk.core.database.UserCommand
+
+import scala.concurrent.duration.DurationInt
+import scala.concurrent.{Await, Future}
+import scala.util.{Failure, Success, Try}
+
+class Conf(arguments: Seq[String]) extends ScallopConf(arguments) {
+ banner("OpenWhisk admin command line tool")
+
+ val verbose = tally()
+ val configFile = opt[File](descr = "application.conf path")
Review comment:
That can be done. Another way I was thinking to have better support for
Couch by reading `whisk.properties` as being done by current `wskadmin`. So
scala tooling would also read that and seed in required typesafe properties
such that for couch you need not pass in application.conf.
For others like Cosmos or later Mongo user can pass application.conf
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3722: Scala based admin tooling
chetanmeh commented on a change in pull request #3722: Scala based admin tooling
URL:
https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r193949023
##
File path: core/admin/src/main/scala/whisk/core/cli/Main.scala
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.cli
+
+import java.io.File
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import ch.qos.logback.classic.{Level, LoggerContext}
+import org.rogach.scallop._
+import org.slf4j.LoggerFactory
+import pureconfig.error.ConfigReaderException
+import whisk.common.{AkkaLogging, Logging, TransactionId}
+import whisk.core.database.UserCommand
+
+import scala.concurrent.duration.DurationInt
+import scala.concurrent.{Await, Future}
+import scala.util.{Failure, Success, Try}
+
+class Conf(arguments: Seq[String]) extends ScallopConf(arguments) {
+ banner("OpenWhisk admin command line tool")
+
+ val verbose = tally()
+ val configFile = opt[File](descr = "application.conf path")
Review comment:
That can be done. Another way I was thinking to have better support for
Couch by read `whisk.properties` as being done by current `wskadmin`. So scalal
tooling would also read that and seed in required typesafe properties such that
for couch you need not pass in application.conf.
For others like Cosmos or later Mongo user can pass application.conf
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3734: Correct text in webaction doc.
codecov-io commented on issue #3734: Correct text in webaction doc. URL: https://github.com/apache/incubator-openwhisk/pull/3734#issuecomment-395640397 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=h1) Report > Merging [#3734](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/a7665146f89cd499f7af4e794bde5365761d8f20?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3734 +/- ## === Coverage 75.05% 75.05% === Files 127 127 Lines6042 6042 Branches 393 393 === Hits 4535 4535 Misses 1507 1507 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=footer). Last update [a766514...4c8aaa8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3734?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tz70s opened a new pull request #3734: Correct text in webaction doc.
tz70s opened a new pull request #3734: Correct text in webaction doc. URL: https://github.com/apache/incubator-openwhisk/pull/3734 Mainly remove the redundant `A`. Signed-off-by: Tzu-Chiao Yeh ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [x] Documentation ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tz70s closed pull request #3734: Correct text in webaction doc.
tz70s closed pull request #3734: Correct text in webaction doc. URL: https://github.com/apache/incubator-openwhisk/pull/3734 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/webactions.md b/docs/webactions.md index f78e6b550f..ea137c6f23 100644 --- a/docs/webactions.md +++ b/docs/webactions.md @@ -146,12 +146,12 @@ The controller will pass along the action-specified headers, if any, to the HTTP All web actions, when invoked, receives additional HTTP request details as parameters to the action input argument. They are: -1. `__ow_method` (type: string). the HTTP method of the request. -2. `__ow_headers` (type: map string to string): A the request headers. +1. `__ow_method` (type: string): the HTTP method of the request. +2. `__ow_headers` (type: map string to string): the request headers. 3. `__ow_path` (type: string): the unmatched path of the request (matching stops after consuming the action extension). -4. `__ow_user` (type: string): the namespace identifying the OpenWhisk authenticated subject -5. `__ow_body` (type: string): the request body entity, as a base64 encoded string when content is binary or JSON object/array, or plain string otherwise -6. `__ow_query` (type: string): the query parameters from the request as an unparsed string +4. `__ow_user` (type: string): the namespace identifying the OpenWhisk authenticated subject. +5. `__ow_body` (type: string): the request body entity, as a base64 encoded string when content is binary or JSON object/array, or plain string otherwise. +6. `__ow_query` (type: string): the query parameters from the request as an unparsed string. A request may not override any of the named `__ow_` parameters above; doing so will result in a failed request with status equal to 400 Bad Request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tz70s commented on a change in pull request #3722: Scala based admin tooling
tz70s commented on a change in pull request #3722: Scala based admin tooling
URL:
https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r193944971
##
File path: core/admin/src/main/scala/whisk/core/cli/Main.scala
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.cli
+
+import java.io.File
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import ch.qos.logback.classic.{Level, LoggerContext}
+import org.rogach.scallop._
+import org.slf4j.LoggerFactory
+import pureconfig.error.ConfigReaderException
+import whisk.common.{AkkaLogging, Logging, TransactionId}
+import whisk.core.database.UserCommand
+
+import scala.concurrent.duration.DurationInt
+import scala.concurrent.{Await, Future}
+import scala.util.{Failure, Success, Try}
+
+class Conf(arguments: Seq[String]) extends ScallopConf(arguments) {
+ banner("OpenWhisk admin command line tool")
+
+ val verbose = tally()
+ val configFile = opt[File](descr = "application.conf path")
Review comment:
Hi @chetanmeh,
I'm wondering if there can be a _default_ path of `application.conf` that we
can automatically generate this during ansible deployment? i.e. step on setup
couchdb.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode
codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging [#3704](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **decrease** coverage by `0.57%`. > The diff coverage is `12.06%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3704 +/- ## == - Coverage 75.06% 74.49% -0.58% == Files 127 127 Lines6043 6096 +53 Branches 388 391 +3 == + Hits 4536 4541 +5 - Misses 1507 1555 +48 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/common/Scheduler.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9TY2hlZHVsZXIuc2NhbGE=) | `100% <ø> (ø)` | :arrow_up: | | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.88% <0%> (-1%)` | :arrow_down: | | [...n/scala/whisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==) | `75.28% <43.75%> (-8.29%)` | :arrow_down: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `91.3% <0%> (-0.19%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=footer). Last update [fe19220...4594b80](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tz70s opened a new pull request #3734: Correct text in webaction doc.
tz70s opened a new pull request #3734: Correct text in webaction doc. URL: https://github.com/apache/incubator-openwhisk/pull/3734 Mainly remove the redundant `A`. Signed-off-by: Tzu-Chiao Yeh ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [x] Documentation ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tz70s commented on issue #3530: factor out max code blob size to a deployment configuration
tz70s commented on issue #3530: factor out max code blob size to a deployment configuration URL: https://github.com/apache/incubator-openwhisk/issues/3530#issuecomment-395623297 @rabbah , I'm working on this. Is the limit on code size configurable during creating/updating actions or just get fixed after deploying whisk? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3709: Inlined attachments
csantanapr commented on issue #3709: Inlined attachments URL: https://github.com/apache/incubator-openwhisk/pull/3709#issuecomment-395620572 PG1 2996 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3728: Add information on using Composer with the PHP runtime
rabbah closed pull request #3728: Add information on using Composer with the PHP runtime URL: https://github.com/apache/incubator-openwhisk/pull/3728 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/actions.md b/docs/actions.md index 36edb62551..05de898a59 100644 --- a/docs/actions.md +++ b/docs/actions.md @@ -644,6 +644,19 @@ and then create the action: wsk action create helloPHP --kind php:7.1 helloPHP.zip ``` +### Including Composer dependencies + +If your PHP action requires [Composer](https://getcomposer.org) dependencies, you can install them as usual using `composer require` which will create a `vendor` directory. Add this directory to your action's zip file and create the action: + +```bash +zip -r helloPHP.zip index.php vendor +wsk action create helloPHP --kind php:7.1 helloPHP.zip +``` + +The PHP runtime will automatically include Composer's autoloader for you, so you can immediately use the dependencies in your action code. + +Note that if you don't include your own `vendor` folder, then the runtime will include one for you. The packages included are listed in the [reference](https://github.com/apache/incubator-openwhisk/blob/master/docs/reference.md#composer-packages). + ## Creating Swift actions This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3728: Add information on using Composer with the PHP runtime
codecov-io commented on issue #3728: Add information on using Composer with the PHP runtime URL: https://github.com/apache/incubator-openwhisk/pull/3728#issuecomment-395614861 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=h1) Report > Merging [#3728](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3728 +/- ## == + Coverage 75.06% 75.11% +0.04% == Files 127 127 Lines6043 6051 +8 Branches 388 388 == + Hits 4536 4545 +9 + Misses 1507 1506 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `94.54% <0%> (+3.05%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=footer). Last update [fe19220...382d38a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3728?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing
tysonnorris commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193926390
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##
@@ -205,10 +213,35 @@ class ContainerProxy(
// and we keep it in case we need to destroy it.
case Event(data: PreWarmedData, _) => stay using data
-// Run was successful
-case Event(data: WarmedData, _) =>
+// Init was successful
+case Event(data: WarmedData, _: PreWarmedData) =>
+ //in case concurrency supported, multiple runs can begin as soon as init
is complete
context.parent ! NeedWork(data)
- goto(Ready) using data
+ stay using data
+
+// Run was successful
+case Event(_: WarmedData, s: WarmedData) =>
+ val newData = s.decrementActive
+
+ context.parent ! NeedWork(newData)
+
+ if (newData.activeActivationCount > 0) {
+stay using newData
+ } else {
+logging.info(this, "going to ready after load completed")
+goto(Ready) using newData
+ }
+
+case Event(job: Run, data: WarmedData)
+if stateData.activeActivationCount < poolConfig.maxConcurrent &&
!rescheduleJob => //if there was a delay, or a failure on resume, skip the run
+
+ implicit val transid = job.msg.transid
+ val newData = data.incrementActive
+
+ initializeAndRun(data.container, job)
+.map(_ => WarmedData(data.container, job.msg.user.namespace,
job.action, Instant.now))
Review comment:
This is a confusing part of `ContainerProxy` for me - that `WarmedData` is
used for both event _and_ state. These ones that are `.pipeTo` are events, and
do not track the current state. At some point I would rename these events to
something like `RunComplete` (with a `WarmedData` val), and still used
`WarmedData` for state.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility
codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility URL: https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392093713 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@76edd95`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `69.23%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3707 +/- ## = Coverage ? 75.02% = Files ? 127 Lines ? 6051 Branches ? 383 = Hits ? 4540 Misses? 1511 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `85.45% <69.23%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=footer). Last update [76edd95...0da5858](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility
codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility URL: https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392093713 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@76edd95`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `69.23%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3707 +/- ## = Coverage ? 75.02% = Files ? 127 Lines ? 6051 Branches ? 383 = Hits ? 4540 Misses? 1511 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `85.45% <69.23%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=footer). Last update [76edd95...0da5858](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3729: Add brief Kubernetes Setup section to main README.md
rabbah closed pull request #3729: Add brief Kubernetes Setup section to main README.md URL: https://github.com/apache/incubator-openwhisk/pull/3729 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 075a8bdd6c..7e8269af35 100644 --- a/README.md +++ b/README.md @@ -29,13 +29,14 @@ OpenWhisk is a cloud-first distributed event-based programming service. It provi * [Quick Start](#quick-start) (Docker-Compose) * [Native development](#native-development) (Mac and Ubuntu) +* [Kubernetes](#kubernetes-setup) * [Vagrant](#vagrant-setup) * [Learn concepts and commands](#learn-concepts-and-commands) * [Issues](#issues) * [Slack](#slack) ### Quick Start -The easiest way to start using OpenWhisk is to get Docker installed on on Mac, Windows or Linux. The [Docker website](https://docs.docker.com/install/) has details instructions on getting the tools installed. This does not give you a prodcution deployment but gives you enough of the pieces to start writing functions and seeing them run. +The easiest way to start using OpenWhisk is to get Docker installed on on Mac, Windows or Linux. The [Docker website](https://docs.docker.com/install/) has details instructions on getting the tools installed. This does not give you a production deployment but gives you enough of the pieces to start writing functions and seeing them run. ``` git clone https://github.com/apache/incubator-openwhisk-devtools.git @@ -45,6 +46,15 @@ make quick-start For more detailed instructions or if you encounter problems see the [OpenWhisk-dev tools](https://github.com/apache/incubator-openwhisk-devtools/blob/master/docker-compose/README.md) project. +### Kubernetes Setup + +Another path to quickly starting to use OpenWhisk is to install it on a Kubernetes cluster. OpenWhisk can be installed on Minikube, on a managed Kubernetes cluster provisioned from a public cloud provider, or on a Kubernetes cluster you manage yourself. To get started, + +``` +git clone https://github.com/apache/incubator-openwhisk-deploy-kube.git +``` + +Then follow the instructions in the [OpenWhisk on Kubernetes README.md](https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/README.md). ### Vagrant Setup A [Vagrant](http://vagrantup.com) machine is also available to run OpenWhisk on Mac, Windows PC or GNU/Linux but isn't used by as much of the dev team so sometimes lags behind. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing
tysonnorris commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193925034
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##
@@ -205,10 +213,35 @@ class ContainerProxy(
// and we keep it in case we need to destroy it.
case Event(data: PreWarmedData, _) => stay using data
-// Run was successful
-case Event(data: WarmedData, _) =>
+// Init was successful
+case Event(data: WarmedData, _: PreWarmedData) =>
+ //in case concurrency supported, multiple runs can begin as soon as init
is complete
context.parent ! NeedWork(data)
- goto(Ready) using data
+ stay using data
+
+// Run was successful
+case Event(_: WarmedData, s: WarmedData) =>
+ val newData = s.decrementActive
+
+ context.parent ! NeedWork(newData)
+
+ if (newData.activeActivationCount > 0) {
+stay using newData
+ } else {
+logging.info(this, "going to ready after load completed")
+goto(Ready) using newData
+ }
+
+case Event(job: Run, data: WarmedData)
+if stateData.activeActivationCount < poolConfig.maxConcurrent &&
!rescheduleJob => //if there was a delay, or a failure on resume, skip the run
Review comment:
These should be the same? I thought that data was only a matching
convenience. Will change it but am curious if this is problematic?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing
tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r193924904 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala ## @@ -53,14 +52,24 @@ case object Paused extends ContainerState case object Removing extends ContainerState // Data -sealed abstract class ContainerData(val lastUsed: Instant) +sealed abstract class ContainerData(val lastUsed: Instant, val activeActivationCount: Int = 0) Review comment: yes - fixing that This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3704: Provide graceful shutdown for invoker
codecov-io commented on issue #3704: Provide graceful shutdown for invoker URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging [#3704](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **decrease** coverage by `0.57%`. > The diff coverage is `12.28%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3704 +/- ## == - Coverage 75.06% 74.48% -0.58% == Files 127 127 Lines6043 6095 +52 Branches 388 391 +3 == + Hits 4536 4540 +4 - Misses 1507 1555 +48 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) | Coverage Δ | | |---|---|---| | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/common/Scheduler.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9TY2hlZHVsZXIuc2NhbGE=) | `100% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.88% <0%> (-1%)` | :arrow_down: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...n/scala/whisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==) | `75.28% <43.75%> (-8.29%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `91.3% <0%> (-0.19%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=footer). Last update [fe19220...a575b58](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193923095 ## File path: docs/parameters.md ## @@ -25,7 +25,7 @@ This page outlines how to configure parameters when deploying packages and actio ### Passing parameters to an action at invoke time -Parameters can be passed to the action when it is invoked. These examples use JavaScript but all the other languages work the same way (see documentation on [Swift actions](./actions.md#creating-swift-actions), [Python actions](./actions.mdcreating-python-actions), [Java actions](./actions.mdcreating-java-actions), [PHP actions](./actions.mdcreating-php-actions), [Docker actions](./actions.mdcreating-docker-actions) or [Go actions](./actions.mdcreating-go-actions) as appropriate for more detailed examples). +Parameters can be passed to the action when it is invoked. These examples use JavaScript but all the other languages work the same way (see documentation on [this page](./actions.md) as appropriate for more detailed examples). Review comment: Updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/5aa8fc7fa6a09f219f704d301541b213b9aa07c8?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `80.64%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2795 +/- ## == + Coverage 75.06% 75.06% +<.01% == Files 127 127 Lines6043 6084 +41 Branches 388 390 +2 == + Hits 4536 4567 +31 - Misses 1507 1517 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `92.67% <100%> (+0.85%)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <100%> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `75% <55.55%> (-16.49%)` | :arrow_down: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.61% <80%> (-1.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [5aa8fc7...e526d05](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility
tysonnorris commented on a change in pull request #3707: enable concurrent runs
on ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193920614
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+//sentinels should be all together
+if (concurrent) {
Review comment:
That is done already, but what is important is the unknown ordering of
sentinels vs log output since these should be different when container runs
activations concurrently (without concurrency, the container logs always
alternate between ...). With concurrent
activations, the sentinel from previous activation may output in between logs
of subsequent activations, like:
```
```
So in the nodejs container test I will force the activation logs to all be
output before any sentinels are output.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] akharitonov opened a new issue #3733: Distributed deployment: export | unreachable
akharitonov opened a new issue #3733: Distributed deployment: export |
unreachable
URL: https://github.com/apache/incubator-openwhisk/issues/3733
I'm attempting to deploy a distributed OpenWhisk according to [this
guide](https://github.com/apache/incubator-openwhisk/blob/master/ansible/README_DISTRIBUTED.md).
However, right away there is an issue.
Specifically when I run
`ansible all -i environments/distributed -m ping`
All of the hosts specified by me in the`
/home/uvlba/openwhisk/ansible/environments/hosts` are reachable but there is
one that is not: "export"
`export | UNREACHABLE! => {
"changed": false,
"msg": "Failed to connect to the host via ssh: ssh: Could not resolve
hostname export: Name or service not known\r\n",
"unreachable": true
}`
It's not present in any of the configs as far as I can tell for the
distributed environment nor I see any mentions of it anywhere in the
documentation. Where is it coming from? What is that export host?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility
rabbah commented on a change in pull request #3707: enable concurrent runs on
ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193919343
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+//sentinels should be all together
+if (concurrent) {
Review comment:
could you just count the number of sentinel occurrences to match the number
of activations?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility
tysonnorris commented on a change in pull request #3707: enable concurrent runs
on ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193897689
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+//sentinels should be all together
+if (concurrent) {
Review comment:
The sentinels of different activations will be interleaved, but only with
sentinels of other activations, not with log messages. It is true this assumes
that the activations processing concurrently are run with this test class, and
it is also true that an image could have behavior to cause concurrently
submitted activations to emit sentinels at different times. I'll see if
something better can be done, but I'm not sure what - we need to make sure the
log output is interleaved amongst concurrent activations, but predicting the
exact should be impossible, unless the action forces ordering within, defeating
the concurrency model...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility
tysonnorris commented on a change in pull request #3707: enable concurrent runs
on ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193916422
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+//sentinels should be all together
+if (concurrent) {
Review comment:
for now will disable this, and container tests will have to validate their
own support for concurrency by causing some coordination within the container
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala
dubee closed pull request #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala URL: https://github.com/apache/incubator-openwhisk/pull/3732 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/common/scala/Dockerfile b/common/scala/Dockerfile index 693f6d2788..44000957d3 100644 --- a/common/scala/Dockerfile +++ b/common/scala/Dockerfile @@ -1,7 +1,7 @@ # Licensed to the Apache Software Foundation (ASF) under one or more contributor # license agreements; and to You under the Apache License, Version 2.0. -FROM openjdk:8u151-jdk-alpine +FROM adoptopenjdk/openjdk8:jdk8u172-b11-alpine ENV LANG en_US.UTF-8 ENV LANGUAGE en_US:en This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
codecov-io commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-386808429 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=h1) Report > Merging [#3467](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/583b154661ff0bb46b7c85a1ba92c2ec285b714d?src=pr=desc) will **increase** coverage by `0.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3467 +/- ## == + Coverage 74.11% 74.66% +0.54% == Files 127 127 Lines6043 6051 +8 Branches 388 388 == + Hits 4479 4518 +39 + Misses 1564 1533 -31 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `47.27% <0%> (-44.22%)` | :arrow_down: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `83.11% <0%> (-0.65%)` | :arrow_down: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (+1.14%)` | :arrow_up: | | [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: | | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `100% <0%> (+7.69%)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.34% <0%> (+14.63%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+22.91%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `58.33% <0%> (+36.11%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh) | `88.46% <0%> (+65.38%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=footer). Last update [583b154...b601f70](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use
[GitHub] apercova opened a new pull request #132: Fix to fallback when LOCAL_IP cannot be obtained
apercova opened a new pull request #132: Fix to fallback when LOCAL_IP cannot be obtained URL: https://github.com/apache/incubator-openwhisk-devtools/pull/132 I've tried to do make quick-start from CentOS 7 I noticed that LOCAL_IP cannot be obtained within CentOS 7 the way Makefile tries to do so. I supposed fallback to localhost should execute but I realized that fallback conditional is actually intended to be executed only on systems other than Linux. I propose this change to allow fallback conditional to be executed the same way on Linux and no-Linux systems This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903326
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
+ def toInt: Int = instance
+}
+
+case class ControllerInstanceId(private val instance: String) {
+ //keep instance private, since we will replace illegal chars for kafka usage
+ //for kafka topic legal chars see
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L29
+ val ILLEGAL_CHARS = "[^a-zA-Z0-9._-]".r
+ //validate once on construction - reserve 20 (arbitrary) chars for prefix to
be prepended to create topic names
+ private val MAX_NAME_LENGTH = 249 - 20
+ val replaced = ILLEGAL_CHARS.replaceAllIn(instance, "")
+ require(replaced.length <= MAX_NAME_LENGTH, s"topic name can be at most
${MAX_NAME_LENGTH} ${replaced}")
Review comment:
don't need `{}` in string interpenetration here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lornajane commented on issue #108: make quick-start fails when DOCKER_HOST isn't set
lornajane commented on issue #108: make quick-start fails when DOCKER_HOST isn't set URL: https://github.com/apache/incubator-openwhisk-devtools/issues/108#issuecomment-395583513 Finally got time to retry with my linux machine and I had a similar but different problem. I now need to set `export DOCKER_HOST_IP=172.17.0.1` which refers to the host machine and works from both the host machine itself and from inside the containers. I believe this value is automatically set on OS X, but it wasn't for me (now on Ubuntu 18.04). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lornajane commented on issue #129: make quick-start hangs on setup phase
lornajane commented on issue #129: make quick-start hangs on setup phase URL: https://github.com/apache/incubator-openwhisk-devtools/issues/129#issuecomment-395582959 I have just had a similar problem on Linux and fixed it with `export DOCKER_HOST_IP=172.17.0.1` - maybe this will help you too? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3507: allow use of string for controller id
rabbah commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-395581898 should get a PG. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903226
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
+ def toInt: Int = instance
+}
+
+case class ControllerInstanceId(private val instance: String) {
+ //keep instance private, since we will replace illegal chars for kafka usage
+ //for kafka topic legal chars see
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L29
+ val ILLEGAL_CHARS = "[^a-zA-Z0-9._-]".r
+ //validate once on construction - reserve 20 (arbitrary) chars for prefix to
be prepended to create topic names
+ private val MAX_NAME_LENGTH = 249 - 20
Review comment:
this too can be in the singleton.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903495
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -202,7 +202,7 @@ object Controller {
// if deploying multiple instances (scale out), must pass the instance
number as the
require(args.length >= 1, "controller instance required")
-val instance = args(0).toInt
+val instance = ControllerInstanceId(args(0).trim)
Review comment:
i think trim is not necessary since you will replace space it in the
constructor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903178
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
+ def toInt: Int = instance
+}
+
+case class ControllerInstanceId(private val instance: String) {
+ //keep instance private, since we will replace illegal chars for kafka usage
+ //for kafka topic legal chars see
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L29
+ val ILLEGAL_CHARS = "[^a-zA-Z0-9._-]".r
Review comment:
also should probably move to singleton.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903004
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
+ def toInt: Int = instance
+}
+
+case class ControllerInstanceId(private val instance: String) {
Review comment:
if we don't match on the case class anywhere, might as well make this as
regular class which will actually hide `instance`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252805
##
File path:
tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
##
@@ -1747,7 +1747,7 @@ trait WebActionsApiBaseTests extends
ControllerTestCommon with BeforeAndAfterEac
}
class TestingEntitlementProvider(config: WhiskConfig, loadBalancer:
LoadBalancer)
- extends EntitlementProvider(config, loadBalancer, InstanceId(0)) {
Review comment:
if we can make all InstanceId essentially a StringInstanceId, then an
`apply(int)` instance would provide backward compatibility so you don't have to
change all the cons sites.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903815
##
File path:
tests/src/test/scala/whisk/core/entity/test/ControllerInstanceIdTests.scala
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity.test
+
+import org.junit.runner.RunWith
+import org.scalatest.FlatSpec
+import org.scalatest.Matchers
+import org.scalatest.junit.JUnitRunner
+import whisk.core.entity.ControllerInstanceId
+
+@RunWith(classOf[JUnitRunner])
+class ControllerInstanceIdTests extends FlatSpec with Matchers {
+
+ behavior of "StringInstanceId"
+
+ it should "strip unusable characters when creating a topic name" in {
+val id = ControllerInstanceId("1234&&^^%%5$$7890._-123")
Review comment:
add trailing space for `trim` test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193903140
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
+ def toInt: Int = instance
+}
+
+case class ControllerInstanceId(private val instance: String) {
+ //keep instance private, since we will replace illegal chars for kafka usage
+ //for kafka topic legal chars see
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L29
+ val ILLEGAL_CHARS = "[^a-zA-Z0-9._-]".r
Review comment:
does this need to be public?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala
csantanapr commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala URL: https://github.com/apache/incubator-openwhisk/pull/3732#issuecomment-395581479 @tysonnorris @houshengbo was able to find an `adoptopenjdk` that is hotspot and not openj9. So moving to this I think is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193902709
##
File path:
common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.entity
+
+import spray.json.DefaultJsonProtocol
+
+case class InvokerInstanceId(val instance: Int, name: Option[String] = None) {
Review comment:
hmm this file contains both invoer and controller ids... would leave it as
intance.id or break it up into two files as the better approach?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah opened a new pull request #315: Introduce some utility methods in triggers.go to reduce copy/paste
rabbah opened a new pull request #315: Introduce some utility methods in triggers.go to reduce copy/paste URL: https://github.com/apache/incubator-openwhisk-cli/pull/315 Add a method for working with parameters and annotations, and creating the feed life cycle event. This is intended as an incremental change that is mostly semantic preserving. Because of the extent of refactoring needed, many small incremental patches will be suitable. There is one small semantic change here which is to start exiting early on error. This is the code moved from `main` to `util`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #314: refactor CLI to reduce bloat
rabbah opened a new issue #314: refactor CLI to reduce bloat URL: https://github.com/apache/incubator-openwhisk-cli/issues/314 The CLI code is quite bloated with a lot of copy/paste, little sharing of code for CRUD operations, redundancy between CREATE and UPDATE, and unnecessary JSON structs for working with API responses. Further, the use of global `Flags` across asset handlers can be confusing and should be removed. Where possible, we should remove all the global variable references that are mutable. The intent is to refactor the code so that: - CRUD operations share common functions more closely - Remove the repetitive error messages which are used as format strings, and ids - Remove all unnecessary structs which are used for working with JSON - Exit on error, because the returned errors just bubble up to `main` which exits anyway This should reduce significantly reduce the lines of code in the CLI - as a rough measure of bloat: `wc -l commands/*.go` is 7204 `cat commands/*.go | sort -u | wc -l` is 3318 The CLI should be leaner and easier to work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #313: cannot wsk trigger update
rabbah opened a new issue #313: cannot wsk trigger update URL: https://github.com/apache/incubator-openwhisk-cli/issues/313 `wsk trigger update x` for any new trigger `x` will fail because the code tries to fetch the trigger first and exists if it's not found. This is not consistent with `wsk action update`, `wsk rule update`, and `wsk package update` all of which will create the entity if it doesn't exist. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3694: Add retries to CLI test framework for network errors
mdeuser commented on a change in pull request #3694: Add retries to CLI test
framework for network errors
URL:
https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r193895451
##
File path: tests/src/test/scala/common/Wsk.scala
##
@@ -1036,13 +1036,28 @@ trait RunWskCmd extends BaseRunWsk {
val args = baseCommand
if (verbose) args += "--verbose"
if (showCmd) println(args.mkString(" ") + " " + params.mkString(" "))
-val rr = TestUtils.runCmd(
- DONTCARE_EXIT,
- workingDir,
- TestUtils.logger,
- sys.env ++ env,
- stdinFile.getOrElse(null),
- args ++ params: _*)
+val rr =
+ retry(
+{
+ val rr = TestUtils.runCmd(
+DONTCARE_EXIT,
+workingDir,
+TestUtils.logger,
+sys.env ++ env,
+stdinFile.getOrElse(null),
+args ++ params: _*)
+
+ if (expectedExitCode != NETWORK_ERROR_EXIT) {
+withClue(hideStr(reportFailure(args ++ params, expectedExitCode,
rr).toString(), hideFromOutput)) {
Review comment:
will each retry will have a `withClue` stack trace message, followed by a
final `withClue` message (line 1062) if all retries fail?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility
tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility URL: https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193895111 ## File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala ## @@ -53,10 +58,12 @@ import whisk.core.entity.size.SizeLong * @param hostname the host name * @param timeout the timeout in msecs to wait for a response * @param maxResponse the maximum size in bytes the connection will accept + * @param maxConcurrent the maximum number of concurrent requests allowed */ -protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize)( +protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize, maxConcurrent: Int)( Review comment: Tried this, it fails compilation with an issue in using `object HttpUtils` from elsewhere - doesn't seem right, is there something special when object is public, using private class with default constructor args? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #214: Add Notice file
dgrove-oss opened a new pull request #214: Add Notice file URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala
tysonnorris commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala URL: https://github.com/apache/incubator-openwhisk/pull/3732#issuecomment-395570940 @dubee fine by me - I only left as `openjdk` instead of `adoptopenjdk` per carlos request in #3504 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3507: allow use of string for controller id
tysonnorris commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-395568367 classes renamed, let me know if you have other comments? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #931: schema encoding of the runtime manifest schema uses uint16
mrutkows closed issue #931: schema encoding of the runtime manifest schema uses uint16 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/931 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #930: wskdeploy should fail if host info does not parse or cannot be retrieved
mrutkows closed issue #930: wskdeploy should fail if host info does not parse or cannot be retrieved URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/930 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #929: if manifest read fails, wskdeploy should not read details from hardcoded manifest
mrutkows closed issue #929: if manifest read fails, wskdeploy should not read details from hardcoded manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/929 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #928: hardcoded protocol does not allow for http to be used
mrutkows closed issue #928: hardcoded protocol does not allow for http to be used URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/928 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #927: action deployed when runtime is deprecated
mrutkows closed issue #927: action deployed when runtime is deprecated URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/927 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #3704: Provide graceful shutdown for invoker
dubee commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193886385
##
File path:
common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
##
@@ -163,6 +171,26 @@ class MessageFeed(description: String,
goto(FillingPipeline)
} else stay
+case Event(GracefulShutdown, _) =>
+ goto(GracefulShutdownDrain)
+
+case _ => stay
+ }
+
+ when(GracefulShutdownDrain) {
+case Event(Processed, _) =>
+ updateHandlerCapacity()
+ sendOutstandingMessages()
+ stay
+
+case Event(FillCompleted(messages), _) =>
Review comment:
Hmm, do we know if events are handled in synchronous or asynchronous fashion
in the Akka FSM?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #3704: Provide graceful shutdown for invoker
dubee commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193886385
##
File path:
common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
##
@@ -163,6 +171,26 @@ class MessageFeed(description: String,
goto(FillingPipeline)
} else stay
+case Event(GracefulShutdown, _) =>
+ goto(GracefulShutdownDrain)
+
+case _ => stay
+ }
+
+ when(GracefulShutdownDrain) {
+case Event(Processed, _) =>
+ updateHandlerCapacity()
+ sendOutstandingMessages()
+ stay
+
+case Event(FillCompleted(messages), _) =>
Review comment:
Hmm, do we know if events are handled synchronous or asynchronous in the
Akka FSM?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss closed pull request #213: Add the DISCLAIMER file for Apache incubator project
dgrove-oss closed pull request #213: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/213 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/DISCLAIMER.txt b/DISCLAIMER.txt new file mode 100644 index 000..f6c0ece --- /dev/null +++ b/DISCLAIMER.txt @@ -0,0 +1 @@ +Apache OpenWhisk is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. diff --git a/README.md b/README.md index aee96b6..f4eea6d 100644 --- a/README.md +++ b/README.md @@ -198,3 +198,7 @@ If your OpenWhisk deployment is not working, check our Report bugs, ask questions and request features [here on GitHub](../../issues). You can also join our slack channel and chat with developers. To get access to our slack channel, request an invite [here](http://slack.openwhisk.org). + +# Disclaimer + +Apache OpenWhisk is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maximann opened a new pull request #270: Fix binary encoding
maximann opened a new pull request #270: Fix binary encoding URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/270 This addresses #269 Note: I'm not a python coder, so I'm sure there might be better ways to achieve this. When encoding binary data (ascii string) as utf with variable length encoding only 7 bits are preserved. The 8th bit has a special meaning to indicate the variable encoding "continuation bit". This will of course corrupt any true binary data that has values larger than 127. A secondary issue addressed in this MR relates to the base 64 encoding mechanism. The method called previously inserts newline characters in the encoded string every 76 characters, something that's not typically expected in newer encoding libraries. I've added a new flag which allows encoding without newline characters (which I assume is what most people will expect). Finally, each message is encoded twice in the current implementation, once to retrieve the size and a second time to actually trigger the function. This fix has the potential to break existing functions that may rely on the old behavior. I'm not sure how to address that and would appreciate feedback. A new parameter to trigger the fixed binary encoding may be necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maximann commented on issue #269: Binary Encoding causes Corruption
maximann commented on issue #269: Binary Encoding causes Corruption URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/269#issuecomment-395519353 I will submit a PR shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3694: Add retries to CLI test framework for network errors
codecov-io commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=h1) Report > Merging [#3694](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3694 +/- ## == - Coverage 75.06% 75.05% -0.01% == Files 127 127 Lines6043 6045 +2 Branches 388 388 == + Hits 4536 4537 +1 - Misses 1507 1508 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ommon/scala/src/main/scala/whisk/utils/Retry.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL1JldHJ5LnNjYWxh) | `87.5% <66.66%> (-12.5%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=footer). Last update [fe19220...fa0668b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3729: Add brief Kubernetes Setup section to main README.md
codecov-io commented on issue #3729: Add brief Kubernetes Setup section to main README.md URL: https://github.com/apache/incubator-openwhisk/pull/3729#issuecomment-395538299 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=h1) Report > Merging [#3729](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3729 +/- ## === Coverage 75.06% 75.06% === Files 127 127 Lines6043 6043 Branches 388 388 === Hits 4536 4536 Misses 1507 1507 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=footer). Last update [fe19220...d2bb1ca](https://codecov.io/gh/apache/incubator-openwhisk/pull/3729?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on a change in pull request #3467: Remove actionControllers
tests from incubator-openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk/pull/3467#discussion_r193863012
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -104,19 +113,25 @@ object ActionContainer {
sys.props
.get("docker.host")
.orElse(sys.env.get("DOCKER_HOST"))
+.orElse {
+ // Check if we are running on docker-machine env.
+
Option(WhiskProperties.getProperty("whisk.version.name")).filter(_.toLowerCase.contains("mac")).map
{
+case _ => s"tcp://${WhiskProperties.getMainDockerEndpoint}"
+ }
+}
Review comment:
it's a nice convenience - the precedence order is -D, ENV, then whisk props.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3704: Provide graceful shutdown for invoker
codecov-io commented on issue #3704: Provide graceful shutdown for invoker URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging [#3704](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **decrease** coverage by `0.57%`. > The diff coverage is `3.84%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3704 +/- ## == - Coverage 75.06% 74.48% -0.58% == Files 127 127 Lines6043 6091 +48 Branches 388 382 -6 == + Hits 4536 4537 +1 - Misses 1507 1554 +47 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=tree) | Coverage Δ | | |---|---|---| | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/common/Scheduler.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9TY2hlZHVsZXIuc2NhbGE=) | `100% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `84.88% <0%> (-1%)` | :arrow_down: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...n/scala/whisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==) | `73.8% <18.18%> (-9.76%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=footer). Last update [fe19220...e3f614a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3731: Relax connection retry in invoker
dubee closed pull request #3731: Relax connection retry in invoker
URL: https://github.com/apache/incubator-openwhisk/pull/3731
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
b/common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
index 07c6fc7e5b..d39118201d 100644
--- a/common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
+++ b/common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
@@ -126,9 +126,8 @@ protected[core] class HttpUtils(hostname: String, timeout:
FiniteDuration, maxRe
} match {
case Success(response) => response
case Failure(t: RetryableConnectionError) if retry =>
-val sleepTime = 10.milliseconds
+val sleepTime = 50.milliseconds
if (timeout > Duration.Zero) {
- logging.info(this, s"POST failed with ${t} - retrying after sleeping
${sleepTime}.")
Thread.sleep(sleepTime.toMillis)
val newTimeout = timeout - sleepTime
execute(request, newTimeout, retry = true)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo
csantanapr commented on a change in pull request #3467: Remove
actionControllers tests from incubator-openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk/pull/3467#discussion_r193860177
##
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##
@@ -104,19 +113,25 @@ object ActionContainer {
sys.props
.get("docker.host")
.orElse(sys.env.get("DOCKER_HOST"))
+.orElse {
+ // Check if we are running on docker-machine env.
+
Option(WhiskProperties.getProperty("whisk.version.name")).filter(_.toLowerCase.contains("mac")).map
{
+case _ => s"tcp://${WhiskProperties.getMainDockerEndpoint}"
+ }
+}
Review comment:
I don't like this, I don't want the runtimes test to rely on WhiskProperties
to have a `whisk.properties` file present.
If user is using docker-machine the `DOCKER_HOST` env variable needs to be
set and use.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala
codecov-io commented on issue #3732: Switch to use adoptopenjdk/openjdk8:jdk8u172-b11-alpine for scala URL: https://github.com/apache/incubator-openwhisk/pull/3732#issuecomment-395532604 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=h1) Report > Merging [#3732](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3732 +/- ## === Coverage 75.06% 75.06% === Files 127 127 Lines6043 6043 Branches 388 388 === Hits 4536 4536 Misses 1507 1507 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=footer). Last update [fe19220...8d68cc8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3732?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #3694: Add retries to CLI test framework for network errors
dubee commented on a change in pull request #3694: Add retries to CLI test
framework for network errors
URL:
https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r193858792
##
File path: tests/src/test/scala/common/Wsk.scala
##
@@ -1036,13 +1036,28 @@ trait RunWskCmd extends BaseRunWsk {
val args = baseCommand
if (verbose) args += "--verbose"
if (showCmd) println(args.mkString(" ") + " " + params.mkString(" "))
-val rr = TestUtils.runCmd(
- DONTCARE_EXIT,
- workingDir,
- TestUtils.logger,
- sys.env ++ env,
- stdinFile.getOrElse(null),
- args ++ params: _*)
+val rr =
+ retry(
+{
+ val rr = TestUtils.runCmd(
+DONTCARE_EXIT,
+workingDir,
+TestUtils.logger,
+sys.env ++ env,
+stdinFile.getOrElse(null),
+args ++ params: _*)
+
+ if (expectedExitCode != NETWORK_ERROR_EXIT) {
+withClue(hideStr(reportFailure(args ++ params, expectedExitCode,
rr).toString(), hideFromOutput)) {
Review comment:
Yes, `withClue` will print the stack trace if the final retry fails.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #3709: Inlined attachments
csantanapr commented on issue #3709: Inlined attachments URL: https://github.com/apache/incubator-openwhisk/pull/3709#issuecomment-395531440 PG1 2996 ⌛️ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3731: Relax connection retry in invoker
codecov-io commented on issue #3731: Relax connection retry in invoker URL: https://github.com/apache/incubator-openwhisk/pull/3731#issuecomment-395528400 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=h1) Report > Merging [#3731](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fe19220689029572670f5fd422564d87c991c07a?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3731 +/- ## == - Coverage 75.06% 75.05% -0.01% == Files 127 127 Lines6043 6042 -1 Branches 388 393 +5 == - Hits 4536 4535 -1 Misses 1507 1507 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `91.3% <100%> (-0.19%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=footer). Last update [fe19220...276c466](https://codecov.io/gh/apache/incubator-openwhisk/pull/3731?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3704: Provide graceful shutdown for invoker
rabbah commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193853597
##
File path:
common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
##
@@ -163,6 +171,26 @@ class MessageFeed(description: String,
goto(FillingPipeline)
} else stay
+case Event(GracefulShutdown, _) =>
+ goto(GracefulShutdownDrain)
+
+case _ => stay
+ }
+
+ when(GracefulShutdownDrain) {
+case Event(Processed, _) =>
+ updateHandlerCapacity()
+ sendOutstandingMessages()
+ stay
+
+case Event(FillCompleted(messages), _) =>
Review comment:
right - if filling, you need to wait.
you'll also need to prevent a further fill.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #269: Binary Encoding causes Corruption
rabbah commented on issue #269: Binary Encoding causes Corruption URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/269#issuecomment-395519569 @maximann fork the repo, then you can create branches in your own fork, and submit a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maximann commented on issue #269: Binary Encoding causes Corruption
maximann commented on issue #269: Binary Encoding causes Corruption URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/269#issuecomment-395519353 I don't have permissions to create a branch so I'm attaching a patch here. [issue-269.zip](https://github.com/apache/incubator-openwhisk-package-kafka/files/2081648/issue-269.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3731: Relax connection retry in invoker
rabbah commented on issue #3731: Relax connection retry in invoker URL: https://github.com/apache/incubator-openwhisk/pull/3731#issuecomment-395516765 travis not enough? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3731: Relax connection retry in invoker
rabbah commented on issue #3731: Relax connection retry in invoker URL: https://github.com/apache/incubator-openwhisk/pull/3731#issuecomment-395516765 travis not enugh? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last commented on issue #3731: Relax connection retry in invoker
sven-lange-last commented on issue #3731: Relax connection retry in invoker URL: https://github.com/apache/incubator-openwhisk/pull/3731#issuecomment-395515577 PG 1 / 2995 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #3732: Try another openjdk to see it fits
houshengbo opened a new pull request #3732: Try another openjdk to see it fits URL: https://github.com/apache/incubator-openwhisk/pull/3732 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maximann opened a new issue #269: Binary Encoding causes Corruption
maximann opened a new issue #269: Binary Encoding causes Corruption URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/269 It looks to me like https://github.com/apache/incubator-openwhisk-package-kafka/blob/449bbae13e813ba4dcd11dc33f47ab29d5e3541a/provider/consumer.py#L455 encodes all values as UTF-8 before base64. My understanding is that some byte values are not valid UTF-8, thus corruption can occur at the line above. ISO-8859-1 seems like the better choice. I'd be happy to file a bug if this seems like a reasonable hypothesis and if someone could point me to where to do that. I was also wondering if someone has encountered a similar issue before, especially since binary serializers such as Avro are popular for Kafka. Slack Transcript: id you try the with the parameter “isBinaryValue” set to true ? Max Manndorff [18 hours ago] Yes csantanapr [18 hours ago] I believe the intention is to take the binary data encode base64 to be able to be sent to the controller http rest api csantanapr [18 hours ago] The controller will take the base64 in the json, passed it down thru kafka, invoker sends the base64 data in a http post request to the function runtime, the function receives the application/json with the this field base64 data Max Manndorff [18 hours ago] Right, that makes sense. But my understanding is all of this happens after binary data was consumed in the provider code linked above, so the corrupted data gets passed along just fine and makes it to the invocation correctly. But when binary messages are consumed from the external kafka cluster (the cluster which the trigger is setup for), and encoded as a UTF-8 strings before being passed along to the controller, the corruption has already happened. Or at least that's what I think is happening. csantanapr [17 hours ago] I think we saw a problem in practice we found messages had corrupted data and the line 456 is what tries to attempt to clean Max Manndorff [17 hours ago] Definitely seeing that in my logs: ```[2018-06-06T23:24:13.040Z] [WARNING] [??] [kafkatriggers] [/core/qmpTrigger] Value contains non-unicode bytes. Replacing invalid bytes.``` Max Manndorff [17 hours ago] If you're ok with it I'll try to fix this for binary formats such as Avro tomorrow and send a diff your way. csantanapr [17 hours ago] You mean don’t do encode utf-8 when isBinaryValue=true ? csantanapr [17 hours ago] My concern is current users how are they impacted in production with the change csantanapr [17 hours ago] When they proceess the input value in the function and they decode base64 they get UTF-8 data and work on that data. (edited) csantanapr [17 hours ago] With this change then their value data will not be UTF-8 and they functions would start to fail unexpectedly? csantanapr [17 hours ago] I’m all in for improving the code but no throwing the current customers under the bus, oops I meant users :smiley_cat: csantanapr [17 hours ago] Open and issue on the kafka repo and submit a PR so we can discuss more in depth the details with others Max Manndorff [17 hours ago] Sounds good, will do Max Manndorff [17 hours ago] Thanks Max Manndorff [17 hours ago] (I agree, valid concerns) (edited) csantanapr [17 hours ago] Maybe we need an extra parameter, or maybe is compatible or we try one and then other one think about it csantanapr [17 hours ago] Or deprecate and use new method, or handle triggers already created leave them alone etc... csantanapr [17 hours ago] Those are the type of things I also want to include as part of the fix and companion tests how roll it out to production csantanapr [17 hours ago] This is Awesome that people are coming forward to contribute to event feeds +1 cc @dubee Max Manndorff [17 hours ago] FWIW, I doubt that true binary works at all. The issue is explained here as well: https://haacked.com/archive/2012/01/30/hazards-of-converting-binary-data-to-a-string.aspx/ You’ve Been Haacked Hazards of Converting Binary Data To A String Back in November, someone asked a question on StackOverflow about converting arbitrary binary data (in the form of a byte array) to a string. I know this because I make it a habit to read randomly selected questions in StackOverflow written in November 2011. Questions about text encodings in particular really turn me on. Jan 29th, 2012 at 4:00 PM (edited) csantanapr [17 hours ago] You might be correct csantanapr [17 hours ago] We just need something that can be safely pass thru http application/json csantanapr [17 hours ago] That’s why my explanation on all the touch points that data gets touch and transform csantanapr [17 hours ago] In the issue we can ping
[GitHub] mdeuser commented on a change in pull request #3694: Add retries to CLI test framework for network errors
mdeuser commented on a change in pull request #3694: Add retries to CLI test
framework for network errors
URL:
https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r193823978
##
File path: tests/src/test/scala/common/Wsk.scala
##
@@ -1036,13 +1036,28 @@ trait RunWskCmd extends BaseRunWsk {
val args = baseCommand
if (verbose) args += "--verbose"
if (showCmd) println(args.mkString(" ") + " " + params.mkString(" "))
-val rr = TestUtils.runCmd(
- DONTCARE_EXIT,
- workingDir,
- TestUtils.logger,
- sys.env ++ env,
- stdinFile.getOrElse(null),
- args ++ params: _*)
+val rr =
+ retry(
+{
+ val rr = TestUtils.runCmd(
+DONTCARE_EXIT,
+workingDir,
+TestUtils.logger,
+sys.env ++ env,
+stdinFile.getOrElse(null),
+args ++ params: _*)
+
+ if (expectedExitCode != NETWORK_ERROR_EXIT) {
+withClue(hideStr(reportFailure(args ++ params, expectedExitCode,
rr).toString(), hideFromOutput)) {
Review comment:
is the `withClue` line still needed now that the `retry` is displaying the
failure message?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sven-lange-last opened a new pull request #3731: Relax connection retry in invoker
sven-lange-last opened a new pull request #3731: Relax connection retry in invoker URL: https://github.com/apache/incubator-openwhisk/pull/3731 ## Description * In the past, sleep time between connection retries has been 100 ms. This has been lowered to 10 ms with #3710. On a loaded invoker, 50 ms makes more sense. * Reduce log volume on loaded invoker. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] idibidiart opened a new issue #3730: Is latest NodeJS 10.2.x supported as a runtime?
idibidiart opened a new issue #3730: Is latest NodeJS 10.2.x supported as a runtime? URL: https://github.com/apache/incubator-openwhisk/issues/3730 Is latest NodeJS 10.2.x supported as a runtime? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #213: Add the DISCLAIMER file for Apache incubator project
dgrove-oss opened a new pull request #213: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #724: API Gateway - Add support to specify response type in manifest file
pritidesai commented on issue #724: API Gateway - Add support to specify response type in manifest file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724#issuecomment-395464144 yup definitely, please refer to wip PR #951, expecting it to be completed by this week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] akrabat commented on issue #11: Set up PHP 7.1 runtime for multiarch build
akrabat commented on issue #11: Set up PHP 7.1 runtime for multiarch build URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/11#issuecomment-395458557 What does using Jesse do to the size of the image and does that have implications for cold-start time? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3
rabbah commented on issue #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27#issuecomment-395455618 not necessary should be able to rebase and merge as there are no conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] akrabat commented on issue #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3
akrabat commented on issue #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27#issuecomment-395455325 Fixed that version number @rabbah. Do you want me to rebase it into the previous commit? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] akrabat commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3
akrabat commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27#discussion_r193781999 ## File path: core/php7.1Action/CHANGELOG.md ## @@ -0,0 +1,44 @@ + + +## 1.0.1 + +- Change: Update PHP to 7.1.8 +- Change: Update [guzzlehttp/guzzle](https://packagist.org/packages/guzzlehttp/guzzle) to 6.3.3 +- Change: Update [ramsey/uuid](https://packagist.org/packages/ramsey/uuid) to 3.7.3 + +## 1.0.0 +Initial release + +- Added: PHP: 7.1.9. Review comment: > was this 7.1.9? I believe so. At least, that's what `openwhisk/action-php-v7.1:latest` from Docker Hub has. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr=desc) will **increase** coverage by `0.59%`. > The diff coverage is `59.25%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.09% +0.59% == Files 126 127 +1 Lines5994 6048 +54 Branches 392 385 -7 == + Hits 4466 4542 +76 + Misses 1528 1506 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=tree) | Coverage Δ | | |---|---|---| | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=footer). Last update [7082e94...d7520e1](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr=desc) will **increase** coverage by `0.59%`. > The diff coverage is `59.25%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.09% +0.59% == Files 126 127 +1 Lines5994 6048 +54 Branches 392 385 -7 == + Hits 4466 4542 +76 + Misses 1528 1506 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=footer). Last update [7082e94...d7520e1](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] dgrove-oss opened a new pull request #3729: Add brief Kubernetes Setup section to main README.md
dgrove-oss opened a new pull request #3729: Add brief Kubernetes Setup section to main README.md URL: https://github.com/apache/incubator-openwhisk/pull/3729 ## Description With the recent improvements to the Helm-based deployment of OpenWhisk on Kubernetes, I think the user experience of deploying it is smooth enough we should make this option more visible. Added a 1 paragraph section on Kubernetes deployment to the main README.md with a link to the deploy-kube repo for details. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ x ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #26: Add the DISCLAIMER file for Apache incubator project
rabbah closed pull request #26: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/DISCLAIMER.txt b/DISCLAIMER.txt new file mode 100644 index 000..ab06725 --- /dev/null +++ b/DISCLAIMER.txt @@ -0,0 +1 @@ +Apache OpenWhisk Runtime PHP is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. diff --git a/README.md b/README.md index cc6054c..5d66dcc 100644 --- a/README.md +++ b/README.md @@ -109,3 +109,7 @@ Using IntelliJ: -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128 ``` + +# Disclaimer + +Apache OpenWhisk Runtime PHP is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3
rabbah commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27#discussion_r193777978 ## File path: core/php7.1Action/CHANGELOG.md ## @@ -0,0 +1,44 @@ + + +## 1.0.1 + +- Change: Update PHP to 7.1.8 +- Change: Update [guzzlehttp/guzzle](https://packagist.org/packages/guzzlehttp/guzzle) to 6.3.3 +- Change: Update [ramsey/uuid](https://packagist.org/packages/ramsey/uuid) to 3.7.3 + +## 1.0.0 +Initial release + +- Added: PHP: 7.1.9. Review comment: was this 7.1.9? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3
rabbah commented on a change in pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27#discussion_r193777696 ## File path: core/php7.1Action/CHANGELOG.md ## @@ -0,0 +1,44 @@ + + +## 1.0.1 + +- Change: Update PHP to 7.1.8 Review comment: should be 7.1.18 matching the dockerfile. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
