Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach". Thanks for the input @sormuras! - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635369067
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove double quotes jdk.jconsole and jdk.jdi changes look fine. - Marked as reviewed by cjplummer (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-208012
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote: >> Yeah, I believe you're right. Noted as something else to file against the >> translation tool. > > Just out of curiosity, do we know why `\t` was attached in the first place? I > don't think it is with the original English properties. I can see that in 2012, the original did not have `\t` while the translated files did. (Did not search before then). Seems like this discrepancy originates from awhile ago. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635242656
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
>> line 278:
>>
>>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>>> "{0}" verweist auf das nicht deklarierte Element "{1}".
>>> 277: UniqueNotationName = Deklaration für die Notation "{0}" ist
>>> nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren
>>> Notationsdeklarationen deklariert werden.
>>> 278: ENTITYFailedInitializeGrammar = ENTITYDatatype-Validator:
>>> Nicht erfolgreich. Initialisierungsmethode muss mit einer gültigen
>>> Grammatikreferenz aufgerufen werden. \t
>>
>> It looks like the _zh_CN_ file should also have the `\t` removed, but such
>> changes are done by the translation tool. I think in this case, we should
>> manually remove it, and then file a bug against the translation tool.
>
> Yeah, I believe you're right. Noted as something else to file against the
> translation tool.
Just out of curiosity, do we know why `\t` was attached in the first place? I
don't think it is with the original English properties.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635231459
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove double quotes I was asked to have a look at this PR elsewhere. I cannot verify correctness of translation, but I can review this PR generally for `jdk.javadoc`. >From what I can see, the changes are only to the property files, which is >expected from the PR title. The keys from English files 1-1 match the keys >from non-English files: there are no missing or extra keys. >From that point of view, the changes to `jdk.javadoc` look good. - Marked as reviewed by prappo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2110098592
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties > line 285: > >> 283: VIRTUAL_MACHINE=Virtuelle Maschine >> 284: VM_ARGUMENTS=VM-Argumente >> 285: VMINTERNAL_FRAME_ACCESSIBLE_DESCRIPTION=Innerer Frame für das >> Monitoring einer Java Virtual Machine > > This one-off change is consistent with the change in > _src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java_. Consistently changed to be "[Denglisch](https://en.wikipedia.org/wiki/Denglisch)" instead of German. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634249847
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties >> line 409: >> >>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >>> ein nicht bedingtes Muster als auch ein Standardlabel >>> 408: >>> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch >>> umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster >> >> Here and elsewhere in this file and other translations, I'm surprised >> `switch` is not being translated, and is being capitalized. In the English >> form, it is not being used as a keyword, although could maybe be seen as a >> short form of `switch' statement, in which case `switch` should be treated >> as a keyword and not translated or capitalized. > > Good catch. Seems to be across all files and I'm assuming it's for the reason > you suggested. I'll bring this up to the go team. I have no way to fix this > since I can't rely on google translate. This can be caught in a future update > if the go team can successfully differentiate the difference between the word > `switch` and a `switch keyword`. Yes. "Switch ..." is the short form for "Das Switch-Statement ..." or "Das `switch` Statement ..." and all other longer forms that match the context. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634244985
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties >> line 66: >> >>> 64: label.size=Göße: >>> 65: label.source=: >>> 66: label.outputbins=Aächer: >> >> How confident are we in this ? >> google translate says that the old text referred to 'compartments' and the >> new one to 'areas' and I wonder why that is better ? >> >> https://translate.google.com/?sl=auto=en=Ausgabebereiche%0AAusgebefacher=translate > > "Ausgabefächer" is the best German translation here. The reason for going with "Bereich (area)" instead of "Fach (compartment)" is that an area is more general compared to a compartment. At least in German: every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach". - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634240847
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 325:
>>
>>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>>> 324: {"unknown", "unbekannt"},
>>> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
>>
>> The English entry is:
>>
>> {"Unmonitoring", "Unmonitoring {0} "},
>>
>> But the German entry now says "Monitoring". I'm sure what the original
>> "\u00DCberwachung" translates to, other than berwachung is monitoring. Now
>> this resource is partly in English, and is the incorrect English.
>
> I don't know German, but when plugging `"Monitoring von {0} aufheben"` into
> google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word
> that could also be used in German? No clue. The translation tool decided to
> make this change.
>
> @sormuras do you have any input on this?
It's correct.
The "Un" of "Unmonitoring" is moved to the associated verb in German:
"aufheben". which in this context translates to "cancel" or "revoke". This
seems to be one of the few cases where there's no commonly used single word in
German for "Unmonitoring".
> Now this resource is partly in English, and is the incorrect English.
That's how Tech-German often works - take a word from English and use it as-is,
sometimes missing the original meaning. Such words or phrases are then referred
to as: Denglisch.
In this case "Überwachung" was German, "Monitoring" is Denglisch. I'd revert
that to `\u00DCberwachung` - but both are okay.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634236406
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties > line 66: > >> 64: label.size=Göße: >> 65: label.source=: >> 66: label.outputbins=Aächer: > > How confident are we in this ? > google translate says that the old text referred to 'compartments' and the > new one to 'areas' and I wonder why that is better ? > > https://translate.google.com/?sl=auto=en=Ausgabebereiche%0AAusgebefacher=translate "Ausgabefächer" is the best German translation here. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634221518
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:38:18 GMT, Damon Nguyen wrote: >> While we do not translate Java keywords (when used as such, e.g. "`class` >> not allowed here"), and option names (e.g. `--class-path`) we have typically >> translated other text that is not mandated by the language or tools, (e.g. >> `the name of this class`, ``, ``. >> >> This change seems to be going backwards. >> >> Whatever the policy we use for translating (or not translating) parts of a >> message, we should be consistent across all tools and documents. > > @jonathan-gibbons I just realized that this change to the German file matches > the file with the Japanese and Chinese localized files. By that I mean the > "backwards" translations are also present for the Japanese and Chinese files. > > However, the previous versions of the Japanese and Chinese files don't have > these bits translated. So in summary, I can revert the German file back to > German but the Japanese and Chinese files will still be English for these > parts because I wouldn't know what to revert them to in their local language. > > As a result, I actually think it might be better to change this German file > as shown in the current version of the PR just to remain consistent with the > other localized versions of this file. We can still bring this up to the go > team as an issue, but I think this is the best solution now for this drop at > least. No one else except people reading this PR will spot inconsistencies between translations in different languages. So inconsistencies across languages will not be obvious to end users. But anyone (end-user) using the tool in any one of these languages is likely to spot inconsistencies in the translations for that one language. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633937355
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
> line 325:
>
>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>> 324: {"unknown", "unbekannt"},
>> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
>
> The English entry is:
>
> {"Unmonitoring", "Unmonitoring {0} "},
>
> But the German entry now says "Monitoring". I'm sure what the original
> "\u00DCberwachung" translates to, other than berwachung is monitoring. Now
> this resource is partly in English, and is the incorrect English.
I don't know German, but when plugging `"Monitoring von {0} aufheben"` into
google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word
that could also be used in German? No clue. The translation tool decided to
make this change.
@sormuras do you have any input on this?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633925334
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The translation tool adjusted some definitions, which causes some changes in
>> localized files where the source file had no changes. This causes some words
>> being reverted from localized languages to English, and some had its
>> definitions changed.
>>
>> Alternatively, the diffs are viewable here and was generated using Jonathan
>> Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove double quotes
src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
line 325:
> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
> 324: {"unknown", "unbekannt"},
> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
The English entry is:
{"Unmonitoring", "Unmonitoring {0} "},
But the German entry now says "Monitoring". I'm sure what the original
"\u00DCberwachung" translates to, other than berwachung is monitoring. Now this
resource is partly in English, and is the incorrect English.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633902362
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove double quotes - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/9125337b..32d69e89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19609=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19609=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
