Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1856027270 Merged to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino merged PR #14984: URL: https://github.com/apache/kafka/pull/14984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426827635
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -393,7 +400,7 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
-if (this.isAtLeast(IBP_3_7_IV0)) {
+if (this.isAtLeast(IBP_3_7_IV4)) {
Review Comment:
Noting that we do not have a test for this. In the interest of time, let's
add a test for this in a follow-on PR rather than here unless we find other
issues.
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -68,17 +68,17 @@ public void testDescribeWithKRaft() {
);
// Change expected message to reflect latest MetadataVersion
(SupportedMaxVersion increases when adding a new version)
assertEquals("Feature: metadata.version\tSupportedMinVersion:
3.0-IV1\t" +
-"SupportedMaxVersion: 3.7-IV3\tFinalizedVersionLevel:
3.3-IV1\t", outputWithoutEpoch(commandOutput));
+"SupportedMaxVersion: 3.8-IV0\tFinalizedVersionLevel:
3.3-IV1\t", outputWithoutEpoch(commandOutput));
}
-@ClusterTest(clusterType = Type.KRAFT, metadataVersion =
MetadataVersion.IBP_3_7_IV0)
+@ClusterTest(clusterType = Type.KRAFT, metadataVersion =
MetadataVersion.IBP_3_7_IV4)
Review Comment:
Seem that this change is unnecessary, but it doesn't hurt, either - so let's
leave it alone in the interest of time unless we find something else that
definitely needs fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
ijuma commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855332987 Java 21 build passed, others have failures that look unrelated: > Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest.testSyncTopicConfigs() Build / JDK 11 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() Build / JDK 11 and Scala 2.13 / kafka.network.SocketServerTest.testSaslReauthenticationFailureWithKip152SaslAuthenticate() Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated() Build / JDK 17 and Scala 2.13 / kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures() Build / JDK 17 and Scala 2.13 / org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest.testBumpTransactionalEpoch(String).quorum=kraft Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest.testSyncTopicConfigs() Build / JDK 8 and Scala 2.12 / kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testProduceConsumeWithWildcardAcls(String).quorum=kraft Build / JDK 8 and Scala 2.12 / kafka.api.SaslMultiMechanismConsumerTest.testCoordinatorFailover(String, String).quorum=zk.groupProtocol=generic Build / JDK 8 and Scala 2.12 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders() Build / JDK 8 and Scala 2.12 / org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest.testBumpTransactionalEpoch(String).quorum=kraft Build / JDK 8 and Scala 2.12 / org.apache.kafka.tiered.storage.integration.TransactionsWithTieredStoreTest.testSendOffsetsToTransactionTimeout(String).quorum=kraft Build / JDK 8 and Scala 2.12 / org.apache.kafka.tools.MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful [5] Type=Raft-Combined, MetadataVersion=3.8-IV0, Security=PLAINTEXT Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsBounceTest.testWithGroupId() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
No, you asked to split this PR into two separate PRs, one for 3.7 without
any reference to 3.8 and this one. I am saying that doing that has no value
because 3.8 is labeled as unstable so having it in 3.7 isn't an issue.
Customers cannot use 3.8 unless they explicitly allow unstable metadata
versions.
If we want 3.7 to be clean then you would also need to remove all ELR code
not just the MV referencing it. This would be a BIG change because it removes
tests and updates the JSON files representing the record format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
No, you asked to split this PR into two separate PRs, one for 3.7 without
any reference to 3.8 and this one. I am saying that doing that has no value
because 3.8 is labeled as unstable so having it in 3.7 isn't an issue.
Customers cannot use 3.8 unless they explicitly allow unstable metadata
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855063162 > Please update the PR description to explain what issue is being fixed. The description doesn't match the changes included in this PR. > > Same with the PR title. Is the [KAFKA-15922](https://issues.apache.org/jira/browse/KAFKA-15922) also related to this PR? The original PRs for KAFKA-15922 are what got us to this point. My PR here was just meant to bump the latest stable version to the MV supporting JBOD. I've added a little more to reduce the number of PRs that need to be committed to streamline things. All the changes though are related to KAFKA-15922. I have updated the comment to try to reflect the current state of changes. I have no idea what to change the title to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
You just need to return `false` for `isElrSupported()`. Is that what you are
asking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
You just need to return false for `isElrSupported()`. Is that what you are
asking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426120064
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
Okay, I updated the comment to try to make it clearer. This is where we
really need the KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
If we remove the tag from here should we also remove all the other code
associated with ELR from the 3.7 branch?
I don't think removing it from the 3.7 branch really buys us much of
anything except more code churn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
If we remove the tag from here should we also remove all the other code
associated with ELR from the 3.7 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426068254
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
+IBP_3_7_IV3(18, "3.7", "IV3", false),
+
+// Add new fetch request version for KIP-951
+IBP_3_7_IV4(19, "3.7", "IV4", false),
+
// Add ELR related supports (KIP-966).
-IBP_3_7_IV3(18, "3.7", "IV3", true);
+IBP_3_8_IV0(20, "3.8", "IV0", true);
Review Comment:
Can you split this change into two PRs/commits? One that fixes the MV in 3.7
and one that introduced the new 3.8 MV. The one that fixes the 3.7 versions
should be cherry picked to the 3.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
jolshan commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426014858
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
very small nit here -- but the comment could be a little clearer. Something
like
IBP_3_7_IV3 was reserved for ELR changes (KIP-966) but has been deferred to
a later MV
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426006570
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -228,6 +230,8 @@ public void testShortVersion() {
assertEquals("3.6", IBP_3_6_IV2.shortVersion());
assertEquals("3.7", IBP_3_7_IV0.shortVersion());
assertEquals("3.7", IBP_3_7_IV1.shortVersion());
+assertEquals("3.7", IBP_3_7_IV2.shortVersion());
+assertEquals("3.7", IBP_3_7_IV4.shortVersion());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426005487
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
MetadataVersion.IBP_3_7_IV0,
MetadataVersion.IBP_3_7_IV1,
MetadataVersion.IBP_3_7_IV2,
- MetadataVersion.IBP_3_7_IV3
+ MetadataVersion.IBP_3_7_IV4,
+ MetadataVersion.IBP_3_8_IV0
Review Comment:
I'm against adding it here as it doesn't add anything. IV4 and IV2 are the
important ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426004845
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -274,7 +278,8 @@ public void testVersion() {
assertEquals("3.7-IV0", IBP_3_7_IV0.version());
assertEquals("3.7-IV1", IBP_3_7_IV1.version());
assertEquals("3.7-IV2", IBP_3_7_IV2.version());
-assertEquals("3.7-IV3", IBP_3_7_IV3.version());
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003941
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
-// 3.7-IV0 is the latest production version in the 3.7 line
-assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+// 3.7-IV2 is the latest production version in the 3.7 line
+assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
assertEquals(IBP_3_7_IV0,
MetadataVersion.fromVersionString("3.7-IV0"));
assertEquals(IBP_3_7_IV1,
MetadataVersion.fromVersionString("3.7-IV1"));
assertEquals(IBP_3_7_IV2,
MetadataVersion.fromVersionString("3.7-IV2"));
-assertEquals(IBP_3_7_IV3,
MetadataVersion.fromVersionString("3.7-IV3"));
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003081
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
Done!
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
-// 3.7-IV0 is the latest production version in the 3.7 line
-assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+// 3.7-IV2 is the latest production version in the 3.7 line
+assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
jolshan commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425960046
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
I think that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425956907
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
MetadataVersion.IBP_3_7_IV0,
MetadataVersion.IBP_3_7_IV1,
MetadataVersion.IBP_3_7_IV2,
- MetadataVersion.IBP_3_7_IV3
+ MetadataVersion.IBP_3_7_IV4,
+ MetadataVersion.IBP_3_8_IV0
Review Comment:
Maybe we should keep this here as per the other comments? Not sure, since
the test will take some time, and maybe we don't want to spend it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425955291
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
-// 3.7-IV0 is the latest production version in the 3.7 line
-assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+// 3.7-IV2 is the latest production version in the 3.7 line
+assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
assertEquals(IBP_3_7_IV0,
MetadataVersion.fromVersionString("3.7-IV0"));
assertEquals(IBP_3_7_IV1,
MetadataVersion.fromVersionString("3.7-IV1"));
assertEquals(IBP_3_7_IV2,
MetadataVersion.fromVersionString("3.7-IV2"));
-assertEquals(IBP_3_7_IV3,
MetadataVersion.fromVersionString("3.7-IV3"));
Review Comment:
Keep it?
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
MetadataVersion.IBP_3_7_IV0,
MetadataVersion.IBP_3_7_IV1,
MetadataVersion.IBP_3_7_IV2,
- MetadataVersion.IBP_3_7_IV3
+ MetadataVersion.IBP_3_7_IV4,
+ MetadataVersion.IBP_3_8_IV0
Review Comment:
Notng that we are removing MetadataVersion.IBP_3_7_IV3 because it is
"burned" and will never be used.
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+// IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
I think we should keep the value and just not have anything associated with
it. Call it "reserved", similar to IBP_3_7_IV1. WDYT?
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
-// 3.7-IV0 is the latest production version in the 3.7 line
-assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+// 3.7-IV2 is the latest production version in the 3.7 line
+assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
Review Comment:
Isn't it IBP_3_7_IV4?
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -228,6 +230,8 @@ public void testShortVersion() {
assertEquals("3.6", IBP_3_6_IV2.shortVersion());
assertEquals("3.7", IBP_3_7_IV0.shortVersion());
assertEquals("3.7", IBP_3_7_IV1.shortVersion());
+assertEquals("3.7", IBP_3_7_IV2.shortVersion());
+assertEquals("3.7", IBP_3_7_IV4.shortVersion());
Review Comment:
Keep IV3?
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -274,7 +278,8 @@ public void testVersion() {
assertEquals("3.7-IV0", IBP_3_7_IV0.version());
assertEquals("3.7-IV1", IBP_3_7_IV1.version());
assertEquals("3.7-IV2", IBP_3_7_IV2.version());
-assertEquals("3.7-IV3", IBP_3_7_IV3.version());
Review Comment:
keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1424185932
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -166,13 +166,12 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
// 3.7-IV0 is the latest production version in the 3.7 line
Review Comment:
Thank you!
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
ijuma commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1423923940
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -166,13 +166,12 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
// 3.7-IV0 is the latest production version in the 3.7 line
Review Comment:
This comment doesn't seem correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
pprovenzano commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1851271238 Okay, I think I have addresses the issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]
rondagostino commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1850991968 @pprovenzano Can you look at the test failures? `60 tests have failed. There are 0 new tests failing, 60 existing failing` https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14984/2/tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
