Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108802/#review32111
---


Thanks for taking care of this! Just a few comments.


dolphin/src/dolphinpart.cpp


This if() is not useful, delete NULL is fine.



dolphin/src/dolphinpart.cpp


Shouldn't this be done only if addDel is true, as it was before?



dolphin/src/dolphinpart.cpp


Same code as in dolphincontextmenu. If it can't be shared, at least there 
should be a comment about where the code comes from, for easier maintainance.



dolphin/src/dolphinpart.cpp


There are other ways to bring the context menu than the right button. 
There's the context key, too.
So better watch for the QEvent::ContextMenu event instead of hardcoding 
"release of right button", if it really has to be done with the event filter.


- David Faure


On May 5, 2013, 1:53 p.m., Dawit Alemayehu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108802/
> ---
> 
> (Updated May 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Frank Reininghaus.
> 
> 
> Description
> ---
> 
> This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are 
> automatically toggled if the user presses the Shift key and allows  
> https://git.reviewboard.kde.org/r/107509/ to be applied.
> 
> The code is completely based on what Dolphin's context menu does. Even though 
> this works as planned, I still have reservations about the use of 
> KModifierKeyInfo since every key press event from any application is sent to 
> the application that connects to its signals. In my code and unlike what is 
> done in Dolphin's context menu, I try to mitigate the impact of that by 
> ignoring the signal when the part does not have the focus. Still if there is 
> a better way to capture key press events at the part level I would like to 
> use that instead. Any ideas ?
> 
> 
> Diffs
> -
> 
>   dolphin/src/dolphinpart.h 7881ded 
>   dolphin/src/dolphinpart.cpp 627ba79 
> 
> Diff: http://git.reviewboard.kde.org/r/108802/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

[Thiago Macieira]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110043/#review32093
---


I don't like it. There's a reason why I removed the equivalent code from Qt and 
there's a reason I refuse to consider adding it back. At least you've made this 
about filenames only, so there's hope.

If you're going to use any range, I recommend using the same, old range from Qt 
3 and early Qt 4.


kdecore/localization/klocale_kde.cpp


Use the same range that Qt used from 2003 to 2007: U+10FE00 to 10FEFF



kdecore/localization/klocale_kde.cpp


Don't check the BOM. No file names have BOM.



kdecore/localization/klocale_kde.cpp


BOM handling again.


- Thiago Macieira


On May 5, 2013, 8:13 a.m., Róbert Szókovács wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110043/
> ---
> 
> (Updated May 5, 2013, 8:13 a.m.)
> 
> 
> Review request for kdelibs and Thiago Macieira.
> 
> 
> Description
> ---
> 
> This patch works around the problem of filenames that are not valid UTF8 
> strings:  in KLocalePrivate::initFileNameEncoding() KDE sets the QFile's 
> encoding/decoding function, to to/fromUTF8() in QString, which in turn calls 
> QUtf8's converter function (QUtf8 is not exported to developers, so I had to 
> use an inefficient method, I think it would be better if we could use the 
> state parameter for error detection). I replaced this with the said 
> functions' copy/pasted version and changed it, so when it encounters an 
> invalid UTF8 string, it will encode it byte by byte, mapping the lower 128 
> their normal unicode place and the upper 128 to U+18000-U+1807F, and of 
> course the decoder reverses it. 
> To make this actually work you have to define the KDE_UTF8_FILENAMES 
> enviroment variable to a specific value ("broken_names").
> 
> To test it, do the following: .kde/env/KDE_UTF8_FILENAMES.sh with this 
> content: 
> export KDE_UTF8_FILENAMES=broken_names
> logout, login, try dolphin on faulty files. (instead of the usual boxed "?" 
> you'll see just boxes)
> 
> 
> This addresses bug 165044.
> http://bugs.kde.org/show_bug.cgi?id=165044
> 
> 
> Diffs
> -
> 
>   kdecore/localization/klocale_kde.cpp b010e74 
> 
> Diff: http://git.reviewboard.kde.org/r/110043/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/
---

(Updated May 5, 2013, 2:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime.


Description
---

This fixes most of the Krazy fixes for KUrifilter-plugins.
http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html


Diffs
-

  kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
  kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
  kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
  kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
  kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
  kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
  kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
  kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
  kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 

Diff: http://git.reviewboard.kde.org/r/110313/diff/


Testing
---

Compiles.
Only 4 issues remaining.


Thanks,

Maarten De Meyer

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/#review32088
---


This review has been submitted with commit 
b45d3208240e3fb0b0368b83e3a38b92d633bd75 by Maarten De Meyer to branch master.

- Commit Hook


On May 4, 2013, 10:50 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110313/
> ---
> 
> (Updated May 4, 2013, 10:50 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> ---
> 
> This fixes most of the Krazy fixes for KUrifilter-plugins.
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
>   kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
>   kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
>   kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
>   kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
>   kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
>   kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 
> 
> Diff: http://git.reviewboard.kde.org/r/110313/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> Only 4 issues remaining.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108802/
---

(Updated May 5, 2013, 1:53 p.m.)


Review request for KDE Base Apps, David Faure and Frank Reininghaus.


Changes
---

Update patch not to use KModifierKeyInfo.


Description
---

This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are 
automatically toggled if the user presses the Shift key and allows  
https://git.reviewboard.kde.org/r/107509/ to be applied.

The code is completely based on what Dolphin's context menu does. Even though 
this works as planned, I still have reservations about the use of 
KModifierKeyInfo since every key press event from any application is sent to 
the application that connects to its signals. In my code and unlike what is 
done in Dolphin's context menu, I try to mitigate the impact of that by 
ignoring the signal when the part does not have the focus. Still if there is a 
better way to capture key press events at the part level I would like to use 
that instead. Any ideas ?


Diffs (updated)
-

  dolphin/src/dolphinpart.h 7881ded 
  dolphin/src/dolphinpart.cpp 627ba79 

Diff: http://git.reviewboard.kde.org/r/108802/diff/


Testing
---


Thanks,

Dawit Alemayehu

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 1:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32081
---


This review has been submitted with commit 
c44df47be1ddf69df381ff44595c2332c83fab60 by Raymond Wooninck to branch master.

- Commit Hook


On May 5, 2013, 12:02 p.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 12:02 p.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32080
---

Ship it!


Ship It!

- Oswald Buddenhagen


On May 5, 2013, 12:02 p.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 12:02 p.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/#review32079
---

Ship it!


Ship It!

- Dawit Alemayehu


On May 4, 2013, 10:50 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110313/
> ---
> 
> (Updated May 4, 2013, 10:50 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> ---
> 
> This fixes most of the Krazy fixes for KUrifilter-plugins.
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
>   kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
>   kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
>   kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
>   kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
>   kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
>   kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 
> 
> Diff: http://git.reviewboard.kde.org/r/110313/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> Only 4 issues remaining.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Dawit Alemayehu]

> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/ikwsopts.cpp, line 412
> > 
> >
> > What is the point of using a QPointer when the parent is set to NULL ?
> 
> Maarten De Meyer wrote:
> The parent is not NULL, it is this (third argument). The firs argument is 
> the provider to be edited, or when creating a new provider: 0
> Please correct me if I'm wrong.

My mistake. I forgot my own code since I wrote it a long time ago.


- Dawit


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/#review32045
---


On May 4, 2013, 10:50 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110313/
> ---
> 
> (Updated May 4, 2013, 10:50 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> ---
> 
> This fixes most of the Krazy fixes for KUrifilter-plugins.
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
>   kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
>   kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
>   kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
>   kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
>   kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
>   kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 
> 
> Diff: http://git.reviewboard.kde.org/r/110313/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> Only 4 issues remaining.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Maarten De Meyer]

> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/ikwsopts.cpp, line 107
> > 
> >
> > what exactly is  ? Is this i18n specific keyword ?

Yes it is il8n semantic markup.  is a Line break, perhaps  tags are 
better here?
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics#Semantic_Tags


> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/ikwsopts.cpp, line 412
> > 
> >
> > What is the point of using a QPointer when the parent is set to NULL ?

The parent is not NULL, it is this (third argument). The firs argument is the 
provider to be edited, or when creating a new provider: 0
Please correct me if I'm wrong.


- Maarten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/#review32045
---


On May 4, 2013, 10:50 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110313/
> ---
> 
> (Updated May 4, 2013, 10:50 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> ---
> 
> This fixes most of the Krazy fixes for KUrifilter-plugins.
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
>   kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
>   kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
>   kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
>   kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
>   kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
>   kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 
> 
> Diff: http://git.reviewboard.kde.org/r/110313/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> Only 4 issues remaining.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 11:41 a.m., Oswald Buddenhagen wrote:
> > kdm/kfrontend/genkdmconf.c, line 2112
> > 
> >
> > and now you ignored the warning from the compiler. ;)

Apologies, my C/C++ knowledge is quite rusty :-)


- Raymond


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32067
---


On May 5, 2013, 12:02 p.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 12:02 p.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 12:02 p.m.)


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Changes
---

Fixes the compiler warning.


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs (updated)
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32067
---



kdm/kfrontend/genkdmconf.c


and now you ignored the warning from the compiler. ;)


- Oswald Buddenhagen


On May 5, 2013, 11:37 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 11:37 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 11:37 a.m.)


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Changes
---

Resolve the compile issue


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs (updated)
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32066
---



kdm/kfrontend/genkdmconf.c


you didn't compile that ...


- Oswald Buddenhagen


On May 5, 2013, 11:22 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 11:22 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

[Max Brazhnikov]

> > Ok, here's a patch for GetInfo_ReadfromPipe only:
> > http://people.freebsd.org/~makc/patches/read_from_pipe.diff
> 
> Looks good to me (although I have not tested it). Small note: there is 
> a contructor of QStringList taking a QString so if you have a list with 
> only one item you don't need to construct an empty list and then add 
> something using operator<<.

Yes, I'm aware of it, but 'operator<<' looks more clear for me.
 
> Side-note: there is a comment talking about using /proc/pci if lspci is 
> not found. Not that newer kernels do have a /proc/pci at all ;)

I prefer not to make functional changes in (linux) code, which I can't test :)

> >> While you're at it you
> >> can then fix the type (devies -> devices), too ;)
> > 
> > I've removed those comments completely.
> 
> Another solution for that problem ;)
> 
> Eike

Max

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

[Max Brazhnikov]

> Am 02.05.2013 15:49, schrieb Max Brazhnikov:
> 
> > Use libusb-1 to query info about usb devices in kinfocenter.
> > Remove *BSD specific code: it doesn't work on all supported FreeBSD
> > versions. In principle it can be saved for NetBSD, but NetBSD could
> > use libusb-1, thus drop it for simplification.
> > Remove polling and use DeviceNotifier instead.
> > Add FindLibUSB-1.cmake
> 
> First, the pkg-config stuff can be used on Windows. If the stuff isn't 
> there it will simply do nothing, but it could.

ok, I'll fix it.

> Then, find_library should never write it's stuff to a *_LIBRARIES 
> variable as it will always only find one lib. The libraries variable 
> should be composed from the libs found before and should not be a cached 
> variable.

ok.

> Finally, if the .pc provides a version you should use the newer 
> interface of FPHSA that also allows version selection.

Shouldn't cmake stuff work without pkg-config? Another problem is that FreeBSD 
has it's own implementation of  libusb, which claims v1.0 api and there's no 
way to determine the version analogous to libusb.org version.

> Eike

Max

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 11:22 a.m.)


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Changes
---

useradd should work equally on all distro's, therefore the distro check is 
removed and if useradd is found, then the greeteruid is created.


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs (updated)
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 11:01 a.m., Oswald Buddenhagen wrote:
> > kdm/kfrontend/genkdmconf.c, line 2112
> > 
> >
> > i wonder whether this condition is actually useful. i originally added 
> > it because some *BSDs (iirc) had an incompatible adduser command. the 
> > situation may be entirely different for useradd.

I guess that we could rely on the fact that if useradd is found, the command 
would work in the same way for all distro's.  I will update the patch and just 
leave the check for useradd


- Raymond


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32063
---


On May 5, 2013, 10:53 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 10:53 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32063
---



kdm/kfrontend/genkdmconf.c


i wonder whether this condition is actually useful. i originally added it 
because some *BSDs (iirc) had an incompatible adduser command. the situation 
may be entirely different for useradd.


- Oswald Buddenhagen


On May 5, 2013, 10:53 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 10:53 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 10:53 a.m.)


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Changes
---

Unified approach for debian and openSUSE based on useradd


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs (updated)
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote:
> > useradd also exists on debian ("useradd is a low level utility for adding 
> > users. On Debian, administrators should usually use adduser(8) instead."), 
> > so in principle the paths can be unified.
> > 
> > however, when i was trying to implement this a decade or so ago, useradd 
> > was apparently requiring the caller to provide a UID, at which point i 
> > simply gave up. did i look wrong? or is this feature a semi-new addition?
> 
> Raymond Wooninck wrote:
> According to the useradd man-page on openSUSE: 
> 
>-r, --system
>Create a system account.
> 
>System users will be created with no aging information in 
> /etc/shadow, and their numeric identifiers are chosen in the
>SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, 
> instead of UID_MIN-UID_MAX (and their GID counterparts for the creation of
>groups).
> 
>-u, --uid UID
>The numerical value of the user's ID. This value must be 
> unique, unless the -o option is used. The value must be non-negative. The
>default is to use the smallest ID value greater than or equal 
> to UID_MIN and greater than every other user.
> 
> So if UID is not given, then it will be determined through the default 
> (as indicated). 
> 
> I am also not sure if debian and openSUSE have the same version of 
> useradd, so that the two could be merged in a single statement.  If you are 
> running debian, then please send me the man page for useradd and I will 
> update the patch with a unified approach.
> 
> Thomas Lübking wrote:
> O.o?
> 
> I've *never* explicitly added a UID to useradd - and yes, i'm that old ;-)
> 
> As a "reference", a p-l article from 1999
> http://www.pro-linux.de/artikel/2/893/useradd.html
> 
> and here's a manpage, mentioning 1995 as last edition date
> 
> http://static.cray-cyber.org/Documentation/NEC_SX_R10_1/G1AH03E/USERADD.1M.HTML

Further checking indicates that openSUSE is currently using shadow-4.1.5.1, 
which seems to come from debian as that the source tarball is 
http://pkg-shadow.alioth.debian.org/releases/shadow-%{version}.tar.bz2

openSUSE added only a few patches to run a script to update a NIS database, so 
based on this I assume we can unified the coding. I will create a new patch in 
the next hour.


- Raymond


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32057
---


On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 8:04 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Thomas Lübking]

> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote:
> > useradd also exists on debian ("useradd is a low level utility for adding 
> > users. On Debian, administrators should usually use adduser(8) instead."), 
> > so in principle the paths can be unified.
> > 
> > however, when i was trying to implement this a decade or so ago, useradd 
> > was apparently requiring the caller to provide a UID, at which point i 
> > simply gave up. did i look wrong? or is this feature a semi-new addition?
> 
> Raymond Wooninck wrote:
> According to the useradd man-page on openSUSE: 
> 
>-r, --system
>Create a system account.
> 
>System users will be created with no aging information in 
> /etc/shadow, and their numeric identifiers are chosen in the
>SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, 
> instead of UID_MIN-UID_MAX (and their GID counterparts for the creation of
>groups).
> 
>-u, --uid UID
>The numerical value of the user's ID. This value must be 
> unique, unless the -o option is used. The value must be non-negative. The
>default is to use the smallest ID value greater than or equal 
> to UID_MIN and greater than every other user.
> 
> So if UID is not given, then it will be determined through the default 
> (as indicated). 
> 
> I am also not sure if debian and openSUSE have the same version of 
> useradd, so that the two could be merged in a single statement.  If you are 
> running debian, then please send me the man page for useradd and I will 
> update the patch with a unified approach.

O.o?

I've *never* explicitly added a UID to useradd - and yes, i'm that old ;-)

As a "reference", a p-l article from 1999
http://www.pro-linux.de/artikel/2/893/useradd.html

and here's a manpage, mentioning 1995 as last edition date
http://static.cray-cyber.org/Documentation/NEC_SX_R10_1/G1AH03E/USERADD.1M.HTML


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32057
---


On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 8:04 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote:
> > useradd also exists on debian ("useradd is a low level utility for adding 
> > users. On Debian, administrators should usually use adduser(8) instead."), 
> > so in principle the paths can be unified.
> > 
> > however, when i was trying to implement this a decade or so ago, useradd 
> > was apparently requiring the caller to provide a UID, at which point i 
> > simply gave up. did i look wrong? or is this feature a semi-new addition?

According to the useradd man-page on openSUSE: 

   -r, --system
   Create a system account.

   System users will be created with no aging information in 
/etc/shadow, and their numeric identifiers are chosen in the
   SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, instead 
of UID_MIN-UID_MAX (and their GID counterparts for the creation of
   groups).

   -u, --uid UID
   The numerical value of the user's ID. This value must be unique, 
unless the -o option is used. The value must be non-negative. The
   default is to use the smallest ID value greater than or equal to 
UID_MIN and greater than every other user.

So if UID is not given, then it will be determined through the default (as 
indicated). 

I am also not sure if debian and openSUSE have the same version of useradd, so 
that the two could be merged in a single statement.  If you are running debian, 
then please send me the man page for useradd and I will update the patch with a 
unified approach. 


- Raymond


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32057
---


On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 8:04 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32057
---


useradd also exists on debian ("useradd is a low level utility for adding 
users. On Debian, administrators should usually use adduser(8) instead."), so 
in principle the paths can be unified.

however, when i was trying to implement this a decade or so ago, useradd was 
apparently requiring the caller to provide a UID, at which point i simply gave 
up. did i look wrong? or is this feature a semi-new addition?

- Oswald Buddenhagen


On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> ---
> 
> (Updated May 5, 2013, 8:04 a.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> ---
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and 
> utilizes the correct tools to create the kdm user and group. This would fix 
> an very old situation where at this moment only debian installations were 
> recognized and properly handled.
> 
> The code follows the coding for debian
> 
> 
> Diffs
> -
> 
>   kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> ---
> 
> Testing has been done on a couple of openSUSE systems and here the user and 
> group were properly created and no more error messages were shown. 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

[Alexander Neundorf]

On Sunday 05 May 2013, Martin Graesslin wrote:
...
> As I already wrote in my last mail to this thread: yes everybody knows your
> opinion of how kdelibs freeze should be handled. Repeating it in every
> single thread which might even be slightly related to the freeze, won't
> change anything. All the arguments you bring up were valid or not two
> years ago and that hasn't change. 

This is not generally true.
Something which may not have been seen as a valid option some time ago may 
become a valid option now or in the future, due to how things develop, what 
experiences people make, etc.

Alex

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110043/#review32055
---


this is kinda getting old ...
just two links to discussions i was involved in:
http://www.mail-archive.com/development@qt-project.org/msg04255.html
http://comments.gmane.org/gmane.comp.kde.devel.core/54679


- Oswald Buddenhagen


On May 5, 2013, 8:13 a.m., Róbert Szókovács wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110043/
> ---
> 
> (Updated May 5, 2013, 8:13 a.m.)
> 
> 
> Review request for kdelibs and Thiago Macieira.
> 
> 
> Description
> ---
> 
> This patch works around the problem of filenames that are not valid UTF8 
> strings:  in KLocalePrivate::initFileNameEncoding() KDE sets the QFile's 
> encoding/decoding function, to to/fromUTF8() in QString, which in turn calls 
> QUtf8's converter function (QUtf8 is not exported to developers, so I had to 
> use an inefficient method, I think it would be better if we could use the 
> state parameter for error detection). I replaced this with the said 
> functions' copy/pasted version and changed it, so when it encounters an 
> invalid UTF8 string, it will encode it byte by byte, mapping the lower 128 
> their normal unicode place and the upper 128 to U+18000-U+1807F, and of 
> course the decoder reverses it. 
> To make this actually work you have to define the KDE_UTF8_FILENAMES 
> enviroment variable to a specific value ("broken_names").
> 
> To test it, do the following: .kde/env/KDE_UTF8_FILENAMES.sh with this 
> content: 
> export KDE_UTF8_FILENAMES=broken_names
> logout, login, try dolphin on faulty files. (instead of the usual boxed "?" 
> you'll see just boxes)
> 
> 
> This addresses bug 165044.
> http://bugs.kde.org/show_bug.cgi?id=165044
> 
> 
> Diffs
> -
> 
>   kdecore/localization/klocale_kde.cpp b010e74 
> 
> Diff: http://git.reviewboard.kde.org/r/110043/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110043/
---

(Updated May 5, 2013, 8:13 a.m.)


Review request for kdelibs and Thiago Macieira.


Changes
---

I very much like the idea of finally making it possible to deal with non-utf8 
files, since this can always happen when plugging in a USB key coming from 
another OS, mounting a network partition, etc.

Ideally this should be handled in Qt rather than in KDE though. But let's see 
what Thiago has to say about either solution, it's his domain...

Triggering this with a special env var is probably too "shy". We probably want 
this to work out of the box without the need for users to change set an env 
var, provided that it doesn't create any regressions (ok, the performance issue 
would be a regression, which is another reason for doing this in Qt directly -- 
only for filenames of course).


Description
---

This patch works around the problem of filenames that are not valid UTF8 
strings:  in KLocalePrivate::initFileNameEncoding() KDE sets the QFile's 
encoding/decoding function, to to/fromUTF8() in QString, which in turn calls 
QUtf8's converter function (QUtf8 is not exported to developers, so I had to 
use an inefficient method, I think it would be better if we could use the state 
parameter for error detection). I replaced this with the said functions' 
copy/pasted version and changed it, so when it encounters an invalid UTF8 
string, it will encode it byte by byte, mapping the lower 128 their normal 
unicode place and the upper 128 to U+18000-U+1807F, and of course the decoder 
reverses it. 
To make this actually work you have to define the KDE_UTF8_FILENAMES enviroment 
variable to a specific value ("broken_names").

To test it, do the following: .kde/env/KDE_UTF8_FILENAMES.sh with this content: 
export KDE_UTF8_FILENAMES=broken_names
logout, login, try dolphin on faulty files. (instead of the usual boxed "?" 
you'll see just boxes)


This addresses bug 165044.
http://bugs.kde.org/show_bug.cgi?id=165044


Diffs
-

  kdecore/localization/klocale_kde.cpp b010e74 

Diff: http://git.reviewboard.kde.org/r/110043/diff/


Testing
---


Thanks,

Róbert Szókovács

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

[Raymond Wooninck]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/
---

(Updated May 5, 2013, 8:04 a.m.)


Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.


Changes
---

Get ride of some whitespaces at the end of the line


Description
---

This patch allows for the recognition of an openSUSE/SUSE installation and 
utilizes the correct tools to create the kdm user and group. This would fix an 
very old situation where at this moment only debian installations were 
recognized and properly handled.

The code follows the coding for debian


Diffs (updated)
-

  kdm/kfrontend/genkdmconf.c 69b42f1 

Diff: http://git.reviewboard.kde.org/r/110315/diff/


Testing
---

Testing has been done on a couple of openSUSE systems and here the user and 
group were properly created and no more error messages were shown. 


Thanks,

Raymond Wooninck

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

[Martin Graesslin]

On Saturday 04 May 2013 22:34:04 Kevin Kofler wrote:
> On Friday 03 May 2013 at 17:04:44, Matthias Klumpp wrote:
> > @Kevin: I am only remotely following this issue, but as PackageKit
> > developer, I would of course like to see our project in Plasma
> > Workspaces as soon as possible. But I don't know the exact issues
> > here. Also, having KSecrets merged would be a nice goal too. (The
> > SecretService API is very stable, and has the potential to become a
> > new de-facto XDG standard soon)
> 
> The issues are the same in both cases: They're kdelibs features and kdelibs
> does not accept any features. By the time the first release of the Plasma
> Workspaces based on KF5 is planned, kdelibs will have been feature-frozen
> for THREE YEARS!!! (And I'm not even speaking of applications there!)
@Kevin: a small tip. People might consider your arguments as valid if you 
would calm down a little bit in your writing. I cannot consider arguments of 
people as serious if they scream, neither in spoken communication nor in 
written communication.

As I already wrote in my last mail to this thread: yes everybody knows your 
opinion of how kdelibs freeze should be handled. Repeating it in every single 
thread which might even be slightly related to the freeze, won't change 
anything. All the arguments you bring up were valid or not two years ago and 
that hasn't change. Don't expect that people just change their mind because 
Kevin just pointed out that it will be a freeze of three years in the end.

It would be really awesome if you could switch your passion on that topic in 
constructive work and help making kde-framworks rock so that the freeze is not 
that long. I don't see why one wouldn't want to start integrating new features 
right now.

Cheers
Martin