date:20151004

I am currently blocked for releasing KF 5.15 because I think these bugfixes
should be in, and they need review:

https://git.reviewboard.kde.org/r/125497/
("KSycoca: spot dirs from the future, and `touch` them to avoid constant 
ksycoca rebuilds")

https://git.reviewboard.kde.org/r/125504/
("KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock")

Is there any other showstopper I should be waiting for, BTW?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125504/
---

(Updated Oct. 4, 2015, 9:40 a.m.)


Review request for KDE Frameworks and Milian Wolff.


Summary (updated)
-

KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock


Bugs: 353360
https://bugs.kde.org/show_bug.cgi?id=353360


Repository: kservice


Description
---

This led to a deadlock in some cases (although I didn't manage to write
a unittest that triggers it). Still, adding the unittest I wrote, it's
always good to have more.

BUG: 353360


Diffs
-

  autotests/kservicetest.h 62dcbae98b250fc89cff316efb065b4b86c0f0f5 
  autotests/kservicetest.cpp 87cfe6fb73dbec11561e906582920aa7d70a6f6e 
  src/services/kservicetypeprofile.cpp b920e303e8ffdfb7df447e628ab45348f2950c2f 

Diff: https://git.reviewboard.kde.org/r/125504/diff/


Testing
---

ctest .

(I looked at the git log for when that line was added, Waldo Bastian added it 
with a comment about something only slightly related, "Call 
KServiceTypeProfile::clear() when ksycoca gets reset.")


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/
---

(Updated Oct. 4, 2015, 12:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
---

Submitted with commit bfe6f2fc9fc093723af065fbb1bf734148f0c1c2 by David Faure 
to branch master.


Repository: kcoreaddons


Description
---

BUG: 345140
REVIEW: 125517


Diffs
-

  autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
  src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 

Diff: https://git.reviewboard.kde.org/r/125517/diff/


Testing
---

unittest; clicking on a file with unicode space in dolphin now works.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reviews needed for KF 5.15

2015-10-04 Thread Bhushan Shah

On Sun, Oct 4, 2015 at 3:11 PM, David Faure  wrote:
> https://git.reviewboard.kde.org/r/125497/
> ("KSycoca: spot dirs from the future, and `touch` them to avoid constant 
> ksycoca rebuilds")

I will need bit of help from our packagers to package it.. Once this
is packaged I can test it. I tried to manually cross build but I
screwed something else.. and I failed to build it. Sorry for delay.

IMO patch itself looks quite sensible..

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000



> On Oct. 4, 2015, 11:25 a.m., David Faure wrote:
> > Albert, in review 122300 (commit b746dcf93239e93eafeedfaeff53e1ac387f5ca1 
> > in kcoreaddons), you mentionned that commit was a workaround, I think this 
> > is the real fix for it?

Actually, it seems so. I can remove the "hack" from that commit and all 
unittests still pass. Will amend.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/#review86325
---


On Oct. 4, 2015, 11:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125517/
> ---
> 
> (Updated Oct. 4, 2015, 11:24 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> BUG: 345140
> 
> 
> Diffs
> -
> 
>   autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
>   src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 
> 
> Diff: https://git.reviewboard.kde.org/r/125517/diff/
> 
> 
> Testing
> ---
> 
> unittest; clicking on a file with unicode space in dolphin now works.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/
---

(Updated Oct. 4, 2015, 11:28 a.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Repository: kcoreaddons


Description (updated)
---

BUG: 345140
REVIEW: 125517


Diffs (updated)
-

  autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
  src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 

Diff: https://git.reviewboard.kde.org/r/125517/diff/


Testing
---

unittest; clicking on a file with unicode space in dolphin now works.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/#review86325
---


Albert, in review 122300 (commit b746dcf93239e93eafeedfaeff53e1ac387f5ca1 in 
kcoreaddons), you mentionned that commit was a workaround, I think this is the 
real fix for it?

- David Faure


On Oct. 4, 2015, 11:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125517/
> ---
> 
> (Updated Oct. 4, 2015, 11:24 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> BUG: 345140
> 
> 
> Diffs
> -
> 
>   autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
>   src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 
> 
> Diff: https://git.reviewboard.kde.org/r/125517/diff/
> 
> 
> Testing
> ---
> 
> unittest; clicking on a file with unicode space in dolphin now works.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125514: Add a web shortcut manager

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125514/#review86327
---

Seems useful to have, I've seen such actions in multiple places, including 
KHTML and KWebkit (and I know you're coming from kdepim with this).

I'm wondering if the naming couldn't be improved though. This has very little 
to do with "shortcuts", it only shares the search provider definitions. I'm 
thinking of KIO::SearchProviderActions, in line with KFileItemActions and 
KDesktopFileActions.

(or maybe KUriFilterSearchProviderActions, since KUriFilterSearchProvider 
exists? Although that class is for the plugins, so apps don't really know about 
it).
I suggest to wait for more input before renaming, let's see what others think.

autotests/webshortcutmenumanagertest.cpp (line 31)

ctor and dtor are not useful for test objects
(if any code needs to be added, initTestCase/cleanupTestCase is better 
anyway)

=> better let the compiler generate the automatic ctor and dtor.

autotests/webshortcutmenumanagertest.cpp (line 62)

no way to be more specific about what we expect to see?

If it's all plugins then indeed it's difficult.

src/widgets/CMakeLists.txt (line 141)

Shouldn't this be installed as KIO/WebShortcutsMenuManager, to match the 
classname? In that case, it should be moved to the next list of headers, those 
that end up under KIO/

src/widgets/webshortcutsmenumanager.h (line 31)

s/add/set the/   (adding usually means you can call it multiple times, to 
add more data)

src/widgets/webshortcutsmenumanager.h (line 40)

The class docu should be just above this line,
and should have @since 5.16

src/widgets/webshortcutsmenumanager.h (line 59)

@param selectedText the text to search for

src/widgets/webshortcutsmenumanager.h (line 64)

s/WebShortCut action/web shortcut actions/

src/widgets/webshortcutsmenumanager.cpp (line 96)

Better declare the var inside the loop (and further down where used), to be 
more C++ and less C.

src/widgets/webshortcutsmenumanager.cpp (line 109)

if (!QStandardPaths::findExecutable("kcmshell5").isEmpty()) {

just in case.

- David Faure

On Oct. 4, 2015, 5:44 a.m., Laurent Montel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125514/
> ---
> 
> (Updated Oct. 4, 2015, 5:44 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> When we select text we can provide a search from internet.
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/webshortcutsmenumanager.h PRE-CREATION 
>   autotests/webshortcutmenumanagertest.cpp PRE-CREATION 
>   src/widgets/webshortcutsmenumanager.cpp PRE-CREATION 
>   autotests/CMakeLists.txt 989acd4 
>   autotests/webshortcutmenumanagertest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125514/diff/
> 
> 
> Testing
> ---
> 
> Tested from long time in kdepim.
> I added autotests for it.
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/#review86331
---

Ship it!


Ship It!

- Albert Astals Cid


On oct. 4, 2015, 7:58 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125497/
> ---
> 
> (Updated oct. 4, 2015, 7:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
> 
> 
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id=353036
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> BUG: 353036
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
>   src/sycoca/ksycoca.cpp d5abcc4e4d241378a83f158aa6201034433ff792 
> 
> Diff: https://git.reviewboard.kde.org/r/125497/diff/
> 
> 
> Testing
> ---
> 
> unit test (failed before patch, works with it).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

2015-10-04 Thread Bhushan Shah



> On Oct. 4, 2015, 6:01 p.m., Albert Astals Cid wrote:
> > Ship It!

Actually this patch doesn't fix teh issue. (See bug report)


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/#review86331
---


On Oct. 4, 2015, 1:28 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125497/
> ---
> 
> (Updated Oct. 4, 2015, 1:28 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
> 
> 
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id=353036
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> BUG: 353036
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
>   src/sycoca/ksycoca.cpp d5abcc4e4d241378a83f158aa6201034433ff792 
> 
> Diff: https://git.reviewboard.kde.org/r/125497/diff/
> 
> 
> Testing
> ---
> 
> unit test (failed before patch, works with it).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/#review86333
---

Ship it!


Ship It!

- Albert Astals Cid


On oct. 4, 2015, 11:28 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125517/
> ---
> 
> (Updated oct. 4, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> BUG: 345140
> REVIEW: 125517
> 
> 
> Diffs
> -
> 
>   autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
>   src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 
> 
> Diff: https://git.reviewboard.kde.org/r/125517/diff/
> 
> 
> Testing
> ---
> 
> unittest; clicking on a file with unicode space in dolphin now works.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.



> On Oct. 4, 2015, 10:30 a.m., Albert Astals Cid wrote:
> > Can we have a test for this? Or is it hard to re-create the conditions 
> > artificially?

I don't understand your question. This RR includes an autotest.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/#review86322
---


On Oct. 4, 2015, 7:58 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125497/
> ---
> 
> (Updated Oct. 4, 2015, 7:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
> 
> 
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id=353036
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> BUG: 353036
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
>   src/sycoca/ksycoca.cpp d5abcc4e4d241378a83f158aa6201034433ff792 
> 
> Diff: https://git.reviewboard.kde.org/r/125497/diff/
> 
> 
> Testing
> ---
> 
> unit test (failed before patch, works with it).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125511: Add missing documentation for argument to LAUNCHER_EXEC_NEW

2015-10-04 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125511/#review86317
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 3, 2015, 8:25 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125511/
> ---
> 
> (Updated Oct. 3, 2015, 8:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Code already exists was just missing the docs for this argument
> 
> 
> Diffs
> -
> 
>   src/klauncher_cmds.h 35e0d9f352d459b724452758ac3d564d73cd4472 
> 
> Diff: https://git.reviewboard.kde.org/r/125511/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/#review86322
---


Can we have a test for this? Or is it hard to re-create the conditions 
artificially?

- Albert Astals Cid


On oct. 4, 2015, 7:58 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125497/
> ---
> 
> (Updated oct. 4, 2015, 7:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
> 
> 
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id=353036
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> BUG: 353036
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
>   src/sycoca/ksycoca.cpp d5abcc4e4d241378a83f158aa6201034433ff792 
> 
> Diff: https://git.reviewboard.kde.org/r/125497/diff/
> 
> 
> Testing
> ---
> 
> unit test (failed before patch, works with it).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125517/
---

Review request for KDE Frameworks and Albert Astals Cid.


Repository: kcoreaddons


Description
---

BUG: 345140


Diffs
-

  autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa 
  src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 

Diff: https://git.reviewboard.kde.org/r/125517/diff/


Testing
---

unittest; clicking on a file with unicode space in dolphin now works.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125515: Preserve relative link targets when copying symlinks.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/
---

Review request for KDE Frameworks.


Bugs: 352927
https://bugs.kde.org/show_bug.cgi?id=352927


Repository: kio


Description
---

BUG: 352927
Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572


Diffs
-

  autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
  src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
  autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 

Diff: https://git.reviewboard.kde.org/r/125515/diff/


Testing
---

2 unit tests added


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock

2015-10-04 Thread Milian Wolff


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125504/#review86320
---

Ship it!


if the tests still pass, I'd say go for it. I'll notify you when I can 
reproduce this after this gets merged.

- Milian Wolff


On Oct. 4, 2015, 9:40 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125504/
> ---
> 
> (Updated Oct. 4, 2015, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Milian Wolff.
> 
> 
> Bugs: 353360
> https://bugs.kde.org/show_bug.cgi?id=353360
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This led to a deadlock in some cases (although I didn't manage to write
> a unittest that triggers it). Still, adding the unittest I wrote, it's
> always good to have more.
> 
> BUG: 353360
> 
> 
> Diffs
> -
> 
>   autotests/kservicetest.h 62dcbae98b250fc89cff316efb065b4b86c0f0f5 
>   autotests/kservicetest.cpp 87cfe6fb73dbec11561e906582920aa7d70a6f6e 
>   src/services/kservicetypeprofile.cpp 
> b920e303e8ffdfb7df447e628ab45348f2950c2f 
> 
> Diff: https://git.reviewboard.kde.org/r/125504/diff/
> 
> 
> Testing
> ---
> 
> ctest .
> 
> (I looked at the git log for when that line was added, Waldo Bastian added it 
> with a comment about something only slightly related, "Call 
> KServiceTypeProfile::clear() when ksycoca gets reset.")
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 108 - Fixed!

2015-10-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/108/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Oct 2015 09:38:49 +
Build duration: 4 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 
46 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 24012/49631 
(48%)CONDITIONAL 12980/20078 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6896/7136 
(97%)CONDITIONAL 3761/6917 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7269/13911 
(52%)CONDITIONAL 3780/5271 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1884/7566 
(25%)CONDITIONAL 722/1117 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 424/837 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1147 (60%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 389/600 (65%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 278/283 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2584/10547 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 108 - Fixed!

2015-10-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/108/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Oct 2015 09:38:49 +
Build duration: 4 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 
46 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 24012/49631 
(48%)CONDITIONAL 12980/20078 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6896/7136 
(97%)CONDITIONAL 3761/6917 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7269/13911 
(52%)CONDITIONAL 3780/5271 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1884/7566 
(25%)CONDITIONAL 722/1117 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 424/837 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1147 (60%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 389/600 (65%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 278/283 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2584/10547 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125504/
---

(Updated Oct. 4, 2015, 10:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Milian Wolff.


Changes
---

Submitted with commit 94ae1a54991212d30b95f690e4086d9a7aec07c8 by David Faure 
to branch master.


Bugs: 353360
https://bugs.kde.org/show_bug.cgi?id=353360


Repository: kservice


Description
---

This led to a deadlock in some cases (although I didn't manage to write
a unittest that triggers it). Still, adding the unittest I wrote, it's
always good to have more.

BUG: 353360


Diffs
-

  autotests/kservicetest.h 62dcbae98b250fc89cff316efb065b4b86c0f0f5 
  autotests/kservicetest.cpp 87cfe6fb73dbec11561e906582920aa7d70a6f6e 
  src/services/kservicetypeprofile.cpp b920e303e8ffdfb7df447e628ab45348f2950c2f 

Diff: https://git.reviewboard.kde.org/r/125504/diff/


Testing
---

ctest .

(I looked at the git log for when that line was added, Waldo Bastian added it 
with a comment about something only slightly related, "Call 
KServiceTypeProfile::clear() when ksycoca gets reset.")


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.



> On oct. 4, 2015, 10:30 a.m., Albert Astals Cid wrote:
> > Can we have a test for this? Or is it hard to re-create the conditions 
> > artificially?
> 
> David Faure wrote:
> I don't understand your question. This RR includes an autotest.

you're right, sorry i didn't pay enough attention.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/#review86322
---


On oct. 4, 2015, 7:58 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125497/
> ---
> 
> (Updated oct. 4, 2015, 7:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
> 
> 
> Bugs: 353036
> https://bugs.kde.org/show_bug.cgi?id=353036
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> BUG: 353036
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
>   src/sycoca/ksycoca.cpp d5abcc4e4d241378a83f158aa6201034433ff792 
> 
> Diff: https://git.reviewboard.kde.org/r/125497/diff/
> 
> 
> Testing
> ---
> 
> unit test (failed before patch, works with it).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel



> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > Seems useful to have, I've seen such actions in multiple places, including 
> > KHTML and KWebkit (and I know you're coming from kdepim with this).
> > 
> > I'm wondering if the naming couldn't be improved though. This has very 
> > little to do with "shortcuts", it only shares the search provider 
> > definitions. I'm thinking of KIO::SearchProviderActions, in line with 
> > KFileItemActions and KDesktopFileActions.
> > 
> > (or maybe KUriFilterSearchProviderActions, since KUriFilterSearchProvider 
> > exists? Although that class is for the plugins, so apps don't really know 
> > about it).
> > I suggest to wait for more input before renaming, let's see what others 
> > think.

Ok I wait but KUriFilterSearchProviderActions seems good as name


> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > autotests/webshortcutmenumanagertest.cpp, line 62
> > 
> >
> > no way to be more specific about what we expect to see?
> > 
> > If it's all plugins then indeed it's difficult.

It's specific about config. so we can't be sure that we have specific plugin.
So I verify just that menu is not empty => it generates a correct menu.


> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > src/widgets/CMakeLists.txt, line 141
> > 
> >
> > Shouldn't this be installed as KIO/WebShortcutsMenuManager, to match 
> > the classname? In that case, it should be moved to the next list of 
> > headers, those that end up under KIO/

indeed I will fix it.


- Laurent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125514/#review86327
---


On oct. 4, 2015, 5:44 matin, Laurent Montel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125514/
> ---
> 
> (Updated oct. 4, 2015, 5:44 matin)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> When we select text we can provide a search from internet.
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/webshortcutsmenumanager.h PRE-CREATION 
>   autotests/webshortcutmenumanagertest.cpp PRE-CREATION 
>   src/widgets/webshortcutsmenumanager.cpp PRE-CREATION 
>   autotests/CMakeLists.txt 989acd4 
>   autotests/webshortcutmenumanagertest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125514/diff/
> 
> 
> Testing
> ---
> 
> Tested from long time in kdepim.
> I added autotests for it.
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125514/
---

(Updated oct. 4, 2015, 2:04 après-midi)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

When we select text we can provide a search from internet.


Diffs (updated)
-

  autotests/CMakeLists.txt 989acd4 
  autotests/webshortcutmenumanagertest.h PRE-CREATION 
  autotests/webshortcutmenumanagertest.cpp PRE-CREATION 
  src/widgets/CMakeLists.txt 820cd34 
  src/widgets/webshortcutsmenumanager.h PRE-CREATION 
  src/widgets/webshortcutsmenumanager.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125514/diff/


Testing
---

Tested from long time in kdepim.
I added autotests for it.


Thanks,

Laurent Montel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-04 Thread Frank Reininghaus


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review86340
---


Looks good! The only thing that I'm not sure about is whether 1000 bytes are 
guaranteed to be enough. Some quick Googling tells me that path lengths of 4096 
are possible. Maybe we could allocate a temporary large array on the heap if 
the readlink call fails with the 1000 byte buffer on the stack?

- Frank Reininghaus


On Okt. 4, 2015, 9:24 vorm., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> ---
> 
> (Updated Okt. 4, 2015, 9:24 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 352927
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
>   src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
>   autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
> 
> 
> Testing
> ---
> 
> 2 unit tests added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125334: Small improvements in ColumnProxyModel

2015-10-04 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/
---

(Updated Oct. 4, 2015, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit c0b8ee043e8fbf1edd7b4e3223dedb00960f2e0a by Aleix Pol to 
branch master.


Repository: kdeclarative


Description
---

* Add a check for a property set so that it doesn't re-compute if the new value 
is the same as the former.
* Implement ::setData to the source model.


Diffs
-

  autotests/columnproxymodeltest.h 46b8d40 
  autotests/columnproxymodeltest.cpp 8844651 
  src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
  src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 

Diff: https://git.reviewboard.kde.org/r/125334/diff/


Testing
---

added test, does what I need it to do on muon.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125334: Small improvements in ColumnProxyModel

2015-10-04 Thread Mark Gaiser


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/#review86337
---


+1


src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp (lines 118 - 119)


Always use curly braces. (kde coding style)


- Mark Gaiser


On sep 21, 2015, 4:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125334/
> ---
> 
> (Updated sep 21, 2015, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> * Add a check for a property set so that it doesn't re-compute if the new 
> value is the same as the former.
> * Implement ::setData to the source model.
> 
> 
> Diffs
> -
> 
>   autotests/columnproxymodeltest.h 46b8d40 
>   autotests/columnproxymodeltest.cpp 8844651 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 
> 
> Diff: https://git.reviewboard.kde.org/r/125334/diff/
> 
> 
> Testing
> ---
> 
> added test, does what I need it to do on muon.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125334: Small improvements in ColumnProxyModel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/#review86338
---

Ship it!


Ship It!

- David Edmundson


On Sept. 21, 2015, 4:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125334/
> ---
> 
> (Updated Sept. 21, 2015, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> * Add a check for a property set so that it doesn't re-compute if the new 
> value is the same as the former.
> * Implement ::setData to the source model.
> 
> 
> Diffs
> -
> 
>   autotests/columnproxymodeltest.h 46b8d40 
>   autotests/columnproxymodeltest.cpp 8844651 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 
> 
> Diff: https://git.reviewboard.kde.org/r/125334/diff/
> 
> 
> Testing
> ---
> 
> added test, does what I need it to do on muon.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125515: Preserve relative link targets when copying symlinks.



> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote:
> > Looks good! The only thing that I'm not sure about is whether 1000 bytes 
> > are guaranteed to be enough. Some quick Googling tells me that path lengths 
> > of 4096 are possible. Maybe we could allocate a temporary large array on 
> > the heap if the readlink call fails with the 1000 byte buffer on the stack?
> 
> Xuetian Weng wrote:
> Just FYI, even PATH_MAX may not exists on some system (AFAIK, hurd, 
> allowed by posix).
> And though st.st_size is mentioned in readlink man page, it may not 
> return useful value.
> 
> 
> More information 
> http://stackoverflow.com/questions/9385386/howto-use-readlink-with-dynamic-memory-allocation
> 
> David Faure wrote:
> Just for info, I basically restored this code from kdelibs4 :)
> But of course I could have a missed a bug report about someone with a 
> huge symlink target.
> 
> Checking what Qt does... ah, PATH_MAX if defined, otherwise a loop which 
> reallocs twice more every time (starting from 256 bytes).
> Personally I'm tempted to just make it 4096, "it ought to be enough for 
> everybody" as the saying goes :-)
> 
> Xuetian Weng wrote:
> So.. is it possible to directly use Qt API there? Why bother handle it 
> ourselves :) ?

I explain that in the comments in the patch: because Qt resolves relative 
symlink targets to absolute ones, which is exactly what triggered this bug in 
the first place.

I think it makes sense for Qt to do so; the 99% use case for symlinks is to 
read the target file (or dir). In our case however, to copy a symlink, we do 
care whether it's relative or absolute.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review86340
---


On Oct. 4, 2015, 9:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> ---
> 
> (Updated Oct. 4, 2015, 9:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 352927
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
>   src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
>   autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
> 
> 
> Testing
> ---
> 
> 2 unit tests added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-10-04 Thread Frank Reininghaus



> On Okt. 3, 2015, 8:08 vorm., David Faure wrote:
> > I just realized another problem with this approach: since the latest 
> > libkonq release installs konqpopupmenuplugin.desktop already, this patch 
> > will make the next KIO release conflict with that last libkonq release 
> > (which by definition cannot have a version check). Moving stuff between 
> > products is hard!
> > 
> > So you were right, better install this under a different filename like in 
> > your v1 of the patch (just doublecheck that having two definitions of the 
> > same servicetype in two different files doesn't break things, but I don't 
> > think it does). And in the second step (later) we can reuse that filename 
> > to provide a different servicetypename and deprecate KonqPopupMenuPlugin.
> > Sorry for not realizing this sooner.
> > 
> > In any case, due to the issue with translations we wanted to commit this 
> > after today's release (but of course this delays the fix by one month).
> > Unless Luigi is available this weekend to do the merging, but it's getting 
> > tight.
> 
> Luigi Toscano wrote:
> I would say that it's better to postpone for the next release (merge 
> immediately after the tag), so there is a bit more time to catch issues and 
> it's not risky for this release (too tight now, exactly).
> 
> Hrvoje Senjan wrote:
> > since the latest libkonq release installs konqpopupmenuplugin.desktop 
> already
> 
> But that release is kdelibs4 based, so there shouldn't be any conflict 
> here...
> 
> David Faure wrote:
> Oh, is there really no release that installs konqpopupmenuplugin.desktop 
> into servicestypes5? I thought people said otherwise in bug reports, but I 
> didn't fully follow that (and looking again now I indeed don't see that 
> clearly said).
> 
> If this was never released it's easier indeed, this patch can go in 
> (after the release) then.

Yes, there is currently no KF5-based release of anything that installs this 
file. Service menus might work for some users though if distros package 
lib/konq (which is ported to KF5, but not released).

I'll push this and the commit for the "Create New" menu issue tomorrow if there 
are no objections. Maybe I'll also send a mail to the kde-packager list, such 
that the packagers can decide if they want to backport them. This would prevent 
that users will have to wait until November (or even longer, if distros do not 
update the KF5 libs regularly) until they get a functional context menu again.


- Frank


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125425/#review86276
---


On Okt. 3, 2015, 7:50 vorm., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125425/
> ---
> 
> (Updated Okt. 3, 2015, 7:50 vorm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 350769
> https://bugs.kde.org/show_bug.cgi?id=350769
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This is a modified version of the file konqpopupmenuplugin.desktop in 
> kde-baseapps (see 
> https://quickgit.kde.org/?p=kde-baseapps.git=blob=94a680ac215b4638a0c7cdd2b20bc7830b9619f2=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop
>  for the latest version).
> 
> I modified the name to kioservicemenuplugin.desktop because the file has not 
> been Konqueror-specific for quite some time. I also updated the 'Comment' 
> accordingly and removed the outdated translations.
> 
> I hope I did that right - any comments are welcome!
> 
> Note: Just like https://git.reviewboard.kde.org/r/124983/ this should 
> probably be pushed to master after the tagging for the next version because 
> of the translations. On the one hand, the translation of this 'Comment' might 
> not be that important because the it is not shown anywhere in the UI as far 
> as I know (it is shown in the 'Type' column in Dolphin though when viewing 
> the directory where this file is installed). But on the other hand, it might 
> be better to resolve both context menu issues in the same KIO release. What 
> do others think?
> 
> 
> Diffs
> -
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/konqpopupmenuplugin.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125425/diff/
> 
> 
> Testing
> ---
> 
> Konsole service actions are shown in the context menu again.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-04 Thread Xuetian Weng



> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote:
> > Looks good! The only thing that I'm not sure about is whether 1000 bytes 
> > are guaranteed to be enough. Some quick Googling tells me that path lengths 
> > of 4096 are possible. Maybe we could allocate a temporary large array on 
> > the heap if the readlink call fails with the 1000 byte buffer on the stack?

Just FYI, even PATH_MAX may not exists on some system (AFAIK, hurd, allowed by 
posix).
And though st.st_size is mentioned in readlink man page, it may not return 
useful value.


More information 
http://stackoverflow.com/questions/9385386/howto-use-readlink-with-dynamic-memory-allocation


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review86340
---


On Oct. 4, 2015, 9:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> ---
> 
> (Updated Oct. 4, 2015, 9:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 352927
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
>   src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
>   autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
> 
> 
> Testing
> ---
> 
> 2 unit tests added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-04 Thread Xuetian Weng



> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote:
> > Looks good! The only thing that I'm not sure about is whether 1000 bytes 
> > are guaranteed to be enough. Some quick Googling tells me that path lengths 
> > of 4096 are possible. Maybe we could allocate a temporary large array on 
> > the heap if the readlink call fails with the 1000 byte buffer on the stack?
> 
> Xuetian Weng wrote:
> Just FYI, even PATH_MAX may not exists on some system (AFAIK, hurd, 
> allowed by posix).
> And though st.st_size is mentioned in readlink man page, it may not 
> return useful value.
> 
> 
> More information 
> http://stackoverflow.com/questions/9385386/howto-use-readlink-with-dynamic-memory-allocation
> 
> David Faure wrote:
> Just for info, I basically restored this code from kdelibs4 :)
> But of course I could have a missed a bug report about someone with a 
> huge symlink target.
> 
> Checking what Qt does... ah, PATH_MAX if defined, otherwise a loop which 
> reallocs twice more every time (starting from 256 bytes).
> Personally I'm tempted to just make it 4096, "it ought to be enough for 
> everybody" as the saying goes :-)

So.. is it possible to directly use Qt API there? Why bother handle it 
ourselves :) ?


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review86340
---


On Oct. 4, 2015, 9:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> ---
> 
> (Updated Oct. 4, 2015, 9:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 352927
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
>   src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
>   autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
> 
> 
> Testing
> ---
> 
> 2 unit tests added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/
---

Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
---

Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
from GPL 2+ to LGPL 2+ with author's permission.


Diffs
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kdropwidgetdecorator.h PRE-CREATION 
  src/kdropwidgetdecorator.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125521/diff/


Testing
---

It builds, the headers I expect are in the right places, etc. I just noticed 
I'm not exporting the class though, will fix that and reupload.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/
---

(Updated Oct. 4, 2015, 1:43 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Added exporting the class.


Repository: kwidgetsaddons


Description
---

Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
from GPL 2+ to LGPL 2+ with author's permission.


Diffs (updated)
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kdropwidgetdecorator.h PRE-CREATION 
  src/kdropwidgetdecorator.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125521/diff/


Testing
---

It builds, the headers I expect are in the right places, etc. I just noticed 
I'm not exporting the class though, will fix that and reupload.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox



> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> >

Thanks


> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> > tests/kcollapsiblegroupboxtest.cpp, line 35
> > 
> >
> > just curious: why?

We don't know which apps will enable it, so it's best to test every widget as 
though some app might.

This widget doesn't use pixmaps, so it's pretty pointless for now, but it might 
in future and I want setting this to be a standard thing in all qwidget 
graphical tests.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86315
---


On Oct. 3, 2015, 1:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 3, 2015, 1:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125515: Preserve relative link targets when copying symlinks.



> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote:
> > Looks good! The only thing that I'm not sure about is whether 1000 bytes 
> > are guaranteed to be enough. Some quick Googling tells me that path lengths 
> > of 4096 are possible. Maybe we could allocate a temporary large array on 
> > the heap if the readlink call fails with the 1000 byte buffer on the stack?
> 
> Xuetian Weng wrote:
> Just FYI, even PATH_MAX may not exists on some system (AFAIK, hurd, 
> allowed by posix).
> And though st.st_size is mentioned in readlink man page, it may not 
> return useful value.
> 
> 
> More information 
> http://stackoverflow.com/questions/9385386/howto-use-readlink-with-dynamic-memory-allocation

Just for info, I basically restored this code from kdelibs4 :)
But of course I could have a missed a bug report about someone with a huge 
symlink target.

Checking what Qt does... ah, PATH_MAX if defined, otherwise a loop which 
reallocs twice more every time (starting from 256 bytes).
Personally I'm tempted to just make it 4096, "it ought to be enough for 
everybody" as the saying goes :-)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review86340
---


On Oct. 4, 2015, 9:24 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> ---
> 
> (Updated Oct. 4, 2015, 9:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 352927
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e 
>   src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 
>   autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
> 
> 
> Testing
> ---
> 
> 2 unit tests added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review86352
---



src/kdropwidgetdecorator.h (line 37)


This isn't really a decorator pattern. It's just a widget.

A decorator would probably take a QTabBar as an argument and then create 
and show this widget as needed depending on how many tabs that tabbar had.



src/kdropwidgetdecorator.cpp (line 41)


if nothing is connected, or it's a queuedconnection then b is uninitialised.

For what this is trying to do, a function pointer might work better.


- David Edmundson


On Oct. 4, 2015, 7:43 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125521/
> ---
> 
> (Updated Oct. 4, 2015, 7:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed 
> from GPL 2+ to LGPL 2+ with author's permission.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kdropwidgetdecorator.h PRE-CREATION 
>   src/kdropwidgetdecorator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125521/diff/
> 
> 
> Testing
> ---
> 
> It builds, the headers I expect are in the right places, etc. I just noticed 
> I'm not exporting the class though, will fix that and reupload.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/
---

(Updated Oct. 4, 2015, 6:42 p.m.)


Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.


Changes
---

Reworked to avoid trying to utime() on system dirs, which failed due to no 
permissions.


Summary (updated)
-

KSycoca: store mtime for every source dir, to detect changes.


Bugs: 353036
https://bugs.kde.org/show_bug.cgi?id=353036


Repository: kservice


Description (updated)
---

The old solution was to compare the mtime of the source dirs with
a stored timestamp of "just before listing them". However this assumes
that time always moves forward, and some people have a phone that also acts
as a time machine (a limited one, with a single possible "destination", 
01/01/1970).

Well, this new solution should also avoid problems with DST making time
go back 1h once a year; or problems when changing timezones (although we
could also just use UTC everywhere for these issues).

BUG: 353036
REVIEW: 125497


Diffs (updated)
-

  autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba 
  src/sycoca/kbuildsycoca.cpp 924c55724ffeabace492b37ee3f1658a1efcee39 
  src/sycoca/kbuildsycoca_p.h b3a86ecc4f611219132af2ec10a8f052e27c2d4b 
  src/sycoca/ksycoca.cpp cc721eaf4ae42d65dccaf71eeb21211696be130c 
  src/sycoca/ksycoca_p.h 314aaa91d9a07896cb3cef13bdb849d5c7e359ea 

Diff: https://git.reviewboard.kde.org/r/125497/diff/


Testing
---

unit test (failed before patch, works with it).


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KTabWidget vs QTabWidget

2015-10-04 Thread Jeremy Whiting

Thanks,

First patch here: https://git.reviewboard.kde.org/r/125521/. After
that I'll try using it in Kile and Okular, see how that goes.

On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig  wrote:
>
> On 09/25/2015 01:57 AM, Jeremy Whiting wrote:
>>
>> Michel,
>>
>> Would you mind if I move the DropWidget you wrote for kile into
>> kwidgetsaddons and give it a name like KDropWidget and relicense it to
>> LGPL v2+ ?
>>
> That's totally fine with me.
>
> Michel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 4, 2015, 8:37 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138
src/kcollapsiblegroupbox.h PRE-CREATION
src/kcollapsiblegroupbox.cpp PRE-CREATION
tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af
tests/kcollapsiblegroupboxtest.cpp PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.