KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/41/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 25 Mar 2019 04:54:20 +
 Build duration:
45 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13362)18%
(1814/9846)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/24/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 25 Mar 2019 04:54:24 +
 Build duration:
27 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.57.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(456/2236)18%
(203/1134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)60%
(64/106)src100%
(8/8)100%
(8/8)68%
(222/327)50%
(105/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/8)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/49/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 25 Mar 2019 04:54:19 +
 Build duration:
9 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13362)18%
(1814/9846)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D20034: Pass focus to child searchbar when KPluginSelector is focused

[Nathaniel Graham]

ngraham added reviewers: Plasma, Frameworks.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D20034

To: jayeshbhoot, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20034: Pass focus to child searchbar when KPluginSelector is focused

[Jayesh Bhoot]

jayeshbhoot created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jayeshbhoot requested review of this revision.

REVISION SUMMARY
  This commit is a precursor to autofocusing on searchbar in
  plasmasearch kcm module.
  BUG: 399516

REPOSITORY
  R295 KCMUtils

BRANCH
  fix/focus-searchbar-in-plasmasearch-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20034

AFFECTED FILES
  src/kpluginselector.cpp

To: jayeshbhoot
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20032: Convert string formatting tests to be data driven

[Stefan Brüns]

bruns added a dependent revision: D20033: Default string formatting test to C 
locale, add localized run.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20031: Declare PropertyInfo as QMetaType

[Stefan Brüns]

bruns added a dependent revision: D20032: Convert string formatting tests to be 
data driven.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20031

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20033: Default string formatting test to C locale, add localized run

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Using the user locale leads to random test failures, as arbitrary parts
  may have been translated.
  
  For localized debugging of the formatting functions, the test can be
  run with the "--localized" option, using the current user locale. The
  localized version is added to the test suite to increase code coverage,
  but failures are ignored. In verbose mode, the formatted and localized
  strings are shown.
  
  Depends on D20032 

TEST PLAN
  ctest
  ctest -V -R propertyinfo
  LANG=ar ./build/bin/propertyinfotest_bin --localized

REPOSITORY
  R286 KFileMetaData

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D20033

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20032: Convert string formatting tests to be data driven

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Less boilerplate code in the actual test data.
  
  Depends on D20031 

TEST PLAN
  LANG=C ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20032

AFFECTED FILES
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20031: Declare PropertyInfo as QMetaType

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Required for data driven unit tests, probably useful elsewhere.
  
  No functional changes

TEST PLAN
  ctests

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20031

AFFECTED FILES
  src/propertyinfo.cpp
  src/propertyinfo.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#437670 , @arvidhansson 
wrote:
  
  > In D19952#437419 , @ndavis wrote:
  >
  > > This can be done in the system tray widget instead of making a separate 
icon for off. Ever notice how the notifications icon is grey when it's not 
active?
  >
  >
  > Sorry, I don't understand, never had noticed anything special with the 
notifications.
  
  
  Top icon is for notifications (partly transparent), bottom icon is for 
Redshift (100% opacity)
  F6718240: Screenshot_20190324_184101.png 

  
  In D19952#437664 , @arvidhansson 
wrote:
  
  > [...] is it just me or is the transparent icon more like grey?
  
  
  It's not just you, but that's how partly transparent black on a white 
background is supposed to look.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19887: Proposal for KFileItem to skip stat()

[David Faure]

dfaure added a comment.


  OK so I read about the use case in https://phabricator.kde.org/D19784 and it 
confirms my suspicion: the right fix is to do the stat on demand, called from 
those methods that need the information it gathers -- with a boolean to check 
that we only do it once of course.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19887

To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

[David Faure]

dfaure added a comment.


  > If they point to files on a network drive, and the network or the drive is 
not responding
  
  Well that's exactly the problem with network mounts, and the reason they are 
a sucky technical solution.
  KIO's async jobs never have that problem.
  
  You will never be able to remove all uses of synchronous local file APIs in 
all of Qt and KDE-made software -- or IMHO any other large toolkit or 
application.
  
  At best, the kernel should offer better solutions for users to get rid of 
non-responding mounts more easily.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20005: Report human-readable error if Qt5Widgets is required but is not found

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks, apol
Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  OK so this is about KFileItem::text() and KFileItem::iconName().
  
  Indeed this doesn't need the stat() done by KFileItem's init(). This means 
the right solution is indeed for KFileItem to do that stat() on demand, and 
this code doesn't need any changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19930: [kwallets] compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19930

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

[Albert Astals Cid]

aacid added a comment.


  Makes sense to me

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  The added signal seems fine to me. Much less black magic than an event filter 
(which would have been the other option).

INLINE COMMENTS

> kdiroperator.h:916
> +/**
> + * Triggered when the user hit Enter/Return
> + */

Missing @since 5.57

> kfilewidgettest_gui.cpp:30
>  
> -KFileWidget* fileWidget = new 
> KFileWidget(QUrl(QStringLiteral("kfiledialog:///OpenDialog")), nullptr);
> -fileWidget->setMode(KFile::Files | KFile::ExistingOnly);
> +QApplication *ptr_app = 
> +

This bit is what's non-idiomatic, IMHO.

Why not capture app by reference?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19824

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20021: Add support for extracting data from ogg and ts files

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#437419 , @ndavis wrote:
  
  > In D19952#436853 , @arvidhansson 
wrote:
  >
  > > In D19952#436834 , @taskf 
wrote:
  > >
  > > > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  > >
  > >
  > > I agree, it isn't  even an caps-lock-off key. A 50% tranparent icon would 
fit better
  >
  >
  > This can be done in the system tray widget instead of making a separate 
icon for off. Ever notice how the notifications icon is grey when it's not 
active?
  
  
  Sorry, I don't understand, never had noticed anything special with the 
notifications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19876: Fix: apply correctly the text colors of the chosen scheme

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  one minor nit, otherwise looks like a good improvement

INLINE COMMENTS

> katehighlight.cpp:78
> +if (schema == QLatin1String("Normal")) {
> +return QLatin1String("Default");
> +} else if (schema == QLatin1String("Solarized (light)")) {

return QStringLiteral, otherwise you allocate on every function call (also 
below)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, ngraham, bruns, demsking, sars

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#436919 , @taskf wrote:
  
  > Hmm, still I somehow like the stroked version, while I wouldn't recommend 
using it this particular case. Even the transparent version can easily be 
controlled the `disabled` state of this icon object. Currently, I think it 
would be good to add both icons to Breeze iconset, just in case there is 
another use case for it some day. I added all the other mockups I did just to 
let you know.
  >  F6716206: image.png 
  
  
  Yes, both icon may be the best alternative, is it just me or is the 
transparent icon more like grey?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D20016: Don't set a null completer on a non-editable combobox

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:c955994053a7: Dont set a null completer on a 
non-editable combobox (authored by elvisangelaccio).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20016?vs=54683=54728

REVISION DETAIL
  https://phabricator.kde.org/D20016

AFFECTED FILES
  src/kcombobox.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/68/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Mar 2019 17:51:26 +
 Build duration:
2 hr 38 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss added a task: T10716: Add check for accidental http: usage.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich updated this revision to Diff 54726.
astippich added a comment.


  - Add failing ogg video test case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54725=54726

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich added a comment.


  forgot rebasing...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich updated this revision to Diff 54725.
astippich added a comment.


  - Add failing ogg video test case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54707=54725

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added a comment.


  To update it, you just run `arc diff` again while on your branch. No need to 
even do `git add`!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added a comment.


  Do you need a hand with navigating Phabricator's weirdness?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20025

To: krutovmikhail, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20025

To: krutovmikhail, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail added a comment.


  This was created as a new revision due to --amend prior to arc diff. Not sure 
on how to update diff on previous one properly, previous is abandoned now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail retitled this revision from "Initial adaptation of patch from 
Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy when in 
"edit mode"".
krutovmikhail edited the summary of this revision.
krutovmikhail added reviewers: ngraham, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Initial adaptation of patch from Dolphin; keyUp -> goUp

[Mikhail Krutov]

krutovmikhail created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
krutovmikhail requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode

REVISION DETAIL
  https://phabricator.kde.org/D20026

AFFECTED FILES
  src/CMakeLists.txt
  src/filewidgets/CMakeLists.txt
  src/filewidgets/keypressedeventfilter.cpp
  src/filewidgets/keypressedeventfilter.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: krutovmikhail
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Bug 195801 - go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail retitled this revision from "WIP: Initial adaptation of patch 
from Dolphin; keyUp -> goUp" to "WIP: Bug 195801 - go up in folder hierachy 
when in "edit mode"".
krutovmikhail edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20025

To: krutovmikhail, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: WIP: Initial adaptation of patch from Dolphin; keyUp -> goUp

[Mikhail Krutov]

krutovmikhail retitled this revision from "Initial adaptation of patch from 
Dolphin; keyUp -> goUp" to "WIP: Initial adaptation of patch from Dolphin; 
keyUp -> goUp".
krutovmikhail added reviewers: Dolphin, ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20025

To: krutovmikhail, #dolphin, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20025: Initial adaptation of patch from Dolphin; keyUp -> goUp

[Mikhail Krutov]

krutovmikhail created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
krutovmikhail requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode

REVISION DETAIL
  https://phabricator.kde.org/D20025

AFFECTED FILES
  src/CMakeLists.txt
  src/filewidgets/CMakeLists.txt
  src/filewidgets/keypressedeventfilter.cpp
  src/filewidgets/keypressedeventfilter.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: krutovmikhail
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20021: Add support for extracting data from ogg and ts files

[Stefan Brüns]

bruns added a comment.


  In D20021#437531 , @astippich 
wrote:
  
  > What I meant is that no metadata is currently extracted at all. Is it 
possible to mark a complete test row as expected failure?
  
  
  `QEXPECT_FAIL("Vorbis Video", "Not yet supported", Abort)` before the first 
QCOMPARE should work

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/42/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Mar 2019 18:56:51 +
 Build duration:
2 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3217/3857)47%
(4348/9311)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(1017/1045)49%
(2204/4543)src77%
(20/26)77%
(20/26)79%
(1195/1508)42%
(467/1102)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/47/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Mar 2019 18:56:51 +
 Build duration:
2 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3217/3857)47%
(4348/9311)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(1017/1045)49%
(2204/4543)src77%
(20/26)77%
(20/26)79%
(1195/1508)42%
(467/1102)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20020: Split ffmpeg tests into video properties and metadata tests

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:6ee3df16ab20: Split ffmpeg tests into video properties 
and metadata tests (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20020?vs=54708=54713

REVISION DETAIL
  https://phabricator.kde.org/D20020

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich added a comment.


  What I meant is that no metadata is currently extracted at all. Is it 
possible to mark a complete test row as expected failure?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19876: Fix: apply correctly the text colors of the chosen scheme

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with that.
  In the long run we should use only the syntaxhighlighting themes and provide 
UX for that.
  Volunteers?

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-schemas

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars

D20020: Split ffmpeg tests into video properties and metadata tests

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20016: Don't set a null completer on a non-editable combobox

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kcombobox.cpp:94
>  Q_D(KComboBox);
>  d->init();
>  setEditable(rw);

Hmm? This calls init() on editable comboboxes too.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20012: Fix number localization for properties

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in propertyinfotest.cpp:97
> This will of course fail as soon as someone translates fps, e.g. german 
> "B/s", even more in RTL locales.
> 
> Probably the better solution is to provide the whole string verbatim, and 
> mark it with i18n. Until then, tests should be run with an en or C locale.

I do not want to start adding translations to unit tests, that seems over the 
top.
I agree it's not perfect, but it is an easy way to catch at least some missing 
localizations.
If you prefer, I can query startsWith(QLocale.toString())

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20012

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into video properties and metadata tests

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into video properties and metadata tests

[Alexander Stippich]

astippich updated this revision to Diff 54708.
astippich added a comment.


  - rephrase comment

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20020?vs=54705=54708

BRANCH
  refactor_ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D20020

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into video properties and metadata tests

[Stefan Brüns]

bruns added a comment.


  ..., otherwise, LGTM

INLINE COMMENTS

> ffmpegextractortest.cpp:53
>  
> -void ffmpegExtractorTest::videoTest()
> +//test only for testing intrinsic video properties
> +void ffmpegExtractorTest::testVideoProperties()

a little bit to much "test" here ;)
and missing space

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into video properties and metadata tests

[Alexander Stippich]

astippich retitled this revision from "Split ffmpeg tests into common 
properties and metadata" to "Split ffmpeg tests into video properties and 
metadata tests".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich updated this revision to Diff 54707.
astippich added a comment.


  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54686=54707

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into common properties and metadata

[Alexander Stippich]

astippich updated this revision to Diff 54705.
astippich added a comment.


  - rename tests

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20020?vs=54685=54705

BRANCH
  refactor_ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D20020

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Stefan Brüns]

bruns added a comment.


  In D20021#437489 , @astippich 
wrote:
  
  > For reasons unknown, the metadata is not correctly extracted and "title" is 
not found for ogg videos, that's why it is not included there. I would like to 
investigate this later.
  
  
  Can you add it nevertheless, and mark it with a QEXPECT_FAIL, using an extra 
"expectFail" column?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich added a comment.


  For reasons unknown, the metadata is not correctly extracted and "title" is 
not found for ogg videos, that's why it is not included there. I would like to 
investigate this later.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags updated this revision to Diff 54702.
nibags added a comment.


  - Pass schema name as parameter
  
  I've also done debug and everything works as it should. 
  Any problem or detail to change, don't hesitate to say

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19876?vs=54614=54702

BRANCH
  fix-schemas

REVISION DETAIL
  https://phabricator.kde.org/D19876

AFFECTED FILES
  src/syntax/katehighlight.cpp
  src/syntax/katehighlight.h

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/67/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Mar 2019 15:52:03 +
 Build duration:
1 hr 59 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/64/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Mar 2019 17:14:09 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32950/60498)39%
(17161/0)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4368/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8432/14405)51%
(4756/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4364/8043)40%
(1922/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(349/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D20005: Report human-readable error if Qt5Widgets is required but is not found

[Alexander Potashev]

aspotashev updated this revision to Diff 54695.
aspotashev retitled this revision from "WIP: Find Qt5Widgets, required for 
Qt5::uic" to "Report human-readable error if Qt5Widgets is required but is not 
found".
aspotashev added a comment.


  Implement probably the most lightweight behaviour.

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20005?vs=54636=54695

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#436853 , @arvidhansson 
wrote:
  
  > In D19952#436834 , @taskf wrote:
  >
  > > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  >
  >
  > I agree, it isn't  even an caps-lock-off key. A 50% tranparent icon would 
fit better
  
  
  This can be done in the system tray widget instead of making a separate icon 
for off.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/50/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Mar 2019 17:14:09 +
 Build duration:
9 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32912/60504)39%
(17128/3)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4371/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8418/14412)51%
(4746/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4361/8043)40%
(1919/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D20008: Fix uninitialized value in SimpleJobPrivate

[Michael Pyne]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:920d2c4ca7d5: kjobs: Fix compiler warning for uninit 
value in SimpleJobPrivate. (authored by mpyne).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20008?vs=54642=54693

REVISION DETAIL
  https://phabricator.kde.org/D20008

AFFECTED FILES
  src/core/job_p.h

To: mpyne, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20012: Fix number localization for properties

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> propertyinfotest.cpp:97
>  QCOMPARE(framerate.formatAsDisplayString(QVariant(23)), 
> QStringLiteral("23 fps"));
> -QCOMPARE(framerate.formatAsDisplayString(QVariant(23.976)), 
> QStringLiteral("23.98 fps"));
> +QCOMPARE(framerate.formatAsDisplayString(QVariant(23.976)), 
> QString(QLocale().toString(23.98) + QStringLiteral(" fps")));
>  

This will of course fail as soon as someone translates fps, e.g. german "B/s", 
even more in RTL locales.

Probably the better solution is to provide the whole string verbatim, and mark 
it with i18n. Until then, tests should be run with an en or C locale.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20012

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19812: Add a web page to view and compare icons of different sizes

[Pino Toscano]

pino added a comment.


  In D19812#436174 , @guoyunhe wrote:
  
  > In D19812#436154 , @pino wrote:
  >
  > > - please harden the script using at least -e and -u flags for set: this 
way, it will not keep executing when a command fails, and undeclared variables 
are not silently expanded to empty string (to prevent typos)
  >
  >
  > Sorry, I am not very familiar with shell script. What does the -e or -u 
flags mean and how to use them? Can you give an example? Thanks.
  
  
  
  
  - -e: exits whenever any of the programs return a non-zero (i.e. failure) 
return code; this is useful to not silently ignore failures, and makes the 
behaviour similar to each line in a target of a Makefile
  - -u: immediately fails when trying to expand a variable that was not 
previously set; this way, things like `mkdir "$DIR/foo"` will immediately fail 
if `$FOO` was not set previously (so prevent misbehaviours due to typos, or 
code path not taken into account)

INLINE COMMENTS

> generate_web_data.sh:7
> +then
> +echo "Error: Directory $DIR/icons does not exist."
> +exit

this should go to stderr, as it is an error

> generate_web_data.sh:13
> +then
> +echo "Error: Directory $DIR/icons-dark does not exist."
> +exit

ditto

> index.html:93
> +  
> +  https://unpkg.com/vue";>
> +

Always using the network is not exactly a good idea:

- the page is unusable if there is no Internet connection
- this (private!) website will be phoned home every time an user loads this 
page locally, without even notifying the user

At least in Debian I see a `libjs-vue` package, so please make sure to work 
with local copies only. Otherwise this is a big privacy concern.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Nathaniel Graham]

ngraham added a comment.


  In D19952#436919 , @taskf wrote:
  
  > Hmm, still I somehow like the stroked version, while I wouldn't recommend 
using it this particular case. Even the transparent version can easily be 
controlled the `disabled` state of this icon object. Currently, I think it 
would be good to add both icons to Breeze iconset, just in case there is 
another use case for it some day. I added all the other mockups I did just to 
let you know.
  >  F6716206: image.png 
  
  
  Try to follow the Breeze icon style as much as possible. These locks look 
distinctly different from other Breeze lock icons, and the colors and shapes 
are different too. The goal is to blend in with other Breeze-style icons, not 
to stand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe updated this revision to Diff 54688.
guoyunhe added a comment.


  Fix typo

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54546=54688

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> generate_web_data.sh:7
> +then
> +echo "Error: Directory $DIR/icons does not exists."
> +exit

exists -> exist

> generate_web_data.sh:13
> +then
> +echo "Error: Directory $DIR/icons-dark does not exists."
> +exit

ditto

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20021: Add support for extracting data from ogg and ts files

[Stefan Brüns]

bruns added a comment.


  According to ffplay, the ogg file has title and the like, so it should be 
listed in the MetaData test.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into common properties and metadata

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in ffmpegextractortest.h:33
> What is metadata data? :p

Data for testing metadata ;-)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into common properties and metadata

[Stefan Brüns]

bruns added a comment.


  Can you rename the `videoTest()`, so it is clear one is about intrinsic video 
properties, and the other about explicit information stored in tags/metadata 
bitstreams? Also add a comment saying so.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into common properties and metadata

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ffmpegextractortest.h:33
> +void videoTestMetaData();
> +void videoTestMetaData_data();
>  };

What is metadata data? :p

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20020: Split ffmpeg tests into common properties and metadata

[Alexander Stippich]

astippich added a dependent revision: D20021: Add support for extracting data 
from ogg and ts files.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20020

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich added reviewers: ngraham, bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich added a dependency: D20020: Split ffmpeg tests into common properties 
and metadata.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

[Alexander Stippich]

astippich created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  CCBUG: 399650

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/63/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Mar 2019 15:52:03 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32926/60495)39%
(17157/0)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4369/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8407/14402)51%
(4749/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4365/8043)40%
(1923/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(349/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D20020: Split ffmpeg tests into common properties and metadata

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D20020

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/49/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Mar 2019 15:52:03 +
 Build duration:
6 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32916/60502)39%
(17141/3)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4371/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8422/14410)51%
(4754/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4361/8043)40%
(1919/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D20016: Don't set a null completer on a non-editable combobox

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 54683.
elvisangelaccio added a comment.


  - David's suggestion

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20016?vs=54660=54683

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

AFFECTED FILES
  src/kcombobox.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20016: Don't set a null completer on a non-editable combobox

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dfaure wrote in kcombobox.cpp:60
> Are you sure the line shouldn't be moved under this if()? It wouldn't warn 
> here, since that's the case where it's editable.
> 
> At least this seems safer, unless you did the additional research of whether 
> (or not) there is indeed a completer that we want to remove on editable 
> comboboxes.

`init()` is never called on an editable combobox, if I'm not wrong. But you are 
right, that should be safer and would still prevent the warning.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20016: Don't set a null completer on a non-editable combobox

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcombobox.cpp:60
>  
>  if (q->isEditable()) {
>  q->lineEdit()->setContextMenuPolicy(Qt::DefaultContextMenu);

Are you sure the line shouldn't be moved under this if()? It wouldn't warn 
here, since that's the case where it's editable.

At least this seems safer, unless you did the additional research of whether 
(or not) there is indeed a completer that we want to remove on editable 
comboboxes.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20016

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19967: [kpeople] make it compile without foreach

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> matchessolver.cpp:62
>  //because they are the same
> -QList keys = destinationResolver.keys(urlB);
> -foreach (const QString , keys) {
> -destinationResolver[key] = urlA;
> +const auto lst = destinationResolver.keys(urlB);
> +auto it = lst.constBegin();

`lst` used to be called `keys`, there's no particular reason to rename it.

> metacontact.cpp:51
>  QVariantList ret;
> -Q_FOREACH (const AbstractContact::Ptr , m_contacts) {
> +for (const AbstractContact::Ptr  : qAsConst(m_contacts)) 
> {
>  QVariant val = contact->customProperty(key);

(the qAsConst isn't technically needed since this method is const; but it 
doesn't hurt either)

> mergecontactswidget.cpp:185
>  // retrieve all the widget where the box is checked
> -QPair mergeContact ;
> -Q_FOREACH (mergeContact, m_listMergeContacts) {
> +for (QPair 
> mergeContact :  qAsConst(m_listMergeContacts)) {
>  if (mergeContact.second->isContactSelected()) {

const & would be even better.

(It'll get lengthy, so this might be a reason to switch for const auto & here, 
although some might object that the type isn't visible in the code here)

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D19967

To: mlaurent, dfaure
Cc: apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54680.
knauss added a comment.


  fixing a typo.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54679=54680

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/base.htignore
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/62/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Mar 2019 14:16:16 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32947/60496)39%
(17154/0)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4369/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8429/14403)51%
(4752/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4364/8043)40%
(1922/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(347/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D18793: Handle text completion with block selection mode

[loh tar]

loh.tar added a comment.


  In D18793#421367 , @ahmadsamir 
wrote:
  
  > In D18793#420599 , @loh.tar 
wrote:
  >
  > > Fix this patch also Bug 382213 ?
  >
  >
  > No, it doesn't fix it.
  
  
  But this may D19446 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18793

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, mwolff
Cc: loh.tar, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Mar 2019 14:16:16 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32932/60502)39%
(17154/3)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8422/14410)51%
(4753/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4361/8043)40%
(1919/4803)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54679.
knauss added a comment.


  make parallel network requests.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54663=54679

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/base.htignore
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bc42a1b2f913: Dont create thumbnails for encrypted 
Vaults (authored by ivan).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19979?vs=54673=54678

REVISION DETAIL
  https://phabricator.kde.org/D19979

AFFECTED FILES
  src/widgets/previewjob.cpp

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/66/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Mar 2019 14:16:16 +
 Build duration:
6 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Hallas]

hallas added a comment.


  Thanks a lot for the feedback guys, I will spend some time and implement it 
and push an updated patch.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[Christoph Cullmann]

cullmann added a comment.


  I still need to test that again ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D20018: Update URLs to use https

[Yuri Chornoivan]

yurchor requested changes to this revision.
yurchor added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> argparserutils.py:62
>'generate dependency diagrams.\n'
> -  'See .')
> +  'See .')
>  exit(1)

https://www.graphviz.org/download/

> Doxyfile.global:2
>  # Default settings for KDE projects
> -# See http://www.stack.nl/~dimitri/doxygen/manual/config.html for help
> +# See https://www.stack.nl/~dimitri/doxygen/manual/config.html for help
>  

http://www.doxygen.nl/manual/config.html

> library.html:22
>
> -  KDE's  href="http://community.kde.org/Policies/Library_Documentation_Policy;>Doxygen 
> guidelines are available online.
> +  KDE's  href="https://community.kde.org/Policies/Library_Documentation_Policy;>Doxygen
>  guidelines are available online.
>

https://community.kde.org/Frameworks/Frameworks_Documentation_Policy

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D20018

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D20018: Update URLs to use https

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Largely using the tools from D19996 .

REPOSITORY
  R264 KApiDox

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20018

AFFECTED FILES
  CMakeLists.txt
  docs/metainfo_syntax.md
  src/kapidox/argparserutils.py
  src/kapidox/data/Doxyfile.global
  src/kapidox/data/htmlresource/kde.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/footer.html
  src/kapidox/data/templates/library.html

To: vkrause
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19979: Don't create thumbnails for encrypted Vaults

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

[Ivan Čukić]

ivan updated this revision to Diff 54673.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19979?vs=54582=54673

REVISION DETAIL
  https://phabricator.kde.org/D19979

AFFECTED FILES
  src/widgets/previewjob.cpp

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

[Ivan Čukić]

ivan marked an inline comment as done.
ivan added inline comments.

INLINE COMMENTS

> broulik wrote in previewjob.cpp:307
> Did you profile the impact of this call? I don't think it's cached. Can this 
> maybe be moved to the thumbnail KIO so it's done out of process?

I didn't do any profiling.

We can not cache because mount points can change. KMountPoint provides no 
signals of this.

It should not be overly expensive - small number of mounts to process.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/52/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 24 Mar 2019 13:11:50 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

D18793: Handle text completion with block selection mode

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, I still don't like that we do different things in replaceText depending 
on the selection of the potential activeView, that makes this function harder 
to use correctly, as it might magically do something the user might not expect.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18793

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, mwolff
Cc: loh.tar, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19978: Allow to set custom hints for notifications

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:06a61528cd48: Allow to set custom hints for notifications 
(authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19978?vs=54669=54671

REVISION DETAIL
  https://phabricator.kde.org/D19978

AFFECTED FILES
  src/knotification.cpp
  src/knotification.h
  src/notifybypopup.cpp

To: nicolasfella, broulik, davidedmundson
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D19978: Allow to set custom hints for notifications

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  hints

REVISION DETAIL
  https://phabricator.kde.org/D19978

To: nicolasfella, broulik, davidedmundson
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns