D27247: Unify the look of all icons containing  (no sign)

[Matej Mrenica]

mthw added a comment.


  @ndavis I've set my name, do I need to "arc diff" again or something else?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Noah Davis]

ndavis added a comment.


  You need to set your full name as your git user name. Otherwise, the system 
won't let me land it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Matej Mrenica]

mthw added a comment.


  Since you accepted, can you also commit this, please?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27269: Use ecm_qt_install_logging_categories over manual categories file

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27269

To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27268: Fixed handling of relative paths by KUrlNavigator

[Ahmad Samir]

ahmadsamir added reviewers: dfaure, elvisangelaccio.
ahmadsamir added a comment.


  I am curious, why would you remove the already present part of the path? when 
I make the url navigator editable the text cursor is already at the end of the 
path, so I can just start typing the name of a sub-direcotry in the current 
directory, and it'll offer auto-completion.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27268

To: mdlubakowski, #frameworks, dfaure, elvisangelaccio
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 304 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/304/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 11 Feb 2020 04:48:20 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_kurlrequestertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)66%
(269/406)66%
(269/406)56%
(34652/62078)40%
(17573/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(57/58)98%
(57/58)95%
(9629/10181)47%
(4485/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8735/14619)51%
(4519/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4685/8330)43%
(2074/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(391/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 296 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/296/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 11 Feb 2020 04:48:20 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Icons look like this, 16x16 & 22x22 :
  F8096704: Screenshot_20200211_050115.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 75429.
kossebau added a comment.


  missing bottom aligning of warning symbol for 22

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27272?vs=75428=75429

BRANCH
  adddatastatusicons

REVISION DETAIL
  https://phabricator.kde.org/D27272

AFFECTED FILES
  icons-dark/status/16/data-error.svg
  icons-dark/status/16/data-information.svg
  icons-dark/status/16/data-warning.svg
  icons-dark/status/22/data-error.svg
  icons-dark/status/22/data-information.svg
  icons-dark/status/22/data-warning.svg
  icons/status/16/data-error.svg
  icons/status/16/data-information.svg
  icons/status/16/data-warning.svg
  icons/status/22/data-error.svg
  icons/status/22/data-information.svg
  icons/status/22/data-warning.svg

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 75428.
kossebau added a comment.


  Add own data-* icons, done to best what sleeplessness and community.kde.org 
guides
  allowed me to twist together.
  
  Color-adaption works.
  Hardcoded #ff for the !,i,X symbols should possible see some fix, but
  all existing usage of the same error/warning/info emblem also has the same
  hardcoding.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27272?vs=75319=75428

BRANCH
  adddatastatusicons

REVISION DETAIL
  https://phabricator.kde.org/D27272

AFFECTED FILES
  icons-dark/status/16/data-error.svg
  icons-dark/status/16/data-information.svg
  icons-dark/status/16/data-warning.svg
  icons-dark/status/22/data-error.svg
  icons-dark/status/22/data-information.svg
  icons-dark/status/22/data-warning.svg
  icons/status/16/data-error.svg
  icons/status/16/data-information.svg
  icons/status/16/data-warning.svg
  icons/status/22/data-error.svg
  icons/status/22/data-information.svg
  icons/status/22/data-warning.svg

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/7/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 01:33:28 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 491 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 109 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/109/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Tue, 11 Feb 2020 01:52:07 +
 Build duration:
1 min 14 sec and counting

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/7/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 01:33:26 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_addresstest

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/61/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 11 Feb 2020 01:16:44 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/95/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 11 Feb 2020 01:16:44 +
 Build duration:
3 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 303 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/303/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 11 Feb 2020 01:08:24 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34824/62087)40%
(17692/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9722/10183)47%
(4539/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8725/14619)51%
(4517/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8330)43%
(2076/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 01:19:09 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 177 lines...][2020-02-11T01:20:33.799Z] USERDOMAIN= 'DESKTOP-L331S90'[2020-02-11T01:20:33.799Z] USERNAME  = 'Jenkins'[2020-02-11T01:20:33.799Z] USERPROFILE   = 'C:\Users\Jenkins'[2020-02-11T01:20:33.799Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2020-02-11T01:20:33.799Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2020-02-11T01:20:33.799Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\'[2020-02-11T01:20:33.799Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.24.28127\'[2020-02-11T01:20:33.799Z] VCTOOLSVERSION= '14.24.28314'[2020-02-11T01:20:33.799Z] VISUALSTUDIOVERSION   = '16.0'[2020-02-11T01:20:33.799Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2020-02-11T01:20:33.800Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2020-02-11T01:20:33.800Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2020-02-11T01:20:33.800Z] VSCMD_ARG_TGT_ARCH= 'x64'[2020-02-11T01:20:33.800Z] VSCMD_VER = '16.4.3'[2020-02-11T01:20:33.800Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2020-02-11T01:20:33.800Z] WINDIR= 'C:\Windows'[2020-02-11T01:20:33.800Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0'[2020-02-11T01:20:33.800Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2020-02-11T01:20:33.800Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2020-02-11T01:20:33.800Z] WINDOWSSDKLIBVERSION  = '10.0.18362.0\'[2020-02-11T01:20:33.800Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\'[2020-02-11T01:20:33.800Z] WINDOWSSDKVERSION = '10.0.18362.0\'[2020-02-11T01:20:33.800Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-11T01:20:33.800Z] __DOTNET_ADD_64BIT= '1'[2020-02-11T01:20:33.800Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-11T01:20:33.800Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-11T01:20:33.800Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\kcalendarcore;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-11T01:20:33.800Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:20:33.800Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-11T01:20:33.800Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-11T01:20:33.800Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-11T01:20:33.800Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:20:33.800Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-11T01:20:33.800Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-11T01:20:33.800Z] [2020-02-11T01:20:33.800Z] [2020-02-11T01:20:33.800Z] == Commencing Configuration:[2020-02-11T01:20:33.800Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/kcalendarcore/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-11T01:20:35.191Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-11T01:20:36.187Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-11T01:20:36.187Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 01:19:08 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 201 lines...][2020-02-11T01:19:43.033Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-11T01:19:43.033Z] __DOTNET_ADD_64BIT= '1'[2020-02-11T01:19:43.033Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-11T01:19:43.033Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-11T01:19:43.033Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\kcontacts;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-11T01:19:43.033Z] QT_PLUGIN_PATH= 'C:\CI\Software Installs\kcontacts\lib\plugins;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-11T01:19:43.033Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\kcontacts\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:19:43.033Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-11T01:19:43.033Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-11T01:19:43.033Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\kcontacts\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:19:43.033Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-11T01:19:43.033Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-11T01:19:43.033Z] [2020-02-11T01:19:43.033Z] [2020-02-11T01:19:43.033Z] == Commencing Configuration:[2020-02-11T01:19:43.033Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/kcontacts/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-11T01:19:43.606Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-11T01:19:44.177Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-11T01:19:44.177Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-11T01:19:45.559Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-11T01:19:45.559Z] -- Detecting C compiler ABI info[2020-02-11T01:19:46.500Z] -- Detecting C compiler ABI info - done[2020-02-11T01:19:46.500Z] -- Detecting C compile features[2020-02-11T01:19:47.442Z] -- Detecting C compile features - done[2020-02-11T01:19:47.442Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-11T01:19:48.386Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-11T01:19:48.386Z] -- Detecting CXX compiler ABI info[2020-02-11T01:19:48.952Z] -- Detecting CXX compiler ABI info - done[2020-02-11T01:19:48.952Z] -- Detecting CXX compile features[2020-02-11T01:19:51.488Z] -- Detecting CXX compile features - done[2020-02-11T01:19:51.488Z] -- [2020-02-11T01:19:51.488Z] [2020-02-11T01:19:51.488Z] Installing in C:/CI/Software Installs/kcontacts. Run C:/CI/Job Build/build/prefix.sh to set the environment for KContacts.[2020-02-11T01:19:51.488Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-11T01:19:51.488Z] -- Looking for __GLIBC__[2020-02-11T01:19:51.488Z] -- Looking for __GLIBC__ - not found[2020-02-11T01:19:51.488Z] -- Found KF5CoreAddons: C:/CI/Software Installs/kcontacts/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.68.0") [2020-02-11T01:19:51.488Z] -- Found Gettext: C:/Craft/CI-Qt514/windows-msvc2019_64-cl-debug/bin/msgmerge.exe (found version "0.19.8.1") [2020-02-11T01:19:51.488Z] -- Found KF5I18n: C:/CI/Software Installs/kcontacts/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.68.0") [2020-02-11T01:19:51.488Z] -- Found KF5Config: C:/CI/Software Installs/kcontacts/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.68.0") [2020-02-11T01:19:51.488Z] -- Found KF5Codecs: C:/CI/Software 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 295 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/295/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 11 Feb 2020 01:08:24 +
 Build duration:
5 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27269: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f385d5716762: Use ecm_qt_install_logging_categories over 
manual categories file (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27269?vs=75313=75426#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27269?vs=75313=75426

REVISION DETAIL
  https://phabricator.kde.org/D27269

AFFECTED FILES
  CMakeLists.txt
  kio.categories
  src/CMakeLists.txt
  src/core/CMakeLists.txt
  src/gui/CMakeLists.txt
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/ftp/CMakeLists.txt
  src/ioslaves/http/CMakeLists.txt
  src/ioslaves/http/kcookiejar/CMakeLists.txt
  src/ioslaves/remote/CMakeLists.txt
  src/ioslaves/trash/CMakeLists.txt
  src/kcms/kio/CMakeLists.txt
  src/kiod/CMakeLists.txt
  src/kioexec/CMakeLists.txt
  src/kpasswdserver/CMakeLists.txt
  src/urifilters/ikws/CMakeLists.txt
  src/urifilters/localdomain/CMakeLists.txt
  src/urifilters/shorturi/CMakeLists.txt
  src/widgets/CMakeLists.txt

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27178: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:19cd6b195279: Use ecm_qt_install_logging_categories over 
manual categories file (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27178?vs=75070=75424#toc

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27178?vs=75070=75424

REVISION DETAIL
  https://phabricator.kde.org/D27178

AFFECTED FILES
  CMakeLists.txt
  sonnet.categories
  src/CMakeLists.txt
  src/core/CMakeLists.txt
  src/plugins/aspell/CMakeLists.txt
  src/plugins/hspell/CMakeLists.txt
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/ispellchecker/CMakeLists.txt
  src/plugins/nsspellchecker/CMakeLists.txt
  src/plugins/voikko/CMakeLists.txt
  src/ui/CMakeLists.txt

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/51/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 11 Feb 2020 01:01:59 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/5/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 01:01:59 +
 Build duration:
1 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 175 lines...][2020-02-11T01:02:53.090Z] USERDOMAIN= 'DESKTOP-KQ77DSL'[2020-02-11T01:02:53.090Z] USERNAME  = 'Jenkins'[2020-02-11T01:02:53.090Z] USERPROFILE   = 'C:\Users\Jenkins'[2020-02-11T01:02:53.090Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2020-02-11T01:02:53.090Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2020-02-11T01:02:53.090Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.24.28314\'[2020-02-11T01:02:53.090Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.24.28127\'[2020-02-11T01:02:53.090Z] VCTOOLSVERSION= '14.24.28314'[2020-02-11T01:02:53.090Z] VISUALSTUDIOVERSION   = '16.0'[2020-02-11T01:02:53.090Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2020-02-11T01:02:53.090Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2020-02-11T01:02:53.090Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2020-02-11T01:02:53.090Z] VSCMD_ARG_TGT_ARCH= 'x64'[2020-02-11T01:02:53.090Z] VSCMD_VER = '16.4.3'[2020-02-11T01:02:53.090Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2020-02-11T01:02:53.090Z] WINDIR= 'C:\Windows'[2020-02-11T01:02:53.090Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0'[2020-02-11T01:02:53.090Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2020-02-11T01:02:53.090Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2020-02-11T01:02:53.090Z] WINDOWSSDKLIBVERSION  = '10.0.18362.0\'[2020-02-11T01:02:53.090Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\'[2020-02-11T01:02:53.090Z] WINDOWSSDKVERSION = '10.0.18362.0\'[2020-02-11T01:02:53.090Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-11T01:02:53.090Z] __DOTNET_ADD_64BIT= '1'[2020-02-11T01:02:53.090Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-11T01:02:53.090Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-11T01:02:53.090Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\kcalendarcore;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-11T01:02:53.090Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:02:53.090Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-11T01:02:53.090Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-11T01:02:53.090Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-11T01:02:53.090Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T01:02:53.090Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-11T01:02:53.090Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-11T01:02:53.090Z] [2020-02-11T01:02:53.090Z] [2020-02-11T01:02:53.090Z] == Commencing Configuration:[2020-02-11T01:02:53.090Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/kcalendarcore/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-11T01:02:53.665Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-11T01:02:53.665Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-11T01:02:53.665Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 160 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/160/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 11 Feb 2020 00:44:59 +
 Build duration:
5 min 37 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.68.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6927/9112)43%
(10794/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2897/2990)49%
(6191/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/799)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/5/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 00:46:49 +
 Build duration:
28 sec and counting
   CONSOLE OUTPUT
  [...truncated 201 lines...][2020-02-11T00:47:12.547Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-11T00:47:12.547Z] __DOTNET_ADD_64BIT= '1'[2020-02-11T00:47:12.547Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-11T00:47:12.547Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-11T00:47:12.547Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\kcontacts;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-11T00:47:12.547Z] QT_PLUGIN_PATH= 'C:\CI\Software Installs\kcontacts\lib\plugins;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-11T00:47:12.547Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\kcontacts\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T00:47:12.547Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-11T00:47:12.547Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-11T00:47:12.547Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\kcontacts\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-11T00:47:12.547Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-11T00:47:12.547Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-11T00:47:12.548Z] [2020-02-11T00:47:12.548Z] [2020-02-11T00:47:12.548Z] == Commencing Configuration:[2020-02-11T00:47:12.548Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/kcontacts/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-11T00:47:12.809Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-11T00:47:13.070Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-11T00:47:13.070Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-11T00:47:13.640Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-11T00:47:13.640Z] -- Detecting C compiler ABI info[2020-02-11T00:47:13.899Z] -- Detecting C compiler ABI info - done[2020-02-11T00:47:13.899Z] -- Detecting C compile features[2020-02-11T00:47:14.161Z] -- Detecting C compile features - done[2020-02-11T00:47:14.161Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-11T00:47:14.420Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-11T00:47:14.420Z] -- Detecting CXX compiler ABI info[2020-02-11T00:47:14.988Z] -- Detecting CXX compiler ABI info - done[2020-02-11T00:47:14.988Z] -- Detecting CXX compile features[2020-02-11T00:47:15.249Z] -- Detecting CXX compile features - done[2020-02-11T00:47:15.249Z] -- [2020-02-11T00:47:15.249Z] [2020-02-11T00:47:15.249Z] Installing in C:/CI/Software Installs/kcontacts. Run C:/CI/Job Build/build/prefix.sh to set the environment for KContacts.[2020-02-11T00:47:15.249Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-11T00:47:15.249Z] -- Looking for __GLIBC__[2020-02-11T00:47:15.249Z] -- Looking for __GLIBC__ - not found[2020-02-11T00:47:15.509Z] -- Found KF5CoreAddons: C:/CI/Software Installs/kcontacts/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.68.0") [2020-02-11T00:47:15.509Z] -- Found Gettext: C:/Craft/CI-Qt514/windows-msvc2019_64-cl-debug/bin/msgmerge.exe (found version "0.19.8.1") [2020-02-11T00:47:15.509Z] -- Found KF5I18n: C:/CI/Software Installs/kcontacts/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.68.0") [2020-02-11T00:47:15.509Z] -- Found KF5Config: C:/CI/Software Installs/kcontacts/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.68.0") [2020-02-11T00:47:15.509Z] -- Found KF5Codecs: C:/CI/Software 

D27270: Use ecm_qt_install_logging_categories over manual categories files

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R174:473ec03799d6: Use ecm_qt_install_logging_categories over 
manual categories files (authored by kossebau).

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27270?vs=75314=75423

REVISION DETAIL
  https://phabricator.kde.org/D27270

AFFECTED FILES
  CMakeLists.txt
  kcontacts.categories
  kcontacts.renamecategories
  src/CMakeLists.txt

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/107/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 11 Feb 2020 00:44:59 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 108 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/108/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Tue, 11 Feb 2020 00:44:59 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 142 lines...][2020-02-11T00:45:53.582Z] _ = '/usr/bin/java'[2020-02-11T00:45:53.582Z] STAGE_NAME= 'Configuring Build'[2020-02-11T00:45:53.582Z] EXECUTOR_NUMBER   = '0'[2020-02-11T00:45:53.582Z] BUILD_DISPLAY_NAME= '#108'[2020-02-11T00:45:53.582Z] HUDSON_HOME   = '/home/production/data'[2020-02-11T00:45:53.582Z] ANDROID_NDK_HOST  = 'linux-x86_64'[2020-02-11T00:45:53.582Z] JOB_BASE_NAME = 'kf5-qt5 AndroidQt5.13'[2020-02-11T00:45:53.582Z] PATH  = '/opt/Qt/5.13.2/android_armv7/bin:/opt/kdeandroid-deps/bin:/opt/cmake/bin:/opt/Qt/5.13.2/android_armv7/bin:/opt/android-sdk/tools:/opt/android-sdk/tools/bin:/opt/android-sdk/platform-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'[2020-02-11T00:45:53.582Z] STANDALONE_EXTRA  = '--stl=libc++ --arch=arm'[2020-02-11T00:45:53.582Z] BUILD_ID  = '108'[2020-02-11T00:45:53.582Z] BUILD_TAG = 'jenkins-Frameworks-kcoreaddons-kf5-qt5 AndroidQt5.13-108'[2020-02-11T00:45:53.582Z] ANDROID_ARCH  = 'arm'[2020-02-11T00:45:53.582Z] JENKINS_URL   = 'https://build.kde.org/'[2020-02-11T00:45:53.582Z] LANG  = 'en_US.UTF-8'[2020-02-11T00:45:53.582Z] QT_PATH   = '/opt/Qt'[2020-02-11T00:45:53.582Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/'[2020-02-11T00:45:53.582Z] ANDROID_NDK_ROOT  = '/opt/android-ndk'[2020-02-11T00:45:53.582Z] DEBIAN_FRONTEND   = 'noninteractive'[2020-02-11T00:45:53.582Z] BUILD_NUMBER  = '108'[2020-02-11T00:45:53.582Z] SHELL = '/bin/sh'[2020-02-11T00:45:53.582Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/108/display/redirect'[2020-02-11T00:45:53.582Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/display/redirect'[2020-02-11T00:45:53.582Z] ANDROID_SDK_ROOT  = '/opt/android-sdk'[2020-02-11T00:45:53.582Z] STANDALONE_CXX= 'clang++'[2020-02-11T00:45:53.582Z] JOB_NAME  = 'Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13'[2020-02-11T00:45:53.582Z] PWD   = '/home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13'[2020-02-11T00:45:53.582Z] LC_ALL= 'en_US.UTF-8'[2020-02-11T00:45:53.582Z] JAVA_HOME = '/usr/lib/jvm/java-8-openjdk-amd64'[2020-02-11T00:45:53.582Z] ANDROID_HOME  = '/opt/android-sdk'[2020-02-11T00:45:53.582Z] ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'[2020-02-11T00:45:53.582Z] ANDROID_NDK   = '/opt/android-ndk'[2020-02-11T00:45:53.582Z] CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.13.2/android_armv7:/opt/kdeandroid-deps'[2020-02-11T00:45:53.582Z] XDG_DATA_DIRS = '/home/user/install-prefix/share:/opt/kdeandroid-deps/share'[2020-02-11T00:45:53.582Z] LD_LIBRARY_PATH   = '/opt/Qt/5.13.2/android_armv7/lib:/opt/kdeandroid-deps/lib'[2020-02-11T00:45:53.582Z] PKG_CONFIG_PATH   = '/opt/Qt/5.13.2/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'[2020-02-11T00:45:53.582Z] QMAKEFEATURES = '/opt/Qt/5.13.2/android_armv7/mkspecs/features'[2020-02-11T00:45:53.582Z] QML2_IMPORT_PATH  = '/opt/kdeandroid-deps/lib/qml'[2020-02-11T00:45:53.582Z] XDG_CONFIG_DIRS   = '/opt/kdeandroid-deps/etc/xdg'[2020-02-11T00:45:53.582Z] QT_SELECT = 'qt5'[2020-02-11T00:45:53.582Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-11T00:45:53.582Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-11T00:45:53.582Z] [2020-02-11T00:45:53.582Z] [2020-02-11T00:45:53.582Z] == Commencing Configuration:[2020-02-11T00:45:53.582Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.13.2/android_armv7;/opt/kdeandroid-deps" -DANDROID_API_LEVEL=21 "/home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13"[2020-02-11T00:45:53.582Z] -- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=[2020-02-11T00:45:53.582Z] -- Android: Targeting API '21' with architecture 'arm', ABI 'armeabi-v7a', and processor 

D27151: Use ecm_qt_install_logging_categories over manual categories file

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:fcb1eff1c610: Use ecm_qt_install_logging_categories over 
manual categories file (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27151?vs=74974=75422

REVISION DETAIL
  https://phabricator.kde.org/D27151

AFFECTED FILES
  CMakeLists.txt
  kcoreaddons.categories
  src/lib/CMakeLists.txt

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/60/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 10 Feb 2020 23:22:29 +
 Build duration:
6 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 10 Feb 2020 23:22:29 +
 Build duration:
5 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:86041b6d8634: Add ecm_qt_install_logging_categories  
ecm_qt_export_logging_category (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27150?vs=75312=75421#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27150?vs=75312=75421

REVISION DETAIL
  https://phabricator.kde.org/D27150

AFFECTED FILES
  modules/ECMQtDeclareLoggingCategory.cmake
  tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt
  tests/ECMQtDeclareLoggingCategoryTest/log.categories
  tests/ECMQtDeclareLoggingCategoryTest/log.renamecategories

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27291: install smb as both smb:// and cifs://

[Alexander Saoutkin]

feverfew added a comment.


  In D27291#609358 , @dfaure wrote:
  
  > feverfew: you're probably looking at master while this is a patch for the 
19.12 branch.
  >  See https://phabricator.kde.org/D26358 which happened in master.
  >
  > I guess that makes this commit ok for 19.12, but it has to be redone 
differently in master.
  
  
  That's exactly what I did, ignore me :)

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27291: install smb as both smb:// and cifs://

[David Faure]

dfaure added a comment.


  feverfew: you're probably looking at master while this is a patch for the 
19.12 branch.
  See https://phabricator.kde.org/D26358 which happened in master.
  
  I guess that makes this commit ok for 19.12, but it has to be redone 
differently in master.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27291: install smb as both smb:// and cifs://

[David Faure]

dfaure added a comment.


  Both are supported, but indeed json is preferred over installed .protocol 
files.
  
  You can use protocoltojson (from kio) to do the conversion.
  This is all technically unrelated to this commit, except that the nice cmake 
hack to generate two files isn't even needed with json, you can just bundle up 
both protocols into the same json file (see kio/src/ioslaves/http/http.json for 
an example).

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Re: Frameworks 5.67 re-spin request

[David Faure]

On lundi 10 février 2020 15:32:11 CET Nate Graham wrote:
> Hello frameworks packagers,
> I hate to have to make this request, bug could we get Frameworks 5.67
> re-spun to include these two commits:
> 
> https://cgit.kde.org/kirigami.git/commit/?id=f695cde36a6829b8b92b2fd82deff16
> d9385fcb9
> 
> https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=6995b4ae81a2f3ca3c24d
> 2fa6d1560bfe0898737
> 
> These commits fix highly user-visible issues with scrollbars in
> QML-based apps, most notably Discover.
> 
> I've been told that most LTS distros are planning to ship Plasma 5.18
> with Frameworks 5.67, so if that version doesn't include these fixes,
> then Plasma 5.18 LTS users will be stuck with the issues for years and
> we'll get a ton of bug reports.

Done:

kirigami v5.67.1
b0f31c4c671f3cb4cab3425f5d757c6cf6e2d02b
0311ba00b213a26acddd9fe4ce0642ed2500a076429ea5fe4424fdf634f12e68  
sources/kirigami2-5.67.1.tar.xz

qqc2-desktop-style v5.67.1
a992466f2fe596b1ae34da91fd7e95e21b973a52
b2af96084e85096506cc109634234150cfc88a9fcf2d6887c55ef1787c046a44  
sources/qqc2-desktop-style-5.67.1.tar.xz

https://kde.org/info/kde-frameworks-5.67.0.php updated (without much polish).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D27291: install smb as both smb:// and cifs://

[Alexander Saoutkin]

feverfew added a comment.


  I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking 
at the repo and it appears to be the case, so I'm not seeing how this diff is 
seeing this as a rename?

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Noah Davis]

ndavis added a comment.


  I think rather than adjusting hardcoded opacity in the SVGs, we need to make 
configurable plasmashell opacity a reality. Then, if we want to do an effect 
like what Nate described, we could have a way to automatically adjust the 
global plasmashell opacity.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  - Breeze panel and dialog being different when using a dark theme
  - Avoiding controls to be used in ViewBackground areas / using Background 
Breeze color without it looking gray
  
  I have no idea how these could be fixed without just using a color file-d 
theme by default :-(
  The top area could work for the second one, but stuff like wifi password box 
and clipboard box might probably still fall outside...
  
  - Breeze panel and dialog being different when there's a maximized window
  
  I have no idea how this could be addressed at all. It's not currently doing 
that either. And making the panel opaque on maximized app would not work either 
unless the dialog is also fully opaque. Which I'm not a fan of, in this patch.
  
  tl;dr: kinda stuck with this one, not sure what I could do to address those 
problems. I should keep thinking about this.
  
  Maybe the look could be implemented first for just Breeze Light and Dark and 
not Breeze first, but it would probably be very weird to explain it to the user 
("Breeze is more opaque and follows the colorscheme, Breeze Light is the 
opposite").

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27247: Unify the look of all icons containing  (no sign)

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: ndavis.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!
  
  @ndavis does this look okay to you? And what do you think about that lonely 
24px `audio-volume-muted` icon in the actions folder? Once this lands, should 
we move it to the 24px status icons folder so it can join its rightful brethren?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Matej Mrenica]

mthw updated this revision to Diff 75406.
mthw added a comment.


  Fixed

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75389=75406

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/mail-mark-junk.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/mail-mark-junk.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/mail-mark-junk.svg
  icons-dark/actions/32/mail-mark-junk.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/mail-mark-junk.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/mail-mark-junk.svg
  icons/actions/24/audio-volume-muted.svg
  icons/actions/24/mail-mark-junk.svg
  icons/actions/32/mail-mark-junk.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

[Nathaniel Graham]

ngraham removed a dependent revision: D27222: [applets/taskmanager] increase 
size of tooltip playback ToolButton sizes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-pc3-toolbutton-sizing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27221

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: gvgeo, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Nathaniel Graham]

ngraham added a comment.


  Just found a 24px version of `audio-volume-muted` in the actions folder that 
either needs the same change, or needs to be deleted. Almost done!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27297: KGuiAddons: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R273:9cdefdd60fb0: KGuiAddons: Convert license headers to SPDX 
statements (authored by cordlandwehr).

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27297?vs=75392=75403

REVISION DETAIL
  https://phabricator.kde.org/D27297

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/kiconutilstest.cpp
  autotests/kiconutilstest.h
  autotests/kwordwraptest.cpp
  src/colors/kcolorcollection.cpp
  src/colors/kcolorcollection.h
  src/colors/kcolormimedata.cpp
  src/colors/kcolormimedata.h
  src/colors/kcolorspaces.cpp
  src/colors/kcolorspaces_p.h
  src/colors/kcolorutils.cpp
  src/colors/kcolorutils.h
  src/colors/kguiaddons_colorhelpers_p.h
  src/fonts/kfontutils.cpp
  src/fonts/kfontutils.h
  src/text/kdatevalidator.cpp
  src/text/kdatevalidator.h
  src/text/kwordwrap.cpp
  src/text/kwordwrap.h
  src/util/kiconutils.cpp
  src/util/kiconutils.h
  src/util/kimagecache.h
  src/util/klocalimagecacheimpl.cpp
  src/util/klocalimagecacheimpl.h
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfo.h
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h
  src/util/urlhandler.cpp
  tests/kmodifierkeyinfotest.cpp
  tests/openurltest.cpp

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Nathaniel Graham]

ngraham added a comment.


  One thing I notice other platforms do is to make the panel  more opaque when 
there's a maximized window up against it. That resolves the issue of a 
translucent panel reflecting the wallpaper color in a way that's jarringly 
different from pop-ups that appear on top of window content.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27141: Drop Policykit backend

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:4d241b3f4f54: Drop Policykit backend (authored by 
davidedmundson).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27141?vs=74953=75400

REVISION DETAIL
  https://phabricator.kde.org/D27141

AFFECTED FILES
  src/ConfigureChecks.cmake
  src/backends/dbus/org.kde.kf5auth.conf
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/policykit/kauth-policy-gen-polkit.cpp

To: davidedmundson, lbeltrame
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a subscriber: KDevelop.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for feedback, sounds good, so we are 2 already. Now curious about more 
opinions.
  Though when I said "crude hacking" I really meant it ;) So sadly nothing to 
seriously upload. This need some qualified icon drawing person do get the 
proper roundings, diagonals and proportions done. Also to decide whether to 
align the "!" and the "i" vertically or not, given the narrow top of the 
warning triangle shape asks to add more internal top margin to not blend into 
the triangle borders. I would have my opinion on this, but prefer more 
experienced to do this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/163/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 10 Feb 2020 18:17:56 +
 Build duration:
3 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D27299: Vertically center tooltip icon/image

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9d27675c3b4e: Vertically center tooltip icon/image 
(authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27299?vs=75394=75398

REVISION DETAIL
  https://phabricator.kde.org/D27299

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: ngraham, #vdg, #plasma, filipf, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ndavis wrote in DefaultToolTip.qml:57
> Do you actually need Qt.AlignHCenter? Isn't there some margin setting that 
> decides how the text is placed relative to the icon?

Text isn't involved here; setting both vertical and horizontal alignment 
properties ensures that the image or icon is centered in its cell.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27288: [policy-gen] Fix the code to actually captured the correct capture group

[Ahmad Samir]

ahmadsamir edited the test plan for this revision.
ahmadsamir added a reviewer: apol.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D27288

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> DefaultToolTip.qml:57
>  visible: toolTip != null && toolTip.image != ""
> -Layout.alignment: Qt.AlignTop
> +Layout.alignment: Qt.AlignHCenter | Qt.AlignVCenter
>  }

Do you actually need Qt.AlignHCenter? Isn't there some margin setting that 
decides how the text is placed relative to the icon?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the widget tooltip's icon/image is top-aligned, which in practice 
makes it
  vertically centered when the tooltip has only one line of text, but not 
vertically
  centered when there are two lines of text.
  
  This patch makes it vertally centered all the time, improving the appearance.

TEST PLAN
  Before: F8095695: Before.png 
  
  After: F8095696: After.png 
  
  F8095697: Better everywhere.mp4 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27297: KGuiAddons: Convert license headers to SPDX statements

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R273 KGuiAddons

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27297

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/162/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 10 Feb 2020 17:43:11 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetest

D27297: KGuiAddons: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add license text files in LICENSES
  folder as required by the REUSE specification.
  
  License clarification of kguiaddons/tests/openurltest.cpp given in:
  https://mail.kde.org/pipermail/kde-frameworks-devel/2020-February/103423.html

REPOSITORY
  R273 KGuiAddons

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27297

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/kiconutilstest.cpp
  autotests/kiconutilstest.h
  autotests/kwordwraptest.cpp
  src/colors/kcolorcollection.cpp
  src/colors/kcolorcollection.h
  src/colors/kcolormimedata.cpp
  src/colors/kcolormimedata.h
  src/colors/kcolorspaces.cpp
  src/colors/kcolorspaces_p.h
  src/colors/kcolorutils.cpp
  src/colors/kcolorutils.h
  src/colors/kguiaddons_colorhelpers_p.h
  src/fonts/kfontutils.cpp
  src/fonts/kfontutils.h
  src/text/kdatevalidator.cpp
  src/text/kdatevalidator.h
  src/text/kwordwrap.cpp
  src/text/kwordwrap.h
  src/util/kiconutils.cpp
  src/util/kiconutils.h
  src/util/kimagecache.h
  src/util/klocalimagecacheimpl.cpp
  src/util/klocalimagecacheimpl.h
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfo.h
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h
  src/util/urlhandler.cpp
  tests/kmodifierkeyinfotest.cpp
  tests/openurltest.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27297: KGuiAddons: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27297

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27292: set the share comment as UDS_COMMENT for the UI to display

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug105086

REVISION DETAIL
  https://phabricator.kde.org/D27292

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27296: [PlasmaComponents]Clean up ListItem code

[George Vogiatzis]

gvgeo created this revision.
gvgeo added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Removed two unused lines.
  Removed old comments.
  Minor style changes to comments.

TEST PLAN
  Everything must stay unchanged visually and function wise for ListItems.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27296

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

To: gvgeo, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27292: set the share comment as UDS_COMMENT for the UI to display

[Harald Sitter]

sitter added a comment.


  We talked about this on telegram and what Kai is thinking of may be the mime 
comment. Upon review UDS_COMMENT (or KFileItem::comment()) seems to simply not 
be modeled in dolphin. The model has a Comment column but as far as I can tell 
the data for that column is never set, which explains why dolphin doesn't show 
the comment even when enabling the relevant column in the details view.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27292

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Filip Fila]

filipf added a comment.


  Right, I also noticed the color-aware theme now has somewhat more pronounced 
discrepancy between the panel and the popups when dark color schemes are used.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27247: Unify the look of all icons containing  (no sign)

[Matej Mrenica]

mthw updated this revision to Diff 75389.
mthw added a comment.


  Changes to "font-disable" and "mail-mark-junk" are now included too.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75334=75389

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/mail-mark-junk.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/mail-mark-junk.svg
  icons-dark/actions/24/mail-mark-junk.svg
  icons-dark/actions/32/mail-mark-junk.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/mail-mark-junk.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/mail-mark-junk.svg
  icons/actions/24/mail-mark-junk.svg
  icons/actions/32/mail-mark-junk.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Noah Davis]

ndavis added a comment.


  In D27122#608443 , @niccolove 
wrote:
  
  > Using Background for panels would break the visual integration with 
dialogs, so I would avoid doing that.
  >
  > Regarding panel popups / dialogs; I'm already working on the toparea patch 
- https://phabricator.kde.org/D27189 - but I was thinking, the problem with 
using Background is the controls on top of it e.g. kickoff search. Since the 
transparency makes the background color not as gray, the only problem is when 
things are opaque (I remember we talked about this in the VDG chat). Now, 
*there is* a version of Breeze opaque in the breeze/opaque/ directory which is 
used when compositing is disabled. For that one, I did leave 
ColorScheme-Background, so the problem is not there when the actual opaque 
version is used. I think that people who want things to be 100% opaque will 
install a theme rather than manually editing the svg, so they would not have 
that problem as well. That isn't to say that I won't work on the top area, just 
that I would not make the this patch dependent on it.
  >
  > I also tried to tweak the intensity value to make the normal 
ColorScheme-Background fine, but I did not have any success. It seems like it's 
not a color which manages to work in this usecase, while 
ColorScheme-ViewBackground is okay.
  
  
  This is really about how this fits with our color scheme system, not so much 
about the aesthetics of transparency and blur. If you need different colors 
from normal to get this to look right, how will it look when you use other 
different colors? How does this look with color schemes besides Breeze and 
Breeze Dark (e.g., Arc Dark, Materia Dark)? If it only works properly with 
Breeze/Breeze Dark because ViewBackground is a lighter/darker color, this isn't 
going to work for all color schemes. You'll end up having to use a custom 
colors file anyway (as in Breeze Light/Dark desktop themes) to guarantee that 
everything will look right.
  
  Now that I've had the chance to try this patch, I can some issues. Even if 
you use a custom colors file, it seems this patch only looks right when there 
are no windows open, which doesn't seem realistic.
  
  Arc Dark: F8095615: Screenshot_20200210_114242.PNG 

  
  Materia Dark: F8095604: Screenshot_20200210_113801.PNG 

  
  Nordic-Darker: F8095606: Screenshot_20200210_113950.PNG 

  
  Even Breeze Dark has trouble: F8095608: Screenshot_20200210_114056.PNG 

  
  That's not to say the current situation is perfect, but the color difference 
isn't so stark (Breeze Dark): F8095617: Screenshot_20200210_114353.PNG 

  
  Light themes don't really have this problem, but dark themes have a big 
problem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27272: Add status icons: data-error, data-warning, data-information

[Nathaniel Graham]

ngraham added a comment.


  Those don't look too bad. :) Wanna submit them?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27247: Unify the look of all icons containing  (no sign)

[Nathaniel Graham]

ngraham added a comment.


  sure, good idea!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27292: set the share comment as UDS_COMMENT for the UI to display

[Kai Uwe Broulik]

broulik added a comment.


  The comment will be shown in the status bar when hovering a file.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27292

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27295: smb: support more advanced hidden file flag

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  smb attaches different meaning to the +x flags of files to represent DOS
  style flags. read them and hide hidden files. we currently have no
  KIO backing for the others but for documentation purpose I've mentioned
  them in detail so we can extend this in the future without having
  to descend into samba docs.
  
  FIXED-IN: 19.12.3
  BUG: 307353

TEST PLAN
  - set jpgs hidden as described in bug report
  - they are now hidden in dolphin

REPOSITORY
  R320 KIO Extras

BRANCH
  bug307353

REVISION DETAIL
  https://phabricator.kde.org/D27295

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27294: fix free space calculation

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - collapse statvfs call, there's no purpose in manually opening the file when 
libsmbc has a convenience wrapper that does exactly what we need with less code 
on our end
  - blockSize is now calculated as per the conditional branches in smbc_stat.c
  - free space calculation is now backwards compatible with slightly busted 
legacy versions of libsmbc not setting f_bavail
  
  FIXED-IN: 19.12.3
  BUG: 298801

TEST PLAN
  free space calculation now works with windows10, ubuntu18.04, ubuntu19.10

REPOSITORY
  R320 KIO Extras

BRANCH
  bug298801

REVISION DETAIL
  https://phabricator.kde.org/D27294

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27293: smb: do not map uid and gid

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  libsmbc returns the uid/gid of the process, not of the file, the data
  is entirely useless to us. do not list it.
  currently there is no way to get the actual uid/gid of a dirent. internally
  there seems to be tech available that uses the samba unix extension but
  that doesn't have any public API.
  
  in short: we can't determine ownership client-side
  
  BUG: 212801

TEST PLAN
  no longer shows current user as owner. in particular when that is not true!

REPOSITORY
  R320 KIO Extras

BRANCH
  bug212801

REVISION DETAIL
  https://phabricator.kde.org/D27293

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27292: set the share comment as UDS_COMMENT for the UI to display

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  currently this seems to not really have any visibility through dolphin
  so concluding the fix also requires changes to dolphin to enable the
  comment somewhere. it is technically a column in the details view but
  that doesn't actually seem to work
  
  CCBUG: 105086

TEST PLAN
  hoping for the best in absence of a UI!

REPOSITORY
  R320 KIO Extras

BRANCH
  bug105086

REVISION DETAIL
  https://phabricator.kde.org/D27292

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To give an example what I would expect proper Breeze status icons to look 
like, get an idea of me doing crude hacking to turn the emblem variants into 
something matching the style guide for status icons:
  adding in-icon margins & removing the explicit contrast outline:
  F8095572: KDevelop using new data status icons.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27291: install smb as both smb:// and cifs://

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 160 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/160/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 10 Feb 2020 15:50:20 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D27215: add vvave icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  vvave (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27215

To: mbruchert, #vdg, camiloh, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68a273aef6c1: Make the attached property a simple QObject 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27200?vs=75133=75383#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27200?vs=75133=75383

REVISION DETAIL
  https://phabricator.kde.org/D27200

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml

To: mart, bshah, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Re: License Clarification for kguiaddons/tests/openurltest.cpp

[Aleix Pol]

Hi Andreas,
I'm happy with it having whatever license is more appropriate within
the framework. You suggestion makes sense to me.

Aleix

On Sat, Feb 8, 2020 at 4:43 PM Andreas Cord-Landwehr
 wrote:
>
> Hi Aleix,
>
> I found the file kguiaddons/tests/openurltest.cpp with an ambiguous license
> statement about both LGPL and GPL. According to the license header, you are
> the only copyright holder and a review of the file authors resulted in only
> minor contributions by others.
>
> Can you clarify the file license? With a look at the other files in the test
> folder, the best fitting license would be
>
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
>
> to be consistent.
>
> Cheers,
> Andreas
>
>

D27291: install smb as both smb:// and cifs://

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the latter while not IANA registered is apparently used in places. to
  cheaply support it we now configure the protocol file for both protocol
  'smb' and 'cifs' and installing two protocol files. they are still both
  backed by the same plugin and otherwise the same.
  code-wise this also required adjustments to the URL validation tech as
  it has hardcoded checks for smb schemes.
  
  FIXED-IN: 19.12.3
  BUG: 327295

TEST PLAN
  - cifs://host/share
  - cifs://host
  - cifs://
  
  all open correctly. they do get translated to smb because of the checkUrl 
code.
  
  checkUrl seems entirely pointless, SMBUrl does a bit of validation/fixing as 
part of
  updateCache. It occurs to me checkUrl should simply be incorporated into 
SMBUrl
  and we should construct an SMBUrl where we previously called checkUrl. before 
doing
  anything of value we construct SMBUrls anyway, so the isolated logic does 
absolutely
  nothing SMBUrl couldn't do just as well. also needs a unit test -.- ... too 
much 
  refactoring for a bugfix though

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb_browse.cpp
  smb/kio_smb_internal.cpp
  smb/smb.protocol
  smb/smb.protocol.cmake

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27247: Unify the look of all icons containing  (no sign)

[Matej Mrenica]

mthw added a comment.


  I also made adjustments to "font-disable" and "mail-mark-junk", do you want 
me to include them? After that all icons containing  will be the same.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

Frameworks 5.67 re-spin request

[Nate Graham]

Hello frameworks packagers,
I hate to have to make this request, bug could we get Frameworks 5.67 
re-spun to include these two commits:


https://cgit.kde.org/kirigami.git/commit/?id=f695cde36a6829b8b92b2fd82deff16d9385fcb9

https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=6995b4ae81a2f3ca3c24d2fa6d1560bfe0898737

These commits fix highly user-visible issues with scrollbars in 
QML-based apps, most notably Discover.


I've been told that most LTS distros are planning to ship Plasma 5.18 
with Frameworks 5.67, so if that version doesn't include these fixes, 
then Plasma 5.18 LTS users will be stuck with the issues for years and 
we'll get a ton of bug reports.


Thanks in advance for the consideration!

Nate

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos added a comment.


  Note: extra space (right fill) is not computed correctly if tabs are used for 
line indentation.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26118: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D26118#608935 , @broulik wrote:
  
  > This appears to have broken policy file generation. The polkit files I now 
get have
  >
  >   Neues Plymouth-Design 
installieren
  >
  >
  > Note the "Name" in the `xml:lang`
  
  
  Right. Should be fixed by D27288 . I 
counted wrongly, QRegExp::capturedTexts(1) is 
QRegularExpressionMatch::captured(1) not captured(0)...

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D26118

To: ahmadsamir, #frameworks, mlaurent, dfaure, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27288: [policy-gen] Fix the code to actually captured the correct capture group

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This was a mistake in porting form QRegExp::capturedTexts() to 
QRegularExpression;
  capturedTexts(1) translates to QRegularExpressionMatch::captured(1), not 0.
  
  Thanks to brouilk for reporting it in https://phabricator.kde.org/D26118.
  
  TODO: add unit test to catch this

TEST PLAN
  make && ctest

REPOSITORY
  R283 KAuth

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[René J . V . Bertin]

rjvbb added a comment.


  >   This is a MacBook Pro Retina, 13-inch, Mid 2014 with macOS 10.15.2 with 
only this one disk. It's clearly not supposed to get removed, imo :)
  
  Indeed. The icon shown is for internal disks.
  
  Thanks for drawing attention to this, I'm going to have to look into things.
  
  Is it possible that PCIe drives are mounted over something other than SATA (I 
don't see any mention of that bus in the UDI, and IIRC I do on my own 2011 Mac 
that still uses 2.5" drives.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27284: [polkit-1] Simplify Polkit1Backend action exists lookup

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:3a7a57c33453: [polkit-1] Simplify Polkit1Backend action 
exists lookup (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27284?vs=75357=75363#toc

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27284?vs=75357=75363

REVISION DETAIL
  https://phabricator.kde.org/D27284

AFFECTED FILES
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h

To: davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27283: [polkit-1] Return an error status in actionStatus if there is an error

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:d80fdb8966a0: [polkit-1] Return an error status in 
actionStatus if there is an error (authored by davidedmundson).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27283?vs=75356=75362

REVISION DETAIL
  https://phabricator.kde.org/D27283

AFFECTED FILES
  src/backends/polkit-1/Polkit1Backend.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos added a comment.


  This is an example with right fill of 3 characters, left fill off, with 
indentation lines (note that they spend all visual lines of the dynamically 
wrapped line).
  
  F8095407: image.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos created this revision.
eudoxos added a reviewer: VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
eudoxos requested review of this revision.

REVISION SUMMARY
  The configuration UI is somewhat clumsy, some better arrangement suggestion 
would be welcome.
  There are still more options on the radar, such as showing the "broken-line" 
character also
  optionally indented (now is shown left with line numbers) and others.

REPOSITORY
  R39 KTextEditor

BRANCH
  dynwrap-marker (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27285

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katelinelayout.cpp
  src/render/katelinelayout.h
  src/render/katerenderer.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: eudoxos, #vdg
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26118: Port QRegExp to QRegularExpression

[Kai Uwe Broulik]

broulik added a comment.


  This appears to have broken policy file generation. The polkit files I now 
get have
  
Neues Plymouth-Design 
installieren
  
  Note the "Name" in the `xml:lang`

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D26118

To: ahmadsamir, #frameworks, mlaurent, dfaure, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27284: [polkit-1] Simplify Polkit1Backend action exists lookup

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  kauth_fixup

REVISION DETAIL
  https://phabricator.kde.org/D27284

To: davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[Milian Wolff]

mwolff added a comment.


  In D27065#608920 , @rjvbb wrote:
  
  > How do you connect? The Mac OS has a built-in VNC server but it has to be 
activated. Once it is you should be able to connect using any VNC client 
(possibly using ssh tunnelling?).
  
  
  Yes, I'm connected via VNC and ssh.
  
  > You can configure the Finder to show every connected volume on the desktop, 
IIRC it used to be the default that it shows everything. Should be in the 
Preferences that you can find under the application menu (the one immediately 
to the right of the Apple icon/menu).
  
  F8095364: mac_disks.png 
  
  > Can you please ask the owner how that drive is connected? The SM0256F is a 
PCIe drive; according to 
https://www.anandtech.com/show/9136/the-2015-macbook-review/8 `In the 2013 
MacBook Air 13” for example the drive model was “SM0256F”`.
  
  This is a MacBook Pro Retina, 13-inch, Mid 2014 with macOS 10.15.2 with only 
this one disk. It's clearly not supposed to get removed, imo :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[René J . V . Bertin]

rjvbb added a comment.


  How do you connect? The Mac OS has a built-in VNC server but it has to be 
activated. Once it is you should be able to connect using any VNC client 
(possibly using ssh tunnelling?).
  
  You can configure the Finder to show every connected volume on the desktop, 
IIRC it used to be the default that it shows everything. Should be in the 
Preferences that you can find under the application menu (the one immediately 
to the right of the Apple icon/menu).
  
  Can you please ask the owner how that drive is connected? The SM0256F is a 
PCIe drive; according to 
https://www.anandtech.com/show/9136/the-2015-macbook-review/8 `In the 2013 
MacBook Air 13” for example the drive model was “SM0256F”`.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks, rjvbb, cgilles
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Simply linking the emblem icons is in any case a first cheap shot. So far I 
am hoping for someone fluent with icon designing who could take a look at the 
at the rules for status icons ( 
https://hig.kde.org/style/icons/action_status.html ) and give the Breeze-style 
typical in-icon margins as well as the system’s color pick-up logic.
  
  As fallback I would try to do this myself, but that takes ages for me :) And 
given error/warning/info are simple common shapes, I would hope the in-house 
artists do that for breakfast :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Like @davidre said. Abusing emblem icons would be a not-nice hack, those 
icons serve a different purpose and thus also follow different rules (e.g. 
being able to be painted on top of complex backgrounds).  We want to use icons 
whose names and type are semantically correct, not pick names of icons whose 
current appearance in the Breeze theme comes close to what looks okay.
  
  Another candidate for the new icons would be e.g. in cells of tables or other 
dense forms where one wants to mark an error/warning/info state 
in-line/in-cell, see e.g. KMyMoney's current usage of some own custom icon:
  F8095290: KMyMoney-cell-warning.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27283: [polkit-1] Return an error status in actionStatus if there is an error

[David Edmundson]

davidedmundson added a dependent revision: D27284: [polkit-1] Simplify 
Polkit1Backend action exists lookup.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D27283

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns