D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  So I think this is ready to be merged and I would do so this weekend

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  T10413 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  What's the phab task you filed about this again? I can't find it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 311 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/311/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 21 Feb 2020 04:42:11 +
 Build duration:
8 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34808/62086)40%
(17700/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9726/10183)47%
(4548/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8730/14619)51%
(4524/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8329)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 303 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/303/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 21 Feb 2020 04:42:12 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 436 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/436/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 21 Feb 2020 04:42:12 +
 Build duration:
5 min 49 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34797/62086)40%
(17686/43872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9726/10183)47%
(4546/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8727/14619)51%
(4517/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8329)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4288)36%
(1300/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D27245: Ki18n: Convert license headers to SPDX statements

[Friedrich W. H. Kossebau]

kossebau added a comment.


  What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root 
directory? Could that not be removed given the new copy 
`LICENSES/LGPL-2.1-only.txt`?
  Or are both copies required? If so, why? Similar question also for any other 
repo.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/110/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 21 Feb 2020 01:49:37 +
 Build duration:
1 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D27535: Add XdgOutputV1 version 2

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM

INLINE COMMENTS

> xdgoutput_interface.cpp:319
> +}
> +if (wl_resource_get_version(d->resource) < 
> ZXDG_OUTPUT_V1_DESCRIPTION_SINCE_VERSION) {
> +return;

noob question: what would happen if you didn't have this check?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27535

To: davidedmundson, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27535: Add XdgOutputV1 version 2

[David Edmundson]

davidedmundson updated this revision to Diff 76077.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27535?vs=76076=76077

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/registry.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27535: Add XdgOutputV1 version 2

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Will be useful for making plasma widgets not move about
  on multi monitor. QtWayland already supports it

TEST PLAN
  Unit test

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27535

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/registry.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kateviewhelpers.cpp:1963
>  const int s = qMin(m_iconAreaWidth * 
> devicePixelRatioF(), h * devicePixelRatioF()) - 2;
> -px_mark = px_mark.scaled(s, s, 
> Qt::KeepAspectRatio, Qt::SmoothTransformation);
> +QPixmap px_mark = markIcon.pixmap(s);
> +px_mark.setDevicePixelRatio(devicePixelRatioF());

Possibly `QIcon::paint()` might be also working here as wanted? Needs someone 
with HiDPI to check if all things behave as wanted. The old code with all the 
`devicePixelRatioF()` made me change not too much here.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Alexander Saoutkin]

feverfew added a comment.


  Ok I've commandeered this on request, as we're so close to getting this done. 
I've simply addressed sitter's comments here seeming as they're simple enough 
to do so without understanding the code that well. I haven't actually tested 
this in any capacity, as again, I'm not too familiar with this code and what 
it's trying to accomplish. If someone could point me in the correct direction 
I'll test as well.
  
  Also the way Phab has parsed this diff looks odd to me. It claims there's 
been a copy between two of  the files but looking locally this hasn't happened 
AFAICT (and I definitely didn't intend so). I also did a `git diff` before `arc 
diff` and I didn't notice anything odd there. Could someone do a sanity check 
for me in that regard?

INLINE COMMENTS

> sitter wrote in AuthBackend.h:61
> I wonder if we should change that. Right now every backend gets a QBA copy 
> even when they don't need to modify it. So it sounds to me like it should be 
> const& and the mac backend should make a copy on its stack. Not that it 
> matters a great deal though, so if you disagree that's fine too.

Looking at the code your intuition was correct, i.e. none of the QBAs were 
modified, so I've switched to const &

> sitter wrote in DBusHelperProxy.cpp:102
> We need to be backwards compatible here. As far as I can tell this is where 
> we call the actual helper binary. The helper binary may have been built with 
> an older version of kauth, so it doesn't necessarily understand the new API.
> 
> You could call org.freedesktop.DBus.Introspectable to figure out which method 
> arguments it supports, or possibly the simpler approach is to could with new 
> arguments and if that results in org.freedesktop.DBus.Error.InvalidArgs try 
> again with old arguments before giving up.

Done as requested. Note three's a blocking call in the slot, but I'm assuming 
(for simplicity's sake) that's ok. LMK if otherwise.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added a comment.


  See e.g. how bookmark mark symbols become crisp in bigger sizes (though they 
take advantage currently in being mostly regular lines and thus partially cope 
with pixelscaling):
  F8116357: Screenshot_20200221_003940.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Submitting Grantlee as a KF5 Framework

[Friedrich W. H. Kossebau]

Hi Daniel,

Am Donnerstag, 20. Februar 2020, 22:14:29 CET schrieb Daniel Nicoletti:
> Yes, an user just raised an issue which I fixed in one PR,
> however the PR is 5yo, should I redo it in gitlab?
> Shouldn't the GitHub repo be removed or marked as moved to KDE?

Seems you missed that Grantlee for now returned to be github-only-based 
independent project, only planning to join KDE & KDE Frameworks for KF6.

See https://marc.info/?l=kde-frameworks-devel=157757468828735=2 for the 
announcement of plan changes.

So any patches for Grantlee need to be done and provided via Github again.

Cheers
Friedrich

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added a comment.


  https://invent.kde.org/kde/kate/merge_requests/68 would be the respective 
patch for Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Kate, KDevelop.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Symbols used for marks can be used in different sizes, e.g. depending of the
  line height, to which the icon border adapts, or for the context menu on
  actions to toggle those marks. Being limited to set a single pixmap as
  symbol for a mark results can result in badly scaled symbols being
  displayed.
  Switching to QIcon as dynamic pixmap provider for markers improves this.
  
  For backward compatibility QIcon & QPixmaps are converted into each other in
  case APIs are used mixed.
  
  Currently this is WIP as KDevelop as user of the mark interfaces partially
  relies on providing a single pixmap only, and while taking the pixmaps from
  QIcons does some QIcon::Mode-based rendering (for breakpoints, marking
  disabled, reached, pending or normal ones) or color-tinting (marking line
  removal/addition in patch display with positive & negative colors) before
  passing the pixmaps on. I am not yet sure whether to
  a) turning all those processings into explisit separate dedicatd icons
  
(my favourite)
  
  b) adding some additional rendering flags to marks
  is the best approach.
  
  If going for a), this patch would be final as is.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/markinterface.h
  src/search/katesearchbar.cpp
  src/view/kateviewhelpers.cpp

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27520: add readdirplus2 support for samba>=4.12

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM but please wait for @asn's undoubtedly more expert review. :)

REPOSITORY
  R320 KIO Extras

BRANCH
  readdirplus2

REVISION DETAIL
  https://phabricator.kde.org/D27520

To: sitter, ngraham, asn
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  In D27508#614856 , @ngraham wrote:
  
  > Removing the monochrome system-help icon is what's needed to fix 417879, 
though. If we can't do that, then we can't fix the bug.
  
  
  We're back to needing to solve the fundamental technical issue with Breeze 
Icons. Removing or adding icons isn't going to fix it. We've got to create a 
way to force apps to use monochrome icons when we want to use them and I don't 
know how to do that. Alternatively, we could redesign Breeze to work better 
with the XDG spec, but I don't have the time, creativity or drive to create 
tons of good replacement icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham added a comment.


  Removing the monochrome system-help icon is what's needed to fix 417879, 
though. If we can't do that, then we can't fix the bug.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Alexander Saoutkin]

feverfew updated this revision to Diff 76073.
feverfew added a comment.


  - add const &

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=76071=76073

BRANCH
  arcpatch-D21795

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

Re: Banning QNetworkAccessManager

[Albert Astals Cid]

El dijous, 20 de febrer de 2020, a les 14:29:47 CET, Allen Winter va escriure:
> On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote:
> > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va 
> > escriure:
> > > Additionally, improved documentation, a possible KNAM and/or driving the 
> > > QNAM 
> > > changes upstream can still be done alongside this obviously.
> > 
> > Also for Qt5 which will probably never be changed a clazy warning and 
> > making it easy to run clazy on gitlab CI would be great.
> > 
> 
> Krazy has a checker for QNetworkAccessManager use in Qt4 code.
> I could add a checker for Qt5 code if someone tells me what to look for
> (not that many people look at krazy reports. couldn't hurt. might help.

There's other ways to do it, but i guess we could start with something that 
checks for this?

https://community.kde.org/Policies/API_to_Avoid#QNetworkAccessManager

Cheers,
  Albert

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Alexander Saoutkin]

feverfew updated this revision to Diff 76071.
feverfew marked 4 inline comments as done.
feverfew added a comment.


  - Rebase
  - Respond to sitter's comments

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=63880=76071

BRANCH
  arcpatch-D21795

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Alexander Saoutkin]

feverfew commandeered this revision.
feverfew added a reviewer: chinmoyr.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

Re: Submitting Grantlee as a KF5 Framework

[Daniel Nicoletti]

Yes, an user just raised an issue which I fixed in one PR,
however the PR is 5yo, should I redo it in gitlab?
Shouldn't the GitHub repo be removed or marked as moved to KDE?

Em sáb., 21 de dez. de 2019 às 10:23, Friedrich W. H. Kossebau <
kosse...@kde.org> escreveu:

> Hi Stephen,
>
> Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> > Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> >
> > I've pushed a few commits to make it depend on ECM etc.
>
> You pushed only to github though it seems :) Forwarded your commits now to
> the
> master branch on the main KDE repo. And did some commits to make things
> even
> more (current) KF-like.
>
> Speaking of making sure all is synced & moved from github to KDE systems:
>
> There are still some merge requests open on https://github.com/steveire/
> grantlee/pulls . Also are
> there some open issues which might be wanted to be
> moved over to bugs.kde.org?
>
> Cheers
> Friedrich
>
>
>

-- 
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo added a comment.


  After some digging, I found that KBookmarkGroup has more items that the 
KFilePlacesModel.
  It is impossible to make `KBookmark` move at the end of a `BookmarkGroup`, if 
the item is not in the `KFilePlacesModel`.
  I don't see a better solution than the current revision of the patch. 
(Assuming that my proposed change of using null as first item is acceptable.)
  
index: KBookmarkGroup -> KFilePlacesModel
0 :  "Home" -> "Home"
1 :  "Desktop" -> "Desktop"
2 :  "Network" -> "Trash"
3 :  "Trash" -> "Downloads"
4 :  "Recent Files" -> "kde"
5 :  "Recent Locations" -> "config"
6 :  "Modified Today" -> "Templates"
7 :  "Modified Yesterday" -> "Sync"
8 :  "Documents" -> "Pictures"
9 :  "Images" -> "Network"
10 :  "Audio" -> "Recent Files"
11 :  "Videos" -> "Recent Locations"
12 :  "--- separator ---" -> "--- separator ---"
13 :  "--- separator ---" -> "--- separator ---"
14 :  "--- separator ---" -> "--- separator ---"
15 :  "--- separator ---" -> "--- separator ---"
16 :  "--- separator ---" -> "--- separator ---"
17 :  "Downloads"
18 :  "kde"
19 :  "config"
20 :  "--- separator ---"
21 :  "--- separator ---"
22 :  "Templates"
23 :  "Sync"
24 :  "--- separator ---"
25 :  "Pictures"
26 :  "--- separator ---"
27 :  "--- separator ---"
28 :  ""

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella added a comment.


  Thanks for the patch, makes sense.
  
  Please make the commit message a bit more elaborate

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Jonah Brüchert]

jbbgameich added reviewers: nicolasfella, vkrause.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  Couple of screenshots more from this patch:
  
  F8115905: Screenshot_20200220_194559.png 

  F8115907: Screenshot_20200220_194611.png 

  F8115910: Screenshot_20200220_194622.png 

  F8115913: Screenshot_20200220_194636.png 

  F8115915: Screenshot_20200220_194647.png 

  F8115917: Screenshot_20200220_194703.png 

  F8115919: Screenshot_20200220_194714.png 

  F8115921: Screenshot_20200220_194724.png 

  F8115923: Screenshot_20200220_194734.png 

  F8115925: Screenshot_20200220_194745.png 

  F8115927: Screenshot_20200220_194756.png 

  F8115929: Screenshot_20200220_194817.png 

  F8115931: Screenshot_20200220_194829.png 

  F8115933: Screenshot_20200220_194840.png 

  F8115936: Screenshot_20200220_194854.png 

  F8115939: Screenshot_20200220_194904.png 

  F8115941: Screenshot_20200220_194915.png 

  F8115943: Screenshot_20200220_194926.png 

  F8115946: Screenshot_20200220_194939.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto created this revision.
cacahueto added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cacahueto requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added a comment.


  In D27444#614762 , @mart wrote:
  
  > - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  > - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet
  
  
  Regarding these two points:
  
  - This patch already provides a single svg with top and bottom areas
  - When there is a top panel, the idea is to place the top area at the bottom, 
like Kickoff currently dynamically places the user avatar and name on the side 
far from the panel. The toparea should never touch the panel, imo.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  i also wonder if the normal "toolbar2 element already existing can be used..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  some considerations:
  
  - this toparea will need to "overflow" its parent for the exact distance 
needed to perfectly fuse with the background, and has to work with both dialogs 
and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the 
exact same shape) for this reason also fallback should be disabled and be used 
only in themes that directly provide it.
  - we need 2 margins here: how much we want to overflow, which i would say 
should be the actual framesvg margins, so one doesn't have to *ever* access the 
dialog instance or the applet background, and the margins we want to actually 
use as padding for its contents. we can decide either to put both as hints in 
the svg, or to use units.smallspacing as padding for the contents and be happy 
with it
  - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27527: Add new `smiley-add` icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  FEATURE: 417298
  FIXED-IN: 5.68

TEST PLAN
  F8115850: smiley-add.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  smiley-add-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27527

AFFECTED FILES
  icons-dark/actions/16/smiley-add.svg
  icons-dark/actions/22/smiley-add.svg
  icons/actions/16/smiley-add.svg
  icons/actions/22/smiley-add.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.14/11/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 20 Feb 2020 16:55:45 +
 Build duration:
1 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectrootC_.CI.Job_Build Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

Re: Banning QNetworkAccessManager

[Nicolás Alvarez]

El jue., 20 de feb. de 2020 a la(s) 10:30, Allen Winter
(win...@kde.org) escribió:
>
> On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote:
> > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va 
> > escriure:
> > > Additionally, improved documentation, a possible KNAM and/or driving the 
> > > QNAM
> > > changes upstream can still be done alongside this obviously.
> >
> > Also for Qt5 which will probably never be changed a clazy warning and 
> > making it easy to run clazy on gitlab CI would be great.
> >
>
> Krazy has a checker for QNetworkAccessManager use in Qt4 code.
> I could add a checker for Qt5 code if someone tells me what to look for
> (not that many people look at krazy reports. couldn't hurt. might help.

I started making a checker for this based on clang-static-analyzer.
Looks like clazy uses a different approach altogether by looking at
ASTs alone, so I don't think I can integrate into that...

-- 
Nicolás

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.14/10/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 20 Feb 2020 14:41:19 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectrootC_.CI.Job_Build Failed: 3 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectrootC_.CI.Job_Build.autotests.BarChartFailed: projectrootC_.CI.Job_Build.autotests.LineChartFailed: projectrootC_.CI.Job_Build.autotests.PieChart

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Aleix Pol Gonzalez]

apol added a comment.


  +1 code looks much better!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27520: add readdirplus2 support for samba>=4.12

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, asn.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  unlike the dirent itering we do not need a separate stat call with this
  new api by instead itering on what are effectively stat-like objects.
  
  this simply runs before the regular itering which we still use to list
  shares and workgroups. browse_stat_path has been split into stat and
  udsentry-construction-from-stat so it can be used across both code
  paths.
  
  fun fact on the side: if there actually was a stat() api that returned
  libsmb_file_info, we could use that as well and forget about the stats
  structs in general :S
  
  BUG: 402988
  FIXED-IN: 20.04.0

TEST PLAN
  - build samba 4.12 rc
  - list server
  - list share
  - list dir in share
  
  - on 4.7
  - all of the above

REPOSITORY
  R320 KIO Extras

BRANCH
  readdirplus2

REVISION DETAIL
  https://phabricator.kde.org/D27520

AFFECTED FILES
  smb/CMakeLists.txt
  smb/config-smb.h.cmake
  smb/kio_smb.h
  smb/kio_smb_browse.cpp

To: sitter, ngraham, asn
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Re: Banning QNetworkAccessManager

[Allen Winter]

On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote:
> El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va 
> escriure:
> > Additionally, improved documentation, a possible KNAM and/or driving the 
> > QNAM 
> > changes upstream can still be done alongside this obviously.
> 
> Also for Qt5 which will probably never be changed a clazy warning and making 
> it easy to run clazy on gitlab CI would be great.
> 

Krazy has a checker for QNetworkAccessManager use in Qt4 code.
I could add a checker for Qt5 code if someone tells me what to look for
(not that many people look at krazy reports. couldn't hurt. might help.

D27463: KconfigXT: Add a value attribute to Enum field choices

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigXmlParser.cpp:203
> If you don't mind I am putting aside the second part as it is not directly 
> related to this PR, i.e name attribute validation. (FYI we had 
> KConfigXmlParser::validateNameAndKey)

I guess there are more problematic characters. IMO this is not the right place, 
you pointed `validateNameAndKey()` which seems to be a better choice to 
implement such checks.

BTW, this is not related to this PR.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27497: Fix code generation for entries with min/max

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me

INLINE COMMENTS

> test_param_minmax.h.ref:25
> +  {
> +qDebug() << "setFoo: value " << v << " is less than the minimum 
> value of 0.01";
> +v = 0.01;

We probably should not output anything or at least let the user give logging 
context to the debug output.
This is not about this review though.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76040.
meven marked an inline comment as done.
meven added a comment.


  Warn user about / . : being forbidden in choice's attribute name

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=75969=76040

BRANCH
  arcpatch-D27463

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> bport wrote in KConfigXmlParser.cpp:203
> Can we do a test on more than '  ' value, proably solve other case.
> And we probably want to limit what is a correct value, any string seems a bit 
> too large, some character can be problematic when we write back to config 
> file.

If you don't mind I am putting aside the second part as it is not directly 
related to this PR, i.e name attribute validation. (FYI we had 
KConfigXmlParser::validateNameAndKey)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> KConfigXmlParser.cpp:203
>  }
> +else if (choice.name.contains(QLatin1Char(' '))) {
> +std::cerr << "Tag  attribute 'name' cannot contain a 
> space. You can use attribute 'value' to pass any string as the choice value." 
> << std::endl;

Can we do a test on more than '  ' value, proably solve other case.
And we probably want to limit what is a correct value, any string seems a bit 
too large, some character can be problematic when we write back to config file.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

Re: Banning QNetworkAccessManager

[Volker Krause]

On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote:
> On Wed, Feb 19, 2020 at 9:30 PM Volker Krause  wrote:
> > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote:
> > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause  wrote:
> > > > I agree on the problem of QNAM's default, see also
> > > > https://conf.kde.org/en/
> > > > akademy2019/public/events/135 on that subject.
> > > > 
> > > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote:
> > > > [...]
> > > > 
> > > > > Prior to now, i've taken the approach of advertising that
> > > > > QNetworkAccessManager is broken and needs a flag set within
> > > > > applications when used, however unfortunately this seems to have
> > > > > been
> > > > > an ineffective approach and cases of broken behaviour continue to
> > > > > appear (despite this brokeness being known about and advertised
> > > > > since
> > > > > back in the Qt 4.x series when this class was introduced)
> > > > > 
> > > > > Therefore, given the Qt Project is unlikely to change their position
> > > > 
> > > > > on this, I would like to propose the following:
> > > > The Qt Project is actually in favor of changing at least the
> > > > redirection
> > > > default to exactly what we want it to be.
> > > > https://codereview.qt-project.org/c/qt/qtbase/+/273175 has the change,
> > > > and
> > > > got approval both by Lars and one of the maintainers. It is merely
> > > > stuck
> > > > in dealing with the unit test fallout in Qt's CI that somebody has to
> > > > take care of. Doesn't immediately help us of course, but claiming Qt
> > > > is
> > > > unwilling to change this is simply wrong.
> > > > 
> > > > > 1) That effective immediately, QNetworkAccessManager and it's
> > > > > children
> > > > > classes be banned and prohibited within KDE software, to be enforced
> > > > > by server side hooks.
> > > > > 2) That we fork QNetworkAccessManager and the associated classes
> > > > > within the appropriate Framework (to be determined), where the
> > > > > defective behaviour can then be corrected.
> > > > 
> > > > While this might solve the redirection problem, it brings us yet
> > > > another
> > > > then unmaintained HTTP implementation next to the one in KIO, which is
> > > > a
> > > > far bigger problem long term. We need less of those, not more.
> > > > 
> > > > To address the problem of people not using the correct defaults, I did
> > > > propose a much less extreme approach in the above mentioned talk at
> > > > Akademy, namely having a KNetworkAccessManager as a sub-class of QNAM
> > > > in
> > > > a low-tier frameworks that essentially just enables redirects and
> > > > HSTS.
> > > > QNAM's implementation isn't the problem after all, the defaults are.
> > > > 
> > > > Commit hooks warning about QNAM usage might still be a good idea, but
> > > > as a
> > > > warning only. Hard blocking QNAM-using code would block at least three
> > > > repos I spend a lot of time on currently, none of which even talks to
> > > > KDE
> > > > servers.
> > > > 
> > > > If you need to take more drastic measures against code not doing this
> > > > correctly regardless, you can do that my dropping the server-side
> > > > workarounds. Yes, that would break the affected application possibly,
> > > > but
> > > > at least it would not cause massive collateral damage for the people
> > > > using this correctly.
> > > > 
> > > > It would also help to know where specifically we have that problem, so
> > > > we
> > > > can actually solve it, and so we can figure out why we failed to fix
> > > > this
> > > > there earlier.
> > > 
> > > Just bringing this up again - it seems we've not had much movement on
> > > this aside from the Wiki page.
> > > 
> > > Examining that Qt merge request, it not only is targeted at just Qt
> > > 6.x, it also hasn't had any movement since the start of October 2019 -
> > > 4 months ago.
> > > Given that we are going to be on Qt 5.x for some time, that merge
> > > request can't be considered to be the 'fix' for this issue.
> > 
> > The targeting of Qt6 is due to this aiming at dev when that was still Qt
> > 5.x, but you are right of course, somebody needs to do the work there to
> > drive this to completion, no matter in which version it will actually
> > land.
> 
> Indeed.
> 
> > > We need a solution that will ensure software released today doesn't
> > > cause us pain in several years time, because as I illustrated in an
> > > earlier email to this thread, software has a habit of remaining in use
> > > for an extremely long amount of time (August 2014 being the release
> > > date of the Marble versions in question hitting that old URL).
> > > 
> > > The easiest path forward is to simply ban QNetworkAccessManager.
> > 
> > That might be the easiest path for you, but certainly not for me, given
> > two of the modules I work on most atm are using QNAM (not even to talk to
> > KDE infrastructure), and would suddenly no longer be allowed to be hosted
> > here?
> Ideally they 

D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  I don't know what hotspot is used for, but the other ones are probably used 
by 3rd party apps. The virt-manager and system-help icons are definitely used 
by 3rd party apps in places where monochrome icons should be.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

[Méven Car]

meven accepted this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Fixing QNetworkAccessManager use

[Ben Cooksley]

On Thu, Feb 20, 2020 at 2:09 AM Friedrich W. H. Kossebau
 wrote:
>
> Am Mittwoch, 19. Februar 2020, 08:05:01 CET schrieb Ben Cooksley:
> > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause  wrote:
> > > It would also help to know where specifically we have that problem, so we
> > > can actually solve it, and so we can figure out why we failed to fix this
> > > there earlier.
> >
> > Just bringing this up again - it seems we've not had much movement on
> > this aside from the Wiki page.
>
> The wiki page currently still just recommends to set
> "networkAccessManger->setAttribute(QNetworkRequest::FollowRedirectsAttribute,
> true);"
>
> Which seems simple, but possible not what is enough in all cases.
>
> So my open questions here to be able to act on code I contribute to are:
>
> a) What about the mentioned QNetworkRequest::NoLessSafeRedirectPolicy, in
> which cases should that be used and when not?

For interacting with download.kde.org / files.kde.org, I would advise
against using this policy, as they will in virtually all instances
redirect to mirrors (who don't support https and are http only)

>
> b) What about the HSTS stuff, when is that recommended?

That should be enabled yes.

>
> c) What is a sane number for QNetworkRequest::maximumRedirectsAllowed?

5 to 10 redirects is a relatively sane number I would expect. At the
most I would expect our servers to issue a maximum of 3 redirects in a
given chain of URLs.
If it is longer than that then we are doing something wrong.

>
> Both in general and when it comes to KDE servers.
>
> Personally I am still unsure what the actual issue is. Why are redirects
> needed at all. Why all the address changes all the time? The "U" in
> "URL"/"URI" is for "uniform", not "unstable", isn't it ;)

Please see my other email regarding this.

>
> Can you give some examples for URLs of resources our code uses on KDE servers,
> and why they needed to change?

Get Hot New Stuff functionality (Gen 1), originally using a static
file tree under http://download.kde.org/khotnewstuff/
This needed to change for two reasons:
1) Mandatory HTTPS
2) The benefit of having these files mirrored, considering their
extremely small size and declining client base (KDE 3 and parts of KDE
4) was negligible and creating more load on our systems to support the
mirroring process than we got in terms of benefit of having them
mirrored. We therefore transitioned to serving these through a CDN.

Get Hot New Stuff functionality (Gen 2), originally using a dynamic
web service at http://newstuff.kde.org/ and http://data.kstuff.org/
needed to change for two reasons:
1) Mandatory HTTPS
2) The dynamic web service had not been updated in several years, and
was dependent on a very specific system setup we hadn't been able to
replicate and needed to decomission due to it's age. We therefore
needed to convert it to static files, and arrange for those to be
hosted elsewhere in our systems. newstuff.kde.org now converts the
requests sent to it to redirects to specific static files to keep
applications using it working (which includes KF5 era applications who
still actively use this and in at least one case continue to be
released using this)

Get Hot New Stuff functionality (Gen 3), originally used a file at
http://download.kde.org/ocs/providers.xml (now at
https://autoconfig.kde.org/ocs/providers.xml)
This needed to change for two reasons:
1) Mandatory HTTPS
2) It was necessary for non-sysadmins (particularly those involved in
running store.kde.org) to be able to update the file directly. As the
server hosting download.kde.org is sensitive and doesn't support
deploying changes from Git when they are committed, we had to move the
file to a different subdomain which could support this.

Marble maps, originally hosted under http://download.kde.org/ and
later at http://files.kde.org/marble/maps/ and now at
https://maps.kde.org/,
This need to be moved for couple of reasons:
1) When we transitioned download.kde.org to be a mirror redirector, it
was no longer possible for us to easily host non-mirrored resources
under the same domain (and the maps weren't mirrored), requiring they
be moved to files.kde.org (which as an added benefit also made it
possible for developers to update the maps themselves)
2) Later, it was discovered that Marble performance for loading maps
using files.kde.org after it transitioned to being a mirror redirector
as well was quite poor due to the large number of http requests
involved. We therefore shifted it to a CDN based resource which
eliminated these performance issues, known as maps.kde.org.

KStars resources, originally hosted under
http://download.kde.org/apps/kstars/ needed to be moved to
https://files.kde.org/ for the following reasons:
1) Mandatory HTTPS
2) To allow developers to freely update them as needed, something
which isn't possible on download.kde.org (which is restricted due to
it hosting the master copies of tarballs)

There have also been two instances where we have been