Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- Review request for KDE Frameworks and Anthony Fieroni. Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs - src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- Ship it! Ship It! - Anthony Fieroni On Март 14, 2017, 11:16 след обяд, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 14, 2017, 11:16 след обяд) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to limit CPU usage or to discard it? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On March 14, 2017, 11:16 p.m., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated March 14, 2017, 11:16 p.m.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- Ship it! Ship It! - Matthieu Gallien On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! KFileMetaData being in use by itself, IMHO Baloo problematics should not block this correction. - Matthieu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. I almost forgot to ask an automatic test for your fix. Please do not ship without it. - Matthieu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix. Please do not ship > without it. You can see that current tests do not cover the line you are modifying: https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/ . - Matthieu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On Март 15, 2017, 8:55 д.п., Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix. Please do not ship > without it. > > Matthieu Gallien wrote: > You can see that current tests do not cover the line you are modifying: > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/ > . Unfortunately, I've got not that much experience in writing autotests... I think the proper test that would have revealed that problem would be actually a test for ExtractorCollection::fetchExtractors (just check some more or less obvious mimetypes and see that correct plugins are returned). If you think this is fine, I can see how other tests are done and then add one. - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 14, 2017, 9:16 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask an automatic test for your fix. Please do not ship
> without it.
>
> Matthieu Gallien wrote:
> You can see that current tests do not cover the line you are modifying:
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/
> .
>
> Igor Poboiko wrote:
> Unfortunately, I've got not that much experience in writing autotests...
>
> I think the proper test that would have revealed that problem would be
> actually a test for ExtractorCollection::fetchExtractors (just check some
> more or less obvious mimetypes and see that correct plugins are returned).
> If you think this is fine, I can see how other tests are done and then
> add one.
Thanks for taking care of that bug.
Do not feel scared, there are already tests that may get you started. I am also
very happy to help if I can.
In the current automatic tests, you will see that there are example files in
the samplefiles directory. There is even one called plain_text_file.txt.
You can have a look at any of the tests called
extractortest.{h|cpp}. They may provide you inspiration.
Let me know if I can help you.
- Matthieu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102851
---
On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130013/
> ---
>
> (Updated mars 14, 2017, 10:16 après-midi)
>
>
> Review request for KDE Frameworks and Anthony Fieroni.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see
> https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer
> matches ANY of the text/ mimetypes.
> This broke completely Baloo indexing e.g. simple plain text files.
> Introduced check however allows to provide "text/plain" as supported mimetype
> for the extractor and hope that everything containing plain text will be
> inherited from it.
>
>
> Diffs
> -
>
> src/extractors/plaintextextractor.cpp 26e1247
>
> Diff: https://git.reviewboard.kde.org/r/130013/diff/
>
>
> Testing
> ---
>
> KFileMetaData compiles.
> Baloo indexes plain text files.
> Everybody is happy.
>
>
> Thanks,
>
> Igor Poboiko
>
>
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? I didn't see much performance issues; and from what can I see, DB size didn't change much after reindexing, so there is no redundant extractors as far as I can see. Concerning performance - I don't believe there is much overhead too much I think we should instead use profilers to find bottlenecks. I don't think it is one of them. - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 14, 2017, 9:16 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what can I see, DB size > didn't change much after reindexing, so there is no redundant extractors as > far as I can see. > Concerning performance - I don't believe there is much overhead too much > I think we should instead use profilers to find bottlenecks. I don't think it > is one of them. One more test, if i'm not too cheeky, please consider to have files like epub or svg i.e. complex mime types. For this types we have surely more than one extractor who can reflect on db size and cpu time. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On March 14, 2017, 11:16 p.m., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated March 14, 2017, 11:16 p.m.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated Март 16, 2017, 8:33 п.п.) Review request for KDE Frameworks and Anthony Fieroni. Changes --- Added new test for ExtractorCollection. As for now, it simply checks if collection finds an extractor for known (text/plain) mimetype, and doesn't find anything for a-priory incorrect mimetype. Also removed unused include (otherwise test should have been linked with KI18N, which is actually not needed). Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs (updated) - autotests/CMakeLists.txt 5ab742b autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what can I see, DB size > didn't change much after reindexing, so there is no redundant extractors as > far as I can see. > Concerning performance - I don't believe there is much overhead too much > I think we should instead use profilers to find bottlenecks. I don't think it > is one of them. > > Anthony Fieroni wrote: > One more test, if i'm not too cheeky, please consider to have files like > epub or svg i.e. complex mime types. For this types we have surely more than > one extractor who can reflect on db size and cpu time. Funny thing: I didn't manage to find any type with more than one extractor. SVG is matched only by PlainTextExtractor (apparently, the only extractor working with images is Exiv2Extractor, which doesn't support svg), and EPUB is matched only by EPubExtractor (apparently, internally it is zip-archive and there is no extractors working with archives). Anyways, if two extractors got the same DocTerm some file, Baloo won't save it twice, it saves only unique terms. And if they extract different terms - well, it gives more chances to match users search, which is even better! I also tried indexing whole /usr/share/icons directory, with lots of svg icons - well, I didn't see a change (again, subjectively: I didn't use profilers). Apparently, extraction takes considerably much more time that iterating over bunch of mimetypes per file (~100?). - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On Март 16, 2017, 8:33 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 16, 2017, 8:33 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > autotests/CMakeLists.txt 5ab742b > autotests/extractorcollectiontest.cpp PRE-CREATION > src/externalextractor.cpp 05f0645 > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask an automatic test for your fix. Please do not ship
> without it.
>
> Matthieu Gallien wrote:
> You can see that current tests do not cover the line you are modifying:
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/
> .
>
> Igor Poboiko wrote:
> Unfortunately, I've got not that much experience in writing autotests...
>
> I think the proper test that would have revealed that problem would be
> actually a test for ExtractorCollection::fetchExtractors (just check some
> more or less obvious mimetypes and see that correct plugins are returned).
> If you think this is fine, I can see how other tests are done and then
> add one.
>
> Matthieu Gallien wrote:
> Thanks for taking care of that bug.
>
> Do not feel scared, there are already tests that may get you started. I
> am also very happy to help if I can.
> In the current automatic tests, you will see that there are example files
> in the samplefiles directory. There is even one called plain_text_file.txt.
> You can have a look at any of the tests called
> extractortest.{h|cpp}. They may provide you inspiration.
>
> Let me know if I can help you.
Thanks for having taken care of automatic test.
I had a more general look at the exitsing tests with plain_text_file.txt. They
are completely like the other automatic tests like taglib, the extractor is
hardcoded. No way they would detect the bug you are fixing.
If nobody beats me to it, I will try to fix that problem soon.
As far as I am concerned, please push your fix.
- Matthieu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102851
---
On mars 16, 2017, 9:33 après-midi, Igor Poboiko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130013/
> ---
>
> (Updated mars 16, 2017, 9:33 après-midi)
>
>
> Review request for KDE Frameworks and Anthony Fieroni.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see
> https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer
> matches ANY of the text/ mimetypes.
> This broke completely Baloo indexing e.g. simple plain text files.
> Introduced check however allows to provide "text/plain" as supported mimetype
> for the extractor and hope that everything containing plain text will be
> inherited from it.
>
>
> Diffs
> -
>
> autotests/CMakeLists.txt 5ab742b
> autotests/extractorcollectiontest.cpp PRE-CREATION
> src/externalextractor.cpp 05f0645
> src/extractors/plaintextextractor.cpp 26e1247
>
> Diff: https://git.reviewboard.kde.org/r/130013/diff/
>
>
> Testing
> ---
>
> KFileMetaData compiles.
> Baloo indexes plain text files.
> Everybody is happy.
>
>
> Thanks,
>
> Igor Poboiko
>
>
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated March 17, 2017, 8:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Anthony Fieroni. Changes --- Submitted with commit f9c8bb29b2cf5d46ff68c0261393084d1ff16ece by Igor Poboiko to branch master. Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs - autotests/CMakeLists.txt 5ab742b autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
