Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Sat, Mar 11, 2017 at 3:47 AM, Edward K. Ream  wrote:

> On Fri, Mar 10, 2017 at 11:02 PM, lewis  wrote
> ​:
>

I've made a mini "@theme ekr light" node that contains my "light"
> settings.  There are just nodes in the theme
>

​Oops, I should have said, there are just *two* nodes in the theme...

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Fri, Mar 10, 2017 at 11:02 PM, lewis  wrote:

> I have exactly the same myLeoSettings.leo file on 2 PC's both running
> commit = 51b3d984000e. The selected theme is 'base dark theme'.
>
> On Vista PC with Python 3.5.2, PyQt version 5.6.0 installed, the theme is
> dark all over as expected.
>
> However on win10 PC with Python 3.6.0, PyQt version 5.8.0 installed, the
> outline pane and body panes have a *light background*.  If I select a
> menu bar item, the text displayed is not readable - almost no contrast.
>

​This happens to me when I forget to disable settings that conflict with
the theme's settings.

The last node of my myLeoSettings.leo file is called "Themes, if any". A
clone of this node appears as the last top-level node of the file.  It
contains all the themes that I am testing.  All but one of those @theme
nodes start with @ignore.

I've made a mini "@theme ekr light" node that contains my "light"
settings.  There are just nodes in the theme, a user style sheet (@data
qt-gui-user-style-sheet) and @string focused-border-unfocus-color =
@solarized-base2

Whenever there is a mystery with themes, use the print-style-sheet command
to see what settings are in effect. The Leo code that composes that style
sheet inserts comments at the head of both the main and user style sheets,
so you can see which settings came from which @data node.

HTH.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

I have exactly the same myLeoSettings.leo file on 2 PC's both running 
commit = 51b3d984000e. The selected theme is 'base dark theme'.

On Vista PC with Python 3.5.2, PyQt version 5.6.0 installed, the theme is 
dark all over as expected.

However on win10 PC with Python 3.6.0, PyQt version 5.8.0 installed, the 
outline pane and body panes have a *light background*.  If I select a menu 
bar item, the text displayed is not readable - almost no contrast.

This has happened this several times over the last few days but I haven't 
reported it as the themes have been changing so often. So I have used 
identical myLeoSettings.leo files to rule out any other effects.
Is this possibly something similar to the issue 436 
 raised by alacnorr ?

Regards
Lewis

On Friday, March 10, 2017 at 11:33:39 PM UTC+11, Edward K. Ream wrote:

>
> ​Everything works for me on my Windows 10 machine.
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Fri, Mar 10, 2017 at 4:24 AM, lewis  wrote:

> Running 'windows ekr dark theme' if I select a menu bar item, the text
> displayed is not readable unless I place cursor over it. e.g. Help> about
> Leo
> the text is a very light grey on an even lighter background
>

​Everything works for me on my Windows 10 machine.

Your stylesheet looks ok to me.  There are no @-constants that haven't been
resolved.

I would suggest removing/disabling the QWidget entry first, and then
playing around with various settings.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

Running 'windows ekr dark theme' if I select a menu bar item, the text 
displayed is not readable unless I place cursor over it. e.g. Help> about 
Leo
the text is a very light grey on an even lighter background - no contrast 
is the problem.

So from 'windows ekr dark theme'
this is the console output from the 'print-style-sheet' command:

** isPython3: True
Leo 5.4, build 20170309174318, Thu Mar  9 17:43:18 CST 2017
Git repo info: branch = master, commit = d1ca44fd68a5
Python 3.6.0, PyQt version 5.8.0
Windows 10 AMD64 (build 10.0.14393) SP0
style sheet for: ...


/* = From qt-gui-plugin-style-sheet = */

/*
@language css
windows leo_dark theme: a minor modification of leo_dark theme 0.
*/
/* = active pane highlighting = */
QTextEdit#log-widget,
LeoQTreeWidget#treeWidget,
QTextEdit#richTextEdit {
border-color:   #073642;
border-style:   solid;
border-width:   5px;
}
QTextEdit:focus#log-widget,
LeoQTreeWidget:focus#treeWidget,
QTextEdit:focus#richTextEdit {
border-color:   red;
}
QTextEdit:hover#log-widget,
LeoQTreeWidget:hover#treeWidget,
QTextEdit:hover#richTextEdit {
border-color: @focused-border-hover-color;
}
/* = The body pane = */
QTextEdit#richTextEdit {
background-color:   #002b36;
color:  #839496;
font-family:DejaVu Sans Mono;
font-size:  14pt;
font-weight:normal; /* normal,bold,100,..,900 */
font-style: normal; /* normal,italic,oblique */
selection-color:#002b36;
selection-background-color: #b58900;
}
/* = bookmarks plugin styling = */
#show_bookmarks QPushButton {
margin: 0; padding: 1; border: none;
font-size: 11pt;
color: #839496;
font-weight: regular;
text-decoration: @bookmarks_base_decoration;
}
#show_bookmarks QPushButton[style_class~='bookmark_children'] {
font-size: ignore;
color: #839496;
font-weight: ignore;
text-decoration: underline;
}
#show_bookmarks QPushButton[style_class~='bookmark_expanded'] {
font-size: ignore;
color: #839496;
font-weight: bold;
text-decoration: underline;
}
#show_bookmarks QPushButton[style_class~='bookmark_current'] {
font-size: ignore;
color: #cb4b16;
font-weight: bold;
text-decoration: ignore;
}
/* = Buttons = */
QPushButton {
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
color:  #839496;
}
QPushButton:hover {
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
color:  #002b36;
}
/* = Log panes = */
QTextEdit#log-widget {
background-color:   #073642;
color:  #93a1a1;
font-family:DejaVu Sans Mono;
font-size:  14pt;
font-style: normal; /* normal, italic,oblique */
font-weight:normal; /* normal,bold,100,..,900 */
selection-background-color: blue;
selection-color:white;
}
/* = Menues = */
QMenu {
color:  #eee8d5;
}
QMenu::item:selected {
color:  #002b36;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
}
QMenuBar::item {
color:  #839496;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
}
QMenuBar::item:selected {
color:  #002b36;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
}
QMenuBar::item:pressed {
color:  #eee8d5;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
}
/* = Mini-buffer = */
QLineEdit#lineEdit {
color:  #b58900;
background-color:   #002b36;
font-family:DejaVu Sans Mono;
font-size:  12pt;
font-weight:normal; /* normal,bold,100,..,900 */
font-style: normal; /* normal,italic,oblique */
selection-color:red;
selection-background-color: lightgrey;
}
QLabel#minibufferLabel {
color:  #6c71c4;
}
QLineEdit#lineEdit[style_class ~= 'minibuffer_warning'] {
background-color:   #073642;
}
QLineEdit#lineEdit[style_class ~= 'minibuffer_error'] {
color:  #dc322f;
background-color:   #073642;
}
/* = Status line = */
QLineEdit#status1,
QLineEdit#status2
{
background-color:   #002b36;
border-color:   #073642;
border-style:   solid;
border-width:   1px;
}
/* = Scroll bars = */
QScrollBar::horizontal {
height: 7px;
}
QScrollBar::vertical {
width: 7px;
}
QScrollBar::add-page,
QScrollBar::sub-page {
background: #002b36;
}
QScrollBar::handle {
background: #586e75;
color:  #586e75;
}
QScrollBar::handle:hover {
background:   #839496;
color:#839496;
}
/* to make these show up, remove the ::handle style above... bug? */
QScrollBar::add-line,
QScrollBar::sub-line 

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thu, Mar 9, 2017 at 3:29 PM, lewis  wrote:

> Sorry, which theme would you like me to run 'print-style-sheet' on?
>

​The theme that doesn't look right.  But I don't want to support the old
"ekr dark" theme.

Please use the new "@theme windows ekr dark theme" node instead. That has a
much better chance of working.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

Sorry, which theme would you like me to run 'print-style-sheet' on?

Lewis

*On Friday, March 10, 2017 at 2:40:12 AM UTC+11, Edward K. Ream wrote:*
>
>
> *On Thu, Mar 9, 2017 at 7:25 AM, lewis  > wrote:*
>
>>
>> *Using leo_dark theme 0,  this is the console output from the 
>> 'print-style-sheet' command:*
>>
>
> *​Not sure this helps, because this is not the problem theme.*
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thursday, March 9, 2017 at 9:40:12 AM UTC-6, Edward K. Ream wrote:

BTW, rev 16e8ab1 adds a comment to all theme style sheets so we can tell 
> where they came from.
>

Let's consider the old ekr stylesheet to be dead. Please report any 
problems with the new  @theme windows ekr dark theme.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thu, Mar 9, 2017 at 11:27 AM, Terry Brown  wrote:

- I think it's bad form for themes to use @data qt-gui-user-style-sheet,
> that should be solely for the use of the user.
>

​I agree.  The new "​windows ekr dark theme" uses the main style sheet.
​​



> - Particularly in Ubunutu getting consistent theme appearance is tough,
> because it depends on the user's desktop settings.  Are the using Gnome or
> KDE, what desktop theme are they using, etc. etc.
>

​It's tough everywhere. A new pattern may help, as I'll explain in a new
thread.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Terry Brown]

[New email: I'm transitioning from my yahoo email to my gmail email, so
this is the address I intend to use going forward.]

These are just tangential comments:

 - I think it's bad form for themes to use @data qt-gui-user-style-sheet,
that should be solely for the use of the user.  Sure the user can paste
their stuff on the end, but shouldn't need to, themes should be more
swappable than that.  If themes want to build of the default style sheet
they can either copy the whole thing, or we need a @data
qt-gui-theme-style-sheet which is added to the default style-sheet.  Or
maybe some setting for a theme to indicate that it's entries should be
appended to the default style sheet rather than replacing it.

- Particularly in Ubunutu getting consistent theme appearance is tough,
because it depends on the user's desktop settings.  Are the using Gnome or
KDE, what desktop theme are they using, etc. etc.

Cheers -Terry

On Thu, Mar 9, 2017 at 9:40 AM, Edward K. Ream  wrote:

> On Thu, Mar 9, 2017 at 7:25 AM, lewis  wrote:
>
>> Using leo_dark theme 0,  this is the console output from the
>> 'print-style-sheet' command:
>>
>
> ​Not sure this helps, because this is not the problem theme.
>
> Anyway, the ekr_dark theme is a special case because it only sets the user
> stylesheet, ​
>
> ​@data qt-gui-user-style-sheet, not the main stylesheet, @data
> qt-gui-plugin-style-sheet.
>
> I guess the thing to do is to use the main stylesheet, like all other
> themes.  I'll do this next.
>
> BTW, rev 16e8ab1 adds a comment to all theme style sheets so we can tell
> where they came from.
>
> Edward
>
> --
> You received this message because you are subscribed to the Google Groups
> "leo-editor" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to leo-editor+unsubscr...@googlegroups.com.
> To post to this group, send email to leo-editor@googlegroups.com.
> Visit this group at https://groups.google.com/group/leo-editor.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thu, Mar 9, 2017 at 7:25 AM, lewis  wrote:

> Using leo_dark theme 0,  this is the console output from the
> 'print-style-sheet' command:
>

​Not sure this helps, because this is not the problem theme.

Anyway, the ekr_dark theme is a special case because it only sets the user
stylesheet, ​

​@data qt-gui-user-style-sheet, not the main stylesheet, @data
qt-gui-plugin-style-sheet.

I guess the thing to do is to use the main stylesheet, like all other
themes.  I'll do this next.

BTW, rev 16e8ab1 adds a comment to all theme style sheets so we can tell
where they came from.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

Correction - the pic dark_theme_2.jpg is actually a shot of leo_dark theme 
1. This is indicated by the white menu bar.
Apologies if it confused anyone.

On Thursday, March 9, 2017 at 5:14:38 PM UTC+11, lewis wrote:
>
> screenshots below
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

Using leo_dark theme 0,  this is the console output from the 
'print-style-sheet' command:

Git repo info: branch = master, commit = 203fc8e10b05
Python 3.6.0, PyQt version 5.8.0
Windows 10 AMD64 (build 10.0.14393) SP0
style sheet for: ...


/* = From qt-gui-plugin-style-sheet = */

/*
@language css
*/
/* = active pane highlighting = */
QTextEdit#log-widget, LeoQTreeWidget#treeWidget, QTextEdit#richTextEdit {
border-color:   white;
border-style:   solid;
border-width:   3px;
}
QTextEdit:focus#log-widget, LeoQTreeWidget:focus#treeWidget, 
QTextEdit:focus#richTextEdit {
border-color:   blue;
}
QTextEdit:hover#log-widget, LeoQTreeWidget:hover#treeWidget, 
QTextEdit:hover#richTextEdit {
border-color: @focused-border-hover-color;
}
/* = The body pane = */
QTextEdit#richTextEdit {
font-family: DejaVu Sans Mono; /* font-family: Courier New; */
font-size: 16pt;
font-weight: normal; /* normal,bold,100,..,900 */
font-style: normal; /* normal,italic,oblique */
background-color: #002b36;
color: #839496; /* bodytextforegroundcolor; */
selection-color: #002b36;
selection-background-color: #b58900;
}
/* = bookmarks plugin styling = */
#show_bookmarks QPushButton {
margin: 0; padding: 1; border: none;
font-size: 11pt;
color: #839496;
font-weight: regular;
text-decoration: @bookmarks_base_decoration;
}
#show_bookmarks QPushButton[style_class~='bookmark_children'] {
font-size: ignore;
color: #839496;
font-weight: ignore;
text-decoration: underline;
}
#show_bookmarks QPushButton[style_class~='bookmark_expanded'] {
font-size: ignore;
color: #839496;
font-weight: bold;
text-decoration: underline;
}
#show_bookmarks QPushButton[style_class~='bookmark_current'] {
font-size: ignore;
color: #cb4b16;
font-weight: bold;
text-decoration: ignore;
}
/* = Buttons = */
QPushButton {
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
color:  #839496;
}
QPushButton:hover {
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
color:  #002b36;
}
/* = Log panes = */
QTextEdit#log-widget {
background-color:   #073642; /* solarized dark */
color:  #93a1a1; /* solarized dark */
font-family:DejaVu Sans Mono; /* font-family: Courier New; */
font-size:  16pt;
font-style: normal; /* normal, italic,oblique */
font-weight:normal; /* normal,bold,100,..,900 */
selection-background-color: blue;
selection-color:white;
}
/* = Menues = */
QMenu {
color:  #eee8d5;
}
QMenu::item:selected {
color:  #002b36;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
}
QMenuBar::item {
color:  #839496;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
}
QMenuBar::item:selected {
color:  #002b36;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #657b83, 
stop:0.4 #839496, stop:0.6 #839496, stop:0.9 #657b83);
}
QMenuBar::item:pressed {
color:  #eee8d5;
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 #002b36, stop:0.9 #073642);
}
/* = Mini-buffer = */
QLineEdit#lineEdit {
color:  #b58900;
background-color:   #002b36;
font-family:DejaVu Sans Mono;
font-size:  12px;
font-weight:normal; /* normal,bold,100,..,900 */
font-style: normal; /* normal,italic,oblique */
selection-color:red;
selection-background-color: lightgrey;
}
QLabel#minibufferLabel {
color: #6c71c4;
}
QLineEdit#lineEdit[style_class ~= 'minibuffer_warning'] {
background-color: #073642;
}
QLineEdit#lineEdit[style_class ~= 'minibuffer_error'] {
color:  #dc322f;
background-color:   #073642;
}
/* = Status line = */
QLineEdit#status1 {
background-color:   #002b36;
border-color:   #073642;
border-style:   solid;
border-width:   1px;
}
QLineEdit#status2 {
background-color:   #002b36;
border-color:   #073642;
border-width:   1px;
border-style:   solid;
}
/* = Scroll bars = */
QScrollBar::horizontal {
height: 7px;
}
QScrollBar::vertical {
width: 7px;
}
QScrollBar::add-page, QScrollBar::sub-page {
background: #002b36;
}
QScrollBar::handle {
background: #586e75;
color:  #586e75;
}
QScrollBar::handle:hover {
background:   #839496;
color:#839496;
}
/* to make these show up, remove the ::handle style above... bug? */
QScrollBar::add-line, QScrollBar::sub-line {
background:   #586e75;
color:#586e75;
}
/* = Splitters = */
QSplitter::handle {
background-color: #586e75;
}
QSplitter::handle:hover {
background-color: #6c71c4;
}
/* = Tab bar = */
QTabBar::tab {
margin-right: 5px;
padding: 2px;
}
QTabBar::tab {
background: qlineargradient( x1:0 y1:0, x2:0 y2:1, stop:0.1 #073642, 
stop:0.4 #002b36, stop:0.6 

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thu, Mar 9, 2017 at 12:14 AM, lewis  wrote:

> screenshots below
>

​Please ​

​do print-style-sheet and report the results.  You must be running Leo in a
console.  Thanks.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Thu, Mar 9, 2017 at 5:30 AM, Edward K. Ream  wrote:

Hmm.  That's odd.  I see:
>
> @bool use_focus_border = False
>

​It turns out that ​

​@bool use_focus_border is no longer used.​

Rev 203fc8e removes the setting and all references to it. In addition, it
adds "@ignore border trees" to various themes in leoSettings.leo.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Wed, Mar 8, 2017 at 6:20 PM, lewis  wrote:

> Hi Edward,
>
> Thanks for this work.
>
> A summary of the themes:
> EKR theme isn't working as expected. I can send a screenshot later today.
> leo_dark theme 0 - works fine red outline
>

​I assume by "red outline" you mean a "focus border".

That's controlled by:

@theme leo_dark theme 0-->settings-->style sheet settings-->border

Hmm.  That's odd.  I see:

@bool use_focus_border = False

There seems to be several problems here.  I'm investigating.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

Hi Edward,

Thanks for this work. 

A summary of the themes:
EKR theme isn't working as expected. I can send a screenshot later today.
leo_dark theme 0 - works fine red outline
leo_dark theme 1 - works fine
leo_dark theme 2 - works fine





*Leo Log WindowLeo 5.4, build 20170308152312, Wed Mar  8 15:23:12 CST 
2017Git repo info: branch = master, commit = 15894fa9ed71Python 2.7.13, 
PyQt version 4.8.7Windows 10 AMD64 (build 10.0.14393) *

I will verify on another machine also.

Regards
Lewis

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Saturday, March 4, 2017 at 8:16:50 AM UTC-6, Edward K. Ream wrote:

Now themes should be even more ready ;-)

Rev 5d6851d adds gradient settings to several themes so that now menus show 
up correctly.

All themes appear to be minimally useful at least.  Let me know if you find 
a glaring problem.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

['Terry Brown' via leo-editor]

When I tried themes last night the dark themes didn't seem to be working, 
background color wise, even with color definitions. 

Also, I'd just include all settings needed by a theme in the theme node and not 
make  users copy two things. I don't think the duplication is a problem. 

Cheers -Terry

On March 7, 2017 6:06:59 AM CST, "Edward K. Ream"  wrote:
>On Tue, Mar 7, 2017 at 5:39 AM, Edward K. Ream 
>wrote:
>
>>
>> On Mon, Mar 6, 2017 at 10:01 PM, 'Terry Brown' via leo-editor <
>> leo-editor@googlegroups.com> wrote:
>>
>>>
>>> Hi Jon.  I'm using the "@solarized-" names, and they're working ok,
>I
>>> don't think that part of the theme machinery is damaged.  But note
>that
>>> those names aren't built into Leo, they have to be defined in
>>> @settings
>>
>>
>> ​I'll make a note to that effect in leoSettings.leo and themes.leo.
>>
>
>​Done at d84a87d.
>
>Note: the changes do not affect any existing stylesheet. As explained
>in
>the top-level Themes node, if you want solarized colors, you must move
>
>Themes-->About solarized colors-->Solarized color definitions
>
>into the theme's @stylesheet tree.
>
>I'll be closing #350
>
>as soon as tree indicators work properly on Windows.
>
>Edward
>
>-- 
>You received this message because you are subscribed to the Google
>Groups "leo-editor" group.
>To unsubscribe from this group and stop receiving emails from it, send
>an email to leo-editor+unsubscr...@googlegroups.com.
>To post to this group, send email to leo-editor@googlegroups.com.
>Visit this group at https://groups.google.com/group/leo-editor.
>For more options, visit https://groups.google.com/d/optout.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Tue, Mar 7, 2017 at 5:39 AM, Edward K. Ream  wrote:

>
> On Mon, Mar 6, 2017 at 10:01 PM, 'Terry Brown' via leo-editor <
> leo-editor@googlegroups.com> wrote:
>
>>
>> Hi Jon.  I'm using the "@solarized-" names, and they're working ok, I
>> don't think that part of the theme machinery is damaged.  But note that
>> those names aren't built into Leo, they have to be defined in
>> @settings
>
>
> ​I'll make a note to that effect in leoSettings.leo and themes.leo.
>

​Done at d84a87d.

Note: the changes do not affect any existing stylesheet. As explained in
the top-level Themes node, if you want solarized colors, you must move

Themes-->About solarized colors-->Solarized color definitions

into the theme's @stylesheet tree.

I'll be closing #350 
as soon as tree indicators work properly on Windows.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Mon, Mar 6, 2017 at 10:01 PM, 'Terry Brown' via leo-editor <
leo-editor@googlegroups.com> wrote:

>
> Hi Jon.  I'm using the "@solarized-" names, and they're working ok, I
> don't think that part of the theme machinery is damaged.  But note that
> those names aren't built into Leo, they have to be defined in
> @settings


​I'll make a note to that effect in leoSettings.leo and themes.leo.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[jon h]

On 7 March 2017 at 14:01, 'Terry Brown' via leo-editor <
leo-editor@googlegroups.com> wrote:

> I'm using the "@solarized-" names, and they're working ok, I
> don't think that part of the theme machinery is damaged.  But note that
> those names aren't built into Leo, they have to be defined in
> @settings, so if you copied the @data qt-gui-plugin-style-sheet node
> without copying the section of settings that defines them, they won't
> work.
>

Hi Terry.

I was playing with it late last night (Australian time) and was thinking
that at least some of the problem seemed to be that "@solarized-"
names weren't defined in my @settings.

Thanks.
I'll try again in a few days.

/Jon

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

['Terry Brown' via leo-editor]

On Sun, 5 Mar 2017 22:28:36 -0800 (PST)
jon h  wrote:

> Hi
> 
> It's only a couple of days since I started trying to use Leo.
> Can't use it after dark until there's a dark theme working. :)
> 
> On Sunday, 5 March 2017 21:55:43 UTC+10, lewis wrote:
> >
> > The ekr_dark theme ... reloads at restart.
> > The outline and log pane retain a white background.
> 
> Same result for me.
> 
> I also tried "leo_dark theme 0", 
> and both of them persisted between restarts of Leo.
> 
> Most changes took effect as soon as I did Reload Styles.
> Qt interface changes didn't happen until Leo was restarted.
> 
> With ekr_dark, only the text pane was dark, 
> so I went back to playing with "leo_dark theme 0".
> 
> Yesterday, with dark 0, I had replaced some 
> "@solarized-" names with a #hexvalue, and they took effect.

Hi Jon.  I'm using the "@solarized-" names, and they're working ok, I
don't think that part of the theme machinery is damaged.  But note that
those names aren't built into Leo, they have to be defined in
@settings, so if you copied the @data qt-gui-plugin-style-sheet node
without copying the section of settings that defines them, they won't
work.

In my old personal settings I have them defined in their own nodes in
@settings, e.g. a node with headline

  @color solarized-yellow = #b58900

and and empty (and irrelevant) body.

According to leoSettings.leo it's also possible to define them in a
comment in the stylesheet definition, but that's only done in dark 1
and dark 2, not dark 0.

Cheers -Terry

> Today I made a simple python script to replace all of them.
> You can see the result in this screenshot (png ~250kB) :
> https://mega.nz/#!WwEjxDSK!6qxd7FxGicq37aNdzDcEfHYdzS8ONrukS1UdAP0yeC4
> 
> The log pane was properly colored, but the other tabs were not.
> As you can see, the menus were too light to read.
> 
> Anyway, it seems that the problem I had earlier
> was that "@solarized-" names do not take effect,
> but I've no idea why they don't.
> 
> A zip of the py file and the before and after leo files is attached.
> (I'm *not* suggesting anyone should make their regular theme this
> way!)
> 
> /Jon
> 
> Leo 5.4, build 20170304105326 (not in a repo)
> Python 3.6.0 in a pyenv; PyQt version 5.8.0
> Ubuntu 14.04, XFCE with an Ambiance Dark theme.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Monday, March 6, 2017 at 6:27:33 AM UTC-6, Edward K. Ream wrote:
>
> On Mon, Mar 6, 2017 at 12:28 AM, jon h  wrote:
>
> It's only a couple of days since I started trying to use Leo.
>> Can't use it after dark until there's a dark theme working. :)
>>
>
> ​Heh.  We'll see what we can do about this.​
>

I've just reopened #350: themes not working as documented 
. It will remain open 
until it's straightforward to use the canned themes.  This may involve 
fixing #62  as well. 
I'll delay 5.5b1 for as long as it takes...

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Mon, Mar 6, 2017 at 12:28 AM, jon h  wrote:

It's only a couple of days since I started trying to use Leo.
> Can't use it after dark until there's a dark theme working. :)
>

​Heh.  We'll see what we can do about this.​

Most changes took effect as soon as I did Reload Styles.
> Qt interface changes didn't happen until Leo was restarted.
>

​First, I think we should remove the instruction to do reload styles.  Best
simply to reload Leo.
​


> With ekr_dark, only the text pane was dark, so I went back to playing with 
> "leo_dark
> theme 0".
>
> Yesterday, with dark 0, I had replaced some "@solarized-" names with a
> #hexvalue, and they took effect.
>

​Good.  Could you share the script with us?  ​

​

> Today I made a simple python script to replace all of them.
> You can see the result in this screenshot (png ~250kB) :
> https://mega.nz/#!WwEjxDSK!6qxd7FxGicq37aNdzDcEfHYdzS8ONrukS1UdAP0yeC4
>
> The log pane was properly colored, but the other tabs were not.
> As you can see, the menus were too light to read.
>
> Anyway, it seems that the problem I had earlier
> ​ ​
> was that "@solarized-" names do not take effect,
> ​ ​
> but I've no idea why they don't.
> ​
> #62: Syntax @color settings don't dereference
> ​ probably applies.
> ​
>
>
A zip of the py file and the before and after leo files is attached.
> (I'm *not* suggesting anyone should make their regular theme this way!)
>

​Nor am I.  I'd like to get themes working more smoothly before 5.5b1.

Thanks for your help, Jon.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[jon h]

Hi

It's only a couple of days since I started trying to use Leo.
Can't use it after dark until there's a dark theme working. :)

On Sunday, 5 March 2017 21:55:43 UTC+10, lewis wrote:
>
> The ekr_dark theme ... reloads at restart.
> The outline and log pane retain a white background.
>

Same result for me.

I also tried "leo_dark theme 0", 
and both of them persisted between restarts of Leo.

Most changes took effect as soon as I did Reload Styles.
Qt interface changes didn't happen until Leo was restarted.

With ekr_dark, only the text pane was dark, 
so I went back to playing with "leo_dark theme 0".

Yesterday, with dark 0, I had replaced some 
"@solarized-" names with a #hexvalue, and they took effect.

Today I made a simple python script to replace all of them.
You can see the result in this screenshot (png ~250kB) :
https://mega.nz/#!WwEjxDSK!6qxd7FxGicq37aNdzDcEfHYdzS8ONrukS1UdAP0yeC4

The log pane was properly colored, but the other tabs were not.
As you can see, the menus were too light to read.

Anyway, it seems that the problem I had earlier
was that "@solarized-" names do not take effect,
but I've no idea why they don't.

A zip of the py file and the before and after leo files is attached.
(I'm *not* suggesting anyone should make their regular theme this way!)

/Jon

Leo 5.4, build 20170304105326 (not in a repo)
Python 3.6.0 in a pyenv; PyQt version 5.8.0
Ubuntu 14.04, XFCE with an Ambiance Dark theme.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.


replace_colors.py.7z
Description: application/7z-compressed

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Sun, Mar 5, 2017 at 5:55 AM, lewis  wrote:

> The ekr_dark theme works better and it reloads at restart.
> The outline and log pane retain a white background. The Find Tab has a
> dark background. I'll go back and try the leo_dark theme 1.
>

​Themes are definitely tricky.  There is a note saying that you may have to
move some settings out of the settings tree.

I know for sure that ekr_dark works on both Windows and Linux, except that
tree indicators aren't visible, per the message:

Referenced setting not found: @string tree-image-closed
Referenced setting not found: @string tree-image-open

So this is definitely a work in progress.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

running ekr_dark theme there is a 'setting not found' message in console 
output:
[snip]
reading settings in C:\Users\lewis\.leo\workbook.leo
Referenced setting not found: @string tree-image-closed
Referenced setting not found: @string tree-image-open
reading: C:\Users\lewis\.leo\workbook.leo

** isPython3: True
Leo 5.4, build 20170304105326, Sat Mar  4 10:53:26 CST 2017
Git repo info: branch = master, commit = 0f2706de85e8
[snip]

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

The ekr_dark theme works better and it reloads at restart.
The outline and log pane retain a white background. The Find Tab has a dark 
background. I'll go back and try the leo_dark theme 1.

Lewis

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[Edward K. Ream]

On Sun, Mar 5, 2017 at 2:14 AM, lewis  wrote:

> OK, to test I followed the new instructions in themes.leo. I used those
> instructions as they are the only ones which describe the new system.
>

​The same instructions also appear in the Themes node in leoSettings.leo.
​


> I deleted all existing `@data qt-gui-plugin-style-sheet` nodes in
> myLeoSettings.leo. I used the "leo_dark theme 1" node from themes.leo
>

​I didn't test that theme.  Could you try using the ​

​@theme ekr_dark theme instead? That works for me.  That way we can debug
the machinery first, and the actual themes later.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: #350: Themes are ready for serious testing

[lewis]

OK, to test I followed the new instructions in themes.leo. I used those 
instructions as they are the only ones which describe the new system.
I deleted all existing `@data qt-gui-plugin-style-sheet` nodes in 
myLeoSettings.leo. I used the "leo_dark theme 1" node from themes.leo

After I selected menu Settings>Reload Styles, the theme changed to a dark 
blue. *However* the outline pane retained it's white background. Other 
files opened in this session had the same dark theme.
Close Leo and restarted. Leo reverted to it's default style and not the 
theme I loaded.

Are the instructions in themes.leo correct?




*Leo 5.4, build 20170304105326, Sat Mar  4 10:53:26 CST 2017Git repo info: 
branch = master, commit = 0f2706de85e8Python 3.6.0, PyQt version 
5.8.0Windows 10 AMD64 (build 10.0.14393) SP0*

Regards
Lewis

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.