date:20120820

 sfx2/inc/sfx2/thumbnailview.hxx   |   10 --
 sfx2/source/control/thumbnailview.cxx |   13 -
 2 files changed, 23 deletions(-)

New commits:
commit 21a4d3cafa0f959613991b0b6777c58557ec56c1
Author: Rafael Dominguez 
Date:   Tue Aug 21 00:10:09 2012 -0430

Remove unused attributes from ThumbnailView class.

Change-Id: I4cb95d4f2f11eed332067e332bd9dfd95d119ce9

diff --git a/sfx2/inc/sfx2/thumbnailview.hxx b/sfx2/inc/sfx2/thumbnailview.hxx
index 6f0978d..a42b805 100644
--- a/sfx2/inc/sfx2/thumbnailview.hxx
+++ b/sfx2/inc/sfx2/thumbnailview.hxx
@@ -195,10 +195,6 @@ public:
 
 sal_uInt16 GetItemId( const Point& rPos ) const;
 
-sal_uInt16 GetColCount() const { return mnUserCols; }
-
-sal_uInt16 GetLineCount() const { return mnUserVisLines; }
-
 long GetItemWidth() const { return mnItemWidth; }
 
 long GetItemHeight() const { return mnItemHeight; }
@@ -319,7 +315,6 @@ protected:
 
 protected:
 
-Timer maTimer;
 ValueItemList mItemList;
 ScrollBar* mpScrBar;
 Rectangle maItemListRect;
@@ -331,15 +326,10 @@ protected:
 long mnDisplayHeight;   // Height of the data display box (name, etc)
 long mnVisLines;
 long mnLines;
-long mnUserItemWidth;
-long mnUserItemHeight;
 sal_uInt16 mnScrBarOffset;
 sal_uInt16 mnSelItemId;
 sal_uInt16 mnHighItemId;
 sal_uInt16 mnCols;
-sal_uInt16 mnCurCol;
-sal_uInt16 mnUserCols;
-sal_uInt16 mnUserVisLines;
 sal_uInt16 mnFirstLine;
 sal_uInt16 mnSpacing;
 bool mbScroll : 1;
diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index ff1b61e..6e221bb 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -89,16 +89,11 @@ void ThumbnailView::ImplInit()
 mnItemPadding = 0;
 mnVisLines  = 0;
 mnLines = 0;
-mnUserItemWidth = 0;
-mnUserItemHeight= 0;
 mnFirstLine = 0;
 mnScrBarOffset = 1;
 mnSelItemId = 0;
 mnHighItemId= 0;
 mnCols  = 0;
-mnCurCol= 0;
-mnUserCols  = 0;
-mnUserVisLines  = 0;
 mnSpacing   = 0;
 mbScroll= false;
 mbHasVisibleItems   = false;
@@ -258,15 +253,9 @@ void ThumbnailView::CalculateItemPositions ()
 if (!mnCols)
 mnCols = 1;
 
-if ( mnUserCols && mnUserCols < mnCols )
-mnCols = mnUserCols;
-
 // calculate maximum number of visible rows
 mnVisLines = (sal_uInt16)((aWinSize.Height()-mnHeaderHeight) / 
(mnItemHeight));
 
-if ( mnUserVisLines && mnUserVisLines < mnVisLines )
-mnVisLines = mnUserVisLines;
-
 // calculate empty space
 long nHSpace = aWinSize.Width()-nScrBarWidth - mnCols*mnItemWidth;
 long nVSpace = aWinSize.Height()-mnHeaderHeight - mnVisLines*mnItemHeight;
@@ -848,7 +837,6 @@ void ThumbnailView::RemoveItem( sal_uInt16 nItemId )
 // reset variables
 if ( (mnHighItemId == nItemId) || (mnSelItemId == nItemId) )
 {
-mnCurCol= 0;
 mnHighItemId= 0;
 mnSelItemId = 0;
 }
@@ -865,7 +853,6 @@ void ThumbnailView::Clear()
 
 // reset variables
 mnFirstLine = 0;
-mnCurCol= 0;
 mnHighItemId= 0;
 mnSelItemId = 0;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[GSoC] Evaluations time!

2012-08-20 Thread Cedric Bosdonnat

Hi all,

You have until Friday 24th to fill the mentor and students evaluations
here:
http://www.google-melange.com/gsoc/dashboard/google/gsoc2012#evaluations

Some of you already did it, thanks. For those who haven't done it yet,
poke me if you have troubles filing your evaluation (I can do it for you
as an admin).

--
Cedric


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSOC] Calc Performance Project End

2012-08-20 Thread Daniel Bankston


Hello, everyone,

I have had a great summer working on LibreOffice.  I was lucky to have 
two of the best mentors anyone could hope for: Kohei Yoshida and Markus 
Mohrhard.  All of my work has been guided by them and would not have 
been possible without them.  I will be a better student and software 
development professional because of my work on LibreOffice this summer.  
I hope that LibreOffice is a little better because of my work.


We were able to make some great progress on the Calc's import 
performance.  See my blog for an idea of some our achievements: 
http://dbank-libreoffice.blogspot.com/. There is still work to be done 
improving the import performance of styles, pivot tables, and more.  
Which brings me to my next point...


I have really enjoyed working on LibreOffice with my mentors and the 
LibreOffice community.  Even though GSOC is now over and I have resumed 
taking classes, I'd like to continue to work on LibreOffice when I 
can.   So I will see you all around!


Once again, thank you so much for allowing me to work with you on 
LibreOffice as a part of this year's GSOC, and thank you all for your 
continued hard work on all aspects of LibreOffice.



Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: basic/Library_sb.mk chart2/Library_chartcontroller.mk dbaccess/CppunitTest_dbaccess_macros_test.mk editeng/Library_editeng.mk formula/Library_for.mk framework/Library_fwe.mk s

 basic/Library_sb.mk  |4 
 chart2/Library_chartcontroller.mk|4 
 dbaccess/CppunitTest_dbaccess_macros_test.mk |5 -
 editeng/Library_editeng.mk   |4 
 formula/Library_for.mk   |4 
 framework/Library_fwe.mk |4 
 sc/CppunitTest_sc_annotationshapeobj.mk  |5 -
 sc/CppunitTest_sc_cellrangeobj.mk|5 -
 sc/CppunitTest_sc_chart_regression_test.mk   |5 -
 sc/CppunitTest_sc_databaserangeobj.mk|5 -
 sc/CppunitTest_sc_datapilotfieldobj.mk   |5 -
 sc/CppunitTest_sc_datapilottableobj.mk   |5 -
 sc/CppunitTest_sc_editfieldobj_cell.mk   |5 -
 sc/CppunitTest_sc_editfieldobj_header.mk |5 -
 sc/CppunitTest_sc_filters_test.mk|5 -
 sc/CppunitTest_sc_macros_test.mk |5 -
 sc/CppunitTest_sc_namedrangeobj.mk   |5 -
 sc/CppunitTest_sc_namedrangesobj.mk  |5 -
 sc/CppunitTest_sc_subsequent_filters_test.mk |5 -
 sc/CppunitTest_sc_tableautoformatfield.mk|5 -
 sc/CppunitTest_sc_tablesheetobj.mk   |3 ---
 sc/CppunitTest_sc_tablesheetsobj.mk  |3 ---
 sc/CppunitTest_sc_ucalc.mk   |6 --
 sc/Library_sc.mk |4 
 scaddins/Library_analysis.mk |4 
 scaddins/Library_date.mk |4 
 sfx2/Library_sfx.mk  |4 
 starmath/CppunitTest_starmath_qa_cppunit.mk  |2 --
 starmath/Library_sm.mk   |4 
 svtools/Library_svt.mk   |5 +
 svx/Library_svxcore.mk   |4 
 sw/CppunitTest_sw_filters_test.mk|2 --
 sw/CppunitTest_sw_swdoc_test.mk  |6 --
 sw/Library_sw.mk |4 
 vcl/Library_vcl.mk   |4 
 35 files changed, 57 insertions(+), 97 deletions(-)

New commits:
commit 9e04ae0b7d86895420634e442a09feb366340393
Author: MatÃºÅ¡ Kukan 
Date:   Mon Aug 20 22:59:40 2012 +0200

add more runtime deps on resource files for unit-tests

Change-Id: Id9bbb2bbcafe335eada3f36ae103a9074a56848f

diff --git a/basic/Library_sb.mk b/basic/Library_sb.mk
index 90cbe71..fa0e820 100644
--- a/basic/Library_sb.mk
+++ b/basic/Library_sb.mk
@@ -170,4 +170,8 @@ $(eval $(call gb_Library_add_asmobjects,sb,\
 ))
 endif
 
+# Runtime dependency for unit-tests
+$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,sb)) :| \
+   $(call gb_AllLangResTarget_get_target,sb)
+
 # vim: set noet sw=4 ts=4:
diff --git a/chart2/Library_chartcontroller.mk 
b/chart2/Library_chartcontroller.mk
index bd18379..19220da 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -213,4 +213,8 @@ $(eval $(call 
gb_Library_add_exception_objects,chartcontroller,\
 chart2/source/controller/main/UndoGuard \
 ))
 
+# Runtime dependency for unit-tests
+$(call gb_LinkTarget_get_target,$(call 
gb_Library_get_linktargetname,chartcontroller)) :| \
+   $(call gb_AllLangResTarget_get_target,chartcontroller)
+
 # vim: set noet sw=4 ts=4:
diff --git a/dbaccess/CppunitTest_dbaccess_macros_test.mk 
b/dbaccess/CppunitTest_dbaccess_macros_test.mk
index 1b7c4b4..c35ebd5 100644
--- a/dbaccess/CppunitTest_dbaccess_macros_test.mk
+++ b/dbaccess/CppunitTest_dbaccess_macros_test.mk
@@ -124,9 +124,4 @@ $(eval $(call 
gb_CppunitTest_use_filter_configuration,dbaccess_macros_test))
 
 $(eval $(call gb_CppunitTest_use_unittest_configuration,dbaccess_macros_test))
 
-# we need to
-# - explicitly depend on the dbaccess resource files needed at unit-test 
runtime
-$(call gb_CppunitTest_get_target,dbaccess_macros_test) : \
-$(WORKDIR)/AllLangRes/dbaccess \
-
 # vim: set noet sw=4 ts=4:
diff --git a/editeng/Library_editeng.mk b/editeng/Library_editeng.mk
index 81164b9..91f7e4a 100644
--- a/editeng/Library_editeng.mk
+++ b/editeng/Library_editeng.mk
@@ -156,4 +156,8 @@ $(eval $(call gb_Library_use_libraries,editeng,\
 
 $(eval $(call gb_Library_use_external,editeng,icuuc))
 
+# Runtime dependency for unit-tests
+$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,editeng)) 
:| \
+   $(call gb_AllLangResTarget_get_target,editeng)
+
 # vim: set noet sw=4 ts=4:
diff --git a/formula/Library_for.mk b/formula/Library_for.mk
index 90820c3..ce93f16 100644
--- a/formula/Library_for.mk
+++ b/formula/Library_for.mk
@@ -65,4 +65,8 @@ $(eval $(call gb_Library_add_exception_objects,for,\
 formula/source/core/resource/core_resource \
 ))
 
+# Runtime dependency for unit-tests
+$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,for)) :| \
+   $(call gb_AllLangResTarget_get_target,for)
+
 # vim: set noet sw=4 ts=4:
diff --git a/framework/Library_fwe.mk b/framework/Library_fwe.mk

Re: [Libreoffice] [GSoC 2012][svg export filter] Weekly Report #13

2012-08-20 Thread Thorsten Behrens

Marco Cecchetti wrote:
> I thanks my mentor and all the community for support.
> 
Hi Marco,

it is on us to thank you for your excellent work on svg slideshow
export!

> The only things that still doesn’t work properly, as far as I can
> see, is that hyperlinks inside animated paragraph don’t work
> properly.
>
Not a deal breaker really.

> You can look at the source code in the feature branch:
> feature/svg-export, that includes all new commits after the last
> master branch merging. The last commit is enough experimental.
> 
> Be aware that there is still a lot of debugging code in the
> current implementation and a good amount of tracing info is
> present in the exported svg document too.
> 
Although today is hard pens-down, I'd like to ask you to clean up
that branch as much as possible until code submission to Google is
due (end of the month or somesuch). Debugging code is perfectly ok,
if it's conditionally compiled, or defaults-off in javascript. And
let's merge it to master then.

A nice screencast, or demo svg with ~all the features would be cool
as well - that would complement the weekly logs quite wonderfully.

> 7- exporting embedded svg image natively, without transforming them
>into a bitmap and back.
>
Let's chat about that next week, when gsoc is over - that looks like
a nice, rewarding easy hack for you or another interested hacker in
svg export. ;)

Cheers,

-- Thorsten


pgp2PDdKZGQn7.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][REVIEW 3-6-1 1/3][PUSHED 3-6-1] resolved fdo#53325 CSV space delimiter and quoted field

2012-08-20 Thread Kohei Yoshida


On 08/20/2012 11:51 AM, Markus Mohrhard wrote:

2012/8/20 Petr Mladek :

Eike Rathke píše v Po 20. 08. 2012 v 15:34 +0200:

Hi,

Please review and cherry-pick to 3-6
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44a402d5a05dd32aa2e1ab80c9ea75b560dc3b9
that fixes https://bugs.freedesktop.org/show_bug.cgi?id=53325


Makes sense. I double checked it with several other scenarios and it
worked fine => pushed into 3-6 branch.

It looks pretty safe. It would be great to get it into 3-6-1 branch as
well. Two more approvals are needed.


Looks good to me. One more needed for 3-6-1.


Cherry-picked to 3-6-1 with my additional sign-off.

Kohei


--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6-1' - sc/source

 sc/source/ui/docshell/impex.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 76ae3173bb16f5ce4899026bb2bed109ecee6ce4
Author: Eike Rathke 
Date:   Mon Aug 20 14:38:27 2012 +0200

resolved fdo#53325 CSV space delimiter and quoted field

CSV import didn't recognize end of field if a field was quoted and the
delimiter was space.

Change-Id: I46de608d545011437fe8a298854c134d6cf54b6b
Signed-off-by: Petr Mladek 
Signed-off-by: Markus Mohrhard 
Signed-off-by: Kohei Yoshida 

diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index ab2fc5e..2957661 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -596,7 +596,10 @@ static QuoteType lcl_isFieldEndQuote( const sal_Unicode* 
p, const sal_Unicode* p
 // Due to broken CSV generators that don't double embedded quotes check if
 // a field separator immediately or with trailing spaces follows the quote,
 // only then end the field, or at end of string.
-while (p[1] == ' ')
+const sal_Unicode cBlank = ' ';
+if (p[1] == cBlank && ScGlobal::UnicodeStrChr( pSeps, cBlank))
+return FIELDEND_QUOTE;
+while (p[1] == cBlank)
 ++p;
 if (!p[1] || ScGlobal::UnicodeStrChr( pSeps, p[1]))
 return FIELDEND_QUOTE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[GSOC] PDF Signing Support - Final

2012-08-20 Thread Gökçen Eraslan

Hello all,

After the GSoC midterm, there were two remaining important objectives to
do: to write the NSS code to create a PKCS7 object (which includes the
actual signature, ecrypted SHA1 digest and the public certificate) and
to improve the PDF signing GUI (which can be seen in the experimental
mode only).

For the NSS part, first I have used the NSS PKCS7 API (secpkcs7.h and
pkcs7t.h) to create the PKCS7 object. But it was very hard for me since
NSS lacks a proper documentation[1] (the one in the header files is not
sufficient). Anyway, later on, I have decided to newer and more fine
grained NSS CMS (Cryptographic Message Syntax) API (cms.h and cmst.h).

I have followed following steps to create a PKCS7 object:

1- We need a NSS CERTCertificate structure to operate on the NSS world.
So, DER encoded certificate data is obtained via the Encoded attribute
of XCertificate[2] and converted to a CERTCertificate structure using
the CERT_DecodeCertFromPackage function.

2- SHA1 sum of the PDF file is computed using the HASH_Create,
HASH_Begin, HASH_Update and HASH_End functions[3].

3a- An empty CMS message is created using NSS_CMSMessage_Create.

3b- A SignedData is created inside the CMS message using the
NSS_CMSSignedData_Create function.

3c- Since we use a detached PKCS7 object (which means that the PKCS7
signature object contains only the signature part, excluding the data
itself) for the signing, an empty Data object is created inside the
SignedData using NSS_CMSContentInfo_SetContent_Data.

3d- Certificate chain and signer info is added to the SignedData, using
NSS_CMSSignerInfo_IncludeCerts and NSS_CMSSignedData_AddSignerInfo
respectively.

3e- SHA1 is added to the CMS message using NSS_CMSSignedData_SetDigestValue.

3f- CMS message is DER-encoded via NSS_CMSEncoder_Start and
NSS_CMSEncoder_Finish. (NSS_CMSEncoder_Update is not used since we don't
have a Data).

4- Finally, DER encoded PKCS object is converted to the HEX
representation and written to the relevant structure of the PDF which is
prepared in the earlier commits.

And for the GUI part, I have used Thunderbird certificate selection GUI
design in the PDF export dialog. Now, the selected certificate
information is printed in a disabled Edit control and users are able to
clear the selected certificate to cancel the signing operation. (I have
also used the PassWord = True property in the .src file for the
certificate password input.)

At the end of the day, however, Adobe acroread shows the PDF signatures
as invalid for some reason. But, it shows the certificate details
correctly (which was not the case when I have used the old NSS PKCS7
API). So it seems DER/HEX encodings and the inclusion of the certificate
chain are correct but there is a bug, apparently. Maybe the calculation
of SHA1 or passing the private key password to NSS is wrong. I will try
to figure it out soon.

Thanks to kendy and sberg for their devoted support in this GSoC project.

Best regards.

[1] https://developer.mozilla.org/en-US/docs/NSS/PKCS_7_functions
[2]
http://api.libreoffice.org/docs/common/ref/com/sun/star/security/XCertificate.html#Encoded
[3]
http://www.mozilla.org/projects/security/pki/nss/ref/nssfunctions.html#utils

--
Gökçen Eraslan

signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSoC 2012][Collaboration] brief status

Hi Eike,

On 20 August 2012 22:24, Eike Rathke  wrote:
> Hi Matúš,
>
> On Tuesday, 2012-08-14 19:47:37 +0200, Matúš Kukan wrote:
>
>> Well, one thing I don't like at all is that it does not work with
>> .service and .client files installed but I have no idea why and how to
>> debug it. So I am just ignoring the problem and not using the files.
>
> That's odd. Did you contact Will / #telepathy about this?

No. It was weird, seemed to work and suddenly not again..
I gave up.
This is one thing I will probably look at once again to get annoyed.

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSoC 2012][Collaboration] short final report

Hi Eike,

On 20 August 2012 22:21, Eike Rathke  wrote:
> Hi Matúš,
>
> On Monday, 2012-08-20 18:05:16 +0200, Matúš Kukan wrote:
>
>> For this GSoC I've been working on tubes framework as you surely know.
>> Started by Eike, Michael and Will [1] much was already done and I was
>> re-factoring it, adding functionality..
>
> Thank you very much for your work and patience having to bear with us :-)

:-)

>> Hope this helps and feel free to contact me for any hints.
>> (The documentation in tubes/ may not be that good)
>
> I hope this didn't scare you away and you'll continue to work on tubes
> functionality also after GSoC ended.

I meant that my comments are not good ( / existing).
I've added only few in 2bb73133df604f44dfe7904c42bbc37827f3fd4c

Well, the last week(s) I was trying hard to find some job for me. (Not
that there is nothing more to be done, but if you want to avoid UI
work ..)
I may continue if I will see anybody working in that area (or trying
to use tubes) and/or I will find something useful / needed to work on
in tubes.
At least I will adapt tubes to new ui work by Caolán when ready.
But now I'd like to work on other things in LibreOffice, mostly gbuild related.

> Would you like to prepare a blog entry with a few nice screen shots we
> could use to shamelessly promote your work? :-)

I still hope Michael will do this. :-) Or you will.
The dialog is little different, has few more buttons.. but not much has changed.
I am not a good promoter and I can't see what is the goal.
I tried to write at least something into readme.

Thanks,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSOC-UPDATE](20.08) Impress Remote -- first testing apk.

2012-08-20 Thread John Smith

On Mon, Aug 20, 2012 at 11:11 PM, Michael Meeks  wrote:
>
> I'd be careful of that in case they become popular ;-) I'd suggest you
> use your freedesktop webspace; checkout your freedesktop account name
> (used to be in .git/config); assuming it is 'ahunt':
>
> ssh ah...@users.freedesktop.org
>
> if you make a directory public_html you can drop files in there that
> appear at http://users.freedesktop.org/~ahunt/
>
Totally off topic, Im sorry, but ... but im intrigued: Could this be a
good solution to store the clang static src analysis reports as well ?
If so, I guess that would require me to get a account at
users.freedesktop.org ? How should I go about getting that ?

Again, im sorry for the off-topic question; but it just sounds like a
good solution to the 'store html pages where' issue im struggling
with.

Thanks,


John Smith.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSOC-UPDATE](20.08) Impress Remote -- first testing apk.

Hi Andrzej,

On Mon, 2012-08-20 at 22:10 +0200, Andrzej J. R. Hunt wrote:
> - Fixed a minor bug affecting the formatting of network servers in the 
> discovery screen.

Nice :-)

> - Migrated the rest of the activities and fragments to ABS -- hopefully 
> this means the App will work under Android 2.3+ (possibly earlier 

Good news indeed.

> A first apk for testing, which is only known to work with Android >= 
> 4.0.3 (might work on Android 2.3+, with some theming issues), can be 
> found under 
> http://ahunt.org/libreoffice/remote/sdremote-20082012-alpha01.apk . (At 
> the moment I'm hosting these on my webspace

I'd be careful of that in case they become popular ;-) I'd suggest you
use your freedesktop webspace; checkout your freedesktop account name
(used to be in .git/config); assuming it is 'ahunt':

ssh ah...@users.freedesktop.org

if you make a directory public_html you can drop files in there that
appear at http://users.freedesktop.org/~ahunt/

>  -- would it be appropriate to place them on the LO site anywhere ?).

As/when Tor gets up-loading automated, hopefully they'll land as if by
magic here:

http://dev-builds.libreoffice.org/daily/

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSoC 2012][Collaboration] brief status

Hi Matúš,

On Tuesday, 2012-08-14 19:47:37 +0200, Matúš Kukan wrote:

> Well, one thing I don't like at all is that it does not work with
> .service and .client files installed but I have no idea why and how to
> debug it. So I am just ignoring the problem and not using the files.

That's odd. Did you contact Will / #telepathy about this?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpbRwarzkW3g.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSoC 2012][Collaboration] short final report

Hi Matúš,

On Monday, 2012-08-20 18:05:16 +0200, Matúš Kukan wrote:

> For this GSoC I've been working on tubes framework as you surely know.
> Started by Eike, Michael and Will [1] much was already done and I was
> re-factoring it, adding functionality..

Thank you very much for your work and patience having to bear with us :-)

> Hope this helps and feel free to contact me for any hints.
> (The documentation in tubes/ may not be that good)

I hope this didn't scare you away and you'll continue to work on tubes
functionality also after GSoC ended.

Would you like to prepare a blog entry with a few nice screen shots we
could use to shamelessly promote your work? :-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpzwmKt7i26v.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSOC-UPDATE](20.08) Impress Remote -- first testing apk.

2012-08-20 Thread Andrzej J. R. Hunt


Hi everyone,

The latest updates:
- Minor fixes to discovery, to prevent deadlocks.
- Discovery now working on windows: was previously non-functional, due 
to including
  Winsock headers but linking against winsock2. (The LO pairing dialog 
is however still blank under windows.)
- Fixed a minor bug affecting the formatting of network servers in the 
discovery screen.
- Migrated the rest of the activities and fragments to ABS -- hopefully 
this means the App will work under Android 2.3+ (possibly earlier 
versions too). I'll be testing that tomorrow once I've added emulator 
detection to the selection screen (I no longer have any devices with 
Android < 4, meaning I can only test this on the emulator, which I can't 
do since I currently can't connect from emulator to localhost*).
- Bluetooth discovery and pairing functional (pairing for bluetooth is 
dealt with by the OS), communication not yet possible (I'm still 
figuring out how serial communication can be properly set up / how to 
use service records etc.)


* I mean to add emulator detection and manual IP entry tomorrow to allow 
testing using an emulator again.


A first apk for testing, which is only known to work with Android >= 
4.0.3 (might work on Android 2.3+, with some theming issues), can be 
found under 
http://ahunt.org/libreoffice/remote/sdremote-20082012-alpha01.apk . (At 
the moment I'm hosting these on my webspace -- would it be appropriate 
to place them on the LO site anywhere?). The server side is currently 
only known to work on Linux -- on Windows the pairing dialog is 
non-functional, and Mac hasn't been tested. Both smartphone and computer 
have to be on the same network, with ports 1598 (udp) and 1599 (tcp) 
open. Please be gentle with the "coverflow" switching widget, as it can 
cause an endless loop of slides switching back and forward if slides are 
changed too violently. Comments and feedback greatly appreciated, but 
please be aware that some parts are still unpolished and brittle. (I'll 
set up a wiki page to keep track of issues experienced tomorrow.)


Cheers,

Andrej
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSoC 2012][svg export filter] Weekly Report #13

2012-08-20 Thread Marco Cecchetti



Hi everybody,
this is my last GSoC weekly report.
I thanks my mentor and all the community for support.

Report #13
-
Date/Time, Footer and Page Number text fields are displayed
correctly again.

Fixed several bugs related to synchronization of the two
iterations on both meta comment actions and text paragraphs/text
portions enumerations. At present list items inside a table or
an OLE object are not exported correctly.

Enabled support for animating text paragraph. Both entrance and
exit effects work on text shapes, on the contrary there is not yet
support for emphasis effects such as changing font color and
font properties.
At present it is possible to apply an effect to the whole paragraph
only, no support is provided for by word or by character effect
variants.

The MetaSlide class has two new methods for collecting text shapes
from the text shape exported index and hyperlinks.
A new HyperlinkElement class has been designed for handling text
portion with an attached URL. The routine handling mouse click has
been modified in order to interacting with the EventMultiplexer
instance belonging to the current slide even when no animations
are exported.

All that let us supporting both web links and local links to slide
belonging to the current document.

The routine handling mouse click has been modified in order to avoid
to start the next effect or switch to the next slide when there is
a text fragment selected.

Now when the user selects text or performs a right click in order
to copy the selected text no further action is executed by the
presentation engine. When the left mouse button is clicked the
previous selection is discarded but still no further action is
performed by the presentation engine.

I spent last two days in making text animations compatible with
text selection I succeeded in achieving some good result.
The only things that still doesn’t work properly, as far as I can
see, is that hyperlinks inside animated paragraph don’t work
properly.
---


You can read the full details on my gsoc project log book:
https://docs.google.com/document/d/1GSLPSIWRGSDTSi69dT9Te8tRyTJcAekxT7scoCoGO2M/edit

You can get some sample presentation here:
http://users.freedesktop.org:8080/~mcecchetti/svg-export/samples/text-export/
For testing selection/searching features you need to utilize
Google Chrome or Internet Explorer.

You can look at the source code in the feature branch:
feature/svg-export, that includes all new commits after the last
master branch merging. The last commit is enough experimental.

Be aware that there is still a lot of debugging code in the
current implementation and a good amount of tracing info is
present in the exported svg document too.



What left out
-
Unfortunately I didn't succeeded in the GSoC time-frame to provide
the following features/bug-fixes:

1- complete support for animation involving text paragraph;

2- adding new meta comment actions that let me switching the
   implementation of text exporting to meta comment actions only;

3- supporting text export for table shapes and ole2 shapes;

4- text decorations (underline, strike-through) are not yet supported;

5- adjusting text when the font used is not the one required;

6- shadowed, outlined, embossed and engraved text is not supported;

7- exporting embedded svg image natively, without transforming them
   into a bitmap and back.
---

Cheers,
-- Marco


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSOC-UDPATE](17.08) Impress Remote

2012-08-20 Thread Andrzej J. R. Hunt


Hi Michael,
On 08/20/2012 01:30 PM, Michael Meeks wrote:



One issue is powering up bluetooth on Android: documentation insists
that you ask the user to switch on bluetooth: one option is to add an
item "Search for Bluetooth" devices on the selection screen which does
this, or alternatively to just ask the user every single time the app
is started.

I -imagine- that UX wise, enabling bluetooth during a pairing flow, and
disabling it again if we don't connect is perhaps the best plan from a
UX & battery perspective ?

Yes, I think that's probably best, and easiest to implement.



  On a related note, I assume it's worth adding an "Add computer
manually" item to the same screen for cases where server discovery
doesn't work (e.g. if the router doesn't pass on multicast packets).

Yep - I guess so; "type your IP address here" or whatever ?
Ok. I'll probably also implement some form of emulator detection (i.e. 
if 10.0.2.2 exists  then add an Entry "Emulator host" to the list of 
servers) to simplify testing since server discovery doesn't work (and 
neither does bluetooth) when on the emulator.



If it's ok with everyone I'm going to include cleaned bluetooth
headers, from android, in the source tree to avoid the need for
installing a library which isn't actually linked or used. (Headers
viewable

Makes perfect sense; it'd be good to ensure that these are in a
top-level directory, with a link to where they came from (as below).
Would it be appropriate to place these in external, or do you mean a top 
level bluetooth folder? (I'd already put them into the remote folder, 
where I use them, but I can change that fairly simply.)



Assuming tests on my home network go fine I should publish a first apk
this coming Monday, when I'll do the last bits of transitioning to
ABS.

Perhaps the best thing to do is to get a 'make' in android/ to compile
the .apk inside our build tree, and work with Tor to get them building &
up-loading automatically from the new Android tinderboxen :-)

I'll try and add that. (For now I can upload them manually though.)


Nice work though,

Michael.


Thanks,

Andrzej
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Timothy Pearson

> On Mon, 2012-08-20 at 18:02 +0200, Stephan Bergmann wrote:
>> On 08/20/2012 05:51 PM, Timothy Pearson wrote:
>> > Can you please post the generated kdefilepicker.moc.cxx file?  I am
>> > somewhat surprised that moc is failing to generate valid code in this
>> > case.
>
> LuboÅ¡ solved this for us,
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=da9871c3ce2d7ca4efbc40c2d55d08c6b13834cc
>
> C.
>

Glad to hear it; thanks for the fix!

Tim

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Timothy Pearson

> On 08/20/2012 05:51 PM, Timothy Pearson wrote:
>> Can you please post the generated kdefilepicker.moc.cxx file?  I am
>> somewhat surprised that moc is failing to generate valid code in this
>> case.
>
> attached
>
> Stephan

OK, I think I see the problem.  Qt3's moc is too stupid to understand the
#if/#else/#endif construct around "void fileHighlightedCommand(const
TQString &);", so it tries to use the TDE specific code in a pure
KDE3.5/Qt3 environment and obviously fails.

I don't see a good way around this, so for now it might be a good idea to
comment out the /vcl/unx/kde/fpicker/kdefilepicker.hxx
b/vcl/unx/kde/fpicker/kdefilepicker.hxx "void fileHighlightedCommand(const
TQString &);" line in GIT (with a suitable FIXME comment) while I attempt
to work on a solution.

Tim

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Timothy Pearson

> On 08/20/2012 01:41 PM, Caolán McNamara wrote:
>> On Sun, 2012-08-19 at 03:44 -0500, Timothy Pearson wrote:
>>> This patch restores the TDE VCL and filepicker interfaces to full
>>> functionality in LO 3.6.0:
>>> http://git.trinitydesktop.org/cgit/tde/plain/main/thirdparty/libreoffice/3.6.0/patches/libreoffice-fix-tde-vcl.diff
>>>
>>> This patch does not affect the KDE3 plugin and should be committed to
>>> LO
>>> GIT.  The LO code currently in GIT both does not display widgets and
>>> also
>>> hangs when used under TDE; this patch resolves these issues.
>>
>> Fair enough, pushed to master now.
>
> That commit
> 
> "Fix TDE VCL interface" makes my build start to fail:
>
>> [ build CXX ] CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx
>> /home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:
>> In member function virtual bool KDEFileDialog::qt_invoke(int,
>> QUObject*):
>> /home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:43:
>> error: ISO C++ forbids declaration of type name with no type
>> [-fpermissive]
>> /home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:43:
>> error: ISO C++ forbids declaration of type name with no type
>> [-fpermissive]
>> /home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:37:
>> error: expected primary-expression before const
>> /home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:37:
>> error: expected ) before const
>
> and kdefilepicker.moc.cxx:92 is
>
>> case 0: fileHighlightedCommand((const TQString&)*((const
>> TQString*)static_QUType_ptr.get(_o+1))); break;
>
> (so 92:43 is that first mention of "TQString").  Anybody any insight
> what's broken there for me?
>
> Stephan
>

Can you please post the generated kdefilepicker.moc.cxx file?  I am
somewhat surprised that moc is failing to generate valid code in this
case.

To anyone monitoring with an eye toward reverting the patch, the portion
of the patch causing this error should be limited to the changes in
/vcl/unx/kde/fpicker/kdefilepicker.hxx.

Thanks!

Tim

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ATTENTION] Gerrit is now the primary git repo. Freedesktop is now read-only

On 20 August 2012 16:07, Kohei Yoshida  wrote:
> I also had feature/calc-multiline-input re-appeared on gerrit (it had been
> deleted on fdo), and unable to remove it on gerrit for the exact same error
> message.
>
> Could you delete that branch too?

Done by me, so it should now work for all.
I couldn't do it either but Norbert fixed that somehow.

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] Changes to 'feature/creation-test'

New branch 'feature/creation-test' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-08-20 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Aibara  changed:

   What|Removed |Added

 Depends on||52080

--- Comment #357 from Aibara  2012-08-20 19:26:35 
UTC ---
Add https://bugs.freedesktop.org/show_bug.cgi?id=52080 - Large files become
unresponsive since version 3.5.0.
Regression - working with large files was fine with Writer in the 3.4 series,
now broken.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6-1' - sal/osl

 sal/osl/w32/file_dirvol.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9127c6d7534d77f0ee5cf34264b682a7e97a92df
Author: Stephan Bergmann 
Date:   Mon Aug 20 15:18:35 2012 +0200

fdo#53252: _toupper is unreliable

 
"toupper,
_toupper, towupper, _toupper_l, _towupper_l: Visual Studio 2005" states: "In
order for toupper to give the expected results, __isascii and isupper must 
both
return nonzero."  But a community comment clarifies: "This is incorrect, and
should refer to '_toupper' (the macro form), not 'toupper'."  (Which makes
sense, as otherwise toupper would violate the C Standard.)

And indeed, at least for some LO built against MSVC 2008 Express on Windows 
7,
_toupper('C') = '#' is broken, while toupper('C') = 'C' is good.  (And the
unexpected '#' then causes all sorts of errors in the code.)

Change-Id: Iddaddcaf0cc3ffb30e55b0f410a6cfe9118accc8
Signed-off-by: Petr Mladek 
Signed-off-by: Tor Lillqvist 
Signed-off-by: Michael Meeks 

diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index d7a531c..47309a4 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -1116,7 +1116,7 @@ oslFileError SAL_CALL osl_getDirectoryItem(rtl_uString 
*strFilePath, oslDirector
 osl_acquireDirectoryItem( (oslDirectoryItem)pItemImpl );
 
 _tcscpy( pItemImpl->cDriveString, 
reinterpret_cast(strSysFilePath->buffer) );
-pItemImpl->cDriveString[0] = _toupper( 
pItemImpl->cDriveString[0] );
+pItemImpl->cDriveString[0] = toupper( 
pItemImpl->cDriveString[0] );
 
 if ( pItemImpl->cDriveString[_tcslen(pItemImpl->cDriveString) 
- 1] != '\\' )
 _tcscat( pItemImpl->cDriveString, TEXT( "\\" ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED 3-6-1 1/3] fdo#53252: File Open on "C:" crash


On Mon, 2012-08-20 at 17:34 +0300, Tor Lillqvist wrote:
> Two more approvals needed for 3-6-1 branch.

Pushed; thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-08-20 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 53325, which changed state.

Bug 53325 Summary: FILEOPEN "CSV" import not correctly recognizing space and 
text field delimiters, i.e. web log file
https://bugs.freedesktop.org/show_bug.cgi?id=53325

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-08-20 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 43313, which changed state.

Bug 43313 Summary: TABLE border of merged cell is misplaced (regression since 
3.3.4)
https://bugs.freedesktop.org/show_bug.cgi?id=43313

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] java5 updates, converting to generics

On Fri, 2012-08-17 at 17:06 +0200, Noel Grandin wrote:
> Hi
> 
> Warning, this is a fairly large patch.

pushed, make check continues to work.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: filter/source

 filter/source/pdf/impdialog.src |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f906ac27761332580b769f5f90d1f6bbd7f93701
Author: GÃ¶kÃ§en Eraslan 
Date:   Mon Aug 20 19:46:15 2012 +0200

Use PassWord property in impdialog.src for certificate Edit widget.

Change-Id: I597de8efa8838b35597a401c27e1eb709fd8ef31

diff --git a/filter/source/pdf/impdialog.src b/filter/source/pdf/impdialog.src
index cf6cfa1..353c53a 100644
--- a/filter/source/pdf/impdialog.src
+++ b/filter/source/pdf/impdialog.src
@@ -867,6 +867,7 @@ TabPage  RID_PDF_TAB_SIGNING
 {
 Border = TRUE ;
 Pos = MAP_APPFONT ( 102, 35 ) ;
+PassWord = TRUE;
 Size = MAP_APPFONT ( 68 , 12 ) ;
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Help Locating Base Code

2012-08-20 Thread Joel Madero

I am still having a hard time locating the relevant code for this bug
fdo#53001. I did the backtrace with the dialog open and I didn't see
anything useful in there. If someone can help direct me to the relevant
code OR if someone is willing to take the bug and fix it, I think it's a 20
minute fix but hours upon hours of trying to find the code has left me a
bit frustrated.

Best Regards,
Joel

On Thu, Aug 9, 2012 at 10:34 AM, Joel Madero  wrote:

> Thanks to everyone. I have successfully done my first backtrace :) It was
> unrelated but I see things that make sense  :) now time to try to locate
> this dialog and the trigger that is affecting image linking.
>
>
> Joel
>
>
> On Wed, Aug 8, 2012 at 11:49 PM, Jan Holesovsky  wrote:
>
>> Hi Joel,
>>
>> Joel Madero píše v St 08. 08. 2012 v 18:35 -0700:
>>
>> > Thanks for the advice. Unfortunately every time I run "run" and get into
>> > database I get a segfault in gdb.
>> >
>> > Program received signal SIGSEGV, Segmentation fault.
>> > [Switching to Thread 0x7fffc2d06700 (LWP 4977)]
>>
>> To see where it crashed, do 'bt' in gdb - that will show you backtrace
>> of the crash.  If it looks unrelated, do 'thread apply all bt' which
>> will show backtrace of all threads.
>>
>> > Not sure why. Also mine looks nothing like Lionel's did when he ran gdb.
>> > Mine looks more like this:
>>
>> After issuing 'bt' (Lionel's "and look at the backtrace"), you should
>> see something similar to Lionel's output :-)
>>
>> All the best,
>> Kendy
>>
>>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: widget layout progress

2012-08-20 Thread Noel Grandin

On Mon, Aug 20, 2012 at 6:03 PM, Caolán McNamara  wrote:
> Making a bit of progress in widget layout.
>
> [*] maybe the cast-happy syntax looks a bit vile. Perhaps a bit family
> of get_foos_by_name, or a get_by_name template instead ?
>

How about get_VclContainer, get_CheckBox, etc ?
It's a library class, so it's supposed to make the client code easier
to use, even at the cost of introducing some extra weight into itself.
And it's not like there are lots of different ways of extracting the
widgets, so the "by_name" is unnecessary IMNSHO :-)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

On Mon, 2012-08-20 at 18:02 +0200, Stephan Bergmann wrote:
> On 08/20/2012 05:51 PM, Timothy Pearson wrote:
> > Can you please post the generated kdefilepicker.moc.cxx file?  I am
> > somewhat surprised that moc is failing to generate valid code in this
> > case.

Luboš solved this for us,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=da9871c3ce2d7ca4efbc40c2d55d08c6b13834cc

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-5, 3-6][REVIEW 3-6-1] fdo#47434 pptx arrow import

Korrawit Pruegsanusak píše v St 15. 08. 2012 v 23:16 +0700:
> Hello all,
> 
> I'd like to propose [1] which fix fdo#47434 to be included in -3-5,
> 3-6, and 3-6-1 if possible.

It looks safe and works well => pushed into 3-5 and 3-6 branches:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=9b1f4aac63e0f1e5453485f8b4c36c9020bbea03
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=6cbb9602e15794b4d39d2482a40c22d3fd0328f9

It is safe enough to be included in 3-6-1. Well, we need two more
approvals.

> For the detailed explanation, please see in bugzilla starting from comment 
> #13.
> 
> Also, the unit test waiting in gerrit [2] couldn't be backported
> because I use XShapeDumper available only in master, and my skill
> isn't enough to use UNO API. ;)

IMHO, it is enough to keep it in master and safe resources for other
bugfixes, new unit tests, ...


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - svx/source

 svx/source/svdraw/svdoashp.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 6cbb9602e15794b4d39d2482a40c22d3fd0328f9
Author: Muthu Subramanian 
Date:   Tue Aug 14 16:12:53 2012 +0530

fdo#47434: Zero rect. size causing wrong line positions.

Thanks to Korrawit Pruegsanusak 
for the indepth analysis and debugging.

Signed-off-by: Petr Mladek 

diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 4c4ff86..cf7cec8 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -3031,6 +3031,10 @@ void SdrObjCustomShape::TRSetBaseGeometry(const 
basegfx::B2DHomMatrix& rMatrix,
 // build and set BaseRect (use scale)
 Point aPoint = Point();
 Size aSize(FRound(aScale.getX()), FRound(aScale.getY()));
+// fdo#47434 We need a valid rectangle here
+if( !aSize.Height() ) aSize.setHeight( 1 );
+if( !aSize.Width() ) aSize.setWidth( 1 );
+
 Rectangle aBaseRect(aPoint, aSize);
 SetSnapRect(aBaseRect);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - svx/source

 svx/source/svdraw/svdoashp.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 9b1f4aac63e0f1e5453485f8b4c36c9020bbea03
Author: Muthu Subramanian 
Date:   Tue Aug 14 16:12:53 2012 +0530

fdo#47434: Zero rect. size causing wrong line positions.

Thanks to Korrawit Pruegsanusak 
for the indepth analysis and debugging.

Signed-off-by: Petr Mladek 

diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 1e66287..4359459 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -3026,6 +3026,10 @@ void SdrObjCustomShape::TRSetBaseGeometry(const 
basegfx::B2DHomMatrix& rMatrix,
 // build and set BaseRect (use scale)
 Point aPoint = Point();
 Size aSize(FRound(aScale.getX()), FRound(aScale.getY()));
+// fdo#47434 We need a valid rectangle here
+if( !aSize.Height() ) aSize.setHeight( 1 );
+if( !aSize.Width() ) aSize.setWidth( 1 );
+
 Rectangle aBaseRect(aPoint, aSize);
 SetSnapRect(aBaseRect);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[GSoC 2012][Collaboration] short final report

Hi,

For this GSoC I've been working on tubes framework as you surely know.
Started by Eike, Michael and Will [1] much was already done and I was
re-factoring it, adding functionality..

If you want to have fun with collaboration, configure with
--enable-telepathy and build + run calc.
For more hints, look into tubes/README

Now, in the rare case, you want to use this, e.g., for writer:
- The easy part is to look at tubes' unit test to get a feeling what
needs to be implemented.
  The unit test is similar to what real app does. (see also ScCollaboration)
  It should be easy to use tubes for sending messages.
- The problematic part is to create useful messages on user's input
and interpret them on the other side.
  There is much to do about this in calc also.

I've learned something new about C++, about LibreOffice's source and
it was fun, mostly.
Thanks Eike and others for helping out.

Hope this helps and feel free to contact me for any hints.
(The documentation in tubes/ may not be that good)

All the best,
Matúš

[1] http://erack.org/blog/archives/15-LibreOffice-goes-collaborating.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

widget layout progress

Making a bit of progress in widget layout.

Seeing as I'm a bit "close" to it, I'd like to demo some sample commits
of how conversions would look to see if it makes anyone violently ill.

Basically we'd use the gtk ui builder format which is ui editable with
glade.

Full Conversion: Here's what a "full conversion" of a dialog away from
the binary res format to the xml .ui format would look like
http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/cmclayouttrans&id=064c21aec9245148e90290afd00c46b0999d19c4
i.e.
a) remove the .src and .hrc
b) remove from the .hxx and .cxx any controls which only exist in the
code in order to get them loaded from the .res file
c) adapt the code to use "get_by_name" to find a widget if code needs to
get an explicit handle to one to set callbacks or whatever[*]

And its help ids in helpcontent2 like so..
http://cgit.freedesktop.org/libreoffice/help/commit/?h=feature/cmclayouttrans&id=4add66152cd6c1c9f4f39be35d8d016cb5b11080
i.e. help ids become the path/to/dialog + dialog name + widget name

Incremental Conversion: Here's an "incremental" conversion from the
binary format to to .ui. In this case no code changes happen at all.
Once the .ui widget ids (and their types) match the ids that the
existing code expects then "magic" makes it work out of the box if the
ui is correctly named and put in the right place.
http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/cmclayouttrans&id=aefe9698a6982eaefdae51dbaebc15a4e0bd28a7

The idea here is that, with the right conversion utility, the .src files
could be converted to some basic glade-editable skeleton and there's no
programming ability required to knock that into shape for submission.
The submitted .ui can then be dropped in as-is, and/or code then
optimized to complete the conversion.

I'll do up a wiki page with a bit more detail in a while.

[*] maybe the cast-happy syntax looks a bit vile. Perhaps a bit family
of get_foos_by_name, or a get_by_name template instead ?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Stephan Bergmann


On 08/20/2012 05:51 PM, Timothy Pearson wrote:

Can you please post the generated kdefilepicker.moc.cxx file?  I am
somewhat surprised that moc is failing to generate valid code in this
case.


attached

Stephan

/
** KDEFileDialog meta object code from reading C++ file 'kdefilepicker.hxx'
**
** Created: Mon Aug 20 17:59:23 2012
**  by: The Qt MOC ($Id: qt/moc_yacc.cpp   3.3.8   edited Feb 2 14:59 $)
**
** WARNING! All changes made in this file will be lost!
*/

#undef QT_NO_COMPAT
#include "../../../../../../../vcl/unx/kde/fpicker/kdefilepicker.hxx"
#include 
#include 

#include 
#if !defined(Q_MOC_OUTPUT_REVISION) || (Q_MOC_OUTPUT_REVISION != 26)
#error "This file was generated using the moc from 3.3.8b. It"
#error "cannot be used with the include files from this version of Qt."
#error "(The moc has changed too much.)"
#endif

const char *KDEFileDialog::className() const
{
return "KDEFileDialog";
}

QMetaObject *KDEFileDialog::metaObj = 0;
static QMetaObjectCleanUp cleanUp_KDEFileDialog( "KDEFileDialog", &KDEFileDialog::staticMetaObject );

#ifndef QT_NO_TRANSLATION
QString KDEFileDialog::tr( const char *s, const char *c )
{
if ( qApp )
	return qApp->translate( "KDEFileDialog", s, c, QApplication::DefaultCodec );
else
	return QString::fromLatin1( s );
}
#ifndef QT_NO_TRANSLATION_UTF8
QString KDEFileDialog::trUtf8( const char *s, const char *c )
{
if ( qApp )
	return qApp->translate( "KDEFileDialog", s, c, QApplication::UnicodeUTF8 );
else
	return QString::fromUtf8( s );
}
#endif // QT_NO_TRANSLATION_UTF8

#endif // QT_NO_TRANSLATION

QMetaObject* KDEFileDialog::staticMetaObject()
{
if ( metaObj )
	return metaObj;
QMetaObject* parentObject = KFileDialog::staticMetaObject();
static const QUParameter param_slot_0[] = {
	{ 0, &static_QUType_ptr, "TQString", QUParameter::In }
};
static const QUMethod slot_0 = {"fileHighlightedCommand", 1, param_slot_0 };
static const QUParameter param_slot_1[] = {
	{ 0, &static_QUType_QString, 0, QUParameter::In }
};
static const QUMethod slot_1 = {"fileHighlightedCommand", 1, param_slot_1 };
static const QUMethod slot_2 = {"selectionChangedCommand", 0, 0 };
static const QMetaData slot_tbl[] = {
	{ "fileHighlightedCommand(const TQString&)", &slot_0, QMetaData::Protected },
	{ "fileHighlightedCommand(const QString&)", &slot_1, QMetaData::Protected },
	{ "selectionChangedCommand()", &slot_2, QMetaData::Protected }
};
metaObj = QMetaObject::new_metaobject(
	"KDEFileDialog", parentObject,
	slot_tbl, 3,
	0, 0,
#ifndef QT_NO_PROPERTIES
	0, 0,
	0, 0,
#endif // QT_NO_PROPERTIES
	0, 0 );
cleanUp_KDEFileDialog.setMetaObject( metaObj );
return metaObj;
}

void* KDEFileDialog::qt_cast( const char* clname )
{
if ( !qstrcmp( clname, "KDEFileDialog" ) )
	return this;
return KFileDialog::qt_cast( clname );
}

bool KDEFileDialog::qt_invoke( int _id, QUObject* _o )
{
switch ( _id - staticMetaObject()->slotOffset() ) {
case 0: fileHighlightedCommand((const TQString&)*((const TQString*)static_QUType_ptr.get(_o+1))); break;
case 1: fileHighlightedCommand((const QString&)static_QUType_QString.get(_o+1)); break;
case 2: selectionChangedCommand(); break;
default:
	return KFileDialog::qt_invoke( _id, _o );
}
return TRUE;
}

bool KDEFileDialog::qt_emit( int _id, QUObject* _o )
{
return KFileDialog::qt_emit(_id,_o);
}
#ifndef QT_NO_PROPERTIES

bool KDEFileDialog::qt_property( int id, int f, QVariant* v)
{
return KFileDialog::qt_property( id, f, v);
}

bool KDEFileDialog::qt_static_property( QObject* , int , int , QVariant* ){ return FALSE; }
#endif // QT_NO_PROPERTIES
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][REVIEW 3-6-1 1/3] resolved fdo#53325 CSV space delimiter and quoted field

2012-08-20 Thread Markus Mohrhard

2012/8/20 Petr Mladek :
> Eike Rathke píše v Po 20. 08. 2012 v 15:34 +0200:
>> Hi,
>>
>> Please review and cherry-pick to 3-6
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44a402d5a05dd32aa2e1ab80c9ea75b560dc3b9
>> that fixes https://bugs.freedesktop.org/show_bug.cgi?id=53325
>
> Makes sense. I double checked it with several other scenarios and it
> worked fine => pushed into 3-6 branch.
>
> It looks pretty safe. It would be great to get it into 3-6-1 branch as
> well. Two more approvals are needed.

Looks good to me. One more needed for 3-6-1.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][NEED_UPDATE 3-5] fdo#48200 ( regression )

Noel Power píše v Čt 16. 08. 2012 v 17:44 +0100:
> Please think about cherrypicking
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b94bff540a47a9fc5ce0586aa58e28321c96e4aa

Yup, the variable bUseRegularExpressions is not longer set in 3-6
branch. It seems that the related methods were removed during some clean
up. It work well, there => pushed into 3-6, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=f1c26949e29278a3eae0c167f172a0fd4895fd2f


Hmm, the variable bUseRegularExpressions is still used on several
locations in 3-5. It needs more tweaking to make it working there. I am
not sure if it is worth the effort, though.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

 sc/source/filter/xml/xmlfilti.cxx |2 --
 sc/source/filter/xml/xmlfilti.hxx |1 -
 2 files changed, 3 deletions(-)

New commits:
commit f1c26949e29278a3eae0c167f172a0fd4895fd2f
Author: Noel Power 
Date:   Thu Aug 16 17:43:40 2012 +0100

fix for fdo#48200.diff import regrex state for filter

Change-Id: If05b53602a8d8ea260093b3f6a9c0fca45cb74b9
Signed-off-by: Petr Mladek 

diff --git a/sc/source/filter/xml/xmlfilti.cxx 
b/sc/source/filter/xml/xmlfilti.cxx
index 65c9420..faee78f 100644
--- a/sc/source/filter/xml/xmlfilti.cxx
+++ b/sc/source/filter/xml/xmlfilti.cxx
@@ -61,7 +61,6 @@ ScXMLFilterContext::ScXMLFilterContext( ScXMLImport& rImport,
 pDatabaseRangeContext(pTempDatabaseRangeContext),
 bSkipDuplicates(false),
 bCopyOutputData(false),
-bUseRegularExpressions(false),
 bConditionSourceRange(false)
 {
 ScDocument* pDoc(GetScImport().GetDocument());
@@ -152,7 +151,6 @@ SvXMLImportContext *ScXMLFilterContext::CreateChildContext( 
sal_uInt16 nPrefix,
 
 void ScXMLFilterContext::EndElement()
 {
-mrQueryParam.bRegExp = bUseRegularExpressions;
 mrQueryParam.bInplace = !bCopyOutputData;
 mrQueryParam.bDuplicate = !bSkipDuplicates;
 
diff --git a/sc/source/filter/xml/xmlfilti.hxx 
b/sc/source/filter/xml/xmlfilti.hxx
index 8a9715d..052829e 100644
--- a/sc/source/filter/xml/xmlfilti.hxx
+++ b/sc/source/filter/xml/xmlfilti.hxx
@@ -62,7 +62,6 @@ class ScXMLFilterContext : public SvXMLImportContext
 sal_Int16   nUserListIndex;
 boolbSkipDuplicates;
 boolbCopyOutputData;
-boolbUseRegularExpressions;
 boolbEnabledUserList;
 boolbConditionSourceRange;
 std::vector maConnStack;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PUSHED][PATCH] fix dead code and fields in Java code

On Fri, 2012-08-17 at 17:15 +0200, Noel Grandin wrote:
> Hi
> 
> These patches remove various bits of dead code in the Java files.

With one trivial change built and passed make check for me, pushed now

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 4 commits - tubes/CppunitTest_tubes_test.mk tubes/inc tubes/Library_tubes.mk tubes/qa tubes/README tubes/source

 tubes/CppunitTest_tubes_test.mk   |5 -
 tubes/Library_tubes.mk|1 
 tubes/README  |   76 +++--
 tubes/inc/tubes/collaboration.hxx |4 +
 tubes/inc/tubes/contact-list.hxx  |   62 -
 tubes/inc/tubes/manager.hxx   |   27 ---
 tubes/qa/test_manager.cxx |3 
 tubes/source/contact-list.cxx |  137 --
 tubes/source/contacts.cxx |   64 -
 tubes/source/manager.cxx  |   86 +--
 10 files changed, 143 insertions(+), 322 deletions(-)

New commits:
commit aa460e5731e94d00cf0776c10ab86013d334ae16
Author: MatÃºÅ¡ Kukan 
Date:   Mon Aug 20 17:28:46 2012 +0200

tubes: update README

Change-Id: Iab26aa96301851ace6244688a38bbb99630afd73

diff --git a/tubes/README b/tubes/README
index e8e12fb..7d67636 100644
--- a/tubes/README
+++ b/tubes/README
@@ -3,9 +3,6 @@
 The idea is to provide 1-1 collaboration between contacts and many-many
 collaboration via MUCs, using Telepathy DBus Tubes over Jabber/XMPP.
 
-First stab is at 1-1 contact channels, hopefully MUCs can be realized using
-the same TeleConference abstraction.
-
 To enable configure LibO with --enable-telepathy
 
 Currently (2012-04-14) at least telepathy-glib 0.18 is needed, which doesn't
@@ -19,7 +16,7 @@ cp -p $HOME/usr/lib/libtelepathy-glib.* 
$SRCDIR/solver/$INPATH/lib/
 
 If you have a Telepathy-enabled LibreOffice installed to /usr (including
 liboapprover) you may also want to install the .service and .client files to
-make everything service-activatable:
+make everything service-activatable. Currently this does not seem to work.
 
 mkdir -p $HOME/.local/share/telepathy/clients
 ln -s $PWD/tubes/LibreOffice.client \
@@ -31,86 +28,41 @@ make everything service-activatable:
   $PWD/tubes/org.freedesktop.Telepathy.Client.LibreOffice.service \
   $HOME/.local/share/dbus-1/services
 
-Otherwise, you need to make sure liboapprover and a Telepathy-enabled
-LibreOffice are running.
-
-
-* Demo modes
 
-This allows you to play with the interposing without having a telepathy
-enabled setup:
+* liboapprover
 
-INTERCEPT=demo ./soffice -calc
+You may run it in the background. When someone wants to collaborate with you,
+you then get a confirmation dialog.
 
-Create a bit of a document, type 'saveas' with spelling auto-correction
-disabled, and bingo.
+* Demo modes
 
+To play with the interposing without having an online account connected, create
+a bit of a document, go to File -> Collaboration -> startDemoSession and bingo.
 
-* Status 2012-03-23:
 
 * To do interesting things with this code build and run calc thus:
 
-   SAL_LOG=1 LIBO_TUBES=slave ./soffice -calc   # user one
-   SAL_LOG=1 LIBO_TUBES=master ./soffice -calc  # user two
-
-   hope that a nasty race-condition doesn't occur during startup:
-which is flagged by "we are supposed to handle only one channel" you
-hit it: bang - just try again.
-
-   you also require only a single jabber connection enabled (in
-empathy) and to have your opponent added and approved on both sides.
+   SAL_LOG=1 ./soffice --calc
 
-   Now type simple strings into cells, rename sheets, or type
-'saveme' to transfer your document as-is to the other side ...
+   Now type simple strings into cells, rename sheets, or go to
+File -> Collaboration; Listen; startBuddySession;
+to transfer your document as-is to the other side ...
 
 
-* Status 2012-03-20:
-
-* no LibO code depends on this module yet, so it is not built in a regular
-  build, even if configured with --enable-telepathy, so cd tubes and make here
-  * to enable the various SAL_INFO and SAL_WARN messages emitted during
-cppunittest pass SAL_LOG=... and do a debug build
-  * SAL_LOG="+WARN+INFO.tubes" make -rs debug=true
-  * the cppunittest will currently fail anyway (even if it wouldn't for other
-reasons), this is on purpose to be able to see the output as otherwise it
-is silenced down ... :-(
-
 * for the cppunittest needed:
   * Configure two Jabber accounts in Empathy
   * Both must be online and on each other's contact list
   * Copy qa/test-config.ini.example to qa/test-config.ini, and specify those
 two accounts' JIDs in it.
 
-* very nasty GMainLoop handling for cppunittest, HOPEFULLY we will get rid of
-  that in a real LibO
-* working:
-  * contact channels are setup
-  * tube is offered/accepted
-  * packets are sent and received
-
-
-TODO:
-
-* cleanup code to use a refcounted single instance thats holds mpAccountManager
-  and stuff and actually releases them, instead of statics
-* TeleManager should be a single instance, not holding any account information;
-  instead, the start...Session() methods should also get the account passed
-* implement master/slave mode in 1-1 buddy conferences, master would do strong
-  ordering
-
 
-other TODOs:
+* TODOs:
 
-* associate a document with a conferenc

Re: [PUSHED][PATCH] Fix TDE VCL interface

2012-08-20 Thread Stephan Bergmann


On 08/20/2012 01:41 PM, Caolán McNamara wrote:

On Sun, 2012-08-19 at 03:44 -0500, Timothy Pearson wrote:

This patch restores the TDE VCL and filepicker interfaces to full
functionality in LO 3.6.0:
http://git.trinitydesktop.org/cgit/tde/plain/main/thirdparty/libreoffice/3.6.0/patches/libreoffice-fix-tde-vcl.diff

This patch does not affect the KDE3 plugin and should be committed to LO
GIT.  The LO code currently in GIT both does not display widgets and also
hangs when used under TDE; this patch resolves these issues.


Fair enough, pushed to master now.


That commit 
 
"Fix TDE VCL interface" makes my build start to fail:



[ build CXX ] CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx
/home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:
 In member function ‘virtual bool KDEFileDialog::qt_invoke(int, QUObject*)’:
/home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:43:
 error: ISO C++ forbids declaration of ‘type name’ with no type [-fpermissive]
/home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:43:
 error: ISO C++ forbids declaration of ‘type name’ with no type [-fpermissive]
/home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:37:
 error: expected primary-expression before ‘const’
/home/sbergman/lo/core/workdir/unxlngx6/CustomTarget/vcl/unx/kde/fpicker/kdefilepicker.moc.cxx:92:37:
 error: expected ‘)’ before ‘const’


and kdefilepicker.moc.cxx:92 is


case 0: fileHighlightedCommand((const TQString&)*((const 
TQString*)static_QUType_ptr.get(_o+1))); break;


(so 92:43 is that first mention of "TQString").  Anybody any insight 
what's broken there for me?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][REVIEW 3-6-1 1/3] resolved fdo#53325 CSV space delimiter and quoted field

Eike Rathke píše v Po 20. 08. 2012 v 15:34 +0200:
> Hi,
> 
> Please review and cherry-pick to 3-6
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44a402d5a05dd32aa2e1ab80c9ea75b560dc3b9
> that fixes https://bugs.freedesktop.org/show_bug.cgi?id=53325

Makes sense. I double checked it with several other scenarios and it
worked fine => pushed into 3-6 branch.

It looks pretty safe. It would be great to get it into 3-6-1 branch as
well. Two more approvals are needed.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

 sc/source/ui/docshell/impex.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 0e176a7411beced06ce27c5f059aa97e7de4212d
Author: Eike Rathke 
Date:   Mon Aug 20 14:38:27 2012 +0200

resolved fdo#53325 CSV space delimiter and quoted field

CSV import didn't recognize end of field if a field was quoted and the
delimiter was space.

Change-Id: I46de608d545011437fe8a298854c134d6cf54b6b
Signed-off-by: Petr Mladek 

diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index ab2fc5e..2957661 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -596,7 +596,10 @@ static QuoteType lcl_isFieldEndQuote( const sal_Unicode* 
p, const sal_Unicode* p
 // Due to broken CSV generators that don't double embedded quotes check if
 // a field separator immediately or with trailing spaces follows the quote,
 // only then end the field, or at end of string.
-while (p[1] == ' ')
+const sal_Unicode cBlank = ' ';
+if (p[1] == cBlank && ScGlobal::UnicodeStrChr( pSeps, cBlank))
+return FIELDEND_QUOTE;
+while (p[1] == cBlank)
 ++p;
 if (!p[1] || ScGlobal::UnicodeStrChr( pSeps, p[1]))
 return FIELDEND_QUOTE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: android/sdremote

 android/sdremote/src/org/libreoffice/impressremote/BlankScreenFragment.java
   |5 +-
 android/sdremote/src/org/libreoffice/impressremote/PresentationActivity.java   
   |   19 +-
 android/sdremote/src/org/libreoffice/impressremote/PresentationFragment.java   
   |4 +-
 android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java   
   |5 +-
 
android/sdremote/src/org/libreoffice/impressremote/StartPresentationActivity.java
 |5 +-
 android/sdremote/src/org/libreoffice/impressremote/ThumbnailFragment.java  
   |5 +-
 6 files changed, 24 insertions(+), 19 deletions(-)

New commits:
commit 34322a1360dd6e10df4212a9fa7d050abcb64dbf
Author: Andrzej J.R. Hunt 
Date:   Mon Aug 20 17:23:40 2012 +0200

More ABS migration.

Change-Id: If56d5c7f8c28248215cf558b03eabe1f5b4569ff

diff --git 
a/android/sdremote/src/org/libreoffice/impressremote/BlankScreenFragment.java 
b/android/sdremote/src/org/libreoffice/impressremote/BlankScreenFragment.java
index e849125..3760b22 100644
--- 
a/android/sdremote/src/org/libreoffice/impressremote/BlankScreenFragment.java
+++ 
b/android/sdremote/src/org/libreoffice/impressremote/BlankScreenFragment.java
@@ -8,14 +8,15 @@ import android.graphics.Color;
 import android.graphics.Paint;
 import android.graphics.RectF;
 import android.os.Bundle;
-import android.support.v4.app.Fragment;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.widget.ImageView;
 
-public class BlankScreenFragment extends Fragment {
+import com.actionbarsherlock.app.SherlockFragment;
+
+public class BlankScreenFragment extends SherlockFragment {
 
 CommunicationService mCommunicationService;
 
diff --git 
a/android/sdremote/src/org/libreoffice/impressremote/PresentationActivity.java 
b/android/sdremote/src/org/libreoffice/impressremote/PresentationActivity.java
index 13bff68..2ce7db1 100644
--- 
a/android/sdremote/src/org/libreoffice/impressremote/PresentationActivity.java
+++ 
b/android/sdremote/src/org/libreoffice/impressremote/PresentationActivity.java
@@ -7,7 +7,6 @@ import java.util.TimeZone;
 import org.libreoffice.impressremote.communication.CommunicationService;
 import org.libreoffice.impressremote.communication.SlideShow.Timer;
 
-import android.app.ActionBar;
 import android.app.AlertDialog;
 import android.content.ComponentName;
 import android.content.Context;
@@ -18,14 +17,11 @@ import android.os.Bundle;
 import android.os.Handler;
 import android.os.IBinder;
 import android.preference.PreferenceManager;
-import android.support.v4.app.FragmentActivity;
 import android.support.v4.app.FragmentManager;
 import android.support.v4.app.FragmentTransaction;
 import android.text.format.DateFormat;
 import android.view.KeyEvent;
 import android.view.LayoutInflater;
-import android.view.Menu;
-import android.view.MenuItem;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.View.OnClickListener;
@@ -35,7 +31,10 @@ import android.widget.FrameLayout;
 import android.widget.TextView;
 import android.widget.ToggleButton;
 
-public class PresentationActivity extends FragmentActivity {
+import com.actionbarsherlock.app.ActionBar;
+import com.actionbarsherlock.app.SherlockFragmentActivity;
+
+public class PresentationActivity extends SherlockFragmentActivity {
 private CommunicationService mCommunicationService;
 private boolean mIsBound = false;
 private FrameLayout mLayout;
@@ -126,15 +125,17 @@ public class PresentationActivity extends 
FragmentActivity {
 };
 
 // -- ACTION BAR 
---
+
 @Override
-public boolean onCreateOptionsMenu(Menu menu) {
-getMenuInflater().inflate(R.menu.actionbar_presentation, menu);
+public boolean onCreateOptionsMenu(com.actionbarsherlock.view.Menu menu) {
+getSupportMenuInflater().inflate(R.menu.actionbar_presentation, menu);
 mActionBarManager = new ActionBarManager();
 return true;
 }
 
 @Override
-public boolean onOptionsItemSelected(MenuItem item) {
+public boolean onOptionsItemSelected(
+com.actionbarsherlock.view.MenuItem item) {
 Intent aIntent;
 switch (item.getItemId()) {
 case R.id.actionbar_presentation_submenu_options:
@@ -209,7 +210,7 @@ public class PresentationActivity extends FragmentActivity {
 
 public ActionBarManager() {
 
-ActionBar aBar = getActionBar();
+ActionBar aBar = getSupportActionBar();
 aBar.setDisplayOptions(ActionBar.DISPLAY_SHOW_CUSTOM);
 aBar.setCustomView(R.layout.presentation_actionbar);
 
diff --git 
a/android/sdremote/src/org/libreoffice/impressremote/PresentationFragment.java 
b/android/sdremote/src/org/libreoffice/impressremote/PresentationFragment.java
index 21aeb49..3b7bdca 100644
--- 
a/android/sdremote/src/org/libr

Unconfirmed Bugs Triaging Update #2

2012-08-20 Thread Joel Madero

Hi All,

Progress is still going for the unconfirmed bugs but we still needs people
to actively and aggressively help. If you have some time in the coming
weeks take a look at the following document:

https://docs.google.com/spreadsheet/ccc?key=0ApS-XtOUGGH5dDIwaXN1YnNsM0h4RXFKdVhvb2RRb0E

If you can do 1 bug a week that helps, once we get these unconfirmed under
control we'll be able to assign a small team to keep up with new bugs but
getting caught up is challenging and any and all help is appreciated. Here
are the new #'s.

Start Date: August 5th, 2012
Starting # of Bugs: 1,472
# of Bugs Today: 1,177*
Bugs done: 295
New Bugs Since August 5th: 322

Yes this means that we're actually BEHIND the pace of bugs still ;) But,
good news is that our goal in QA isn't to have bugs triaged the day they
are posted but instead just not have them sitting for months and months.

Best regards to everyone,
Joel

P.S. I'm going to try to actively recruit a few more people from the
#libreoffice channel who are probably knowledgeable to help triage but just
never have been asked to participate in LO. Also, I'm updating the triaging
wiki, if anyone is available to help please email me directly and we'll
coordinate something, looking for both feedback on what should be on the
wiki (right now it's pretty bad) as well as people to actually help write
it.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/CustomTarget_kde_moc.mk vcl/CustomTarget_tde_moc.mk vcl/unx

 vcl/CustomTarget_kde_moc.mk   |2 +-
 vcl/CustomTarget_tde_moc.mk   |2 +-
 vcl/unx/kde/fpicker/kdefilepicker.hxx |6 --
 3 files changed, 6 insertions(+), 4 deletions(-)

New commits:
commit da9871c3ce2d7ca4efbc40c2d55d08c6b13834cc
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Mon Aug 20 17:16:06 2012 +0200

do not make Qt3 moc mix KDE3 and TDE slots

Qt3 moc does not understand #ifdef, so filter out unwanted stuff for it.

diff --git a/vcl/CustomTarget_kde_moc.mk b/vcl/CustomTarget_kde_moc.mk
index d0c26e2..5ec2a35 100644
--- a/vcl/CustomTarget_kde_moc.mk
+++ b/vcl/CustomTarget_kde_moc.mk
@@ -34,6 +34,6 @@ $(call 
gb_CustomTarget_get_workdir,vcl/unx/kde/fpicker)/kdefilepicker.moc.cxx :\
$(SRCDIR)/vcl/unx/kde/fpicker/kdefilepicker.hxx \
| $(call gb_CustomTarget_get_workdir,vcl/unx/kde/fpicker)/.dir
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),MOC,1)
-   $(MOC) -o $@ $<
+   cat $< | grep -v 'FILTER_OUT_TDE' | $(MOC) -o $@ -f$<
 
 # vim:set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/vcl/CustomTarget_tde_moc.mk b/vcl/CustomTarget_tde_moc.mk
index d0c26e2..78c3b4b 100644
--- a/vcl/CustomTarget_tde_moc.mk
+++ b/vcl/CustomTarget_tde_moc.mk
@@ -34,6 +34,6 @@ $(call 
gb_CustomTarget_get_workdir,vcl/unx/kde/fpicker)/kdefilepicker.moc.cxx :\
$(SRCDIR)/vcl/unx/kde/fpicker/kdefilepicker.hxx \
| $(call gb_CustomTarget_get_workdir,vcl/unx/kde/fpicker)/.dir
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),MOC,1)
-   $(MOC) -o $@ $<
+   cat $< | grep -v 'FILTER_OUT_KDE' | $(MOC) -o $@ -f$<
 
 # vim:set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/vcl/unx/kde/fpicker/kdefilepicker.hxx 
b/vcl/unx/kde/fpicker/kdefilepicker.hxx
index ed7eef3..57ac7b6 100644
--- a/vcl/unx/kde/fpicker/kdefilepicker.hxx
+++ b/vcl/unx/kde/fpicker/kdefilepicker.hxx
@@ -114,10 +114,12 @@ protected:
 boolcanNotifySelection( void ) const { return 
m_bCanNotifySelection; }
 
 protected slots:
+// Qt3 moc does not really understand #ifdef and would process both slots,
+// so the FILTER_OUT_FOO tags are used to remove some slots before moc sees 
them.
 #ifdef ENABLE_TDE
-voidfileHighlightedCommand( const TQString & );
+voidfileHighlightedCommand( const TQString & ); // 
FILTER_OUT_TDE
 #else // ENABLE_TDE
-voidfileHighlightedCommand( const QString & );
+voidfileHighlightedCommand( const QString & );  // 
FILTER_OUT_KDE
 #endif // ENABLE_TDE
 voidselectionChangedCommand();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Text fields in fax, letter and report templates

2012-08-20 Thread Túri István

Hi, I'm trying to create unified templates for the template wizards 
described above. In detail, I would insert placeholders instead of the constant 
texts and make the wizards get the language dependent ones from vcl resources. 
Now, my problem is, that the three templates use some kind of TextFieldHandler 
stuff, which is not really clear for me. I would like to ask someone who is 
insider in this topic, that how is this working exactly? Does it recognize the 
fields written in "<...>"? What has this TextFieldSupplier and TextFieldMaster 
has to do with it? How can I manipulate any of these? So far, I have been 
experimenting with various stuff, but I couldn't get ahead with it. 
Thanks,István___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: android/sdremote

 android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java   
|1 +
 
android/sdremote/src/org/libreoffice/impressremote/communication/ServerFinder.java
 |8 +---
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 2e44e8134b077032341849886e2aad465cee1fd9
Author: Andrzej J.R. Hunt 
Date:   Mon Aug 20 17:10:46 2012 +0200

Fixed formatting of Network Servers in selection screen.

Change-Id: Ia2e0612588b1bad4971b73852f9cbededb233c7e

diff --git 
a/android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java 
b/android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java
index f6f9514..267636f 100644
--- a/android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java
+++ b/android/sdremote/src/org/libreoffice/impressremote/SelectorActivity.java
@@ -101,6 +101,7 @@ public class SelectorActivity extends Activity {
 
 void doUnbindService() {
 unbindService(mConnection);
+mCommunicationService = null;
 }
 
 private ServiceConnection mConnection = new ServiceConnection() {
diff --git 
a/android/sdremote/src/org/libreoffice/impressremote/communication/ServerFinder.java
 
b/android/sdremote/src/org/libreoffice/impressremote/communication/ServerFinder.java
index c88d018..4734ff4 100644
--- 
a/android/sdremote/src/org/libreoffice/impressremote/communication/ServerFinder.java
+++ 
b/android/sdremote/src/org/libreoffice/impressremote/communication/ServerFinder.java
@@ -53,9 +53,10 @@ public class ServerFinder {
 if (i == aBuffer.length || !aCommand.equals("LOREMOTE_ADVERTISE")) 
{
 return;
 }
-for (int j = i; j < aBuffer.length; j++) {
-if (aPacket.getData()[i] == '\n') {
-aName = new String(aPacket.getData(), i + 1, j, CHARSET);
+for (int j = i + 1; j < aBuffer.length; j++) {
+if (aPacket.getData()[j] == '\n') {
+aName = new String(aPacket.getData(), i + 1, j - (i + 1),
+CHARSET);
 break;
 }
 }
@@ -66,6 +67,7 @@ public class ServerFinder {
 .getAddress().getHostAddress(), aName,
 System.currentTimeMillis());
 mServerList.put(aServer.getAddress(), aServer);
+System.out.println("Contains:<<" + aName + ">>");
 
 Intent aIntent = new Intent(
 CommunicationService.MSG_SERVERLIST_CHANGED);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: libxml2 patches Re: xmllint problem validating using ODF RelaxNG

2012-08-20 Thread Daniel Veillard

On Mon, Aug 20, 2012 at 04:38:17PM +0200, Michael Stahl wrote:
> On 20/08/12 15:06, Daniel Veillard wrote:
> > On Thu, Nov 17, 2011 at 05:45:10PM +, Michael Meeks wrote:
> 
> >>Hopefully we're not doing validation in LibreOffice on load/save - but
> >> this is more of an xmllint feature, so we don't need to update our
> >> internal libxml2.
> 
> no validation is done of anything.
> 
> >>Which reminds me - Daniel, we've inherited a number of 'interesting'
> >> patches from OO.o on top of libxml2 and libxmlsec which are in git here:
> >>
> >>http://cgit.freedesktop.org/libreoffice/core/tree/libxml2
> > 
> >   Never too late, I looked a it today. There was only one patch which
> >   made sense upstream:
> > 
> > http://cgit.freedesktop.org/libreoffice/core/plain/libxml2/libxml2-latin.patch
> > 
> > the others either were updates to auto* files that were updated
> > independantly, a change to linker file to export symbols I dont want to
> > see exported ,
> 
> http://cgit.freedesktop.org/libreoffice/core/tree/libxml2/libxml2-global-symbols.patch
> 
> argh, don't remind me :-/
> 
> we should be able to get rid of that one though, as it is only necessary
> for older Solaris 10 versions, and currently we don't really support
> Solaris anyway in LO; from Solaris 10 Update 4 onwards there is libxml2
> version 2.6.23 which has all the features needed for the libxmlsec we
> use, so just using system libxml2/libxslt on Solaris should work; i
> would hope libxml2/libxslt are available by default on all OpenSolaris
> based distros.
> 
> > or things which had been changed upstream usually in
> > slightly different ways :-)
> 
> by the way, is something like
> 
> http://cgit.freedesktop.org/libreoffice/core/tree/libxml2/libxml2-long-path.patch
> 
> also upstream?

  I can't tell ! There is a macro IS_WINDOWS_PATH defined just before
xmlCanonicPath() but the diff doesn't include function name contextual
informations so I can't tell if you really apply to the same function.

> iirc there was some common configuration of Windows where
> we would want to access paths that are longer than the ridiculously
> small limit for the maximum path length on that ... platform, and then
> they have some silly notation with \\? that supports long pathnames...

  I would think that's something which is not there a priori, but such
changes really ought to be discussed on the list. My use and interest
in Windows is close to an absolute zero (as long as the code works there
!) so I'm not the right person to review this :-)

> oh, there are some more patches for libxslt here, but i guess it's
> mostly uninteresting stuff:
> 
> http://cgit.freedesktop.org/libreoffice/core/tree/libxslt

  Most of them are basically the same as for libxml2 but I would have
to double check. The most interesting would be the configure patch but
it seems to be very nuch tailored to your own buiolding environment
  So nothing exciting but some double checking needed...

Daniel


-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] fdo#47674 Calc: save settings for import ascii text dialog

Hi jumbo444,

Btw, if you'd like to see your first name here then use it in your From
header ;-)

On Saturday, 2012-08-18 02:46:59 -0700, jumbo444 wrote:

> > * Do not use RTL_CONSTASCII_USTRINGPARAM with new code, OUString knows
> > about ASCII literals. 
> > 
> Actually, I'm quite lost with all types of string. Where can I get tuto
> about string, String, OUString, UString, etc.?

Not really a tutorial, but overview
https://wiki.documentfoundation.org/Development/String_Classes

Note that internally we don't use std::string, and if possible new code
should use OUString instead of the deprecated String, and OString
instead of ByteString.


> I noticed that caption of Dlg is missing filename in case of File Import.
> Patch enclosed correct this.

Good catch, thanks, pushed as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b985dcf72d31cee191711f879675ec9affa2f76


> > * Sensible indentation, please ;-)
> > 
> I'm new with Linux and not comfortable with vim. I'm coming from MS-Windows.
> I learned C at school in late 80's, then TurboC, Borland C++ and C++ Builder
> by myself. So I have still a lot to learned :)
> I promise to improve my coding ;)

Great :-)  If you use Vim then just press Tab for one indentation level,
each source file has a Vim mode line at the end to tell it to use
4 spaces and no tabs per indentation level:

/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

Similar for Emacs the very first line:

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpWbGhWK6Gkv.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sd/source

 sd/source/ui/remotecontrol/DiscoveryService.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 92aab43c80cac484b5db2467b35132c55792736d
Author: Andrzej J.R. Hunt 
Date:   Mon Aug 20 16:53:58 2012 +0200

Include winsock2 instead of winsock for discovery.

Change-Id: I86aa527fe913ec6fc1ca566e083eadd64b4db2a5

diff --git a/sd/source/ui/remotecontrol/DiscoveryService.cxx 
b/sd/source/ui/remotecontrol/DiscoveryService.cxx
index 30b2131..69e8854 100644
--- a/sd/source/ui/remotecontrol/DiscoveryService.cxx
+++ b/sd/source/ui/remotecontrol/DiscoveryService.cxx
@@ -17,7 +17,8 @@
 #include "DiscoveryService.hxx"
 
 #ifdef WIN32
-  #include 
+  #include 
+  #include 
   typedef int socklen_t;
 #else
   #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: android/experimental

 android/experimental/DocumentLoader/Makefile |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e9f3727313ee523fa0da802fa3fedb0ad6b8f20f
Author: Tor Lillqvist 
Date:   Mon Aug 20 14:39:28 2012 +0300

Don't be shy

Change-Id: I806dcac11667abfd89a3202ed56e6370e18e185d

diff --git a/android/experimental/DocumentLoader/Makefile 
b/android/experimental/DocumentLoader/Makefile
index b9a75ee..917004a 100644
--- a/android/experimental/DocumentLoader/Makefile
+++ b/android/experimental/DocumentLoader/Makefile
@@ -257,7 +257,7 @@ build-ant: copy-stuff properties
 install: build-ant
unset JAVA_HOME && $(ANT) debug install
@echo
-   @echo 'Run it with something like what "make run" does (see Makefile)'
+   @echo 'Run it with "make run"'
@echo
 
 uninstall:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: gerrit: Why 'verified'?

2012-08-20 Thread Bjoern Michaelsen

On Mon, Aug 20, 2012 at 03:39:29PM +0200, Jan Holesovsky wrote:
> But this all is the implicit meaning of the +2, isn't it?

No, code-review means: the _code_ looks good to my human developer eyes.
verified means: builds, and passes all automatic or manual tests I care about.

Tinderboxes will set the verified flag only for example. A non-developer
running a build with the fix and checking for the bug can also set verified --
although he cannot really judge the implementation.

The separation makes some sense. For example we want tinderboxes to build as
much as possible. OTOH we dont want tinderboxes to build a change that some
anonyous guy uploaded without one of our commiters at least having a look 
first.(*)

Also ideally in the end you will set the change to +2 codereview and a
tinderbox later moves along and builds/tests the change. Once the tinderbox
reports it is happy too, the change gets merged.

Best,

Bjoern

(*) Nifty little keylogger implementation you injected in gbuild there ...
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

 sc/source/ui/dbgui/scuiasciiopt.cxx |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 5b985dcf72d31cee191711f879675ec9affa2f76
Author: Laurent Balland-Poirier 
Date:   Sat Aug 18 11:24:20 2012 +0200

fdo#47674 Save setting for Import Ascii Text Dlg

Caption of Dlg is missing Filename for import of CSV

Change-Id: Ia7202229e012008d1dd4ec6f7df0457d19e92a6c

diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx 
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index 4a25381..c3bfdbc 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -303,14 +303,13 @@ ScImportAsciiDlg::ScImportAsciiDlg( Window* 
pParent,String aDatName,
 String aName = GetText();
 switch (meCall)
 {
+case SC_TEXTTOCOLUMNS:
+SetText( maStrTextToColumns );
+break;
 case SC_IMPORTFILE:
 aName.AppendAscii(RTL_CONSTASCII_STRINGPARAM(" - ["));
 aName += aDatName;
 aName += ']';
-break;
-case SC_TEXTTOCOLUMNS:
-SetText( maStrTextToColumns );
-break;
 default:
 SetText( aName );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

libxml2 patches Re: xmllint problem validating using ODF RelaxNG

2012-08-20 Thread Michael Stahl

On 20/08/12 15:06, Daniel Veillard wrote:
> On Thu, Nov 17, 2011 at 05:45:10PM +, Michael Meeks wrote:

>>  Hopefully we're not doing validation in LibreOffice on load/save - but
>> this is more of an xmllint feature, so we don't need to update our
>> internal libxml2.

no validation is done of anything.

>>  Which reminds me - Daniel, we've inherited a number of 'interesting'
>> patches from OO.o on top of libxml2 and libxmlsec which are in git here:
>>
>>  http://cgit.freedesktop.org/libreoffice/core/tree/libxml2
> 
>   Never too late, I looked a it today. There was only one patch which
>   made sense upstream:
> 
> http://cgit.freedesktop.org/libreoffice/core/plain/libxml2/libxml2-latin.patch
> 
> the others either were updates to auto* files that were updated
> independantly, a change to linker file to export symbols I dont want to
> see exported ,

http://cgit.freedesktop.org/libreoffice/core/tree/libxml2/libxml2-global-symbols.patch

argh, don't remind me :-/

we should be able to get rid of that one though, as it is only necessary
for older Solaris 10 versions, and currently we don't really support
Solaris anyway in LO; from Solaris 10 Update 4 onwards there is libxml2
version 2.6.23 which has all the features needed for the libxmlsec we
use, so just using system libxml2/libxslt on Solaris should work; i
would hope libxml2/libxslt are available by default on all OpenSolaris
based distros.

> or things which had been changed upstream usually in
> slightly different ways :-)

by the way, is something like

http://cgit.freedesktop.org/libreoffice/core/tree/libxml2/libxml2-long-path.patch

also upstream? iirc there was some common configuration of Windows where
we would want to access paths that are longer than the ridiculously
small limit for the maximum path length on that ... platform, and then
they have some silly notation with \\? that supports long pathnames...

oh, there are some more patches for libxslt here, but i guess it's
mostly uninteresting stuff:

http://cgit.freedesktop.org/libreoffice/core/tree/libxslt
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][REVIEW 3-6-1 1/3] fdo#53252: File Open on "C:" crash

2012-08-20 Thread Tor Lillqvist

> Two more approvals needed for 3-6-1 branch.
>
> +1

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6][REVIEW 3-6-1 1/3] fdo#53252: File Open on "C:" crash

Stephan Bergmann píše v Po 20. 08. 2012 v 15:47 +0200:
> 
>  
> "fdo#53252: _toupper is unreliable" is a rather trivial fix for 3.6 MAB 
>  "UI: CRASH when 
> edit LibO File Dialog Path Pane." Please verify for backporting to 
> libreoffice-3-6 and libreoffice-3-6-1 (in case it's not too late).

Great catch! Looks sane and safe => pushed into 3-6 branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=d3d9ec4630a63cfc8879371752644262e4d9b4b8

Two more approvals needed for 3-6-1 branch.


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sal/osl

 sal/osl/w32/file_dirvol.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d3d9ec4630a63cfc8879371752644262e4d9b4b8
Author: Stephan Bergmann 
Date:   Mon Aug 20 15:18:35 2012 +0200

fdo#53252: _toupper is unreliable

 
"toupper,
_toupper, towupper, _toupper_l, _towupper_l: Visual Studio 2005" states: "In
order for toupper to give the expected results, __isascii and isupper must 
both
return nonzero."  But a community comment clarifies: "This is incorrect, and
should refer to '_toupper' (the macro form), not 'toupper'."  (Which makes
sense, as otherwise toupper would violate the C Standard.)

And indeed, at least for some LO built against MSVC 2008 Express on Windows 
7,
_toupper('C') = '#' is broken, while toupper('C') = 'C' is good.  (And the
unexpected '#' then causes all sorts of errors in the code.)

Change-Id: Iddaddcaf0cc3ffb30e55b0f410a6cfe9118accc8
Signed-off-by: Petr Mladek 

diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index d7a531c..47309a4 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -1116,7 +1116,7 @@ oslFileError SAL_CALL osl_getDirectoryItem(rtl_uString 
*strFilePath, oslDirector
 osl_acquireDirectoryItem( (oslDirectoryItem)pItemImpl );
 
 _tcscpy( pItemImpl->cDriveString, 
reinterpret_cast(strSysFilePath->buffer) );
-pItemImpl->cDriveString[0] = _toupper( 
pItemImpl->cDriveString[0] );
+pItemImpl->cDriveString[0] = toupper( 
pItemImpl->cDriveString[0] );
 
 if ( pItemImpl->cDriveString[_tcslen(pItemImpl->cDriveString) 
- 1] != '\\' )
 _tcscat( pItemImpl->cDriveString, TEXT( "\\" ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Announcing LibreOffice HardHacks!

2012-08-20 Thread Italo Vignoli

I think that we should spread the news by linking your post in the
announce mailing list and in a TDF blog post. I will do it later today,
as I am currently answering some media questions on the subject.

On 08/20/2012 02:40 AM, Bjoern Michaelsen wrote:
> Hi,
> 
> as already hinted at in the ESC minutes, here is the full announcement of the
> LibreOffice HardHacks:
> 
>  http://skyfromme.wordpress.com/2012/08/20/announcing-libreoffice-hardhacks/

-- 
Italo Vignoli - it...@italovignoli.com
mob +39.348.5653829 - VoIP 5316...@messagenet.it
skype italovignoli - gtalk italo.vign...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ATTENTION] Gerrit is now the primary git repo. Freedesktop is now read-only

2012-08-20 Thread Kohei Yoshida


On 08/18/2012 01:59 PM, Norbert Thiebaud wrote:

On Sat, Aug 18, 2012 at 12:15 PM, David Tardon  wrote:

Hi,


It seems that some branches that had been deleted on fd.o have crept
back. And they cannot be deleted again:

$ git push origin :feature/gbuild_sdext
remote: Processing changes: refs: 1, done
To ssh://dtardon@logerrit/core
  ! [remote rejected] feature/gbuild_sdext (can not delete references)
  error: failed to push some refs to 'ssh://dtardon@logerrit/core'


This seems to be an ACL issue as I was able to execute successfully
that very command.


I also had feature/calc-multiline-input re-appeared on gerrit (it had 
been deleted on fdo), and unable to remove it on gerrit for the exact 
same error message.


Could you delete that branch too?

Thanks,

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 4 commits - configure.in connectivity/Library_dbtools.mk ios/qa

 configure.in|7 +--
 connectivity/Library_dbtools.mk |2 +-
 ios/qa/sc/Makefile  |4 ++--
 3 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 18ac29d515af36ae4240d5d48dfa7814cfd8d075
Author: Tor Lillqvist 
Date:   Mon Aug 20 16:57:41 2012 +0300

No jvmaccess for iOS

Change-Id: Ifc83795c84cc82832a185317d4aa3554419e31e3

diff --git a/connectivity/Library_dbtools.mk b/connectivity/Library_dbtools.mk
index 0d321a0..4a26a31 100644
--- a/connectivity/Library_dbtools.mk
+++ b/connectivity/Library_dbtools.mk
@@ -54,7 +54,7 @@ $(eval $(call gb_Library_use_libraries,dbtools,\
cppuhelper \
sal \
salhelper \
-   jvmaccess \
+   $(if $(filter IOS,$(OS)),,jvmaccess) \
utl \
tl \
comphelper \
commit ac0d668a407cc441dacc7d9a9edb70aff555a518
Author: Tor Lillqvist 
Date:   Mon Aug 20 15:49:09 2012 +0300

Skip DISABLE_DBCONNECTIVITY attempts for now

Change-Id: I3d454d10aee05ce5b4bfd8ea0852bbc751933058

diff --git a/configure.in b/configure.in
index 6f8d115..3a52117 100644
--- a/configure.in
+++ b/configure.in
@@ -2239,9 +2239,12 @@ if test -z "$enable_database_connectivity"; then
 # Do enable database connectivity for Android for now as otherwise
 # we presumably will get linking errors... We are not as far in
 # the work for iOS, so we might as well disable it for iOS already.
-if test $_os != iOS; then
+
+# And actually, do enable it for iOS, too. Let's get back to
+# figuring out what to do with this later, if ever.
+#if test $_os != iOS; then
 enable_database_connectivity=yes
-fi
+#fi
 fi
 
 DISABLE_DBCONNECTIVITY=''
commit 616b6211b7c5165620d7b80467d1d02688d09a0d
Author: Tor Lillqvist 
Date:   Mon Aug 20 15:41:35 2012 +0300

No libi18npaperlo any more

Change-Id: I544a352fe0e43140d1bae62a95bf383c1432a076

diff --git a/ios/qa/sc/Makefile b/ios/qa/sc/Makefile
index 8707dd4..76d5450 100644
--- a/ios/qa/sc/Makefile
+++ b/ios/qa/sc/Makefile
@@ -39,7 +39,7 @@ SRCS = filters-test.m
 
 CFLAGS = $(SOLARINC)
 
-LIBS = -Wl,$(WORKDIR)/LinkTarget/CppunitTest/libtest_sc_filters_test.a 
$(foreach LIB, bin/cppunit/cppunittester lib/bootstrap.uno lib/configmgr.uno 
lib/expwrap.uno lib/fastsax.uno lib/i18npool.uno lib/introspection.uno 
lib/reflection.uno lib/stocservices.uno lib/unobootstrapprotector 
lib/unoexceptionprotector, -Wl,$(OUTDIR)/$(LIB).a) $(SOLARLIB) -lanalysislo 
-lavmedialo -lbasegfxlo -lcanvastoolslo -lcollator_data -lcomphelpgcc3 
-lcppcanvaslo -lcppunit -lcrypto -ldatelo -ldict_ja -ldict_zh -ldrawinglayerlo 
-leditenglo -lexpat_xmlparse -lexpat_xmltok -lfilterconfiglo -lforlo -lforuilo 
-lfwelo -lfwilo -lfwklo -lgcc3_uno -li18nisolang1gcc3 -li18npaperlo 
-li18nutilgcc3 -licudata -licui18n -licuuc -lindex_data -ljpeg -ljvmfwk -llnglo 
-llocaledata_en -llocaledata_es -llocaledata_euro -llocaledata_others 
-lmsfilterlo -looxlo -lpackage2 -lreg -lsal_textenc -lsalcpprt -lsaxlo 
-lscfiltlo -lsclo -lsfxlo -lsotlo -lstore -lsvllo -lsvtlo -lsvxlo -lsvxcorelo 
-ltest -ltextconv_dict -ltklo -l
 tllo -lucb1 -lucbhelper4gcc3 -lucpfile1 -lunoxmllo -luno_cppuhelpergcc3 
-luno_cppu -luno_sal -luno_salhelpergcc3 -lunotest -lutllo -lvcllo 
-lxmlscriptlo -lxml2 -lxmlreader -lxolo -lxstor -lz $(addprefix -framework , 
$(gb_Library__FRAMEWORKS)) -liconv -lobjc
+LIBS = -Wl,$(WORKDIR)/LinkTarget/CppunitTest/libtest_sc_filters_test.a 
$(foreach LIB, bin/cppunit/cppunittester lib/bootstrap.uno lib/configmgr.uno 
lib/expwrap.uno lib/fastsax.uno lib/i18npool.uno lib/introspection.uno 
lib/reflection.uno lib/stocservices.uno lib/unobootstrapprotector 
lib/unoexceptionprotector, -Wl,$(OUTDIR)/$(LIB).a) $(SOLARLIB) -lanalysislo 
-lavmedialo -lbasegfxlo -lcanvastoolslo -lcollator_data -lcomphelpgcc3 
-lcppcanvaslo -lcppunit -lcrypto -ldatelo -ldict_ja -ldict_zh -ldrawinglayerlo 
-leditenglo -lexpat_xmlparse -lexpat_xmltok -lfilterconfiglo -lforlo -lforuilo 
-lfwelo -lfwilo -lfwklo -lgcc3_uno -li18nisolang1gcc3 -li18nutilgcc3 -licudata 
-licui18n -licuuc -lindex_data -ljpeg -ljvmfwk -llnglo -llocaledata_en 
-llocaledata_es -llocaledata_euro -llocaledata_others -lmsfilterlo -looxlo 
-lpackage2 -lreg -lsal_textenc -lsalcpprt -lsaxlo -lscfiltlo -lsclo -lsfxlo 
-lsotlo -lstore -lsvllo -lsvtlo -lsvxlo -lsvxcorelo -ltest -ltextconv_dict 
-ltklo -ltllo -lucb1 -l
 ucbhelper4gcc3 -lucpfile1 -lunoxmllo -luno_cppuhelpergcc3 -luno_cppu -luno_sal 
-luno_salhelpergcc3 -lunotest -lutllo -lvcllo -lxmlscriptlo -lxml2 -lxmlreader 
-lxolo -lxstor -lz $(addprefix -framework , $(gb_Library__FRAMEWORKS)) -liconv 
-lobjc
 
 all: $(APPDIR)/$(APP) stuff
 
commit 69cf7d51c971f95df409b72b0695231a22037878
Author: Tor Lillqvist 
Date:   Mon Aug 20 15:38:50 2012 +0300

Just look at $(CC) to find out which arch the tree is for

Change-Id: I0af01be14f992a4842d174f06815e65895f0ee69

diff --git a/ios/qa/sc/Makefile b/ios/qa/sc/Makefile
index 4174214..8707dd4 100644
--- a/

Re: Liberation Fonts updated to 2.0

On Fri, 2012-08-17 at 13:02 +0100, Michael Meeks wrote:
> On Fri, 2012-08-17 at 11:08 +0100, Caolán McNamara wrote:
> > I don't think there are any risks, now that there's been a little burn
> > in time on master to test that there's no build/install cockups. 
> 
>   Great; so a +1 from me for -3-6 then :-)

so, pushed to 3-6 now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - more_fonts/fonts more_fonts/prj ooo.lst.in

 more_fonts/fonts/ttf_liberation/makefile.mk|   44 ++
 more_fonts/fonts/ttf_liberation_narrow/makefile.mk |   63 +
 more_fonts/prj/build.lst   |1 
 more_fonts/prj/d.lst   |6 +-
 ooo.lst.in |1 
 5 files changed, 87 insertions(+), 28 deletions(-)

New commits:
commit ee93da11b3395dc47e8718a8237ee2c650fbc85e
Author: CaolÃ¡n McNamara 
Date:   Thu Jul 26 17:47:21 2012 +0100

bump liberation fonts to 2.0

The 2.0 fonts are rebased on the google fonts and are now OFL and have a
shed-load more glyphs in them. But note that current releases does not 
include
Liberation Sans Narrow font because that couldn't be relicensed to OFL, so 
we
retain the Narrow version from the old release.

Change-Id: Ibd71055eed804cfe7629fb8d2ea7b9c900ba5710
(cherry picked from commit cb2536da21dcbd63aecdbc5ec45933afeff61772)

Signed-off-by: Michael Meeks 

diff --git a/more_fonts/fonts/ttf_liberation/makefile.mk 
b/more_fonts/fonts/ttf_liberation/makefile.mk
index 3a77bc1..8669508 100644
--- a/more_fonts/fonts/ttf_liberation/makefile.mk
+++ b/more_fonts/fonts/ttf_liberation/makefile.mk
@@ -1,29 +1,20 @@
-#*
 #
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-# 
-# Copyright 2000, 2010 Oracle and/or its affiliates.
+# This file is part of the LibreOffice project.
 #
-# OpenOffice.org - a multi-platform office productivity suite
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
-# This file is part of OpenOffice.org.
+# This file incorporates work covered by the following license notice:
 #
-# OpenOffice.org is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License version 3
-# only, as published by the Free Software Foundation.
+#   Licensed to the Apache Software Foundation (ASF) under one or more
+#   contributor license agreements. See the NOTICE file distributed
+#   with this work for additional information regarding copyright
+#   ownership. The ASF licenses this file to you under the Apache
+#   License, Version 2.0 (the "License"); you may not use this file
+#   except in compliance with the License. You may obtain a copy of
+#   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 #
-# OpenOffice.org is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Lesser General Public License version 3 for more details
-# (a copy is included in the LICENSE file that accompanied this code).
-#
-# You should have received a copy of the GNU Lesser General Public License
-# version 3 along with OpenOffice.org.  If not, see
-# 
-# for a copy of the LGPLv3 License.
-#
-#*
 
 PRJ=..$/..
 
@@ -35,10 +26,12 @@ TARGET=ttf_liberation
 .INCLUDE : settings.mk
 
 # --- Files 
-
-TARFILE_NAME=liberation-fonts-ttf-1.07.1
-TARFILE_MD5=0be45d54cc5e1c2e3102e32b8c190346
-TARFILE_ROOTDIR=liberation-fonts-ttf-1.07.1
+# Note: Current release does not include Liberation Sans Narrow font because
+# that couldn't be relicensed to OFL, so we take the Narrow version from
+# the old release
+TARFILE_NAME=liberation-fonts-ttf-2.00.0
+TARFILE_MD5=cfbf1ac6f61bf6cf45342a0cc9381be5
+TARFILE_ROOTDIR=liberation-fonts-ttf-2.00.0
 
 PATCH_FILES=
 
@@ -57,4 +50,3 @@ BUILD_FLAGS=
 .IF "$(WITH_FONTS)"!="NO"
 .INCLUDE : tg_ext.mk
 .ENDIF
-
diff --git a/more_fonts/fonts/ttf_liberation_narrow/makefile.mk 
b/more_fonts/fonts/ttf_liberation_narrow/makefile.mk
new file mode 100644
index 000..3d8ea73
--- /dev/null
+++ b/more_fonts/fonts/ttf_liberation_narrow/makefile.mk
@@ -0,0 +1,63 @@
+#*
+#
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+# 
+# Copyright 2000, 2010 Oracle and/or its affiliates.
+#
+# OpenOffice.org - a multi-platform office productivity suite
+#
+# This file is part of OpenOffice.org.
+#
+# OpenOffice.org is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License version 3
+# only, as published by the Free Software Foundation.
+#
+# OpenOffice.org is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License version 3 for more details
+# (a copy is included in the LICEN

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-20 Thread John Smith

On Mon, Aug 20, 2012 at 11:43 AM, Bjoern Michaelsen
 wrote:
> On Sun, Aug 19, 2012 at 09:14:52PM +0200, John Smith wrote:
>> When I run 'make help' I get this :
>>
>>unitcheckrun unit tests
>>slowcheckrun slow unit tests
>>subsequentcheck  run system tests (requires full installation)
>>checkrun unit tests and if in toplevel subsequentcheck
>>
>> Which gives me the idea that, when run from the top level, 'make
>> check' also runs 'make subsequentcheck ', and that it would make sense
>> to also run 'make unitcheck' and 'make slowcheck' here ? Or am I
>> missing something ?
>
> Make check on toplevel does dev-install and subsequentcheck. And dev-install
> includes both unitcheck and slowcheck.
>
> Best,
>
> Bjoern
>
Thanks, so 'make check' on the toplevel should be sufficient then to
run all the tests.

One more question: is there a make target that 'only' builds
libreoffice without building any of the tests ? ( I think maybe 'make
build' ?)

Im not sure if I really will need such a target, but I get the
impression that running just 'make' like this "*FLAGS+='-fprofile-arcs
-ftest-coverage' make" will result in the actual tests (code)
themselves be instrumented for coverage analysis as well as the
LibreOffice code; im not quite sure if this matters or not.


Regards,


John Smith.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-6][REVIEW 3-6-1] fdo#53252: File Open on "C:" crash

2012-08-20 Thread Stephan Bergmann

 
"fdo#53252: _toupper is unreliable" is a rather trivial fix for 3.6 MAB 
 "UI: CRASH when 
edit LibO File Dialog Path Pane."  Please verify for backporting to 
libreoffice-3-6 and libreoffice-3-6-1 (in case it's not too late).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gerrit: Why 'verified'?

2012-08-20 Thread Jan Holesovsky

Hi Eike,

On 2012-08-20 at 15:32 +0200, Eike Rathke wrote:

> > Please, what is the meaning of the 'verified' state in gerrit,
> 
> I interpreted it as "verified that the code compiles and works and
> doesn't break anything (hopefully ;-)"
> 
> > and can we get just rid of that?
> 
> I think the idea of 'verified' is to have at least one reviewer verify
> that code works before actually pushing it.

But this all is the implicit meaning of the +2, isn't it?

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sal/osl

 sal/osl/w32/file_dirvol.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e642eec333b9a80b04a9c19290d959de1f0ae5ff
Author: Stephan Bergmann 
Date:   Mon Aug 20 15:18:35 2012 +0200

fdo#53252: _toupper is unreliable

 
"toupper,
_toupper, towupper, _toupper_l, _towupper_l: Visual Studio 2005" states: "In
order for toupper to give the expected results, __isascii and isupper must 
both
return nonzero."  But a community comment clarifies: "This is incorrect, and
should refer to '_toupper' (the macro form), not 'toupper'."  (Which makes
sense, as otherwise toupper would violate the C Standard.)

And indeed, at least for some LO built against MSVC 2008 Express on Windows 
7,
_toupper('C') = '#' is broken, while toupper('C') = 'C' is good.  (And the
unexpected '#' then causes all sorts of errors in the code.)

Change-Id: Iddaddcaf0cc3ffb30e55b0f410a6cfe9118accc8

diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index 1a3114f..2736723 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -1117,7 +1117,7 @@ oslFileError SAL_CALL osl_getDirectoryItem(rtl_uString 
*strFilePath, oslDirector
 osl_acquireDirectoryItem( (oslDirectoryItem)pItemImpl );
 
 _tcscpy( pItemImpl->cDriveString, 
reinterpret_cast(strSysFilePath->buffer) );
-pItemImpl->cDriveString[0] = _toupper( 
pItemImpl->cDriveString[0] );
+pItemImpl->cDriveString[0] = toupper( 
pItemImpl->cDriveString[0] );
 
 if ( pItemImpl->cDriveString[_tcslen(pItemImpl->cDriveString) 
- 1] != '\\' )
 _tcscat( pItemImpl->cDriveString, TEXT( "\\" ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[REVIEW 3-6] resolved fdo#53325 CSV space delimiter and quoted field

Hi,

Please review and cherry-pick to 3-6
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44a402d5a05dd32aa2e1ab80c9ea75b560dc3b9
that fixes https://bugs.freedesktop.org/show_bug.cgi?id=53325

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpHHTK2RXbnc.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gerrit: Why 'verified'?

Hi Jan,

On Monday, 2012-08-20 15:18:36 +0200, Jan Holesovsky wrote:

> Please, what is the meaning of the 'verified' state in gerrit,

I interpreted it as "verified that the code compiles and works and
doesn't break anything (hopefully ;-)"

> and can we get just rid of that?

I think the idea of 'verified' is to have at least one reviewer verify
that code works before actually pushing it.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp5dERQ1IYQj.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

gerrit: Why 'verified'?

2012-08-20 Thread Jan Holesovsky

Hi there,

Please, what is the meaning of the 'verified' state in gerrit, and can
we get just rid of that?

It was not the first time I had to post my review twice, just because I
forgot to set the 'Verified' state that has no reasonable meaning I can
think of ;-)

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Use Thunderbird-like certificate selection GUI in pdf signin...

2012-08-20 Thread Gerrit

>From Jan Holesovsky :

Jan Holesovsky has submitted this change and it was merged.

Change subject: Use Thunderbird-like certificate selection GUI in pdf signing.
..


Use Thunderbird-like certificate selection GUI in pdf signing.

Change-Id: Ibe834f1aecc60ba09a2c19d75b094881b82c248a
---
M filter/source/pdf/impdialog.cxx
M filter/source/pdf/impdialog.hrc
M filter/source/pdf/impdialog.hxx
M filter/source/pdf/impdialog.src
4 files changed, 81 insertions(+), 50 deletions(-)

Approvals:
  Jan Holesovsky: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/431
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe834f1aecc60ba09a2c19d75b094881b82c248a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Gökçen Eraslan 
Gerrit-Reviewer: Jan Holesovsky 
Gerrit-Reviewer: Stephan Bergmann 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: filter/source

 filter/source/pdf/impdialog.cxx |   56 +---
 filter/source/pdf/impdialog.hrc |   22 ---
 filter/source/pdf/impdialog.hxx |   10 ---
 filter/source/pdf/impdialog.src |   41 +++--
 4 files changed, 80 insertions(+), 49 deletions(-)

New commits:
commit 74ae4c44627068192eb0bda6c22367dd33cb0316
Author: GÃ¶kÃ§en Eraslan 
Date:   Mon Aug 20 00:54:08 2012 +0200

Use Thunderbird-like certificate selection GUI in pdf signing.

Change-Id: Ibe834f1aecc60ba09a2c19d75b094881b82c248a
Reviewed-on: https://gerrit.libreoffice.org/431
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 9f1bb2c..8330730 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -44,6 +44,7 @@
 #include "com/sun/star/frame/XController.hpp"
 #include "com/sun/star/view/XSelectionSupplier.hpp"
 #include "com/sun/star/security/XDocumentDigitalSignatures.hpp"
+#include "com/sun/star/security/XCertificate.hpp"
 
 #include 
 
@@ -1683,7 +1684,10 @@ ImpPDFTabSigningPage::ImpPDFTabSigningPage( Window* 
pParent,
   const SfxItemSet& rCoreSet ) :
 SfxTabPage( pParent, PDFFilterResId( RID_PDF_TAB_SIGNING ), rCoreSet ),
 
-maCbSignPDF( this, PDFFilterResId( CB_SIGN_PDF ) ),
+maFtSignCert( this, PDFFilterResId( FT_SIGN_CERT_TEXT ) ),
+maEdSignCert( this, PDFFilterResId( ED_SIGN_CERT ) ),
+maPbSignCertSelect( this, PDFFilterResId( BTN_SIGN_CERT_SELECT ) ),
+maPbSignCertClear( this, PDFFilterResId( BTN_SIGN_CERT_CLEAR ) ),
 maFtSignPassword( this, PDFFilterResId( FT_SIGN_PASSWORD ) ),
 maEdSignPassword( this, PDFFilterResId( ED_SIGN_PASSWORD ) ),
 maFtSignLocation( this, PDFFilterResId( FT_SIGN_LOCATION ) ),
@@ -1692,12 +1696,13 @@ ImpPDFTabSigningPage::ImpPDFTabSigningPage( Window* 
pParent,
 maEdSignContactInfo( this, PDFFilterResId( ED_SIGN_CONTACT ) ),
 maFtSignReason( this, PDFFilterResId( FT_SIGN_REASON ) ),
 maEdSignReason( this, PDFFilterResId( ED_SIGN_REASON ) ),
-maPbSignSelectCert( this, PDFFilterResId( BTN_SIGN_SELECT_CERT ) ),
 maSignCertificate()
 {
 FreeResource();
 
-maPbSignSelectCert.SetClickHdl( LINK( this, ImpPDFTabSigningPage, 
ClickmaPbSignSelectCert ) );
+maPbSignCertSelect.Enable( true );
+maPbSignCertSelect.SetClickHdl( LINK( this, ImpPDFTabSigningPage, 
ClickmaPbSignCertSelect ) );
+maPbSignCertClear.SetClickHdl( LINK( this, ImpPDFTabSigningPage, 
ClickmaPbSignCertClear ) );
 }
 
 // 
-
@@ -1705,7 +1710,7 @@ ImpPDFTabSigningPage::~ImpPDFTabSigningPage()
 {
 }
 
-IMPL_LINK_NOARG( ImpPDFTabSigningPage, ClickmaPbSignSelectCert )
+IMPL_LINK_NOARG( ImpPDFTabSigningPage, ClickmaPbSignCertSelect )
 {
 
 uno::Sequence< uno::Any > aArgs( 2 );
@@ -1722,6 +1727,29 @@ IMPL_LINK_NOARG( ImpPDFTabSigningPage, 
ClickmaPbSignSelectCert )
 
 maSignCertificate = xSigner->chooseCertificate();
 
+if (maSignCertificate.is())
+{
+maEdSignCert.SetText(maSignCertificate->getSubjectName());
+maPbSignCertClear.Enable( true );
+maEdSignLocation.Enable( true );
+maEdSignPassword.Enable( true );
+maEdSignContactInfo.Enable( true );
+maEdSignReason.Enable( true );
+}
+
+return 0;
+}
+
+IMPL_LINK_NOARG( ImpPDFTabSigningPage, ClickmaPbSignCertClear )
+{
+maEdSignCert.SetText(OUString(""));
+maSignCertificate.clear();
+maPbSignCertClear.Enable( false );
+maEdSignLocation.Enable( false );
+maEdSignPassword.Enable( false );
+maEdSignContactInfo.Enable( false );
+maEdSignReason.Enable( false );
+
 return 0;
 }
 
@@ -1735,12 +1763,12 @@ SfxTabPage*  ImpPDFTabSigningPage::Create( Window* 
pParent,
 // 
-
 void ImpPDFTabSigningPage::GetFilterConfigItem( ImpPDFTabDialog* paParent  )
 {
-paParent->mbSignPDF = maCbSignPDF.IsChecked();
+paParent->mbSignPDF = maSignCertificate.is();
+paParent->maSignCertificate = maSignCertificate;
 paParent->msSignLocation = maEdSignLocation.GetText();
 paParent->msSignPassword = maEdSignPassword.GetText();
 paParent->msSignContact = maEdSignContactInfo.GetText();
 paParent->msSignReason = maEdSignReason.GetText();
-paParent->maSignCertificate = maSignCertificate;
 
 }
 
@@ -1748,16 +1776,14 @@ void ImpPDFTabSigningPage::GetFilterConfigItem( 
ImpPDFTabDialog* paParent  )
 void ImpPDFTabSigningPage::SetFilterConfigItem( const  ImpPDFTabDialog* 
paParent )
 {
 
-maCbSignPDF.SetToggleHdl( LINK( this, ImpPDFTabSigningPage, 
ToggleSignPDFHdl ) );
 maEdSignLocation.Enable( false );
 maEdSignPassword.Enable( false );
 maEdSignContactInfo.Enable( false );
 maEdSignReason.Enable( false );
-maPbSignSelectCert.Enab

Re: [Libreoffice] xmllint problem validating using ODF RelaxNG

2012-08-20 Thread Daniel Veillard

On Thu, Nov 17, 2011 at 05:45:10PM +, Michael Meeks wrote:
> Hi Dag & Daniel,
> 
> On Wed, 2011-11-16 at 14:43 +0100, Dag Wieers wrote:
> > There is a (known) problem when using xmllint with the ODF RelaxNG schema, 
> > that causes xmllint to fail with error message:
> > 
> >  Unimplemented block at relaxng.c:8948
> 
>   Hopefully we're not doing validation in LibreOffice on load/save - but
> this is more of an xmllint feature, so we don't need to update our
> internal libxml2.
> 
>   Which reminds me - Daniel, we've inherited a number of 'interesting'
> patches from OO.o on top of libxml2 and libxmlsec which are in git here:
> 
>   http://cgit.freedesktop.org/libreoffice/core/tree/libxml2

  Never too late, I looked a it today. There was only one patch which
  made sense upstream:

http://cgit.freedesktop.org/libreoffice/core/plain/libxml2/libxml2-latin.patch

the others either were updates to auto* files that were updated
independantly, a change to linker file to export symbols I dont want to
see exported , or things which had been changed upstream usually in
slightly different ways :-)


>   http://cgit.freedesktop.org/libreoffice/core/tree/libxmlsec

  That really should be forwarded to Aleksey Sanin 
who maintains xmlsec

>   (not a well formed report I'm afraid, and some are prolly uninteresting
> pragmatic nasties for internal compilation); We're using libxml2-2.7.6
> and xmlsec1-1.2.4 - prolly somewhat out of date due to the validation
> cost of updating them.
> 
> > Thanks to Daniel for the excellent support :-)
> 
>   And thanks for your heads up & nice to have Daniel on the CC of a mail
> again, it's been a while (somehow) :-)

 and as you can see I can be a bit slow at mails too, that doesn't help
 :-)

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: pptx import filter

2012-08-20 Thread Radek Doulik

Hi Jean-Tiare,

On Sun, 2012-08-19 at 10:25 -0400, Jean-Tiare LE BIGOT wrote:
> Hi all,
> 
> Thanks for the tip. I spend hours tracing the bug with GDB but I stuck. 
> I can not figure out where to fix it.
> 
> Here is the situation: I have a pptx file with
> 
> - title (fine)
> - 4 items in a list (buggy)
> 
> In Powerpoint, all the text in the list is 18p but a signe word is 8p.
> In Impress, the begin of the text is 20p, the word at 8p is 8p an the 
> remaining text is 8p also.
> 
> After bisecting the pptx file, it appears that there is an empty "span" 
> at the very beginning of the first list item. It's size is set to 20p. 
> The only other "span" with a size specified is the one at 8p. All other 
> elements have no size information on them.
> 
> When an element has no size specified, it is imported with the same size 
> as the immediate previous element whereas it should take the default 
> size specified in the theme. In my case, the size is specified in the 
> MasterSlide->OtherStyle->lvl1pPr.
> 
> in the import filter, there is a file 
> oox/source/drawingml/textrun.cxx:63 This is the only line where the size 
> appears to be used in a computation. Ideed, manually forcing the size to 
> 18 when at 0 fixes the problem for me.
> 
> But... It's really not the right place nor the right way to do it since 
> it would orverride the theme...
> I also know the themes in the master slide are imported properly.
> 
> I also traced the code down to pptshape.cxx where the text seems to be 
> imported into the core. I obviously missed something...
> 
> My question is: where can I fix this 

you run into quite complex area. The text list style can be set from
many sources (presentation style, master style, theme,
placeholders,  with various precedence). I think ppt/pptshape.cxx
and drawingml/shape.cxx are right places to look at.

I would start at Shape::createAndInsert and look where the wrong size
appears and try to find where it comes from and/or if the master style
was applied.

Cheers
Radek

> Thanks a lot for your help (and patient reading)
> 
> Le 2012-08-17 15:31, Miklos Vajna a écrit :
> > On Fri, Aug 17, 2012 at 03:54:25PM +0200, Jean-Tiare LE BIGOT 
> >  wrote:
> >> Is there anyone already working on the pptx import filter ?
> >> I'd like to work on the font size import.
> >>
> >> Is there any code shared between the pptx/docx/... filters ?
> >
> > Hi,
> >
> > Look under the oox/ module, that's shared between docx/xlsx/pptx.
> >
> > Miklos
> > ___
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> >
> 
> 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

QA Mission Statement (was: Re: Fwd: Re: Closing NEEDINFO bugs)

2012-08-20 Thread Nino Novak

Hi,

On 20. Aug 2012 00:56, Bjoern Michaelsen wrote:

> [...]
> The first goal of the QA team is [...]

nice statement :-)

I had the impulse to put it in a prominent place on the QA Homepage[1]. Feel
free to complete it or improve wording.

Nino
[1] http://wiki.documentfoundation.org/QA


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

 sc/source/ui/docshell/impex.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit b44a402d5a05dd32aa2e1ab80c9ea75b560dc3b9
Author: Eike Rathke 
Date:   Mon Aug 20 14:38:27 2012 +0200

resolved fdo#53325 CSV space delimiter and quoted field

CSV import didn't recognize end of field if a field was quoted and the
delimiter was space.

Change-Id: I46de608d545011437fe8a298854c134d6cf54b6b

diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 09da442..d110481 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -571,7 +571,10 @@ static QuoteType lcl_isFieldEndQuote( const sal_Unicode* 
p, const sal_Unicode* p
 // Due to broken CSV generators that don't double embedded quotes check if
 // a field separator immediately or with trailing spaces follows the quote,
 // only then end the field, or at end of string.
-while (p[1] == ' ')
+const sal_Unicode cBlank = ' ';
+if (p[1] == cBlank && ScGlobal::UnicodeStrChr( pSeps, cBlank))
+return FIELDEND_QUOTE;
+while (p[1] == cBlank)
 ++p;
 if (!p[1] || ScGlobal::UnicodeStrChr( pSeps, p[1]))
 return FIELDEND_QUOTE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/source

 sc/source/ui/docshell/docsh8.cxx |   33 +
 1 file changed, 33 insertions(+)

New commits:
commit c767178bd30e2a9430ff9140e0f2fcac5d2a5a10
Author: Tor Lillqvist 
Date:   Mon Aug 20 13:55:45 2012 +0300

Fix compilation in the (experimental) DISABLE_DBCONNECTIVITY case

Change-Id: I392b0203e0850a57eb3e1dfdaf21eafed838129b

diff --git a/sc/source/ui/docshell/docsh8.cxx b/sc/source/ui/docshell/docsh8.cxx
index 2868abc..96f0a7b 100644
--- a/sc/source/ui/docshell/docsh8.cxx
+++ b/sc/source/ui/docshell/docsh8.cxx
@@ -34,7 +34,10 @@
 #include 
 #include 
 #include 
+
+#ifndef DISABLE_DBCONNECTIVITY
 #include 
+#endif
 
 #include 
 #include 
@@ -104,6 +107,8 @@ using ::std::vector;
 #define SC_DBPROP_EXTENSION "Extension"
 #define SC_DBPROP_CHARSET   "CharSet"
 
+#ifndef DISABLE_DBCONNECTIVITY
+
 namespace
 {
 sal_uLong lcl_getDBaseConnection(uno::Reference& 
_rDrvMgr,uno::Reference& _rConnection,String& 
_rTabName,const String& rFullFileName,rtl_TextEncoding eCharSet)
@@ -159,6 +164,9 @@ namespace
 return 0L;
 }
 }
+
+#endif // !DISABLE_DBCONNECTIVITY
+
 // ---
 // MoveFile/KillFile/IsDocument: similar to SfxContentHelper
 
@@ -245,6 +253,8 @@ bool ScDocShell::IsDocument( const INetURLObject& rURL )
 
 // ---
 
+#ifndef DISABLE_DBCONNECTIVITY
+
 static void lcl_setScalesToColumns(ScDocument& rDoc, const vector& 
rScales)
 {
 SvNumberFormatter* pFormatter = rDoc.GetFormatTable();
@@ -292,9 +302,19 @@ static void lcl_setScalesToColumns(ScDocument& rDoc, const 
vector& rScales
 }
 }
 
+#endif // !DISABLE_DBCONNECTIVITY
+
 sal_uLong ScDocShell::DBaseImport( const String& rFullFileName, CharSet 
eCharSet,
ScColWidthParam aColWidthParam[MAXCOLCOUNT], 
ScFlatBoolRowSegments& rRowHeightsRecalc )
 {
+#ifdef DISABLE_DBCONNECTIVITY
+(void) rFullFileName;
+(void) eCharSet;
+(void) aColWidthParam;
+(void) rRowHeightsRecalc;
+
+return ERRCODE_IO_GENERAL;
+#else
 ScColumn::DoubleAllocSwitch aAllocSwitch(true);
 
 sal_uLong nErr = eERR_OK;
@@ -470,8 +490,11 @@ sal_uLong ScDocShell::DBaseImport( const String& 
rFullFileName, CharSet eCharSet
 aDocument.DoColResize( 0, 0, static_cast(nColCount) - 1, 0 );
 
 return nErr;
+#endif // !DISABLE_DBCONNECTIVITY
 }
 
+#ifndef DISABLE_DBCONNECTIVITY
+
 namespace {
 
 inline bool IsAsciiDigit( sal_Unicode c )
@@ -777,8 +800,17 @@ inline void lcl_getLongVarCharString( rtl::OUString& 
rString, ScBaseCell* pCell,
 
 }
 
+#endif // !DISABLE_DBCONNECTIVITY
+
 sal_uLong ScDocShell::DBaseExport( const rtl::OUString& rFullFileName, CharSet 
eCharSet, bool& bHasMemo )
 {
+#ifdef DISABLE_DBCONNECTIVITY
+(void) rFullFileName;
+(void) eCharSet;
+(void) bHasMemo;
+
+return ERRCODE_IO_GENERAL;
+#else
 // remove the file so the dBase driver doesn't find an invalid file
 INetURLObject aDeleteObj( rFullFileName, INET_PROT_FILE );
 KillFile( aDeleteObj );
@@ -1156,6 +1188,7 @@ sal_uLong ScDocShell::DBaseExport( const rtl::OUString& 
rFullFileName, CharSet e
 }
 
 return nErr;
+#endif // !DISABLE_DBCONNECTIVITY
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PUSHED][PATCH] fix various JavaDoc issues in the Java code

2012-08-20 Thread Noel Grandin



On 2012-08-20 13:56, Caolán McNamara wrote:

On Fri, 2012-08-17 at 17:13 +0200, Noel Grandin wrote:

Hi

These patches fix various javadoc issues in the java code.

Regards, Noel Grandin

That's a lot of work :-), pushed now. Does this mean we're javadoc
warning free now ? And if we, is there a error-out-on-warning javadoc
option we can enable to lock in those wins ?

C.



No, there are still a few warnings here and there. I left anything I 
wasn't confident in fixing.

I'm using Eclipse's built-in checker to find these.

It would be possible to run the javadoc tool and parse the output to 
find problems, but that would be a separate step in the build process, 
it's not just an option to the javac compiler.


Disclaimer: http://www.peralex.com/disclaimer.html


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ATTENTION] Gerrit is now the primary git repo. Freedesktop is now read-only

2012-08-20 Thread Jan Holesovsky

Hi Petr, all,

On 2012-08-20 at 12:56 +0200, Petr Mladek wrote:

> I have many clones, so I created the attached script to do the job:

I've just pushed:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa6808ba1163b22ce31d205eedb8f8718eeb7263

With this, it is enough to do:

./g --set-push-user 

and you are done :-)

[no need to add anything to the .ssh/config either]

Apologies for accidentally pushing that to libreoffice-3-6-1 branch, I
forgot to check the branch I was on before pushing.

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: g

 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aa6808ba1163b22ce31d205eedb8f8718eeb7263
Author: Jan Holesovsky 
Date:   Mon Aug 20 13:58:37 2012 +0200

Update ./g --set-push-user to work with gerrit.

Change-Id: If83b29222740e9d479d8b3c9b9d90ccc3706cd49

diff --git a/g b/g
index 902f3ac..a82fc31 100755
--- a/g
+++ b/g
@@ -258,7 +258,7 @@ for REPO in $DIRS ; do
 
 if [ -d "$DIR" -a "z$PUSH_USER" != "z" ]; then
echo "setting up push url for $DIR"
-   (cd $DIR && git config remote.origin.pushurl 
"ssh://${PUSH_USER}@git.freedesktop.org/git/libreoffice/${REPO}")
+   (cd $DIR && git config remote.origin.pushurl 
"ssh://${PUSH_USER}@gerrit.libreoffice.org:29418/${REPO}")
 elif [ -d "$DIR" -a "z$LAST_WORKING" != "z" ]; then
echo "fetching notes for $REPO ..."
(cd $DIR && git fetch origin 'refs/notes/*:refs/notes/*')
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-6-1' - g

 g |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8b2e53b30ead136ccf74e1f7bb5295d68080585f
Author: Jan Holesovsky 
Date:   Mon Aug 20 13:58:37 2012 +0200

Update ./g --set-push-user to work with gerrit.

Change-Id: If83b29222740e9d479d8b3c9b9d90ccc3706cd49

diff --git a/g b/g
index 11ecaa6..1657481 100755
--- a/g
+++ b/g
@@ -251,7 +251,7 @@ for REPO in $DIRS ; do
 
 if [ -d "$DIR" -a "z$PUSH_USER" != "z" ]; then
echo "setting up push url for $DIR"
-   (cd $DIR && git config remote.origin.pushurl 
"ssh://${PUSH_USER}@git.freedesktop.org/git/libreoffice/${REPO}")
+   (cd $DIR && git config remote.origin.pushurl 
"ssh://${PUSH_USER}@gerrit.libreoffice.org:29418/${REPO}")
 elif [ -d "$DIR" -a "z$LAST_WORKING" != "z" ]; then
echo "fetching notes for $REPO ..."
(cd $DIR && git fetch origin 'refs/notes/*:refs/notes/*')
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PUSHED][PATCH] fix various JavaDoc issues in the Java code

On Fri, 2012-08-17 at 17:13 +0200, Noel Grandin wrote:
> Hi
> 
> These patches fix various javadoc issues in the java code.
> 
> Regards, Noel Grandin

That's a lot of work :-), pushed now. Does this mean we're javadoc
warning free now ? And if we, is there a error-out-on-warning javadoc
option we can enable to lock in those wins ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Fix TDE VCL interface

On Sun, 2012-08-19 at 03:44 -0500, Timothy Pearson wrote:
> This patch restores the TDE VCL and filepicker interfaces to full
> functionality in LO 3.6.0:
> http://git.trinitydesktop.org/cgit/tde/plain/main/thirdparty/libreoffice/3.6.0/patches/libreoffice-fix-tde-vcl.diff
> 
> This patch does not affect the KDE3 plugin and should be committed to LO
> GIT.  The LO code currently in GIT both does not display widgets and also
> hangs when used under TDE; this patch resolves these issues.

Fair enough, pushed to master now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/unx

 vcl/unx/generic/plugadapt/salplug.cxx |3 -
 vcl/unx/kde/UnxFilePicker.cxx |8 ++
 vcl/unx/kde/fpicker/kdefilepicker.cxx |   27 -
 vcl/unx/kde/fpicker/kdefilepicker.hxx |4 +
 vcl/unx/kde/salnativewidgets-kde.cxx  |   92 --
 5 files changed, 101 insertions(+), 33 deletions(-)

New commits:
commit af4ca5a8c6e2848cb855a15986d5c4c9991140bf
Author: Timothy Pearson 
Date:   Mon Aug 20 12:40:33 2012 +0100

Fix TDE VCL interface

Change-Id: Ifd28ab758ba8be89a57c152d3fb9d361715bb33f

diff --git a/vcl/unx/generic/plugadapt/salplug.cxx 
b/vcl/unx/generic/plugadapt/salplug.cxx
index 4af49cd..67b806e 100644
--- a/vcl/unx/generic/plugadapt/salplug.cxx
+++ b/vcl/unx/generic/plugadapt/salplug.cxx
@@ -189,10 +189,7 @@ static SalInstance* autodetect_plugin()
 else if ( desktop == DESKTOP_GNOME )
 pList = pStandardFallbackList;
 else if( desktop == DESKTOP_TDE )
-{
 pList = pTDEFallbackList;
-nListEntry = 1;
-}
 else if( desktop == DESKTOP_KDE )
 {
 pList = pKDEFallbackList;
diff --git a/vcl/unx/kde/UnxFilePicker.cxx b/vcl/unx/kde/UnxFilePicker.cxx
index f217720..5c06e25 100644
--- a/vcl/unx/kde/UnxFilePicker.cxx
+++ b/vcl/unx/kde/UnxFilePicker.cxx
@@ -81,7 +81,11 @@ namespace
 uno::Sequence aRet(3);
 aRet[0] = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ui.dialogs.FilePicker"));
 aRet[1] = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ui.dialogs.SystemFilePicker"));
+#ifdef ENABLE_TDE
+aRet[2] = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ui.dialogs.TDEFilePicker"));
+#else // ENABLE_TDE
 aRet[2] = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ui.dialogs.KDEFilePicker"));
+#endif // ENABLE_TDE
 return aRet;
 }
 }
@@ -717,7 +721,11 @@ void UnxFilePicker::initFilePicker()
 #endif
 
 // The executable name
+#ifdef ENABLE_TDE
+rtl::OUString helperurl( 
RTL_CONSTASCII_USTRINGPARAM("${ORIGIN}/tdefilepicker"));
+#else // ENABLE_TDE
 rtl::OUString helperurl( 
RTL_CONSTASCII_USTRINGPARAM("${ORIGIN}/kdefilepicker"));
+#endif // ENABLE_TDE
 rtl::Bootstrap::expandMacros( helperurl );
 rtl::OUString helperpath;
 osl::FileBase::getSystemPathFromFileURL( helperurl, helperpath );
diff --git a/vcl/unx/kde/fpicker/kdefilepicker.cxx 
b/vcl/unx/kde/fpicker/kdefilepicker.cxx
index d52a6a7..6b5bba1 100644
--- a/vcl/unx/kde/fpicker/kdefilepicker.cxx
+++ b/vcl/unx/kde/fpicker/kdefilepicker.cxx
@@ -85,6 +85,14 @@
 
 #endif // ENABLE_TDE
 
+#ifdef ENABLE_TDE
+#define QCheckBox_String"TQCheckBox"
+#define QComboBox_String"TQComboBox"
+#else // ENABLE_TDE
+#define QCheckBox_String"QCheckBox"
+#define QComboBox_String"QComboBox"
+#endif // ENABLE_TDE
+
 #include 
 #include 
 
@@ -104,8 +112,13 @@ KDEFileDialog::KDEFileDialog( const QString &startDir, 
const QString &filter,
   m_bIsExecuting( false ),
   m_bCanNotifySelection( true )
 {
+#ifdef ENABLE_TDE
+connect( this, SIGNAL( fileHighlighted( const TQString & ) ),
+ this, SLOT( fileHighlightedCommand( const TQString & ) ) );
+#else // ENABLE_TDE
 connect( this, SIGNAL( fileHighlighted( const QString & ) ),
  this, SLOT( fileHighlightedCommand( const QString & ) ) );
+#endif // ENABLE_TDE
 
 connect( this, SIGNAL( selectionChanged() ),
  this, SLOT( selectionChangedCommand() ) );
@@ -434,7 +447,7 @@ void KDEFileDialog::getValue( const QString &rId, const 
QString &rAction )
 if ( pWidget )
 {
 QCString qClassName = pWidget->className();
-if ( qClassName == "QCheckBox" )
+if ( qClassName == QCheckBox_String )
 {
 QCheckBox *pCheckBox = static_cast< QCheckBox* >( pWidget );
 
@@ -443,7 +456,7 @@ void KDEFileDialog::getValue( const QString &rId, const 
QString &rAction )
 else
 qString.append( " bool false" );
 }
-else if ( qClassName == "QComboBox" )
+else if ( qClassName == QComboBox_String )
 {
 QComboBox *pComboBox = static_cast< QComboBox* >( pWidget );
 if ( rAction == "getItems" )
@@ -480,14 +493,14 @@ void KDEFileDialog::setValue( const QString &rId, const 
QString &rAction, const
 if ( pWidget )
 {
 QCString qClassName = pWidget->className();
-if ( qClassName == "QCheckBox" )
+if ( qClassName == QCheckBox_String )
 {
 QCheckBox *pCheckBox = static_cast< QCheckBox* >( pWidget );
 
 bool bValue = ( !rValue.isEmpty() ) && ( rValue.front().lower() == 
"true" );
 pCheckBox->setChecked( bValue );
 }
-else if ( qClassName == "QComboBox" )
+else if ( qClassName == QComboBox_String )
 {
 QComboBox *pComboBox = static_cast< QComboBox* >( pWidget );
 if ( rAction == "addItem" )
@@ -562,7 +575,7 @@ QStr

Re: [GSOC-UDPATE](17.08) Impress Remote

Hi Andrzej,

On Fri, 2012-08-17 at 21:33 +0200, Andrzej J. R. Hunt wrote:
> I finally managed to get dbus control of bluetooth working today, and
> started working on the actual communication

Nice :-)

> One issue is powering up bluetooth on Android: documentation insists
> that you ask the user to switch on bluetooth: one option is to add an
> item "Search for Bluetooth" devices on the selection screen which does
> this, or alternatively to just ask the user every single time the app
> is started.

I -imagine- that UX wise, enabling bluetooth during a pairing flow, and
disabling it again if we don't connect is perhaps the best plan from a
UX & battery perspective ?

>  On a related note, I assume it's worth adding an "Add computer
> manually" item to the same screen for cases where server discovery
> doesn't work (e.g. if the router doesn't pass on multicast packets).

Yep - I guess so; "type your IP address here" or whatever ?

> If it's ok with everyone I'm going to include cleaned bluetooth
> headers, from android, in the source tree to avoid the need for
> installing a library which isn't actually linked or used. (Headers
> viewable

Makes perfect sense; it'd be good to ensure that these are in a
top-level directory, with a link to where they came from (as below).

> Assuming tests on my home network go fine I should publish a first apk
> this coming Monday, when I'll do the last bits of transitioning to
> ABS.

Perhaps the best thing to do is to get a 'make' in android/ to compile
the .apk inside our build tree, and work with Tor to get them building &
up-loading automatically from the new Android tinderboxen :-)

Nice work though,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sfx2/inc sfx2/source

 sfx2/inc/sfx2/app.hxx|1 -
 sfx2/inc/sfx2/objsh.hxx  |1 -
 sfx2/source/appl/app.cxx |1 -
 sfx2/source/appl/appmain.cxx |6 --
 sfx2/source/doc/objmisc.cxx  |6 --
 5 files changed, 15 deletions(-)

New commits:
commit 5eac8941849c30b454f8a1e74a232cd995fc57d3
Author: CaolÃ¡n McNamara 
Date:   Mon Aug 20 12:24:14 2012 +0100

PreInit and MemoryError can be removed from core

The logic of 8fb5a686f40eadd2bdd9519fc65f23cc29ec3163 in binfilter
appears to hold for core as well

Change-Id: I73cd47586c4c83858f9eca92e019ad0108b514e0

diff --git a/sfx2/inc/sfx2/app.hxx b/sfx2/inc/sfx2/app.hxx
index 80be15d..5ff15f2 100644
--- a/sfx2/inc/sfx2/app.hxx
+++ b/sfx2/inc/sfx2/app.hxx
@@ -136,7 +136,6 @@ class SFX2_DLLPUBLIC SfxApplication: public SfxShell
 voidInit();
 voidExit();
 voidSettingsChange( sal_uInt16, const AppSettings 
& );
-voidPreInit( );
 voidQuit();
 voidDeinitialize();
 
diff --git a/sfx2/inc/sfx2/objsh.hxx b/sfx2/inc/sfx2/objsh.hxx
index 5e96dc8..4b1c16b 100644
--- a/sfx2/inc/sfx2/objsh.hxx
+++ b/sfx2/inc/sfx2/objsh.hxx
@@ -443,7 +443,6 @@ public:
 // Misc
 sal_BoolIsPreview() const;
 SfxObjectCreateMode GetCreateMode() const { return eCreateMode; }
-virtual voidMemoryError();
 SfxProgress*GetProgress() const;
 voidSetWaitCursor( sal_Bool bSet ) const;
 
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index 4ee6df4..3aa48ab 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -187,7 +187,6 @@ SfxApplication::SfxApplication()
 
 pAppData_Impl = new SfxAppData_Impl( this );
 pAppData_Impl->m_xImeStatusWindow->init();
-pApp->PreInit();
 
 RTL_LOGFILE_CONTEXT_TRACE( aLog, "{ initialize DDE" );
 
diff --git a/sfx2/source/appl/appmain.cxx b/sfx2/source/appl/appmain.cxx
index d2f66bf..edf1478 100644
--- a/sfx2/source/appl/appmain.cxx
+++ b/sfx2/source/appl/appmain.cxx
@@ -103,12 +103,6 @@ void SfxApplication::Exit()
 {
 }
 
-//---
-
-void SfxApplication::PreInit( )
-{
-}
-
 //-
 
 SfxFilterMatcher& SfxApplication::GetFilterMatcher()
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index ada681f..842d716 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -983,12 +983,6 @@ void SfxObjectShell::SetNoName()
 
 //
 
-void SfxObjectShell::MemoryError()
-{
-}
-
-//
-
 SfxProgress* SfxObjectShell::GetProgress() const
 {
 return pImp->pProgress;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Few notes about optimizing files (Windows OS)

Hi there,

On Sun, 2012-08-19 at 00:27 -0700, ape wrote:
> Few notes about optimizing files that are loaded into RAM at startup
> LibreOffice.

Yep - this dumb icon bloat in the soffice.bin is a well known issue
that we'd love to have fixed.

>   I don't know programming and use the resource editor for this
> purpose. Files (LibO-3.7.0_alpha+) that allow you to check my notes
> are attached.

The real work here is splitting up the DLLs during the build process,
and hacking the gnumakefiles to generate improved DLLs, that is quite
some work & testing and would be much appreciated.

We use the same icons in a somewhat non-obvious way to set window
decoration icons in the vcl/ windows backend IIRC - there was once an
easyhack to fix that to use the themed images.zip instead. 

All the best,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] binfilter: remove two unused methods

On Mon, 2012-08-20 at 07:39 +0200, Thomas Arnhold wrote:

looks good to me, pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: binfilter/bf_sfx2 binfilter/inc

 binfilter/bf_sfx2/source/appl/sfx2_app.cxx |1 -
 binfilter/bf_sfx2/source/appl/sfx2_appmain.cxx |5 -
 binfilter/bf_sfx2/source/doc/sfx2_objmisc.cxx  |7 ---
 binfilter/inc/bf_sfx2/app.hxx  |1 -
 binfilter/inc/bf_sfx2/objsh.hxx|1 -
 5 files changed, 15 deletions(-)

New commits:
commit 8fb5a686f40eadd2bdd9519fc65f23cc29ec3163
Author: Thomas Arnhold 
Date:   Mon Aug 20 07:26:17 2012 +0200

remove two unused methods

Change-Id: Ib71b21246af0815d349ba1e5fca3613b86b9c12d

diff --git a/binfilter/bf_sfx2/source/appl/sfx2_app.cxx 
b/binfilter/bf_sfx2/source/appl/sfx2_app.cxx
index 2bab8e1..d99dc12 100644
--- a/binfilter/bf_sfx2/source/appl/sfx2_app.cxx
+++ b/binfilter/bf_sfx2/source/appl/sfx2_app.cxx
@@ -116,7 +116,6 @@ SfxApplication* SfxApplication::pApp = NULL;
 /*N*/
 /*N*/   pAppData_Impl = new SfxAppData_Impl( this );
 /*N*/ pAppData_Impl->m_xImeStatusWindow->init();
-/*N*/ pApp->PreInit();
 /*N*/
 /*N*/ pCfgMgr = new SfxConfigManager;
 /*N*/ }
diff --git a/binfilter/bf_sfx2/source/appl/sfx2_appmain.cxx 
b/binfilter/bf_sfx2/source/appl/sfx2_appmain.cxx
index 48d612e..fa9dd2f 100644
--- a/binfilter/bf_sfx2/source/appl/sfx2_appmain.cxx
+++ b/binfilter/bf_sfx2/source/appl/sfx2_appmain.cxx
@@ -167,11 +167,6 @@ SV_DECL_PTRARR(SfxInitLinkList, LinkPtr, 4, 4)
 
 //---
 
-/*N*/ void SfxApplication::PreInit( )
-/*N*/ {
-/*N*/ }
-
-
 void SfxApplication::Main( )
 {
 }
diff --git a/binfilter/bf_sfx2/source/doc/sfx2_objmisc.cxx 
b/binfilter/bf_sfx2/source/doc/sfx2_objmisc.cxx
index f809c55..9c53209 100644
--- a/binfilter/bf_sfx2/source/doc/sfx2_objmisc.cxx
+++ b/binfilter/bf_sfx2/source/doc/sfx2_objmisc.cxx
@@ -571,13 +571,6 @@ namespace binfilter {
 
 //
 
-void SfxObjectShell::MemoryError()
-{
-DBG_BF_ASSERT(0, "STRIP");  // VIRTUAL
-}
-
-//
-
 /*N*/ SfxProgress* SfxObjectShell::GetProgress() const
 /*N*/ {
 /*N*/   return pImp->pProgress;
diff --git a/binfilter/inc/bf_sfx2/app.hxx b/binfilter/inc/bf_sfx2/app.hxx
index 7222fed..8f30f5b 100644
--- a/binfilter/inc/bf_sfx2/app.hxx
+++ b/binfilter/inc/bf_sfx2/app.hxx
@@ -216,7 +216,6 @@ public:
 
 virtual voidMain( );
 
-voidPreInit( );
 static SfxApplication*  GetOrCreate();
 voidQuit();
 voidInitLabelResMgr( const char* );
diff --git a/binfilter/inc/bf_sfx2/objsh.hxx b/binfilter/inc/bf_sfx2/objsh.hxx
index 6111770..42c2cc6 100644
--- a/binfilter/inc/bf_sfx2/objsh.hxx
+++ b/binfilter/inc/bf_sfx2/objsh.hxx
@@ -274,7 +274,6 @@ public:
 // Misc
 sal_BoolIsPreview() const;
 SfxObjectCreateMode GetCreateMode() const { return eCreateMode; }
-virtual voidMemoryError();
 SfxProgress*GetProgress() const;
 
 // Naming Interface
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: binfilter/bf_sd binfilter/bf_svtools binfilter/bf_svx binfilter/bf_sw binfilter/inc

 binfilter/bf_sd/source/filter/propread.hxx  |   12 -
 binfilter/bf_sd/source/filter/sd_propread.cxx   |   32 -
 binfilter/bf_svtools/source/misc/tl_strimp.cxx  |   44 --
 binfilter/bf_svtools/source/misc/tl_tstring.cxx |   42 ++
 binfilter/bf_svx/source/svdraw/makefile.mk  |1 
 binfilter/bf_svx/source/svdraw/svx_svdcrtv.cxx  |1 
 binfilter/bf_svx/source/svdraw/svx_svdpntv.cxx  |   65 --
 binfilter/bf_svx/source/svdraw/svx_svdvmark.cxx |   83 -
 binfilter/bf_sw/source/core/frmedt/sw_fews.cxx  |4 
 binfilter/bf_sw/source/ui/inc/edtwin.hxx|2 
 binfilter/bf_sw/source/ui/utlui/sw_initui.cxx   |1 
 binfilter/inc/bf_svx/svdpntv.hxx|   13 --
 binfilter/inc/bf_svx/svdvmark.hxx   |  153 
 binfilter/inc/bf_sw/fesh.hxx|3 
 binfilter/inc/bf_tools/string.hxx   |1 
 15 files changed, 44 insertions(+), 413 deletions(-)

New commits:
commit f8dafc05e3f2621bdd4ed871aaa00366792a2f48
Author: CaolÃ¡n McNamara 
Date:   Sun Aug 19 15:09:15 2012 +0100

callcatcher: ditch some unused methods

Change-Id: I11a0b7e8ee9ee419279c947dd282cd1437ff3e2f

diff --git a/binfilter/bf_sd/source/filter/propread.hxx 
b/binfilter/bf_sd/source/filter/propread.hxx
index 35ae1f9..4a9984b 100644
--- a/binfilter/bf_sd/source/filter/propread.hxx
+++ b/binfilter/bf_sd/source/filter/propread.hxx
@@ -105,18 +105,6 @@ class PropItem : public SvMemoryStream
 PropItem&   operator=( PropItem& rPropItem );
 };
 
-// 
-
-class Dictionary : protected List
-{
-friend class Section;
-
-public :
-Dictionary(){};
-~Dictionary();
-Dictionary& operator=( Dictionary& rDictionary );
-};
-
 } //namespace binfilter
 #endif
 
diff --git a/binfilter/bf_sd/source/filter/sd_propread.cxx 
b/binfilter/bf_sd/source/filter/sd_propread.cxx
index d8c8124..64583c7 100644
--- a/binfilter/bf_sd/source/filter/sd_propread.cxx
+++ b/binfilter/bf_sd/source/filter/sd_propread.cxx
@@ -40,38 +40,6 @@ PropItem& PropItem::operator=( PropItem& rPropItem )
 return *this;
 }
 
-//  ---
-
-struct Dict
-{
-sal_uInt32  mnId;
-String  aString;
-
-Dict( sal_uInt32 nId, String rString ) { mnId = nId; aString = 
rString; };
-};
-
-//  ---
-
-Dictionary::~Dictionary()
-{
-for ( void* pPtr = First(); pPtr; pPtr = Next() )
-delete (Dict*)pPtr;
-}
-
-//  ---
-
-Dictionary& Dictionary::operator=( Dictionary& rDictionary )
-{
-if ( this != &rDictionary )
-{
-void* pPtr; for ( pPtr = First(); pPtr; pPtr = Next() )
-delete (Dict*)pPtr;
-
-for ( pPtr = rDictionary.First(); pPtr; pPtr = rDictionary.Next() )
-Insert( new Dict( ((Dict*)pPtr)->mnId, ((Dict*)pPtr)->aString ), 
LIST_APPEND );
-}
-return *this;
-}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/binfilter/bf_svtools/source/misc/tl_strimp.cxx 
b/binfilter/bf_svtools/source/misc/tl_strimp.cxx
index 8e0641b..a30f8c1 100644
--- a/binfilter/bf_svtools/source/misc/tl_strimp.cxx
+++ b/binfilter/bf_svtools/source/misc/tl_strimp.cxx
@@ -531,50 +531,6 @@ xub_StrLen STRING::Search( STRCODE c, xub_StrLen nIndex ) 
const
 
 // ---
 
-xub_StrLen STRING::Search( const STRCODE* pCharStr, xub_StrLen nIndex ) const
-{
-DBG_CHKTHIS( STRING, DBGCHECKSTRING );
-
-sal_Int32 nLen = mpData->mnLen;
-xub_StrLen nStrLen  = ImplStringLen( pCharStr );
-
-// Falls die Laenge des uebergebenen Strings 0 ist oder der Index
-// hinter dem String liegt, dann wurde der String nicht gefunden
-if ( !nStrLen || (nIndex >= nLen) )
-return STRING_NOTFOUND;
-
-const STRCODE* pStr = mpData->maStr;
-pStr += nIndex;
-
-if ( nStrLen == 1 )
-{
-STRCODE cSearch = *pCharStr;
-while ( nIndex < nLen )
-{
-if ( *pStr == cSearch )
-return nIndex;
-++pStr,
-++nIndex;
-}
-}
-else
-{
-// Nur innerhalb des Strings suchen
-while ( nLen - nIndex >= nStrLen )
-{
-// Stimmt der String ueberein
-if ( ImplStringCompareWithoutZero( pStr, pCharStr, nStrLen ) == 0 )
-return nIndex;
-++pStr,
-++nIndex;
-}
-}
-
-return STRING_NOTFOUND;
-}
-
-// ---
-
 xub_StrLen STRING::GetTokenCount( STRCODE cTok ) const
 {
 DBG_CHKTHIS( STRING, DBGCHECKSTRING );
diff --git a/binfilter/bf_svtools/source/misc/tl_tstring.cxx 
b/binfil

[Libreoffice-commits] .: 2 commits - boost/boost.4713.warnings.patch sot/inc sot/source ucb/source unusedcode.easy xmlsecurity/source

 boost/boost.4713.warnings.patch|  119 
+-
 sot/inc/sot/storage.hxx|1 
 sot/source/sdstor/stgcache.cxx |5 
 sot/source/sdstor/stgcache.hxx |1 
 sot/source/sdstor/ucbstorage.cxx   |   54 
 ucb/source/ucp/cmis/cmis_content.cxx   |9 
 ucb/source/ucp/cmis/cmis_content.hxx   |2 
 unusedcode.easy|9 
 xmlsecurity/source/xmlsec/mscrypt/sanextension_mscryptimpl.cxx |6 
 xmlsecurity/source/xmlsec/mscrypt/sanextension_mscryptimpl.hxx |2 
 xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx |   23 -
 xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx |2 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx  |   11 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx  |1 
 xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx  |   10 
 xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx  |1 
 16 files changed, 128 insertions(+), 128 deletions(-)

New commits:
commit b972e05976e50c94e700800bbc78b54186c3b9f5
Author: CaolÃ¡n McNamara 
Date:   Mon Aug 20 10:16:48 2012 +0100

more shadow warnings at highest debugging levels

Change-Id: Iad5dd52961be6ef82836ccb5e9c12ab6bb3c034d

diff --git a/boost/boost.4713.warnings.patch b/boost/boost.4713.warnings.patch
index 6564c9b..d1224f6 100644
--- a/boost/boost.4713.warnings.patch
+++ b/boost/boost.4713.warnings.patch
@@ -906,7 +906,7 @@
  if( !allow_null )
  {
  BOOST_PTR_CONTAINER_THROW_EXCEPTION( 0 == x && "null not 
allowed", 
 misc/boost_1_44_0/boost/pool/object_pool.hpp.orig  2011-07-14 
16:08:31.672964851 +0100
+--- misc/boost_1_44_0/boost/pool/object_pool.hpp   2011-07-14 
16:08:31.672964851 +0100
 +++ misc/build/boost_1_44_0/boost/pool/object_pool.hpp 2011-07-14 
16:09:20.851594534 +0100
 @@ -53,8 +53,8 @@
  
@@ -957,3 +957,120 @@
  typedef boost::date_time::all_date_names_put 
facet_def;
  return std::locale(loc, new facet_def(w_short_month_names,
w_long_month_names,
+--- misc/boost_1_44_0/boost/date_time/time_facet.hpp   2012-08-20 
09:12:51.552094137 +0100
 misc/build/boost_1_44_0/boost/date_time/time_facet.hpp 2012-08-20 
09:10:07.884255317 +0100
+@@ -439,31 +439,31 @@
+   a_time_dur.get_rep().as_special());
+   }
+ 
+-  string_type format(m_time_duration_format);
++  string_type lcl_format(m_time_duration_format);
+   if (a_time_dur.is_negative()) {
+ // replace %- with minus sign.  Should we use the numpunct facet?
+-boost::algorithm::replace_all(format,
++boost::algorithm::replace_all(lcl_format,
+   duration_sign_negative_only,
+   negative_sign);
+   // remove all the %+ in the string with '-'
+-boost::algorithm::replace_all(format,
++boost::algorithm::replace_all(lcl_format,
+   duration_sign_always,
+   negative_sign);
+   }
+   else { //duration is positive
+ // remove all the %- combos from the string
+-boost::algorithm::erase_all(format, duration_sign_negative_only);
++boost::algorithm::erase_all(lcl_format, duration_sign_negative_only);
+ // remove all the %+ in the string with '+'
+-boost::algorithm::replace_all(format,
++boost::algorithm::replace_all(lcl_format,
+   duration_sign_always,
+   positive_sign);
+   }
+ 
+   // %T and %R have to be replaced here since they are not standard
+-  boost::algorithm::replace_all(format,
++  boost::algorithm::replace_all(lcl_format,
+ boost::as_literal(formats_type::full_24_hour_time_format),
+ boost::as_literal(formats_type::full_24_hour_time_expanded_format));
+-  boost::algorithm::replace_all(format,
++  boost::algorithm::replace_all(lcl_format,
+ boost::as_literal(formats_type::short_24_hour_time_format),
+ boost::as_literal(formats_type::short_24_hour_time_expanded_format));
+ 
+@@ -476,22 +476,22 @@
+* here ourself.
+*/
+   string_type hours_str;
+-  if (format.find(unrestricted_hours_format) != string_type::npos) {
++  if (lcl_format.find(unrestricted_hours_format) != string_type::npos) {
+ hours_str = hours_as_string(a_time_dur);
+-boost::algorithm::replace_all(format, unrestricted_hours_format, 
hours_str);
++boost::algorithm::replace_all(lcl_format, unrestricted_hours_format, 
hours_str);
+   }
+   // We still have to process restricted hours format

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - configure.in

 configure.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b30db013a27eaff3f7e938aff5565ec874e1e692
Author: Michael Stahl 
Date:   Mon Aug 20 12:41:08 2012 +0200

configure: fix S390X CPUNAME:

The value was changed to S390x, presumably by accident, breaking the
build (regression from 480b32d3809830002ecc28508d40af3ecd4ad272).

(cherry picked from commit 8c482683edf6aee17d4718150158293461b88b3b)

Change-Id: Icca90818c6363855437a273714a8317becdfd0e5
Signed-off-by: Rene Engelhard 

diff --git a/configure.in b/configure.in
index e631f6d..2cd5055 100644
--- a/configure.in
+++ b/configure.in
@@ -3258,7 +3258,7 @@ linux-gnu*)
 ;;
 s390x)
 CPU=3
-CPUNAME=S390x
+CPUNAME=S390X
 RTL_ARCH=S390x
 LIB64="lib64"
 OUTPATH=unxlngs390x
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - solenv/bin

 solenv/bin/concat-deps.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3877aa04dd0b424735b39d9c8874319ffce1ddd3
Author: Rene Engelhard 
Date:   Mon Aug 20 10:01:47 2012 +0200

concat-deps.c: add || defined (__FreeBSD_kernel__) for arch-specifics

Change-Id: Ie321ada6d2c078881fdedc61d72c94034297fea3
(cherry picked from commit 410b6f01f07f8f1a84f2118c71735cdbb5331d5f)

Signed-off-by: Michael Stahl 

diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c
index 28ac2ed..aab36e4 100644
--- a/solenv/bin/concat-deps.c
+++ b/solenv/bin/concat-deps.c
@@ -39,7 +39,7 @@
 
 #if defined(__linux) || defined(__OpenBSD__) || \
 defined(__FreeBSD__) || defined(__NetBSD__) || \
-defined(__DragonFly__)
+defined(__DragonFly__) || defined(__FreeBSD_kernel__)
 #if __BYTE_ORDER == __LITTLE_ENDIAN
 #define CORE_BIG_ENDIAN 0
 #define CORE_LITTLE_ENDIAN 1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: canvas/source

 canvas/source/cairo/cairo_canvashelper.cxx |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit b65b4160bfae737d3bc435f23d551bef65e02f81
Author: Radek Doulik 
Date:   Mon Aug 20 12:54:37 2012 +0200

fill whole polypolygon at once, so that fill rule is applied correctly

  - fixes rest of n#759172

Change-Id: I6c2694bf8276337b7d1fa54a12867bfc2b658a23

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 924e6f8..a7cf165 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -1045,12 +1045,6 @@ namespace cairocanvas
 if( aPolygon.isClosed() )
 cairo_close_path( pCairo );
 
-if( aOperation == Fill && pTextures )
-{
-cairo_set_matrix( pCairo, &aOrigMatrix );
-doOperation( aOperation, pCairo, pTextures, pDevice, 
aPolyPolygon.getB2DRange() );
-cairo_set_matrix( pCairo, &aIdentityMatrix );
-}
 }
 else
 {
@@ -1063,6 +1057,14 @@ namespace cairocanvas
 }
 }
 }
+
+if( aOperation == Fill && pTextures )
+{
+cairo_set_matrix( pCairo, &aOrigMatrix );
+doOperation( aOperation, pCairo, pTextures, pDevice, 
aPolyPolygon.getB2DRange() );
+cairo_set_matrix( pCairo, &aIdentityMatrix );
+}
+
 if( bOpToDo && ( aOperation != Fill || !pTextures ) )
 doOperation( aOperation, pCairo, pTextures, pDevice, 
aPolyPolygon.getB2DRange() );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [ATTENTION] Gerrit is now the primary git repo. Freedesktop is now read-only

Norbert Thiebaud píše v Pá 17. 08. 2012 v 13:53 -0500:
> core, binfitler, dictionaries, help and translations are now hosted
> primarely on gerrit.libreoffice.org
> 
> please update your .git/config to reflect that.
> the easiest way is to edit the [remote "origin"] entry
> 
> something like
> 
> [remote "origin"]
>   fetch = +refs/heads/*:refs/remotes/origin/*
>   url = ssh://logerrit/core.git

I have many clones, so I created the attached script to do the job:

Usage:  sh -x lo-git-to-gerrit path-to-core-dir

Warranty: I did my best. It worked here. You might want to use --dry-run
option before you run it for real :-)


Best Regards,
Petr


lo-git-to-gerrit
Description: application/shellscript
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - comphelper/inc comphelper/source configure.in sw/inc sw/JunitTest_sw_complex.mk sw/qa sw/source

 comphelper/inc/comphelper/TypeGeneration.hxx  |1 
 comphelper/source/property/TypeGeneration.cxx |2 
 configure.in  |2 
 sw/JunitTest_sw_complex.mk|2 
 sw/inc/cmdid.h|1 
 sw/inc/unoprnms.hxx   |   11 -
 sw/qa/complex/writer/CheckTable.java  |  273 +
 sw/source/core/unocore/unomap.cxx |1 
 sw/source/core/unocore/unoprnms.cxx   |1 
 sw/source/core/unocore/unotbl.cxx |  283 +++---
 10 files changed, 453 insertions(+), 124 deletions(-)

New commits:
commit 8c482683edf6aee17d4718150158293461b88b3b
Author: Michael Stahl 
Date:   Mon Aug 20 12:41:08 2012 +0200

configure: fix S390X CPUNAME:

The value was changed to S390x, presumably by accident, breaking the
build (regression from 480b32d3809830002ecc28508d40af3ecd4ad272).

Change-Id: Icca90818c6363855437a273714a8317becdfd0e5

diff --git a/configure.in b/configure.in
index c47a5fe..6f8d115 100644
--- a/configure.in
+++ b/configure.in
@@ -3459,7 +3459,7 @@ linux-gnu*)
 ;;
 s390x)
 CPU=3
-CPUNAME=S390x
+CPUNAME=S390X
 RTL_ARCH=S390x
 LIB64="lib64"
 OUTPATH=unxlngs390x
commit 139cbd048133321aebc3cd33d7be86597d468666
Author: Michael Stahl 
Date:   Mon Aug 20 12:37:41 2012 +0200

SwXTextTable::setPropertyValue: de-dent

Change-Id: Icad5dfcf8b9962623ac9f8954672a50a232bb9be

diff --git a/sw/source/core/unocore/unotbl.cxx 
b/sw/source/core/unocore/unotbl.cxx
index 5638ccf..7b9dc1b 100644
--- a/sw/source/core/unocore/unotbl.cxx
+++ b/sw/source/core/unocore/unotbl.cxx
@@ -3086,72 +3086,71 @@ void SwXTextTable::setPropertyValue(const OUString& 
rPropertyName,
 {
 break; // something else
 }
+SwDoc* pDoc = pFmt->GetDoc();
+SwFrm* pFrm = SwIterator::FirstElement( *pFmt 
);
+// tables without layout (invisible header/footer?)
+if (!pFrm)
 {
-SwDoc* pDoc = pFmt->GetDoc();
-SwFrm* pFrm = SwIterator::FirstElement( 
*pFmt );
-// tables without layout (invisible header/footer?)
-if( pFrm )
-{
-lcl_FormatTable(pFmt);
-SwTable* pTable = SwTable::FindTable( pFmt );
-SwTableLines &rLines = pTable->GetTabLines();
+break;
+}
+lcl_FormatTable(pFmt);
+SwTable* pTable = SwTable::FindTable( pFmt );
+SwTableLines &rLines = pTable->GetTabLines();
 
 
-// hier muessen die Actions aufgehoben werden
-UnoActionRemoveContext aRemoveContext(pDoc);
-const SwTableBox* pTLBox = 
lcl_FindCornerTableBox(rLines, true);
-const SwStartNode* pSttNd = pTLBox->GetSttNd();
-SwPosition aPos(*pSttNd);
-// set cursor to top left cell
-SwUnoCrsr* pUnoCrsr = pDoc->CreateUnoCrsr(aPos, 
sal_True);
-pUnoCrsr->Move( fnMoveForward, fnGoNode );
-pUnoCrsr->SetRemainInSection( sal_False );
+// hier muessen die Actions aufgehoben werden
+UnoActionRemoveContext aRemoveContext(pDoc);
+const SwTableBox* pTLBox = lcl_FindCornerTableBox(rLines, 
true);
+const SwStartNode* pSttNd = pTLBox->GetSttNd();
+SwPosition aPos(*pSttNd);
+// set cursor to top left cell
+SwUnoCrsr* pUnoCrsr = pDoc->CreateUnoCrsr(aPos, sal_True);
+pUnoCrsr->Move( fnMoveForward, fnGoNode );
+pUnoCrsr->SetRemainInSection( sal_False );
 
 
 
-const SwTableBox* pBRBox = 
lcl_FindCornerTableBox(rLines, false);
-pUnoCrsr->SetMark();
-pUnoCrsr->GetPoint()->nNode = *pBRBox->GetSttNd();
-pUnoCrsr->Move( fnMoveForward, fnGoNode );
-SwUnoTableCrsr* pCrsr = 
dynamic_cast(pUnoCrsr);
-pCrsr->MakeBoxSels();
+const SwTableBox* pBRBox = lcl_FindCornerTableBox(rLines, 
false);
+pUnoCrsr->SetMark();
+pUnoCrsr->GetPoint()->nNode = *pBRBox->GetSttNd();
+pUnoCrsr->Move( fnMoveForward, fnGoNode );
+SwUnoTableCrsr* pCrsr = 
dynamic_cast(pUnoCrsr);
+pCrsr->MakeBoxSels();
 
-S

Re: LibreOffice enhancements