[Libreoffice-ux-advise] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 --- Comment #13 from xordevore...@gmail.com --- > Here is the answer: > https://design.blog.documentfoundation.org/2016/04/01/the-many-faced-god- > part-2-how-libreoffice-draw-is-expected-to-evolve/ > I'd like to add my 2 cents regarding that document that's more than half a decade old, times change, and the bugs I lodge against LO Draw probably would never have been issues, or even ever crossed the minds, of end-users in 2016. In 2016, LO draw didn't have fuzzy shadows, glowing effects, or several other features that it has today. Did anywhere in that half-decade document call for such? Can we put ancient documentation aside and the locked-in mentality that goes with it and look toward the future? Because I've a whole list of approved enhancements waiting in the wings for a programmer to pick up eventually, and I've love for one day for those to be incorporated DESPITE not being in that ancient document. Thank you. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/source
desktop/source/lib/init.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit ac77d8a368e1ed21211bfe7768149481502317df
Author: Tomaž Vajngerl
AuthorDate: Fri Sep 3 12:04:08 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Sep 3 14:20:46 2021 +0200
indexing: add indexing xml as a format for writer
Needed so we can run "convert-to" service with COOL to produce
indexing XML documents.
Change-Id: Iabb77bd562a3307d0d20769a77f069e5250028ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121540
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit f35b9909070919013a753c382bff52614403c7a2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121576
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index cd2562be2a86..b803d1372a77 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -255,6 +255,7 @@ const ExtensionMap aWriterExtensionMap[] =
{ "txt", "Text" },
{ "xhtml", "XHTML Writer File" },
{ "png", "writer_png_Export" },
+{ "xml", "writer_indexing_export" },
{ nullptr, nullptr }
};
[Libreoffice-bugs] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 --- Comment #12 from Telesto --- Another request which slightly messes with the principle of one bug/topic for each report. But UX likes to combine things regarding the same dialog/UI. -- Based on bug 144279 The DPI spinbox shows integral numbers. However if you switch from Dots per inch to Pixel per CM the spinbox shows a rounded value (37), while internally the resolution is still exactly 96 PPI The dialog would be more self-explanatory if the spinbox did show some digits after the comma (Corel Paintshop has 3). This would explain the result by itself. And make it possible to input stuff behind the comma. If you touch the spinbox you lose the Dots per CM equivalent of say 96 DPI and you can't go back.. Yes, switching to DPI and go back to cm.. -- - More detailed: > You see that 96 pixels per inch doesn't mean some "round" number of pixels > per cm: 96 PPI = 37.7952755905512... pixels per cm. When you switch from in > to cm in the resolution, the control shows a rounded (down) value, but > internally the resolution is still exactly 96 PPI - which is *correct*, > because user might need just to check some different units without actually > change the resolution. However, when user starts to *modify* the resolution > using the new units, the new value is the integral number of pixels per unit > - and when you select 37 again, it is true 37 pixels per cm, not the initial > 37.7952755905512... which you started with. Hence the difference in the size > - which is again OK. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 --- Comment #12 from Telesto --- Another request which slightly messes with the principle of one bug/topic for each report. But UX likes to combine things regarding the same dialog/UI. -- Based on bug 144279 The DPI spinbox shows integral numbers. However if you switch from Dots per inch to Pixel per CM the spinbox shows a rounded value (37), while internally the resolution is still exactly 96 PPI The dialog would be more self-explanatory if the spinbox did show some digits after the comma (Corel Paintshop has 3). This would explain the result by itself. And make it possible to input stuff behind the comma. If you touch the spinbox you lose the Dots per CM equivalent of say 96 DPI and you can't go back.. Yes, switching to DPI and go back to cm.. -- - More detailed: > You see that 96 pixels per inch doesn't mean some "round" number of pixels > per cm: 96 PPI = 37.7952755905512... pixels per cm. When you switch from in > to cm in the resolution, the control shows a rounded (down) value, but > internally the resolution is still exactly 96 PPI - which is *correct*, > because user might need just to check some different units without actually > change the resolution. However, when user starts to *modify* the resolution > using the new units, the new value is the integral number of pixels per unit > - and when you select 37 again, it is true 37 pixels per cm, not the initial > 37.7952755905512... which you started with. Hence the difference in the size > - which is again OK. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144279] Exporting a selected shape of 7x7 to any image format shows size of 7, 01 cm when changing DPI to Dots per CM & increase it from 37 to 38 and back, size becomes 7, 16 c
https://bugs.documentfoundation.org/show_bug.cgi?id=144279 Telesto changed: What|Removed |Added Resolution|--- |NOTABUG CC||heiko.tietze@documentfounda ||tion.org Status|UNCONFIRMED |RESOLVED --- Comment #8 from Telesto --- (In reply to Mike Kaganski from comment #7) > You see that 96 pixels per inch doesn't mean some "round" number of pixels > per cm: 96 PPI = 37.7952755905512... pixels per cm. When you switch from in > to cm in the resolution, the control shows a rounded (down) value, but > internally the resolution is still exactly 96 PPI - which is *correct*, > because user might need just to check some different units without actually > change the resolution. However, when user starts to *modify* the resolution > using the new units, the new value is the integral number of pixels per unit > - and when you select 37 again, it is true 37 pixels per cm, not the initial > 37.7952755905512... which you started with. Hence the difference in the size > - which is again OK. Sorry, for me needing such an expansive answer; mea culpa The dialog would be more self-explanatory if the spinbox did show some digits after the comma (Corel Paintshop has 3). This would explain the result by itself. And make it possible to input stuff behind the comma. If you touch the spinbox you lose the Dots per CM equivalent of say 96 DPI and you can't go back.. Yes, switching to DPI and go back to CM.. Note: personally I dislike using pixels per cm, so not something affecting me per se.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144238 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144238 [Bug 144238] External content disabled for WEBSERVICE call -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144238] External content disabled for WEBSERVICE call
https://bugs.documentfoundation.org/show_bug.cgi?id=144238 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108827 CC||79045_79...@mail.ru Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108827 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||131516 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131516 [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 66402b476da8bcbd87f9dd7d7410ee48bfdeeadc Author: Olivier Hallot AuthorDate: Fri Sep 3 14:09:44 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 3 14:09:44 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 844431301fc078c697a22b332531369caa00612b - Revert "Create guide about Calc macros to format cell borders" This reverts commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3. Reason for revert: new file in wrong position Change-Id: Icebc9502ad250493c704d309eefeb388f6118c11 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121554 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index ce0d3ff57a73..844431301fc0 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3 +Subproject commit 844431301fc078c697a22b332531369caa00612b
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary text/sbasic
AllLangHelp_sbasic.mk |1
source/auxiliary/sbasic.tree |1
text/sbasic/guide/calc_borders.xhp | 248 -
3 files changed, 250 deletions(-)
New commits:
commit 844431301fc078c697a22b332531369caa00612b
Author: Olivier Hallot
AuthorDate: Fri Sep 3 14:08:40 2021 +0200
Commit: Olivier Hallot
CommitDate: Fri Sep 3 14:09:43 2021 +0200
Revert "Create guide about Calc macros to format cell borders"
This reverts commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3.
Reason for revert: new file in wrong position
Change-Id: Icebc9502ad250493c704d309eefeb388f6118c11
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121554
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index dc978fef3..fc3aca51c 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -19,7 +19,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
helpcontent2/source/text/sbasic/guide/access2base \
helpcontent2/source/text/sbasic/guide/basic_2_python \
helpcontent2/source/text/sbasic/guide/basic_examples \
-helpcontent2/source/text/sbasic/guide/calc_borders \
helpcontent2/source/text/sbasic/guide/control_properties \
helpcontent2/source/text/sbasic/guide/create_dialog \
helpcontent2/source/text/sbasic/guide/insert_control \
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index 3902268c6..9256c75d0 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -375,7 +375,6 @@
Event-Driven Macros
%PRODUCTNAME Basic Programming
Examples
Calling Python Scripts from
Basic
-Formatting Borders in Calc with
Macros
Access2Base, the API for Base
users
diff --git a/text/sbasic/guide/calc_borders.xhp
b/text/sbasic/guide/calc_borders.xhp
deleted file mode 100644
index 6ca63b619..0
--- a/text/sbasic/guide/calc_borders.xhp
+++ /dev/null
@@ -1,248 +0,0 @@
-
-
-
-
-
-
-Formatting Borders in Calc with
Macros
-/text/sbasic/guide/calc_borders.xhp
-
-
-
-
-
-macros;format borders
-
- Formatting
Borders in Calc with Macros
- By using Basic or
Python programming languages it is possible to write macros that apply formats
to ranges of cells in Calc.
-
- Formatting Borders in Ranges of Cells
- The code snippet
below creates a Sub called
FormatCellBorder that applies new border formats to a given
range address in the current Calc sheet.
-
-Sub
FormatCellBorder(cellAddress as String, newStyle as Byte, newWidth as Long,
Optional newColor as Long)
-' Creates the UNO
struct that will store the new line format
-
Dim lineFormat as New com.sun.star.table.BorderLine2
-
lineFormat.LineStyle = newStyle
-
lineFormat.LineWidth = newWidth
-
If Not IsMissing(newColor) Then lineFormat.Color = newColor
-' Gets the target
cell
-
Dim oCell as Object
-
Set oCell =
ThisComponent.CurrentController.ActiveSheet.getCellRangeByName(cellAddress)
-' Applies the new
format to all borders
-
oCell.TopBorder = lineFormat
-
oCell.RightBorder = lineFormat
-
oCell.LeftBorder = lineFormat
-
oCell.BottomBorder = lineFormat
-End
Sub
-
- The
Sub described above takes in four arguments:
-
-
-cellAddress is a string such as denoting the range
to be formatted in the format "A1".
-
-
-newStyle is an integer value that corresponds to
the border line style (see Line Styles below).
-
-
-newWidth is an integer value that defines the line
width.
-
-
-newColor is an integer value corresponding to a
color defined using the RGB function.
-
-
- To call
FormatCellBorder create a new macro and pass the desired
arguments, as shown below:
-
-Sub
MyMacro
-' Gives access to
the line style constants
-
Dim cStyle as Object
-
Set cStyle = com.sun.star.table.BorderLineStyle
-' Formats "B5"
with solid blue borders
-
FormatCellBorder("B5", cStyle.SOLID, 20, RGB(0, 0, 255))
-' Formats all
borders in the range "D2:F6" with red dotted borders
-
FormatCellBorder("D2:F6", cStyle.DOTTED, 20, RGB(255, 0, 0))
-End
Sub
-
- It is possible to
implement the same functionality in Python:
-
-from
uno import createUnoStruct
-from
scriptforge import CreateScriptService
-
-def
formatCellBorder(cellAddress, newStyle, newWidth, newColor=0):
-# Defines the new
line format
-
line_format = createUnoStruct("com.sun.star.table.BorderLine2")
-
line_format.LineStyle = newStyle
-
line_format.LineWidth = newWidth
-
line_format.Color = newColor
-# Scriptforge
service to access cell ranges
-
doc =
[Libreoffice-bugs] [Bug 144276] WEBSERVICE function to certain external URL results in #VALUE! error
https://bugs.documentfoundation.org/show_bug.cgi?id=144276 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1516 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4276 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4238 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144238] External content disabled for WEBSERVICE call
https://bugs.documentfoundation.org/show_bug.cgi?id=144238 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1516 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0784 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140784] The WEBSERVICE function doesn't work on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=140784 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1516 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66037] FILEOPEN: MathML formulas in HTML documents are not imported correctly, HTML5 import filter needed
https://bugs.documentfoundation.org/show_bug.cgi?id=66037 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||044 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66044] HTML5 export filter with MathML support
https://bugs.documentfoundation.org/show_bug.cgi?id=66044 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||037 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3959e3b76fd03734153666299bad40995fa55f30 Author: Rafael Lima AuthorDate: Fri Sep 3 13:59:59 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 3 13:59:59 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3 - Create guide about Calc macros to format cell borders Change-Id: Ia7bbbf25322775e3a291fcb474079b2e2bc4e41e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121461 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 5dd44ff1d347..ce0d3ff57a73 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a +Subproject commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary text/sbasic
AllLangHelp_sbasic.mk |1
source/auxiliary/sbasic.tree |1
text/sbasic/guide/calc_borders.xhp | 248 +
3 files changed, 250 insertions(+)
New commits:
commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3
Author: Rafael Lima
AuthorDate: Thu Sep 2 03:26:34 2021 +0200
Commit: Olivier Hallot
CommitDate: Fri Sep 3 13:59:57 2021 +0200
Create guide about Calc macros to format cell borders
Change-Id: Ia7bbbf25322775e3a291fcb474079b2e2bc4e41e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121461
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index fc3aca51c..dc978fef3 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
helpcontent2/source/text/sbasic/guide/access2base \
helpcontent2/source/text/sbasic/guide/basic_2_python \
helpcontent2/source/text/sbasic/guide/basic_examples \
+helpcontent2/source/text/sbasic/guide/calc_borders \
helpcontent2/source/text/sbasic/guide/control_properties \
helpcontent2/source/text/sbasic/guide/create_dialog \
helpcontent2/source/text/sbasic/guide/insert_control \
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index 9256c75d0..3902268c6 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -375,6 +375,7 @@
Event-Driven Macros
%PRODUCTNAME Basic Programming
Examples
Calling Python Scripts from
Basic
+Formatting Borders in Calc with
Macros
Access2Base, the API for Base
users
diff --git a/text/sbasic/guide/calc_borders.xhp
b/text/sbasic/guide/calc_borders.xhp
new file mode 100644
index 0..6ca63b619
--- /dev/null
+++ b/text/sbasic/guide/calc_borders.xhp
@@ -0,0 +1,248 @@
+
+
+
+
+
+
+Formatting Borders in Calc with
Macros
+/text/sbasic/guide/calc_borders.xhp
+
+
+
+
+
+macros;format borders
+
+ Formatting
Borders in Calc with Macros
+ By using Basic or
Python programming languages it is possible to write macros that apply formats
to ranges of cells in Calc.
+
+ Formatting Borders in Ranges of Cells
+ The code snippet
below creates a Sub called
FormatCellBorder that applies new border formats to a given
range address in the current Calc sheet.
+
+Sub
FormatCellBorder(cellAddress as String, newStyle as Byte, newWidth as Long,
Optional newColor as Long)
+' Creates the UNO
struct that will store the new line format
+
Dim lineFormat as New com.sun.star.table.BorderLine2
+
lineFormat.LineStyle = newStyle
+
lineFormat.LineWidth = newWidth
+
If Not IsMissing(newColor) Then lineFormat.Color = newColor
+' Gets the target
cell
+
Dim oCell as Object
+
Set oCell =
ThisComponent.CurrentController.ActiveSheet.getCellRangeByName(cellAddress)
+' Applies the new
format to all borders
+
oCell.TopBorder = lineFormat
+
oCell.RightBorder = lineFormat
+
oCell.LeftBorder = lineFormat
+
oCell.BottomBorder = lineFormat
+End
Sub
+
+ The
Sub described above takes in four arguments:
+
+
+cellAddress is a string such as denoting the range
to be formatted in the format "A1".
+
+
+newStyle is an integer value that corresponds to
the border line style (see Line Styles below).
+
+
+newWidth is an integer value that defines the line
width.
+
+
+newColor is an integer value corresponding to a
color defined using the RGB function.
+
+
+ To call
FormatCellBorder create a new macro and pass the desired
arguments, as shown below:
+
+Sub
MyMacro
+' Gives access to
the line style constants
+
Dim cStyle as Object
+
Set cStyle = com.sun.star.table.BorderLineStyle
+' Formats "B5"
with solid blue borders
+
FormatCellBorder("B5", cStyle.SOLID, 20, RGB(0, 0, 255))
+' Formats all
borders in the range "D2:F6" with red dotted borders
+
FormatCellBorder("D2:F6", cStyle.DOTTED, 20, RGB(255, 0, 0))
+End
Sub
+
+ It is possible to
implement the same functionality in Python:
+
+from
uno import createUnoStruct
+from
scriptforge import CreateScriptService
+
+def
formatCellBorder(cellAddress, newStyle, newWidth, newColor=0):
+# Defines the new
line format
+
line_format = createUnoStruct("com.sun.star.table.BorderLine2")
+
line_format.LineStyle = newStyle
+
line_format.LineWidth = newWidth
+
line_format.Color = newColor
+# Scriptforge
service to access cell ranges
+
doc = CreateScriptService("Calc")
+
cell = doc.XCellRange(cellAddress)
+
cell.TopBorder = line_format
+
cell.RightBorder = line_format
+
[Libreoffice-commits] mso-dumper.git: msodumper/binarystream.py
msodumper/binarystream.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0ffc7eac2596ff590eb7c7612940c7d785fea167
Author: Hossein
AuthorDate: Thu Sep 2 20:12:41 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 13:59:32 2021 +0200
Handling exception on invalid values of the fields
There are situations where a field has an invalid value. In such a
case, an exception is occurs, the program halts execution, and the
output will be incomplete.
With this fix, if a key is not found for the dict, name="INVALID"
will be use in the output XML.
This is an example execution for attachment 171572 from tdf#142021
, "EMF with PolyfillMode set to 0 before the bottom star record"
PolygonFillMode can be either 1 or 2, but the field value has the
value of 0.
PolygonFillMode = {
0x01: "ALTERNATE",
0x02: "WINDING"
}
$ /opt/libreoffice7.2/program/python ./emf-dump.py star_pfm0.emf
Traceback (most recent call last):
File "./emf-dump.py", line 29, in
main(sys.argv)
File "./emf-dump.py", line 25, in main
dumper.dump()
File "./emf-dump.py", line 20, in dump
strm.dump()
File "msodumper/emfrecord.py", line 76, in dump
handler.dump()
File "msodumper/emfrecord.py", line 400, in dump
self.printAndSet("PolygonFillMode", self.readuInt32(),
dict=PolygonFillMode)
File "msodumper/binarystream.py", line 32, in printAndSet
attrs += ' name="%s"' % dict[value]
KeyError: 0
Change-Id: Id965ba0c47eace3029dd5fa12266f1a144eee41e
Reviewed-on: https://gerrit.libreoffice.org/c/mso-dumper/+/121529
Tested-by: Miklos Vajna
Reviewed-by: Miklos Vajna
diff --git a/msodumper/binarystream.py b/msodumper/binarystream.py
index bdd8f37..4946a45 100644
--- a/msodumper/binarystream.py
+++ b/msodumper/binarystream.py
@@ -29,7 +29,7 @@ class BinaryStream:
attrs = ""
if dict:
if value in dict or default is None:
-attrs += ' name="%s"' % dict[value]
+attrs += ' name="%s"' % dict.get(value, "INVALID")
else:
attrs += ' name="%s"' % default
if hexdump and type(value) != float:
[Libreoffice-bugs] [Bug 144277] setting a hyperlink changes the character size
https://bugs.documentfoundation.org/show_bug.cgi?id=144277 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from V Stuart Foote --- check settings for character styles -- 'Internet Link' and 'Visited Internet Link' -- which you've applied by creating a Hyperlink pointing to the bookmark. Adjust their size to match the formatting applied to default paragraph and they won't resize. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 93156] Middle-of-connector anchor doesn't update its targets when moved
https://bugs.documentfoundation.org/show_bug.cgi?id=93156 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #15 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d350a1364a1c34b96d00f2f716c44882b7b57fe9 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144279] Exporting a selected shape of 7x7 to any image format shows size of 7, 01 cm when changing DPI to Dots per CM & increase it from 37 to 38 and back, size becomes 7, 16 c
https://bugs.documentfoundation.org/show_bug.cgi?id=144279 --- Comment #7 from Mike Kaganski --- (In reply to Telesto from comment #6) > why there is the variation.. > * 7,01 cm on dialog initialization. And 6,98 cm after bumping DPI to 97 and > back to 96. If this is a rounding should end up this way, please make it > consistent. This is reasonable. Please limit it to this. > * And even worse in case of switching from DPI to Pixel to CM. Where moving > 37 Pixel the CM up to 38 and back to 37 end up with 7,16 CM not 7,01 cm No it is fine. If you look above, I wrote: > You define a resolution: > > Note: assuming DPI 96 > > which means that each pixel is exactly 1/96 in ~ 0.264583 mm. You see that 96 pixels per inch doesn't mean some "round" number of pixels per cm: 96 PPI = 37.7952755905512... pixels per cm. When you switch from in to cm in the resolution, the control shows a rounded (down) value, but internally the resolution is still exactly 96 PPI - which is *correct*, because user might need just to check some different units without actually change the resolution. However, when user starts to *modify* the resolution using the new units, the new value is the integral number of pixels per unit - and when you select 37 again, it is true 37 pixels per cm, not the initial 37.7952755905512... which you started with. Hence the difference in the size - which is again OK. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144282] Crash when changing protection options on document
https://bugs.documentfoundation.org/show_bug.cgi?id=144282 --- Comment #1 from Steve Garry --- Created attachment 174759 --> https://bugs.documentfoundation.org/attachment.cgi?id=174759=edit copy of document downloard that is subject of bug Document downloaded as per details in bug report. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144282] New: Crash when changing protection options on document
https://bugs.documentfoundation.org/show_bug.cgi?id=144282 Bug ID: 144282 Summary: Crash when changing protection options on document Product: LibreOffice Version: 7.2.0.4 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@huntsgrove.ie Description: Downloaded a document that requires completion of text boxes and then upload to supplier. Form is protected on arrival. Change protect option, then go to section to change protect on field. On selecting second field, after a few moments, app crashes. Steps to Reproduce: 1.Open document 2.Change protect compatibility optio, then change section properties 3.enter data line 1, then tab to next box. Attempt data entry on second line, app crashes Actual Results: crash of app on selecting second text line Expected Results: Removal of original text to be replaced by typed entry Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes Version: 7.2.0.4 (x64) / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL Affected file that causes this crash can be downloaded from https://www.virginmedia.com/help/account-holder-has-died, the file causing problems is the bereavement transfer form that is available to download from the link -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125244] Option is grayed out to create trend lines for all data series
https://bugs.documentfoundation.org/show_bug.cgi?id=125244 --- Comment #6 from Commit Notification --- Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a tdf#125244 Fix instructions about Trend Lines in charts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125244] Option is grayed out to create trend lines for all data series
https://bugs.documentfoundation.org/show_bug.cgi?id=125244 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba5efc928a3842dfdc115bc6018f00349e9573c7 Author: Rafael Lima AuthorDate: Fri Sep 3 13:46:46 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 3 13:46:46 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a - tdf#125244 Fix instructions about Trend Lines in charts In the past it was possible to add trend lines for all data series at once. However this behavior changed and documentation had not been updated. Change-Id: I8c0e93a4d8e35aadc5e2454d49adff572fdf3028 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121552 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index ff74220156e7..5dd44ff1d347 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ff74220156e7dbf65d27d43759922c64130ee66b +Subproject commit 5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a
[Libreoffice-commits] help.git: source/text
source/text/schart/01/04050100.xhp | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) New commits: commit 5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a Author: Rafael Lima AuthorDate: Fri Sep 3 02:11:55 2021 +0200 Commit: Olivier Hallot CommitDate: Fri Sep 3 13:46:44 2021 +0200 tdf#125244 Fix instructions about Trend Lines in charts In the past it was possible to add trend lines for all data series at once. However this behavior changed and documentation had not been updated. Change-Id: I8c0e93a4d8e35aadc5e2454d49adff572fdf3028 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121552 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/schart/01/04050100.xhp b/source/text/schart/01/04050100.xhp index ee7ac03fe..4569d9bc5 100644 --- a/source/text/schart/01/04050100.xhp +++ b/source/text/schart/01/04050100.xhp @@ -87,20 +87,24 @@ Name of Y variable in trend line equation. If you insert a trend line to a chart type that uses categories, like Line or Column, then the numbers 1, 2, 3, … are used as x-values to calculate the trend line. For such charts the XY chart type might be more suitable. - + + -To insert a trend line for a data series, select the data series in the chart. Choose Insert - Trend Line, or right-click to open the context menu, and choose Insert Trend Line. +To insert a trend line for a data series, first double-click the chart to enter edit mode and select the data series in the chart to which a trend line is to be created. + + +Choose Insert - Trend Line, or right-click the data series to open the context menu, and choose Insert Trend Line. - Mean Value Lines are special trend lines that show the mean value. Use Insert - Mean Value Lines to insert mean value lines for data series. - To delete a trend line or mean value line, click the line, then press the Del key. - -A trend line is shown in the legend automatically. Its name can be defined in options of the trend line. + + +The menu item Insert - Trend Line is only available when the chart is in edit mode. It will appear grayed out if the chart is in edit mode but no data series is selected. The trend line has the same color as the corresponding data series. To change the line properties, select the trend line and choose Format - Format Selection - Line. +A trend line is shown in the legend automatically. Its name can be defined in options of the trend line. Trend Line Equation and Coefficient of Determination
[Libreoffice-bugs] [Bug 121613] Missing documentation for adjacent cells feature in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121613 --- Comment #1 from Commit Notification --- Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/ff74220156e7dbf65d27d43759922c64130ee66b tdf#121613 Add information about Adjacent Cells -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121613] Missing documentation for adjacent cells feature in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121613 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cfeb08efc9cdd74487917078223d208fbf7869c4 Author: Rafael Lima AuthorDate: Fri Sep 3 13:44:02 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 3 13:44:02 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to ff74220156e7dbf65d27d43759922c64130ee66b - tdf#121613 Add information about Adjacent Cells Change-Id: Ia16b0dd8c1cd7ae157b16c180fcd6737f58e7f4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121415 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 95e6fe8d728b..ff74220156e7 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 95e6fe8d728b7981e4262e71646fd212da1775aa +Subproject commit ff74220156e7dbf65d27d43759922c64130ee66b
[Libreoffice-commits] help.git: source/text
source/text/scalc/guide/borders.xhp | 54 +--- source/text/shared/01/05030500.xhp | 23 +-- 2 files changed, 46 insertions(+), 31 deletions(-) New commits: commit ff74220156e7dbf65d27d43759922c64130ee66b Author: Rafael Lima AuthorDate: Wed Sep 1 01:05:06 2021 +0200 Commit: Olivier Hallot CommitDate: Fri Sep 3 13:44:00 2021 +0200 tdf#121613 Add information about Adjacent Cells Change-Id: Ia16b0dd8c1cd7ae157b16c180fcd6737f58e7f4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121415 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/guide/borders.xhp b/source/text/scalc/guide/borders.xhp index 44cb2a7b6..885aad22e 100644 --- a/source/text/scalc/guide/borders.xhp +++ b/source/text/scalc/guide/borders.xhp @@ -1,6 +1,5 @@ - - - - User Defined Borders in Cells - /text/scalc/guide/borders.xhp - - - -cells;borders - line arrangements with cells - borders;cells -MW made "line arrangement;" a one level entry + +User Defined Borders in Cells + /text/scalc/guide/borders.xhp + + + + + + cells;borders + line arrangements with cells + borders;cells + User Defined Borders in Cells You can apply a variety of different lines to selected cells. @@ -101,9 +101,7 @@ - - You cannot apply borders to multiple selections. - Default Settings + Default Settings Click one of the Default icons to set or reset multiple borders. @@ -188,7 +186,6 @@ - Examples Select a single cell, then choose Format - Cells - Borders. Click the lower edge to set a very thin line as a lower border. All other lines will be removed from the cell. @@ -207,11 +204,24 @@ advanced example for cell borders + + adjacent cells;remove border + + + + Adjacent Cells + This option becomes available when formatting a range of cells that already have borders and the new format defined for the range involves removing outer borders. + By default the option Remove border is disabled and the borders at the edges of the selected range are left unchanged. Check this option if the borders at the edge of the selection should be removed. + If the preset No Borders is chosen then the Remove border option is enabled. + + - - - - - + + + + + + + - \ No newline at end of file + diff --git a/source/text/shared/01/05030500.xhp b/source/text/shared/01/05030500.xhp index 043701100..2394b823c 100644 --- a/source/text/shared/01/05030500.xhp +++ b/source/text/shared/01/05030500.xhp @@ -37,16 +37,21 @@ -To modify the border of an entire table, place the cursor in a table cell, right-click, choose Table, and then click the Borders tab. To modify the border of a table cell, select the cell, right-click, choose Table, and then click the Borders tab. - - - + To modify the border of an entire table, place the cursor in a table cell, right-click, choose Table, and then click the Borders tab. To modify the border of a table cell, select the cell, right-click, choose Table, and then click the Borders tab. + + + + Line arrangement + Select a predefined border style to apply. + Alternatively, use the Borders button on the toolbar to apply predefined border formats. + + + + +The Remove border option in the Adjacent Cells section determines if borders in the edges of the selected range are to be removed. Leave this option unchecked if edge borders should be left unchanged. +Read the help page to learn more on how to define custom line arrangements. + -Line arrangement -Select a predefined border style to apply. -If you are in a table or spreadsheet, you can also add or remove predefined borders. Use the Borders icon on the Table Bar. - - Line Click the border style that you want to apply. The style is applied to the borders selected in the preview.
[Libreoffice-bugs] [Bug 144184] Calc disables header/footer when saves a spreadsheet (Win only)
https://bugs.documentfoundation.org/show_bug.cgi?id=144184 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||v...@vlbnu.nl --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 144281 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144281] Filesave: header lost after saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=144281 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 144184 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144281] New: Filesave: header lost after saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=144281 Bug ID: 144281 Summary: Filesave: header lost after saving file Product: LibreOffice Version: 7.2.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: v...@vlbnu.nl Created attachment 174758 --> https://bugs.documentfoundation.org/attachment.cgi?id=174758=edit header lost when saved file and reopen Version: 7.2.0.4 (x64) / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 16; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL When a header is set and the file is saved and openning is opened, the header is gone. see attechment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144238] External content disabled for WEBSERVICE call
https://bugs.documentfoundation.org/show_bug.cgi?id=144238 Eike Rathke changed: What|Removed |Added Component|Calc|framework --- Comment #2 from Eike Rathke --- As mentioned in bug 144276 I believe that is a broken server implementation maybe tied with a timing problem. curl -i 'http://data.fixer.io/api/latest?access_key=74ba35e56db252bd4737c215d4b0bf62==PLN' works and advertises access-control-allow-methods: GET, HEAD, POST, PUT, PATCH, DELETE, OPTIONS but already curl -I 'http://data.fixer.io/api/latest?access_key=74ba35e56db252bd4737c215d4b0bf62==PLN' (doing a HEAD request) fails with 403 Forbidden status. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144279] Exporting a selected shape of 7x7 to any image format shows size of 7, 01 cm when changing DPI to Dots per CM & increase it from 37 to 38 and back, size becomes 7, 16 c
https://bugs.documentfoundation.org/show_bug.cgi?id=144279 Telesto changed: What|Removed |Added Summary|Exporting a selected shape |Exporting a selected shape |of 7x7 to any image format |of 7x7 to any image format |shows size of 7,01 cm in|shows size of 7,01 cm when |the export options dialog |changing DPI to Dots per CM |(see comment 3) |& increase it from 37 to 38 ||and back, size becomes 7,16 ||cm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144279] Exporting a selected shape of 7x7 to any image format shows size of 7, 01 cm in the export options dialog (see comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144279 Telesto changed: What|Removed |Added Resolution|NOTABUG |--- Status|RESOLVED|UNCONFIRMED --- Comment #6 from Telesto --- (In reply to Mike Kaganski from comment #5) > This is normal. > > You are saving a raster image file that must have an integral number of > pixels in both dimensions. You define a resolution: > > Note: assuming DPI 96 > > which means that each pixel is exactly 1/96 in ~ 0.264583 mm. > > Such an image may only have 264 or 265 pixels to approximate 7 cm. In first > case, the resulting actual metric size would be 69.85 mm; in the second, it > would be ~70.114 mm. That is correctly displayed to the user. Ah, however, - shifting goalposts a little - still confused why there is the variation.. * 7,01 cm on dialog initialization. And 6,98 cm after bumping DPI to 97 and back to 96. If this is a rounding should end up this way, please make it consistent. * And even worse in case of switching from DPI to Pixel to CM. Where moving 37 Pixel the CM up to 38 and back to 37 end up with 7,16 CM not 7,01 cm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/sallayout.hxx |2 +-
vcl/source/gdi/CommonSalLayout.cxx | 13 +
2 files changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 104847ed014e95a915d314de7091c7d572eade67
Author: Noel Grandin
AuthorDate: Fri Sep 3 10:12:01 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Sep 3 13:15:21 2021 +0200
simplify ApplyDXArray method params
pass only the required data to it
Change-Id: I849780371b71d3620dc36681453f5dbe1527b7bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121577
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 93d4b02d7dc8..701be24a5e3e 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -200,7 +200,7 @@ private:
GenericSalLayout( const GenericSalLayout& ) = delete;
GenericSalLayout& operator=( const GenericSalLayout& ) =
delete;
-voidApplyDXArray(const ImplLayoutArgs&);
+voidApplyDXArray(const DeviceCoordinate*, SalLayoutFlags
nLayoutFlags);
voidJustify(DeviceCoordinate nNewWidth);
voidApplyAsianKerning(const OUString& rStr);
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index b2d332c82958..f21c2f572d25 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -195,7 +195,7 @@ void GenericSalLayout::AdjustLayout(ImplLayoutArgs& rArgs)
SalLayout::AdjustLayout(rArgs);
if (rArgs.mpDXArray)
-ApplyDXArray(rArgs);
+ApplyDXArray(rArgs.mpDXArray, rArgs.mnFlags);
else if (rArgs.mnLayoutWidth)
Justify(rArgs.mnLayoutWidth);
// apply asian kerning if the glyphs are not already formatted
@@ -633,11 +633,8 @@ void GenericSalLayout::GetCharWidths(DeviceCoordinate*
pCharWidths) const
// * For any RTL glyph that has DX adjustment, insert enough Kashidas to
// fill in the added space.
-void GenericSalLayout::ApplyDXArray(const ImplLayoutArgs& rArgs)
+void GenericSalLayout::ApplyDXArray(const DeviceCoordinate* pDXArray,
SalLayoutFlags nLayoutFlags)
{
-if (rArgs.mpDXArray == nullptr)
-return;
-
int nCharCount = mnEndCharPos - mnMinCharPos;
std::unique_ptr const pOldCharWidths(new
DeviceCoordinate[nCharCount]);
std::unique_ptr const pNewCharWidths(new
DeviceCoordinate[nCharCount]);
@@ -649,15 +646,15 @@ void GenericSalLayout::ApplyDXArray(const ImplLayoutArgs&
rArgs)
for (int i = 0; i < nCharCount; ++i)
{
if (i == 0)
-pNewCharWidths[i] = rArgs.mpDXArray[i];
+pNewCharWidths[i] = pDXArray[i];
else
-pNewCharWidths[i] = rArgs.mpDXArray[i] - rArgs.mpDXArray[i - 1];
+pNewCharWidths[i] = pDXArray[i] - pDXArray[i - 1];
}
bool bKashidaJustify = false;
DeviceCoordinate nKashidaWidth = 0;
hb_codepoint_t nKashidaIndex = 0;
-if (rArgs.mnFlags & SalLayoutFlags::KashidaJustification)
+if (nLayoutFlags & SalLayoutFlags::KashidaJustification)
{
hb_font_t *pHbFont = GetFont().GetHbFont();
// Find Kashida glyph width and index.
[Libreoffice-bugs] [Bug 139053] lODEv 7.2 crashes when opening am ods created by Office365
https://bugs.documentfoundation.org/show_bug.cgi?id=139053 Elmar changed: What|Removed |Added Resolution|INSUFFICIENTDATA|WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144250] Freeze when scrolling after changing column width
https://bugs.documentfoundation.org/show_bug.cgi?id=144250 Telesto changed: What|Removed |Added Version|6.4.0.3 release |6.2.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144250] Freeze when scrolling after changing column width
https://bugs.documentfoundation.org/show_bug.cgi?id=144250 Telesto changed: What|Removed |Added Keywords||bibisected, bisected, perf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3
https://bugs.documentfoundation.org/show_bug.cgi?id=144249 Telesto changed: What|Removed |Added Keywords||perf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell content increased from 2 seconds (6.0) to 10 seconds with (7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4249 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144250] Freeze when scrolling after changing column width
https://bugs.documentfoundation.org/show_bug.cgi?id=144250 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4249 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3
https://bugs.documentfoundation.org/show_bug.cgi?id=144249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4250, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4257 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144276] WEBSERVICE function to certain external URL results in #VALUE! error
https://bugs.documentfoundation.org/show_bug.cgi?id=144276 Eike Rathke changed: What|Removed |Added Component|Calc|framework --- Comment #2 from Eike Rathke --- Might be a timing problem of the requests issued or the web server not wanting to let have us access otherwise. Effectively we're getting a HTTP status code 403 Forbidden. Deep down at https://opengrok.libreoffice.org/xref/core/ucb/source/ucp/webdav-neon/webdavcontent.cxx?r=10d29c39#2235 the GET() call fails, or if retried already the getResourceOptions() call at https://opengrok.libreoffice.org/xref/core/ucb/source/ucp/webdav-neon/webdavcontent.cxx?r=10d29c39#2225 both with the 403. The latter for the OPTIONS() call at https://opengrok.libreoffice.org/xref/core/ucb/source/ucp/webdav-neon/webdavcontent.cxx?r=10d29c39#3928 It was successful twice when single stepping through that sequence in the debugger, which doesn't make things easier, so I believe it is some (too fast) timing problem and the server thinking bad of us thus denying with 403. Or we issue some request between that isn't on its access-control-allow-methods list, but it doesn't look like from the first glance (list with curl -i for that URL is GET, HEAD, POST, PUT, PATCH, DELETE, OPTIONS). On the other hand, using curl -I 'http://data.fixer.io/api/latest?access_key=74ba35e56db252bd4737c215d4b0bf62==PLN' to issue a HEAD request I also get a 403 error. Which makes me believe the server has a broken implementation anyway. Nothing that could be solved at the Calc level and I'm not familiar with that code. Setting 'framework' component. Not even sure this is a bug, given the curl -I behaviour. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/firebird
external/firebird/ExternalProject_firebird.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6eee0843d4b354b849a21e6cb0978936d5f4dd01 Author: Mike Kaganski AuthorDate: Fri Sep 3 09:19:27 2021 +0200 Commit: Mike Kaganski CommitDate: Fri Sep 3 12:55:23 2021 +0200 No need to check DBGUTIL specially ... as discussed in comments to https://gerrit.libreoffice.org/c/core/+/121470 Change-Id: I9be45e2157972156ab7c2aac820b69aa894cacfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121553 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/external/firebird/ExternalProject_firebird.mk b/external/firebird/ExternalProject_firebird.mk index edb3ed9eabea..4843043da3f7 100644 --- a/external/firebird/ExternalProject_firebird.mk +++ b/external/firebird/ExternalProject_firebird.mk @@ -52,7 +52,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build): $(CXXFLAGS_CXX11) \ $(if $(filter TRUE,$(COM_IS_CLANG)), -Wno-c++11-narrowing) \ $(if $(call gb_Module__symbols_enabled,firebird),$(gb_DEBUGINFO_FLAGS)) \ - $(if $(ENABLE_DEBUG)$(ENABLE_DBGUTIL),$(if $(filter MSC,$(COM)),-Od -Z7,-Wno-error)) \ + $(if $(ENABLE_DEBUG),$(if $(filter MSC,$(COM)),-Od -Z7)) \ " \ && export LDFLAGS=" \ $(if $(SYSTEM_LIBATOMIC_OPS),$(LIBATOMIC_OPS_LIBS), \ @@ -83,7 +83,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build): '<' 101200)), \ ac_cv_func_clock_gettime=no)) \ && LC_ALL=C $(MAKE) \ - $(if $(ENABLE_DEBUG)$(ENABLE_DBGUTIL),Debug) SHELL='$(SHELL)' $(if $(filter LINUX,$(OS)),CXXFLAGS="$$CXXFLAGS -std=gnu++11") \ + $(if $(ENABLE_DEBUG),Debug) SHELL='$(SHELL)' $(if $(filter LINUX,$(OS)),CXXFLAGS="$$CXXFLAGS -std=gnu++11") \ MATHLIB="$(if $(SYSTEM_LIBTOMMATH),$(LIBTOMMATH_LIBS),-L$(call gb_UnpackedTarball_get_dir,libtommath) -ltommath)" \ LIBO_TUNNEL_LIBRARY_PATH='$(subst ','\'',$(subst $$,,$(call gb_Helper_extend_ld_path,$(call gb_UnpackedTarball_get_dir,icu)/source/lib)))' \ $(if $(filter MACOSX,$(OS)), \
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwpsilverbullet.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit ba346227f1c4f896b717676a7eae22fea222f3e4 Author: Caolán McNamara AuthorDate: Thu Sep 2 10:15:10 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 3 12:49:43 2021 +0200 ofz: MemorySanitizer: use-of-uninitialized-value Change-Id: If1db8debe4f3b3dc6a8890b03ee8d2d70cc63a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121572 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/lotuswordpro/source/filter/lwpsilverbullet.cxx b/lotuswordpro/source/filter/lwpsilverbullet.cxx index 338e71e5290a..07232d36d9bb 100644 --- a/lotuswordpro/source/filter/lwpsilverbullet.cxx +++ b/lotuswordpro/source/filter/lwpsilverbullet.cxx @@ -98,6 +98,8 @@ void LwpSilverBullet::Read() for (sal_uInt16 nC = 0; nC < nNumPos; nC++) m_pResetPositionFlags[nC] = m_pObjStrm->QuickReaduInt8(); +memset(m_pResetPositionFlags + nNumPos, 0, SAL_N_ELEMENTS(m_pResetPositionFlags) - nNumPos); + m_nUseCount = m_pObjStrm->QuickReaduInt32(); m_pAtomHolder->Read(m_pObjStrm.get());
[Libreoffice-commits] core.git: xmloff/source xmlsecurity/source
xmloff/source/chart/SchXMLTextListContext.cxx |1
xmloff/source/chart/XMLLabelSeparatorContext.cxx|3 --
xmloff/source/core/DocumentSettingsContext.cxx |1
xmloff/source/core/xmlexp.cxx |5 ---
xmloff/source/core/xmlimp.cxx |2 -
xmloff/source/core/xmlmultiimagehelper.cxx |3 --
xmloff/source/draw/shapeexport.cxx |1
xmloff/source/draw/ximpshap.cxx |9 +-
xmloff/source/meta/MetaImportComponent.cxx |2 -
xmloff/source/meta/xmlmetae.cxx |3 --
xmloff/source/script/XMLEventImportHelper.cxx |4 --
xmloff/source/style/MultiPropertySetHelper.cxx |2 -
xmloff/source/style/PageMasterImportContext.cxx |1
xmloff/source/style/PageMasterPropHdlFactory.cxx|3 --
xmloff/source/style/numehelp.cxx|6 +---
xmloff/source/style/xmlexppr.cxx|3 --
xmloff/source/style/xmlnumfi.cxx|2 -
xmloff/source/text/XMLFootnoteConfigurationImportContext.cxx|1
xmloff/source/text/XMLIndexBibliographyConfigurationContext.cxx |3 --
xmloff/source/text/XMLIndexTabStopEntryContext.cxx |1
xmloff/source/text/XMLTextFrameContext.cxx |3 --
xmloff/source/text/XMLTextListBlockContext.cxx |4 --
xmloff/source/text/XMLTextListItemContext.cxx |3 --
xmloff/source/text/XMLTextNumRuleInfo.cxx |5 ---
xmloff/source/text/txtfldi.cxx | 14
+-
xmloff/source/text/txtlists.cxx |4 --
xmloff/source/text/txtparae.cxx |1
xmloff/source/text/txtparai.cxx |4 --
xmloff/source/text/txtprhdl.cxx |3 --
xmloff/source/xforms/SchemaRestrictionContext.cxx |3 --
xmloff/source/xforms/XFormsSubmissionContext.cxx|3 --
xmlsecurity/source/dialogs/certificatechooser.cxx |1
xmlsecurity/source/framework/signaturecreatorimpl.cxx |2 -
xmlsecurity/source/framework/signatureverifierimpl.cxx |1
xmlsecurity/source/gpg/CertificateImpl.cxx |3 --
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |2 -
36 files changed, 23 insertions(+), 89 deletions(-)
New commits:
commit 6cc1ee903544ed813402303e93753dac8226984f
Author: Noel Grandin
AuthorDate: Fri Sep 3 09:11:06 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Sep 3 12:44:22 2021 +0200
clang-tidy:readability-redundant-member-init
Change-Id: Iede70151af052505b780c6ce708aa74d97da5c75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121545
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/source/chart/SchXMLTextListContext.cxx
b/xmloff/source/chart/SchXMLTextListContext.cxx
index 33aaa5028b8f..8b60d895bdef 100644
--- a/xmloff/source/chart/SchXMLTextListContext.cxx
+++ b/xmloff/source/chart/SchXMLTextListContext.cxx
@@ -74,7 +74,6 @@ SchXMLTextListContext::SchXMLTextListContext(
, Sequence< OUString>& rTextList )
: SvXMLImportContext( rImport )
, m_rTextList( rTextList )
-, m_aTextVector()
{
}
diff --git a/xmloff/source/chart/XMLLabelSeparatorContext.cxx
b/xmloff/source/chart/XMLLabelSeparatorContext.cxx
index 1d05bfca1cfb..93beff46cf41 100644
--- a/xmloff/source/chart/XMLLabelSeparatorContext.cxx
+++ b/xmloff/source/chart/XMLLabelSeparatorContext.cxx
@@ -32,8 +32,7 @@ XMLLabelSeparatorContext::XMLLabelSeparatorContext(
const XMLPropertyState& rProp,
::std::vector< XMLPropertyState > ) :
XMLElementPropertyContext(
-rImport, nElement, rProp, rProps ),
-m_aSeparator()
+rImport, nElement, rProp, rProps )
{
}
diff --git a/xmloff/source/core/DocumentSettingsContext.cxx
b/xmloff/source/core/DocumentSettingsContext.cxx
index f221bfbc0f00..b40ac306963a 100644
--- a/xmloff/source/core/DocumentSettingsContext.cxx
+++ b/xmloff/source/core/DocumentSettingsContext.cxx
@@ -352,7 +352,6 @@ XMLConfigBaseContext::XMLConfigBaseContext(SvXMLImport&
rImport,
XMLConfigBaseContext* pTempBaseContext)
: SvXMLImportContext( rImport ),
maProps( rImport.GetComponentContext() ),
-maProp(),
mrAny(rTempAny),
mpBaseContext(pTempBaseContext)
{
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index 889b9243e8d6..c64fb6052d45 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -2455,7 +2455,6 @@
[Libreoffice-bugs] [Bug 144101] LibreOfficeDev - Immediate crash when attempting to edit a database report
https://bugs.documentfoundation.org/show_bug.cgi?id=144101 --- Comment #12 from Alex Thurgood --- Not sure what to do about this now. In normal use, I tried switching JDKs (from 12 to 14) to see if that would make any difference, and now I don't get an immediate crash. Even switching back to the previously used JDK no longer causes a crash. Only in a debug session do I get the immediate crash (and the bt I've already uploaded), as confirmed by Buovjaga. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144253] About the functionality of standard filters
https://bugs.documentfoundation.org/show_bug.cgi?id=144253 --- Comment #5 from NISZ LibreOffice Team --- Created attachment 174757 --> https://bugs.documentfoundation.org/attachment.cgi?id=174757=edit Minimal reproducer made in current Calc master This is not xlsx-specific. Filtering this file also reproduces the issue. There is another issue: the Autofilter dropdown and the Standard filter dialog does not display these calculated number values (but not with constant values!) according to the cell format. This seems to be an independent problem, I'll file another bug for that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 NISZ LibreOffice Team changed: What|Removed |Added Depends on||144253 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144253 [Bug 144253] About the functionality of standard filters -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144253] About the functionality of standard filters
https://bugs.documentfoundation.org/show_bug.cgi?id=144253 NISZ LibreOffice Team changed: What|Removed |Added CC||libreoff...@nisz.hu, ||nem...@numbertext.org, ||varga.bala...@nisz.hu Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression Blocks||103512 --- Comment #4 from NISZ LibreOffice Team --- Seems to have started with https://cgit.freedesktop.org/libreoffice/core/commit/?id=3069df790cca2917e5aedd87bac1af65f9605d51 author Balazs Varga 2021-07-02 09:40:32 +0200 committer Xisco Fauli 2021-07-08 09:50:09 +0200 tdf#142910 sc filter: fix "greater than" or "smaller than" etc Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103512 [Bug 103512] [META] AutoFilter-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144253] About the functionality of standard filters
https://bugs.documentfoundation.org/show_bug.cgi?id=144253 --- Comment #3 from NISZ LibreOffice Team --- Created attachment 174756 --> https://bugs.documentfoundation.org/attachment.cgi?id=174756=edit The example file in Excel and Calc after filtering them Confirming with: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: bc7baa18435000f47f90e47d3300710bcb4cf56b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL Filtering for formatted values makes all of them disappear. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144253] About the functionality of standard filters
https://bugs.documentfoundation.org/show_bug.cgi?id=144253 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 174755 --> https://bugs.documentfoundation.org/attachment.cgi?id=174755=edit The example file in Excel and Calc side by side when filtering them -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/source
sw/source/uibase/uiview/view2.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 7c2893de81a25db4279ae8da0ef030a596f36b56
Author: Miklos Vajna
AuthorDate: Fri Sep 3 09:28:39 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 12:13:21 2021 +0200
sw: fix crash in SwView::Execute()
Crashreport:
program/../program/libswlo.so
SwView::Execute(SfxRequest&)
sw/source/uibase/uiview/view2.cxx:1312
program/libmergedlo.so
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&,
SfxRequest&, bool)
sfx2/source/control/dispatch.cxx:263
/opt/collaboraoffice6.4/program/libmergedlo.so
SfxDispatcher::Execute_(SfxShell&, SfxSlot const&,
SfxRequest&, SfxCallMode)
sfx2/source/control/dispatch.cxx:760 (discriminator
3)
/opt/collaboraoffice6.4/program/libmergedlo.so
SfxDispatcher::Execute(unsigned short, SfxCallMode,
SfxItemSet const*, SfxItemSet const*, unsigned short)
sfx2/source/control/dispatch.cxx:819
Change-Id: I2e7b27f458971dbd33971589f71337c59981ee83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121547
Reviewed-by: Michael Meeks
Tested-by: Jenkins CollaboraOffice
diff --git a/sw/source/uibase/uiview/view2.cxx
b/sw/source/uibase/uiview/view2.cxx
index 1e2356884137..9820b695d7cb 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -1309,6 +1309,11 @@ void SwView::Execute(SfxRequest )
const sal_uLong newPosY = newPosYTwips->GetValue();
const Point mPoint(newPosX, newPosY);
const SdrHdl* handle =
pSdrView->GetHdlList().GetHdl(handleNum);
+if (!handle)
+{
+break;
+}
+
if (handle->GetKind() == SdrHdlKind::Anchor ||
handle->GetKind() == SdrHdlKind::Anchor_TR)
m_pWrtShell->FindAnchorPos(mPoint, /*bMoveIt=*/true);
else
[Libreoffice-bugs] [Bug 84850] EDITING: undo of deleted cells fails to recalculate formula
https://bugs.documentfoundation.org/show_bug.cgi?id=84850 --- Comment #9 from afkebooks@gmail.com --- Afkebooks provides all medical ebooks, video courses we have variety of learning components including: video lectures, scan demonstrations, interactive components/quizzes, and more to improve diagnostic accuracy.All online courses cover the same topics as our comprehensive live courses. https://afkebooks.com/category/videos -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/imet/ios2met.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 65d4320110d3f6ab9242389fdc8d392de13cbb74
Author: Caolán McNamara
AuthorDate: Thu Sep 2 16:51:03 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 12:06:15 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I00531cdb266c4277af742cee6ce5d05f0ea3334e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121523
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/imet/ios2met.cxx
b/vcl/source/filter/imet/ios2met.cxx
index 0057d3f55808..0888a84c576d 100644
--- a/vcl/source/filter/imet/ios2met.cxx
+++ b/vcl/source/filter/imet/ios2met.cxx
@@ -936,6 +936,12 @@ void OS2METReader::ReadBox(bool bGivenPos)
sal_Int32 nHRound = ReadCoord(bCoord32);
sal_Int32 nVRound = ReadCoord(bCoord32);
+if (!pOS2MET->good())
+{
+SAL_WARN("filter.os2met", "OS2METReader::ReadBox: short read");
+return;
+}
+
tools::Rectangle aBoxRect( P0, aAttr.aCurPos );
if ( pAreaStack )
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hwpread.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 27b84d7460cbb925429826d20c4cee5439ad7053 Author: Caolán McNamara AuthorDate: Thu Sep 2 12:02:55 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 3 12:05:37 2021 +0200 cid#1490898 Unchecked return value Change-Id: I49124165e0d00d84f3ebdb0414d6db58f6da1209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121519 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx index de69eb4cd004..31da8c7efde7 100644 --- a/hwpfilter/source/hwpread.cxx +++ b/hwpfilter/source/hwpread.cxx @@ -70,17 +70,17 @@ bool FieldCode::Read(HWPFile & hwpf) uint binlen; /* Length of any binary data format */ hwpf.Read4b(size); -hwpf.Read2b(dummy); +if (!hwpf.Read2b(dummy)) +return false; hwpf.ReadBlock(, 2); hwpf.Read4b(reserved1.data(), 1); -hwpf.Read2b(location_info); +if (!hwpf.Read2b(location_info)) +return false; hwpf.ReadBlock(reserved2.data(), 22); hwpf.Read4b(len1); hwpf.Read4b(len2); hwpf.Read4b(len3); -bool bSuccess = hwpf.Read4b(binlen); - -if (!bSuccess) +if (!hwpf.Read4b(binlen)) return false; uint const len1_ = std::min(len1, 1024) / sizeof(hchar);
[Libreoffice-commits] core.git: sd/source
sd/source/filter/ppt/pptinanimations.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 6c0c3bd74e0d94f48feda9bd7663bb9b5d9fc320
Author: Caolán McNamara
AuthorDate: Thu Sep 2 10:05:50 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 12:05:03 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Ie4fe1a4d346d3b790349132460b9efcc448d0eb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121551
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/filter/ppt/pptinanimations.cxx
b/sd/source/filter/ppt/pptinanimations.cxx
index 313a724ec639..d03efbc87980 100644
--- a/sd/source/filter/ppt/pptinanimations.cxx
+++ b/sd/source/filter/ppt/pptinanimations.cxx
@@ -2129,13 +2129,13 @@ void AnimationImporter::importAnimateKeyPoints( const
Atom* pAtom, const Referen
OUString aFormula;
pIter = pAtom->findFirstChildAtom(DFF_msofbtAnimKeyTime);
-sal_Int32 nTemp;
bool bToNormalize = false;
for( int nKeyTime = 0; (nKeyTime < nKeyTimes) && pIter; nKeyTime++ )
{
if( pIter->seekToContent() )
{
-mrStCtrl.ReadInt32( nTemp );
+sal_Int32 nTemp(0);
+mrStCtrl.ReadInt32(nTemp);
double fTemp = static_cast(nTemp) / 1000.0;
aKeyTimes[nKeyTime] = fTemp;
if( fTemp == -1 )
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/emfreader.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit b6e5aca3b35df4b0fd05f449435bb69bd0cea164
Author: Caolán McNamara
AuthorDate: Wed Sep 1 17:09:50 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 12:04:41 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I71d3b07c7ca2467b7bc1db5350dbdeb1f8910cb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121478
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index 45e50a90d7d4..758a3220d517 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -1511,7 +1511,9 @@ namespace emfio
mpInputStream->ReadUInt32( BkColorSrc ).ReadUInt32(
iUsageSrc ).ReadUInt32( offBmiSrc ).ReadUInt32( cbBmiSrc )
.ReadUInt32( offBitsSrc ).ReadUInt32(
cbBitsSrc ).ReadInt32( cxSrc ).ReadInt32( cySrc ) ;
-if ( (cbBitsSrc > (SAL_MAX_UINT32 - 14)) ||
((SAL_MAX_UINT32 - 14) - cbBitsSrc < cbBmiSrc) ||
+if ( !mpInputStream->good() ||
+ (cbBitsSrc > (SAL_MAX_UINT32 - 14)) ||
+ ((SAL_MAX_UINT32 - 14) - cbBitsSrc < cbBmiSrc) ||
cxDest == SAL_MAX_INT32 || cyDest ==
SAL_MAX_INT32 )
{
bStatus = false;
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/GraphicFormatDetector.cxx |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit c06bc8cf1b3e1057eb846605b61570bb1f3713da Author: Caolán McNamara AuthorDate: Thu Sep 2 20:16:39 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 3 12:04:22 2021 +0200 ofz: MemorySanitizer: use-of-uninitialized-value Change-Id: I6a8dd39528038fbcc496e56d6fcefc4ec8db68cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121536 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/filter/GraphicFormatDetector.cxx b/vcl/source/filter/GraphicFormatDetector.cxx index df7cc1fb03d4..264e6d9136c6 100644 --- a/vcl/source/filter/GraphicFormatDetector.cxx +++ b/vcl/source/filter/GraphicFormatDetector.cxx @@ -299,13 +299,17 @@ bool isPCT(SvStream& rStream, sal_uLong nStreamPos, sal_uLong nStreamLen) rStream.ReadInt16(y1).ReadInt16(x1).ReadInt16(y2).ReadInt16(x2); rStream.SetEndian(oldNumberFormat); // reset format +// read version op +rStream.ReadBytes(sBuf, 3); + +if (!rStream.good()) +break; + if (x1 > x2 || y1 > y2 || // bad bdbox (x1 == x2 && y1 == y2) || // 1 pixel picture x2 - x1 > 2048 || y2 - y1 > 2048) // picture abnormally big bdBoxOk = false; -// read version op -rStream.ReadBytes(sBuf, 3); // see http://developer.apple.com/legacy/mac/library/documentation/mac/pdf/Imaging_With_QuickDraw/Appendix_A.pdf // normal version 2 - page A23 and A24 if (sBuf[0] == 0x00 && sBuf[1] == 0x11 && sBuf[2] == 0x02)
[Libreoffice-bugs] [Bug 143390] New "Search Commands" feature: Search window remains on top when switching to other applications
https://bugs.documentfoundation.org/show_bug.cgi?id=143390 --- Comment #3 from Caolán McNamara --- This "search commands" is a popup and I think how it works is consistent with the other ones. So if the "underline" popup and the writer "table" popup work the same as this "search command" popup then it has ~always been like this and is nothing new. If I'm right about that I'd guess there's some duplicate issue of this about other popups staying around if changing workspace or switching to another applications window. IIRC some of the backends will explicitly popdown popups on a click outside their area, I guess that's what the kf5 one is doing. Popups are fraught with complexity in this area. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143390] New "Search Commands" feature: Search window remains on top when switching to other applications
https://bugs.documentfoundation.org/show_bug.cgi?id=143390 --- Comment #3 from Caolán McNamara --- This "search commands" is a popup and I think how it works is consistent with the other ones. So if the "underline" popup and the writer "table" popup work the same as this "search command" popup then it has ~always been like this and is nothing new. If I'm right about that I'd guess there's some duplicate issue of this about other popups staying around if changing workspace or switching to another applications window. IIRC some of the backends will explicitly popdown popups on a click outside their area, I guess that's what the kf5 one is doing. Popups are fraught with complexity in this area. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/inc/cuitabarea.hxx |2
cui/source/tabpages/tpcolor.cxx | 14
cui/uiconfig/ui/colorpage.ui| 575
3 files changed, 312 insertions(+), 279 deletions(-)
New commits:
commit ef3dd0e04e734974ff9a6b7f30d0377ecd952842
Author: Heiko Tietze
AuthorDate: Thu Sep 2 10:38:14 2021 +0200
Commit: Heiko Tietze
CommitDate: Fri Sep 3 11:59:17 2021 +0200
Resolves tdf#120333 - Access to color palettes via tight extensions
Change-Id: I335854a29eaddf76b847642250626b7032ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121498
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index 3f18d069f6e4..b5af2475a218 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -675,6 +675,7 @@ private:
std::unique_ptr m_xBtnAdd;
std::unique_ptr m_xBtnDelete;
std::unique_ptr m_xBtnWorkOn;
+std::unique_ptr m_xMoreColors;
std::unique_ptr m_xCtlPreviewOld;
std::unique_ptr m_xCtlPreviewNew;
std::unique_ptr m_xValSetColorListWin;
@@ -692,6 +693,7 @@ private:
DECL_LINK(ClickAddHdl_Impl, weld::Button&, void);
DECL_LINK(ClickWorkOnHdl_Impl, weld::Button&, void);
DECL_LINK(ClickDeleteHdl_Impl, weld::Button&, void);
+DECL_STATIC_LINK(SvxColorTabPage, OnMoreColorsClick, weld::Button&, void);
DECL_LINK(SelectPaletteLBHdl, weld::ComboBox&, void);
DECL_LINK( SelectValSetHdl_Impl, ValueSet*, void );
diff --git a/cui/source/tabpages/tpcolor.cxx b/cui/source/tabpages/tpcolor.cxx
index 7be82dca2676..a5f2e7b7aa98 100644
--- a/cui/source/tabpages/tpcolor.cxx
+++ b/cui/source/tabpages/tpcolor.cxx
@@ -35,6 +35,7 @@
#include
#include
#include
+#include
using namespace com::sun::star;
@@ -75,6 +76,7 @@ SvxColorTabPage::SvxColorTabPage(weld::Container* pPage,
weld::DialogController*
, m_xBtnAdd(m_xBuilder->weld_button("add"))
, m_xBtnDelete(m_xBuilder->weld_button("delete"))
, m_xBtnWorkOn(m_xBuilder->weld_button("edit"))
+, m_xMoreColors(m_xBuilder->weld_button("btnMoreColors"))
, m_xCtlPreviewOld(new weld::CustomWeld(*m_xBuilder, "oldpreview",
m_aCtlPreviewOld))
, m_xCtlPreviewNew(new weld::CustomWeld(*m_xBuilder, "newpreview",
m_aCtlPreviewNew))
, m_xValSetColorListWin(new weld::CustomWeld(*m_xBuilder, "colorset",
*m_xValSetColorList))
@@ -128,6 +130,9 @@ SvxColorTabPage::SvxColorTabPage(weld::Container* pPage,
weld::DialogController*
m_xBtnDelete->set_sensitive(false);
m_xBtnDelete->set_tooltip_text( SvxResId(RID_SVXSTR_DELETEUSERCOLOR1) );
+m_xMoreColors->set_from_icon_name("cmd/sc_additionsdialog.png");
+m_xMoreColors->connect_clicked(LINK(this, SvxColorTabPage,
OnMoreColorsClick));
+
// disable preset color values
m_xRGBpreset->set_sensitive(false);
m_xCMYKpreset->set_sensitive(false);
@@ -536,6 +541,15 @@ IMPL_LINK_NOARG(SvxColorTabPage, SelectColorModeHdl_Impl,
weld::Toggleable&, voi
UpdateColorValues();
}
+
+IMPL_STATIC_LINK_NOARG(SvxColorTabPage, OnMoreColorsClick, weld::Button&, void)
+{
+css::uno::Sequence aArgs(1);
+aArgs[0].Name = "AdditionsTag";
+aArgs[0].Value <<= OUString("Color Palette");
+comphelper::dispatchCommand(".uno:AdditionsDialog", aArgs);
+}
+
void SvxColorTabPage::ChangeColor(const Color , bool bUpdatePreset )
{
aPreviousColor = rNewColor;
diff --git a/cui/uiconfig/ui/colorpage.ui b/cui/uiconfig/ui/colorpage.ui
index 46f99e9db764..ac680de34ef0 100644
--- a/cui/uiconfig/ui/colorpage.ui
+++ b/cui/uiconfig/ui/colorpage.ui
@@ -1,84 +1,84 @@
-
+
100
-1
-10
+1
+10
255
-1
-10
+1
+10
100
-1
-10
+1
+10
100
-1
-10
+1
+10
100
-1
-10
+1
+10
255
-1
-10
+1
+10
255
-1
-10
+1
+10
True
-False
-res/sc10350.png
+False
+res/sc10350.png
True
-False
+False
True
True
-6
+6
6
True
-False
+False
True
-0
-none
+0
+none
-
+
True
-False
+False
start
start
-6
12
6
+6
True
-False
+False
3
True
-False
+False
center
Palette:
-True
-paletteselector
+True
+paletteselector
0
0
@@ -91,7 +91,7 @@
[Libreoffice-bugs] [Bug 143792] FORMATTING: Style changes not applied to specific cells with multiple selection
https://bugs.documentfoundation.org/show_bug.cgi?id=143792 --- Comment #6 from Mike Kaganski --- Created attachment 174754 --> https://bugs.documentfoundation.org/attachment.cgi?id=174754=edit How to create anew -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143792] FORMATTING: Style changes not applied to specific cells with multiple selection
https://bugs.documentfoundation.org/show_bug.cgi?id=143792 --- Comment #6 from Mike Kaganski --- Created attachment 174754 --> https://bugs.documentfoundation.org/attachment.cgi?id=174754=edit How to create anew -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features
https://bugs.documentfoundation.org/show_bug.cgi?id=120200 Bug 120200 depends on bug 120333, which changed state. Bug 120333 Summary: No way to load color palette https://bugs.documentfoundation.org/show_bug.cgi?id=120333 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104118] [META] Color palette bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=104118 Bug 104118 depends on bug 120333, which changed state. Bug 120333 Summary: No way to load color palette https://bugs.documentfoundation.org/show_bug.cgi?id=120333 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113223] [META] Color fill issues of the Area fill tab
https://bugs.documentfoundation.org/show_bug.cgi?id=113223 Bug 113223 depends on bug 120333, which changed state. Bug 120333 Summary: No way to load color palette https://bugs.documentfoundation.org/show_bug.cgi?id=120333 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89192] Remember settings in export file dialog and export options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=89192 Heiko Tietze changed: What|Removed |Added CC||olivier.hallot@libreoffice. ||org --- Comment #11 from Heiko Tietze --- *** Bug 143842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143842] [UI] Set a configurable default export parameters for exporting Draw objects
https://bugs.documentfoundation.org/show_bug.cgi?id=143842 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Heiko Tietze --- Rather than adding another option I'd recommend to remember the last used options. And this is requested in bug 89192. Some projects might need to save at a different path than other, it just depends on the project. The current behavior to use the path where the document is saved/loaded from sounds appropriate in this regards. *** This bug has been marked as a duplicate of bug 89192 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143842] [UI] Set a configurable default export parameters for exporting Draw objects
https://bugs.documentfoundation.org/show_bug.cgi?id=143842 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Heiko Tietze --- Rather than adding another option I'd recommend to remember the last used options. And this is requested in bug 89192. Some projects might need to save at a different path than other, it just depends on the project. The current behavior to use the path where the document is saved/loaded from sounds appropriate in this regards. *** This bug has been marked as a duplicate of bug 89192 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - include/sfx2 sfx2/source
include/sfx2/sidebar/Deck.hxx |1 +
sfx2/source/sidebar/Deck.cxx | 18 ++
2 files changed, 19 insertions(+)
New commits:
commit 95b3e2a0a4407a3e09efbacef5987ff6d69bc400
Author: Caolán McNamara
AuthorDate: Tue Aug 31 10:25:08 2021 +0100
Commit: Michael Weghorn
CommitDate: Fri Sep 3 11:52:24 2021 +0200
tdf#142458 minimal width not including extra width needed by scrolledwindow
its only including the width of the panels and not the extra space
possibly required by the container window. Which is 2x the
m_nBorderWidth of 1pixel of VclScrolledWindow in this case.
Change-Id: I56775c7183d7a8b87af263ddc8bb17373779e9ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121290
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/include/sfx2/sidebar/Deck.hxx b/include/sfx2/sidebar/Deck.hxx
index a3d3a63aff01..47a33ab17d2c 100644
--- a/include/sfx2/sidebar/Deck.hxx
+++ b/include/sfx2/sidebar/Deck.hxx
@@ -74,6 +74,7 @@ private:
private:
const OUString msId;
sal_Int32 mnMinimalWidth;
+sal_Int32 mnScrolledWindowExtraWidth;
sal_Int32 mnMinimalHeight;
SharedPanelContainer maPanels;
diff --git a/sfx2/source/sidebar/Deck.cxx b/sfx2/source/sidebar/Deck.cxx
index 074a0bad7466..dd7f7c6716c3 100644
--- a/sfx2/source/sidebar/Deck.cxx
+++ b/sfx2/source/sidebar/Deck.cxx
@@ -46,6 +46,7 @@ Deck::Deck(const DeckDescriptor& rDeckDescriptor,
SidebarDockingWindow* pParentW
: InterimItemWindow(pParentWindow, "sfx/ui/deck.ui", "Deck")
, msId(rDeckDescriptor.msId)
, mnMinimalWidth(0)
+, mnScrolledWindowExtraWidth(0)
, mnMinimalHeight(0)
, maPanels()
, mxParentWindow(pParentWindow)
@@ -59,6 +60,15 @@ Deck::Deck(const DeckDescriptor& rDeckDescriptor,
SidebarDockingWindow* pParentW
mxVerticalScrollBar->vadjustment_set_step_increment(10);
mxVerticalScrollBar->vadjustment_set_page_increment(100);
+
+// tdf#142458 Measure the preferred width of an empty ScrolledWindow
+// to add to the width of the union of panel widths when calculating
+// the minimal width of the deck
+mxVerticalScrollBar->set_hpolicy(VclPolicyType::NEVER);
+mxVerticalScrollBar->set_vpolicy(VclPolicyType::NEVER);
+mnScrolledWindowExtraWidth =
mxVerticalScrollBar->get_preferred_size().Width();
+mxVerticalScrollBar->set_hpolicy(VclPolicyType::AUTOMATIC);
+mxVerticalScrollBar->set_vpolicy(VclPolicyType::AUTOMATIC);
}
Deck::~Deck()
@@ -202,6 +212,14 @@ void Deck::RequestLayoutInternal()
DeckLayouter::LayoutDeck(mxParentWindow.get(), GetContentArea(),
mnMinimalWidth, mnMinimalHeight, maPanels,
*GetTitleBar(), *mxVerticalScrollBar);
+
+if (mnMinimalWidth)
+{
+// tdf#142458 at this point mnMinimalWidth contains the width required
+// by the panels, but extra space may be needed by the scrolledwindow
+// that will contain the panels
+mnMinimalWidth += mnScrolledWindowExtraWidth;
+}
}
void Deck::RequestLayout()
[Libreoffice-bugs] [Bug 138655] Hide Tips Of The Day when showing Impress templates manager dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=138655 --- Comment #5 from Heiko Tietze --- (In reply to Caolán McNamara from comment #4) > So, unless I miss something, the fix of bug 143353 solves this Yes, it works as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144279] Exporting a selected shape of 7x7 to any image format shows size of 7, 01 cm in the export options dialog (see comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144279 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #5 from Mike Kaganski --- This is normal. You are saving a raster image file that must have an integral number of pixels in both dimensions. You define a resolution: > Note: assuming DPI 96 which means that each pixel is exactly 1/96 in ~ 0.264583 mm. Such an image may only have 264 or 265 pixels to approximate 7 cm. In first case, the resulting actual metric size would be 69.85 mm; in the second, it would be ~70.114 mm. That is correctly displayed to the user. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87720] Default insert image anchor, wrapping, and spacing (see comment #43 for summary at 2020-04-15)
https://bugs.documentfoundation.org/show_bug.cgi?id=87720 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3604 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102011] EDITING: Default wrap spacing to for images is not convenient
https://bugs.documentfoundation.org/show_bug.cgi?id=102011 Heiko Tietze changed: What|Removed |Added CC||marita.friesd...@web.de --- Comment #22 from Heiko Tietze --- *** Bug 143604 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143604] Increasing wrap space by default when inserting an image
https://bugs.documentfoundation.org/show_bug.cgi?id=143604 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||720 --- Comment #2 from Heiko Tietze --- Yes, zero distance is a bad default. Has been requested in bug 102011. And some work around this topic in bug 87720. *** This bug has been marked as a duplicate of bug 102011 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143604] Increasing wrap space by default when inserting an image
https://bugs.documentfoundation.org/show_bug.cgi?id=143604 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||720 --- Comment #2 from Heiko Tietze --- Yes, zero distance is a bad default. Has been requested in bug 102011. And some work around this topic in bug 87720. *** This bug has been marked as a duplicate of bug 102011 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144278] can't dismiss Impress Tip of the Day on top of Choose a Template
https://bugs.documentfoundation.org/show_bug.cgi?id=144278 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Caolán McNamara --- *** This bug has been marked as a duplicate of bug 143353 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125257] [META] Tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=125257 Bug 125257 depends on bug 138655, which changed state. Bug 138655 Summary: Hide Tips Of The Day when showing Impress templates manager dialog https://bugs.documentfoundation.org/show_bug.cgi?id=138655 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138655] Hide Tips Of The Day when showing Impress templates manager dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=138655 Caolán McNamara changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Caolán McNamara --- T solution I've attempted in https://git.libreoffice.org/core/+/1f42157e2457e30a7f18fdf9d7bb5bddfb819f04%5E%21 is to not allow launch of the tip of the day during startup if the template dialog is shown. And then after the template dialog is dismissed then relaunch the tip of the day dialog if one wanted to appear while the template dialog was running. So, unless I miss something, the fix of bug 143353 solves this *** This bug has been marked as a duplicate of bug 143353 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: android/Bootstrap android/source include/LibreOfficeKit libreofficekit/source sc/source
android/Bootstrap/src/org/libreoffice/kit/Document.java |1
android/source/src/java/org/libreoffice/InvalidationHandler.java | 54
+-
include/LibreOfficeKit/LibreOfficeKitEnums.h | 15 ++
libreofficekit/source/gtk/lokdocview.cxx |1
sc/source/ui/inc/gridwin.hxx |3
sc/source/ui/view/gridwin.cxx|7 +
sc/source/ui/view/tabvwsh3.cxx |2
7 files changed, 79 insertions(+), 4 deletions(-)
New commits:
commit e72a7368b368a822d2400ee7db60312226ad3195
Author: Ilhan Yesil
AuthorDate: Mon May 31 15:10:47 2021 +0200
Commit: Michael Weghorn
CommitDate: Fri Sep 3 11:45:21 2021 +0200
tdf#131548 Android: jump to cell
Added LOK_CALLBACK_SC_FOLLOW_JUMP: fire this signal to jump to cell
cursor in android viewer. Payload format same as
LOK_CALLBACK_INVALIDATE_TILES.
Change-Id: Ic896baccf1327d6ccdf104811446e3454a42679e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116448
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/android/Bootstrap/src/org/libreoffice/kit/Document.java
b/android/Bootstrap/src/org/libreoffice/kit/Document.java
index 69f8f76c3eb4..ed7208da5924 100644
--- a/android/Bootstrap/src/org/libreoffice/kit/Document.java
+++ b/android/Bootstrap/src/org/libreoffice/kit/Document.java
@@ -92,6 +92,7 @@ public class Document {
public static final int CALLBACK_COMMENT = 32;
public static final int CALLBACK_INVALIDATE_HEADER = 33;
public static final int CALLBACK_CELL_ADDRESS = 34;
+public static final int CALLBACK_SC_FOLLOW_JUMP = 52;
/**
* Set text selection types
diff --git a/android/source/src/java/org/libreoffice/InvalidationHandler.java
b/android/source/src/java/org/libreoffice/InvalidationHandler.java
index d74f150bfb44..0f3f1dd7b889 100644
--- a/android/source/src/java/org/libreoffice/InvalidationHandler.java
+++ b/android/source/src/java/org/libreoffice/InvalidationHandler.java
@@ -55,6 +55,7 @@ public class InvalidationHandler implements
Document.MessageCallback, Office.Mes
&& messageID != Document.CALLBACK_DOCUMENT_PASSWORD
&& messageID != Document.CALLBACK_HYPERLINK_CLICKED
&& messageID != Document.CALLBACK_SEARCH_RESULT_SELECTION
+&& messageID != Document.CALLBACK_SC_FOLLOW_JUMP
&& messageID != Document.CALLBACK_TEXT_SELECTION
&& messageID != Document.CALLBACK_TEXT_SELECTION_START
&& messageID != Document.CALLBACK_TEXT_SELECTION_END)
@@ -114,6 +115,9 @@ public class InvalidationHandler implements
Document.MessageCallback, Office.Mes
case Document.CALLBACK_CELL_CURSOR:
invalidateCellCursor(payload);
break;
+case Document.CALLBACK_SC_FOLLOW_JUMP:
+jumpToCell(payload);
+break;
case Document.CALLBACK_INVALIDATE_HEADER:
invalidateHeader();
break;
@@ -214,6 +218,14 @@ public class InvalidationHandler implements
Document.MessageCallback, Office.Mes
}
}
+private void jumpToCell(String payload) {
+RectF cellCursorRect = convertPayloadCellToRectangle(payload);
+
+if (cellCursorRect != null) {
+moveViewportToMakeSelectionVisible(cellCursorRect);
+}
+}
+
/**
* Handles the search result selection message, which is a JSONObject
*
@@ -368,6 +380,40 @@ public class InvalidationHandler implements
Document.MessageCallback, Office.Mes
if (coordinates.length != 4) {
return null;
}
+return convertPayloadToRectangle(coordinates);
+}
+
+/**
+ * Parses the payload text with rectangle coordinates and converts to
rectangle in pixel coordinates
+ *
+ * @param payload - invalidation message payload text
+ * @return rectangle in pixel coordinates
+ */
+public RectF convertPayloadCellToRectangle(String payload) {
+String payloadWithoutWhitespace = payload.replaceAll("\\s", ""); //
remove all whitespace from the string
+
+if (payloadWithoutWhitespace.isEmpty() ||
payloadWithoutWhitespace.equals("EMPTY")) {
+return null;
+}
+
+String[] coordinates = payloadWithoutWhitespace.split(",");
+
+if (coordinates.length != 6 ) {
+return null;
+}
+return convertPayloadToRectangle(coordinates);
+}
+
+/**
+ * Converts rectangle coordinates to rectangle in pixel coordinates
+ *
+ * @param coordinates - the first four items defines the rectangle
+ * @return rectangle in pixel coordinates
+ */
+public RectF convertPayloadToRectangle(String[] coordinates) {
+if (coordinates.length < 4 ) {
+return
[Libreoffice-bugs] [Bug 144173] EDITING Tracked character format change does not retain multiple character formatting settings
https://bugs.documentfoundation.org/show_bug.cgi?id=144173 NISZ LibreOffice Team changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from NISZ LibreOffice Team --- Verified in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d5ade739771ddf06cc7ee6d4af15672bfcf09ed6 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143792] FORMATTING: Style changes not applied to specific cells with multiple selection
https://bugs.documentfoundation.org/show_bug.cgi?id=143792 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- Sorry, I don't get it. I select A1:A3 and make it bold, which results in B1 remaining normal. But the cell property is bold. Cannot see any difference to the other cells and cannot reproduce in a new line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143792] FORMATTING: Style changes not applied to specific cells with multiple selection
https://bugs.documentfoundation.org/show_bug.cgi?id=143792 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- Sorry, I don't get it. I select A1:A3 and make it bold, which results in B1 remaining normal. But the cell property is bold. Cannot see any difference to the other cells and cannot reproduce in a new line. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144280] New: Note taking component
https://bugs.documentfoundation.org/show_bug.cgi?id=144280 Bug ID: 144280 Summary: Note taking component Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: penguinvitami...@stoneypoint.co.za Hi All I'm a heavy Microsoft OneNote user (I use LibreOffice on Mac, Linux and Windows for my personal stuff). No other office suite or standalone app (free or paid) feature a decent alternative for OneNote. I tried many alternatives and it just don't compare. Would adding a OneNote alternative not be an icebreaker for expanding LibreOffice? (I understand the massive investment/resources for such an undertaking). OneNote strenght is in its freeform layouts, embedding of attachments, drawing and freeform text blocks. Your current application suite has many of these features already and maybe a lot of it can be repurposed in such a Note taking app. Migrating data from OneNote to such an app a must. Thanks for the work and effort making LibreOffice great! -Penguinvitamins2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143390] New "Search Commands" feature: Search window remains on top when switching to other applications
https://bugs.documentfoundation.org/show_bug.cgi?id=143390 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||caol...@redhat.com --- Comment #2 from Heiko Tietze --- With kf5 and clicking another application window the search dialog disappears but puts LibreOffice back into the focus. Does not happen using the keyboard (alt+tab) which makes the dialog disappear first. Using gtk3 the dialog remains active but in the background. Using gen the dialog remains active and stays in front of all applications. Not sure how the behavior is on a native gtk system. And it maybe also depend on the window manager. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 7d0d07ed0f572c99c70d7f4384dfce644cbbf939 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: x11 Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143390] New "Search Commands" feature: Search window remains on top when switching to other applications
https://bugs.documentfoundation.org/show_bug.cgi?id=143390 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||caol...@redhat.com --- Comment #2 from Heiko Tietze --- With kf5 and clicking another application window the search dialog disappears but puts LibreOffice back into the focus. Does not happen using the keyboard (alt+tab) which makes the dialog disappear first. Using gtk3 the dialog remains active but in the background. Using gen the dialog remains active and stays in front of all applications. Not sure how the behavior is on a native gtk system. And it maybe also depend on the window manager. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 7d0d07ed0f572c99c70d7f4384dfce644cbbf939 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: x11 Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/dialog/SafeModeDialog.cxx | 1 svx/source/dialog/dlgctl3d.cxx | 5 - svx/source/dialog/pagectrl.cxx | 5 - svx/source/engine3d/obj3d.cxx | 6 -- svx/source/engine3d/scene3d.cxx| 2 svx/source/engine3d/view3d.cxx | 6 -- svx/source/fmcomp/fmgridif.cxx | 3 - svx/source/form/databaselocationinput.cxx | 2 svx/source/form/filtnav.cxx| 1 svx/source/form/formcontroller.cxx | 12 +--- svx/source/form/formdispatchinterceptor.cxx| 1 svx/source/form/navigatortree.cxx | 1 svx/source/items/autoformathelper.cxx | 30 -- svx/source/sdr/animation/animationstate.cxx| 3 - svx/source/sdr/animation/objectanimator.cxx| 1 svx/source/sdr/attribute/sdrallfillattributeshelper.cxx| 12 svx/source/sdr/attribute/sdreffectstextattribute.cxx | 2 svx/source/sdr/attribute/sdrfilltextattribute.cxx | 3 - svx/source/sdr/attribute/sdrformtextattribute.cxx | 5 - svx/source/sdr/attribute/sdrformtextoutlineattribute.cxx | 4 - svx/source/sdr/attribute/sdrlineeffectstextattribute.cxx | 3 - svx/source/sdr/attribute/sdrlinefilleffectstextattribute.cxx | 3 - svx/source/sdr/attribute/sdrtextattribute.cxx | 2 svx/source/sdr/contact/displayinfo.cxx | 1 svx/source/sdr/contact/objectcontact.cxx | 5 - svx/source/sdr/contact/objectcontactofobjlistpainter.cxx | 7 -- svx/source/sdr/contact/objectcontactofpageview.cxx | 3 - svx/source/sdr/contact/viewcontact.cxx | 5 - svx/source/sdr/contact/viewcontactofe3dscene.cxx | 6 -- svx/source/sdr/contact/viewcontactofmasterpagedescriptor.cxx | 3 - svx/source/sdr/contact/viewcontactofsdrobj.cxx | 3 - svx/source/sdr/contact/viewcontactofsdrpage.cxx| 3 - svx/source/sdr/contact/viewobjectcontact.cxx | 3 - svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx | 7 -- svx/source/sdr/overlay/overlaymanager.cxx | 6 -- svx/source/sdr/overlay/overlayobject.cxx | 4 - svx/source/sdr/overlay/overlaytools.cxx| 18 ++ svx/source/sdr/primitive2d/sdrcaptionprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrconnectorprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrellipseprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrframeborderprimitive2d.cxx | 11 +-- svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrmeasureprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrole2primitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrolecontentprimitive2d.cxx| 3 - svx/source/sdr/primitive2d/sdrpathprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx | 3 - svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx | 5 - svx/source/sidebar/area/AreaPropertyPanelBase.cxx | 15 - svx/source/sidebar/line/LinePropertyPanel.cxx | 3 - svx/source/sidebar/media/MediaPlaybackPanel.cxx| 1 svx/source/sidebar/nbdtmg.cxx | 3 - svx/source/sidebar/paragraph/ParaPropertyPanel.cxx | 1 svx/source/sidebar/possize/PosSizePropertyPanel.cxx| 3 - svx/source/sidebar/shapes/DefaultShapesPanel.cxx | 1 svx/source/smarttags/SmartTagMgr.cxx | 4 - svx/source/stbctrls/zoomsliderctrl.cxx |
[Libreoffice-bugs] [Bug 33749] Inconsistencies in Help pages on Cell Merging and Splitting (unmerging) in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=33749 --- Comment #25 from Heiko Tietze --- (In reply to Rafael Lima from comment #24) > ... in Writer the terminology is correct: "Split Cells". ... In Calc it > is not possible to Split a cell. True, so the only argument is consistency and burden for l10n. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 33749] Inconsistencies in Help pages on Cell Merging and Splitting (unmerging) in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=33749 --- Comment #25 from Heiko Tietze --- (In reply to Rafael Lima from comment #24) > ... in Writer the terminology is correct: "Split Cells". ... In Calc it > is not possible to Split a cell. True, so the only argument is consistency and burden for l10n. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5464 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||qui...@gmail.com --- Comment #11 from Heiko Tietze --- (In reply to Telesto from comment #5) > B) Please don't use the general claim about not being a graphic manipulation > tool. ... There is simply a balance to balance to it. Yes, it is. And dealing with the resolution is beyond but... > C) ... Shapes are not raster images. They don't have internal DPI.. ...is a strong argument. (In reply to Telesto from comment #7) > However I do ask myself to what end does Draw exist. Here is the answer: https://design.blog.documentfoundation.org/2016/04/01/the-many-faced-god-part-2-how-libreoffice-draw-is-expected-to-evolve/ (In reply to Regina Henschel from comment #10) > Idea for example: Add a toggle button with connecting bracket between > connected settings with the meaning "automatic adapt connected setting" vs > "do not connect settings but keep value in the other setting". Such > connection exists between "width" and "height" and it exists between > "resolution" and "dimension". No objection, sounds like an easy to understand solution. But DPI and size are not independently. You might be able to change the DPI first but the other way around it doesn't work. So before we introduce the connect toggle we need to work on the backend. Tomaz, what do you think? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5464 -- You are receiving this mail because: You are on the CC list for the bug.
