Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-20 Thread renayama19661014
Hi Dejan,

 ocf_run now has option -q to suppress output logging in case the
 command ran OK.

Thanks!!

I test ocf_run in pgsql.

Had better patch be able to appoint the practice by the option of ocf_run in an 
OCF parameter of
pgsql-RA, too?

(example)
 parameter name=monitor_silent_log unique=0 required=0
 

 /parameter

Or are not necessary?

Best Regards,
Hideo Yamauchi.



--- Dejan Muhamedagic deja...@fastmail.fm wrote:

 Hi Hideo-san,
 
 On Fri, Aug 20, 2010 at 11:20:03AM +0900, renayama19661...@ybb.ne.jp wrote:
  Hi Serge,
  Hi Lars,
  Hi Dejan,
  
  Thank you for an opinion.
  
  I think it to be good with an option of ocf_run. 
  An option will be useful in future. 
  
  To Dejan : About this matter, do we wait for the opinion of
  other people a little more?
 
 ocf_run now has option -q to suppress output logging in case the
 command ran OK.
 
 Cheers,
 
 Dejan
 
  
  Best Regards,
  Hideo Yamauchi.
  
  
  --- Serge Dubrouski serge...@gmail.com wrote:
  
   I'm in a complete agreement with Lars. Instead of creating new
   function runasowner_for_monitor() inside an RA, and pgsql probably not
   the only case of too much logging, I'd rather introduce a new option
   for ocf_run.
   
   On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree l...@novell.com 
   wrote:
On 2010-08-18T14:42:15, renayama19661...@ybb.ne.jp wrote:
   
I send the patch which I changed it of to form same as former monitor.
   
With this patch, the log of the monitor processing becomes quiet.
   
Yes, but the output goes to stdout still, it is just not captured by the
script - but the lrmd might still catch it.
   
In my opinion, the best fix would be to introduce a -q option to
ocf_run, which would prevent the logging for the success case.
   
   
Regards,
#65533; #65533;Lars
   
--
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N#65533;rnberg)
Experience is the name everyone gives to their mistakes. -- Oscar 
Wilde
   
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
   
   
   
   
   -- 
   Serge Dubrouski.
   ___
   Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
   http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
   Home Page: http://linux-ha.org/
   
  
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
 

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-19 Thread renayama19661014
Hi Serge,
Hi Lars,
Hi Dejan,

Thank you for an opinion.

I think it to be good with an option of ocf_run. 
An option will be useful in future. 

To Dejan : About this matter, do we wait for the opinion of other people a 
little more?

Best Regards,
Hideo Yamauchi.


--- Serge Dubrouski serge...@gmail.com wrote:

 I'm in a complete agreement with Lars. Instead of creating new
 function runasowner_for_monitor() inside an RA, and pgsql probably not
 the only case of too much logging, I'd rather introduce a new option
 for ocf_run.
 
 On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree l...@novell.com wrote:
  On 2010-08-18T14:42:15, renayama19661...@ybb.ne.jp wrote:
 
  I send the patch which I changed it of to form same as former monitor.
 
  With this patch, the log of the monitor processing becomes quiet.
 
  Yes, but the output goes to stdout still, it is just not captured by the
  script - but the lrmd might still catch it.
 
  In my opinion, the best fix would be to introduce a -q option to
  ocf_run, which would prevent the logging for the success case.
 
 
  Regards,
  #65533; #65533;Lars
 
  --
  Architect Storage/HA, OPS Engineering, Novell, Inc.
  SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N#65533;rnberg)
  Experience is the name everyone gives to their mistakes. -- Oscar Wilde
 
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
 
 
 
 
 -- 
 Serge Dubrouski.
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
 

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread Dejan Muhamedagic
Hi,

On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661...@ybb.ne.jp wrote:
 Hi, 
 
 I tested the latest edition of pgsql.
 
 However, log is output at every monitor processing in the latest edition.
 
 This is a practice result of select now().
 
 Aug 17 15:03:35 n1 pgsql[16269]: INFO: now -- 
 2010-08-17-15:03:35.28827+09
 (1 row) 
 Aug 17 15:03:45 n1 pgsql[16516]: INFO: now --- 
 2010-08-17
 15:03:45.528977+09 (1 row) 
 
 I send the patch which I changed it of to form same as former monitor.
 
 With this patch, the log of the monitor processing becomes quiet.

We need a different kind of ocf_run, the existing one makes too
much noise. Or to fix it. Anybody against dropping ocf_log info?

What is your opinion?

Thanks,

Dejan

 Best Regards,
 Hideo Yamauchi.


 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread renayama19661014
Hi Dejan,

 We need a different kind of ocf_run, the existing one makes too
 much noise. Or to fix it. Anybody against dropping ocf_log info?
 
 What is your opinion?

When we use logd, ocf_log functions well. 
However, we give considerably annoying log when we do not use logd. 

We advance to the direction that does not use logd now. 

If a problem is solved by changing it into new ocf_log, I obey the policy.


Best Regards,
Hideo Yamauchi.


--- Dejan Muhamedagic deja...@fastmail.fm wrote:

 Hi,
 
 On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661...@ybb.ne.jp wrote:
  Hi, 
  
  I tested the latest edition of pgsql.
  
  However, log is output at every monitor processing in the latest edition.
  
  This is a practice result of select now().
  
  Aug 17 15:03:35 n1 pgsql[16269]: INFO: now --
 2010-08-17-15:03:35.28827+09
  (1 row) 
  Aug 17 15:03:45 n1 pgsql[16516]: INFO: now --- 
  2010-08-17
  15:03:45.528977+09 (1 row) 
  
  I send the patch which I changed it of to form same as former monitor.
  
  With this patch, the log of the monitor processing becomes quiet.
 
 We need a different kind of ocf_run, the existing one makes too
 much noise. Or to fix it. Anybody against dropping ocf_log info?
 
 What is your opinion?
 
 Thanks,
 
 Dejan
 
  Best Regards,
  Hideo Yamauchi.
 
 
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
 
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
 

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread Dejan Muhamedagic
On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661...@ybb.ne.jp wrote:
 Hi Dejan,
 
  We need a different kind of ocf_run, the existing one makes too
  much noise. Or to fix it. Anybody against dropping ocf_log info?
  
  What is your opinion?
 
 When we use logd, ocf_log functions well. 

I don't understand how would logd make a difference?

 However, we give considerably annoying log when we do not use logd. 
 
 We advance to the direction that does not use logd now. 

Why is that?

 If a problem is solved by changing it into new ocf_log, I obey the policy.

Let's hope we get some input from others too.

Cheers,

Dejan

 Best Regards,
 Hideo Yamauchi.
 
 
 --- Dejan Muhamedagic deja...@fastmail.fm wrote:
 
  Hi,
  
  On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661...@ybb.ne.jp wrote:
   Hi, 
   
   I tested the latest edition of pgsql.
   
   However, log is output at every monitor processing in the latest edition.
   
   This is a practice result of select now().
   
   Aug 17 15:03:35 n1 pgsql[16269]: INFO: now --
  2010-08-17-15:03:35.28827+09
   (1 row) 
   Aug 17 15:03:45 n1 pgsql[16516]: INFO: now 
   --- 2010-08-17
   15:03:45.528977+09 (1 row) 
   
   I send the patch which I changed it of to form same as former monitor.
   
   With this patch, the log of the monitor processing becomes quiet.
  
  We need a different kind of ocf_run, the existing one makes too
  much noise. Or to fix it. Anybody against dropping ocf_log info?
  
  What is your opinion?
  
  Thanks,
  
  Dejan
  
   Best Regards,
   Hideo Yamauchi.
  
  
   ___
   Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
   http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
   Home Page: http://linux-ha.org/
  
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
  
 
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread renayama19661014
Hi Dejan,

Thank you for comment.

  When we use logd, ocf_log functions well. 
 
 I don't understand how would logd make a difference?

When we do not use logd, all log is output.
 * We use logfacility without using logd.

(snip)
if
  [ -n $HA_LOGFACILITY ]
then
  : logging through syslog
  # loglevel is unknown, use 'notice' for now
  loglevel=notice
  case ${*} in
*ERROR*)loglevel=err;;
*WARN*) loglevel=warning;;
*INFO*|info)loglevel=info;;
  esac
  logger -t $HA_LOGTAG -p ${HA_LOGFACILITY}.${loglevel} ${*} --- 
this
fi  
(snip)

  We advance to the direction that does not use logd now. 
 
 Why is that?

In fact, we always used the script which confirmed survival of logd.
However, we decided to abolish survival monitor of this logd this time. 
And it was decided that the log went by way of a syslog.

 Let's hope we get some input from others too.

All right.

Best Regards,
Hideo Yamauchi.


--- Dejan Muhamedagic deja...@fastmail.fm wrote:

 On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661...@ybb.ne.jp wrote:
  Hi Dejan,
  
   We need a different kind of ocf_run, the existing one makes too
   much noise. Or to fix it. Anybody against dropping ocf_log info?
   
   What is your opinion?
  
  When we use logd, ocf_log functions well. 
 
 I don't understand how would logd make a difference?
 
  However, we give considerably annoying log when we do not use logd. 
  
  We advance to the direction that does not use logd now. 
 
 Why is that?
 
  If a problem is solved by changing it into new ocf_log, I obey the policy.
 
 Let's hope we get some input from others too.
 
 Cheers,
 
 Dejan
 
  Best Regards,
  Hideo Yamauchi.
  
  
  --- Dejan Muhamedagic deja...@fastmail.fm wrote:
  
   Hi,
   
   On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661...@ybb.ne.jp 
   wrote:
Hi, 

I tested the latest edition of pgsql.

However, log is output at every monitor processing in the latest 
edition.

This is a practice result of select now().

Aug 17 15:03:35 n1 pgsql[16269]: INFO: now 
--
   2010-08-17-15:03:35.28827+09
(1 row) 
Aug 17 15:03:45 n1 pgsql[16516]: INFO: now 
--- 2010-08-17
15:03:45.528977+09 (1 row) 

I send the patch which I changed it of to form same as former monitor.

With this patch, the log of the monitor processing becomes quiet.
   
   We need a different kind of ocf_run, the existing one makes too
   much noise. Or to fix it. Anybody against dropping ocf_log info?
   
   What is your opinion?
   
   Thanks,
   
   Dejan
   
Best Regards,
Hideo Yamauchi.
   
   
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
   
   ___
   Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
   http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
   Home Page: http://linux-ha.org/
   
  
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
 

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread renayama19661014
Hi Dejan,

SorrryI made a mistake in comment.

 When we do not use logd, all log is output.
  * We use logfacility without using logd.
 
 (snip)
   if
 [ -n $HA_LOGFACILITY ]
 then
 : logging through syslog
 # loglevel is unknown, use 'notice' for now
   loglevel=notice
   case ${*} in
 *ERROR*)  loglevel=err;;
 *WARN*)   loglevel=warning;;
 *INFO*|info)  loglevel=info;;
 esac
 logger -t $HA_LOGTAG -p ${HA_LOGFACILITY}.${loglevel} ${*} --- 
 this
 fi
 (snip)

This is comment of another problem. 
Please please forget this comment.

The main point of my change is not to use ocf_run by monitor processing. 
When distance of monitor is short, the reason is because very useless log is 
output.

Best Regards,
Hideo Yamauchi.

--- renayama19661...@ybb.ne.jp wrote:

 Hi Dejan,
 
 Thank you for comment.
 
   When we use logd, ocf_log functions well. 
  
  I don't understand how would logd make a difference?
 
 When we do not use logd, all log is output.
  * We use logfacility without using logd.
 
 (snip)
   if
 [ -n $HA_LOGFACILITY ]
 then
 : logging through syslog
 # loglevel is unknown, use 'notice' for now
   loglevel=notice
   case ${*} in
 *ERROR*)  loglevel=err;;
 *WARN*)   loglevel=warning;;
 *INFO*|info)  loglevel=info;;
 esac
 logger -t $HA_LOGTAG -p ${HA_LOGFACILITY}.${loglevel} ${*} --- 
 this
 fi
 (snip)
 
   We advance to the direction that does not use logd now. 
  
  Why is that?
 
 In fact, we always used the script which confirmed survival of logd.
 However, we decided to abolish survival monitor of this logd this time. 
 And it was decided that the log went by way of a syslog.
 
  Let's hope we get some input from others too.
 
 All right.
 
 Best Regards,
 Hideo Yamauchi.
 
 
 --- Dejan Muhamedagic deja...@fastmail.fm wrote:
 
  On Wed, Aug 18, 2010 at 05:07:07PM +0900, renayama19661...@ybb.ne.jp wrote:
   Hi Dejan,
   
We need a different kind of ocf_run, the existing one makes too
much noise. Or to fix it. Anybody against dropping ocf_log info?

What is your opinion?
   
   When we use logd, ocf_log functions well. 
  
  I don't understand how would logd make a difference?
  
   However, we give considerably annoying log when we do not use logd. 
   
   We advance to the direction that does not use logd now. 
  
  Why is that?
  
   If a problem is solved by changing it into new ocf_log, I obey the policy.
  
  Let's hope we get some input from others too.
  
  Cheers,
  
  Dejan
  
   Best Regards,
   Hideo Yamauchi.
   
   
   --- Dejan Muhamedagic deja...@fastmail.fm wrote:
   
Hi,

On Wed, Aug 18, 2010 at 02:42:15PM +0900, renayama19661...@ybb.ne.jp 
wrote:
 Hi, 
 
 I tested the latest edition of pgsql.
 
 However, log is output at every monitor processing in the latest 
 edition.
 
 This is a practice result of select now().
 
 Aug 17 15:03:35 n1 pgsql[16269]: INFO: now 
 --
2010-08-17-15:03:35.28827+09
 (1 row) 
 Aug 17 15:03:45 n1 pgsql[16516]: INFO: now 
 --- 2010-08-17
 15:03:45.528977+09 (1 row) 
 
 I send the patch which I changed it of to form same as former monitor.
 
 With this patch, the log of the monitor processing becomes quiet.

We need a different kind of ocf_run, the existing one makes too
much noise. Or to fix it. Anybody against dropping ocf_log info?

What is your opinion?

Thanks,

Dejan

 Best Regards,
 Hideo Yamauchi.


 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

   
   ___
   Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
   http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
   Home Page: http://linux-ha.org/
  ___
  Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
  http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
  Home Page: http://linux-ha.org/
  
 
 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/
 

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org

Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread Lars Marowsky-Bree
On 2010-08-18T14:42:15, renayama19661...@ybb.ne.jp wrote:

 I send the patch which I changed it of to form same as former monitor.
 
 With this patch, the log of the monitor processing becomes quiet.

Yes, but the output goes to stdout still, it is just not captured by the
script - but the lrmd might still catch it.

In my opinion, the best fix would be to introduce a -q option to
ocf_run, which would prevent the logging for the success case.


Regards,
Lars

-- 
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Experience is the name everyone gives to their mistakes. -- Oscar Wilde

___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-18 Thread Serge Dubrouski
I'm in a complete agreement with Lars. Instead of creating new
function runasowner_for_monitor() inside an RA, and pgsql probably not
the only case of too much logging, I'd rather introduce a new option
for ocf_run.

On Wed, Aug 18, 2010 at 5:59 AM, Lars Marowsky-Bree l...@novell.com wrote:
 On 2010-08-18T14:42:15, renayama19661...@ybb.ne.jp wrote:

 I send the patch which I changed it of to form same as former monitor.

 With this patch, the log of the monitor processing becomes quiet.

 Yes, but the output goes to stdout still, it is just not captured by the
 script - but the lrmd might still catch it.

 In my opinion, the best fix would be to introduce a -q option to
 ocf_run, which would prevent the logging for the success case.


 Regards,
    Lars

 --
 Architect Storage/HA, OPS Engineering, Novell, Inc.
 SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
 Experience is the name everyone gives to their mistakes. -- Oscar Wilde

 ___
 Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
 http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
 Home Page: http://linux-ha.org/




-- 
Serge Dubrouski.
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


[Linux-ha-dev] [PATCH]Restraint of the noisy log output of the monitor processing.

2010-08-17 Thread renayama19661014
Hi, 

I tested the latest edition of pgsql.

However, log is output at every monitor processing in the latest edition.

This is a practice result of select now().

Aug 17 15:03:35 n1 pgsql[16269]: INFO: now -- 
2010-08-17-15:03:35.28827+09
(1 row) 
Aug 17 15:03:45 n1 pgsql[16516]: INFO: now --- 
2010-08-17
15:03:45.528977+09 (1 row) 

I send the patch which I changed it of to form same as former monitor.

With this patch, the log of the monitor processing becomes quiet.


Best Regards,
Hideo Yamauchi.


pgsql.patch
Description: 465324755-pgsql.patch
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/