from:"arvind Yadav"

[PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/nxp/clk-lpc32xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index 7b359af..b669a5c 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -526,7 +526,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
!(pll_is_valid(parent_rate, 1, 100, 2000)
  && pll_is_valid(cco_rate, 1, 15600, 32000)
  && pll_is_valid(ref_rate, 1, 100, 2700)))
-   pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu",
+   pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu\n",
   clk_hw_get_name(hw),
   parent_rate, cco_rate, ref_rate);
 
@@ -1505,7 +1505,7 @@ static void __init lpc32xx_clk_init(struct device_node 
*np)
return;
}
if (clk_get_rate(clk_32k) != 32768) {
-   pr_err("invalid clock rate of external 32KHz oscillator");
+   pr_err("invalid clock rate of external 32KHz oscillator\n");
return;
}
 
-- 
1.9.1

[PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/nxp/clk-lpc32xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index 7b359af..b669a5c 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -526,7 +526,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
!(pll_is_valid(parent_rate, 1, 100, 2000)
  && pll_is_valid(cco_rate, 1, 15600, 32000)
  && pll_is_valid(ref_rate, 1, 100, 2700)))
-   pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu",
+   pr_err("%s: PLL clocks are not in valid ranges: %lu/%lu/%lu\n",
   clk_hw_get_name(hw),
   parent_rate, cco_rate, ref_rate);
 
@@ -1505,7 +1505,7 @@ static void __init lpc32xx_clk_init(struct device_node 
*np)
return;
}
if (clk_get_rate(clk_32k) != 32768) {
-   pr_err("invalid clock rate of external 32KHz oscillator");
+   pr_err("invalid clock rate of external 32KHz oscillator\n");
return;
}
 
-- 
1.9.1

[PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/h8300/clk-div.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/h8300/clk-div.c b/drivers/clk/h8300/clk-div.c
index 4ae6244..d413ade 100644
--- a/drivers/clk/h8300/clk-div.c
+++ b/drivers/clk/h8300/clk-div.c
@@ -24,13 +24,13 @@ static void __init h8300_div_clk_setup(struct device_node 
*node)
 
num_parents = of_clk_get_parent_count(node);
if (!num_parents) {
-   pr_err("%s: no parent found", clk_name);
+   pr_err("%s: no parent found\n", clk_name);
return;
}
 
divcr = of_iomap(node, 0);
if (divcr == NULL) {
-   pr_err("%s: failed to map divide register", clk_name);
+   pr_err("%s: failed to map divide register\n", clk_name);
goto error;
}
offset = (unsigned long)divcr & 3;
-- 
1.9.1

[PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/clk-stm32f4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index 96c6b6b..da44f8d 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -1424,7 +1424,7 @@ static void __init stm32f4_rcc_init(struct device_node 
*np)
 
base = of_iomap(np, 0);
if (!base) {
-   pr_err("%s: unable to map resource", np->name);
+   pr_err("%s: unable to map resource\n", np->name);
return;
}
 
-- 
1.9.1

[PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/h8300/clk-div.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/h8300/clk-div.c b/drivers/clk/h8300/clk-div.c
index 4ae6244..d413ade 100644
--- a/drivers/clk/h8300/clk-div.c
+++ b/drivers/clk/h8300/clk-div.c
@@ -24,13 +24,13 @@ static void __init h8300_div_clk_setup(struct device_node 
*node)
 
num_parents = of_clk_get_parent_count(node);
if (!num_parents) {
-   pr_err("%s: no parent found", clk_name);
+   pr_err("%s: no parent found\n", clk_name);
return;
}
 
divcr = of_iomap(node, 0);
if (divcr == NULL) {
-   pr_err("%s: failed to map divide register", clk_name);
+   pr_err("%s: failed to map divide register\n", clk_name);
goto error;
}
offset = (unsigned long)divcr & 3;
-- 
1.9.1

[PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/clk-stm32f4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index 96c6b6b..da44f8d 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -1424,7 +1424,7 @@ static void __init stm32f4_rcc_init(struct device_node 
*np)
 
base = of_iomap(np, 0);
if (!base) {
-   pr_err("%s: unable to map resource", np->name);
+   pr_err("%s: unable to map resource\n", np->name);
return;
}
 
-- 
1.9.1

[PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/clk-frac-synth.c 
b/drivers/clk/spear/clk-frac-synth.c
index 58d678b..cbdf43a 100644
--- a/drivers/clk/spear/clk-frac-synth.c
+++ b/drivers/clk/spear/clk-frac-synth.c
@@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char 
*parent_name,
struct clk *clk;
 
if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-   pr_err("Invalid arguments passed");
+   pr_err("Invalid arguments passed\n");
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1

[PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/h8300/clk-h8s2678.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/h8300/clk-h8s2678.c b/drivers/clk/h8300/clk-h8s2678.c
index fc24b0b..b68045d 100644
--- a/drivers/clk/h8300/clk-h8s2678.c
+++ b/drivers/clk/h8300/clk-h8s2678.c
@@ -93,7 +93,7 @@ static void __init h8s2678_pll_clk_setup(struct device_node 
*node)
 
num_parents = of_clk_get_parent_count(node);
if (!num_parents) {
-   pr_err("%s: no parent found", clk_name);
+   pr_err("%s: no parent found\n", clk_name);
return;
}
 
@@ -104,13 +104,13 @@ static void __init h8s2678_pll_clk_setup(struct 
device_node *node)
 
pll_clock->sckcr = of_iomap(node, 0);
if (pll_clock->sckcr == NULL) {
-   pr_err("%s: failed to map divide register", clk_name);
+   pr_err("%s: failed to map divide register\n", clk_name);
goto free_clock;
}
 
pll_clock->pllcr = of_iomap(node, 1);
if (pll_clock->pllcr == NULL) {
-   pr_err("%s: failed to map multiply register", clk_name);
+   pr_err("%s: failed to map multiply register\n", clk_name);
goto unmap_sckcr;
}
 
-- 
1.9.1

[PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/clk-frac-synth.c 
b/drivers/clk/spear/clk-frac-synth.c
index 58d678b..cbdf43a 100644
--- a/drivers/clk/spear/clk-frac-synth.c
+++ b/drivers/clk/spear/clk-frac-synth.c
@@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char 
*parent_name,
struct clk *clk;
 
if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-   pr_err("Invalid arguments passed");
+   pr_err("Invalid arguments passed\n");
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1

[PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/h8300/clk-h8s2678.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/h8300/clk-h8s2678.c b/drivers/clk/h8300/clk-h8s2678.c
index fc24b0b..b68045d 100644
--- a/drivers/clk/h8300/clk-h8s2678.c
+++ b/drivers/clk/h8300/clk-h8s2678.c
@@ -93,7 +93,7 @@ static void __init h8s2678_pll_clk_setup(struct device_node 
*node)
 
num_parents = of_clk_get_parent_count(node);
if (!num_parents) {
-   pr_err("%s: no parent found", clk_name);
+   pr_err("%s: no parent found\n", clk_name);
return;
}
 
@@ -104,13 +104,13 @@ static void __init h8s2678_pll_clk_setup(struct 
device_node *node)
 
pll_clock->sckcr = of_iomap(node, 0);
if (pll_clock->sckcr == NULL) {
-   pr_err("%s: failed to map divide register", clk_name);
+   pr_err("%s: failed to map divide register\n", clk_name);
goto free_clock;
}
 
pll_clock->pllcr = of_iomap(node, 1);
if (pll_clock->pllcr == NULL) {
-   pr_err("%s: failed to map multiply register", clk_name);
+   pr_err("%s: failed to map multiply register\n", clk_name);
goto unmap_sckcr;
}
 
-- 
1.9.1

[PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/clk/spear/clk-gpt-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/clk-gpt-synth.c 
b/drivers/clk/spear/clk-gpt-synth.c
index 1a722e9..1cf219a6 100644
--- a/drivers/clk/spear/clk-gpt-synth.c
+++ b/drivers/clk/spear/clk-gpt-synth.c
@@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char 
*parent_name, unsigned
struct clk *clk;
 
if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-   pr_err("Invalid arguments passed");
+   pr_err("Invalid arguments passed\n");
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1

[PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/spear/clk-gpt-synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/clk-gpt-synth.c 
b/drivers/clk/spear/clk-gpt-synth.c
index 1a722e9..1cf219a6 100644
--- a/drivers/clk/spear/clk-gpt-synth.c
+++ b/drivers/clk/spear/clk-gpt-synth.c
@@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char 
*parent_name, unsigned
struct clk *clk;
 
if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
-   pr_err("Invalid arguments passed");
+   pr_err("Invalid arguments passed\n");
return ERR_PTR(-EINVAL);
}
 
-- 
1.9.1

[PATCH 0/6] clk: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Arvind Yadav (6):
  [PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines
  [PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines
  [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines
  [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
  [PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines
  [PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

 drivers/clk/clk-stm32f4.c  | 2 +-
 drivers/clk/h8300/clk-div.c| 4 ++--
 drivers/clk/h8300/clk-h8s2678.c| 6 +++---
 drivers/clk/nxp/clk-lpc32xx.c  | 4 ++--
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 drivers/clk/spear/clk-gpt-synth.c  | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

-- 
1.9.1

[PATCH 0/6] clk: pr_err() strings should end with newlines

2017-11-23 Thread Arvind Yadav

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Arvind Yadav (6):
  [PATCH 1/6] clk: stm32f4: pr_err() strings should end with newlines
  [PATCH 2/6] clk: lpc32xx: pr_err() strings should end with newlines
  [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines
  [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
  [PATCH 5/6] clk: h8s2678: pr_err() strings should end with newlines
  [PATCH 6/6] clk: h8300: pr_err() strings should end with newlines

 drivers/clk/clk-stm32f4.c  | 2 +-
 drivers/clk/h8300/clk-div.c| 4 ++--
 drivers/clk/h8300/clk-h8s2678.c| 6 +++---
 drivers/clk/nxp/clk-lpc32xx.c  | 4 ++--
 drivers/clk/spear/clk-frac-synth.c | 2 +-
 drivers/clk/spear/clk-gpt-synth.c  | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

-- 
1.9.1

[PATCH] MIPS: ralink: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2: Subject spelling was not correct. change FIX in place
of 'ix'.
changes in v3: Return rt->irq instead of -ENOENT.

 arch/mips/ralink/timer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..4f46a45 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,9 +109,9 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
-   return -ENOENT;
+   return rt->irq;
}
 
rt->membase = devm_ioremap_resource(>dev, res);
-- 
2.7.4

[PATCH] MIPS: ralink: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2: Subject spelling was not correct. change FIX in place
of 'ix'.
changes in v3: Return rt->irq instead of -ENOENT.

 arch/mips/ralink/timer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..4f46a45 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,9 +109,9 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
-   return -ENOENT;
+   return rt->irq;
}
 
rt->membase = devm_ioremap_resource(>dev, res);
-- 
2.7.4

[PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq

2017-11-23 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/extcon/extcon-axp288.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 981fba5..e16a783 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -301,6 +301,9 @@ static int axp288_extcon_probe(struct platform_device *pdev)
 
for (i = 0; i < EXTCON_IRQ_END; i++) {
pirq = platform_get_irq(pdev, i);
+   if (pirq < 0)
+   return pirq;
+
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_err(>dev,
-- 
2.7.4

[PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq

2017-11-23 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
 drivers/extcon/extcon-axp288.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 981fba5..e16a783 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -301,6 +301,9 @@ static int axp288_extcon_probe(struct platform_device *pdev)
 
for (i = 0; i < EXTCON_IRQ_END; i++) {
pirq = platform_get_irq(pdev, i);
+   if (pirq < 0)
+   return pirq;
+
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_err(>dev,
-- 
2.7.4

[PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/extcon/extcon-adc-jack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
index 3877d86..1802635 100644
--- a/drivers/extcon/extcon-adc-jack.c
+++ b/drivers/extcon/extcon-adc-jack.c
@@ -144,7 +144,7 @@ static int adc_jack_probe(struct platform_device *pdev)
return err;
 
data->irq = platform_get_irq(pdev, 0);
-   if (!data->irq) {
+   if (data->irq < 0) {
dev_err(>dev, "platform_get_irq failed\n");
return -ENODEV;
}
-- 
2.7.4

[PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
 drivers/extcon/extcon-adc-jack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
index 3877d86..1802635 100644
--- a/drivers/extcon/extcon-adc-jack.c
+++ b/drivers/extcon/extcon-adc-jack.c
@@ -144,7 +144,7 @@ static int adc_jack_probe(struct platform_device *pdev)
return err;
 
data->irq = platform_get_irq(pdev, 0);
-   if (!data->irq) {
+   if (data->irq < 0) {
dev_err(>dev, "platform_get_irq failed\n");
return -ENODEV;
}
-- 
2.7.4

[PATCH 0/2] Handle return value and error checking of platform_get_irq

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
platform_get_irq() can fail here and we must check its return value.

Arvind Yadav (2):
  [PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking
  [PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq

 drivers/extcon/extcon-adc-jack.c | 2 +-
 drivers/extcon/extcon-axp288.c   | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH 0/2] Handle return value and error checking of platform_get_irq

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
platform_get_irq() can fail here and we must check its return value.

Arvind Yadav (2):
  [PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking
  [PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq

 drivers/extcon/extcon-adc-jack.c | 2 +-
 drivers/extcon/extcon-axp288.c   | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH] ipmi: bt-bmc: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/char/ipmi/bt-bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index 70d434b..7566683 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -410,7 +410,7 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc,
int rc;
 
bt_bmc->irq = platform_get_irq(pdev, 0);
-   if (!bt_bmc->irq)
+   if (bt_bmc->irq < 0)
return -ENODEV;
 
rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED,
-- 
2.7.4

[PATCH] ipmi: bt-bmc: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
 drivers/char/ipmi/bt-bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index 70d434b..7566683 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -410,7 +410,7 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc,
int rc;
 
bt_bmc->irq = platform_get_irq(pdev, 0);
-   if (!bt_bmc->irq)
+   if (bt_bmc->irq < 0)
return -ENODEV;
 
rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED,
-- 
2.7.4

[PATCH v2] MIPS: ralink: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2: Subject spelling was not correct. change FIX in place
   of 'ix'.

 arch/mips/ralink/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..913dc84b 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,7 +109,7 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
return -ENOENT;
}
-- 
2.7.4

[PATCH v2] MIPS: ralink: Fix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2: Subject spelling was not correct. change FIX in place
   of 'ix'.

 arch/mips/ralink/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..913dc84b 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,7 +109,7 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
return -ENOENT;
}
-- 
2.7.4

[PATCH] MIPS: ralink: ix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 arch/mips/ralink/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..913dc84b 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,7 +109,7 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
return -ENOENT;
}
-- 
2.7.4

[PATCH] MIPS: ralink: ix platform_get_irq's error checking

2017-11-23 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
 arch/mips/ralink/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b2..913dc84b 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -109,7 +109,7 @@ static int rt_timer_probe(struct platform_device *pdev)
}
 
rt->irq = platform_get_irq(pdev, 0);
-   if (!rt->irq) {
+   if (rt->irq < 0) {
dev_err(>dev, "failed to load irq\n");
return -ENOENT;
}
-- 
2.7.4

[PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-21 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Return keypad->irq insted of -ENXIO.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENXIO insted of keypad->irq. Which was not correct in v3.
changes in v5 :
  Remove changes of v3 and v4. go back to version v2. Which is 
correct.
  No need to check for IRQ0 and return keypad->irq insted of -ENXIO.

 drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..01788a7 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
-   err = -ENXIO;
+   if (keypad->irq < 0) {
+   err = keypad->irq;
goto failed_free;
}
 
-- 
2.7.4

[PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-21 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Return keypad->irq insted of -ENXIO.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENXIO insted of keypad->irq. Which was not correct in v3.
changes in v5 :
  Remove changes of v3 and v4. go back to version v2. Which is 
correct.
  No need to check for IRQ0 and return keypad->irq insted of -ENXIO.

 drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..01788a7 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
-   err = -ENXIO;
+   if (keypad->irq < 0) {
+   err = keypad->irq;
goto failed_free;
}
 
-- 
2.7.4

[PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Return keypad->irq insted of -ENXIO.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes ib v4 :
  Return -ENXIO insted of keypad->irq. Which was not correct in v3.

 drivers/input/keyboard/ep93xx_keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..c6eb31a 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
+   if (keypad->irq <= 0) {
err = -ENXIO;
goto failed_free;
}
-- 
2.7.4

[PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-20 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Return keypad->irq insted of -ENXIO.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes ib v4 :
  Return -ENXIO insted of keypad->irq. Which was not correct in v3.

 drivers/input/keyboard/ep93xx_keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..c6eb31a 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
+   if (keypad->irq <= 0) {
err = -ENXIO;
goto failed_free;
}
-- 
2.7.4

Re: [PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-19 Thread Arvind Yadav


Hi viresh,

Could you please acknowledge a latest version(v3) of this patch.

Thanks,


On Monday 20 November 2017 11:14 AM, Viresh Kumar wrote:

On 18-11-17, 15:03, Arvind Yadav wrote:

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

  drivers/mmc/host/sdhci-spear.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
  
  	sdhci = sdhci_priv(host);

Acked-by: Viresh Kumar <viresh.ku...@linaro.org>

Re: [PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-19 Thread Arvind Yadav


Hi viresh,

Could you please acknowledge a latest version(v3) of this patch.

Thanks,


On Monday 20 November 2017 11:14 AM, Viresh Kumar wrote:

On 18-11-17, 15:03, Arvind Yadav wrote:

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

  drivers/mmc/host/sdhci-spear.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
  
  	sdhci = sdhci_priv(host);

Acked-by: Viresh Kumar

Re: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-19 Thread Arvind Yadav


Hi viresh,

Could you please acknowledge a latest version of this patch.

Thanks,


On Monday 20 November 2017 11:13 AM, Viresh Kumar wrote:

On 18-11-17, 01:58, Arvind Yadav wrote:

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
  drivers/mmc/host/sdhci-spear.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq < 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
  
  	sdhci = sdhci_priv(host);

Acked-by: Viresh Kumar <viresh.ku...@linaro.org>

Re: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-19 Thread Arvind Yadav


Hi viresh,

Could you please acknowledge a latest version of this patch.

Thanks,


On Monday 20 November 2017 11:13 AM, Viresh Kumar wrote:

On 18-11-17, 01:58, Arvind Yadav wrote:

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
  drivers/mmc/host/sdhci-spear.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq < 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
  
  	sdhci = sdhci_priv(host);

Acked-by: Viresh Kumar

[PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sdhci-acpi.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index b988997..0d9965b 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
host->hw_name   = "ACPI";
host->ops   = _acpi_ops_dflt;
host->irq   = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   err = -EINVAL;
+   goto err_free;
+   }
 
host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
resource_size(iomem));
-- 
2.7.4

[PATCH 2/6 v3] mmc: s3cmci: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/s3cmci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index f7f157a..36daee1 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1658,7 +1658,7 @@ static int s3cmci_probe(struct platform_device *pdev)
}
 
host->irq = platform_get_irq(pdev, 0);
-   if (host->irq == 0) {
+   if (host->irq <= 0) {
dev_err(>dev, "failed to get interrupt resource.\n");
ret = -EINVAL;
goto probe_iounmap;
-- 
2.7.4

[PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sunxi-mmc.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index cc98355d..c926ac8 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct 
sunxi_mmc_host *host,
goto error_assert_reset;
 
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = -EINVAL;
+   goto error_assert_reset;
+   }
+
return devm_request_threaded_irq(>dev, host->irq, sunxi_mmc_irq,
sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
 
-- 
2.7.4

[PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sdhci-acpi.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index b988997..0d9965b 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
host->hw_name   = "ACPI";
host->ops   = _acpi_ops_dflt;
host->irq   = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   err = -EINVAL;
+   goto err_free;
+   }
 
host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
resource_size(iomem));
-- 
2.7.4

[PATCH 2/6 v3] mmc: s3cmci: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/s3cmci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index f7f157a..36daee1 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1658,7 +1658,7 @@ static int s3cmci_probe(struct platform_device *pdev)
}
 
host->irq = platform_get_irq(pdev, 0);
-   if (host->irq == 0) {
+   if (host->irq <= 0) {
dev_err(>dev, "failed to get interrupt resource.\n");
ret = -EINVAL;
goto probe_iounmap;
-- 
2.7.4

[PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sunxi-mmc.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index cc98355d..c926ac8 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct 
sunxi_mmc_host *host,
goto error_assert_reset;
 
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = -EINVAL;
+   goto error_assert_reset;
+   }
+
return devm_request_threaded_irq(>dev, host->irq, sunxi_mmc_irq,
sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
 
-- 
2.7.4

[PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of irq.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e0862d3..32a6a22 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1208,7 +1208,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
}
 
irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   if (irq <= 0) {
dev_err(>dev, "failed to get interrupt resource.\n");
ret = -EINVAL;
goto free_host;
-- 
2.7.4

[PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sdhci-spear.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..e04485e 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = -EINVAL;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
sdhci = sdhci_priv(host);
-- 
2.7.4

[PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of irq.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e0862d3..32a6a22 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1208,7 +1208,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
}
 
irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   if (irq <= 0) {
dev_err(>dev, "failed to get interrupt resource.\n");
ret = -EINVAL;
goto free_host;
-- 
2.7.4

[PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  return -EINVAL instead of host->irq.

 drivers/mmc/host/sdhci-spear.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..e04485e 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = -EINVAL;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
sdhci = sdhci_priv(host);
-- 
2.7.4

[PATCH 2/2 v3] misc: atmel-ssc: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes in v3:
  Return -ENODEV instead of ssc->irq.

 drivers/misc/atmel-ssc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index b2a0340..2ec0f9e 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev)
clk_disable_unprepare(ssc->clk);
 
ssc->irq = platform_get_irq(pdev, 0);
-   if (!ssc->irq) {
+   if (ssc->irq <= 0) {
dev_dbg(>dev, "could not get irq\n");
return -ENXIO;
}
-- 
2.7.4

[PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes in v3:
  Return -ENODEV instead of lpc_snoop->irq.

 drivers/misc/aspeed-lpc-snoop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c
index cb78c98..e3be88f 100644
--- a/drivers/misc/aspeed-lpc-snoop.c
+++ b/drivers/misc/aspeed-lpc-snoop.c
@@ -115,7 +115,7 @@ static int aspeed_lpc_snoop_config_irq(struct 
aspeed_lpc_snoop *lpc_snoop,
int rc;
 
lpc_snoop->irq = platform_get_irq(pdev, 0);
-   if (!lpc_snoop->irq)
+   if (lpc_snoop->irq <= 0)
return -ENODEV;
 
rc = devm_request_irq(dev, lpc_snoop->irq,
-- 
2.7.4

[PATCH 2/2 v3] misc: atmel-ssc: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes in v3:
  Return -ENODEV instead of ssc->irq.

 drivers/misc/atmel-ssc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index b2a0340..2ec0f9e 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev)
clk_disable_unprepare(ssc->clk);
 
ssc->irq = platform_get_irq(pdev, 0);
-   if (!ssc->irq) {
+   if (ssc->irq <= 0) {
dev_dbg(>dev, "could not get irq\n");
return -ENXIO;
}
-- 
2.7.4

[PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes in v3:
  Return -ENODEV instead of lpc_snoop->irq.

 drivers/misc/aspeed-lpc-snoop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c
index cb78c98..e3be88f 100644
--- a/drivers/misc/aspeed-lpc-snoop.c
+++ b/drivers/misc/aspeed-lpc-snoop.c
@@ -115,7 +115,7 @@ static int aspeed_lpc_snoop_config_irq(struct 
aspeed_lpc_snoop *lpc_snoop,
int rc;
 
lpc_snoop->irq = platform_get_irq(pdev, 0);
-   if (!lpc_snoop->irq)
+   if (lpc_snoop->irq <= 0)
return -ENODEV;
 
rc = devm_request_irq(dev, lpc_snoop->irq,
-- 
2.7.4

[PATCH 3/3 v3] mfd: sun4i-gpadc: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes in v3 :
  return -EINVAL insted of irq.

 drivers/mfd/sun4i-gpadc.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/sun4i-gpadc.c b/drivers/mfd/sun4i-gpadc.c
index 9cfc881..79a39fe 100644
--- a/drivers/mfd/sun4i-gpadc.c
+++ b/drivers/mfd/sun4i-gpadc.c
@@ -100,8 +100,8 @@ static int sun4i_gpadc_probe(struct platform_device *pdev)
struct resource *mem;
const struct of_device_id *of_id;
const struct mfd_cell *cells;
-   unsigned int irq, size;
-   int ret;
+   unsigned int size;
+   int ret, irq;
 
of_id = of_match_node(sun4i_gpadc_of_match, pdev->dev.of_node);
if (!of_id)
@@ -148,6 +148,9 @@ static int sun4i_gpadc_probe(struct platform_device *pdev)
regmap_write(dev->regmap, SUN4I_GPADC_INT_FIFOC, 0);
 
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return -EINVAL;
+
ret = devm_regmap_add_irq_chip(>dev, dev->regmap, irq,
   IRQF_ONESHOT, 0,
   _gpadc_regmap_irq_chip,
-- 
2.7.4

[PATCH 1/3 v3] mfd: ipaq-micro: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes in v3 :
  return -EINVAL insted of irq.

 drivers/mfd/ipaq-micro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index cd762d0..176cf65 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -410,7 +410,7 @@ static int __init micro_probe(struct platform_device *pdev)
micro_reset_comm(micro);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
+   if (irq <= 0)
return -EINVAL;
ret = devm_request_irq(>dev, irq, micro_serial_isr,
   IRQF_SHARED, "ipaq-micro",
-- 
2.7.4

[PATCH 1/3 v3] mfd: ipaq-micro: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes in v3 :
  return -EINVAL insted of irq.

 drivers/mfd/ipaq-micro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index cd762d0..176cf65 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -410,7 +410,7 @@ static int __init micro_probe(struct platform_device *pdev)
micro_reset_comm(micro);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
+   if (irq <= 0)
return -EINVAL;
ret = devm_request_irq(>dev, irq, micro_serial_isr,
   IRQF_SHARED, "ipaq-micro",
-- 
2.7.4

[PATCH 3/3 v3] mfd: sun4i-gpadc: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes in v3 :
  return -EINVAL insted of irq.

 drivers/mfd/sun4i-gpadc.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/sun4i-gpadc.c b/drivers/mfd/sun4i-gpadc.c
index 9cfc881..79a39fe 100644
--- a/drivers/mfd/sun4i-gpadc.c
+++ b/drivers/mfd/sun4i-gpadc.c
@@ -100,8 +100,8 @@ static int sun4i_gpadc_probe(struct platform_device *pdev)
struct resource *mem;
const struct of_device_id *of_id;
const struct mfd_cell *cells;
-   unsigned int irq, size;
-   int ret;
+   unsigned int size;
+   int ret, irq;
 
of_id = of_match_node(sun4i_gpadc_of_match, pdev->dev.of_node);
if (!of_id)
@@ -148,6 +148,9 @@ static int sun4i_gpadc_probe(struct platform_device *pdev)
regmap_write(dev->regmap, SUN4I_GPADC_INT_FIFOC, 0);
 
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return -EINVAL;
+
ret = devm_regmap_add_irq_chip(>dev, dev->regmap, irq,
   IRQF_ONESHOT, 0,
   _gpadc_regmap_irq_chip,
-- 
2.7.4

[PATCH 5/5 v3] ASoC: intel: mfld: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  Return EIO insted of ctx->irq_num.

 sound/soc/intel/boards/mfld_machine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/boards/mfld_machine.c 
b/sound/soc/intel/boards/mfld_machine.c
index 6f44acf..c819210 100644
--- a/sound/soc/intel/boards/mfld_machine.c
+++ b/sound/soc/intel/boards/mfld_machine.c
@@ -372,6 +372,8 @@ static int snd_mfld_mc_probe(struct platform_device *pdev)
 
/* retrive the irq number */
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return -ENODEV;
 
/* audio interrupt base of SRAM location where
 * interrupts are stored by System FW */
-- 
2.7.4

[PATCH 5/5 v3] ASoC: intel: mfld: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  Return EIO insted of ctx->irq_num.

 sound/soc/intel/boards/mfld_machine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/boards/mfld_machine.c 
b/sound/soc/intel/boards/mfld_machine.c
index 6f44acf..c819210 100644
--- a/sound/soc/intel/boards/mfld_machine.c
+++ b/sound/soc/intel/boards/mfld_machine.c
@@ -372,6 +372,8 @@ static int snd_mfld_mc_probe(struct platform_device *pdev)
 
/* retrive the irq number */
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return -ENODEV;
 
/* audio interrupt base of SRAM location where
 * interrupts are stored by System FW */
-- 
2.7.4

[PATCH 3/5 v4] ASoC: nuc900: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so using signed variable ret.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq.
 sound/soc/nuc900/nuc900-ac97.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index b6615af..893ccf2 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -345,11 +345,12 @@ static int nuc900_ac97_drvprobe(struct platform_device 
*pdev)
goto out;
}
 
-   nuc900_audio->irq_num = platform_get_irq(pdev, 0);
-   if (!nuc900_audio->irq_num) {
+   ret = platform_get_irq(pdev, 0);
+   if (ret <= 0) {
ret = -EBUSY;
goto out;
}
+   nuc900_audio->irq_num = ret;
 
nuc900_ac97_data = nuc900_audio;
 
-- 
2.7.4

[PATCH 3/5 v4] ASoC: nuc900: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so using signed variable ret.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq.
 sound/soc/nuc900/nuc900-ac97.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index b6615af..893ccf2 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -345,11 +345,12 @@ static int nuc900_ac97_drvprobe(struct platform_device 
*pdev)
goto out;
}
 
-   nuc900_audio->irq_num = platform_get_irq(pdev, 0);
-   if (!nuc900_audio->irq_num) {
+   ret = platform_get_irq(pdev, 0);
+   if (ret <= 0) {
ret = -EBUSY;
goto out;
}
+   nuc900_audio->irq_num = ret;
 
nuc900_ac97_data = nuc900_audio;
 
-- 
2.7.4

[PATCH 2/5 v4] ASoC: mt8173: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq_id.

 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c 
b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 8a643a3..1153566 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe 
*afe)
 static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
 {
int ret, i;
-   unsigned int irq_id;
+   int irq_id;
struct mtk_base_afe *afe;
struct mt8173_afe_private *afe_priv;
struct resource *res;
@@ -1105,7 +1105,7 @@ static int mt8173_afe_pcm_dev_probe(struct 
platform_device *pdev)
afe->dev = >dev;
 
irq_id = platform_get_irq(pdev, 0);
-   if (!irq_id) {
+   if (irq_id <= 0) {
dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name);
return -ENXIO;
}
-- 
2.7.4

[PATCH 4/5 v3] ASoC: intel: sst: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  Return EIO insted of ctx->irq_num.

 sound/soc/intel/atom/sst/sst_acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c 
b/sound/soc/intel/atom/sst/sst_acpi.c
index 32d6e02..5e46d06f 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -236,6 +236,9 @@ static int sst_platform_get_resources(struct intel_sst_drv 
*ctx)
/* Find the IRQ */
ctx->irq_num = platform_get_irq(pdev,
ctx->pdata->res_info->acpi_ipc_irq_index);
+   if (ctx->irq_num <= 0)
+   return -EIO;
+
return 0;
 }
 
-- 
2.7.4

[PATCH 2/5 v4] ASoC: mt8173: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq_id.

 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c 
b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 8a643a3..1153566 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe 
*afe)
 static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
 {
int ret, i;
-   unsigned int irq_id;
+   int irq_id;
struct mtk_base_afe *afe;
struct mt8173_afe_private *afe_priv;
struct resource *res;
@@ -1105,7 +1105,7 @@ static int mt8173_afe_pcm_dev_probe(struct 
platform_device *pdev)
afe->dev = >dev;
 
irq_id = platform_get_irq(pdev, 0);
-   if (!irq_id) {
+   if (irq_id <= 0) {
dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name);
return -ENXIO;
}
-- 
2.7.4

[PATCH 4/5 v3] ASoC: intel: sst: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
  Return EIO insted of ctx->irq_num.

 sound/soc/intel/atom/sst/sst_acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c 
b/sound/soc/intel/atom/sst/sst_acpi.c
index 32d6e02..5e46d06f 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -236,6 +236,9 @@ static int sst_platform_get_resources(struct intel_sst_drv 
*ctx)
/* Find the IRQ */
ctx->irq_num = platform_get_irq(pdev,
ctx->pdata->res_info->acpi_ipc_irq_index);
+   if (ctx->irq_num <= 0)
+   return -EIO;
+
return 0;
 }
 
-- 
2.7.4

[PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq.

 sound/soc/cirrus/ep93xx-ac97.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index bbf7a92..efeecee 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 {
struct ep93xx_ac97_info *info;
struct resource *res;
-   unsigned int irq;
+   int irq;
int ret;
 
info = devm_kzalloc(>dev, sizeof(*info), GFP_KERNEL);
@@ -378,7 +378,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
return PTR_ERR(info->regs);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
+   if (irq <= 0)
return -ENODEV;
 
ret = devm_request_irq(>dev, irq, ep93xx_ac97_interrupt,
-- 
2.7.4

[PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
  Return -ENODEV insted of irq.

 sound/soc/cirrus/ep93xx-ac97.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index bbf7a92..efeecee 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 {
struct ep93xx_ac97_info *info;
struct resource *res;
-   unsigned int irq;
+   int irq;
int ret;
 
info = devm_kzalloc(>dev, sizeof(*info), GFP_KERNEL);
@@ -378,7 +378,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
return PTR_ERR(info->regs);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
+   if (irq <= 0)
return -ENODEV;
 
ret = devm_request_irq(>dev, irq, ep93xx_ac97_interrupt,
-- 
2.7.4

[PATCH 06/10 v2] Input: w90p910_ts: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/touchscreen/w90p910_ts.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/input/touchscreen/w90p910_ts.c 
b/drivers/input/touchscreen/w90p910_ts.c
index 638c1d7..fa74f2c 100644
--- a/drivers/input/touchscreen/w90p910_ts.c
+++ b/drivers/input/touchscreen/w90p910_ts.c
@@ -277,6 +277,10 @@ static int w90x900ts_probe(struct platform_device *pdev)
input_set_drvdata(input_dev, w90p910_ts);
 
w90p910_ts->irq_num = platform_get_irq(pdev, 0);
+   if (w90p910_ts->irq_num <= 0) {
+   err = w90p910_ts->irq_num;
+   goto fail4;
+   }
if (request_irq(w90p910_ts->irq_num, w90p910_ts_interrupt,
0, "w90p910ts", w90p910_ts)) {
err = -EBUSY;
-- 
2.7.4

[PATCH 06/10 v2] Input: w90p910_ts: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/touchscreen/w90p910_ts.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/input/touchscreen/w90p910_ts.c 
b/drivers/input/touchscreen/w90p910_ts.c
index 638c1d7..fa74f2c 100644
--- a/drivers/input/touchscreen/w90p910_ts.c
+++ b/drivers/input/touchscreen/w90p910_ts.c
@@ -277,6 +277,10 @@ static int w90x900ts_probe(struct platform_device *pdev)
input_set_drvdata(input_dev, w90p910_ts);
 
w90p910_ts->irq_num = platform_get_irq(pdev, 0);
+   if (w90p910_ts->irq_num <= 0) {
+   err = w90p910_ts->irq_num;
+   goto fail4;
+   }
if (request_irq(w90p910_ts->irq_num, w90p910_ts_interrupt,
0, "w90p910ts", w90p910_ts)) {
err = -EBUSY;
-- 
2.7.4

[PATCH 10/10 v2] Input: palmas-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/palmas-pwrbutton.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/input/misc/palmas-pwrbutton.c 
b/drivers/input/misc/palmas-pwrbutton.c
index 1e1baed..f9b05cf 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -210,6 +210,11 @@ static int palmas_pwron_probe(struct platform_device *pdev)
INIT_DELAYED_WORK(>input_work, palmas_power_button_work);
 
pwron->irq = platform_get_irq(pdev, 0);
+   if (pwron->irq <= 0) {
+   error = pwron->irq;
+   goto err_free_input;
+   }
+
error = request_threaded_irq(pwron->irq, NULL, pwron_irq,
 IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW |
-- 
2.7.4

[PATCH 09/10 v2] Input: sirfsoc-onkey: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/sirfsoc-onkey.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/sirfsoc-onkey.c 
b/drivers/input/misc/sirfsoc-onkey.c
index 4fd038d..de04b48 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false);
 
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
+
error = devm_request_irq(>dev, irq,
 sirfsoc_pwrc_isr, 0,
 "sirfsoc_pwrc_int", pwrcdrv);
-- 
2.7.4

[PATCH 10/10 v2] Input: palmas-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/palmas-pwrbutton.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/input/misc/palmas-pwrbutton.c 
b/drivers/input/misc/palmas-pwrbutton.c
index 1e1baed..f9b05cf 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -210,6 +210,11 @@ static int palmas_pwron_probe(struct platform_device *pdev)
INIT_DELAYED_WORK(>input_work, palmas_power_button_work);
 
pwron->irq = platform_get_irq(pdev, 0);
+   if (pwron->irq <= 0) {
+   error = pwron->irq;
+   goto err_free_input;
+   }
+
error = request_threaded_irq(pwron->irq, NULL, pwron_irq,
 IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW |
-- 
2.7.4

[PATCH 09/10 v2] Input: sirfsoc-onkey: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/sirfsoc-onkey.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/sirfsoc-onkey.c 
b/drivers/input/misc/sirfsoc-onkey.c
index 4fd038d..de04b48 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false);
 
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
+
error = devm_request_irq(>dev, irq,
 sirfsoc_pwrc_isr, 0,
 "sirfsoc_pwrc_int", pwrcdrv);
-- 
2.7.4

[PATCH 04/10 v3] Input: serio: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  irq is unsigned. used struct sun4i_ps2data int variable 
drvdata->irq.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/serio/sun4i-ps2.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
index 04b96fe..38bb163 100644
--- a/drivers/input/serio/sun4i-ps2.c
+++ b/drivers/input/serio/sun4i-ps2.c
@@ -210,7 +210,6 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
struct sun4i_ps2data *drvdata;
struct serio *serio;
struct device *dev = >dev;
-   unsigned int irq;
int error;
 
drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL);
@@ -263,14 +262,13 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
writel(0, drvdata->reg_base + PS2_REG_GCTL);
 
/* Get IRQ for the device */
-   irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   drvdata->irq = platform_get_irq(pdev, 0);
+   if (drvdata->irq <= 0) {
dev_err(dev, "no IRQ found\n");
-   error = -ENXIO;
+   error = drvdata->irq;
goto err_disable_clk;
}
 
-   drvdata->irq = irq;
drvdata->serio = serio;
drvdata->dev = dev;
 
-- 
2.7.4

[PATCH 08/10 v3] Input: twl4030-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  return irq instead of -ENODEV.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/twl4030-pwrbutton.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/twl4030-pwrbutton.c 
b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca..0dcf311 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device 
*pdev)
int irq = platform_get_irq(pdev, 0);
int err;
 
+   if (irq <= 0)
+   return irq;
+
pwr = devm_input_allocate_device(>dev);
if (!pwr) {
dev_err(>dev, "Can't allocate power button\n");
-- 
2.7.4

[PATCH 03/10 v3] Input: twl4030_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  kp->irq is unsigned. use temporary int variable irq.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/twl4030_keypad.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/twl4030_keypad.c 
b/drivers/input/keyboard/twl4030_keypad.c
index f9f98ef..d921238 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -341,6 +341,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
struct input_dev *input;
u8 reg;
int error;
+   int irq;
 
kp = devm_kzalloc(>dev, sizeof(*kp), GFP_KERNEL);
if (!kp)
@@ -388,11 +389,12 @@ static int twl4030_kp_probe(struct platform_device *pdev)
return -EINVAL;
}
 
-   kp->irq = platform_get_irq(pdev, 0);
-   if (!kp->irq) {
+   irq = platform_get_irq(pdev, 0);
+   if (irq <= 0) {
dev_err(>dev, "no keyboard irq assigned\n");
-   return -EINVAL;
+   return irq;
}
+   kp->irq = irq;
 
error = matrix_keypad_build_keymap(keymap_data, NULL,
   TWL4030_MAX_ROWS,
-- 
2.7.4

[PATCH 05/10 v3] Input: cpcap-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  return irq instead of -ENODEV.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/cpcap-pwrbutton.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/cpcap-pwrbutton.c 
b/drivers/input/misc/cpcap-pwrbutton.c
index 0abef63..3a0626b 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -57,6 +57,9 @@ static int cpcap_power_button_probe(struct platform_device 
*pdev)
int irq = platform_get_irq(pdev, 0);
int err;
 
+   if (irq <= 0)
+   return irq;
+
button = devm_kmalloc(>dev, sizeof(*button), GFP_KERNEL);
if (!button)
return -ENOMEM;
-- 
2.7.4

[PATCH 07/10 v3] Input: sun4i-ts: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  ts->irq is unsigned. used int irq variable.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/touchscreen/sun4i-ts.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/sun4i-ts.c 
b/drivers/input/touchscreen/sun4i-ts.c
index d2e14d9..315f26b 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -251,6 +251,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
bool ts_attached;
u32 tp_sensitive_adjust = 15;
u32 filter_type = 1;
+   int irq;
 
ts = devm_kzalloc(dev, sizeof(struct sun4i_ts_data), GFP_KERNEL);
if (!ts)
@@ -314,7 +315,10 @@ static int sun4i_ts_probe(struct platform_device *pdev)
if (IS_ERR(ts->base))
return PTR_ERR(ts->base);
 
-   ts->irq = platform_get_irq(pdev, 0);
+   irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
+   ts->irq = irq;
error = devm_request_irq(dev, ts->irq, sun4i_ts_irq, 0, "sun4i-ts", ts);
if (error)
return error;
-- 
2.7.4

[PATCH 02/10 v3] Input: omap4-keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
   Return irq insted of -EINVAL.
changes in v3 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/omap4-keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c 
b/drivers/input/keyboard/omap4-keypad.c
index 940d38b..9ad840c 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -251,9 +251,9 @@ static int omap4_keypad_probe(struct platform_device *pdev)
}
 
irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   if (irq <= 0) {
dev_err(>dev, "no keyboard irq assigned\n");
-   return -EINVAL;
+   return irq;
}
 
keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL);
-- 
2.7.4

[PATCH 04/10 v3] Input: serio: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  irq is unsigned. used struct sun4i_ps2data int variable 
drvdata->irq.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/serio/sun4i-ps2.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
index 04b96fe..38bb163 100644
--- a/drivers/input/serio/sun4i-ps2.c
+++ b/drivers/input/serio/sun4i-ps2.c
@@ -210,7 +210,6 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
struct sun4i_ps2data *drvdata;
struct serio *serio;
struct device *dev = >dev;
-   unsigned int irq;
int error;
 
drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL);
@@ -263,14 +262,13 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
writel(0, drvdata->reg_base + PS2_REG_GCTL);
 
/* Get IRQ for the device */
-   irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   drvdata->irq = platform_get_irq(pdev, 0);
+   if (drvdata->irq <= 0) {
dev_err(dev, "no IRQ found\n");
-   error = -ENXIO;
+   error = drvdata->irq;
goto err_disable_clk;
}
 
-   drvdata->irq = irq;
drvdata->serio = serio;
drvdata->dev = dev;
 
-- 
2.7.4

[PATCH 08/10 v3] Input: twl4030-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  return irq instead of -ENODEV.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/twl4030-pwrbutton.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/twl4030-pwrbutton.c 
b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca..0dcf311 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device 
*pdev)
int irq = platform_get_irq(pdev, 0);
int err;
 
+   if (irq <= 0)
+   return irq;
+
pwr = devm_input_allocate_device(>dev);
if (!pwr) {
dev_err(>dev, "Can't allocate power button\n");
-- 
2.7.4

[PATCH 03/10 v3] Input: twl4030_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  kp->irq is unsigned. use temporary int variable irq.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/twl4030_keypad.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/twl4030_keypad.c 
b/drivers/input/keyboard/twl4030_keypad.c
index f9f98ef..d921238 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -341,6 +341,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
struct input_dev *input;
u8 reg;
int error;
+   int irq;
 
kp = devm_kzalloc(>dev, sizeof(*kp), GFP_KERNEL);
if (!kp)
@@ -388,11 +389,12 @@ static int twl4030_kp_probe(struct platform_device *pdev)
return -EINVAL;
}
 
-   kp->irq = platform_get_irq(pdev, 0);
-   if (!kp->irq) {
+   irq = platform_get_irq(pdev, 0);
+   if (irq <= 0) {
dev_err(>dev, "no keyboard irq assigned\n");
-   return -EINVAL;
+   return irq;
}
+   kp->irq = irq;
 
error = matrix_keypad_build_keymap(keymap_data, NULL,
   TWL4030_MAX_ROWS,
-- 
2.7.4

[PATCH 05/10 v3] Input: cpcap-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  return irq instead of -ENODEV.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/cpcap-pwrbutton.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/cpcap-pwrbutton.c 
b/drivers/input/misc/cpcap-pwrbutton.c
index 0abef63..3a0626b 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -57,6 +57,9 @@ static int cpcap_power_button_probe(struct platform_device 
*pdev)
int irq = platform_get_irq(pdev, 0);
int err;
 
+   if (irq <= 0)
+   return irq;
+
button = devm_kmalloc(>dev, sizeof(*button), GFP_KERNEL);
if (!button)
return -ENOMEM;
-- 
2.7.4

[PATCH 07/10 v3] Input: sun4i-ts: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  ts->irq is unsigned. used int irq variable.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/touchscreen/sun4i-ts.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/sun4i-ts.c 
b/drivers/input/touchscreen/sun4i-ts.c
index d2e14d9..315f26b 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -251,6 +251,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
bool ts_attached;
u32 tp_sensitive_adjust = 15;
u32 filter_type = 1;
+   int irq;
 
ts = devm_kzalloc(dev, sizeof(struct sun4i_ts_data), GFP_KERNEL);
if (!ts)
@@ -314,7 +315,10 @@ static int sun4i_ts_probe(struct platform_device *pdev)
if (IS_ERR(ts->base))
return PTR_ERR(ts->base);
 
-   ts->irq = platform_get_irq(pdev, 0);
+   irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
+   ts->irq = irq;
error = devm_request_irq(dev, ts->irq, sun4i_ts_irq, 0, "sun4i-ts", ts);
if (error)
return error;
-- 
2.7.4

[PATCH 02/10 v3] Input: omap4-keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2:
   Return irq insted of -EINVAL.
changes in v3 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/omap4-keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c 
b/drivers/input/keyboard/omap4-keypad.c
index 940d38b..9ad840c 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -251,9 +251,9 @@ static int omap4_keypad_probe(struct platform_device *pdev)
}
 
irq = platform_get_irq(pdev, 0);
-   if (!irq) {
+   if (irq <= 0) {
dev_err(>dev, "no keyboard irq assigned\n");
-   return -EINVAL;
+   return irq;
}
 
keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL);
-- 
2.7.4

[PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
   Return keypad->irq insted of -ENXIO.
changes in v3 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..01788a7 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
-   err = -ENXIO;
+   if (keypad->irq <= 0) {
+   err = keypad->irq;
goto failed_free;
}
 
-- 
2.7.4

[PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2:
   Return keypad->irq insted of -ENXIO.
changes in v3 :
   Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c 
b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..01788a7 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
 
keypad->irq = platform_get_irq(pdev, 0);
-   if (!keypad->irq) {
-   err = -ENXIO;
+   if (keypad->irq <= 0) {
+   err = keypad->irq;
goto failed_free;
}
 
-- 
2.7.4

[PATCH 2/3 v3] ASoC: mt8173: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c 
b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 8a643a3..11f5f2a 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe 
*afe)
 static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
 {
int ret, i;
-   unsigned int irq_id;
+   int irq_id;
struct mtk_base_afe *afe;
struct mt8173_afe_private *afe_priv;
struct resource *res;
@@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct 
platform_device *pdev)
afe->dev = >dev;
 
irq_id = platform_get_irq(pdev, 0);
-   if (!irq_id) {
+   if (irq_id <= 0) {
dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name);
-   return -ENXIO;
+   return irq_id;
}
ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
   0, "Afe_ISR_Handle", (void *)afe);
-- 
2.7.4

[PATCH 4/5 v2] ASoC: intel: sst: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/intel/atom/sst/sst_acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c 
b/sound/soc/intel/atom/sst/sst_acpi.c
index 32d6e02..693b970 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -236,6 +236,9 @@ static int sst_platform_get_resources(struct intel_sst_drv 
*ctx)
/* Find the IRQ */
ctx->irq_num = platform_get_irq(pdev,
ctx->pdata->res_info->acpi_ipc_irq_index);
+   if (ctx->irq_num <= 0)
+   return ctx->irq_num;
+
return 0;
 }
 
-- 
2.7.4

[PATCH 3/3 v3] ASoC: nuc900: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so using signed variable ret.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/nuc900/nuc900-ac97.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index b6615af..71fce7c 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -345,11 +345,10 @@ static int nuc900_ac97_drvprobe(struct platform_device 
*pdev)
goto out;
}
 
-   nuc900_audio->irq_num = platform_get_irq(pdev, 0);
-   if (!nuc900_audio->irq_num) {
-   ret = -EBUSY;
+   ret = platform_get_irq(pdev, 0);
+   if (ret <= 0)
goto out;
-   }
+   nuc900_audio->irq_num = ret;
 
nuc900_ac97_data = nuc900_audio;
 
-- 
2.7.4

[PATCH 2/3 v3] ASoC: mt8173: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c 
b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 8a643a3..11f5f2a 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe 
*afe)
 static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
 {
int ret, i;
-   unsigned int irq_id;
+   int irq_id;
struct mtk_base_afe *afe;
struct mt8173_afe_private *afe_priv;
struct resource *res;
@@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct 
platform_device *pdev)
afe->dev = >dev;
 
irq_id = platform_get_irq(pdev, 0);
-   if (!irq_id) {
+   if (irq_id <= 0) {
dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name);
-   return -ENXIO;
+   return irq_id;
}
ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
   0, "Afe_ISR_Handle", (void *)afe);
-- 
2.7.4

[PATCH 4/5 v2] ASoC: intel: sst: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/intel/atom/sst/sst_acpi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c 
b/sound/soc/intel/atom/sst/sst_acpi.c
index 32d6e02..693b970 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -236,6 +236,9 @@ static int sst_platform_get_resources(struct intel_sst_drv 
*ctx)
/* Find the IRQ */
ctx->irq_num = platform_get_irq(pdev,
ctx->pdata->res_info->acpi_ipc_irq_index);
+   if (ctx->irq_num <= 0)
+   return ctx->irq_num;
+
return 0;
 }
 
-- 
2.7.4

[PATCH 3/3 v3] ASoC: nuc900: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so using signed variable ret.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/nuc900/nuc900-ac97.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index b6615af..71fce7c 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -345,11 +345,10 @@ static int nuc900_ac97_drvprobe(struct platform_device 
*pdev)
goto out;
}
 
-   nuc900_audio->irq_num = platform_get_irq(pdev, 0);
-   if (!nuc900_audio->irq_num) {
-   ret = -EBUSY;
+   ret = platform_get_irq(pdev, 0);
+   if (ret <= 0)
goto out;
-   }
+   nuc900_audio->irq_num = ret;
 
nuc900_ac97_data = nuc900_audio;
 
-- 
2.7.4

[PATCH 5/5 v2] ASoC: intel: mfld: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/intel/boards/mfld_machine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/boards/mfld_machine.c 
b/sound/soc/intel/boards/mfld_machine.c
index 6f44acf..77b3162 100644
--- a/sound/soc/intel/boards/mfld_machine.c
+++ b/sound/soc/intel/boards/mfld_machine.c
@@ -372,6 +372,8 @@ static int snd_mfld_mc_probe(struct platform_device *pdev)
 
/* retrive the irq number */
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
 
/* audio interrupt base of SRAM location where
 * interrupts are stored by System FW */
-- 
2.7.4

[PATCH 5/5 v2] ASoC: intel: mfld: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/intel/boards/mfld_machine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/boards/mfld_machine.c 
b/sound/soc/intel/boards/mfld_machine.c
index 6f44acf..77b3162 100644
--- a/sound/soc/intel/boards/mfld_machine.c
+++ b/sound/soc/intel/boards/mfld_machine.c
@@ -372,6 +372,8 @@ static int snd_mfld_mc_probe(struct platform_device *pdev)
 
/* retrive the irq number */
irq = platform_get_irq(pdev, 0);
+   if (irq <= 0)
+   return irq;
 
/* audio interrupt base of SRAM location where
 * interrupts are stored by System FW */
-- 
2.7.4

[PATCH 1/3 v3] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/cirrus/ep93xx-ac97.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index bbf7a92..b86b83b 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 {
struct ep93xx_ac97_info *info;
struct resource *res;
-   unsigned int irq;
+   int irq;
int ret;
 
info = devm_kzalloc(>dev, sizeof(*info), GFP_KERNEL);
@@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
return PTR_ERR(info->regs);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
-   return -ENODEV;
+   if (irq <= 0)
+   return irq;
 
ret = devm_request_irq(>dev, irq, ep93xx_ac97_interrupt,
   IRQF_TRIGGER_HIGH, pdev->name, info);
-- 
2.7.4

[PATCH 1/3 v3] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
   irq was unsigned. so changed it to signed.
changes in v3 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 sound/soc/cirrus/ep93xx-ac97.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index bbf7a92..b86b83b 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 {
struct ep93xx_ac97_info *info;
struct resource *res;
-   unsigned int irq;
+   int irq;
int ret;
 
info = devm_kzalloc(>dev, sizeof(*info), GFP_KERNEL);
@@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
return PTR_ERR(info->regs);
 
irq = platform_get_irq(pdev, 0);
-   if (!irq)
-   return -ENODEV;
+   if (irq <= 0)
+   return irq;
 
ret = devm_request_irq(>dev, irq, ep93xx_ac97_interrupt,
   IRQF_TRIGGER_HIGH, pdev->name, info);
-- 
2.7.4

[PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/sdhci-spear.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
sdhci = sdhci_priv(host);
-- 
2.7.4

[PATCH 5/6 v2] mmc: sh_mmcif: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/sh_mmcif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 53fb18b..481f2c4 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
 
irq[0] = platform_get_irq(pdev, 0);
irq[1] = platform_get_irq(pdev, 1);
-   if (irq[0] < 0) {
+   if (irq[0] <= 0 || irq[1] <= 0) {
dev_err(dev, "Get irq error\n");
return -ENXIO;
}
-- 
2.7.4

[PATCH 6/6 v2] mmc: sunxi-mmc: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/sunxi-mmc.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index cc98355d..ec2a16b 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct 
sunxi_mmc_host *host,
goto error_assert_reset;
 
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = host->irq;
+   goto error_assert_reset;
+   }
+
return devm_request_threaded_irq(>dev, host->irq, sunxi_mmc_irq,
sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
 
-- 
2.7.4

[PATCH 3/6 v2] mmc: sdhci-acpi: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/sdhci-acpi.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index b988997..dd8129e 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
host->hw_name   = "ACPI";
host->ops   = _acpi_ops_dflt;
host->irq   = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   err = host->irq;
+   goto err_free;
+   }
 
host->ioaddr = devm_ioremap_nocache(dev, iomem->start,
resource_size(iomem));
-- 
2.7.4

[PATCH 2/6 v2] mmc: s3cmci: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/s3cmci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index f7f157a..cc801bc 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1658,9 +1658,9 @@ static int s3cmci_probe(struct platform_device *pdev)
}
 
host->irq = platform_get_irq(pdev, 0);
-   if (host->irq == 0) {
+   if (host->irq <= 0) {
dev_err(>dev, "failed to get interrupt resource.\n");
-   ret = -EINVAL;
+   ret = host->irq;
goto probe_iounmap;
}
 
-- 
2.7.4

[PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/mmc/host/sdhci-spear.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = _pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+   if (host->irq <= 0) {
+   ret = host->irq;
+   goto err_host;
+   }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
 
sdhci = sdhci_priv(host);
-- 
2.7.4

< 1 2 3 4 5 6 7 8 9 10 >

301 - 400 of 3336 matches

Mail list logo