Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 08:07:15PM -0700, Anton Vorontsov wrote: > These changes not so much burden for me personally (it was actually easier > for me to just apply the patch without all the arguing), but for those who > actually do real bugfixes/features in the drivers: their local development > trees will produce conflicts. Solving the trivial conflicts not a problem > either, but irritating (especially realizing that you waste time resolving > conflicts because of the "just cosmetic" crap). > These days I don't code that much, but I was in that boat resolving > "cosmetic" conflicts, and I did not like it. So I'm trying to solve the > issue for drivers/power/ developers. This sort of patche can be helpful when doing work over multiple drivers - making the code more consistent means that it's much easier to pattern match when looking over many different drivers. signature.asc Description: Digital signature
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 08:07:15PM -0700, Anton Vorontsov wrote: These changes not so much burden for me personally (it was actually easier for me to just apply the patch without all the arguing), but for those who actually do real bugfixes/features in the drivers: their local development trees will produce conflicts. Solving the trivial conflicts not a problem either, but irritating (especially realizing that you waste time resolving conflicts because of the just cosmetic crap). These days I don't code that much, but I was in that boat resolving cosmetic conflicts, and I did not like it. So I'm trying to solve the issue for drivers/power/ developers. This sort of patche can be helpful when doing work over multiple drivers - making the code more consistent means that it's much easier to pattern match when looking over many different drivers. signature.asc Description: Digital signature
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 07:07:14PM -0700, 'Greg Kroah-Hartman' wrote: > On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: > > On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > > > He doesn't want to take the patch. He's the maintainer so it's his > > > choice. That's the end of the story. > > > > Just to clarify: I don't want to take the patch for a reason, not just > > because of my mood today. Once the patch comes in combination with another > > patch (or a plan) that actually makes use of the wrapper function, then > > I'd happily apply/ack it. > > > > This is the same story as global checkpatch.pl fixes: they are more harm > > than good, and without the actual use of the dev_get_platdata(), the patch > > falls into "global checkpatch.pl fixes" category. > > If you view this as a checkpatch.pl fixup As a standalone patch I view it as a checkpatch.pl fixup. Even the author of the patch seem to agree: | On Thu, Aug 29, 2013 at 11:14:37AM +0900, Jingoo Han wrote: | > This patch is a just cosmetic change. And indeed I am against massive "just cosmetic" changes. These changes not so much burden for me personally (it was actually easier for me to just apply the patch without all the arguing), but for those who actually do real bugfixes/features in the drivers: their local development trees will produce conflicts. Solving the trivial conflicts not a problem either, but irritating (especially realizing that you waste time resolving conflicts because of the "just cosmetic" crap). These days I don't code that much, but I was in that boat resolving "cosmetic" conflicts, and I did not like it. So I'm trying to solve the issue for drivers/power/ developers. Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Thursday, August 29, 2013 11:07 AM, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: > > On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > > > He doesn't want to take the patch. He's the maintainer so it's his > > > choice. That's the end of the story. > > > > Just to clarify: I don't want to take the patch for a reason, not just > > because of my mood today. Once the patch comes in combination with another > > patch (or a plan) that actually makes use of the wrapper function, then > > I'd happily apply/ack it. > > > > This is the same story as global checkpatch.pl fixes: they are more harm > > than good, and without the actual use of the dev_get_platdata(), the patch > > falls into "global checkpatch.pl fixes" category. > > If you view this as a checkpatch.pl fixup, I'll be glad to take it > through my tree instead, to ease the patch burden on you :) Hi Greg, I agree with you. Thank you for your suggestion. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Thursday, August 29, 2013 10:19 AM, Anton Vorontsov wrote: > On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > > He doesn't want to take the patch. He's the maintainer so it's his > > choice. That's the end of the story. > > Just to clarify: I don't want to take the patch for a reason, not just > because of my mood today. Once the patch comes in combination with another > patch (or a plan) that actually makes use of the wrapper function, then > I'd happily apply/ack it. Sorry, I cannot understand. This patch is a just cosmetic change. I cannot understand why you reject it. > > This is the same story as global checkpatch.pl fixes: they are more harm > than good, and without the actual use of the dev_get_platdata(), the patch > falls into "global checkpatch.pl fixes" category. So, what is the harm of the fix using dev_get_platdata() wrapper function? What is "the actual use of the dev_get_platdata()"? Please, give me more detailed description. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: > On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > > He doesn't want to take the patch. He's the maintainer so it's his > > choice. That's the end of the story. > > Just to clarify: I don't want to take the patch for a reason, not just > because of my mood today. Once the patch comes in combination with another > patch (or a plan) that actually makes use of the wrapper function, then > I'd happily apply/ack it. > > This is the same story as global checkpatch.pl fixes: they are more harm > than good, and without the actual use of the dev_get_platdata(), the patch > falls into "global checkpatch.pl fixes" category. If you view this as a checkpatch.pl fixup, I'll be glad to take it through my tree instead, to ease the patch burden on you :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: > He doesn't want to take the patch. He's the maintainer so it's his > choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into "global checkpatch.pl fixes" category. Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wednesday, August 28, 2013 5:37 PM, Dan Carpenter wrote: > > He doesn't want to take the patch. He's the maintainer so it's his > choice. That's the end of the story. > I know that the maintainer's choice is important, because I am also a maintainer of other system or drivers. But, there is no reasonable reason to object my patch. I sent all 35 patches that use dev_get_platdata(). 21 patches of 35 patches have been merged by each maintainer. The maintainers admitted that these patches make the code simpler and enhance the readability, even though these are cosmetic changes. Also, until now, there is no objection. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wednesday, August 28, 2013 5:37 PM, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. I know that the maintainer's choice is important, because I am also a maintainer of other system or drivers. But, there is no reasonable reason to object my patch. I sent all 35 patches that use dev_get_platdata(). 21 patches of 35 patches have been merged by each maintainer. The maintainers admitted that these patches make the code simpler and enhance the readability, even though these are cosmetic changes. Also, until now, there is no objection. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into global checkpatch.pl fixes category. Thanks, Anton -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into global checkpatch.pl fixes category. If you view this as a checkpatch.pl fixup, I'll be glad to take it through my tree instead, to ease the patch burden on you :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Thursday, August 29, 2013 10:19 AM, Anton Vorontsov wrote: On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. Sorry, I cannot understand. This patch is a just cosmetic change. I cannot understand why you reject it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into global checkpatch.pl fixes category. So, what is the harm of the fix using dev_get_platdata() wrapper function? What is the actual use of the dev_get_platdata()? Please, give me more detailed description. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Thursday, August 29, 2013 11:07 AM, Greg Kroah-Hartman wrote: On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into global checkpatch.pl fixes category. If you view this as a checkpatch.pl fixup, I'll be glad to take it through my tree instead, to ease the patch burden on you :) Hi Greg, I agree with you. Thank you for your suggestion. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wed, Aug 28, 2013 at 07:07:14PM -0700, 'Greg Kroah-Hartman' wrote: On Wed, Aug 28, 2013 at 06:18:49PM -0700, Anton Vorontsov wrote: On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote: He doesn't want to take the patch. He's the maintainer so it's his choice. That's the end of the story. Just to clarify: I don't want to take the patch for a reason, not just because of my mood today. Once the patch comes in combination with another patch (or a plan) that actually makes use of the wrapper function, then I'd happily apply/ack it. This is the same story as global checkpatch.pl fixes: they are more harm than good, and without the actual use of the dev_get_platdata(), the patch falls into global checkpatch.pl fixes category. If you view this as a checkpatch.pl fixup As a standalone patch I view it as a checkpatch.pl fixup. Even the author of the patch seem to agree: | On Thu, Aug 29, 2013 at 11:14:37AM +0900, Jingoo Han wrote: | This patch is a just cosmetic change. And indeed I am against massive just cosmetic changes. These changes not so much burden for me personally (it was actually easier for me to just apply the patch without all the arguing), but for those who actually do real bugfixes/features in the drivers: their local development trees will produce conflicts. Solving the trivial conflicts not a problem either, but irritating (especially realizing that you waste time resolving conflicts because of the just cosmetic crap). These days I don't code that much, but I was in that boat resolving cosmetic conflicts, and I did not like it. So I'm trying to solve the issue for drivers/power/ developers. Thanks, Anton -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wednesday, August 28, 2013 10:59 AM, Anton Vorontsov wrote: > On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote: > > > > > Use the wrapper function for retrieving the platform data instead of > > > > > accessing dev->platform_data directly. > > > > > > > > Um.. what is the benefit or rationale of this patch? > > > > > > CC'ed Joe Perches, Dan Carpenter > > > > > > Hi Anton Vorontsov, > > > > > > Usually, using the wrapper function makes the code simpler. > > > Also, it make the code more readable. > > > > Since people are asking my opinion, then yes using > > dev_get_platdata() as intended is better than open coding. It's a > > coding standard thing. > > I don't see any immediate benefit of applying this patch... It does not > fix anything now or in the near future (or we are about to add something > into dev_get_platdata() wrapper, or get rid of dev.platform_data member? > Any plans for this? Then it should be in the commit message.) CC'ed Greg Kroah-Hartman, Andrew Morton, Mark Brown The benefit is that this wrapper function makes the code simpler and enhances readability. I don't know why you disagree. :( Also, this is a cosmetic change which does not have harmful effect. There is no special plan. I just want to make the best use of this wrapper function in order to enhance readability and make the code simpler. > > Without any plans to actually use the wrapper the patch is just a churn > [that might result into patch conflicts that I'll have to deal with], so > I'll refrain from applying it. Um, if you want, I will send v2 patch re-based on the latest git tree. Please, consider this patch positively. :-) Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote: > > > > Use the wrapper function for retrieving the platform data instead of > > > > accessing dev->platform_data directly. > > > > > > Um.. what is the benefit or rationale of this patch? > > > > CC'ed Joe Perches, Dan Carpenter > > > > Hi Anton Vorontsov, > > > > Usually, using the wrapper function makes the code simpler. > > Also, it make the code more readable. > > Since people are asking my opinion, then yes using > dev_get_platdata() as intended is better than open coding. It's a > coding standard thing. I don't see any immediate benefit of applying this patch... It does not fix anything now or in the near future (or we are about to add something into dev_get_platdata() wrapper, or get rid of dev.platform_data member? Any plans for this? Then it should be in the commit message.) Without any plans to actually use the wrapper the patch is just a churn [that might result into patch conflicts that I'll have to deal with], so I'll refrain from applying it. Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Um.. what is the benefit or rationale of this patch? CC'ed Joe Perches, Dan Carpenter Hi Anton Vorontsov, Usually, using the wrapper function makes the code simpler. Also, it make the code more readable. Since people are asking my opinion, then yes using dev_get_platdata() as intended is better than open coding. It's a coding standard thing. I don't see any immediate benefit of applying this patch... It does not fix anything now or in the near future (or we are about to add something into dev_get_platdata() wrapper, or get rid of dev.platform_data member? Any plans for this? Then it should be in the commit message.) Without any plans to actually use the wrapper the patch is just a churn [that might result into patch conflicts that I'll have to deal with], so I'll refrain from applying it. Thanks, Anton -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Wednesday, August 28, 2013 10:59 AM, Anton Vorontsov wrote: On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Um.. what is the benefit or rationale of this patch? CC'ed Joe Perches, Dan Carpenter Hi Anton Vorontsov, Usually, using the wrapper function makes the code simpler. Also, it make the code more readable. Since people are asking my opinion, then yes using dev_get_platdata() as intended is better than open coding. It's a coding standard thing. I don't see any immediate benefit of applying this patch... It does not fix anything now or in the near future (or we are about to add something into dev_get_platdata() wrapper, or get rid of dev.platform_data member? Any plans for this? Then it should be in the commit message.) CC'ed Greg Kroah-Hartman, Andrew Morton, Mark Brown The benefit is that this wrapper function makes the code simpler and enhances readability. I don't know why you disagree. :( Also, this is a cosmetic change which does not have harmful effect. There is no special plan. I just want to make the best use of this wrapper function in order to enhance readability and make the code simpler. Without any plans to actually use the wrapper the patch is just a churn [that might result into patch conflicts that I'll have to deal with], so I'll refrain from applying it. Um, if you want, I will send v2 patch re-based on the latest git tree. Please, consider this patch positively. :-) Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Mon, Aug 12, 2013 at 09:22:42AM +0900, Jingoo Han wrote: > On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote: > > On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: > > > Use the wrapper function for retrieving the platform data instead of > > > accessing dev->platform_data directly. > > > > Um.. what is the benefit or rationale of this patch? > > CC'ed Joe Perches, Dan Carpenter > > Hi Anton Vorontsov, > > Usually, using the wrapper function makes the code simpler. > Also, it make the code more readable. Since people are asking my opinion, then yes using dev_get_platdata() as intended is better than open coding. It's a coding standard thing. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Mon, Aug 12, 2013 at 09:22:42AM +0900, Jingoo Han wrote: On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote: On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Um.. what is the benefit or rationale of this patch? CC'ed Joe Perches, Dan Carpenter Hi Anton Vorontsov, Usually, using the wrapper function makes the code simpler. Also, it make the code more readable. Since people are asking my opinion, then yes using dev_get_platdata() as intended is better than open coding. It's a coding standard thing. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote: > On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: > > Use the wrapper function for retrieving the platform data instead of > > accessing dev->platform_data directly. > > Um.. what is the benefit or rationale of this patch? CC'ed Joe Perches, Dan Carpenter Hi Anton Vorontsov, Usually, using the wrapper function makes the code simpler. Also, it make the code more readable. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote: On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Um.. what is the benefit or rationale of this patch? CC'ed Joe Perches, Dan Carpenter Hi Anton Vorontsov, Usually, using the wrapper function makes the code simpler. Also, it make the code more readable. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: > Use the wrapper function for retrieving the platform data instead of > accessing dev->platform_data directly. Um.. what is the benefit or rationale of this patch? Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 33/35] power: use dev_get_platdata()
On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Um.. what is the benefit or rationale of this patch? Thanks, Anton -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
