Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
All, Please reply to [EMAIL PROTECTED] rather than this email account. Regards, Dave Jeff Garzik wrote: [EMAIL PROTECTED]">Andi Kleen wrote: de4x5 is stable, but tends to perform badly under load, mostly becauseit doesn't use rx_copybreak and overflows standard socket buffers with itsalways MTU sized skbuffs. One of the reasons that de4x5 isn't gone already is that I get reportsthat de4x5 performs better than the tulip driver for their card. Jeff
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
All, As you can see, I get little time to attend to maintenance chores on the de4x5 driver. If there are particular problems that you want sorted out please let me know and I'll see what I can do. Regards, Dave -- Jeff Garzik wrote: > Andi Kleen wrote: > >> de4x5 is stable, but tends to perform badly under load, mostly because >> it doesn't use rx_copybreak and overflows standard socket buffers with its >> always MTU sized skbuffs. > > > One of the reasons that de4x5 isn't gone already is that I get reports > that de4x5 performs better than the tulip driver for their card. > > Jeff > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
In message <[EMAIL PROTECTED]> you write: > > 12. Probably Post 2.4 > > > * module remove race bugs (ipchains modules -- Rusty; won't fix for > >2.4) > > Is this an ipchains bug, or a more general module subsystem bug? There's a fundamental problem with any module which reduces counts in interrupts. Viro's `solution' doesn't apply here; there is a real solution but I Believed In The Code Freeze. Rusty. -- Hacking time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, Nov 12, 2000 at 10:09:39PM -0500, Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: > > 4. Boot Time Failures > > > * Various Alpha's don't boot under 2.4.0-test9 (PCI-PCI bridges are > >not configured correctly Michal Jaegermann; Richard Henderson may > >have an idea what's failing.) > > Move to patch-exists-but-not-merged. rth has patches, co-developed with > Ivan Kokshaysky Would be nice, wouldn't it. Unfortunately this is not the case. rth has patches which help to boot his machine, and few others, but this still does not work in general. Ivan works now pretty hard, with my involvment into this, trying to identify and fix the problem. Michal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Mon, Nov 13, 2000 at 11:58:00PM +0100, Roger Larsson wrote: > On Sunday 12 November 2000 23:31, Erik Mouw wrote: > > I can still hang the system with XMMS (1.0.1) using real-time priority. > > The system doesn't die, but it is completely unresponsive. There is no > > sound, but after the MP3 file is played, the system works again. I can > > reproduce this behaviour with usb-uhci and uhci-alt on 2.4.0-test10. > > I haven't test test11-pre3 yet, but the changes don't look too big that > > the "bug" has been fixed. > > Does it use non blocking IO? > In such case you might have created an infinite loop at high priority > resulting in a busylock of all other processes. Possible, I didn't look at the source. It would explain the behaviour, but why isn't there any sound? Erik -- J.A.K. (Erik) Mouw, Information and Communication Theory Group, Department of Electrical Engineering, Faculty of Information Technology and Systems, Delft University of Technology, PO BOX 5031, 2600 GA Delft, The Netherlands Phone: +31-15-2783635 Fax: +31-15-2781843 Email: [EMAIL PROTECTED] WWW: http://www-ict.its.tudelft.nl/~erik/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sunday 12 November 2000 23:31, Erik Mouw wrote:
> On Sun, Nov 12, 2000 at 02:39:09PM -0500, [EMAIL PROTECTED] wrote:
> > * USB: system hang with USB audio driver {CRITICAL} (David
> >Woodhouse, Randy Dunlap, Narayan Desai) (Fixed with usb-uhci;
> >uhci-alt is unknown -- randy dunlap)
>
> I can still hang the system with XMMS (1.0.1) using real-time priority.
> The system doesn't die, but it is completely unresponsive. There is no
> sound, but after the MP3 file is played, the system works again. I can
> reproduce this behaviour with usb-uhci and uhci-alt on 2.4.0-test10.
> I haven't test test11-pre3 yet, but the changes don't look too big that
> the "bug" has been fixed.
>
Does it use non blocking IO?
In such case you might have created an infinite loop at high priority
resulting in a busylock of all other processes.
> BTW, I don't think this is a critical bug.
>
>
> Erik
--
Home page:
http://www.norran.net/nra02596/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, Nov 12, 2000 at 02:39:09PM -0500, [EMAIL PROTECTED] wrote: > Fixed > > * Zip/Imm/Parport will reliably hang the system (James M. "Dart", >fixed) This isn't fixed, I'm pretty sure. I haven't looked at it yet. Tim. */ PGP signature
Re: Linux 2.4 Status/TODO page (test11-pre3)
> >8. Fix Exists But Isnt Merged
> > * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
> > (Keith Owens)
>
> Fix (by whom?)
Me :-)
> included in 2.4.0-test11-pre3. Looks good.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
Figures. I'll be quick to blame esd, it does pretty much all writes blind. -d Matti Aarnio wrote: > On Sun, Nov 12, 2000 at 07:26:37PM -0800, David Ford wrote: > > [EMAIL PROTECTED] wrote: > > > Fixed > > > * Incredibly slow loopback tcp bug (believed fixed about 2.3.48) > > > > Note; if I set up ESD to listen on a tcp port, connecting locally sounds > > horrible. I haven't looked to see who's fault it really is. > > FTP-transfer of large file over loopback gives me about 80 MB/sec > speeds at 2.4.0-test8 -- nor is the ESD bad sounding. > > However my Alpha has the SB support very bad sounding.. > It sounds like spectrum reversal, in fact -- first noticed > when playing stereophonic MP3 with xmms, but when same file > was played to .WAV file at an intel box (where it sounds quite > ok), and that wav is play(1)ed at the alpha -- same bad sound. > > > -d > > /Matti Aarnio -- ---NOTICE -- fwd: fwd: fwd: type emails will be deleted automatically. "There is a natural aristocracy among men. The grounds of this are virtue and talents", Thomas Jefferson [1742-1826], 3rd US President - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, Nov 12, 2000 at 07:26:37PM -0800, David Ford wrote: > [EMAIL PROTECTED] wrote: > > Fixed > > * Incredibly slow loopback tcp bug (believed fixed about 2.3.48) > > Note; if I set up ESD to listen on a tcp port, connecting locally sounds > horrible. I haven't looked to see who's fault it really is. FTP-transfer of large file over loopback gives me about 80 MB/sec speeds at 2.4.0-test8 -- nor is the ESD bad sounding. However my Alpha has the SB support very bad sounding.. It sounds like spectrum reversal, in fact -- first noticed when playing stereophonic MP3 with xmms, but when same file was played to .WAV file at an intel box (where it sounds quite ok), and that wav is play(1)ed at the alpha -- same bad sound. > -d /Matti Aarnio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, Nov 12, 2000 at 02:39:09PM -0500, [EMAIL PROTECTED] wrote:
> * USB: fix setting urb->dev in printer, acm, bluetooth, all serial
>drivers (Greg KH) {CRITICAL} (test10-pre1)
Confirmed, this is in the latest version and is fixed.
thanks,
greg k-h
--
greg@(kroah|wirex).com
http://immunix.org/~greg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
Jeff Garzik wrote: > > * 2.4.0-test10 pcmcia fails to detect IRQ's correctly, and will > >sometimes kill all software interrupts on card insertion on a NEC > >Versa LX (David Ford) > > Still does this with test11-pre-latest? I'll test this tomorrow, I can't interrupt my laptop for the evening. -d -- ---NOTICE -- fwd: fwd: fwd: type emails will be deleted automatically. "There is a natural aristocracy among men. The grounds of this are virtue and talents", Thomas Jefferson [1742-1826], 3rd US President - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
[EMAIL PROTECTED] wrote:
> 4. Boot Time Failures
> * Various Alpha's don't boot under 2.4.0-test9 (PCI-PCI bridges are
>not configured correctly Michal Jaegermann; Richard Henderson may
>have an idea what's failing.)
Move to patch-exists-but-not-merged. rth has patches, co-developed with
Ivan Kokshaysky
> 8. Fix Exists But Isnt Merged
> * Many network device drivers don't call MOD_INC_USE_COUNT in
>dev->open. (Paul Gortmaker has patches)
Update: net drivers can now set an owner member as of test11-pre3, to
completely eliminate any race. Net drivers that don't call MOD_xxx at
all should just be updated to use the new stuff.
> * using ramfs with highmem enabled can yield a kernel NULL pointer
>dereference. (wollny at cns.mpg.de has a patch)
fixed as of test11-pre2.
> 9. To Do
> * Fix mount failures due to copy_* user mishandling
Details?
> * Misc locking problems
> + Power management locking (Alan Cox)
A patch from Alan for this made it into test10 or test11-pre1.
> * Copying between two encrypting loop devices causes an immediate
>deadlock in the request queue (Andi Kleen)
Loopback block device has serious problems, not just this.. I am gonna
look at it this week...
> * 2.4.0-test10 pcmcia fails to detect IRQ's correctly, and will
>sometimes kill all software interrupts on card insertion on a NEC
>Versa LX (David Ford)
Still does this with test11-pre-latest?
> * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
>(Keith Owens)
move to "should already be fixed, confirmation wanted." I think Keith
said he doesn't exercise that particular code path anymore, so he didn't
test James' patch.
> * drivers/input/mousedev.c dereferences userspace pointers directly
>(prumpf)
yum :)
> 10. To Do But Non Showstopper
>
> * Go through as 2.4pre kicks in and figure what we should mark
>obsolete for the final 2.4 (i.e. XT hard disk support?)
* Go through as 2.4pre kicks in and figure out what FOO_DEBUG options
need to be turned off. __iovirt_debug is a notable one that will hurt
performance (IMHO), because every write[bwl] gets routed to a function
call that checks stuff before performing the I/O.
> * Union mount (Al Viro)
I think this is complete? Isn't this mount --bind?
> * Loop device can still hang (William Stearns has script that will
>hang 2.4.0-test7, Peter Enderborg has a short sequence that will
>hang 2.4.0test9)
Maybe combine this entry and the loopback crypto one above into a more
general "loopback works for some cases, deadlocks for others"
> 11. To Check
> * NFS bugs are fixed
Is this worthy of an entry? I think that every bug fix applied should
have a listing here, then. :) check that parport bugs are fixed.
check that serial bugs are fixed. etc. ...
> * List of potential problems found by Stanford students using g++
>hacks:
> + Andy Chou's list of mismatched spinlocks and interrupts/bh
> enable/disable.
> + Seth Andrew Hallem's list potentially sleeping functions
> called with interrupts off or spinlocks held.
> + Dawson Engler's list of potential kmalloc/kfree bugs
A few people are hanging onto these lists, and going through them. This
could be an 'in progress' item.
> * Potential races in file locking code (Christian Ehrhardt -- patch
>which may fix some of these posted by trond, at
>http://boudicca.tux.org/hypermail/linux-kernel/2000week45/0404.htm
>l)
I think trond's patch was applied.
> * many drivers are not hot-plugging safe (__devinit/__devexit)
>(Barklomiej Zolnierkiewicz)
Many drivers are not supposed to be hotplug safe!
If the hardware is not known to be hotpluggable, then the driver should
not use __devinit/exit. Doing so needlessly avoids the __init code
drop, wasting memory.
> 12. Probably Post 2.4
> * module remove race bugs (ipchains modules -- Rusty; won't fix for
>2.4)
Is this an ipchains bug, or a more general module subsystem bug?
> * NCR5380 isnt smp safe (Frank Davis --- belives the driver should
>be rewritten)
hehe I personally believe many of the current kernel drivers should be
rewritten ;-)
Jeff
--
Jeff Garzik |
Building 1024 | Would you like a Twinkie?
MandrakeSoft|
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, 12 Nov 2000 14:39:09 -0500,
[EMAIL PROTECTED] wrote:
>6. In Progress
> * DRM and MTD cannot use AGP support module when CONFIG_MODVERSIONS
> is defined (issue with get_module_symbol caused fix proposed by
> John Levon to be rejected) (Keith Owens has fix)
Fix included in 2.4.0-test11-pre1. I have seen no problems, apart from
dwwm who wants the interface backported to 2.2, but that is a separate
issue.
>8. Fix Exists But Isnt Merged
> * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
> (Keith Owens)
Fix (by whom?) included in 2.4.0-test11-pre3. Looks good.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, Nov 12, 2000 at 02:39:09PM -0500, [EMAIL PROTECTED] wrote:
> * USB: system hang with USB audio driver {CRITICAL} (David
>Woodhouse, Randy Dunlap, Narayan Desai) (Fixed with usb-uhci;
>uhci-alt is unknown -- randy dunlap)
I can still hang the system with XMMS (1.0.1) using real-time priority.
The system doesn't die, but it is completely unresponsive. There is no
sound, but after the MP3 file is played, the system works again. I can
reproduce this behaviour with usb-uhci and uhci-alt on 2.4.0-test10.
I haven't test test11-pre3 yet, but the changes don't look too big that
the "bug" has been fixed.
BTW, I don't think this is a critical bug.
Erik
--
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Department
of Electrical Engineering, Faculty of Information Technology and Systems,
Delft University of Technology, PO BOX 5031, 2600 GA Delft, The Netherlands
Phone: +31-15-2783635 Fax: +31-15-2781843 Email: [EMAIL PROTECTED]
WWW: http://www-ict.its.tudelft.nl/~erik/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, 12 Nov 2000, adrian wrote: > vt82c686a. Also, I can't seem to find which VPx is generally associated Heh.pci.ids Regards, Adrian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, 12 Nov 2000, adrian wrote: > Does this include VPx were x does not exist? Geez. Excuse me. I should watch my assumptions. Out of curiosity, is there a reason why lspci reports vt82c586 and the kernel reports vt82c686a at bootup? The board is documented to have the vt82c686a. Also, I can't seem to find which VPx is generally associated with which southbridge. Regards, Adrian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO page (test11-pre3)
On Sun, 12 Nov 2000 [EMAIL PROTECTED] wrote: [snip] > 2. Capable Of Corrupting Your FS/data > > * Use PCI DMA by default in IDE is unsafe (must not do so on via >VPx, x < 3) (Vojtech Pavlik --- requires chipset tuning to be >enabled according to Andre Hedrick --- we need to turn this on by >default, if it is safe -- TYT) [snip] Does this include VPx were x does not exist? (vt82c686a VIA Apollo VP, specifically Asus K7M) Regards, Adrian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Date: Fri, 3 Nov 2000 17:10:52 -0800 (PST)
From: James Simmons <[EMAIL PROTECTED]>
> * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
>(Keith Owens)
Still not fixed :-( Here is the patch again. Keith give it a try and tell
me if it solves your problems.
Keith, have you had a chance to test the patch? Does it fix things? I
note that it's apparently not in test11-pre2.
- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
tulip vs. de4x5 (was Re: Linux 2.4 Status / TODO page ...)
Jeff Garzik wrote: > > > de4x5 is becoming EISA-only in 2.5.x too, since its PCI support is > duplicated now in tulip driver. > I've got some DEC Miatas with DECchip 21142/43 ethernet cards, and I don't get the same link speeds when using the de4x5 and tulip drivers, as of 2.4.0-test10. The machines are connected to a Netgear 16-port 10/100 hub. With the tulip driver the hub shows a 10 Mb/s connection; with the de4x5 driver the hub shows a 100 Mb/s connection. In both cases the drivers are configured into the kernel, not as modules, if it matters. Am I doing something wrong, or is this a known issue? FWIW, these machines are diskless, and according to the hub they download the kernel at 100 Mb/s. When the tulip-based kernel initializes the card, the hub shows the link speed switching to 10 Mb/s. from lspci -v: 00:03.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 30) Flags: bus master, medium devsel, latency 255, IRQ 24 I/O ports at 8000 [size=128] Memory at 0900 (32-bit, non-prefetchable) [size=128] Expansion ROM at 0904 [disabled] [size=256K] de4x5 boot messages: eth0: DC21143 at 0x8000 (PCI bus 0, device 3), h/w address 00:00:f8:76:3c:74, and requires IRQ24 (provided by PCI BIOS). de4x5.c:V0.545 1999/11/28 [EMAIL PROTECTED] tulip boot messages: Linux Tulip driver version 0.9.10 (September 6, 2000) eth0: Digital DS21143 Tulip rev 48 at 0x8000, 00:00:F8:76:3C:74, IRQ 24. eth0: EEPROM default media type Autosense. eth0: Index #0 - Media 10baseT (#0) described by a 21142 Serial PHY (2) block. eth0: Index #1 - Media 10baseT-FD (#4) described by a 21142 Serial PHY (2) block. eth0: Index #2 - Media 10base2 (#1) described by a 21142 Serial PHY (2) block. eth0: Index #3 - Media AUI (#2) described by a 21142 Serial PHY (2) block. eth0: Index #4 - Media MII (#11) described by a 21142 MII PHY (3) block. eth0: MII transceiver #5 config 2000 status 784b advertising 01e1. -- Jim - James A. Schutt [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Date: Fri, 03 Nov 2000 17:20:53 -0500 From: Jeff Garzik <[EMAIL PROTECTED]> > 4. Boot Time Failures > > * Crashes on boot on some Compaqs ? (may be fixed) compaq laptops? desktops? or alphas? Absolutely no idea. This was one I inherited from Alan's list. If Alan or someone else doesn't speak up on this one, I'll remove it from the list (at a guess, it might be the docking station bug that's already been fixed, but without more information I'm only guessing). > * Fixing autofs4 to deal with VFS changes (Jeremy Fitzhardinge) I thought this was complete a long time ago? Could be. Jeremy? - Ted - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
[EMAIL PROTECTED] wrote: > >Date: Fri, 03 Nov 2000 16:10:50 -0500 >From: Jeff Garzik <[EMAIL PROTECTED]> > >Part of that might be that serial doesn't support hotplug without >patching. > > Did the patch which I sent out a few weeks ago actually work? I haven't > had time to get back to it, but I now have a cardbus card, so it's on my > todo list I do not have CardBus card, so I can't test it. Did you make sure to have a pci_driver::remove function? That is a requirement for PCI hotplug. Otherwise, your driver's probe routine will never be called. I have a built-in Xircom modem on my Toshiba laptop, and it works great with your patch. Jeff -- Jeff Garzik | "When I do this, my computer freezes." Building 1024 | -user MandrakeSoft| "Don't do that." | -level 1 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
[EMAIL PROTECTED] wrote: >> * Issue with notifiers that try to deregister themselves? (lnz; >>notifier locking change by Garzik should backed out, according to >>Jeff) > >and according to Alan > > But it hasn't been backed out yet, correct? It has been backed out. Notifier register and deregister are locked, but not notifier call. -- Jeff Garzik | "When I do this, my computer freezes." Building 1024 | -user MandrakeSoft| "Don't do that." | -level 1 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Date: Fri, 03 Nov 2000 16:10:50 -0500 From: Jeff Garzik <[EMAIL PROTECTED]> Part of that might be that serial doesn't support hotplug without patching. Did the patch which I sent out a few weeks ago actually work? I haven't had time to get back to it, but I now have a cardbus card, so it's on my todo list - Ted - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Date: Fri, 3 Nov 2000 15:53:34 + (GMT) From: Alan Cox <[EMAIL PROTECTED]> > * AIC7xxx doesnt work non PCI ? (Doug says OK, new version due >anyway) This is now in Justin Gibbs hand but will take time to move on. Doug confirmed his current code is now merged too. Does this mean that the problem has been fixed in the latest 2.4 tree? i.e., Does Doug's current code have the problem fixed? > * Issue with notifiers that try to deregister themselves? (lnz; >notifier locking change by Garzik should backed out, according to >Jeff) and according to Alan But it hasn't been backed out yet, correct? Someone one send a patch to Linus? - Ted - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Jeff Garzik wrote: > > Alan Cox wrote: > > > * Check all devices use resources properly (Everyone now has to use > > >request_region and check the return since we no longer single > > >thread driver inits in all module cases. Also memory regions are > > >now requestable and a lot of old drivers dont know this yet. -- > > >Alan Cox) > > > > Folks have done most of the common drivers. So its not really a show stopper > > now just a 'clean up' > > s/check_region/request_region/ is moving along, but there is still a > ways to go. I agree with "folks have done most of the common drivers" > > I have seen very few additions of request_mem_region, though. Something which I forgot to add when mentioning my ioremap patch is that you can pretty much forget about adding request_mem_region() to the same drivers since both changes are in the same spot of code and doing one without doing the other is kind of silly. (i.e. the patches I have for 8390 based drivers do both at once). Although simply having a dev->vmem [or dev->base] added to struct netdevice in 2.4.0, as was discussed many months ago(*) might go a long way in allowing driver back-compatibility from 2.5.x into 2.4.x - probably worthwhile. (*) Search <[EMAIL PROTECTED]> in any linux-net mailing list archive of Dec 1999. Paul. _ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Hello! > > Luckily, my old Multia died. 8) > > > > Jeff, tulip did not work with genuine Digital cards. > > I'm pretty sure I fixed that. Tested it on my Multia in fact :) (and > my AS200 too) > > The fix should be in 2.2.17 tulip.c, as well as 2.4.x... Then sed -e 's/Luckily/What a pity/' in may mail. 8) Alexey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
[EMAIL PROTECTED] wrote: > > de4x5 is becoming EISA-only in 2.5.x too, since its PCI support is > > duplicated now in tulip driver. > > Luckily, my old Multia died. 8) > > Jeff, tulip did not work with genuine Digital cards. I'm pretty sure I fixed that. Tested it on my Multia in fact :) (and my AS200 too) The fix should be in 2.2.17 tulip.c, as well as 2.4.x... Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Mon, 6 Nov 2000, Keith Owens wrote: > I'm not sure why you think this can be used for module persistent > storage. If a module calls inter_module_register() on load, it should > call inter_module_unregister() on unload. All the registered data > points into the loaded module, remove the module and the storage > disappears as well. You can kmalloc() both the im_name and userdata arguments to inter_module_register and you ought to be able to pass NULL as the owner. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Sun, 5 Nov 2000 23:15:27 + (GMT),
David Woodhouse <[EMAIL PROTECTED]> wrote:
>Your patch looks like it'll work. Although I don't really see any
>advantage over {get,put}_module_symbol() in this case, it does look like
>it can be used to finally provide module persistent storage, which will be
>useful.
Cleanliness. All other module data flows go via explicit symbols which
are fixed up at link time or via registration functions. Having a few
sources that use a third mechanism which forces people to use
EXPORT_SYMBOL_NOVERS() to make it work is messy and redundant.
I'm not sure why you think this can be used for module persistent
storage. If a module calls inter_module_register() on load, it should
call inter_module_unregister() on unload. All the registered data
points into the loaded module, remove the module and the storage
disappears as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Sat, 4 Nov 2000, Keith Owens wrote:
> Move this to "in progress" and add MTD code breaks with
> CONFIG_MODVERSIONS, for the same reason. I wrote a patch to replace
> get_module_symbol a week ago and sent it to the DRM/AGP/MTD people for
> testing - no response yet.
Sorry for the delay. I don't actually have any appropriate hardware any
more that doesn't now have a JFFS root filesystem, making it difficult to
test the modular code :)
Your patch looks like it'll work. Although I don't really see any
advantage over {get,put}_module_symbol() in this case, it does look like
it can be used to finally provide module persistent storage, which will be
useful.
However, the easy fix for the MTD code is to use EXPORT_SYMBOL_NOVERS()
for the offending symbols. It's the most appropriate for putting into 2.4.
If the inter_module_{put,get} change is really going into 2.4 at this
late stage, then I'll merge your patch into my CVS tree and look at
updating the MTD code in the 2.4 tree to a more recent version. I was
intending to leave that for later, though.
Also - if it goes into 2.4, please make sure it goes into 2.2 as well.
get_module_symbol() is already broken there because it doesn't increase
the module's use count, and it'll prevent an ugly mess of ifdefs.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Keith Owens writes: > Move this to "in progress" and add MTD code breaks with > CONFIG_MODVERSIONS, for the same reason. I wrote a patch to replace > get_module_symbol a week ago and sent it to the DRM/AGP/MTD people for > testing - no response yet. I have a fix likewise for the MTD code, so it builds without CONFIG_MODULES _ |_| - ---+---+- | | Russell King[EMAIL PROTECTED] --- --- | | | | http://www.arm.linux.org.uk/personal/aboutme.html / / | | +-+-+ --- -+- / | THE developer of ARM Linux |+| /|\ / | | | --- | +-+-+ - /\\\ | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Hello! > de4x5 is becoming EISA-only in 2.5.x too, since its PCI support is > duplicated now in tulip driver. Luckily, my old Multia died. 8) Jeff, tulip did not work with genuine Digital cards. de4x5 was faulty (link state machine was broken, it has lost link after some events on wire) but it worked yet. Alexey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Fri, 3 Nov 2000 10:09:31 -0500, [EMAIL PROTECTED] wrote: >9. To Do > * DRM cannot use AGP support module when CONFIG_MODVERSIONS is > defined (issue with get_module_symbol caused fix proposed by John > Levon to be rejected) Move this to "in progress" and add MTD code breaks with CONFIG_MODVERSIONS, for the same reason. I wrote a patch to replace get_module_symbol a week ago and sent it to the DRM/AGP/MTD people for testing - no response yet. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Fri, Nov 03, 2000 at 06:57:32PM -0500, Jeff Garzik wrote: > Andi Kleen wrote: > > de4x5 is stable, but tends to perform badly under load, mostly because > > it doesn't use rx_copybreak and overflows standard socket buffers with its > > always MTU sized skbuffs. > > One of the reasons that de4x5 isn't gone already is that I get reports > that de4x5 performs better than the tulip driver for their card. I have the same reports from various sources (but then they complain about the socket buffer issue ;) I think it would be best to just keep it as it is with minimal mainteance, even in 2.5. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Alan Cox wrote: > > > Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and > > > 56K card that will kill the machine if you physically pull it out no matter what > Linksys rings a bell with an outstandng 2.2 lockup on pcmcia. I think this might > be a driver bug ? I suspect it might be, I also think it may be getting the wrong voltage or it's poorly designed hardware. It gets hot enough to make a blister if you don't handle it carefully. It works fine all the while installed, goes for days on end, even tho it gets incredibly hot. :) -d -- "The difference between 'involvement' and 'commitment' is like an eggs-and-ham breakfast: the chicken was 'involved' - the pig was 'committed'." begin:vcard n:Ford;David x-mozilla-html:TRUE org:http://www.kalifornia.com/images/paradise.jpg"> adr:;; version:2.1 email;internet:[EMAIL PROTECTED] title:Blue Labs Developer x-mozilla-cpt:;-12480 fn:David Ford end:vcard
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Fri, 3 Nov 2000 17:10:52 -0800 (PST),
James Simmons <[EMAIL PROTECTED]> wrote:
>
>> * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
>>(Keith Owens)
>
>Still not fixed :-( Here is the patch again. Keith give it a try and tell
>me if it solves your problems.
The patch looks OK to me. I worked around my original problem (screen
deadlock in kdb) by skipping the cli()/restore_flags() when kdb is
active, kdb guarantees that only one cpu at a time is doing any work.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
David Ford wrote: > The odd part is that it used to work "way back when". Was this just a fluke? That may have been back in the legacy days. Ejecting ne2k should be ok as long as you are using ne2k-pci or pcnet_cs. Eject serial looks like bad news unless you are using serial_cs (which is impossible at the moment, AFAIK). -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Alan Cox wrote: > > > > Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and > > > 56K card that will kill the machine if you physically pull it out no matter what > > > cardctl/module steps are taken. > > > > > > It uses the ne2k and serial drivers. > > > > Part of that might be that serial doesn't support hotplug without > > patching. > > Linksys rings a bell with an outstandng 2.2 lockup on pcmcia. I think this might > be a driver bug ? On 2.2.x, possibly. On 2.4.x: 1) insert CardBus serial or modem card, that reports itself as PCI_CLASS_COMMUNICATION_SERIAL. 2) modprobe serial, it sees and registers the PCI serial port. 3) eject card, which serial.c doesn't presently notice. ... Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> } Andi, neither you nor me nor Alan nor anyone are able to audit > } all this unnevessarily overcomplicated code. It was buggy, is buggy > } and will be buggy. It is inavoidable, as soon as you have hundreds > } of drivers. > } > If they are buggy and unsupported, why aren't they being expunged from > the main source tree and placed into a ``contrib'' directory or something > for people who may want those drivers? Because by 2.4.5 it will be working ;). Pain power 8) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> > Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and > > 56K card that will kill the machine if you physically pull it out no matter what > > cardctl/module steps are taken. > > > > It uses the ne2k and serial drivers. > > Part of that might be that serial doesn't support hotplug without > patching. Linksys rings a bell with an outstandng 2.2 lockup on pcmcia. I think this might be a driver bug ? > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Andi Kleen wrote: > de4x5 is stable, but tends to perform badly under load, mostly because > it doesn't use rx_copybreak and overflows standard socket buffers with its > always MTU sized skbuffs. One of the reasons that de4x5 isn't gone already is that I get reports that de4x5 performs better than the tulip driver for their card. Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Fri, Nov 03, 2000 at 05:30:26PM -0500, Jeff Garzik wrote: > Bill Wendling wrote: > > > > Also sprach [EMAIL PROTECTED]: > > } > de4x5 is probably also buggy in regard to this. > > } > > } de4x5 is hopeless. I added nice comment in softnet to it. > > } Unfortunately it was lost. 8) > > } > > } Andi, neither you nor me nor Alan nor anyone are able to audit > > } all this unnevessarily overcomplicated code. It was buggy, is buggy > > } and will be buggy. It is inavoidable, as soon as you have hundreds > > } of drivers. > > } > > If they are buggy and unsupported, why aren't they being expunged from > > the main source tree and placed into a ``contrib'' directory or something > > for people who may want those drivers? > > de4x5 is stable. Its hopeless to add stuff to it, or try to any fix of > the (IMHO small) issues, but its fine as is. For maintenance issues, > its PCI support will be eliminated in 2.5.x because it is a duplicate of > support in the tulip driver. de4x5 is stable, but tends to perform badly under load, mostly because it doesn't use rx_copybreak and overflows standard socket buffers with its always MTU sized skbuffs. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Bill Wendling wrote: > > Also sprach [EMAIL PROTECTED]: > } > de4x5 is probably also buggy in regard to this. > } > } de4x5 is hopeless. I added nice comment in softnet to it. > } Unfortunately it was lost. 8) > } > } Andi, neither you nor me nor Alan nor anyone are able to audit > } all this unnevessarily overcomplicated code. It was buggy, is buggy > } and will be buggy. It is inavoidable, as soon as you have hundreds > } of drivers. > } > If they are buggy and unsupported, why aren't they being expunged from > the main source tree and placed into a ``contrib'' directory or something > for people who may want those drivers? de4x5 is stable. Its hopeless to add stuff to it, or try to any fix of the (IMHO small) issues, but its fine as is. For maintenance issues, its PCI support will be eliminated in 2.5.x because it is a duplicate of support in the tulip driver. Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Also sprach [EMAIL PROTECTED]: } > de4x5 is probably also buggy in regard to this. } } de4x5 is hopeless. I added nice comment in softnet to it. } Unfortunately it was lost. 8) } } Andi, neither you nor me nor Alan nor anyone are able to audit } all this unnevessarily overcomplicated code. It was buggy, is buggy } and will be buggy. It is inavoidable, as soon as you have hundreds } of drivers. } If they are buggy and unsupported, why aren't they being expunged from the main source tree and placed into a ``contrib'' directory or something for people who may want those drivers? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
The odd part is that it used to work "way back when". Was this just a fluke? -d Jeff Garzik wrote: > > Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and > > 56K card that will kill the machine if you physically pull it out no matter what > > cardctl/module steps are taken. > > > > It uses the ne2k and serial drivers. > > Part of that might be that serial doesn't support hotplug without > patching. -- "The difference between 'involvement' and 'commitment' is like an eggs-and-ham breakfast: the chicken was 'involved' - the pig was 'committed'." begin:vcard n:Ford;David x-mozilla-html:TRUE org:http://www.kalifornia.com/images/paradise.jpg"> adr:;; version:2.1 email;internet:[EMAIL PROTECTED] title:Blue Labs Developer x-mozilla-cpt:;-12480 fn:David Ford end:vcard
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Alan Cox wrote: > > * Check all devices use resources properly (Everyone now has to use > >request_region and check the return since we no longer single > >thread driver inits in all module cases. Also memory regions are > >now requestable and a lot of old drivers dont know this yet. -- > >Alan Cox) > > Folks have done most of the common drivers. So its not really a show stopper > now just a 'clean up' s/check_region/request_region/ is moving along, but there is still a ways to go. I agree with "folks have done most of the common drivers" I have seen very few additions of request_mem_region, though. > > * Issue with notifiers that try to deregister themselves? (lnz; > >notifier locking change by Garzik should backed out, according to > >Jeff) > > and according to Alan Fixed for a couple versions now. > > * Spin doing ioctls on a down netdeice as it unloads == BOOM > >(prumpf, Alan Cox) Possible other net driver SMP issues (andi > >kleen) > > Turns out to be safe according to Jeff and ANK To avoid Andi confusing the issue :) ... 1) The first item listed does not exist 2) the second item listed exists -- many net drivers are not SMP. They are most of the way there, but there are still small races which exist in some drivers. Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
[EMAIL PROTECTED] wrote: > > Hello! > > > that does hardware register access without protecting against interrupts > > or checking if the interface is up. > > This issue is not that issue. It is separate issue and in fact > it is private problem of driver and its author, what is safe, > what is not safe. > > F.e. I see no cathastrophe even if MII registers are accessed without > any protections. Diag utilities do this from user space. 8)8) It depends on the hardware... For the ioctl-only case, you are correct. rtnl_lock protects us there. But when the timer and ioctl both call mdio_xxx, you need SMP protection, otherwise you corrupt the multi-step MDIO read/write found in many drivers. IMNSHO the timer routines found in net drivers should all be converted to kernel threads. There are too many limitations placed on you by timers. > > de4x5 is probably also buggy in regard to this. > > de4x5 is hopeless. I added nice comment in softnet to it. > Unfortunately it was lost. 8) > > Andi, neither you nor me nor Alan nor anyone are able to audit > all this unnevessarily overcomplicated code. It was buggy, is buggy > and will be buggy. It is inavoidable, as soon as you have hundreds > of drivers. de4x5 is becoming EISA-only in 2.5.x too, since its PCI support is duplicated now in tulip driver. Jeff -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
David Ford wrote: > > Alan Cox wrote: > > > > 10. To Do But Non Showstopper > > > * PCMCIA/Cardbus hangs (Basically unusable - Hinds pcmcia code is > > >reliable) > > > + PCMCIA crashes on unloading pci_socket > > > > The pci_socket crash is fixed it seems > > Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and > 56K card that will kill the machine if you physically pull it out no matter what > cardctl/module steps are taken. > > It uses the ne2k and serial drivers. Part of that might be that serial doesn't support hotplug without patching. -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Alan Cox wrote: > > 10. To Do But Non Showstopper > > * PCMCIA/Cardbus hangs (Basically unusable - Hinds pcmcia code is > >reliable) > > + PCMCIA crashes on unloading pci_socket > > The pci_socket crash is fixed it seems Not unless it was fixed in test10 release. I have a PC LinkSys dual 10/100 and 56K card that will kill the machine if you physically pull it out no matter what cardctl/module steps are taken. It uses the ne2k and serial drivers. -d -- "The difference between 'involvement' and 'commitment' is like an eggs-and-ham breakfast: the chicken was 'involved' - the pig was 'committed'." begin:vcard n:Ford;David x-mozilla-html:TRUE org:http://www.kalifornia.com/images/paradise.jpg"> adr:;; version:2.1 email;internet:[EMAIL PROTECTED] title:Blue Labs Developer x-mozilla-cpt:;-12480 fn:David Ford end:vcard
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Hello! > that does hardware register access without protecting against interrupts > or checking if the interface is up. This issue is not that issue. It is separate issue and in fact it is private problem of driver and its author, what is safe, what is not safe. F.e. I see no cathastrophe even if MII registers are accessed without any protections. Diag utilities do this from user space. 8)8) > de4x5 is probably also buggy in regard to this. de4x5 is hopeless. I added nice comment in softnet to it. Unfortunately it was lost. 8) Andi, neither you nor me nor Alan nor anyone are able to audit all this unnevessarily overcomplicated code. It was buggy, is buggy and will be buggy. It is inavoidable, as soon as you have hundreds of drivers. Alexey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
On Fri, Nov 03, 2000 at 10:03:48PM +0300, [EMAIL PROTECTED] wrote: > Hello! > > > It is not safe, just not worse than 2.2. > > Andi.. 8) > > That issue, which was meant here, it is 100% safe. > > I start to suspect you did not look into this code since 2.2. I actually did, and that is when all this started. I found lots of code that does hardware register access without protecting against interrupts or checking if the interface is up. Tulip, eepro100 seem to be ok. 3c59x seems to be buggy de4x5 is probably also buggy in regard to this. It also does this: case DE4X5_GET_STATS:/* Get the driver statistics */ ioc->len = sizeof(lp->pktStats); spin_lock_irqsave(&lp->lock, flags); if (copy_to_user(ioc->data, &lp->pktStats, ioc->len)) return -EFAULT; spin_unlock_irqrestore(&lp->lock, flags); break; rrunner does GFP_KERNEL kmallocs and copy_to_user with a spin lock held. The hardware register access is probably also racy with interrupts (not 100% sure) depca seems to be buggy too. ... [this was just a 5 minutes grep session. I suspect most of these bugs were also in 2.2] Of course the window is very small because nobody really uses these interrupts regularly. > I acn assume that nothing has changed in ISDN, > in other drivers big changes happened. 8) ISDN syncppp seems to be slightly buggy (module unload race with slhc, compressor init dubious, racy device management that could be cured by the kernel lock), non PPP ISDN does not have a network ioctl. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Hello! > It is not safe, just not worse than 2.2. Andi.. 8) That issue, which was meant here, it is 100% safe. I start to suspect you did not look into this code since 2.2. I acn assume that nothing has changed in ISDN, in other drivers big changes happened. 8) Alexey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> * VGA Console can cause SMP deadlock when doing printk {CRITICAL}
>(Keith Owens)
Still not fixed :-( Here is the patch again. Keith give it a try and tell
me if it solves your problems.
--- vgacon.c.orig Tue Oct 24 18:45:58 2000
+++ vgacon.cTue Oct 24 19:08:51 2000
@@ -46,11 +46,13 @@
#include
#include
#include
+#include
#include
#include
#include
+static spinlock_t vga_lock = SPIN_LOCK_UNLOCKED;
#define BLANK 0x0020
@@ -152,8 +154,7 @@
* ddprintk might set the console position from interrupt
* handlers, thus the write has to be IRQ-atomic.
*/
- save_flags(flags);
- cli();
+ spin_lock_irqsave(&vga_lock, flags);
#ifndef SLOW_VGA
v1 = reg + (val & 0xff00);
@@ -166,7 +167,7 @@
outb_p(reg+1, vga_video_port_reg);
outb_p(val & 0xff, vga_video_port_val);
#endif
- restore_flags(flags);
+ spin_unlock_irqrestore(&vga_lock, flags);
}
static const char __init *vgacon_startup(void)
@@ -415,7 +416,7 @@
if ((from == lastfrom) && (to == lastto)) return;
lastfrom = from; lastto = to;
- save_flags(flags); cli();
+ spin_lock_irqsave(&vga_lock, flags);
outb_p(0x0a, vga_video_port_reg); /* Cursor start */
curs = inb_p(vga_video_port_val);
outb_p(0x0b, vga_video_port_reg); /* Cursor end */
@@ -428,7 +429,7 @@
outb_p(curs, vga_video_port_val);
outb_p(0x0b, vga_video_port_reg); /* Cursor end */
outb_p(cure, vga_video_port_val);
- restore_flags(flags);
+ spin_unlock_irqrestore(&vga_lock, flags);
}
static void vgacon_cursor(struct vc_data *c, int mode)
@@ -533,11 +534,11 @@
{
/* save original values of VGA controller registers */
if(!vga_vesa_blanked) {
- cli();
+ spin_lock_irq(&vga_lock);
vga_state.SeqCtrlIndex = inb_p(seq_port_reg);
vga_state.CrtCtrlIndex = inb_p(vga_video_port_reg);
vga_state.CrtMiscIO = inb_p(video_misc_rd);
- sti();
+ spin_unlock_irq(&vga_lock);
outb_p(0x00,vga_video_port_reg);/* HorizontalTotal */
vga_state.HorizontalTotal = inb_p(vga_video_port_val);
@@ -561,7 +562,7 @@
/* assure that video is enabled */
/* "0x20" is VIDEO_ENABLE_bit in register 01 of sequencer */
- cli();
+ spin_lock_irq(&vga_lock);
outb_p(0x01,seq_port_reg);
outb_p(vga_state.ClockingMode | 0x20,seq_port_val);
@@ -598,13 +599,13 @@
/* restore both index registers */
outb_p(vga_state.SeqCtrlIndex,seq_port_reg);
outb_p(vga_state.CrtCtrlIndex,vga_video_port_reg);
- sti();
+ spin_unlock_irq(&vga_lock);
}
static void vga_vesa_unblank(void)
{
/* restore original values of VGA controller registers */
- cli();
+ spin_lock_irq(&vga_lock);
outb_p(vga_state.CrtMiscIO,video_misc_wr);
outb_p(0x00,vga_video_port_reg);/* HorizontalTotal */
@@ -629,7 +630,7 @@
/* restore index/control registers */
outb_p(vga_state.SeqCtrlIndex,seq_port_reg);
outb_p(vga_state.CrtCtrlIndex,vga_video_port_reg);
- sti();
+ spin_unlock_irq(&vga_lock);
}
static void vga_pal_blank(void)
@@ -750,7 +751,7 @@
charmap += 4*cmapsz;
#endif
- cli();
+ spin_lock_irq(&vga_lock);
outb_p( 0x00, seq_port_reg ); /* First, the sequencer */
outb_p( 0x01, seq_port_val ); /* Synchronous reset */
outb_p( 0x02, seq_port_reg );
@@ -766,7 +767,7 @@
outb_p( 0x00, gr_port_val );/* disable odd-even addressing */
outb_p( 0x06, gr_port_reg );
outb_p( 0x00, gr_port_val );/* map start at A000: */
- sti();
+ spin_unlock_irq(&vga_lock);
if (arg) {
if (set)
@@ -793,7 +794,7 @@
}
}
- cli();
+ spin_lock_irq(&vga_lock);
outb_p( 0x00, seq_port_reg ); /* First, the sequencer */
outb_p( 0x01, seq_port_val ); /* Synchronous reset */
outb_p( 0x02, seq_port_reg );
@@ -833,8 +834,7 @@
inb_p( video_port_status );
outb_p ( 0x20, attrib_port );
}
- sti();
-
+ spin_unlock_irq(&vga_lock);
return 0;
}
@@ -865,12 +865,12 @@
registers; they are write-only on EGA, but it appears that they
are all don't care bits on EGA, so I guess it doesn't matter. */
- cli();
+ spin_lock_irq(&vga_lock);
outb_p( 0x07, vga_video_port_reg ); /* CRTC overflow register */
ovr = inb_p(vga_video_port_val);
outb_p( 0x09, vga_video_port_reg ); /* Font size register */
fsr = inb_p(vga_video_port_val);
- sti();
+ spin_lock_irq(&vga_lock);
vde = maxscan & 0xf
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> > * Spin doing ioctls on a down netdeice as it unloads == BOOM > >(prumpf, Alan Cox) Possible other net driver SMP issues (andi > >kleen) > > Turns out to be safe according to Jeff and ANK It is not safe, just not worse than 2.2. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> > 3. Security > > * Fix module remove race bug (still to be done: TTY, ldisc, I2C, >video_device - Al Viro) (Rogier Wolff will handle ATM) TBD: sysctl, kernel_thread * drivers/input/mousedev.c dereferences userspace pointers directly. We should make this fail for a bit to catch those bugs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
> * Palmax PD1100 hangs during boot since 2.4.0-test9 (Alan Cox) Fixed in pre10. > * AIC7xxx doesnt work non PCI ? (Doug says OK, new version due >anyway) This is now in Justin Gibbs hand but will take time to move on. Doug confirmed his current code is now merged too. > * Check all devices use resources properly (Everyone now has to use >request_region and check the return since we no longer single >thread driver inits in all module cases. Also memory regions are >now requestable and a lot of old drivers dont know this yet. -- >Alan Cox) Folks have done most of the common drivers. So its not really a show stopper now just a 'clean up' > * Issue with notifiers that try to deregister themselves? (lnz; >notifier locking change by Garzik should backed out, according to >Jeff) and according to Alan > * SCSI CD-ROM doesn't work on filesystems with < 2kb block size >(Jens Axboe will fix) SCSI M/O has the same problem. 2.2 can mount MSDOS fs on M/O 2.4test 10 cant. > * FAT filesystem doesn't support 2kb sector sizes (did under 2.2.16, >doesn't under 2.4.0test7. Kazu Makashima, alan) This is the same as the SCSI cd rom issue. You can either do reblocking in the fat layer and other fs's needing it or do it in the scsi code. > * Spin doing ioctls on a down netdeice as it unloads == BOOM >(prumpf, Alan Cox) Possible other net driver SMP issues (andi >kleen) Turns out to be safe according to Jeff and ANK > 10. To Do But Non Showstopper > * PCMCIA/Cardbus hangs (Basically unusable - Hinds pcmcia code is >reliable) > + PCMCIA crashes on unloading pci_socket The pci_socket crash is fixed it seems > * Some AWE cards are not being found by ISAPnP ?? You have this one higher up as problems with some SB AWE cards Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.4 Status/TODO Page
>> Network block device seems broken by block device changes (In sec. 11. To Check) FWIW... I have a set of Pentium Pro machines connected by 100 MBit ethernet. I've been testing the bonnie I/O benchmark over nbd. Using 2.4 kernels up to test6, bonnie would hang when using backing files 100MB and larger. Using the test8 kernel, bonnie seems to work fine. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
