Re: [patch] support for document class option leqno
Dear Uwe, dear Jean-Marc, dear LyX developers, On 2017-05-02, Uwe Stöhr wrote: > El 02.05.2017 a las 17:02, Jean-Marc Lasgouttes escribió: >> 1/ understand, for the various languages and packages implementing these >> languages what are the cases where the default is to put the number on >> the left. I have identified one, there are probably others. >> 2/ see whether LyX can have this knowledge (e.g. using a new tag in the >> language file). >> 3/ when the situation is clear, I can implement on-screen visualization. It would be an enhancement if LyX "native screen rendering" (without instant preview) made this right for RTL languages. We can, however, implement correct "leqno"-support without this, as ... ... > - leqno puts the formula number ALWAYS on the left side. This is clearly > stated in the AMS manuals and also in the LaTeX companion 2nd edition. I think, we can safely assume that with "leqno", there is no numbering on the right side. OTOH, the *default* is not always right. Left numbering is the default in "some special classes", but also for (at least some) RTL languages. > So I would like to keep it as it is: > - LyX supports to switch the numbering side from the default right side > to the left. > - if a user uses a special class using as default left numbering he > knows if overriding this makes sense or not. LyX leaves such a very > special case tho the user. I can live without native "reqno" support. However, I cannot live with the current GUI interface: The drop-down box Fromula numbering [Right] [Left ] is misleading (it is "default" vs. "left"). We know its wrong for RTL languages and some classes. Why not: [ ] Place equation numbers left. ? (Where do we toggle equation/formula numbering and how is it called?) Günter
Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer
Am 03.05.2017 um 01:34 schrieb Tommaso Cucinotta :
>
> commit 8c10182962efa643edfcfbe64fc830b5fc0d9a65
> Author: Tommaso Cucinotta
> Date: Wed May 3 01:29:36 2017 +0200
>
>findadv: hide word-findadv verb from the mini-buffer
>
>The current set of options to provide include names of
>the find and replace internal buffers, something out of
>reach for the user. Furthermore, options are provided
>using a multi-line syntax, which cannot be entered
>using the mini-buffer AFAIK.
> ---
> src/LyXAction.cpp |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp
> index e9f45f5..16efb26 100644
> --- a/src/LyXAction.cpp
> +++ b/src/LyXAction.cpp
> @@ -4069,7 +4069,7 @@ void LyXAction::init()
> * \li Origin: Tommaso, Nov 15 2007
> * \endvar
> */
> - { LFUN_WORD_FINDADV, "word-findadv", ReadOnly | NoBuffer, Edit
> },
> + { LFUN_WORD_FINDADV, "", ReadOnly | NoBuffer, Edit | Hidden },
>
> /*!
> * \var lyx::FuncCode lyx::LFUN_WORD_FIND_BACKWARD
Something like the attached patch is needed!?
Stephan
fix-8c10182.patch
Description: Binary data
Re: LyX 2.3.0alpha1-1
Am Dienstag, 2. Mai 2017 um 19:19:44, schrieb Scott Kostyshak > On Tue, May 02, 2017 at 08:24:40AM +0200, Kornel Benko wrote: > > Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > > > > > > Kornel, which commits should I cherry-pick from master to > > > 2.3.0-alpha1-x? i.e. which commits do I need for Uwe to build from the > > > tar ball? > > > > I committed it now under 0935f94 > > OK. And 0f798d6 is needed also right? No, it is not needed. Only if one wants to add numbers different to '2.3' version. (But it does not harm either) > Anything (in addition to 0935f94 > and 0f798d6) after db8069c2 that I need to cherry-pick for the Windows > build? Not that I were aware of. > Scott Kornel signature.asc Description: This is a digitally signed message part.
Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #191
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/191/-- [...truncated 739 lines...] GEN moc_GuiNomenclature.cpp GEN moc_GuiNote.cpp GEN moc_GuiParagraph.cpp GEN moc_GuiPhantom.cpp GEN moc_GuiPrefs.cpp GEN moc_GuiPrintindex.cpp GEN moc_GuiPrintNomencl.cpp GEN moc_GuiProgress.cpp GEN moc_GuiProgressView.cpp GEN moc_GuiRef.cpp GEN moc_GuiSearch.cpp GEN moc_GuiSelection.cpp GEN moc_GuiSelectionManager.cpp GEN moc_GuiSendto.cpp GEN moc_GuiSetBorder.cpp GEN moc_GuiShowFile.cpp GEN moc_GuiSpellchecker.cpp GEN moc_GuiSymbols.cpp GEN moc_GuiTabularCreate.cpp GEN moc_GuiTabular.cpp GEN moc_GuiTexinfo.cpp GEN moc_GuiThesaurus.cpp GEN moc_GuiToc.cpp GEN moc_GuiToolbar.cpp GEN moc_GuiView.cpp GEN moc_GuiViewSource.cpp GEN moc_GuiVSpace.cpp GEN moc_GuiWorkArea.cpp GEN moc_GuiWrap.cpp GEN moc_IconPalette.cpp GEN moc_InGuiThread.cpp GEN moc_InsertTableWidget.cpp GEN moc_InsetParamsDialog.cpp GEN moc_InsetParamsWidget.cpp GEN moc_LayoutBox.cpp GEN moc_LengthCombo.cpp GEN moc_LyXFileDialog.cpp GEN moc_Menus.cpp GEN moc_PanelStack.cpp GEN moc_TocModel.cpp GEN moc_TocWidget.cpp GEN moc_ToolTipFormatter.cpp GEN moc_Validator.cpp GEN Resources.qrc GEN Resources.cpp make all-am make[6]: Entering directory '/build/workspace/src/frontends/qt4' CXX ButtonPolicy.o CXX Dialog.o CXX Action.o CXX BulletsModule.o CXX ButtonController.o CXX CategorizedCombo.o CXX ColorCache.o CXX CustomizedWidgets.o CXX DialogView.o CXX DockView.o CXX EmptyTable.o CXX FancyLineEdit.o CXX FileDialog.o CXX FindAndReplace.o CXX FloatPlacement.o CXX GuiAbout.o CXX GuiAlert.o CXX GuiApplication.o CXX GuiBibitem.o CXX GuiBibtex.o CXX GuiBox.o CXX GuiBranch.o CXX GuiBranches.o CXX GuiChanges.o CXX GuiCharacter.o CXX GuiCitation.o CXX GuiClipboard.o CXX GuiCommandBuffer.o CXX GuiCommandEdit.o CXX GuiCompare.o CXX GuiCompareHistory.o CXX GuiCompleter.o CXX GuiDelimiter.o CXX GuiDialog.o CXX GuiDocument.o CXX GuiErrorList.o CXX GuiERT.o CXX GuiExternal.o CXX GuiFontExample.o CXX GuiFontLoader.o CXX GuiFontMetrics.o CXX GuiGraphics.o CXX GuiHSpace.o CXX GuiHyperlink.o CXX GuiIdListModel.o CXX GuiImage.o CXX GuiInclude.o CXX GuiIndex.o CXX GuiIndices.o CXX GuiInfo.o CXX GuiKeySymbol.o CXX GuiLabel.o CXX GuiLine.o CXX GuiListings.o CXX GuiLog.o CXX GuiMathMatrix.o CXX GuiNomenclature.o CXX GuiNote.o CXX GuiPainter.o CXX GuiParagraph.o CXX GuiPhantom.o CXX GuiPrefs.o CXX GuiPrintindex.o CXX GuiPrintNomencl.o CXX GuiProgress.o CXX GuiProgressView.o CXX GuiRef.o CXX GuiSearch.o CXX GuiSelection.o CXX GuiSelectionManager.o CXX GuiSendto.o CXX GuiSetBorder.o CXX GuiShowFile.o CXX GuiSpellchecker.o CXX GuiSymbols.o CXX GuiTabular.o CXX GuiTabularCreate.o CXX GuiTexinfo.o CXX GuiThesaurus.o CXX GuiToc.o CXX GuiToolbar.o CXX GuiView.o CXX GuiViewSource.o CXX GuiVSpace.o CXX GuiWorkArea.o CXX GuiWrap.o CXX IconPalette.o CXX InGuiThread.o CXX InsertTableWidget.o CXX InsetParamsDialog.o CXX InsetParamsWidget.o CXX LengthCombo.o CXX LyXFileDialog.o CXX LaTeXHighlighter.o CXX LayoutBox.o CXX Menus.o CXX PanelStack.o CXX qt_helpers.o CXX TocModel.o CXX TocWidget.o CXX Toolbars.o CXX ToolTipFormatter.o CXX Validator.o CXX Resources.o In file included from Resources.cpp:9:0: Resources.cpp:298073:44: warning: 'qInitResources_Resources__init_variable__' defined but not used [-Wunused-variable] Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_Resources)) ^ /usr/include/qt4/QtCore/qglobal.h:941:21: note: in definition of macro 'Q_CONSTRUCTOR_FUNCTION0' static const int AFUNC ## __init_variable__ = AFUNC(); ^ Resources.cpp:298073:1: note: in expansion of macro 'Q_CONSTRUCTOR_FUNCTION' Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_Resources)) ^ Resources.cpp:298073:24: note: in expansion of macro 'QT_MANGLE_NAMESPACE' Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_Resources))
Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #174
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/174/-- [...truncated 1618 lines...] [ 73%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathSplit.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/InsetMathSplit.cpp.o -c /build/lyx/src/mathed/InsetMathSplit.cpp [ 73%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathDelim.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/InsetMathDelim.cpp.o -c /build/lyx/src/mathed/InsetMathDelim.cpp [ 73%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathHull.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/InsetMathHull.cpp.o -c /build/lyx/src/mathed/InsetMathHull.cpp [ 74%] Building CXX object src/mathed/CMakeFiles/mathed.dir/MathRow.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/MathRow.cpp.o -c /build/lyx/src/mathed/MathRow.cpp [ 74%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathFont.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/InsetMathFont.cpp.o -c /build/lyx/src/mathed/InsetMathFont.cpp [ 74%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathPar.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/InsetMathPar.cpp.o -c /build/lyx/src/mathed/InsetMathPar.cpp [ 74%] Building CXX object src/mathed/CMakeFiles/mathed.dir/MacroTable.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -Wall -Wunused-parameter --std=c++14 -fno-strict-aliasing -Wall -Wunused-parameter --std=c++14 -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/mathed.dir/MacroTable.cpp.o -c /build/lyx/src/mathed/MacroTable.cpp [ 74%] Building CXX object src/mathed/CMakeFiles/mathed.dir/InsetMathString.cpp.o cd /build/lyx/build/src/mathed && /usr/bin/c++ -DBOOST_USER_CONFIG="" -DQT_CORE_LIB -DQT_NO_DEBUG -I/build/lyx/build -I/build/lyx/src -I/build/lyx/3rdparty/boost -I/build/lyx/src/mathed -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/inclu
Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #182
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/182/-- [...truncated 735 lines...] GEN moc_GuiMathMatrix.cpp GEN moc_GuiNomenclature.cpp GEN moc_GuiNote.cpp GEN moc_GuiParagraph.cpp GEN moc_GuiPhantom.cpp GEN moc_GuiPrefs.cpp GEN moc_GuiPrintindex.cpp GEN moc_GuiPrintNomencl.cpp GEN moc_GuiProgress.cpp GEN moc_GuiProgressView.cpp GEN moc_GuiRef.cpp GEN moc_GuiSearch.cpp GEN moc_GuiSelection.cpp GEN moc_GuiSelectionManager.cpp GEN moc_GuiSendto.cpp GEN moc_GuiSetBorder.cpp GEN moc_GuiShowFile.cpp GEN moc_GuiSpellchecker.cpp GEN moc_GuiSymbols.cpp GEN moc_GuiTabularCreate.cpp GEN moc_GuiTabular.cpp GEN moc_GuiTexinfo.cpp GEN moc_GuiThesaurus.cpp GEN moc_GuiToc.cpp GEN moc_GuiToolbar.cpp GEN moc_GuiView.cpp GEN moc_GuiViewSource.cpp GEN moc_GuiVSpace.cpp GEN moc_GuiWorkArea.cpp GEN moc_GuiWrap.cpp GEN moc_IconPalette.cpp GEN moc_InGuiThread.cpp GEN moc_InsertTableWidget.cpp GEN moc_InsetParamsDialog.cpp GEN moc_InsetParamsWidget.cpp GEN moc_LayoutBox.cpp GEN moc_LengthCombo.cpp GEN moc_LyXFileDialog.cpp GEN moc_Menus.cpp GEN moc_PanelStack.cpp GEN moc_TocModel.cpp GEN moc_TocWidget.cpp GEN moc_ToolTipFormatter.cpp GEN moc_Validator.cpp GEN Resources.qrc GEN Resources.cpp make all-am make[6]: Entering directory '/build/workspace/src/frontends/qt4' CXX ButtonPolicy.o CXX Dialog.o CXX Action.o CXX BulletsModule.o CXX ButtonController.o CXX CategorizedCombo.o CXX ColorCache.o CXX CustomizedWidgets.o CXX DialogView.o CXX DockView.o CXX EmptyTable.o CXX FancyLineEdit.o CXX FileDialog.o CXX FindAndReplace.o CXX FloatPlacement.o CXX GuiAbout.o CXX GuiAlert.o CXX GuiApplication.o CXX GuiBibitem.o CXX GuiBibtex.o CXX GuiBox.o CXX GuiBranch.o CXX GuiBranches.o CXX GuiChanges.o CXX GuiCharacter.o CXX GuiCitation.o CXX GuiClipboard.o CXX GuiCommandBuffer.o CXX GuiCommandEdit.o CXX GuiCompare.o CXX GuiCompareHistory.o CXX GuiCompleter.o CXX GuiDelimiter.o CXX GuiDialog.o CXX GuiDocument.o CXX GuiErrorList.o CXX GuiERT.o CXX GuiExternal.o CXX GuiFontExample.o CXX GuiFontLoader.o CXX GuiFontMetrics.o CXX GuiGraphics.o CXX GuiHSpace.o CXX GuiHyperlink.o CXX GuiIdListModel.o CXX GuiImage.o CXX GuiInclude.o CXX GuiIndex.o CXX GuiIndices.o CXX GuiInfo.o CXX GuiKeySymbol.o CXX GuiLabel.o CXX GuiLine.o CXX GuiListings.o CXX GuiLog.o CXX GuiMathMatrix.o CXX GuiNomenclature.o CXX GuiNote.o CXX GuiPainter.o CXX GuiParagraph.o CXX GuiPhantom.o CXX GuiPrefs.o CXX GuiPrintindex.o CXX GuiPrintNomencl.o CXX GuiProgress.o CXX GuiProgressView.o CXX GuiRef.o CXX GuiSearch.o CXX GuiSelection.o CXX GuiSelectionManager.o CXX GuiSendto.o CXX GuiSetBorder.o CXX GuiShowFile.o CXX GuiSpellchecker.o CXX GuiSymbols.o CXX GuiTabular.o CXX GuiTabularCreate.o CXX GuiTexinfo.o CXX GuiThesaurus.o CXX GuiToc.o CXX GuiToolbar.o CXX GuiView.o CXX GuiViewSource.o CXX GuiVSpace.o CXX GuiWorkArea.o CXX GuiWrap.o CXX IconPalette.o CXX InGuiThread.o CXX InsertTableWidget.o CXX InsetParamsDialog.o CXX InsetParamsWidget.o CXX LengthCombo.o CXX LyXFileDialog.o CXX LaTeXHighlighter.o CXX LayoutBox.o CXX Menus.o CXX PanelStack.o CXX qt_helpers.o CXX TocModel.o CXX TocWidget.o CXX Toolbars.o CXX ToolTipFormatter.o CXX Validator.o CXX Resources.o In file included from Resources.cpp:9:0: Resources.cpp:298073:44: warning: 'qInitResources_Resources__init_variable__' defined but not used [-Wunused-variable] Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_Resources)) ^ /usr/include/qt4/QtCore/qglobal.h:941:21: note: in definition of macro 'Q_CONSTRUCTOR_FUNCTION0' static const int AFUNC ## __init_variable__ = AFUNC(); ^ Resources.cpp:298073:1: note: in expansion of macro 'Q_CONSTRUCTOR_FUNCTION' Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_Resources)) ^ Resources.cpp:298073:24: note: in expansion of macro 'QT_MANGLE_NAMESPACE' Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResou
Re: [LyX/master] Added testcase for crash with using function word-findadv
hmm.., not sure if [8c101829/lyxgit] would need a rollback then... T. On 02/05/2017 12:23, Kornel Benko wrote: commit c4c989b9c8d687e6f52d44fc411cf2ad14b2f8c1 Author: Kornel Benko Date: Tue May 2 12:22:09 2017 +0200 Added testcase for crash with using function word-findadv --- development/autotests/findadv-crash-in.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/development/autotests/findadv-crash-in.txt b/development/autotests/findadv-crash-in.txt new file mode 100644 index 000..bc3affe --- /dev/null +++ b/development/autotests/findadv-crash-in.txt @@ -0,0 +1,10 @@ +# Test for searching with regular expressions +# Crash in using function 'word-findadv' + +Lang C +TestBegin test.lyx -dbg find > lyx-log.txt 2>&1 +KK: abcd +KK: \Axword-findadv a\[Return] +TestEnd +Lang C +Assert ! pcregrep 'SIGSEGV signal caught' lyx-log.txt
Re: LyX 2.3 alpha 1
On Tue, May 02, 2017 at 03:51:10PM +0100, F M Salter wrote: > > Could it be that this is all part of pdfcomment's fragility? Yes, I think so. -- Enrico
Re: LyX 2.3.0alpha1-1
On Tue, May 02, 2017 at 08:24:40AM +0200, Kornel Benko wrote: > Am Montag, 1. Mai 2017 um 20:25:44, schrieb Scott Kostyshak > > Kornel, which commits should I cherry-pick from master to > > 2.3.0-alpha1-x? i.e. which commits do I need for Uwe to build from the > > tar ball? > > I committed it now under 0935f94 OK. And 0f798d6 is needed also right? Anything (in addition to 0935f94 and 0f798d6) after db8069c2 that I need to cherry-pick for the Windows build? Scott signature.asc Description: PGP signature
Re: [LyX/master] Remove workaround for bug in TeXLive2005.
On Mon, May 01, 2017 at 05:48:51PM +, Guenter Milde wrote: > On 2017-05-01, Kornel Benko wrote: > Yes, the ukrainean defs (koi8-u) still miss some definitions. > I added a specific force and it works here now. The test passes here now. Thanks, Scott signature.asc Description: PGP signature
Re: [patch] support for document class option leqno
El 02.05.2017 a las 17:02, Jean-Marc Lasgouttes escribió: 1/ understand, for the various languages and packages implementing these languages what are the cases where the default is to put the number on the left. I have identified one, there are probably others. 2/ see whether LyX can have this knowledge (e.g. using a new tag in the language file). 3/ when the situation is clear, I can implement on-screen visualization. I see it a bit different: - leqno puts the formula number ALWAYS on the left side. This is clearly stated in the AMS manuals and also in the LaTeX companion 2nd edition. I spent some time in testing out Farsi, Arabic and Hebrew and with leqno I get the number on the left side. So as I wrote, I don't see a problem. I trusted you that you got it at the right side but you have not provided such a case. If it was a misunderstanding and you have no test case for that, we should trust that leqno leads to left numbering and can setup the visualization accordingly. Concerning reqno, this is already the default. It has only an effect for document classes using left numbering. But these are special classes for scientific journals. If the user want to override the requirements of special classes he can still do it. There is no need for LyX to provide support for this. Moreover this would be hard to investigate what classes are affected and why the use already left numbering. So I would like to keep it as it is: - LyX supports to switch the numbering side from the default right side to the left. - if a user uses a special class using as default left numbering he knows if overriding this makes sense or not. LyX leaves such a very special case tho the user. regards Uwe
Re: Crash with using lyx-function word-findadv
Le 02/05/2017 à 18:15, Tommaso Cucinotta a écrit : On 02/05/2017 18:00, Jean-Marc Lasgouttes wrote: Why not make the function internal, i.e. give it an empty name like LFUN_FINISHED_BACKWARD? u mean, just this [1] ? or, do we need "Hidden" ? I would say we should use both. JMarc
Re: Crash with using lyx-function word-findadv
On 02/05/2017 18:10, Kornel Benko wrote:
It would still be nice to have the possibility to use minibuffer for scripted
findadv tests.
(The reason is that the minibuffer commands are language independent)
would make sense as a feature enh request, needs a syntax rethinking.
This is what we have now with the regular find (word-find):
// data is of the form
// "
//"
docstring search;
docstring howto = split(ev.argument(), search, '\n');
bool casesensitive = parse_bool(howto);
bool matchword = parse_bool(howto);
bool forward = parse_bool(howto);
return findOne(bv, search, casesensitive, matchword, forward, true,
true);
the multi-line encoding allows for searching single-line arbitrary text without
having special encoding for that.
The replace options has something more (replaced text).
// data is of the form
// "
//
// "
and this is the crap :-) coming out of a FindAdv request (either find adv and
replace adv):
ostringstream & operator<<(ostringstream & os, FindAndReplaceOptions const &
opt)
{
os << to_utf8(opt.find_buf_name) << "\nEOSS\n"
<< opt.casesensitive << ' '
<< opt.matchword << ' '
<< opt.forward << ' '
<< opt.expandmacros << ' '
<< opt.ignoreformat << ' '
<< to_utf8(opt.repl_buf_name) << "\nEOSS\n"
<< opt.keep_case << ' '
<< int(opt.scope) << ' '
<< int(opt.restr);
LYXERR(Debug::FIND, "built: " << os.str());
return os;
}
:-P.
T.
Re: Crash with using lyx-function word-findadv
On 02/05/2017 18:00, Jean-Marc Lasgouttes wrote:
Why not make the function internal, i.e. give it an empty name like
LFUN_FINISHED_BACKWARD?
u mean, just this [1] ? or, do we need "Hidden" ?
T.
[1]
tommaso@tommylap:~/lyx-trunk-ws/lyx$ git diff
diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp
index e9f45f58..4f65266d 100644
--- a/src/LyXAction.cpp
+++ b/src/LyXAction.cpp
@@ -4069,7 +4069,7 @@ void LyXAction::init()
* \li Origin: Tommaso, Nov 15 2007
* \endvar
*/
- { LFUN_WORD_FINDADV, "word-findadv", ReadOnly | NoBuffer, Edit
},
+ { LFUN_WORD_FINDADV, "", ReadOnly | NoBuffer, Edit },
/*!
* \var lyx::FuncCode lyx::LFUN_WORD_FIND_BACKWARD
Re: Crash with using lyx-function word-findadv
Am Dienstag, 2. Mai 2017 um 17:56:21, schrieb Tommaso Cucinotta > On 02/05/2017 11:19, Kornel Benko wrote: > > Start lyx > > select new file > > type anything e.g. 'abcd' > > Goto home position > > in minibuffer type word-findadv a > > Any (or no at all) parameter to this function leads to crash. > > This is independent of active search dialog. > > (would be great to have an autotest for this :-) ) > the attached patch fixes the crash for me, can you please check ? Yes, keytest/findadv-crash passes now. > Can we commit to master now ? > > > For comparision, the function 'word-find' does not crash, but doesn't find > > anything either. > > these LFUNs use a special syntax to be provided, encoding the set of > available search options as a string; the regular word-find can be hand-made, > but the one needed by the word-findadv() requires a multi-line options string > including the name of the search and replace internal buffers within > theBuffers(), which are generally things internal to LyX and not exposed to > the user... > ... if we'd like to have a "word-findadv a" command to find "a" with default > options, that can be achieved by tweaking the > >istringstream & operator>>(istringstream & is, FindAndReplaceOptions & opt) > > function in lyxfind.cpp. Can't remember why this is done this way (passing > the names of these 2 buffers), probably at that time I couldn't find a > better/simpler way to find those 2 special buffers from the lyxfind.cpp > context :-(! > > T. It would still be nice to have the possibility to use minibuffer for scripted findadv tests. (The reason is that the minibuffer commands are language independent) Kornel signature.asc Description: This is a digitally signed message part.
Re: Crash with using lyx-function word-findadv
Le 02/05/2017 à 17:56, Tommaso Cucinotta a écrit : Can we commit to master now ? Yes, I think so. For comparision, the function 'word-find' does not crash, but doesn't find anything either. these LFUNs use a special syntax to be provided, encoding the set of available search options as a string; the regular word-find can be hand-made, but the one needed by the word-findadv() requires a multi-line options string including the name of the search and replace internal buffers within theBuffers(), which are generally things internal to LyX and not exposed to the user... Why not make the function internal, i.e. give it an empty name like LFUN_FINISHED_BACKWARD? JMarc
Re: Crash with using lyx-function word-findadv
On 02/05/2017 11:19, Kornel Benko wrote:
Start lyx
select new file
type anything e.g. 'abcd'
Goto home position
in minibuffer type word-findadv a
Any (or no at all) parameter to this function leads to crash.
This is independent of active search dialog.
(would be great to have an autotest for this :-) )
the attached patch fixes the crash for me, can you please check ?
Can we commit to master now ?
For comparision, the function 'word-find' does not crash, but doesn't find
anything either.
these LFUNs use a special syntax to be provided, encoding the set of available
search options as a string; the regular word-find can be hand-made, but the one
needed by the word-findadv() requires a multi-line options string including the
name of the search and replace internal buffers within theBuffers(), which are
generally things internal to LyX and not exposed to the user...
... if we'd like to have a "word-findadv a" command to find "a" with default
options, that can be achieved by tweaking the
istringstream & operator>>(istringstream & is, FindAndReplaceOptions & opt)
function in lyxfind.cpp. Can't remember why this is done this way (passing the
names of these 2 buffers), probably at that time I couldn't find a
better/simpler way to find those 2 special buffers from the lyxfind.cpp context
:-(!
T.
>From f2819a9daf5014434f2b39636268cad8455e0bd9 Mon Sep 17 00:00:00 2001
From: Tommaso Cucinotta
Date: Tue, 2 May 2017 17:46:38 +0200
Subject: [PATCH] findadv: fix crash on wrong syntax/usage of word-findadv LFUN
from mini-command.
---
src/lyxfind.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp
index c743fb81..d789c012 100644
--- a/src/lyxfind.cpp
+++ b/src/lyxfind.cpp
@@ -1512,6 +1512,11 @@ bool findAdv(BufferView * bv, FindAndReplaceOptions const & opt)
DocIterator cur;
int match_len = 0;
+ // e.g., when invoking word-findadv from mini-buffer wither with
+ // wrong options syntax or before ever opening advanced F&R pane
+ if (theBufferList().getBuffer(FileName(to_utf8(opt.find_buf_name))) == 0)
+ return false;
+
try {
MatchStringAdv matchAdv(bv->buffer(), opt);
int length = bv->cursor().selectionEnd().pos() - bv->cursor().selectionBegin().pos();
--
2.9.3
Re: Crash with using lyx-function word-findadv
On 02/05/2017 11:19, Kornel Benko wrote: Start lyx select new file type anything e.g. 'abcd' Goto home position in minibuffer type word-findadv a Any (or no at all) parameter to this function leads to crash. confirmed... T.
Re: [patch] support for document class option leqno
Le 29/04/2017 à 16:38, Guenter Milde a écrit :
So, it seems in arabic equation numbering does not change sides.
It still may be different with babel vs. polyglossia, with other RTL
languages and/or additional packages.
I think that it depends on the package (Hebrew shall be checked too).
This needs to be investigated.
The safe option would be a 3-way setting:
equation numbers:
default# no option
left # leqno
right # reqno + require("amsmath")
? This would also fit in the scheme to name opion settings that don't insert
code "default".
I suspect we will have to do this, indeed.
JMarc
Re: [patch] support for document class option leqno
Le 02/05/2017 à 16:42, Kornel Benko a écrit : Am Dienstag, 2. Mai 2017 um 16:35:03, schrieb Jean-Marc Lasgouttes Le 02/05/2017 à 16:31, Kornel Benko a écrit : Is this one better? But I see the number to the right when editing. The pdflatex output is to the left, as it is the math-preview. I thought tht the question was whether the number is on the left when typesetting. It seemed to me that Uwe mentioned that he did not observe that in Arabic documents. Maybe. Citing Uwe: Here is the citation I am referring to: > At first I sent the patch using left/right but JMarc said that this > would be incorrect for RTL languages. I cannot get such a case here but > as JMarc wrote today that he gets this. Thus we need to investigate that > further how and when leqno leads to numbering at the right side. So here is what I propose: 1/ understand, for the various languages and packages implementing these languages what are the cases where the default is to put the number on the left. I have identified one, there are probably others. 2/ see whether LyX can have this knowledge (e.g. using a new tag in the language file). 3/ when the situation is clear, I can implement on-screen visualization. To be frank, I am not really interested in trying all our RtL languages variants and see what they do. I did not open this particular can of worms. But I will do the part I know how to do. Uwe? JMarc
Re: LyX 2.3 alpha 1
On 02/05/17 14:44, F M Salter wrote: > > > > On 01/05/17 15:02, Enrico Forestieri wrote: >> On Sat, Apr 29, 2017 08:27 AM, F M Salter wrote: >>> ... >>> ... >>> 1. Is this a demonstration of a flawed copying procedure? >>> 2, or of something else? >> This is a limitation of the \pdfmarkupcomment latex macro that does >> not allow changing language inside it. You can overcome this by >> resetting the language changes inside the "PDF (Markup)" inset or, >> if you really need them, by making sure that no language switch occurs >> inside \pdfmarkupcomment. You can fix your document by changing the >> language of the "Opts" inset to "English (USA)", then select the >> whole "PDF (Markup)" inset (not only its content) and also change its >> language to "English (USA)". See the attached. >> -- >> Enrico >> >> ... >> ... > Thank you very much for your helpful commentary. It has > increased my understanding of the characteristics of the pdfcomment > package. In not understanding the significance of what you had > written, I did not appreciate that the language components mattered. > I won't make a similar mistake again. However, I previously had asked > if anyone had any experience of the annotations disappearing. I had a > document which suddenly failed to provide the annotations and no > errors were reported. After a piecemeal copying of the document into > a new lyx file, the annotations reappeared. Adding a few more > annotations provided output with at least one highlight which extended > to the page edge and did not carry on to the following line as the > markup required. There was at least another peculiarity but I can't > remember it in detail. Adding further annotations finally produced > another file, with no reported errors but with no annotations either! > Back to square one. In trying to resolve this problem, I came across > the file upon which you have commented. However, I have also > carried out another piecemeal copying. This time using LyX 2.2.2. > Again the file created provided annotated output. I compared the > working and non-working lyx files in emacs. The only difference was > in the white space at one point in the lyx file! The spacing > concerned is not part of the documents' text! There is at least > one further peculiarity. Where one word, in a region being > highlighted, was hyphenated, the word-part carried on to the next line > was not highlighted, but before and after were! Could it be that this > is all part of pdfcomment's fragility? Regards Frank Salter
Re: [patch] support for document class option leqno
Am Dienstag, 2. Mai 2017 um 16:35:03, schrieb Jean-Marc Lasgouttes > Le 02/05/2017 à 16:31, Kornel Benko a écrit : > >> Is this one better? > > > > But I see the number to the right when editing. The pdflatex output is to > > the left, as it is the math-preview. > > I thought tht the question was whether the number is on the left when > typesetting. It seemed to me that Uwe mentioned that he did not observe > that in Arabic documents. Maybe. Citing Uwe: > > Hi JMarc, > > > > the patch misses the visualization within LYX. I have the same problem > > as with the visualization of mathindent. I cannot find where in the code > > we set draw the general math inset. You said that you will do something > > for mathindent maybe you could give me also a hint for the formula number? Difficult to understand what 'visualization' means. Maybe, he has not math-preview set. > I have promised to implement on screen support for leqno and fleqn, but > I have not do so yet. I am waiting to see what is actually necessary for > leqno. > > JMarc Kornel signature.asc Description: This is a digitally signed message part.
Re: [patch] support for document class option leqno
Le 02/05/2017 à 16:31, Kornel Benko a écrit : Is this one better? But I see the number to the right when editing. The pdflatex output is to the left, as it is the math-preview. I thought tht the question was whether the number is on the left when typesetting. It seemed to me that Uwe mentioned that he did not observe that in Arabic documents. I have promised to implement on screen support for leqno and fleqn, but I have not do so yet. I am waiting to see what is actually necessary for leqno. JMarc
Re: [patch] support for document class option leqno
Am Dienstag, 2. Mai 2017 um 16:00:40, schrieb Jean-Marc Lasgouttes > Le 02/05/2017 à 15:37, Kornel Benko a écrit : > >> I do not know anything about Arabic, so I created with LyX 2.3.3dev a > >> document with language arabic_arabi, and I see the equation numbers on > >> the left. > >> > >> I do not understand why you do not see the same, Uwe. > > > > Wrong file attached? The sent doc is neither arabic, nor contains any math. > > Indeed ;) I have two computers on my desk and sent my email from the > wrong one... > > Is this one better? Yes. But I see the number to the right when editing. The pdflatex output is to the left, as it is the math-preview. > JMarc Kornel signature.asc Description: This is a digitally signed message part.
Re: [patch] support for document class option leqno
Le 02/05/2017 à 15:37, Kornel Benko a écrit : I do not know anything about Arabic, so I created with LyX 2.3.3dev a document with language arabic_arabi, and I see the equation numbers on the left. I do not understand why you do not see the same, Uwe. Wrong file attached? The sent doc is neither arabic, nor contains any math. Indeed ;) I have two computers on my desk and sent my email from the wrong one... Is this one better? JMarc nouveau1.lyx Description: application/lyx
Re: [patch] support for document class option leqno
Am Dienstag, 2. Mai 2017 um 14:47:23, schrieb Jean-Marc Lasgouttes > Le 26/04/2017 à 00:16, Uwe Stöhr a écrit : > > El 25.04.2017 a las 07:41, Guenter Milde escribió: > > > >> In this case, shouldn't it be named "right/left", as "before/after" would > >> mean reverse placement (left/right) in RTL languages? > > > > At first I sent the patch using left/right but JMarc said that this > > would be incorrect for RTL languages. I cannot get such a case here but > > as JMarc wrote today that he gets this. Thus we need to investigate that > > further how and when leqno leads to numbering at the right side. > > I do not know anything about Arabic, so I created with LyX 2.3.3dev a > document with language arabic_arabi, and I see the equation numbers on > the left. > > I do not understand why you do not see the same, Uwe. > > JMarc > Wrong file attached? The sent doc is neither arabic, nor contains any math. Kornel signature.asc Description: This is a digitally signed message part.
Re: [patch] support for document class option leqno
Le 26/04/2017 à 00:16, Uwe Stöhr a écrit : El 25.04.2017 a las 07:41, Guenter Milde escribió: In this case, shouldn't it be named "right/left", as "before/after" would mean reverse placement (left/right) in RTL languages? At first I sent the patch using left/right but JMarc said that this would be incorrect for RTL languages. I cannot get such a case here but as JMarc wrote today that he gets this. Thus we need to investigate that further how and when leqno leads to numbering at the right side. I do not know anything about Arabic, so I created with LyX 2.3.3dev a document with language arabic_arabi, and I see the equation numbers on the left. I do not understand why you do not see the same, Uwe. JMarc nouveau1.lyx Description: application/lyx
Re: Default to Qt 4 or Qt 5 with our build systems?
Le 01/05/2017 à 22:18, Uwe Stöhr a écrit : The plan was not to require Qt 5.1 but just to set in CMake the default switch from Qt4 to Qt5. What Qt5 version you use its up to you. The Qt5 that LyX makes me use is the Qt5 that is packaged on my system (on Linux). JMarc
Re: copy inside math and paste in text mode gives LaTeX
Le 01/05/2017 à 23:50, Enrico Forestieri a écrit : Is there a missing feature here? No, this is actually a feature. This allows you to overcome shortcomings of lyx that do not allow to otherwise obtain what you can directly get with latex. I see how this feature is useful, but it would be better to have math pasted as math and a "paste as text" command for what you describe. JMarc
Re: 2.3.0alpha1 tar balls are available
Le 24/04/2017 à 07:41, Scott Kostyshak a écrit :
The tar balls and sig files are here:
ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.3/lyx-2.3.0alpha1
Non-packagers, please do a quick test of compilation (from the tar ball)
and basic functionality on your platform, and let us know how it goes.
I get these warnings with Debian Jessie
1.2.5/mythes.cxx: In member function ‘int MyThes::thInitialize(const char*,
const char*)’:
1.2.5/mythes.cxx:51:29: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (idxsz <= 0 || idxsz > std::numeric_limits::max() /
sizeof(sizeof(char*))) {
^
1.2.5/mythes.cxx: In member function ‘int MyThes::Lookup(const char*, int,
mentry**)’:
1.2.5/mythes.cxx:179:36: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
if (nmeanings < 0 || nmeanings > std::numeric_limits::max() /
sizeof(mentry))
^
insets/InsetListingsParams.cpp: In constructor
‘lyx::{anonymous}::ParValidator::ParValidator()’:
insets/InsetListingsParams.cpp:297:1: note: variable tracking size limit
exceeded with -fvar-tracking-assignments, retrying without
ParValidator::ParValidator()
^
insets/InsetSpecialChar.cpp: In member function ‘virtual lyx::docstring
lyx::InsetSpecialChar::toolTip(const lyx::BufferView&, int, int) const’:
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘LDOTS’ not handled
in switch [-Wswitch]
switch (kind_) {
^
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘MENU_SEPARATOR’
not handled in switch [-Wswitch]
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘PHRASE_LYX’ not
handled in switch [-Wswitch]
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘PHRASE_TEX’ not
handled in switch [-Wswitch]
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘PHRASE_LATEX2E’
not handled in switch [-Wswitch]
insets/InsetSpecialChar.cpp:92:9: warning: enumeration value ‘PHRASE_LATEX’ not
handled in switch [-Wswitch]
Configuration
Host type: x86_64-pc-linux-gnu
Special build flags: build=prerelease std-regex warnings assertions
use-hunspell
Bundled libraries:boost mythes
C++ Compiler:g++ (4.9.2)
C++ Compiler flags: -Wall -Wextra -g -O2 -std=c++14
C++ Compiler user flags:
Linker flags:
Linker user flags:
Qt Frontend:
Qt version: 4.8.6
Packaging: posix
LyX binary dir: /usr/local/bin
LyX files dir: /usr/local/share/lyx-2.3.0alpha1
Thanks,
Scott
Crash with using lyx-function word-findadv
Start lyx select new file type anything e.g. 'abcd' Goto home position in minibuffer type word-findadv a Any (or no at all) parameter to this function leads to crash. This is independent of active search dialog. For comparision, the function 'word-find' does not crash, but doesn't find anything either. Kornel signature.asc Description: This is a digitally signed message part.
Re: [LyX/master] Cmake build: Correct suffixing on non-gcc-compilers
Am Dienstag, 2. Mai 2017 um 08:27:56, schrieb Stephan Witt > Am 02.05.2017 um 08:23 schrieb Kornel Benko : > > > > commit 0935f94f0d448c1a9b521e4825b30b94fe0521ff > > Author: Kornel Benko > > Date: Tue May 2 08:16:00 2017 +0200 > > > >Cmake build: Correct suffixing on non-gcc-compilers > > > >If the value LYX_PROGRAM_SUFFIX is not handled, we have to use > >LYX_PACKAGE_SUFFIX. > >The naming 'PACKAGE' in our sources is misleading, as it is used > >for the name of the debian/rpm packages as well. > > Are you confident it works with clang compilers as expected? > I’m not sure how to test that… > > Stephan For non-gcc compilers it the same as it was ever. We have LYX_OPTION(PROGRAM_SUFFIX "Append version suffix to binaries" ON GCC) in CMakeLists.txt. The macro LYX_OPTION in development/cmake/modules/LyXMacros.cmake handles the value LYX_PROGRAM_SUFFIX depending on value of CMAKE_COMPILER_IS_GNUCXX. I compiled with clang. So far on linux it seems to work. Tested with 'lyx2.3 -dbg files,locale', configured with -DLYX_LOCALVERSIONING=ON Kornel signature.asc Description: This is a digitally signed message part.
