Re: Using PGP keys to sign documents, helpful for needauth converters?

2020-07-08 Thread Richard Kimberly Heck
On 7/7/20 4:39 AM, Pavel Sanda wrote:
> On Mon, Jul 06, 2020 at 02:30:57PM -0400, Richard Kimberly Heck wrote:
>> Could we use the private key to put some kind of signature into the
>> header, along with an indication of what key is needed to verify it?
> We could just store in the header ascii-armorized signature from pgp
> of the .lyx file (without this section) and perhaps store fingerprint
> which would help with importing the public key of person who signed it.
>
> We should be however cautious whether we would automatize key
> retrieval - I would let the user handle the key retieval business
> on his own. There old keyservers are half-way broken method nowadays
> and many projects use different ways of distributing keys.

Yes, I was thinking NOT to automate that. People would need to import
keys manually if they wanted to do that. We could pop some kind of
message about what key needed importing. The idea here is just to make
it possible to mark documents as "safe", not to make it easy to mark
them as "safe". (I'm imagining some exploit that makes LyX import the
key of the attacker)

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Docbook 5 merged

2020-07-08 Thread Richard Kimberly Heck

First, let me add my congratulations to that of others. This really is
very nice work.

One thing that might be attractive to people is the possibility of using
DocBook 5 export possibly plus some XSLT or something of the sort to
produce ebooks. This has been much discussed on the user list. You might
see if Steve Litt is interested in this, in particular.

On 7/8/20 3:24 PM, Thibaut Cuvelier wrote:
> On Wed, 8 Jul 2020 at 15:01, Pavel Sanda  > wrote:
>
> There are several TODOs I see now:
>
There are some TODO files in the tree. (JMarc, do you have one with some
other name?) You could think of adding one. (We might also organize
these a bit better.)


> I'm adding a few other points (including a future roadmap):
> - Rewrite https://wiki.lyx.org/LyX/DocBook
> - Default output format (for the sake of completeness)

This is probably trivial. Look at how the LyXHTML format is handled in
lib/configure.py.


> - (For later:) add support for CALS tables (add a document-wise parameter)
> - (For much later): import DocBook documents — I'm not sure you can
> count on me for this…

That would be very much later! We can't do that now for anything but LaTeX.


> - If some other dev could at least quickly look through commit
> 3883b85f49054 , that would be appreciated, it's too long for one
> eyes only
> Apart from these, really good work Thibaut... 
>
>
> By the way, Guillaume already had a look at it before submission on
> the list :).

I had a look, though quickly as I was looking for whitespace issues. The
proof here will definitely be in use. It would be great if we could get
some testing. The XHTML code has some known issues. Hopefully, some of
these will have been fixed in the translation, but some of them will
probably linger. It is really, really hard to get the tag nesting right
all the time.

 

> - As with any new feature there are likely some hidden issues and
> we would benefit from docbook users feedback and I'm not sure how
> to proceed.
>   We could ask on users lists for the feedback (and perhaps
> persuade JMarc to release 2.4alpha1, which would be just quick
> technical preview with zero quality ensurance and sole purpose of
> testing docbook - so interested users do not need to compile?)
>
We have done some 'monthly' releases of this type. I'd be happy to
produce one, if it seems like a good idea.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1992

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1992/--
[...truncated 2110 lines...]
  GEN  moc_GuiThesaurus.cpp
  GEN  moc_GuiToc.cpp
  GEN  moc_GuiToolbar.cpp
  GEN  moc_GuiView.cpp
  GEN  moc_GuiViewSource.cpp
  GEN  moc_GuiVSpace.cpp
  GEN  moc_GuiWorkArea.cpp
  GEN  moc_GuiWrap.cpp
  GEN  moc_IconPalette.cpp
  GEN  moc_InGuiThread.cpp
  GEN  moc_InsertTableWidget.cpp
  GEN  moc_InsetParamsDialog.cpp
  GEN  moc_InsetParamsWidget.cpp
  GEN  moc_LayoutBox.cpp
  GEN  moc_LengthCombo.cpp
  GEN  moc_LyXFileDialog.cpp
  GEN  moc_Menus.cpp
  GEN  moc_PanelStack.cpp
  GEN  moc_TocModel.cpp
  GEN  moc_TocWidget.cpp
  GEN  moc_ToolTipFormatter.cpp
  GEN  moc_Validator.cpp
make  all-am
make[7]: Entering directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends/qt'
  CXX  ButtonPolicy.o
  CXX  Dialog.o
  CXX  Action.o
  CXX  BulletsModule.o
  CXX  ButtonController.o
  CXX  CategorizedCombo.o
  CXX  ColorCache.o
  CXX  CustomizedWidgets.o
  CXX  DialogView.o
  CXX  DockView.o
  CXX  EmptyTable.o
  CXX  FancyLineEdit.o
  CXX  FileDialog.o
  CXX  FindAndReplace.o
  CXX  FloatPlacement.o
  CXX  GuiAbout.o
  CXX  GuiAlert.o
  CXX  GuiApplication.o
  CXX  GuiBibitem.o
  CXX  GuiBibtex.o
  CXX  GuiBox.o
  CXX  GuiBranch.o
  CXX  GuiBranches.o
  CXX  GuiChanges.o
  CXX  GuiCharacter.o
  CXX  GuiCitation.o
  CXX  GuiClickableLabel.o
  CXX  GuiClipboard.o
  CXX  GuiCommandBuffer.o
  CXX  GuiCommandEdit.o
  CXX  GuiCompare.o
  CXX  GuiCompareHistory.o
  CXX  GuiCompleter.o
  CXX  GuiCounter.o
  CXX  GuiDelimiter.o
  CXX  GuiDialog.o
  CXX  GuiDocument.o
  CXX  GuiErrorList.o
  CXX  GuiERT.o
  CXX  GuiExternal.o
  CXX  GuiFontExample.o
  CXX  GuiFontLoader.o
  CXX  GuiFontMetrics.o
  CXX  GuiGraphics.o
  CXX  GuiHSpace.o
  CXX  GuiHyperlink.o
  CXX  GuiIdListModel.o
  CXX  GuiImage.o
  CXX  GuiInclude.o
  CXX  GuiIndex.o
  CXX  GuiIndices.o
  CXX  GuiInfo.o
  CXX  GuiKeySymbol.o
  CXX  GuiLabel.o
  CXX  GuiLine.o
  CXX  GuiListings.o
  CXX  GuiLog.o
  CXX  GuiLyXFiles.o
  CXX  GuiMathMatrix.o
  CXX  GuiNomenclature.o
  CXX  GuiNote.o
  CXX  GuiPainter.o
  CXX  GuiParagraph.o
  CXX  GuiPhantom.o
  CXX  GuiPrefs.o
  CXX  GuiPrintindex.o
  CXX  GuiPrintNomencl.o
  CXX  GuiProgress.o
  CXX  GuiProgressView.o
  CXX  GuiRef.o
  CXX  GuiSearch.o
  CXX  GuiSelection.o
  CXX  GuiSelectionManager.o
  CXX  GuiSendto.o
  CXX  GuiSetBorder.o
  CXX  GuiShowFile.o
  CXX  GuiSpellchecker.o
  CXX  GuiSymbols.o
  CXX  GuiTabular.o
  CXX  GuiTabularCreate.o
  CXX  GuiTexinfo.o
  CXX  GuiThesaurus.o
  CXX  GuiToc.o
  CXX  GuiToolbar.o
  CXX  GuiView.o
  CXX  GuiViewSource.o
  CXX  GuiVSpace.o
  CXX  GuiWorkArea.o
  CXX  GuiWrap.o
  CXX  IconPalette.o
  CXX  InGuiThread.o
  CXX  InsertTableWidget.o
  CXX  InsetParamsDialog.o
  CXX  InsetParamsWidget.o
  CXX  LengthCombo.o
  CXX  LyXFileDialog.o
  CXX  LaTeXHighlighter.o
  CXX  LayoutBox.o
  CXX  Menus.o
  CXX  PanelStack.o
  CXX  qt_helpers.o
  CXX  TocModel.o
  CXX  TocWidget.o
  CXX  Toolbars.o
  CXX  ToolTipFormatter.o
  CXX  Validator.o
  AR   liblyxqt.a
make[7]: Leaving directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends/qt'
make[6]: Leaving directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends/qt'
Making all in .
make[6]: Entering directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends'
  CXX  WorkAreaManager.o
  AR   liblyxfrontends.a
make[6]: Leaving directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends'
make[5]: Leaving directory 
'/build/workspace/lyx-2.4.0dev/_build/sub/src/frontends'
Making all in .
make[5]: Entering directory '/build/workspace/lyx-2.4.0dev/_build/sub/src'
  CXX  Author.o
  CXX  boost.o
  CXX  BranchList.o
  CXX  Buffer.o
  CXX  buffer_funcs.o
  CXX  BufferList.o
  CXX  BufferParams.o
  CXX  BufferView.o
  CXX  Bullet.o
  CXX  Changes.o
  CXX  Chktex.o
  CXX  CiteEnginesList.o
  CXX  CmdDef.o
  CXX  Color.o
  CXX  ConverterCache.o
  CXX  Converter.o
  CXX  CoordCache.o
  CXX  Counters.o
  CXX  Cursor.o
  CXX  CursorSlice.o
  CXX  CutAndPaste.o
  CXX  DepTable.o
  CXX  DocIterator.o
  CXX  Encoding.o
  CXX  BufferEncodings.o
  CXX  ErrorList.o
  CXX  Exporter.o
  CXX  factory.o
  CXX  Floating.o
  CXX  FloatList.o
  CXX  FontInfo.o
  CXX  FontList.o
  CXX  Font.o
  CXX  Format.o
  

Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 14:54, Jean-Marc Lasgouttes 
wrote:

> Item 1 is about checking return of regex_match
>
> Item 2 is probably fixed by an earlier definition of the "label" variable
>

Here are two patches, one per item. I also included Kornel's comment about
std::regex_match.


0001-Update-RELEASE-NOTES-for-DocBook.patch
Description: Binary data


0002-Fix-Coverity-false-positive-for-null-pointer-derefer.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Thibaut Cuvelier
It looks fine, thanks!

Thibaut Cuvelier


On Thu, 9 Jul 2020 at 00:46, Pavel Sanda  wrote:

> On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote:
> > > Good, do you have idea on top of which commit this was written (even
> > > approximate date would be helpful).
> > >
> >
> > The last commit before modifying this file dates back to October 2017:
> >
> https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2
>
> Thanks, Customization Manual should be hopefully ok now. P
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Docbook 5 merged

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:24:46PM +0200, Thibaut Cuvelier wrote:
> > - As with any new feature there are likely some hidden issues and we would
> > benefit from docbook users feedback and I'm not sure how to proceed.
> >   We could ask on users lists for the feedback (and perhaps persuade JMarc
> > to release 2.4alpha1, which would be just quick technical preview
> >   with zero quality ensurance and sole purpose of testing docbook - so
> > interested users do not need to compile?)
> >   Maybe you have better idea though.
> >
> 
> I can also reach out to DocBook-related mailing lists, in case someone
> there has interest in LyX. D-BookeR's Patricia could also be interested in
> testing this (and having binaries for them would be really very
> appreciated!).

Ok lets give it week to stabilize issues which are just popping now on the list
and then we'll ask JMarc for alpha tarball and Eugene for Win binary so 
interested
folks can give it a try...
Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote:
> > Good, do you have idea on top of which commit this was written (even
> > approximate date would be helpful).
> >
> 
> The last commit before modifying this file dates back to October 2017:
> https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2

Thanks, Customization Manual should be hopefully ok now. P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 23:55:28 +0200
schrieb Pavel Sanda :

> On Wed, Jul 08, 2020 at 09:32:26PM +0200, Kornel Benko wrote:
> > This patch fixes it.  
> 
> Nice catch! Please commit. P

OK, done.

Kornel


pgpvPeZG_UN19.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:32:26PM +0200, Kornel Benko wrote:
> This patch fixes it.

Nice catch! Please commit. P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Text selection does not work as expected

2020-07-08 Thread Scott Kostyshak
On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote:

> Here we go, patch attached. I decided to put Qt version check 5.10.1,
> because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and
> the bug was not there yet.

Your patch is perfect, Eugene. Thanks! Please commit.

One minor typo: "wuickly" should be "quickly".

Thanks for your Qt bug report. I know it takes time to make a minimal
example and post it. It looks like they're taking a look and already
it's good to know that it can't be reproduced on macOS.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 14:28:23 +0200
schrieb Kornel Benko :

> Am Wed, 8 Jul 2020 13:54:18 +0200
> schrieb Pavel Sanda :
> 
> > On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote:  
> > > All of the failed tests fail in style 'Description', defined probably in
> > > stdlists.inc. Roundtrip fails because of missing entry 'DocBookItemTag
> > > listitem'.
> > 
> > Do you know what is this 'Roundtrip' test suppose to test? P  
> 
> Not exactly.
> 
> Source: src/tests/check_layout.cpp
> 
> Looks like the interpreted data of input layout have an extra line (not found 
> in input)
> 
> input:
>   ...
> HTMLTitle 0
> DocBookTag variablelist
> DocBookItemTag varlistentry
> DocBookItemLabelTag term
> DocBookItemInnerTag para
> Spellcheck 1
> Interpreted:
>   ...
> HTMLTitle 0
> DocBookTag variablelist
> DocBookItemTag listitem
> DocBookItemTag varlistentry
> DocBookItemLabelTag term
> DocBookItemInnerTag para
> Spellcheck 1
> 
>   Kornel

This patch fixes it.

Kornel
diff --git a/src/Layout.cpp b/src/Layout.cpp
index 04cd74792f..c45fd5c101 100644
--- a/src/Layout.cpp
+++ b/src/Layout.cpp
@@ -1605,11 +1605,11 @@ void Layout::write(ostream & os) const
 	if(!docbookitemtag_.empty())
 		os << "\tDocBookItemTag " << docbookitemtag_ << '\n';
 	if(!docbookitemattr_.empty())
 		os << "\tDocBookItemAttr " << docbookitemattr_ << '\n';
 	if(!docbookitemwrappertag_.empty())
-		os << "\tDocBookItemTag " << docbookitemwrappertag_ << '\n';
+		os << "\tDocBookItemWrapperTag " << docbookitemwrappertag_ << '\n';
 	if(!docbookitemwrapperattr_.empty())
 		os << "\tDocBookItemWrapperAttr " << docbookitemwrapperattr_ << '\n';
 	if(!docbookitemlabeltag_.empty())
 		os << "\tDocBookItemLabelTag " << docbookitemlabeltag_ << '\n';
 	if(!docbookitemlabelattr_.empty())


pgpRmU6CZunKa.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Docbook 5 merged

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 15:01, Pavel Sanda  wrote:

> There are several TODOs I see now:
>

I'm adding a few other points (including a future roadmap):
- Rewrite https://wiki.lyx.org/LyX/DocBook
- Default output format (for the sake of completeness)
- (For later:) add support for CALS tables (add a document-wise parameter)
- (For much later): import DocBook documents — I'm not sure you can count
on me for this…


> - Add entries into various sections of RELEASE-NOTES, these should contain:
>   - New output target for Docbook 5
>   - Files gone (examples/layouts)
>   - Warning that ppl. using archaic Docbook 4 document need to manually
> convert them, because layouts are gone
>   - External deps. changed  - we do not use sgmltools anymore,
> distribution packagers can drop these
>

There is a patch attached for this. Comments welcome :).


> - Add promo section about Docbbok 5 to https://wiki.lyx.org/LyX/NewInLyX24,
> explaining whats new compared to outdated D4 sgml backend (somewhere to the
> top, this is a major thing).
>

I did something on the wiki. As it does not require file format changes
(except in layouts), I put it in the second part of the page.


> - If some other dev could at least quickly look through commit
> 3883b85f49054 , that would be appreciated, it's too long for one eyes only
> Apart from these, really good work Thibaut...


By the way, Guillaume already had a look at it before submission on the
list :).


> - As with any new feature there are likely some hidden issues and we would
> benefit from docbook users feedback and I'm not sure how to proceed.
>   We could ask on users lists for the feedback (and perhaps persuade JMarc
> to release 2.4alpha1, which would be just quick technical preview
>   with zero quality ensurance and sole purpose of testing docbook - so
> interested users do not need to compile?)
>   Maybe you have better idea though.
>

I can also reach out to DocBook-related mailing lists, in case someone
there has interest in LyX. D-BookeR's Patricia could also be interested in
testing this (and having binaries for them would be really very
appreciated!).


> - Two already known issues - fix documentation and tests, please see other
> mails...
>

Documentation is in progress, thanks Pavel :)! For tests, I'll have a look
later.


0001-Update-RELEASE-NOTES-for-DocBook.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 19:56, Pavel Sanda  wrote:

> On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote:
> > > > Here is the updated version of the manual and the corresponding
> patch. It
> > > > should apply cleanly, now (even though I don't get why it's that
> > > large???)!
> > >
> > > I don't want updated version. I want some very old one where you did
> not
> > > made any
> > > git merging or rebasing.
> > >
> >
> >  Here is a very old copy, I've updated it so that it reflects the current
> > state of the code. Is it good enough?
>
> Good, do you have idea on top of which commit this was written (even
> approximate
> date would be helpful).
>

The last commit before modifying this file dates back to October 2017:
https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1991

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1991/--
[...truncated 1132 lines...]
  CXX  insets/InsetSpace.o
  CXX  insets/InsetSpecialChar.o
  CXX  insets/InsetTabular.o
  CXX  insets/InsetText.o
  CXX  insets/InsetTOC.o
  CXX  insets/InsetVSpace.o
  CXX  insets/InsetWrap.o
  AR   liblyxinsets.a
  CXX  main.o
  CXX  BiblioInfo.o
  CXX  Box.o
  CXX  Compare.o
  CXX  Dimension.o
  CXX  EnchantChecker.o
  CXX  PersonalWordList.o
  CXX  LaTeXFonts.o
  CXX  Thesaurus.o
  CXXLDlyx
make[4]: Leaving directory '/build/workspace/src'
Making all in client
make[4]: Entering directory '/build/workspace/src/client'
  CXX  boost.o
  CXX  client.o
  CXXLDlyxclient
make[4]: Leaving directory '/build/workspace/src/client'
Making all in tex2lyx
make[4]: Entering directory '/build/workspace/src/tex2lyx'
  CXX  boost.o
  CXX  Context.o
  CXX  dummy_impl.o
  CXX  math.o
  CXX  Parser.o
  CXX  Preamble.o
  CXX  table.o
  CXX  tex2lyx.o
  CXX  text.o
  CXXLDtex2lyx
make[4]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in convert
make[4]: Entering directory '/build/workspace/src/convert'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/build/workspace/src/convert'
make[3]: Leaving directory '/build/workspace/src'
make[2]: Leaving directory '/build/workspace/src'
Making all in sourcedoc
make[2]: Entering directory '/build/workspace/sourcedoc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/sourcedoc'
Making all in lib
make[2]: Entering directory '/build/workspace/lib'
Making all in doc
make[3]: Entering directory '/build/workspace/lib/doc'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/doc'
Making all in lyx2lyx
make[3]: Entering directory '/build/workspace/lib/lyx2lyx'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/lyx2lyx'
make[3]: Entering directory '/build/workspace/lib'
  GEN  lyx.desktop
  GEN  lyx.png
  GEN  lyx.svg
make[3]: Leaving directory '/build/workspace/lib'
make[2]: Leaving directory '/build/workspace/lib'
Making all in src/client
make[2]: Entering directory '/build/workspace/src/client'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/client'
Making all in src/tex2lyx
make[2]: Entering directory '/build/workspace/src/tex2lyx'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in src/convert
make[2]: Entering directory '/build/workspace/src/convert'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/convert'
make[2]: Entering directory '/build/workspace'
make[2]: Leaving directory '/build/workspace'
make[1]: Leaving directory '/build/workspace'
# Executing: make check
Making check in autotests
make[1]: Entering directory '/build/workspace/autotests'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/autotests'
Making check in config
make[1]: Entering directory '/build/workspace/config'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/config'
Making check in development
make[1]: Entering directory '/build/workspace/development'
make[2]: Entering directory '/build/workspace/development'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/development'
make[1]: Leaving directory '/build/workspace/development'
Making check in po
make[1]: Entering directory '/build/workspace/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/po'
Making check in 3rdparty
make[1]: Entering directory '/build/workspace/3rdparty'
make[2]: Entering directory '/build/workspace/3rdparty'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/3rdparty'
make[1]: Leaving directory '/build/workspace/3rdparty'
Making check in src
make[1]: Entering directory '/build/workspace/src'
  CHK  lyx_commit_hash.h
make  check-recursive
make[2]: Entering directory '/build/workspace/src'
Making check in support
make[3]: Entering directory '/build/workspace/src/support'
make  check-am
make[4]: Entering directory '/build/workspace/src/support'
make  check_convert check_filetools check_lstrings check_trivstring
make[5]: Entering directory '/build/workspace/src/support'
  CXX  tests/check_convert.o
  CXX  tests/dummy_functions.o
  CXX  tests/boost.o
  CXXLDcheck_convert
  CXX  tests/check_filetools.o
  CXXLDcheck_filetools
  CXX  tests/check_lstrings.o
  CXXLDcheck_lstrings
  CXX  tests/check_trivstring.o
  CXXLDcheck_trivstring
make[5]: Leaving directory '/build/workspace/src/support'
make  check-TESTS
make[5]: Entering directory 

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote:
> > > Here is the updated version of the manual and the corresponding patch. It
> > > should apply cleanly, now (even though I don't get why it's that
> > large???)!
> >
> > I don't want updated version. I want some very old one where you did not
> > made any
> > git merging or rebasing.
> >
> 
>  Here is a very old copy, I've updated it so that it reflects the current
> state of the code. Is it good enough?

Good, do you have idea on top of which commit this was written (even approximate
date would be helpful).

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Text selection does not work as expected

2020-07-08 Thread Yu Jin
Am Sa., 4. Juli 2020 um 22:02 Uhr schrieb Scott Kostyshak :

> On Sat, Jul 04, 2020 at 07:50:18PM +0200, Yu Jin wrote:
> > Am Sa., 4. Juli 2020 um 17:16 Uhr schrieb Scott Kostyshak <
> skost...@lyx.org
> > >:
> >
> > >
> > > Thanks for looking into this, Eugene. Just to make sure I understand,
> > > you think this is a Qt bug, right? I don't know anything about this
> > >
> >
> > It looks like a Qt bug indeed, I have reported it on Qt bugtracker.
>
> Great, thanks for doing that. I suggest to put the URL to the Qt bug
> report when you commit.
>
> > But to
> > clarify, the bug occurs only on touchpads (not on Windows 10 in general).
> > I have tested an older LyX version on my notebook, 2.3.1 (with Qt 5.10.1)
> > -> no bug. The newer LyX versions, which come with Qt 5.12.5 and also my
> > latest betainstaller, where I used Qt 5.15.0, do have that bug, therefore
> > it seems like a Qt bug.
> >
> >
> > > stuff, so hopefully a different LyX developer takes a look. Don't spend
> > > time making a new patch based on my comments (wait for another LyX dev
> > > first), but if you do get a +1 to commit, it would be nice to mark
> > > exactly what parts of the code are in there because of a workaround for
> > > a Qt bug, and how to test that the bug is no longer relevant (e.g., "to
> > > test if this workaround is still needed, try to select a word by
> > > double-clicking in LyX on Windows 10. For more information, see the
> > > following ML thread...").
> > >
> > > Taking a step back, what changed that triggered this bug? I'm guessing
> > > that it is because we compiled LyX 2.3.5 with a newer Qt version. Is
> that
> > > correct? Is it worth compiling 2.3.4 on your machine to double-check
> that
> > > you *can* reproduce the bug (since using a newer Qt version)? What Qt
> > > version was 2.3.4 compiled with? I personally would support putting the
> > > added lines in preprocessor guards but I don't know how other LyX
> > > developers feel about that. Here is the flavor of preprocessor checking
> > > that I think is easiest:
> > >
> >
> > I have compiled master with Qt 5.15.0 on my machine, resulting in the bug
> > occuring. Compiling master with Qt 5.9.9 (I could not download 5.10.1, to
> > match what is used in the LyX version I have tried above, for some
> reason)
> > didn't produce the bug.
>
> Thanks for those checks.
>
> > > #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
> > >// code here...
> > > #endif
> >
> >
> > I see and understand now that workarounds for Qt bugs are not easy to
> > handle. Also I can't predict when or if the bug will be fixed in Qt. So
> > what is attached is what I can provide for now, maybe other developers
> have
> > more experience or better ideas?
>
> So something like the following could work (but I haven't tested):
>
> #if (QT_VERSION > QT_VERSION_CHECK(5, 9, 9))
>// we do not see the bug with 5.9.9 and do see it with 5.15.0
>// Qt bug report: 
>...
> #endif
>
> > Btw do we have some kind of tracker for
> > this kind of issues?
>
> I think in trac we have (or at least had) a keyword "qtbug". But we were
> never too careful about using it.
>
> If no one else responds within a couple of days, if you make a patch
> with the Qt version guards, I think I would feel comfortable taking a
> closer look and would likely give a +1.
>

Here we go, patch attached. I decided to put Qt version check 5.10.1,
because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and
the bug was not there yet.

Eugene


MouseMoveEvent.diff
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 04:27:30PM +0200, Thibaut Cuvelier wrote:
> On Wed, 8 Jul 2020 at 14:38, Pavel Sanda  wrote:
> 
> > On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote:
> > > commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2
> > > Author: Thibaut Cuvelier 
> > > Date:   Fri May 10 02:54:44 2019 +0200
> > >
> > > Add documentation for the new layout attributes.
> >
> > Thibaut, this patch broke the manual (likely wrong merge from some changes
> > already committed to master.) I already reverted it.
> >
> > Can you send either pacth which works or old version of your manual
> > which was fully working, I can do careful merge.
> >
> 
> Here is the updated version of the manual and the corresponding patch. It
> should apply cleanly, now (even though I don't get why it's that large???)!

I don't want updated version. I want some very old one where you did not made 
any 
git merging or rebasing.

The current version spits on console stuff like

Text.cpp (1939): Handling unknown body token: `\change_inserted'
Text.cpp (1939): Handling unknown body token: `1075283030 1557448766'
Text.cpp (1939): Handling unknown body token: `\end_layout'
Paragraph ended in line 28725
Missing \end_layout.

which means the patching mechanism sorted out things wrongly.
Also if you look carefully you have doubled entries for 
DocBookRoot/DocBookForceAbstract.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools #1782

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1782/
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Richard Kimberly Heck
On 7/8/20 11:28 AM, Jean-Marc Lasgouttes wrote:
> Le 08/07/2020 à 14:53, Jean-Marc Lasgouttes a écrit :
>> Hello,
>>
>> More work for Thibaut :) I ran coverity against master and here is
>> what it returns (below).
>
> Now I tried clang 10 and I get the following 2 warnings. Besides the
> overloading problem, the indentation issue seems to be related with
> the fact that you use spaces as indentation, whereas we use tabs.
>
> I am not sure what is the best way to fix indentation now that the
> patches are in. Ideas?

Most of it is fine, actually. There are isolated instances of spaces.
I'll see if I can find them.

Riki


>
> In file included from ../../master/src/factory.cpp:29:
> ../../master/src/insets/InsetCounter.h:42:7: warning:
> 'lyx::InsetCounter::docbook' hides overloaded virtual function
> [-Woverloaded-virtual]
>     void docbook(odocstream &, OutputParams const &) const;
>  ^
> ../../master/src/insets/InsetCommand.h:92:7: note: hidden overloaded
> virtual function 'lyx::InsetCommand::docbook' declared here: type
> mismatch at 1st parameter ('lyx::XMLStream &' vs 'lyx::odocstream &'
> (aka 'basic_ostream > &'))
>     void docbook(XMLStream &, OutputParams const &) const;
>  ^
> 1 warning generated.
> ../../master/src/output_docbook.cpp:363:10: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>     if (!special_case && firstInset->lyxCode() ==
> lyx::LISTINGS_CODE)
>     ^
> ../../master/src/output_docbook.cpp:359:13: note: previous statement
> is here
>     if (!special_case && firstInset->lyxCode() == lyx::ERT_CODE)
>     ^
> 1 warning generated.


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Wininstaller, fix bug where previous installations, with emergency version greater than 1, could not be seen in registry on overinstall

2020-07-08 Thread Richard Kimberly Heck
On 7/7/20 3:55 PM, Yu Jin wrote:
> Am Di., 7. Juli 2020 um 21:29 Uhr schrieb Richard Kimberly Heck
> mailto:rikih...@lyx.org>>:
>
> On 7/7/20 3:19 PM, Yu Jin wrote:
>> Am Di., 7. Juli 2020 um 21:14 Uhr schrieb Eugene Chornyi
>> mailto:yu_...@lyx.org>>:
>>
>> commit 32e501a282a3c9e83181979c32bf9b9cde79e43f
>> Author: Eugene Chornyi mailto:yu_...@lyx.org>>
>> Date:   Tue Jul 7 21:13:34 2020 +0200
>>
>>     Wininstaller, fix bug where previous installations, with
>> emergency version greater than 1, could not be seen in
>> registry on overinstall
>> ---
>>  .../Win32/packaging/installer/include/init.nsh     |    8
>> ++--
>>  1 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git
>> a/development/Win32/packaging/installer/include/init.nsh
>> b/development/Win32/packaging/installer/include/init.nsh
>> index 76bacd5..bdbb495 100644
>> --- a/development/Win32/packaging/installer/include/init.nsh
>> +++ b/development/Win32/packaging/installer/include/init.nsh
>> @@ -660,13 +660,17 @@ Function .onInit
>>      ReadRegStr $0 HKLM
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$5"
>> "DisplayVersion"
>>      # also check for an emergency release
>>      ${if} $0 == ""
>> -     ReadRegStr $0 HKLM
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$51"
>> "DisplayVersion"
>> +     ${For} $7 0 20
>> +      ReadRegStr $0 HKLM
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$5$7"
>> "DisplayVersion"
>> +     ${Next}
>>      ${endif}
>>     ${else}
>>      ReadRegStr $0 HKCU
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$5"
>> "DisplayVersion"
>>      # also check for an emergency release
>>      ${if} $0 == ""
>> -     ReadRegStr $0 HKCU
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$51"
>> "DisplayVersion"
>> +     ${For} $7 0 20
>> +      ReadRegStr $0 HKCU
>> 
>> "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}${APP_VERSION_MAJOR}${APP_VERSION_MINOR}$5$7"
>> "DisplayVersion"
>> +     ${Next}
>>      ${endif}
>>     ${endif}
>>     ${if} $0 != ""
>> -- 
>> lyx-cvs mailing list
>> lyx-...@lists.lyx.org 
>> http://lists.lyx.org/mailman/listinfo/lyx-cvs
>>
>>
>> This is the fix from the recent report in the devel ML. OK to
>> commit to stable?
>
> OK. Remember to add a note to status.23x.
>
> Done, I hope I did it right, but looks good.

Perfect!

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling and using master on macOS

2020-07-08 Thread racoon



On 2020-07-08 08:28, Stephan Witt wrote:

Am 07.07.2020 um 07:35 schrieb Daniel :


On 2020-07-07 07:30, Daniel wrote:

On 2020-07-07 00:24, Stephan Witt wrote:

Am 06.07.2020 um 09:59 schrieb Daniel :


On 2020-03-15 21:37, Stephan Witt wrote:

Am 15.03.2020 um 17:16 schrieb Daniel :


Hi,

I am about to try compiling and using master on macOS. I just has a look at 
INSTALL.MacOSX. It mentions Qt version 4. That seems a bit outdated. But I 
guess that I am looking at the latest guide to compile on macOS, right?

Yes, it’s outdated. It should work with Qt4 - but Qt4 cannot be used on recent 
macOS.
Basically I’m using the script LyX-Mac-binary-release.sh in development folder. 
That’s much easier than other options, IMO.
First step is to install Xcode and the automake and/or cmake utilities. This 
can be done with macports or homebrew. I’m using macports.
Second step is to get Qt5 - as source or binary distribution. I’m using the 
source tarball and build Qt5 myself.
Optional components are the spell checker and libmagic frameworks.
Finally I start development/LyX-Mac-binary-release.sh with
--enable-cxx11
--with-qt-dir=/path/to/qt5
Stephan


Thanks. Finally came around trying it on macOS. I take it one has to run the 
last command with sh, right? So, from the lyx directory (in the lyxgit 
directory) I execute

sh development/LyX-Mac-binary-release.sh --enable-cxx11 
--with-qt-dir=/Users//Qt/5.9.9

(where I replace  by my macOS user name. Unfortunately, I get the 
following:

: command not found-binary-release.sh: line 2:
: command not found-binary-release.sh: line 4:
: command not found-binary-release.sh: line 9:
: command not found-binary-release.sh: line 19:
: command not found-binary-release.sh: line 23:
: command not found-binary-release.sh: line 27:
': not a valid identifiery-release.sh: line 28: unset: `LD_LIBRARY_PATH
: command not found-binary-release.sh: line 29:
: command not found-binary-release.sh: line 44:
: command not found-binary-release.sh: line 49:
development/LyX-Mac-binary-release.sh: line 53: syntax error near unexpected 
tok'n `in
'evelopment/LyX-Mac-binary-release.sh: line 53: `case "${QtVersion}:${QtAPI}" in

By the way, if finally successful, where will this put the LyX.app?

Daniel


I’ve made a protocol of the steps I took to build the package on a new system. 
See the attached log. Probably the crucial thing is the mklyx-2.3.4.3.sh script.

I’m used to configure and build LyX out of source. I have a working directory 
with one or more versions of LyX source code and a directory lyx-build for the 
results. For Qt I have a source directory and an install target in parallel, 
the build directory is in lyx-build.

$ ls /Users/Shared/LyX
lyx-2.3.4.3 (source)
lyx-2.3.5.2 (source)
lyx-build (directory)
qt-5.9.9-frameworks-cocoa-x86_64  (QTDIR for 5.9.9)
qt-everywhere-opensource-src-5.9.9 (source)

The lyx-build contains the build directory, the installed package (LyX.app) and 
the resulting disk image.

$ ls /Users/Shared/LyX/
LyX-2.3.4.3+qt5-x86_64-cocoa.dmg (disk image)
LyX-2.3.4.3.app (working app)
LyX-2.3.4.3.build (binaries)
LyX-2.3.5.2+qt5-x86_64-cocoa.dmg (disk image)
LyX-2.3.5.2.app (working app)
LyX-2.3.5.2.build (binaries)
qt-5.9.9-build-x86_64 (binaries)

The /bin/sh on a Mac is in fact a bash, IMO.

Stephan



I am using git to download the lyx source and qt installer. But the steps 
should be the same except for the unpacking and setting my own directories, 
right?
Also what does
osascript -e 'tell application "Finder" to display notification "LyX is great 
stuff"'
do? It looks strange.
Daniel


Okay, I guess it can't be the same because there is a specific LyX version 
mentioned (2.3.4.3). What would I use if I want to compile from git (master)?


Yes, that’s true - this is the build from the shipped tar file for 2.3.4.3. But 
it works for git clones too.

The difference to master is the name of the directory and this is your choice. 
I’m using „lyx“ for it. I have another git clone for stable named „lyx-2.3.x“.

The resulting applications are placed in lyx-build and named according to the 
AC_INIT macro in configure.ac (e.g. LyX,2.4.0dev => LyX-2.4.0dev.app).

In case you want to do the single steps w/o the build script you may try the 
following:

1. create a dedicated build dir - e.g. lyx-build/master

2. create or update the configure script - run autogen.sh in your git checkout 
(in place)


In this step I get:

% sh autogen.sh
: command not found
: command not found
: command not found:
'utogen.sh: line 18: syntax error near unexpected token `in
'utogen.sh: line 18: `case $automake_version in

I guess it does not fails for some reason?

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes

Le 08/07/2020 à 14:53, Jean-Marc Lasgouttes a écrit :

Hello,

More work for Thibaut :) I ran coverity against master and here is what 
it returns (below).


Now I tried clang 10 and I get the following 2 warnings. Besides the 
overloading problem, the indentation issue seems to be related with the 
fact that you use spaces as indentation, whereas we use tabs.


I am not sure what is the best way to fix indentation now that the 
patches are in. Ideas?


JMarc


In file included from ../../master/src/factory.cpp:29:
../../master/src/insets/InsetCounter.h:42:7: warning: 
'lyx::InsetCounter::docbook' hides overloaded virtual function 
[-Woverloaded-virtual]

void docbook(odocstream &, OutputParams const &) const;
 ^
../../master/src/insets/InsetCommand.h:92:7: note: hidden overloaded 
virtual function 'lyx::InsetCommand::docbook' declared here: type 
mismatch at 1st parameter ('lyx::XMLStream &' vs 'lyx::odocstream &' 
(aka 'basic_ostream > &'))

void docbook(XMLStream &, OutputParams const &) const;
 ^
1 warning generated.
../../master/src/output_docbook.cpp:363:10: warning: misleading 
indentation; statement is not part of the previous 'if' 
[-Wmisleading-indentation]
if (!special_case && firstInset->lyxCode() == 
lyx::LISTINGS_CODE)

^
../../master/src/output_docbook.cpp:359:13: note: previous statement is here
if (!special_case && firstInset->lyxCode() == lyx::ERT_CODE)
^
1 warning generated.
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New DocBook support

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 15:48, Pavel Sanda  wrote:

> On Wed, Jul 08, 2020 at 03:44:01PM +0200, Thibaut Cuvelier wrote:
> > I don't exactly know where to submit this, so here it is: another patch
> to
> > clean up. This should remove support for DeclareDocBookClass in layouts,
> as
> > it's no more useful.
>
> it's in. p
>

That's efficient :)!
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New DocBook support

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 03:44:01PM +0200, Thibaut Cuvelier wrote:
> I don't exactly know where to submit this, so here it is: another patch to
> clean up. This should remove support for DeclareDocBookClass in layouts, as
> it's no more useful.

it's in. p
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New DocBook support

2020-07-08 Thread Thibaut Cuvelier
On Fri, 26 Jun 2020 at 18:56, Thibaut Cuvelier  wrote:

> Dear list,
>
> Here is the complete set of patches for the new DocBook implementation
> I've been working on for the last few years. It is a complete overhaul of
> the existing DocBook implementation, with a completely different mindset:
> the goal is to be able to convert almost any LyX document into DocBook, not
> only those that follow the DocBook templates. It works pretty well for now:
> D-BookeR (https://www.d-booker.fr/) can use it to convert a 200-A4-page
> LyX book into DocBook and use it in their toolchains (minus specificities
> for D-BookeR's use of DocBook, with many tags disabled).
>
> (This is a follow-up to https://www.lyx.org/trac/ticket/8444, cleanly
> divided in several patches and reviewed by Guillaume.)
>
> These patches apply cleanly on 4dc33e52f8c5b4a4c31e05da09ccb1dfb627e5cb
> (you can have a look at
> https://gitlab.com/gadmm/lyx-unstable/-/merge_requests/3). Guillaume
> reviewed it all, except the Python parts (they are quite small). It relies
> on the patches I recently submitted for XMLStream and MathML improvements.
> This contribution also includes documentation for the new layout parts, and
> a few test cases (both LyX documents and their reference DocBook
> translation). The division in patches is designed so that the code base
> remains compilable between patches.
>
> There are still a few points to discuss. More specifically:
> - documents are supposed to only contain one bibliography, at the very
> end. Other cases will probably lead to invalid DockBook. In DocBook, a
> bibliography is supposed to be either at the beginning or at the end of a
> book/part/chapter/section; it is not always clear at which level the
> bibliography should be output
> - handling subfigures is currently implemented in a suboptimal way:
> InsetFloat looks specifically for a given kind of pattern of insets in the
> LyX document (https://wiki.lyx.org/FAQ/FiguresSideBySide). Guillaume
> would have rather seen gathering information in OutputParams, but the
> implementation would be far from straightforward...
> - similarly, for floats, the DocBook tags for the floats and the captions
> are hard-coded in the Floating class, and not in the layouts. It is
> unlikely that this part should be overridden by other document
> classes/modules. The only missing part is algorithms, which are not handled
> by DocBook for now (but they may in the future:
> https://github.com/docbook/docbook/issues/157). Or am I missing other
> kinds of floats?
>
> Only the "main" DocBook vocabulary is implemented (the one that is being
> normalised by OASIS, the major standard body for XML-based things). The
> output requires DocBook 5.2 (which is not yet released), due to support for
> subfigures (other documents are compatible with 5.0): I had to ask the
> DocBook committee to include it at some point for this project. There is no
> option to output simplified DocBook (
> https://docbook.org/schemas/5x-custom.html#simple); Beamer documents are
> not translated to DocBook Slides (
> https://docbook.org/schemas/5x-custom.html#slides). These two variants
> are unofficial, and could be implemented in the future (I did not look at
> them to see how complex it would be).
>
> If anything could help you review this, let me know!
>
> All the best,
> Thibaut Cuvelier
>

I don't exactly know where to submit this, so here it is: another patch to
clean up. This should remove support for DeclareDocBookClass in layouts, as
it's no more useful.


0001-Clean-up-DeclareDocBookClass.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes

Le 08/07/2020 à 15:32, Kornel Benko a écrit :

I wonder why the use of std::regex_match()?

We use
#include "support/regex.h"
the correct is either
lyx::regex_match()
or
regex_match()
in the lyx namespace.



Very good point. We use the second form in the source.

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Docbook 5 merged

2020-07-08 Thread Jean-Marc Lasgouttes

Le 08/07/2020 à 15:00, Pavel Sanda a écrit :

- As with any new feature there are likely some hidden issues and we would 
benefit from docbook users feedback and I'm not sure how to proceed.
   We could ask on users lists for the feedback (and perhaps persuade JMarc to 
release 2.4alpha1, which would be just quick technical preview
   with zero quality ensurance and sole purpose of testing docbook - so 
interested users do not need to compile?)
   Maybe you have better idea though.


Yes, I can do that.


Apart from these, really good work Thibaut...


Indeed, congratulations!

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 14:53:49 +0200
schrieb Jean-Marc Lasgouttes :

> >>> CID 360530:  Error handling issues  (CHECKED_RETURN)
> >>> Calling "regex_match" without checking return value (as is done 
> >>> elsewhere 48
> >>> out of 49 times).  
> 1194  std::regex_match(tag, match, tagRegex);
> 1195 1196 if (toDocBookTag.find(match[1]) == 

I wonder why the use of std::regex_match()?

We use
#include "support/regex.h"
the correct is either
lyx::regex_match()
or
regex_match()
in the lyx namespace.

Kornel


pgpYmDrsTfnNT.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Fwd: New DocBook support (0005)

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 02:01:38PM +0200, Pavel Sanda wrote:
> You have them in attachment :)
now really. p
-- pp   2020-07-08 13:56:16.458794194 +0200
++ 0004-Add-required-elements-in-the-layouts-to-support-DocB.patch  
2020-07-08 13:55:04.926411437 +0200
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -2141,7 +2141,7 @@ Buffer::ExportStatus 
Buffer::writeDocBookSource(odocstream & os, string const &
  output == FullSource || output == OnlyBody;
 
if (output_preamble) {
-   if (runparams.flavor == OutputParams::XML)
+   if (runparams.flavor == OutputParams::DOCBOOK5)
os << "\n";
 
// FIXME UNICODE
@@ -2150,14 +2150,14 @@ Buffer::ExportStatus 
Buffer::writeDocBookSource(odocstream & os, string const &
// FIXME UNICODE
if (! tclass.class_header().empty())
os << from_ascii(tclass.class_header());
-   else if (runparams.flavor == OutputParams::XML)
+   else if (runparams.flavor == OutputParams::DOCBOOK5)
os << "PUBLIC \"-//OASIS//DTD DocBook XML V4.2//EN\" "
<< 
"\"https://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd\";;
else
os << " PUBLIC \"-//OASIS//DTD DocBook V4.2//EN\"";
 
docstring preamble = params().preamble;
-   if (runparams.flavor != OutputParams::XML ) {
+   if (runparams.flavor != OutputParams::DOCBOOK5 ) {
preamble += "\n";
preamble += "\n";
preamble += "\n";
@@ -2178,7 +2178,7 @@ Buffer::ExportStatus 
Buffer::writeDocBookSource(odocstream & os, string const &
if (output_body) {
string top = top_element;
top += " lang=\"";
-   if (runparams.flavor == OutputParams::XML)
+   if (runparams.flavor == OutputParams::DOCBOOK5)
top += params().language->code();
else
top += params().language->code().substr(0, 2);
@@ -2189,7 +2189,7 @@ Buffer::ExportStatus 
Buffer::writeDocBookSource(odocstream & os, string const &
top += params().options;
}
 
-   os << "\n";
 
--- a/src/Converter.cpp
+++ b/src/Converter.cpp
@@ -277,7 +277,7 @@ OutputParams::FLAVOR Converters::getFlavor(Graph::EdgePath 
const & path,
return OutputParams::PDFLATEX;
}
if (conv.xml())
-   return OutputParams::XML;
+   return OutputParams::DOCBOOK5;
}
return buffer ? buffer->params().getOutputFlavor()
  : OutputParams::LATEX;
--- a/src/Format.cpp
+++ b/src/Format.cpp
@@ -827,7 +827,7 @@ FlavorTranslator initFlavorTranslator()
f.addPair(OutputParams::LUATEX, "luatex");
f.addPair(OutputParams::PDFLATEX, "pdflatex");
f.addPair(OutputParams::XETEX, "xetex");
-   f.addPair(OutputParams::XML, "docbook-xml");
+   f.addPair(OutputParams::DOCBOOK5, "docbook-xml");
f.addPair(OutputParams::HTML, "xhtml");
f.addPair(OutputParams::TEXT, "text");
f.addPair(OutputParams::LYX, "lyx");
--- a/src/Text3.cpp
+++ b/src/Text3.cpp
@@ -3065,7 +3065,6 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & 
cmd,

cur.buffer()->params().documentClass().insetLayout(from_utf8(s));
if (il.lyxtype() != InsetLayout::CHARSTYLE &&
il.lyxtype() != InsetLayout::CUSTOM &&
-   il.lyxtype() != InsetLayout::ELEMENT &&
il.lyxtype ()!= InsetLayout::STANDARD)
enable = false;
break;
--- a/src/mathed/InsetMathHull.cpp
+++ b/src/mathed/InsetMathHull.cpp
@@ -2431,7 +2431,7 @@ int InsetMathHull::docbook(odocstream & os, OutputParams 
const & runparams) cons
 
odocstringstream ls;
otexstream ols(ls);
-   if (runparams.flavor == OutputParams::XML) {
+   if (runparams.flavor == OutputParams::DOCBOOK5) {
ms << MTag("alt role='tex' ");
// Workaround for db2latex: db2latex always includes equations 
with
// \ensuremath{} or \begin{display}\end{display}
@@ -2459,7 +2459,7 @@ int InsetMathHull::docbook(odocstream & os, OutputParams 
const & runparams) cons
else
ms << xml::uniqueID(from_ascii("anon"));
 
-   if (runparams.flavor == OutputParams::XML)
+   if (runparams.flavor == OutputParams::DOCBOOK5)
ms << from_ascii("\"/>");
else
ms << from_ascii("\">");
--- a/src/mathed/InsetMathRef.cpp
+++ b/src/mathed/InsetMathRef.cpp
@@ -187,7 +187,7 @@ int InsetMathRef::docbook(odocstream & os, OutputParams 
const & runparams) const
if (cell(1).empty()) {
os << "";
   

Re: Docbook 5 merged

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 03:00:10PM +0200, Pavel Sanda wrote:
> - Two already known issues - fix documentation and tests, please see other 
> mails...
another one: we can't still select docbook as default output format of the 
document...

p
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Docbook 5 merged

2020-07-08 Thread Pavel Sanda
Hi Thibaut and others,

I am mostly done with merging Docbook to master.

There are several TODOs I see now:

- Add entries into various sections of RELEASE-NOTES, these should contain:
  - New output target for Docbook 5
  - Files gone (examples/layouts)
  - Warning that ppl. using archaic Docbook 4 document need to manually convert 
them, because layouts are gone
  - External deps. changed  - we do not use sgmltools anymore, distribution 
packagers can drop these

- Add promo section about Docbbok 5 to https://wiki.lyx.org/LyX/NewInLyX24, 
explaining whats new compared to outdated D4 sgml backend (somewhere to the 
top, this is a major thing).

- If some other dev could at least quickly look through commit 3883b85f49054 , 
that would be appreciated, it's too long for one eyes only

- As with any new feature there are likely some hidden issues and we would 
benefit from docbook users feedback and I'm not sure how to proceed.
  We could ask on users lists for the feedback (and perhaps persuade JMarc to 
release 2.4alpha1, which would be just quick technical preview
  with zero quality ensurance and sole purpose of testing docbook - so 
interested users do not need to compile?)
  Maybe you have better idea though.

- Two already known issues - fix documentation and tests, please see other 
mails...



Apart from these, really good work Thibaut...

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes

Hello,

More work for Thibaut :) I ran coverity against master and here is what 
it returns (below).



Item 1 is about checking return of regex_match

Item 2 is probably fixed by an earlier definition of the "label" variable

Item 3&4 seem to be only an issue with libstdc++, we cannot do much 
about it IMO.


The full dashboard is at
https://scan.coverity.com/projects/lyx?tab=overview

JMarc


 Message transféré 
Sujet : New Defects reported by Coverity Scan for LyX
Date : Wed, 08 Jul 2020 10:32:16 + (UTC)
De : scan-ad...@coverity.com
Pour : lasgout...@lyx.org

Hi,

Please find the latest report on new defect(s) introduced to LyX found 
with Coverity Scan.


4 new defect(s) introduced to LyX found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 360530:  Error handling issues  (CHECKED_RETURN)
/home/lasgoutt/src/lyx/coverity/lyx/src/insets/InsetBibtex.cpp: 1194 in 
lyx::InsetBibtex::docbook(lyx::XMLStream &, const lyx::OutputParams &) 
const()




*** CID 360530:  Error handling issues  (CHECKED_RETURN)
/home/lasgoutt/src/lyx/coverity/lyx/src/insets/InsetBibtex.cpp: 1194 in 
lyx::InsetBibtex::docbook(lyx::XMLStream &, const lyx::OutputParams &) 
const()

1188map delayedTags;
1189 1190 		// Read all tags from HTML and convert those that 
have a 1:1 matching.

1191while (tagIt != tagEnd) {
1192 			string tag = tagIt->str(); // regex_match cannot work with 
temporary strings.

1193++tagIt;

CID 360530:  Error handling issues  (CHECKED_RETURN)
Calling "regex_match" without checking return value (as is done elsewhere 
48 out of 49 times).

1194std::regex_match(tag, match, tagRegex);
1195 1196 			if (toDocBookTag.find(match[1]) == 
toDocBookTag.end()) {
1197 LYXERR0("The BibTeX field " << match[1].str() << " is 
unknown.");
1198 xs << XMLStream::ESCAPE_NONE << from_utf8("\n");

1199continue;

** CID 360529:  Null pointer dereferences  (FORWARD_NULL)
/home/lasgoutt/src/lyx/coverity/lyx/src/output_docbook.cpp: 926 in 
lyx::docbookParagraphs(const lyx::Text &, const lyx::Buffer &, 
lyx::XMLStream &, const lyx::OutputParams &)()




*** CID 360529:  Null pointer dereferences  (FORWARD_NULL)
/home/lasgoutt/src/lyx/coverity/lyx/src/output_docbook.cpp: 926 in 
lyx::docbookParagraphs(const lyx::Text &, const lyx::Buffer &, 
lyx::XMLStream &, const lyx::OutputParams &)()

920 docstring id = docstring();
921 for (pos_type i = 0; i < par->size(); 
++i) {
922 Inset const *inset = 
par->getInset(i);
923 if (inset && 
dynamic_cast(inset)) {
924 // Generate the 
attributes for the section if need be.
925 auto label = 
dynamic_cast(inset);

CID 360529:  Null pointer dereferences  (FORWARD_NULL)
Passing null pointer "label" to 
"_ZNK3lyx10InsetLabel11screenLabelB5cxx11Ev", which dereferences it. (The dereference 
happens because this is a virtual function call.)

926 id += "xml:id=\"" + 
xml::cleanID(label->screenLabel()) + "\"";
927 928 // Don't output the 
ID as a DocBook .
929 	 
ourparams.docbook_anchors_to_ignore.emplace(label->screenLabel());

930 931 // Cannot have 
multiple IDs per tag.

** CID 349481:  Resource leaks  (CTOR_DTOR_LEAK)



*** CID 349481:  Resource leaks  (CTOR_DTOR_LEAK)
/usr/include/c++/9/bits/hashtable.h: 1241 in 
std::_Hashtablestd::char_traits, std::allocator>, 
std::__cxx11::basic_string, 
std::allocator>, 
std::allocatorstd::char_traits, std::allocator>>, 
std::__detail::_Identity, 
std::equal_tostd::char_traits, std::allocator>>, 
std::hash, 
std::allocator>>, std::__detail::_Mod_range_hashing, 
std::__detail::_Default_ranged_hash, 
std::__detail::_Prime_rehash_policy, 
std::__detail::_Hashtable_traits<(bool)1, (bool)1, 
(bool)1>>::_Hashtable(const 
std::_Hashtablestd::char_traits, std::allocator>, 
std::__cxx11::basic_string, 
std::allocator>, 
std::allocatorstd::char_traits, std::allocator>>, 
std::__detail::_Identity, 
std::equal_tostd::char_traits, std::allocator>>, 
std::hash, 
std::allocator>>, std::__detail::_Mod_range_hashing, 
std::__detail::_Default_ranged_hash, 
std::__detail::_Prime_rehash_policy, 

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote:
> commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2
> Author: Thibaut Cuvelier 
> Date:   Fri May 10 02:54:44 2019 +0200
> 
> Add documentation for the new layout attributes.

Thibaut, this patch broke the manual (likely wrong merge from some changes
already committed to master.) I already reverted it.

Can you send either pacth which works or old version of your manual
which was fully working, I can do careful merge.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 13:54:18 +0200
schrieb Pavel Sanda :

> On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote:
> > All of the failed tests fail in style 'Description', defined probably in 
> > stdlists.inc.
> > Roundtrip fails because of missing entry 'DocBookItemTag listitem'.  
> 
> Do you know what is this 'Roundtrip' test suppose to test? P

Not exactly.

Source: src/tests/check_layout.cpp

Looks like the interpreted data of input layout have an extra line (not found 
in input)

input:
...
HTMLTitle 0
DocBookTag variablelist
DocBookItemTag varlistentry
DocBookItemLabelTag term
DocBookItemInnerTag para
Spellcheck 1
Interpreted:
...
HTMLTitle 0
DocBookTag variablelist
DocBookItemTag listitem
DocBookItemTag varlistentry
DocBookItemLabelTag term
DocBookItemInnerTag para
Spellcheck 1

Kornel


pgp4kl6ecOsgm.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Fwd: New DocBook support (0005)

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 12:35:55AM +0200, Thibaut Cuvelier wrote:
> > On Mon, Jul 06, 2020 at 05:18:16AM +0200, Thibaut Cuvelier wrote:
> > > > > diff --git a/src/OutputParams.h b/src/OutputParams.h
> > > > > index 1ad36722d0..0244a0ea41 100644
> 
> 
> Here is a rebased version of the patch. Numbering has been lost due to

Thanks, landed.

> compiles (I don't know where you had issues with XML being renamed
> DOCBOOK5???).

You have them in attachment :)

I also committed the rest of patches, they looked fine, but please
check new message on email list, there are some issues with testing
one docbook tag reported.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote:
> All of the failed tests fail in style 'Description', defined probably in 
> stdlists.inc.
> Roundtrip fails because of missing entry 'DocBookItemTag listitem'.

Do you know what is this 'Roundtrip' test suppose to test? P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 12:02:59 +0200
schrieb Jean-Marc Lasgouttes :

> Le 08/07/2020 à 11:58, ci-...@inria.fr a écrit :
> > FAIL: tests/test_layout  
> 
> Something is  wrong with this test...
> 
> JMarc

Yes, checking the layouts with "ctest -R check_layout" gives:
42% tests passed, 109 tests failed out of 187

All of the failed tests fail in style 'Description', defined probably in 
stdlists.inc.
Roundtrip fails because of missing entry 'DocBookItemTag listitem'.

Kornel


pgpAlr0urUctC.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Jean-Marc Lasgouttes

Le 08/07/2020 à 11:58, ci-...@inria.fr a écrit :

FAIL: tests/test_layout


Something is  wrong with this test...

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1990/--
[...truncated 1153 lines...]
  CXX  insets/InsetSpace.o
  CXX  insets/InsetSpecialChar.o
  CXX  insets/InsetTabular.o
  CXX  insets/InsetText.o
  CXX  insets/InsetTOC.o
  CXX  insets/InsetVSpace.o
  CXX  insets/InsetWrap.o
  AR   liblyxinsets.a
  CXX  main.o
  CXX  BiblioInfo.o
  CXX  Box.o
  CXX  Compare.o
  CXX  Dimension.o
  CXX  EnchantChecker.o
  CXX  PersonalWordList.o
  CXX  LaTeXFonts.o
  CXX  Thesaurus.o
  CXXLDlyx
make[4]: Leaving directory '/build/workspace/src'
Making all in client
make[4]: Entering directory '/build/workspace/src/client'
  CXX  boost.o
  CXX  client.o
  CXXLDlyxclient
make[4]: Leaving directory '/build/workspace/src/client'
Making all in tex2lyx
make[4]: Entering directory '/build/workspace/src/tex2lyx'
  CXX  boost.o
  CXX  Context.o
  CXX  dummy_impl.o
  CXX  math.o
  CXX  Parser.o
  CXX  Preamble.o
  CXX  table.o
  CXX  tex2lyx.o
  CXX  text.o
  CXXLDtex2lyx
make[4]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in convert
make[4]: Entering directory '/build/workspace/src/convert'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/build/workspace/src/convert'
make[3]: Leaving directory '/build/workspace/src'
make[2]: Leaving directory '/build/workspace/src'
Making all in sourcedoc
make[2]: Entering directory '/build/workspace/sourcedoc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/sourcedoc'
Making all in lib
make[2]: Entering directory '/build/workspace/lib'
Making all in doc
make[3]: Entering directory '/build/workspace/lib/doc'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/doc'
Making all in lyx2lyx
make[3]: Entering directory '/build/workspace/lib/lyx2lyx'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/lyx2lyx'
make[3]: Entering directory '/build/workspace/lib'
  GEN  lyx.desktop
  GEN  lyx.png
  GEN  lyx.svg
make[3]: Leaving directory '/build/workspace/lib'
make[2]: Leaving directory '/build/workspace/lib'
Making all in src/client
make[2]: Entering directory '/build/workspace/src/client'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/client'
Making all in src/tex2lyx
make[2]: Entering directory '/build/workspace/src/tex2lyx'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in src/convert
make[2]: Entering directory '/build/workspace/src/convert'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/convert'
make[2]: Entering directory '/build/workspace'
make[2]: Leaving directory '/build/workspace'
make[1]: Leaving directory '/build/workspace'
# Executing: make check
Making check in autotests
make[1]: Entering directory '/build/workspace/autotests'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/autotests'
Making check in config
make[1]: Entering directory '/build/workspace/config'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/config'
Making check in development
make[1]: Entering directory '/build/workspace/development'
make[2]: Entering directory '/build/workspace/development'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/development'
make[1]: Leaving directory '/build/workspace/development'
Making check in po
make[1]: Entering directory '/build/workspace/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/po'
Making check in 3rdparty
make[1]: Entering directory '/build/workspace/3rdparty'
make[2]: Entering directory '/build/workspace/3rdparty'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/3rdparty'
make[1]: Leaving directory '/build/workspace/3rdparty'
Making check in src
make[1]: Entering directory '/build/workspace/src'
  CHK  lyx_commit_hash.h
make  check-recursive
make[2]: Entering directory '/build/workspace/src'
Making check in support
make[3]: Entering directory '/build/workspace/src/support'
make  check-am
make[4]: Entering directory '/build/workspace/src/support'
make  check_convert check_filetools check_lstrings check_trivstring
make[5]: Entering directory '/build/workspace/src/support'
  CXX  tests/check_convert.o
  CXX  tests/dummy_functions.o
  CXX  tests/boost.o
  CXXLDcheck_convert
  CXX  tests/check_filetools.o
  CXXLDcheck_filetools
  CXX  tests/check_lstrings.o
  CXXLDcheck_lstrings
  CXX  tests/check_trivstring.o
  CXXLDcheck_trivstring
make[5]: Leaving directory '/build/workspace/src/support'
make  check-TESTS
make[5]: Entering directory 

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #1781

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1781/--
[...truncated 966 lines...]
OutputParams.h:364:32: warning:   
'std::__debug::unordered_set > 
lyx::OutputParams::docbook_anchors_to_ignore' [-Wreorder]
  std::unordered_set docbook_anchors_to_ignore;
^
OutputParams.cpp:21:1: warning:   when initialized here [-Wreorder]
 OutputParams::OutputParams(Encoding const * enc)
 ^
  CXX  output_plaintext.o
  CXX  Paragraph.o
  CXX  ParagraphMetrics.o
  CXX  ParagraphParameters.o
  CXX  ParIterator.o
  CXX  PDFOptions.o
  CXX  Row.o
  CXX  RowPainter.o
  CXX  Server.o
  CXX  ServerSocket.o
  CXX  xml.o
  CXX  Session.o
  CXX  Spacing.o
  CXX  TexRow.o
  CXX  texstream.o
  CXX  Text.o
  CXX  Text2.o
  CXX  Text3.o
  CXX  TextClass.o
In file included from TextClass.cpp:17:0:
TextClass.h: In constructor 'lyx::TextClass::TextClass()':
TextClass.h:378:7: warning: 'lyx::TextClass::bibintoc_' will be initialized 
after [-Wreorder]
  bool bibintoc_;
   ^
TextClass.h:309:14: warning:   'std::__cxx11::string 
lyx::TextClass::docbookroot_' [-Wreorder]
  std::string docbookroot_;
  ^
TextClass.cpp:136:1: warning:   when initialized here [-Wreorder]
 TextClass::TextClass()
 ^
  CXX  TextMetrics.o
  CXX  TocBackend.o
  CXX  TocBuilder.o
  CXX  Trans.o
  CXX  Undo.o
  CXX  VCBackend.o
  CXX  version.o
  CXX  VSpace.o
  CXX  WordList.o
  CXX  Layout.o
  AR   liblyxcore.a
  CXX  graphics/epstools.o
  CXX  graphics/GraphicsCache.o
  CXX  graphics/GraphicsCacheItem.o
  CXX  graphics/GraphicsConverter.o
  CXX  graphics/GraphicsLoader.o
  CXX  graphics/GraphicsParams.o
  CXX  graphics/PreviewImage.o
  CXX  graphics/PreviewLoader.o
  AR   liblyxgraphics.a
  CXX  mathed/InsetMathAMSArray.o
  CXX  mathed/InsetMathArray.o
  CXX  mathed/InsetMathBig.o
  CXX  mathed/InsetMathBoldSymbol.o
  CXX  mathed/InsetMathBox.o
  CXX  mathed/InsetMathBrace.o
  CXX  mathed/InsetMath.o
  CXX  mathed/InsetMathCancel.o
  CXX  mathed/InsetMathCancelto.o
  CXX  mathed/InsetMathCases.o
  CXX  mathed/InsetMathChar.o
  CXX  mathed/InsetMathClass.o
  CXX  mathed/InsetMathColor.o
  CXX  mathed/InsetMathCommand.o
  CXX  mathed/InsetMathComment.o
  CXX  mathed/InsetMathDecoration.o
  CXX  mathed/InsetMathDelim.o
  CXX  mathed/InsetMathDiagram.o
  CXX  mathed/InsetMathDiff.o
  CXX  mathed/InsetMathDots.o
  CXX  mathed/InsetMathEnsureMath.o
  CXX  mathed/InsetMathEnv.o
  CXX  mathed/InsetMathExFunc.o
  CXX  mathed/InsetMathExInt.o
  CXX  mathed/InsetMathFont.o
  CXX  mathed/InsetMathFontOld.o
  CXX  mathed/InsetMathFrac.o
  CXX  mathed/InsetMathGrid.o
  CXX  mathed/InsetMathHull.o
  CXX  mathed/InsetMathKern.o
  CXX  mathed/InsetMathLefteqn.o
  CXX  mathed/InsetMathLim.o
  CXX  mathed/InsetMathMacro.o
  CXX  mathed/InsetMathMacroArgument.o
  CXX  mathed/InsetMathMacroTemplate.o
  CXX  mathed/InsetMathMatrix.o
  CXX  mathed/InsetMathNest.o
  CXX  mathed/InsetMathNumber.o
  CXX  mathed/InsetMathOverset.o
  CXX  mathed/InsetMathPar.o
  CXX  mathed/InsetMathPhantom.o
  CXX  mathed/InsetMathRef.o
  CXX  mathed/InsetMathRoot.o
  CXX  mathed/InsetMathScript.o
  CXX  mathed/InsetMathSideset.o
  CXX  mathed/InsetMathSize.o
  CXX  mathed/InsetMathSpace.o
  CXX  mathed/InsetMathSpecialChar.o
  CXX  mathed/InsetMathSplit.o
  CXX  mathed/InsetMathSqrt.o
  CXX  mathed/InsetMathStackrel.o
  CXX  mathed/InsetMathString.o
  CXX  mathed/InsetMathSubstack.o
  CXX  mathed/InsetMathSymbol.o
  CXX  mathed/InsetMathTabular.o
  CXX  mathed/InsetMathUnderset.o
  CXX  mathed/InsetMathUnknown.o
  CXX  mathed/InsetMathXArrow.o
  CXX  mathed/InsetMathXYMatrix.o
  CXX  mathed/MacroTable.o
  CXX  mathed/MathAtom.o
  CXX  mathed/MathAutoCorrect.o
  CXX  mathed/MathClass.o
  CXX  mathed/MathData.o
  CXX  mathed/MathExtern.o
  CXX  mathed/MathFactory.o
  CXX  mathed/MathParser.o
  CXX  mathed/MathRow.o
  CXX  mathed/MathStream.o
  CXX  mathed/MathSupport.o
  CXX  mathed/TextPainter.o
  AR   liblyxmathed.a
  CXX  insets/ExternalSupport.o
  CXX  insets/ExternalTemplate.o
  CXX  insets/ExternalTransforms.o
  CXX  insets/RenderButton.o
  CXX  insets/RenderGraphic.o
  CXX  insets/RenderPreview.o
  CXX  insets/Inset.o
  CXX  insets/InsetArgument.o
  CXX  insets/InsetBibitem.o
  CXX  insets/InsetBibtex.o
  CXX  insets/InsetBox.o
  CXX  insets/InsetBranch.o
  CXX  insets/InsetCaption.o
  CXX  insets/InsetCaptionable.o
  CXX  insets/InsetCitation.o
  CXX  insets/InsetCollapsible.o
  CXX  

Re: Compiling and using master on macOS

2020-07-08 Thread Stephan Witt
Am 08.07.2020 um 08:21 schrieb Daniel :
> 
> On 2020-07-07 00:24, Stephan Witt wrote:
>> Am 06.07.2020 um 09:59 schrieb Daniel :
>>> 
>>> On 2020-03-15 21:37, Stephan Witt wrote:
 Am 15.03.2020 um 17:16 schrieb Daniel :
> 
> Hi,
> 
> I am about to try compiling and using master on macOS. I just has a look 
> at INSTALL.MacOSX. It mentions Qt version 4. That seems a bit outdated. 
> But I guess that I am looking at the latest guide to compile on macOS, 
> right?
 Yes, it’s outdated. It should work with Qt4 - but Qt4 cannot be used on 
 recent macOS.
 Basically I’m using the script LyX-Mac-binary-release.sh in development 
 folder. That’s much easier than other options, IMO.
 First step is to install Xcode and the automake and/or cmake utilities. 
 This can be done with macports or homebrew. I’m using macports.
 Second step is to get Qt5 - as source or binary distribution. I’m using 
 the source tarball and build Qt5 myself.
 Optional components are the spell checker and libmagic frameworks.
 Finally I start development/LyX-Mac-binary-release.sh with
 --enable-cxx11
 --with-qt-dir=/path/to/qt5
 Stephan
>>> 
>>> Thanks. Finally came around trying it on macOS. I take it one has to run 
>>> the last command with sh, right? So, from the lyx directory (in the lyxgit 
>>> directory) I execute
>>> 
>>> sh development/LyX-Mac-binary-release.sh --enable-cxx11 
>>> --with-qt-dir=/Users//Qt/5.9.9
>>> 
>>> (where I replace  by my macOS user name. Unfortunately, I get the 
>>> following:
>>> 
>>> : command not found-binary-release.sh: line 2:
>>> : command not found-binary-release.sh: line 4:
>>> : command not found-binary-release.sh: line 9:
>>> : command not found-binary-release.sh: line 19:
>>> : command not found-binary-release.sh: line 23:
>>> : command not found-binary-release.sh: line 27:
>>> ': not a valid identifiery-release.sh: line 28: unset: `LD_LIBRARY_PATH
>>> : command not found-binary-release.sh: line 29:
>>> : command not found-binary-release.sh: line 44:
>>> : command not found-binary-release.sh: line 49:
>>> development/LyX-Mac-binary-release.sh: line 53: syntax error near 
>>> unexpected tok'n `in
>>> 'evelopment/LyX-Mac-binary-release.sh: line 53: `case 
>>> "${QtVersion}:${QtAPI}" in
>>> 
>>> By the way, if finally successful, where will this put the LyX.app?
>>> 
>>> Daniel
>> I’ve made a protocol of the steps I took to build the package on a new 
>> system. See the attached log. Probably the crucial thing is the 
>> mklyx-2.3.4.3.sh script.
>> I’m used to configure and build LyX out of source. I have a working 
>> directory with one or more versions of LyX source code and a directory 
>> lyx-build for the results. For Qt I have a source directory and an install 
>> target in parallel, the build directory is in lyx-build.
>> $ ls /Users/Shared/LyX
>> lyx-2.3.4.3 (source)
>> lyx-2.3.5.2 (source)
>> lyx-build (directory)
>> qt-5.9.9-frameworks-cocoa-x86_64  (QTDIR for 5.9.9)
>> qt-everywhere-opensource-src-5.9.9 (source)
>> The lyx-build contains the build directory, the installed package (LyX.app) 
>> and the resulting disk image.
>> $ ls /Users/Shared/LyX/
>> LyX-2.3.4.3+qt5-x86_64-cocoa.dmg (disk image)
>> LyX-2.3.4.3.app (working app)
>> LyX-2.3.4.3.build (binaries)
>> LyX-2.3.5.2+qt5-x86_64-cocoa.dmg (disk image)
>> LyX-2.3.5.2.app (working app)
>> LyX-2.3.5.2.build (binaries)
>> qt-5.9.9-build-x86_64 (binaries)
>> The /bin/sh on a Mac is in fact a bash, IMO.
>> Stephan
> 
> By the way, it might be that I don't really understand how and where these 
> commands are supposed to be called. But if I call
> 
> 
> cat mklyx-2.3.4.3.sh
> #!/bin/sh
> ARCH=x86_64
> SDK=10.14
> MacOsXTarget=10.12
> QtVersion=5.9.9
> QtAPI=-cocoa
> LyXVersion=lyx-2.3.4.3
> EnableCXX11="--enable-cxx11"
> 
> QtConfigureOptions="-debug-and-release" QtAPI=${QtAPI} QtVersion=${QtVersion} 
> \
> QtSourceVersion="qt-everywhere-src-${QtVersion}" \
> PKG_CONFIG= \
> sh ${MKFLAGS} ${LyXVersion}/development/LyX-Mac-binary-release.sh \
>   --with-sdkroot=${SDK} --with-macosx-target=${MacOsXTarget} 
> --with-arch=${ARCH} \
>   
> --with-qt-dir=/Users/Shared/LyX/qt-${QtVersion}-frameworks${QtAPI}-${ARCH} \
>   --with-util-dir=/Users/Shared/LyX/utilities \
>   ${EnableCXX11} \
>   "$@„

Yes, you have to create the file mklyx-2.3.4.3.sh with the given content.

I have to add an explicit note for it…

Stephan
 
> 
> 
> I get
> 
> 
> zsh: event not found: /bin/sh
> 
> 
> Daniel
> 
> -- 
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling and using master on macOS

2020-07-08 Thread Stephan Witt
Am 07.07.2020 um 07:35 schrieb Daniel :
> 
> On 2020-07-07 07:30, Daniel wrote:
>> On 2020-07-07 00:24, Stephan Witt wrote:
>>> Am 06.07.2020 um 09:59 schrieb Daniel :
 
 On 2020-03-15 21:37, Stephan Witt wrote:
> Am 15.03.2020 um 17:16 schrieb Daniel :
>> 
>> Hi,
>> 
>> I am about to try compiling and using master on macOS. I just has a look 
>> at INSTALL.MacOSX. It mentions Qt version 4. That seems a bit outdated. 
>> But I guess that I am looking at the latest guide to compile on macOS, 
>> right?
> Yes, it’s outdated. It should work with Qt4 - but Qt4 cannot be used on 
> recent macOS.
> Basically I’m using the script LyX-Mac-binary-release.sh in development 
> folder. That’s much easier than other options, IMO.
> First step is to install Xcode and the automake and/or cmake utilities. 
> This can be done with macports or homebrew. I’m using macports.
> Second step is to get Qt5 - as source or binary distribution. I’m using 
> the source tarball and build Qt5 myself.
> Optional components are the spell checker and libmagic frameworks.
> Finally I start development/LyX-Mac-binary-release.sh with
> --enable-cxx11
> --with-qt-dir=/path/to/qt5
> Stephan
 
 Thanks. Finally came around trying it on macOS. I take it one has to run 
 the last command with sh, right? So, from the lyx directory (in the lyxgit 
 directory) I execute
 
 sh development/LyX-Mac-binary-release.sh --enable-cxx11 
 --with-qt-dir=/Users//Qt/5.9.9
 
 (where I replace  by my macOS user name. Unfortunately, I get 
 the following:
 
 : command not found-binary-release.sh: line 2:
 : command not found-binary-release.sh: line 4:
 : command not found-binary-release.sh: line 9:
 : command not found-binary-release.sh: line 19:
 : command not found-binary-release.sh: line 23:
 : command not found-binary-release.sh: line 27:
 ': not a valid identifiery-release.sh: line 28: unset: `LD_LIBRARY_PATH
 : command not found-binary-release.sh: line 29:
 : command not found-binary-release.sh: line 44:
 : command not found-binary-release.sh: line 49:
 development/LyX-Mac-binary-release.sh: line 53: syntax error near 
 unexpected tok'n `in
 'evelopment/LyX-Mac-binary-release.sh: line 53: `case 
 "${QtVersion}:${QtAPI}" in
 
 By the way, if finally successful, where will this put the LyX.app?
 
 Daniel
>>> 
>>> I’ve made a protocol of the steps I took to build the package on a new 
>>> system. See the attached log. Probably the crucial thing is the 
>>> mklyx-2.3.4.3.sh script.
>>> 
>>> I’m used to configure and build LyX out of source. I have a working 
>>> directory with one or more versions of LyX source code and a directory 
>>> lyx-build for the results. For Qt I have a source directory and an install 
>>> target in parallel, the build directory is in lyx-build.
>>> 
>>> $ ls /Users/Shared/LyX
>>> lyx-2.3.4.3 (source)
>>> lyx-2.3.5.2 (source)
>>> lyx-build (directory)
>>> qt-5.9.9-frameworks-cocoa-x86_64  (QTDIR for 5.9.9)
>>> qt-everywhere-opensource-src-5.9.9 (source)
>>> 
>>> The lyx-build contains the build directory, the installed package (LyX.app) 
>>> and the resulting disk image.
>>> 
>>> $ ls /Users/Shared/LyX/
>>> LyX-2.3.4.3+qt5-x86_64-cocoa.dmg (disk image)
>>> LyX-2.3.4.3.app (working app)
>>> LyX-2.3.4.3.build (binaries)
>>> LyX-2.3.5.2+qt5-x86_64-cocoa.dmg (disk image)
>>> LyX-2.3.5.2.app (working app)
>>> LyX-2.3.5.2.build (binaries)
>>> qt-5.9.9-build-x86_64 (binaries)
>>> 
>>> The /bin/sh on a Mac is in fact a bash, IMO.
>>> 
>>> Stephan
>>> 
>>> 
>> I am using git to download the lyx source and qt installer. But the steps 
>> should be the same except for the unpacking and setting my own directories, 
>> right?
>> Also what does
>> osascript -e 'tell application "Finder" to display notification "LyX is 
>> great stuff"'
>> do? It looks strange.
>> Daniel
> 
> Okay, I guess it can't be the same because there is a specific LyX version 
> mentioned (2.3.4.3). What would I use if I want to compile from git (master)?

Yes, that’s true - this is the build from the shipped tar file for 2.3.4.3. But 
it works for git clones too.

The difference to master is the name of the directory and this is your choice. 
I’m using „lyx“ for it. I have another git clone for stable named „lyx-2.3.x“.

The resulting applications are placed in lyx-build and named according to the 
AC_INIT macro in configure.ac (e.g. LyX,2.4.0dev => LyX-2.4.0dev.app).

In case you want to do the single steps w/o the build script you may try the 
following:

1. create a dedicated build dir - e.g. lyx-build/master

2. create or update the configure script - run autogen.sh in your git checkout 
(in place)

3. prepare your environment variables

export CPPFLAGS="-isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk
 

Re: Compiling and using master on macOS

2020-07-08 Thread Daniel

On 2020-07-07 00:24, Stephan Witt wrote:

Am 06.07.2020 um 09:59 schrieb Daniel :


On 2020-03-15 21:37, Stephan Witt wrote:

Am 15.03.2020 um 17:16 schrieb Daniel :


Hi,

I am about to try compiling and using master on macOS. I just has a look at 
INSTALL.MacOSX. It mentions Qt version 4. That seems a bit outdated. But I 
guess that I am looking at the latest guide to compile on macOS, right?

Yes, it’s outdated. It should work with Qt4 - but Qt4 cannot be used on recent 
macOS.
Basically I’m using the script LyX-Mac-binary-release.sh in development folder. 
That’s much easier than other options, IMO.
First step is to install Xcode and the automake and/or cmake utilities. This 
can be done with macports or homebrew. I’m using macports.
Second step is to get Qt5 - as source or binary distribution. I’m using the 
source tarball and build Qt5 myself.
Optional components are the spell checker and libmagic frameworks.
Finally I start development/LyX-Mac-binary-release.sh with
--enable-cxx11
--with-qt-dir=/path/to/qt5
Stephan


Thanks. Finally came around trying it on macOS. I take it one has to run the 
last command with sh, right? So, from the lyx directory (in the lyxgit 
directory) I execute

sh development/LyX-Mac-binary-release.sh --enable-cxx11 
--with-qt-dir=/Users//Qt/5.9.9

(where I replace  by my macOS user name. Unfortunately, I get the 
following:

: command not found-binary-release.sh: line 2:
: command not found-binary-release.sh: line 4:
: command not found-binary-release.sh: line 9:
: command not found-binary-release.sh: line 19:
: command not found-binary-release.sh: line 23:
: command not found-binary-release.sh: line 27:
': not a valid identifiery-release.sh: line 28: unset: `LD_LIBRARY_PATH
: command not found-binary-release.sh: line 29:
: command not found-binary-release.sh: line 44:
: command not found-binary-release.sh: line 49:
development/LyX-Mac-binary-release.sh: line 53: syntax error near unexpected 
tok'n `in
'evelopment/LyX-Mac-binary-release.sh: line 53: `case "${QtVersion}:${QtAPI}" in

By the way, if finally successful, where will this put the LyX.app?

Daniel


I’ve made a protocol of the steps I took to build the package on a new system. 
See the attached log. Probably the crucial thing is the mklyx-2.3.4.3.sh script.

I’m used to configure and build LyX out of source. I have a working directory 
with one or more versions of LyX source code and a directory lyx-build for the 
results. For Qt I have a source directory and an install target in parallel, 
the build directory is in lyx-build.

$ ls /Users/Shared/LyX
lyx-2.3.4.3 (source)
lyx-2.3.5.2 (source)
lyx-build (directory)
qt-5.9.9-frameworks-cocoa-x86_64  (QTDIR for 5.9.9)
qt-everywhere-opensource-src-5.9.9 (source)

The lyx-build contains the build directory, the installed package (LyX.app) and 
the resulting disk image.

$ ls /Users/Shared/LyX/
LyX-2.3.4.3+qt5-x86_64-cocoa.dmg (disk image)
LyX-2.3.4.3.app (working app)
LyX-2.3.4.3.build (binaries)
LyX-2.3.5.2+qt5-x86_64-cocoa.dmg (disk image)
LyX-2.3.5.2.app (working app)
LyX-2.3.5.2.build (binaries)
qt-5.9.9-build-x86_64 (binaries)

The /bin/sh on a Mac is in fact a bash, IMO.

Stephan




By the way, it might be that I don't really understand how and where 
these commands are supposed to be called. But if I call



cat mklyx-2.3.4.3.sh
#!/bin/sh
ARCH=x86_64
SDK=10.14
MacOsXTarget=10.12
QtVersion=5.9.9
QtAPI=-cocoa
LyXVersion=lyx-2.3.4.3
EnableCXX11="--enable-cxx11"

QtConfigureOptions="-debug-and-release" QtAPI=${QtAPI} 
QtVersion=${QtVersion} \

QtSourceVersion="qt-everywhere-src-${QtVersion}" \
PKG_CONFIG= \
sh ${MKFLAGS} ${LyXVersion}/development/LyX-Mac-binary-release.sh \
	--with-sdkroot=${SDK} --with-macosx-target=${MacOsXTarget} 
--with-arch=${ARCH} \


--with-qt-dir=/Users/Shared/LyX/qt-${QtVersion}-frameworks${QtAPI}-${ARCH} \
--with-util-dir=/Users/Shared/LyX/utilities \
${EnableCXX11} \
"$@"


I get


zsh: event not found: /bin/sh


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel