Re: Groupbox layout

[Stephan Witt]

Am 06.08.2020 um 17:04 schrieb Jürgen Spitzmüller :
> 
> Am Do., 6. Aug. 2020 um 14:58 Uhr schrieb Stephan Witt :
>  I cannot see the big deal to set the flat flag on Linux. With QtDesigner on 
> Linux and Qt 5.9.7 the difference is not
> obvious to me. See the screen-shots I’ve attached. More or less space only.
> Personally I’d prefer non-flat on Linux too.
> 
> Go ahead and set it to non-flat generally. This whole story has too much 
> weight already.

For now I’ve pushed the published patch with the check for platform plugin.

I didn’t want to change the appearance for Linux binaries.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Do., 6. Aug. 2020 um 14:58 Uhr schrieb Stephan Witt :

>  I cannot see the big deal to set the flat flag on Linux. With QtDesigner
> on Linux and Qt 5.9.7 the difference is not
> obvious to me. See the screen-shots I’ve attached. More or less space only.
> Personally I’d prefer non-flat on Linux too.
>

Go ahead and set it to non-flat generally. This whole story has too much
weight already.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-06 14:57, Stephan Witt wrote:

Am 06.08.2020 um 07:37 schrieb racoon :


On 2020-08-06 07:28, Stephan Witt wrote:

Am 06.08.2020 um 05:01 schrieb Daniel :


On 2020-08-06 00:02, Stephan Witt wrote:

Am 05.08.2020 um 12:47 schrieb Stephan Witt :


Am 04.08.2020 um 05:36 schrieb Daniel :


On 2020-08-04 00:03, Daniel wrote:

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I will need 
to ask on stackexchange…


Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan



Nice! It seems to work as expected. And I think it improves the readability of the 
preferences on mac. My hunch is that we would want the analogue for every other OS but 
with "setFlat(true)" because currently not all group boxes are set to flat and 
likely some will be missed in the future.


Just to be sure: the method relies on the particular creation process of panels 
by the Preferences dialog, right? It can probably be adapted for the Document 
Settings dialog but would not (easily) work on the lowesy (application) level.


Yes, the method enumerates the child widgets after initial UI setup. This 
method works for the Preferences dialog as the code is placed there.

Other methods I can imagine would be:
1. put the code at a lower level of the class hierarchy for dialogs and make it 
more general that way or
2. create a own GUI class derived from QGroupbox, override the init code and 
use that instead of the Qt class (don’t know how to do this in designer)

Next patch with more general scope - I’ve moved the code to dialog factory 
utility GuiView::findOrBuild().


Great, seems to work everywhere as expected (dialogs and widgets). So, I guess 
what is missing is the part with:


#else
flatGroupBoxes(dialog->asQWidget(), true);



May be. I did not hear the applause for your proposal :)
So, I’d rather left it as an open task for an improvement for other devs.

Stephan


I am a bit worried this will get lost then. I seem to remember that when
I first saw that group boxes where sometimes flat and suggested to give
them their default layout, that Jürgen said that they should be
invariably flat. But seeing the effect on macOS, he probably thought
it's okay with the default there. So, I am inclined to think that he
would applaud these changes.


This would be this patch then. I cannot see the big deal to set the flat
flag on Linux. With QtDesigner on Linux and Qt 5.9.7 the difference is not
obvious to me. See the screen-shots I’ve attached. More or less space only.
Personally I’d prefer non-flat on Linux too.


If I understood the situation on Linux correctly, then it depends on the 
user what style is used. So, there can be quite some variation depending 
on the user's choice.


--
Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[racoon]

On 2020-08-06 07:28, Stephan Witt wrote:

Am 06.08.2020 um 05:01 schrieb Daniel :


On 2020-08-06 00:02, Stephan Witt wrote:

Am 05.08.2020 um 12:47 schrieb Stephan Witt :


Am 04.08.2020 um 05:36 schrieb Daniel :


On 2020-08-04 00:03, Daniel wrote:

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I will need 
to ask on stackexchange…


Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan



Nice! It seems to work as expected. And I think it improves the readability of the 
preferences on mac. My hunch is that we would want the analogue for every other OS but 
with "setFlat(true)" because currently not all group boxes are set to flat and 
likely some will be missed in the future.


Just to be sure: the method relies on the particular creation process of panels 
by the Preferences dialog, right? It can probably be adapted for the Document 
Settings dialog but would not (easily) work on the lowesy (application) level.


Yes, the method enumerates the child widgets after initial UI setup. This 
method works for the Preferences dialog as the code is placed there.

Other methods I can imagine would be:
1. put the code at a lower level of the class hierarchy for dialogs and make it 
more general that way or
2. create a own GUI class derived from QGroupbox, override the init code and 
use that instead of the Qt class (don’t know how to do this in designer)

Next patch with more general scope - I’ve moved the code to dialog factory 
utility GuiView::findOrBuild().


Great, seems to work everywhere as expected (dialogs and widgets). So, I guess 
what is missing is the part with:


#else
flatGroupBoxes(dialog->asQWidget(), true);



May be. I did not hear the applause for your proposal :)
So, I’d rather left it as an open task for an improvement for other devs.

Stephan


I am a bit worried this will get lost then. I seem to remember that when
I first saw that group boxes where sometimes flat and suggested to give
them their default layout, that Jürgen said that they should be
invariably flat. But seeing the effect on macOS, he probably thought
it's okay with the default there. So, I am inclined to think that he
would applaud these changes.

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Stephan Witt]

Am 06.08.2020 um 05:01 schrieb Daniel :
> 
> On 2020-08-06 00:02, Stephan Witt wrote:
>> Am 05.08.2020 um 12:47 schrieb Stephan Witt :
>>> 
>>> Am 04.08.2020 um 05:36 schrieb Daniel :
 
 On 2020-08-04 00:03, Daniel wrote:
> On 2020-08-03 22:43, Stephan Witt wrote:
>> Am 03.08.2020 um 16:52 schrieb Daniel :
>>> 
>>> On 3/8/20 16:20, Jürgen Spitzmüller wrote:
 Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
> Thanks. I hope you did not compile the list manually. :)
 No: grep setFlat *.h
> I was actually hoping that there could be a general way to affect all
> boxes with "one" call. But if my search for this does not bear
> fruit, I'll resort to the manual solution.
 I doubt you can do this generally.
>>> 
>>> Seemed to me like something one should be able to do. But probably I 
>>> will need to ask on stackexchange…
>> 
>> Something like the attached patch? It’s only a hack for the preferences 
>> to get the idea.
>> 
>> This can be put in a helper method and called when it seems appropriate.
>> 
>> Stephan
>> 
>> 
> Nice! It seems to work as expected. And I think it improves the 
> readability of the preferences on mac. My hunch is that we would want the 
> analogue for every other OS but with "setFlat(true)" because currently 
> not all group boxes are set to flat and likely some will be missed in the 
> future.
 
 Just to be sure: the method relies on the particular creation process of 
 panels by the Preferences dialog, right? It can probably be adapted for 
 the Document Settings dialog but would not (easily) work on the lowesy 
 (application) level.
>>> 
>>> Yes, the method enumerates the child widgets after initial UI setup. This 
>>> method works for the Preferences dialog as the code is placed there.
>>> 
>>> Other methods I can imagine would be:
>>> 1. put the code at a lower level of the class hierarchy for dialogs and 
>>> make it more general that way or
>>> 2. create a own GUI class derived from QGroupbox, override the init code 
>>> and use that instead of the Qt class (don’t know how to do this in designer)
>> Next patch with more general scope - I’ve moved the code to dialog factory 
>> utility GuiView::findOrBuild().
> 
> Great, seems to work everywhere as expected (dialogs and widgets). So, I 
> guess what is missing is the part with:
> 
> 
> #else
>   flatGroupBoxes(dialog->asQWidget(), true);
> 

May be. I did not hear the applause for your proposal :) 
So, I’d rather left it as an open task for an improvement for other devs.

Stephan 


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-06 00:02, Stephan Witt wrote:

Am 05.08.2020 um 12:47 schrieb Stephan Witt :


Am 04.08.2020 um 05:36 schrieb Daniel :


On 2020-08-04 00:03, Daniel wrote:

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I will need 
to ask on stackexchange…


Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan



Nice! It seems to work as expected. And I think it improves the readability of the 
preferences on mac. My hunch is that we would want the analogue for every other OS but 
with "setFlat(true)" because currently not all group boxes are set to flat and 
likely some will be missed in the future.


Just to be sure: the method relies on the particular creation process of panels 
by the Preferences dialog, right? It can probably be adapted for the Document 
Settings dialog but would not (easily) work on the lowesy (application) level.


Yes, the method enumerates the child widgets after initial UI setup. This 
method works for the Preferences dialog as the code is placed there.

Other methods I can imagine would be:
1. put the code at a lower level of the class hierarchy for dialogs and make it 
more general that way or
2. create a own GUI class derived from QGroupbox, override the init code and 
use that instead of the Qt class (don’t know how to do this in designer)


Next patch with more general scope - I’ve moved the code to dialog factory 
utility GuiView::findOrBuild().


Great, seems to work everywhere as expected (dialogs and widgets). So, I 
guess what is missing is the part with:



#else
flatGroupBoxes(dialog->asQWidget(), true);


--
Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Stephan Witt]

Am 05.08.2020 um 12:47 schrieb Stephan Witt :
> 
> Am 04.08.2020 um 05:36 schrieb Daniel :
>> 
>> On 2020-08-04 00:03, Daniel wrote:
>>> On 2020-08-03 22:43, Stephan Witt wrote:
 Am 03.08.2020 um 16:52 schrieb Daniel :
> 
> On 3/8/20 16:20, Jürgen Spitzmüller wrote:
>> Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
>>> Thanks. I hope you did not compile the list manually. :)
>> No: grep setFlat *.h
>>> I was actually hoping that there could be a general way to affect all
>>> boxes with "one" call. But if my search for this does not bear
>>> fruit, I'll resort to the manual solution.
>> I doubt you can do this generally.
> 
> Seemed to me like something one should be able to do. But probably I will 
> need to ask on stackexchange…
 
 Something like the attached patch? It’s only a hack for the preferences to 
 get the idea.
 
 This can be put in a helper method and called when it seems appropriate.
 
 Stephan
 
 
>>> Nice! It seems to work as expected. And I think it improves the readability 
>>> of the preferences on mac. My hunch is that we would want the analogue for 
>>> every other OS but with "setFlat(true)" because currently not all group 
>>> boxes are set to flat and likely some will be missed in the future.
>> 
>> Just to be sure: the method relies on the particular creation process of 
>> panels by the Preferences dialog, right? It can probably be adapted for the 
>> Document Settings dialog but would not (easily) work on the lowesy 
>> (application) level.
> 
> Yes, the method enumerates the child widgets after initial UI setup. This 
> method works for the Preferences dialog as the code is placed there.
> 
> Other methods I can imagine would be:
> 1. put the code at a lower level of the class hierarchy for dialogs and make 
> it more general that way or
> 2. create a own GUI class derived from QGroupbox, override the init code and 
> use that instead of the Qt class (don’t know how to do this in designer)

Next patch with more general scope - I’ve moved the code to dialog factory 
utility GuiView::findOrBuild().

Stephan


GuiViewGroupBoxesFlat.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Stephan Witt]

Am 04.08.2020 um 05:36 schrieb Daniel :
> 
> On 2020-08-04 00:03, Daniel wrote:
>> On 2020-08-03 22:43, Stephan Witt wrote:
>>> Am 03.08.2020 um 16:52 schrieb Daniel :
 
 On 3/8/20 16:20, Jürgen Spitzmüller wrote:
> Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
>> Thanks. I hope you did not compile the list manually. :)
> No: grep setFlat *.h
>> I was actually hoping that there could be a general way to affect all
>> boxes with "one" call. But if my search for this does not bear
>> fruit, I'll resort to the manual solution.
> I doubt you can do this generally.
 
 Seemed to me like something one should be able to do. But probably I will 
 need to ask on stackexchange…
>>> 
>>> Something like the attached patch? It’s only a hack for the preferences to 
>>> get the idea.
>>> 
>>> This can be put in a helper method and called when it seems appropriate.
>>> 
>>> Stephan
>>> 
>>> 
>> Nice! It seems to work as expected. And I think it improves the readability 
>> of the preferences on mac. My hunch is that we would want the analogue for 
>> every other OS but with "setFlat(true)" because currently not all group 
>> boxes are set to flat and likely some will be missed in the future.
> 
> Just to be sure: the method relies on the particular creation process of 
> panels by the Preferences dialog, right? It can probably be adapted for the 
> Document Settings dialog but would not (easily) work on the lowesy 
> (application) level.

Yes, the method enumerates the child widgets after initial UI setup. This 
method works for the Preferences dialog as the code is placed there.

Other methods I can imagine would be:
1. put the code at a lower level of the class hierarchy for dialogs and make it 
more general that way or
2. create a own GUI class derived from QGroupbox, override the init code and 
use that instead of the Qt class (don’t know how to do this in designer)

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-04 00:03, Daniel wrote:

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I 
will need to ask on stackexchange…


Something like the attached patch? It’s only a hack for the 
preferences to get the idea.


This can be put in a helper method and called when it seems appropriate.

Stephan




Nice! It seems to work as expected. And I think it improves the 
readability of the preferences on mac. My hunch is that we would want 
the analogue for every other OS but with "setFlat(true)" because 
currently not all group boxes are set to flat and likely some will be 
missed in the future.


Just to be sure: the method relies on the particular creation process of 
panels by the Preferences dialog, right? It can probably be adapted for 
the Document Settings dialog but would not (easily) work on the lowesy 
(application) level.


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I will need 
to ask on stackexchange…


Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan




Nice! It seems to work as expected. And I think it improves the 
readability of the preferences on mac. My hunch is that we would want 
the analogue for every other OS but with "setFlat(true)" because 
currently not all group boxes are set to flat and likely some will be 
missed in the future.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Stephan Witt]

Am 03.08.2020 um 16:52 schrieb Daniel :
> 
> On 3/8/20 16:20, Jürgen Spitzmüller wrote:
>> Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
>>> Thanks. I hope you did not compile the list manually. :)
>> No: grep setFlat *.h
>>> I was actually hoping that there could be a general way to affect all
>>> boxes with "one" call. But if my search for this does not bear
>>> fruit, I'll resort to the manual solution.
>> I doubt you can do this generally.
> 
> Seemed to me like something one should be able to do. But probably I will 
> need to ask on stackexchange…

Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan


QGroupBox-setFlat.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jean-Marc Lasgouttes]

Le 3 août 2020 13:28:47 GMT+02:00, "Jürgen Spitzmüller"  a écrit 
:
>This should be possible with some effort. We need to set the flat
>property in the *.cpp files rather than in the layout files (where is
>is set now, via Qt Designer). We could add a new boolean member
>useFlatGB() to support/os.h which returns true by default and false for
>Mac. Then it would be just adding a lot of
>
>xxxGB->SetFlat(os::useFlatGB());

The new helper should not be in os.h, which is not for UI. It should live in 
GuiApplication and depend either on the Qt frontend (I do not remember the 
names) or the current style name

JMarc

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)


No: grep setFlat *.h


I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.


I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I 
will need to ask on stackexchange...


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
> Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

> I was actually hoping that there could be a general way to affect all
> boxes with "one" call. But if my search for this does not bear
> fruit, I'll resort to the manual solution.

I doubt you can do this generally.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 3/8/20 13:28, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 11:51 +0200 schrieb Daniel:

More complicated might be to force all group boxes (for macOS) to
non-flat mode. I'll have to research about how that could be done.


This should be possible with some effort. We need to set the flat
property in the *.cpp files rather than in the layout files (where is
is set now, via Qt Designer). We could add a new boolean member
useFlatGB() to support/os.h which returns true by default and false for
Mac. Then it would be just adding a lot of

xxxGB->SetFlat(os::useFlatGB());

These are affected if you feel like having a go:

ui_BiblioUi.h:CiteStyleBG->setFlat(true);
ui_BiblioUi.h:BiblioStyleBG->setFlat(true);
ui_BiblioUi.h:bibtexGB->setFlat(true);
ui_BibtexUi.h:bibGB->setFlat(true);
ui_BibtexUi.h:optionsGB->setFlat(true);
ui_BoxUi.h:TypesizeGB->setFlat(true);
ui_BoxUi.h:AlignmentGB->setFlat(true);
ui_BoxUi.h:DecorationGB->setFlat(true);
ui_BoxUi.h:colorGB->setFlat(true);
ui_CharacterUi.h:groupBox->setFlat(true);
ui_CharacterUi.h:groupBox_2->setFlat(true);
ui_CharacterUi.h:groupBox_4->setFlat(true);
ui_CharacterUi.h:groupBox_3->setFlat(true);
ui_CitationUi.h:FormattingGB->setFlat(true);
ui_ColorUi.h:fontcolorGB->setFlat(true);
ui_ColorUi.h:backgroundGB->setFlat(true);
ui_CompareHistoryUi.h:groupBox->setFlat(true);
ui_CompareUi.h:groupBox->setFlat(true);
ui_ExternalUi.h:GroupBox3->setFlat(true);
ui_ExternalUi.h:optionsGB->setFlat(true);
ui_ExternalUi.h:displayGB->setFlat(true);
ui_ExternalUi.h:rotationGB->setFlat(true);
ui_ExternalUi.h:scaleGB->setFlat(true);
ui_ExternalUi.h:cropGB->setFlat(true);
ui_FindAndReplaceUi.h:groupBox_2->setFlat(true);
ui_FloatPlacementUi.h:aligmentGB->setFlat(true);
ui_FloatPlacementUi.h:optionsGB->setFlat(true);
ui_FloatPlacementUi.h:groupBox->setFlat(true);
ui_GraphicsUi.h:sizeGB->setFlat(true);
ui_GraphicsUi.h:rotationGB->setFlat(true);
ui_GraphicsUi.h:displayGB->setFlat(true);
ui_GraphicsUi.h:graphicsGroupGB->setFlat(true);
ui_HyperlinkUi.h:typeGB->setFlat(true);
ui_IncludeUi.h:listingsGB->setFlat(true);
ui_IndicesUi.h:indexGB->setFlat(true);
ui_LaTeXUi.h:groupBox->setFlat(true);
ui_LaTeXUi.h:optionsGB->setFlat(true);
ui_LaTeXUi.h:childDocGB->setFlat(true);
ui_ListingsSettingsUi.h:packageGB->setFlat(true);
ui_ListingsUi.h:placementGB->setFlat(true);
ui_ListingsUi.h:numberstyleGB->setFlat(true);
ui_ListingsUi.h:basicstyleGB->setFlat(true);
ui_ListingsUi.h:languageGB->setFlat(true);
ui_ListingsUi.h:rangeGB->setFlat(true);
ui_ListingsUi.h:listingsGB->setFlat(true);
ui_LyXFilesUi.h:filterGB->setFlat(true);
ui_MasterChildUi.h:includeonlyGB->setFlat(true);
ui_MathMatrixUi.h:alignmentGB->setFlat(true);
ui_MathMatrixUi.h:decorationtGB->setFlat(true);
ui_OutputUi.h:outputFormatGB->setFlat(true);
ui_OutputUi.h:savingGB->setFlat(true);
ui_OutputUi.h:outputsyncCB->setFlat(true);
ui_OutputUi.h:xhtmlGB->setFlat(true);
ui_PageLayoutUi.h:paperFormatGB->setFlat(true);
ui_PageLayoutUi.h:pageLayoutGB->setFlat(true);
ui_ParagraphUi.h:groupBox->setFlat(true);
ui_ParagraphUi.h:aligmentGB->setFlat(true);
ui_ParagraphUi.h:labelwidthGB->setFlat(true);
ui_PDFSupportUi.h:use_hyperrefGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_2->setFlat(true);
ui_PDFSupportUi.h:bookmarksGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_3->setFlat(true);
ui_PhantomUi.h:PhantomBG->setFlat(true);
ui_PrefCompletionUi.h:groupBox_3->setFlat(true);
ui_PrefCompletionUi.h:groupBox_2->setFlat(true);
ui_PrefCompletionUi.h:groupBox_4->setFlat(true);
ui_PrefConvertersUi.h:converterDefGB->setFlat(true);
ui_PrefConvertersUi.h:cacheGB->setFlat(true);
ui_PrefConvertersUi.h:securityGB->setFlat(true);
ui_PrefDocHandlingUi.h:GeometryGB->setFlat(true);
ui_PrefDocHandlingUi.h:documentsGB->setFlat(true);
ui_PrefDocHandlingUi.h:tabsGB->setFlat(true);
ui_PrefEditUi.h:scrollGB->setFlat(true);
ui_PrefEditUi.h:fullscreenGB->setFlat(true);
ui_PrefEditUi.h:fullscreenLimitGB->setFlat(true);
ui_PrefFileformatsUi.h:defaultFormatGB->setFlat(true);
ui_PrefInputUi.h:keyboardGB->setFlat(true);
ui_PrefInputUi.h:mouseGB->setFlat(true);
ui_PrefInputUi.h:scrollzoomGB->setFlat(true);
ui_PrefLanguageUi.h:rtlGB2->setFlat(true);
ui_PrefLatexUi.h:bibtexGB->setFlat(true);
ui_PrefLatexUi.h:indexGB->setFlat(true);
ui_PrefLatexUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:groupBox->setFlat(true);

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Montag, den 03.08.2020, 11:51 +0200 schrieb Daniel:
> More complicated might be to force all group boxes (for macOS) to 
> non-flat mode. I'll have to research about how that could be done.

This should be possible with some effort. We need to set the flat
property in the *.cpp files rather than in the layout files (where is
is set now, via Qt Designer). We could add a new boolean member
useFlatGB() to support/os.h which returns true by default and false for
Mac. Then it would be just adding a lot of

xxxGB->SetFlat(os::useFlatGB());

These are affected if you feel like having a go:

ui_BiblioUi.h:CiteStyleBG->setFlat(true);
ui_BiblioUi.h:BiblioStyleBG->setFlat(true);
ui_BiblioUi.h:bibtexGB->setFlat(true);
ui_BibtexUi.h:bibGB->setFlat(true);
ui_BibtexUi.h:optionsGB->setFlat(true);
ui_BoxUi.h:TypesizeGB->setFlat(true);
ui_BoxUi.h:AlignmentGB->setFlat(true);
ui_BoxUi.h:DecorationGB->setFlat(true);
ui_BoxUi.h:colorGB->setFlat(true);
ui_CharacterUi.h:groupBox->setFlat(true);
ui_CharacterUi.h:groupBox_2->setFlat(true);
ui_CharacterUi.h:groupBox_4->setFlat(true);
ui_CharacterUi.h:groupBox_3->setFlat(true);
ui_CitationUi.h:FormattingGB->setFlat(true);
ui_ColorUi.h:fontcolorGB->setFlat(true);
ui_ColorUi.h:backgroundGB->setFlat(true);
ui_CompareHistoryUi.h:groupBox->setFlat(true);
ui_CompareUi.h:groupBox->setFlat(true);
ui_ExternalUi.h:GroupBox3->setFlat(true);
ui_ExternalUi.h:optionsGB->setFlat(true);
ui_ExternalUi.h:displayGB->setFlat(true);
ui_ExternalUi.h:rotationGB->setFlat(true);
ui_ExternalUi.h:scaleGB->setFlat(true);
ui_ExternalUi.h:cropGB->setFlat(true);
ui_FindAndReplaceUi.h:groupBox_2->setFlat(true);
ui_FloatPlacementUi.h:aligmentGB->setFlat(true);
ui_FloatPlacementUi.h:optionsGB->setFlat(true);
ui_FloatPlacementUi.h:groupBox->setFlat(true);
ui_GraphicsUi.h:sizeGB->setFlat(true);
ui_GraphicsUi.h:rotationGB->setFlat(true);
ui_GraphicsUi.h:displayGB->setFlat(true);
ui_GraphicsUi.h:graphicsGroupGB->setFlat(true);
ui_HyperlinkUi.h:typeGB->setFlat(true);
ui_IncludeUi.h:listingsGB->setFlat(true);
ui_IndicesUi.h:indexGB->setFlat(true);
ui_LaTeXUi.h:groupBox->setFlat(true);
ui_LaTeXUi.h:optionsGB->setFlat(true);
ui_LaTeXUi.h:childDocGB->setFlat(true);
ui_ListingsSettingsUi.h:packageGB->setFlat(true);
ui_ListingsUi.h:placementGB->setFlat(true);
ui_ListingsUi.h:numberstyleGB->setFlat(true);
ui_ListingsUi.h:basicstyleGB->setFlat(true);
ui_ListingsUi.h:languageGB->setFlat(true);
ui_ListingsUi.h:rangeGB->setFlat(true);
ui_ListingsUi.h:listingsGB->setFlat(true);
ui_LyXFilesUi.h:filterGB->setFlat(true);
ui_MasterChildUi.h:includeonlyGB->setFlat(true);
ui_MathMatrixUi.h:alignmentGB->setFlat(true);
ui_MathMatrixUi.h:decorationtGB->setFlat(true);
ui_OutputUi.h:outputFormatGB->setFlat(true);
ui_OutputUi.h:savingGB->setFlat(true);
ui_OutputUi.h:outputsyncCB->setFlat(true);
ui_OutputUi.h:xhtmlGB->setFlat(true);
ui_PageLayoutUi.h:paperFormatGB->setFlat(true);
ui_PageLayoutUi.h:pageLayoutGB->setFlat(true);
ui_ParagraphUi.h:groupBox->setFlat(true);
ui_ParagraphUi.h:aligmentGB->setFlat(true);
ui_ParagraphUi.h:labelwidthGB->setFlat(true);
ui_PDFSupportUi.h:use_hyperrefGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_2->setFlat(true);
ui_PDFSupportUi.h:bookmarksGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_3->setFlat(true);
ui_PhantomUi.h:PhantomBG->setFlat(true);
ui_PrefCompletionUi.h:groupBox_3->setFlat(true);
ui_PrefCompletionUi.h:groupBox_2->setFlat(true);
ui_PrefCompletionUi.h:groupBox_4->setFlat(true);
ui_PrefConvertersUi.h:converterDefGB->setFlat(true);
ui_PrefConvertersUi.h:cacheGB->setFlat(true);
ui_PrefConvertersUi.h:securityGB->setFlat(true);
ui_PrefDocHandlingUi.h:GeometryGB->setFlat(true);
ui_PrefDocHandlingUi.h:documentsGB->setFlat(true);
ui_PrefDocHandlingUi.h:tabsGB->setFlat(true);
ui_PrefEditUi.h:scrollGB->setFlat(true);
ui_PrefEditUi.h:fullscreenGB->setFlat(true);
ui_PrefEditUi.h:fullscreenLimitGB->setFlat(true);
ui_PrefFileformatsUi.h:defaultFormatGB->setFlat(true);
ui_PrefInputUi.h:keyboardGB->setFlat(true);
ui_PrefInputUi.h:mouseGB->setFlat(true);
ui_PrefInputUi.h:scrollzoomGB->setFlat(true);
ui_PrefLanguageUi.h:rtlGB2->setFlat(true);
ui_PrefLatexUi.h:bibtexGB->setFlat(true);
ui_PrefLatexUi.h:indexGB->setFlat(true);
ui_PrefLatexUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:

Re: Groupbox layout

[Daniel]

On 2/8/20 17:17, Yu Jin wrote:
Am So., 2. Aug. 2020 um 15:51 Uhr schrieb Daniel >:


On 2020-08-02 14:08, Jürgen Spitzmüller wrote:
 > Am Sonntag, den 02.08.2020, 10:30 +0200 schrieb Daniel:
 >> I suggest to add bold to groupbox titles. This is
 >> also how it is done in Libre Office and MS Office.
 >
 > This is a style choice. Here (GTK Adwaita Style), they are bold.

So, at least it is not necessary to apply bold on all WMs. That leaves
at least macOS (and maybe Windows).

Here is how I see the situation: LyX is moving away from the default
(non-flat) styling of group boxes. On macOS there is no style guide for
such boxes. Hence the qt team does the styling. They did not give it
much love. So, I think it's up to LyX to take care of this because
otherwise the user is left in the UI-dust. Maybe a bold should be
applied for macOS only (and maybe Windows) then?

I attached a screenshot showing how it looks on Windows. It's not too 
bad imho.


Yes, that looks more acceptable than on macOS. But it is a bit 
unsatisfactory that it looks only "not too bad". I have not seen this 
style in Windows 10 anywhere else than in LyX.


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 3/8/20 11:51, Daniel wrote:

On 3/8/20 10:10, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:

That's exactly what I am saying. We should apply a fix to the style!


How do you want to do that? The style is not provided by us.


I am not sure. I am not at the mac currently, so I can't try for now. 
But I'll do later.


Probably the easiest would be a style on the application applied only 
for macOS (and maybe Windows):


QGroupBox::title {font-weight: bold;}

More complicated might be to force all group boxes (for macOS) to 
non-flat mode. I'll have to research about how that could be done.


Being able to do the latter would also be cool because it would allow us 
to switch all groupboxes (except on macOS) to flat (and maybe back once 
it goes out of fashion) without ending up with a mixed-up user interface 
(some flat some not).


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 3/8/20 10:10, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:

That's exactly what I am saying. We should apply a fix to the style!


How do you want to do that? The style is not provided by us.


I am not sure. I am not at the mac currently, so I can't try for now. 
But I'll do later.


Probably the easiest would be a style on the application applied only 
for macOS (and maybe Windows):


QGroupBox::title {font-weight: bold;}

More complicated might be to force all group boxes (for macOS) to 
non-flat mode. I'll have to research about how that could be done.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:
> That's exactly what I am saying. We should apply a fix to the style!

How do you want to do that? The style is not provided by us.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-03 07:55, Jürgen Spitzmüller wrote:

Am Sonntag, den 02.08.2020, 19:40 +0200 schrieb Daniel:

The people who designed the Qt mac style didn't think much about flat

group boxes. I am quite certain. In particular when they did not have

any guide from Apple how it should be done since Apple does not
support

flat group boxes. Apple is very much about uniformity when it comes
to

style, I think. And it's not like the Qt people couldn't have better

things to do than take care of a non-default style on mac given the

great amount of unresolved Qt bugs.


The people who design the styles are not necessarily the people who fix
Qt bugs.

I think if flat group boxes are not used on Mac, they should link them
to non-flat ones.

I any case this is an issue in the style and should be fixed there.


That's exactly what I am saying. We should apply a fix to the style!

Or do you mean: Qt should fix the style but not LyX? I think there have 
been several Qt bugs that LyX has worked around in the past, so I don't 
see why this one is special. It might take Qt a long time to fix such 
an, arguably, secondary problem (since the usage of flat groupboxes are 
uncommon on macOS). It seems like an obvious problem but no one seems to 
have bothered for now. I think that's due to people not using the flat 
style group boxes, for example, Scribus does not. IMO, if it is rather 
easy, we should do something about it in the meanwhile.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Sonntag, den 02.08.2020, 19:40 +0200 schrieb Daniel:
> The people who designed the Qt mac style didn't think much about flat
> 
> group boxes. I am quite certain. In particular when they did not have
> 
> any guide from Apple how it should be done since Apple does not
> support
> 
> flat group boxes. Apple is very much about uniformity when it comes
> to
> 
> style, I think. And it's not like the Qt people couldn't have better
> 
> things to do than take care of a non-default style on mac given the
> 
> great amount of unresolved Qt bugs.

The people who design the styles are not necessarily the people who fix
Qt bugs.

I think if flat group boxes are not used on Mac, they should link them
to non-flat ones.

I any case this is an issue in the style and should be fixed there.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-02 17:53, Jürgen Spitzmüller wrote:

Am Sonntag, den 02.08.2020, 17:53 +0200 schrieb Jürgen Spitzmüller:

As said repeatedly over the last days, I am very reluctant to
overpaint
Qt style decisions. The people who designed the Qt windows style
probably had a reason to not embolden the header (or, otherwise, this
should be fixed in the style).


Mac style here, of course.


I am not giving up yet. :)

I understand the general idea. And it is nice that everything looks fine
on your WM. On macOS there is no choice.

I can only point at the screen capture I send from macOS. It doesn't
look right to me at all. And apparently it does not look right according
to any other app I tried on macOS. None has this style.

The people who designed the Qt mac style didn't think much about flat
group boxes. I am quite certain. In particular when they did not have
any guide from Apple how it should be done since Apple does not support
flat group boxes. Apple is very much about uniformity when it comes to
style, I think. And it's not like the Qt people couldn't have better
things to do than take care of a non-default style on mac given the
great amount of unresolved Qt bugs.

All Qt apps I tested use the default group box not the flat one. And
those (non-Qt) apps that use a flat style all style the group box header
bold.

I think it's okay to go for non-default styles (flat group box). But
there can be kinks in the styles then that needs fixing.

Daniel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Sonntag, den 02.08.2020, 17:53 +0200 schrieb Jürgen Spitzmüller:
> As said repeatedly over the last days, I am very reluctant to
> overpaint
> Qt style decisions. The people who designed the Qt windows style
> probably had a reason to not embolden the header (or, otherwise, this
> should be fixed in the style).

Mac style here, of course.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Sonntag, den 02.08.2020, 15:51 +0200 schrieb Daniel:
> So, at least it is not necessary to apply bold on all WMs. That
> leaves 
> 
> at least macOS (and maybe Windows).
> 
> 
> 
> Here is how I see the situation: LyX is moving away from the default 
> 
> (non-flat) styling of group boxes. On macOS there is no style guide
> for 
> 
> such boxes. Hence the qt team does the styling. They did not give it 
> 
> much love. So, I think it's up to LyX to take care of this because 
> 
> otherwise the user is left in the UI-dust. Maybe a bold should be 
> 
> applied for macOS only (and maybe Windows) then?

As said repeatedly over the last days, I am very reluctant to overpaint
Qt style decisions. The people who designed the Qt windows style
probably had a reason to not embolden the header (or, otherwise, this
should be fixed in the style).

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Yu Jin]

Am So., 2. Aug. 2020 um 15:51 Uhr schrieb Daniel :

> On 2020-08-02 14:08, Jürgen Spitzmüller wrote:
> > Am Sonntag, den 02.08.2020, 10:30 +0200 schrieb Daniel:
> >> I suggest to add bold to groupbox titles. This is
> >> also how it is done in Libre Office and MS Office.
> >
> > This is a style choice. Here (GTK Adwaita Style), they are bold.
>
> So, at least it is not necessary to apply bold on all WMs. That leaves
> at least macOS (and maybe Windows).
>
> Here is how I see the situation: LyX is moving away from the default
> (non-flat) styling of group boxes. On macOS there is no style guide for
> such boxes. Hence the qt team does the styling. They did not give it
> much love. So, I think it's up to LyX to take care of this because
> otherwise the user is left in the UI-dust. Maybe a bold should be
> applied for macOS only (and maybe Windows) then?
>

I attached a screenshot showing how it looks on Windows. It's not too bad
imho.

-- 
Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Daniel]

On 2020-08-02 14:08, Jürgen Spitzmüller wrote:

Am Sonntag, den 02.08.2020, 10:30 +0200 schrieb Daniel:

I suggest to add bold to groupbox titles. This is
also how it is done in Libre Office and MS Office.


This is a style choice. Here (GTK Adwaita Style), they are bold.


So, at least it is not necessary to apply bold on all WMs. That leaves 
at least macOS (and maybe Windows).


Here is how I see the situation: LyX is moving away from the default 
(non-flat) styling of group boxes. On macOS there is no style guide for 
such boxes. Hence the qt team does the styling. They did not give it 
much love. So, I think it's up to LyX to take care of this because 
otherwise the user is left in the UI-dust. Maybe a bold should be 
applied for macOS only (and maybe Windows) then?


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

[Jürgen Spitzmüller]

Am Sonntag, den 02.08.2020, 10:30 +0200 schrieb Daniel:
> I suggest to add bold to groupbox titles. This is 
> also how it is done in Libre Office and MS Office.

This is a style choice. Here (GTK Adwaita Style), they are bold.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel