[MediaWiki-commits] [Gerrit] Fixing role for amssq48-62, reverting amssq47 change - change (operations/puppet)

2013-10-09 Thread Cmjohnson (Code Review)
Cmjohnson has submitted this change and it was merged.

Change subject: Fixing role for amssq48-62, reverting amssq47 change
..


Fixing role for amssq48-62, reverting amssq47 change

Change-Id: I41d859a1eef6cfe52fdad73d0830968d5605a645
---
M manifests/site.pp
1 file changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Cmjohnson: Looks good to me, approved
  Mark Bergsma: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/manifests/site.pp b/manifests/site.pp
index 426868f..45ecb45 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -115,14 +115,19 @@
 include role::cache::text
 }
 
-# amssq47-62 are text varnish
-node /amssq(4[7-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
-include role::cache::text
+# amssq47 is a text varnish
+node /^amssq47\.esams\.wikimedia\.org$/ {
+include role::cache::text, role::cache::ssl::unified
 
 interface::add_ip6_mapped { "main": }
 }
 
+# amssq48-62 are text varnish
+node /^amssq(4[8-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
+include role::cache::varnish::text
 
+interface::add_ip6_mapped { "main": }
+}
 
 # analytics1001.wikimedia.org has a public IP
 node "analytics1001.wikimedia.org" {

-- 
To view, visit https://gerrit.wikimedia.org/r/88744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41d859a1eef6cfe52fdad73d0830968d5605a645
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 
Gerrit-Reviewer: Cmjohnson 
Gerrit-Reviewer: Mark Bergsma 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove upstream definition as we only connect to localhost - change (operations/puppet)

2013-10-09 Thread Mark Bergsma (Code Review)
Mark Bergsma has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88747


Change subject: Remove upstream definition as we only connect to localhost
..

Remove upstream definition as we only connect to localhost

Change-Id: I02d2869ae3502f4f9b726e692d9104b04e1e4764
---
M modules/protoproxy/templates/localssl.erb
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/47/88747/1

diff --git a/modules/protoproxy/templates/localssl.erb 
b/modules/protoproxy/templates/localssl.erb
index 3f6e95b..55f99ff 100644
--- a/modules/protoproxy/templates/localssl.erb
+++ b/modules/protoproxy/templates/localssl.erb
@@ -1,12 +1,6 @@
 # Proxy site configuration file for <%= name %>
 # This file is managed by Puppet!
 
-upstream localhost {
-   # max fails is ignored when using one host, so we use the same host 
twice
-   server 127.0.0.1:<%= @upstream_port %>;
-   server 127.0.0.1:<%= @upstream_port %>;
-}
-
 # SSL proxying
 server {
listen [::]:443 ssl;
@@ -21,7 +15,7 @@
keepalive_timeout 60;
 
location / {
-   proxy_pass http://localhost;
+   proxy_pass http://127.0.0.1:<%= @upstream_port %>;
 
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;

-- 
To view, visit https://gerrit.wikimedia.org/r/88747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02d2869ae3502f4f9b726e692d9104b04e1e4764
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] load ValueView when Wikibase is installed via composer - change (mediawiki...Wikibase)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88746


Change subject: load ValueView when Wikibase is installed via composer
..

load ValueView when Wikibase is installed via composer

Change-Id: Ic2bf7b0159091cb7c2c73406264f734adb1dcf75
---
M lib/WikibaseLib.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/46/88746/1

diff --git a/lib/WikibaseLib.php b/lib/WikibaseLib.php
index eaa7e7a..3ca4d05 100644
--- a/lib/WikibaseLib.php
+++ b/lib/WikibaseLib.php
@@ -79,7 +79,12 @@
@include_once( __DIR__ . '/../../DataValues/ValueView/ValueView.php' );
 }
 
-// Include the ValueView library if that hasn't been done yet.
+// Include the ValueView library is Wikibase is installed via composer.
+if ( !defined( 'VALUEVIEW_VERSION' ) ) {
+   @include_once( __DIR__ . 
'/../vendor/data-values/data-values/ValueView/ValueView.php' );
+}
+
+// Include the ValueView library if that hasn't been done yet. (e.g. using 
Wikibase build)
 if ( !defined( 'VALUEVIEW_VERSION' ) ) {
@include_once( __DIR__ . 
'/../../../data-values/data-values/ValueView/ValueView.php' );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/88746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2bf7b0159091cb7c2c73406264f734adb1dcf75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Specify encoding of source files as utf-8 - change (integration/jenkins-job-builder-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Specify encoding of source files as utf-8
..


Specify encoding of source files as utf-8

Per
http://pear.php.net/manual/en/package.php.php-codesniffer.advanced-usage.php.

Shell script wrapper update is: https://gerrit.wikimedia.org/r/88745

Bug: 55508
Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
---
M macro.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/macro.yaml b/macro.yaml
index f8d481e..abf48a9 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -313,6 +313,7 @@
 builders:
  - shell: |
 phpcs -v -s . \
+ --encoding=utf-8 \
  --standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \
  --extensions=php,inc \
  --ignore=languages/messages/Messages*.php,*.i18n.php \
@@ -334,6 +335,7 @@
 fi
 
 phpcs -v -s $PHPCS_FILES \
+ --encoding=utf-8 \
  --standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \
  --ignore=languages/messages/Messages,*.i18n.php \
  --report-checkstyle=checkstyle-phpcs.xml \

-- 
To view, visit https://gerrit.wikimedia.org/r/88743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
Gerrit-PatchSet: 3
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] run-phpcs-mw: Specify encoding of source files as utf-8 - change (integration/jenkins)

2013-10-09 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: run-phpcs-mw: Specify encoding of source files as utf-8
..


run-phpcs-mw: Specify encoding of source files as utf-8

Port of https://gerrit.wikimedia.org/r/#/c/88743 against JJB macro:

Per
http://pear.php.net/manual/en/package.php.php-codesniffer.advanced-usage.php.
Bug: 55508

Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
---
M bin/run-phpcs-mw.sh
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved



diff --git a/bin/run-phpcs-mw.sh b/bin/run-phpcs-mw.sh
index db62d81..9f2266e 100755
--- a/bin/run-phpcs-mw.sh
+++ b/bin/run-phpcs-mw.sh
@@ -82,6 +82,7 @@
 echo "Starting PHPCS..."
 set -xe
 phpcs -v -s $PHPCS_FILES \
+   --encoding=utf-8 \
--standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \
$PHPCS_OPTS \
--ignore=$IGNORE_WITH_SEP \

-- 
To view, visit https://gerrit.wikimedia.org/r/88745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] run-phpcs-mw: Specify encoding of source files as utf-8 - change (integration/jenkins)

2013-10-09 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88745


Change subject: run-phpcs-mw: Specify encoding of source files as utf-8
..

run-phpcs-mw: Specify encoding of source files as utf-8

Port of https://gerrit.wikimedia.org/r/#/c/88743 against JJB macro:

Per
http://pear.php.net/manual/en/package.php.php-codesniffer.advanced-usage.php.
Bug: 55508

Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
---
M bin/run-phpcs-mw.sh
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins 
refs/changes/45/88745/1

diff --git a/bin/run-phpcs-mw.sh b/bin/run-phpcs-mw.sh
index db62d81..9f2266e 100755
--- a/bin/run-phpcs-mw.sh
+++ b/bin/run-phpcs-mw.sh
@@ -82,6 +82,7 @@
 echo "Starting PHPCS..."
 set -xe
 phpcs -v -s $PHPCS_FILES \
+   --encoding=utf-8 \
--standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \
$PHPCS_OPTS \
--ignore=$IGNORE_WITH_SEP \

-- 
To view, visit https://gerrit.wikimedia.org/r/88745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Disable jquery.ime for VE till IME support is improved - change (mediawiki...UniversalLanguageSelector)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Disable jquery.ime for VE till IME support is improved
..


Disable jquery.ime for VE till IME support is improved

Bug: 55492
Change-Id: I30cffd94413b50bb57a403a9d06dbc0498a02d0a
---
M UniversalLanguageSelector.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php
index 7da0f49..fa50ef8 100644
--- a/UniversalLanguageSelector.php
+++ b/UniversalLanguageSelector.php
@@ -128,7 +128,7 @@
  *
  * @since 2013.07
  */
-$wgULSNoImeSelectors = array( '#wpCaptchaWord' );
+$wgULSNoImeSelectors = array( '#wpCaptchaWord', '.ve-ce-documentNode' );
 
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/88727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30cffd94413b50bb57a403a9d06dbc0498a02d0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Amire80 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixing role for amssq48-62, reverting amssq47 change - change (operations/puppet)

2013-10-09 Thread Cmjohnson (Code Review)
Cmjohnson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88744


Change subject: Fixing role for amssq48-62, reverting amssq47 change
..

Fixing role for amssq48-62, reverting amssq47 change

Change-Id: I41d859a1eef6cfe52fdad73d0830968d5605a645
---
M manifests/site.pp
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/44/88744/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 426868f..59ba8dc 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -115,14 +115,19 @@
 include role::cache::text
 }
 
-# amssq47-62 are text varnish
-node /amssq(4[7-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
-include role::cache::text
+# amssq47 is a text varnish
+node /^amssq47\.esams\.wikimedia\.org$/ {
+include role::cache::text, role::cache::ssl::unified
 
 interface::add_ip6_mapped { "main": }
 }
 
+# amssq48-62 are text varnish
+node /amssq(4[8-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
+include role::cache::varnish::text
 
+interface::add_ip6_mapped { "main": }
+}
 
 # analytics1001.wikimedia.org has a public IP
 node "analytics1001.wikimedia.org" {

-- 
To view, visit https://gerrit.wikimedia.org/r/88744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41d859a1eef6cfe52fdad73d0830968d5605a645
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Specify encoding of source files as utf-8 - change (integration/jenkins-job-builder-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88743


Change subject: Specify encoding of source files as utf-8
..

Specify encoding of source files as utf-8

Per
http://pear.php.net/manual/en/package.php.php-codesniffer.advanced-usage.php.

Bug: 55508
Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
---
M macro.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/43/88743/1

diff --git a/macro.yaml b/macro.yaml
index f8d481e..635b29f 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -313,6 +313,7 @@
 builders:
  - shell: |
 phpcs -v -s . \
+ --encoding=utf-8 \
  --standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \
  --extensions=php,inc \
  --ignore=languages/messages/Messages*.php,*.i18n.php \

-- 
To view, visit https://gerrit.wikimedia.org/r/88743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44f42262d709b2b9ad876bdf9fc44fb5e3dfff09
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] this fixes the Math test and is needed for further Flow updates - change (qa/browsertests)

2013-10-09 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: this fixes the Math test and is needed for further Flow updates
..


this fixes the Math test and is needed for further Flow updates

Change-Id: Ibf84650c71f7363aab863ab5c70c71823eb3af55
---
M features/flow_anon.feature
M features/step_definitions/flow_steps.rb
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Zfilipin: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/features/flow_anon.feature b/features/flow_anon.feature
index 9507cf4..d35e4e7 100644
--- a/features/flow_anon.feature
+++ b/features/flow_anon.feature
@@ -7,5 +7,5 @@
 When I create a Title of Flow Topic in Flow new topic
   And I create a Body of Flow Topic into Flow body
   And I click New topic save
-Then the page should contain Title of Flow Topic
-  And the page should contain Body of Flow Topic
+Then the Flow page should contain Title of Flow Topic
+  And the Flow page should contain Body of Flow Topic
diff --git a/features/step_definitions/flow_steps.rb 
b/features/step_definitions/flow_steps.rb
index 729bff7..8f0af3f 100644
--- a/features/step_definitions/flow_steps.rb
+++ b/features/step_definitions/flow_steps.rb
@@ -22,7 +22,7 @@
   on(FlowPage).new_topic_save_element.when_present.click
 end
 
-Then(/^the page should contain (.+)$/) do |flow_topic|
+Then(/^the Flow page should contain (.+)$/) do |flow_topic|
   on(FlowPage) do |page|
 page.wait_until(20) do # 10 seconds wasn't enough on ee-flow...
   page.text.include? 'just now'

-- 
To view, visit https://gerrit.wikimedia.org/r/88741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf84650c71f7363aab863ab5c70c71823eb3af55
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 
Gerrit-Reviewer: Zfilipin 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] this fixes the Math test and is needed for further Flow updates - change (qa/browsertests)

2013-10-09 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88741


Change subject: this fixes the Math test and is needed for further Flow updates
..

this fixes the Math test and is needed for further Flow updates

Change-Id: Ibf84650c71f7363aab863ab5c70c71823eb3af55
---
M features/flow_anon.feature
M features/step_definitions/flow_steps.rb
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/41/88741/1

diff --git a/features/flow_anon.feature b/features/flow_anon.feature
index 9507cf4..d35e4e7 100644
--- a/features/flow_anon.feature
+++ b/features/flow_anon.feature
@@ -7,5 +7,5 @@
 When I create a Title of Flow Topic in Flow new topic
   And I create a Body of Flow Topic into Flow body
   And I click New topic save
-Then the page should contain Title of Flow Topic
-  And the page should contain Body of Flow Topic
+Then the Flow page should contain Title of Flow Topic
+  And the Flow page should contain Body of Flow Topic
diff --git a/features/step_definitions/flow_steps.rb 
b/features/step_definitions/flow_steps.rb
index 729bff7..8f0af3f 100644
--- a/features/step_definitions/flow_steps.rb
+++ b/features/step_definitions/flow_steps.rb
@@ -22,7 +22,7 @@
   on(FlowPage).new_topic_save_element.when_present.click
 end
 
-Then(/^the page should contain (.+)$/) do |flow_topic|
+Then(/^the Flow page should contain (.+)$/) do |flow_topic|
   on(FlowPage) do |page|
 page.wait_until(20) do # 10 seconds wasn't enough on ee-flow...
   page.text.include? 'just now'

-- 
To view, visit https://gerrit.wikimedia.org/r/88741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf84650c71f7363aab863ab5c70c71823eb3af55
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] isolating amssq47, changing role for amssq47-62 - change (operations/puppet)

2013-10-09 Thread Cmjohnson (Code Review)
Cmjohnson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88742


Change subject: isolating amssq47, changing role for amssq47-62
..

isolating amssq47, changing role for amssq47-62

Change-Id: Iba49c2824c6b95dadb5552854870f57df3225a18
---
M manifests/site.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/42/88742/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 426868f..16e096c 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -116,8 +116,8 @@
 }
 
 # amssq47-62 are text varnish
-node /amssq(4[7-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
-include role::cache::text
+node /amssq(47|4[8-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
+role::cache::varnish::text
 
 interface::add_ip6_mapped { "main": }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/88742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba49c2824c6b95dadb5552854870f57df3225a18
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update dependency version - change (mediawiki...Wikibase)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88740


Change subject: Update dependency version
..

Update dependency version

Change-Id: Ifbaf62fed028289ec34c28b290378411e69dab72
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/40/88740/1

diff --git a/composer.json b/composer.json
index 2fd5c39..7411cfa 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"data-values/data-values": "*",
"data-values/data-types": "*",
"wikibase/data-model": "*",
-"diff/diff": ">=0.6"
+"diff/diff": ">=0.9"
 },
"minimum-stability" : "dev",
"autoload": {

-- 
To view, visit https://gerrit.wikimedia.org/r/88740
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbaf62fed028289ec34c28b290378411e69dab72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update docs and @since tags - change (mediawiki...WikibaseQuery)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88739


Change subject: Update docs and @since tags
..

Update docs and @since tags

Change-Id: I7ad97df42ed03cbeef9930cb54112de062ca
---
M README.md
M src/Wikibase/Query/Api/EntitiesByPropertyValue.php
M src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
M src/Wikibase/Query/DIC/Builders/QueryInterfaceBuilder.php
M src/Wikibase/Query/DIC/Builders/QueryStoreBuilder.php
M src/Wikibase/Query/DIC/DependencyBuilder.php
M src/Wikibase/Query/DIC/DependencyManager.php
M src/Wikibase/Query/DIC/ExtensionAccess.php
M src/Wikibase/Query/DIC/WikibaseQuery.php
M src/Wikibase/Query/QueryEntityDeserializer.php
M src/Wikibase/Query/QueryEntitySerializer.php
M src/Wikibase/Query/Setup/ExtensionSetup.php
M src/Wikibase/Query/Setup/HookSetup.php
A src/Wikibase/Query/Setup/SchemaUpdater.php
M src/Wikibase/Query/Setup/WikibaseQueryBuilder.php
15 files changed, 31 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQuery 
refs/changes/39/88739/1

diff --git a/README.md b/README.md
index fe6a84a..6c0e117 100644
--- a/README.md
+++ b/README.md
@@ -17,11 +17,12 @@
 ## Requirements
 
 * PHP 5.3 or later
+* [Wikibase 
DataModel](https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/blob/master/README.md)
 0.5 or later
 * Wikibase Repo 0.5 or later
-* Wikibase QueryEngine 0.1 or later
-* Ask 1.x
-* DataValues 0.1 or later
-* Serialization 2.x
+* [Wikibase 
QueryEngine](https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/blob/master/README.md)
 0.1 or later
+* 
[Ask](https://github.com/wikimedia/mediawiki-extensions-Ask/blob/master/README.md)
 1.x
+* [DataValues](https://www.mediawiki.org/wiki/Extension:DataValues) 0.1 or 
later
+* 
[Serialization](https://github.com/wikimedia/mediawiki-extensions-Serialization/blob/master/README.md)
 2.x
 
 ## Installation
 
@@ -42,6 +43,13 @@
 }
 }
 
+## Technical documentation
+
+All classes provided by WikibaseQuery reside in the Wikibase\Query namespace.
+
+Public classes and interfaces have an @since tag denoting the version since 
which they can be accessed.
+Constructs without an @since tag are package private and should not be used by 
extensions.
+
 ## Tests
 
 This library comes with a set up PHPUnit tests that cover all non-trivial 
code. You can run these
diff --git a/src/Wikibase/Query/Api/EntitiesByPropertyValue.php 
b/src/Wikibase/Query/Api/EntitiesByPropertyValue.php
index 2224da2..d764d46 100644
--- a/src/Wikibase/Query/Api/EntitiesByPropertyValue.php
+++ b/src/Wikibase/Query/Api/EntitiesByPropertyValue.php
@@ -8,8 +8,6 @@
 use Wikibase\Query\DIC\ExtensionAccess;
 
 /**
- * @since 0.1
- *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  */
diff --git 
a/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php 
b/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
index 017c453..2308760 100644
--- a/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
+++ b/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
@@ -10,8 +10,6 @@
 use Wikibase\Repo\WikibaseRepo;
 
 /**
- * @since 1.0
- *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  */
diff --git a/src/Wikibase/Query/DIC/Builders/QueryInterfaceBuilder.php 
b/src/Wikibase/Query/DIC/Builders/QueryInterfaceBuilder.php
index 5fe27ef..18add69 100644
--- a/src/Wikibase/Query/DIC/Builders/QueryInterfaceBuilder.php
+++ b/src/Wikibase/Query/DIC/Builders/QueryInterfaceBuilder.php
@@ -9,8 +9,6 @@
 use Wikibase\Query\DIC\DependencyManager;
 
 /**
- * @since 1.0
- *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  */
diff --git a/src/Wikibase/Query/DIC/Builders/QueryStoreBuilder.php 
b/src/Wikibase/Query/DIC/Builders/QueryStoreBuilder.php
index 301eb9e..d2e0f1c 100644
--- a/src/Wikibase/Query/DIC/Builders/QueryStoreBuilder.php
+++ b/src/Wikibase/Query/DIC/Builders/QueryStoreBuilder.php
@@ -14,8 +14,6 @@
 use Wikibase\Repo\WikibaseRepo;
 
 /**
- * @since 1.0
- *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  */
diff --git a/src/Wikibase/Query/DIC/DependencyBuilder.php 
b/src/Wikibase/Query/DIC/DependencyBuilder.php
index 9e9793a..eaf7571 100644
--- a/src/Wikibase/Query/DIC/DependencyBuilder.php
+++ b/src/Wikibase/Query/DIC/DependencyBuilder.php
@@ -12,7 +12,7 @@
  *
  * Class based on suggestions by Tobias Schlitt.
  *
- * @since 1.0
+ * @since 0.1
  *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
diff --git a/src/Wikibase/Query/DIC/DependencyManager.php 
b/src/Wikibase/Query/DIC/DependencyManager.php
index 9dd0163..ebf6a41 100644
--- a/src/Wikibase/Query/DIC/DependencyManager.php
+++ b/src/Wikibase/Query/DIC/DependencyManager.php
@@ -17,7 +17,7 @@

[MediaWiki-commits] [Gerrit] two preferences removed, collapsible and experiments - change (qa/browsertests)

2013-10-09 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: two preferences removed, collapsible and experiments
..


two preferences removed, collapsible and experiments

Change-Id: Ic8e273ca94f85e609709190260b10dadbf00b416
---
M features/step_definitions/preferences_appearance_steps.rb
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Zfilipin: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/features/step_definitions/preferences_appearance_steps.rb 
b/features/step_definitions/preferences_appearance_steps.rb
index 0687b8a..f51ec89 100644
--- a/features/step_definitions/preferences_appearance_steps.rb
+++ b/features/step_definitions/preferences_appearance_steps.rb
@@ -37,8 +37,6 @@
 page.hidden_categories_check_element.should exist
 page.justify_paragraphs_check_element.should exist
 page.auto_number_check_element.should exist
-page.collapse_sidebar_vector_check_element.should exist
-page.exclude_from_experiments_check_element.should exist
   end
 end
 Then(/^I have Math options radio buttons$/) do

-- 
To view, visit https://gerrit.wikimedia.org/r/88738
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8e273ca94f85e609709190260b10dadbf00b416
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 
Gerrit-Reviewer: Zfilipin 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...Wikibase)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: update composer file
..


update composer file

Change-Id: I51ccc4793317f5a4370cfe6144605ea6f5eaa3cc
---
M composer.json
1 file changed, 39 insertions(+), 33 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index ac0dbba..e02e44c 100644
--- a/composer.json
+++ b/composer.json
@@ -1,34 +1,40 @@
 {
-  "name": "wikibase/wikibase",
-  "type": "mediawiki-extension",
-  "description": "Structured data repository for MediaWiki",
-  "keywords": [
-"wikibase",
-"wikidata",
-"wikibaselib",
-"wikibaseclient",
-"wikibaserepo"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Wikibase";,
-  "license": "GNU GPL v2+",
-  "authors": [
-{
-  "name": "The Wikidata team",
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Talk:Wikibase";,
-"wiki": "https://www.mediawiki.org/wiki/Wikibase";
-  },
-  "require": {
-"php": ">=5.3.0",
-"data-values/data-values": "dev-mw1.22-wmf21",
-"data-values/data-types": "dev-mw1.22-wmf21",
-"wikibase/data-model": "dev-mw1.22-wmf21",
-"diff/diff": "dev-mw1.22-wmf21"
-  },
-  "minimum-stability": "dev"
-}
\ No newline at end of file
+   "name": "wikibase/wikibase",
+   "type": "mediawiki-extension",
+   "description": "Structured data repository for MediaWiki",
+   "keywords": [
+   "wikibase",
+   "wikidata",
+   "wikibaselib",
+   "wikibaseclient",
+   "wikibaserepo"
+   ],
+   "homepage": "https://www.mediawiki.org/wiki/Wikibase";,
+   "license": "GNU GPL v2+",
+   "authors": [
+   {
+   "name": "The Wikidata team",
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": "https://www.mediawiki.org/wiki/Talk:Wikibase";,
+   "wiki": "https://www.mediawiki.org/wiki/Wikibase";
+   },
+   "require": {
+   "php": ">=5.3.0",
+   "data-values/data-values": "dev-mw1.22-wmf21",
+   "data-values/data-types": "dev-mw1.22-wmf21",
+   "wikibase/data-model": "dev-mw1.22-wmf21",
+   "diff/diff": "dev-mw1.22-wmf21"
+   },
+   "minimum-stability": "dev",
+   "autoload": {
+   "files" : [
+   "repo/Wikibase.php",
+   "client/WikibaseClient.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88737
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51ccc4793317f5a4370cfe6144605ea6f5eaa3cc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] two preferences removed, collapsible and experiments - change (qa/browsertests)

2013-10-09 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88738


Change subject: two preferences removed, collapsible and experiments
..

two preferences removed, collapsible and experiments

Change-Id: Ic8e273ca94f85e609709190260b10dadbf00b416
---
M features/step_definitions/preferences_appearance_steps.rb
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/38/88738/1

diff --git a/features/step_definitions/preferences_appearance_steps.rb 
b/features/step_definitions/preferences_appearance_steps.rb
index 0687b8a..f51ec89 100644
--- a/features/step_definitions/preferences_appearance_steps.rb
+++ b/features/step_definitions/preferences_appearance_steps.rb
@@ -37,8 +37,6 @@
 page.hidden_categories_check_element.should exist
 page.justify_paragraphs_check_element.should exist
 page.auto_number_check_element.should exist
-page.collapse_sidebar_vector_check_element.should exist
-page.exclude_from_experiments_check_element.should exist
   end
 end
 Then(/^I have Math options radio buttons$/) do

-- 
To view, visit https://gerrit.wikimedia.org/r/88738
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8e273ca94f85e609709190260b10dadbf00b416
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...DataValues)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: update composer file
..


update composer file

Change-Id: Icfd582336547883bfdee15c8c431186f23d791e2
---
M composer.json
1 file changed, 36 insertions(+), 34 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index b8f5488..07664a1 100644
--- a/composer.json
+++ b/composer.json
@@ -1,35 +1,37 @@
 {
-  "name": "data-values/data-values",
-  "type": "library",
-  "description": "A library containing definitions for various values (ie 
quantities, times, coordinates, etc)",
-  "keywords": [
-"datavalues",
-"valueparsers",
-"valueformatters",
-"datatypes",
-"valuevalidators",
-"wikidata"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:DataValues";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/mediawiki",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:DataValues";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:DataValues";
-  },
-  "require": {
-"php": ">=5.3.0"
-  },
-  "replace": {
-"mediawiki/data-values": "*"
-  }
-}
\ No newline at end of file
+   "name": "data-values/data-values",
+   "type": "library",
+   "description": "A library containing definitions for various values (ie 
quantities, times, coordinates, etc)",
+   "keywords": [
+   "datavalues",
+   "valueparsers",
+   "valueformatters",
+   "datatypes",
+   "valuevalidators",
+   "wikidata"
+   ],
+   "homepage": "https://www.mediawiki.org/wiki/Extension:DataValues";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/mediawiki",
+   "forum": 
"https://www.mediawiki.org/wiki/Extension_talk:DataValues";,
+   "wiki": "https://www.mediawiki.org/wiki/Extension:DataValues";
+   },
+   "require": {
+   "php": ">=5.3.0"
+   },
+   "autoload": {
+   "files" : [
+   "DataValues.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd582336547883bfdee15c8c431186f23d791e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...Diff)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: update composer file
..


update composer file

Change-Id: I88974766c2a72ac16d41c512a75e49b8b778bed5
---
M composer.json
1 file changed, 35 insertions(+), 30 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 4f40fc0..8aa5a3b 100644
--- a/composer.json
+++ b/composer.json
@@ -1,31 +1,36 @@
 {
-  "name": "diff/diff",
-  "type": "library",
-  "description": "Library for diffing, patching and representing differences 
between complex objects",
-  "keywords": [
-"diff",
-"wikidata"
-  ],
-  "homepage": "https://github.com/wikimedia/mediawiki-extensions-Diff";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:Diff";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:Diff";
-  },
-  "require": {
-"php": ">=5.3.0"
-  },
-  "require-dev": {
-"satooshi/php-coveralls": "dev-master"
-  }
-}
\ No newline at end of file
+   "name": "diff/diff",
+   "type": "library",
+   "description": "Library for diffing, patching and representing 
differences between complex objects",
+   "keywords": [
+   "diff",
+   "wikidata"
+   ],
+   "homepage": "https://github.com/wikimedia/mediawiki-extensions-Diff";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": "https://www.mediawiki.org/wiki/Extension_talk:Diff";,
+   "wiki": "https://www.mediawiki.org/wiki/Extension:Diff";
+   },
+   "require": {
+   "php": ">=5.3.0"
+   },
+   "require-dev": {
+   "satooshi/php-coveralls": "dev-master"
+   },
+   "autoload": {
+   "files" : [
+   "Diff.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88974766c2a72ac16d41c512a75e49b8b778bed5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...WikibaseDataModel)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: update composer file
..


update composer file

Change-Id: Ibb67be9f85ea1ba94d53e4a3e5685f55dddf6963
---
M composer.json
1 file changed, 35 insertions(+), 30 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 6977d37..be3bf02 100644
--- a/composer.json
+++ b/composer.json
@@ -1,31 +1,36 @@
 {
-  "name": "wikibase/data-model",
-  "type": "library",
-  "description": "PHP implementation of the Wikibase DataModel",
-  "keywords": [
-"Wikibase",
-"DataModel",
-"Wikidata"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:WikibaseDataModel";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";
-  },
-  "require": {
-"php": ">=5.3.0",
-"diff/diff": "dev-mw1.22-wmf21",
-"data-values/data-values": "dev-mw1.22-wmf21"
-  }
-}
\ No newline at end of file
+   "name": "wikibase/data-model",
+   "type": "library",
+   "description": "PHP implementation of the Wikibase DataModel",
+   "keywords": [
+   "Wikibase",
+   "DataModel",
+   "Wikidata"
+   ],
+   "homepage": 
"https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": 
"https://www.mediawiki.org/wiki/Extension_talk:WikibaseDataModel";,
+   "wiki": 
"https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";
+   },
+   "require": {
+   "php": ">=5.3.0",
+   "diff/diff": "dev-mw1.22-wmf21",
+   "data-values/data-values": "dev-mw1.22-wmf21"
+   },
+   "autoload": {
+   "files" : [
+   "WikibaseDataModel.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb67be9f85ea1ba94d53e4a3e5685f55dddf6963
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...WikibaseDataModel)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88733


Change subject: update composer file
..

update composer file

Change-Id: Ibb67be9f85ea1ba94d53e4a3e5685f55dddf6963
---
M composer.json
1 file changed, 35 insertions(+), 30 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDataModel 
refs/changes/33/88733/1

diff --git a/composer.json b/composer.json
index 6977d37..be3bf02 100644
--- a/composer.json
+++ b/composer.json
@@ -1,31 +1,36 @@
 {
-  "name": "wikibase/data-model",
-  "type": "library",
-  "description": "PHP implementation of the Wikibase DataModel",
-  "keywords": [
-"Wikibase",
-"DataModel",
-"Wikidata"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:WikibaseDataModel";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";
-  },
-  "require": {
-"php": ">=5.3.0",
-"diff/diff": "dev-mw1.22-wmf21",
-"data-values/data-values": "dev-mw1.22-wmf21"
-  }
-}
\ No newline at end of file
+   "name": "wikibase/data-model",
+   "type": "library",
+   "description": "PHP implementation of the Wikibase DataModel",
+   "keywords": [
+   "Wikibase",
+   "DataModel",
+   "Wikidata"
+   ],
+   "homepage": 
"https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": 
"https://www.mediawiki.org/wiki/Extension_talk:WikibaseDataModel";,
+   "wiki": 
"https://www.mediawiki.org/wiki/Extension:WikibaseDataModel";
+   },
+   "require": {
+   "php": ">=5.3.0",
+   "diff/diff": "dev-mw1.22-wmf21",
+   "data-values/data-values": "dev-mw1.22-wmf21"
+   },
+   "autoload": {
+   "files" : [
+   "WikibaseDataModel.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb67be9f85ea1ba94d53e4a3e5685f55dddf6963
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer - change (mediawiki...DataTypes)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: update composer
..


update composer

Change-Id: I42e41a24af22296392caebc26c0c78443d74ac8e
---
M composer.json
1 file changed, 38 insertions(+), 33 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 2ef11ba..26d25fe 100644
--- a/composer.json
+++ b/composer.json
@@ -1,34 +1,39 @@
 {
-  "name": "data-values/data-types",
-  "type": "library",
-  "description": "PHP library defining the DataTypes\\DataType class of which 
instances represent a type of value, such as \"positive integer\" or 
\"percentage\".",
-  "keywords": [
-"datavalues",
-"datatypes"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:DataTypes";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-},
-{
-  "name": "Wikidata community",
-  "homepage": "https://wikidata.org";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:DataTypes";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:DataTypes";
-  },
-  "require": {
-"php": ">=5.3.0",
-"data-values/data-values": "dev-mw1.22-wmf21"
-  }
-}
\ No newline at end of file
+   "name": "data-values/data-types",
+   "type": "library",
+   "description": "PHP library defining the DataTypes\\DataType class of 
which instances represent a type of value, such as \"positive integer\" or 
\"percentage\".",
+   "keywords": [
+   "datavalues",
+   "datatypes"
+   ],
+   "homepage": "https://www.mediawiki.org/wiki/Extension:DataTypes";,
+   "license": "GPL-2.0+",
+   "authors": [
+  {
+ "name": "Jeroen De Dauw",
+ "email": "jeroended...@gmail.com",
+ "homepage": "http://jeroendedauw.com";,
+ "role": "Developer"
+  },
+  {
+ "name": "Wikidata community",
+ "homepage": "https://wikidata.org";,
+ "role": "Developer"
+  }
+   ],
+   "support": {
+  "issues": "https://bugzilla.wikimedia.org/";,
+  "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+  "forum": "https://www.mediawiki.org/wiki/Extension_talk:DataTypes";,
+  "wiki": "https://www.mediawiki.org/wiki/Extension:DataTypes";
+   },
+   "require": {
+  "php": ">=5.3.0",
+  "data-values/data-values": "dev-mw1.22-wmf21"
+   },
+   "autoload": {
+  "files" : [
+ "DataTypes.php"
+  ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42e41a24af22296392caebc26c0c78443d74ac8e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DataTypes
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...Wikibase)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88737


Change subject: update composer file
..

update composer file

Change-Id: I51ccc4793317f5a4370cfe6144605ea6f5eaa3cc
---
M composer.json
1 file changed, 39 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/37/88737/1

diff --git a/composer.json b/composer.json
index ac0dbba..ef480a5 100644
--- a/composer.json
+++ b/composer.json
@@ -1,34 +1,40 @@
 {
-  "name": "wikibase/wikibase",
-  "type": "mediawiki-extension",
-  "description": "Structured data repository for MediaWiki",
-  "keywords": [
-"wikibase",
-"wikidata",
-"wikibaselib",
-"wikibaseclient",
-"wikibaserepo"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Wikibase";,
-  "license": "GNU GPL v2+",
-  "authors": [
-{
-  "name": "The Wikidata team",
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Talk:Wikibase";,
-"wiki": "https://www.mediawiki.org/wiki/Wikibase";
-  },
-  "require": {
-"php": ">=5.3.0",
-"data-values/data-values": "dev-mw1.22-wmf21",
-"data-values/data-types": "dev-mw1.22-wmf21",
-"wikibase/data-model": "dev-mw1.22-wmf21",
-"diff/diff": "dev-mw1.22-wmf21"
-  },
-  "minimum-stability": "dev"
-}
\ No newline at end of file
+   "name": "wikibase/wikibase",
+   "type": "mediawiki-extension",
+   "description": "Structured data repository for MediaWiki",
+   "keywords": [
+   "wikibase",
+   "wikidata",
+   "wikibaselib",
+   "wikibaseclient",
+   "wikibaserepo"
+   ],
+   "homepage": "https://www.mediawiki.org/wiki/Wikibase";,
+   "license": "GNU GPL v2+",
+   "authors": [
+   {
+   "name": "The Wikidata team",
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": "https://www.mediawiki.org/wiki/Talk:Wikibase";,
+   "wiki": "https://www.mediawiki.org/wiki/Wikibase";
+   },
+   "require": {
+   "php": ">=5.3.0",
+   "data-values/data-values": "dev-mw1.22-wmf21",
+   "data-values/data-types": "dev-mw1.22-wmf21",
+   "wikibase/data-model": "dev-mw1.22-wmf21",
+   "diff/diff": "dev-mw1.22-wmf21"
+   },
+   "minimum-stability": "dev",
+"autoload": {
+   "files" : [
+   "repo/Wikibase.php",
+   "client/WikibaseClient.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88737
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51ccc4793317f5a4370cfe6144605ea6f5eaa3cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] id value for Search button changed - change (qa/browsertests)

2013-10-09 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: id value for Search button changed
..


id value for Search button changed

Change-Id: Ia191b881871010499622fc34abf65e41adcf5143
---
M features/support/pages/random_page.rb
M features/support/pages/search_page.rb
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Zfilipin: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/features/support/pages/random_page.rb 
b/features/support/pages/random_page.rb
index cc97b08..fe0ebae 100644
--- a/features/support/pages/random_page.rb
+++ b/features/support/pages/random_page.rb
@@ -20,7 +20,7 @@
   a(:print_export, text: 'Print/export')
   a(:printable_version, text: 'Printable version')
   li(:uls_malayalam_inscript2_item, data_ime_inputmethod: 'ml-inscript2')
-  button(:search_button, id: 'mw-searchButton')
+  button(:search_button, id: 'searchButton')
   text_field(:search_input, id: 'searchInput')
   a(:uls_trigger, class: 'uls-trigger')
 end
diff --git a/features/support/pages/search_page.rb 
b/features/support/pages/search_page.rb
index 6a4fc4a..2d1fd83 100644
--- a/features/support/pages/search_page.rb
+++ b/features/support/pages/search_page.rb
@@ -2,7 +2,7 @@
   include PageObject
 
   div(:one_result, class: 'suggestions-result')
-  button(:search_button, id: 'mw-searchButton')
+  button(:search_button, id: 'searchButton')
   text_field(:search_input, id: 'searchInput')
   div(:search_results, class: 'suggestions-results')
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/88736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia191b881871010499622fc34abf65e41adcf5143
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 
Gerrit-Reviewer: Zfilipin 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove stray newline - change (integration/jenkins-job-builder-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Remove stray newline
..


Remove stray newline

Change-Id: If51b35d1eafe91e464dceada9c8f100937c51003
---
M macro.yaml
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/macro.yaml b/macro.yaml
index 156ee39..f8d481e 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -359,7 +359,6 @@
 builders:
  - shell: /var/lib/jenkins/bin/run-phpcs-mw.sh nowarnings HEAD
 
-
 - publisher:
 name: phpcs
 publishers:

-- 
To view, visit https://gerrit.wikimedia.org/r/88717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If51b35d1eafe91e464dceada9c8f100937c51003
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] id value for Search button changed - change (qa/browsertests)

2013-10-09 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88736


Change subject: id value for Search button changed
..

id value for Search button changed

Change-Id: Ia191b881871010499622fc34abf65e41adcf5143
---
M features/support/pages/random_page.rb
M features/support/pages/search_page.rb
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/36/88736/1

diff --git a/features/support/pages/random_page.rb 
b/features/support/pages/random_page.rb
index cc97b08..fe0ebae 100644
--- a/features/support/pages/random_page.rb
+++ b/features/support/pages/random_page.rb
@@ -20,7 +20,7 @@
   a(:print_export, text: 'Print/export')
   a(:printable_version, text: 'Printable version')
   li(:uls_malayalam_inscript2_item, data_ime_inputmethod: 'ml-inscript2')
-  button(:search_button, id: 'mw-searchButton')
+  button(:search_button, id: 'searchButton')
   text_field(:search_input, id: 'searchInput')
   a(:uls_trigger, class: 'uls-trigger')
 end
diff --git a/features/support/pages/search_page.rb 
b/features/support/pages/search_page.rb
index 6a4fc4a..2d1fd83 100644
--- a/features/support/pages/search_page.rb
+++ b/features/support/pages/search_page.rb
@@ -2,7 +2,7 @@
   include PageObject
 
   div(:one_result, class: 'suggestions-result')
-  button(:search_button, id: 'mw-searchButton')
+  button(:search_button, id: 'searchButton')
   text_field(:search_input, id: 'searchInput')
   div(:search_results, class: 'suggestions-results')
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/88736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia191b881871010499622fc34abf65e41adcf5143
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...Diff)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88735


Change subject: update composer file
..

update composer file

Change-Id: I88974766c2a72ac16d41c512a75e49b8b778bed5
---
M composer.json
1 file changed, 35 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/35/88735/1

diff --git a/composer.json b/composer.json
index 4f40fc0..8aa5a3b 100644
--- a/composer.json
+++ b/composer.json
@@ -1,31 +1,36 @@
 {
-  "name": "diff/diff",
-  "type": "library",
-  "description": "Library for diffing, patching and representing differences 
between complex objects",
-  "keywords": [
-"diff",
-"wikidata"
-  ],
-  "homepage": "https://github.com/wikimedia/mediawiki-extensions-Diff";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:Diff";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:Diff";
-  },
-  "require": {
-"php": ">=5.3.0"
-  },
-  "require-dev": {
-"satooshi/php-coveralls": "dev-master"
-  }
-}
\ No newline at end of file
+   "name": "diff/diff",
+   "type": "library",
+   "description": "Library for diffing, patching and representing 
differences between complex objects",
+   "keywords": [
+   "diff",
+   "wikidata"
+   ],
+   "homepage": "https://github.com/wikimedia/mediawiki-extensions-Diff";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+   "forum": "https://www.mediawiki.org/wiki/Extension_talk:Diff";,
+   "wiki": "https://www.mediawiki.org/wiki/Extension:Diff";
+   },
+   "require": {
+   "php": ">=5.3.0"
+   },
+   "require-dev": {
+   "satooshi/php-coveralls": "dev-master"
+   },
+   "autoload": {
+   "files" : [
+   "Diff.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88974766c2a72ac16d41c512a75e49b8b778bed5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer file - change (mediawiki...DataValues)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88732


Change subject: update composer file
..

update composer file

Change-Id: Icfd582336547883bfdee15c8c431186f23d791e2
---
M composer.json
1 file changed, 36 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/32/88732/1

diff --git a/composer.json b/composer.json
index b8f5488..07664a1 100644
--- a/composer.json
+++ b/composer.json
@@ -1,35 +1,37 @@
 {
-  "name": "data-values/data-values",
-  "type": "library",
-  "description": "A library containing definitions for various values (ie 
quantities, times, coordinates, etc)",
-  "keywords": [
-"datavalues",
-"valueparsers",
-"valueformatters",
-"datatypes",
-"valuevalidators",
-"wikidata"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:DataValues";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
-}
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/mediawiki",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:DataValues";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:DataValues";
-  },
-  "require": {
-"php": ">=5.3.0"
-  },
-  "replace": {
-"mediawiki/data-values": "*"
-  }
-}
\ No newline at end of file
+   "name": "data-values/data-values",
+   "type": "library",
+   "description": "A library containing definitions for various values (ie 
quantities, times, coordinates, etc)",
+   "keywords": [
+   "datavalues",
+   "valueparsers",
+   "valueformatters",
+   "datatypes",
+   "valuevalidators",
+   "wikidata"
+   ],
+   "homepage": "https://www.mediawiki.org/wiki/Extension:DataValues";,
+   "license": "GPL-2.0+",
+   "authors": [
+   {
+   "name": "Jeroen De Dauw",
+   "email": "jeroended...@gmail.com",
+   "homepage": "http://jeroendedauw.com";,
+   "role": "Developer"
+   }
+   ],
+   "support": {
+   "issues": "https://bugzilla.wikimedia.org/";,
+   "irc": "irc://irc.freenode.net/mediawiki",
+   "forum": 
"https://www.mediawiki.org/wiki/Extension_talk:DataValues";,
+   "wiki": "https://www.mediawiki.org/wiki/Extension:DataValues";
+   },
+   "require": {
+   "php": ">=5.3.0"
+   },
+   "autoload": {
+   "files" : [
+   "DataValues.php"
+   ]
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd582336547883bfdee15c8c431186f23d791e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] adding mw1125 back to dsh groups - change (operations/puppet)

2013-10-09 Thread Cmjohnson (Code Review)
Cmjohnson has submitted this change and it was merged.

Change subject: adding mw1125 back to dsh groups
..


adding mw1125 back to dsh groups

Change-Id: I53fe3a17c94846d17875b60400b44577e7246543
---
M files/dsh/group/apache-eqiad
M files/dsh/group/apaches
M files/dsh/group/mediawiki-installation
M files/dsh/group/mw-eqiad
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Cmjohnson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/files/dsh/group/apache-eqiad b/files/dsh/group/apache-eqiad
index 175fb1a..12bfc5a 100644
--- a/files/dsh/group/apache-eqiad
+++ b/files/dsh/group/apache-eqiad
@@ -122,7 +122,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/apaches b/files/dsh/group/apaches
index b4631d2..9b3dcb3 100644
--- a/files/dsh/group/apaches
+++ b/files/dsh/group/apaches
@@ -297,7 +297,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/mediawiki-installation 
b/files/dsh/group/mediawiki-installation
index b6e6517..55ca2fc 100644
--- a/files/dsh/group/mediawiki-installation
+++ b/files/dsh/group/mediawiki-installation
@@ -332,7 +332,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/mw-eqiad b/files/dsh/group/mw-eqiad
index a7d11e7..2f9d320 100644
--- a/files/dsh/group/mw-eqiad
+++ b/files/dsh/group/mw-eqiad
@@ -123,7 +123,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128

-- 
To view, visit https://gerrit.wikimedia.org/r/88731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53fe3a17c94846d17875b60400b44577e7246543
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 
Gerrit-Reviewer: Cmjohnson 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] adding mw1125 back to dsh groups - change (operations/puppet)

2013-10-09 Thread Cmjohnson (Code Review)
Cmjohnson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88731


Change subject: adding mw1125 back to dsh groups
..

adding mw1125 back to dsh groups

Change-Id: I53fe3a17c94846d17875b60400b44577e7246543
---
M files/dsh/group/apache-eqiad
M files/dsh/group/apaches
M files/dsh/group/mediawiki-installation
M files/dsh/group/mw-eqiad
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/31/88731/1

diff --git a/files/dsh/group/apache-eqiad b/files/dsh/group/apache-eqiad
index 175fb1a..12bfc5a 100644
--- a/files/dsh/group/apache-eqiad
+++ b/files/dsh/group/apache-eqiad
@@ -122,7 +122,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/apaches b/files/dsh/group/apaches
index b4631d2..9b3dcb3 100644
--- a/files/dsh/group/apaches
+++ b/files/dsh/group/apaches
@@ -297,7 +297,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/mediawiki-installation 
b/files/dsh/group/mediawiki-installation
index b6e6517..55ca2fc 100644
--- a/files/dsh/group/mediawiki-installation
+++ b/files/dsh/group/mediawiki-installation
@@ -332,7 +332,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128
diff --git a/files/dsh/group/mw-eqiad b/files/dsh/group/mw-eqiad
index a7d11e7..2f9d320 100644
--- a/files/dsh/group/mw-eqiad
+++ b/files/dsh/group/mw-eqiad
@@ -123,7 +123,7 @@
 mw1122
 mw1123
 mw1124
-
+mw1125
 mw1126
 mw1127
 mw1128

-- 
To view, visit https://gerrit.wikimedia.org/r/88731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53fe3a17c94846d17875b60400b44577e7246543
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update composer - change (mediawiki...DataTypes)

2013-10-09 Thread Aude (Code Review)
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88730


Change subject: update composer
..

update composer

Change-Id: I42e41a24af22296392caebc26c0c78443d74ac8e
---
M composer.json
1 file changed, 36 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTypes 
refs/changes/30/88730/1

diff --git a/composer.json b/composer.json
index 2ef11ba..24f8aaa 100644
--- a/composer.json
+++ b/composer.json
@@ -1,34 +1,39 @@
 {
-  "name": "data-values/data-types",
-  "type": "library",
-  "description": "PHP library defining the DataTypes\\DataType class of which 
instances represent a type of value, such as \"positive integer\" or 
\"percentage\".",
-  "keywords": [
-"datavalues",
-"datatypes"
-  ],
-  "homepage": "https://www.mediawiki.org/wiki/Extension:DataTypes";,
-  "license": "GPL-2.0+",
-  "authors": [
-{
-  "name": "Jeroen De Dauw",
-  "email": "jeroended...@gmail.com",
-  "homepage": "http://jeroendedauw.com";,
-  "role": "Developer"
+"name": "data-values/data-types",
+"type": "library",
+"description": "PHP library defining the DataTypes\\DataType class of 
which instances represent a type of value, such as \"positive integer\" or 
\"percentage\".",
+"keywords": [
+  "datavalues",
+  "datatypes"
+],
+"homepage": "https://www.mediawiki.org/wiki/Extension:DataTypes";,
+"license": "GPL-2.0+",
+"authors": [
+  {
+ "name": "Jeroen De Dauw",
+ "email": "jeroended...@gmail.com",
+ "homepage": "http://jeroendedauw.com";,
+ "role": "Developer"
+  },
+  {
+ "name": "Wikidata community",
+ "homepage": "https://wikidata.org";,
+ "role": "Developer"
+  }
+],
+"support": {
+  "issues": "https://bugzilla.wikimedia.org/";,
+  "irc": "irc://irc.freenode.net/wikimedia-wikidata",
+  "forum": "https://www.mediawiki.org/wiki/Extension_talk:DataTypes";,
+  "wiki": "https://www.mediawiki.org/wiki/Extension:DataTypes";
 },
-{
-  "name": "Wikidata community",
-  "homepage": "https://wikidata.org";,
-  "role": "Developer"
+"require": {
+  "php": ">=5.3.0",
+  "data-values/data-values": "dev-mw1.22-wmf21"
+},
+"autoload": {
+  "files" : [
+ "DataTypes.php"
+  ]
 }
-  ],
-  "support": {
-"issues": "https://bugzilla.wikimedia.org/";,
-"irc": "irc://irc.freenode.net/wikimedia-wikidata",
-"forum": "https://www.mediawiki.org/wiki/Extension_talk:DataTypes";,
-"wiki": "https://www.mediawiki.org/wiki/Extension:DataTypes";
-  },
-  "require": {
-"php": ">=5.3.0",
-"data-values/data-values": "dev-mw1.22-wmf21"
-  }
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/88730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42e41a24af22296392caebc26c0c78443d74ac8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTypes
Gerrit-Branch: mw1.22-wmf21
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow reindex count to differ from old count - change (mediawiki...CirrusSearch)

2013-10-09 Thread Manybubbles (Code Review)
Manybubbles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88729


Change subject: Allow reindex count to differ from old count
..

Allow reindex count to differ from old count

This is required because we reindex while handling live traffic.  We
should be doing a forceSearchIndex after each in place reindex over the
time of the reindex to catch up.

Change-Id: I55b3f21d6ddff8cdd7325d00cb67d25487d6ecb4
---
M maintenance/updateOneSearchIndexConfig.php
1 file changed, 31 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/29/88729/1

diff --git a/maintenance/updateOneSearchIndexConfig.php 
b/maintenance/updateOneSearchIndexConfig.php
index 74b9739..7f589b7 100644
--- a/maintenance/updateOneSearchIndexConfig.php
+++ b/maintenance/updateOneSearchIndexConfig.php
@@ -45,14 +45,20 @@
private $removeIndecies = false;
 
/**
-* @var are there too few replicas in the index we're making?
+* @var boolean are there too few replicas in the index we're making?
 */
private $tooFewReplicas = false;
 
/**
-* @var number of processes to use when reindexing
+* @var int number of processes to use when reindexing
 */
private $reindexProcesses;
+
+   /**
+* @var float how much can the reindexed copy of an index is allowed to 
deviate from the current
+* copy without triggering a reindex failure
+*/
+   private $reindexAcceptableCountDeviation;
 
public function __construct() {
parent::__construct();
@@ -90,6 +96,9 @@
"performed during this operation manually.  Defaults to 
false." );
$maintenance->addOption( 'reindexProcesses', 'Number of 
processess to use in reindex.  ' .
'Not supported on Windows.  Defaults to 1 on Windows 
and 10 otherwise.', false, true );
+   $maintenance->addOption( 'reindexAcceptableCountDeviation', 
'How much can the reindexed ' .
+   'copy of an index is allowed to deviate from the 
current copy without triggering a ' .
+   'reindex failure.  Defaults to 5%.', false, true );
}
 
public function execute() {
@@ -114,6 +123,8 @@
$this->indexIdentifier = 
$this->pickIndexIdentifierFromOption( $this->getOption( 'indexIdentifier', 
'current' ) );
$this->reindexAndRemoveOk = $this->getOption( 
'reindexAndRemoveOk', false );
$this->reindexProcesses = $this->getOption( 
'reindexProcesses', wfIsWindows() ? 1 : 10 );
+   $this->reindexAcceptableCountDeviation = 
self::parsePotentialPercent(
+   $this->getOption( 
'reindexAcceptableCountDeviation', '5%' ) );
 
$this->validateIndex();
$this->validateAnalyzers();
@@ -469,12 +480,17 @@
}
 
$this->output( $this->indent . "Verifying counts..." );
-   $oldCount = CirrusSearchConnection::getPageType( 
$this->indexType )->count();
+   // We can't verify counts are exactly equal because 
they won't be - we still push updates into
+   // the old index while reindexing the new one.
+   $oldCount = (float) 
CirrusSearchConnection::getPageType( $this->indexType )->count();
$this->getIndex()->refresh();
-   $newCount = $this->getPageType()->count();
-   if ( $oldCount !== $newCount ) {
-   $this->output( "Different!  Expected $oldCount 
but got $newCount\n" );
-   $this->error( "Failed to load index.  Expected 
$oldCount but got $newCount.  Check for warnings above.", 1 );
+   $newCount = (float) $this->getPageType()->count();
+   $difference = $oldCount > 0 ? abs( $oldCount - 
$newCount ) / $oldCount : 0;
+   if ( $difference > 
$this->reindexAcceptableCountDeviation ) {
+   $this->output( "Not close enough!  
old=$oldCount new=$newCount difference=$difference\n" );
+   $this->error( 'Failed to load index - counts 
not close enough.  ' .
+   "old=$oldCount new=$newCount 
difference=$difference.  " .
+   'Check for warnings above.', 1 );
}
$this->output( "done\n" );
} else {
@@ -698,6 +714,14 @@
}
return $result;
}
+
+   private static function parsePotentialPercent( $str ) {
+   $result = floatval( $str );
+   if ( strpos( 

[MediaWiki-commits] [Gerrit] Implement ve.dm.Surface.prototype.undo() and redo() in terms... - change (mediawiki...VisualEditor)

2013-10-09 Thread Catrope (Code Review)
Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88728


Change subject: Implement ve.dm.Surface.prototype.undo() and redo() in terms of 
change()
..

Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

...or really changeInternal(), so we can avoid adding undo transactions
to the undo stack.

Also get rid of the pattern where undo() and redo() return a selection
which the caller then has to restore, and instead just restore the
selection.

Bug: 53224
Change-Id: If5a3b4d4162e9f0713ee9cd26e79a66efe52770f
---
M modules/ve/dm/ve.dm.Surface.js
M modules/ve/test/ce/ve.ce.Surface.test.js
M modules/ve/test/ui/actions/ve.ui.IndentationAction.test.js
M modules/ve/test/ui/actions/ve.ui.ListAction.test.js
M modules/ve/test/ve.test.utils.js
M modules/ve/ui/actions/ve.ui.HistoryAction.js
6 files changed, 47 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/28/88728/1

diff --git a/modules/ve/dm/ve.dm.Surface.js b/modules/ve/dm/ve.dm.Surface.js
index bf949ea..a5690c2 100644
--- a/modules/ve/dm/ve.dm.Surface.js
+++ b/modules/ve/dm/ve.dm.Surface.js
@@ -454,12 +454,28 @@
  * @method
  * @param {ve.dm.Transaction|ve.dm.Transaction[]|null} transactions One or 
more transactions to
  *  process, or null to process none
- * @param {ve.Range|undefined} selection
+ * @param {ve.Range} [selection] Selection to apply
  * @emits lock
  * @emits contextChange
  * @emits unlock
  */
 ve.dm.Surface.prototype.change = function ( transactions, selection ) {
+   this.changeInternal( transactions, selection, false );
+};
+
+/**
+ * Internal implementation of change(). Do not use this, use change() instead.
+ *
+ * @private
+ * @method
+ * @param {ve.dm.Transaction|ve.dm.Transaction[]|null} transactions
+ * @param {ve.Range} [selection] [selection]
+ * @param {boolean} [skipUndoStack=false] If true, do not modify the undo stack
+ * @emits lock
+ * @emits contextChange
+ * @emits unlock
+ */
+ve.dm.Surface.prototype.changeInternal = function ( transactions, selection, 
skipUndoStack ) {
var i, len, contextChange = false;
 
if ( !this.enabled ) {
@@ -477,8 +493,10 @@
this.emit( 'lock' );
for ( i = 0, len = transactions.length; i < len; i++ ) {
if ( !transactions[i].isNoOp() ) {
-   this.truncateUndoStack();
-   this.smallStack.push( transactions[i] );
+   if ( !skipUndoStack ) {
+   this.truncateUndoStack();
+   this.smallStack.push( transactions[i] );
+   }
// The .commit() call below indirectly invokes 
setSelection()
this.documentModel.commit( transactions[i] );
if ( 
transactions[i].hasElementAttributeOperations() ) {
@@ -533,66 +551,52 @@
  * Step backwards in history.
  *
  * @method
- * @emits lock
- * @emits unlock
  * @emits history
- * @returns {ve.Range} Selection or null if no further state could be reached
  */
 ve.dm.Surface.prototype.undo = function () {
+   var i, item, selection, transaction, transactions = [];
if ( !this.enabled || !this.hasPastState() ) {
return;
}
-   var item, i, transaction, selection;
+
this.breakpoint();
this.undoIndex++;
 
-   if ( this.bigStack[this.bigStack.length - this.undoIndex] ) {
-   this.emit( 'lock' );
-   item = this.bigStack[this.bigStack.length - this.undoIndex];
+   item = this.bigStack[this.bigStack.length - this.undoIndex];
+   if ( item ) {
+   // Apply reversed transactions in reversed order, and translate 
the selection accordingly
selection = item.selection;
-
for ( i = item.stack.length - 1; i >= 0; i-- ) {
transaction = item.stack[i].reversed();
selection = transaction.translateRange( selection );
-   this.documentModel.commit( transaction );
+   transactions.push( transaction );
}
-   this.emit( 'unlock' );
+   this.changeInternal( transactions, selection, true );
this.emit( 'history' );
-   return selection;
}
-   return null;
 };
 
 /**
  * Step forwards in history.
  *
  * @method
- * @emits lock
- * @emits unlock
  * @emits history
- * @returns {ve.Range} Selection or null if no further state could be reached
  */
 ve.dm.Surface.prototype.redo = function () {
+   var item;
if ( !this.enabled || !this.hasFutureState() ) {
return;
}
-   var item, i, transaction, selection;
+
this.breakpoin

[MediaWiki-commits] [Gerrit] Move phpunit tests to tests/phpunit - change (mediawiki...Translate)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Move phpunit tests to tests/phpunit
..


Move phpunit tests to tests/phpunit

Also fixed the UnitTestsList hook to include tests from subdirectories.

Change-Id: I623c4856ee7a521eb3795990f1512659289330f6
---
M TranslateHooks.php
M _autoload.php
R tests/phpunit/BlackListTest.php
R tests/phpunit/HookDocTest.php
R tests/phpunit/Makefile
R tests/phpunit/MediaWikiExtensionTest.php
R tests/phpunit/MediaWikiMessageCheckerTest.php
R tests/phpunit/MessageCollectionTest.php
R tests/phpunit/MessageGroupBaseTest.php
R tests/phpunit/MessageGroupStatesUpdaterJobTest.php
R tests/phpunit/MessageGroupsTest.php
R tests/phpunit/MessageIndexRebuildJobTest.php
R tests/phpunit/MessageIndexTest.php
R tests/phpunit/MockFileBasedMessageGroup.php
R tests/phpunit/MockMessageCollectionForExport.php
R tests/phpunit/MockSuperUser.php
R tests/phpunit/MockWikiMessageGroup.php
R tests/phpunit/PageTranslationParserTest.php
R tests/phpunit/PageTranslationTaggingTest.php
R tests/phpunit/SolrTTMServerTest.php
R tests/phpunit/SpecialPagesTest.php
R tests/phpunit/StringMatcherTest.php
R tests/phpunit/TPParseTest.php
R tests/phpunit/TTMServerTest.php
R tests/phpunit/TranslateHooksTest.php
R tests/phpunit/TranslateSandboxTest.php
R tests/phpunit/TranslationFuzzyUpdaterTest.php
R tests/phpunit/TranslationStashStorageTest.php
R tests/phpunit/api/ApiGroupReviewTest.php
R tests/phpunit/api/ApiQueryMessageGroupsTest.php
R tests/phpunit/api/ApiTokensTest.php
R tests/phpunit/api/ApiTranslationReviewTest.php
R tests/phpunit/data/Example-result.i18n.php
R tests/phpunit/data/Example.i18n.php
R tests/phpunit/data/IniFFSTest1.ini
R tests/phpunit/data/IniFFSTest2.ini
R tests/phpunit/data/MediaWikiExtensionTest-conf1.yaml
R tests/phpunit/data/MediaWikiExtensionTest-conf2.yaml
R tests/phpunit/data/MixedSourceLanguageGroups.yaml
R tests/phpunit/data/ParentGroups.yaml
R tests/phpunit/data/jsontest_fi.json
R tests/phpunit/data/mediawiki-extensions.txt
R tests/phpunit/data/minimal.xlf
R tests/phpunit/data/pythontest.py
R tests/phpunit/ffs/AndroidXmlFFSTest.php
R tests/phpunit/ffs/DtdFFSTest.php
R tests/phpunit/ffs/GettextFFSTest.php
R tests/phpunit/ffs/IniFFSTest.php
R tests/phpunit/ffs/JavaFFSTest.php
R tests/phpunit/ffs/JsonFFSTest.php
R tests/phpunit/ffs/MediaWikiExtensionFFSTest.php
R tests/phpunit/ffs/PythonSingleFFSTest.php
R tests/phpunit/ffs/RubyYamlFFSTest.php
R tests/phpunit/ffs/XliffFFSTest.php
R tests/phpunit/insertables/MediaWikiInsertablesSuggesterTest.php
R tests/phpunit/messageindexdata.ser
R tests/phpunit/pagetranslation/FailDoubleOpen.ptfile
R tests/phpunit/pagetranslation/FailEmptySection.ptfile
R tests/phpunit/pagetranslation/FailMultipleSectionMarkers.ptfile
R tests/phpunit/pagetranslation/FailNotAtomic.ptfile
R tests/phpunit/pagetranslation/FailSectionMarkerPlace.ptfile
R tests/phpunit/pagetranslation/FailTags.ptfile
R tests/phpunit/pagetranslation/FailTags2.ptfile
R tests/phpunit/pagetranslation/FailUnclosed.ptfile
R tests/phpunit/pagetranslation/HeaderSection.ptfile
R tests/phpunit/pagetranslation/HeaderSection.ptsource
R tests/phpunit/pagetranslation/HeaderSection.pttarget
R tests/phpunit/pagetranslation/Inline.ptfile
R tests/phpunit/pagetranslation/Inline.pttarget
R tests/phpunit/pagetranslation/LoneHeader.ptfile
R tests/phpunit/pagetranslation/LoneHeader.ptsource
R tests/phpunit/pagetranslation/Nowiki.ptfile
R tests/phpunit/pagetranslation/Nowiki.pttarget
R tests/phpunit/pagetranslation/NowikiInside.ptfile
R tests/phpunit/pagetranslation/NowikiInside.pttarget
R tests/phpunit/pagetranslation/NowikiOnly.ptfile
R tests/phpunit/pagetranslation/NowikiOnly.pttest
R tests/phpunit/pagetranslation/Simple.ptfile
R tests/phpunit/pagetranslation/Simple.ptsource
R tests/phpunit/pagetranslation/Simple.pttarget
R tests/phpunit/pagetranslation/Simple.pttest
R tests/phpunit/pagetranslation/SimpleWithMarker.ptfile
R tests/phpunit/pagetranslation/SimpleWithMarker.pttarget
R tests/phpunit/pagetranslation/Variables.ptfile
R tests/phpunit/pagetranslation/Variables.pttarget
R tests/phpunit/pagetranslation/Whitespace.ptfile
R tests/phpunit/pagetranslation/Whitespace.pttarget
87 files changed, 22 insertions(+), 13 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TranslateHooks.php b/TranslateHooks.php
index 9ae6c27..602b448 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -198,17 +198,25 @@
 * @param $files array
 * @return bool
 */
-   public static function setupUnitTests( &$files ) {
-   $testDir = __DIR__ . '/tests/';
-   $files = array_merge( $files, glob( "$testDir/*Test.php" ) );
+   public static function setupUnitTests( array &$files ) {
+   $dir = __DIR__ . '/tests/phpunit';
+   $directoryIterator = new RecursiveDirectoryIterator( $dir );
+   $fileIterator = 

[MediaWiki-commits] [Gerrit] Disable jquery.ime for VE till IME support is improved - change (mediawiki...UniversalLanguageSelector)

2013-10-09 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88727


Change subject: Disable jquery.ime for VE till IME support is improved
..

Disable jquery.ime for VE till IME support is improved

Bug: 55492
Change-Id: I30cffd94413b50bb57a403a9d06dbc0498a02d0a
---
M UniversalLanguageSelector.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/27/88727/1

diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php
index 7da0f49..fa50ef8 100644
--- a/UniversalLanguageSelector.php
+++ b/UniversalLanguageSelector.php
@@ -128,7 +128,7 @@
  *
  * @since 2013.07
  */
-$wgULSNoImeSelectors = array( '#wpCaptchaWord' );
+$wgULSNoImeSelectors = array( '#wpCaptchaWord', '.ve-ce-documentNode' );
 
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/88727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30cffd94413b50bb57a403a9d06dbc0498a02d0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Move phpunit tests to tests/phpunit - change (mediawiki...Translate)

2013-10-09 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88726


Change subject: Move phpunit tests to tests/phpunit
..

Move phpunit tests to tests/phpunit

Also fixed the UnitTestTfiles hook to include tests also
from subdirectories.

Change-Id: I623c4856ee7a521eb3795990f1512659289330f6
---
M TranslateHooks.php
M _autoload.php
R tests/phpunit/BlackListTest.php
R tests/phpunit/HookDocTest.php
R tests/phpunit/Makefile
R tests/phpunit/MediaWikiExtensionTest.php
R tests/phpunit/MediaWikiMessageCheckerTest.php
R tests/phpunit/MessageCollectionTest.php
R tests/phpunit/MessageGroupBaseTest.php
R tests/phpunit/MessageGroupStatesUpdaterJobTest.php
R tests/phpunit/MessageGroupsTest.php
R tests/phpunit/MessageIndexRebuildJobTest.php
R tests/phpunit/MessageIndexTest.php
R tests/phpunit/MockFileBasedMessageGroup.php
R tests/phpunit/MockMessageCollectionForExport.php
R tests/phpunit/MockSuperUser.php
R tests/phpunit/MockWikiMessageGroup.php
R tests/phpunit/PageTranslationParserTest.php
R tests/phpunit/PageTranslationTaggingTest.php
R tests/phpunit/SolrTTMServerTest.php
R tests/phpunit/SpecialPagesTest.php
R tests/phpunit/StringMatcherTest.php
R tests/phpunit/TPParseTest.php
R tests/phpunit/TTMServerTest.php
R tests/phpunit/TranslateHooksTest.php
R tests/phpunit/TranslateSandboxTest.php
R tests/phpunit/TranslationFuzzyUpdaterTest.php
R tests/phpunit/TranslationStashStorageTest.php
R tests/phpunit/api/ApiGroupReviewTest.php
R tests/phpunit/api/ApiQueryMessageGroupsTest.php
R tests/phpunit/api/ApiTokensTest.php
R tests/phpunit/api/ApiTranslationReviewTest.php
R tests/phpunit/data/Example-result.i18n.php
R tests/phpunit/data/Example.i18n.php
R tests/phpunit/data/IniFFSTest1.ini
R tests/phpunit/data/IniFFSTest2.ini
R tests/phpunit/data/MediaWikiExtensionTest-conf1.yaml
R tests/phpunit/data/MediaWikiExtensionTest-conf2.yaml
R tests/phpunit/data/MixedSourceLanguageGroups.yaml
R tests/phpunit/data/ParentGroups.yaml
R tests/phpunit/data/jsontest_fi.json
R tests/phpunit/data/mediawiki-extensions.txt
R tests/phpunit/data/minimal.xlf
R tests/phpunit/data/pythontest.py
R tests/phpunit/ffs/AndroidXmlFFSTest.php
R tests/phpunit/ffs/DtdFFSTest.php
R tests/phpunit/ffs/GettextFFSTest.php
R tests/phpunit/ffs/IniFFSTest.php
R tests/phpunit/ffs/JavaFFSTest.php
R tests/phpunit/ffs/JsonFFSTest.php
R tests/phpunit/ffs/MediaWikiExtensionFFSTest.php
R tests/phpunit/ffs/PythonSingleFFSTest.php
R tests/phpunit/ffs/RubyYamlFFSTest.php
R tests/phpunit/ffs/XliffFFSTest.php
R tests/phpunit/insertables/MediaWikiInsertablesSuggesterTest.php
R tests/phpunit/messageindexdata.ser
R tests/phpunit/pagetranslation/FailDoubleOpen.ptfile
R tests/phpunit/pagetranslation/FailEmptySection.ptfile
R tests/phpunit/pagetranslation/FailMultipleSectionMarkers.ptfile
R tests/phpunit/pagetranslation/FailNotAtomic.ptfile
R tests/phpunit/pagetranslation/FailSectionMarkerPlace.ptfile
R tests/phpunit/pagetranslation/FailTags.ptfile
R tests/phpunit/pagetranslation/FailTags2.ptfile
R tests/phpunit/pagetranslation/FailUnclosed.ptfile
R tests/phpunit/pagetranslation/HeaderSection.ptfile
R tests/phpunit/pagetranslation/HeaderSection.ptsource
R tests/phpunit/pagetranslation/HeaderSection.pttarget
R tests/phpunit/pagetranslation/Inline.ptfile
R tests/phpunit/pagetranslation/Inline.pttarget
R tests/phpunit/pagetranslation/LoneHeader.ptfile
R tests/phpunit/pagetranslation/LoneHeader.ptsource
R tests/phpunit/pagetranslation/Nowiki.ptfile
R tests/phpunit/pagetranslation/Nowiki.pttarget
R tests/phpunit/pagetranslation/NowikiInside.ptfile
R tests/phpunit/pagetranslation/NowikiInside.pttarget
R tests/phpunit/pagetranslation/NowikiOnly.ptfile
R tests/phpunit/pagetranslation/NowikiOnly.pttest
R tests/phpunit/pagetranslation/Simple.ptfile
R tests/phpunit/pagetranslation/Simple.ptsource
R tests/phpunit/pagetranslation/Simple.pttarget
R tests/phpunit/pagetranslation/Simple.pttest
R tests/phpunit/pagetranslation/SimpleWithMarker.ptfile
R tests/phpunit/pagetranslation/SimpleWithMarker.pttarget
R tests/phpunit/pagetranslation/Variables.ptfile
R tests/phpunit/pagetranslation/Variables.pttarget
R tests/phpunit/pagetranslation/Whitespace.ptfile
R tests/phpunit/pagetranslation/Whitespace.pttarget
87 files changed, 21 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/26/88726/1

diff --git a/TranslateHooks.php b/TranslateHooks.php
index 9ae6c27..602b448 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -198,17 +198,25 @@
 * @param $files array
 * @return bool
 */
-   public static function setupUnitTests( &$files ) {
-   $testDir = __DIR__ . '/tests/';
-   $files = array_merge( $files, glob( "$testDir/*Test.php" ) );
+   public static function setupUnitTests( array &$files ) {
+   $dir = __DIR__ . '/tests/phpunit';
+   $directoryIterator = new Recur

[MediaWiki-commits] [Gerrit] add iptables accept from ulsfo for monitoring - change (operations/puppet)

2013-10-09 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88724


Change subject: add iptables accept from ulsfo for monitoring
..

add iptables accept from ulsfo for monitoring

ulsfo public IP space is 198.35.26.0/28 per DNS and
puppet files/autoinstall/subnets

needed for snmp traps (puppet freshness) and nrpe checks

applied on neon (icinga)

Change-Id: I602b21156c5e45c1457c3c351a7d8cac213d417a
---
M manifests/misc/icinga.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/24/88724/1

diff --git a/manifests/misc/icinga.pp b/manifests/misc/icinga.pp
index 498e793..2decd7c 100644
--- a/manifests/misc/icinga.pp
+++ b/manifests/misc/icinga.pp
@@ -640,6 +640,7 @@
 iptables_add_service{ 'public_154': source => '208.80.154.0/24', service 
=> 'all', jump => 'ACCEPT' }
 iptables_add_service{ 'public_fundraising': source => '208.80.155.0/27', 
service => 'all', jump => 'ACCEPT' }
 iptables_add_service{ 'public_esams': source => '91.198.174.0/25', service 
=> 'all', jump => 'ACCEPT' }
+iptables_add_service{ 'public_ulsfo': source => '198.35.26.0/28', service 
=> 'all', jump => 'ACCEPT' }
   }
 
   class iptables-drops {

-- 
To view, visit https://gerrit.wikimedia.org/r/88724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I602b21156c5e45c1457c3c351a7d8cac213d417a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] db1039 to s7 - change (operations/puppet)

2013-10-09 Thread Springle (Code Review)
Springle has submitted this change and it was merged.

Change subject: db1039 to s7
..


db1039 to s7

Change-Id: I50a9a1e3b56c51a146e9547a6357ac79ed238084
---
M manifests/site.pp
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Springle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/site.pp b/manifests/site.pp
index 1be6a7b..426868f 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -644,8 +644,8 @@
 }
 }
 
-node /^db10(06|15|22|27|39|40)\.eqiad\.wmnet/ {
-if $hostname =~ /^db10(22|39|40)/ {
+node /^db10(06|15|22|27|40)\.eqiad\.wmnet/ {
+if $hostname =~ /^db10(22|40)/ {
 class { role::coredb::s6 : innodb_file_per_table => true, mariadb => 
true }
 } elsif $hostname =~ /^db10(15|27)/ {
 class { role::coredb::s6 : mariadb => true }
@@ -654,8 +654,10 @@
 }
 }
 
-node /^db10(07|24|28|41)\.eqiad\.wmnet/ {
-if $hostname == "db1028" {
+node /^db10(07|24|28|39|41)\.eqiad\.wmnet/ {
+if $hostname =~ /^db10(39)/ {
+class { role::coredb::s7 : innodb_file_per_table => true, mariadb => 
true }
+} elsif $hostname == "db1028" {
 class { role::coredb::s7 : mariadb => true }
 } else {
 include role::coredb::s7

-- 
To view, visit https://gerrit.wikimedia.org/r/88723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50a9a1e3b56c51a146e9547a6357ac79ed238084
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Springle 
Gerrit-Reviewer: Springle 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] db1039 to s7 - change (operations/puppet)

2013-10-09 Thread Springle (Code Review)
Springle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88723


Change subject: db1039 to s7
..

db1039 to s7

Change-Id: I50a9a1e3b56c51a146e9547a6357ac79ed238084
---
M manifests/site.pp
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/23/88723/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 1be6a7b..426868f 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -644,8 +644,8 @@
 }
 }
 
-node /^db10(06|15|22|27|39|40)\.eqiad\.wmnet/ {
-if $hostname =~ /^db10(22|39|40)/ {
+node /^db10(06|15|22|27|40)\.eqiad\.wmnet/ {
+if $hostname =~ /^db10(22|40)/ {
 class { role::coredb::s6 : innodb_file_per_table => true, mariadb => 
true }
 } elsif $hostname =~ /^db10(15|27)/ {
 class { role::coredb::s6 : mariadb => true }
@@ -654,8 +654,10 @@
 }
 }
 
-node /^db10(07|24|28|41)\.eqiad\.wmnet/ {
-if $hostname == "db1028" {
+node /^db10(07|24|28|39|41)\.eqiad\.wmnet/ {
+if $hostname =~ /^db10(39)/ {
+class { role::coredb::s7 : innodb_file_per_table => true, mariadb => 
true }
+} elsif $hostname == "db1028" {
 class { role::coredb::s7 : mariadb => true }
 } else {
 include role::coredb::s7

-- 
To view, visit https://gerrit.wikimedia.org/r/88723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50a9a1e3b56c51a146e9547a6357ac79ed238084
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Springle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki...TwnMainPage)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Update formatting
..


Update formatting

Change-Id: Icdf40302bdc35e8a19fcec442a79f724ef0be3bb
---
M CachedStat.php
M TwnMainPage.php
M resources/css/ext.translate.mainpage.css
M resources/js/ext.translate.mainpage.js
M tests/phpunit/CachedStatTest.php
5 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CachedStat.php b/CachedStat.php
index 45332e4..c12a047 100644
--- a/CachedStat.php
+++ b/CachedStat.php
@@ -75,6 +75,7 @@
if ( !is_array( $value ) ) {
if ( $this->onMiss !== 'update' ) {
CachedStatJob::newJob( $this )->insert();
+
return null;
} else {
return $this->doUpdate();
diff --git a/TwnMainPage.php b/TwnMainPage.php
index 1f2da2a..950c33c 100644
--- a/TwnMainPage.php
+++ b/TwnMainPage.php
@@ -50,7 +50,7 @@
$dir = new RecursiveDirectoryIterator( __DIR__ . '/tests/phpunit' );
$ite = new RecursiveIteratorIterator( $dir );
$matches = new RegexIterator( $ite, '/.*Test\.php/', 
RegexIterator::GET_MATCH );
-   foreach( $matches as $file ) {
+   foreach ( $matches as $file ) {
$files = array_merge( $files, $file );
}
 
diff --git a/resources/css/ext.translate.mainpage.css 
b/resources/css/ext.translate.mainpage.css
index 2f6724c..b84c4e6 100644
--- a/resources/css/ext.translate.mainpage.css
+++ b/resources/css/ext.translate.mainpage.css
@@ -95,7 +95,7 @@
 
 .stats-tile {
background-color: #3366BB;
-   background-color: rgba(51,102,187,0.9);
+   background-color: rgba(51, 102, 187, 0.9);
color: white;
height: 130px;
margin: auto;
@@ -124,7 +124,7 @@
 }
 
 .unused.stats-tile {
-   background-color: rgba(51,102,187,0.3);
+   background-color: rgba(51, 102, 187, 0.3);
 }
 
 .stats-number {
@@ -152,7 +152,6 @@
 .main-widget label {
font-size: 16px;
 }
-
 
 .main-widget .row input {
padding: 6px;
@@ -584,6 +583,7 @@
cursor: pointer;
font-size: 14px;
 }
+
 .same-language-uls-trigger:hover {
border-color: #AA;
 }
diff --git a/resources/js/ext.translate.mainpage.js 
b/resources/js/ext.translate.mainpage.js
index 8f80ade..4d8e13c 100644
--- a/resources/js/ext.translate.mainpage.js
+++ b/resources/js/ext.translate.mainpage.js
@@ -48,11 +48,11 @@
/**
 * Show the message group stats bars.
 */
-   function showMessageGroupStats ( language ) {
+   function showMessageGroupStats( language ) {
var $tiles = $( '.project-tile' );
 
// Clear current numbers first so they don't stay if something 
goes wrong
-   $tiles.each( function() {
+   $tiles.each( function () {
var $tile = $( this );
$tile.find( '.project-statsbar' ).empty().removeData( 
'languagestatsbar' );
$tile.find( '.project-statstext' ).empty();
@@ -66,7 +66,7 @@
} );
 
mw.translate.loadLanguageStats( language ).done( function () {
-   $tiles.each( function() {
+   $tiles.each( function () {
var $tile = $( this ),
translated, proofread,
$statsbar = $tile.find( 
'.project-statsbar' ),
@@ -96,7 +96,7 @@
.append(
$( '' ).addClass( 
'translate' )
.text( mw.msg( 
'percent', Math.round( translated ) ) ),
-   $( '' 
).addClass('proofread')
+   $( '' ).addClass( 
'proofread' )
.text( mw.msg( 
'percent', Math.round( proofread ) ) )
);
} );
@@ -106,7 +106,7 @@
/**
 * Setup the project tiles in the main page.
 */
-   function setupProjectTiles () {
+   function setupProjectTiles() {
var language = mw.config.get( 'wgUserLanguage' ),
$selector,
$tiles = $( '.project-tile' );
@@ -175,7 +175,7 @@
$tiles.eq( 7 ).replaceWith( $selector );
}
 
-   function signupLanguageSelector () {
+   function signupLanguageSelector() {
$( '.signup-language-selector' ).uls( {
onSelect: function ( language ) {
if ( $( '#language-' + language ).length ) {
diff --git a/tests/phpunit/Cached

[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki...TranslationNotifications)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Update formatting
..


Update formatting

Change-Id: Ie273d5ffd4d9f4c99a43d9f9ee9664c00963cc1f
---
M SpecialNotifyTranslators.php
M resources/ext.translationnotifications.notifytranslators.js
M scripts/DigestEmailer.php
3 files changed, 8 insertions(+), 10 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialNotifyTranslators.php b/SpecialNotifyTranslators.php
index 206c011..755128d 100644
--- a/SpecialNotifyTranslators.php
+++ b/SpecialNotifyTranslators.php
@@ -105,7 +105,7 @@
 
$formFields = array();
 
-   $default = (int) $tpage !== 0 ? $tpage : 'unset';
+   $default = (int)$tpage !== 0 ? $tpage : 'unset';
$formFields['TranslatablePage'] = array(
'type' => 'select',
'label-message' => array( 
'translationnotifications-translatablepage-title' ),
@@ -603,10 +603,10 @@
$notificationText
)->numParams( count( $relevantLanguages ) )
->inLanguage( $userFirstLanguage )
-   ->text()
-   // Bidi-isolation of site name from date
-   . $userFirstLanguage->getDirMarkEntity()
-   . ', ~'; // Date and time
+   ->text();
+   // Bidi-isolation of site name from date
+   $text .= $userFirstLanguage->getDirMarkEntity() .
+   ', ~'; // Date and time
 
$editSummary = $this->msg(
'translationnotifications-edit-summary',
diff --git a/resources/ext.translationnotifications.notifytranslators.js 
b/resources/ext.translationnotifications.notifytranslators.js
index 1a1d0fa..20a8c8c 100644
--- a/resources/ext.translationnotifications.notifytranslators.js
+++ b/resources/ext.translationnotifications.notifytranslators.js
@@ -36,7 +36,7 @@
} );
 
// Attach the language autocomplete widget.
-   $( '#wpUserLanguage' ).multiselectautocomplete( { inputbox : 
'#mw-input-wpLanguagesToNotify' } );
+   $( '#wpUserLanguage' ).multiselectautocomplete( { inputbox: 
'#mw-input-wpLanguagesToNotify' } );
 
/**
 * Notification preview
@@ -100,6 +100,5 @@
.hide()
.attr( { id: previewId } )
);
-
} );
 }( jQuery, mediaWiki ) );
diff --git a/scripts/DigestEmailer.php b/scripts/DigestEmailer.php
index 9a7ad50..70bc8cc 100644
--- a/scripts/DigestEmailer.php
+++ b/scripts/DigestEmailer.php
@@ -64,9 +64,8 @@
}
}
$firstLangCode = $user->getOption( 
'translationnotifications-lang-1' );
-   $firstLang = Language::factory(
-   $firstLangCode )->fetchLanguageName( 
$signedUpLangCodes[0]
-   );
+   $firstLang = Language::factory( $firstLangCode )
+   ->fetchLanguageName( $signedUpLangCodes[0] );
$this->output( "\tSigned up for: " . implode( ', ', 
$signedUpLangCodes ) . "\n" );
 
// Draft the mail for this user

-- 
To view, visit https://gerrit.wikimedia.org/r/88710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie273d5ffd4d9f4c99a43d9f9ee9664c00963cc1f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslationNotifications
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Amire80 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update jobs for LangEng extensions - change (integration/zuul-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88722


Change subject: Update jobs for LangEng extensions
..

Update jobs for LangEng extensions

* CLDR: No longer run phpcs-strict. The extension doesn't pass, because of
  an issue with UTF-8 (bug 55508). Keep running the strict job on HEAD.
* Interwiki: Add phpcs-strict voting in all stages.
* Translate: Cleanup jobs. Run phpcs-strict voting in all stages.
* TranslattionNotifications: Cleanup jobs. Run phpcs-strict voting in all
  stages.
* UniversalLanguageSelector: Cleanup jobs. Run phpcs-strict voting in all
  stages.

Change-Id: I4c2c6c5ae556752b3f48fbd8d329f0d6b90f9245
---
M layout.yaml
1 file changed, 26 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/22/88722/1

diff --git a/layout.yaml b/layout.yaml
index 7095669..af68132 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -1129,11 +1129,11 @@
   # FIXME use a template
   - name: mediawiki/extensions/cldr
 check-only:
+  - mwext-cldr-phpcs-strict-HEAD # Experiment, bug 48420
   - mwext-cldr-jslint
   - mwext-cldr-lint
-  - mwext-cldr-phpcs-strict-HEAD # Experiment, bug 48420
-  - mwext-cldr-phpcs-strict # Experiment, bug 48420
 gate-and-submit:
+  - mwext-cldr-phpcs-strict-HEAD # Experiment, bug 48420
   - mwext-cldr-jslint
   - mwext-cldr-lint:
 - mwext-cldr-testextensions-master
@@ -1523,9 +1523,12 @@
 extname: Insider
 
   - name: mediawiki/extensions/Interwiki
-template:
-  - name: extension-checks
-extname: Interwiki
+check-only:
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
+  - mwext-TranslationNotifications-lint
+gate-and-submit:
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
+  - mwext-TranslationNotifications-lint:
 
   - name: mediawiki/extensions/intersection
 template:
@@ -2167,39 +2170,33 @@
 
   - name: mediawiki/extensions/Translate
 check:
-  - mwext-Translate-jslint
-  - mwext-Translate-phpcs-HEAD
   - mwext-Translate-phpcs-strict-HEAD  # Experiment, bug 48420
+  - mwext-Translate-jslint
   - mwext-Translate-lint
 test:
-  - mwext-Translate-jslint
-  - mwext-Translate-phpcs-HEAD
   - mwext-Translate-phpcs-strict-HEAD  # Experiment, bug 48420
+  - mwext-Translate-jslint
   - mwext-Translate-lint:
 - mwext-Translate-testextensions-master
 gate-and-submit:
+  - mwext-Translate-phpcs-strict # Experiment for bug 48420
   - mwext-Translate-jslint
-  - mwext-Translate-phpcs-HEAD
-  # Experiment for bug 48420
-  - mwext-Translate-phpcs-strict
   - mwext-Translate-lint:
 - mwext-Translate-testextensions-master
 
   - name: mediawiki/extensions/TranslationNotifications
 check:
-  - mwext-TranslationNotifications-jslint
-  - mwext-TranslationNotifications-phpcs-HEAD
-  - mwext-TranslationNotifications-lint
-  - mwext-TranslationNotifications-phpcs-strict # Experiment, bug 48420
   - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
-test:
   - mwext-TranslationNotifications-jslint
-  - mwext-TranslationNotifications-phpcs-HEAD
+  - mwext-TranslationNotifications-lint
+test:
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
+  - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-lint:
 - mwext-TranslationNotifications-testextensions-master
 gate-and-submit:
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
   - mwext-TranslationNotifications-jslint
-  - mwext-TranslationNotifications-phpcs-HEAD
   - mwext-TranslationNotifications-lint:
 - mwext-TranslationNotifications-testextensions-master
 
@@ -2216,18 +2213,16 @@
   - name: mediawiki/extensions/TwnMainPage
 check:
   - mwext-TwnMainPage-jslint
-  - mwext-TwnMainPage-phpcs-HEAD
   - mwext-TwnMainPage-lint
-  - mwext-TwnMainPage-phpcs-strict # Experiment, bug 48420
   - mwext-TwnMainPage-phpcs-strict-HEAD # Experiment, bug 48420
 test:
   - mwext-TwnMainPage-jslint
-  - mwext-TwnMainPage-phpcs-HEAD
+  - mwext-TwnMainPage-phpcs-strict-HEAD # Experiment, bug 48420
   - mwext-TwnMainPage-lint:
 - mwext-TwnMainPage-testextensions-master
 gate-and-submit:
   - mwext-TwnMainPage-jslint
-  - mwext-TwnMainPage-phpcs-HEAD
+  - mwext-TwnMainPage-phpcs-strict-HEAD # Experiment, bug 48420
   - mwext-TwnMainPage-lint:
 - mwext-TwnMainPage-testextensions-master
 
@@ -2239,14 +2234,18 @@
   - name: mediawiki/extensions/UniversalLanguageSelector
 check-only:
   - mwext-UniversalLanguageSelector-lint
-  - mwext-UniversalLanguageSelector-phpcs-HEAD
+  - mwext

[MediaWiki-commits] [Gerrit] Code needed for Selenium tests - change (mediawiki...Translate)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Code needed for Selenium tests
..


Code needed for Selenium tests

Change-Id: Iddc361509401078121acc5efc764b1c55fbc48c3
---
A tests/browser/Gemfile
A tests/browser/Gemfile.lock
A tests/browser/README.md
A tests/browser/config/config.yml
A tests/browser/config/cucumber.yml
A tests/browser/features/support/env.rb
A tests/browser/features/support/modules/url_module.rb
7 files changed, 108 insertions(+), 0 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/Gemfile b/tests/browser/Gemfile
new file mode 100755
index 000..7f53e68
--- /dev/null
+++ b/tests/browser/Gemfile
@@ -0,0 +1,12 @@
+#ruby=ruby-2.0.0-p247
+#ruby-gemset=Translate
+
+source 'https://rubygems.org'
+
+gem 'cucumber'
+gem 'json'
+gem 'mediawiki-selenium'
+gem 'net-http-persistent'
+gem 'page-object'
+gem 'rspec-expectations'
+gem 'syntax'
diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
new file mode 100644
index 000..f708dd8
--- /dev/null
+++ b/tests/browser/Gemfile.lock
@@ -0,0 +1,58 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+builder (3.2.2)
+childprocess (0.3.9)
+  ffi (~> 1.0, >= 1.0.11)
+cucumber (1.3.8)
+  builder (>= 2.1.2)
+  diff-lcs (>= 1.1.3)
+  gherkin (~> 2.12.1)
+  multi_json (>= 1.7.5, < 2.0)
+  multi_test (>= 0.0.2)
+data_magic (0.16.1)
+  faker (>= 1.1.2)
+  yml_reader (>= 0.2)
+diff-lcs (1.2.4)
+faker (1.2.0)
+  i18n (~> 0.5)
+ffi (1.9.0)
+gherkin (2.12.1)
+  multi_json (~> 1.3)
+i18n (0.6.5)
+json (1.8.0)
+mediawiki-selenium (0.1.8)
+multi_json (1.8.1)
+multi_test (0.0.2)
+net-http-persistent (2.9)
+page-object (0.9.2)
+  page_navigation (>= 0.8)
+  selenium-webdriver (>= 2.35.0)
+  watir-webdriver (>= 0.6.4)
+page_navigation (0.9)
+  data_magic (>= 0.14)
+rspec-expectations (2.14.3)
+  diff-lcs (>= 1.1.3, < 2.0)
+rubyzip (0.9.9)
+selenium-webdriver (2.35.1)
+  childprocess (>= 0.2.5)
+  multi_json (~> 1.0)
+  rubyzip (< 1.0.0)
+  websocket (~> 1.0.4)
+syntax (1.0.0)
+watir-webdriver (0.6.4)
+  selenium-webdriver (>= 2.18.0)
+websocket (1.0.7)
+yml_reader (0.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  cucumber
+  json
+  mediawiki-selenium
+  net-http-persistent
+  page-object
+  rspec-expectations
+  syntax
diff --git a/tests/browser/README.md b/tests/browser/README.md
new file mode 100644
index 000..3c5449a
--- /dev/null
+++ b/tests/browser/README.md
@@ -0,0 +1 @@
+Please see https://github.com/wikimedia/qa-browsertests for instructions on 
how to run tests.
diff --git a/tests/browser/config/config.yml b/tests/browser/config/config.yml
new file mode 100644
index 000..6df0a31
--- /dev/null
+++ b/tests/browser/config/config.yml
@@ -0,0 +1,24 @@
+chrome:
+  name: chrome
+  platform: Linux
+  version:
+
+firefox:
+  name: firefox
+  platform: Linux
+  version: 23
+
+internet_explorer_8:
+  name: internet_explorer
+  platform: Windows XP
+  version: 8
+
+internet_explorer_9:
+  name: internet_explorer
+  platform: Windows 7
+  version: 9
+
+internet_explorer_10:
+  name: internet_explorer
+  platform: Windows 8
+  version: 10
diff --git a/tests/browser/config/cucumber.yml 
b/tests/browser/config/cucumber.yml
new file mode 100644
index 000..150c284
--- /dev/null
+++ b/tests/browser/config/cucumber.yml
@@ -0,0 +1,2 @@
+ci: --format Cucumber::Formatter::Sauce --out reports/junit
+default: --format progress
diff --git a/tests/browser/features/support/env.rb 
b/tests/browser/features/support/env.rb
new file mode 100644
index 000..2281d94
--- /dev/null
+++ b/tests/browser/features/support/env.rb
@@ -0,0 +1 @@
+require 'mediawiki/selenium'
diff --git a/tests/browser/features/support/modules/url_module.rb 
b/tests/browser/features/support/modules/url_module.rb
new file mode 100644
index 000..6268546
--- /dev/null
+++ b/tests/browser/features/support/modules/url_module.rb
@@ -0,0 +1,10 @@
+module URL
+  def self.url(name)
+if ENV['MEDIAWIKI_URL']
+  mediawiki_url = ENV['MEDIAWIKI_URL']
+else
+  mediawiki_url = 'http://en.wikipedia.beta.wmflabs.org/wiki/'
+end
+"#{mediawiki_url}#{name}"
+  end
+end

-- 
To view, visit https://gerrit.wikimedia.org/r/88702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddc361509401078121acc5efc764b1c55fbc48c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use MW_INSTALL_PATH for test path if defined - change (mediawiki...UniversalLanguageSelector)

2013-10-09 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88721


Change subject: Use MW_INSTALL_PATH for test path if defined
..

Use MW_INSTALL_PATH for test path if defined

Change-Id: Ib4eedb61f37e3b8a5c834dc417342543771a2d33
---
M tests/phpunit/Makefile
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/21/88721/1

diff --git a/tests/phpunit/Makefile b/tests/phpunit/Makefile
index be36655..eabe3a1 100644
--- a/tests/phpunit/Makefile
+++ b/tests/phpunit/Makefile
@@ -1,2 +1,10 @@
+ifndef MW_INSTALL_PATH
+   MW_INSTALL_PATH=../../..
+endif
+
 default:
-   php ../../../tests/phpunit/phpunit.php .
+   php ${MW_INSTALL_PATH}/tests/phpunit/phpunit.php .
+
+.PHONY: *Test.php
+*Test.php:
+   php ${MW_INSTALL_PATH}/tests/phpunit/phpunit.php $@

-- 
To view, visit https://gerrit.wikimedia.org/r/88721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4eedb61f37e3b8a5c834dc417342543771a2d33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [WIP]Fetch user translations support for Translation Stash API - change (mediawiki...Translate)

2013-10-09 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88720


Change subject: [WIP]Fetch user translations support for Translation Stash API
..

[WIP]Fetch user translations support for Translation Stash API

Change-Id: I8ce1266a17d8b84c142960b7b1685dc6f454336c
---
M api/ApiTranslationStash.php
M resources/js/ext.translate.special.translationstash.js
M stash/TranslationStashStorage.php
3 files changed, 36 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/20/88720/1

diff --git a/api/ApiTranslationStash.php b/api/ApiTranslationStash.php
index b5c73a9..28a2c2f 100644
--- a/api/ApiTranslationStash.php
+++ b/api/ApiTranslationStash.php
@@ -18,6 +18,12 @@
$action = $params['subaction'];
 
if ( $action === 'add' ) {
+   if ( !isset( $params['title'] ) ) {
+   $this->dieUsageMsg( array( 'missingparam', 
'title' ) );
+   }
+   if ( !isset( $params['value'] ) ) {
+   $this->dieUsageMsg( array( 'missingparam', 
'value' ) );
+   }
// Ugly, but API modules don't have proper dependency 
injection
$stash = new TranslationStashStorage( wfGetDB( 
DB_MASTER ) );
 
@@ -27,9 +33,22 @@
$params['value'],
FormatJson::decode( $params['metadata'], true )
);
-   $stash->addTranslation( $translation );
+   $stash->addTranslation( serialize( $translation ) );
}
 
+   if ( $action === 'query' ) {
+   $stash = new TranslationStashStorage( wfGetDB( 
DB_MASTER ) );
+   $translations = $stash->getTranslations( 
$this->getUser() );
+   for ( $i = 0; $i < count( $translations ); $i++ ) {
+   $translation = array(
+   'title' => 
$translations[$i]->getTitle()->getPrefixedDBKey(),
+   'value' => 
$translations[$i]->getValue(),
+   'metadata' =>  
$translations[$i]->getMetadata(),
+   );
+   $output['translations'][] = $translation;
+   }
+
+   }
// If we got this far, nothing has failed
$output['result'] = 'ok';
$this->getResult()->addValue( null, $this->getModuleName(), 
$output );
@@ -56,16 +75,16 @@
public function getAllowedParams() {
return array(
'subaction' => array(
-   ApiBase::PARAM_TYPE => array( 'add' ),
+   ApiBase::PARAM_TYPE => array( 'add', 'query' ),
ApiBase::PARAM_REQUIRED => true,
),
'title' => array(
ApiBase::PARAM_TYPE => 'string',
-   ApiBase::PARAM_REQUIRED => true,
+   ApiBase::PARAM_REQUIRED => false,
),
'value' => array(
ApiBase::PARAM_TYPE => 'string',
-   ApiBase::PARAM_REQUIRED => true,
+   ApiBase::PARAM_REQUIRED => false,
),
'metadata' => array(
ApiBase::PARAM_TYPE => 'string',
diff --git a/resources/js/ext.translate.special.translationstash.js 
b/resources/js/ext.translate.special.translationstash.js
index a597053..faf01d1 100644
--- a/resources/js/ext.translate.special.translationstash.js
+++ b/resources/js/ext.translate.special.translationstash.js
@@ -8,10 +8,20 @@
 ( function ( $, mw ) {
'use strict';
 
-   function getMessages( messageGroup, language, offset, limit ) {
+   function getUserTranslations() {
var api = new mw.Api();
 
return api.get( {
+   action: 'translationstash',
+   subaction: 'query',
+   token: $( '#token' ).val()
+   } );
+   }
+
+   function getMessages( messageGroup, language, offset, limit ) {
+   var api = new mw.Api();
+
+   return api.post( {
action: 'query',
list: 'messagecollection',
mcgroup: messageGroup,
@@ -21,8 +31,6 @@
mclimit: limit,
mcprop: 'definition|properties'
} );
-
-   // @todo: We need to get translations from the stash api
}
 
  

[MediaWiki-commits] [Gerrit] Consistency tweaks in preparation for adding extension to tr... - change (mediawiki...VectorBeta)

2013-10-09 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88719


Change subject: Consistency tweaks in preparation for adding extension to 
translatewiki.net
..

Consistency tweaks in preparation for adding extension to translatewiki.net

* Add extension credits array
* Add extension description message

Change-Id: I4ea880fc321b497d191b79f1968a1607699dbbdd
---
M VectorBeta.i18n.php
M VectorBeta.php
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VectorBeta 
refs/changes/19/88719/1

diff --git a/VectorBeta.i18n.php b/VectorBeta.i18n.php
index 4fb7269..9214c7b 100644
--- a/VectorBeta.i18n.php
+++ b/VectorBeta.i18n.php
@@ -25,6 +25,7 @@
  * English
  */
 $messages['en'] = array(
+   'vectorbeta-desc' => 'Adds access to turning on beta styles of the 
Vector skin within the BetaFeatures preferences',
'vector-beta-feature-typography-message' => 'Vector typography refresh',
'vector-beta-feature-typography-description' => 'Updates typography of 
the Vector skin to improve readability, accessibility and consistency.',
 );
@@ -33,6 +34,7 @@
  * Message documentation (Message documentation)
  */
 $messages['qqq'] = array(
+   'vectorbeta-desc' => '{{desc|name=Vector 
Beta|url=https://www.mediawiki.org/wiki/Extension:VectorBeta}}',
'vector-beta-feature-typography-message' => 'Name shown in user 
preferences for Vector typography beta feature experiment.',
'vector-beta-feature-typography-description' => 'Brief explanation of 
Vector typography beta feature experiment.',
 );
diff --git a/VectorBeta.php b/VectorBeta.php
index 0cafef5..ddbc1e9 100644
--- a/VectorBeta.php
+++ b/VectorBeta.php
@@ -19,6 +19,15 @@
  * @ingroup extensions
  */
 
+$wgExtensionCredits['other'][] = array(
+   'author' => srray( 'Trevor Parscal' ),
+   'descriptionmsg' => 'vectorbeta-desc',
+   'name' => 'VectorBeta',
+   'path' => __FILE__,
+   'url' => 'https://www.mediawiki.org/wiki/Extension:VectorBeta',
+   // 'version' => '',
+);
+
 $wgAutoloadClasses['VectorBetaHooks'] = __DIR__ . '/VectorBeta.hooks.php';
 
 $wgExtensionMessagesFiles['VectorBeta'] = __DIR__ . '/VectorBeta.i18n.php';

-- 
To view, visit https://gerrit.wikimedia.org/r/88719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ea880fc321b497d191b79f1968a1607699dbbdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup jobs - change (integration/jenkins-job-builder-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88718


Change subject: Cleanup jobs
..

Cleanup jobs

Change-Id: I22fe6ddf3dd76840e9fbbfd72962878f7ce5a1c4
---
M mediawiki-extensions.yaml
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/18/88718/1

diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index e2e4605..42eeec8 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -510,7 +510,6 @@
 - project:
 name: 'mwext-cldr'
 jobs:
- - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
 
 - project:
@@ -566,28 +565,22 @@
 - project:
 name: 'mwext-Translate'
 jobs:
- - '{name}-phpcs-lenient'
- - '{name}-phpcs-lenient-HEAD'
- - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
 
 - project:
 name: 'mwext-TranslationNotifications'
 jobs:
- - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
 
 - project:
 name: 'mwext-TwnMainPage'
 jobs:
- - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
 
 - project:
 name: 'mwext-UniversalLanguageSelector'
 jobs:
  - '{name}-ruby1.9.3lint'
- - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
 
 - project:

-- 
To view, visit https://gerrit.wikimedia.org/r/88718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22fe6ddf3dd76840e9fbbfd72962878f7ce5a1c4
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove stray newline - change (integration/jenkins-job-builder-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88717


Change subject: Remove stray newline
..

Remove stray newline

Change-Id: If51b35d1eafe91e464dceada9c8f100937c51003
---
M macro.yaml
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/17/88717/1

diff --git a/macro.yaml b/macro.yaml
index 156ee39..f8d481e 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -359,7 +359,6 @@
 builders:
  - shell: /var/lib/jenkins/bin/run-phpcs-mw.sh nowarnings HEAD
 
-
 - publisher:
 name: phpcs
 publishers:

-- 
To view, visit https://gerrit.wikimedia.org/r/88717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If51b35d1eafe91e464dceada9c8f100937c51003
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Change course status "Passed" to "Ended" to avoid ambiguity ... - change (mediawiki...EducationProgram)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Change course status "Passed" to "Ended" to avoid ambiguity 
about "passing" a course.
..


Change course status "Passed" to "Ended" to avoid ambiguity
about "passing" a course.

Change-Id: Ifa10a4238a3acc0fb7c94d96d48e9d6cfcbcab9c
---
M EducationProgram.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/EducationProgram.i18n.php b/EducationProgram.i18n.php
index 345370b..8f5fba1 100644
--- a/EducationProgram.i18n.php
+++ b/EducationProgram.i18n.php
@@ -206,7 +206,7 @@
'special-articles' => 'Articles (Education Program)',
 
// Course statuses
-   'ep-course-status-passed' => 'Passed',
+   'ep-course-status-passed' => 'Ended',
'ep-course-status-current' => 'Current',
'ep-course-status-planned' => 'Planned',
'ep-course-status-current-planned' => 'Current and planned',
@@ -317,7 +317,7 @@
'epstudentpager-header-user-id' => 'Username',
'epstudentpager-header-id' => 'Id',
'epstudentpager-header-current-courses' => 'Current courses',
-   'epstudentpager-header-passed-courses' => 'Passed courses',
+   'epstudentpager-header-passed-courses' => 'Ended courses',
'epstudentpager-header-first-enroll' => 'First enrollment',
'epstudentpager-header-last-active' => 'Last active',
'epstudentpager-header-active-enroll' => 'Currently enrolled',

-- 
To view, visit https://gerrit.wikimedia.org/r/78392
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa10a4238a3acc0fb7c94d96d48e9d6cfcbcab9c
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Ragesoss 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] TranslationNotifications check-only -> check - change (integration/zuul-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: TranslationNotifications check-only -> check
..


TranslationNotifications check-only -> check

check-only should only be used whenever we are not using the test
pipeline or we will get duplicate replies.

Change-Id: Ia0ce63449f052dbdb5c18848c5f107817f77feb7
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/layout.yaml b/layout.yaml
index a30bc97..7095669 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -2186,7 +2186,7 @@
 - mwext-Translate-testextensions-master
 
   - name: mediawiki/extensions/TranslationNotifications
-check-only:
+check:
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
   - mwext-TranslationNotifications-lint

-- 
To view, visit https://gerrit.wikimedia.org/r/88716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0ce63449f052dbdb5c18848c5f107817f77feb7
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] TranslationNotifications check-only -> check - change (integration/zuul-config)

2013-10-09 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88716


Change subject: TranslationNotifications check-only -> check
..

TranslationNotifications check-only -> check

check-only should only be used whenever we are not using the test
pipeline or we will get duplicate replies.

Change-Id: Ia0ce63449f052dbdb5c18848c5f107817f77feb7
---
M layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/16/88716/1

diff --git a/layout.yaml b/layout.yaml
index a30bc97..7095669 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -2186,7 +2186,7 @@
 - mwext-Translate-testextensions-master
 
   - name: mediawiki/extensions/TranslationNotifications
-check-only:
+check:
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
   - mwext-TranslationNotifications-lint

-- 
To view, visit https://gerrit.wikimedia.org/r/88716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0ce63449f052dbdb5c18848c5f107817f77feb7
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add documentation on SQL format to interfaces - change (mediawiki...WikibaseDatabase)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88715


Change subject: Add documentation on SQL format to interfaces
..

Add documentation on SQL format to interfaces

Change-Id: I9a7e26d19e29e1a6f5727b0d8f0b89d0f68c168f
---
M src/Schema/SchemaModificationSqlBuilder.php
M src/Schema/TableSqlBuilder.php
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase 
refs/changes/15/88715/1

diff --git a/src/Schema/SchemaModificationSqlBuilder.php 
b/src/Schema/SchemaModificationSqlBuilder.php
index c44e0df..8ef1d1d 100644
--- a/src/Schema/SchemaModificationSqlBuilder.php
+++ b/src/Schema/SchemaModificationSqlBuilder.php
@@ -6,6 +6,10 @@
 use Wikibase\Database\Schema\Definitions\IndexDefinition;
 
 /**
+ * The SQL returned by the methods in this interface may contain multiple 
statements.
+ * The SQL may also consist out of multiple lines. Lines may contain multiple
+ * statements, though statements may not be spread over multiple lines.
+ *
  * @since 0.1
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroended...@gmail.com >
diff --git a/src/Schema/TableSqlBuilder.php b/src/Schema/TableSqlBuilder.php
index 421cbb6..5104dc8 100644
--- a/src/Schema/TableSqlBuilder.php
+++ b/src/Schema/TableSqlBuilder.php
@@ -6,16 +6,9 @@
 use Wikibase\Database\Schema\Definitions\TableDefinition;
 
 /**
- * Base database abstraction class to put stuff into that is not present
- * in the MW core db abstraction layer.
- *
- * Like to core class DatabaseBase, each deriving class provides support
- * for a specific type of database.
- *
- * Everything implemented in these classes could go into DatabaseBase and
- * deriving classes, though this might take quite some time, hence 
implementation
- * is first done here. If you feel like taking core CR crap and waiting a few
- * months, by all means try to get the functionality into core.
+ * The SQL returned by the methods in this interface may contain multiple 
statements.
+ * The SQL may also consist out of multiple lines. Lines may contain multiple
+ * statements, though statements may not be spread over multiple lines.
  *
  * @since 0.1
  * @licence GNU GPL v2+

-- 
To view, visit https://gerrit.wikimedia.org/r/88715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a7e26d19e29e1a6f5727b0d8f0b89d0f68c168f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update .gitignore - change (mediawiki...Wikibase)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Update .gitignore
..


Update .gitignore

- do not include the .idea directory generated by RubyMine

Change-Id: I66ae91bebb5e1688fa05836f7730765798654d06
---
M .gitignore
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
index 4f363d4..f279a81 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,4 +11,6 @@
 
 easyrdf/
 
-!.*
\ No newline at end of file
+!.*
+
+selenium_cuc/.idea

-- 
To view, visit https://gerrit.wikimedia.org/r/88699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66ae91bebb5e1688fa05836f7730765798654d06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [WikimediaEvents] Deployed on WMF cluster - change (translatewiki)

2013-10-09 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: [WikimediaEvents] Deployed on WMF cluster
..


[WikimediaEvents] Deployed on WMF cluster

https://git.wikimedia.org/commitdiff/operations%2Fmediawiki-config/7a0dd0b3b0478eec429cfa10abd0e314f984b349

Change-Id: I188af8ff4cc7885d6621877365e7c25643882df0
---
M groups/MediaWiki/WikimediaAgg.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/groups/MediaWiki/WikimediaAgg.yaml 
b/groups/MediaWiki/WikimediaAgg.yaml
index 3ae97ff..b1d5a08 100644
--- a/groups/MediaWiki/WikimediaAgg.yaml
+++ b/groups/MediaWiki/WikimediaAgg.yaml
@@ -102,6 +102,7 @@
   - ext-wikibasedatamodel
   - ext-wikilove # r90124
   - ext-wikihiero
+  - ext-wikimediaevents # change-Id: If573f4be6f709433c270eeed0dbe94077f877b91
   - ext-wikimediaincubator # r89556
   - ext-wikimediaincubatorinfopage
   - ext-wikimediashoplink # 2012-06-27, change-Id 
1a0c3707bd6603b27d80c997968b24231eea2b04

-- 
To view, visit https://gerrit.wikimedia.org/r/88713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I188af8ff4cc7885d6621877365e7c25643882df0
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...WikibaseDatabase)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused import
..


Remove unused import

Change-Id: Ibcf05e33bb46f22b6b8fc4df33569857daeb4492
---
M src/SQLite/SQLiteSchemaSqlBuilder.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/SQLite/SQLiteSchemaSqlBuilder.php 
b/src/SQLite/SQLiteSchemaSqlBuilder.php
index b8bf44c..a84c743 100644
--- a/src/SQLite/SQLiteSchemaSqlBuilder.php
+++ b/src/SQLite/SQLiteSchemaSqlBuilder.php
@@ -4,7 +4,6 @@
 
 use Exception;
 use Wikibase\Database\Escaper;
-use Wikibase\Database\QueryInterface\QueryInterface;
 use Wikibase\Database\Schema\Definitions\FieldDefinition;
 use Wikibase\Database\Schema\Definitions\IndexDefinition;
 use Wikibase\Database\Schema\SchemaModificationSqlBuilder;

-- 
To view, visit https://gerrit.wikimedia.org/r/88714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcf05e33bb46f22b6b8fc4df33569857daeb4492
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...WikibaseDatabase)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88714


Change subject: Remove unused import
..

Remove unused import

Change-Id: Ibcf05e33bb46f22b6b8fc4df33569857daeb4492
---
M src/SQLite/SQLiteSchemaSqlBuilder.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase 
refs/changes/14/88714/1

diff --git a/src/SQLite/SQLiteSchemaSqlBuilder.php 
b/src/SQLite/SQLiteSchemaSqlBuilder.php
index b8bf44c..a84c743 100644
--- a/src/SQLite/SQLiteSchemaSqlBuilder.php
+++ b/src/SQLite/SQLiteSchemaSqlBuilder.php
@@ -4,7 +4,6 @@
 
 use Exception;
 use Wikibase\Database\Escaper;
-use Wikibase\Database\QueryInterface\QueryInterface;
 use Wikibase\Database\Schema\Definitions\FieldDefinition;
 use Wikibase\Database\Schema\Definitions\IndexDefinition;
 use Wikibase\Database\Schema\SchemaModificationSqlBuilder;

-- 
To view, visit https://gerrit.wikimedia.org/r/88714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcf05e33bb46f22b6b8fc4df33569857daeb4492
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add vikipedia.com.tr and vikipedia.com.tr RT #5928 - change (operations/dns)

2013-10-09 Thread Akosiaris (Code Review)
Akosiaris has submitted this change and it was merged.

Change subject: add vikipedia.com.tr and vikipedia.com.tr RT #5928
..


add vikipedia.com.tr and vikipedia.com.tr
RT #5928

** Registrant:
   WIKIMEDIA FOUNDATION, INC.
   149 NEW MONTGOMERY STREET NTHIRD FLOOR
   SAN FRANCISCO CA94105
   Out of Turkey,
 Aruba

Created on..: 2013-Oct-02.

NS change requested -> RT #5928

Change-Id: I5a3fe4380f5aed0afd6c48910cb32f78be29fde8
---
A templates/vikipedi.com.tr
A templates/vikipedia.com.tr
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Akosiaris: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/vikipedi.com.tr b/templates/vikipedi.com.tr
new file mode 12
index 000..f8431e2
--- /dev/null
+++ b/templates/vikipedi.com.tr
@@ -0,0 +1 @@
+wikipedia.org
\ No newline at end of file
diff --git a/templates/vikipedia.com.tr b/templates/vikipedia.com.tr
new file mode 12
index 000..f8431e2
--- /dev/null
+++ b/templates/vikipedia.com.tr
@@ -0,0 +1 @@
+wikipedia.org
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/88706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a3fe4380f5aed0afd6c48910cb32f78be29fde8
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Akosiaris 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [WikimediaEvents] Deployed on WMF cluster - change (translatewiki)

2013-10-09 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88713


Change subject: [WikimediaEvents] Deployed on WMF cluster
..

[WikimediaEvents] Deployed on WMF cluster

https://git.wikimedia.org/commitdiff/operations%2Fmediawiki-config/7a0dd0b3b0478eec429cfa10abd0e314f984b349

Change-Id: I188af8ff4cc7885d6621877365e7c25643882df0
---
M groups/MediaWiki/WikimediaAgg.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/13/88713/1

diff --git a/groups/MediaWiki/WikimediaAgg.yaml 
b/groups/MediaWiki/WikimediaAgg.yaml
index 3ae97ff..b1d5a08 100644
--- a/groups/MediaWiki/WikimediaAgg.yaml
+++ b/groups/MediaWiki/WikimediaAgg.yaml
@@ -102,6 +102,7 @@
   - ext-wikibasedatamodel
   - ext-wikilove # r90124
   - ext-wikihiero
+  - ext-wikimediaevents # change-Id: If573f4be6f709433c270eeed0dbe94077f877b91
   - ext-wikimediaincubator # r89556
   - ext-wikimediaincubatorinfopage
   - ext-wikimediashoplink # 2012-06-27, change-Id 
1a0c3707bd6603b27d80c997968b24231eea2b04

-- 
To view, visit https://gerrit.wikimedia.org/r/88713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I188af8ff4cc7885d6621877365e7c25643882df0
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Expand integration test to use DefinitionReader - change (mediawiki...WikibaseDatabase)

2013-10-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Expand integration test to use DefinitionReader
..


Expand integration test to use DefinitionReader

The previous TableCreationAndDeletion test now also
uses a TableDefinitionReader in its execution making
sure the defintion that is read is equal to that
that was initially created

This change also fixes various small issues through
both the MySql and SQLite classes

Change-Id: I10808c074a39a28a906f668a4260ca9abbafa25b
---
M src/MediaWiki/MediaWikiQueryInterface.php
M src/MediaWiki/MediaWikiTableBuilder.php
M src/MySQL/MySQLTableDefinitionReader.php
M src/MySQL/MySQLTableSqlBuilder.php
M src/SQLite/SQLiteFieldSqlBuilder.php
M src/SQLite/SQLiteSchemaSqlBuilder.php
M src/SQLite/SQLiteTableDefinitionReader.php
M src/SQLite/SQLiteTableSqlBuilder.php
R tests/integration/MediaWiki/Schema/TableCreateReadDeleteTest.php
M tests/phpunit/MySQL/MySQLTableDefinitionReaderTest.php
M tests/phpunit/MySQL/MySQLTableSqlBuilderTest.php
M tests/phpunit/SQLite/SQLiteSchemaSqlBuilderTest.php
M tests/phpunit/SQLite/SQLiteTableDefinitionReaderTest.php
M tests/phpunit/SQLite/SQLiteTableSqlBuilderTest.php
14 files changed, 120 insertions(+), 76 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/MediaWiki/MediaWikiQueryInterface.php 
b/src/MediaWiki/MediaWikiQueryInterface.php
index bea4790..6976173 100644
--- a/src/MediaWiki/MediaWikiQueryInterface.php
+++ b/src/MediaWiki/MediaWikiQueryInterface.php
@@ -150,7 +150,7 @@
public function select( $tableName, array $fields, array $conditions, 
array $options = array() ) {
$selectionResult = $this->getDB()->select(
$tableName,
-$fields,
+   $fields,
$conditions,
__METHOD__,
$options
diff --git a/src/MediaWiki/MediaWikiTableBuilder.php 
b/src/MediaWiki/MediaWikiTableBuilder.php
index 5b6a030..c5fcf6c 100644
--- a/src/MediaWiki/MediaWikiTableBuilder.php
+++ b/src/MediaWiki/MediaWikiTableBuilder.php
@@ -71,11 +71,14 @@
public function createTable( TableDefinition $table ) {
$sql = $this->tableSqlBuilder->getCreateTableSql( $table );
 
-   $success = $this->getDB()->query( $sql );
+   foreach( explode( PHP_EOL, $sql ) as $query ){
+   $success = $this->getDB()->query( $query );
 
-   if ( $success === false ) {
-   throw new TableCreationFailedException( $table, 
$this->getDB()->lastError() );
+   if ( $success === false ) {
+   throw new TableCreationFailedException( $table, 
$this->getDB()->lastError() );
+   }
}
+
}
 
/**
diff --git a/src/MySQL/MySQLTableDefinitionReader.php 
b/src/MySQL/MySQLTableDefinitionReader.php
index 22afbae..20ba608 100644
--- a/src/MySQL/MySQLTableDefinitionReader.php
+++ b/src/MySQL/MySQLTableDefinitionReader.php
@@ -50,23 +50,23 @@
 */
private function getFields( $tableName ) {
$results = $this->queryInterface->select(
-   'information_schema.COLUMNS',
+   'INFORMATION_SCHEMA.COLUMNS',
array(
'name' => 'COLUMN_NAME',
'cannull' => 'IS_NULLABLE',
'type' => 'DATA_TYPE',
-   'default' => 'COLUMN_DEFAULT' ),
-   array( 'TABLE_SCHEMA' => $tableName )
+   'defaultvalue' => 'COLUMN_DEFAULT', ),
+   array( 'TABLE_NAME' => $tableName )
);
 
$fields = array();
foreach( $results as $field ){
 
$fields[] = new FieldDefinition(
-   $field['name'],
-   $this->getDataType( $field['type'] ),
-   $this->getNullable( $field['cannull'] ),
-   $field['default'] );
+   $field->name,
+   $this->getDataType( $field->type ),
+   $this->getNullable( $field->cannull ),
+   $field->defaultvalue );
}
 
return $fields;
@@ -82,7 +82,7 @@
$indexes = array();
 
$constraintsResult = $this->queryInterface->select(
-   'information_schema.table_constraints',
+   'INFORMATION_SCHEMA.TABLE_CONSTRAINTS',
array(
'name' => 'CONSTRAINT_NAME',
'type' => 'CONSTRAINT_TYPE',
@@ -90,4

[MediaWiki-commits] [Gerrit] Stash: load in correct language and minor refactoring - change (mediawiki...Translate)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Stash: load in correct language and minor refactoring
..


Stash: load in correct language and minor refactoring

Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
---
M resources/js/ext.translate.special.translationstash.js
1 file changed, 21 insertions(+), 9 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.translate.special.translationstash.js 
b/resources/js/ext.translate.special.translationstash.js
index 7327fda..46030f6 100644
--- a/resources/js/ext.translate.special.translationstash.js
+++ b/resources/js/ext.translate.special.translationstash.js
@@ -19,8 +19,10 @@
mclanguage: language,
mcoffset: offset,
mclimit: limit,
-   mcprop: 'definition|translation|tags|properties'
+   mcprop: 'definition|properties'
} );
+
+   // @todo: We need to get translations from the stash api
}
 
function addMessage( message ) {
@@ -92,7 +94,7 @@
var $messageTable = $( '.tux-messagelist' ),
messagegroup = '!sandbox';
 
-   getMessages( messagegroup, $messageTable.data( 'targetLang' ), 
0, 5 )
+   getMessages( messagegroup, $messageTable.data( 'targetlangcode' 
), 0, 20 )
.done( function ( result ) {
var messages = result.query.messagecollection;
$.each( messages, function ( index, message ) {
@@ -110,18 +112,28 @@
}
 
$( 'document' ).ready( function () {
-   var $messageTable = $( '.tux-messagelist' );
+   var $messageTable = $( '.tux-messagelist' ),
+   $ulsTrigger = $( '.ext-translate-language-selector > 
.uls' );
 
-   $( '.ext-translate-language-selector .uls' ).uls( {
+   $ulsTrigger.uls( {
onSelect: function ( language ) {
-   $( '.ext-translate-language-selector > .uls' )
-   .text( $.uls.data.getAutonym( language 
) )
+   var direction = $.uls.data.getDir( language ),
+   autonym = $.uls.data.getAutonym( 
language );
+
+   $ulsTrigger
+   .text( autonym )
.attr( {
lang: language,
-   dir: $.uls.data.getDir( 
language )
+   dir: direction
} );
-   $messageTable.empty();
-   $messageTable.data( 'targetLang', language );
+
+   $messageTable
+   .empty()
+   .data( {
+   targetlangcode: language,
+   targetlangdir: direction
+   } );
+
loadMessages();
}
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/88693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki...TranslationNotifications)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88710


Change subject: Update formatting
..

Update formatting

Change-Id: Ie273d5ffd4d9f4c99a43d9f9ee9664c00963cc1f
---
M SpecialNotifyTranslators.php
M resources/ext.translationnotifications.notifytranslators.js
M scripts/DigestEmailer.php
3 files changed, 8 insertions(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslationNotifications 
refs/changes/10/88710/1

diff --git a/SpecialNotifyTranslators.php b/SpecialNotifyTranslators.php
index 206c011..755128d 100644
--- a/SpecialNotifyTranslators.php
+++ b/SpecialNotifyTranslators.php
@@ -105,7 +105,7 @@
 
$formFields = array();
 
-   $default = (int) $tpage !== 0 ? $tpage : 'unset';
+   $default = (int)$tpage !== 0 ? $tpage : 'unset';
$formFields['TranslatablePage'] = array(
'type' => 'select',
'label-message' => array( 
'translationnotifications-translatablepage-title' ),
@@ -603,10 +603,10 @@
$notificationText
)->numParams( count( $relevantLanguages ) )
->inLanguage( $userFirstLanguage )
-   ->text()
-   // Bidi-isolation of site name from date
-   . $userFirstLanguage->getDirMarkEntity()
-   . ', ~'; // Date and time
+   ->text();
+   // Bidi-isolation of site name from date
+   $text .= $userFirstLanguage->getDirMarkEntity() .
+   ', ~'; // Date and time
 
$editSummary = $this->msg(
'translationnotifications-edit-summary',
diff --git a/resources/ext.translationnotifications.notifytranslators.js 
b/resources/ext.translationnotifications.notifytranslators.js
index 1a1d0fa..20a8c8c 100644
--- a/resources/ext.translationnotifications.notifytranslators.js
+++ b/resources/ext.translationnotifications.notifytranslators.js
@@ -36,7 +36,7 @@
} );
 
// Attach the language autocomplete widget.
-   $( '#wpUserLanguage' ).multiselectautocomplete( { inputbox : 
'#mw-input-wpLanguagesToNotify' } );
+   $( '#wpUserLanguage' ).multiselectautocomplete( { inputbox: 
'#mw-input-wpLanguagesToNotify' } );
 
/**
 * Notification preview
@@ -100,6 +100,5 @@
.hide()
.attr( { id: previewId } )
);
-
} );
 }( jQuery, mediaWiki ) );
diff --git a/scripts/DigestEmailer.php b/scripts/DigestEmailer.php
index 9a7ad50..70bc8cc 100644
--- a/scripts/DigestEmailer.php
+++ b/scripts/DigestEmailer.php
@@ -64,9 +64,8 @@
}
}
$firstLangCode = $user->getOption( 
'translationnotifications-lang-1' );
-   $firstLang = Language::factory(
-   $firstLangCode )->fetchLanguageName( 
$signedUpLangCodes[0]
-   );
+   $firstLang = Language::factory( $firstLangCode )
+   ->fetchLanguageName( $signedUpLangCodes[0] );
$this->output( "\tSigned up for: " . implode( ', ', 
$signedUpLangCodes ) . "\n" );
 
// Draft the mail for this user

-- 
To view, visit https://gerrit.wikimedia.org/r/88710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie273d5ffd4d9f4c99a43d9f9ee9664c00963cc1f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslationNotifications
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki...TwnMainPage)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88711


Change subject: Update formatting
..

Update formatting

Change-Id: Icdf40302bdc35e8a19fcec442a79f724ef0be3bb
---
M CachedStat.php
M TwnMainPage.php
M resources/css/ext.translate.mainpage.css
M resources/js/ext.translate.mainpage.js
M tests/phpunit/CachedStatTest.php
5 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage 
refs/changes/11/88711/1

diff --git a/CachedStat.php b/CachedStat.php
index 45332e4..c12a047 100644
--- a/CachedStat.php
+++ b/CachedStat.php
@@ -75,6 +75,7 @@
if ( !is_array( $value ) ) {
if ( $this->onMiss !== 'update' ) {
CachedStatJob::newJob( $this )->insert();
+
return null;
} else {
return $this->doUpdate();
diff --git a/TwnMainPage.php b/TwnMainPage.php
index 1f2da2a..950c33c 100644
--- a/TwnMainPage.php
+++ b/TwnMainPage.php
@@ -50,7 +50,7 @@
$dir = new RecursiveDirectoryIterator( __DIR__ . '/tests/phpunit' );
$ite = new RecursiveIteratorIterator( $dir );
$matches = new RegexIterator( $ite, '/.*Test\.php/', 
RegexIterator::GET_MATCH );
-   foreach( $matches as $file ) {
+   foreach ( $matches as $file ) {
$files = array_merge( $files, $file );
}
 
diff --git a/resources/css/ext.translate.mainpage.css 
b/resources/css/ext.translate.mainpage.css
index 2f6724c..b84c4e6 100644
--- a/resources/css/ext.translate.mainpage.css
+++ b/resources/css/ext.translate.mainpage.css
@@ -95,7 +95,7 @@
 
 .stats-tile {
background-color: #3366BB;
-   background-color: rgba(51,102,187,0.9);
+   background-color: rgba(51, 102, 187, 0.9);
color: white;
height: 130px;
margin: auto;
@@ -124,7 +124,7 @@
 }
 
 .unused.stats-tile {
-   background-color: rgba(51,102,187,0.3);
+   background-color: rgba(51, 102, 187, 0.3);
 }
 
 .stats-number {
@@ -152,7 +152,6 @@
 .main-widget label {
font-size: 16px;
 }
-
 
 .main-widget .row input {
padding: 6px;
@@ -584,6 +583,7 @@
cursor: pointer;
font-size: 14px;
 }
+
 .same-language-uls-trigger:hover {
border-color: #AA;
 }
diff --git a/resources/js/ext.translate.mainpage.js 
b/resources/js/ext.translate.mainpage.js
index 8f80ade..4d8e13c 100644
--- a/resources/js/ext.translate.mainpage.js
+++ b/resources/js/ext.translate.mainpage.js
@@ -48,11 +48,11 @@
/**
 * Show the message group stats bars.
 */
-   function showMessageGroupStats ( language ) {
+   function showMessageGroupStats( language ) {
var $tiles = $( '.project-tile' );
 
// Clear current numbers first so they don't stay if something 
goes wrong
-   $tiles.each( function() {
+   $tiles.each( function () {
var $tile = $( this );
$tile.find( '.project-statsbar' ).empty().removeData( 
'languagestatsbar' );
$tile.find( '.project-statstext' ).empty();
@@ -66,7 +66,7 @@
} );
 
mw.translate.loadLanguageStats( language ).done( function () {
-   $tiles.each( function() {
+   $tiles.each( function () {
var $tile = $( this ),
translated, proofread,
$statsbar = $tile.find( 
'.project-statsbar' ),
@@ -96,7 +96,7 @@
.append(
$( '' ).addClass( 
'translate' )
.text( mw.msg( 
'percent', Math.round( translated ) ) ),
-   $( '' 
).addClass('proofread')
+   $( '' ).addClass( 
'proofread' )
.text( mw.msg( 
'percent', Math.round( proofread ) ) )
);
} );
@@ -106,7 +106,7 @@
/**
 * Setup the project tiles in the main page.
 */
-   function setupProjectTiles () {
+   function setupProjectTiles() {
var language = mw.config.get( 'wgUserLanguage' ),
$selector,
$tiles = $( '.project-tile' );
@@ -175,7 +175,7 @@
$tiles.eq( 7 ).replaceWith( $selector );
}
 
-   function signupLanguageSelector () {
+   function signupLanguageSelector() {
$( '.signup-language-selector' ).uls( {
onSelect: function ( language ) {
if ( $( '#language-' + 

[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki...UniversalLanguageSelector)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88708


Change subject: Update formatting
..

Update formatting

Change-Id: Iaee2ab4f36d3a0dce143c62965ab29de504b31ea
---
M ResourceLoaderULSModule.php
M UniversalLanguageSelector.hooks.php
M UniversalLanguageSelector.php
M api/ApiULSLocalization.php
M resources/css/ext.uls.css
M resources/css/ext.uls.displaysettings.css
M resources/css/ext.uls.inputsettings.css
M resources/js/ext.uls.displaysettings.js
M resources/js/ext.uls.eventlogger.js
M resources/js/ext.uls.ime.js
M resources/js/ext.uls.init.js
M resources/js/ext.uls.interface.js
M resources/js/ext.uls.languagesettings.js
13 files changed, 49 insertions(+), 42 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/08/88708/1

diff --git a/ResourceLoaderULSModule.php b/ResourceLoaderULSModule.php
index 88bf275..4bbd6eb 100644
--- a/ResourceLoaderULSModule.php
+++ b/ResourceLoaderULSModule.php
@@ -53,6 +53,7 @@
foreach ( $this->getData() as $key => $value ) {
$out .= Xml::encodeJsCall( 'mw.config.set', array( 
$key, $value ) );
}
+
return $out;
}
 
@@ -77,6 +78,7 @@
'hash' => $hash,
'timestamp' => $timestamp,
) );
+
return $timestamp;
}
 }
diff --git a/UniversalLanguageSelector.hooks.php 
b/UniversalLanguageSelector.hooks.php
index f776b43..b3fa7e8 100644
--- a/UniversalLanguageSelector.hooks.php
+++ b/UniversalLanguageSelector.hooks.php
@@ -33,6 +33,7 @@
if ( !$wgULSEnableAnon && $user->isAnon() ) {
return false;
}
+
return true;
}
 
@@ -141,6 +142,7 @@
foreach ( $preferred as $code => $weight ) {
if ( isset( $supported[$code] ) ) {
wfProfileOut( __METHOD__ );
+
return $code;
}
}
@@ -152,11 +154,13 @@
$code = $parts[0];
if ( isset( $supported[$code] ) ) {
wfProfileOut( __METHOD__ );
+
return $code;
}
}
 
wfProfileOut( __METHOD__ );
+
return '';
}
 
@@ -206,6 +210,7 @@
// Apply immediately
$code = $languageToSave;
}
+
// Otherwise just use what is stored in preferences
return true;
}
@@ -219,6 +224,7 @@
if ( self::isSupportedLanguage( $languageToSave ) ) {
$request->response()->setcookie( 'language', 
$languageToSave );
$code = $languageToSave;
+
return true;
}
 
@@ -226,6 +232,7 @@
$languageToUse = $request->getCookie( 'language' );
if ( self::isSupportedLanguage( $languageToUse ) ) {
$code = $languageToUse;
+
return true;
}
 
diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php
index 7da0f49..d53aa6f 100644
--- a/UniversalLanguageSelector.php
+++ b/UniversalLanguageSelector.php
@@ -76,7 +76,6 @@
 /**
  * Allow anonymous users to change language with cookie and setlang
  * query param.
-
  * Do not use if you are caching anonymous page views without
  * taking cookies into account.
  *
@@ -130,7 +129,6 @@
  */
 $wgULSNoImeSelectors = array( '#wpCaptchaWord' );
 
-
 /**
  * Array of jQuery selectors of elements on which webfonts must not be applied.
  * By default exclude the interwiki language links.
@@ -161,17 +159,17 @@
 $wgHooks['SkinTemplateOutputPageBeforeExec'][] =
'UniversalLanguageSelectorHooks::onSkinTemplateOutputPageBeforeExec';
 
-
 $wgDefaultUserOptions['uls-preferences'] = '';
 $wgHooks['GetPreferences'][] = 
'UniversalLanguageSelectorHooks::onGetPreferences';
 
-$wgExtensionFunctions[] = function() {
+$wgExtensionFunctions[] = function () {
global $wgHooks, $wgResourceModules, $wgULSEventLogging, 
$wgULSGeoService;
 
if ( $wgULSGeoService === true ) {
-   $wgHooks['BeforePageDisplay'][] = function( &$out ) {
+   $wgHooks['BeforePageDisplay'][] = function ( &$out ) {
/** @var OutputPage $out */
$out->addScript( '' );
+
return true;
};
}
@@ -183,13 +181,13 @@
if ( class_exists( 'ResourceLoaderSchemaModule' ) ) {
/// @see 
https://meta.wikimedia.org/wiki/Schema:UniversalLanguageSelector
  

[MediaWiki-commits] [Gerrit] Update grouping and sorting - change (integration/jenkins-job-builder-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Update grouping and sorting
..


Update grouping and sorting

Change-Id: I5851217fe14c723cc94d54ff54fcd79cd84471df
---
M mediawiki-extensions.yaml
1 file changed, 50 insertions(+), 50 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index 0fc7ba0..e2e4605 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -62,6 +62,16 @@
  - junit:
 results: 'junit*.xml'
 
+- job-template:
+name: 'mwext-PoolCounter-build'
+defaults: use-remote-zuul
+triggers:
+ - zuul
+builders:
+ - shell: |
+cd daemon
+make
+
 # Job specific to Wikibase, let us switch between client
 # and server configurations.
 - job-template:
@@ -493,10 +503,30 @@
 ext-name: VisualEditor
 
 - project:
+name: 'mwext-BlameMaps'
+jobs:
+ - python-jobs
+
+- project:
 name: 'mwext-cldr'
 jobs:
  - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
+
+- project:
+name: 'mwext-ConfirmEdit'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-DumpHTML'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-EventLogging'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-MobileFrontend'
@@ -504,26 +534,29 @@
  - '{name}-ruby1.9.3lint'
 
 - project:
-name: 'mwext-UniversalLanguageSelector'
+name: 'mwext-Offline'
 jobs:
- - '{name}-ruby1.9.3lint'
- - '{name}-phpcs-strict'
- - '{name}-phpcs-strict-HEAD'
+ - python-jobs
 
-- job-template:
-name: 'mwext-PoolCounter-build'
-defaults: use-remote-zuul
-triggers:
- - zuul
-builders:
- - shell: |
-cd daemon
-make
+- project:
+name: 'mwext-OpenStackManager'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-PoolCounter'
 jobs:
  - 'mwext-PoolCounter-build'
+
+- project:
+name: 'mwext-SemanticBundle'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-SemanticResultFormats'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-timeline'
@@ -551,44 +584,11 @@
  - '{name}-phpcs-strict-HEAD'
 
 - project:
-name: 'mwext-BlameMaps'
+name: 'mwext-UniversalLanguageSelector'
 jobs:
- - python-jobs
-
-- project:
-name: 'mwext-ConfirmEdit'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-DumpHTML'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-EventLogging'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-Offline'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-OpenStackManager'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-SemanticBundle'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-SemanticResultFormats'
-jobs:
- - python-jobs
+ - '{name}-ruby1.9.3lint'
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
 
 - project:
 name: 'mwext-WikimediaMaintenance'

-- 
To view, visit https://gerrit.wikimedia.org/r/88707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5851217fe14c723cc94d54ff54fcd79cd84471df
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Run PHP CS strict on 4 extensions - change (integration/zuul-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Run PHP CS strict on 4 extensions
..


Run PHP CS strict on 4 extensions

CLDR, TranslationNotifications, TwnMainPage and ULS. Only on check,
possibly to later be made voting.

References:
* https://gerrit.wikimedia.org/r/#/c/88626
* https://gerrit.wikimedia.org/r/#/c/88635

Depends on Change-Id I95ba7ca87c6ce93ef97a0b7c54c88832b0a32ccf.

Change-Id: Iec223a59a72432e95bde256247f40d27c6b90f70
---
M layout.yaml
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/layout.yaml b/layout.yaml
index e57795a..a30bc97 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -1131,6 +1131,8 @@
 check-only:
   - mwext-cldr-jslint
   - mwext-cldr-lint
+  - mwext-cldr-phpcs-strict-HEAD # Experiment, bug 48420
+  - mwext-cldr-phpcs-strict # Experiment, bug 48420
 gate-and-submit:
   - mwext-cldr-jslint
   - mwext-cldr-lint:
@@ -2188,6 +2190,8 @@
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
   - mwext-TranslationNotifications-lint
+  - mwext-TranslationNotifications-phpcs-strict # Experiment, bug 48420
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
 test:
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
@@ -2214,6 +2218,8 @@
   - mwext-TwnMainPage-jslint
   - mwext-TwnMainPage-phpcs-HEAD
   - mwext-TwnMainPage-lint
+  - mwext-TwnMainPage-phpcs-strict # Experiment, bug 48420
+  - mwext-TwnMainPage-phpcs-strict-HEAD # Experiment, bug 48420
 test:
   - mwext-TwnMainPage-jslint
   - mwext-TwnMainPage-phpcs-HEAD
@@ -2236,6 +2242,8 @@
   - mwext-UniversalLanguageSelector-phpcs-HEAD
   - mwext-UniversalLanguageSelector-jslint
   - mwext-UniversalLanguageSelector-ruby1.9.3lint
+  - mwext-UniversalLanguageSelector-phpcs-strict # Experiment, bug 48420
+  - mwext-UniversalLanguageSelector-phpcs-strict-HEAD # Experiment, bug 
48420
 gate-and-submit:
   - mwext-UniversalLanguageSelector-jslint
   - mwext-UniversalLanguageSelector-phpcs-HEAD

-- 
To view, visit https://gerrit.wikimedia.org/r/88703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec223a59a72432e95bde256247f40d27c6b90f70
Gerrit-PatchSet: 3
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 54492) Display a custom sitename for specific site groups - change (mediawiki...Wikibase)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: (bug 54492) Display a custom sitename for specific site groups
..


(bug 54492) Display a custom sitename for specific site groups

This will allow to specify a message for a sitename for
special sites as e.g. Wikimedia Commons which then gets
displayed instead of the language name in the first column
of the sitelinks table.

This requires to add the sitegroup to
$wgWBSettings['specialSiteLinkGroups'] and specify a message.

Needs https://gerrit.wikimedia.org/r/#/c/85986/ to be
merged into WikimediaMessages

Change-Id: Id6ba4e138794ae2aba8d2d96bc9a1154f2c38308
---
M lib/WikibaseLib.i18n.php
M lib/config/WikibaseLib.default.php
M lib/includes/modules/SitesModule.php
M lib/resources/Resources.php
M lib/resources/wikibase.ui.SiteLinksEditTool.js
M repo/includes/ItemView.php
6 files changed, 70 insertions(+), 21 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/WikibaseLib.i18n.php b/lib/WikibaseLib.i18n.php
index c58786b..f057d31 100644
--- a/lib/WikibaseLib.i18n.php
+++ b/lib/WikibaseLib.i18n.php
@@ -50,6 +50,7 @@
'wikibase-replicationnote' => 'Please notice that it can take several 
minutes until the changes are visible on all wikis.',
'wikibase-sitelinks-wikipedia' => 'Wikipedia pages linked to this item',
'wikibase-sitelinks-sitename-columnheading' => 'Language',
+   'wikibase-sitelinks-sitename-columnheading-special' => 'Site',
'wikibase-sitelinks-siteid-columnheading' => 'Code',
'wikibase-sitelinks-link-columnheading' => 'Linked article',
'wikibase-tooltip-error-details' => 'Details',
@@ -153,6 +154,8 @@
 See also Wikidatas glossary for [[d:Wikidata:Glossary#sitelinks|site links]] 
and [[d:Wikidata:Glossary#Item|item]].',
'wikibase-sitelinks-sitename-columnheading' => 'Site links table column 
heading for the column containing the language names.
 {{Identical|Language}}',
+   'wikibase-sitelinks-sitename-columnheading-special' => 'Site links 
table column heading for the sitename column for special sites such as e.g. 
Commons.
+{{Identical|Language}}',
'wikibase-sitelinks-siteid-columnheading' => 'Site links table column 
heading for the column containing the language codes.
 {{Identical|Code}}',
'wikibase-sitelinks-link-columnheading' => 'Site links table column 
heading for the column containg the title/link of/to the referenced (wiki) 
page.',
diff --git a/lib/config/WikibaseLib.default.php 
b/lib/config/WikibaseLib.default.php
index aa58ca2..7b63972 100644
--- a/lib/config/WikibaseLib.default.php
+++ b/lib/config/WikibaseLib.default.php
@@ -51,6 +51,8 @@
'wikipedia',
),
 
+   'specialSiteLinkGroups' => array(),
+
// local by default. Set to something LBFactory understands.
'changesDatabase' => false,
 
diff --git a/lib/includes/modules/SitesModule.php 
b/lib/includes/modules/SitesModule.php
index e5b48f2..cfd70e4 100644
--- a/lib/includes/modules/SitesModule.php
+++ b/lib/includes/modules/SitesModule.php
@@ -48,6 +48,7 @@
$sites = array();
 
$groups = Settings::get( "siteLinkGroups" );
+   $specialGroups = Settings::get( "specialSiteLinkGroups" );
 
/**
 * @var MediaWikiSite $site
@@ -56,7 +57,15 @@
$group = $site->getGroup();
 
if ( $site->getType() === Site::TYPE_MEDIAWIKI && 
in_array( $group, $groups ) ) {
-   $languageName = Utils::fetchLanguageName( 
$site->getLanguageCode() );
+   // FIXME: quickfix to allow a custom site-name 
/ handling for groups defined in $wgSpecialSiteLinkGroups
+   if ( in_array( $group, $specialGroups ) ) {
+   $languageNameMsg = wfMessage( 
'wikibase-sitelinks-sitename-' . $site->getGlobalId() );
+   $languageName = 
$languageNameMsg->exists() ? $languageNameMsg->parse() : $site->getGlobalId();
+   $groupName = 'special';
+   } else {
+   $languageName = 
Utils::fetchLanguageName( $site->getLanguageCode() );
+   $groupName = $group;
+   }
$globalId = $site->getGlobalId();
 
// Use protocol relative URIs, as it's safe to 
assume that all wikis support the same protocol
@@ -80,7 +89,7 @@
'pageUrl' => $pageUrl,
'apiUrl' => $apiUrl,
'languageCode' => 
$site->getLanguageCode(),
-  

[MediaWiki-commits] [Gerrit] Update grouping and sorting - change (integration/jenkins-job-builder-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88707


Change subject: Update grouping and sorting
..

Update grouping and sorting

Change-Id: I5851217fe14c723cc94d54ff54fcd79cd84471df
---
M mediawiki-extensions.yaml
1 file changed, 50 insertions(+), 50 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/07/88707/1

diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index 0fc7ba0..e2e4605 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -62,6 +62,16 @@
  - junit:
 results: 'junit*.xml'
 
+- job-template:
+name: 'mwext-PoolCounter-build'
+defaults: use-remote-zuul
+triggers:
+ - zuul
+builders:
+ - shell: |
+cd daemon
+make
+
 # Job specific to Wikibase, let us switch between client
 # and server configurations.
 - job-template:
@@ -493,10 +503,30 @@
 ext-name: VisualEditor
 
 - project:
+name: 'mwext-BlameMaps'
+jobs:
+ - python-jobs
+
+- project:
 name: 'mwext-cldr'
 jobs:
  - '{name}-phpcs-strict'
  - '{name}-phpcs-strict-HEAD'
+
+- project:
+name: 'mwext-ConfirmEdit'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-DumpHTML'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-EventLogging'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-MobileFrontend'
@@ -504,26 +534,29 @@
  - '{name}-ruby1.9.3lint'
 
 - project:
-name: 'mwext-UniversalLanguageSelector'
+name: 'mwext-Offline'
 jobs:
- - '{name}-ruby1.9.3lint'
- - '{name}-phpcs-strict'
- - '{name}-phpcs-strict-HEAD'
+ - python-jobs
 
-- job-template:
-name: 'mwext-PoolCounter-build'
-defaults: use-remote-zuul
-triggers:
- - zuul
-builders:
- - shell: |
-cd daemon
-make
+- project:
+name: 'mwext-OpenStackManager'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-PoolCounter'
 jobs:
  - 'mwext-PoolCounter-build'
+
+- project:
+name: 'mwext-SemanticBundle'
+jobs:
+ - python-jobs
+
+- project:
+name: 'mwext-SemanticResultFormats'
+jobs:
+ - python-jobs
 
 - project:
 name: 'mwext-timeline'
@@ -551,44 +584,11 @@
  - '{name}-phpcs-strict-HEAD'
 
 - project:
-name: 'mwext-BlameMaps'
+name: 'mwext-UniversalLanguageSelector'
 jobs:
- - python-jobs
-
-- project:
-name: 'mwext-ConfirmEdit'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-DumpHTML'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-EventLogging'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-Offline'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-OpenStackManager'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-SemanticBundle'
-jobs:
- - python-jobs
-
-- project:
-name: 'mwext-SemanticResultFormats'
-jobs:
- - python-jobs
+ - '{name}-ruby1.9.3lint'
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
 
 - project:
 name: 'mwext-WikimediaMaintenance'

-- 
To view, visit https://gerrit.wikimedia.org/r/88707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5851217fe14c723cc94d54ff54fcd79cd84471df
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add vikipedia.com.tr and vikipedia.com.tr RT #5928 - change (operations/dns)

2013-10-09 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88706


Change subject: add vikipedia.com.tr and vikipedia.com.tr RT #5928
..

add vikipedia.com.tr and vikipedia.com.tr
RT #5928

** Registrant:
   WIKIMEDIA FOUNDATION, INC.
   149 NEW MONTGOMERY STREET NTHIRD FLOOR
   SAN FRANCISCO CA94105
   Out of Turkey,
 Aruba

Created on..: 2013-Oct-02.

NS change requested -> RT #5928

Change-Id: I5a3fe4380f5aed0afd6c48910cb32f78be29fde8
---
A templates/vikipedi.com.tr
A templates/vikipedia.com.tr
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dns 
refs/changes/06/88706/1

diff --git a/templates/vikipedi.com.tr b/templates/vikipedi.com.tr
new file mode 12
index 000..f8431e2
--- /dev/null
+++ b/templates/vikipedi.com.tr
@@ -0,0 +1 @@
+wikipedia.org
\ No newline at end of file
diff --git a/templates/vikipedia.com.tr b/templates/vikipedia.com.tr
new file mode 12
index 000..f8431e2
--- /dev/null
+++ b/templates/vikipedia.com.tr
@@ -0,0 +1 @@
+wikipedia.org
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/88706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a3fe4380f5aed0afd6c48910cb32f78be29fde8
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add PHP CodeSniffer jobs for 4 extensions - change (integration/jenkins-job-builder-config)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Add PHP CodeSniffer jobs for 4 extensions
..


Add PHP CodeSniffer jobs for 4 extensions

CLDR, TranslationNotifications, TwnMainPage, UniversalLanguageSelector.
This needs to be merged before Change-Id
Iec223a59a72432e95bde256247f40d27c6b90f70

Change-Id: I95ba7ca87c6ce93ef97a0b7c54c88832b0a32ccf
---
M mediawiki-extensions.yaml
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index a9eef0c..0fc7ba0 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -493,6 +493,12 @@
 ext-name: VisualEditor
 
 - project:
+name: 'mwext-cldr'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
 name: 'mwext-MobileFrontend'
 jobs:
  - '{name}-ruby1.9.3lint'
@@ -501,6 +507,8 @@
 name: 'mwext-UniversalLanguageSelector'
 jobs:
  - '{name}-ruby1.9.3lint'
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
 
 - job-template:
 name: 'mwext-PoolCounter-build'
@@ -531,6 +539,18 @@
  - '{name}-phpcs-strict-HEAD'
 
 - project:
+name: 'mwext-TranslationNotifications'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
+name: 'mwext-TwnMainPage'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
 name: 'mwext-BlameMaps'
 jobs:
  - python-jobs

-- 
To view, visit https://gerrit.wikimedia.org/r/88704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95ba7ca87c6ce93ef97a0b7c54c88832b0a32ccf
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Move the remaining non-wikipedia projects to text-varnish - change (operations/puppet)

2013-10-09 Thread Mark Bergsma (Code Review)
Mark Bergsma has submitted this change and it was merged.

Change subject: Move the remaining non-wikipedia projects to text-varnish
..


Move the remaining non-wikipedia projects to text-varnish

Change-Id: Id692ee6e2e85d40b5ae5213ae9c3e2c32c84f733
---
M manifests/lvs.pp
1 file changed, 18 insertions(+), 18 deletions(-)

Approvals:
  Mark Bergsma: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/lvs.pp b/manifests/lvs.pp
index f83dc58..aa75b39 100644
--- a/manifests/lvs.pp
+++ b/manifests/lvs.pp
@@ -114,38 +114,26 @@
'pmtpa' => {
'textsvc' => "10.2.1.25",
'wikipedialb' => "208.80.152.201",
-   'wiktionarylb' => "208.80.152.202",
-   'wikiquotelb' => "208.80.152.203",
-   'wikibookslb' => "208.80.152.204",
-   'wikisourcelb' => "208.80.152.205",
-   'wikinewslb' => "208.80.152.206",
-   'wikiversitylb' => "208.80.152.207",
},
'eqiad' => {
'textsvc' => "10.2.2.25",
'wikipedialb' => "208.80.154.225",
-   'wiktionarylb' => "208.80.154.226",
-   'wikiquotelb' => "208.80.154.227",
-   'wikibookslb' => "208.80.154.228",
-   'wikisourcelb' => "208.80.154.229",
-   'wikinewslb' => "208.80.154.230",
-   'wikiversitylb' => "208.80.154.231",
},
'esams' => {
'textsvc' => "10.2.3.25",
'wikipedialb' => "91.198.174.225",
-   'wiktionarylb' => "91.198.174.226",
-   'wikiquotelb' => "91.198.174.227",
-   'wikibookslb' => "91.198.174.228",
-   'wikisourcelb' => "91.198.174.229",
-   'wikinewslb' => "91.198.174.230",
-   'wikiversitylb' => "91.198.174.231",
},
'ulsfo' => {},
},
'text-varnish' => {
'pmtpa' => {
'wikimedialb' => "208.80.152.200",
+   'wiktionarylb' => "208.80.152.202",
+   'wikiquotelb' => "208.80.152.203",
+   'wikibookslb' => "208.80.152.204",
+   'wikisourcelb' => "208.80.152.205",
+   'wikinewslb' => "208.80.152.206",
+   'wikiversitylb' => "208.80.152.207",
'mediawikilb' => "208.80.152.208",
'foundationlb' => "208.80.152.209",
'wikidatalb' => '208.80.152.218',
@@ -153,6 +141,12 @@
},
'eqiad' => {
'wikimedialb' => "208.80.154.224",
+   'wiktionarylb' => "208.80.154.226",
+   'wikiquotelb' => "208.80.154.227",
+   'wikibookslb' => "208.80.154.228",
+   'wikisourcelb' => "208.80.154.229",
+   'wikinewslb' => "208.80.154.230",
+   'wikiversitylb' => "208.80.154.231",
'mediawikilb' => "208.80.154.232",
'foundationlb' => "208.80.154.233",
'wikidatalb' => '208.80.154.242',
@@ -160,6 +154,12 @@
},
'esams' => {
'wikimedialb' => "91.198.174.224",
+   'wiktionarylb' => "91.198.174.226",
+   'wikiquotelb' => "91.198.174.227",
+   'wikibookslb' => "91.198.174.228",
+   'wikisourcelb' => "91.198.174.229",
+   'wikinewslb' => "91.198.174.230",
+  

[MediaWiki-commits] [Gerrit] redirect vikipedi[a].com.tr to tr.wikipedia.org - change (operations/apache-config)

2013-10-09 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88705


Change subject: redirect vikipedi[a].com.tr to tr.wikipedia.org
..

redirect vikipedi[a].com.tr to tr.wikipedia.org

redirect vikipedia.com.tr and vikipedia.com.tr to
the Turkish Wikipedia

RT #5928

Change-Id: I9c1f068241c26c76259048034c89050bb94d6eb2
---
M redirects.conf
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config 
refs/changes/05/88705/1

diff --git a/redirects.conf b/redirects.conf
index 16f7122..7697fbc 100644
--- a/redirects.conf
+++ b/redirects.conf
@@ -83,6 +83,8 @@
 textbook.wikipedia.org \
 ve.wikimedia.org \
 vikimedija.org *.vikimedija.org \
+vikipedi.com.tr *.vikipedi.com.tr \
+vikipedia.com.tr *.vikipedia.com.tr \
 visualwikipedia.com *.visualwikipedia.com \
 visualwikipedia.net *.visualwikipedia.net \
 voyagewiki.com *.voyagewiki.com \
@@ -724,6 +726,10 @@
 RewriteCond %{HTTP_HOST} (.*)wikipedia\.in$
 RewriteRule ^(.*)$ http://wikimedia.in/wikipedia.html [R=301,L]
 
+# vikipedi.com.tr & vikipedia.com.tr - RT #5928
+RewriteCond %{HTTP_HOST} (.*)vikipedi[a]\.com\.tr$
+RewriteRule ^(.*)$ http://tr.wikipedia.org [R=301,L]
+
 # coffee - keep for historic reasons:)
 RewriteCond %{HTTP_HOST} =coffee.wikimedia.org
 RewriteRule ^(.*)$ 
http://en.wikipedia.org/wiki/Hyper_Text_Coffee_Pot_Control_Protocol [R=301,L,NE]

-- 
To view, visit https://gerrit.wikimedia.org/r/88705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c1f068241c26c76259048034c89050bb94d6eb2
Gerrit-PatchSet: 1
Gerrit-Project: operations/apache-config
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add UserGetReservedNames hook subscriber - change (mediawiki...ArticleFeedbackv5)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Add UserGetReservedNames hook subscriber
..


Add UserGetReservedNames hook subscriber

bug: 54198
Change-Id: Ia38b5fd3696e667d85f8708a28123cf2c391a89a
---
M ArticleFeedbackv5.hooks.php
M ArticleFeedbackv5.php
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Matthias Mullie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ArticleFeedbackv5.hooks.php b/ArticleFeedbackv5.hooks.php
index d4f902f..899857d 100644
--- a/ArticleFeedbackv5.hooks.php
+++ b/ArticleFeedbackv5.hooks.php
@@ -931,4 +931,13 @@
 
return true;
}
+
+   /**
+* @param array $names
+* @return bool
+*/
+   public function onUserGetReservedNames( &$names ) {
+   $names[] = 'msg:articlefeedbackv5-default-user';
+   return true;
+   }
 }
diff --git a/ArticleFeedbackv5.php b/ArticleFeedbackv5.php
index 7c0e9df..e5e28aa 100644
--- a/ArticleFeedbackv5.php
+++ b/ArticleFeedbackv5.php
@@ -442,6 +442,7 @@
 $wgHooks['ProtectionForm::save'][] = 
'ArticleFeedbackv5Hooks::onProtectionSave';
 $wgHooks['ProtectionForm::showLogExtract'][] = 
'ArticleFeedbackv5Hooks::onShowLogExtract';
 $wgHooks['UserLoginComplete'][] = 'ArticleFeedbackv5Hooks::userLoginComplete';
+$wgHooks['UserGetReservedNames'][] = 
'ArticleFeedbackv5Hooks::onUserGetReservedNames';
 
 // API Registration
 $wgAPIListModules['articlefeedbackv5-view-feedback'] = 
'ApiViewFeedbackArticleFeedbackv5';

-- 
To view, visit https://gerrit.wikimedia.org/r/84476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia38b5fd3696e667d85f8708a28123cf2c391a89a
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Matthias Mullie 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add PHP CodeSniffer jobs for 4 extensions - change (integration/jenkins-job-builder-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88704


Change subject: Add PHP CodeSniffer jobs for 4 extensions
..

Add PHP CodeSniffer jobs for 4 extensions

CLDR, TranslationNotifications, TwnMainPage, UniversalLanguageSelector.
This needs to be merged before Change-Id
Iec223a59a72432e95bde256247f40d27c6b90f70

Change-Id: I95ba7ca87c6ce93ef97a0b7c54c88832b0a32ccf
---
M mediawiki-extensions.yaml
1 file changed, 24 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/04/88704/1

diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index a9eef0c..611d434 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -493,6 +493,12 @@
 ext-name: VisualEditor
 
 - project:
+name: 'mwext-cldr'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
 name: 'mwext-MobileFrontend'
 jobs:
  - '{name}-ruby1.9.3lint'
@@ -531,6 +537,24 @@
  - '{name}-phpcs-strict-HEAD'
 
 - project:
+name: 'mwext-TranslationNotifications'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
+name: 'mwext-TwnMainPage'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
+name: 'mwext-UniversalLanguageSelector'
+jobs:
+ - '{name}-phpcs-strict'
+ - '{name}-phpcs-strict-HEAD'
+
+- project:
 name: 'mwext-BlameMaps'
 jobs:
  - python-jobs

-- 
To view, visit https://gerrit.wikimedia.org/r/88704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95ba7ca87c6ce93ef97a0b7c54c88832b0a32ccf
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Run PHP CS strict on 4 extensions - change (integration/zuul-config)

2013-10-09 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88703


Change subject: Run PHP CS strict on 4 extensions
..

Run PHP CS strict on 4 extensions

CLDR, TranslationNotifications, TwnMainPage and ULS. Only on check,
possibly to later be made voting.

References:
* https://gerrit.wikimedia.org/r/#/c/88626
* https://gerrit.wikimedia.org/r/#/c/88635

Change-Id: Iec223a59a72432e95bde256247f40d27c6b90f70
---
M layout.yaml
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config 
refs/changes/03/88703/1

diff --git a/layout.yaml b/layout.yaml
index e57795a..b54ac48 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -1131,6 +1131,7 @@
 check-only:
   - mwext-cldr-jslint
   - mwext-cldr-lint
+  - mwext-cldr-phpcs-strict-HEAD  # Experiment, bug 48420
 gate-and-submit:
   - mwext-cldr-jslint
   - mwext-cldr-lint:
@@ -2188,6 +2189,7 @@
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
   - mwext-TranslationNotifications-lint
+  - mwext-TranslationNotifications-phpcs-strict-HEAD # Experiment, bug 
48420
 test:
   - mwext-TranslationNotifications-jslint
   - mwext-TranslationNotifications-phpcs-HEAD
@@ -2214,6 +2216,7 @@
   - mwext-TwnMainPage-jslint
   - mwext-TwnMainPage-phpcs-HEAD
   - mwext-TwnMainPage-lint
+  - mwext-TwnMainPage-phpcs-strict-HEAD # Experiment, bug 48420
 test:
   - mwext-TwnMainPage-jslint
   - mwext-TwnMainPage-phpcs-HEAD
@@ -2236,6 +2239,7 @@
   - mwext-UniversalLanguageSelector-phpcs-HEAD
   - mwext-UniversalLanguageSelector-jslint
   - mwext-UniversalLanguageSelector-ruby1.9.3lint
+  - mwext-UniversalLanguageSelector-phpcs-strict-HEAD # Experiment, bug 
48420
 gate-and-submit:
   - mwext-UniversalLanguageSelector-jslint
   - mwext-UniversalLanguageSelector-phpcs-HEAD

-- 
To view, visit https://gerrit.wikimedia.org/r/88703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec223a59a72432e95bde256247f40d27c6b90f70
Gerrit-PatchSet: 1
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Code needed for Selenium tests - change (mediawiki...Translate)

2013-10-09 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88702


Change subject: Code needed for Selenium tests
..

Code needed for Selenium tests

Change-Id: Iddc361509401078121acc5efc764b1c55fbc48c3
---
A tests/browser/Gemfile
A tests/browser/Gemfile.lock
A tests/browser/README.md
A tests/browser/config/config.yml
A tests/browser/config/cucumber.yml
A tests/browser/features/support/env.rb
A tests/browser/features/support/modules/url_module.rb
7 files changed, 108 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/02/88702/1

diff --git a/tests/browser/Gemfile b/tests/browser/Gemfile
new file mode 100755
index 000..7f53e68
--- /dev/null
+++ b/tests/browser/Gemfile
@@ -0,0 +1,12 @@
+#ruby=ruby-2.0.0-p247
+#ruby-gemset=Translate
+
+source 'https://rubygems.org'
+
+gem 'cucumber'
+gem 'json'
+gem 'mediawiki-selenium'
+gem 'net-http-persistent'
+gem 'page-object'
+gem 'rspec-expectations'
+gem 'syntax'
diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
new file mode 100644
index 000..f708dd8
--- /dev/null
+++ b/tests/browser/Gemfile.lock
@@ -0,0 +1,58 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+builder (3.2.2)
+childprocess (0.3.9)
+  ffi (~> 1.0, >= 1.0.11)
+cucumber (1.3.8)
+  builder (>= 2.1.2)
+  diff-lcs (>= 1.1.3)
+  gherkin (~> 2.12.1)
+  multi_json (>= 1.7.5, < 2.0)
+  multi_test (>= 0.0.2)
+data_magic (0.16.1)
+  faker (>= 1.1.2)
+  yml_reader (>= 0.2)
+diff-lcs (1.2.4)
+faker (1.2.0)
+  i18n (~> 0.5)
+ffi (1.9.0)
+gherkin (2.12.1)
+  multi_json (~> 1.3)
+i18n (0.6.5)
+json (1.8.0)
+mediawiki-selenium (0.1.8)
+multi_json (1.8.1)
+multi_test (0.0.2)
+net-http-persistent (2.9)
+page-object (0.9.2)
+  page_navigation (>= 0.8)
+  selenium-webdriver (>= 2.35.0)
+  watir-webdriver (>= 0.6.4)
+page_navigation (0.9)
+  data_magic (>= 0.14)
+rspec-expectations (2.14.3)
+  diff-lcs (>= 1.1.3, < 2.0)
+rubyzip (0.9.9)
+selenium-webdriver (2.35.1)
+  childprocess (>= 0.2.5)
+  multi_json (~> 1.0)
+  rubyzip (< 1.0.0)
+  websocket (~> 1.0.4)
+syntax (1.0.0)
+watir-webdriver (0.6.4)
+  selenium-webdriver (>= 2.18.0)
+websocket (1.0.7)
+yml_reader (0.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  cucumber
+  json
+  mediawiki-selenium
+  net-http-persistent
+  page-object
+  rspec-expectations
+  syntax
diff --git a/tests/browser/README.md b/tests/browser/README.md
new file mode 100644
index 000..3c5449a
--- /dev/null
+++ b/tests/browser/README.md
@@ -0,0 +1 @@
+Please see https://github.com/wikimedia/qa-browsertests for instructions on 
how to run tests.
diff --git a/tests/browser/config/config.yml b/tests/browser/config/config.yml
new file mode 100644
index 000..6df0a31
--- /dev/null
+++ b/tests/browser/config/config.yml
@@ -0,0 +1,24 @@
+chrome:
+  name: chrome
+  platform: Linux
+  version:
+
+firefox:
+  name: firefox
+  platform: Linux
+  version: 23
+
+internet_explorer_8:
+  name: internet_explorer
+  platform: Windows XP
+  version: 8
+
+internet_explorer_9:
+  name: internet_explorer
+  platform: Windows 7
+  version: 9
+
+internet_explorer_10:
+  name: internet_explorer
+  platform: Windows 8
+  version: 10
diff --git a/tests/browser/config/cucumber.yml 
b/tests/browser/config/cucumber.yml
new file mode 100644
index 000..150c284
--- /dev/null
+++ b/tests/browser/config/cucumber.yml
@@ -0,0 +1,2 @@
+ci: --format Cucumber::Formatter::Sauce --out reports/junit
+default: --format progress
diff --git a/tests/browser/features/support/env.rb 
b/tests/browser/features/support/env.rb
new file mode 100644
index 000..2281d94
--- /dev/null
+++ b/tests/browser/features/support/env.rb
@@ -0,0 +1 @@
+require 'mediawiki/selenium'
diff --git a/tests/browser/features/support/modules/url_module.rb 
b/tests/browser/features/support/modules/url_module.rb
new file mode 100644
index 000..6268546
--- /dev/null
+++ b/tests/browser/features/support/modules/url_module.rb
@@ -0,0 +1,10 @@
+module URL
+  def self.url(name)
+if ENV['MEDIAWIKI_URL']
+  mediawiki_url = ENV['MEDIAWIKI_URL']
+else
+  mediawiki_url = 'http://en.wikipedia.beta.wmflabs.org/wiki/'
+end
+"#{mediawiki_url}#{name}"
+  end
+end

-- 
To view, visit https://gerrit.wikimedia.org/r/88702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddc361509401078121acc5efc764b1c55fbc48c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Wikidata Build from 12:00 09.OCT.2013 DNM - change (mediawiki...Wikidata)

2013-10-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88701


Change subject: Wikidata Build from 12:00 09.OCT.2013 DNM
..

Wikidata Build from 12:00 09.OCT.2013 DNM

> DO NOT MERGE <

Change-Id: I5884b60c0170ec4baafd5f9bbfd14bf558d9f998
---
A Wikidata.php
A composer.json
A composer.lock
A vendor/autoload.php
A vendor/composer/ClassLoader.php
A vendor/composer/autoload_classmap.php
A vendor/composer/autoload_files.php
A vendor/composer/autoload_namespaces.php
A vendor/composer/autoload_real.php
A vendor/composer/installed.json
A vendor/data-values/data-types
A vendor/data-values/data-values
A vendor/diff/diff
A vendor/wikibase/data-model
A vendor/wikibase/wikibase
15 files changed, 861 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/01/88701/1

diff --git a/Wikidata.php b/Wikidata.php
new file mode 100644
index 000..140ba76
--- /dev/null
+++ b/Wikidata.php
@@ -0,0 +1,3 @@
+=5.3.0",
+   "wikibase/wikibase": "*"
+},
+   "minimum-stability" : "dev"
+}
diff --git a/composer.lock b/composer.lock
new file mode 100644
index 000..ba74f17
--- /dev/null
+++ b/composer.lock
@@ -0,0 +1,265 @@
+{
+"_readme": [
+"This file locks the dependencies of your project to a known state",
+"Read more about it at 
http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file";
+],
+"hash": "a80abba438d0e3f3977c3654a7c24491",
+"packages": [
+{
+"name": "data-values/data-types",
+"version": "dev-master",
+"source": {
+"type": "git",
+"url": 
"https://github.com/wikimedia/mediawiki-extensions-DataTypes.git";,
+"reference": "b9b775a20e5678e0ac8cd1f40682e21e95c10573"
+},
+"dist": {
+"type": "zip",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-DataTypes/zipball/b9b775a20e5678e0ac8cd1f40682e21e95c10573";,
+"reference": "b9b775a20e5678e0ac8cd1f40682e21e95c10573",
+"shasum": ""
+},
+"require": {
+"data-values/data-values": "dev-master",
+"php": ">=5.3.0"
+},
+"type": "library",
+"autoload": {
+"files": [
+"DataTypes.php"
+]
+},
+"notification-url": "https://packagist.org/downloads/";,
+"license": [
+"GPL-2.0+"
+],
+"authors": [
+{
+"name": "Jeroen De Dauw",
+"email": "jeroended...@gmail.com",
+"homepage": "http://jeroendedauw.com";,
+"role": "Developer"
+},
+{
+"name": "Wikidata community",
+"homepage": "https://wikidata.org";,
+"role": "Developer"
+}
+],
+"description": "PHP library defining the DataTypes\\DataType class 
of which instances represent a type of value, such as \"positive integer\" or 
\"percentage\".",
+"homepage": "https://www.mediawiki.org/wiki/Extension:DataTypes";,
+"keywords": [
+"datatypes",
+"datavalues"
+],
+"time": "2013-10-08 00:52:54"
+},
+{
+"name": "data-values/data-values",
+"version": "dev-master",
+"source": {
+"type": "git",
+"url": 
"https://github.com/wikimedia/mediawiki-extensions-DataValues.git";,
+"reference": "19b64a01f58738d33ff8892ec9966536b31f7702"
+},
+"dist": {
+"type": "zip",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-DataValues/zipball/19b64a01f58738d33ff8892ec9966536b31f7702";,
+"reference": "19b64a01f58738d33ff8892ec9966536b31f7702",
+"shasum": ""
+},
+"require": {
+"php": ">=5.3.0"
+},
+"replace": {
+"mediawiki/data-values": "*"
+},
+"type": "library",
+"autoload": {
+"files": [
+"DataValues.php",
+"ValueView/ValueView.php"
+]
+},
+"notification-url": "https://packagist.org/downloads/";,
+"license": [
+"GPL-2.0+"
+],
+"authors": [
+{
+"name": "Jeroen De Dauw",
+"email": "jeroended...@gmail.com",
+"homepage": "http://jeroendedauw.com";,
+"role": "Developer"
+  

[MediaWiki-commits] [Gerrit] zuul: metrics for test/gate pipelines - change (integration/docroot)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: zuul: metrics for test/gate pipelines
..


zuul: metrics for test/gate pipelines

Change adds two new graphite based graphs that show the Zuul processing
for the busiest pipelines: test and gate.

I have also exploded the render URL for easier editing.

Change-Id: I9cd0a6a8eba123b89743f785b8b9d317cb293e17
---
M org/wikimedia/integration/zuul/default.html
1 file changed, 47 insertions(+), 3 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/org/wikimedia/integration/zuul/default.html 
b/org/wikimedia/integration/zuul/default.html
index 3604541..e703831 100644
--- a/org/wikimedia/integration/zuul/default.html
+++ b/org/wikimedia/integration/zuul/default.html
@@ -5,7 +5,51 @@


Job Stats
-   
-
-   
+   
+   
+
+   
+   
+
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cd0a6a8eba123b89743f785b8b9d317cb293e17
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] zuul: metrics for test/gate pipelines - change (integration/docroot)

2013-10-09 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88700


Change subject: zuul: metrics for test/gate pipelines
..

zuul: metrics for test/gate pipelines

Change adds two new graphite based graphs that show the Zuul processing
for the busiest pipelines: test and gate.

I have also exploded the render URL for easier editing.

Change-Id: I9cd0a6a8eba123b89743f785b8b9d317cb293e17
---
M org/wikimedia/integration/zuul/default.html
1 file changed, 47 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/docroot 
refs/changes/00/88700/1

diff --git a/org/wikimedia/integration/zuul/default.html 
b/org/wikimedia/integration/zuul/default.html
index 3604541..e703831 100644
--- a/org/wikimedia/integration/zuul/default.html
+++ b/org/wikimedia/integration/zuul/default.html
@@ -5,7 +5,51 @@


Job Stats
-   
-
-   
+   
+   
+
+   
+   
+
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cd0a6a8eba123b89743f785b8b9d317cb293e17
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add .gitreview and .gitignore - change (mediawiki...Wikidata)

2013-10-09 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged.

Change subject: Add .gitreview and .gitignore
..


Add .gitreview and .gitignore

Change-Id: I2891a9d2acaf803ec6c2ca241d596650e5efcbca
---
A .gitignore
A .gitreview
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Addshore: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..98b092a
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,4 @@
+.svn
+*~
+*.kate-swp
+.*.swp
diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..a165c57
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,6 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=mediawiki/extensions/Wikidata.git
+defaultbranch=master
+defaultrebase=0

-- 
To view, visit https://gerrit.wikimedia.org/r/88660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2891a9d2acaf803ec6c2ca241d596650e5efcbca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Changed message 'Geographic coordinate' to 'Geographic coord... - change (mediawiki...DataTypes)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Changed message 'Geographic coordinate' to 'Geographic 
coordinates'
..


Changed message 'Geographic coordinate' to 'Geographic coordinates'

Change-Id: I664fa490b3b903fac2b79e2833eb3243729cbfd2
---
M DataTypes.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tobias Gritschacher: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/DataTypes.i18n.php b/DataTypes.i18n.php
index e2da770..98b42aa 100644
--- a/DataTypes.i18n.php
+++ b/DataTypes.i18n.php
@@ -28,7 +28,7 @@
'datatypes-type-mediawiki-title' => 'MediaWiki title',
'datatypes-type-unknown' => 'Unspecified',
'datatypes-type-boolean' => 'Boolean',
-   'datatypes-type-globe-coordinate' => 'Geographic coordinate',
+   'datatypes-type-globe-coordinate' => 'Geographic coordinates',
'datatypes-type-time' => 'Time',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I664fa490b3b903fac2b79e2833eb3243729cbfd2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DataTypes
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update .gitignore - change (mediawiki...Wikibase)

2013-10-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88699


Change subject: Update .gitignore
..

Update .gitignore

- do not include the .idea directory generated by RubyMine

Change-Id: I66ae91bebb5e1688fa05836f7730765798654d06
---
M .gitignore
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/99/88699/1

diff --git a/.gitignore b/.gitignore
index 4f363d4..f279a81 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,4 +11,6 @@
 
 easyrdf/
 
-!.*
\ No newline at end of file
+!.*
+
+selenium_cuc/.idea

-- 
To view, visit https://gerrit.wikimedia.org/r/88699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66ae91bebb5e1688fa05836f7730765798654d06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] delete dsh group 'nagios' - change (operations/puppet)

2013-10-09 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: delete dsh group 'nagios'
..


delete dsh group 'nagios'

this was once created most likely by me when using upgrade-helper script
to create dsh groups from parsing nagios config as the reliable source.
but it doesn't make sense to keep an outdated version in git.

Change-Id: I83bbc69c6de11e9166c91b0db624e531b31f2570
---
D files/dsh/group/nagios
1 file changed, 0 insertions(+), 724 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/files/dsh/group/nagios b/files/dsh/group/nagios
deleted file mode 100644
index 19dcba6..000
--- a/files/dsh/group/nagios
+++ /dev/null
@@ -1,724 +0,0 @@
-db32
-srv209
-mw8
-amssq52
-knsq25
-db1022
-nfs1
-mw1129
-db22
-srv190
-mw1138
-sq78
-amssq38
-db1016
-search9
-mw
-es1001
-db9
-mw1025
-mw1151
-sq50
-amssq31
-mw1160
-srv236
-mw1059
-hume
-db33
-srv219
-db38
-mw4
-nescio
-mw2
-mw10
-mw6
-mw1
-mw68
-srv218
-mw9
-searchidx2
-db26
-mw7
-mw3
-91.198.174.6
-srv283
-mw5
-sq72
-mw1082
-mw65
-mw70
-srv231
-srv228
-srv245
-srv289
-mw43
-yvon
-mw66
-mw16
-srv211
-srv295
-mw11
-srv301
-srv237
-lvs1004
-snapshot3
-mw29
-mw45
-srv271
-srv201
-srv297
-srv254
-mw1073
-srv282
-srv227
-srv269
-mw1140
-srv225
-srv198
-srv194
-ssl3003
-mw62
-srv224
-srv243
-srv197
-srv272
-mw47
-mw18
-mw1118
-mw1112
-mw1141
-srv268
-amssq54
-mw55
-srv253
-srv226
-srv216
-srv285
-amssq62
-knsq29
-amssq33
-mw1046
-snapshot4
-mw58
-ssl3004
-srv210
-snapshot1
-mw71
-srv280
-mw34
-cp3002
-mw52
-srv207
-srv276
-mw1002
-mw20
-mw33
-lvs6
-srv300
-mw54
-srv229
-mw14
-db25
-srv270
-srv261
-srv263
-srv213
-srv264
-mw35
-db1001
-mw27
-srv189
-ssl4
-mw37
-mw46
-owa3
-mw59
-srv234
-srv262
-mw1116
-mw1065
-mw1063
-srv208
-mw1051
-ms5
-mw1158
-srv298
-mw1104
-srv205
-mw15
-amssq32
-sq67
-mw31
-srv193
-mw1134
-dataset2
-srv251
-mw57
-mw69
-srv202
-srv221
-srv275
-knsq27
-srv232
-sq75
-mw61
-db37
-srv248
-pdf1
-mw49
-mw25
-srv279
-srv290
-mw41
-srv257
-srv212
-db1020
-srv288
-mw17
-mw30
-amssq48
-srv241
-srv265
-srv286
-srv249
-mw1137
-srv220
-srv247
-mw1045
-mw1006
-srv203
-srv274
-srv235
-srv287
-srv233
-srv256
-srv246
-mw1058
-mw42
-mw1107
-srv296
-mw32
-mw74
-srv294
-srv199
-sq54
-gurvin
-srv200
-srv277
-mw1050
-sq73
-srv259
-amssq40
-srv292
-srv188
-db1031
-srv195
-mw1008
-mw26
-srv250
-knsq24
-amssq56
-srv214
-mw44
-srv222
-srv191
-mw1007
-srv252
-mw67
-mw60
-mw21
-srv273
-mw48
-srv204
-mw19
-srv215
-srv258
-mw36
-srv187
-srv244
-ms6
-mw39
-mw63
-db1034
-mw72
-db1012
-mw24
-mw22
-mw53
-db1048
-mw56
-srv239
-srv238
-mw64
-srv291
-mw38
-mw28
-srv192
-srv293
-knsq17
-mw1121
-mw51
-mw12
-mw40
-mw73
-storage3
-srv260
-srv242
-srv267
-sq79
-srv299
-snapshot2
-srv196
-srv240
-srv230
-ssl3002
-mw13
-srv223
-amssq51
-mw1026
-mw1150
-grosley
-db1021
-db1010
-
-mw1009
-db36
-arsenic
-db1040
-db1025
-db1033
-pdf2
-mw1030
-cp1044
-mw1139
-virt2
-mw1126
-db1005
-db23
-lvs1002
-db1008
-db1026
-mw1144
-amssq37
-mw1047
-db1002
-mw1036
-mw1084
-lvs1005
-db1007
-knsq19
-amslvs3
-amssq46
-bayes
-db14
-sq48
-db10
-knsq28
-mw1034
-db19
-copper
-mw1052
-aluminium
-amssq59
-db44
-emery
-amssq44
-amssq45
-sq53
-mw1143
-db11
-db1003
-amssq34
-db1045
-mw1156
-db1015
-db17
-db1035
-mw1100
-db12
-amssq58
-mw1105
-lvs5
-sq43
-linne
-db1018
-ms3
-db1009
-db41
-db40
-amslvs4
-sq49
-db1046
-sq74
-db18
-amssq61
-db1043
-mw1135
-db13
-ssl1003
-db1041
-amssq55
-amssq57
-db47
-mw1093
-amssq43
-db16
-amssq60
-db1044
-db29
-amssq53
-knsq22
-sq80
-amslvs2
-brewster
-db1028
-amssq39
-mw1049
-mw1090
-db39
-amssq47
-carbon
-sq84
-mw1048
-mw1153
-mw1023
-ssl1004
-es1
-ssl1001
-mw1085
-hooft
-amssq35
-db1038
-db35
-amslvs1
-mw1074
-db1004
-es1002
-sq81
-ms1004
-db1006
-db27
-db1024
-db1011
-db1039
-mw1032
-mw1019
-db1013
-ssl3001
-amssq50
-db1017
-amssq49
-db1027
-mw1080
-db21
-cp3001
-mw1122
-db30
-mw1015
-mw1124
-tridge
-mw1070
-db1042
-mw1035
-db1030
-argon
-db15
-amssq36
-mw1086
-search2
-cp1043
-es3
-amssq41
-mw1109
-db1029
-mw1004
-db1019
-search5
-sq65
-maerlant
-amssq42
-mw1028
-formey
-db34
-db1014
-project2
-sq83
-mw1003
-lvs1006
-sq60
-mw1117
-lvs2
-search6
-db46
-mw1013
-mw1071
-mw1072
-gallium
-es2
-sq76
-mw1067
-mw1068
-mw1114
-kaulen
-mw1083
-search8
-mw1149
-sq61
-ssl1002
-mw1055
-sq56
-mw1014
-mw1016
-mw1011
-mw1024
-db45
-knsq18
-erzurumi
-search1
-db42
-stafford
-mw1142
-knsq20
-mw1123
-sanger
-ssl2
-mw1096
-sq52
-mw1154
-es1003
-mw1043
-mw1060
-mw1148
-dobson
-sq63
-sq57
-williams
-mw1069
-sq64
-mw1078
-niobium
-mw1053
-mw1128
-mw1031
-mw1079
-mw1157
-mw1029
-mw1077
-mw1075
-mw1113
-mw1101
-mw1130
-mw1088
-transcode1
-mw1106
-msfe1001
-streber
-stat1
-db43
-mw1146
-magnesium
-mw1098
-sq59
-mw1152
-tarin
-pdf3
-mw1010
-search4
-mw1044
-ms1002
-mw1001
-db24
-es1004
-es4
-owa1
-mw1136
-mw1041
-zinc
-hooper
-lvs4
-mw1091
-locke
-sq44
-mw1022
-mw1147
-knsq26
-lvs3
-sq62
-mw1057
-208.80.152.131
-sq51
-gilman
-knsq23
-knsq16
-mw1133
-mw1102
-search12
-mw1097
-mw108

[MediaWiki-commits] [Gerrit] Navigation Timing: differentiate by auth status rather than ... - change (operations/puppet)

2013-10-09 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: Navigation Timing: differentiate by auth status rather than wiki
..


Navigation Timing: differentiate by auth status rather than wiki

The per-wiki metrics haven't been especially insightful; we have too many wikis
and the performance differences between them are relatively minor when simple
page views are concerned. It'd be more interesting to compare the experience of
logged-in users with anonymous visitors. So log that instead.


Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
---
M files/graphite/modules/navtiming.py
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/files/graphite/modules/navtiming.py 
b/files/graphite/modules/navtiming.py
index 7770178..e47d0ec 100644
--- a/files/graphite/modules/navtiming.py
+++ b/files/graphite/modules/navtiming.py
@@ -58,16 +58,13 @@
 event['pageSpeed'] = (
 event['loadEventEnd'] - event['domInteractive'])
 
-wiki = meta['wiki']
-if not event.get('isAnon'):
-continue
-
 site = 'mobile' if 'mobileMode' in event else 'desktop'
+auth = 'anonymous' if event.get('isAnon') else 'authenticated'
 
 for metric in metrics:
 value = event.get(metric, 0)
 if value > 0 and value < 6:
 stat = 'browser.%s.%s:%s|ms' % (metric, site, value)
 sock.sendto(stat.encode('utf-8'), addr)
-stat = 'browser.%s.%s.%s:%s|ms' % (metric, wiki, site, value)
+stat = 'browser.%s.%s.%s:%s|ms' % (metric, site, auth, value)
 sock.sendto(stat.encode('utf-8'), addr)

-- 
To view, visit https://gerrit.wikimedia.org/r/88692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Faidon Liambotis 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Make the save api customizable for translationeditor plugin - change (mediawiki...Translate)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Make the save api customizable for translationeditor plugin
..


Make the save api customizable for translationeditor plugin

Introduce TranslationApiStorage class

Change-Id: I2bbc6676c9ce99444f3b346d6c670ccda3a07968
---
M Resources.php
M resources/js/ext.translate.editor.js
A resources/js/ext.translate.storage.js
3 files changed, 80 insertions(+), 40 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Resources.php b/Resources.php
index 00542b7..30d0e77 100644
--- a/Resources.php
+++ b/Resources.php
@@ -28,6 +28,10 @@
),
 ) + $resourcePaths;
 
+$wgResourceModules['ext.translate.storage'] = array(
+   'scripts' => 'resources/js/ext.translate.storage.js',
+) + $resourcePaths;
+
 $wgResourceModules['ext.translate.editor'] = array(
'scripts' => array(
'resources/js/ext.translate.editor.js',
@@ -42,6 +46,7 @@
),
'dependencies' => array(
'ext.translate.base',
+   'ext.translate.storage',
'ext.translate.hooks',
'ext.translate.dropdownmenu',
'jquery.uls.grid',
diff --git a/resources/js/ext.translate.editor.js 
b/resources/js/ext.translate.editor.js
index 03d3af5..9c665aa 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -31,6 +31,7 @@
this.saving = false;
this.expanded = false;
this.listen();
+   this.storage = this.options.storage || new 
mw.translate.TranslationApiStorage();
}
 
TranslateEditor.prototype = {
@@ -138,7 +139,7 @@
 */
save: function () {
var translateEditor = this,
-   api = new mw.Api(), translation;
+   translation;
 
mw.translateHooks.run( 'beforeSubmit', 
translateEditor.$editor );
translation = translateEditor.$editor.find( 
'.editcolumn textarea' ).val();
@@ -158,56 +159,54 @@
translateEditor.$editor.find( '.message-tools-history' )
.removeClass( 'hide' );
 
-   api.postWithEditToken( {
-   action: 'edit',
-   title: translateEditor.message.title,
-   text: translation
-   }, function ( response ) {
-   if ( response.edit.result === 'Success' ) {
-   translateEditor.markTranslated();
-
-   // Update the translation
-   translateEditor.message.translation = 
translation;
-   translateEditor.$editTrigger.find( 
'.tux-list-translation' )
-   .text( translation );
-   } else {
-   translateEditor.savingError( 
response.warning );
-   }
-
-   translateEditor.saving = false;
-
-   // remove warnings if any.
-   translateEditor.removeWarning( 'diff' );
-   translateEditor.removeWarning( 'validation' );
-
-   $( '.tux-editor-clear-translated' )
-   .removeClass( 'hide' )
-   .prop( 'disabled', false );
-
-   // Save callback
-   if ( translateEditor.options.onSave ) {
-   translateEditor.options.onSave( 
translation );
-   }
-
-   mw.translate.dirty = false;
-   mw.translateHooks.run( 'afterSubmit', 
translateEditor.$editor );
-   }, function ( errorCode, results ) {
-   translateEditor.savingError( results.error.info 
);
-
-   translateEditor.saving = false;
+   this.storage.save(
+   translateEditor.message.title,
+   translation
+   ).done( function () {
+   // Update the translation
+   translateEditor.message.translation = 
translation;
+   translateEditor.onSaveSuccess();
+   } ).fail( function ( errorCode, response ) {
+   translateEditor.onSaveFail( response.error.info 
);
} );
+   },
+
+   /**

[MediaWiki-commits] [Gerrit] Make sitelink browsertests work on beta labs - change (mediawiki...Wikibase)

2013-10-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged.

Change subject: Make sitelink browsertests work on beta labs
..


Make sitelink browsertests work on beta labs

- the instances on beta labs provide limited content
  e.g. there are only a few wikipedias and those only have
  a limited number of articles. this needs to be taken into account
  when choosing testcases. an alternative would be to implement a
  better setup logic, e.g. create new articles on the beta wikipedias
  before running sitelinks tests.

Change-Id: If8eff8824456470253b7172c41e1b45585b396ed
---
M selenium_cuc/features/sitelinks.feature
M selenium_cuc/features/support/utils/utils.rb
2 files changed, 37 insertions(+), 37 deletions(-)

Approvals:
  Tobias Gritschacher: Verified; Looks good to me, approved



diff --git a/selenium_cuc/features/sitelinks.feature 
b/selenium_cuc/features/sitelinks.feature
index a495da86..d7339d3 100644
--- a/selenium_cuc/features/sitelinks.feature
+++ b/selenium_cuc/features/sitelinks.feature
@@ -105,10 +105,10 @@
   @save_sitelink @modify_entity
   Scenario Outline: Save sitelink
 Given The following sitelinks do not exist:
-  | enwiki | Africa |
+  | enwiki | Asia |
 When I click the sitelink add button
   And I type enwiki into the siteid input field
-  And I type Africa into the page input field
+  And I type Asia into the page input field
   And I 
 Then There should be 1 sitelinks in the list
 
@@ -120,10 +120,10 @@
   @save_sitelink @modify_entity
   Scenario Outline: Save sitelink & reload
 Given The following sitelinks do not exist:
-  | enwiki | Africa |
+  | enwiki | Asia |
 When I click the sitelink add button
   And I type enwiki into the siteid input field
-  And I type Africa into the page input field
+  And I type Asia into the page input field
   And I 
   And I reload the page
 Then There should be 1 sitelinks in the list
@@ -136,10 +136,10 @@
   @save_sitelink @modify_entity
   Scenario: Edit sitelink
 Given The following sitelinks do not exist:
-  | enwiki | Africa |
+  | enwiki | Asia |
   | enwiki | Europe |
 When I add the following sitelinks:
-  | enwiki | Africa |
+  | enwiki | Asia |
   And I reload the page
   And I click the sitelink edit button
   And I type Europe into the page input field
@@ -170,31 +170,31 @@
 
 Examples:
   | siteid | pagename | expected_language | normalized_pagename |
-  | enwiki | Africa   | English   | Africa  |
-  | srwiki | Helijum  | српски / srpski   | Хелијум |
+  | enwiki | Asia   | English   | Asia|
+  | sqwiki | wikipedia  | shqip | Wikipedia   |
 
   @save_sitelink @modify_entity
   Scenario: Add multiple sitelinks
 Given The following sitelinks do not exist:
   | enwiki | Europe |
-  | dewiki | Europa |
-  | itwiki | Europa |
+  | dewiki | Testseite |
+  | sqwiki | Wikipedia |
   When I add the following sitelinks:
 | enwiki | Europe |
-| dewiki | Europa |
-| itwiki | Europa |
+| dewiki | Testseite |
+| sqwiki | Wikipedia |
   Then There should be 3 sitelinks in the list
 
   @save_sitelink @modify_entity
   Scenario: Remove multiple sitelinks
 Given The following sitelinks do not exist:
   | enwiki | Europe |
-  | dewiki | Europa |
-  | itwiki | Europa |
+  | dewiki | Testseite |
+  | sqwiki | Wikipedia |
 When I add the following sitelinks:
   | enwiki | Europe |
-  | dewiki | Europa |
-  | itwiki | Europa |
+  | dewiki | Testseite |
+  | sqwiki | Wikipedia |
   And I remove all sitelinks
   And I reload the page
 Then There should be 0 sitelinks in the list
@@ -204,48 +204,48 @@
   @save_sitelink @modify_entity
   Scenario: Initial sorting of sitelinks
 Given The following sitelinks do not exist:
-  | enwiki | Rome |
-  | dewiki | Rom |
-  | itwiki | Roma |
-  | fiwiki | Rooma |
+  | enwiki | Rashidun |
+  | dewiki | Error |
+  | sqwiki | Wikipedia |
+  | simplewiki | Wiktionary |
 When I add the following sitelinks:
-  | enwiki | Rome |
-  | dewiki | Rom |
-  | itwiki | Roma |
-  | fiwiki | Rooma |
+  | enwiki | Rashidun |
+  | dewiki | Error |
+  | sqwiki | Wikipedia |
+  | simplewiki | Wiktionary |
 And I reload the page
 Then There should be 4 sitelinks in the list
  And Order of sitelinks should be:
-   | dewiki | enwiki | fiwiki | itwiki |
+   | dewiki | enwiki | simplewiki | sqwiki |
 
   @save_sitelink @modify_entity
   Scenario: Sorting sitelinks by languagename
 Given The following sitelinks do not exist:
-  | enwiki | Rome |
-  | dewiki | Rom |
-  | itwiki | Roma |
-  | fiwiki | Rooma |
+  | enwiki | Rashidun |
+   

[MediaWiki-commits] [Gerrit] Remove unused (and broken) labs config from squid manifest - change (operations/puppet)

2013-10-09 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88698


Change subject: Remove unused (and broken) labs config from squid manifest
..

Remove unused (and broken) labs config from squid manifest

Per , squid.pp is not
applied on labs -- which is what I'd expect, given that it references an
undefined function. So: clean it up.

Bug: 38524
Change-Id: I132fef92c4870e0f2a40fa3819f53cf8fcfb4d08
---
M manifests/squid.pp
1 file changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/88698/1

diff --git a/manifests/squid.pp b/manifests/squid.pp
index b5abcff..3c8ea07 100644
--- a/manifests/squid.pp
+++ b/manifests/squid.pp
@@ -7,18 +7,6 @@
# Fast C External redirect helper
require squid::redirector
 
-   if $realm == "labs" {
-   # Nova mounts /dev/vdb on /mnt by default. We want to use that 
device
-   # for coss usage.
-   mount { "/mnt":
-   name => '/mnt',
-   ensure => absent;
-   }
-
-   # FIXME: Hack for arrays in LDAP - you suck puppet
-   $squid_coss_disks = split(get_var('squid_coss_disks'), ',')
-   }
-
class packages {
package { ["squid", "squid-frontend"]:
ensure => latest;

-- 
To view, visit https://gerrit.wikimedia.org/r/88698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I132fef92c4870e0f2a40fa3819f53cf8fcfb4d08
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add Option to Enable Keyword Links - change (mediawiki...SyntaxHighlight_GeSHi)

2013-10-09 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Add Option to Enable Keyword Links
..


Add Option to Enable Keyword Links

Patch by Bryan Petty

Bug: 53787
Change-Id: I8c818859df8240cfcfef94d06d5d12a848cc76dc
---
M SyntaxHighlight_GeSHi.class.php
M SyntaxHighlight_GeSHi.php
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/SyntaxHighlight_GeSHi.class.php b/SyntaxHighlight_GeSHi.class.php
index 4538a5f..7318574 100644
--- a/SyntaxHighlight_GeSHi.class.php
+++ b/SyntaxHighlight_GeSHi.class.php
@@ -327,6 +327,9 @@
 * @return GeSHi
 */
public static function prepare( $text, $lang ) {
+
+   global $wgSyntaxHighlightKeywordLinks;
+
self::initialise();
$geshi = new GeSHi( $text, $lang );
if( $geshi->error() == GESHI_ERROR_NO_SUCH_LANG ) {
@@ -335,7 +338,7 @@
$geshi->set_encoding( 'UTF-8' );
$geshi->enable_classes();
$geshi->set_overall_class( "source-$lang" );
-   $geshi->enable_keyword_links( false );
+   $geshi->enable_keyword_links( $wgSyntaxHighlightKeywordLinks );
 
// If the source code is over 100 kB, disable higlighting of 
symbols.
// If over 200 kB, disable highlighting of strings too.
diff --git a/SyntaxHighlight_GeSHi.php b/SyntaxHighlight_GeSHi.php
index 0b6cb0c..5372342 100644
--- a/SyntaxHighlight_GeSHi.php
+++ b/SyntaxHighlight_GeSHi.php
@@ -48,7 +48,10 @@
'url'=> 
'https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi',
 );
 
-$wgSyntaxHighlightDefaultLang = null; //Change this in LocalSettings.php
+// Change these in LocalSettings.php
+$wgSyntaxHighlightDefaultLang = null;
+$wgSyntaxHighlightKeywordLinks = false;
+
 $dir = dirname(__FILE__) . '/';
 $wgExtensionMessagesFiles['SyntaxHighlight_GeSHi'] = $dir . 
'SyntaxHighlight_GeSHi.i18n.php';
 $wgAutoloadClasses['SyntaxHighlight_GeSHi'] = $dir . 
'SyntaxHighlight_GeSHi.class.php';

-- 
To view, visit https://gerrit.wikimedia.org/r/82854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c818859df8240cfcfef94d06d5d12a848cc76dc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Changed message 'Geographic coordinate' to 'Geographic coord... - change (mediawiki...DataTypes)

2013-10-09 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88697


Change subject: Changed message 'Geographic coordinate' to 'Geographic 
coordinates'
..

Changed message 'Geographic coordinate' to 'Geographic coordinates'

Change-Id: I664fa490b3b903fac2b79e2833eb3243729cbfd2
---
M DataTypes.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTypes 
refs/changes/97/88697/1

diff --git a/DataTypes.i18n.php b/DataTypes.i18n.php
index 4bc6182..2ab8591 100644
--- a/DataTypes.i18n.php
+++ b/DataTypes.i18n.php
@@ -28,7 +28,7 @@
'datatypes-type-mediawiki-title' => 'MediaWiki title',
'datatypes-type-unknown' => 'Unspecified',
'datatypes-type-boolean' => 'Boolean',
-   'datatypes-type-globe-coordinate' => 'Geographic coordinate',
+   'datatypes-type-globe-coordinate' => 'Geographic coordinates',
'datatypes-type-time' => 'Time',
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I664fa490b3b903fac2b79e2833eb3243729cbfd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTypes
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mod - 1. remove obsolete tests. \n2. Add some setup to exist... - change (sartoris)

2013-10-09 Thread Rfaulk (Code Review)
Rfaulk has submitted this change and it was merged.

Change subject: mod - 1. remove obsolete tests. \n2. Add some setup to existing 
tests.
..


mod - 1. remove obsolete tests. \n2. Add some setup to existing tests.

Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
---
M sartoris/tests/test.py
1 file changed, 3 insertions(+), 18 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved



diff --git a/sartoris/tests/test.py b/sartoris/tests/test.py
index da0a46e..3ce088f 100644
--- a/sartoris/tests/test.py
+++ b/sartoris/tests/test.py
@@ -48,13 +48,6 @@
 rmtree(config_local.TEST_REPO)
 
 
-class TestNullHandler(unittest.TestCase):
-def test_emit(self):
-# null_handler = NullHandler()
-# self.assertEqual(expected, null_handler.emit(record))
-assert False  # TODO: implement your test here
-
-
 class TestSartorisInit(unittest.TestCase):
 """ Test cases for Sartoris initialization and config """
 def test_conf_hook_dir(self):
@@ -98,6 +91,7 @@
 except SartorisError:
 assert False
 
+@setup_deco
 def test_diff(self):
 """
 diff - test to ensure that ``diff`` method functions
@@ -109,6 +103,7 @@
 except SartorisError:
 assert False
 
+@setup_deco
 def test_log_deploys(self):
 """
 log_deploys - test to ensure that ``log_deploys`` method functions
@@ -120,17 +115,7 @@
 except SartorisError:
 assert False
 
-def test_resync(self):
-"""
-resync - test to ensure that ``resync`` method functions
-without exception
-"""
-sartoris_obj = Sartoris()
-try:
-sartoris_obj.resync(None)
-except SartorisError:
-assert False
-
+@setup_deco
 def test_revert(self):
 """
 revert - test to ensure that ``revert`` method functions

-- 
To view, visit https://gerrit.wikimedia.org/r/88696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk 
Gerrit-Reviewer: Rfaulk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mod - 1. remove obsolete tests. \n2. Add some setup to exist... - change (sartoris)

2013-10-09 Thread Rfaulk (Code Review)
Rfaulk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88696


Change subject: mod - 1. remove obsolete tests. \n2. Add some setup to existing 
tests.
..

mod - 1. remove obsolete tests. \n2. Add some setup to existing tests.

Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
---
M sartoris/tests/test.py
1 file changed, 3 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/96/88696/1

diff --git a/sartoris/tests/test.py b/sartoris/tests/test.py
index da0a46e..3ce088f 100644
--- a/sartoris/tests/test.py
+++ b/sartoris/tests/test.py
@@ -48,13 +48,6 @@
 rmtree(config_local.TEST_REPO)
 
 
-class TestNullHandler(unittest.TestCase):
-def test_emit(self):
-# null_handler = NullHandler()
-# self.assertEqual(expected, null_handler.emit(record))
-assert False  # TODO: implement your test here
-
-
 class TestSartorisInit(unittest.TestCase):
 """ Test cases for Sartoris initialization and config """
 def test_conf_hook_dir(self):
@@ -98,6 +91,7 @@
 except SartorisError:
 assert False
 
+@setup_deco
 def test_diff(self):
 """
 diff - test to ensure that ``diff`` method functions
@@ -109,6 +103,7 @@
 except SartorisError:
 assert False
 
+@setup_deco
 def test_log_deploys(self):
 """
 log_deploys - test to ensure that ``log_deploys`` method functions
@@ -120,17 +115,7 @@
 except SartorisError:
 assert False
 
-def test_resync(self):
-"""
-resync - test to ensure that ``resync`` method functions
-without exception
-"""
-sartoris_obj = Sartoris()
-try:
-sartoris_obj.resync(None)
-except SartorisError:
-assert False
-
+@setup_deco
 def test_revert(self):
 """
 revert - test to ensure that ``revert`` method functions

-- 
To view, visit https://gerrit.wikimedia.org/r/88696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix up amssq node expr (caught non squid hosts) - change (operations/puppet)

2013-10-09 Thread ArielGlenn (Code Review)
ArielGlenn has submitted this change and it was merged.

Change subject: fix up amssq node expr (caught non squid hosts)
..


fix up amssq node expr (caught non squid hosts)

Change-Id: I7328612e33ba0e232faceea79c0f664787ae02ab
---
M manifests/site.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  ArielGlenn: Verified; Looks good to me, approved



diff --git a/manifests/site.pp b/manifests/site.pp
index f117f94..1be6a7b 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -116,7 +116,7 @@
 }
 
 # amssq47-62 are text varnish
-node /amssq4[7-9]|5[0-9]|6[0-2]\.esams\.wikimedia\.org$/ {
+node /amssq(4[7-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
 include role::cache::text
 
 interface::add_ip6_mapped { "main": }

-- 
To view, visit https://gerrit.wikimedia.org/r/88695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7328612e33ba0e232faceea79c0f664787ae02ab
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: ArielGlenn 
Gerrit-Reviewer: ArielGlenn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix up amssq node expr (caught non squid hosts) - change (operations/puppet)

2013-10-09 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88695


Change subject: fix up amssq node expr (caught non squid hosts)
..

fix up amssq node expr (caught non squid hosts)

Change-Id: I7328612e33ba0e232faceea79c0f664787ae02ab
---
M manifests/site.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/88695/1

diff --git a/manifests/site.pp b/manifests/site.pp
index f117f94..1be6a7b 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -116,7 +116,7 @@
 }
 
 # amssq47-62 are text varnish
-node /amssq4[7-9]|5[0-9]|6[0-2]\.esams\.wikimedia\.org$/ {
+node /amssq(4[7-9]|5[0-9]|6[0-2])\.esams\.wikimedia\.org$/ {
 include role::cache::text
 
 interface::add_ip6_mapped { "main": }

-- 
To view, visit https://gerrit.wikimedia.org/r/88695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7328612e33ba0e232faceea79c0f664787ae02ab
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: ArielGlenn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Various user rights config changes on Wikidata - change (operations/mediawiki-config)

2013-10-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88694


Change subject: Various user rights config changes on Wikidata
..

Various user rights config changes on Wikidata

Bug: 55495

'autopatrolled' should include 'confirmed'
'rollbacker' should include 'autopatrolled'
'propertycreator' should include 'autopatrolled'

Change-Id: If0320af3fe46151726b51b5273f8654a49293830
---
M wmf-config/InitialiseSettings.php
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/94/88694/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index ff5f11e..daa8787 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -8063,6 +8063,15 @@
'bureaucrat' => array(
'flood', // bug 48013
),
+   'rollbacker' => array(
+   'autopatrolled', // bug 55495
+   ),
+   'propertycreator' => array(
+   'autopatrolled', // bug 55495
+   ),
+   'autopatrolled' => array(
+   'confirmed', // bug 55495
+   ),
),
'+zhwiki' => array(
'bureaucrat' => array( 'flood' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/88694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0320af3fe46151726b51b5273f8654a49293830
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Stash: load in correct language and minor refactoring - change (mediawiki...Translate)

2013-10-09 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88693


Change subject: Stash: load in correct language and minor refactoring
..

Stash: load in correct language and minor refactoring

Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
---
M resources/js/ext.translate.special.translationstash.js
1 file changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/93/88693/1

diff --git a/resources/js/ext.translate.special.translationstash.js 
b/resources/js/ext.translate.special.translationstash.js
index 7327fda..46030f6 100644
--- a/resources/js/ext.translate.special.translationstash.js
+++ b/resources/js/ext.translate.special.translationstash.js
@@ -19,8 +19,10 @@
mclanguage: language,
mcoffset: offset,
mclimit: limit,
-   mcprop: 'definition|translation|tags|properties'
+   mcprop: 'definition|properties'
} );
+
+   // @todo: We need to get translations from the stash api
}
 
function addMessage( message ) {
@@ -92,7 +94,7 @@
var $messageTable = $( '.tux-messagelist' ),
messagegroup = '!sandbox';
 
-   getMessages( messagegroup, $messageTable.data( 'targetLang' ), 
0, 5 )
+   getMessages( messagegroup, $messageTable.data( 'targetlangcode' 
), 0, 20 )
.done( function ( result ) {
var messages = result.query.messagecollection;
$.each( messages, function ( index, message ) {
@@ -110,18 +112,28 @@
}
 
$( 'document' ).ready( function () {
-   var $messageTable = $( '.tux-messagelist' );
+   var $messageTable = $( '.tux-messagelist' ),
+   $ulsTrigger = $( '.ext-translate-language-selector > 
.uls' );
 
-   $( '.ext-translate-language-selector .uls' ).uls( {
+   $ulsTrigger.uls( {
onSelect: function ( language ) {
-   $( '.ext-translate-language-selector > .uls' )
-   .text( $.uls.data.getAutonym( language 
) )
+   var direction = $.uls.data.getDir( language ),
+   autonym = $.uls.data.getAutonym( 
language );
+
+   $ulsTrigger
+   .text( autonym )
.attr( {
lang: language,
-   dir: $.uls.data.getDir( 
language )
+   dir: direction
} );
-   $messageTable.empty();
-   $messageTable.data( 'targetLang', language );
+
+   $messageTable
+   .empty()
+   .data( {
+   targetlangcode: language,
+   targetlangdir: direction
+   } );
+
loadMessages();
}
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/88693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Navigation Timing: differentiate by auth status rather than ... - change (operations/puppet)

2013-10-09 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88692


Change subject: Navigation Timing: differentiate by auth status rather than wiki
..

Navigation Timing: differentiate by auth status rather than wiki

The per-wiki metrics haven't been especially insightful; we have too many wikis
and the performance differences between them are relatively minor when simple
page views are concerned. It'd be more interesting to compare the experience of
logged-in users with anonymous visitors. So log that instead.

Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
---
M files/graphite/modules/navtiming.py
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/88692/1

diff --git a/files/graphite/modules/navtiming.py 
b/files/graphite/modules/navtiming.py
index 7770178..e47d0ec 100644
--- a/files/graphite/modules/navtiming.py
+++ b/files/graphite/modules/navtiming.py
@@ -58,16 +58,13 @@
 event['pageSpeed'] = (
 event['loadEventEnd'] - event['domInteractive'])
 
-wiki = meta['wiki']
-if not event.get('isAnon'):
-continue
-
 site = 'mobile' if 'mobileMode' in event else 'desktop'
+auth = 'anonymous' if event.get('isAnon') else 'authenticated'
 
 for metric in metrics:
 value = event.get(metric, 0)
 if value > 0 and value < 6:
 stat = 'browser.%s.%s:%s|ms' % (metric, site, value)
 sock.sendto(stat.encode('utf-8'), addr)
-stat = 'browser.%s.%s.%s:%s|ms' % (metric, wiki, site, value)
+stat = 'browser.%s.%s.%s:%s|ms' % (metric, site, auth, value)
 sock.sendto(stat.encode('utf-8'), addr)

-- 
To view, visit https://gerrit.wikimedia.org/r/88692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I71ae3a6879e048837ad5f87c0cf985c0f0b9a7e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add option 'skipgroup' to manageMessageChanges.php - change (mediawiki...Translate)

2013-10-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Add option 'skipgroup' to manageMessageChanges.php
..


Add option 'skipgroup' to manageMessageChanges.php

Plan to use this in update-externals in the translatewiki repo, to exclude
ext- from being processed. This should make the command run about twice as
quickly, because there are no expected changes in ext-*.

Change-Id: Ibb1f38ead8377bd31a2b4521c9e0e5f90bb038da
---
M scripts/processMessageChanges.php
1 file changed, 46 insertions(+), 33 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/processMessageChanges.php 
b/scripts/processMessageChanges.php
index 1718e92..4b8feac 100644
--- a/scripts/processMessageChanges.php
+++ b/scripts/processMessageChanges.php
@@ -40,22 +40,22 @@
$this->mDescription = 'Script for processing message changes in 
file based message groups';
$this->addOption(
'group',
-   'Comma separated list of group IDs (can use * as 
wildcard)',
+   'Comma separated list of group IDs to process (can use 
* as wildcard). ' .
+   'Default: "*"',
+   false, /*required*/
+   true /*has arg*/
+   );
+   $this->addOption(
+   'skipgroup',
+   'Comma separated list of group IDs to not process (can 
use * as wildcard). ' .
+   'Overrides --group parameter. Default: "*"',
false, /*required*/
true /*has arg*/
);
}
 
public function execute() {
-   /**
-* @var $groups MessageGroupBase[]
-*/
-   $groups = MessageGroups::getGroupsByType( 
'FileBasedMessageGroup' );
-   $whitelist = $this->getOption( 'group' );
-
-   if ( $whitelist ) {
-   $groups = $this->filterGroups( $groups, $whitelist );
-   }
+   $groups = $this->getGroups();
 
$this->counter = 0;
/** @var FileBasedMessageGroup $group */
@@ -74,6 +74,42 @@
$this->output( "No changes found\n" );
}
}
+
+   /**
+* Gets list of message groups filtered by user input.
+* @return MessageGroup[]
+*/
+   protected function getGroups() {
+   /// @var $groups MessageGroup[]
+   $groups = MessageGroups::getGroupsByType( 
'FileBasedMessageGroup' );
+
+   // Include all if option not given
+   $include = $this->getOption( 'group', '*' );
+   $include = explode( ',', $include );
+   $include = array_map( 'trim', $include );
+   $include = MessageGroups::expandWildcards( $include );
+
+   // Exclude nothing if option not given
+   $exclude = $this->getOption( 'skipgroup', '' );
+   $exclude = explode( ',', $exclude );
+   $exclude = array_map( 'trim', $exclude );
+   $exclude = MessageGroups::expandWildcards( $exclude );
+
+   // Flip to allow isset
+   $include = array_flip( $include );
+   $exclude = array_flip( $exclude );
+
+   $groups = array_filter( $groups,
+   function ( MessageGroup $group ) use ( $include, 
$exclude ) {
+   $id = $group->getId();
+   return isset( $include[$id] ) && !isset( 
$exclude[$id] );
+   }
+   );
+
+   return $groups;
+   }
+
+
 
protected function writeChanges() {
// This method is almost identical with MessageIndex::store
@@ -253,29 +289,6 @@
 */
protected static function compareContent( $a, $b ) {
return $a === $b;
-   }
-
-   /**
-* Filters groups.
-*
-* @since 2012-10-15
-* @param MessageGroupBase[] $groups
-* @param string $whitelist Comma separated list of group IDs that 
should be processed (can
-* use * as wildcard)
-* @return array of filtered groups
-*/
-   protected function filterGroups( $groups, $whitelist ) {
-   $whitelist = explode( ',', trim( $whitelist ) );
-   $whitelist = MessageGroups::expandWildcards( $whitelist );
-
-   $filtered = array();
-   foreach ( $whitelist as $id ) {
-   if ( isset( $groups[$id] ) ) {
-   $filtered[$id] = $groups[$id];
-   }
-   }
-
-   return $filtered;
}
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/87712
To unsubscribe, 

[MediaWiki-commits] [Gerrit] repool db1022 in S6. move db1039 to assist with upgrades in ... - change (operations/mediawiki-config)

2013-10-09 Thread Springle (Code Review)
Springle has submitted this change and it was merged.

Change subject: repool db1022 in S6. move db1039 to assist with upgrades in S7. 
depool db1007 for upgrade
..


repool db1022 in S6. move db1039 to assist with upgrades in S7. depool db1007 
for upgrade

Change-Id: Ie7aad70ae9a1165b85d1a36b5ece3227c5b676fc
---
M wmf-config/db-eqiad.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Springle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index a4a38b8..3442dba 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -123,17 +123,17 @@
),
's6' => array(
'db1006'   => 0,
-   #'db1022'   => 100, # snapshot
+   'db1022'   => 100, # snapshot
'db1027'   => 400,
'db1040'   => 400,
'db1015'   => 400,
-   'db1039'   => 100,
),
's7' => array(
'db1041' => 0,
-   'db1007' => 100, # snapshot
+   #'db1007' => 100, # snapshot
'db1024' => 400,
'db1028' => 400,
+   #'db1039'   => 100,
),
 ),
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7aad70ae9a1165b85d1a36b5ece3227c5b676fc
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Springle 
Gerrit-Reviewer: Springle 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] repool db1022 in S6. move db1039 to assist with upgrades in ... - change (operations/mediawiki-config)

2013-10-09 Thread Springle (Code Review)
Springle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88691


Change subject: repool db1022 in S6. move db1039 to assist with upgrades in S7. 
depool db1007 for upgrade
..

repool db1022 in S6. move db1039 to assist with upgrades in S7. depool db1007 
for upgrade

Change-Id: Ie7aad70ae9a1165b85d1a36b5ece3227c5b676fc
---
M wmf-config/db-eqiad.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/91/88691/1

diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index a4a38b8..3442dba 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -123,17 +123,17 @@
),
's6' => array(
'db1006'   => 0,
-   #'db1022'   => 100, # snapshot
+   'db1022'   => 100, # snapshot
'db1027'   => 400,
'db1040'   => 400,
'db1015'   => 400,
-   'db1039'   => 100,
),
's7' => array(
'db1041' => 0,
-   'db1007' => 100, # snapshot
+   #'db1007' => 100, # snapshot
'db1024' => 400,
'db1028' => 400,
+   #'db1039'   => 100,
),
 ),
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7aad70ae9a1165b85d1a36b5ece3227c5b676fc
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Springle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


<    1   2   3