[MediaWiki-commits] [Gerrit] WIP New test for Visual Editor Page Settings (aka Tools) menu - change (mediawiki...VisualEditor)
Jhall has uploaded a new change for review. https://gerrit.wikimedia.org/r/97144 Change subject: WIP New test for Visual Editor Page Settings (aka Tools) menu .. WIP New test for Visual Editor Page Settings (aka Tools) menu Change-Id: Ia30e0e12e01d765443818dd516e0e4ea8fda0b5c --- A modules/ve-mw/test/browser/features/step_definitions/tools_steps.rb M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb A modules/ve-mw/test/browser/features/tools.feature 3 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/44/97144/1 diff --git a/modules/ve-mw/test/browser/features/step_definitions/tools_steps.rb b/modules/ve-mw/test/browser/features/step_definitions/tools_steps.rb new file mode 100644 index 000..c257bc6 --- /dev/null +++ b/modules/ve-mw/test/browser/features/step_definitions/tools_steps.rb @@ -0,0 +1,22 @@ +When(/^I click the Page settings menu option$/) do + on(VisualEditorPage) do |page| +page.tools_menu_element.when_present.click +page.tools_page_settings_element.when_present.click + end +end + +And(/^I enter a (.+) category label$/) do |content| + on(VisualEditorPage).add_category_element.when_present.send_keys(content) +end + +When(/^I enter a (.+) sort option label$/) do |content| + on(VisualEditorPage).add_category_sort_element.when_present.send_keys(content) +end + +When(/^I click to confirm the new category$/) do + on(VisualEditorPage).confirm_category_element.when_present.click +end + +When(/^I click the Apply Changes button$/) do + on(VisualEditorPage).apply_changes_element.when_present.click +end \ No newline at end of file diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index e12749c..cd10359 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -31,6 +31,8 @@ span(:subheading2, text: 'Sub-heading 2') span(:subheading3, text: 'Sub-heading 3') span(:subheading4, text: 'Sub-heading 4') + span(:tools_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-menu') + span(:tools_page_settings, class: 'oo-ui-iconedElement-icon oo-ui-icon-settings') span(:ve_bullets, class: 'oo-ui-iconedElement-icon oo-ui-icon-bullet-list') span(:ve_computer_code, class: 'oo-ui-iconedElement-icon oo-ui-icon-code') div(:ve_heading_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-down') @@ -66,9 +68,12 @@ end in_frame(:index = 2) do |frame| +text_field(:add_category, placeholder: 'Add a category', frame: frame) span(:add_parameter, class: 've-ui-mwParameterResultWidget-name', frame: frame) +div(:add_category_sort, class: 'oo-ui-widget oo-ui-inputWidget oo-ui-textInputWidget', frame: frame) span(:add_template, text: 'Add template', frame: frame) span(:apply_changes, text: 'Apply changes', frame: frame) +div(:confirm_category, class: 'oo-ui-optionWidget-icon oo-ui-icon-check', frame: frame) div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame: frame) span(:insert_reference, text: 'Insert reference', frame: frame) text_field(:parameter_box, index: 0, frame: frame) diff --git a/modules/ve-mw/test/browser/features/tools.feature b/modules/ve-mw/test/browser/features/tools.feature new file mode 100644 index 000..6b5f1fa --- /dev/null +++ b/modules/ve-mw/test/browser/features/tools.feature @@ -0,0 +1,27 @@ +@ie6-bug @ie7-bug @ie8-bug @ie9-bug @ie10-bug @en.wikipedia.beta.wmflabs.org @test2.wikipedia.org @login +Feature: VisualEditor Page Settings (aka Tools) menu + + Background: +Given I am logged in +And I am at my user page +When I click Edit for VisualEditor +And I click the Page settings menu option + + Scenario: VisualEditor create new category +And I enter a Test category label +And I click to confirm the new category +And I click the Apply Changes button +And I click Save page +And I click Review your changes +Then [[Category:Test]] should appear in the diff view +And I can click the X on the save box + + Scenario: VisualEditor create new category with sort +And I enter a Sorted Test category label +And I click to confirm the new category +And I enter a New Sort sort option label +And I click the Apply Changes button +And I click Save page +And I click Review your changes +Then [[Category:Sorted Test]] should appear in the diff view +And I can click the X on the save box -- To view, visit https://gerrit.wikimedia.org/r/97144 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia30e0e12e01d765443818dd516e0e4ea8fda0b5c Gerrit-PatchSet: 1 Gerrit-Project:
[MediaWiki-commits] [Gerrit] Offer up wmflabs.org as default domain for new proxies. - change (mediawiki...OpenStackManager)
jenkins-bot has submitted this change and it was merged. Change subject: Offer up wmflabs.org as default domain for new proxies. .. Offer up wmflabs.org as default domain for new proxies. Change-Id: If298f2d10afb02f9573f70ebf46c7c942fd32824 --- M special/SpecialNovaProxy.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Andrew Bogott: Looks good to me, approved jenkins-bot: Verified diff --git a/special/SpecialNovaProxy.php b/special/SpecialNovaProxy.php index 9016368..88f57d0 100644 --- a/special/SpecialNovaProxy.php +++ b/special/SpecialNovaProxy.php @@ -107,6 +107,7 @@ 'label-message' = 'openstackmanager-dnsdomain', 'section' = 'frontend', 'name' = 'domain', + 'default' = 'wmflabs' ); $proxyInfo['backendhost'] = array( 'type' = 'select', -- To view, visit https://gerrit.wikimedia.org/r/97140 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If298f2d10afb02f9573f70ebf46c7c942fd32824 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/OpenStackManager Gerrit-Branch: master Gerrit-Owner: Andrew Bogott abog...@wikimedia.org Gerrit-Reviewer: Andrew Bogott abog...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Avoid fatals in Special:History - change (mediawiki...MobileFrontend)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/97145 Change subject: Avoid fatals in Special:History .. Avoid fatals in Special:History Bug: 57392 Change-Id: Ia0a612af3ff51c905eda8d9dbcbbefa10ee09fa6 --- M includes/specials/SpecialHistory.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/45/97145/1 diff --git a/includes/specials/SpecialHistory.php b/includes/specials/SpecialHistory.php index 795f53c..ee09e12 100644 --- a/includes/specials/SpecialHistory.php +++ b/includes/specials/SpecialHistory.php @@ -33,6 +33,8 @@ } else { wfHttpError( 404, $this-msg( 'mobile-frontend-history-404-title' )-text(), $this-msg( 'mobile-frontend-history-404-desc' )-text() ); + // Stop the query from running + return; } } $res = $this-doQuery(); -- To view, visit https://gerrit.wikimedia.org/r/97145 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0a612af3ff51c905eda8d9dbcbbefa10ee09fa6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update PagedTiffHandler to master for I52fe2ec25 - change (mediawiki/core)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/97147 Change subject: Update PagedTiffHandler to master for I52fe2ec25 .. Update PagedTiffHandler to master for I52fe2ec25 Change-Id: I46a7bc520b635895ecf37741611df5124e6e875e --- M extensions/PagedTiffHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/47/97147/1 diff --git a/extensions/PagedTiffHandler b/extensions/PagedTiffHandler index 65dd904..cbb473b 16 --- a/extensions/PagedTiffHandler +++ b/extensions/PagedTiffHandler -Subproject commit 65dd9041883ec4cfffb4ff6cf5c835eec6871e7d +Subproject commit cbb473bc2278173606d41a5949ef6056d49669ad -- To view, visit https://gerrit.wikimedia.org/r/97147 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46a7bc520b635895ecf37741611df5124e6e875e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Ori.livneh o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] No format for lists - change (wiktionary/anagrimes)
Darkdadaah has uploaded a new change for review. https://gerrit.wikimedia.org/r/97146 Change subject: No format for lists .. No format for lists We don't need to add links when writing lists, the formate.pl script does the job. Change-Id: I97a6c159e26d0be6d192fa6eeb9ebdd4f1a7bfa4 --- M scripts/articles_list.pl 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wiktionary/anagrimes refs/changes/46/97146/1 diff --git a/scripts/articles_list.pl b/scripts/articles_list.pl index a4376b5..fb2aba0 100755 --- a/scripts/articles_list.pl +++ b/scripts/articles_list.pl @@ -286,7 +286,7 @@ $ok_pattern =~ s/\n/\\n/g; $ok_pattern =~ s/\r/\\r/g; open(ARTICLES, $p{'output_path'}) or die Couldn't write $p{'output_path'}: $!\n; - my @line = ([[$article-{'fulltitle'}]]); + my @line = ($article-{'fulltitle'}); push @line, $ok_pattern; print ARTICLES join(\t, @line) . \n; close(ARTICLES); @@ -297,7 +297,7 @@ $no_pattern =~ s/\r/\\r/g; open(ARTICLES, $p{'output_rejected_path'}) or die Couldn't write $p{'output_rejected_path'}: $!\n; - my @line = ([[$article-{'fulltitle'}]]); + my @line = ($article-{'fulltitle'}); push @line, $ok_pattern; push @line, $no_pattern; print ARTICLES join(\t, @line) . \n; @@ -312,7 +312,7 @@ if ($p{'output_path'}) { open(ARTICLES, $p{'output_path'}) or die Couldn't write $p{'output_path'}: $!\n; - my @line = ([[$article-{'fulltitle'}]]); + my @line = ($article-{'fulltitle'}); print ARTICLES join(\t, @line) . \n; close(ARTICLES); } @@ -348,6 +348,5 @@ # Get data from dump my $art_count = get_articles_list(\%par); -close(DUMP); __END__ -- To view, visit https://gerrit.wikimedia.org/r/97146 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I97a6c159e26d0be6d192fa6eeb9ebdd4f1a7bfa4 Gerrit-PatchSet: 1 Gerrit-Project: wiktionary/anagrimes Gerrit-Branch: master Gerrit-Owner: Darkdadaah darkdad...@yahoo.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update PagedTiffHandler to master for I52fe2ec25 - change (mediawiki/core)
Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/97148 Change subject: Update PagedTiffHandler to master for I52fe2ec25 .. Update PagedTiffHandler to master for I52fe2ec25 Change-Id: I8e8827b1ec875e06daa667e9a3ab81ad8bd3ef57 --- M extensions/PagedTiffHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/48/97148/1 diff --git a/extensions/PagedTiffHandler b/extensions/PagedTiffHandler index 65dd904..cbb473b 16 --- a/extensions/PagedTiffHandler +++ b/extensions/PagedTiffHandler -Subproject commit 65dd9041883ec4cfffb4ff6cf5c835eec6871e7d +Subproject commit cbb473bc2278173606d41a5949ef6056d49669ad -- To view, visit https://gerrit.wikimedia.org/r/97148 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e8827b1ec875e06daa667e9a3ab81ad8bd3ef57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Ori.livneh o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update PagedTiffHandler to master for I52fe2ec25 - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update PagedTiffHandler to master for I52fe2ec25 .. Update PagedTiffHandler to master for I52fe2ec25 Change-Id: I46a7bc520b635895ecf37741611df5124e6e875e --- M extensions/PagedTiffHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/extensions/PagedTiffHandler b/extensions/PagedTiffHandler index 65dd904..cbb473b 16 --- a/extensions/PagedTiffHandler +++ b/extensions/PagedTiffHandler -Subproject commit 65dd9041883ec4cfffb4ff6cf5c835eec6871e7d +Subproject commit cbb473bc2278173606d41a5949ef6056d49669ad -- To view, visit https://gerrit.wikimedia.org/r/97147 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46a7bc520b635895ecf37741611df5124e6e875e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update PagedTiffHandler to master for I52fe2ec25 - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update PagedTiffHandler to master for I52fe2ec25 .. Update PagedTiffHandler to master for I52fe2ec25 Change-Id: I8e8827b1ec875e06daa667e9a3ab81ad8bd3ef57 --- M extensions/PagedTiffHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/extensions/PagedTiffHandler b/extensions/PagedTiffHandler index 65dd904..cbb473b 16 --- a/extensions/PagedTiffHandler +++ b/extensions/PagedTiffHandler -Subproject commit 65dd9041883ec4cfffb4ff6cf5c835eec6871e7d +Subproject commit cbb473bc2278173606d41a5949ef6056d49669ad -- To view, visit https://gerrit.wikimedia.org/r/97148 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e8827b1ec875e06daa667e9a3ab81ad8bd3ef57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing use statement in client hooks - change (mediawiki...Wikibase)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/97149 Change subject: Add missing use statement in client hooks .. Add missing use statement in client hooks Bug: 57461 Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/49/97149/1 diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index 6ee65e2..f47cb8e 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -24,8 +24,9 @@ use StripState; use Title; use User; -use Wikibase\Client\WikibaseClient; +use Wikibase\Client\Hooks\InfoActionHookHandler; use Wikibase\Client\MovePageNotice; +use Wikibase\Client\WikibaseClient; use Wikibase\DataModel\SimpleSiteLink; /** -- To view, visit https://gerrit.wikimedia.org/r/97149 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix fatal - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: Fix fatal .. Fix fatal PHP Fatal error: Call to a member function getLocalUrl() on a non-object in /usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php on line 94 Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 --- M includes/specials/SpecialHistory.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialHistory.php b/includes/specials/SpecialHistory.php index 795f53c..d22fe0b 100644 --- a/includes/specials/SpecialHistory.php +++ b/includes/specials/SpecialHistory.php @@ -93,7 +93,7 @@ $canSeeText = $rev-userCan( Revision::DELETED_TEXT, $user ); if ( $canSeeText $prev $prev-userCan( Revision::DELETED_TEXT, $user ) ) { $diffLink = SpecialPage::getTitleFor( 'MobileDiff', $prev-getId() )-getLocalUrl(); - } elseif ( $canSeeText ) { + } elseif ( $canSeeText $rev-getTitle() !== null ) { $diffLink = $rev-getTitle()-getLocalUrl( array( 'oldid' = $rev-getId() ) ); } else { $diffLink = false; -- To view, visit https://gerrit.wikimedia.org/r/97133 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cache Hide Requests - change (mediawiki...CentralNotice)
jenkins-bot has submitted this change and it was merged. Change subject: Cache Hide Requests .. Cache Hide Requests Change-Id: If6279142ad768959e1d05f4c67941a6f148d68ec (cherry picked from commit 6cea54b182d53459988dd8ed2bb57bd40401bc73) --- M special/SpecialHideBanners.php 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mwalker: Looks good to me, approved jenkins-bot: Verified diff --git a/special/SpecialHideBanners.php b/special/SpecialHideBanners.php index f947876..18e983e 100644 --- a/special/SpecialHideBanners.php +++ b/special/SpecialHideBanners.php @@ -6,6 +6,9 @@ * see fundrasing banners. */ class SpecialHideBanners extends UnlistedSpecialPage { + // Cache this blank response for a day or so (60 * 60 * 24 s.) + const CACHE_EXPIRY = 86400; + function __construct() { parent::__construct( 'HideBanners' ); } @@ -22,7 +25,10 @@ wfResetOutputBuffers(); header( 'Content-Type: image/png' ); - header( 'Cache-Control: no-cache' ); + if ( !$this-getUser()-isLoggedIn() ) { + $expiry = SpecialHideBanners::CACHE_EXPIRY; + header( Cache-Control: public, s-maxage={$expiry}, max-age=0 ); + } } /** -- To view, visit https://gerrit.wikimedia.org/r/97150 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6279142ad768959e1d05f4c67941a6f148d68ec Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not mobilify hide links - change (mediawiki...CentralNotice)
jenkins-bot has submitted this change and it was merged. Change subject: Do not mobilify hide links .. Do not mobilify hide links This is actually not required; I proved to myself that *.*.domain gets *.domain cookies. Change-Id: Ib881222056808fed498d5c9bc17c9c33f768fd2a (cherry picked from commit 7c8263972bb083c48b16e2d334ca5697eb6167a4) --- M CentralNotice.hooks.php 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Mwalker: Looks good to me, approved jenkins-bot: Verified diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php index 7722bff..66ccbbd 100644 --- a/CentralNotice.hooks.php +++ b/CentralNotice.hooks.php @@ -309,12 +309,6 @@ $wgCentralBannerDispatcher = $mc-getMobileUrl( $wgCentralBannerDispatcher ); $wgCentralBannerRecorder = $mc-getMobileUrl( $wgCentralBannerRecorder ); } - - $mobileHides = array(); - foreach( $wgNoticeHideUrls as $url ) { - $mobileHides[] = $mc-getMobileUrl( $url ); - } - $wgNoticeHideUrls = array_merge( $wgNoticeHideUrls, $mobileHides ); } $vars[ 'wgNoticeFundraisingUrl' ] = $wgNoticeFundraisingUrl; -- To view, visit https://gerrit.wikimedia.org/r/97151 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib881222056808fed498d5c9bc17c9c33f768fd2a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix fatal - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: Fix fatal .. Fix fatal PHP Fatal error: Call to a member function getLocalUrl() on a non-object in /usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php on line 94 Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 (cherry picked from commit 160013d74367a4f7c3407986493008f437b64211) --- M includes/specials/SpecialHistory.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Awjrichards: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialHistory.php b/includes/specials/SpecialHistory.php index 7fc0224..6b63ab1 100644 --- a/includes/specials/SpecialHistory.php +++ b/includes/specials/SpecialHistory.php @@ -90,7 +90,7 @@ $canSeeText = $rev-userCan( Revision::DELETED_TEXT, $user ); if ( $canSeeText $prev $prev-userCan( Revision::DELETED_TEXT, $user ) ) { $diffLink = SpecialPage::getTitleFor( 'MobileDiff', $prev-getId() )-getLocalUrl(); - } elseif ( $canSeeText ) { + } elseif ( $canSeeText $rev-getTitle() !== null ) { $diffLink = $rev-getTitle()-getLocalUrl( array( 'oldid' = $rev-getId() ) ); } else { $diffLink = false; -- To view, visit https://gerrit.wikimedia.org/r/97152 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: wmf4 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Awjrichards aricha...@wikimedia.org Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix fatal - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: Fix fatal .. Fix fatal PHP Fatal error: Call to a member function getLocalUrl() on a non-object in /usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php on line 94 Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 (cherry picked from commit 160013d74367a4f7c3407986493008f437b64211) --- M includes/specials/SpecialHistory.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Awjrichards: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialHistory.php b/includes/specials/SpecialHistory.php index 795f53c..d22fe0b 100644 --- a/includes/specials/SpecialHistory.php +++ b/includes/specials/SpecialHistory.php @@ -93,7 +93,7 @@ $canSeeText = $rev-userCan( Revision::DELETED_TEXT, $user ); if ( $canSeeText $prev $prev-userCan( Revision::DELETED_TEXT, $user ) ) { $diffLink = SpecialPage::getTitleFor( 'MobileDiff', $prev-getId() )-getLocalUrl(); - } elseif ( $canSeeText ) { + } elseif ( $canSeeText $rev-getTitle() !== null ) { $diffLink = $rev-getTitle()-getLocalUrl( array( 'oldid' = $rev-getId() ) ); } else { $diffLink = false; -- To view, visit https://gerrit.wikimedia.org/r/97153 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: wmf5 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Awjrichards aricha...@wikimedia.org Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97154 Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: I72dade4473dcfa5e364b691ad47e433232dd7e72 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/54/97154/1 diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 25173d6..160013d 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 25173d637de5a8b288d89e77bb6aef1e0fa700d5 +Subproject commit 160013d74367a4f7c3407986493008f437b64211 -- To view, visit https://gerrit.wikimedia.org/r/97154 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72dade4473dcfa5e364b691ad47e433232dd7e72 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing use statement in client hooks - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Add missing use statement in client hooks .. Add missing use statement in client hooks Bug: 57461 Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index 6ee65e2..f47cb8e 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -24,8 +24,9 @@ use StripState; use Title; use User; -use Wikibase\Client\WikibaseClient; +use Wikibase\Client\Hooks\InfoActionHookHandler; use Wikibase\Client\MovePageNotice; +use Wikibase\Client\WikibaseClient; use Wikibase\DataModel\SimpleSiteLink; /** -- To view, visit https://gerrit.wikimedia.org/r/97149 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97155 Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: I138aa26d212195f61ecdbcb3954c57204a7b411b --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/55/97155/1 diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index c009df3..160013d 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit c009df30952ae37785032d7b3fbf150dd157a7e2 +Subproject commit 160013d74367a4f7c3407986493008f437b64211 -- To view, visit https://gerrit.wikimedia.org/r/97155 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I138aa26d212195f61ecdbcb3954c57204a7b411b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core)
Reedy has submitted this change and it was merged. Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: I72dade4473dcfa5e364b691ad47e433232dd7e72 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 25173d6..160013d 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 25173d637de5a8b288d89e77bb6aef1e0fa700d5 +Subproject commit 160013d74367a4f7c3407986493008f437b64211 -- To view, visit https://gerrit.wikimedia.org/r/97154 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72dade4473dcfa5e364b691ad47e433232dd7e72 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core)
Reedy has submitted this change and it was merged. Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: I138aa26d212195f61ecdbcb3954c57204a7b411b --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index c009df3..160013d 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit c009df30952ae37785032d7b3fbf150dd157a7e2 +Subproject commit 160013d74367a4f7c3407986493008f437b64211 -- To view, visit https://gerrit.wikimedia.org/r/97155 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138aa26d212195f61ecdbcb3954c57204a7b411b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update Wikibase to master - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97157 Change subject: Update Wikibase to master .. Update Wikibase to master Change-Id: Ie35e3ee2ba058be599a9c4a6d489df5488142e04 --- M extensions/Wikibase 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/57/97157/1 diff --git a/extensions/Wikibase b/extensions/Wikibase index 26c596f..45f469f 16 --- a/extensions/Wikibase +++ b/extensions/Wikibase -Subproject commit 26c596f3e0011a396478997ee6951dcde2c06718 +Subproject commit 45f469f18a1effdccb88fd31829c79dbb9702b39 -- To view, visit https://gerrit.wikimedia.org/r/97157 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie35e3ee2ba058be599a9c4a6d489df5488142e04 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing use statement in client hooks - change (mediawiki...Wikibase)
Aude has submitted this change and it was merged. Change subject: Add missing use statement in client hooks .. Add missing use statement in client hooks Bug: 57461 Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 (cherry picked from commit 45f469f18a1effdccb88fd31829c79dbb9702b39) --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Aude: Verified; Looks good to me, approved diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index 6ee65e2..f47cb8e 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -24,8 +24,9 @@ use StripState; use Title; use User; -use Wikibase\Client\WikibaseClient; +use Wikibase\Client\Hooks\InfoActionHookHandler; use Wikibase\Client\MovePageNotice; +use Wikibase\Client\WikibaseClient; use Wikibase\DataModel\SimpleSiteLink; /** -- To view, visit https://gerrit.wikimedia.org/r/97156 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506336d6a1e10fd174c7cc7ce831cbcc203354d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.23-wmf5 Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Pull in some updates to OSM. - change (mediawiki/core)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/97158 Change subject: Pull in some updates to OSM. .. Pull in some updates to OSM. Change-Id: I748ba6ac88bd1aed46713f7af488ba835623e230 --- M extensions/OpenStackManager 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/58/97158/1 diff --git a/extensions/OpenStackManager b/extensions/OpenStackManager index ffe85af..a774b64 16 --- a/extensions/OpenStackManager +++ b/extensions/OpenStackManager -Subproject commit ffe85aff6280055575ed30f7d6ec08462923fb80 +Subproject commit a774b64dcf5d39a9018baa0d2b03340effe0ab66 -- To view, visit https://gerrit.wikimedia.org/r/97158 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I748ba6ac88bd1aed46713f7af488ba835623e230 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Andrew Bogott abog...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update Wikibase, fix for action=info - change (mediawiki/core)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/97159 Change subject: Update Wikibase, fix for action=info .. Update Wikibase, fix for action=info Bug: 57461 Change-Id: Ie21372adb3a0cb71a5dedb4aede6349a7a735241 --- M extensions/Wikibase 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/59/97159/1 diff --git a/extensions/Wikibase b/extensions/Wikibase index 26c596f..08cce08 16 --- a/extensions/Wikibase +++ b/extensions/Wikibase -Subproject commit 26c596f3e0011a396478997ee6951dcde2c06718 +Subproject commit 08cce0887530a3a12eaafe25bd6faa75f65f10bb -- To view, visit https://gerrit.wikimedia.org/r/97159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie21372adb3a0cb71a5dedb4aede6349a7a735241 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Aude aude.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MF to head of wmf5 branch - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97160 Change subject: Update MF to head of wmf5 branch .. Update MF to head of wmf5 branch Change-Id: I06eb51bfd5eb3c751be8dd94354a9c236bea44f9 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/60/97160/1 diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 160013d..9b129c1 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 160013d74367a4f7c3407986493008f437b64211 +Subproject commit 9b129c1336cbd3b8dff50269c5c1ee392c21c4df -- To view, visit https://gerrit.wikimedia.org/r/97160 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06eb51bfd5eb3c751be8dd94354a9c236bea44f9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MF to head of wmf4 branch - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97161 Change subject: Update MF to head of wmf4 branch .. Update MF to head of wmf4 branch Change-Id: I2d98ff23472c2138cf82ab609349c6627a653c59 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/61/97161/1 diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 160013d..1bd33d4 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 160013d74367a4f7c3407986493008f437b64211 +Subproject commit 1bd33d40b006ca23fb186be9d776ef4c8e4c4647 -- To view, visit https://gerrit.wikimedia.org/r/97161 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d98ff23472c2138cf82ab609349c6627a653c59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MF to head of wmf5 branch - change (mediawiki/core)
Reedy has submitted this change and it was merged. Change subject: Update MF to head of wmf5 branch .. Update MF to head of wmf5 branch Change-Id: I06eb51bfd5eb3c751be8dd94354a9c236bea44f9 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 160013d..9b129c1 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 160013d74367a4f7c3407986493008f437b64211 +Subproject commit 9b129c1336cbd3b8dff50269c5c1ee392c21c4df -- To view, visit https://gerrit.wikimedia.org/r/97160 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06eb51bfd5eb3c751be8dd94354a9c236bea44f9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MF to head of wmf4 branch - change (mediawiki/core)
Reedy has submitted this change and it was merged. Change subject: Update MF to head of wmf4 branch .. Update MF to head of wmf4 branch Change-Id: I2d98ff23472c2138cf82ab609349c6627a653c59 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved diff --git a/extensions/MobileFrontend b/extensions/MobileFrontend index 160013d..1bd33d4 16 --- a/extensions/MobileFrontend +++ b/extensions/MobileFrontend -Subproject commit 160013d74367a4f7c3407986493008f437b64211 +Subproject commit 1bd33d40b006ca23fb186be9d776ef4c8e4c4647 -- To view, visit https://gerrit.wikimedia.org/r/97161 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d98ff23472c2138cf82ab609349c6627a653c59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf4 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update Wikibase, fix for action=info - change (mediawiki/core)
Reedy has submitted this change and it was merged. Change subject: Update Wikibase, fix for action=info .. Update Wikibase, fix for action=info Bug: 57461 Change-Id: Ie21372adb3a0cb71a5dedb4aede6349a7a735241 --- M extensions/Wikibase 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved diff --git a/extensions/Wikibase b/extensions/Wikibase index 26c596f..08cce08 16 --- a/extensions/Wikibase +++ b/extensions/Wikibase -Subproject commit 26c596f3e0011a396478997ee6951dcde2c06718 +Subproject commit 08cce0887530a3a12eaafe25bd6faa75f65f10bb -- To view, visit https://gerrit.wikimedia.org/r/97159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie21372adb3a0cb71a5dedb4aede6349a7a735241 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.23wmf5 Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Clean up MimeMagic singleton handling - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/97164 Change subject: Clean up MimeMagic singleton handling .. Clean up MimeMagic singleton handling bug: 56915 Change-Id: Ic8ed63816281be21cbcbe7d925a063d0d984c99e --- M includes/MimeMagic.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/64/97164/1 diff --git a/includes/MimeMagic.php b/includes/MimeMagic.php index 8220e92..f5c28ab 100644 --- a/includes/MimeMagic.php +++ b/includes/MimeMagic.php @@ -167,7 +167,7 @@ /** The singleton instance */ - private static $instance; + private static $instance = null; /** Initializes the MimeMagic object. This is called by MimeMagic::singleton(). * @@ -336,7 +336,7 @@ * Get an instance of this class * @return MimeMagic */ - public static function singleton() { + public static function singleton() { if ( self::$instance === null ) { self::$instance = new MimeMagic; } -- To view, visit https://gerrit.wikimedia.org/r/97164 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic8ed63816281be21cbcbe7d925a063d0d984c99e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz asch...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Create a fresh Title object in the job - change (mediawiki...MassMessage)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/97162 Change subject: Create a fresh Title object in the job .. Create a fresh Title object in the job In some cases one project's interwiki prefix might be a namespace on another. For example, [[wikidata:]] on Meta is an interwiki prefix, but on Wikidata itself it is a namespace. By creating a fresh title object we avoid losing the namespace. Bug: 57464 Change-Id: I6e7d970473a86a1c6b2fb4f0f54019a2a2407458 --- M MassMessageJob.php M MassMessageSubmitJob.php 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/62/97162/1 diff --git a/MassMessageJob.php b/MassMessageJob.php index 21b1ec9..b8f80d0 100644 --- a/MassMessageJob.php +++ b/MassMessageJob.php @@ -21,6 +21,9 @@ * @return bool */ public function run() { + // Create a fresh Title object so interwiki prefixes and namespaces + // dont get confused. Bug 57464 + $this-title = Title::newFromText( $this-params['title'] ); $status = $this-sendMessage(); if ( $status !== true ) { diff --git a/MassMessageSubmitJob.php b/MassMessageSubmitJob.php index ca25805..36f748c 100644 --- a/MassMessageSubmitJob.php +++ b/MassMessageSubmitJob.php @@ -25,6 +25,7 @@ foreach ( $pages as $page ) { $title = Title::newFromText( $page['title'] ); + $data['title'] = $page['title']; $jobsByTarget[$page['wiki']][] = new MassMessageJob( $title, $data ); } -- To view, visit https://gerrit.wikimedia.org/r/97162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e7d970473a86a1c6b2fb4f0f54019a2a2407458 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MassMessage Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move file to adhere to module declaration - change (mediawiki...UploadWizard)
MarkTraceur has uploaded a new change for review. https://gerrit.wikimedia.org/r/97163 Change subject: Move file to adhere to module declaration .. Move file to adhere to module declaration Also be consistent with the other filename. Change-Id: I8faf7a62ec05502141bb668f250606ed45a5cddd --- R resources/ext.uploadWizard.uploadCampaign.list.css 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/63/97163/1 diff --git a/resources/ext.UploadWizard.uploadCampaign.list.css b/resources/ext.uploadWizard.uploadCampaign.list.css similarity index 100% rename from resources/ext.UploadWizard.uploadCampaign.list.css rename to resources/ext.uploadWizard.uploadCampaign.list.css -- To view, visit https://gerrit.wikimedia.org/r/97163 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8faf7a62ec05502141bb668f250606ed45a5cddd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: MarkTraceur mtrac...@member.fsf.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] WIP: (Bug 57276) Update pre sep constraints in serializer - change (mediawiki...Parsoid)
Subramanya Sastry has uploaded a new change for review. https://gerrit.wikimedia.org/r/97165 Change subject: WIP: (Bug 57276) Update pre sep constraints in serializer .. WIP: (Bug 57276) Update pre sep constraints in serializer Change-Id: I24ff084301d7f188e0d64a7034659193fa20ae34 --- M js/lib/mediawiki.WikitextSerializer.js M js/tests/parserTests-blacklist.js 2 files changed, 39 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/65/97165/1 diff --git a/js/lib/mediawiki.WikitextSerializer.js b/js/lib/mediawiki.WikitextSerializer.js index 9117d6b..951a951 100644 --- a/js/lib/mediawiki.WikitextSerializer.js +++ b/js/lib/mediawiki.WikitextSerializer.js @@ -2674,24 +2674,54 @@ content = ' ' + content.replace(/(\n(!--(?:[^\-]|\-(?!\-))*\-\-)*)(?!$)/g, '$1 ' ); - // Strip trailing separators - //var trailingSep = content.match(/\s*$/); - //content = content.replace(/\s*$/, ''); - cb(content, node); - // Preserve separator source - //state.sep.src = trailingSep trailingSep[0] || ''; state.sep.src = ''; } state.inIndentPre = false; }, sepnls: { before: function(node, otherNode) { - return node.data.parsoid.stx === 'html' ? {} : {min:1}; + if (node.data.parsoid.stx === 'html') { + return {}; + } else if (otherNode.nodeName === 'PRE') { + var minNLs = 2, maxNLs = 0; + if (DU.isText(node.firstChild)) { + var nlMatch = node.firstChild.nodeValue.match(/^(\n*)/); + minNLs = 2 - nlMatch[1].length; + maxNLs += nlMatch[1].length; + } + if (DU.isText(otherNode.lastChild)) { + var nlMatch = otherNode.lastChild.nodeValue.match(/[^]*?(\n*)$/); + minNLs = minNLs - nlMatch[1].length; + maxNLs += nlMatch[1].length; + } + console.warn(maxNLs: + maxNLs); + return {min: minNLs 0 ? 0 : minNLs, max: maxNLs 2 ? 2 : maxNLs}; + } else { + return {min:1}; + } }, after: function(node, otherNode) { - return node.data.parsoid.stx === 'html' ? {} : {min:1}; + if (node.data.parsoid.stx === 'html') { + return {}; + } else if (otherNode.nodeName === 'PRE') { + var minNLs = 2, maxNLs = 0; + if (DU.isText(otherNode.firstChild)) { + var nlMatch = otherNode.firstChild.nodeValue.match(/^(\n*)/); + minNLs = minNLs - nlMatch[1].length; + maxNLs += nlMatch[1].length; + } + if (DU.isText(node.lastChild)) { + var nlMatch = node.lastChild.nodeValue.match(/[^]*?(\n*)$/); + minNLs = minNLs - nlMatch[1].length; + maxNLs += nlMatch[1].length; + } + console.warn(maxNLs: + maxNLs); + return {min: minNLs 0 ? 0 : minNLs, max: maxNLs 2 ? 2 : maxNLs}; + } else { + return {min:1}; + } } } }, diff --git a/js/tests/parserTests-blacklist.js b/js/tests/parserTests-blacklist.js index d66ce46..11abadb 100644 --- a/js/tests/parserTests-blacklist.js +++ b/js/tests/parserTests-blacklist.js @@ -712,7 +712,6 @@ add(html2html, pre with forbidden attribute values (bug 3202)); add(html2html, nowiki inside pre (bug 13238));
[MediaWiki-commits] [Gerrit] Disable OAuth on fishbowl wikis - change (operations/mediawiki-config)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97166 Change subject: Disable OAuth on fishbowl wikis .. Disable OAuth on fishbowl wikis Change-Id: Ib9802962162745c27011b6e3cb342445adda3361 --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/66/97166/1 diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 987ee89..4d3a71b 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -9791,6 +9791,7 @@ 'wmgUseOAuth' = array( 'default' = true, 'private' = false, + 'fishbowl' = false, ), # @} -- To view, visit https://gerrit.wikimedia.org/r/97166 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9802962162745c27011b6e3cb342445adda3361 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable OAuth on fishbowl wikis - change (operations/mediawiki-config)
Reedy has submitted this change and it was merged. Change subject: Disable OAuth on fishbowl wikis .. Disable OAuth on fishbowl wikis Change-Id: Ib9802962162745c27011b6e3cb342445adda3361 --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: CSteipp: Looks good to me, but someone else must approve Reedy: Verified; Looks good to me, approved diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 987ee89..4d3a71b 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -9791,6 +9791,7 @@ 'wmgUseOAuth' = array( 'default' = true, 'private' = false, + 'fishbowl' = false, ), # @} -- To view, visit https://gerrit.wikimedia.org/r/97166 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9802962162745c27011b6e3cb342445adda3361 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: CSteipp cste...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Load SpamBlacklist from meta over HTTPS - change (mediawiki...SpamBlacklist)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97167 Change subject: Load SpamBlacklist from meta over HTTPS .. Load SpamBlacklist from meta over HTTPS Change-Id: I3c3d397d5779aa0affcfa8455c2197ac562c5424 --- M SpamBlacklist.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist refs/changes/67/97167/1 diff --git a/SpamBlacklist.php b/SpamBlacklist.php index 2fd7855..d904abf 100644 --- a/SpamBlacklist.php +++ b/SpamBlacklist.php @@ -23,7 +23,7 @@ */ $wgBlacklistSettings = array( 'spam' = array( - 'files' = array( http://meta.wikimedia.org/w/index.php?title=Spam_blacklistaction=rawsb_ver=1; ) + 'files' = array( https://meta.wikimedia.org/w/index.php?title=Spam_blacklistaction=rawsb_ver=1; ) ) ); -- To view, visit https://gerrit.wikimedia.org/r/97167 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c3d397d5779aa0affcfa8455c2197ac562c5424 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SpamBlacklist Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] If a user has a temporary password set, still take over the ... - change (mediawiki...MassMessage)
jenkins-bot has submitted this change and it was merged. Change subject: If a user has a temporary password set, still take over the account .. If a user has a temporary password set, still take over the account Bug: 57439 Change-Id: I4a85b3430940f4378932ad169219cf36e88f1e6c --- M MassMessage.body.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified diff --git a/MassMessage.body.php b/MassMessage.body.php index eca47dd..cba6529 100644 --- a/MassMessage.body.php +++ b/MassMessage.body.php @@ -42,7 +42,7 @@ // Function kinda copied from the AbuseFilter $user = User::newFromName( $wgMassMessageAccountUsername ); $user-load(); - if ( $user-getId() $user-mPassword == '' ) { + if ( $user-getId() $user-mPassword == '' $user-mNewpassword == '' ) { // We've already stolen the account return $user; } -- To view, visit https://gerrit.wikimedia.org/r/97117 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a85b3430940f4378932ad169219cf36e88f1e6c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MassMessage Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org Gerrit-Reviewer: MZMcBride w...@mzmcbride.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make WebRequest::protocol protected as it's used in subclass... - change (mediawiki/core)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/97168 Change subject: Make WebRequest::protocol protected as it's used in subclasses in the same file .. Make WebRequest::protocol protected as it's used in subclasses in the same file Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e --- M includes/WebRequest.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/68/97168/1 diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 536ce12..46cba52 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -54,7 +54,7 @@ * Cached URL protocol * @var string */ - private $protocol; + protected $protocol; public function __construct() { /// @todo FIXME: This preemptive de-quoting can interfere with other web libraries -- To view, visit https://gerrit.wikimedia.org/r/97168 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing space in a comment - change (mediawiki...MultimediaViewer)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/97169 Change subject: Fixing space in a comment .. Fixing space in a comment Change-Id: I713dfb75d2fd242b0b314b283e03a7220c3bf383 --- M MultimediaViewerHooks.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/69/97169/1 diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php index 1f170fc..d72dabb 100644 --- a/MultimediaViewerHooks.php +++ b/MultimediaViewerHooks.php @@ -8,7 +8,7 @@ * (at your option) any later version. * * MultimediaViewer is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of + * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * -- To view, visit https://gerrit.wikimedia.org/r/97169 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I713dfb75d2fd242b0b314b283e03a7220c3bf383 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing space in a comment - change (mediawiki...MultimediaViewer)
jenkins-bot has submitted this change and it was merged. Change subject: Fixing space in a comment .. Fixing space in a comment Change-Id: I713dfb75d2fd242b0b314b283e03a7220c3bf383 --- M MultimediaViewerHooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php index 1f170fc..d72dabb 100644 --- a/MultimediaViewerHooks.php +++ b/MultimediaViewerHooks.php @@ -8,7 +8,7 @@ * (at your option) any later version. * * MultimediaViewer is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of + * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * -- To view, visit https://gerrit.wikimedia.org/r/97169 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I713dfb75d2fd242b0b314b283e03a7220c3bf383 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allow query campaign api to work for campaigns with space in... - change (mediawiki...CentralNotice)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/97170 Change subject: Allow query campaign api to work for campaigns with space in their names .. Allow query campaign api to work for campaigns with space in their names Bug: 57373 Change-Id: I0cdaabea1a9bf6aa87ebcc4250c1633deccfb625 --- M api/ApiCentralNoticeQueryCampaign.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/70/97170/1 diff --git a/api/ApiCentralNoticeQueryCampaign.php b/api/ApiCentralNoticeQueryCampaign.php index ca4adfb..e5a22bc 100644 --- a/api/ApiCentralNoticeQueryCampaign.php +++ b/api/ApiCentralNoticeQueryCampaign.php @@ -6,7 +6,7 @@ * @var string sanitize campaign name * FIXME: the string is apparently unrestricted in Special:CentralNotice */ - const CAMPAIGNS_FILTER = '/[a-zA-Z0-9_|\-]+/'; + const CAMPAIGNS_FILTER = '/[a-zA-Z0-9 _|\-]+/'; public function execute() { // Obtain the ApiResults object from the base -- To view, visit https://gerrit.wikimedia.org/r/97170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cdaabea1a9bf6aa87ebcc4250c1633deccfb625 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make importml.sh less Linux-centric, more UNIX-agnostic - change (mediawiki...MultimediaViewer)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/97171 Change subject: Make importml.sh less Linux-centric, more UNIX-agnostic .. Make importml.sh less Linux-centric, more UNIX-agnostic Bash could be located at different places on different OSes. Bug: 57470 Change-Id: I8db54fe4b2b91b9b2f1a47756262e848cff39afe --- M importml.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/71/97171/1 diff --git a/importml.sh b/importml.sh index 44244fe..148b590 100755 --- a/importml.sh +++ b/importml.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash if [ $1 = --reverse ]; then MLDIR=$2 -- To view, visit https://gerrit.wikimedia.org/r/97171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8db54fe4b2b91b9b2f1a47756262e848cff39afe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improving functions documentation - change (mediawiki...MultimediaViewer)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/97172 Change subject: Improving functions documentation .. Improving functions documentation Change-Id: I1d316df98a2157b9f5593eaf4c7f9587d22796a7 --- M MultimediaViewerHooks.php 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/72/97172/1 diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php index d72dabb..5eca70e 100644 --- a/MultimediaViewerHooks.php +++ b/MultimediaViewerHooks.php @@ -31,7 +31,7 @@ /** * Handler for all places where we add the modules * Could be on article pages or on Category pages -* @param OutputPage $out +* @param OutputPage $out The OutputPage object * @return bool */ protected static function getModules( $out ) { @@ -49,8 +49,8 @@ * Handler for BeforePageDisplay hook * Add JavaScript to the page when an image is on it * and the user has enabled the feature if BetaFeatures is installed -* @param OutputPage $out -* @param Skin $skin +* @param OutputPage $out The OutputPage object +* @param Skin $skin The Skin object that will be used to generate the page * @return bool */ public static function getModulesForArticle( $out, $skin ) { @@ -64,7 +64,7 @@ /** * Handler for CategoryPageView hook * Add JavaScript to the page if there are images in the category -* @param CategoryPage $catPage +* @param CategoryPage $catPage The CategoryPage instance (CategoryPage is a subclass of Article) * @return bool */ public static function getModulesForCategory( $catPage ) { @@ -78,7 +78,11 @@ return true; } - // Add a beta preference to gate the feature + /** +* Add a beta preference to gate the feature +* @param User $user The user who has requested or saved their preferences +* @param $prefs List of options +*/ public static function getBetaPreferences( $user, $prefs ) { global $wgExtensionAssetsPath; @@ -95,7 +99,7 @@ /** * Export variables used in both PHP and JS to keep DRY -* @param array $vars +* @param array $vars Array of variables to be added into the output of the startup module * @return bool */ public static function resourceLoaderGetConfigVars( $vars ) { -- To view, visit https://gerrit.wikimedia.org/r/97172 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d316df98a2157b9f5593eaf4c7f9587d22796a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make WebRequest::protocol protected as it's used in subclass... - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Make WebRequest::protocol protected as it's used in subclasses in the same file .. Make WebRequest::protocol protected as it's used in subclasses in the same file Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e --- M includes/WebRequest.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 536ce12..46cba52 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -54,7 +54,7 @@ * Cached URL protocol * @var string */ - private $protocol; + protected $protocol; public function __construct() { /// @todo FIXME: This preemptive de-quoting can interfere with other web libraries -- To view, visit https://gerrit.wikimedia.org/r/97168 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If894e9122fa56e957c666c887fb33ed60733ac0e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Lohit Kannada font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97173 Change subject: Add request-url field for Lohit Kannada font. .. Add request-url field for Lohit Kannada font. Added the git and gerrit commit URLs for the addition of the Lohit Kannada font for Kannada (kn) and Tulu (tcy) language. Change-Id: I085d975b8b8e7fbeeefc8b6e52a7df8f696018ac --- M data/fontrepo/fonts/LohitKannada/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/73/97173/1 diff --git a/data/fontrepo/fonts/LohitKannada/font.ini b/data/fontrepo/fonts/LohitKannada/font.ini index 313e955..fc3923e 100644 --- a/data/fontrepo/fonts/LohitKannada/font.ini +++ b/data/fontrepo/fonts/LohitKannada/font.ini @@ -3,4 +3,5 @@ version=2.5.3 license=OFL-1.1 licensefile=OFL.txt +request-url=[https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85714] url=https://fedorahosted.org/lohit/ -- To view, visit https://gerrit.wikimedia.org/r/97173 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I085d975b8b8e7fbeeefc8b6e52a7df8f696018ac Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Lohit Telugu font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97174 Change subject: Add request-url field for Lohit Telugu font. .. Add request-url field for Lohit Telugu font. Added the git and gerrit commit URLs for the addition of the Lohit Telugu font for Telugu (te) language. Change-Id: I48366d8eaaa189ef3684f1231660cab79cf0ecc9 --- M data/fontrepo/fonts/LohitTelugu/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/74/97174/1 diff --git a/data/fontrepo/fonts/LohitTelugu/font.ini b/data/fontrepo/fonts/LohitTelugu/font.ini index db335fd..77b865f 100644 --- a/data/fontrepo/fonts/LohitTelugu/font.ini +++ b/data/fontrepo/fonts/LohitTelugu/font.ini @@ -3,4 +3,5 @@ version=2.5.3 license=OFL-1.1 licensefile=OFL.txt +request-url=[https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85714] url=https://fedorahosted.org/lohit/ -- To view, visit https://gerrit.wikimedia.org/r/97174 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48366d8eaaa189ef3684f1231660cab79cf0ecc9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Pagul font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97175 Change subject: Add request-url field for Pagul font. .. Add request-url field for Pagul font. Added the git and gerrit commit URLs for the addition of the Pagul font for Saurashtra (saz) language Change-Id: I7533e69853e8eca5e881e48aae86a702e75ebeda --- M data/fontrepo/fonts/Pagul/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/75/97175/1 diff --git a/data/fontrepo/fonts/Pagul/font.ini b/data/fontrepo/fonts/Pagul/font.ini index c89ff3b..5aa2f10 100644 --- a/data/fontrepo/fonts/Pagul/font.ini +++ b/data/fontrepo/fonts/Pagul/font.ini @@ -3,4 +3,5 @@ version=1.0 license=GPL-3.0.0-with-font-exception licensefile=gpl-3.0.txt +request-url=[https://www.mediawiki.org/wiki/Special:Code/MediaWiki/87738] url=http://sourceforge.net/projects/pagul/ -- To view, visit https://gerrit.wikimedia.org/r/97175 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7533e69853e8eca5e881e48aae86a702e75ebeda Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for KhmerOSbattambang font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97176 Change subject: Add request-url field for KhmerOSbattambang font. .. Add request-url field for KhmerOSbattambang font. Added the git and gerrit commit URLs for the addition of the KhmerOSbattambang font for Khmer (km) language. Change-Id: I324c683efcfe2f90b5c6ae7636e4dc61f8b26a5b --- M data/fontrepo/fonts/KhmerOSbattambang/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/76/97176/1 diff --git a/data/fontrepo/fonts/KhmerOSbattambang/font.ini b/data/fontrepo/fonts/KhmerOSbattambang/font.ini index 5f07f35..67a3a63 100644 --- a/data/fontrepo/fonts/KhmerOSbattambang/font.ini +++ b/data/fontrepo/fonts/KhmerOSbattambang/font.ini @@ -3,4 +3,5 @@ version=1.10 license=LGPL-2.1+ licensefile=lgpl-2.1.txt +request-url=[https://www.mediawiki.org/wiki/Special:Code/MediaWiki/87161] url=http://www.khmeros.info/drupal612/en/fonts -- To view, visit https://gerrit.wikimedia.org/r/97176 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I324c683efcfe2f90b5c6ae7636e4dc61f8b26a5b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Thaana font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97177 Change subject: Add request-url field for Thaana font. .. Add request-url field for Thaana font. Added the bug URL for the addition of the Thaana font for the Divehi (dv) language. Change-Id: I309906351fdd1a61772e43c67d011369a8dd70b3 --- M data/fontrepo/fonts/FreeFontThana/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/77/97177/1 diff --git a/data/fontrepo/fonts/FreeFontThana/font.ini b/data/fontrepo/fonts/FreeFontThana/font.ini index c2bd58a..b90af74 100644 --- a/data/fontrepo/fonts/FreeFontThana/font.ini +++ b/data/fontrepo/fonts/FreeFontThana/font.ini @@ -4,6 +4,7 @@ license=GPL-3.0 licensefile=gpl-3.0.txt url=www.gnu.org/software/freefont +request-url=[https://bugzilla.wikimedia.org/show_bug.cgi?id=42812] ttf=FreeFont-Thaana.ttf eot=FreeFont-Thaana.eot woff=FreeFont-Thaana.woff -- To view, visit https://gerrit.wikimedia.org/r/97177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I309906351fdd1a61772e43c67d011369a8dd70b3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for NuosuSIL font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97178 Change subject: Add request-url field for NuosuSIL font. .. Add request-url field for NuosuSIL font. Added the bug URL for the addition of the NuosuSIL font for the Sichuan Yi (ii) language. Change-Id: Ia0e2d1fc050154d0fa61aa58b70fe3d44e2e4a6b --- M data/fontrepo/fonts/NuosuSIL/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/78/97178/1 diff --git a/data/fontrepo/fonts/NuosuSIL/font.ini b/data/fontrepo/fonts/NuosuSIL/font.ini index 172c2c5..72a42a4 100644 --- a/data/fontrepo/fonts/NuosuSIL/font.ini +++ b/data/fontrepo/fonts/NuosuSIL/font.ini @@ -3,6 +3,7 @@ version=2.1.1 license=OFL-1.1 licensefile=OFL.txt +request-url=[https://bugzilla.wikimedia.org/show_bug.cgi?id=52959] url=http://scripts.sil.org/SILYI_home ttf=NuosuSIL.ttf eot=NuosuSIL.eot -- To view, visit https://gerrit.wikimedia.org/r/97178 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0e2d1fc050154d0fa61aa58b70fe3d44e2e4a6b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for TharLon font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97179 Change subject: Add request-url field for TharLon font. .. Add request-url field for TharLon font. Added the bug URL for the addition of the TharLon font for Burmese (my) language Change-Id: Icb4b2798d6301f4a37643015c727a2d320088c5d --- M data/fontrepo/fonts/TharLon/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/79/97179/1 diff --git a/data/fontrepo/fonts/TharLon/font.ini b/data/fontrepo/fonts/TharLon/font.ini index 6d261eb..161b340 100644 --- a/data/fontrepo/fonts/TharLon/font.ini +++ b/data/fontrepo/fonts/TharLon/font.ini @@ -3,4 +3,5 @@ version=1.003 license=OFL-1.1 licensefile=OFL.txt +request-url=[https://bugzilla.wikimedia.org/show_bug.cgi?id=34817] url=http://code.google.com/p/tharlon-font/ -- To view, visit https://gerrit.wikimedia.org/r/97179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb4b2798d6301f4a37643015c727a2d320088c5d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for NafeesWeb font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97180 Change subject: Add request-url field for NafeesWeb font. .. Add request-url field for NafeesWeb font. Added the bug URL for the addition of the NafeesWeb font for Urdu (ur) language. Change-Id: I62d87324f6d4d3d93ce0a2ddd539d778426c6d15 --- M data/fontrepo/fonts/NafeesWeb/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/80/97180/1 diff --git a/data/fontrepo/fonts/NafeesWeb/font.ini b/data/fontrepo/fonts/NafeesWeb/font.ini index 89594c8..202d267 100644 --- a/data/fontrepo/fonts/NafeesWeb/font.ini +++ b/data/fontrepo/fonts/NafeesWeb/font.ini @@ -3,6 +3,7 @@ version=1.2 license=GPL-2.0 licensefile=gpl-2.0.txt +request-url=[https://bugzilla.wikimedia.org/46693] #URL seems broken but, Debian has this font confirming its license validity. #Also see: http://groups.yahoo.com/group/urdu_computing/message/1081 url=http://www.crulp.org/nafeesWebNaskh.html -- To view, visit https://gerrit.wikimedia.org/r/97180 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62d87324f6d4d3d93ce0a2ddd539d778426c6d15 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for LKlug font. - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97181 Change subject: Add request-url field for LKlug font. .. Add request-url field for LKlug font. Added the bug URL for the addition of the LKlug font for Sinhala (si) language. Change-Id: I66b44600821bf5746e7fe792c7b598315ffb9d8b --- M data/fontrepo/fonts/lklug/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/81/97181/1 diff --git a/data/fontrepo/fonts/lklug/font.ini b/data/fontrepo/fonts/lklug/font.ini index 6101f00..9ea9548 100644 --- a/data/fontrepo/fonts/lklug/font.ini +++ b/data/fontrepo/fonts/lklug/font.ini @@ -5,6 +5,7 @@ licensefile=gpl-2.0.txt //URL is 404 at present. Current version is derived from Debian. url=http://www.lug.lk/fonts/lklug +request-url=[https://bugzilla.wikimedia.org/52964] ttf=lklug.ttf eot=lklug.eot woff=lklug.woff -- To view, visit https://gerrit.wikimedia.org/r/97181 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I66b44600821bf5746e7fe792c7b598315ffb9d8b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] page.images, pagination: Added history pushState for url chan... - change (mediawiki/core)
RAZVOR has uploaded a new change for review. https://gerrit.wikimedia.org/r/97182 Change subject: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 .. page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 Change-Id: I7ad6e022de0fd4e14d710d0996a0b3e3a6dabf6c --- M resources/mediawiki.page/mediawiki.page.image.pagination.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/82/97182/1 diff --git a/resources/mediawiki.page/mediawiki.page.image.pagination.js b/resources/mediawiki.page/mediawiki.page.image.pagination.js index 662f7dc..55ca2ef 100644 --- a/resources/mediawiki.page/mediawiki.page.image.pagination.js +++ b/resources/mediawiki.page/mediawiki.page.image.pagination.js @@ -8,7 +8,7 @@ // tr with the new page's table.multipageimage's tr element. // table.multipageimage always has only one row. function loadPage( page ) { - history.pushState({foo:bar},foo,page); + history.pushState({foo:'bar'},'foo',page); var $multipageimage = $( 'table.multipageimage' ), $spinner = $.createSpinner( { size: 'large', @@ -54,3 +54,5 @@ } } ); }( mediaWiki, jQuery ) ); + + -- To view, visit https://gerrit.wikimedia.org/r/97182 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ad6e022de0fd4e14d710d0996a0b3e3a6dabf6c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: RAZVOR iraz...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removing the request-bug and request-defaults fields and add... - change (mediawiki...UniversalLanguageSelector)
Arrbee has uploaded a new change for review. https://gerrit.wikimedia.org/r/97183 Change subject: Removing the request-bug and request-defaults fields and adding the request-url field. .. Removing the request-bug and request-defaults fields and adding the request-url field. Added the request-url field for Phetsarath, Siyam Rupali, OskiEast, amiri, AbyssinicaSIL, Jomolhari, Tuladha Jejeg, CharisSIL, DoulosSIL, Akkadian fonts Change-Id: I81fbfe2ed65c2f87c41f73c65724b1dbe2abe684 --- M data/fontrepo/fonts/AbyssinicaSIL/font.ini M data/fontrepo/fonts/Akkadian/font.ini M data/fontrepo/fonts/CharisSIL/font.ini M data/fontrepo/fonts/DoulosSIL/font.ini M data/fontrepo/fonts/Jomolhari/font.ini M data/fontrepo/fonts/OskiEast/font.ini M data/fontrepo/fonts/Phetsarath/font.ini M data/fontrepo/fonts/SiyamRupali/font.ini M data/fontrepo/fonts/TuladhaJejeg/font.ini M data/fontrepo/fonts/amiri/font.ini 10 files changed, 12 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/83/97183/1 diff --git a/data/fontrepo/fonts/AbyssinicaSIL/font.ini b/data/fontrepo/fonts/AbyssinicaSIL/font.ini index 4f85506..b221097 100644 --- a/data/fontrepo/fonts/AbyssinicaSIL/font.ini +++ b/data/fontrepo/fonts/AbyssinicaSIL/font.ini @@ -3,6 +3,5 @@ version=1.200 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/88325 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90306/ +request-url=[https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90306/] url=http://scripts.sil.org/AbyssinicaSIL diff --git a/data/fontrepo/fonts/Akkadian/font.ini b/data/fontrepo/fonts/Akkadian/font.ini index de7490e..3e88b5e 100644 --- a/data/fontrepo/fonts/Akkadian/font.ini +++ b/data/fontrepo/fonts/Akkadian/font.ini @@ -3,6 +3,6 @@ version=2.56 license=George-Douros licensefile=George-Douros.txt -request-bug=https://mediawiki.org/wiki/Special:Code/MediaWiki/112469 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/ +request-url=https://gerrit.wikimedia.org/r/#/c/25479/ +#original request http://ultimategerardm.blogspot.in/2012/02/cuneiform-is-supported-at.html url=http://users.teilar.gr/~g1951d/; diff --git a/data/fontrepo/fonts/CharisSIL/font.ini b/data/fontrepo/fonts/CharisSIL/font.ini index c7966bc..b46ea03 100644 --- a/data/fontrepo/fonts/CharisSIL/font.ini +++ b/data/fontrepo/fonts/CharisSIL/font.ini @@ -3,6 +3,5 @@ version=4.011 license=OFL-1.1 licensefile=OFL.txt -request-bug=http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100020, https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 -#request-default=https://gerrit.wikimedia.org/r/#/c/25479/ +request-url=[https://gerrit.wikimedia.org/r/#/c/25479/,https://bugzilla.wikimedia.org/show_bug.cgi?id=47190] url=http://scripts.sil.org/CharisSIL diff --git a/data/fontrepo/fonts/DoulosSIL/font.ini b/data/fontrepo/fonts/DoulosSIL/font.ini index 736c3a9..efabcf6 100644 --- a/data/fontrepo/fonts/DoulosSIL/font.ini +++ b/data/fontrepo/fonts/DoulosSIL/font.ini @@ -3,6 +3,5 @@ version=4.112 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 -#request-default=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 +request-url=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 url=http://scripts.sil.org/DoulosSIL diff --git a/data/fontrepo/fonts/Jomolhari/font.ini b/data/fontrepo/fonts/Jomolhari/font.ini index b06f74e..46843c0 100644 --- a/data/fontrepo/fonts/Jomolhari/font.ini +++ b/data/fontrepo/fonts/Jomolhari/font.ini @@ -3,6 +3,6 @@ version=0.003 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://bugzilla.wikimedia.org/show_bug.cgi?id=33718 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90308/ +request-url=[https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90308/] +#originally requested through https://bugzilla.wikimedia.org/33718 url=https://sites.google.com/site/chrisfynn2/home/fonts/jomolhari diff --git a/data/fontrepo/fonts/OskiEast/font.ini b/data/fontrepo/fonts/OskiEast/font.ini index f365728..9ebe50c 100644 --- a/data/fontrepo/fonts/OskiEast/font.ini +++ b/data/fontrepo/fonts/OskiEast/font.ini @@ -3,8 +3,7 @@ version=2.200 license=GPL-3.0 licensefile=gpl-3.0.txt -request-bug=https://bugzilla.wikimedia.org/42421 -request-default=https://gerrit.wikimedia.org/r/#/c/80548/ +request-url=https://gerrit.wikimedia.org/r/#/c/80548/ url=http://www.languagegeek.com/font/fontdownload.html#AlgonAndInu ttf=oskie.ttf eot=oskie.eot diff --git a/data/fontrepo/fonts/Phetsarath/font.ini b/data/fontrepo/fonts/Phetsarath/font.ini index d9e148f..c8c1997 100644 --- a/data/fontrepo/fonts/Phetsarath/font.ini +++ b/data/fontrepo/fonts/Phetsarath/font.ini @@ -3,8 +3,7 @@
[MediaWiki-commits] [Gerrit] Don't use @deprecated for parameters - change (mediawiki...Echo)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/97184 Change subject: Don't use @deprecated for parameters .. Don't use @deprecated for parameters Makes PHPStorm think the whole function is deprecated, switched them to @param $var type deprecated Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818 --- M formatters/BasicFormatter.php M formatters/PageLinkFormatter.php 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/84/97184/1 diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php index cdf442e..8d3bce3 100644 --- a/formatters/BasicFormatter.php +++ b/formatters/BasicFormatter.php @@ -152,7 +152,7 @@ * * @param $event EchoEvent that the notification is for. * @param $user User to format the notification for. -* @deprecated $type +* @param $type string deprecated */ protected function applyChangeBeforeFormatting( EchoEvent $event, User $user, $type ) { // Use the bundle message if use-bundle is true and there is a bundle message @@ -257,7 +257,7 @@ * * @param $event EchoEvent * @param $user User -* @deprecated $type +* @param $type string deprecated * @return array */ protected function formatEmail( $event, $user, $type ) { @@ -534,7 +534,7 @@ * Get raw bundle data for an event so it can be manipulated * @param $event EchoEvent * @param $user User -* @deprecated $type +* @param $type string deprecated * @return ResultWrapper|bool */ protected function getRawBundleData( $event, $user, $type ) { @@ -565,7 +565,8 @@ * this function to use a differnt group iterator such as title, namespace * @param $event EchoEvent * @param $user User -* @deprecated $type +* @param $type string deprecated +* @throws MWException */ protected function generateBundleData( $event, $user, $type ) { global $wgEchoMaxNotificationCount; diff --git a/formatters/PageLinkFormatter.php b/formatters/PageLinkFormatter.php index cdec629..816777b 100644 --- a/formatters/PageLinkFormatter.php +++ b/formatters/PageLinkFormatter.php @@ -37,7 +37,7 @@ * link from Page B and X other pages * @param $event EchoEvent * @param $user User -* @deprecated $type +* @param $type string deprecated */ protected function generateBundleData( $event, $user, $type ) { global $wgEchoMaxNotificationCount; -- To view, visit https://gerrit.wikimedia.org/r/97184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Restore MediaWiki:Signupstart for account creation - change (mediawiki/core)
MarkAHershberger has uploaded a new change for review. https://gerrit.wikimedia.org/r/97185 Change subject: Restore MediaWiki:Signupstart for account creation .. Restore MediaWiki:Signupstart for account creation This was removed during the redesign of the login process in I489042c5, but it was reported that this message is used to display legal notices previously. We should keep this around or at the very least provide advance notice for people. Bug: 56455 Change-Id: I79423c1a05f0359c902d1940c3ffcd5e509dcf97 --- M includes/templates/Usercreate.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/85/97185/1 diff --git a/includes/templates/Usercreate.php b/includes/templates/Usercreate.php index 4750af9..94aeffe 100644 --- a/includes/templates/Usercreate.php +++ b/includes/templates/Usercreate.php @@ -51,7 +51,8 @@ h2 class=createaccount-join ?php $this-msg( $this-data['loggedin'] ? 'createacct-another-join' : 'createacct-join' ); ? /h2 - form name=userlogin2 id=userlogin2 class=mw-ui-vform method=post action=?php $this-text( 'action' ); ? + div id=signupstart?php $this-msgWiki( 'signupstart' ); ?/div + form name=userlogin2 id=userlogin2 class=mw-ui-vform method=post action=?php $this-text( 'action' ); ? section class=mw-form-header ?php $this-html( 'header' ); /* extensions such as ConfirmEdit add form HTML here */ ? /section -- To view, visit https://gerrit.wikimedia.org/r/97185 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I79423c1a05f0359c902d1940c3ffcd5e509dcf97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: MarkAHershberger mhershber...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] page.images, pagination: Added history pushState for url chan... - change (mediawiki/core)
RAZVOR has uploaded a new change for review. https://gerrit.wikimedia.org/r/97186 Change subject: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 .. page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 Change-Id: I4752bb198986585237b14ee471be9b1338ea8637 --- M resources/mediawiki.page/mediawiki.page.image.pagination.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/86/97186/1 diff --git a/resources/mediawiki.page/mediawiki.page.image.pagination.js b/resources/mediawiki.page/mediawiki.page.image.pagination.js index 55ca2ef..987fcf1 100644 --- a/resources/mediawiki.page/mediawiki.page.image.pagination.js +++ b/resources/mediawiki.page/mediawiki.page.image.pagination.js @@ -8,7 +8,7 @@ // tr with the new page's table.multipageimage's tr element. // table.multipageimage always has only one row. function loadPage( page ) { - history.pushState({foo:'bar'},'foo',page); + history.pushState({{ 'url': page }, document.title ,page); var $multipageimage = $( 'table.multipageimage' ), $spinner = $.createSpinner( { size: 'large', @@ -30,7 +30,7 @@ ajaxifyPageNavigation ); - wm.hook('wikipage.content').fire($multipageimage); + mw.hook( 'wikipage.content' ).fire( $( '#mw-content-text' ) ); } function ajaxifyPageNavigation() { -- To view, visit https://gerrit.wikimedia.org/r/97186 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4752bb198986585237b14ee471be9b1338ea8637 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: RAZVOR iraz...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removing the request-bug and request-defaults fields and add... - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Removing the request-bug and request-defaults fields and adding the request-url field. .. Removing the request-bug and request-defaults fields and adding the request-url field. Added the request-url field for Phetsarath, Siyam Rupali, OskiEast, amiri, AbyssinicaSIL, Jomolhari, Tuladha Jejeg, CharisSIL, DoulosSIL, Akkadian fonts Change-Id: I81fbfe2ed65c2f87c41f73c65724b1dbe2abe684 --- M data/fontrepo/fonts/AbyssinicaSIL/font.ini M data/fontrepo/fonts/Akkadian/font.ini M data/fontrepo/fonts/CharisSIL/font.ini M data/fontrepo/fonts/DoulosSIL/font.ini M data/fontrepo/fonts/Jomolhari/font.ini M data/fontrepo/fonts/OskiEast/font.ini M data/fontrepo/fonts/Phetsarath/font.ini M data/fontrepo/fonts/SiyamRupali/font.ini M data/fontrepo/fonts/TuladhaJejeg/font.ini M data/fontrepo/fonts/amiri/font.ini 10 files changed, 12 insertions(+), 20 deletions(-) Approvals: Santhosh: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/AbyssinicaSIL/font.ini b/data/fontrepo/fonts/AbyssinicaSIL/font.ini index 4f85506..83e7dec 100644 --- a/data/fontrepo/fonts/AbyssinicaSIL/font.ini +++ b/data/fontrepo/fonts/AbyssinicaSIL/font.ini @@ -3,6 +3,5 @@ version=1.200 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/88325 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90306/ +request-url=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90306/ url=http://scripts.sil.org/AbyssinicaSIL diff --git a/data/fontrepo/fonts/Akkadian/font.ini b/data/fontrepo/fonts/Akkadian/font.ini index de7490e..3e88b5e 100644 --- a/data/fontrepo/fonts/Akkadian/font.ini +++ b/data/fontrepo/fonts/Akkadian/font.ini @@ -3,6 +3,6 @@ version=2.56 license=George-Douros licensefile=George-Douros.txt -request-bug=https://mediawiki.org/wiki/Special:Code/MediaWiki/112469 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/ +request-url=https://gerrit.wikimedia.org/r/#/c/25479/ +#original request http://ultimategerardm.blogspot.in/2012/02/cuneiform-is-supported-at.html url=http://users.teilar.gr/~g1951d/; diff --git a/data/fontrepo/fonts/CharisSIL/font.ini b/data/fontrepo/fonts/CharisSIL/font.ini index c7966bc..f57f95b 100644 --- a/data/fontrepo/fonts/CharisSIL/font.ini +++ b/data/fontrepo/fonts/CharisSIL/font.ini @@ -3,6 +3,5 @@ version=4.011 license=OFL-1.1 licensefile=OFL.txt -request-bug=http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100020, https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 -#request-default=https://gerrit.wikimedia.org/r/#/c/25479/ +request-url=https://gerrit.wikimedia.org/r/#/c/25479/,https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 url=http://scripts.sil.org/CharisSIL diff --git a/data/fontrepo/fonts/DoulosSIL/font.ini b/data/fontrepo/fonts/DoulosSIL/font.ini index 736c3a9..efabcf6 100644 --- a/data/fontrepo/fonts/DoulosSIL/font.ini +++ b/data/fontrepo/fonts/DoulosSIL/font.ini @@ -3,6 +3,5 @@ version=4.112 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 -#request-default=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 +request-url=https://bugzilla.wikimedia.org/show_bug.cgi?id=47190 url=http://scripts.sil.org/DoulosSIL diff --git a/data/fontrepo/fonts/Jomolhari/font.ini b/data/fontrepo/fonts/Jomolhari/font.ini index b06f74e..a9c7b3d 100644 --- a/data/fontrepo/fonts/Jomolhari/font.ini +++ b/data/fontrepo/fonts/Jomolhari/font.ini @@ -3,6 +3,6 @@ version=0.003 license=OFL-1.1 licensefile=OFL.txt -request-bug=https://bugzilla.wikimedia.org/show_bug.cgi?id=33718 -request-default=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90308/ +request-url=https://gerrit.wikimedia.org/r/#/c/25479/, https://gerrit.wikimedia.org/r/#/c/90308/ +#originally requested through https://bugzilla.wikimedia.org/33718 url=https://sites.google.com/site/chrisfynn2/home/fonts/jomolhari diff --git a/data/fontrepo/fonts/OskiEast/font.ini b/data/fontrepo/fonts/OskiEast/font.ini index f365728..9ebe50c 100644 --- a/data/fontrepo/fonts/OskiEast/font.ini +++ b/data/fontrepo/fonts/OskiEast/font.ini @@ -3,8 +3,7 @@ version=2.200 license=GPL-3.0 licensefile=gpl-3.0.txt -request-bug=https://bugzilla.wikimedia.org/42421 -request-default=https://gerrit.wikimedia.org/r/#/c/80548/ +request-url=https://gerrit.wikimedia.org/r/#/c/80548/ url=http://www.languagegeek.com/font/fontdownload.html#AlgonAndInu ttf=oskie.ttf eot=oskie.eot diff --git a/data/fontrepo/fonts/Phetsarath/font.ini b/data/fontrepo/fonts/Phetsarath/font.ini index d9e148f..c8c1997 100644 --- a/data/fontrepo/fonts/Phetsarath/font.ini +++ b/data/fontrepo/fonts/Phetsarath/font.ini @@ -3,8 +3,7 @@ version=1.01 license=OFL-1.1 licensefile=OFL.txt
[MediaWiki-commits] [Gerrit] page.images, pagination: Added history pushState for url chan... - change (mediawiki/core)
RAZVOR has uploaded a new change for review. https://gerrit.wikimedia.org/r/97188 Change subject: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 .. page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 Change-Id: I93e9c65f1808b0f8f8b6cfb7e5a4a9f0b4757584 --- M resources/mediawiki.page/mediawiki.page.image.pagination.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/88/97188/1 diff --git a/resources/mediawiki.page/mediawiki.page.image.pagination.js b/resources/mediawiki.page/mediawiki.page.image.pagination.js index 1177c3c..987fcf1 100644 --- a/resources/mediawiki.page/mediawiki.page.image.pagination.js +++ b/resources/mediawiki.page/mediawiki.page.image.pagination.js @@ -8,7 +8,7 @@ // tr with the new page's table.multipageimage's tr element. // table.multipageimage always has only one row. function loadPage( page ) { - + history.pushState({{ 'url': page }, document.title ,page); var $multipageimage = $( 'table.multipageimage' ), $spinner = $.createSpinner( { size: 'large', @@ -30,7 +30,7 @@ ajaxifyPageNavigation ); - + mw.hook( 'wikipage.content' ).fire( $( '#mw-content-text' ) ); } function ajaxifyPageNavigation() { -- To view, visit https://gerrit.wikimedia.org/r/97188 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93e9c65f1808b0f8f8b6cfb7e5a4a9f0b4757584 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: RAZVOR iraz...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] page.images, pagination: Added history pushState for url chan... - change (mediawiki/core)
RAZVOR has uploaded a new change for review. https://gerrit.wikimedia.org/r/97187 Change subject: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 .. page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 Change-Id: I5f5a9aa56fd55daf05de44a708ab79d1130f5ad2 --- M resources/mediawiki.page/mediawiki.page.image.pagination.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/87/97187/1 diff --git a/resources/mediawiki.page/mediawiki.page.image.pagination.js b/resources/mediawiki.page/mediawiki.page.image.pagination.js index 987fcf1..1177c3c 100644 --- a/resources/mediawiki.page/mediawiki.page.image.pagination.js +++ b/resources/mediawiki.page/mediawiki.page.image.pagination.js @@ -8,7 +8,7 @@ // tr with the new page's table.multipageimage's tr element. // table.multipageimage always has only one row. function loadPage( page ) { - history.pushState({{ 'url': page }, document.title ,page); + var $multipageimage = $( 'table.multipageimage' ), $spinner = $.createSpinner( { size: 'large', @@ -30,7 +30,7 @@ ajaxifyPageNavigation ); - mw.hook( 'wikipage.content' ).fire( $( '#mw-content-text' ) ); + } function ajaxifyPageNavigation() { -- To view, visit https://gerrit.wikimedia.org/r/97187 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f5a9aa56fd55daf05de44a708ab79d1130f5ad2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: RAZVOR iraz...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Enforce redirect URL to be absolute - change (mediawiki...ZeroRatedMobileAccess)
Yurik has uploaded a new change for review. https://gerrit.wikimedia.org/r/97189 Change subject: Enforce redirect URL to be absolute .. Enforce redirect URL to be absolute Relative protocol URLs // are not always supported, enforce HTTP/HTTPS Change-Id: I46b08e5bb16af88e2bcee47da6eaa5cf74484ecf --- M includes/PageRenderingHooks.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess refs/changes/89/97189/1 diff --git a/includes/PageRenderingHooks.php b/includes/PageRenderingHooks.php index dd82dfe..745b43c 100644 --- a/includes/PageRenderingHooks.php +++ b/includes/PageRenderingHooks.php @@ -974,6 +974,7 @@ $langCode = $config['showLangs'][0]; $isLanding = $config['showZeroPage']; } - return $this-getStartPageUrl( $langCode, false, $isLanding ); + $url = $this-getStartPageUrl( $langCode, false, $isLanding ); + return wfExpandUrl( $url ); } } -- To view, visit https://gerrit.wikimedia.org/r/97189 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46b08e5bb16af88e2bcee47da6eaa5cf74484ecf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess Gerrit-Branch: master Gerrit-Owner: Yurik yu...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for LKlug font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for LKlug font. .. Add request-url field for LKlug font. Added the bug URL for the addition of the LKlug font for Sinhala (si) language. Change-Id: I66b44600821bf5746e7fe792c7b598315ffb9d8b --- M data/fontrepo/fonts/lklug/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/lklug/font.ini b/data/fontrepo/fonts/lklug/font.ini index 6101f00..3937a52 100644 --- a/data/fontrepo/fonts/lklug/font.ini +++ b/data/fontrepo/fonts/lklug/font.ini @@ -5,6 +5,7 @@ licensefile=gpl-2.0.txt //URL is 404 at present. Current version is derived from Debian. url=http://www.lug.lk/fonts/lklug +request-url=https://bugzilla.wikimedia.org/52964 ttf=lklug.ttf eot=lklug.eot woff=lklug.woff -- To view, visit https://gerrit.wikimedia.org/r/97181 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66b44600821bf5746e7fe792c7b598315ffb9d8b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add Twitter account to Varnish's error page - change (operations/puppet)
Faidon Liambotis has uploaded a new change for review. https://gerrit.wikimedia.org/r/97190 Change subject: Add Twitter account to Varnish's error page .. Add Twitter account to Varnish's error page Credits go to ErikM :) Change-Id: I291ad585b03e93eaefd437b87fb31bd2d95da3e3 --- M templates/varnish/errorpage.inc.vcl.erb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/90/97190/1 diff --git a/templates/varnish/errorpage.inc.vcl.erb b/templates/varnish/errorpage.inc.vcl.erb index a06504e..af9f8fe 100644 --- a/templates/varnish/errorpage.inc.vcl.erb +++ b/templates/varnish/errorpage.inc.vcl.erb @@ -84,6 +84,7 @@ div id=en lang=en pOur servers are currently experiencing a technical problem. This is probably temporary and should be fixed soon. Please a href=} + / + req.url + { onclick=window.location.reload(false); return falsetry again/a in a few minutes./p +pYou may be able to get further information in Wikimedia's a href=https://twitter.com/wikimedia;Twitter feed/a./p hr noshade=noshade size=1px width=80% / div class=TechnicalStuff If you report this error to the Wikimedia System Administrators, please include the details below.br/ -- To view, visit https://gerrit.wikimedia.org/r/97190 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I291ad585b03e93eaefd437b87fb31bd2d95da3e3 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for NafeesWeb font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for NafeesWeb font. .. Add request-url field for NafeesWeb font. Added the bug URL for the addition of the NafeesWeb font for Urdu (ur) language. Change-Id: I62d87324f6d4d3d93ce0a2ddd539d778426c6d15 --- M data/fontrepo/fonts/NafeesWeb/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/NafeesWeb/font.ini b/data/fontrepo/fonts/NafeesWeb/font.ini index 89594c8..164f6e0 100644 --- a/data/fontrepo/fonts/NafeesWeb/font.ini +++ b/data/fontrepo/fonts/NafeesWeb/font.ini @@ -3,6 +3,7 @@ version=1.2 license=GPL-2.0 licensefile=gpl-2.0.txt +request-url=https://bugzilla.wikimedia.org/46693 #URL seems broken but, Debian has this font confirming its license validity. #Also see: http://groups.yahoo.com/group/urdu_computing/message/1081 url=http://www.crulp.org/nafeesWebNaskh.html -- To view, visit https://gerrit.wikimedia.org/r/97180 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62d87324f6d4d3d93ce0a2ddd539d778426c6d15 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Lohit Kannada font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for Lohit Kannada font. .. Add request-url field for Lohit Kannada font. Added the git and gerrit commit URLs for the addition of the Lohit Kannada font for Kannada (kn) and Tulu (tcy) language. Change-Id: I085d975b8b8e7fbeeefc8b6e52a7df8f696018ac --- M data/fontrepo/fonts/LohitKannada/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/LohitKannada/font.ini b/data/fontrepo/fonts/LohitKannada/font.ini index 313e955..511d25d 100644 --- a/data/fontrepo/fonts/LohitKannada/font.ini +++ b/data/fontrepo/fonts/LohitKannada/font.ini @@ -3,4 +3,5 @@ version=2.5.3 license=OFL-1.1 licensefile=OFL.txt +request-url=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85714 url=https://fedorahosted.org/lohit/ -- To view, visit https://gerrit.wikimedia.org/r/97173 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I085d975b8b8e7fbeeefc8b6e52a7df8f696018ac Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Lohit Telugu font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for Lohit Telugu font. .. Add request-url field for Lohit Telugu font. Added the git and gerrit commit URLs for the addition of the Lohit Telugu font for Telugu (te) language. Change-Id: I48366d8eaaa189ef3684f1231660cab79cf0ecc9 --- M data/fontrepo/fonts/LohitTelugu/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/LohitTelugu/font.ini b/data/fontrepo/fonts/LohitTelugu/font.ini index db335fd..5ae9b41 100644 --- a/data/fontrepo/fonts/LohitTelugu/font.ini +++ b/data/fontrepo/fonts/LohitTelugu/font.ini @@ -3,4 +3,5 @@ version=2.5.3 license=OFL-1.1 licensefile=OFL.txt +request-url=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85714 url=https://fedorahosted.org/lohit/ -- To view, visit https://gerrit.wikimedia.org/r/97174 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48366d8eaaa189ef3684f1231660cab79cf0ecc9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for KhmerOSbattambang font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for KhmerOSbattambang font. .. Add request-url field for KhmerOSbattambang font. Added the git and gerrit commit URLs for the addition of the KhmerOSbattambang font for Khmer (km) language. Change-Id: I324c683efcfe2f90b5c6ae7636e4dc61f8b26a5b --- M data/fontrepo/fonts/KhmerOSbattambang/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/KhmerOSbattambang/font.ini b/data/fontrepo/fonts/KhmerOSbattambang/font.ini index 5f07f35..83db369 100644 --- a/data/fontrepo/fonts/KhmerOSbattambang/font.ini +++ b/data/fontrepo/fonts/KhmerOSbattambang/font.ini @@ -3,4 +3,5 @@ version=1.10 license=LGPL-2.1+ licensefile=lgpl-2.1.txt +request-url=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/87161 url=http://www.khmeros.info/drupal612/en/fonts -- To view, visit https://gerrit.wikimedia.org/r/97176 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I324c683efcfe2f90b5c6ae7636e4dc61f8b26a5b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Pagul font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for Pagul font. .. Add request-url field for Pagul font. Added the git and gerrit commit URLs for the addition of the Pagul font for Saurashtra (saz) language Change-Id: I7533e69853e8eca5e881e48aae86a702e75ebeda --- M data/fontrepo/fonts/Pagul/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/Pagul/font.ini b/data/fontrepo/fonts/Pagul/font.ini index c89ff3b..24c1cf6 100644 --- a/data/fontrepo/fonts/Pagul/font.ini +++ b/data/fontrepo/fonts/Pagul/font.ini @@ -3,4 +3,5 @@ version=1.0 license=GPL-3.0.0-with-font-exception licensefile=gpl-3.0.txt +request-url=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/87738 url=http://sourceforge.net/projects/pagul/ -- To view, visit https://gerrit.wikimedia.org/r/97175 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7533e69853e8eca5e881e48aae86a702e75ebeda Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Thaana font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for Thaana font. .. Add request-url field for Thaana font. Added the bug URL for the addition of the Thaana font for the Divehi (dv) language. Change-Id: I309906351fdd1a61772e43c67d011369a8dd70b3 --- M data/fontrepo/fonts/FreeFontThana/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/FreeFontThana/font.ini b/data/fontrepo/fonts/FreeFontThana/font.ini index c2bd58a..ea0a44e 100644 --- a/data/fontrepo/fonts/FreeFontThana/font.ini +++ b/data/fontrepo/fonts/FreeFontThana/font.ini @@ -4,6 +4,7 @@ license=GPL-3.0 licensefile=gpl-3.0.txt url=www.gnu.org/software/freefont +request-url=https://bugzilla.wikimedia.org/show_bug.cgi?id=42812 ttf=FreeFont-Thaana.ttf eot=FreeFont-Thaana.eot woff=FreeFont-Thaana.woff -- To view, visit https://gerrit.wikimedia.org/r/97177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I309906351fdd1a61772e43c67d011369a8dd70b3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for TharLon font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for TharLon font. .. Add request-url field for TharLon font. Added the bug URL for the addition of the TharLon font for Burmese (my) language Change-Id: Icb4b2798d6301f4a37643015c727a2d320088c5d --- M data/fontrepo/fonts/TharLon/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/TharLon/font.ini b/data/fontrepo/fonts/TharLon/font.ini index 6d261eb..055d27e 100644 --- a/data/fontrepo/fonts/TharLon/font.ini +++ b/data/fontrepo/fonts/TharLon/font.ini @@ -3,4 +3,5 @@ version=1.003 license=OFL-1.1 licensefile=OFL.txt +request-url=https://bugzilla.wikimedia.org/show_bug.cgi?id=34817 url=http://code.google.com/p/tharlon-font/ -- To view, visit https://gerrit.wikimedia.org/r/97179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb4b2798d6301f4a37643015c727a2d320088c5d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for NuosuSIL font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for NuosuSIL font. .. Add request-url field for NuosuSIL font. Added the bug URL for the addition of the NuosuSIL font for the Sichuan Yi (ii) language. Change-Id: Ia0e2d1fc050154d0fa61aa58b70fe3d44e2e4a6b --- M data/fontrepo/fonts/NuosuSIL/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/NuosuSIL/font.ini b/data/fontrepo/fonts/NuosuSIL/font.ini index 172c2c5..b8e2b58 100644 --- a/data/fontrepo/fonts/NuosuSIL/font.ini +++ b/data/fontrepo/fonts/NuosuSIL/font.ini @@ -3,6 +3,7 @@ version=2.1.1 license=OFL-1.1 licensefile=OFL.txt +request-url=https://bugzilla.wikimedia.org/show_bug.cgi?id=52959 url=http://scripts.sil.org/SILYI_home ttf=NuosuSIL.ttf eot=NuosuSIL.eot -- To view, visit https://gerrit.wikimedia.org/r/97178 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e2d1fc050154d0fa61aa58b70fe3d44e2e4a6b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Check supposed revision being reverted is on the same page - change (mediawiki...Echo)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/97191 Change subject: Check supposed revision being reverted is on the same page .. Check supposed revision being reverted is on the same page Bug: 57474 Change-Id: Idec054930dd20a01ec9d5132cce25378914629fc --- M Hooks.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/91/97191/1 diff --git a/Hooks.php b/Hooks.php index 758a1c5..69faf27 100644 --- a/Hooks.php +++ b/Hooks.php @@ -462,7 +462,7 @@ $undidRevId = $wgRequest-getVal( 'wpUndidRevision' ); if ( $undidRevId ) { $undidRevision = Revision::newFromId( $undidRevId ); - if ( $undidRevision ) { + if ( $undidRevision $undidRevision-getTitle()-equals( $title ) ) { $victimId = $undidRevision-getUser(); if ( $victimId ) { // No notifications for anonymous users EchoEvent::create( array( -- To view, visit https://gerrit.wikimedia.org/r/97191 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idec054930dd20a01ec9d5132cce25378914629fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't send rollback notification if nothing changed - change (mediawiki...Echo)
jenkins-bot has submitted this change and it was merged. Change subject: Don't send rollback notification if nothing changed .. Don't send rollback notification if nothing changed Bug: 56574 Change-Id: If727161560ee07482293e8c012b8ba90bb5df505 --- M Hooks.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/Hooks.php b/Hooks.php index 758a1c5..13c24fc 100644 --- a/Hooks.php +++ b/Hooks.php @@ -789,7 +789,10 @@ static function onRollbackComplete( $page, $agent, $newRevision, $oldRevision ) { $victimId = $oldRevision-getUser(); - if ( $victimId ) { // No notifications for anonymous users + if ( + $victimId // No notifications for anonymous users + !$oldRevision-getContent()-equals( $newRevision-getContent() ) // No notifications for null rollbacks + ) { EchoEvent::create( array( 'type' = 'reverted', 'title' = $page-getTitle(), -- To view, visit https://gerrit.wikimedia.org/r/95797 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If727161560ee07482293e8c012b8ba90bb5df505 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Alex Monk kren...@gmail.com Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [BUGFIX] Fix import order due to enable import BeautifullSou... - change (pywikibot/compat)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/97193 Change subject: [BUGFIX] Fix import order due to enable import BeautifullSoup module .. [BUGFIX] Fix import order due to enable import BeautifullSoup module BS is imported via wikipedia.py thus this must file be imported first ( This partially reverts importing parts changed by following: https://gerrit.wikimedia.org/r/#/c/97019/ https://gerrit.wikimedia.org/r/#/c/96381/ ) Change-Id: Ib339a08ef94346008aeaeeb05308769ab32372a6 --- M reflinks.py 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/93/97193/1 diff --git a/reflinks.py b/reflinks.py index e49172d..5627458 100644 --- a/reflinks.py +++ b/reflinks.py @@ -51,9 +51,8 @@ import os import gzip import StringIO -import externals -from BeautifulSoup import UnicodeDammit import wikipedia as pywikibot +from BeautifulSoup import UnicodeDammit import pagegenerators import noreferences from pywikibot import i18n @@ -464,16 +463,16 @@ page.put(new, self.msg) except pywikibot.EditConflict: pywikibot.output(u'Skipping %s because of edit conflict' - % (page.title(),)) + % page.title()) except pywikibot.SpamfilterError, e: pywikibot.output( u'Cannot change %s because of blacklist entry %s' % (page.title(), e.url)) except pywikibot.PageNotSaved, error: -pywikibot.error(u'putting page: %s' % (error.args,)) +pywikibot.error(u'putting page: %s' % error.args) except pywikibot.LockedPage: pywikibot.output(u'Skipping %s (locked page)' - % (page.title(),)) + % page.title()) except pywikibot.ServerError, e: pywikibot.output(u'Server Error : %s' % e) @@ -532,7 +531,7 @@ new_text = page.get() if not page.canBeEdited(): pywikibot.output(uYou can't edit page %s - % page.title(asLink=True)) + % page.title(asLink=True)) continue except pywikibot.NoPage: pywikibot.output(u'Page %s not found' % page.title(asLink=True)) -- To view, visit https://gerrit.wikimedia.org/r/97193 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib339a08ef94346008aeaeeb05308769ab32372a6 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add request-url field for Lohit Oriya font. - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Add request-url field for Lohit Oriya font. .. Add request-url field for Lohit Oriya font. Added the git and gerrit commit URL for the addition of the Lohit Oriya font for Odia (or) language. Change-Id: I8d3ddcd3c29a0ddc0a90e35010e7d7b22746801c --- M data/fontrepo/fonts/LohitOriya/font.ini 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/data/fontrepo/fonts/LohitOriya/font.ini b/data/fontrepo/fonts/LohitOriya/font.ini index aa8d4b8..e142446 100644 --- a/data/fontrepo/fonts/LohitOriya/font.ini +++ b/data/fontrepo/fonts/LohitOriya/font.ini @@ -3,4 +3,5 @@ version=2.5.3 license=OFL-1.1 licensefile=OFL.txt +request-url=https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85673 url=https://fedorahosted.org/lohit/ -- To view, visit https://gerrit.wikimedia.org/r/97053 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d3ddcd3c29a0ddc0a90e35010e7d7b22746801c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Arrbee run...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [PEP8] changes - change (pywikibot/compat)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/97194 Change subject: [PEP8] changes .. [PEP8] changes Change-Id: Icb7da4f9edd7c63c80745c12a9024c90b0b3b0d8 --- M copyright_put.py 1 file changed, 70 insertions(+), 45 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/94/97194/1 diff --git a/copyright_put.py b/copyright_put.py index 7e997b1..7141642 100644 --- a/copyright_put.py +++ b/copyright_put.py @@ -9,9 +9,18 @@ # Distributed under the terms of the MIT license. # -import sys, re, codecs, os, time, shutil +import sys +import re +import codecs +import os +import time +import shutil + import wikipedia as pywikibot -import config, date +import config +import date +import catlib +import pagegenerators from copyright import put, join_family_data, appdir, reports_cat @@ -40,10 +49,10 @@ } template_cat = { - '_default': [u'This template is used by copyright.py, a script part of [[:m:Using the python wikipediabot|PyWikipediaBot]].', - u''], - 'it': [u'Questo template è usato dallo script copyright.py del [[:m:Using the python wikipediabot|PyWikipediaBot]].', - u'Template usati da bot'], +'_default': [u'This template is used by copyright.py, a script part of [[:m:Using the python wikipediabot|PyWikipediaBot]].', + u''], +'it': [u'Questo template è usato dallo script copyright.py del [[:m:Using the python wikipediabot|PyWikipediaBot]].', + u'Template usati da bot'], } stat_msg = { @@ -62,41 +71,38 @@ separatorC = re.compile('(?m)^== +') -def get_wiki_save_page(stat_page = False): + +def get_wiki_save_page(stat_page=False): site = pywikibot.getSite() - wiki_save_path = { -'_default': u'User:%s/Report' % config.usernames[site.family.name][site.lang], -'es': u'Usuario:%s/Reporte' % config.usernames[site.family.name][site.lang], +'_default': u'User:%s/Report' % config.usernames[ +site.family.name][site.lang], +'es': u'Usuario:%s/Reporte' % config.usernames[ +site.family.name][site.lang], 'it': u'Utente:RevertBot/Report' } save_path = pywikibot.translate(site, wiki_save_path) - if stat_page: return pywikibot.Page(site, '%s/%s' % (save_path, - pywikibot.translate(site, stat_msg)[0])) - + pywikibot.translate(site, + stat_msg)[0])) if append_date_to_wiki_save_path: t = time.localtime() day = '' if append_day_to_wiki_save_path: day = '_' + str(t[2]) - -save_path += day + '_' + date.monthName(site.language(), t[1]) + '_' + str(t[0]) - +save_path += '%s_%s_%s' % (day, date.monthName(site.language(), t[1]), + str(t[0])) return pywikibot.Page(site, save_path) -def set_template(name = None): +def set_template(name=None): site = pywikibot.getSite() - tcat = pywikibot.translate(site, template_cat) - url = %s://%s%s % (site.protocol(), site.hostname(), site.path()) - botdate = u div style=text-align:right{{{1}}}/divnoinclude%s\n[[%s:%s]]/noinclude % (tcat[0], site.namespace(14), tcat[1]) @@ -108,25 +114,24 @@ if name == 'botdate': p = pywikibot.Page(site, 'Template:botdate') if not p.exists(): -p.put(botdate, comment = 'Init.') - +p.put(botdate, comment='Init.') if name == 'botbox': p = pywikibot.Page(site, 'Template:botbox') if not p.exists(): -p.put(botbox, comment = 'Init.') +p.put(botbox, comment='Init.') + def stat_sum(engine, text): return len(re.findall('(?im)^\*.*?' + engine + '.*?- ', text)) -def get_stats(): -import catlib, pagegenerators +def get_stats(): msg = pywikibot.translate(pywikibot.getSite(), stat_msg) cat = catlib.Category(pywikibot.getSite(), 'Category:%s' % pywikibot.translate(pywikibot.getSite(), reports_cat)) -gen = pagegenerators.CategorizedPageGenerator(cat, recurse = True) +gen = pagegenerators.CategorizedPageGenerator(cat, recurse=True) output = u{| {{prettytable|width=|align=|text-align=left}} ! %s ! %s @@ -135,8 +140,8 @@ ! %s ! %s |- - % ( msg[1], msg[2], msg[3], 'Google', 'Yahoo', 'Live Search' ) -gnt = 0 ; ynt = 0 ; mnt = 0 ; ent = 0 ; sn = 0 ; snt = 0 + % (msg[1], msg[2], msg[3], 'Google', 'Yahoo', 'Live Search') +gnt, ynt, mnt, ent, sn, snt = 0, 0, 0, 0, 0, 0 for page in gen: data = page.get() gn = stat_sum('google', data) @@ -144,7 +149,11 @@ mn = stat_sum('(msn|live)', data) en =
[MediaWiki-commits] [Gerrit] Thanks is not using namespaces - change (mediawiki...Thanks)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/97195 Change subject: Thanks is not using namespaces .. Thanks is not using namespaces Added in 422f0f6062ea57e46fcf7b58ce7121b31fcf3362 Change-Id: I8809348d30fdd8b569affd00cc061de22b38e6dc --- M tests/ApiThankTest.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks refs/changes/95/97195/1 diff --git a/tests/ApiThankTest.php b/tests/ApiThankTest.php index e92efc6..ab1237c 100644 --- a/tests/ApiThankTest.php +++ b/tests/ApiThankTest.php @@ -10,7 +10,7 @@ * * @author Adam Shorland */ -class ApiThankTest extends \ApiTestCase { +class ApiThankTest extends ApiTestCase { public function setUp() { parent::setUp(); -- To view, visit https://gerrit.wikimedia.org/r/97195 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8809348d30fdd8b569affd00cc061de22b38e6dc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Thanks Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [CONFIG] new mw release 1.23wmf4 - change (pywikibot/compat)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/97196 Change subject: [CONFIG] new mw release 1.23wmf4 .. [CONFIG] new mw release 1.23wmf4 Change-Id: Ib54996e9de82e4befc84a464edcd2dae45553a5e --- M family.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/96/97196/1 diff --git a/family.py b/family.py index 56398bd..054afab 100644 --- a/family.py +++ b/family.py @@ -4857,7 +4857,7 @@ Return Wikimedia projects version number as a string. # Don't use this, use versionnumber() instead. This only exists # to not break family files. -return '1.23wmf3' +return '1.23wmf4' def shared_image_repository(self, code): return ('commons', 'commons') -- To view, visit https://gerrit.wikimedia.org/r/97196 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib54996e9de82e4befc84a464edcd2dae45553a5e Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [CONFIG] new mw version 1.23wmf4 - change (pywikibot/core)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/97197 Change subject: [CONFIG] new mw version 1.23wmf4 .. [CONFIG] new mw version 1.23wmf4 Change-Id: I2b44fdc3de2a3c9207562a3eb09f13e70b9d18de --- M pywikibot/family.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/97/97197/1 diff --git a/pywikibot/family.py b/pywikibot/family.py index 71d8a38..8b2dd72 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -1065,7 +1065,7 @@ Return Wikimedia projects version number as a string. # Don't use this, use versionnumber() instead. This only exists # to not break family files. -return '1.23wmf3' +return '1.23wmf4' def shared_image_repository(self, code): return ('commons', 'commons') -- To view, visit https://gerrit.wikimedia.org/r/97197 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2b44fdc3de2a3c9207562a3eb09f13e70b9d18de Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [CONFIG] new mw release 1.23wmf4 - change (pywikibot/compat)
Xqt has submitted this change and it was merged. Change subject: [CONFIG] new mw release 1.23wmf4 .. [CONFIG] new mw release 1.23wmf4 Change-Id: Ib54996e9de82e4befc84a464edcd2dae45553a5e --- M family.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/family.py b/family.py index 56398bd..054afab 100644 --- a/family.py +++ b/family.py @@ -4857,7 +4857,7 @@ Return Wikimedia projects version number as a string. # Don't use this, use versionnumber() instead. This only exists # to not break family files. -return '1.23wmf3' +return '1.23wmf4' def shared_image_repository(self, code): return ('commons', 'commons') -- To view, visit https://gerrit.wikimedia.org/r/97196 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib54996e9de82e4befc84a464edcd2dae45553a5e Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com Gerrit-Reviewer: Xqt i...@gno.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [PEP8] changes - change (pywikibot/compat)
Xqt has submitted this change and it was merged. Change subject: [PEP8] changes .. [PEP8] changes Change-Id: Icb7da4f9edd7c63c80745c12a9024c90b0b3b0d8 --- M copyright_put.py 1 file changed, 70 insertions(+), 45 deletions(-) Approvals: Xqt: Looks good to me, approved diff --git a/copyright_put.py b/copyright_put.py index 7e997b1..7141642 100644 --- a/copyright_put.py +++ b/copyright_put.py @@ -9,9 +9,18 @@ # Distributed under the terms of the MIT license. # -import sys, re, codecs, os, time, shutil +import sys +import re +import codecs +import os +import time +import shutil + import wikipedia as pywikibot -import config, date +import config +import date +import catlib +import pagegenerators from copyright import put, join_family_data, appdir, reports_cat @@ -40,10 +49,10 @@ } template_cat = { - '_default': [u'This template is used by copyright.py, a script part of [[:m:Using the python wikipediabot|PyWikipediaBot]].', - u''], - 'it': [u'Questo template è usato dallo script copyright.py del [[:m:Using the python wikipediabot|PyWikipediaBot]].', - u'Template usati da bot'], +'_default': [u'This template is used by copyright.py, a script part of [[:m:Using the python wikipediabot|PyWikipediaBot]].', + u''], +'it': [u'Questo template è usato dallo script copyright.py del [[:m:Using the python wikipediabot|PyWikipediaBot]].', + u'Template usati da bot'], } stat_msg = { @@ -62,41 +71,38 @@ separatorC = re.compile('(?m)^== +') -def get_wiki_save_page(stat_page = False): + +def get_wiki_save_page(stat_page=False): site = pywikibot.getSite() - wiki_save_path = { -'_default': u'User:%s/Report' % config.usernames[site.family.name][site.lang], -'es': u'Usuario:%s/Reporte' % config.usernames[site.family.name][site.lang], +'_default': u'User:%s/Report' % config.usernames[ +site.family.name][site.lang], +'es': u'Usuario:%s/Reporte' % config.usernames[ +site.family.name][site.lang], 'it': u'Utente:RevertBot/Report' } save_path = pywikibot.translate(site, wiki_save_path) - if stat_page: return pywikibot.Page(site, '%s/%s' % (save_path, - pywikibot.translate(site, stat_msg)[0])) - + pywikibot.translate(site, + stat_msg)[0])) if append_date_to_wiki_save_path: t = time.localtime() day = '' if append_day_to_wiki_save_path: day = '_' + str(t[2]) - -save_path += day + '_' + date.monthName(site.language(), t[1]) + '_' + str(t[0]) - +save_path += '%s_%s_%s' % (day, date.monthName(site.language(), t[1]), + str(t[0])) return pywikibot.Page(site, save_path) -def set_template(name = None): +def set_template(name=None): site = pywikibot.getSite() - tcat = pywikibot.translate(site, template_cat) - url = %s://%s%s % (site.protocol(), site.hostname(), site.path()) - botdate = u div style=text-align:right{{{1}}}/divnoinclude%s\n[[%s:%s]]/noinclude % (tcat[0], site.namespace(14), tcat[1]) @@ -108,25 +114,24 @@ if name == 'botdate': p = pywikibot.Page(site, 'Template:botdate') if not p.exists(): -p.put(botdate, comment = 'Init.') - +p.put(botdate, comment='Init.') if name == 'botbox': p = pywikibot.Page(site, 'Template:botbox') if not p.exists(): -p.put(botbox, comment = 'Init.') +p.put(botbox, comment='Init.') + def stat_sum(engine, text): return len(re.findall('(?im)^\*.*?' + engine + '.*?- ', text)) -def get_stats(): -import catlib, pagegenerators +def get_stats(): msg = pywikibot.translate(pywikibot.getSite(), stat_msg) cat = catlib.Category(pywikibot.getSite(), 'Category:%s' % pywikibot.translate(pywikibot.getSite(), reports_cat)) -gen = pagegenerators.CategorizedPageGenerator(cat, recurse = True) +gen = pagegenerators.CategorizedPageGenerator(cat, recurse=True) output = u{| {{prettytable|width=|align=|text-align=left}} ! %s ! %s @@ -135,8 +140,8 @@ ! %s ! %s |- - % ( msg[1], msg[2], msg[3], 'Google', 'Yahoo', 'Live Search' ) -gnt = 0 ; ynt = 0 ; mnt = 0 ; ent = 0 ; sn = 0 ; snt = 0 + % (msg[1], msg[2], msg[3], 'Google', 'Yahoo', 'Live Search') +gnt, ynt, mnt, ent, sn, snt = 0, 0, 0, 0, 0, 0 for page in gen: data = page.get() gn = stat_sum('google', data) @@ -144,7 +149,11 @@ mn = stat_sum('(msn|live)', data) en = len(re.findall('=== \[\[', data)) sn = len(data) -gnt += gn ; ynt
[MediaWiki-commits] [Gerrit] [CONFIG] new mw version 1.23wmf4 - change (pywikibot/core)
jenkins-bot has submitted this change and it was merged. Change subject: [CONFIG] new mw version 1.23wmf4 .. [CONFIG] new mw version 1.23wmf4 Change-Id: I2b44fdc3de2a3c9207562a3eb09f13e70b9d18de --- M pywikibot/family.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/family.py b/pywikibot/family.py index 71d8a38..8b2dd72 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -1065,7 +1065,7 @@ Return Wikimedia projects version number as a string. # Don't use this, use versionnumber() instead. This only exists # to not break family files. -return '1.23wmf3' +return '1.23wmf4' def shared_image_repository(self, code): return ('commons', 'commons') -- To view, visit https://gerrit.wikimedia.org/r/97197 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b44fdc3de2a3c9207562a3eb09f13e70b9d18de Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com Gerrit-Reviewer: Merlijn van Deen valhall...@arctus.nl Gerrit-Reviewer: Xqt i...@gno.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Enable claims with the same property, but different value fo... - change (pywikibot/core)
Tholam has uploaded a new change for review. https://gerrit.wikimedia.org/r/97198 Change subject: Enable claims with the same property, but different value for claimit.py .. Enable claims with the same property, but different value for claimit.py claimit now adds claims with the same property if they have different values and also checks for duplicate sources. Bug: 54415 Change-Id: I811bf0a88c7e43631e95e9798140ffea401379ca --- M scripts/claimit.py 1 file changed, 19 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/98/97198/1 diff --git a/scripts/claimit.py b/scripts/claimit.py index f326a4c..96a6d20 100755 --- a/scripts/claimit.py +++ b/scripts/claimit.py @@ -76,20 +76,29 @@ else: for claim in self.claims: if claim.getID() in item.get().get('claims'): -pywikibot.output( -u'A claim for %s already exists. Skipping' -% (claim.getID(),)) -#TODO FIXME: This is a very crude way of dupe checking +for existingclaimwithproperty in item.claims[claim]: +if existingclaimwithproperty.getTarget() == claim.getTarget(): +pywikibot.output(item for %s has already property %s with value %s + % (page.title(), claim, existingclaimwithproperty.getTarget())) +break +else: +continue +else: +pywikibot.output('Adding additional %s -- %s' + % (claim.getID(), claim.getTarget())) +item.addClaim(claim) +source = self.getSource(page.site.language()) +if self.source: +if not self.source in claim.getSources(): +claim.addSource(self.source, bot=True) else: -pywikibot.output('Adding %s -- %s' +pywikibot.output('Adding %s -- %s' % (claim.getID(), claim.getTarget())) item.addClaim(claim) -# A generator might yield pages from multiple languages source = self.getSource(page.site.language()) -if source: -claim.addSource(source, bot=True) -# TODO FIXME: We need to check that we aren't adding a -# duplicate +if self.source: +if not self.source in claim.getSources(): +claim.addSource(self.source, bot=True) def main(): -- To view, visit https://gerrit.wikimedia.org/r/97198 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I811bf0a88c7e43631e95e9798140ffea401379ca Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Tholam t@lamsinfosystem.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Mark ApiThank as requiring write - change (mediawiki...Thanks)
Mattflaschen has uploaded a new change for review. https://gerrit.wikimedia.org/r/97199 Change subject: Mark ApiThank as requiring write .. Mark ApiThank as requiring write Change-Id: Ic6bc0ec65ed0b39114f12a41551c25898d784110 --- M ApiThank.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks refs/changes/99/97199/1 diff --git a/ApiThank.php b/ApiThank.php index 7febee5..473b6d8 100644 --- a/ApiThank.php +++ b/ApiThank.php @@ -115,6 +115,11 @@ return true; } + // Writes to the Echo database and sometimes log tables. + public function isWriteMode() { + return true; + } + public function getTokenSalt() { return ''; } -- To view, visit https://gerrit.wikimedia.org/r/97199 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6bc0ec65ed0b39114f12a41551c25898d784110 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Thanks Gerrit-Branch: master Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [CONFIG] update namespace alias for ang-wiki - change (pywikibot/compat)
Xqt has submitted this change and it was merged. Change subject: [CONFIG] update namespace alias for ang-wiki .. [CONFIG] update namespace alias for ang-wiki Change-Id: Idf2d719696a1fad6bb1c88f3c9c1567103fefb22 --- M families/wikipedia_family.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/families/wikipedia_family.py b/families/wikipedia_family.py index 5e22feb..f21ac5f 100644 --- a/families/wikipedia_family.py +++ b/families/wikipedia_family.py @@ -89,7 +89,7 @@ 'als': u'Wikipedia', 'am': u'ውክፔዲያ', 'an': u'Wikipedia', -'ang': u'Wikipedia', +'ang': [u'Wikipǣdia', u'Wikipaedia', u'Wikipedia'], 'ar': [u'ويكيبيديا', u'وب'], 'arc': [u'ܘܝܩܝܦܕܝܐ', u'Wikipedia'], 'arz': u'ويكيبيديا', @@ -369,7 +369,7 @@ 'als': u'Wikipedia Diskussion', 'am': u'ውክፔዲያ ውይይት', 'an': u'Descusión Wikipedia', -'ang': u'Wikipedia talk', +'ang': [u'Wikipǣdiamōtung', u'Wikipaediamotung', u'Wikipædiamotung'], 'ar': [u'نقاش ويكيبيديا', u'نو'], 'arc': u'ܡܡܠܠܐ ܕܘܝܩܝܦܕܝܐ', 'arz': u'نقاش ويكيبيديا', -- To view, visit https://gerrit.wikimedia.org/r/97200 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf2d719696a1fad6bb1c88f3c9c1567103fefb22 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de Gerrit-Reviewer: Xqt i...@gno.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [CONFIG] update namespace alias for ang-wiki - change (pywikibot/compat)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/97200 Change subject: [CONFIG] update namespace alias for ang-wiki .. [CONFIG] update namespace alias for ang-wiki Change-Id: Idf2d719696a1fad6bb1c88f3c9c1567103fefb22 --- M families/wikipedia_family.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/00/97200/1 diff --git a/families/wikipedia_family.py b/families/wikipedia_family.py index 5e22feb..f21ac5f 100644 --- a/families/wikipedia_family.py +++ b/families/wikipedia_family.py @@ -89,7 +89,7 @@ 'als': u'Wikipedia', 'am': u'ውክፔዲያ', 'an': u'Wikipedia', -'ang': u'Wikipedia', +'ang': [u'Wikipǣdia', u'Wikipaedia', u'Wikipedia'], 'ar': [u'ويكيبيديا', u'وب'], 'arc': [u'ܘܝܩܝܦܕܝܐ', u'Wikipedia'], 'arz': u'ويكيبيديا', @@ -369,7 +369,7 @@ 'als': u'Wikipedia Diskussion', 'am': u'ውክፔዲያ ውይይት', 'an': u'Descusión Wikipedia', -'ang': u'Wikipedia talk', +'ang': [u'Wikipǣdiamōtung', u'Wikipaediamotung', u'Wikipædiamotung'], 'ar': [u'نقاش ويكيبيديا', u'نو'], 'arc': u'ܡܡܠܠܐ ܕܘܝܩܝܦܕܝܐ', 'arz': u'نقاش ويكيبيديا', -- To view, visit https://gerrit.wikimedia.org/r/97200 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf2d719696a1fad6bb1c88f3c9c1567103fefb22 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt i...@gno.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Mark ApiThank as requiring write - change (mediawiki...Thanks)
jenkins-bot has submitted this change and it was merged. Change subject: Mark ApiThank as requiring write .. Mark ApiThank as requiring write Change-Id: Ic6bc0ec65ed0b39114f12a41551c25898d784110 --- M ApiThank.php 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/ApiThank.php b/ApiThank.php index 7febee5..473b6d8 100644 --- a/ApiThank.php +++ b/ApiThank.php @@ -115,6 +115,11 @@ return true; } + // Writes to the Echo database and sometimes log tables. + public function isWriteMode() { + return true; + } + public function getTokenSalt() { return ''; } -- To view, visit https://gerrit.wikimedia.org/r/97199 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6bc0ec65ed0b39114f12a41551c25898d784110 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Thanks Gerrit-Branch: master Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org Gerrit-Reviewer: EBernhardson ebernhard...@wikimedia.org Gerrit-Reviewer: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: Mattflaschen mflasc...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits