[MediaWiki-commits] [Gerrit] Load module 'ext.wikiEditor.toolbar.styles' - change (mediawiki...CodeEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218820
Change subject: Load module 'ext.wikiEditor.toolbar.styles'
..
Load module 'ext.wikiEditor.toolbar.styles'
This style module hides the old toolbar while loading and
avoids horizontal resize of the textarea with disabled syntax highlight.
Bug: T102738
Bug: T102739
Change-Id: I41f16f1a5034eeebf7b80a68ebded8a4442df8fa
---
M CodeEditor.hooks.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor
refs/changes/20/218820/1
diff --git a/CodeEditor.hooks.php b/CodeEditor.hooks.php
index 8bc5d9d..3aa0f4d 100644
--- a/CodeEditor.hooks.php
+++ b/CodeEditor.hooks.php
@@ -36,6 +36,7 @@
}
public static function editPageShowEditFormInitial( $editpage, $output
) {
+ $output-addModuleStyles( 'ext.wikiEditor.toolbar.styles' );
$lang = self::getPageLanguage( $editpage-getContextTitle() );
if ( $lang $output-getUser()-getOption( 'usebetatoolbar' )
) {
$output-addModules( 'ext.codeEditor' );
--
To view, visit https://gerrit.wikimedia.org/r/218820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41f16f1a5034eeebf7b80a68ebded8a4442df8fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Repair search button - change (mediawiki...CodeEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218385
Change subject: Repair search button
..
Repair search button
Bug: T102486
Change-Id: I452147dd12ff46e08fbce0646090f979510ae3f8
---
M modules/jquery.codeEditor.js
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor
refs/changes/85/218385/1
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index cef2f21..101c31d 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -56,7 +56,6 @@
context.showInvisibleChars = ( cookieEnabled === 1 );
cookieEnabled = parseInt( mw.cookie.get( 'codeEditor-' +
context.instance + '-lineWrappingActive' ), 10 );
context.lineWrappingActive = ( cookieEnabled === 1 );
- context.showSearchReplace = 0;
/*
* Event Handlers
@@ -165,12 +164,10 @@
context.codeEditor.setShowInvisibles(
context.showInvisibleChars );
};
toggleSearchReplace = function ( context ) {
- context.showSearchReplace =
!context.showSearchReplace;
-
- if ( context.showSearchReplace ) {
+ if ( !context.codeEditor.searchBox ||
!context.codeEditor.searchBox.isFocused() ) {
ace.config.loadModule(
'ace/ext/searchbox', function ( e ) {
//
ace.editor.searchBox.show();
- e.Search(
context.codeEditor, !0 );
+ e.Search(
context.codeEditor );
} );
} else {
context.codeEditor.searchBox.hide();
--
To view, visit https://gerrit.wikimedia.org/r/218385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I452147dd12ff46e08fbce0646090f979510ae3f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add help link - change (mediawiki...AbuseFilter)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217517
Change subject: Add help link
..
Add help link
Change-Id: I086188855d76e047c0d201ee967231561ecad5d1
---
M special/SpecialAbuseFilter.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter
refs/changes/17/217517/1
diff --git a/special/SpecialAbuseFilter.php b/special/SpecialAbuseFilter.php
index e8574fd..42b7c9c 100644
--- a/special/SpecialAbuseFilter.php
+++ b/special/SpecialAbuseFilter.php
@@ -61,6 +61,7 @@
if ( $subpage == 'tools' ) {
$view = 'AbuseFilterViewTools';
$pageType = 'tools';
+ $out-addHelpLink( 'Extension:AbuseFilter/Rules format'
);
}
if ( count( $params ) == 2 $params[0] == 'revert'
is_numeric( $params[1] ) ) {
@@ -72,11 +73,13 @@
if ( count( $params ) $params[0] == 'test' ) {
$view = 'AbuseFilterViewTestBatch';
$pageType = 'test';
+ $out-addHelpLink( 'Extension:AbuseFilter/Rules format'
);
}
if ( count( $params ) $params[0] == 'examine' ) {
$view = 'AbuseFilterViewExamine';
$pageType = 'examine';
+ $out-addHelpLink( 'Extension:AbuseFilter/Rules format'
);
}
if ( !empty( $params[0] ) ( $params[0] == 'history' ||
$params[0] == 'log' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/217517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I086188855d76e047c0d201ee967231561ecad5d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: He7d3r he7...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a link to Special:Tags - change (mediawiki...AbuseFilter)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/217500 Change subject: Add a link to Special:Tags .. Add a link to Special:Tags Change-Id: I05b381aeb43531b2a0fd797523d8a63acd5f3cc3 --- M i18n/en.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter refs/changes/00/217500/1 diff --git a/i18n/en.json b/i18n/en.json index bd45ae7..f10ddde 100755 --- a/i18n/en.json +++ b/i18n/en.json @@ -164,7 +164,7 @@ abusefilter-edit-warn-actions: Actions:, abusefilter-edit-warn-preview: Preview selected message, abusefilter-edit-warn-edit: Create/Edit selected message, - abusefilter-edit-tag-tag: Tags to apply (one per line):, + abusefilter-edit-tag-tag: [[Special:Tags|Tags]] to apply (one per line):, abusefilter-edit-denied: You may not view details of this filter, because it is hidden from public view., abusefilter-edit-main: Filter parameters, abusefilter-edit-done-subtitle: Filter edited, -- To view, visit https://gerrit.wikimedia.org/r/217500 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05b381aeb43531b2a0fd797523d8a63acd5f3cc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: He7d3r he7...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improve readability of license text in save dialog - change (mediawiki...VisualEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216959
Change subject: Improve readability of license text in save dialog
..
Improve readability of license text in save dialog
Previously, it failed in WCAG contrast ratio tests. To make
it pass, font size has been slightly increased and color
has been darkened.
Bug: T100017
Change-Id: I073ca96c64d5e3af3c01936d34e9e83e9384b4b5
---
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/59/216959/1
diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
index 53f628e..4cc2bfb 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
@@ -60,9 +60,9 @@
}
.ve-ui-mwSaveDialog-license {
- font-size: 0.85em;
+ font-size: 0.9em;
line-height: 1.25em;
padding: 0;
margin: 0;
- color: #999;
+ color: #535353;
}
--
To view, visit https://gerrit.wikimedia.org/r/216959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I073ca96c64d5e3af3c01936d34e9e83e9384b4b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Glaisher glaisher.w...@gmail.com
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] making displaying reference group names optional When refere... - change (mediawiki...Cite)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216698
Change subject: making displaying reference group names optional When reference
group names are used, the reference will show up with the reference group name
in square brackets. This patch introduces an additional variable to allow for
this behavior to be turned off via
..
making displaying reference group names optional
When reference group names are used, the reference will show up with the
reference group name in square brackets. This patch introduces an additional
variable to allow for this behavior to be turned off via LocalSettings.php. The
default behavior will not change.
See https://phabricator.wikimedia.org/T94410 for details.
Change-Id: I1d6c1748f682670bced3b8e50c7df917eafef6a9
---
M Cite_body.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite
refs/changes/98/216698/1
diff --git a/Cite_body.php b/Cite_body.php
index 64e2865..315505d 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -838,6 +838,7 @@
*/
function linkRef( $group, $key, $count = null, $label = null, $subkey =
'' ) {
global $wgContLang;
+ global $wgCiteShowGroupNames;
$label = is_null( $label ) ? ++$this-mGroupCnt[$group] :
$label;
return
@@ -847,7 +848,7 @@
$this-refKey( $key, $count ),
$this-referencesKey( $key . $subkey ),
$this-getLinkLabel( $label, $group,
- ( ( $group ==
self::DEFAULT_GROUP ) ? '' : $group ) . $wgContLang-formatNum( $label ) )
+ ( ( $group ==
self::DEFAULT_GROUP || !$wgCiteShowGroupNames ) ? '' : $group ) .
$wgContLang-formatNum( $label ) )
)-inContentLanguage()-plain()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/216698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6c1748f682670bced3b8e50c7df917eafef6a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix T56548, regex failure in _getUserDataOld(). - change (pywikibot/compat)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/215587 Change subject: Fix T56548, regex failure in _getUserDataOld(). .. Fix T56548, regex failure in _getUserDataOld(). Change-Id: I675a5ad3960d4407d57f423ae07cdaa77ac2ca22 --- M wikipedia.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/87/215587/1 diff --git a/wikipedia.py b/wikipedia.py index 3f3496a..a069c69 100644 --- a/wikipedia.py +++ b/wikipedia.py @@ -7508,7 +7508,7 @@ # Search for a token tokenR = re.compile( -r\input type='hidden' value=\(.*?)\ name=\wpEditToken\) +r\input type=\hidden\ value=\(.*?)\ name=\wpEditToken\) tokenloc = tokenR.search(text) if tokenloc: self._token[index] = tokenloc.group(1) -- To view, visit https://gerrit.wikimedia.org/r/215587 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I675a5ad3960d4407d57f423ae07cdaa77ac2ca22 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Alex S.H. Lin ale...@mail2000.com.tw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix to digits grouping rule - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214902
Change subject: Fix to digits grouping rule
..
Fix to digits grouping rule
Avoid grouping in negative numbers too.
Following the example of LanguagePl.php
Bug: T94300
Change-Id: Ib96616497507c9347cc72f894243b583619c2b11
---
M languages/classes/LanguageEt.php
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/02/214902/1
diff --git a/languages/classes/LanguageEt.php b/languages/classes/LanguageEt.php
index 6425a53..759531b 100644
--- a/languages/classes/LanguageEt.php
+++ b/languages/classes/LanguageEt.php
@@ -1,6 +1,6 @@
?php
/**
- * Estonian (Eesti) specific code.
+ * Estonian (eesti) specific code.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -22,20 +22,18 @@
*/
/**
- * Estonian (Eesti)
+ * Estonian (eesti)
*
* @ingroup Language
*/
class LanguageEt extends Language {
/**
-* Avoid grouping whole numbers between 0 to
-*
+* Avoid grouping whole numbers between - to
* @param string $_
-*
* @return string
*/
function commafy( $_ ) {
- if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
+ if ( !preg_match( '/^\-?\d{1,4}(\.\d+)?$/', $_ ) ) {
return strrev( (string)preg_replace(
'/(\d{3})(?=\d)(?!\d*\.)/', '$1,', strrev( $_ ) ) );
} else {
return $_;
--
To view, visit https://gerrit.wikimedia.org/r/214902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib96616497507c9347cc72f894243b583619c2b11
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Tests: Added require_once OAuthAuthDBTest.php and @group Dat... - change (mediawiki...OAuthAuthentication)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214811
Change subject: Tests: Added require_once OAuthAuthDBTest.php and @group
Database
..
Tests: Added require_once OAuthAuthDBTest.php and @group Database
* Added require_once __DIR__ . '/OAuthAuthDBTest.php'; to tests with a
subclass of OAuthAuthDBTest to fix Class not found errors
* Also added @group Database to tests that interfere with the database to
ensure they are not ran by 'make databaseless'
This does not fix Table doesn't exist error in Parser tests
Bug: T100870
Change-Id: I2f4ca1e54de87abbc8bf3c4a87464d3efda4d39a
---
M tests/OAuthAuthConfigTest.php
M tests/OAuthAuthDBTest.php
M tests/OAuthAuthExternalUserTest.php
M tests/OAuthAuthHooksTest.php
4 files changed, 11 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication
refs/changes/11/214811/1
diff --git a/tests/OAuthAuthConfigTest.php b/tests/OAuthAuthConfigTest.php
index 07a87b2..ae00def 100644
--- a/tests/OAuthAuthConfigTest.php
+++ b/tests/OAuthAuthConfigTest.php
@@ -1,4 +1,7 @@
?php
+
+require_once __DIR__ . '/OAuthAuthDBTest.php';
+
/**
* @group OAuthAuthentication
*/
diff --git a/tests/OAuthAuthDBTest.php b/tests/OAuthAuthDBTest.php
index 8080ceb..52cc509 100644
--- a/tests/OAuthAuthDBTest.php
+++ b/tests/OAuthAuthDBTest.php
@@ -1,5 +1,6 @@
?php
/**
+ * @group Database
* @group OAuthAuthentication
*/
class OAuthAuthDBTest extends MediaWikiTestCase {
diff --git a/tests/OAuthAuthExternalUserTest.php
b/tests/OAuthAuthExternalUserTest.php
index d739b28..1298924 100644
--- a/tests/OAuthAuthExternalUserTest.php
+++ b/tests/OAuthAuthExternalUserTest.php
@@ -1,5 +1,9 @@
?php
+
+require_once __DIR__ . '/OAuthAuthDBTest.php';
+
/**
+ * @group Database
* @group OAuthAuthentication
*/
class OAuthAuthExternalUserTest extends OAuthAuthDBTest {
diff --git a/tests/OAuthAuthHooksTest.php b/tests/OAuthAuthHooksTest.php
index b3b8735..6aea751 100644
--- a/tests/OAuthAuthHooksTest.php
+++ b/tests/OAuthAuthHooksTest.php
@@ -1,4 +1,7 @@
?php
+
+require_once __DIR__ . '/OAuthAuthDBTest.php';
+
/**
* @group OAuthAuthentication
*/
--
To view, visit https://gerrit.wikimedia.org/r/214811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f4ca1e54de87abbc8bf3c4a87464d3efda4d39a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Zhuyifei1999 zhuyifei1...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add HTML attributes lang and dir to toctitle - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/214649 Change subject: Add HTML attributes lang and dir to toctitle .. Add HTML attributes lang and dir to toctitle The toctitle is in user interface language. This change add the HTML attributes lang and dir to the toctitle. This allows to copy (a part of) the rendered HTML to a word processing and the language for spell checking has the right language. Change-Id: I17730869f81744560672d7d0acb67ced71e69c4e --- M includes/Linker.php 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/49/214649/1 diff --git a/includes/Linker.php b/includes/Linker.php index 4a1aa87..6c4b060 100644 --- a/includes/Linker.php +++ b/includes/Linker.php @@ -1699,7 +1699,12 @@ $title = wfMessage( 'toc' )-inLanguage( $lang )-escaped(); return 'div id=toc class=toc' - . 'div id=toctitleh2' . $title . /h2/div\n + . Html::openElement( 'div', array( + 'id' = 'toctitle', + 'lang' = $lang-getHtmlCode(), + 'dir' = $lang-getDir(), + ) ) + . 'h2' . $title . /h2/div\n . $toc . /ul\n/div\n; } -- To view, visit https://gerrit.wikimedia.org/r/214649 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17730869f81744560672d7d0acb67ced71e69c4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added a space - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213558
Change subject: Added a space
..
Added a space
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Recentchanges-legend-heading/en
Change-Id: Icaa93495cc51f297a46c6ffaa1816f2a11639b3c
---
M languages/i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/58/213558/1
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 9ad4d55..aebd18a 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1230,7 +1230,7 @@
recentchanges-label-bot: This edit was performed by a bot,
recentchanges-label-unpatrolled: This edit has not yet been
patrolled,
recentchanges-label-plusminus: The page size changed by this number
of bytes,
- recentchanges-legend-heading: '''Legend:''',
+ recentchanges-legend-heading: '''Legend:nbsp;''',
recentchanges-legend-newpage: {{int:recentchanges-label-newpage}}
(also see [[Special:NewPages|list of new pages]]),
recentchanges-legend-minor: {{int:recentchanges-label-minor}},
recentchanges-legend-bot: {{int:recentchanges-label-bot}},
--
To view, visit https://gerrit.wikimedia.org/r/213558
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaa93495cc51f297a46c6ffaa1816f2a11639b3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove unused parameter lang from $.wikiEditor.auto* functions - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213600
Change subject: Remove unused parameter lang from $.wikiEditor.auto* functions
..
Remove unused parameter lang from $.wikiEditor.auto* functions
Change-Id: I71680155b668b6e87be909d2b765f9cbed064bbf
---
M modules/jquery.wikiEditor.js
1 file changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/00/213600/1
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 7c8e4c3..a96b7fa 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -165,11 +165,10 @@
* with a default.
*
* @param object Object to extract property from
-* @param lang Language code, defaults to wgUserLanguage
*/
- autoLang: function ( object, lang ) {
- var defaultKey = $( 'body' ).hasClass( 'rtl' ) ? 'default-rtl'
: 'default';
- lang = lang || mw.config.get( 'wgUserLanguage' );
+ autoLang: function ( object ) {
+ var defaultKey = $( 'body' ).hasClass( 'rtl' ) ? 'default-rtl'
: 'default',
+ lang = mw.config.get( 'wgUserLanguage' );
return hasOwn.call( object, lang ) ? object[lang] : (
object[defaultKey] || object['default'] || object );
},
@@ -179,10 +178,9 @@
*
* @param icon Icon object from e.g. toolbar config
* @param path Default icon path, defaults to $.wikiEditor.imgPath
-* @param lang Language code, defaults to wgUserLanguage
*/
- autoIcon: function ( icon, path, lang ) {
- var src = $.wikiEditor.autoLang( icon, lang );
+ autoIcon: function ( icon, path ) {
+ var src = $.wikiEditor.autoLang( icon );
path = path || $.wikiEditor.imgPath;
// Prepend path if src is not absolute
if ( src.substr( 0, 7 ) !== 'http://' src.substr( 0, 8 ) !==
'https://' src[0] !== '/' ) {
@@ -197,16 +195,15 @@
* @param icon Icon object, see autoIcon()
* @param offset Offset object
* @param path Icon path, see autoIcon()
-* @param lang Language code, defaults to wgUserLanguage
*/
- autoIconOrOffset: function ( icon, offset, path, lang ) {
- lang = lang || mw.config.get( 'wgUserLanguage' );
+ autoIconOrOffset: function ( icon, offset, path ) {
+ var lang = mw.config.get( 'wgUserLanguage' );
if ( typeof offset === 'object' hasOwn.call( offset, lang )
) {
return offset[lang];
} else if ( typeof icon === 'object' hasOwn.call( icon, lang
) ) {
- return $.wikiEditor.autoIcon( icon, undefined, lang );
+ return $.wikiEditor.autoIcon( icon );
} else {
- return $.wikiEditor.autoLang( offset, lang );
+ return $.wikiEditor.autoLang( offset );
}
}
};
--
To view, visit https://gerrit.wikimedia.org/r/213600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71680155b668b6e87be909d2b765f9cbed064bbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.js: Handle IE9 like IE10 and above for style loading - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213778
Change subject: mediawiki.js: Handle IE9 like IE10 and above for style loading
..
mediawiki.js: Handle IE9 like IE10 and above for style loading
Bug: T93319
Change-Id: Ibcdb9ea984d543db8cb92e6ecb589c72147dbe9f
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/78/213778/1
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index f2b4b00..4df7398 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -866,9 +866,9 @@
// By default, always create a new style.
Appending text to a style
// tag is bad as it means the contents have to
be re-parsed (bug 45810).
//
- // Except, of course, in IE 9 and below. In
there we default to re-using and
+ // Except, of course, in IE 8 and below. In
there we default to re-using and
// appending to a style tag due to the IE
stylesheet limit (bug 31676).
- if ( 'documentMode' in document
document.documentMode = 9 ) {
+ if ( 'documentMode' in document
document.documentMode = 8 ) {
$style = getMarker().prev();
// Verify that the element before the
marker actually is a
--
To view, visit https://gerrit.wikimedia.org/r/213778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcdb9ea984d543db8cb92e6ecb589c72147dbe9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add Portuguese translation - change (labs...crosswatch)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213335
Change subject: Add Portuguese translation
..
Add Portuguese translation
Also fix a typo in the English translation.
Change-Id: Ia5edaf9ccaef1c7249d1b941c9d153a3bbef0287
---
M frontend/src/i18n/locale-en.json
A frontend/src/i18n/locale-pt.json
2 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/crosswatch
refs/changes/35/213335/1
diff --git a/frontend/src/i18n/locale-en.json b/frontend/src/i18n/locale-en.json
index 2704c57..78aaff3 100644
--- a/frontend/src/i18n/locale-en.json
+++ b/frontend/src/i18n/locale-en.json
@@ -7,7 +7,7 @@
DESCRIPTION: An enhanced watchlist for Wikimedia projects.,
SIGN_IN_BUTTON: Sign in with OAuth,
SEARCH: Search,
- SIGNED_IN_MSG: Welcome {{username}}, you are signed in. It may take a bit
until your watchlist ist fully loaded.,
+ SIGNED_IN_MSG: Welcome {{username}}, you are signed in. It may take a bit
until your watchlist is fully loaded.,
MINOREDIT_FLAG: m,
BOTEDIT_FLAG: b,
NEWPAGE_FLAG: N
diff --git a/frontend/src/i18n/locale-pt.json b/frontend/src/i18n/locale-pt.json
new file mode 100644
index 000..1b90f32
--- /dev/null
+++ b/frontend/src/i18n/locale-pt.json
@@ -0,0 +1,14 @@
+{
+ DOCUMENTATION: Documentação,
+ TALK: Discussão,
+ REPORT_BUGS: Relato de erros,
+ SIGN_IN: Entrar,
+ SIGN_OUT: Sair,
+ DESCRIPTION: Uma lista de páginas vigiadas aprimorada para os projetos
Wikimedia.,
+ SIGN_IN_BUTTON: Enrar com OAuth,
+ SEARCH: Pesquisa,
+ SIGNED_IN_MSG: Bem-vindo(a) {{username}}, você já está conectado. Pode
levar algum tempo até que a sua lista de páginas vigiadas seja completamente
carregada.,
+ MINOREDIT_FLAG: m,
+ BOTEDIT_FLAG: b,
+ NEWPAGE_FLAG: N
+}
--
To view, visit https://gerrit.wikimedia.org/r/213335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5edaf9ccaef1c7249d1b941c9d153a3bbef0287
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/crosswatch
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: He7d3r he7...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Minor header fixes for Typography Refresh - change (mediawiki...Vector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212889
Change subject: Minor header fixes for Typography Refresh
..
Minor header fixes for Typography Refresh
This fixes top-margin for H1 inside .mw-body-content, and increase
font-size for H3 from 1.17em to 1.2em (bumping to 17px default).
Final patch for this bug.
Bug: T66653
Change-Id: I1e75bc4fc3e04ca6c9238d4ce116136e9bafacd1
---
M components/common.less
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/89/212889/1
diff --git a/components/common.less b/components/common.less
index 088b373..9308861 100644
--- a/components/common.less
+++ b/components/common.less
@@ -60,6 +60,11 @@
h1 {
font-size: @content-heading-font-size;
}
+ .mw-body-content {
+ h1 {
+ margin-top: 1em;
+ }
+ }
h2 {
font-size: 1.5em;
@@ -77,7 +82,7 @@
}
h3 {
- font-size: 1.17em;
+ font-size: 1.2em;
}
h3,
--
To view, visit https://gerrit.wikimedia.org/r/212889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e75bc4fc3e04ca6c9238d4ce116136e9bafacd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Edokter er...@darcoury.nl
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] SpecialOAuthLogin.php/init: Removing !$status-isGood() erro... - change (mediawiki...OAuthAuthentication)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212785
Change subject: SpecialOAuthLogin.php/init: Removing !$status-isGood() error
handling
..
SpecialOAuthLogin.php/init: Removing !$status-isGood() error handling
$status is not defined within init subpage
Bug: T100020
Change-Id: I5a6ccab4c89912cffe54b51e20a0e2bf4165c3bd
---
M specials/SpecialOAuthLogin.php
1 file changed, 0 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication
refs/changes/85/212785/1
diff --git a/specials/SpecialOAuthLogin.php b/specials/SpecialOAuthLogin.php
index c427e7a..010ce0b 100644
--- a/specials/SpecialOAuthLogin.php
+++ b/specials/SpecialOAuthLogin.php
@@ -50,9 +50,6 @@
} catch ( Exception $e ) {
throw new \ErrorPageError(
'oauthauth-error', $e-getMessage() );
}
- if ( !$status-isGood() ) {
- throw new \ErrorPageError(
'oauthauth-error', $status-getMessage() );
- }
break;
case 'finish':
--
To view, visit https://gerrit.wikimedia.org/r/212785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a6ccab4c89912cffe54b51e20a0e2bf4165c3bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Zhuyifei1999 zhuyifei1...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix some warnings spotted by JSLint - change (mediawiki...FlaggedRevs)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212589
Change subject: Fix some warnings spotted by JSLint
..
Fix some warnings spotted by JSLint
* Remove variable fr.
* Declare variables at the begin of the function. (partially)
* Use {} around if then else statements.
Todo:
* Reorder functions to prevent forward references.
This will be done in a separate change for better diff.
Change-Id: I3ea968a6d794dc4cc83bffb6a9306f30642f1ccd
---
M frontend/modules/ext.flaggedRevs.advanced.js
M frontend/modules/ext.flaggedRevs.review.js
2 files changed, 98 insertions(+), 97 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/89/212589/1
diff --git a/frontend/modules/ext.flaggedRevs.advanced.js
b/frontend/modules/ext.flaggedRevs.advanced.js
index d941800..aa12278 100644
--- a/frontend/modules/ext.flaggedRevs.advanced.js
+++ b/frontend/modules/ext.flaggedRevs.advanced.js
@@ -6,26 +6,26 @@
( function ( mw, $ ) {
use strict;
-var fr = {
/* Dropdown collapse timer */
- boxCollapseTimer: null,
+ var boxCollapseTimer = null;
+
/* Startup function */
- init: function () {
+ function init() {
// Enables rating detail box
var toggle = $( '#mw-fr-revisiontoggle' );
if ( toggle.length ) {
toggle.css( 'display', 'inline' ); // show toggle
control
- fr.hideBoxDetails(); // hide the initially displayed
ratings
+ hideBoxDetails(); // hide the initially displayed
ratings
}
// Bar UI: Toggle the box when the toggle is clicked
- $( '.fr-toggle-symbol#mw-fr-revisiontoggle' ).click(
fr.toggleBoxDetails );
+ $( '.fr-toggle-symbol#mw-fr-revisiontoggle' ).click(
toggleBoxDetails );
// Simple UI: Show the box on mouseOver
- $( '.fr-toggle-arrow#mw-fr-revisiontoggle' ).mouseover(
fr.onBoxMouseOver );
- $( '.flaggedrevs_short#mw-fr-revisiontag' ).mouseout(
fr.onBoxMouseOut );
+ $( '.fr-toggle-arrow#mw-fr-revisiontoggle' ).mouseover(
onBoxMouseOver );
+ $( '.flaggedrevs_short#mw-fr-revisiontag' ).mouseout(
onBoxMouseOut );
// Enables diff detail box and toggle
toggle = $( '#mw-fr-difftoggle' );
@@ -33,7 +33,7 @@
toggle.css( 'display', 'inline' ); // show toggle
control
$( '#mw-fr-stablediff' ).hide();
}
- toggle.children( 'a' ).click( fr.toggleDiff );
+ toggle.children( 'a' ).click( toggleDiff );
// Enables log detail box and toggle
toggle = $( '#mw-fr-logtoggle' );
@@ -41,67 +41,67 @@
toggle.css( 'display', 'inline' ); // show toggle
control
$( '#mw-fr-logexcerpt' ).hide();
}
- toggle.children( 'a' ).click( fr.toggleLog );
+ toggle.children( 'a' ).click( toggleLog );
// Enables changing of save button when review this checkbox
changes
- $( '#wpReviewEdit' ).click( fr.updateSaveButton );
- },
+ $( '#wpReviewEdit' ).click( updateSaveButton );
+ }
/* Expands flag info box details */
- showBoxDetails: function () {
+ function showBoxDetails() {
$( '#mw-fr-revisiondetails' ).css( 'display', 'block' );
- },
+ }
/* Collapses flag info box details */
- hideBoxDetails: function () {
+ function hideBoxDetails() {
$( '#mw-fr-revisiondetails' ).css( 'display', 'none' );
- },
+ }
/**
* Toggles flag info box details for (+/-) control
* @context {jQuery}
* @param e {jQuery.Event}
*/
- toggleBoxDetails: function () {
+ function toggleBoxDetails() {
var toggle = $( '#mw-fr-revisiontoggle' ),
ratings = $( '#mw-fr-revisiondetails' );
if ( toggle.length ratings.length ) {
// Collapsed - expand
if ( ratings.css( 'display' ) === 'none' ) {
- fr.showBoxDetails();
+ showBoxDetails();
toggle.text( mw.msg( 'revreview-toggle-hide' )
);
// Expanded - collapse
} else {
- fr.hideBoxDetails();
+ hideBoxDetails();
toggle.text( mw.msg( 'revreview-toggle-show' )
);
}
}
- },
+ }
/**
* Expands flag info box details on
[MediaWiki-commits] [Gerrit] Use .prop according to jQuery doc - change (mediawiki...FlaggedRevs)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211941
Change subject: Use .prop according to jQuery doc
..
Use .prop according to jQuery doc
Use .prop( 'disabled', true ) instead of .prop( 'disabled', 'disabled' )
See https://api.jquery.com/prop/
Change-Id: Ied516beedaf2d32b34594cd6e186752f32dd1f38
---
M frontend/modules/ext.flaggedRevs.review.js
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/41/211941/1
diff --git a/frontend/modules/ext.flaggedRevs.review.js
b/frontend/modules/ext.flaggedRevs.review.js
index 05b9402..34d842d 100644
--- a/frontend/modules/ext.flaggedRevs.review.js
+++ b/frontend/modules/ext.flaggedRevs.review.js
@@ -26,7 +26,7 @@
/*global jsReviewNeedsChange*/
// wtf? this is set in frontend/RevisionReviewFormUI by
outputting JS
if ( typeof jsReviewNeedsChange !== 'undefined'
jsReviewNeedsChange === 1 ) {
- $( '#mw-fr-submit-accept' ).prop( 'disabled',
'disabled' );
+ $( '#mw-fr-submit-accept' ).prop( 'disabled', true );
}
// Setup select form option colors
@@ -96,7 +96,7 @@
// (a) If only a few levels are zero (incomplete) then
disable submission.
// (b) Re-enable submission for already accepted revs when
ratings change.
$( '#mw-fr-submit-accept' )
- .prop( 'disabled', somezero ? 'disabled' : '' )
+ .prop( 'disabled', somezero )
.val( mw.msg( 'revreview-submit-review' ) ); // reset
to Accept
// Update colors of select
@@ -125,7 +125,7 @@
* Lock review form from submissions (using during AJAX requests)
*/
'lockReviewForm': function ( form ) {
- form.find( 'input,textarea,select' ).prop( 'disabled',
'disabled' );
+ form.find( 'input,textarea,select' ).prop( 'disabled', true );
},
/*
@@ -135,12 +135,12 @@
var i, inputs = form.find( 'input' );
for ( i = 0; i inputs.length; i++ ) {
if ( inputs.eq( i ).prop( 'type' ) !== 'submit' ) { //
not all buttons can be enabled
- inputs.eq( i ).prop( 'disabled', '' );
+ inputs.eq( i ).prop( 'disabled', false );
} else {
inputs.eq( i ).blur(); // focus off element
(bug 24013)
}
}
- form.find( 'textarea,select' ).prop( 'disabled', '' );
+ form.find( 'textarea,select' ).prop( 'disabled', false );
},
/*
@@ -240,8 +240,8 @@
usubmit.val( mw.msg(
'revreview-submit-unreview' ) );
usubmit.css( 'fontWeight', '' ); //
back to normal
usubmit.show(); // now available
- usubmit.prop( 'disabled', '' ); //
unlock
- rsubmit.prop( 'disabled', 'disabled' );
// lock if present
+ usubmit.prop( 'disabled', false ); //
unlock
+ rsubmit.prop( 'disabled', true ); //
lock if present
// Revision was unflagged
} else if ( usubmit.val() === mw.msg(
'revreview-submitting' ) ) {
usubmit.val( mw.msg(
'revreview-submit-unreviewed' ) ); // done!
@@ -249,8 +249,8 @@
// Unlock and reset *flag* button
asubmit.val( mw.msg(
'revreview-submit-review' ) );
asubmit.css( 'fontWeight', '' ); //
back to normal
- asubmit.prop( 'disabled', '' ); //
unlock
- rsubmit.prop( 'disabled', '' ); //
unlock if present
+ asubmit.prop( 'disabled', false ); //
unlock
+ rsubmit.prop( 'disabled', false ); //
unlock if present
}
}
// (b) Remove review tag from drafts
@@ -286,11 +286,11 @@
// Revision was flagged
if ( asubmit.val() === mw.msg(
'revreview-submitting' ) ) {
asubmit.val( mw.msg(
'revreview-submit-review' ) ); // back to normal
- asubmit.prop( 'disabled', '' ); //
unlock
+ asubmit.prop(
[MediaWiki-commits] [Gerrit] Unify and simplify onload event execution - change (mediawiki...FlaggedRevs)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211944
Change subject: Unify and simplify onload event execution
..
Unify and simplify onload event execution
Change-Id: I82f8177bf445717efcca2bd8e2b9478e21a070b4
---
M frontend/modules/ext.flaggedRevs.advanced.js
M frontend/modules/ext.flaggedRevs.review.js
2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/44/211944/1
diff --git a/frontend/modules/ext.flaggedRevs.advanced.js
b/frontend/modules/ext.flaggedRevs.advanced.js
index 15faede..b78ba41 100644
--- a/frontend/modules/ext.flaggedRevs.advanced.js
+++ b/frontend/modules/ext.flaggedRevs.advanced.js
@@ -207,8 +207,6 @@
};
// Perform some onload events:
-$( function () {
- fr.init();
-} );
+$( fr.init );
}( mediaWiki, jQuery ) );
diff --git a/frontend/modules/ext.flaggedRevs.review.js
b/frontend/modules/ext.flaggedRevs.review.js
index 05b9402..6bb4842 100644
--- a/frontend/modules/ext.flaggedRevs.review.js
+++ b/frontend/modules/ext.flaggedRevs.review.js
@@ -415,8 +415,6 @@
};
// Perform some onload events:
-$( document ).ready( function () {
- fr.init();
-} );
+$( fr.init );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/211944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82f8177bf445717efcca2bd8e2b9478e21a070b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove quotes around object properties - change (mediawiki...FlaggedRevs)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211942
Change subject: Remove quotes around object properties
..
Remove quotes around object properties
Change-Id: I7e15bef854660c8e59534f9c31c704b42f3f8cc4
---
M frontend/modules/ext.flaggedRevs.review.js
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/42/211942/1
diff --git a/frontend/modules/ext.flaggedRevs.review.js
b/frontend/modules/ext.flaggedRevs.review.js
index 05b9402..874d77d 100644
--- a/frontend/modules/ext.flaggedRevs.review.js
+++ b/frontend/modules/ext.flaggedRevs.review.js
@@ -9,10 +9,10 @@
var wgFlaggedRevsParams = mw.config.get( 'wgFlaggedRevsParams' ),
fr = {
/* User is reviewing this page? */
- 'isUserReviewing': 0,
+ isUserReviewing: 0,
/* Startup function */
- 'init': function () {
+ init: function () {
var form = $( '#mw-fr-reviewform' );
// Enable AJAX-based submit functionality to the review form on
this page
@@ -55,7 +55,7 @@
* - Also remove comment box clutter in case of invalid input.
* NOTE: all buttons should exist (perhaps hidden though)
*/
- 'updateReviewForm': function ( form ) {
+ updateReviewForm: function ( form ) {
if ( form.prop( 'disabled' ) ) {
return;
}
@@ -106,7 +106,7 @@
/*
* Update select color for the selected item/option
*/
- 'updateReviewFormColors': function ( form ) {
+ updateReviewFormColors: function ( form ) {
for ( var tag in wgFlaggedRevsParams.tags ) { // for each tag
var select = form.find( [name='wp + tag + '] ).eq(
0 );
// Look for a selector for this tag
@@ -124,14 +124,14 @@
/*
* Lock review form from submissions (using during AJAX requests)
*/
- 'lockReviewForm': function ( form ) {
+ lockReviewForm: function ( form ) {
form.find( 'input,textarea,select' ).prop( 'disabled',
'disabled' );
},
/*
* Unlock review form from submissions (using after AJAX requests)
*/
- 'unlockReviewForm': function ( form ) {
+ unlockReviewForm: function ( form ) {
var i, inputs = form.find( 'input' );
for ( i = 0; i inputs.length; i++ ) {
if ( inputs.eq( i ).prop( 'type' ) !== 'submit' ) { //
not all buttons can be enabled
@@ -149,7 +149,7 @@
* Note: requestArgs build-up from radios/checkboxes
* based on patch by Daniel Arnold (bug 13744)
*/
- 'submitRevisionReview': function ( button, form ) {
+ submitRevisionReview: function ( button, form ) {
var i;
fr.lockReviewForm( form ); // disallow submissions
// Build up arguments array and update submit button text...
@@ -209,7 +209,7 @@
/*
* Update form elements after AJAX review.
*/
- 'postSubmitRevisionReview': function ( form, response ) {
+ postSubmitRevisionReview: function ( form, response ) {
var msg = response.substr( 6 ); // remove err# or suc#
// Read new last change time timestamp for conflict handling
// @TODO: pass last-chage-time data using JSON or something not
retarded
@@ -310,7 +310,7 @@
/*
* Enable AJAX-based functionality to set that a user is reviewing a
page/diff
*/
- 'enableAjaxReviewActivity': function () {
+ enableAjaxReviewActivity: function () {
// User is already reviewing in another tab...
if ( $( '#mw-fr-user-reviewing' ).val() === 1 ) {
fr.isUserReviewing = 1;
@@ -325,7 +325,7 @@
/*
* Flag users as now reviewing
*/
- 'advertiseReviewing': function ( e, isInitial ) {
+ advertiseReviewing: function ( e, isInitial ) {
if ( isInitial !== true ) { // don't send if just setting up
form
if ( !fr.setReviewingStatus( 1 ) ) {
return; // failed
@@ -351,7 +351,7 @@
/*
* Flag users as no longer reviewing
*/
- 'deadvertiseReviewing': function ( e, isInitial ) {
+ deadvertiseReviewing: function ( e, isInitial ) {
if ( isInitial !== true ) { // don't send if just setting up
form
if ( !fr.setReviewingStatus( 0 ) ) {
return; // failed
@@ -379,7 +379,7 @@
/*
* Set reviewing status for this page/diff
*/
- 'setReviewingStatus': function ( value ) {
+ setReviewingStatus: function ( value ) {
[MediaWiki-commits] [Gerrit] Remove unused variables in JavaScript - change (mediawiki...FlaggedRevs)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211945
Change subject: Remove unused variables in JavaScript
..
Remove unused variables in JavaScript
Change-Id: I2494fdcffd684c860e9f3bef9c1949219dae6efe
---
M frontend/modules/ext.flaggedRevs.advanced.js
M frontend/modules/ext.flaggedRevs.review.js
2 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/45/211945/1
diff --git a/frontend/modules/ext.flaggedRevs.advanced.js
b/frontend/modules/ext.flaggedRevs.advanced.js
index 15faede..101b99e 100644
--- a/frontend/modules/ext.flaggedRevs.advanced.js
+++ b/frontend/modules/ext.flaggedRevs.advanced.js
@@ -62,7 +62,7 @@
* @context {jQuery}
* @param e {jQuery.Event}
*/
- 'toggleBoxDetails': function ( e ) {
+ 'toggleBoxDetails': function () {
var toggle = $( '#mw-fr-revisiontoggle' ),
ratings = $( '#mw-fr-revisiondetails' );
@@ -84,7 +84,7 @@
* @context {jQuery}
* @param e {jQuery.Event}
*/
- 'onBoxMouseOver': function ( e ) {
+ 'onBoxMouseOver': function () {
/*global window*/
window.clearTimeout( fr.boxCollapseTimer );
fr.boxCollapseTimer = null;
@@ -131,7 +131,7 @@
* @context {jQuery}
* @param e {jQuery.Event}
*/
- 'toggleDiff': function ( e ) {
+ 'toggleDiff': function () {
var diff = $( '#mw-fr-stablediff' ),
toggle = $( '#mw-fr-difftoggle' );
@@ -151,7 +151,7 @@
* @context {jQuery}
* @param e {jQuery.Event}
*/
- 'toggleLog': function ( e ) {
+ 'toggleLog': function () {
var hideMsg, showMsg,
log = $( '#mw-fr-logexcerpt' ),
toggle = $( '#mw-fr-logtoggle' );
diff --git a/frontend/modules/ext.flaggedRevs.review.js
b/frontend/modules/ext.flaggedRevs.review.js
index 05b9402..2f1d453 100644
--- a/frontend/modules/ext.flaggedRevs.review.js
+++ b/frontend/modules/ext.flaggedRevs.review.js
@@ -16,7 +16,7 @@
var form = $( '#mw-fr-reviewform' );
// Enable AJAX-based submit functionality to the review form on
this page
- $( '#mw-fr-submit-accept,#mw-fr-submit-unaccept' ).click(
function ( e ) {
+ $( '#mw-fr-submit-accept,#mw-fr-submit-unaccept' ).click(
function () {
fr.submitRevisionReview( this, form );
return false; // don't do normal non-AJAX submit
} );
@@ -32,7 +32,7 @@
// Setup select form option colors
fr.updateReviewFormColors( form );
// Update review form on change
- form.find( 'input,select' ).change( function ( e ) {
+ form.find( 'input,select' ).change( function () {
fr.updateReviewForm( form );
} );
@@ -40,7 +40,7 @@
fr.enableAjaxReviewActivity();
// De-advertise user as no longer reviewing on navigate-away
/*global window*/
- $( window ).unload( function ( e ) {
+ $( window ).unload( function () {
if ( fr.isUserReviewing === 1 ) {
fr.deadvertiseReviewing();
}
@@ -192,7 +192,7 @@
post_data += 'rsargs[]=' + encodeURIComponent(
requestArgs[i] );
}
// Send POST request via AJAX!
- var call = $.ajax( {
+ $.ajax( {
url : mw.util.wikiScript( 'index' ),
type : 'POST',
data : post_data,
@@ -200,7 +200,7 @@
success : function ( response ) {
fr.postSubmitRevisionReview( form, response );
},
- error: function ( response ) {
+ error: function () {
fr.unlockReviewForm( form );
}
} );
@@ -269,7 +269,7 @@
url_pars += 'rsargs[]=' +
encodeURIComponent( requestArgs[i] );
}
// Send GET request via AJAX!
- var call = $.ajax( {
+ $.ajax( {
url : mw.util.wikiScript( 'index'
) + url_pars,
type : 'GET',
dataType : 'html', // response type
@@ -389,7 +389,7 @@
nRevId = inputOldId ?
[MediaWiki-commits] [Gerrit] Install: Fixes for oauthauth_user table creation: - change (mediawiki...OAuthAuthentication)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211093
Change subject: Install: Fixes for oauthauth_user table creation:
..
Install: Fixes for oauthauth_user table creation:
/utils/Hooks.php: Added a slash to fix possibly missing slash
/store/oauthauth.sql: Removed a comma to fix syntax error
Bug: T99219
Change-Id: Ie613ba3dee553e902f6536dd7a1bea8b573edac8
---
M store/oauthauth.sql
M utils/Hooks.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication
refs/changes/93/211093/1
diff --git a/store/oauthauth.sql b/store/oauthauth.sql
index 56fc6f5..dc927b4 100644
--- a/store/oauthauth.sql
+++ b/store/oauthauth.sql
@@ -4,7 +4,7 @@
`oaau_username` varchar(255) binary not null,
`oaau_access_token` varchar(127) binary not null default '',
`oaau_access_secret` varchar(127) binary not null default '',
- `oaau_identify_timestamp` binary(14) not null default '',
+ `oaau_identify_timestamp` binary(14) not null default ''
) /*$wgDBTableOptions*/;
CREATE UNIQUE INDEX /*i*/idx_rid ON /*_*/oauthauth_user (`oaau_rid`);
diff --git a/utils/Hooks.php b/utils/Hooks.php
index 6df4a81..bbda513 100644
--- a/utils/Hooks.php
+++ b/utils/Hooks.php
@@ -45,7 +45,7 @@
}
public static function onLoadExtensionSchemaUpdates( $updater = null ) {
- $updater-addExtensionTable( 'oauthauth_user', __DIR__ .
'../store/oauthauth.sql' );
+ $updater-addExtensionTable( 'oauthauth_user', __DIR__ .
'/../store/oauthauth.sql' );
}
public static function onGetPreferences( $user, $preferences ) {
--
To view, visit https://gerrit.wikimedia.org/r/211093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie613ba3dee553e902f6536dd7a1bea8b573edac8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Zhuyifei1999 zhuyifei1...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove redundant line-height declarations from elements.css - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207424
Change subject: Remove redundant line-height declarations from elements.css
..
Remove redundant line-height declarations from elements.css
Elements.css declares line-height of 1.5em for certain common
elements, like ol, ul and dd. These are redundant as each skin already
declares the same line-height for the content, and all elements inherit
this line-height from the body.
At the same time, these declaration override the content line-height of
1.6em set in Vector, creating inconsistencies that cannot be 'hacked'
away. Removing these line-height declarations has no impact, other
then making the typography refresh actually work as intended.
Change-Id: I5b682a9527294e96f3999773724cbf8fb9631197
---
M resources/src/mediawiki.skinning/elements.css
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/24/207424/1
diff --git a/resources/src/mediawiki.skinning/elements.css
b/resources/src/mediawiki.skinning/elements.css
index eb57abb..8140d1a 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -141,7 +141,6 @@
p {
margin: .4em 0 .5em 0;
- line-height: 1.5em;
}
p img {
@@ -149,14 +148,12 @@
}
ul {
- line-height: 1.5em;
list-style-type: square;
margin: .3em 0 0 1.6em;
padding: 0;
}
ol {
- line-height: 1.5em;
margin: .3em 0 0 3.2em;
padding: 0;
list-style-image: none;
@@ -177,7 +174,6 @@
}
dd {
- line-height: 1.5em;
margin-left: 1.6em;
margin-bottom: .1em;
}
@@ -215,7 +211,6 @@
border: 1px solid #2f6fab;
margin: 1em 0 1em 0;
padding: 0 1em 1em;
- line-height: 1.5em;
}
fieldset.nested {
--
To view, visit https://gerrit.wikimedia.org/r/207424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b682a9527294e96f3999773724cbf8fb9631197
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Edokter er...@darcoury.nl
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the cached editTime if available - change (pywikibot/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205065
Change subject: Use the cached editTime if available
..
Use the cached editTime if available
Change-Id: I2bd2fb0a7ae64d23e9a68eed176cc7bcf1521a39
---
M pywikibot/page.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/65/205065/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index a2eb04c..5199e06 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -567,12 +567,14 @@
return self._lastNonBotUser
@remove_last_args(('datetime', ))
-def editTime(self):
+def editTime(self, force=False):
Return timestamp of last revision to page.
@rtype: pywikibot.Timestamp
-return self.latest_revision.timestamp
+if not force and hasattr(self, '_timestamp'):
+return pywikibot.Timestamp.fromISOformat(self._timestamp)
+ return self.latest_revision.timestamp
@property
def previous_revision_id(self):
--
To view, visit https://gerrit.wikimedia.org/r/205065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bd2fb0a7ae64d23e9a68eed176cc7bcf1521a39
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Strainu w...@strainu.ro
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use the cached editTime if available - change (pywikibot/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205023
Change subject: Use the cached editTime if available
..
Use the cached editTime if available
Change-Id: Ifa4f0b2f724731805b2f028b84079c055415d9df
---
M pywikibot/page.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/23/205023/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index a2eb04c..b3a2abc 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -567,12 +567,14 @@
return self._lastNonBotUser
@remove_last_args(('datetime', ))
-def editTime(self):
+def editTime(self, force=False):
Return timestamp of last revision to page.
@rtype: pywikibot.Timestamp
-return self.latest_revision.timestamp
+ if not force and hasattr(self, '_timestamp'):
+return pywikibot.Timestamp.fromISOformat(self._timestamp)
+ return self.latest_revision.timestamp
@property
def previous_revision_id(self):
--
To view, visit https://gerrit.wikimedia.org/r/205023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa4f0b2f724731805b2f028b84079c055415d9df
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Strainu w...@strainu.ro
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable automatic sorting of Page Status Indicators - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202012
Change subject: Disable automatic sorting of Page Status Indicators
..
Disable automatic sorting of Page Status Indicators
Consistency is cited for automatic sorting of indicators, but benefits are not
demonstrated and it takes away any control of icon placement by the user
without having to play with the indicator name (which is often not possible) or
resort to other unsightly hacks in template: and module: space.
Indicators were created to move away from these hacks, but has failed in that
respect, and users want to regain control of indicator placement. Therefor this
patch removed the ksort() statement, so indicators are placed in the oder they
are placed on the page.
Sorting can be implemented at template level if so desired, as templates are
the main recommended method for invoking indicators in the first place.
Bug: T94307
Change-Id: If2148e0f9d705e732755f4f1d420e302d11810cf
---
M includes/OutputPage.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/12/202012/1
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index cac89f4..efd5145 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1383,8 +1383,6 @@
*/
public function setIndicators( array $indicators ) {
$this-mIndicators = $indicators + $this-mIndicators;
- // Keep ordered by key
- ksort( $this-mIndicators );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/202012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2148e0f9d705e732755f4f1d420e302d11810cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Edokter er...@darcoury.nl
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Emergency fixes - change (labs...grrrit)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200351
Change subject: Emergency fixes
..
Emergency fixes
- remove #wmt which cannot be joined without invite
- fix username check on join to check for actual username instead of
config username
- add moar logging so we can see what's going on in connecting to gerrit
Change-Id: Ifdca6b7cf606dc4d877a757fb42f7ff2d13c679e
---
M config.yaml
M src/relay.js
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/grrrit
refs/changes/51/200351/1
diff --git a/config.yaml b/config.yaml
index e1cd412..b1b6042 100644
--- a/config.yaml
+++ b/config.yaml
@@ -170,9 +170,6 @@
mediawiki/extensions/Campaigns,
mediawiki/extensions/EducationProgram
}
-#wmt: {
-labs/tools/WMT
-}
#brickimedia: {
mediawiki/extensions/MediaWikiChat
}
diff --git a/src/relay.js b/src/relay.js
index 4aa3adc..6a9c629 100644
--- a/src/relay.js
+++ b/src/relay.js
@@ -33,6 +33,7 @@
function subscribeToGerritStream(host, port, username, keypath, listener) {
var conn = ssh2.Client();
+logging.info('Connecting to gerrit..');
conn.connect({
host: host,
port: port,
@@ -40,12 +41,13 @@
privateKey: require('fs').readFileSync(keypath),
});
conn.on('ready', function() {
+logging.info('Connected; requesting stream-events');
conn.exec('gerrit stream-events', function(err, stream) {
if (err) {
logging.error(err);
throw err;
}
-
+logging.info('Connected to event stream!');
stream.on('data', function(data) {
listener(err, JSON.parse(data));
});
@@ -104,7 +106,8 @@
var joinedChannels = [];
function waitForChannelJoins(channel, nick, message) {
-if(nick === config.nick) {
+logging.info(nick + joined + channel);
+if(nick === ircClient.nick) {
joinedChannels.push(channel);
logging.info(Joined channel + channel);
}
--
To view, visit https://gerrit.wikimedia.org/r/200351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdca6b7cf606dc4d877a757fb42f7ff2d13c679e
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/grrrit
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Pywikipedia Conversion Bot valhall...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.action.edit.preview: Disable if there is no #wpTex... - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200477
Change subject: mediawiki.action.edit.preview: Disable if there is no
#wpTextbox1
..
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1
ProofreadPage has custom editforms for Index pages, which are not
supported by the API. These editforms have no #wpTextbox1, so disable
live preview in that case.
Make this check on click avoid T94089.
Bug: T78709
Change-Id: I628d3b226a4294f2878fc4175080a975fd86e507
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/77/200477/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 4aa839c..f24703a 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -9,15 +9,20 @@
*/
function doLivePreview( e ) {
var isDiff, api, request, postData, copySelectors, section,
- $wikiPreview, $wikiDiff, $editform, $copyElements,
$spinner, $errorBox;
+ $wikiPreview, $wikiDiff, $editform, $textbox, $summary,
$copyElements, $spinner, $errorBox;
isDiff = ( e.target.name === 'wpDiff' );
$wikiPreview = $( '#wikiPreview' );
$wikiDiff = $( '#wikiDiff' );
$editform = $( '#editform' );
+ $textbox = $editform.find( '#wpTextbox1' );
+ $summary = $editform.find( '#wpSummary' );
$errorBox = $( '.errorbox' );
section = $editform.find( '[name=wpSection]' ).val();
+ if ( $textbox.length === 0 ) {
+ return;
+ }
// Show changes for a new section is not yet supported
if ( isDiff section === 'new' ) {
return;
@@ -68,8 +73,8 @@
action: 'parse',
uselang: mw.config.get( 'wgUserLanguage' ),
title: mw.config.get( 'wgPageName' ),
- text: $editform.find( '#wpTextbox1' ).textSelection(
'getContents' ),
- summary: $editform.find( '#wpSummary' ).textSelection(
'getContents' )
+ text: $textbox.textSelection( 'getContents' ),
+ summary: $summary.textSelection( 'getContents' )
};
if ( section !== '' ) {
--
To view, visit https://gerrit.wikimedia.org/r/200477
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I628d3b226a4294f2878fc4175080a975fd86e507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move deprecated HTML attributes to CSS - change (mediawiki...LiquidThreads)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200326
Change subject: Move deprecated HTML attributes to CSS
..
Move deprecated HTML attributes to CSS
Follows up I71d6c8487c176a033a00a0213f60e7e7e2ab19d6.
Bug: T74519
Change-Id: Id61871ce6c04af9ae52a84cef7c4061f28b94c6d
---
M lqt.css
M pages/TalkpageView.php
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads
refs/changes/26/200326/1
diff --git a/lqt.css b/lqt.css
index 9e4d765..cf89232 100644
--- a/lqt.css
+++ b/lqt.css
@@ -485,6 +485,7 @@
.TalkpagePager_nav td{
vertical-align: top;
text-align: center;
+ padding: 3px;
}
.lqt-drag-confirm label {
diff --git a/pages/TalkpageView.php b/pages/TalkpageView.php
index 3a720fe..0bc7637 100644
--- a/pages/TalkpageView.php
+++ b/pages/TalkpageView.php
@@ -567,7 +567,7 @@
$links = $this-getPagingLinks( $linkTexts, $disabledTexts );
$navClass = htmlspecialchars( $this-getNavClass() );
- $s = table class=\$navClass\ align=\center\
cellpadding=\3\tr\n;
+ $s = table class=\$navClass\tr\n;
$cellAttrs = 'width: ' . 100 / count( $links ) . '%';
foreach ( $labels as $type = $label ) {
$s .= td style='$cellAttrs'{$links[$type]}/td\n;
--
To view, visit https://gerrit.wikimedia.org/r/200326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id61871ce6c04af9ae52a84cef7c4061f28b94c6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: He7d3r he7...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make all QUnit tests pass for languages other than English - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199241
Change subject: Make all QUnit tests pass for languages other than English
..
Make all QUnit tests pass for languages other than English
Some tablesorter tests were failing for a content language different from
English, and the test for two functions from mw.language for a different
UI language.
This patch provides a mocked environment for all these tests, simulating
English language.
Bug: T59776
Change-Id: Ibfc83c34a896dc5fb5e892fb0ffd60e618880781
---
M tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
M tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
3 files changed, 61 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/41/199241/1
diff --git
a/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
b/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
index 2c56eea..97a3ae1 100644
--- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
@@ -6,17 +6,40 @@
var text, ipv4,
simpleMDYDatesInMDY, simpleMDYDatesInDMY, oldMDYDates,
complexMDYDates, clobberedDates, MYDates, YDates,
- currencyData, transformedCurrencyData,
- config = {
+ currencyData, transformedCurrencyData;
+
+ QUnit.module( 'jquery.tablesorter.parsers', QUnit.newMwEnvironment( {
+ setup: function () {
+ this.liveMonths = mw.language.months;
+ mw.language.months = {
+ 'keys': {
+ 'names': ['january', 'february',
'march', 'april', 'may_long', 'june',
+ 'july', 'august', 'september',
'october', 'november', 'december'],
+ 'genitive': ['january-gen',
'february-gen', 'march-gen', 'april-gen', 'may-gen', 'june-gen',
+ 'july-gen', 'august-gen',
'september-gen', 'october-gen', 'november-gen', 'december-gen'],
+ 'abbrev': ['jan', 'feb', 'mar', 'apr',
'may', 'jun',
+ 'jul', 'aug', 'sep', 'oct',
'nov', 'dec']
+ },
+ 'names': ['January', 'February', 'March',
'April', 'May', 'June',
+ 'July', 'August', 'September',
'October', 'November', 'December'],
+ 'genitive': ['January', 'February', 'March',
'April', 'May', 'June',
+ 'July', 'August', 'September',
'October', 'November', 'December'],
+ 'abbrev': ['Jan', 'Feb', 'Mar', 'Apr', 'May',
'Jun',
+ 'Jul', 'Aug', 'Sep', 'Oct',
'Nov', 'Dec']
+ };
+ },
+ teardown: function () {
+ mw.language.months = this.liveMonths;
+ },
+ config: {
wgContentLanguage: 'en',
/* default date format of the content language */
wgDefaultDateFormat: 'dmy',
/* These two are important for numeric interpretations
*/
wgSeparatorTransformTable: ['', ''],
wgDigitTransformTable: ['', '']
- };
-
- QUnit.module( 'jquery.tablesorter.parsers', QUnit.newMwEnvironment( {
config: config } ) );
+ }
+ } ) );
/**
* For a value, check if the parser recognizes it and how it transforms
it
diff --git a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
index f7700f8..f63aa27 100644
--- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -156,9 +156,29 @@
];
QUnit.module( 'jquery.tablesorter', QUnit.newMwEnvironment( {
+ setup: function () {
+ this.liveMonths = mw.language.months;
+ mw.language.months = {
+ 'keys': {
+ 'names': ['january', 'february',
'march', 'april', 'may_long', 'june',
+ 'july', 'august', 'september',
'october', 'november', 'december'],
+ 'genitive': ['january-gen',
'february-gen', 'march-gen', 'april-gen',
[MediaWiki-commits] [Gerrit] Special:ItemByTitle should preserve url parameters - change (mediawiki...Wikibase)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199239
Change subject: Special:ItemByTitle should preserve url parameters
..
Special:ItemByTitle should preserve url parameters
The most prominent use case for this is
Special:ItemByTitle/enwiki/Wikipedia?action=history, which should redirect to
Q52?action=history, keeping the action=history parameter. But also all other
parameters will be preserved.
Bug: T50037
Change-Id: Ieb70546481d8e58824bd5df96c5116fbe063c02a
---
M repo/includes/specials/SpecialItemByTitle.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/39/199239/1
diff --git a/repo/includes/specials/SpecialItemByTitle.php
b/repo/includes/specials/SpecialItemByTitle.php
index d42a132..152b351 100644
--- a/repo/includes/specials/SpecialItemByTitle.php
+++ b/repo/includes/specials/SpecialItemByTitle.php
@@ -154,7 +154,9 @@
// Redirect to the item page if we found its content
if ( $itemId !== null ) {
$title = $this-titleLookup-getTitleForId(
$itemId );
- $itemUrl = $title-getFullUrl();
+ $query = $request-getValues();
+ unset( $query['title'] );
+ $itemUrl = $title-getFullUrl( $query );
$this-getOutput()-redirect( $itemUrl );
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/199239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb70546481d8e58824bd5df96c5116fbe063c02a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Schnark listenle...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use 'json' module instead of deprecated 'jquery.json' - change (mediawiki...BookManagerv2)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199322
Change subject: Use 'json' module instead of deprecated 'jquery.json'
..
Use 'json' module instead of deprecated 'jquery.json'
See
* https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078725.html
* https://gerrit.wikimedia.org/r/#/c/140560/
Change-Id: Iaeb968f9bd1bcd15275ca025205fb359b57aef9f
---
M BookManagerv2.php
M modules/ext.BookManagerv2.editor.js
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BookManagerv2
refs/changes/22/199322/1
diff --git a/BookManagerv2.php b/BookManagerv2.php
index 5996af1..197212a 100644
--- a/BookManagerv2.php
+++ b/BookManagerv2.php
@@ -166,7 +166,7 @@
'dependencies' = array(
'jquery.ui.sortable',
'mediawiki.jqueryMsg',
- 'jquery.json',
+ 'json',
'mediawiki.util'
),
'messages' = array(
diff --git a/modules/ext.BookManagerv2.editor.js
b/modules/ext.BookManagerv2.editor.js
index 6a303e5..9806697 100644
--- a/modules/ext.BookManagerv2.editor.js
+++ b/modules/ext.BookManagerv2.editor.js
@@ -17,7 +17,7 @@
**/
( function ( mw, $ ) {
function updateJson( $json ) {
- $( 'input#json-editor-sections' ).val( $.toJSON( $json ) );
+ $( 'input#json-editor-sections' ).val( JSON.stringify( $json )
);
}
function showOrHide( $element ) {
@@ -36,7 +36,7 @@
}
var imagePath = mw.config.get( 'wgExtensionAssetsPath' ) +
'/BookManagerv2/images/',
- sectionJson = $.evalJSON( $( 'input#json-editor-sections'
).val() ),
+ sectionJson = JSON.parse( $( 'input#json-editor-sections'
).val() ),
noSectionsExist = sectionJson.length === 0,
moveAlt = mw.message( 'bookmanagerv2-move-alt' ).text(),
removeAlt = mw.message( 'bookmanagerv2-remove-alt' ).text(),
--
To view, visit https://gerrit.wikimedia.org/r/199322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaeb968f9bd1bcd15275ca025205fb359b57aef9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BookManagerv2
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: He7d3r he7...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Partially revert increased wikitable padding - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198557
Change subject: Partially revert increased wikitable padding
..
Partially revert increased wikitable padding
Follow up to gerrit:188311. This change sparked a lot of debate on enwiki and
Diffusion. In the original patch, consensus settled on 0.2em 0.4em, but 0.3em
0.4em was applied instead. This patch implements the original, as discussed in
T91890.
Bug: T91890
Change-Id: I271424cb2c3e595223b33b112b48b2f7b46286c5
---
M resources/src/mediawiki.legacy/shared.css
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/198557/1
diff --git a/resources/src/mediawiki.legacy/shared.css
b/resources/src/mediawiki.legacy/shared.css
index 56e4625..eac3069 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -528,7 +528,7 @@
table.wikitable * tr th,
table.wikitable * tr td {
border: 1px solid #aaa;
- padding: 0.3em 0.4em;
+ padding: 0.2em 0.4em;
}
table.wikitable tr th,
--
To view, visit https://gerrit.wikimedia.org/r/198557
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I271424cb2c3e595223b33b112b48b2f7b46286c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Edokter er...@darcoury.nl
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Check for the return on insert and update instead of relying... - change (mediawiki...Interwiki)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198235
Change subject: Check for the return on insert and update instead of relying on
modified rows. Rows updated with no change result in erroneous error messages.
..
Check for the return on insert and update instead of relying on modified rows.
Rows updated with no change result in erroneous error messages.
Change-Id: I9611c9e3d666f824bf762d493b4a6479a9ef5f41
---
M Interwiki_body.php
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Interwiki
refs/changes/35/198235/1
diff --git a/Interwiki_body.php b/Interwiki_body.php
index 0070cfb..510dbe9 100644
--- a/Interwiki_body.php
+++ b/Interwiki_body.php
@@ -274,14 +274,15 @@
return;
}
+ $success = true;
if ( $do === 'add' ) {
- $dbw-insert( 'interwiki', $data, __METHOD__,
'IGNORE' );
+ $success = $dbw-insert( 'interwiki', $data,
__METHOD__, 'IGNORE' );
} else { // $do === 'edit'
- $dbw-update( 'interwiki', $data, array(
'iw_prefix' = $prefix ), __METHOD__, 'IGNORE' );
+ $success = $dbw-update( 'interwiki', $data,
array( 'iw_prefix' = $prefix ), __METHOD__, 'IGNORE' );
}
// used here: interwiki_addfailed, interwiki_added,
interwiki_edited
- if ( $dbw-affectedRows() === 0 ) {
+ if ( $dbw-affectedRows() === 0 !$success ) {
$this-error( interwiki_{$do}failed, $prefix
);
$this-showForm( $do );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/198235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9611c9e3d666f824bf762d493b4a6479a9ef5f41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Interwiki
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Alexia was...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move style for TOC hiding to separate module - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197107
Change subject: Move style for TOC hiding to separate module
..
Move style for TOC hiding to separate module
* Load module 'mediawiki.toc' on 'position' = 'top' to avoid flickering.
* Add dependency from 'mediawiki.action.edit.preview' to
'mediawiki.toc' to avoid flickering on preview.
Change-Id: Ib7c81e9433e7e3976e40e407f63fc8e924957faa
---
M resources/Resources.php
M resources/src/mediawiki.legacy/commonPrint.css
M resources/src/mediawiki.legacy/oldshared.css
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.skinning/content.css
A resources/src/mediawiki/mediawiki.toc.css
A resources/src/mediawiki/mediawiki.toc.print.css
7 files changed, 25 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/07/197107/1
diff --git a/resources/Resources.php b/resources/Resources.php
index a158af7..9268179 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -986,8 +986,17 @@
),
'mediawiki.toc' = array(
'scripts' = 'resources/src/mediawiki/mediawiki.toc.js',
+ 'skinStyles' = array(
+ 'default' = array(
+ 'resources/src/mediawiki/mediawiki.toc.css' =
+ array( 'media' = 'screen'),
+
'resources/src/mediawiki/mediawiki.toc.print.css' =
+ array( 'media' = 'print' ),
+ ),
+ ),
'dependencies' = 'jquery.cookie',
'messages' = array( 'showtoc', 'hidetoc' ),
+ 'position' = 'top',
'targets' = array( 'desktop', 'mobile' ),
),
'mediawiki.Uri' = array(
@@ -1068,6 +1077,7 @@
'mediawiki.api',
'mediawiki.action.history.diff',
'mediawiki.util',
+ 'mediawiki.toc', // preload to avoid flickering
'mediawiki.jqueryMsg',
),
'messages' = array(
diff --git a/resources/src/mediawiki.legacy/commonPrint.css
b/resources/src/mediawiki.legacy/commonPrint.css
index 9a8d391..096cd23 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -19,8 +19,6 @@
#colophon,
.mw-editsection,
.mw-editsection-like,
-.toctoggle,
-#toc.tochidden,
div#f-poweredbyico,
div#f-copyrightico,
li#about,
diff --git a/resources/src/mediawiki.legacy/oldshared.css
b/resources/src/mediawiki.legacy/oldshared.css
index c2bd5a7..b8f8dd5 100644
--- a/resources/src/mediawiki.legacy/oldshared.css
+++ b/resources/src/mediawiki.legacy/oldshared.css
@@ -213,11 +213,6 @@
margin: 0 0 0 2em;
}
-#toc .toctoggle,
-.toc .toctoggle {
- font-size: 94%;
-}
-
.error {
color: red;
font-size: larger;
diff --git a/resources/src/mediawiki.legacy/shared.css
b/resources/src/mediawiki.legacy/shared.css
index 467714e..64084a9 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -1123,8 +1123,6 @@
}
.mw-editsection,
-.toctoggle,
-.tochidden,
#jump-to-nav {
-moz-user-select: none;
-webkit-user-select: none;
diff --git a/resources/src/mediawiki.skinning/content.css
b/resources/src/mediawiki.skinning/content.css
index 7dd5ee7..f412fc3 100644
--- a/resources/src/mediawiki.skinning/content.css
+++ b/resources/src/mediawiki.skinning/content.css
@@ -83,11 +83,6 @@
margin: 0 0 0 2em;
}
-#toc .toctoggle,
-.toc .toctoggle {
- font-size: 94%;
-}
-
/* Warning */
.mw-warning {
margin-left: 50px;
diff --git a/resources/src/mediawiki/mediawiki.toc.css
b/resources/src/mediawiki/mediawiki.toc.css
new file mode 100644
index 000..835a451
--- /dev/null
+++ b/resources/src/mediawiki/mediawiki.toc.css
@@ -0,0 +1,11 @@
+.tochidden,
+.toctoggle {
+ -moz-user-select: none;
+ -webkit-user-select: none;
+ -ms-user-select: none;
+ user-select: none;
+}
+
+.toctoggle {
+ font-size: 94%;
+}
diff --git a/resources/src/mediawiki/mediawiki.toc.print.css
b/resources/src/mediawiki/mediawiki.toc.print.css
new file mode 100644
index 000..da2c08f
--- /dev/null
+++ b/resources/src/mediawiki/mediawiki.toc.print.css
@@ -0,0 +1,4 @@
+#toc.tochidden,
+.toctoggle {
+ display: none;
+}
--
To view, visit https://gerrit.wikimedia.org/r/197107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7c81e9433e7e3976e40e407f63fc8e924957faa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
[MediaWiki-commits] [Gerrit] TOC: Separate columns for tocnumber and toctext - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196541
Change subject: TOC: Separate columns for tocnumber and toctext
..
TOC: Separate columns for tocnumber and toctext
IE 7 and lower ignores these definitions and shows the TOC as before.
Bug: T92481
Change-Id: Ibed5f02f04e63a4152109ddf9c2a23f4e45880ca
---
M resources/src/mediawiki.legacy/commonPrint.css
M resources/src/mediawiki.skinning/content.css
2 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/41/196541/1
diff --git a/resources/src/mediawiki.legacy/commonPrint.css
b/resources/src/mediawiki.legacy/commonPrint.css
index 9a8d391..0c66f0d 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -131,6 +131,20 @@
*display: inline;
}
+/* Separate columns for tocnumber and toctext */
+/* Ignored by IE7 and lower */
+.tocnumber,
+.toctext {
+ display: table-cell;
+}
+
+/* Space between the columns for tocnumber and toctext */
+/* Ignored by IE7 and lower */
+.tocnumber:after {
+ content: ;
+ padding-right: 0.5em;
+}
+
#footer {
background: white;
color: black;
diff --git a/resources/src/mediawiki.skinning/content.css
b/resources/src/mediawiki.skinning/content.css
index 7dd5ee7..9beed0d 100644
--- a/resources/src/mediawiki.skinning/content.css
+++ b/resources/src/mediawiki.skinning/content.css
@@ -88,6 +88,20 @@
font-size: 94%;
}
+/* Separate columns for tocnumber and toctext */
+/* Ignored by IE7 and lower */
+.tocnumber,
+.toctext {
+ display: table-cell;
+}
+
+/* Space between the columns for tocnumber and toctext */
+/* Ignored by IE7 and lower */
+.tocnumber:after {
+ content: ;
+ padding-right: 0.5em;
+}
+
/* Warning */
.mw-warning {
margin-left: 50px;
--
To view, visit https://gerrit.wikimedia.org/r/196541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibed5f02f04e63a4152109ddf9c2a23f4e45880ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.page.startup: Simplify jQuery - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196542
Change subject: mediawiki.page.startup: Simplify jQuery
..
mediawiki.page.startup: Simplify jQuery
Change-Id: If443fdc543a0eebcaa3d82ab92eadb39b0f0f196
---
M resources/src/mediawiki.page/mediawiki.page.startup.js
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/42/196542/1
diff --git a/resources/src/mediawiki.page/mediawiki.page.startup.js
b/resources/src/mediawiki.page/mediawiki.page.startup.js
index 4aae606..5ae497b 100644
--- a/resources/src/mediawiki.page/mediawiki.page.startup.js
+++ b/resources/src/mediawiki.page/mediawiki.page.startup.js
@@ -4,9 +4,8 @@
// Client profile classes for html
// Allows for easy hiding/showing of JS or no-JS-specific UI elements
- $( 'html' )
- .addClass( 'client-js' )
- .removeClass( 'client-nojs' );
+ $( document.documentElement )
+ .toggleClass( 'client-nojs client-js' );
$( function () {
mw.util.init();
--
To view, visit https://gerrit.wikimedia.org/r/196542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If443fdc543a0eebcaa3d82ab92eadb39b0f0f196
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Highlight target references - change (mediawiki...Cite)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196172
Change subject: Highlight target references
..
Highlight target references
Highlight the target reference when the user clicks a reference link,
and also highlight the note in the text when he clicks the backlink.
This is done using the :target selector and a light blue background-color.
The color (and the rest of the code) are from English Wikipedia, from where
it has been copied to many other wikis, so the feature itself and especially
the color seem to be agreed on.
Browsers that don't support the :target selector (notably Internet Explorer 8
and below) will just ignore the new style and fall back to current behavior.
Wikis that have added this code to their common.css can remove it, but
of course nothing will break when they keep the duplicate code.
Bug: T10303
Change-Id: I5775daf6934516ce9c98841399e5a358195c1374
---
M modules/ext.cite.css
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite
refs/changes/72/196172/1
diff --git a/modules/ext.cite.css b/modules/ext.cite.css
index e1a14eb..de0632c 100644
--- a/modules/ext.cite.css
+++ b/modules/ext.cite.css
@@ -23,6 +23,12 @@
user-select: none;
}
+/* Highlight clicked reference in blue to help navigation */
+ol.references li:target,
+sup.reference:target {
+ background-color: #def;
+}
+
@media print {
.mw-cite-backlink {
display: none;
--
To view, visit https://gerrit.wikimedia.org/r/196172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5775daf6934516ce9c98841399e5a358195c1374
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Schnark listenle...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.jqueryMsg: Fix examples in comments - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/195374
Change subject: mediawiki.jqueryMsg: Fix examples in comments
..
mediawiki.jqueryMsg: Fix examples in comments
Change-Id: Ia6fcb718e9c0ef073ed472af29c8ca4507f45b5a
---
M resources/src/mediawiki/mediawiki.jqueryMsg.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/195374/1
diff --git a/resources/src/mediawiki/mediawiki.jqueryMsg.js
b/resources/src/mediawiki/mediawiki.jqueryMsg.js
index b5c2dba..79939f6 100644
--- a/resources/src/mediawiki/mediawiki.jqueryMsg.js
+++ b/resources/src/mediawiki/mediawiki.jqueryMsg.js
@@ -136,7 +136,7 @@
* Returns a function suitable for use as a global, to construct
strings from the message key (and optional replacements).
* e.g.
*
-* window.gM = mediaWiki.parser.getMessageFunction( options );
+* window.gM = mediaWiki.jqueryMsg.getMessageFunction( options );
* $( 'p#headline' ).html( gM( 'hello-user', username ) );
*
* Like the old gM() function this returns only strings, so it destroys
any bindings. If you want to preserve bindings use the
@@ -178,7 +178,7 @@
* the current selector. Bindings to passed-in jquery elements are
preserved. Functions become click handlers for [$1 linktext] links.
* e.g.
*
-*$.fn.msg = mediaWiki.parser.getJqueryPlugin( options );
+*$.fn.msg = mediaWiki.jqueryMsg.getPlugin( options );
*var userlink = $( 'a' ).click( function () { alert(
hello!! ) } );
*$( 'p#headline' ).msg( 'hello-user', userlink );
*
--
To view, visit https://gerrit.wikimedia.org/r/195374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6fcb718e9c0ef073ed472af29c8ca4507f45b5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.jqueryMsg: Implement a new function $.fn.appendMsg() - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/195363
Change subject: mediawiki.jqueryMsg: Implement a new function $.fn.appendMsg()
..
mediawiki.jqueryMsg: Implement a new function $.fn.appendMsg()
This function allows to append a message to a jQuery object without
replacing the current content.
Example:
$( 'p' )
.append( 'Text ibefore/i the message ' )
.appendMsg( 'parentheses', $( 'a' ).text( 'link' ) )
.append( ' Text iafter/i the message.' );
Change-Id: I0c6849933f5aebf35cadf5360443775430896e8c
---
M resources/src/mediawiki/mediawiki.jqueryMsg.js
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/195363/1
diff --git a/resources/src/mediawiki/mediawiki.jqueryMsg.js
b/resources/src/mediawiki/mediawiki.jqueryMsg.js
index b5c2dba..7f1616a 100644
--- a/resources/src/mediawiki/mediawiki.jqueryMsg.js
+++ b/resources/src/mediawiki/mediawiki.jqueryMsg.js
@@ -190,16 +190,20 @@
* We append to 'this', which in a jQuery plugin context will be the
selected elements.
*
* @param {Object} options Parser options
+* @param {boolean} append Do not empty the jQuery object before
appending
* @return {Function} Function suitable for assigning to jQuery plugin,
such as jQuery#msg
* @return {string} return.key Message key.
* @return {Array|Mixed} return.replacements Optional variable
replacements (variadically or an array).
* @return {jQuery} return.return
*/
- mw.jqueryMsg.getPlugin = function ( options ) {
+ mw.jqueryMsg.getPlugin = function ( options, append ) {
var failableParserFn = getFailableParserFn( options );
return function () {
- var $target = this.empty();
+ var $target = this;
+ if ( !append ) {
+ $target = $target.empty();
+ }
// TODO: Simply appendWithoutParsing( $target,
failableParserFn( arguments ).contents() )
// or Simply appendWithoutParsing( $target,
failableParserFn( arguments ) )
$.each( failableParserFn( arguments ).contents(),
function ( i, node ) {
@@ -1249,6 +1253,13 @@
*/
$.fn.msg = mw.jqueryMsg.getPlugin();
+ /**
+* @method
+* @member jQuery
+* @see mw.jqueryMsg#getPlugin
+*/
+ $.fn.appendMsg = mw.jqueryMsg.getPlugin( {}, true );
+
// Replace the default message parser with jqueryMsg
oldParser = mw.Message.prototype.parser;
mw.Message.prototype.parser = function () {
--
To view, visit https://gerrit.wikimedia.org/r/195363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c6849933f5aebf35cadf5360443775430896e8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.sectionAnchor: Decrease contrast for section ancho... - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/195032
Change subject: mediawiki.sectionAnchor: Decrease contrast for section anchor
symbol
..
mediawiki.sectionAnchor: Decrease contrast for section anchor symbol
Decrease the contrast for section anchor symbol when hovering the heading.
This reduces the distraction by the section anchor symbol.
Bug: T18691
Change-Id: Iecb8f26355204f1f62e1a912eb27ab674954c2ba
---
M includes/EditPage.php
M resources/src/mediawiki/mediawiki.sectionAnchor.css
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/195032/1
diff --git a/includes/EditPage.php b/includes/EditPage.php
index a8a17cf..7116342 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -2997,6 +2997,10 @@
if ( $this-formtype == 'preview' ) {
$this-showPreview( $previewOutput );
} else {
+ $wgOut-addHTML( div class='previewnote'\n .
+ 'h2 id=mw-previewheader' . wfMessage( 'preview'
)-escaped() . /h2 .
+ wfMessage( 'previewnote' )-plain() .
+ '/div' );
// Empty content container for LivePreview
$pageViewLang = $this-mTitle-getPageViewLanguage();
$attribs = array( 'lang' =
$pageViewLang-getHtmlCode(), 'dir' = $pageViewLang-getDir(),
diff --git a/resources/src/mediawiki/mediawiki.sectionAnchor.css
b/resources/src/mediawiki/mediawiki.sectionAnchor.css
index c2a6f3a..131594f 100644
--- a/resources/src/mediawiki/mediawiki.sectionAnchor.css
+++ b/resources/src/mediawiki/mediawiki.sectionAnchor.css
@@ -29,7 +29,7 @@
.mw-headline-anchor,
.mw-headline-anchor:visited {
- color: #888;
+ color: #ccc;
}
.mw-headline-anchor:hover,
--
To view, visit https://gerrit.wikimedia.org/r/195032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecb8f26355204f1f62e1a912eb27ab674954c2ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] sectionAnchor:Move § from HTML to CSS - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/194377
Change subject: sectionAnchor:Move § from HTML to CSS
..
sectionAnchor:Move § from HTML to CSS
This ensures that the HTML not contains a navigation button.
Remove the unused system message section-symbol.
Bug: T18691
Change-Id: I21125761173a1d020b546b249d0fcecfe26d2631
---
M includes/Linker.php
M languages/i18n/en.json
M resources/src/mediawiki/mediawiki.sectionAnchor.css
3 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/77/194377/1
diff --git a/includes/Linker.php b/includes/Linker.php
index a9c26c64..813ff6d 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1760,8 +1760,7 @@
// navigate, so the symbol is being
read during navigation). Pending T13555 being fixed.
'aria-hidden' = 'true',
'title' = wfMessage(
'headline-anchor-title' )-text()
- ),
- wfMessage( 'section-symbol' )-text()
+ )
)
. span class=\mw-headline\
id=\$anchor\$html/span
. $link
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index a81a89e..2b8c4c1 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -3676,6 +3676,5 @@
json-error-recursion: One or more recursive references in the value
to be encoded,
json-error-inf-or-nan: One or more NAN or INF values in the value to
be encoded,
json-error-unsupported-type: A value of a type that cannot be
encoded was given,
- headline-anchor-title: Link to this section,
- section-symbol: §
+ headline-anchor-title: Link to this section
}
diff --git a/resources/src/mediawiki/mediawiki.sectionAnchor.css
b/resources/src/mediawiki/mediawiki.sectionAnchor.css
index c2a6f3a..285ccc1 100644
--- a/resources/src/mediawiki/mediawiki.sectionAnchor.css
+++ b/resources/src/mediawiki/mediawiki.sectionAnchor.css
@@ -13,6 +13,10 @@
user-select: none;
}
+.mw-headline-anchor:after {
+ content: §;
+}
+
/* @noflip */
.mw-content-ltr .mw-headline-anchor,
.mw-content-rtl .mw-content-ltr .mw-headline-anchor {
--
To view, visit https://gerrit.wikimedia.org/r/194377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21125761173a1d020b546b249d0fcecfe26d2631
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Resources.php: Simplify dependencies to single modules - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/194124 Change subject: Resources.php: Simplify dependencies to single modules .. Resources.php: Simplify dependencies to single modules Change-Id: Icaa81662243259f166a28e3b6bb5b8ac6fea4bb3 --- M resources/Resources.php 1 file changed, 15 insertions(+), 43 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/24/194124/1 diff --git a/resources/Resources.php b/resources/Resources.php index 965c783..c01920a 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -776,9 +776,7 @@ 'mediawiki.apihelp' = array( 'styles' = 'resources/src/mediawiki/mediawiki.apihelp.css', 'targets' = array( 'desktop' ), - 'dependencies' = array( - 'mediawiki.hlist', - ), + 'dependencies' = 'mediawiki.hlist', 'position' = 'top', ), 'mediawiki.template' = array( @@ -812,9 +810,7 @@ ), 'mediawiki.api.login' = array( 'scripts' = 'resources/src/mediawiki.api/mediawiki.api.login.js', - 'dependencies' = array( - 'mediawiki.api', - ), + 'dependencies' = 'mediawiki.api', ), 'mediawiki.api.parse' = array( 'scripts' = 'resources/src/mediawiki.api/mediawiki.api.parse.js', @@ -885,18 +881,14 @@ ), 'mediawiki.hidpi' = array( 'scripts' = 'resources/src/mediawiki/mediawiki.hidpi.js', - 'dependencies' = array( - 'jquery.hidpi', - ), + 'dependencies' = 'jquery.hidpi', 'skipFunction' = 'resources/src/mediawiki.hidpi-skip.js', 'targets' = array( 'desktop', 'mobile' ), ), 'mediawiki.hlist' = array( 'styles' = 'resources/src/mediawiki/mediawiki.hlist.css', 'scripts' = 'resources/src/mediawiki/mediawiki.hlist.js', - 'dependencies' = array( - 'jquery.client', - ), + 'dependencies' = 'jquery.client', ), 'mediawiki.htmlform' = array( 'scripts' = 'resources/src/mediawiki/mediawiki.htmlform.js', @@ -928,9 +920,7 @@ = array( 'media' = 'print' ), ), 'scripts' = 'resources/src/mediawiki/mediawiki.notification.js', - 'dependencies' = array( - 'mediawiki.page.startup', - ), + 'dependencies' = 'mediawiki.page.startup', 'targets' = array( 'desktop', 'mobile' ), ), 'mediawiki.notify' = array( @@ -977,9 +967,7 @@ ), 'mediawiki.toc' = array( 'scripts' = 'resources/src/mediawiki/mediawiki.toc.js', - 'dependencies' = array( - 'jquery.cookie', - ), + 'dependencies' = 'jquery.cookie', 'messages' = array( 'showtoc', 'hidetoc' ), 'targets' = array( 'desktop', 'mobile' ), ), @@ -1017,9 +1005,7 @@ ), 'mediawiki.cookie' = array( 'scripts' = 'resources/src/mediawiki/mediawiki.cookie.js', - 'dependencies' = array( - 'jquery.cookie', - ), + 'dependencies' = 'jquery.cookie', 'targets' = array( 'desktop', 'mobile' ), ), 'mediawiki.toolbar' = array( @@ -1132,9 +1118,7 @@ ), 'mediawiki.action.view.redirect' = array( 'scripts' = 'resources/src/mediawiki.action/mediawiki.action.view.redirect.js', - 'dependencies' = array( - 'jquery.client', - ), + 'dependencies' = 'jquery.client', 'position' = 'top', ), 'mediawiki.action.view.redirectPage' = array( @@ -1259,9 +1243,7 @@ ), 'mediawiki.page.startup' = array( 'scripts' = 'resources/src/mediawiki.page/mediawiki.page.startup.js', - 'dependencies' = array( - 'mediawiki.util', - ), + 'dependencies' = 'mediawiki.util', 'position' = 'top', 'targets' = array( 'desktop', 'mobile' ), ), @@ -1320,16 +1302,12 @@ 'mediawiki.special.block' = array( 'scripts' = 'resources/src/mediawiki.special/mediawiki.special.block.js', 'styles' = 'resources/src/mediawiki.special/mediawiki.special.block.css', - 'dependencies' = array( - 'mediawiki.util', - ), + 'dependencies' = 'mediawiki.util', ), 'mediawiki.special.changeemail' =
[MediaWiki-commits] [Gerrit] Add Draft namespace on zhwiki - change (operations/mediawiki-config)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/193827 Change subject: Add Draft namespace on zhwiki .. Add Draft namespace on zhwiki And prevent indexing of the pagesin draft namespace. Please check if I am wrong. Bug: T91223 Change-Id: I65e7db9d78cb209f7ca908d9c16d8fa9faae3f18 --- M wmf-config/InitialiseSettings.php 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/27/193827/1 diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 6167e6d..425e8dd 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -3586,6 +3586,7 @@ 'CAT' = NS_CATEGORY, 'H' = NS_HELP, 'P' = 100, + '草稿' = 118, //T91223 ), '+zhwikibooks' = array( '维基教科书' = NS_PROJECT, @@ -4944,7 +4945,7 @@ 108 = 'Ìwé', 109 = 'Ọ̀rọ̀_ìwé', ), - 'zhwiki' = array( 100 = 'Portal', 101 = 'Portal_talk' ), + 'zhwiki' = array( 100 = 'Portal', 101 = 'Portal_talk', 118 = 'Draft', 119 = 'Draft_talk' ), //T91223 'zh_classicalwiki' = array( 100 = '門', 101 = '議' ), 'zh_min_nanwiki' = array( 100 = 'Portal', 101 = 'Portal_talk' ), 'zh_yuewiki' = array( @@ -9877,6 +9878,10 @@ NS_HELP_TALK = 'noindex,follow', NS_CATEGORY_TALK = 'noindex,follow', ), + 'zhwiki' = array( + 118 = 'noindex,nofollow', // T91223 + 119 = 'noindex,nofollow', + ), ), # @} end of ROBOT @@ -10025,6 +10030,7 @@ 'default' = array(), 'enwiki' = array( 118, 119 ), // draft and draft talk 'hewiki' = array( 118, 119 ), // draft and draft talk - T86329 + 'zhwiki' = array( 118, 119 ), // draft and draft talk - T91223 ), 'wgRevisionCacheExpiry' = array( -- To view, visit https://gerrit.wikimedia.org/r/193827 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65e7db9d78cb209f7ca908d9c16d8fa9faae3f18 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Bugreporter bugreport...@sina.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.sectionAnchor: Show section anchor link when focused - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193797
Change subject: mediawiki.sectionAnchor: Show section anchor link when focused
..
mediawiki.sectionAnchor: Show section anchor link when focused
The new section anchor link is focusable by tabs.
Show the link when focused.
Change-Id: Iaea95333d098c1e2e0b1fc32371ffc72ee7584a9
---
M resources/src/mediawiki/mediawiki.sectionAnchor.css
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/97/193797/1
diff --git a/resources/src/mediawiki/mediawiki.sectionAnchor.css
b/resources/src/mediawiki/mediawiki.sectionAnchor.css
index c2a6f3a..7e65249 100644
--- a/resources/src/mediawiki/mediawiki.sectionAnchor.css
+++ b/resources/src/mediawiki/mediawiki.sectionAnchor.css
@@ -53,7 +53,8 @@
.mw-body h3:focus .mw-headline-anchor,
.mw-body h4:focus .mw-headline-anchor,
.mw-body h5:focus .mw-headline-anchor,
-.mw-body h6:focus .mw-headline-anchor {
+.mw-body h6:focus .mw-headline-anchor,
+.mw-headline-anchor:focus {
filter: alpha(opacity=100);
opacity: 1;
}
--
To view, visit https://gerrit.wikimedia.org/r/193797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaea95333d098c1e2e0b1fc32371ffc72ee7584a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reuse variable profile instead of $.client.profile() - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193861
Change subject: Reuse variable profile instead of $.client.profile()
..
Reuse variable profile instead of $.client.profile()
Change-Id: I66543bd0838b062bea08ca4b5f4fded41ff835cc
---
M modules/jquery.wikiEditor.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/61/193861/1
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 6a8d1db..f6f7df8 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -458,7 +458,7 @@
* Save text selection for old IE (=10)
*/
saveSelection: function () {
- if ( $.client.profile().name === 'msie'
document.selection document.selection.createRange ) {
+ if ( profile.name === 'msie' document.selection
document.selection.createRange ) {
context.$textarea.focus();
context.savedSelection =
document.selection.createRange();
}
@@ -468,7 +468,7 @@
* Restore text selection for old IE (=10)
*/
restoreSelection: function () {
- if ( $.client.profile().name === 'msie'
context.savedSelection !== null ) {
+ if ( profile.name === 'msie' context.savedSelection
!== null ) {
context.$textarea.focus();
context.savedSelection.select();
context.savedSelection = null;
--
To view, visit https://gerrit.wikimedia.org/r/193861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66543bd0838b062bea08ca4b5f4fded41ff835cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add mailto to the allowed URL schemas In I86cff20, Thiemo Mä... - change (mediawiki...Wikibase)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/193669 Change subject: Add mailto to the allowed URL schemas In I86cff20, Thiemo Mättig (WMDE) says: Please note that I currently don't want to add mailto by default, mainly for privacy reasons. .. Add mailto to the allowed URL schemas In I86cff20, Thiemo Mättig (WMDE) says: Please note that I currently don't want to add mailto by default, mainly for privacy reasons. but there're an e-mail property in Wikidata, so supporting mailto is needed. Bug: T91069 Change-Id: Ib05ccb3346e68d7fa9b1b335bb1e35823aefb1e0 --- M lib/config/WikibaseLib.default.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/69/193669/1 diff --git a/lib/config/WikibaseLib.default.php b/lib/config/WikibaseLib.default.php index 9234333..26cf0ba 100644 --- a/lib/config/WikibaseLib.default.php +++ b/lib/config/WikibaseLib.default.php @@ -101,7 +101,7 @@ ), // URL schemes allowed for URL values. See UrlSchemeValidators for a full list. - 'urlSchemes' = array( 'ftp', 'http', 'https', 'irc' ) + 'urlSchemes' = array( 'ftp', 'http', 'https', 'irc', 'mailto' ) ); // experimental stuff -- To view, visit https://gerrit.wikimedia.org/r/193669 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib05ccb3346e68d7fa9b1b335bb1e35823aefb1e0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Bugreporter bugreport...@sina.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.user: Simplify extension of mw.user - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/192599 Change subject: mediawiki.user: Simplify extension of mw.user .. mediawiki.user: Simplify extension of mw.user The module 'mediawiki.user' depends on module 'mediawiki'. 'mediawiki' already defines mw.user with the properties options and tokens and initializes them with mw.Map(). A reinitialization is not necessary. Change-Id: I282a8c0eb62ae960eec495cd8cc94efea9decc2a --- M resources/src/mediawiki/mediawiki.user.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/99/192599/1 diff --git a/resources/src/mediawiki/mediawiki.user.js b/resources/src/mediawiki/mediawiki.user.js index 04d9ec6..c6c46bc 100644 --- a/resources/src/mediawiki/mediawiki.user.js +++ b/resources/src/mediawiki/mediawiki.user.js @@ -8,8 +8,8 @@ byteToHex = [], // Extend the skeleton mw.user from mediawiki.js // This is kind of ugly but we're stuck with this for b/c reasons - options = mw.user.options || new mw.Map(), - tokens = mw.user.tokens || new mw.Map(); + options = mw.user.options, + tokens = mw.user.tokens; /** * Get the current user's groups or rights -- To view, visit https://gerrit.wikimedia.org/r/192599 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I282a8c0eb62ae960eec495cd8cc94efea9decc2a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Apply coding conventions for JavaScript - change (mediawiki...ApiSandbox)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192104
Change subject: Apply coding conventions for JavaScript
..
Apply coding conventions for JavaScript
* Fix whitespaces
* Add closure
* Reduce global variables
Change-Id: I589b3111d8097386139f2732f33ea2c2f55842e0
---
M resources/UiBuilder.js
M resources/apiSandbox.js
M resources/main.js
3 files changed, 25 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApiSandbox
refs/changes/04/192104/1
diff --git a/resources/UiBuilder.js b/resources/UiBuilder.js
index 99a20e6..544e8f8 100644
--- a/resources/UiBuilder.js
+++ b/resources/UiBuilder.js
@@ -192,7 +192,7 @@
$node = $( '#param-' + name );
if ( param.type === 'boolean' ) {
if ( $node.prop( 'checked' )
=== true ) {
- //the = is needed (at
least in post), see bug 25174
+ // the = is needed (at
least in post), see bug 25174
params += '' + name +
'=';
}
} else {
diff --git a/resources/apiSandbox.js b/resources/apiSandbox.js
index 7601c98..5b3be04 100644
--- a/resources/apiSandbox.js
+++ b/resources/apiSandbox.js
@@ -1,22 +1,24 @@
/*jslint regexp: true, browser: true, continue: true, sloppy: true, white:
true, forin: true, plusplus: true */
-/*global mediaWiki,mw */
-mediaWiki.apiSandbox = {
- namespaceOptions: [],
+/*global jQuery, mediaWiki */
+( function ( $, mw ) {
+ mw.apiSandbox = {
+ namespaceOptions: [],
- // build namespace cache
- init: function() {
- $.each( mw.config.get( 'wgFormattedNamespaces' ), function (
nsId, nsName ) {
- if ( Number( nsId ) = 0 ) {
- if ( nsId === '0' ) {
- nsName = mw.msg( 'apisb-ns-main' );
+ // build namespace cache
+ init: function () {
+ $.each( mw.config.get( 'wgFormattedNamespaces' ),
function ( nsId, nsName ) {
+ if ( Number( nsId ) = 0 ) {
+ if ( nsId === '0' ) {
+ nsName = mw.msg(
'apisb-ns-main' );
+ }
+ mw.apiSandbox.namespaceOptions.push( {
+ key: nsId,
+ value: nsName
+ } );
}
- mw.apiSandbox.namespaceOptions.push( {
- key: nsId,
- value: nsName
- } );
- }
- } );
- }
-};
+ } );
+ }
+ };
-mediaWiki.apiSandbox.init();
+ mw.apiSandbox.init();
+}( jQuery, mediaWiki ) );
diff --git a/resources/main.js b/resources/main.js
index a2f94c8..0ee1ab3 100644
--- a/resources/main.js
+++ b/resources/main.js
@@ -1,4 +1,4 @@
-/*global jQuery, mediaWiki, apiSandbox, mw*/
+/*global jQuery, mediaWiki*/
/*jslint regexp: true, browser: true, continue: true, sloppy: true, white:
true, forin: true, plusplus: true */
( function ( $, mw, apiSandbox, undefined ) {
@@ -380,7 +380,7 @@
function () {
var info = {};
if ( isQuery ) {
- $.each( queryModules, function ( key,
queryModule ) {
+ $.each( queryModules, function ( key,
queryModule ) {
info[queryModule] =
paramInfo.querymodules[queryModule];
} );
} else {
@@ -434,7 +434,7 @@
*
* @param html {string} HTML source of a MediaWiki page
* @return {number|null} Backend response time in seconds or null if a
value
-* could not be extracted
+* could not be extracted
*/
function extractResponseTime( html ) {
var match;
@@ -669,4 +669,4 @@
} );
doHash();
} );
-}( jQuery, mediaWiki, mw.apiSandbox ) );
+}( jQuery, mediaWiki, mediaWiki.apiSandbox ) );
--
To view, visit https://gerrit.wikimedia.org/r/192104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id:
[MediaWiki-commits] [Gerrit] mediawiki.special.preferences.js: Simplify modulo - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191869
Change subject: mediawiki.special.preferences.js: Simplify modulo
..
mediawiki.special.preferences.js: Simplify modulo
See:
https://stackoverflow.com/questions/4467539/javascript-modulo-not-behaving
Change-Id: Id3efc7c7a1a57dcbb33ba1272ed5a20428ee6433
---
M resources/src/mediawiki.special/mediawiki.special.preferences.js
1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/69/191869/1
diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 2e660ce..6ea7501 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -223,12 +223,8 @@
localTime = servertime + minuteDiff;
// Bring time within the [0,1440) range.
- while ( localTime 0 ) {
- localTime += 1440;
- }
- while ( localTime = 1440 ) {
- localTime -= 1440;
- }
+ localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
+
$localtimeHolder.text( mediaWiki.language.convertNumber(
minutesToHours( localTime ) ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/191869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3efc7c7a1a57dcbb33ba1272ed5a20428ee6433
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.special.preferences.js: Simplify creating elements - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191871
Change subject: mediawiki.special.preferences.js: Simplify creating elements
..
mediawiki.special.preferences.js: Simplify creating elements
See:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Creating_elements
Change-Id: Ied43829eb19a4270030af4d3f41882f6c0df7935
---
M resources/src/mediawiki.special/mediawiki.special.preferences.js
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/191871/1
diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 2e660ce..e73ad73 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -12,8 +12,11 @@
};
$( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
- $preftoc = $( 'ul id=preftoc/ul' )
- .attr( 'role', 'tablist' );
+ $preftoc = $( 'ul' )
+ .attr( {
+ id: 'preftoc',
+ role: 'tablist'
+ } );
$preferences = $( '#preferences' )
.addClass( 'jsprefs' )
.before( $preftoc );
--
To view, visit https://gerrit.wikimedia.org/r/191871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied43829eb19a4270030af4d3f41882f6c0df7935
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable edit section buttons on live preview - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191556
Change subject: Disable edit section buttons on live preview
..
Disable edit section buttons on live preview
The classical preview also does not show edit section buttons.
Bug: T89941
Change-Id: I5f9e06f33253cd155e063305b822d4ae6d155011
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/56/191556/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 68fbe33..e4ccf2b 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -101,7 +101,8 @@
$.extend( postData, {
pst: '',
preview: '',
- prop:
'text|displaytitle|modules|categorieshtml|templates|langlinks|limitreporthtml'
+ prop:
'text|displaytitle|modules|categorieshtml|templates|langlinks|limitreporthtml',
+ disableeditsection: true
} );
if ( section !== '' ) {
postData.sectionpreview = '';
--
To view, visit https://gerrit.wikimedia.org/r/191556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f9e06f33253cd155e063305b822d4ae6d155011
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove CSS definition for tables in dialogs - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190812
Change subject: Remove CSS definition for tables in dialogs
..
Remove CSS definition for tables in dialogs
The only dialog with a table is the table creator dialog.
For this table a more specific definition exist in
jquery.wikiEditor.dialogs.config.css
These rules overwrite all here removed definitions except of
wikiEditor-toolbar-dialog table { margin-top: 0.75em; }
Without this definition the margin-top slightly increase to the
definition from .wikitable with margin-top: 1em.
Change-Id: I0aab246db05cb4330287666f6a71b56d6b88b0af
---
M modules/jquery.wikiEditor.dialogs.css
1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/12/190812/1
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index 942c66f..8f22683 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -2,23 +2,9 @@
* CSS for WikiEditor Dialogs jQuery plugin
*/
-.wikiEditor-toolbar-dialog table {
- margin-top: 0.75em;
-}
-
-.wikiEditor-toolbar-dialog table td {
- padding: 0.5em;
- height: 3em;
- overflow: visible;
-}
-
/* Put suggestions (default z-index 99) on top of dialogs (z-index 1002) */
div.suggestions {
z-index: 1099;
-}
-
-.wikiEditor-toolbar-dialog table td {
- padding: 0 !important;
}
.wikiEditor-toolbar-dialog .ui-dialog-content fieldset {
--
To view, visit https://gerrit.wikimedia.org/r/190812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0aab246db05cb4330287666f6a71b56d6b88b0af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] jquery.makeCollapsible: Align toggle based on content language - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190713
Change subject: jquery.makeCollapsible: Align toggle based on content language
..
jquery.makeCollapsible: Align toggle based on content language
The collapsible toggle button is in user interface language but the alignment
of this button should fit to the direction of the content language.
Change-Id: I31927b8e091bdf81458c7d3d0cd5f6040af5f0f4
---
M resources/src/jquery/jquery.makeCollapsible.css
1 file changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/13/190713/1
diff --git a/resources/src/jquery/jquery.makeCollapsible.css
b/resources/src/jquery/jquery.makeCollapsible.css
index 0f47150..2e5efba 100644
--- a/resources/src/jquery/jquery.makeCollapsible.css
+++ b/resources/src/jquery/jquery.makeCollapsible.css
@@ -6,18 +6,38 @@
-ms-user-select: none;
user-select: none;
}
+/* Align the toggle based on the direction of the content language */
+/* @noflip */
+.mw-content-ltr .mw-collapsible-toggle,
+.mw-content-rtl .mw-content-ltr .mw-collapsible-toggle {
+ float: right;
+}
+/* @noflip */
+.mw-content-rtl .mw-collapsible-toggle,
+.mw-content-ltr .mw-content-rtl .mw-collapsible-toggle {
+ float: left;
+}
+
.mw-customtoggle,
.mw-collapsible-toggle {
cursor: pointer;
}
/* collapse links in captions should be inline */
-caption .mw-collapsible-toggle {
+caption .mw-collapsible-toggle,
+.mw-content-ltr caption .mw-collapsible-toggle,
+.mw-content-rtl caption .mw-collapsible-toggle,
+.mw-content-rtl .mw-content-ltr caption .mw-collapsible-toggle,
+.mw-content-ltr .mw-content-rtl caption .mw-collapsible-toggle {
float: none;
}
/* list-items go as wide as their parent element, don't float them inside list
items */
-li .mw-collapsible-toggle {
+li .mw-collapsible-toggle,
+.mw-content-ltr li .mw-collapsible-toggle,
+.mw-content-rtl li .mw-collapsible-toggle,
+.mw-content-rtl .mw-content-ltr li .mw-collapsible-toggle,
+.mw-content-ltr .mw-content-rtl li .mw-collapsible-toggle {
float: none;
}
--
To view, visit https://gerrit.wikimedia.org/r/190713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31927b8e091bdf81458c7d3d0cd5f6040af5f0f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.user: Simplify mw.user.generateRandomSessionId - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190640
Change subject: mediawiki.user: Simplify mw.user.generateRandomSessionId
..
mediawiki.user: Simplify mw.user.generateRandomSessionId
Change-Id: I6e6ac9e0813c4ba540e0a53b8e6667162cb60bf7
---
M resources/src/mediawiki/mediawiki.user.js
1 file changed, 9 insertions(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/190640/1
diff --git a/resources/src/mediawiki/mediawiki.user.js
b/resources/src/mediawiki/mediawiki.user.js
index c3ec3f3..537eaa5 100644
--- a/resources/src/mediawiki/mediawiki.user.js
+++ b/resources/src/mediawiki/mediawiki.user.js
@@ -3,19 +3,12 @@
* @singleton
*/
( function ( mw, $ ) {
- var user, i,
+ var user,
deferreds = {},
- byteToHex = [],
// Extend the skeleton mw.user from mediawiki.js
// This is kind of ugly but we're stuck with this for b/c
reasons
options = mw.user.options || new mw.Map(),
tokens = mw.user.tokens || new mw.Map();
-
- // Maps for number - hex string conversion (with padding)
- // idea from: https://github.com/broofa/node-uuid/blob/master/uuid.js
- for ( i = 0; i 256; i++ ) {
- byteToHex[i] = (i + 0x100).toString(16).substr(1);
- }
/**
* Get the current user's groups or rights
@@ -75,28 +68,23 @@
* @return {string} 64 bit integer in hex format, padded
*/
generateRandomSessionId: function () {
- /*jshint bitwise:false */
- var rnds, i, r, cryptoObj, hexRnds = new Array( 8 );
+ var rnds, i, cryptoObj, hexRnds = new Array( 2 );
cryptoObj = window.crypto || window.msCrypto; // for IE
11
if ( cryptoObj ) {
- // We fill an array with 8 random values, each
of which is 8 bits.
+ // We fill an array with 2 random values, each
of which is 32 bits.
// note that rnds is an array-like object not a
true array
- rnds = new Uint8Array( 8 );
+ rnds = new Uint32Array( 2 );
cryptoObj.getRandomValues( rnds );
} else {
- rnds = new Array( 8 );
- // From:
https://github.com/broofa/node-uuid/blob/master/uuid.js
- for ( i = 0, r; i 8; i++ ) {
- if ( ( i 0x03 ) === 0 ) {
- r = Math.random() * 0x1;
- }
- rnds[i] = r ( ( i 0x03 ) 3 )
0xff;
+ rnds = new Array( 2 );
+ for ( i = 0, r; i 2; i++ ) {
+ rnds[i] = Math.floor( Math.random() *
0x1 );
}
}
- // convert to hex using byteToHex that already contains
padding
+ // convert to hex
for ( i = 0; i rnds.length; i++ ) {
- hexRnds[i] = byteToHex[rnds[i]];
+ hexRnds[i] = ( rnds[i] + 0x1
).toString( 16 ).substr( 1 );
}
// concatenation of two random integers with entrophy n
and m
--
To view, visit https://gerrit.wikimedia.org/r/190640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e6ac9e0813c4ba540e0a53b8e6667162cb60bf7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove color overwrite for dialog header border bottom - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190682
Change subject: Remove color overwrite for dialog header border bottom
..
Remove color overwrite for dialog header border bottom
This changes the color of the line under the hader of the dialog boxes
from #6bc8f3 to the default #aed0ea.
This difference is nearly not recognizable and it is not worth to overwrite
the default color.
Change-Id: I88580ab74fc158ec1a498fc489fbdd9cd5ba897a
---
M modules/jquery.wikiEditor.dialogs.css
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/82/190682/1
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index 942c66f..1c7c8e7 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -27,10 +27,6 @@
padding: 0 !important;
}
-.wikiEditor-toolbar-dialog .ui-widget-header {
- border-bottom:1px solid #6bc8f3 !important;
-}
-
.wikiEditor-toolbar-dialog .ui-dialog-content input[type=text] {
-moz-box-sizing: border-box;
-ms-box-sizing: border-box;
--
To view, visit https://gerrit.wikimedia.org/r/190682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88580ab74fc158ec1a498fc489fbdd9cd5ba897a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use mw.libs.pluralRuleParser directly - change (mediawiki...UniversalLanguageSelector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190446
Change subject: Use mw.libs.pluralRuleParser directly
..
Use mw.libs.pluralRuleParser directly
Use mw.libs.pluralRuleParser directly instead of aliasing it to
window.pluralRuleParser.
Bug: T89351
Change-Id: I304372901560a8e9ea201f5ea4515cd7339314b6
---
M lib/jquery.i18n/jquery.i18n.language.js
M resources/js/ext.uls.i18n.js
2 files changed, 3 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/46/190446/1
diff --git a/lib/jquery.i18n/jquery.i18n.language.js
b/lib/jquery.i18n/jquery.i18n.language.js
index ee6eacb..5121be8 100644
--- a/lib/jquery.i18n/jquery.i18n.language.js
+++ b/lib/jquery.i18n/jquery.i18n.language.js
@@ -1,5 +1,4 @@
-/*global pluralRuleParser */
-( function ( $ ) {
+( function ( $, mw ) {
'use strict';
var language = {
@@ -327,7 +326,7 @@
for ( i = 0; i pluralForms.length; i++ ) {
if ( pluralRules[pluralForms[i]] ) {
- if ( pluralRuleParser(
pluralRules[pluralForms[i]], number ) ) {
+ if ( mw.libs.pluralRuleParser(
pluralRules[pluralForms[i]], number ) ) {
return pluralFormIndex;
}
@@ -468,4 +467,4 @@
$.extend( $.i18n.languages, {
'default': language
} );
-}( jQuery ) );
+}( jQuery, mediaWiki ) );
diff --git a/resources/js/ext.uls.i18n.js b/resources/js/ext.uls.i18n.js
index e854c19..3633d93 100644
--- a/resources/js/ext.uls.i18n.js
+++ b/resources/js/ext.uls.i18n.js
@@ -21,10 +21,6 @@
mw.uls = mw.uls || {};
- // jquery.i18n has CLDRPluralRuleParser but MediaWiki also has the same
- // parser. Reuse it by aliasing it to window.pluralRuleParser
- window.pluralRuleParser = mw.libs.pluralRuleParser;
-
// JavaScript side i18n initialization
$.i18n( {
locale: mw.config.get( 'wgUserLanguage' )
--
To view, visit https://gerrit.wikimedia.org/r/190446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I304372901560a8e9ea201f5ea4515cd7339314b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rework color definition in CSS - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190175
Change subject: Rework color definition in CSS
..
Rework color definition in CSS
* Use #rgb instead of #rrggbb where possible.
* Use lower case letters.
Change-Id: I390bf23d44bc2d78eb1d2185fd89b94297d1f05f
---
M modules/jquery.wikiEditor.css
M modules/jquery.wikiEditor.dialogs.config.css
M modules/jquery.wikiEditor.dialogs.css
M modules/jquery.wikiEditor.preview.css
M modules/jquery.wikiEditor.toolbar.css
5 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/75/190175/1
diff --git a/modules/jquery.wikiEditor.css b/modules/jquery.wikiEditor.css
index cabe6a9..35cf099 100644
--- a/modules/jquery.wikiEditor.css
+++ b/modules/jquery.wikiEditor.css
@@ -6,7 +6,7 @@
position: relative;
clear: both;
width: 100%;
- background-color: #E0EEf7;
+ background-color: #e0eef7;
}
.wikiEditor-ui textarea {
width: 100%;
@@ -31,7 +31,7 @@
}
.wikiEditor-ui .wikiEditor-ui-right {
float: right;
- background: #F3F3F3;
+ background: #f3f3f3;
overflow: hidden;
}
.wikiEditor-wikitext {
@@ -77,10 +77,10 @@
display: inline-block;
padding: 0 0.75em;
line-height: 2.5em;
- color: #0645AD;
+ color: #0645ad;
}
.wikiEditor-ui-tabs div.current a {
- color: #33;
+ color: #333;
}
.wikiEditor-ui-tabs div.current a:hover {
text-decoration: none;
diff --git a/modules/jquery.wikiEditor.dialogs.config.css
b/modules/jquery.wikiEditor.dialogs.config.css
index f34e7f0..e34b818 100644
--- a/modules/jquery.wikiEditor.dialogs.config.css
+++ b/modules/jquery.wikiEditor.dialogs.config.css
@@ -169,7 +169,7 @@
}
/* End hide from IE-mac */
.wikiEditor-toolbar-dialog .ui-dialog-buttonpane {
- border-top: 1px solid #cc !important;
+ border-top: 1px solid #ccc !important;
}
.wikiEditor-toolbar-dialog .ui-dialog-content {
padding-bottom: 1em !important;
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index 942c66f..77b715b 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -61,7 +61,7 @@
}
.wikieditor-toolbar-dialog-hint {
- color: #99;
+ color: #999;
}
.wikiEditor-toolbar-dialog {
diff --git a/modules/jquery.wikiEditor.preview.css
b/modules/jquery.wikiEditor.preview.css
index 6b026a1..4a6a1e7 100644
--- a/modules/jquery.wikiEditor.preview.css
+++ b/modules/jquery.wikiEditor.preview.css
@@ -8,7 +8,7 @@
}
.wikiEditor-preview-loading span {
- color: #66;
+ color: #666;
}
.wikiEditor-preview-spinner {
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 83afbe3..6dc5536 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -21,8 +21,8 @@
.wikiEditor-ui-toolbar .sections .section {
float: left;
width: 100%;
- border-top: 1px solid #DD;
- background-color: #E0EEf7;
+ border-top: 1px solid #ddd;
+ background-color: #e0eef7;
}
.wikiEditor-ui-toolbar .sections .section-hidden {
@@ -49,7 +49,7 @@
padding-left: 32px;
margin-left: 0.5em;
height: 32px;
- color: #66;
+ color: #666;
}
/* Top Level Containers */
.wikiEditor-ui-toolbar .tabs,
@@ -64,14 +64,14 @@
float: left;
height: 26px;
padding-right: 6px;
- border-right: 1px solid #DD;
+ border-right: 1px solid #ddd;
margin: 3px;
}
.wikiEditor-ui-toolbar .group-search {
float: right;
padding: 0 0 0 6px;
border-right: none;
- border-left: 1px solid #DD;
+ border-left: 1px solid #ddd;
}
.wikiEditor-ui-toolbar .group-insert {
border-right: none;
@@ -115,7 +115,7 @@
}
.wikiEditor-ui-toolbar .tabs span.tab a.current,
.wikiEditor-ui-toolbar .tabs span.tab a.current:visited {
- color: #33;
+ color: #333;
/* @embed */
background-image: url(images/toolbar/arrow-down.png);
}
@@ -135,7 +135,7 @@
margin: 2px;
margin-left: 5px;
margin-right: 8px;
- color: #77;
+ color: #777;
cursor: default;
}
.wikiEditor-ui-toolbar .group img.tool {
@@ -155,7 +155,7 @@
padding: 0;
margin-right: 0;
cursor: pointer;
- background-color: #ff;
+ background-color: #fff;
}
.wikiEditor-ui-toolbar .group .tool-select .label {
/* @embed */
@@ -169,7 +169,7 @@
margin-right: 4px;
cursor: pointer;
text-decoration: none;
- color: #33;
+ color: #333;
}
.wikiEditor-ui-toolbar .group .tool-select .menu .options {
position: absolute;
@@ -177,7
[MediaWiki-commits] [Gerrit] [DO NOT SUBMIT] testing jenkins after +1 - change (pywikibot/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/189913 Change subject: [DO NOT SUBMIT] testing jenkins after +1 .. [DO NOT SUBMIT] testing jenkins after +1 Change-Id: I33f749680e48ca9f911d5e5c18e735c0960ea6ee --- M tests/site_tests.py 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/13/189913/1 diff --git a/tests/site_tests.py b/tests/site_tests.py index d8daebf..cbf6815 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -1325,15 +1325,12 @@ Test random methods of a site. def test_unlimited_small_step(self): -Test site.randompages() continuation. - -Note that uniqueness is not guaranteed if multiple requests are -performed, so we also don't test this here. - +Test site.randompages() without limit. mysite = self.get_site() pages = [] for rndpage in mysite.randompages(step=5, total=None): self.assertIsInstance(rndpage, pywikibot.Page) +self.assertNotIn(rndpage, pages) pages.append(rndpage) if len(pages) == 11: break -- To view, visit https://gerrit.wikimedia.org/r/189913 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33f749680e48ca9f911d5e5c18e735c0960ea6ee Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Pywikipedia Conversion Bot valhall...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] SpecialWhatlinkshere: Mark redirects containing templates - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/189714 Change subject: SpecialWhatlinkshere: Mark redirects containing templates .. SpecialWhatlinkshere: Mark redirects containing templates Mark redirects containing templates with class mw-redirect on Special:WhatLinksHere. Bug: T89098 Change-Id: Icd921c25a9c3542acb44e7175195328f283a1d5c --- M includes/specials/SpecialWhatlinkshere.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/14/189714/1 diff --git a/includes/specials/SpecialWhatlinkshere.php b/includes/specials/SpecialWhatlinkshere.php index bbc111f..28be790 100644 --- a/includes/specials/SpecialWhatlinkshere.php +++ b/includes/specials/SpecialWhatlinkshere.php @@ -177,7 +177,7 @@ ); return $dbr-select( array( 'page', 'temp_backlink_range' = ($subQuery) ), - array( 'page_id', 'page_namespace', 'page_title', 'rd_from' ), + array( 'page_id', 'page_namespace', 'page_title', 'rd_from', 'page_is_redirect' ), array(), __CLASS__ . '::showIndirectLinks', array( 'ORDER BY' = 'page_id', 'LIMIT' = $queryLimit ), @@ -321,7 +321,7 @@ $link = Linker::linkKnown( $nt, null, - array(), + $row-page_is_redirect ? array( 'class' = 'mw-redirect' ) : array(), $query ); -- To view, visit https://gerrit.wikimedia.org/r/189714 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd921c25a9c3542acb44e7175195328f283a1d5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Generate valid HTML code on error pages - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/189465 Change subject: Generate valid HTML code on error pages .. Generate valid HTML code on error pages For img_auth.php see http://validator.w3.org/check?uri=https%3A%2F%2Fwww.mediawiki.org%2Fw%2Fimg_auth.php;No200=1 For profileinfo.php consistently use / for self-closing elements. Change-Id: I7e6aad0e7a2a745836adc430e3b2f3be5f31b6bb --- M img_auth.php M profileinfo.php 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/65/189465/1 diff --git a/img_auth.php b/img_auth.php index 51470b6..f44cac0 100644 --- a/img_auth.php +++ b/img_auth.php @@ -201,7 +201,12 @@ header( 'Cache-Control: no-cache' ); header( 'Content-Type: text/html; charset=utf-8' ); echo ENDS +!DOCTYPE html html +head +meta charset=UTF-8 / +title$msgHdr/title +/head body h1$msgHdr/h1 p$detailMsg/p diff --git a/profileinfo.php b/profileinfo.php index 4e3fb5a..f172cfb 100644 --- a/profileinfo.php +++ b/profileinfo.php @@ -36,7 +36,7 @@ !DOCTYPE html html head - meta charset=UTF-8 + meta charset=UTF-8 / titleProfiling data/title style /* noc.wikimedia.org/base.css */ @@ -422,7 +422,7 @@ ? /tbody /table -hr +hr / pTotal time: code?php printf( '%5.02f', profile_point::$totaltime ); ?/code/p pTotal memory: code?php printf( '%5.02f', profile_point::$totalmemory / 1024 ); ?/code/p -- To view, visit https://gerrit.wikimedia.org/r/189465 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e6aad0e7a2a745836adc430e3b2f3be5f31b6bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove line under headings - change (mediawiki...Wikibase)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189209
Change subject: Remove line under headings
..
Remove line under headings
Follow-up to Ic4d3aa077eb5e6f9d760137ccf4d7e36d243a053
Change-Id: Ie34bd51217d08e2e4f864c6d29ce433f8e069d4d
---
M lib/resources/wikibase.css
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/09/189209/1
diff --git a/lib/resources/wikibase.css b/lib/resources/wikibase.css
index edbd1a4..0229f2e 100644
--- a/lib/resources/wikibase.css
+++ b/lib/resources/wikibase.css
@@ -83,8 +83,12 @@
margin-bottom: 0.2em;
margin-top: 1em;
padding-left: 10px;
- border-bottom: none;
width: 100%;
+}
+
+/* Remove line under the heading */
+h2.wb-section-heading:after {
+ display: none;
}
.wikibase-entityview input {
@@ -626,7 +630,11 @@
margin-top: 2em;
margin-bottom: 0.2em;
padding-left: 10px;
- border-bottom: none;
+}
+
+/* Remove line under the heading */
+h2.wb-sitelinks-heading:after {
+ display: none;
}
.wb-section-heading .sitelinklistview-counter {
--
To view, visit https://gerrit.wikimedia.org/r/189209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie34bd51217d08e2e4f864c6d29ce433f8e069d4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Convert all language codes for JavaScript with wfBCP47 - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189205
Change subject: Convert all language codes for JavaScript with wfBCP47
..
Convert all language codes for JavaScript with wfBCP47
For the HTML attribute lang the PHP function wfBCP47 is already applied.
This allows to generate HTML from JavaScript with the same values like in PHP.
This avoids to reimplement wfBCP47 in JavaScript.
This ensures to have the same representation in HTML and JavaScript.
Change-Id: I9db7a1828f9bbb174f5c30e6f3d136fcde46af94
---
M includes/OutputPage.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderLanguageDataModule.php
M includes/resourceloader/ResourceLoaderLanguageNamesModule.php
M includes/resourceloader/ResourceLoaderStartUpModule.php
5 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/189205/1
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 5c146e4..6687569 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3189,7 +3189,7 @@
'wgUserGroups' = $user-getEffectiveGroups(),
'wgCategories' = $this-getCategories(),
'wgBreakFrames' = $this-getFrameOptions() == 'DENY',
- 'wgPageContentLanguage' = $lang-getCode(),
+ 'wgPageContentLanguage' = $lang-getHtmlCode(),
'wgPageContentModel' = $title-getContentModel(),
'wgSeparatorTransformTable' =
$compactSeparatorTransTable,
'wgDigitTransformTable' = $compactDigitTransTable,
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index 15bb13f..f65f50f 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -1481,7 +1481,7 @@
) {
$query = array(
'modules' = self::makePackedModulesString( $modules ),
- 'lang' = $lang,
+ 'lang' = wfBCP47( $lang ),
'skin' = $skin,
'debug' = $debug ? 'true' : 'false',
);
diff --git a/includes/resourceloader/ResourceLoaderLanguageDataModule.php
b/includes/resourceloader/ResourceLoaderLanguageDataModule.php
index 1239453..a9595c7 100644
--- a/includes/resourceloader/ResourceLoaderLanguageDataModule.php
+++ b/includes/resourceloader/ResourceLoaderLanguageDataModule.php
@@ -55,7 +55,7 @@
return Xml::encodeJsCall(
'mw.language.setData',
array(
- $context-getLanguage(),
+ wfBCP47( $context-getLanguage() ),
$this-getData( $context )
),
ResourceLoader::inDebugMode()
diff --git a/includes/resourceloader/ResourceLoaderLanguageNamesModule.php
b/includes/resourceloader/ResourceLoaderLanguageNamesModule.php
index 55b1f4b..b6ff3b9 100644
--- a/includes/resourceloader/ResourceLoaderLanguageNamesModule.php
+++ b/includes/resourceloader/ResourceLoaderLanguageNamesModule.php
@@ -52,7 +52,7 @@
return Xml::encodeJsCall(
'mw.language.setData',
array(
- $context-getLanguage(),
+ wfBCP47( $context-getLanguage() ),
'languageNames',
$this-getData( $context )
),
diff --git a/includes/resourceloader/ResourceLoaderStartUpModule.php
b/includes/resourceloader/ResourceLoaderStartUpModule.php
index 48b3576..dceb42d 100644
--- a/includes/resourceloader/ResourceLoaderStartUpModule.php
+++ b/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -80,8 +80,8 @@
'wgActionPaths' = (object)$conf-get( 'ActionPaths' ),
'wgServer' = $conf-get( 'Server' ),
'wgServerName' = $conf-get( 'ServerName' ),
- 'wgUserLanguage' = $context-getLanguage(),
- 'wgContentLanguage' = $wgContLang-getCode(),
+ 'wgUserLanguage' = wfBCP47( $context-getLanguage() ),
+ 'wgContentLanguage' = $wgContLang-getHtmlCode(),
'wgVersion' = $conf-get( 'Version' ),
'wgEnableAPI' = $conf-get( 'EnableAPI' ),
'wgEnableWriteAPI' = $conf-get( 'EnableWriteAPI' ),
--
To view, visit https://gerrit.wikimedia.org/r/189205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9db7a1828f9bbb174f5c30e6f3d136fcde46af94
Gerrit-PatchSet: 1
[MediaWiki-commits] [Gerrit] Apply coding conventions for JavaScript - change (mediawiki...UniversalLanguageSelector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189237
Change subject: Apply coding conventions for JavaScript
..
Apply coding conventions for JavaScript
Change-Id: Id158ac08d32cc7421e47ae6abdd2bd80879f04d9
---
M resources/js/ext.uls.compactlinks.js
M resources/js/ext.uls.displaysettings.js
M resources/js/ext.uls.webfonts.js
3 files changed, 5 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/37/189237/1
diff --git a/resources/js/ext.uls.compactlinks.js
b/resources/js/ext.uls.compactlinks.js
index fe06882..20364f8 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -239,7 +239,7 @@
var assistantLanguages = mw.user.options.get(
'translate-editlangs' );
if ( assistantLanguages assistantLanguages !==
'default' ) {
- return $.grep(
assistantLanguages.split(/,\s*/), function ( language ) {
+ return $.grep( assistantLanguages.split( /,\s*/
), function ( language ) {
return $.inArray( language, languages )
= 0;
} );
}
diff --git a/resources/js/ext.uls.displaysettings.js
b/resources/js/ext.uls.displaysettings.js
index bf57aed..3d90e05 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -533,7 +533,7 @@
mw.webfonts.setup();
// Allow the webfonts library
to finish loading
- setTimeout( function() {
+ setTimeout( function () {
displaySettings.$webfonts = $( 'body' ).data( 'webfonts' );
mw.webfonts.preferences.enable();
diff --git a/resources/js/ext.uls.webfonts.js b/resources/js/ext.uls.webfonts.js
index 745549a..f905f74 100644
--- a/resources/js/ext.uls.webfonts.js
+++ b/resources/js/ext.uls.webfonts.js
@@ -98,10 +98,10 @@
for ( index = 0; index length; index++ ) {
$fixture.text( text[index] );
- width[index] = $fixture.width() || width[index-1];
+ width[index] = $fixture.width() || width[index - 1];
height[index] = $fixture.height();
- if( index 0
+ if ( index 0
( width[index] !== width[index - 1] ||
height[index] !== height[index - 1] )
) {
@@ -206,7 +206,7 @@
// Execute after task queue is processed so that the rendering
is complete.
// This is important because webfonts behavior depends on the
font-family
// property values set by stylesheets.
- setTimeout( function() {
+ setTimeout( function () {
$( 'body' ).webfonts();
// Load the CSS required for the Autonym font. Note
that this won't download the font.
--
To view, visit https://gerrit.wikimedia.org/r/189237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id158ac08d32cc7421e47ae6abdd2bd80879f04d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] blabla test - change (sandbox)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188765
Change subject: blabla test
..
blabla test
Change-Id: I6d1f725eab4440879c05d9f98ab08422e1c547f4
---
M org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/sandbox refs/changes/65/188765/1
diff --git
a/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
b/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
index c29143f..fbc9173 100644
---
a/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
+++
b/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
@@ -41,7 +41,6 @@
new Plus();
new Square();
new Divide();
- new Multiply();
}
private void calculate(String cmdName) {
--
To view, visit https://gerrit.wikimedia.org/r/188765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d1f725eab4440879c05d9f98ab08422e1c547f4
Gerrit-PatchSet: 1
Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Pywikipedia Conversion Bot valhall...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] thumb.php: Generate valid HTML code on error page - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/188789 Change subject: thumb.php: Generate valid HTML code on error page .. thumb.php: Generate valid HTML code on error page http://validator.w3.org/check?uri=https%3A%2F%2Fwww.mediawiki.org%2Fw%2Fthumb.php;No200=1 criticize Error Line 1, Column 1: no document type declaration; implying !DOCTYPE HTML SYSTEM Change-Id: I8dcb6c7f342957ec473fe481aef2011a193ef8a5 --- M thumb.php 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/89/188789/1 diff --git a/thumb.php b/thumb.php index 7352dc4..b49ec19 100644 --- a/thumb.php +++ b/thumb.php @@ -622,7 +622,11 @@ $debug = ''; } echo EOT -htmlheadtitleError generating thumbnail/title/head +!DOCTYPE html +htmlhead +meta charset=UTF-8 / +titleError generating thumbnail/title +/head body h1Error generating thumbnail/h1 p -- To view, visit https://gerrit.wikimedia.org/r/188789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8dcb6c7f342957ec473fe481aef2011a193ef8a5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ... - change (sandbox)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188777
Change subject: ...
..
...
Change-Id: Ibf3a7a82bef6a092a0ed11c7daab8b7145e9b01e
---
M org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/sandbox refs/changes/77/188777/1
diff --git
a/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
b/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
index c29143f..fbc9173 100644
---
a/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
+++
b/org.eclipse.example.calc/src/org/eclipse/example/calc/internal/Calculator.java
@@ -41,7 +41,6 @@
new Plus();
new Square();
new Divide();
- new Multiply();
}
private void calculate(String cmdName) {
--
To view, visit https://gerrit.wikimedia.org/r/188777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf3a7a82bef6a092a0ed11c7daab8b7145e9b01e
Gerrit-PatchSet: 1
Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Pywikipedia Conversion Bot valhall...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.language.init: Ignore case of language code - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188520
Change subject: mediawiki.language.init: Ignore case of language code
..
mediawiki.language.init: Ignore case of language code
This allows capitalization suggested by BCP 47 without the risk
of duplicate entries.
Change-Id: I0ebdead5440862c087920fa93e85aeb47464272e
---
M resources/src/mediawiki.language/mediawiki.language.init.js
M tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/188520/1
diff --git a/resources/src/mediawiki.language/mediawiki.language.init.js
b/resources/src/mediawiki.language/mediawiki.language.init.js
index df95d75..b3765c8 100644
--- a/resources/src/mediawiki.language/mediawiki.language.init.js
+++ b/resources/src/mediawiki.language/mediawiki.language.init.js
@@ -54,6 +54,7 @@
*/
getData: function ( langCode, dataKey ) {
var langData = mw.language.data;
+ langCode = langCode.toLowerCase();
if ( langData langData[langCode] instanceof mw.Map )
{
return langData[langCode].get( dataKey );
}
@@ -71,6 +72,7 @@
*/
setData: function ( langCode, dataKey, value ) {
var langData = mw.language.data;
+ langCode = langCode.toLowerCase();
if ( !( langData[langCode] instanceof mw.Map ) ) {
langData[langCode] = new mw.Map();
}
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
index 16f90df..a068846 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js
@@ -11,10 +11,12 @@
}
} ) );
- QUnit.test( 'mw.language getData and setData', 2, function ( assert ) {
+ QUnit.test( 'mw.language getData and setData', 3, function ( assert ) {
mw.language.setData( 'en', 'testkey', 'testvalue' );
assert.equal( mw.language.getData( 'en', 'testkey' ),
'testvalue', 'Getter setter test for mw.language' );
assert.equal( mw.language.getData( 'en', 'invalidkey' ),
undefined, 'Getter setter test for mw.language with invalid key' );
+ mw.language.setData( 'en-us', 'testkey', 'testvalue' );
+ assert.equal( mw.language.getData( 'en-US', 'testkey' ),
'testvalue', 'Case insensitive test for mw.language' );
} );
QUnit.test( 'mw.language.commafy test', 9, function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/188520
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ebdead5440862c087920fa93e85aeb47464272e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Tablesorter: Replace wgContentLanguage by wgPageContentLanguage - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188362
Change subject: Tablesorter: Replace wgContentLanguage by wgPageContentLanguage
..
Tablesorter: Replace wgContentLanguage by wgPageContentLanguage
wgContentLanguage contains the language code of whole project.
wgPageContentLanguage contains the language code of the content of the page.
For example https://translatewiki.net/wiki/Project:About/de?uselang=eo has
* wgContentLanguage en
* wgPageContentLanguage de
* wgUserLanguage eo
The tablesorter works on the content of the page.
Change-Id: I3e51d96c838a3a4f4562c1f27c360d515e4d8ca6
---
M resources/src/jquery/jquery.tablesorter.js
M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/62/188362/1
diff --git a/resources/src/jquery/jquery.tablesorter.js
b/resources/src/jquery/jquery.tablesorter.js
index 8e1c3f0..5875f93 100644
--- a/resources/src/jquery/jquery.tablesorter.js
+++ b/resources/src/jquery/jquery.tablesorter.js
@@ -8,7 +8,7 @@
* http://www.opensource.org/licenses/mit-license.php
* http://www.gnu.org/licenses/gpl.html
*
- * Depends on mw.config (wgDigitTransformTable, wgDefaultDateFormat,
wgContentLanguage)
+ * Depends on mw.config (wgDigitTransformTable, wgDefaultDateFormat,
wgPageContentLanguage)
* and mw.language.months.
*
* Uses 'tableSorterCollation' in mw.config (if available)
@@ -1102,7 +1102,7 @@
s = $.trim( s.toLowerCase() );
if ( ( match = s.match( ts.dateRegex[0] ) ) !== null ) {
- if ( mw.config.get( 'wgDefaultDateFormat' ) ===
'mdy' || mw.config.get( 'wgContentLanguage' ) === 'en' ) {
+ if ( mw.config.get( 'wgDefaultDateFormat' ) ===
'mdy' || mw.config.get( 'wgPageContentLanguage' ) === 'en' ) {
s = [ match[3], match[1], match[2] ];
} else if ( mw.config.get(
'wgDefaultDateFormat' ) === 'dmy' ) {
s = [ match[3], match[2], match[1] ];
diff --git a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
index 5464d22..ea2f64b 100644
--- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -162,7 +162,7 @@
wgDefaultDateFormat: 'dmy',
wgSeparatorTransformTable: ['', ''],
wgDigitTransformTable: ['', ''],
- wgContentLanguage: 'en'
+ wgPageContentLanguage: 'en'
}
} ) );
@@ -572,7 +572,7 @@
],
function ( $table ) {
mw.config.set( 'wgDefaultDateFormat', 'dmy' );
- mw.config.set( 'wgContentLanguage', 'de' );
+ mw.config.set( 'wgPageContentLanguage', 'de' );
$table.tablesorter();
$table.find( '.headerSort:eq(0)' ).click();
--
To view, visit https://gerrit.wikimedia.org/r/188362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e51d96c838a3a4f4562c1f27c360d515e4d8ca6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] SkinApiTemplate: Remove span dir=auto for firstHeading - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/188370 Change subject: SkinApiTemplate: Remove span dir=auto for firstHeading .. SkinApiTemplate: Remove span dir=auto for firstHeading In Ibf408bc6c5d2f8c05667107a547b0b02e06de270 the span dir=auto around the title was removed. Remove it here also. Change-Id: Ia0b23a3c47ab01faef2cd380c318386cc9372709 --- M includes/skins/SkinApiTemplate.php 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/70/188370/1 diff --git a/includes/skins/SkinApiTemplate.php b/includes/skins/SkinApiTemplate.php index 2062da8..97b7038 100644 --- a/includes/skins/SkinApiTemplate.php +++ b/includes/skins/SkinApiTemplate.php @@ -36,9 +36,7 @@ $this-html( 'headelement' ) ? div class=mw-body role=main - h1 class=firstHeading - span dir=auto?php $this-html( 'title' ) ?/span - /h1 + h1 class=firstHeading?php $this-html( 'title' ) ?/h1 div class=mw-body-content ?php $this-html( 'bodytext' ) ? /div -- To view, visit https://gerrit.wikimedia.org/r/188370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0b23a3c47ab01faef2cd380c318386cc9372709 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki.action.edit.preview: Remove span dir=auto - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188369
Change subject: mediawiki.action.edit.preview: Remove span dir=auto
..
mediawiki.action.edit.preview: Remove span dir=auto
In Ibf408bc6c5d2f8c05667107a547b0b02e06de270 the span dir=auto
around the title was removed. Remove it here also.
Change-Id: Ie774b7746caadc28be11782058deb17dbd96388f
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/69/188369/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index f6fab70..68fbe33 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -116,7 +116,7 @@
response.parse.modulemessages )
);
}
if ( response.parse.displaytitle ) {
- $( '#firstHeading' ).html( 'span
dir=auto' + response.parse.displaytitle + '/span' );
+ $( '#firstHeading' ).html(
response.parse.displaytitle );
}
if ( response.parse.categorieshtml ) {
$( '#catlinks' ).replaceWith(
response.parse.categorieshtml['*'] );
--
To view, visit https://gerrit.wikimedia.org/r/188369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie774b7746caadc28be11782058deb17dbd96388f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove overflow:hidden for headings - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187963
Change subject: Remove overflow:hidden for headings
..
Remove overflow:hidden for headings
In 140a3b84cc8fea6861ca70b8451d399de2149d3d
h1, h2, h3, h4, h5, h6 { overflow: hidden }
was added.
overflow:hidden blocks T18691.
overflow:hidden was added to prevent overflowing of the border
bottom of h1 and h2 into floating transparent objects.
This patch generates the border bottom by a pseudo element with
overflow:hidden.
Bug: T88220
Change-Id: Ic4d3aa077eb5e6f9d760137ccf4d7e36d243a053
---
M resources/src/mediawiki.legacy/oldshared.css
M resources/src/mediawiki.skinning/content.css
M resources/src/mediawiki.skinning/elements.css
3 files changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/187963/1
diff --git a/resources/src/mediawiki.legacy/oldshared.css
b/resources/src/mediawiki.legacy/oldshared.css
index c2bd5a7..51b9136 100644
--- a/resources/src/mediawiki.legacy/oldshared.css
+++ b/resources/src/mediawiki.legacy/oldshared.css
@@ -194,12 +194,17 @@
#toc h2,
.toc h2 {
display: inline;
- border: none;
padding: 0;
font-size: 100%;
font-weight: bold;
}
+/* Remove border under the header */
+#toc h2:after,
+.toc h2:after {
+ display: none;
+}
+
#toc ul,
.toc ul {
list-style-type: none;
diff --git a/resources/src/mediawiki.skinning/content.css
b/resources/src/mediawiki.skinning/content.css
index 51cb8d0..22956ee 100644
--- a/resources/src/mediawiki.skinning/content.css
+++ b/resources/src/mediawiki.skinning/content.css
@@ -55,12 +55,17 @@
#toc h2,
.toc h2 {
display: inline;
- border: none;
padding: 0;
font-size: 100%;
font-weight: bold;
}
+/* Remove border under the header */
+#toc h2:after,
+.toc h2:after {
+ display: none;
+}
+
#toc #toctitle,
.toc #toctitle,
#toc .toctitle,
diff --git a/resources/src/mediawiki.skinning/elements.css
b/resources/src/mediawiki.skinning/elements.css
index 11962f8..3848736 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -89,10 +89,8 @@
background: none;
font-weight: normal;
margin: 0;
- overflow: hidden;
padding-top: .5em;
padding-bottom: .17em;
- border-bottom: 1px solid #aaa;
}
h1 {
@@ -107,7 +105,6 @@
h4,
h5,
h6 {
- border-bottom: none;
font-weight: bold;
}
@@ -139,6 +136,15 @@
margin-bottom: .3em;
}
+/* Line under h1 and h2 without overlapping with floating objects T88220 */
+h1:after,
+h2:after {
+ border-bottom: 1px solid #aaa;
+ content: ;
+ display: block;
+ overflow: hidden;
+}
+
p {
margin: .4em 0 .5em 0;
line-height: 1.5em;
--
To view, visit https://gerrit.wikimedia.org/r/187963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4d3aa077eb5e6f9d760137ccf4d7e36d243a053
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Phabricator T87376: Don't create invalid MediaWiki group nam... - change (mediawiki...LdapAuthentication)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187917
Change subject: Phabricator T87376: Don't create invalid MediaWiki group names
containing whitespace: change spaces to underscores.
..
Phabricator T87376: Don't create invalid MediaWiki group names containing
whitespace: change spaces to underscores.
Change-Id: I5c0b44b88d7f2e1a50f0e94d794f5be2e366db6e
---
M LdapAuthentication.php
1 file changed, 33 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LdapAuthentication
refs/changes/17/187917/1
diff --git a/LdapAuthentication.php b/LdapAuthentication.php
index 5b258fc..362b23d 100644
--- a/LdapAuthentication.php
+++ b/LdapAuthentication.php
@@ -63,6 +63,7 @@
$wgLDAPGroupNameAttribute = array();
$wgLDAPGroupsUseMemberOf = array();
$wgLDAPUseLDAPGroups = array();
+$wgLDAPGroupsFixWhitespace = array();
$wgLDAPLocallyManagedGroups = array();
$wgLDAPGroupsPrevail = array();
$wgLDAPRequiredGroups = array();
@@ -459,6 +460,9 @@
case 'UseLDAPGroups':
global $wgLDAPUseLDAPGroups;
return self::setOrDefault( $wgLDAPUseLDAPGroups,
$domain, false );
+ case 'GroupsFixWhitespace':
+ global $wgLDAPGroupsFixWhitespace;
+ return self::setOrDefault($wgLDAPGroupsFixWhitespace,
$domain, false );
case 'LocallyManagedGroups':
global $wgLDAPLocallyManagedGroups;
return self::setOrDefault( $wgLDAPLocallyManagedGroups,
$domain, array() );
@@ -1639,9 +1643,38 @@
if ( $this-getConf( 'GroupsPrevail' ) count(
$this-userLDAPGroups ) != 0 ) {
$this-allLDAPGroups = $this-searchGroups( '*'
);
}
+
+ // If we sync an LDAP group whose name contains
whitespace, MediaWiki will fail to use
+ // the group correctly (Phabricator bug T87376).
Transform the name to eliminate
+ // whitespace.
+ if ( $this-getConf( 'GroupsFixWhitespace' ) ) {
+ if (isset($this-userLDAPGroups)
isset($this-userLDAPGroups[short])) {
+ foreach ($this-userLDAPGroups[short]
as $key = $value) {
+
$this-userLDAPGroups[short][$key] = self::transformLDAPGroupName($value);
+ }
+ }
+ if (isset($this-allLDAPGroups)
isset($this-allLDAPGroups[short])) {
+ foreach ($this-allLDAPGroups[short]
as $key = $value) {
+
$this-allLDAPGroups[short][$key] = self::transformLDAPGroupName($value);
+ }
+ }
+ }
}
}
+
+ /**
+* Transform an LDAP group name to make it valid for MediaWiki.
+* Make the function public and static so other extensions can perform
the same
+* transformation abstractly without knowing its details.
+*
+* @param $name
+* @return string
+*/
+ public static function transformLDAPGroupName($name) {
+ return str_replace(' ', '_', $name);
+ }
+
/**
* Function to return an array of nested groups when given a group or
list of groups.
* $searchedgroups is used for tail recursion and shouldn't be provided
--
To view, visit https://gerrit.wikimedia.org/r/187917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c0b44b88d7f2e1a50f0e94d794f5be2e366db6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Replace overflow:hidden by display:flex for headings - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187924
Change subject: Replace overflow:hidden by display:flex for headings
..
Replace overflow:hidden by display:flex for headings
This is needed to prevent that the border bottom of h2
is visible through transparent floating objects. Test case:
{| class=floatright
|-
! Header text !! Header text !! Header text
|- | Example || Example || Example
|- | Example || Example || Example
|- | Example || Example || Example
|}
Text before the header.
== Header ==
Text after the header.
Bug: T88220
Change-Id: I100eaf646e2660d62aa50b2617dde6e1c3cf9de3
---
M resources/src/mediawiki.skinning/elements.css
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/24/187924/1
diff --git a/resources/src/mediawiki.skinning/elements.css
b/resources/src/mediawiki.skinning/elements.css
index 11962f8..c780532 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -86,10 +86,11 @@
h5,
h6 {
color: black;
+ display: -webkit-flex;
+ display: flex;
background: none;
font-weight: normal;
margin: 0;
- overflow: hidden;
padding-top: .5em;
padding-bottom: .17em;
border-bottom: 1px solid #aaa;
--
To view, visit https://gerrit.wikimedia.org/r/187924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I100eaf646e2660d62aa50b2617dde6e1c3cf9de3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove .firstHeading { overflow: visible } - change (mediawiki...Vector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187926
Change subject: Remove .firstHeading { overflow: visible }
..
Remove .firstHeading { overflow: visible }
Since I100eaf646e2660d62aa50b2617dde6e1c3cf9de3
h1 { overflow: hidden } is removed.
Bug: T88220
Change-Id: Iab613358764b590b97461f97de9d8b9c1ccf5c8a
---
M components/common.less
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/26/187926/1
diff --git a/components/common.less b/components/common.less
index c25a26a..ebf475f 100644
--- a/components/common.less
+++ b/components/common.less
@@ -97,11 +97,6 @@
font-family: @content-font-family;
}
- .firstHeading {
- /* Change the default from mediawiki.skinning CSS to let
indicators float into heading area */
- overflow: visible;
- }
-
.mw-indicators {
float: right;
line-height: @content-line-height;
--
To view, visit https://gerrit.wikimedia.org/r/187926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab613358764b590b97461f97de9d8b9c1ccf5c8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move notification area out of .mw-body - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187898
Change subject: Move notification area out of .mw-body
..
Move notification area out of .mw-body
Iaa7f427bf30f88c1ea4e6da0558a3535e5d40175 gives .mw-body
an own stacking content which ensures that the Vector menu is always
in front of the content.
Bug: T87573
Change-Id: I8cddb27bd9cdabd782ad4b722d24eee683801b7c
---
M resources/src/mediawiki/mediawiki.notification.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/98/187898/1
diff --git a/resources/src/mediawiki/mediawiki.notification.js
b/resources/src/mediawiki/mediawiki.notification.js
index 132c334..9611ffb 100644
--- a/resources/src/mediawiki/mediawiki.notification.js
+++ b/resources/src/mediawiki/mediawiki.notification.js
@@ -390,7 +390,7 @@
.hide();
// Prepend the notification area to the content area and save
it's object.
- mw.util.$content.prepend( $area );
+ mw.util.$content.after( $area );
offset = $area.offset();
function updateAreaMode() {
--
To view, visit https://gerrit.wikimedia.org/r/187898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cddb27bd9cdabd782ad4b722d24eee683801b7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update HTML title with displaytitle on live preview - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187710
Change subject: Update HTML title with displaytitle on live preview
..
Update HTML title with displaytitle on live preview
Todo: PHP uses message 'creating' when creating a new page.
This is still missing in JavaScript.
Bug: T88117
Change-Id: Ida5c1d470908cefd16925bd5455758d25db02113
---
M resources/Resources.php
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/10/187710/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 6e8cd99..d688372 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1052,6 +1052,8 @@
'mediawiki.jqueryMsg',
),
'messages' = array(
+ 'editing',
+ 'pagetitle',
'otherlanguages',
'tooltip-p-lang',
'summary-preview',
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index f6fab70..b5302fc 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -4,6 +4,20 @@
( function ( mw, $ ) {
/**
+* Remove all HTML tags.
+*
+* PHP: Sanitizer::stripAllTags
+*
+* @param string text HTML fragment
+* @return string
+*/
+ function stripAllTags( text ) {
+ return text
+ .replace( /[^]*/g, '' )
+ .replace( /amp;/g, '' );
+ }
+
+ /**
* @ignore
* @param {jQuery.Event} e
*/
@@ -117,6 +131,11 @@
}
if ( response.parse.displaytitle ) {
$( '#firstHeading' ).html( 'span
dir=auto' + response.parse.displaytitle + '/span' );
+ $( 'title' ).text(
+ mw.msg( 'pagetitle',
+ mw.msg( 'editing',
stripAllTags( response.parse.displaytitle ) )
+ )
+ );
}
if ( response.parse.categorieshtml ) {
$( '#catlinks' ).replaceWith(
response.parse.categorieshtml['*'] );
--
To view, visit https://gerrit.wikimedia.org/r/187710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida5c1d470908cefd16925bd5455758d25db02113
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add commas at end of lines for arrays in PHP - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/187732 Change subject: Add commas at end of lines for arrays in PHP .. Add commas at end of lines for arrays in PHP Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9 --- M WikiEditor.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor refs/changes/32/187732/1 diff --git a/WikiEditor.php b/WikiEditor.php index f685ad0..30da1e4 100644 --- a/WikiEditor.php +++ b/WikiEditor.php @@ -30,7 +30,7 @@ // Adds a tab for previewing in-line 'preview' = array( 'global' = false, 'user' = true ), - // Adds a button and dialog for step-by-step publishing + // Adds a button and dialog for step-by-step publishing 'publish' = array( 'global' = false, 'user' = true ), ); @@ -146,7 +146,7 @@ 'jquery.wikiEditor', 'jquery.wikiEditor.toolbar.i18n', 'jquery.wikiEditor.toolbar', - ) + ), ), 'jquery.wikiEditor.toolbar.i18n' = $wikiEditorTpl + array( 'messages' = array( @@ -403,7 +403,7 @@ 'ext.wikiEditor', 'jquery.wikiEditor.toolbar', 'jquery.wikiEditor.toolbar.config', - ) + ), ), 'ext.wikiEditor.toolbar.styles' = $wikiEditorTpl + array( 'styles' = 'ext.wikiEditor.toolbar.styles.css', -- To view, visit https://gerrit.wikimedia.org/r/187732 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c014bdfa9832fa6a20d0190fe2fc668983d0fb9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing /ul - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/187680 Change subject: Add missing /ul .. Add missing /ul Change-Id: I673213fc424c859ce81b1cf1a85e6ed9e508d0b6 --- M includes/page/Article.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/80/187680/1 diff --git a/includes/page/Article.php b/includes/page/Article.php index 6516ae8..f04201c 100644 --- a/includes/page/Article.php +++ b/includes/page/Article.php @@ -1494,6 +1494,7 @@ ( $forceKnown ? array( 'known', 'noclasses' ) : array() ) ) . '/li'; } + $html .= '/ul'; $redirectToText = wfMessage( 'redirectto' )-inLanguage( $lang )-text(); -- To view, visit https://gerrit.wikimedia.org/r/187680 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I673213fc424c859ce81b1cf1a85e6ed9e508d0b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allow a resizeable toolbar index - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187339
Change subject: Allow a resizeable toolbar index
..
Allow a resizeable toolbar index
Change-Id: I329a143e2ee0a21bee4a9b146c28e6e8df58d570
---
M modules/jquery.wikiEditor.toolbar.css
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/39/187339/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 94971b5..64a3de7 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -211,6 +211,7 @@
width: 20%;
height: 125px;
overflow: auto;
+ resize: horizontal;
}
.wikiEditor-ui-toolbar .booklet .index div {
padding: 4px;
@@ -224,8 +225,6 @@
cursor: default;
}
.wikiEditor-ui-toolbar .booklet .pages {
- float: right;
- width: 80%;
height: 125px;
overflow: auto;
background-color: #FAFAFA;
--
To view, visit https://gerrit.wikimedia.org/r/187339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I329a143e2ee0a21bee4a9b146c28e6e8df58d570
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix whitespaces - change (mediawiki...CodeEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187337
Change subject: Fix whitespaces
..
Fix whitespaces
Change-Id: Ia26f885ac2423d9f4a67b9e4d58a90aba22d0f07
---
M modules/jquery.codeEditor.js
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor
refs/changes/37/187337/1
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index e0c4803..68a57c6 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -7,7 +7,7 @@
*/
'req': [ 'codeEditor' ],
/**
-* Compatability map
+* Compatability map
*/
browsers: {
msie: [['=', 8]],
@@ -125,8 +125,8 @@
};
context.api.addToToolbar( context, {
'section': 'main',
- 'groups' : {
- 'codeeditor-main' : {
+ 'groups': {
+ 'codeeditor-main': {
'tools': {
'codeEditor': {
'labelMsg': 'codeeditor-toolbar-toggle',
@@ -139,8 +139,8 @@
}
}
},
- 'codeeditor-tools' : {
- 'tools' : {
+ 'codeeditor-tools': {
+ 'tools': {
}
}
}
@@ -257,7 +257,7 @@
},
/**
-* Turn off the code editor view and return to the
plain textarea.
+* Turn off the code editor view and return to the
plain textarea.
* May be needed by some folks with funky browsers, or
just to compare.
*/
'disableCodeEditor': function () {
@@ -429,7 +429,7 @@
addToStatus( status, ( c.row +
1 ) + ':' + c.column, '' );
if (
!editor.selection.isEmpty() ) {
r =
editor.getSelectionRange();
- addToStatus( status,
'(' + ( r.end.row - r.start.row ) + ':' + ( r.end.column - r.start.column ) +
')' );
+ addToStatus( status,
'(' + ( r.end.row - r.start.row ) + ':' + ( r.end.column - r.start.column ) +
')' );
}
status.pop();
$lineAndMode.text( status.join(
'' ) );
@@ -640,7 +640,7 @@
row++;
}
col = offset - pos;
- return {row: row, column: col};
+ return { row: row, column: col };
};
start = offsetToPos( options.start );
end = offsetToPos( options.end );
--
To view, visit https://gerrit.wikimedia.org/r/187337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia26f885ac2423d9f4a67b9e4d58a90aba22d0f07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implement ChangeTagsListActive hook - change (mediawiki...MobileFrontend)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187354
Change subject: Implement ChangeTagsListActive hook
..
Implement ChangeTagsListActive hook
This allows users to visit Special:Tags or use the API to see
which change tags are still in active use.
The ChangeTagsListActive hook was introduced to core in
I77f476c8d0f32c80f720aa2c5e66869c81faa282
Change-Id: I6ebf93291c5af594901ce6a244579c46aa973302
---
M MobileFrontend.php
M includes/MobileFrontend.hooks.php
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/54/187354/1
diff --git a/MobileFrontend.php b/MobileFrontend.php
index 2a3c0f4..0ac215a 100644
--- a/MobileFrontend.php
+++ b/MobileFrontend.php
@@ -133,6 +133,7 @@
$wgHooks['ResourceLoaderGetConfigVars'][] =
'MobileFrontendHooks::onResourceLoaderGetConfigVars';
$wgHooks['SpecialPage_initList'][] =
'MobileFrontendHooks::onSpecialPage_initList';
$wgHooks['ListDefinedTags'][] = 'MobileFrontendHooks::onListDefinedTags';
+$wgHooks['ChangeTagsListActive'][] = 'MobileFrontendHooks::onListDefinedTags';
$wgHooks['RecentChange_save'][] = 'MobileFrontendHooks::onRecentChange_save';
$wgHooks['AbuseFilter-generateUserVars'][] =
'MobileFrontendHooks::onAbuseFilterGenerateUserVars';
$wgHooks['AbuseFilter-builder'][] =
'MobileFrontendHooks::onAbuseFilterBuilder';
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 55517c7..ca1a0b6 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -407,10 +407,11 @@
}
/**
-* ListDefinedTags hook handler
+* ListDefinedTags and ChangeTagsListActive hook handler
* @see https://www.mediawiki.org/wiki/Manual:Hooks/ListDefinedTags
-* @param array $tags
+* @see https://www.mediawiki.org/wiki/Manual:Hooks/ChangeTagsListActive
*
+* @param array $tags
* @return bool
*/
public static function onListDefinedTags( $tags ) {
@@ -422,8 +423,8 @@
/**
* RecentChange_save hook handler that tags mobile changes
* @see https://www.mediawiki.org/wiki/Manual:Hooks/RecentChange_save
-* @param RecentChange $rc
*
+* @param RecentChange $rc
* @return bool
*/
public static function onRecentChange_save( RecentChange $rc ) {
--
To view, visit https://gerrit.wikimedia.org/r/187354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ebf93291c5af594901ce6a244579c46aa973302
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: TTO at.li...@live.com.au
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Give .mw-body a own stacking content (z-index: 0) - change (mediawiki...Vector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186768
Change subject: Give .mw-body a own stacking content (z-index: 0)
..
Give .mw-body a own stacking content (z-index: 0)
This avoids that elements from the indicators, from the displaytitle or
from the sitenotice can overlap elements outside the content area
(e.g. software and skin interface components), such as the page
action menu.
Bug: T87573
Bug: T86962
Change-Id: Iaa7f427bf30f88c1ea4e6da0558a3535e5d40175
---
M components/common.less
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/68/186768/1
diff --git a/components/common.less b/components/common.less
index c25a26a..31f4936 100644
--- a/components/common.less
+++ b/components/common.less
@@ -28,6 +28,10 @@
/* Content */
.mw-body {
+ /* Create a own stacking context to prevent overlap with the menu */
+ position: relative;
+ z-index: 0;
+
margin-left: 10em;
padding: @content-padding;
/* Border on top, left, and bottom side */
--
To view, visit https://gerrit.wikimedia.org/r/186768
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa7f427bf30f88c1ea4e6da0558a3535e5d40175
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] LivePreview: Update page status indicators - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186757
Change subject: LivePreview: Update page status indicators
..
LivePreview: Update page status indicators
Todo: Implement Sanitizer::escapeId from PHP
Bug: T87557
Change-Id: I0caa7f3d9498943b3b1bc9054e63092042dd9405
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/186757/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index f6fab70..73fbc75 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -28,6 +28,7 @@
copySelectors = [
// Main
+ '.mw-indicators',
'#firstHeading',
'#wikiPreview',
'#wikiDiff',
@@ -101,20 +102,32 @@
$.extend( postData, {
pst: '',
preview: '',
- prop:
'text|displaytitle|modules|categorieshtml|templates|langlinks|limitreporthtml'
+ prop:
'text|indicators|displaytitle|modules|categorieshtml|templates|langlinks|limitreporthtml'
} );
if ( section !== '' ) {
postData.sectionpreview = '';
}
request = api.post( postData );
request.done( function ( response ) {
- var li, newList, $next, $parent, $list;
+ var li, newList, $next, $parent, $list,
$indicators;
if ( response.parse.modules ) {
mw.loader.load(
response.parse.modules.concat(
response.parse.modulescripts,
response.parse.modulestyles,
response.parse.modulemessages )
);
}
+ if ( response.parse.indicators ) {
+ $indicators = $( '.mw-indicators'
).empty();
+ $.each( response.parse.indicators,
function ( i, indicator ) {
+ var name = 'mw-indicator-' +
indicator.name;
+ // Todo: Implement
Sanitizer::escapeId from PHP
+ $( 'div' )
+ .addClass( 'mw-indicator' )
+ .attr( 'id', name )
+ .html( indicator['*'] )
+ .appendTo( $indicators );
+ } );
+ }
if ( response.parse.displaytitle ) {
$( '#firstHeading' ).html( 'span
dir=auto' + response.parse.displaytitle + '/span' );
}
--
To view, visit https://gerrit.wikimedia.org/r/186757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0caa7f3d9498943b3b1bc9054e63092042dd9405
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use background-image instead of img for toolbar icons - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186639
Change subject: Use background-image instead of img for toolbar icons
..
Use background-image instead of img for toolbar icons
Change-Id: I8af0e2c8585e8d9f6f72133953792eb88a176bcf
---
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
2 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/39/186639/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 94971b5..46c465a 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -76,10 +76,9 @@
.wikiEditor-ui-toolbar .group-insert {
border-right: none;
}
-/* Sprited Buttons */
-.wikiEditor-toolbar-spritedButton {
- /* @embed */
- background: url(images/toolbar/button-sprite.png) 0 0 no-repeat;
+.tool-button {
+ background-position: 2px 2px;
+ background-repeat: no-repeat;
display: block;
float: left;
height: 22px;
@@ -89,6 +88,11 @@
cursor: pointer;
overflow: hidden;
}
+/* Sprited Buttons */
+.wikiEditor-toolbar-spritedButton {
+ /* @embed */
+ background-image: url(images/toolbar/button-sprite.png);
+}
/* Tabs */
.wikiEditor-ui-toolbar .tabs {
list-style: none;
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index 75b40e5..34409b8 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -327,17 +327,16 @@
}
}
if ( !$button ) {
- $button = $( 'img' )
+ $button = $( 'a' )
.attr( {
- 'src': src,
- 'width': 22,
- 'height': 22,
- 'alt': label,
+ 'href': '#',
'title': label,
'rel': id,
'role': 'button',
'class': 'tool
tool-button'
- } );
+ } )
+ .text( label )
+ .css( 'background-image',
'url(' + src + ')' );
}
if ( 'action' in tool ) {
$button
--
To view, visit https://gerrit.wikimedia.org/r/186639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8af0e2c8585e8d9f6f72133953792eb88a176bcf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use sprite as button icon where possible - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/186177 Change subject: Use sprite as button icon where possible .. Use sprite as button icon where possible The icon for italic in language 'os' exists in the sprite like for 'ru'. Change-Id: I126b3fbc2246b485c2b7e8572037447498821e35 --- M modules/jquery.wikiEditor.toolbar.config.js 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor refs/changes/77/186177/1 diff --git a/modules/jquery.wikiEditor.toolbar.config.js b/modules/jquery.wikiEditor.toolbar.config.js index e195f42..52c49b5 100644 --- a/modules/jquery.wikiEditor.toolbar.config.js +++ b/modules/jquery.wikiEditor.toolbar.config.js @@ -83,6 +83,7 @@ 'it': [2, -790], 'ky': [2, -934], 'nl': [2, -790], + 'os': [2, -934], 'pt': [2, -862], 'pt-br': [2, -862], 'pl': [2, -862], -- To view, visit https://gerrit.wikimedia.org/r/186177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I126b3fbc2246b485c2b7e8572037447498821e35 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Support fallback languages for icons - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186006
Change subject: Support fallback languages for icons
..
Support fallback languages for icons
Bug: T87247
Change-Id: I452dd45d20ea4dd542d63274b7aad0272e20ea12
---
M WikiEditor.php
M modules/jquery.wikiEditor.js
M modules/jquery.wikiEditor.toolbar.config.js
3 files changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/06/186006/1
diff --git a/WikiEditor.php b/WikiEditor.php
index f685ad0..ca4cddf 100644
--- a/WikiEditor.php
+++ b/WikiEditor.php
@@ -70,6 +70,7 @@
'dependencies' = array(
'jquery.client',
'jquery.textSelection',
+ 'mediawiki.language',
),
'messages' = array(
'wikieditor-wikitext-tab',
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index c9979ff..4c5f428 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -11,6 +11,8 @@
/*jshint onevar:false, boss:true */
( function ( $, mw ) {
+var hasOwn = Object.prototype.hasOwnProperty;
+
/**
* Global static object for wikiEditor that provides generally useful
functionality to all modules and contexts.
*/
@@ -167,8 +169,21 @@
* @param lang Language code, defaults to wgUserLanguage
*/
autoLang: function ( object, lang ) {
- var defaultKey = $( 'body' ).hasClass( 'rtl' ) ? 'default-rtl'
: 'default';
- return object[lang || mw.config.get( 'wgUserLanguage' )] ||
object[defaultKey] || object['default'] || object;
+ var i, key,
+ isRTL = $( 'body' ).hasClass( 'rtl' ),
+ chain = mw.language.getFallbackLanguageChain();
+
+ if ( isRTL ) {
+ chain[chain.length - 1] = 'default-rtl'; // Do not
fallback to 'en' for RTL languages
+ }
+ chain = [lang].concat( chain ).concat( ['default'] );
+ for ( i = 0; i chain.length; i++ ) {
+ key = chain[i];
+ if ( hasOwn.call( object, key ) ) {
+ return object[key];
+ }
+ }
+ return object;
},
/**
diff --git a/modules/jquery.wikiEditor.toolbar.config.js
b/modules/jquery.wikiEditor.toolbar.config.js
index e195f42..6710ff0 100644
--- a/modules/jquery.wikiEditor.toolbar.config.js
+++ b/modules/jquery.wikiEditor.toolbar.config.js
@@ -29,7 +29,6 @@
'it': [2, -286],
'nl': [2, -502],
'pt': [2, -358],
- 'pt-br': [2,
-358],
'pl': [2, -142],
'ml': [2, -142]
},
@@ -51,7 +50,6 @@
'nl':
'format-bold-V.png',
'os':
'format-bold-os.png',
'pt':
'format-bold-N.png',
- 'pt-br':
'format-bold-N.png',
'pl':
'format-bold-B.png',
'ru':
'format-bold-ru.png',
'ml':
'format-bold-B.png'
@@ -84,7 +82,6 @@
'ky': [2, -934],
'nl': [2, -790],
'pt': [2, -862],
- 'pt-br': [2,
-862],
'pl': [2, -862],
'ru': [2, -934],
'ml': [2, -862]
@@ -107,7 +104,6 @@
'nl':
'format-italic-C.png',
'os':
'format-italic-K.png',
'pt':
'format-italic-I.png',
- 'pt-br':
'format-italic-I.png',
[MediaWiki-commits] [Gerrit] Remove file external link icons.svg - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/185685 Change subject: Remove file external link icons.svg .. Remove file external link icons.svg * The file is unused. * The filename contains spaces. Change-Id: I24dee76bb3aa11f7a106417a4ebf889a4656bb4c --- D resources/src/mediawiki.skinning/images/external link icons.svg 1 file changed, 0 insertions(+), 697 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/85/185685/1 diff --git a/resources/src/mediawiki.skinning/images/external link icons.svg b/resources/src/mediawiki.skinning/images/external link icons.svg deleted file mode 100644 index 6a67993..000 --- a/resources/src/mediawiki.skinning/images/external link icons.svg +++ /dev/null @@ -1,697 +0,0 @@ -?xml version=1.0 encoding=UTF-8 standalone=no? -!-- Created with Inkscape (http://www.inkscape.org/) -- - -svg - xmlns:dc=http://purl.org/dc/elements/1.1/; - xmlns:cc=http://creativecommons.org/ns#; - xmlns:rdf=http://www.w3.org/1999/02/22-rdf-syntax-ns#; - xmlns:svg=http://www.w3.org/2000/svg; - xmlns=http://www.w3.org/2000/svg; - xmlns:sodipodi=http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; - xmlns:inkscape=http://www.inkscape.org/namespaces/inkscape; - width=13 - height=110 - id=svg2 - version=1.1 - inkscape:version=0.48.5 r10040 - sodipodi:docname=external link icons.svg - defs - id=defs4 / - sodipodi:namedview - id=base - pagecolor=#ff - bordercolor=#66 - borderopacity=1.0 - inkscape:pageopacity=0.0 - inkscape:pageshadow=2 - inkscape:zoom=15.99 - inkscape:cx=10.40536 - inkscape:cy=65.686256 - inkscape:document-units=px - inkscape:current-layer=layer5 - showgrid=true - fit-margin-top=0 - fit-margin-left=0 - fit-margin-right=0 - fit-margin-bottom=0 - inkscape:window-width=1283 - inkscape:window-height=711 - inkscape:window-x=1790 - inkscape:window-y=-6 - inkscape:window-maximized=0 -inkscape:grid - type=xygrid - id=grid3246 - empspacing=4 - visible=true - enabled=true - snapvisiblegridlinesonly=true - originx=0px - originy=-27.97px / - /sodipodi:namedview - metadata - id=metadata7 -rdf:RDF - cc:Work - rdf:about= -dc:formatimage/svg+xml/dc:format -dc:type - rdf:resource=http://purl.org/dc/dcmitype/StillImage; / -dc:title / - /cc:Work -/rdf:RDF - /metadata - g - inkscape:groupmode=layer - id=layer2 - inkscape:label=base - style=display:none - transform=translate(-505,-869.36218) -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646 - width=13 - height=12.96 - x=505 - y=885.36218 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646-4 - width=13 - height=12.98 - x=505 - y=901.36218 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646-4-6 - width=13 - height=12.96 - x=505 - y=917.36218 - inkscape:export-filename=/home/rahah/elvidishu/steak/unreal/dev/skins/external link icons/mail.png - inkscape:export-xdpi=90 - inkscape:export-ydpi=90 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646-4-6-9 - width=13 - height=12.96 - x=505 - y=933.36218 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646-4-6-6 - width=13 - height=12.96 - x=505 - y=950.36218 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none - id=rect4646-4-6-2 - width=13 - height=12.98 - x=505 - y=966.36218 / -rect - style=fill:#b3b3b3;fill-opacity:1;fill-rule:evenodd;stroke:none;display:inline - id=rect4646-44 - width=13 - height=12.96 - x=505 - y=869.36218 / - /g - g - inkscape:label=sketch 1 - inkscape:groupmode=layer - id=layer1 - transform=translate(-505,-869.36218) - style=display:none - sodipodi:insensitive=true -path - style=fill:none;stroke:#0066ff;stroke-width:1.5;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none - d=m 507,870.36218 0,5 3,0 4,4 0,-13 -4,4 z - id=path3194 - inkscape:connector-curvature=0 - sodipodi:nodetypes=ccc / -path - style=fill:none;stroke:#5b9dff;stroke-width:1.5;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none - d=m 517,869.36218 c 1,2 1,5 0,7 - id=path3196 -
[MediaWiki-commits] [Gerrit] interface.css: Add #siteNotice { z-index: 0 } - change (mediawiki/core)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185130
Change subject: interface.css: Add #siteNotice { z-index: 0 }
..
interface.css: Add #siteNotice { z-index: 0 }
This prevents that an element with an absolute position and a z-index
from the localNotice or the centralNotice can overlap with the menus.
Change-Id: If1eba138a242226bc5622859004df3d7a717c046
---
M resources/src/mediawiki.skinning/interface.css
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/30/185130/1
diff --git a/resources/src/mediawiki.skinning/interface.css
b/resources/src/mediawiki.skinning/interface.css
index b57ee36..917de47 100644
--- a/resources/src/mediawiki.skinning/interface.css
+++ b/resources/src/mediawiki.skinning/interface.css
@@ -37,6 +37,7 @@
position: relative;
text-align: center;
margin: 0;
+ z-index: 0;
}
#localNotice {
--
To view, visit https://gerrit.wikimedia.org/r/185130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1eba138a242226bc5622859004df3d7a717c046
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Prevent line wrapping for link syntax help column - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184860
Change subject: Prevent line wrapping for link syntax help column
..
Prevent line wrapping for link syntax help column
Bug: T33649
Change-Id: Ia814105aaac986e4ba216d68b1a8afaf38ddfdc1
---
M modules/jquery.wikiEditor.toolbar.css
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/60/184860/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 3148952..9daad2a 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -262,6 +262,11 @@
.wikiEditor-ui-toolbar .section-help .page-table td.cell-description {
width: 20%;
}
+/* T33649 */
+.wikiEditor-ui-toolbar .section-help .page-table .table-link td.cell-syntax {
+ white-space: pre;
+}
+
/* Characters Pages */
.wikiEditor-ui-toolbar .page-characters div span {
border: 1px solid #DD;
--
To view, visit https://gerrit.wikimedia.org/r/184860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia814105aaac986e4ba216d68b1a8afaf38ddfdc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use font-family: monospace, Courier - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184868
Change subject: Use font-family: monospace, Courier
..
Use font-family: monospace, Courier
Use
font-family: monospace, Courier
instead of
font-family: monospace, Courier New
like in resources/src/mediawiki.skinning/elements.css from core.
Change-Id: I87145f8254d34b6d00d76f22c3d0819b9ea5839f
---
M modules/jquery.wikiEditor.toolbar.css
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/68/184868/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 3148952..09cf3be 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -253,7 +253,7 @@
vertical-align: top;
}
.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax {
- font-family: monospace, Courier New;
+ font-family: monospace, Courier;
}
.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
.wikiEditor-ui-toolbar .section-help .page-table td.cell-result {
@@ -276,7 +276,7 @@
color: black;
text-decoration: none;
cursor: pointer;
- font-family: monospace, Courier New;
+ font-family: monospace, Courier;
font-size: 1.25em;
line-height: 1;
}
--
To view, visit https://gerrit.wikimedia.org/r/184868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87145f8254d34b6d00d76f22c3d0819b9ea5839f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix whitespaces in JavaScript - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184840
Change subject: Fix whitespaces in JavaScript
..
Fix whitespaces in JavaScript
* Use a singe space as whitespace.
* Remove space before colon when not used as ternary operator
Change-Id: I6391bbcf10d26fadf82686d7ff226b773868415c
---
M modules/jquery.wikiEditor.js
M modules/jquery.wikiEditor.toolbar.config.js
M modules/jquery.wikiEditor.toolbar.js
3 files changed, 203 insertions(+), 203 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/40/184840/1
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 55a55a8..c9979ff 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -80,7 +80,7 @@
* Path to images - this is a bit messy, and it would need to change if
this code (and images) gets moved into the
* core - or anywhere for that matter...
*/
- imgPath : mw.config.get( 'wgExtensionAssetsPath' ) +
'/WikiEditor/modules/images/',
+ imgPath: mw.config.get( 'wgExtensionAssetsPath' ) +
'/WikiEditor/modules/images/',
/**
* Checks the current browser against the browsers object to determine
if the browser has been black-listed or not.
@@ -429,7 +429,7 @@
saveCursorAndScrollTop: function () {
if ( $.client.profile().name === 'msie' ) {
var IHateIE = {
- 'scrollTop' :
context.$textarea.scrollTop(),
+ 'scrollTop':
context.$textarea.scrollTop(),
'pos': context.$textarea.textSelection(
'getCaretPosition', { startAndEnd: true } )
};
context.$textarea.data( 'IHateIE', IHateIE );
diff --git a/modules/jquery.wikiEditor.toolbar.config.js
b/modules/jquery.wikiEditor.toolbar.config.js
index d858975..e195f42 100644
--- a/modules/jquery.wikiEditor.toolbar.config.js
+++ b/modules/jquery.wikiEditor.toolbar.config.js
@@ -209,7 +209,7 @@
'labelMsg':
'wikieditor-toolbar-tool-heading',
'type': 'select',
'list': {
- 'heading-2' : {
+ 'heading-2': {
'labelMsg': 'wikieditor-toolbar-tool-heading-2',
'action': {
'type': 'encapsulate',
@@ -223,7 +223,7 @@
}
}
},
- 'heading-3' : {
+ 'heading-3': {
'labelMsg': 'wikieditor-toolbar-tool-heading-3',
'action': {
'type': 'encapsulate',
@@ -237,7 +237,7 @@
}
}
},
- 'heading-4' : {
+ 'heading-4': {
'labelMsg': 'wikieditor-toolbar-tool-heading-4',
'action': {
'type': 'encapsulate',
@@ -251,7 +251,7 @@
}
}
},
- 'heading-5' : {
+ 'heading-5': {
'labelMsg': 'wikieditor-toolbar-tool-heading-5',
'action': {
[MediaWiki-commits] [Gerrit] Move style from JavaScript to CSS - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184846
Change subject: Move style from JavaScript to CSS
..
Move style from JavaScript to CSS
Change-Id: I1bf4b886e3b9b789df377dbdd2df94eb80dd61d1
---
M modules/jquery.wikiEditor.dialogs.config.css
M modules/jquery.wikiEditor.dialogs.config.js
M modules/jquery.wikiEditor.dialogs.css
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
5 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/46/184846/1
diff --git a/modules/jquery.wikiEditor.dialogs.config.css
b/modules/jquery.wikiEditor.dialogs.config.css
index 6b3edce..f34e7f0 100644
--- a/modules/jquery.wikiEditor.dialogs.config.css
+++ b/modules/jquery.wikiEditor.dialogs.config.css
@@ -2,6 +2,12 @@
* CSS for WikiEditor Dialogs
*/
+/* Replace Dialog */
+#wikieditor-toolbar-replace-search,
+#wikieditor-toolbar-replace-replace {
+ width: 100%;
+}
+
/* Table Dialog */
#wikieditor-toolbar-table-dialog fieldset {
width: 218px;
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index f5d8af3..e593baf 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -1125,11 +1125,11 @@
fieldset\
div
class=wikieditor-toolbar-field-wrapper\
label
for=wikieditor-toolbar-replace-search
rel=wikieditor-toolbar-tool-replace-search/label\
- input type=text
id=wikieditor-toolbar-replace-search style=width: 100%;/\
+ input type=text
id=wikieditor-toolbar-replace-search/\
/div\
div
class=wikieditor-toolbar-field-wrapper\
label
for=wikieditor-toolbar-replace-replace
rel=wikieditor-toolbar-tool-replace-replace/label\
- input type=text
id=wikieditor-toolbar-replace-replace style=width: 100%;/\
+ input type=text
id=wikieditor-toolbar-replace-replace/\
/div\
div
class=wikieditor-toolbar-field-wrapper\
input type=checkbox
id=wikieditor-toolbar-replace-case/\
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index 6d15f6a..942c66f 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -36,6 +36,7 @@
-ms-box-sizing: border-box;
-webkit-box-sizing: border-box;
-khtml-box-sizing: border-box;
+ box-sizing: border-box;
}
.wikiEditor-toolbar-dialog .ui-dialog-content input[type=radio],
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 3148952..913ecc2 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -231,10 +231,14 @@
background-color: #FAFAFA;
}
/* Help Pages */
-.wikiEditor-ui-toolbar .page-table table {
+.wikiEditor-ui-toolbar .page-table {
padding-left: 5px;
padding-right: 5px;
+}
+.wikiEditor-ui-toolbar .page-table table {
background: none;
+ border-collapse: collapse;
+ width: 100%;
}
.wikiEditor-ui-toolbar .page-table th {
color: #99;
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index 53eb8a8..09f9e76 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -455,7 +455,7 @@
case 'table':
$page.addClass( 'page-table' );
html =
- 'table cellpadding=0 cellspacing=0 ' +
'border=0 width=100% class=table table-' + id + '';
+ 'table class=table-' + id + '';
if ( 'headings' in page ) {
html +=
$.wikiEditor.modules.toolbar.fn.buildHeading( context, page.headings );
}
--
To view, visit https://gerrit.wikimedia.org/r/184846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf4b886e3b9b789df377dbdd2df94eb80dd61d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader
[MediaWiki-commits] [Gerrit] Fix whitespaces for JavaScript and CSS - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184581
Change subject: Fix whitespaces for JavaScript and CSS
..
Fix whitespaces for JavaScript and CSS
Change-Id: I3f6bf0d9e788cdca19b2b699fcb0a7b5ceab2a93
---
M modules/jquery.wikiEditor.dialogs.config.css
M modules/jquery.wikiEditor.dialogs.css
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
4 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/81/184581/1
diff --git a/modules/jquery.wikiEditor.dialogs.config.css
b/modules/jquery.wikiEditor.dialogs.config.css
index 1cc9f5a..6b3edce 100644
--- a/modules/jquery.wikiEditor.dialogs.config.css
+++ b/modules/jquery.wikiEditor.dialogs.config.css
@@ -148,18 +148,18 @@
clear: both;
height: 0;
}
-.wikieditor-toolbar-table-dimension-fields,
-.wikieditor-toolbar-dialog-wrapper {
- display: inline-table;
+.wikieditor-toolbar-table-dimension-fields,
+.wikieditor-toolbar-dialog-wrapper {
+ display: inline-table;
}
/* Hides from IE-mac \*/
-* html .wikieditor-toolbar-table-dimension-fields,
-* html .wikieditor-toolbar-dialog-wrapper {
- height: 1%;
+* html .wikieditor-toolbar-table-dimension-fields,
+* html .wikieditor-toolbar-dialog-wrapper {
+ height: 1%;
}
-.wikieditor-toolbar-table-dimension-fields,
-.wikieditor-toolbar-dialog-wrapper {
- display: block;
+.wikieditor-toolbar-table-dimension-fields,
+.wikieditor-toolbar-dialog-wrapper {
+ display: block;
}
/* End hide from IE-mac */
.wikiEditor-toolbar-dialog .ui-dialog-buttonpane {
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index b97ce7e..6d15f6a 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -21,7 +21,7 @@
padding: 0 !important;
}
-.wikiEditor-toolbar-dialog .ui-dialog-content fieldset {
+.wikiEditor-toolbar-dialog .ui-dialog-content fieldset {
border: none !important;
margin: 0 !important;
padding: 0 !important;
@@ -38,7 +38,7 @@
-khtml-box-sizing: border-box;
}
-.wikiEditor-toolbar-dialog .ui-dialog-content input[type=radio],
+.wikiEditor-toolbar-dialog .ui-dialog-content input[type=radio],
.wikiEditor-toolbar-dialog .ui-dialog-content input[type=checkbox] {
margin-left: 0;
}
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 68f8c20..60b1596 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -77,7 +77,7 @@
border-right: none;
}
/* Sprited Buttons */
-.wikiEditor-toolbar-spritedButton {
+.wikiEditor-toolbar-spritedButton {
/* @embed */
background: url(images/toolbar/button-sprite.png) 0 0 no-repeat;
display: block;
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index a2ba79a..53eb8a8 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -625,8 +625,8 @@
if ( show ) {
$section.removeClass(
'section-hidden' )
.attr( 'aria-expanded',
'true' )
- .animate( {opacity:
100.0}, 'fast', 'linear', function () {
-
$(this).addClass( 'section-visible' );
+ .animate( { opacity:
100.0 }, 'fast', 'linear', function () {
+ $( this
).addClass( 'section-visible' );
} );
if ( $section.hasClass(
'loading' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/184581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f6bf0d9e788cdca19b2b699fcb0a7b5ceab2a93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use obj.hasOwnProperty( prop ) instead of prop in obj - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184619
Change subject: Use obj.hasOwnProperty( prop ) instead of prop in obj
..
Use obj.hasOwnProperty( prop ) instead of prop in obj
'constructor' in {}; // true
Object.prototype.hasOwnProperty( {}, 'constructor' ); // false
Bug: T86643
Change-Id: I4356608956d722dc086e6876a53fdd93435c6f0a
---
M modules/jquery.wikiEditor.js
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/19/184619/1
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 55a55a8..7c67b8d 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -11,6 +11,8 @@
/*jshint onevar:false, boss:true */
( function ( $, mw ) {
+var hasOwn = Object.prototype.hasOwnProperty;
+
/**
* Global static object for wikiEditor that provides generally useful
functionality to all modules and contexts.
*/
@@ -168,7 +170,8 @@
*/
autoLang: function ( object, lang ) {
var defaultKey = $( 'body' ).hasClass( 'rtl' ) ? 'default-rtl'
: 'default';
- return object[lang || mw.config.get( 'wgUserLanguage' )] ||
object[defaultKey] || object['default'] || object;
+ lang = lang || mw.config.get( 'wgUserLanguage' );
+ return hasOwn.call( object, lang ) ? object[lang] :
object[defaultKey] || object['default'] || object;
},
/**
@@ -199,9 +202,9 @@
*/
autoIconOrOffset: function ( icon, offset, path, lang ) {
lang = lang || mw.config.get( 'wgUserLanguage' );
- if ( typeof offset === 'object' lang in offset ) {
+ if ( typeof offset === 'object' hasOwn.call( offset, lang )
) {
return offset[lang];
- } else if ( typeof icon === 'object' lang in icon ) {
+ } else if ( typeof icon === 'object' hasOwn.call( icon, lang
) ) {
return $.wikiEditor.autoIcon( icon, undefined, lang );
} else {
return $.wikiEditor.autoLang( offset, lang );
--
To view, visit https://gerrit.wikimedia.org/r/184619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4356608956d722dc086e6876a53fdd93435c6f0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] jquery.wikiEditor.toolbar.css: Use .cell-description stead o... - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184621
Change subject: jquery.wikiEditor.toolbar.css: Use .cell-description stead of
.description
..
jquery.wikiEditor.toolbar.css: Use .cell-description stead of .description
The following line has the same selector.
Change-Id: I26a131f269c6d0ee11015e388224dae79de4494f
---
M modules/jquery.wikiEditor.toolbar.css
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/21/184621/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 68f8c20..0cd83e3 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -262,7 +262,7 @@
.wikiEditor-ui-toolbar .section-help .page-table td.result {
width: 40%;
}
-.wikiEditor-ui-toolbar .section-help .page-table td.description,
+.wikiEditor-ui-toolbar .section-help .page-table td.cell-description,
.wikiEditor-ui-toolbar .section-help .page-table td.description {
width: 20%;
}
--
To view, visit https://gerrit.wikimedia.org/r/184621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26a131f269c6d0ee11015e388224dae79de4494f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Escape messages - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184300
Change subject: Escape messages
..
Escape messages
* Use .text() instead of .append() to add a text.
* Integrate only once used variables.
Change-Id: I62cd1a402fc44d90e746ec79e96a13aa49e7f926
---
M modules/jquery.wikiEditor.dialogs.config.js
1 file changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/00/184300/1
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index f5d8af3..1220eb3 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -330,28 +330,23 @@
} );
// Add images to the page existence
widget, which will be shown mutually exclusively to communicate if
// the page exists, does not exist or
the title is invalid (like if it contains a | character)
- var existsMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-exists' );
- var notexistsMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-notexists' );
- var invalidMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-invalid' );
- var externalMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-external' );
var loadingMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-loading' );
- var disambigMsg = mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-disambig' );
$(
'#wikieditor-toolbar-link-int-target-status' )
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-exists' )
- .append( existsMsg )
+ .text( mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-exists' ) )
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-notexists' )
- .append( notexistsMsg )
+ .text( mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-notexists' ) )
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-invalid' )
- .append( invalidMsg )
+ .text( mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-invalid' ) )
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-external' )
- .append( externalMsg )
+ .text( mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-external' ) )
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-loading' )
@@ -363,7 +358,7 @@
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-disambig' )
- .append( disambigMsg )
+ .text( mw.msg(
'wikieditor-toolbar-tool-link-int-target-status-disambig' ) )
)
.data( 'existencecache', {} )
.children().hide();
--
To view, visit https://gerrit.wikimedia.org/r/184300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62cd1a402fc44d90e746ec79e96a13aa49e7f926
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner:
[MediaWiki-commits] [Gerrit] Bump minimal Internet Explorer version from 7 to 8 - change (mediawiki...UniversalLanguageSelector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184305
Change subject: Bump minimal Internet Explorer version from 7 to 8
..
Bump minimal Internet Explorer version from 7 to 8
* Internet Explorer 8 does not support Object.keys:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
* jquery.uls.core.js uses Object.keys()
Change-Id: If5a6b6ee65451771fce0429fc4fb9622cc87bf9a
---
M resources/js/ext.uls.init.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/05/184305/1
diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js
index 47008a2..3c86e94 100644
--- a/resources/js/ext.uls.init.js
+++ b/resources/js/ext.uls.init.js
@@ -191,7 +191,7 @@
function isBrowserSupported() {
var blacklist = {
'msie': [
- [ '=', 7 ]
+ [ '=', 8 ]
]
};
--
To view, visit https://gerrit.wikimedia.org/r/184305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5a6b6ee65451771fce0429fc4fb9622cc87bf9a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use background-image instead of img for spinner - change (mediawiki...WikiEditor)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184301
Change subject: Use background-image instead of img for spinner
..
Use background-image instead of img for spinner
* Background images get embedded.
Change-Id: Iea1fb3db29b1eb8d5bff1b9b07a6c16145b9efc0
---
M modules/jquery.wikiEditor.dialogs.config.css
M modules/jquery.wikiEditor.dialogs.config.js
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/01/184301/1
diff --git a/modules/jquery.wikiEditor.dialogs.config.css
b/modules/jquery.wikiEditor.dialogs.config.css
index 1cc9f5a..2863d18 100644
--- a/modules/jquery.wikiEditor.dialogs.config.css
+++ b/modules/jquery.wikiEditor.dialogs.config.css
@@ -56,6 +56,7 @@
#wikieditor-toolbar-link-int-target-status-notexists,
#wikieditor-toolbar-link-int-target-status-invalid,
#wikieditor-toolbar-link-int-target-status-external,
+#wikieditor-toolbar-link-int-target-status-loading,
#wikieditor-toolbar-link-int-target-status-disambig {
padding-left: 30px;
background-position: 0 50%;
@@ -81,6 +82,12 @@
background-image: url(images/dialogs/insert-link-external.png);
background-position: left;
}
+#wikieditor-toolbar-link-int-target-status-loading {
+ /* @embed */
+ background-image: url(images/dialogs/loading-small.gif');
+ background-position: right;
+ height: 18px;
+}
#wikieditor-toolbar-link-int-target-status-disambig {
/* @embed */
background-image: url(images/dialogs/insert-disambiguation.png);
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index f5d8af3..2d3dd02 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -355,11 +355,7 @@
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-loading' )
- .append( $( 'img'
).attr( {
- 'src':
$.wikiEditor.imgPath + 'dialogs/' + 'loading-small.gif',
- 'alt':
loadingMsg,
- 'title':
loadingMsg
- } ) )
+ .attr( 'title',
loadingMsg )
)
.append( $( 'div' )
.attr( 'id',
'wikieditor-toolbar-link-int-target-status-disambig' )
--
To view, visit https://gerrit.wikimedia.org/r/184301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea1fb3db29b1eb8d5bff1b9b07a6c16145b9efc0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Restore support for IE8 - change (mediawiki...UniversalLanguageSelector)
Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184316
Change subject: Restore support for IE8
..
Restore support for IE8
IE8 does not support Object.keys.
Bug: T86516
Change-Id: Ib1a5df6c1660bc30f7b33f1b794a9229ce31cba6
---
M lib/jquery.uls/src/jquery.uls.core.js
1 file changed, 14 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/16/184316/1
diff --git a/lib/jquery.uls/src/jquery.uls.core.js
b/lib/jquery.uls/src/jquery.uls.core.js
index ab7f2ba..42e4336 100644
--- a/lib/jquery.uls/src/jquery.uls.core.js
+++ b/lib/jquery.uls/src/jquery.uls.core.js
@@ -354,13 +354,25 @@
* @return string
*/
getMenuWidth: function () {
- var languagesCount;
+ var language, languagesCount = 0;
if ( this.options.menuWidth ) {
return this.options.menuWidth;
}
- languagesCount = Object.keys( this.options.languages
).length;
+ // IE8 does not support Object.keys
+ if ( Object.keys ) {
+ languagesCount = Object.keys(
this.options.languages ).length;
+ } else {
+ for ( language in this.options.languages ) {
+ if (
Object.prototype.hasOwnProperty.call(
+ this.options.languages,
+ language
+ ) ) {
+ languagesCount++;
+ }
+ }
+ }
if ( languagesCount 12 ) {
return 'narrow';
--
To view, visit https://gerrit.wikimedia.org/r/184316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1a5df6c1660bc30f7b33f1b794a9229ce31cba6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
