Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund
wrote:
>
> On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote:
> > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund
> > wrote:
> > > EXT_shader_implicit_conversions is a useful extension that adds
> > > implicit
> > > conversions to OpenGL ES 3.1. Since it's tested excensively in
> > > dEQP, and
> > > Mesa already has support for implicit conversions, it seems
> > > reasonable to
> > > allow for the extension. This ended up mostly as code-cleanups
> > > anyway.
> > >
> > > While enabling this, one bug was discorvered due to a failing dEQP
> > > test
> > > (see the last patch).
> > >
> > > This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on
> > > i965.
> > >
> > > No piglit regressions observed.
> > >
> > > Erik Faye-Lund (5):
> > > glsl: add has_implicit_conversions()-helper
> > > glsl: add has_implicit_uint_to_int_conversion()-helper
> > > glsl: fall back to inexact function-match
> > > mesa/glsl: add support for EXT_shader_implicit_conversions
> > > glsl: do not allow implicit casts of unsized array initializers
> > >
> > Erik, I think we'd want the hole series minus the ES extension?
> >
> > The issues fixed with the final patch affect GLSL 1.30-4.60 at least.
> > Even if there's no desktop gl tests for it.
> >
>
> Do you mean for the 18.3 release? If so, yes that might be good. The
> last patch alone should also fix it, it shouldn't depend on the other
> patches...
>
Right, applied 742dace8251 ("glsl: do not allow implicit casts of
unsized array initializers") for the 18.3
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > wrote: > > > EXT_shader_implicit_conversions is a useful extension that adds > > > implicit > > > conversions to OpenGL ES 3.1. Since it's tested excensively in > > > dEQP, and > > > Mesa already has support for implicit conversions, it seems > > > reasonable to > > > allow for the extension. This ended up mostly as code-cleanups > > > anyway. > > > > > > While enabling this, one bug was discorvered due to a failing dEQP > > > test > > > (see the last patch). > > > > > > This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on > > > i965. > > > > > > No piglit regressions observed. > > > > > > Erik Faye-Lund (5): > > > glsl: add has_implicit_conversions()-helper > > > glsl: add has_implicit_uint_to_int_conversion()-helper > > > glsl: fall back to inexact function-match > > > mesa/glsl: add support for EXT_shader_implicit_conversions > > > glsl: do not allow implicit casts of unsized array initializers > > > > > Erik, I think we'd want the hole series minus the ES extension? > > > > The issues fixed with the final patch affect GLSL 1.30-4.60 at least. > > Even if there's no desktop gl tests for it. > > > > Do you mean for the 18.3 release? If so, yes that might be good. The > last patch alone should also fix it, it shouldn't depend on the other > patches... > Technically it should be applicable for earlier series. I'll leave it to the guys to decide if we'd want this in 18.2 though. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > wrote: > > EXT_shader_implicit_conversions is a useful extension that adds > > implicit > > conversions to OpenGL ES 3.1. Since it's tested excensively in > > dEQP, and > > Mesa already has support for implicit conversions, it seems > > reasonable to > > allow for the extension. This ended up mostly as code-cleanups > > anyway. > > > > While enabling this, one bug was discorvered due to a failing dEQP > > test > > (see the last patch). > > > > This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on > > i965. > > > > No piglit regressions observed. > > > > Erik Faye-Lund (5): > > glsl: add has_implicit_conversions()-helper > > glsl: add has_implicit_uint_to_int_conversion()-helper > > glsl: fall back to inexact function-match > > mesa/glsl: add support for EXT_shader_implicit_conversions > > glsl: do not allow implicit casts of unsized array initializers > > > Erik, I think we'd want the hole series minus the ES extension? > > The issues fixed with the final patch affect GLSL 1.30-4.60 at least. > Even if there's no desktop gl tests for it. > Do you mean for the 18.3 release? If so, yes that might be good. The last patch alone should also fix it, it shouldn't depend on the other patches... ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund wrote: > > EXT_shader_implicit_conversions is a useful extension that adds implicit > conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and > Mesa already has support for implicit conversions, it seems reasonable to > allow for the extension. This ended up mostly as code-cleanups anyway. > > While enabling this, one bug was discorvered due to a failing dEQP test > (see the last patch). > > This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965. > > No piglit regressions observed. > > Erik Faye-Lund (5): > glsl: add has_implicit_conversions()-helper > glsl: add has_implicit_uint_to_int_conversion()-helper > glsl: fall back to inexact function-match > mesa/glsl: add support for EXT_shader_implicit_conversions > glsl: do not allow implicit casts of unsized array initializers > Erik, I think we'd want the hole series minus the ES extension? The issues fixed with the final patch affect GLSL 1.30-4.60 at least. Even if there's no desktop gl tests for it. 12f001f013c glsl: add has_implicit_conversions()-helper e975c5b785f glsl: add has_implicit_uint_to_int_conversion()-helper ecab2d6f148 glsl: fall back to inexact function-match 742dace8251 glsl: do not allow implicit casts of unsized array initializers -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
LGTM, series is: Reviewed-by: Tapani Pälli On 10/30/18 7:11 PM, Erik Faye-Lund wrote: EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems reasonable to allow for the extension. This ended up mostly as code-cleanups anyway. While enabling this, one bug was discorvered due to a failing dEQP test (see the last patch). This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965. No piglit regressions observed. Erik Faye-Lund (5): glsl: add has_implicit_conversions()-helper glsl: add has_implicit_uint_to_int_conversion()-helper glsl: fall back to inexact function-match mesa/glsl: add support for EXT_shader_implicit_conversions glsl: do not allow implicit casts of unsized array initializers src/compiler/glsl/ast_function.cpp | 2 +- src/compiler/glsl/ast_to_hir.cpp | 8 src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 15 +++ src/compiler/glsl/ir_function.cpp| 3 ++- src/compiler/glsl_types.cpp | 5 ++--- src/mesa/main/extensions_table.h | 1 + 7 files changed, 26 insertions(+), 9 deletions(-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions
EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems reasonable to allow for the extension. This ended up mostly as code-cleanups anyway. While enabling this, one bug was discorvered due to a failing dEQP test (see the last patch). This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965. No piglit regressions observed. Erik Faye-Lund (5): glsl: add has_implicit_conversions()-helper glsl: add has_implicit_uint_to_int_conversion()-helper glsl: fall back to inexact function-match mesa/glsl: add support for EXT_shader_implicit_conversions glsl: do not allow implicit casts of unsized array initializers src/compiler/glsl/ast_function.cpp | 2 +- src/compiler/glsl/ast_to_hir.cpp | 8 src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 15 +++ src/compiler/glsl/ir_function.cpp| 3 ++- src/compiler/glsl_types.cpp | 5 ++--- src/mesa/main/extensions_table.h | 1 + 7 files changed, 26 insertions(+), 9 deletions(-) -- 2.17.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
