Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-04-04 Thread Simon Kagstrom
On Mon, 4 Apr 2011 23:21:35 +0200
William Lallemand  wrote:

> On Sun, 27 Mar 2011 08:36:31 +0200
> Simon Kagstrom  wrote:
> > This set of patches adds support for Spotify playback via an input
> > plugin and Spotify playlists via a playlist plugin.
> > [...]
> > Feedback wanted :-)
>
> I've got an issue using despotify, indeed, it works only with
> --no-daemon.

Yes, I also noticed this. I haven't looked at what might be causing it
yet, but I'll do that.

I haven't looked how/when the daemonzing is done, but one theory is
that the "singleton" in despotify_utils.c is initialized in the wrong
process, after the daemonizing is done. In that case, even though
despotify is initialized, the global session would be NULL.

// Simon

--
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-04-04 Thread William Lallemand
On Sun, 27 Mar 2011 08:36:31 +0200
Simon Kagstrom  wrote:
> Hi!
> 
> This set of patches adds support for Spotify playback via an input
> plugin and Spotify playlists via a playlist plugin.
> 
> They are based on the Despotify library, to which I've had to make a
> few modifications to get it working. Mainly, it's related to struct
> renaming, which would otherwise conflict with MPDs. I'm trying to
> upstream the despotify stuff, but it's difficult to get in contact
> with the despotify developers. For now, I've forked the repository
> myself, and it's available here:
> 
>   https://github.com/SimonKagstrom/despotify
> 
> 
> The patches are:
> 
> 1. Add support utilities to startup despotify and provide a session
> 
> 2. Add an input plugin. Playing a track can be done by
> 
>  mpc add spt://spotify:track:5qENVY0YEdZ7fiuOax70x1
>  mpc play
> 
> 3. Add a playlist plugin. Playlists can be added by
>  
>  mpc load
> spt://spotify:user:simon.kagstrom:playlist:3SUwkOe5VbVHysZcidEZtH
> 
> 4. Add documentation for the Spotify support
> 
> 5. Add despotify to the build system.
> 
> 
> Feedback wanted :-)
> 

Hello !

I've got an issue using despotify, indeed, it works only with
--no-daemon.

Using the normal daemon mode I've got :

[sekh@kirara:/]% mpc add spt://spotify:track:7kxM3UJwN6rHAW5kwdlAHK
[sekh@kirara:/]% mpc play
spt://spotify:track:7kxM3UJwN6rHAW5kwdlAHK
[playing] #1/1   0:00/0:00 (0%)
volume: 82%   repeat: off   random: off   single: off   consume: off

But no sound...

[sekh@kirara:~]% tail -f .mpd/log 
Apr 04 23:16 : avahi: Service 'Music Player' successfully established.
Apr 04 23:16 : decoder_thread: Unrecognized URI

I've built my mpd with these options:

Archive support:
(-bzip2) (-ISO9660) (-ZIP) 
Autodiscovery support:
(-Avahi) (-Bonjour) 
Client support:
(+IPv6) (+TCP) (+UNIX Domain Sockets) 
File format support:
(+AAC) (-C64 SID) (+FFMPEG) (+FLAC) (-FluidSynth) (-GME)
(-libsndfile) (-MikMod) (+MODPLUG) (+MAD) (-MPG123) (-MP4) (+Musepack)
(+OggFLAC) (-OggTremor) (+OggVorbis) (+WAVE) (+WavPack) (-WildMidi) 
Other features:
(+libsamplerate) (+inotify) (+SQLite) 
Metadata support:
(+cue) (+ID3) 
Playback support:
(+ALSA) (-ROAR) (-FFADO) (+FIFO) (+File Recorder) (+HTTP
Daemon) (-RAOP) (+JACK) (+libao) (+OSS) (-OpenAL) (-OS X) (-Pipeline)
(+PulseAudio) (-Media MVP) (+SHOUTcast) (-Solaris) (-WinMM) 
Streaming encoder support:
(+FLAC) (+LAME) (+Ogg Vorbis) (-TwoLAME) (+WAVE) 
Streaming support:
(+CURL) (-Last.FM) (+MMS) (-CDIO_PARANOIA) (+Despotify) 


I'm using an Ubuntu 10.10

-- 
William Lallemand

--
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-30 Thread Simon Kagstrom
On Wed, 30 Mar 2011 21:18:15 +0200
Max Kellermann  wrote:

> On 2011/03/29 20:41, Simon Kagstrom  wrote:
> > No, I'd like to create a set of playlists from my spotify playlists
> > which I can select and load with mpc or some other client.
> 
> MPD should not automatically create playlists, all actions should be
> caused by client commands.  What about a "playlistcopy" command, which
> can copy a remote playlist (from a playlist plugin) to the playlist
> directory?

Yes, I suspected this was a design principle, and I'm fine with that. A
playlistcopy command could be useful, but I'm not quite sure it would
be perfect for me though. I guess that would be used something like

  mpc playlistcopy 
spt://spotify:user:simon.kagstrom:playlist:3SUwkOe5VbVHysZcidEZtH

and then

  mpc lsplaylists

would find a new playlist built from the one above?

For me the problem is mostly to find the spotify playlists to start
with. They are stored in a "rootlist", i.e., a list of playlists,
so I'd still have to use an external tool to list them in that case.


Anyway, I think we can wait with this feature: For me, the external
tool to create xpsf playlists will be fine to start with.

// Simon

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-30 Thread Max Kellermann
On 2011/03/29 20:41, Simon Kagstrom  wrote:
> No, I'd like to create a set of playlists from my spotify playlists
> which I can select and load with mpc or some other client.

MPD should not automatically create playlists, all actions should be
caused by client commands.  What about a "playlistcopy" command, which
can copy a remote playlist (from a playlist plugin) to the playlist
directory?

--
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-29 Thread Simon Kagstrom
On Tue, 29 Mar 2011 19:18:15 +0200
Max Kellermann  wrote:

> On 2011/03/29 17:49, Simon Kagstrom  wrote:
> > I also have a question (again related to playlists, which I haven't
> > really understood it seems). With Spotify, users create their own
> > user playlists which is typically what you play there. In MPD, I
> > would therefore ideally want to easily load these (i.e.,
> > automatically). The despotify-playlist plugin contains everything
> > (basically) needed to parse these, but I don't think the interface
> > really supports something like that.
> > 
> > Or is there some other way of doing that "internally"?
> 
> Do what?  "mpc load ."?

No, I'd like to create a set of playlists from my spotify playlists
which I can select and load with mpc or some other client.

// Simon

--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-29 Thread Max Kellermann
On 2011/03/29 17:49, Simon Kagstrom  wrote:
> I also have a question (again related to playlists, which I haven't
> really understood it seems). With Spotify, users create their own user
> playlists which is typically what you play there. In MPD, I would
> therefore ideally want to easily load these (i.e., automatically). The
> despotify-playlist plugin contains everything (basically) needed to
> parse these, but I don't think the interface really supports something
> like that.
> 
> Or is there some other way of doing that "internally"?

Do what?  "mpc load ."?

--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-29 Thread Simon Kagstrom
On Tue, 29 Mar 2011 17:24:37 +0200
Max Kellermann  wrote:

> > This set of patches adds support for Spotify playback via an input
> > plugin and Spotify playlists via a playlist plugin.
>
> I've merged your patches, but I cannot test them, because I do not
> have a Spotify account.

Thank you!

> Please add documentation to doc/user.xml, and some information about
> your fork (i.e. the required despotify library version) to INSTALL.

I'll get back with better documentation.


I also have a question (again related to playlists, which I haven't
really understood it seems). With Spotify, users create their own user
playlists which is typically what you play there. In MPD, I would
therefore ideally want to easily load these (i.e., automatically). The
despotify-playlist plugin contains everything (basically) needed to
parse these, but I don't think the interface really supports something
like that.

Or is there some other way of doing that "internally"?


As a workaround, I've made a small playlist generator which create xpsf
playlists from your Spotify account:

  
https://github.com/SimonKagstrom/mci500h-hack/tree/master/tools/spotify-playlist-generator

for my purposes, this will probably work out, but I think it feels
slightly hacky. Also, when the user updates the playlists, they will
have to be re-generated.

// Simon

--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] [PATCH 0/5]: Spotify support via despotify

2011-03-29 Thread Max Kellermann
On 2011/03/27 08:36, Simon Kagstrom  wrote:
> Hi!
> 
> This set of patches adds support for Spotify playback via an input
> plugin and Spotify playlists via a playlist plugin.
> 
> They are based on the Despotify library, to which I've had to make a
> few modifications to get it working. Mainly, it's related to struct
> renaming, which would otherwise conflict with MPDs. I'm trying to
> upstream the despotify stuff, but it's difficult to get in contact with
> the despotify developers. For now, I've forked the repository myself,
> and it's available here:
> 
>   https://github.com/SimonKagstrom/despotify

I've merged your patches, but I cannot test them, because I do not
have a Spotify account.

I have added a pkg-config test to configure.ac.  That is needed if you
install the library in a non-standard location.

Please add documentation to doc/user.xml, and some information about
your fork (i.e. the required despotify library version) to INSTALL.

Max

--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team