Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git One more thing, I had a very quick look at the first commit that adds code: you added a copy of libexpat. Why that? Why not link this library, like everybody else does? -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
Max Kellermann writes: On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git Your first commit UpNP database plugin: build and configuration refers to files which don't exist (yet). All commits should be able to build and should work, or git bisect fails, which is annoying when looking for a bug. I wonder why you chose to split the commits this way. I wanted to separate the commit that modified existing mpd files from the commits that added new code. Sorry about not thinking about the bisect issue, but except for the configuration files themselves the commit only activates code if --enable-upnp is used. I wonder if you will actually want to keep this commit history anyway. Maybe the best approach will be to wait for a reasonably stable version (to be decided), decide if you want this at all, add the code in a single modification, and then switch to regular maintenance/modification commits. I think that it is a little early to test for regressions in this code, and that early commit histories only add noise, because it's very difficult to be orderly when exploring new stuff. jf -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
Max Kellermann writes: On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git One more thing, I had a very quick look at the first commit that adds code: you added a copy of libexpat. Why that? Why not link this library, like everybody else does? I am certainly not adding a copy of libexpat ! I have integrated and modified one file from libexpatmm (a c++ wrapper for libexpat), because this is very simple code, and I did not judge that it was worth the trouble to introduce another dependancy for something almost trivial. I have really no objection in principle to depending on libexpatmm instead, only I'm not completely sure that this is packaged on every platform. All this can be changed, this is a relatively big and complex piece of code, and I certainly don't expect to get it right the first time... With the commits I just added tonight, things mostly work with gmpc and minidlna, with exceptions which will be difficult to implement over UpNP (things based on VisitUniqueTags()). The main thing that I find still missing is add directory, I'm not too sure how to do this right. And the stats, I need to do the stats too :) jf -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
On 2013/11/04 19:02, j...@dockes.org wrote: I wanted to separate the commit that modified existing mpd files from the commits that added new code. I don't follow this argument. Adding a new source code file and registering it in Makefile.am belongs together, that's an operation that cannot be splitted. Only when you require modifications to other parts of MPD as preparation for your feature, then this must be a separate commit. For example, when you need one more parameter/method in an existing API declaration or function prototype, or when you add another generic utility library. I wonder if you will actually want to keep this commit history anyway. Maybe the best approach will be to wait for a reasonably stable version (to be decided), decide if you want this at all, add the code in a single modification, and then switch to regular maintenance/modification commits. Tell me when you feel it should be merged, and then I'll review the branch you cleaned up. It's somewhat cumbersome to review this branch in the current form. Hint: learn about stgit. -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
Max Kellermann writes: On 2013/11/04 19:02, j...@dockes.org wrote: I wanted to separate the commit that modified existing mpd files from the commits that added new code. I don't follow this argument. Adding a new source code file and registering it in Makefile.am belongs together, that's an operation that cannot be splitted. Only when you require modifications to other parts of MPD as preparation for your feature, then this must be a separate commit. For example, when you need one more parameter/method in an existing API declaration or function prototype, or when you add another generic utility library. Point taken, I should not have done the Makefile.am modification in this commit, but in the one which added the files. I wonder if you will actually want to keep this commit history anyway. Maybe the best approach will be to wait for a reasonably stable version (to be decided), decide if you want this at all, add the code in a single modification, and then switch to regular maintenance/modification commits. Tell me when you feel it should be merged, and then I'll review the branch you cleaned up. It's somewhat cumbersome to review this branch in the current form. Hint: learn about stgit. Ok. This said, at this point in the evolution of the still very young plugin: - I think that it is more useful to look at the code than at the commits. I am mostly using git as a backup tool for now. In really new code like this, it is not so interesting to look at the history, it's too chaotic. I've already dumped a good part of it. - If nobody is interested in actually trying out the function (as seems to be the case), the merge won't be a concern :) jf -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
On 2013/11/04 19:33, j...@dockes.org wrote: - If nobody is interested in actually trying out the function (as seems to be the case), the merge won't be a concern :) I can't - I have no UPnP hardware. Therefore, I have exactly zero personal interest in the feature ;-) -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server
Max Kellermann writes: On 2013/11/04 19:33, j...@dockes.org wrote: - If nobody is interested in actually trying out the function (as seems to be the case), the merge won't be a concern :) I can't - I have no UPnP hardware. Me neither. Therefore, I have exactly zero personal interest in the feature ;-) I'm much more interested in the MPD proxy db, which I use already. On the other hand, I've also just spent a fair amount of time persuading a piece of code to properly process Hindi text (उसको सत्य नहीं कह सकते हैं), in which I can't even count the letters, so I gather that personal interest is not always the motivation for writing software :) jf -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951iu=/4140/ostg.clktrk ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team