[GitHub] [apisix] tzssangglass edited a comment on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin
tzssangglass edited a comment on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-765208824 assigned me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin
tzssangglass commented on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-765208824 assigned me this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r562442530 ## File path: bin/apisix ## @@ -1,36 +1,43 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +elif [ -s '/usr/share/lua/5.1/apisix/cli/apisix.lua' ]; then +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: @tokers It's really unnecessary for the absolute path, thank you for your review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: feat: user can skip upstream when select service_id
codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging [#1302](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=desc) (bb67c34) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/749eeb58651c03b1d387d81a1d6f636f7fee93ae?el=desc) (749eeb5) will **increase** coverage by `5.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1302 +/- ## == + Coverage 44.36% 49.40% +5.04% == Files 31 41 +10 Lines1961 2360 +399 == + Hits 870 1166 +296 - Misses979 999 +20 - Partials 112 195 +83 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `17.39% <0.00%> (-78.27%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-53.34%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `59.25% <0.00%> (-20.75%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `51.85% <0.00%> (-7.41%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `55.36% <0.00%> (-2.26%)` | :arrow_down: | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | | ... and [28 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=footer). Last update [749eeb5...bb67c34](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #3391: [proposal]: add performance testing in CI
Yiyiyimu commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765199553 Waiting for the test result! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey opened a new pull request #1359: fix: Skip the data directly in Storage level
imjoey opened a new pull request #1359: URL: https://github.com/apache/apisix-dashboard/pull/1359 Signed-off-by: imjoey Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues Fixes #1357 . ___ ### Bugfix - Description As described in #1357 , we decide to move the skip logic to Storage from Store. This PR is going to achieve that. - How to fix? Remove `Skipped` field from `Event` object and Storage will eliminate the invalid data before sending to Store anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3394: fix(standalone): require consumer's id to be the same as username
Firstsawyou commented on pull request #3394: URL: https://github.com/apache/apisix/pull/3394#issuecomment-765178140 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liodo198592 commented on a change in pull request #191: fix：BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…
liodo198592 commented on a change in pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#discussion_r562421744 ## File path: test/e2e/scaffold/ingress.go ## @@ -29,6 +29,141 @@ import ( const ( _serviceAccount = "ingress-apisix-e2e-test-service-account" + _clusterRole = ` +apiVersion: rbac.authorization.k8s.io/v1 +kind: ClusterRole +metadata: + name: apisix-view-clusterrole Review comment: updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed issue #197: docs: add milestone link in README
gxthrj closed issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #198: doc:add milestone link
lianghao208 opened a new pull request #198: URL: https://github.com/apache/apisix-ingress-controller/pull/198 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues Fix #197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
gewei2000 commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765149345
> > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix,
can it solve your problem?
>
> this is not a best way in APISIX. we can use the Route + proxy cache
plugin to implement this feature.
>
> Route: match the request `/service_a/(.*)\.(png|jpg|js|css)$`
> Proxy-cache plugin: implement the proxy and cache file.
can not match any route
route config
```
{
"id": "1",
"name": "static_cache",
"plugins": {
"proxy-cache": {
"cache_zone": "disk_cache_one",
"cache_key": ["$host", "$uri", "$is_args", "$args"],
"cache_bypass": ["$arg_bypass"],
"cache_method": ["GET"],
"cache_http_status": [200],
"hide_cache_headers": true,
"no_cache": ["$arg_test"]
}
},
"upstream_id": "1",
"uris": ["/service_a/(.*)\\.(png|jpg|js|css)$"]
}
```
debug log
```
2021/01/22 13:52:53 [info] 39#39: *4987 [lua] init.lua:387:
http_access_phase(): not find any matched route, client: 10.0.0.3, server: ,
request: "GET /service_a/111.png HTTP/1.1", host: "10.1.2.2:9081"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #197: docs: add milestone link in README
gxthrj opened a new issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197 As many friends wanted to know about the plan of our project, we need to put the [milestone link](https://github.com/apache/apisix-ingress-controller/milestones) in the readme, so that everyone can view it, and also facilitate the discussion and adjustment of the plan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on issue #3391: [proposal]: add performance testing in CI
idbeta edited a comment on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765087092 > @idbeta How could we know that "not differ too much" would happen, or "they are within an order of magnitude". Maybe we need some methods to get over those false positives, but not just "as long as" I plan to change the APISIX's `worker_processes` from `auto` to `1`, then execute 10 times for each test, remove the highest and lowest values, find the average value, and compare it with the expected result (for example, I test 100 times in one route scenario, get the average value is 18942.1789. I think it can be used as the expected value of this scenario. ), which should reduce false positives. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #198: doc:add milestone link
gxthrj merged pull request #198: URL: https://github.com/apache/apisix-ingress-controller/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #197: docs: add milestone link in README
gxthrj commented on issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197#issuecomment-765142414 Is anyone interested to help deal with this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765062764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1154: Resource create request should return the ultimate data
imjoey closed issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: WIP: user can skip upstream when select service_id
codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging [#1302](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=desc) (745747c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5f2232603588a47f902a90d974692a7c6bea535f?el=desc) (5f22326) will **increase** coverage by `1.87%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1302 +/- ## == + Coverage 42.44% 44.31% +1.87% == Files 31 32 +1 Lines1932 1963 +31 == + Hits 820 870 +50 + Misses 1001 981 -20 - Partials 111 112 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: | | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+1.16%)` | :arrow_up: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+1.19%)` | :arrow_up: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `59.09% <0.00%> (+1.27%)` | :arrow_up: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.76%)` | :arrow_up: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+3.08%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=footer). Last update [5f22326...745747c](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
codecov-io edited a comment on pull request #1317: URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #191: fix：BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…
codecov-io commented on pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#issuecomment-764482700 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=h1) Report > Merging [#191](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=desc) (a759b9c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5fa2340e8fe13d2c6226bfdc76d32894fb8c729e?el=desc) (5fa2340) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #191 +/- ## === Coverage 47.68% 47.68% === Files 32 32 Lines1883 1883 === Hits 898 898 Misses846 846 Partials 139 139 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=footer). Last update [5fa2340...a759b9c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #190: chore:add ginkgo check before e2e-test(apache #186)
codecov-io edited a comment on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1) Report > Merging [#190](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=desc) (fc4a36f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0615aea1228ae7a05f2c6dd230f74b2b38e46fc4?el=desc) (0615aea) will **decrease** coverage by `0.96%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=tree) ```diff @@Coverage Diff @@ ## master #190 +/- ## == - Coverage 48.65% 47.68% -0.97% == Files 30 32 +2 Lines1482 1883 +401 == + Hits 721 898 +177 - Misses675 846 +171 - Partials 86 139 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `71.42% <0.00%> (-28.58%)` | :arrow_down: | | [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | `47.54% <0.00%> (-19.71%)` | :arrow_down: | | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `51.72% <0.00%> (-18.16%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `46.45% <0.00%> (-16.45%)` | :arrow_down: | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `53.84% <0.00%> (-11.73%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `31.77% <0.00%> (-7.12%)` | :arrow_down: | | [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/seven/state/service\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NlcnZpY2Vfd29ya2VyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.36% <0.00%> (ø)` | | | [pkg/id/idgen.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2lkL2lkZ2VuLmdv) | `100.00% <0.00%> (ø)` | | | ... and [2 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=footer). Last update [0615aea...fc4a36f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1182: Dockerfile source code is COPY from the current version instead of remote download
juzhiyuan commented on issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182#issuecomment-764441363 The DockerHub maintains an image for Apache APISIX Dashboard[1], you could pull that image instead of the building by hand, and here is the issue[2] to track when to omit that Dockerfile. [1] https://hub.docker.com/r/apache/apisix-dashboard [2] https://github.com/apache/apisix-dashboard/issues/1265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables
Firstsawyou commented on pull request #3363: URL: https://github.com/apache/apisix/pull/3363#issuecomment-764712708 > ci failed I need to adjust the code logic and I will solve the ci problem later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #194: doc: Add Apache APISIX link in README
codecov-io commented on pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764508833 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=h1) Report > Merging [#194](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=desc) (a687212) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5fa2340e8fe13d2c6226bfdc76d32894fb8c729e?el=desc) (5fa2340) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #194 +/- ## === Coverage 47.68% 47.68% === Files 32 32 Lines1883 1883 === Hits 898 898 Misses846 846 Partials 139 139 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=footer). Last update [5fa2340...a687212](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wfgydbu commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.
wfgydbu commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765070897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #3389: bug: get empty data from etcd when apisix init
gy09535 edited a comment on issue #3389: URL: https://github.com/apache/apisix/issues/3389#issuecomment-764556332 > @gy09535 > Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379 --user=apisix: get --from-key /apisix/upstreams` doesn't have: > > ``` > /apisix/upstreams/ > init_dir > ``` > > And what's your etcd's version? Key problem is I can not get data ,the response is empty, but I can watch data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1348: fix: update description input box
codecov-io commented on pull request #1348: URL: https://github.com/apache/apisix-dashboard/pull/1348#issuecomment-764790694 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=h1) Report > Merging [#1348](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=desc) (f60049b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f1a13ba08a51f71f47c8c9d422c108245ab8eba8?el=desc) (f1a13ba) will **decrease** coverage by `18.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1348 +/- ## === - Coverage 62.84% 44.31% -18.53% === Files 41 32-9 Lines2352 1963 -389 === - Hits 1478 870 -608 - Misses702 981 +279 + Partials 172 112 -60 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (-23.24%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1348/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=footer). Last update [f1a13ba...de61f97](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764207165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1833: request help: how to proxy grpc to grpcs.
spacewander closed issue #1833: URL: https://github.com/apache/apisix/issues/1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #650: support different config for APISIX and manager api in e2e test
nic-chen commented on issue #650: URL: https://github.com/apache/apisix-dashboard/issues/650#issuecomment-764473035 we use docker-compose to run env for e2e test now. and have supported different config test on cli test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb closed pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb closed pull request #3084: URL: https://github.com/apache/apisix/pull/3084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1351: bug: some apis bypassed authentication
nic-chen commented on issue #1351: URL: https://github.com/apache/apisix-dashboard/issues/1351#issuecomment-765059735 cc @starsz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1300: Label feature doesn't support Chinese as key?
nic-chen commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764217528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3377: fix: ignore the case of configured host
Firstsawyou commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561654367
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.6",
+"lua-resty-radixtree = 2.6.1",
Review comment:
`lua-resty-expr` also released v1.1.0, I think it can be updated by the
way.
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.6",
+"lua-resty-radixtree = 2.6.1",
Review comment:
Yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3381: fix: markdownlint issue
moonming commented on pull request #3381: URL: https://github.com/apache/apisix/pull/3381#issuecomment-764440900 @Yiyiyimu thanks for you help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3372: feat: allow ETCD work without some special keys
Yiyiyimu commented on pull request #3372: URL: https://github.com/apache/apisix/pull/3372#issuecomment-764445514 Hi @yongboy it would be better if you write some test case to prove it's correctness This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jenskeiner commented on a change in pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.
jenskeiner commented on a change in pull request #3308: URL: https://github.com/apache/apisix/pull/3308#discussion_r561675160 ## File path: doc/plugins/authz-keycloak.md ## @@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/ ## Attributes -| Name| Type | Requirement | Default | Valid | Description | -| --- | - | --- | - | -- | --- | -| discovery | string| optional| | https://host.domain/auth/realms/foo/.well-known/uma2-configuration | URL to discovery document for Keycloak Authorization Services. | -| token_endpoint | string| optional| | https://host.domain/auth/realms/foo/protocol/openid-connect/token | A OAuth2-compliant Token Endpoint that supports the `urn:ietf:params:oauth:grant-type:uma-ticket` grant type. Overrides value from discovery, if given. | -| grant_type | string| optional| "urn:ietf:params:oauth:grant-type:uma-ticket" | ["urn:ietf:params:oauth:grant-type:uma-ticket"]| | -| audience| string| optional| | | The client identifier of the resource server to which the client is seeking access. This parameter is mandatory when parameter permission is defined. | -| permissions | array[string] | optional| | | A string representing a set of one or more resources and scopes the client is seeking access. The format of the string must be: `RESOURCE_ID#SCOPE_ID`.| -| timeout | integer | optional| 3000 | [1000, ...] | Timeout(ms) for the http connection with the Identity Server. | -| ssl_verify | boolean | optional| true | | Verify if SSL cert matches hostname. | -| policy_enforcement_mode | string| optional| "ENFORCING" | ["ENFORCING", "PERMISSIVE"] | | - -### Endpoints - -Endpoints can optionally be discovered by providing a URL pointing to Keycloak's discovery document for Authorization Services for the realm -in the `discovery` attribute. The token endpoint URL will then be determined from that document. Alternatively, the token endpoint can be -specified explicitly via the `token_endpoint` attribute. - -One of `discovery` and `token_endpoint` has to be set. If both are given, the value from `token_endpoint` is used. +| Name | Type | Requirement | Default | Valid | Description | +| -- | - | --- | - | -- | --- | +| discovery | string| optional| |
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1182: Dockerfile source code is COPY from the current version instead of remote download
juzhiyuan closed issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1348: fix: update description input box
juzhiyuan merged pull request #1348: URL: https://github.com/apache/apisix-dashboard/pull/1348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1339: feat: add domSelector and data for search-route
juzhiyuan commented on a change in pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339#discussion_r561447686
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -17,8 +17,34 @@
/* eslint-disable no-undef */
context('Create and Search Route', () => {
+ const timeout = 500;
+ const data = {
Review comment:
data for testcases, LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #872: bug: manager-api should not allow create route with remote_addrs and remote_addr at the same time
nic-chen commented on issue #872: URL: https://github.com/apache/apisix-dashboard/issues/872#issuecomment-764463114 fixed by https://github.com/apache/apisix/pull/3008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3385: test: avoid unstable case caused by delete upstream 1
membphis merged pull request #3385: URL: https://github.com/apache/apisix/pull/3385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1341: test: user can skip upstream when select service_id
LiteSun commented on pull request #1341: URL: https://github.com/apache/apisix-dashboard/pull/1341#issuecomment-764464109 The test code has been merged into the LiteSun:feat-route branch. see https://github.com/apache/apisix-dashboard/pull/1302/commits/eee0847fe9fd4f125767a2ab4ce73aca0f918496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3370: bug: http service should not be started before etcd data is pulled
spacewander commented on issue #3370: URL: https://github.com/apache/apisix/issues/3370#issuecomment-764153237 This is a known issue. We plan to start pulling etcd data in the `init_worker` phase. To achieve this, we need to implement two preconditions first: 1. add Chaos test so that we can cover such a big change 2. allow lua-resty-etcd to use luasocket. Maybe we can do this in version `2.5`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code
moonming commented on pull request #3382: URL: https://github.com/apache/apisix/pull/3382#issuecomment-764675332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb commented on pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb commented on pull request #3084: URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #152: feat: add 2021-01-21-run-ingress-apisix-on-amazon-eks.md
juzhiyuan merged pull request #152: URL: https://github.com/apache/apisix-website/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
juzhiyuan commented on issue #1165: URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795 **Backend** - Provide the `version_check` API; **Frontend** - Call the above API when the page first shows, once. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2101: feat: customed config.yaml when apisix start
membphis commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561775948
##
File path: .github/workflows/lint.yml
##
@@ -1,6 +1,6 @@
name: ❄️ Lint
-on: [pull_request]
+on: [push, pull_request]
Review comment:
why do we need to change it in this PR?
one PR for one thing
##
File path: .travis/linux_openresty_common_runner.sh
##
@@ -108,7 +108,7 @@ script() {
./bin/apisix init_etcd
./bin/apisix start
-#start again --> fial
+#start again --> fail
Review comment:
we should fix it in a new PR.
one PR for one thing
##
File path: Makefile
##
@@ -98,7 +98,7 @@ endif
### stop: Stop the apisix server
.PHONY: stop
stop: default
- $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf -s stop
+ ./bin/apisix stop
Review comment:
ditto
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code
moonming commented on a change in pull request #3382: URL: https://github.com/apache/apisix/pull/3382#discussion_r561885573 ## File path: apisix/upstream.lua ## @@ -131,21 +131,21 @@ function _M.set_by_route(route, api_ctx) local up_conf = api_ctx.matched_upstream if not up_conf then -return 500, "missing upstream configuration in Route or Service" +return 503, "missing upstream configuration in Route or Service" Review comment: no test case cover This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #186: The Ginkgo tool is used in the e2e test script, but the pre-installation check is not performed in the makefile script
tokers closed issue #186: URL: https://github.com/apache/apisix-ingress-controller/issues/186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3366: docs(traffic-split): update the vars example of the docs
Firstsawyou commented on a change in pull request #3366: URL: https://github.com/apache/apisix/pull/3366#discussion_r561595034 ## File path: doc/zh-cn/plugins/traffic-split.md ## @@ -55,12 +55,15 @@ traffic-split 插件使用户可以逐步引导各个上游之间的流量百分 traffic-split 插件主要由 `match` 和 `weighted_upstreams` 两部分组成，`match` 是自定义的条件规则，`weighted_upstreams` 是 upstream 的配置信息。如果配置 `match` 和 `weighted_upstreams` 信息，那么在 `match` 规则校验通过后，会根据 `weighted_upstreams` 中的 `weight` 值；引导插件中各个 upstream 之间的流量比例，否则，所有流量直接到达 `route` 或 `service` 上配置的 `upstream`。当然你也可以只配置 `weighted_upstreams` 部分，这样会直接根据 `weighted_upstreams` 中的 `weight` 值，引导插件中各个 upstream 之间的流量比例。 ->注：1、在 `match` 里，vars 中的表达式是 `and` 的关系，多个 `vars` 之间是 `or` 的关系。2、在插件的 weighted_upstreams 中只有 `weight` 值，表示到达 `route` 或 `service` 上配置的 upstream 流量权重值。如： +>注：1、在 `match` 里，vars 中的表达式是 `and` 的关系，多个 `vars` 之间是 `or` 的关系。2、在插件的 weighted_upstreams 中，若存在单独的 `weight` 字段，表示到达 `route` 或 `service` 上的 upstream 流量权重值。如： Review comment: updated. @tokers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #1279: 当Route中存在被禁用的插件时Service里的同名插件失效
moonming commented on issue #1279: URL: https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-764496391 any PR for this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1335: Align dashboard menu options to the left
juzhiyuan closed issue #1335: URL: https://github.com/apache/apisix-dashboard/issues/1335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1308: test: Create Upstream in Route.
guoqqqi commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561898842
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', () => {
cy.contains(data.routeName).siblings().contains('Edit').click();
// fetching Resource
-cy.wait(500);
+cy.get(domSelector.name).click();
Review comment:
During the test, I found that the new url can be resolve directly after
clicking
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] ClementeGao commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string
ClementeGao commented on issue #122: URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765128154 一定要检查下配置文件 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1344: fix: ignore the init_dir event when watching etcd events
juzhiyuan merged pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis merged pull request #194: doc: Add Apache APISIX link in README
membphis merged pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
tokers commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561456506 ## File path: apisix/cli/apisix.lua ## @@ -0,0 +1,36 @@ +#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit Review comment: And the path is a classical brew path, what if people run APISIX on Linux distro? ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: I'm afraid the path is not so common, people may suffer "file not found" problem in different OS. ## File path: bin/apisix ## @@ -1,36 +1,43 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +elif [ -s '/usr/share/lua/5.1/apisix/cli/apisix.lua' ]; then +
[GitHub] [apisix] spacewander commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code
spacewander commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764218407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1290: Switch Language doesn't work 樂
juzhiyuan closed issue #1290: URL: https://github.com/apache/apisix-dashboard/issues/1290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang closed issue #3364: request help: How to use apisix proxy apisix-dashboard
pengtaochang closed issue #3364: URL: https://github.com/apache/apisix/issues/3364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on issue #3391: [proposal]: add performance testing in CI
idbeta edited a comment on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765087092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1347: fix: editing a Service, the upstream info will be lost.
codecov-io commented on pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#issuecomment-764777926 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=h1) Report > Merging [#1347](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=desc) (42eb74e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6d7f11a14c84c4f918827ae5f24befaf02bf681f?el=desc) (6d7f11a) will **decrease** coverage by `13.90%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1347 +/- ## === - Coverage 62.79% 48.89% -13.91% === Files 41 41 Lines2352 2352 === - Hits 1477 1150 -327 - Misses700 1011 +311 - Partials 175 191 +16 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `17.39% <0.00%> (-78.27%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `59.37% <0.00%> (-28.75%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `62.71% <0.00%> (-20.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `74.46% <0.00%> (-17.03%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `50.43% <0.00%> (-16.96%)` | :arrow_down: | | ... and [13 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=footer). Last update [6d7f11a...42eb74e](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on pull request #1358: fix: add maxlength={256} to Input.TextArea
KishaniKandasamy commented on pull request #1358: URL: https://github.com/apache/apisix-dashboard/pull/1358#issuecomment-765134440  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
membphis commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-764733027 > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? this is not a best way in APISIX. we can use the Route + proxy cache plugin to implement this feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764209076 > @nic-chen Hi, the CI of your PR has not been passed. You need to rebase the master branch, and the get list method of store needs to add the `context` parameter thanks for remind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3393: Plugin enhance
tokers commented on issue #3393: URL: https://github.com/apache/apisix/issues/3393#issuecomment-765067688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3357: bug: failed to match the host which contains uppercase letters
spacewander closed issue #3357: URL: https://github.com/apache/apisix/issues/3357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI
idbeta commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-764523577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] ClementeGao closed issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string
ClementeGao closed issue #122: URL: https://github.com/apache/apisix-docker/issues/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-764509337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #3378: Label feature doesn't support Chinese as key?
juzhiyuan closed issue #3378: URL: https://github.com/apache/apisix/issues/3378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis closed issue #193: request help: Need to add Apache APISIX link in README
membphis closed issue #193: URL: https://github.com/apache/apisix-ingress-controller/issues/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] FeynmanZhou commented on pull request #195: doc: run ingress apisix on kubesphere
FeynmanZhou commented on pull request #195: URL: https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764530599 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1347: fix: editing a Service, the upstream info will be lost.
codecov-io edited a comment on pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#issuecomment-764777926 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=h1) Report > Merging [#1347](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=desc) (8b5dfec) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6d7f11a14c84c4f918827ae5f24befaf02bf681f?el=desc) (6d7f11a) will **decrease** coverage by `13.86%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1347 +/- ## === - Coverage 62.79% 48.93% -13.87% === Files 41 41 Lines2352 2352 === - Hits 1477 1151 -326 - Misses700 1008 +308 - Partials 175 193 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `17.39% <0.00%> (-78.27%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `59.37% <0.00%> (-28.75%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `62.71% <0.00%> (-20.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `74.46% <0.00%> (-17.03%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `50.43% <0.00%> (-16.96%)` | :arrow_down: | | ... and [11 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1347/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=footer). Last update [6d7f11a...8b5dfec](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
Fuchange commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: i agree with you . if people installed apisix by `make install` , it will be ok. but if people installed it by apisix rpm-package , apisix.lua will in ` /usr/local/apisix/apisix/cli/ ` Should we integrate these two paths? After all, bash can't easily find multiple paths like Lua. ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: i agree with you . if people
[GitHub] [apisix] spacewander closed issue #3389: bug: get empty data from etcd when apisix init
spacewander closed issue #3389: URL: https://github.com/apache/apisix/issues/3389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
starsz commented on issue #1161: URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550 This is a big project, I will finish part of them in M2.4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS
tokers commented on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764448797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
starsz commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: add milestone link (#198)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 009db9b add milestone link (#198) 009db9b is described below commit 009db9bcc124398a789fe4aac59d2c74a7264927 Author: rootlh <302824...@qq.com> AuthorDate: Fri Jan 22 14:24:55 2021 +0800 add milestone link (#198) add milestone link --- README.md | 4 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 16fe40e..bc35bd2 100644 --- a/README.md +++ b/README.md @@ -122,6 +122,10 @@ We welcome all kinds of contributions from the open-source community, individual *  - follow and interact with us using hashtag `#ApacheAPISIX` * [Bilibili video](https://space.bilibili.com/551921247) +## Milestone + +* [Milestone](https://github.com/apache/apisix-ingress-controller/milestones) + ## Terminology * Ingress APISIX: the whole service that contains the proxy ([Apache APISIX](https://apisix.apache.org)) and ingress controller (apisix ingress controller).
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #193: request help: Need to add Apache APISIX link in README
gxthrj commented on issue #193: URL: https://github.com/apache/apisix-ingress-controller/issues/193#issuecomment-764462551 Is there anybody interested to deal with this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #20: Modify Helm template to support multiple etcdhost, add anti-affinity
tokers commented on a change in pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r562338355
##
File path: README.md
##
@@ -44,14 +44,15 @@ helm uninstall apisix ./chart/apisix -n default
1. How to install APISIX only?
-The Charts will install etcd 3.4.14 by default. If you want to install Apache
APISIX only, please set `etcd.enabled=false` and set
`etcd.host=http://your_etcd_address:2379`.
+The Charts will install etcd 3.4.14 by default. If you want to install Apache
APISIX only, please set `etcd.enabled=false` and set
`etcd.host={http://your_etcd_address:2379}`.
Review comment:
Strange, if i don't want to install etcd, why should i still care and
set the etcd host?
##
File path: README.md
##
@@ -44,14 +44,15 @@ helm uninstall apisix ./chart/apisix -n default
1. How to install APISIX only?
-The Charts will install etcd 3.4.14 by default. If you want to install Apache
APISIX only, please set `etcd.enabled=false` and set
`etcd.host=http://your_etcd_address:2379`.
+The Charts will install etcd 3.4.14 by default. If you want to install Apache
APISIX only, please set `etcd.enabled=false` and set
`etcd.host={http://your_etcd_address:2379}`.
Please use the FQDN address or the IP of the etcd.
```shell
+# if etcd export by kubernetes service need spell fully qualified name
$ helm install apisix ./chart/apisix -n default \
--set etcd.enabled=false \
---set etcd.host=http://your_etcd_address:2379
+--set etcd.host={http://etcd_node_1:2379\,http://etcd_node_2:2379}
Review comment:
Better to add some descriptions about how people can pass multiple etcd
hosts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #190: chore:add ginkgo check before e2e-test(apache #186)
tokers commented on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764691393 Many thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #3383: request help: how do i know plugin Orchestration condition variables
nic-chen commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-764739359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64
idbeta commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764201065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #650: support different config for APISIX and manager api in e2e test
nic-chen closed issue #650: URL: https://github.com/apache/apisix-dashboard/issues/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jaredhuang commented on issue #3383: request help: how do i know plugin Orchestration condition variables
jaredhuang commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-765056916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3364: request help: How to use apisix proxy apisix-dashboard
pengtaochang commented on issue #3364: URL: https://github.com/apache/apisix/issues/3364#issuecomment-764206385 thanks @Miss-you @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1329: bug: non-json data causes error logs
imjoey commented on issue #1329: URL: https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764195294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xingren23 commented on issue #3353: request help: do you want update skywalking plugin protocal from http1.1 to grpc ?
xingren23 commented on issue #3353: URL: https://github.com/apache/apisix/issues/3353#issuecomment-764190325 > Proxy gRPC in C is different from communication via gRPC in Lua. > > BTW, we are not the maintainer of skywalking. We don't own https://github.com/apache/skywalking-nginx-lua. > It would be better if you ask this question to them. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dw-3 commented on issue #3359: issue of traffic split vars
dw-3 commented on issue #3359: URL: https://github.com/apache/apisix/issues/3359#issuecomment-764195663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r561660169
##
File path: api/test/e2e/route_export_test.go
##
@@ -0,0 +1,716 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "strings"
+ "testing"
+)
+
+func TestRoute_Export(t *testing.T) {
+ exportStrR1 := `
+ "/hello_": {
+ "get": {
+ "operationId": "Get",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "security": [],
+ "x-apisix-enableWebsocket": false,
+ "x-apisix-hosts": ["foo.com",
"*.bar.com"],
+ "x-apisix-labels": {
+ "build": "16",
+ "env": "production",
+ "version": "v2"
+ },
+ "x-apisix-plugins": {
+ "limit-count": {
+ "count": 2,
+ "key": "remote_addr",
+ "rejected_code": 503,
+ "time_window": 60
+ }
+ },
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+ "172.16.238.20:1980": 1
+ },
+ "type": "roundrobin"
+ }
+ },
+ "post": {
+ "operationId": "Post",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "security": [],
+ "x-apisix-enableWebsocket": false,
+ "x-apisix-hosts": ["foo.com",
"*.bar.com"],
+ "x-apisix-labels": {
+ "build": "16",
+ "env": "production",
+ "version": "v2"
+ },
+ "x-apisix-plugins": {
+ "limit-count": {
+ "count": 2,
+ "key": "remote_addr",
+ "rejected_code": 503,
+ "time_window": 60
+ }
+ },
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1344: fix: ignore the init_dir event when watching etcd events
codecov-io edited a comment on pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764618036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
idbeta commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819 > @idbeta > Can this issue be reproduced in the latest version of dashboard? Is there any error log in the APISIX size? > 1、Can not more than 200 characters still can > 2、the route is useless no problem now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1347: fix: editing a Service, the upstream info will be lost.
juzhiyuan commented on a change in pull request #1347:
URL: https://github.com/apache/apisix-dashboard/pull/1347#discussion_r562296901
##
File path: web/src/pages/Service/Create.tsx
##
@@ -81,13 +81,12 @@ const Page: React.FC = (props) => {
(serviceId ? update(serviceId, data) : create(data))
.then(() => {
notification.success({
- message: `${
-serviceId
+ message: `${serviceId
? formatMessage({ id: 'component.global.edit' })
: formatMessage({ id: 'component.global.create' })
- } ${formatMessage({ id: 'menu.service' })} ${formatMessage({
-id: 'component.status.success',
- })}`,
+} ${formatMessage({ id: 'menu.service' })} ${formatMessage({
Review comment:
format
##
File path: web/src/pages/Service/Create.tsx
##
@@ -71,8 +71,8 @@ const Page: React.FC = (props) => {
};
const upstreamFormData = upstreamRef.current?.getData();
-if (upstreamFormData.upstream_id === '') {
- data.upstream = omit(upstreamFormData, ['upstream_id']);
+if (!upstreamFormData.upstream_id) {
Review comment:
Is it possible to have something like:
```js
{
"upstream_id": "",
"xxx": ""
}
```
in `upstreamFormData`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1102: feat: import route from OpenAPI Specification3.0
juzhiyuan commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764448583 > Do we need to add **test cases** about > > 1. import a error file > 2. a file includes two or more APIs Yep This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
