Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2226817555 > @CrazyHZM Hello, 3 weeks have passed, is there have any new suggestions? @AlbumenJ @CrazyHZM Looking forward to new news. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2212499025 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [187 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2212487738 @CrazyHZM Hello, 3 weeks have passed, is there have any new suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641765580
##
dubbo-metrics/dubbo-metrics-annotation/pom.xml:
##
@@ -23,20 +23,18 @@
${revision}
../pom.xml
- dubbo-metrics-event
+ dubbo-metrics-annotation
Review Comment:
The new commit separates MetricsServiceExporter to dubbo-metrics-api, and
rename dubbo-metrics-annotation to dubbo-metrics-monitor.
dubbo-metrics-monitor retains some monitor interfaces. These interfaces have
been marked as deprecated and are still relied upon by various packages.
I'm not sure if this is a good idea, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641662301 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: > Why modify it？ Please only modify the content related to this PR. The implementation of the REST protocol has been moved from the dubbo project to the dubbo-spi-extension project. Here is the test code, and the REST protocol loading fails when executed. ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: > Why modify it？ Please only modify the content related to this PR. Or do I need to add the corresponding dependency packages of the rest protocol? Please confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1644813721 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: Commited rollback and submit a new issues to fix that. https://github.com/apache/dubbo/issues/14340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2171674487 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [160 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641764971
##
dubbo-metrics/dubbo-metrics-starter/pom.xml:
##
@@ -0,0 +1,62 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+org.apache.dubbo
+dubbo-metrics
+${revision}
+../pom.xml
+
+ dubbo-metrics-starter
Review Comment:
Get. The new commit merges dubbo-metrics-starter into dubbo-metrics-default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641764971
##
dubbo-metrics/dubbo-metrics-starter/pom.xml:
##
@@ -0,0 +1,62 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+org.apache.dubbo
+dubbo-metrics
+${revision}
+../pom.xml
+
+ dubbo-metrics-starter
Review Comment:
The new commit merges dubbo-metrics-starter into dubbo-metrics-default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641765580
##
dubbo-metrics/dubbo-metrics-annotation/pom.xml:
##
@@ -23,20 +23,18 @@
${revision}
../pom.xml
- dubbo-metrics-event
+ dubbo-metrics-annotation
Review Comment:
The new commit separates MetricsServiceExporter to dubbo-metrics-api, and
rename dubbo-metrics-annotation to dubbo-metrics-monitor.
dubbo-metrics-monitor retains some monitor interfaces. These interfaces have
been marked as deprecated and are still relied upon by various packages.
I'm not sure how to deal with them, do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641764971
##
dubbo-metrics/dubbo-metrics-starter/pom.xml:
##
@@ -0,0 +1,62 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+org.apache.dubbo
+dubbo-metrics
+${revision}
+../pom.xml
+
+ dubbo-metrics-starter
Review Comment:
The new commit merges dubbo-metrics-starter into dubbo-metrics-default.
Maybe dubbo-metrics-default can be renamed to dubbo-metrics-all? In fact,
all metrics packages are merged here. No distinction is made between default
and other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641676963 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: > Why modify it？ Please only modify the content related to this PR. Or do I need to add the corresponding dependency packages of the rest protocol? Please confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641662301 ## dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml: ## @@ -29,7 +29,7 @@ - + Review Comment: > Why modify it？ Please only modify the content related to this PR. The implementation of the REST protocol has been moved from the dubbo project to the dubbo-spi-extension project. Here is the test code, and the REST protocol loading fails when executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
CrazyHZM commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1641135419
##
dubbo-metrics/dubbo-metrics-starter/pom.xml:
##
@@ -0,0 +1,62 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ 4.0.0
+
+org.apache.dubbo
+dubbo-metrics
+${revision}
+../pom.xml
+
+ dubbo-metrics-starter
Review Comment:
I don't accept adding this jar to manage metrics dependency， It brings a
more complex structure to the Dubbo project.
##
dubbo-metrics/dubbo-metrics-annotation/pom.xml:
##
@@ -23,20 +23,18 @@
${revision}
../pom.xml
- dubbo-metrics-event
+ dubbo-metrics-annotation
Review Comment:
Why should it be separated from the dubbo-metrics-api?
##
dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/main/resources/spring/dubbo-provider.xml:
##
@@ -29,7 +29,7 @@
-
+
Review Comment:
Why modify it？ Please only modify the content related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2169394504 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2166001924 > "[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes." happens again. I have no idea about the reason. It would be great if someone could give some hints. Thanks. @AlbumenJ Thanks for your help. Notice that you triggered a retry, but the results are still not satisfactory. `Run curl "http://dubbo-vm.apache.org:8000/token?workflow_id=9461697580"; -o /home/runner/work/dubbo/dubbo/.tmp/encrypted-sonarcloud-token % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 128 100 1280 0114 0 0:00:01 0:00:01 --:--:-- 114 100 128 100 1280 0114 0 0:00:01 0:00:01 --:--:-- 114 The command rsautl was deprecated in version 3.0. Use 'pkeyutl' instead. Could not open file or uri for loading private key from /home/runner/work/dubbo/dubbo/.tmp/rsa/rsa_private.pem 40E788EC087F:error:[16](https://github.com/apache/dubbo/actions/runs/9461697580/job/26160248316#step:7:17)69:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../crypto/store/store_register.c:237:scheme=file 40E788EC087F:error:8002:system library:file_open:No such file or directory:../providers/implementations/storemgmt/file_store.c:267:calling stat(/home/runner/work/dubbo/dubbo/.tmp/rsa/rsa_private.pem) Error: Process completed with exit code 1.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2160289822 "[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes." happens again. I have no idea about the reason. It would be great if someone could give some hints. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2156033768 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1629302771
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
Rename DubboApplicationMulticasterRegistry to
DubboMulticasterScopeModelInitializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1629302771
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
Rename DubboApplicationMulticasterRegistry to
DubboMulticasterScopeModelInitializer.
Mark DubboEventMulticaster as SPI to allow extension implementation.
I'm not sure what you mean. Does this meet your expectations?
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
Rename DubboApplicationMulticasterRegistry to
DubboMulticasterScopeModelInitializer.
Mark DubboEventMulticaster as SPI to allow extension implementation.
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
I'm not sure what you mean. Does this meet your expectations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2155248241 The log for checks fail is '##[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes.'. I have no idea about the reasion. Looking for help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1629302771
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
Rename DubboApplicationMulticasterRegistry to
DubboMulticasterScopeModelInitializer.
Mark DubboEventMulticaster as SPI to allow extension implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
CrazyHZM commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1628018217
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
DubboApplicationMulticasterRegistry can have more specifications and make it
more general. DubboApplicationMulticasterRegistry needs to be re-named.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2149615925 > @CrazyHZM Hello, 2 weeks have passed, is there have any new suggestions? @AlbumenJ @CrazyHZM Looking forward to new news. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2136577183 @CrazyHZM Hello, 2 weeks have passed, is there have any new suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2133509281 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [104 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119155034 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119154946 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119119339 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605952445
##
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/event/MetaDataEvent.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metadata.event;
+
+import org.apache.dubbo.common.event.DubboEvent;
+import org.apache.dubbo.common.utils.TimePair;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+public abstract class MetaDataEvent extends DubboEvent {
Review Comment:
Submitted,thanks for your guidance !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605952395
##
dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/ConfigCenterChangeEvent.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.common.config.configcenter;
+
+import org.apache.dubbo.common.event.DubboEvent;
+import org.apache.dubbo.common.utils.TimePair;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+public class ConfigCenterChangeEvent extends DubboEvent {
+
+private final String key;
+
+private final String group;
+
+private final String protocol;
+
+private final String changeType;
+
+private final int count;
+
+private final TimePair timePair;
+
+public ConfigCenterChangeEvent(
+ApplicationModel source, String key, String group, String
protocol, String changeType) {
+this(source, key, group, protocol, changeType, 1);
+}
+
+public ConfigCenterChangeEvent(
+ApplicationModel source, String key, String group, String
protocol, String changeType, int count) {
Review Comment:
Accepted and submitted, please confirm whether it is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605952323
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,26 +14,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
-import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
+import org.apache.dubbo.rpc.model.ScopeModelDestroyListener;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboEventBus
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry
Review Comment:
Accepted and submitted, please confirm whether it is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605952297
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,26 +14,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
-import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
+import org.apache.dubbo.rpc.model.ScopeModelDestroyListener;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboEventBus
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry
+implements ScopeModelInitializer,
ScopeModelDestroyListener {
+
+private static final ConcurrentHashMap multicasterMap =
+new ConcurrentHashMap<>();
@Override
public void initializeFrameworkModel(FrameworkModel frameworkModel) {}
@Override
public void initializeApplicationModel(ApplicationModel applicationModel) {
-ScopeBeanFactory beanFactory = applicationModel.getBeanFactory();
-beanFactory.registerBean(MetricsDispatcher.class);
+multicasterMap.computeIfAbsent(applicationModel, t -> new
DefaultDubboEventMulticaster());
+applicationModel.addDestroyListener(this);
}
@Override
public void initializeModuleModel(ModuleModel moduleModel) {}
+
+@Override
+public void onDestroy(ApplicationModel scopeModel) {
+multicasterMap.remove(scopeModel);
+}
+
+@Override
+public boolean isProtocol() {
+return true;
+}
+
+public static DubboLifecycleEventMulticaster
getMulticaster(ApplicationModel applicationModel) {
Review Comment:
Accepted and submitted, please confirm whether it is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119095471 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
FoghostCn commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605782174
##
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/event/MetaDataEvent.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.metadata.event;
+
+import org.apache.dubbo.common.event.DubboEvent;
+import org.apache.dubbo.common.utils.TimePair;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+public abstract class MetaDataEvent extends DubboEvent {
Review Comment:
typo MetaData to Metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
FoghostCn commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605781586
##
dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/ConfigCenterChangeEvent.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.common.config.configcenter;
+
+import org.apache.dubbo.common.event.DubboEvent;
+import org.apache.dubbo.common.utils.TimePair;
+import org.apache.dubbo.rpc.model.ApplicationModel;
+
+public class ConfigCenterChangeEvent extends DubboEvent {
+
+private final String key;
+
+private final String group;
+
+private final String protocol;
+
+private final String changeType;
+
+private final int count;
+
+private final TimePair timePair;
+
+public ConfigCenterChangeEvent(
+ApplicationModel source, String key, String group, String
protocol, String changeType) {
+this(source, key, group, protocol, changeType, 1);
+}
+
+public ConfigCenterChangeEvent(
+ApplicationModel source, String key, String group, String
protocol, String changeType, int count) {
Review Comment:
changeType Why not use enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1605692853
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,26 +14,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
-import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
+import org.apache.dubbo.rpc.model.ScopeModelDestroyListener;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboEventBus
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry
+implements ScopeModelInitializer,
ScopeModelDestroyListener {
+
+private static final ConcurrentHashMap multicasterMap =
+new ConcurrentHashMap<>();
@Override
public void initializeFrameworkModel(FrameworkModel frameworkModel) {}
@Override
public void initializeApplicationModel(ApplicationModel applicationModel) {
-ScopeBeanFactory beanFactory = applicationModel.getBeanFactory();
-beanFactory.registerBean(MetricsDispatcher.class);
+multicasterMap.computeIfAbsent(applicationModel, t -> new
DefaultDubboEventMulticaster());
+applicationModel.addDestroyListener(this);
}
@Override
public void initializeModuleModel(ModuleModel moduleModel) {}
+
+@Override
+public void onDestroy(ApplicationModel scopeModel) {
+multicasterMap.remove(scopeModel);
+}
+
+@Override
+public boolean isProtocol() {
+return true;
+}
+
+public static DubboLifecycleEventMulticaster
getMulticaster(ApplicationModel applicationModel) {
Review Comment:
Yes, you are right !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
CrazyHZM commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1604954801
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,26 +14,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
-import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
+import org.apache.dubbo.rpc.model.ScopeModelDestroyListener;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboEventBus
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry
+implements ScopeModelInitializer,
ScopeModelDestroyListener {
+
+private static final ConcurrentHashMap multicasterMap =
+new ConcurrentHashMap<>();
@Override
public void initializeFrameworkModel(FrameworkModel frameworkModel) {}
@Override
public void initializeApplicationModel(ApplicationModel applicationModel) {
-ScopeBeanFactory beanFactory = applicationModel.getBeanFactory();
-beanFactory.registerBean(MetricsDispatcher.class);
+multicasterMap.computeIfAbsent(applicationModel, t -> new
DefaultDubboEventMulticaster());
+applicationModel.addDestroyListener(this);
}
@Override
public void initializeModuleModel(ModuleModel moduleModel) {}
+
+@Override
+public void onDestroy(ApplicationModel scopeModel) {
+multicasterMap.remove(scopeModel);
+}
+
+@Override
+public boolean isProtocol() {
+return true;
+}
+
+public static DubboLifecycleEventMulticaster
getMulticaster(ApplicationModel applicationModel) {
Review Comment:
Defining an api as static is not a very good idea; try using instance
objects to manage it.
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,26 +14,52 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
-import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
+import org.apache.dubbo.rpc.model.ScopeModelDestroyListener;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboEventBus
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry
Review Comment:
You can refer to other scopemodelInitializers to manage some singleton
object initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2115108687 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2115091611 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2115038429 > please resolve conflicts Resolved ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
songxiaosheng commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2114853639 please resolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2110280513 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [240 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2110252644 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [240 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599973393 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: Well, it's actually just a matter of package naming. I committed the changes and restored the 'dubbo-metrics-api' package name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599989372 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: Well, it's actually just a matter of package naming. I committed the changes. Please confirm whether it is consistent with your suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599973393 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: Well, it's actually just a matter of package naming. I committed the changes and restored the 'dubbo-metrics-api' package name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
songxiaosheng commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599813560 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: We can move towards abstraction, so I suggest relying on APIs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599610701 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: Or should I keep the original 'dubbo-metrics-api' (even though it contains a lot of non-API classes) and name the new 'dubbo-metrics-api' something like 'dubbo-metrics-client'? Looking forward to your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599606336 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: I think the current primary goal is to strip the dubbo project of its dependence on metrics and only retain its dependence on the api, so only a very small amount of content necessary for the dubbo project will be retained in the api. In fact, I renamed the 'dubbo-metrics-api' package to 'dubbo-metrics-core' because it contains many classes that are not APIs, such as 'CombMetricsCollector'. Then a new 'dubbo-metrics-api' was added for dubbo projects to integrate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599606336 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: I think the current primary goal is to strip the dubbo project of its dependence on metrics and only retain its dependence on the api, so only a very small amount of content necessary for the dubbo project will be retained in the api. In fact, I renamed the 'dubbo-metrics-api' package to 'dubbo-metrics-core' because it contains many classes that are not APIs, such as 'CombMetricsCollector'. Then a new 'dubbo-metrics-api' was added for dubbo project integration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2107297072 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [150 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
songxiaosheng commented on code in PR #14106: URL: https://github.com/apache/dubbo/pull/14106#discussion_r1598265214 ## dubbo-metrics/dubbo-metrics-config-center/pom.xml: ## @@ -27,7 +27,7 @@ org.apache.dubbo - dubbo-metrics-api + dubbo-metrics-core Review Comment: Can we consider relying on the API layer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2105802344 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [150 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2105601225 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [150 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
AlbumenJ commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2105586570 > The check item 'dubbo-samples-test-13787' failed because the tests attribute in 'case-configuration.yml' was set incorrectly. Waitting for fix. Fixed in https://github.com/apache/dubbo-integration-cases/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2103959332 The check item 'dubbo-samples-test-13787' failed because the tests attribute in 'case-configuration.yml' was set incorrectly. Waitting for fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2102967060 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [150 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2068370012 @songxiaosheng PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
codecov-commenter commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2068060738 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/14106?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 38.16%. Comparing base [(`a12975a`)](https://app.codecov.io/gh/apache/dubbo/commit/a12975aa93d42a18d308422fddb23b3dc1e8fd9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`daf8165`)](https://app.codecov.io/gh/apache/dubbo/pull/14106?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 27 commits behind head on 3.3. Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.3 #14106 +/- ## == - Coverage 38.55% 38.16% -0.39% == Files1895 1915 +20 Lines 7927279546 +274 Branches1152811540 +12 == - Hits3056030357 -203 - Misses 4443944957 +518 + Partials 4273 4232 -41 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/14106?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2068059675 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [150 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
