[GitHub] [skywalking] codecov-io edited a comment on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
codecov-io edited a comment on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575956045 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@b12b211`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `17.67%`. [](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4264 +/- ## = Coverage ? 26.83% = Files ? 1162 Lines ?25387 Branches ? 3625 = Hits ? 6813 Misses?17965 Partials ? 609 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=tree) | Coverage Δ | | |---|---|---| | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | | | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <ø> (ø)` | | | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | | | [...ywalking/apm/agent/core/boot/AgentPackagePath.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VQYXRoLmphdmE=) | `41.37% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | | | [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...le/provider/handler/ProfileTaskServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL3Byb3ZpZGVyL2hhbmRsZXIvUHJvZmlsZVRhc2tTZXJ2aWNlSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | | | ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=footer). Last update
[GitHub] [skywalking] codecov-io edited a comment on issue #4268: merge e2e profile test project
codecov-io edited a comment on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575968756 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=h1) Report > Merging [#4268](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/90f3c4de557b427426dc33a86f3223be6a831794?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4268 +/- ## == - Coverage 26.92% 26.89% -0.04% == Files1162 1162 Lines 2540025400 Branches 3628 3628 == - Hits 6840 6832 -8 - Misses 1795617963 +7 - Partials 604 605 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `60.88% <0%> (-0.45%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=footer). Last update [90f3c4d...e9860e8](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix
geektcp opened a new pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix ___ ### Bug fix - Bug description. ``` Skywalking server disk is full(100%), Then clean OAP storage ES data and restart Skywalking ,the micro service and agent do not restart . endpointInventoryCache will be null before agent registered ``` - How to fix? check the null and do nothing at MultiScopesSpanListener.setPublicAttrs ___ ### log ``` 2020-01-19 14:24:15,830 - org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.RegisterServiceHandler - 150 [grpcServerPool-1-thread-10] INFO [] - register service instance id=23 [UUID:3524fb27678d48d28fb8217de4980f1a] 2020-01-19 14:24:16,258 - org.apache.skywalking.oap.server.core.cache.EndpointInventoryCache - 95 [grpcServerPool-1-thread-10] WARN [] - EndpointInventory id 14 is not in cache and persistent storage. 2020-01-19 14:24:16,259 - org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2 - 126 [grpcServerPool-1-thread-10] ERROR [] - null java.lang.NullPointerException: null at org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.setPublicAttrs(MultiScopesSpanListener.java:246) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.parseEntry(MultiScopesSpanListener.java:146) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.lambda$notifyEntryListener$1(SegmentParseV2.java:233) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_121] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.notifyEntryListener(SegmentParseV2.java:231) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.preBuild(SegmentParseV2.java:195) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.parse(SegmentParseV2.java:104) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2$Producer.send(SegmentParseV2.java:282) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:57) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:49) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onMessage(ServerCalls.java:248) [grpc-stub-1.15.1.jar:1.15.1] at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.messagesAvailable(ServerCallImpl.java:263) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1MessagesAvailable.runInContext(ServerImpl.java:683) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123) [grpc-core-1.15.1.jar:1.15.1] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_121] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_121] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] geektcp closed pull request #4270: bug fix
geektcp closed pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix
geektcp opened a new pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix ___ ### Bug fix - Bug description. ``` Skywalking server disk is full(100%), Then clean OAP storage ES data and restart Skywalking ,the micro service and agent do not restart . endpointInventoryCache will be null before agent registered ``` - How to fix? check the null and do nothing at MultiScopesSpanListener.setPublicAttrs ___ ### log ``` 2020-01-19 14:24:15,830 - org.apache.skywalking.oap.server.receiver.register.provider.handler.v6.grpc.RegisterServiceHandler - 150 [grpcServerPool-1-thread-10] INFO [] - register service instance id=23 [UUID:3524fb27678d48d28fb8217de4980f1a] 2020-01-19 14:24:16,258 - org.apache.skywalking.oap.server.core.cache.EndpointInventoryCache - 95 [grpcServerPool-1-thread-10] WARN [] - EndpointInventory id 14 is not in cache and persistent storage. 2020-01-19 14:24:16,259 - org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2 - 126 [grpcServerPool-1-thread-10] ERROR [] - null java.lang.NullPointerException: null at org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.setPublicAttrs(MultiScopesSpanListener.java:246) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.listener.endpoint.MultiScopesSpanListener.parseEntry(MultiScopesSpanListener.java:146) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.lambda$notifyEntryListener$1(SegmentParseV2.java:233) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_121] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.notifyEntryListener(SegmentParseV2.java:231) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.preBuild(SegmentParseV2.java:195) ~[skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2.parse(SegmentParseV2.java:104) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.parser.SegmentParseV2$Producer.send(SegmentParseV2.java:282) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:57) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at org.apache.skywalking.oap.server.receiver.trace.provider.handler.v6.grpc.TraceSegmentReportServiceHandler$1.onNext(TraceSegmentReportServiceHandler.java:49) [skywalking-trace-receiver-plugin-6.6.0.jar:6.6.0] at io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onMessage(ServerCalls.java:248) [grpc-stub-1.15.1.jar:1.15.1] at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.messagesAvailable(ServerCallImpl.java:263) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1MessagesAvailable.runInContext(ServerImpl.java:683) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) [grpc-core-1.15.1.jar:1.15.1] at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123) [grpc-core-1.15.1.jar:1.15.1] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_121] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_121] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) Report > Merging [#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/765162dbd0a205800d187914ffa0ca4f25069bb2?src=pr=desc) will **increase** coverage by `0.48%`. > The diff coverage is `17.96%`. [](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4247 +/- ## == + Coverage 26.43% 26.92% +0.48% == Files1179 1162 -17 Lines 2580325398 -405 Branches 3748 3627 -121 == + Hits 6822 6839 +17 + Misses 1837917955 -424 - Partials 602 604 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | :arrow_up: | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] mrproliu commented on issue #4268: merge e2e profile test project
mrproliu commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575972277 /run CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] mrproliu removed a comment on issue #4268: merge e2e profile test project
mrproliu removed a comment on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575972277 /run CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
wu-sheng closed issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] xasnow commented on issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
xasnow commented on issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269#issuecomment-575971084 environment： apache-skywalking-apm-bin-es7 elasticsearch-7.5.1 jdk 1.8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] xasnow opened a new issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
xasnow opened a new issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269 Please answer these questions before submitting your issue. - Why do you submit this issue? - [1 ] Question or discussion DEBUG 2020-01-19 13:59:08:395 main SkyWalkingAgent : On Transformation class com.snow.demo.web.Controllor. ERROR 2020-01-19 13:59:08:493 SkywalkingAgent-5-ServiceAndEndpointRegisterClient-0 ServiceAndEndpointRegisterClient : ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:222) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:203) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:132) at org.apache.skywalking.apm.network.register.v2.RegisterGrpc$RegisterBlockingStub.doServiceRegister(RegisterGrpc.java:386) at org.apache.skywalking.apm.agent.core.remote.ServiceAndEndpointRegisterClient.run(ServiceAndEndpointRegisterClient.java:143) at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:36) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.skywalking.apm.dependencies.io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information: /127.0.0.1:11800 at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) at org.apache.skywalking.apm.dependencies.io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:325) at org.apache.skywalking.apm.dependencies.io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:340) at org.apache.skywalking.apm.dependencies.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:634) at org.apache.skywalking.apm.dependencies.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:581) at org.apache.skywalking.apm.dependencies.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:498) at org.apache.skywalking.apm.dependencies.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:460) at org.apache.skywalking.apm.dependencies.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) at org.apache.skywalking.apm.dependencies.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more Caused by: java.net.ConnectException: Connection refused: no further information ... 11 more DEBUG 2020-01-19 13:59:08:776 main AbstractClassEnhancePluginDefine : prepare to enhance class org.springframework.boot.autoconfigure.web.servlet.error.BasicErrorController by org.apache.skywalking.apm.plugin.spring.mvc.v3.define.ControllerInstrumentation. WARN 2020-01-19 13:59:08:776 main AbstractClassEnhancePluginDefine : enhance class org.springframework.boot.autoconfigure.web.servlet.error.BasicErrorController by plugin org.apache.skywalking.apm.plugin.spring.mvc.v3.define.ControllerInstrumentation is not working. Because witness class org.springframework.web.servlet.view.xslt.AbstractXsltView is not existed. DEBUG 2020-01-19 13:59:08:776 main AbstractClassEnhancePluginDefine : prepare to enhance class org.springframework.boot.autoconfigure.web.servlet.error.BasicErrorController by org.apache.skywalking.apm.plugin.spring.mvc.v4.define.ControllerInstrumentation. WARN 2020-01-19 13:59:08:777 main AbstractClassEnhancePluginDefine : enhance class org.springframework.boot.autoconfigure.web.servlet.error.BasicErrorController by plugin org.apache.skywalking.apm.plugin.spring.mvc.v4.define.ControllerInstrumentation is not working. Because witness class org.springframework.cache.interceptor.DefaultKeyGenerator is not existed. DEBUG 2020-01-19 13:59:08:777 main
[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575970485 The PR could be accepted when you make all CI passed. Please fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575970444 > Actually, I think that #moveTo when doing #in is redundant I think you have removed it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem
in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#discussion_r368268133
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##
@@ -290,28 +278,28 @@ private boolean isMatch() {
switch (valueType) {
case LONG:
-long lvalue = ((LongValueHolder)metrics).getValue();
+long lvalue = ((LongValueHolder) metrics).getValue();
long lexpected =
RunningRule.this.threshold.getLongThreshold();
if (op.test(lexpected, lvalue)) {
matchCount++;
}
break;
case INT:
-int ivalue = ((IntValueHolder)metrics).getValue();
+int ivalue = ((IntValueHolder) metrics).getValue();
int iexpected =
RunningRule.this.threshold.getIntThreshold();
if (op.test(iexpected, ivalue)) {
matchCount++;
}
break;
case DOUBLE:
-double dvalue =
((DoubleValueHolder)metrics).getValue();
+double dvalue = ((DoubleValueHolder)
metrics).getValue();
double dexpected =
RunningRule.this.threshold.getDoubleThreshold();
if (op.test(dexpected, dvalue)) {
matchCount++;
}
break;
case MULTI_INTS:
-int[] ivalueArray =
((MultiIntValuesHolder)metrics).getValues();
+int[] ivalueArray = ((MultiIntValuesHolder)
metrics).getValues();
Review comment:
But we are not using it .SkyWalking has its own format, please revert those.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem
in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267810
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##
@@ -86,7 +83,7 @@ public RunningRule(AlarmRule alarmRule) {
* Receive metrics result from persistence, after it is saved into
storage. In alarm, only minute dimensionality
* metrics are expected to process.
*
- * @param meta of input metrics
+ * @param metaof input metrics
Review comment:
Why change this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575969960 > Any update? Actually, I think that `#moveTo` when doing `#in` is redundant, which can be covered by `#add` operation, and `#moveTo` in `#add` is an essential mechanism to make `public void add()` more safe at `window`'s initial stage, another PR will be created today :). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem
in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267823
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##
@@ -290,28 +278,28 @@ private boolean isMatch() {
switch (valueType) {
case LONG:
-long lvalue = ((LongValueHolder)metrics).getValue();
+long lvalue = ((LongValueHolder) metrics).getValue();
long lexpected =
RunningRule.this.threshold.getLongThreshold();
if (op.test(lexpected, lvalue)) {
matchCount++;
}
break;
case INT:
-int ivalue = ((IntValueHolder)metrics).getValue();
+int ivalue = ((IntValueHolder) metrics).getValue();
int iexpected =
RunningRule.this.threshold.getIntThreshold();
if (op.test(iexpected, ivalue)) {
matchCount++;
}
break;
case DOUBLE:
-double dvalue =
((DoubleValueHolder)metrics).getValue();
+double dvalue = ((DoubleValueHolder)
metrics).getValue();
double dexpected =
RunningRule.this.threshold.getDoubleThreshold();
if (op.test(dexpected, dvalue)) {
matchCount++;
}
break;
case MULTI_INTS:
-int[] ivalueArray =
((MultiIntValuesHolder)metrics).getValues();
+int[] ivalueArray = ((MultiIntValuesHolder)
metrics).getValues();
Review comment:
What change the format of all these cases?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem
in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267794
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##
@@ -187,7 +182,7 @@ public void moveTo(LocalDateTime targetTime) {
private int silenceCountdown;
private LinkedList values;
-private ReentrantLock lock = new ReentrantLock();
+private ReentrantLock reentrantLock = new ReentrantLock();
Review comment:
Why change this name?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] xasnow commented on issue #1689: got a problem
xasnow commented on issue #1689: got a problem URL: https://github.com/apache/skywalking/issues/1689#issuecomment-575969746 Hello, has this problem been solved？ I also had this problem when running on windows This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4268: merge e2e profile test project
codecov-io commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575968756 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=h1) Report > Merging [#4268](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/90f3c4de557b427426dc33a86f3223be6a831794?src=pr=desc) will **decrease** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4268 +/- ## = - Coverage 26.92% 26.83% -0.1% = Files1162 1162 Lines 2540025400 Branches 3628 3628 = - Hits 6840 6817 -23 - Misses 1795617978 +22 - Partials 604 605 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=tree) | Coverage Δ | | |---|---|---| | [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: | | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60.65% <0%> (-16.4%)` | :arrow_down: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: | | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4268/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `60.88% <0%> (-0.45%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=footer). Last update [90f3c4d...47c9211](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265731
##
File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml
##
@@ -46,5 +46,254 @@
+
+e2e-profile-service
+1.1
+
skywalking-e2e-container-${build.id}-profile
+
+
+
+
+
+mysql
+
+
+
+io.fabric8
+docker-maven-plugin
+
+
%a-%t-%i
+
+
+
mysql/mysql-server:${mysql.version}
+
${e2e.container.name.prefix}-datasource
+
+
+Socket:
'/var/run/mysqld/mysqlx.sock' bind-address: '::' port: 3306
+12
+
+
+
root@1234
+
swtest
+
%
+
+
+mysql.port:3306
+
+
+
+
+
skyapm/e2e-container:${e2e.container.version}
+
${e2e.container.name.prefix}-runner
+
+
+mysql
+
jdbc:mysql://${e2e.container.name.prefix}-datasource:3306/swtest
+
+
${provider.name}-${project.version}.jar
+
+
+
-DSW_AGENT_COLLECTOR_BACKEND_SERVICES=127.0.0.1:11800
+-DSW_AGENT_PROFILE_ACTIVE=true
+
-DSW_AGENT_NAME=${provider.name}
+-Dserver.port=9090
+
+
+
+
${e2e.container.name.prefix}-datasource
+
+
+
${e2e.container.name.prefix}-datasource
+
+
+
+webapp.host:webapp.port:8081
+
+service.host:service.port:9090
+
+
+
+${sw.home}:/sw
+
${project.build.directory}:/home
+
../${provider.name}/target/${provider.name}-${project.version}.jar:/home/${provider.name}-${project.version}.jar
+
${project.basedir}/src/docker/rc.d:/rc.d:ro
+
${project.basedir}/src/docker/clusterize.awk:/clusterize.awk
+
+
+
+SkyWalking e2e container is
ready for tests
+300
+
+
+
+
+
+
+
+
+
+
+
+
+h2
+
+
+
+io.fabric8
+docker-maven-plugin
+
+
%a-%t-%i
+Always
+
+
+
skyapm/e2e-container:${e2e.container.version}
+${e2e.container.name.prefix}
+
+
+h2
+
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265708
##
File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml
##
@@ -46,5 +46,254 @@
+
+e2e-profile-service
+1.1
+
skywalking-e2e-container-${build.id}-profile
+
+
+
+
Review comment:
```suggestion
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368266217
##
File path:
test/e2e/e2e-profile/e2e-profile-test-runner/src/docker/clusterize.awk
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#!/usr/bin/awk -f
+
+BEGIN {
Review comment:
The file name `clusterize.awk` should be changed (after copying),
`clusterize.awk` is originally used to modify the `application.yml` to make it
run in cluster mode (to test coordinators), here should be named with something
like `adapt_storage` or other storage related names, if you like
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265675 ## File path: .github/workflows/e2e.yaml ## @@ -111,10 +111,10 @@ jobs: ./mvnw -Dcheckstyle.skip -Drat.skip -T2 -Dmaven.compile.fork -Dmaven.compiler.maxmem=3072 -DskipTests clean install ./mvnw -f test/e2e/pom.xml -pl e2e-base clean install - name: Profile Tests H2(JDK8) -run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh e2e-profile/e2e-profile-h2-test-runner +run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh e2e-profile/e2e-profile-test-runner --env=h2 Review comment: change the name `env` to `storage` please, we may have other `env` in the future This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265760
##
File path: test/e2e/run.sh
##
@@ -70,6 +73,7 @@ do
-De2e.container.version="${E2E_VERSION}" \
-Delasticsearch.version="${ES_VERSION}" \
-Dsw.home="${base_dir}/$test_case/${DIST_PACKAGE//.tar.gz/}" \
+ `if [ ! -z "${env}" ] ; then echo -P"${env}"; fi` \
Review comment:
same here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265752
##
File path: test/e2e/run.sh
##
@@ -36,6 +36,9 @@ while [[ $# -gt 0 ]]; do
--profiles=*)
profiles=${1#*=}
;;
+--env=*)
Review comment:
`env` -> `storage` please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test
project
URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265716
##
File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml
##
@@ -46,5 +46,254 @@
+
+e2e-profile-service
+1.1
+
skywalking-e2e-container-${build.id}-profile
+
+
+
+
+
+mysql
+
+
+
+io.fabric8
+docker-maven-plugin
+
+
%a-%t-%i
+
+
+
mysql/mysql-server:${mysql.version}
+
${e2e.container.name.prefix}-datasource
+
+
+Socket:
'/var/run/mysqld/mysqlx.sock' bind-address: '::' port: 3306
+12
+
+
+
root@1234
+
swtest
+
%
+
+
+mysql.port:3306
+
+
+
+
+
skyapm/e2e-container:${e2e.container.version}
+
${e2e.container.name.prefix}-runner
+
+
+mysql
+
jdbc:mysql://${e2e.container.name.prefix}-datasource:3306/swtest
+
+
${provider.name}-${project.version}.jar
+
+
+
-DSW_AGENT_COLLECTOR_BACKEND_SERVICES=127.0.0.1:11800
+-DSW_AGENT_PROFILE_ACTIVE=true
+
-DSW_AGENT_NAME=${provider.name}
+-Dserver.port=9090
+
+
+
+
${e2e.container.name.prefix}-datasource
+
+
+
${e2e.container.name.prefix}-datasource
+
+
+
+webapp.host:webapp.port:8081
+
+service.host:service.port:9090
+
+
+
+${sw.home}:/sw
+
${project.build.directory}:/home
+
../${provider.name}/target/${provider.name}-${project.version}.jar:/home/${provider.name}-${project.version}.jar
+
${project.basedir}/src/docker/rc.d:/rc.d:ro
+
${project.basedir}/src/docker/clusterize.awk:/clusterize.awk
+
+
+
+SkyWalking e2e container is
ready for tests
+300
+
+
+
+
+
+
+
+
+
+
+
Review comment:
```suggestion
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4268: merge e2e profile test project
wu-sheng commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575967357 @dmsolr please compare this with your PR too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] mrproliu commented on issue #4268: merge e2e profile test project
mrproliu commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575966420 @kezhenxu94 This is a modification of the e2e test case, please help check it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] mrproliu opened a new pull request #4268: merge e2e profile test project
mrproliu opened a new pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268 …orage types Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve performance - Related issues #4104 ___ ### New feature or improvement - The current e2e test cases for profile use different storage to distinguish different projects. Now merge the test projects into one. Use `env` to distinguish different storage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4239: [WIP] Provide influxdb as a new storage plugin
codecov-io commented on issue #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@0133890`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `15.6%`. [](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=tree) ```diff @@ Coverage Diff@@ ## master #4239 +/- ## Coverage ? 26.1% Files ?1178 Lines ? 26101 Branches ?3724 Hits ?6814 Misses? 18682 Partials ? 605 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | | | [...king/oap/server/library/module/ModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZVByb3ZpZGVyLmphdmE=) | `50% <ø> (ø)` | | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/4239/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? =
[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575964891 CI fails, please recheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng opened a new issue #4267: Add document about time condition in GraphQL
wu-sheng opened a new issue #4267: Add document about time condition in GraphQL URL: https://github.com/apache/skywalking/issues/4267 Based on #4266, we should add this kind of documents in here, https://github.com/apache/skywalking/blob/master/docs/en/protocols/query-protocol.md, as a section before Metadata. Anyone wants to contribute this, PR is welcome. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4267: Add document about time condition in GraphQL
wu-sheng commented on issue #4267: Add document about time condition in GraphQL URL: https://github.com/apache/skywalking/issues/4267#issuecomment-575964864 FYI @longdevops332, after codes read, you want to help about this, please send a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4266: Rocketbot time range and interface condition correspondence
wu-sheng commented on issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266#issuecomment-575964741 Read MetricQuery#getValues. There are time format converts about start and end time. You will have the clue about this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4266: Rocketbot time range and interface condition correspondence
wu-sheng closed issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] longdevops332 opened a new issue #4266: Rocketbot time range and interface condition correspondence
longdevops332 opened a new issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266 Everyone, please consult. At present, I need to get the statistics in skywalking to make a report. In the rocketbot tracking module Time range: 2020-01-17 01:00:00 ~ 2020-01-17 02:00:00, How to access the interface in browser debugging under the conditions of "start": "2020-01-17 0600", "end": "2020-01-17 0700", "step": "MINUTE" Everybody, do you know? Please guide me，Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题
wu-sheng closed issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题
wu-sheng commented on issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265#issuecomment-575964031 English only. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] longdevops332 opened a new issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题
longdevops332 opened a new issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265 各位大佬，请教一下，目前需要获取Skywalking中的统计信息制作报表。 Rocketbot追踪模块中 时间范围:2020-01-17 01:00:00 ~ 2020-01-17 02:00:00选择的是这样的， 怎么浏览器调试中接口访问，条件是"start":"2020-01-17 0600","end":"2020-01-17 0700","step":"MINUTE" 各位大佬，有知道的吗？烦请指导指导 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin
dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r368263056
##
File path:
oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/base/InfluxStorageDAO.java
##
@@ -53,6 +53,6 @@ public IRecordDAO newRecordDao(StorageBuilder
storageBuilder) {
@Override
public INoneStreamDAO newNoneStreamDao(StorageBuilder
storageBuilder) {
-return new NoneStreamDAO();
+return new NoneStreamDAO(influxClient, storageBuilder);
Review comment:
That sounds the relationship database better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575960326 > Yeah, this PR doesn't contain any new feature(for skywalking), just a refactor with the new feature of JDK8+. (BTW, I have never said this PR contains any new feature. : P I am not saying about the purpose of this PR. I am still talking about the `Blank` thing. I still think we don't need that. This util is also used in the backend, check the package, it doesn't belong to the agent. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575959311 > Agree, users modify only the OAL files they need. I mean, using two separate OAL files. If the receiver is being active, the provider could make OAL engineer load another OAL file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575959138 ## 1: > the Blank cost more resources, what is the benefit? In many cases, the mothod `org.apache.skywalking.apm.util.StringUtil#isBlank` won't cost more resources. If first character of the string isn't white space, this method returns `false` immediately. Also, we need to check if the method `java.lang.Character#isWhitespace(int)` inside JDK takes time. ## 2: > allowing these two existing will make the further reviews(of other PRs) confusing. It is hard to tell from all reviewers perspective, which one should be used in which cases. Maybe I should add java documents on two methods. ## 3: > If there isn't a case, required this, which I think there isn't as this PR didn't add a new feature, but refactor, I hope we don't add these new APIs. Yeah, this PR doesn't contain any `new feature(for skywalking)`, just a refactor with the `new feature of JDK8+`. (BTW, I have never said this PR contains any new feature. : P This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4228: Support Browser protocol at OAP
arugal commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575958653 > If those are in another OAL file, then OAL engine could provide an API to activate some OAL files, such as from browser-receiver provider. Agree, users modify only the OAL files they need. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@5ca626e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `16.56%`. [](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4177 +/- ## = Coverage ? 26.83% = Files ? 1162 Lines ?25457 Branches ? 3632 = Hits ? 6832 Misses?18020 Partials ? 605 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | | | ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/4177/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [skywalking] wu-sheng commented on issue #4259: i want to know the meaning of the filed "mapping_service_id"
wu-sheng commented on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956118 I will do that for sure, if I could make it passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] coki230 edited a comment on issue #4259: i want to know the meaning of the filed "mapping_service_id"
coki230 edited a comment on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956060 @wu-sheng thanks, if you publish a paper. please send the message to the home page. i will focus it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
codecov-io commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575956045 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@b12b211`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `17.53%`. [](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4264 +/- ## = Coverage ? 26.85% = Files ? 1162 Lines ?25394 Branches ? 3629 = Hits ? 6820 Misses?17966 Partials ? 608 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=tree) | Coverage Δ | | |---|---|---| | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | | | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | | | [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...gent/core/profile/ProfileTaskExecutionContext.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0V4ZWN1dGlvbkNvbnRleHQuamF2YQ==) | `0% <0%> (ø)` | | | [...le/provider/handler/ProfileTaskServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL3Byb3ZpZGVyL2hhbmRsZXIvUHJvZmlsZVRhc2tTZXJ2aWNlSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | | | [...walking/apm/agent/core/profile/ThreadProfiler.java](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UaHJlYWRQcm9maWxlci5qYXZh) | `0% <0%> (ø)` | | | ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/4264/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [skywalking] coki230 commented on issue #4259: i want to know the meaning of the filed "mapping_service_id"
coki230 commented on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956060 thanks, if you publish a paper. please send the message to the home page. i will focus it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575953773 > Empty means that the string contains nothing or is null, while Blank is not only Empty string, but also contains only whitespace character(s). I think @kezhenxu94 's point is why, I have the same concern too. Why do we need to separate these two? First, the `Blank` cost more resources, what is the benefit? Then, allowing these two existing will make the further reviews(of other PRs) confusing. It is hard to tell from all reviewers perspective, which one should be used in which cases. If there isn't a case, required this, which I think there isn't as this PR didn't add a new feature, but refactor, I hope we don't add these new APIs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking-website] branch c200 updated: Update blog text.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch c200 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/c200 by this push: new 718c818 Update blog text. 718c818 is described below commit 718c818886a82efa0166e7d424725a76673a104e Author: Wu Sheng AuthorDate: Sun Jan 19 08:50:47 2020 +0800 Update blog text. --- .../blog/2020-01-20-celebrate-200th-contributor.md | 47 -- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/docs/blog/2020-01-20-celebrate-200th-contributor.md b/docs/blog/2020-01-20-celebrate-200th-contributor.md index 587221c..4f550fa 100644 --- a/docs/blog/2020-01-20-celebrate-200th-contributor.md +++ b/docs/blog/2020-01-20-celebrate-200th-contributor.md @@ -5,32 +5,37 @@  -SkyWalking project provides distributed tracing, topology map analysis, service mesh telemetry analysis, metrics analysis and super cool visualization -targeting distributed system in k8s or traditional VM deployment. +The SkyWalking project provides distributed tracing, topology map analysis, service mesh telemetry analysis, metrics analysis and a super cool visualization +targeting distributed systems in k8s or traditional VM deployments. -The project is widely used in Alibaba, Huawei, Tencent, DiDi, xiaomi, Pingan, China top 3 telecom companies(China Mobile, China telecom, China Unicom), Airlines, Banks and more. Have over 140 company users listing on our [powered by](https://github.com/apache/skywalking/blob/master/docs/powered-by.md) page. +The project is widely used in Alibaba, Huawei, Tencent, DiDi, xiaomi, Pingan, China’s top 3 telecom companies (China Mobile, China telecom, China Unicom), airlines, banks and more. It has over 140 company users listed on our [powered by](https://github.com/apache/skywalking/blob/master/docs/powered-by.md) page. -Today, we welcome and celebrate for over 200 code contributors of our single main repo. We have passed 200 contributors and 200 code contributors long time ago, even can't set an accurate date. But this time, we could have the exact date. **Jan. 20th 2020**. +Today, we welcome and celebrate reaching 200 code contributors on our main repo. We hereby mark this milestone as official today, : **Jan. 20th 2020**. -At this great moment, I would like to share SKyWalking 4 years open source journey. +At this great moment, I would like to share SkyWalking’s 4-year open source journey. -I wrote the first line at Nov 1st, 2015, for guiding people to understand distributed system, as at that time, micro-service and distributed architecture became popular. -In the first 2 years, I never thought it would become a such big and active community, even I didn't think it would be a really open source project. -The target used to be teaching about distributed tracing and analysis only. -With in 2015-2017 to be a normal and obscurity open source project, -people still showed up, asked questions, tried to improve the project, I got several invitations to share the project at local meetups. -All these made me realized people really need a good open source APM project. It was still a blank. +I wrote the first line on Nov. 1st, 2015, guiding people to understand a distributed system just as micro-services and distributed architecture were becoming popular. +In the first 2 years, I never thought it would become such a big and active community. I didn’t even expect it would be an open source project. +Initially, the goal was primarily to teach others about distributed tracing and analysis. -At 2017, I decided to dedicate as much as possible to make the project successful, even made this as my day job. But to be honest, I had no clue about how to do that, because at 2017's China, there was rare to have this kind of job. -So, I began to ask friends around me, `Do you want to collaborate the open source APM with me?`. Clearly, most are **NO**, as people are busy, but 2 of them accepted to help, Xin Zhang and Yongsheng Peng. That was the time we built the SkyWalking 3.x. We shared the 3.2 release at GOPS Shanghai, China. It became the first adoption version using in the production environment. -Comparing to today's SkyWalking, it just liked a prototype and toy, but it had the same tracing design, protocol and analysis method. +It was a typical open source project in obscurity in its first two years. But +people still showed up, asked questions, and tried to improve the project. I got several invitations to share the project at local meetups.All these made me realize people really needed a good open source APM project. -In the whole year of 2017, the contributor team of the project has 15-20, but we only have limited time on the project. Then I began to consider bringing the project
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin
wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as
a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r368257153
##
File path:
oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/base/InfluxStorageDAO.java
##
@@ -53,6 +53,6 @@ public IRecordDAO newRecordDao(StorageBuilder
storageBuilder) {
@Override
public INoneStreamDAO newNoneStreamDao(StorageBuilder
storageBuilder) {
-return new NoneStreamDAO();
+return new NoneStreamDAO(influxClient, storageBuilder);
Review comment:
`INoneStreamDAO` is used for web interactive job, such as @mrproliu 's
profiling task. Basically, this should have little data. Is the influxDB
suitable for this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] ElderJames commented on issue #4257: Receiver implementation in Http protocol
ElderJames commented on issue #4257: Receiver implementation in Http protocol URL: https://github.com/apache/skywalking/issues/4257#issuecomment-575948504 I know that grpc must use http2 but grpc-web use http1.We maybe can support gpc-web. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)
codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) Report > Merging [#4247](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/765162dbd0a205800d187914ffa0ca4f25069bb2?src=pr=desc) will **increase** coverage by `0.48%`. > The diff coverage is `17.96%`. [](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4247 +/- ## == + Coverage 26.43% 26.92% +0.48% == Files1179 1162 -17 Lines 2580325398 -405 Branches 3748 3627 -121 == + Hits 6822 6839 +17 + Misses 1837917955 -424 - Partials 602 604 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | :arrow_up: | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/4247/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30: Support query browser error log
wu-sheng commented on issue #30: Support query browser error log URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-575906990 Let's hold this PR until @Fine0830 is back from the vacation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230959 ## File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal ## @@ -102,3 +102,77 @@ envoy_parent_connections_used = from(EnvoyInstanceMetric.value).filter(metricNam // disable(top_n_database_statement); // disable(zipkin_span); // disable(jaeger_span); + + +// Browser metrics begin Review comment: @kezhenxu94 I want to discuss a thing with you. In @arugal prev PR, this part of OAL is separated in another OAL, I asked him to change like this. But in these days, I prefer his way more. If those are in another OAL file, then OAL engine could provide an API to activate some OAL files, such as from browser-receiver provider. This should make our document easier. What do you think? @arugal This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230585 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java ## @@ -71,16 +71,28 @@ public static final int PROFILE_TASK_LOG = 27; public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28; +// browser +public static final int BROWSER_PERF_DATA = 40; +public static final int SERVICE_PERF_DETAIL = 41; +public static final int SERVICE_PAGE_PATH_PERF_DETAIL = 42; +public static final int SERVICE_VERSION_PERF_DETAIL = 43; +public static final int SERVICE_VERSION_PAGE_PATH_PERF_DETAIL = 44; + /** * Catalog of scope, the metrics processor could use this to group all generated metrics by oal rt. */ public static final String SERVICE_CATALOG_NAME = "SERVICE"; public static final String SERVICE_INSTANCE_CATALOG_NAME = "SERVICE_INSTANCE"; public static final String ENDPOINT_CATALOG_NAME = "ENDPOINT"; +public static final String SERVICE_PAGE_PATH_CATALOG_NAME = "SERVICE_PAGE_PATH"; +public static final String SERVICE_VERSION_PAGE_PATH_CATALOG_NAME = "SERVICE_VERSION_PAGE_PATH"; + private static final Map SERVICE_CATALOG = new HashMap<>(); private static final Map SERVICE_INSTANCE_CATALOG = new HashMap<>(); private static final Map ENDPOINT_CATALOG = new HashMap<>(); +private static final Map SERVICE_PAGE_PATH_CATALOG = new HashMap<>(); +private static final Map SERVICE_VERSION_PAGE_PATH_CATALOG = new HashMap<>(); Review comment: Same rename suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230350 ## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ## @@ -44,6 +44,12 @@ SRC_SERVICE_INSTANCE_CLR_GC: 'ServiceInstanceCLRGC'; SRC_SERVICE_INSTANCE_CLR_THREAD: 'ServiceInstanceCLRThread'; SRC_ENVOY_INSTANCE_METRIC: 'EnvoyInstanceMetric'; +// Browser keywords +SRC_BROWSER_SERVICE_PERF_DETAIL: 'ServicePerfDetail'; +SRC_BROWSER_SERVICE_PAGE_PATH_PERF_DETAIL: 'ServicePagePathPerfDetail'; +SRC_BROWSER_SERVICE_VERSION_PERF_DETAIL: 'ServiceVersionPerfDetail'; +SRC_BROWSER_SERVICE_VERSION_PAGE_PATH_PERF_DETAIL: 'ServiceVersionPagePathPerfDetail'; Review comment: All these should be named `Browser*`. `ServiceVersion` should be `BrowserSingleVersion*`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230313 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -85,7 +85,7 @@ Webhook requires the peer is a web container. The alarm message will send throug - **scopeId**, **scope**. All scopes are defined in org.apache.skywalking.oap.server.core.source.DefaultScopeDefine. - **name**. Target scope entity name. - **id0**. The ID of scope entity, matched the name. -- **id1**. Not used today. +- **id1**. The ID1 of scope entity. Review comment: Do we use this today? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230582 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java ## @@ -71,16 +71,28 @@ public static final int PROFILE_TASK_LOG = 27; public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28; +// browser +public static final int BROWSER_PERF_DATA = 40; +public static final int SERVICE_PERF_DETAIL = 41; +public static final int SERVICE_PAGE_PATH_PERF_DETAIL = 42; +public static final int SERVICE_VERSION_PERF_DETAIL = 43; +public static final int SERVICE_VERSION_PAGE_PATH_PERF_DETAIL = 44; + /** * Catalog of scope, the metrics processor could use this to group all generated metrics by oal rt. */ public static final String SERVICE_CATALOG_NAME = "SERVICE"; public static final String SERVICE_INSTANCE_CATALOG_NAME = "SERVICE_INSTANCE"; public static final String ENDPOINT_CATALOG_NAME = "ENDPOINT"; +public static final String SERVICE_PAGE_PATH_CATALOG_NAME = "SERVICE_PAGE_PATH"; +public static final String SERVICE_VERSION_PAGE_PATH_CATALOG_NAME = "SERVICE_VERSION_PAGE_PATH"; Review comment: Same rename suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230521
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/NotifyHandler.java
##
@@ -82,6 +84,38 @@ public NotifyHandler(AlarmRulesWatcher alarmRulesWatcher) {
endpointMetaInAlarm.setName(textName);
metaInAlarm = endpointMetaInAlarm;
+} else if (DefaultScopeDefine.inServicePageCatalog(scope)) {
+String metricsId = meta.getId();
+String[] ids = metricsId.split(Const.ID_SPLIT);
+int serviceId = Integer.parseInt(ids[0]);
+int pagePathId = Integer.parseInt(ids[1]);
Review comment:
ID1 should not be used in this way. If this is page related alert, then
id0=pageId, which is unique, so don't worry about it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230444 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -85,7 +85,7 @@ Webhook requires the peer is a web container. The alarm message will send throug - **scopeId**, **scope**. All scopes are defined in org.apache.skywalking.oap.server.core.source.DefaultScopeDefine. - **name**. Target scope entity name. - **id0**. The ID of scope entity, matched the name. -- **id1**. Not used today. +- **id1**. The ID1 of scope entity. Review comment: `ID1` is designed for relationship alert. I think it is not related to this PR, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230459
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmMessageFormatter.java
##
@@ -55,6 +55,9 @@ public AlarmMessageFormatter(String format) {
case "id":
valueFroms.add(ValueFrom.ID);
break;
+case "id1":
+valueFroms.add(ValueFrom.ID1);
Review comment:
Same question about `id1`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230557 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java ## @@ -71,16 +71,28 @@ public static final int PROFILE_TASK_LOG = 27; public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28; +// browser +public static final int BROWSER_PERF_DATA = 40; +public static final int SERVICE_PERF_DETAIL = 41; +public static final int SERVICE_PAGE_PATH_PERF_DETAIL = 42; +public static final int SERVICE_VERSION_PERF_DETAIL = 43; +public static final int SERVICE_VERSION_PAGE_PATH_PERF_DETAIL = 44; Review comment: `SERVICE_` should be renamed to `BROWSER_` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/eb1eb97339ddc4ac86349ea5bf9537fc1ca3e9d2?src=pr=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `17.28%`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4228 +/- ## == - Coverage 26.52% 26.27% -0.25% == Files1184 1189 +5 Lines 2562225945 +323 Branches 3630 3687 +57 == + Hits 6795 6816 +21 - Misses 1822818524 +296 - Partials 599 605 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | | |---|---|---| | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | :arrow_up: | | [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <0%> (ø)` | | | [...gent/core/profile/ProfileTaskExecutionContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0V4ZWN1dGlvbkNvbnRleHQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...le/provider/handler/ProfileTaskServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL3Byb3ZpZGVyL2hhbmRsZXIvUHJvZmlsZVRhc2tTZXJ2aWNlSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...alking/oap/server/core/command/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29tbWFuZC9Db21tYW5kU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...walking/apm/agent/core/profile/ThreadProfiler.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UaHJlYWRQcm9maWxlci5qYXZh) | `0% <0%> (ø)` | | | ... and [25 more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`,
[skywalking] branch master updated: Sniffer processing profile task and report status and snapshot (#4220)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 90f3c4d Sniffer processing profile task and report status and snapshot (#4220) 90f3c4d is described below commit 90f3c4de557b427426dc33a86f3223be6a831794 Author: mrproliu <741550...@qq.com> AuthorDate: Sat Jan 18 18:38:03 2020 +0800 Sniffer processing profile task and report status and snapshot (#4220) * sniffer processing profile task and report status and snapshot * resolve testServiceDependencies test case error, use same register with `TraceSegmentServiceClient` * resolve names * change profile to single one thread run. * 1. change to the ArrayList, because known the max size 2. rename issue resolved * add profiling status enum * change sniffer use full name issue * 1. remove `prepareProfiling` method, build profiling status when construct `TracingContext` 2. add `TracingThreadListenerManager`, notify when tracing main thread finish 3. change ProfileThread start when process new profile task * remove unnecessary getter * add test assert error message * adding `AgentServiceRule` * revert original assert * remove unnecessary getter * resolve issues * reduce findService invoke * resolve style error * recheck profiling when change first span operatin name * resolve issues 1. remove `ContextManager#profilingRecheck`, only check on `TracingContext` 2. rename comments 3. resolve volatile array setting * remove article link * add `ProfileTask#maxSamplingCount` check * resolve conflict (Downstream -> Commands) * 1. change profilingSegmentSlots init on construct 2. if is profiling, recheck dont need to stop 3. total profiling count increment on first dump * remove unused return val * remove some `@param` and `@return` * add profile task check result data bean * change profiler slot to `AtomicReferenceArray` * resolved java doc error * fix doc error, remove meaningless descriptions * resolve missed profile receiver on oap starter * resolve method invoke error Co-authored-by: 吴晟 Wu Sheng Co-authored-by: kezhenxu94 --- .../component/command/ProfileTaskCommand.java | 18 +- .../executor/ProfileTaskCommandExecutor.java | 3 +- .../skywalking/apm/agent/core/conf/Config.java | 20 ++ .../agent/core/context/AbstractTracerContext.java | 1 + .../core/context/ContextManagerExtendService.java | 2 +- .../apm/agent/core/context/TracingContext.java | 100 - .../agent/core/context/TracingThreadListener.java | 24 +- .../core/context/trace/AbstractTracingSpan.java| 19 +- .../apm/agent/core/context/trace/EntrySpan.java| 9 +- .../apm/agent/core/context/trace/ExitSpan.java | 17 +- .../apm/agent/core/context/trace/LocalSpan.java| 10 +- .../core/context/trace/StackBasedTracingSpan.java | 25 ++- .../apm/agent/core/profile/ProfileTask.java| 28 ++- .../core/profile/ProfileTaskChannelService.java| 243 + .../core/profile/ProfileTaskExecutionContext.java | 119 +- .../core/profile/ProfileTaskExecutionService.java | 124 --- .../core/profile/ProfileTaskQueryService.java | 129 --- .../apm/agent/core/profile/ProfileThread.java | 115 ++ .../apm/agent/core/profile/ProfilingStatus.java| 24 +- .../apm/agent/core/profile/ThreadProfiler.java | 153 + .../agent/core/profile/TracingThreadSnapshot.java | 73 +++ ...ache.skywalking.apm.agent.core.boot.BootService | 2 +- .../apm/agent/core/boot/ServiceManagerTest.java| 18 +- .../apm/agent/core/context/TracingContextTest.java | 2 +- .../agent/core/test/tools/AgentServiceRule.java| 3 + apm-sniffer/config/agent.config| 12 + docs/en/setup/service-agent/java-agent/README.md | 4 + .../src/main/resources/application.yml | 3 + .../oap/server/core/cache/ProfileTaskCache.java| 45 +++- .../oap/server/core/command/CommandService.java| 2 +- .../profile/ProfileTaskSegmentSnapshotRecord.java | 101 + .../oap/server/core/source/DefaultScopeDefine.java | 1 + .../core/storage/profile/IProfileTaskQueryDAO.java | 7 + .../handler/ProfileTaskServiceHandler.java | 77 ++- .../elasticsearch/query/ProfileTaskQueryEsDAO.java | 19 ++ .../plugin/jdbc/h2/dao/H2ProfileTaskQueryDAO.java | 24 ++ .../skywalking/e2e/ProfileVerificationITCase.java | 40 +++- .../skywalking/e2e/ProfileVerificationITCase.java | 40 +++- .../skywalking/e2e/ProfileVerificationITCase.java | 40
[GitHub] [skywalking] kezhenxu94 merged pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 merged pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot
codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging [#4220](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5279c53b8eb6770c2e9b557f2257370fb3e37267?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4220 +/- ## == + Coverage26.9% 26.92% +0.01% == Files1162 1162 Lines 2541225400 -12 Branches 3633 3628 -5 == + Hits 6838 6839 +1 + Misses 1796817956 -12 + Partials 606 605 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `36.78% <ø> (ø)` | :arrow_up: | | [...apache/skywalking/apm/network/ProtocolVersion.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL1Byb3RvY29sVmVyc2lvbi5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...trace/provider/parser/decorator/SpanDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TcGFuRGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../standardization/SegmentStandardizationWorker.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TZWdtZW50U3RhbmRhcmRpemF0aW9uV29ya2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ywalking/apm/agent/core/profile/ProfileThread.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
[GitHub] [skywalking] JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+
JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575884819 > > we may have to differentiate the meaning between Empty and Blank > > What is the difference? And what is your case? `Empty` means that the string contains nothing or is null, while `Blank` is not only `Empty` string, but also contains only `whitespace character(s)`. test case: 1. Empty: `null or ""` only; 2. Blank: `null, "", " ", or any length of whitespace character` (Of course, the `\t`, `\n` , `\r` and `\f` are treated as whitespace character). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-query-protocol] arugal opened a new pull request #30: Support query browser error log
arugal opened a new pull request #30: Support query browser error log URL: https://github.com/apache/skywalking-query-protocol/pull/30 ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@63e1881`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `10.68%`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4228 +/- ## = Coverage ? 26.52% = Files ? 1184 Lines ?25622 Branches ? 3630 = Hits ? 6795 Misses?18228 Partials ? 599 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0% <ø> (ø)` | | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...trace/provider/parser/decorator/SpanDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TcGFuRGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | | | [.../standardization/SegmentStandardizationWorker.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TZWdtZW50U3RhbmRhcmRpemF0aW9uV29ya2VyLmphdmE=) | `0% <0%> (ø)` | | | [...ce/provider/parser/decorator/SegmentDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TZWdtZW50RGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | | | [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `59.25% <0%> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | | | ... and [10
[GitHub] [skywalking] codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot
codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging [#4220](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5279c53b8eb6770c2e9b557f2257370fb3e37267?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `9.28%`. [](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4220 +/- ## == - Coverage26.9% 26.89% -0.02% == Files1162 1162 Lines 2541225400 -12 Branches 3633 3628 -5 == - Hits 6838 6832 -6 + Misses 1796817963 -5 + Partials 606 605 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../apm/agent/core/profile/TracingThreadSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9UcmFjaW5nVGhyZWFkU25hcHNob3QuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <ø> (-8.05%)` | :arrow_down: | | [...apache/skywalking/apm/network/ProtocolVersion.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL1Byb3RvY29sVmVyc2lvbi5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...trace/provider/parser/decorator/SpanDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TcGFuRGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [.../standardization/SegmentStandardizationWorker.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TZWdtZW50U3RhbmRhcmRpemF0aW9uV29ya2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...ywalking/apm/agent/core/profile/ProfileThread.java](https://codecov.io/gh/apache/skywalking/pull/4220/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` |
[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@63e1881`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `10.68%`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4228 +/- ## = Coverage ? 26.52% = Files ? 1184 Lines ?25622 Branches ? 3630 = Hits ? 6795 Misses?18228 Partials ? 599 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0% <ø> (ø)` | | | [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | | | [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | | | [...trace/provider/parser/decorator/SpanDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TcGFuRGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | | | [.../standardization/SegmentStandardizationWorker.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL3N0YW5kYXJkaXphdGlvbi9TZWdtZW50U3RhbmRhcmRpemF0aW9uV29ya2VyLmphdmE=) | `0% <0%> (ø)` | | | [...ce/provider/parser/decorator/SegmentDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2RlY29yYXRvci9TZWdtZW50RGVjb3JhdG9yLmphdmE=) | `0% <0%> (ø)` | | | [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `59.25% <0%> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | | | ... and [10
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368215552
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.profile;
+
+import com.google.common.base.Objects;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.TracingContext;
+import org.apache.skywalking.apm.agent.core.context.ids.ID;
+
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author MrPro
+ */
+public class ThreadProfiler {
+
+// current tracing context
+private final TracingContext tracingContext;
+// current tracing segment id
+private final ID traceSegmentId;
+// need to profiling thread
+private final Thread profilingThread;
+// profiling execution context
+private final ProfileTaskExecutionContext executionContext;
+
+// profiling time
+private long profilingStartTime;
+private long profilingMaxTimeMills;
+
+// after min duration threshold check, it will start dump
+private ProfilingStatus profilingStatus = ProfilingStatus.READY;
+// thread dump sequence
+private int dumpSequence = 0;
+
+public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId,
Thread profilingThread, ProfileTaskExecutionContext executionContext) {
+this.tracingContext = tracingContext;
+this.traceSegmentId = traceSegmentId;
+this.profilingThread = profilingThread;
+this.executionContext = executionContext;
+this.profilingMaxTimeMills =
TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION);
+}
+
+/**
+ * If tracing start time greater than {@link
ProfileTask#getMinDurationThreshold()}, then start to profiling trace
+ */
+public void startProfilingIfNeed() {
+if (System.currentTimeMillis() - tracingContext.createTime() >
executionContext.getTask().getMinDurationThreshold()) {
+this.profilingStartTime = System.currentTimeMillis();
+this.profilingStatus = ProfilingStatus.PROFILING;
+}
+}
+
+/**
+ * Stop profiling status
+ */
+public void stopProfiling() {
+this.profilingStatus = ProfilingStatus.STOPPED;
+}
+
+/**
+ * dump tracing thread and build thread snapshot
+ *
+ * @return snapshot, if null means dump snapshot error, should stop it
+ */
+public TracingThreadSnapshot buildSnapshot() {
+if (!isProfilingProfilingContinuable()) {
+return null;
+}
+
+long currentTime = System.currentTimeMillis();
+// dump thread
+StackTraceElement[] stackTrace;
+try {
+stackTrace = profilingThread.getStackTrace();
+
+// stack depth is zero, means thread is already run finished
+if (stackTrace.length == 0) {
+return null;
+}
+} catch (Exception e) {
+// dump error ignore and make this profiler stop
+return null;
+}
+
+// if is first dump, check is can start profiling
+if (dumpSequence == 0 && (!executionContext.isStartProfileable())) {
+return null;
+}
+
+int dumpElementCount = Math.min(stackTrace.length,
Config.Profile.DUMP_MAX_STACK_DEPTH);
+
+// use inverted order, because thread dump is start with bottom
+final ArrayList stackList = new ArrayList<>(dumpElementCount);
+for (int i = dumpElementCount - 1; i >= 0; i--) {
+stackList.add(buildStackElementCodeSignature(stackTrace[i]));
+}
+
+String taskId = executionContext.getTask().getTaskId();
+return new TracingThreadSnapshot(taskId, traceSegmentId,
dumpSequence++, currentTime, stackList);
+}
+
+/**
+ * build thread stack element code signature
+ *
+ * @return code sign: className.methodName:lineNumber
+ */
+private String
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
wu-sheng commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368215435
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.profile;
+
+import com.google.common.base.Objects;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.TracingContext;
+import org.apache.skywalking.apm.agent.core.context.ids.ID;
+
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author MrPro
+ */
+public class ThreadProfiler {
+
+// current tracing context
+private final TracingContext tracingContext;
+// current tracing segment id
+private final ID traceSegmentId;
+// need to profiling thread
+private final Thread profilingThread;
+// profiling execution context
+private final ProfileTaskExecutionContext executionContext;
+
+// profiling time
+private long profilingStartTime;
+private long profilingMaxTimeMills;
+
+// after min duration threshold check, it will start dump
+private ProfilingStatus profilingStatus = ProfilingStatus.READY;
+// thread dump sequence
+private int dumpSequence = 0;
+
+public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId,
Thread profilingThread, ProfileTaskExecutionContext executionContext) {
+this.tracingContext = tracingContext;
+this.traceSegmentId = traceSegmentId;
+this.profilingThread = profilingThread;
+this.executionContext = executionContext;
+this.profilingMaxTimeMills =
TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION);
+}
+
+/**
+ * If tracing start time greater than {@link
ProfileTask#getMinDurationThreshold()}, then start to profiling trace
+ */
+public void startProfilingIfNeed() {
+if (System.currentTimeMillis() - tracingContext.createTime() >
executionContext.getTask().getMinDurationThreshold()) {
+this.profilingStartTime = System.currentTimeMillis();
+this.profilingStatus = ProfilingStatus.PROFILING;
+}
+}
+
+/**
+ * Stop profiling status
+ */
+public void stopProfiling() {
+this.profilingStatus = ProfilingStatus.STOPPED;
+}
+
+/**
+ * dump tracing thread and build thread snapshot
+ *
+ * @return snapshot, if null means dump snapshot error, should stop it
+ */
+public TracingThreadSnapshot buildSnapshot() {
+if (!isProfilingProfilingContinuable()) {
+return null;
+}
+
+long currentTime = System.currentTimeMillis();
+// dump thread
+StackTraceElement[] stackTrace;
+try {
+stackTrace = profilingThread.getStackTrace();
+
+// stack depth is zero, means thread is already run finished
+if (stackTrace.length == 0) {
+return null;
+}
+} catch (Exception e) {
+// dump error ignore and make this profiler stop
+return null;
+}
+
+// if is first dump, check is can start profiling
+if (dumpSequence == 0 && (!executionContext.isStartProfileable())) {
+return null;
+}
+
+int dumpElementCount = Math.min(stackTrace.length,
Config.Profile.DUMP_MAX_STACK_DEPTH);
+
+// use inverted order, because thread dump is start with bottom
+final ArrayList stackList = new ArrayList<>(dumpElementCount);
+for (int i = dumpElementCount - 1; i >= 0; i--) {
+stackList.add(buildStackElementCodeSignature(stackTrace[i]));
+}
+
+String taskId = executionContext.getTask().getTaskId();
+return new TracingThreadSnapshot(taskId, traceSegmentId,
dumpSequence++, currentTime, stackList);
+}
+
+/**
+ * build thread stack element code signature
+ *
+ * @return code sign: className.methodName:lineNumber
+ */
+private String
[GitHub] [skywalking] wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot
wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-575879392 > You have only ES DAO for ES6, ProfileTaskQueryEsDAO, ProfileTaskLogEsDAO, and you use them in ES7, they're not compatible trivially, please add the implementations for ES7 version @mrproliu Please fix. FYI @kezhenxu94 it was me asking him to add more real e2e test in the next query and snapshot merge PR. So, maybe some points are missed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368213672
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionService.java
##
@@ -84,19 +90,46 @@ public void run() {
}, timeToProcessMills, TimeUnit.MILLISECONDS);
}
+/**
+ * check and add {@link TracingContext} profiling
+ */
+public boolean addProfiling(TracingContext tracingContext, ID
traceSegmentId, String firstSpanOPName) {
+// get current profiling task, check need profiling
+final ProfileTaskExecutionContext executionContext =
taskExecutionContext.get();
+if (executionContext == null) {
+return false;
+}
+
+return executionContext.attemptProfiling(tracingContext,
traceSegmentId, firstSpanOPName);
+}
+
+/**
+ * Re-check current trace need profiling, encase third part plugin change
the operation name.
Review comment:
```suggestion
* Re-check current trace need profiling, in case that third-party
plugins change the operation name.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214095
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.profile;
+
+import com.google.common.base.Objects;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.TracingContext;
+import org.apache.skywalking.apm.agent.core.context.ids.ID;
+
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author MrPro
+ */
+public class ThreadProfiler {
+
+// current tracing context
+private final TracingContext tracingContext;
+// current tracing segment id
+private final ID traceSegmentId;
+// need to profiling thread
+private final Thread profilingThread;
+// profiling execution context
+private final ProfileTaskExecutionContext executionContext;
+
+// profiling time
+private long profilingStartTime;
+private long profilingMaxTimeMills;
+
+// after min duration threshold check, it will start dump
+private ProfilingStatus profilingStatus = ProfilingStatus.READY;
+// thread dump sequence
+private int dumpSequence = 0;
+
+public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId,
Thread profilingThread, ProfileTaskExecutionContext executionContext) {
+this.tracingContext = tracingContext;
+this.traceSegmentId = traceSegmentId;
+this.profilingThread = profilingThread;
+this.executionContext = executionContext;
+this.profilingMaxTimeMills =
TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION);
+}
+
+/**
+ * If tracing start time greater than {@link
ProfileTask#getMinDurationThreshold()}, then start to profiling trace
+ */
+public void startProfilingIfNeed() {
+if (System.currentTimeMillis() - tracingContext.createTime() >
executionContext.getTask().getMinDurationThreshold()) {
+this.profilingStartTime = System.currentTimeMillis();
+this.profilingStatus = ProfilingStatus.PROFILING;
+}
+}
+
+/**
+ * Stop profiling status
+ */
+public void stopProfiling() {
+this.profilingStatus = ProfilingStatus.STOPPED;
+}
+
+/**
+ * dump tracing thread and build thread snapshot
+ *
+ * @return snapshot, if null means dump snapshot error, should stop it
+ */
+public TracingThreadSnapshot buildSnapshot() {
+if (!isProfilingProfilingContinuable()) {
+return null;
+}
+
+long currentTime = System.currentTimeMillis();
+// dump thread
+StackTraceElement[] stackTrace;
+try {
+stackTrace = profilingThread.getStackTrace();
+
+// stack depth is zero, means thread is already run finished
+if (stackTrace.length == 0) {
+return null;
+}
+} catch (Exception e) {
+// dump error ignore and make this profiler stop
+return null;
+}
+
+// if is first dump, check is can start profiling
+if (dumpSequence == 0 && (!executionContext.isStartProfileable())) {
+return null;
+}
+
+int dumpElementCount = Math.min(stackTrace.length,
Config.Profile.DUMP_MAX_STACK_DEPTH);
+
+// use inverted order, because thread dump is start with bottom
+final ArrayList stackList = new ArrayList<>(dumpElementCount);
+for (int i = dumpElementCount - 1; i >= 0; i--) {
+stackList.add(buildStackElementCodeSignature(stackTrace[i]));
+}
+
+String taskId = executionContext.getTask().getTaskId();
+return new TracingThreadSnapshot(taskId, traceSegmentId,
dumpSequence++, currentTime, stackList);
+}
+
+/**
+ * build thread stack element code signature
+ *
+ * @return code sign: className.methodName:lineNumber
+ */
+private String
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214282
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.profile;
+
+import com.google.common.base.Objects;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.TracingContext;
+import org.apache.skywalking.apm.agent.core.context.ids.ID;
+
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author MrPro
+ */
+public class ThreadProfiler {
+
+// current tracing context
+private final TracingContext tracingContext;
+// current tracing segment id
+private final ID traceSegmentId;
+// need to profiling thread
+private final Thread profilingThread;
+// profiling execution context
+private final ProfileTaskExecutionContext executionContext;
+
+// profiling time
+private long profilingStartTime;
+private long profilingMaxTimeMills;
+
+// after min duration threshold check, it will start dump
+private ProfilingStatus profilingStatus = ProfilingStatus.READY;
+// thread dump sequence
+private int dumpSequence = 0;
+
+public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId,
Thread profilingThread, ProfileTaskExecutionContext executionContext) {
+this.tracingContext = tracingContext;
+this.traceSegmentId = traceSegmentId;
+this.profilingThread = profilingThread;
+this.executionContext = executionContext;
+this.profilingMaxTimeMills =
TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION);
+}
+
+/**
+ * If tracing start time greater than {@link
ProfileTask#getMinDurationThreshold()}, then start to profiling trace
+ */
+public void startProfilingIfNeed() {
+if (System.currentTimeMillis() - tracingContext.createTime() >
executionContext.getTask().getMinDurationThreshold()) {
+this.profilingStartTime = System.currentTimeMillis();
+this.profilingStatus = ProfilingStatus.PROFILING;
+}
+}
+
+/**
+ * Stop profiling status
+ */
+public void stopProfiling() {
+this.profilingStatus = ProfilingStatus.STOPPED;
+}
+
+/**
+ * dump tracing thread and build thread snapshot
+ *
+ * @return snapshot, if null means dump snapshot error, should stop it
+ */
+public TracingThreadSnapshot buildSnapshot() {
+if (!isProfilingProfilingContinuable()) {
+return null;
+}
+
+long currentTime = System.currentTimeMillis();
+// dump thread
+StackTraceElement[] stackTrace;
+try {
+stackTrace = profilingThread.getStackTrace();
+
+// stack depth is zero, means thread is already run finished
+if (stackTrace.length == 0) {
+return null;
+}
+} catch (Exception e) {
+// dump error ignore and make this profiler stop
+return null;
+}
+
+// if is first dump, check is can start profiling
+if (dumpSequence == 0 && (!executionContext.isStartProfileable())) {
+return null;
+}
+
+int dumpElementCount = Math.min(stackTrace.length,
Config.Profile.DUMP_MAX_STACK_DEPTH);
+
+// use inverted order, because thread dump is start with bottom
+final ArrayList stackList = new ArrayList<>(dumpElementCount);
+for (int i = dumpElementCount - 1; i >= 0; i--) {
+stackList.add(buildStackElementCodeSignature(stackTrace[i]));
+}
+
+String taskId = executionContext.getTask().getTaskId();
+return new TracingThreadSnapshot(taskId, traceSegmentId,
dumpSequence++, currentTime, stackList);
+}
+
+/**
+ * build thread stack element code signature
+ *
+ * @return code sign: className.methodName:lineNumber
+ */
+private String
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot
kezhenxu94 commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214112
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.profile;
+
+import com.google.common.base.Objects;
+import org.apache.skywalking.apm.agent.core.conf.Config;
+import org.apache.skywalking.apm.agent.core.context.TracingContext;
+import org.apache.skywalking.apm.agent.core.context.ids.ID;
+
+import java.util.ArrayList;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author MrPro
+ */
+public class ThreadProfiler {
+
+// current tracing context
+private final TracingContext tracingContext;
+// current tracing segment id
+private final ID traceSegmentId;
+// need to profiling thread
+private final Thread profilingThread;
+// profiling execution context
+private final ProfileTaskExecutionContext executionContext;
+
+// profiling time
+private long profilingStartTime;
+private long profilingMaxTimeMills;
+
+// after min duration threshold check, it will start dump
+private ProfilingStatus profilingStatus = ProfilingStatus.READY;
+// thread dump sequence
+private int dumpSequence = 0;
+
+public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId,
Thread profilingThread, ProfileTaskExecutionContext executionContext) {
+this.tracingContext = tracingContext;
+this.traceSegmentId = traceSegmentId;
+this.profilingThread = profilingThread;
+this.executionContext = executionContext;
+this.profilingMaxTimeMills =
TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION);
+}
+
+/**
+ * If tracing start time greater than {@link
ProfileTask#getMinDurationThreshold()}, then start to profiling trace
+ */
+public void startProfilingIfNeed() {
+if (System.currentTimeMillis() - tracingContext.createTime() >
executionContext.getTask().getMinDurationThreshold()) {
+this.profilingStartTime = System.currentTimeMillis();
+this.profilingStatus = ProfilingStatus.PROFILING;
+}
+}
+
+/**
+ * Stop profiling status
+ */
+public void stopProfiling() {
+this.profilingStatus = ProfilingStatus.STOPPED;
+}
+
+/**
+ * dump tracing thread and build thread snapshot
+ *
+ * @return snapshot, if null means dump snapshot error, should stop it
+ */
+public TracingThreadSnapshot buildSnapshot() {
+if (!isProfilingProfilingContinuable()) {
+return null;
+}
+
+long currentTime = System.currentTimeMillis();
+// dump thread
+StackTraceElement[] stackTrace;
+try {
+stackTrace = profilingThread.getStackTrace();
+
+// stack depth is zero, means thread is already run finished
+if (stackTrace.length == 0) {
+return null;
+}
+} catch (Exception e) {
+// dump error ignore and make this profiler stop
+return null;
+}
+
+// if is first dump, check is can start profiling
+if (dumpSequence == 0 && (!executionContext.isStartProfileable())) {
+return null;
+}
+
+int dumpElementCount = Math.min(stackTrace.length,
Config.Profile.DUMP_MAX_STACK_DEPTH);
+
+// use inverted order, because thread dump is start with bottom
+final ArrayList stackList = new ArrayList<>(dumpElementCount);
+for (int i = dumpElementCount - 1; i >= 0; i--) {
+stackList.add(buildStackElementCodeSignature(stackTrace[i]));
+}
+
+String taskId = executionContext.getTask().getTaskId();
+return new TracingThreadSnapshot(taskId, traceSegmentId,
dumpSequence++, currentTime, stackList);
+}
+
+/**
+ * build thread stack element code signature
+ *
+ * @return code sign: className.methodName:lineNumber
+ */
+private String
[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP
arugal commented on a change in pull request #4228: Support Browser protocol at
OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368214206
##
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/NotifyHandler.java
##
@@ -82,6 +82,12 @@ public NotifyHandler(AlarmRulesWatcher alarmRulesWatcher) {
endpointMetaInAlarm.setName(textName);
metaInAlarm = endpointMetaInAlarm;
+} else if (DefaultScopeDefine.inServicePageCatalog(scope)) {
+// TODO handler service page path catalog
+return;
+} else if (DefaultScopeDefine.inServiceVersionCatalog(scope)) {
+// TODO handler service version page path catalog
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
