[PR] Add missing metrics to the `OpenTelemetry Metrics` doc. [skywalking]
wankai123 opened a new pull request, #11446: URL: https://github.com/apache/skywalking/pull/11446 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add missing metrics to the `OpenTelemetry Metrics` doc. [skywalking]
wu-sheng merged PR #11446: URL: https://github.com/apache/skywalking/pull/11446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Add missing metrics to the `OpenTelemetry Metrics` doc. (#11446)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 6d85b931b9 Add missing metrics to the `OpenTelemetry Metrics` doc. (#11446) 6d85b931b9 is described below commit 6d85b931b9e3eaba7cee2be1f2b81ec60dd371b0 Author: Wan Kai AuthorDate: Mon Oct 23 15:21:38 2023 +0800 Add missing metrics to the `OpenTelemetry Metrics` doc. (#11446) --- docs/en/changes/changes.md | 2 +- docs/en/setup/backend/opentelemetry-receiver.md | 45 +++-- 2 files changed, 29 insertions(+), 18 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 3f4b445234..89cfbe0e4a 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -45,6 +45,6 @@ * Separate storage docs to different files, and add an estimated timeline for BanyanDB(end of 2023). * Add topology configuration in UI-Grafana doc. - +* Add missing metrics to the `OpenTelemetry Metrics` doc. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/193?closed=1) diff --git a/docs/en/setup/backend/opentelemetry-receiver.md b/docs/en/setup/backend/opentelemetry-receiver.md index ddbe586f2f..1c82c45529 100644 --- a/docs/en/setup/backend/opentelemetry-receiver.md +++ b/docs/en/setup/backend/opentelemetry-receiver.md @@ -26,21 +26,32 @@ The receiver adds label with key `node_identifier_host_name` to the collected da and its value is from `net.host.name` (or `host.name` for some OTLP versions) resource attributes defined in OpenTelemetry proto, for identification of the metric data. -| Description | Configuration File | Data Source | -|-||---| -| Metrics of Istio Control Plane | otel-rules/istio-controlplane.yaml | Istio Control Plane -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of SkyWalking OAP server itself | otel-rules/oap.yaml | SkyWalking OAP Server(SelfObservability) -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of VMs | otel-rules/vm.yaml | Prometheus node-exporter(VMs) -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server| -| Metrics of K8s cluster | otel-rules/k8s/k8s-cluster.yaml | K8s kube-state-metrics -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of K8s cluster | otel-rules/k8s/k8s-node.yaml | cAdvisor & K8s kube-state-metrics -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server| -| Metrics of K8s cluster | otel-rules/k8s/k8s-service.yaml | cAdvisor & K8s kube-state-metrics -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server| -| Metrics of MYSQL| otel-rules/mysql/mysql-instance.yaml | prometheus/mysqld_exporter -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of MYSQL| otel-rules/mysql/mysql-service.yaml| prometheus/mysqld_exporter -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of PostgreSQL | otel-rules/postgresql/postgresql-instance.yaml | postgres_exporter -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of PostgreSQL | otel-rules/postgresql/postgresql-service.yaml | postgres_exporter -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of Apache APISIX| otel-rules/apisix.yaml | apisix prometheus plugin -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of AWS Cloud EKS| otel-rules/aws-eks/eks-cluster.yaml| AWS Container Insights Receiver -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of AWS Cloud EKS| otel-rules/aws-eks/eks-service.yaml| AWS Container Insights Receiver -> OpenTelemetry Collector -- OTLP exporter --> SkyWalking OAP Server | -| Metrics of AWS Cloud EKS| otel-rules/aws-eks/eks-node.yam
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
Ecostack commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1774645846 Been testing the new version and found some things. First of all, this feature looks amazing and I am happy about what it can provide! Please let me know if this is the right place to post or not. ### Toolkit/Trace API The package github.com/apache/skywalking-go v0.3.0 does not expose the toolkit/trace API, it is a separate package. Would it not be better if that is both coming from the skywalking-go package? ``` require ( github.com/apache/skywalking-go v0.3.0 github.com/apache/skywalking-go/toolkit v0.0.0-20231019114202-ff7ad0ddecba ) ``` ### No trace.SetLog According to the documentation, there should be a log method on the trace. It seems like it does not exist though. Either way, logging inside of a span is correctly reported. Maybe it is best to remove the trace.SetLog from the documentation? ### Injector & Extractor Ref There are two methods, `CreateEntrySpan(operationName string, extractor ExtractorRef)` and `CreateExitSpan(operationName string, peer string, injector InjectorRef)` which require either an **injector or extractor ref**. How would I obtain these or use these methods? Maybe provide an example of how these can be used. ### Component unknown Manual span entries have component value set to `unknown`. Can this be set manually or would it be possible to set this value somehow automatic, maybe the file name or such? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update toolkit-trace.md [skywalking-go]
Ecostack opened a new pull request, #131: URL: https://github.com/apache/skywalking-go/pull/131 Update documentation for advanced feature tracing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
wu-sheng commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1774661794 @Ecostack Could you copy your report at here? https://github.com/apache/skywalking/discussions It is better for others to find discussion context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-go] annotated tag toolkit/v0.3.0 updated (316433e -> 1ba87a7)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.3.0 was modified! *** from 316433e (commit) to 1ba87a7 (tag) tagging 316433e71808ec6a130e81c287caa8b2a98f45a5 (commit) replaces v0.2.0 by Mrproliu on Mon Oct 23 16:36:20 2023 +0800 - Log - Release Apache SkyWalking-Go Toolkit v0.3.0 --- No new revisions were added by this update. Summary of changes:
[skywalking-go] annotated tag toolkit/v0.3.0 deleted (was 1ba87a7)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.3.0 was deleted! *** tag was 1ba87a7 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-go] annotated tag toolkit/v0.3.0 updated (316433e -> 038d3e2)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.3.0 was modified! *** from 316433e (commit) to 038d3e2 (tag) tagging 316433e71808ec6a130e81c287caa8b2a98f45a5 (commit) replaces v0.2.0 by Mrproliu on Mon Oct 23 16:41:07 2023 +0800 - Log - Release Apache SkyWalking-Go Toolkit v0.3.0 --- No new revisions were added by this update. Summary of changes:
[skywalking-go] annotated tag toolkit/v0.3.0 deleted (was 038d3e2)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.3.0 was deleted! *** tag was 038d3e2 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-go] annotated tag toolkit/v0.3.0 updated (316433e -> 5ddfb04)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to annotated tag toolkit/v0.3.0 in repository https://gitbox.apache.org/repos/asf/skywalking-go.git *** WARNING: tag toolkit/v0.3.0 was modified! *** from 316433e (commit) to 5ddfb04 (tag) tagging 316433e71808ec6a130e81c287caa8b2a98f45a5 (commit) replaces v0.2.0 by Mrproliu on Mon Oct 23 16:53:39 2023 +0800 - Log - Release Apache SkyWalking-Go Toolkit v0.3.0 --- No new revisions were added by this update. Summary of changes:
Re: [PR] Update toolkit-trace.md [skywalking-go]
Alipebt commented on code in PR #131: URL: https://github.com/apache/skywalking-go/pull/131#discussion_r1368339014 ## docs/en/advanced-features/manual-apis/toolkit-trace.md: ## @@ -60,9 +60,9 @@ trace.StopSpan() ### Add Span’s Tag and Log -Use `trace.SetLog` to record log in span. +Use `trace.SetLog()` to record log in span. -Use `trace.SetTag` to add tag to span, the parameters of tag are two String which are key and value respectively. +Use `trace.SetTag()` to add tag to span, the parameters of tag are two String which are key and value respectively. Review Comment: Thank you very much. And the method that implements the relevant functionality is named "AddLog," but there is an error where it is written as "SetLog." Could you please correct it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
mrproliu commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1774746232 BTW, @Ecostack For the `github.com/apache/skywalking-go/toolkit` version is not correct problem. I have added a new tag for this. Now, you can use `go get github.com/apache/skywalking-go/toolkit` to get the package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Provide APIs to user and support correlationContext [skywalking-go]
wu-sheng commented on PR #104: URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1774760747 > BTW, @Ecostack For the `github.com/apache/skywalking-go/toolkit` version is not correct problem. > > I have added a new tag for this. Now, you can use `go get github.com/apache/skywalking-go/toolkit` to get the package. @mrproliu Should we update the release doc about this? This seems to be an easy-to-forget thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update the release documentation for the toolkit [skywalking-go]
mrproliu opened a new pull request, #132: URL: https://github.com/apache/skywalking-go/pull/132 Following https://github.com/apache/skywalking-go/pull/104#issuecomment-1774760747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: add a title and a description for trace segments [skywalking-booster-ui]
Fine0830 opened a new pull request, #332: URL: https://github.com/apache/skywalking-booster-ui/pull/332 Screenshot https://github.com/apache/skywalking-booster-ui/assets/20871783/cf20a90b-6269-49f5-a2bc-370ff1896a32";> Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add a title and a description for trace segments [skywalking-booster-ui]
wu-sheng commented on code in PR #332:
URL:
https://github.com/apache/skywalking-booster-ui/pull/332#discussion_r1368391148
##
src/locales/lang/zh.ts:
##
@@ -380,5 +380,7 @@ const msg = {
addExpressions: "添加表达式",
expressions: "表达式",
unhealthyExpression: "非健康表达式",
+ traceDesc:
+"Trace
segment充当在单个操作系统进程（如JVM）中执行的跟踪部分的表示。它包括跨度的集合，通常与单个请求或执行上下文相关联并从中收集。",
Review Comment:
```suggestion
"Trace
Segment代表在单一操作系统进程（例如JVM）中执行的追踪部分。它包含了一组跨度（spans），这些跨度通常与单一请求或执行上下文关联。",
```
##
src/locales/lang/zh.ts:
##
@@ -380,5 +380,7 @@ const msg = {
addExpressions: "添加表达式",
expressions: "表达式",
unhealthyExpression: "非健康表达式",
+ traceDesc:
+"Trace
segment充当在单个操作系统进程（如JVM）中执行的跟踪部分的表示。它包括跨度的集合，通常与单个请求或执行上下文相关联并从中收集。",
Review Comment:
```suggestion
"Trace
Segment代表在单一操作系统进程（例如JVM）中执行的追踪部分。它包含了一组跨度（spans），这些跨度通常与单一请求或执行上下文关联。",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: add a title and a description for trace segments [skywalking-booster-ui]
Fine0830 merged PR #332: URL: https://github.com/apache/skywalking-booster-ui/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-booster-ui] branch main updated: feat: add a title and a description for trace segments (#332)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new d2eae879 feat: add a title and a description for trace segments (#332)
d2eae879 is described below
commit d2eae879573ae657d230aea651de83432aace87c
Author: Fine0830
AuthorDate: Mon Oct 23 17:42:02 2023 +0800
feat: add a title and a description for trace segments (#332)
---
.github/workflows/nodejs.yml| 2 +-
src/locales/lang/en.ts | 2 +
src/locales/lang/es.ts | 2 +
src/locales/lang/zh.ts | 2 +
src/views/dashboard/related/trace/TraceList.vue | 52 ++---
5 files changed, 44 insertions(+), 16 deletions(-)
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
index 3003504b..4f7f664d 100644
--- a/.github/workflows/nodejs.yml
+++ b/.github/workflows/nodejs.yml
@@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
-node-version: [14.x, 16.x, 18.x]
+node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
diff --git a/src/locales/lang/en.ts b/src/locales/lang/en.ts
index 1d983f65..415a4735 100644
--- a/src/locales/lang/en.ts
+++ b/src/locales/lang/en.ts
@@ -382,5 +382,7 @@ const msg = {
addExpressions: "Add Expressions",
expressions: "Expression",
unhealthyExpression: "Unhealthy Expression",
+ traceDesc:
+"The trace segment serves as a representation of a trace portion executed
within one single OS process, such as a JVM. It comprises a collection of
spans, typically associated with and collected from a single request or
execution context.",
};
export default msg;
diff --git a/src/locales/lang/es.ts b/src/locales/lang/es.ts
index b92ba40b..27860e0d 100644
--- a/src/locales/lang/es.ts
+++ b/src/locales/lang/es.ts
@@ -382,5 +382,7 @@ const msg = {
addExpressions: "Add Expressions",
expressions: "Expression",
unhealthyExpression: "Unhealthy Expression",
+ traceDesc:
+"The trace segment serves as a representation of a trace portion executed
within one single OS process, such as a JVM. It comprises a collection of
spans, typically associated with and collected from a single request or
execution context.",
};
export default msg;
diff --git a/src/locales/lang/zh.ts b/src/locales/lang/zh.ts
index edc9a665..b9a6c48d 100644
--- a/src/locales/lang/zh.ts
+++ b/src/locales/lang/zh.ts
@@ -380,5 +380,7 @@ const msg = {
addExpressions: "添加表达式",
expressions: "表达式",
unhealthyExpression: "非健康表达式",
+ traceDesc:
+"Trace
Segment代表在单一操作系统进程（例如JVM）中执行的追踪部分。它包含了一组跨度（spans），这些跨度通常与单一请求或执行上下文关联。",
};
export default msg;
diff --git a/src/views/dashboard/related/trace/TraceList.vue
b/src/views/dashboard/related/trace/TraceList.vue
index c2ebfe10..9be3d2ac 100644
--- a/src/views/dashboard/related/trace/TraceList.vue
+++ b/src/views/dashboard/related/trace/TraceList.vue
@@ -13,15 +13,21 @@ limitations under the License. -->
-
+
+Trace Segments
+
+
+
+
+
+
+
+
{{ t("noData") }}
+
+
+
@@ -78,11 +94,11 @@ limitations under the License. -->
const traceStore = useTraceStore();
const loading = ref(false);
const selectedKey = ref("");
- const pageSize = ref(20);
+ const pageSize = 20;
const total = computed(() =>
-traceStore.traceList.length === pageSize.value
- ? pageSize.value * traceStore.conditions.paging.pageNum + 1
- : pageSize.value * traceStore.conditions.paging.pageNum,
+traceStore.traceList.length === pageSize
+ ? pageSize * traceStore.conditions.paging.pageNum + 1
+ : pageSize * traceStore.conditions.paging.pageNum,
);
function searchTrace() {
@@ -93,7 +109,7 @@ limitations under the License. -->
function updatePage(p: number) {
traceStore.setTraceCondition({
- paging: { pageNum: p, pageSize: pageSize.value },
+ paging: { pageNum: p, pageSize },
});
searchTrace();
}
@@ -101,7 +117,7 @@ limitations under the License. -->
function changeSort(opt: Option[]) {
traceStore.setTraceCondition({
queryOrder: opt[0].value,
- paging: { pageNum: 1, pageSize: pageSize.value },
+ paging: { pageNum: 1, pageSize },
});
searchTrace();
}
@@ -133,6 +149,12 @@ limitations under the License. -->
border-bottom: 1px solid #c1c5ca41;
border-right: 1px solid #c1c5ca41;
height: 35px;
+align-items: center;
+ }
+
+ .title {
+font-weight: bold;
+padding-left: 10px;
}
.selectors {
[skywalking] 01/01: Sync UI
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git commit c955462065ee8c5907c73b984a2a37dd4e19f055 Author: Wu Sheng AuthorDate: Mon Oct 23 17:55:49 2023 +0800 Sync UI --- docs/en/changes/changes.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 89cfbe0e4a..172529fe1a 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -38,8 +38,10 @@ * Refactor: update pagination style. No visualization style change. * Apply MQE on K8s layer UI-templates. * Fix icons display in trace tree diagram. -* fix: update tooltip style to support multiple metrics scrolling view in a metrics graph. +* Fix: update tooltip style to support multiple metrics scrolling view in a metrics graph. * Add a new widget to show jvm memory pool detail. +* Fix: avoid querying data with empty parameters. +* Add a title and a description for trace segments Documentation
[skywalking] branch ui-sync created (now c955462065)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git at c955462065 Sync UI This branch includes the following new commits: new c955462065 Sync UI The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[PR] Sync UI [skywalking]
wu-sheng opened a new pull request, #11448: URL: https://github.com/apache/skywalking/pull/11448 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). Sync UI changes * Fix: avoid querying data with empty parameters. * Add a title and a description for trace segments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Sync UI [skywalking]
wu-sheng commented on PR #11448: URL: https://github.com/apache/skywalking/pull/11448#issuecomment-1774935518 My fault, the sub module is not submitted. Let's hold. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch ui-sync updated: Submit submodule
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/ui-sync by this push: new f4e79553e6 Submit submodule f4e79553e6 is described below commit f4e79553e67cdcdde71854fa224b314bfa405d26 Author: Wu Sheng AuthorDate: Mon Oct 23 19:06:41 2023 +0800 Submit submodule --- skywalking-ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skywalking-ui b/skywalking-ui index 1be2792ff4..d2eae87957 16 --- a/skywalking-ui +++ b/skywalking-ui @@ -1 +1 @@ -Subproject commit 1be2792ff46547fafe5b554b0cd4f086dd8d02b7 +Subproject commit d2eae879573ae657d230aea651de83432aace87c
[skywalking] branch ui-sync updated: Add change logs.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/ui-sync by this push: new c515f41ee3 Add change logs. c515f41ee3 is described below commit c515f41ee3dc3a8ac2d352faaf27881732de73d6 Author: Wu Sheng AuthorDate: Mon Oct 23 19:08:17 2023 +0800 Add change logs. --- docs/en/changes/changes.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 172529fe1a..b20a69ac6a 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -41,7 +41,9 @@ * Fix: update tooltip style to support multiple metrics scrolling view in a metrics graph. * Add a new widget to show jvm memory pool detail. * Fix: avoid querying data with empty parameters. -* Add a title and a description for trace segments +* Add a title and a description for trace segments. +* Add Netty icon for Netty HTTP plugin. +* Add Pulsar menu i18n files. Documentation
Re: [PR] Sync UI [skywalking]
wu-sheng merged PR #11448: URL: https://github.com/apache/skywalking/pull/11448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Sync UI (#11448)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f38a874355 Sync UI (#11448) f38a874355 is described below commit f38a87435593226cd34d644b1e197f4bd31d032b Author: 吴晟 Wu Sheng AuthorDate: Mon Oct 23 20:11:38 2023 +0800 Sync UI (#11448) --- docs/en/changes/changes.md | 6 +- skywalking-ui | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 89cfbe0e4a..b20a69ac6a 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -38,8 +38,12 @@ * Refactor: update pagination style. No visualization style change. * Apply MQE on K8s layer UI-templates. * Fix icons display in trace tree diagram. -* fix: update tooltip style to support multiple metrics scrolling view in a metrics graph. +* Fix: update tooltip style to support multiple metrics scrolling view in a metrics graph. * Add a new widget to show jvm memory pool detail. +* Fix: avoid querying data with empty parameters. +* Add a title and a description for trace segments. +* Add Netty icon for Netty HTTP plugin. +* Add Pulsar menu i18n files. Documentation diff --git a/skywalking-ui b/skywalking-ui index 1be2792ff4..d2eae87957 16 --- a/skywalking-ui +++ b/skywalking-ui @@ -1 +1 @@ -Subproject commit 1be2792ff46547fafe5b554b0cd4f086dd8d02b7 +Subproject commit d2eae879573ae657d230aea651de83432aace87c
Re: [PR] re: Unify topn&query plan [skywalking-banyandb]
lujiajing1126 commented on code in PR #343:
URL:
https://github.com/apache/skywalking-banyandb/pull/343#discussion_r1368665642
##
banyand/measure/measure_query.go:
##
@@ -54,10 +54,25 @@ type Measure interface {
GetSchema() *databasev1.Measure
GetIndexRules() []*databasev1.IndexRule
GetInterval() time.Duration
+ BuildSchema(other Measure) *databasev1.Measure
}
var _ Measure = (*measure)(nil)
+func (s *measure) BuildSchema(other Measure) *databasev1.Measure {
Review Comment:
According to our last discussion, we should build topN schema with entity
names,
https://github.com/apache/skywalking-banyandb/blob/d722db6bcd52554ef429961600d617d28d561ae5/banyand/measure/metadata.go#L204-L220
The actual entity names written for the TopN data point can be found,
https://github.com/apache/skywalking-banyandb/blob/d722db6bcd52554ef429961600d617d28d561ae5/banyand/measure/measure_topn.go#L233-L247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking] branch ui-sync deleted (was c515f41ee3)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git was c515f41ee3 Add change logs. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Feature pulsar monitoring [skywalking]
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1368674556
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##
@@ -193,7 +193,16 @@ public enum Layer {
/**
* Kafka is a distributed streaming platform that is used publish and
subscribe to streams of records.
*/
-KAFKA(31, true);
+KAFKA(31, true),
+
+/**
+ * Pulsar is a distributed pub-sub messaging platform that provides
high-performance, durable messaging.
+ * It is used to publish and subscribe to streams of records.
+ * Pulsar supports scalable and fault-tolerant messaging, making it
suitable for use in distributed systems.
+ */
+PULSAR(32, true),
+
+BOOKKEEPER(33, true);
Review Comment:
Please add comments when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Feature pulsar monitoring [skywalking]
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1368677539
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java:
##
@@ -193,7 +193,16 @@ public enum Layer {
/**
* Kafka is a distributed streaming platform that is used publish and
subscribe to streams of records.
*/
-KAFKA(31, true);
+KAFKA(31, true),
+
+/**
+ * Pulsar is a distributed pub-sub messaging platform that provides
high-performance, durable messaging.
+ * It is used to publish and subscribe to streams of records.
+ * Pulsar supports scalable and fault-tolerant messaging, making it
suitable for use in distributed systems.
+ */
+PULSAR(32, true),
+
+BOOKKEEPER(33, true);
Review Comment:
And documents should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [GSoC][Feature] add SkyWalking Terraform provider [skywalking]
kezhenxu94 commented on issue #10543: URL: https://github.com/apache/skywalking/issues/10543#issuecomment-1775327809 An MVP is implemented in https://github.com/apache/skywalking-terraform -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [GSoC][Feature] add SkyWalking Terraform provider [skywalking]
kezhenxu94 closed issue #10543: [GSoC][Feature] add SkyWalking Terraform provider URL: https://github.com/apache/skywalking/issues/10543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [GSoC][Feature] add SkyWalking Terraform provider [skywalking]
wu-sheng commented on issue #10543: URL: https://github.com/apache/skywalking/issues/10543#issuecomment-1775339935 Would you plan to release a version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feature: add support for fiber [skywalking-go]
CodePrometheus opened a new pull request, #133: URL: https://github.com/apache/skywalking-go/pull/133 [Filber](https://github.com/gofiber/fiber) is a HTTP web framework. I would appreciate it if the members of the community wouldn't mind taking a look at my code and providing some feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add a component ID for Fiber [skywalking]
CodePrometheus opened a new pull request, #11450: URL: https://github.com/apache/skywalking/pull/11450 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a component ID for Fiber [skywalking]
CodePrometheus commented on PR #11450:
URL: https://github.com/apache/skywalking/pull/11450#issuecomment-1775910997
{@link https://github.com/apache/skywalking-go/pull/133}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on PR #625: URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1776258046 > I didn't check the failed test cases. I feel as many other frameworks are using netty, you newly added a plugin for it could change the expected tracing data(spans or something). You should check the fail reason, if the reason is as I mentioned above, we should consider to put netty HTTP plugin as optional only. I have fixed some issues, and the other are just segment size errors.I agree to put the plugin into optional plugins. Some frameworks, such as Vert.x and Spring Cloud Gateway, use Netty as an HTTP server and they also have their own plugins. This could lead to duplicate collections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369418431 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty Http](https://github.com/netty/netty) 4.1.x Review Comment: ```suggestion * [Netty HTTP](https://github.com/netty/netty) 4.1.x ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369419209
##
apm-sniffer/optional-plugins/netty-http-4.1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/http/define/AbstractNettyInstrumentation.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.netty.http.define;
+
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.StaticMethodsInterceptPoint;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassEnhancePluginDefine;
+
+public abstract class AbstractNettyInstrumentation extends
ClassEnhancePluginDefine {
+
+@Override
+public StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() {
+return new StaticMethodsInterceptPoint[0];
+}
+
+@Override
+protected String[] witnessClasses() {
+return new
String[]{"io.netty.handler.codec.compression.SnappyFrameEncoder"};
Review Comment:
Is this witness class for locking 4.x netty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369419603
##
apm-sniffer/optional-plugins/netty-http-4.1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/http/define/AbstractNettyInstrumentation.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.netty.http.define;
+
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.StaticMethodsInterceptPoint;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassEnhancePluginDefine;
+
+public abstract class AbstractNettyInstrumentation extends
ClassEnhancePluginDefine {
+
+@Override
+public StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() {
+return new StaticMethodsInterceptPoint[0];
+}
+
+@Override
+protected String[] witnessClasses() {
+return new
String[]{"io.netty.handler.codec.compression.SnappyFrameEncoder"};
Review Comment:
> Is this witness class for locking 4.x netty?
only 4.1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369420665
##
apm-sniffer/optional-plugins/netty-http-4.1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/http/ChannelPipelineRemoveLastInterceptor.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.netty.http;
+
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelPipeline;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.plugin.netty.http.common.NettyConstants;
+
+import java.lang.reflect.Method;
+
+public class ChannelPipelineRemoveLastInterceptor implements
InstanceMethodsAroundInterceptor {
+
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws
Throwable {
+
+}
+
+@Override
+public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable {
+// if the removed handler is a enhanced handler by skywalking, we call
the method again to remove and return the user handler
Review Comment:
```suggestion
// If the removed handler is enhanced by skywalking, we call the
method again to remove and return the user handler.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369424340 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: ```suggestion * [Netty HTTP](https://github.com/netty/netty) 4.1.x (Optional¹) ``` I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: ```suggestion * [Netty HTTP](https://github.com/netty/netty) 4.1.x (Optional¹) ``` I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369424491 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: And `optional` suffix is required as it is not activated by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Add a component ID for Fiber (ID=5021) (#11450)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 1706020f30 Add a component ID for Fiber (ID=5021) (#11450) 1706020f30 is described below commit 1706020f3035b53f46417e00b7dc2a0b28cae6df Author: Starry AuthorDate: Tue Oct 24 08:36:47 2023 +0800 Add a component ID for Fiber (ID=5021) (#11450) --- docs/en/changes/changes.md | 1 + oap-server/server-starter/src/main/resources/component-libraries.yml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index b20a69ac6a..8f8480031b 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -28,6 +28,7 @@ * Fix AlarmRule expression validation: add labeled metrics mock data for check. * Support collect ZGC memory pool metrics. * Add a component ID for Netty-http (ID=151). +* Add a component ID for Fiber (ID=5021). UI diff --git a/oap-server/server-starter/src/main/resources/component-libraries.yml b/oap-server/server-starter/src/main/resources/component-libraries.yml index 692137430d..1e845ec150 100644 --- a/oap-server/server-starter/src/main/resources/component-libraries.yml +++ b/oap-server/server-starter/src/main/resources/component-libraries.yml @@ -644,6 +644,9 @@ GoFastHttpClient: GoFastHttpServer: id: 5020 language: Golang +Fiber: + id: 5021 + language: Golang # Lua components # [6000, 7000) for Lua agent
Re: [PR] Add a component ID for Fiber [skywalking]
wu-sheng merged PR #11450: URL: https://github.com/apache/skywalking/pull/11450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a component ID for Fiber [skywalking]
wu-sheng commented on PR #11450: URL: https://github.com/apache/skywalking/pull/11450#issuecomment-1776272788 > Ref [apache/skywalking-go#133](https://github.com/apache/skywalking-go/pull/133) @CodePrometheus I updated the comment for you. `@Link` doesn't work well for GitHub. Just paste the URL here, and it will show more friendly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: add support for fiber [skywalking-go]
wu-sheng commented on PR #133: URL: https://github.com/apache/skywalking-go/pull/133#issuecomment-1776274205 ID is registered. Note, we may need another PR on the UI side to represent the server on the topology. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369427405 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. Yes ,it works on the both side. ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. Yes ,it works on the both side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369427531 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. Yes,it works on the both side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369428422 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > (Optional¹)  Is it ok? ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > (Optional¹)  Is it ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369429066 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: It is Optional 2. Optional 1 means having a license incompitable issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369429368 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: The descriptions of Optional 1 and 2 are at the bottom of the doc file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369431092 ## docs/en/setup/service-agent/java-agent/Supported-list.md: ## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: > incompitable I got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a component ID for Fiber [skywalking]
CodePrometheus commented on PR #11450: URL: https://github.com/apache/skywalking/pull/11450#issuecomment-1776306659 Copy that. thx~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: add support for fiber [skywalking-go]
mrproliu commented on PR #133: URL: https://github.com/apache/skywalking-go/pull/133#issuecomment-1776314788 @CodePrometheus Thanks for your contribution. The CI has been failure, please fix it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
peachisai commented on PR #625: URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1776325835 @wu-sheng should i reduce the test version？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a netty-4.1.x plugin to trace http [skywalking-java]
wu-sheng commented on PR #625: URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1776350708 It seems to be fine. Let me check later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.rabbitmq:amqp-client from 5.2.0 to 5.18.0 in /apm-sniffer/apm-sdk-plugin/rabbitmq-plugin [skywalking-java]
dependabot[bot] opened a new pull request, #627: URL: https://github.com/apache/skywalking-java/pull/627 Bumps [com.rabbitmq:amqp-client](https://github.com/rabbitmq/rabbitmq-java-client) from 5.2.0 to 5.18.0. Release notes Sourced from https://github.com/rabbitmq/rabbitmq-java-client/releases";>com.rabbitmq:amqp-client's releases. v5.18.0 Changes between 5.17.0 and 5.18.0 This is a minor release with usability improvements and dependency upgrades. It is compatible with 5.17.x. All users of the 5.x.x series are encouraged to upgrade. Inbound message size is now enforced, with default limit being 64 MiB. Thanks to https://github.com/JHahnHRO";>@JHahnHRO and Sérgio Faria (https://github.com/sergio91pt";>@sergio91pt) for their contribution. Add ability to specify maximum message size GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1062";>#1062 Do not confirmSelect more than once per channel GitHub PR: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1057";>#1057 Make RpcClient (Auto)Closeable GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1032";>#1032 Bump dependencies GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/999";>#999 Dependency MavenGradle compile 'com.rabbitmq:amqp-client:5.18.0' v5.17.1 Changes between 5.17.0 and 5.17.1 This is a minor release with a usability improvement. It is compatible with 5.17.0. Inbound message size is now enforced, with the default limit being 64 MiB. ... (truncated) Commits https://github.com/rabbitmq/rabbitmq-java-client/commit/dcc284ee1b199057a1094055b7eac597539c9942";>dcc284e [maven-release-plugin] prepare release v5.18.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/75d1d1eb2d365f5a8f0fbc1ff5408f3dd706f4ec";>75d1d1e Set release version to 5.18.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/dc7952eaa41feba4c616ffbeb47d99974d16f2dc";>dc7952e Merge pull request https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1064";>#1064 from rabbitmq/dependabot/maven/5.x.x-stable/org.mock... https://github.com/rabbitmq/rabbitmq-java-client/commit/e2fa38f0d8c985a539bdee3a3d40d401a7141a55";>e2fa38f Bump mockito-core from 5.3.1 to 5.4.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/04f1801ae6eaac10af7bf802c8fb7065284624e6";>04f1801 Tweak error message https://github.com/rabbitmq/rabbitmq-java-client/commit/714aae602dcae6cb4b53cadf009323ebac313cc8";>714aae6 Add max inbound message size to ConnectionFactory https://github.com/rabbitmq/rabbitmq-java-client/commit/83cf551fb0142f7a5d042bd54e0cf3c1e47ed419";>83cf551 Fix flaky test https://github.com/rabbitmq/rabbitmq-java-client/commit/0dc9ea2e464158685cd206e35cb52105c156a64c";>0dc9ea2 Do not confirmSelect more than once per channel https://github.com/rabbitmq/rabbitmq-java-client/commit/129dc6abb0cbc36b36cdb6f3d5915f470203277f";>129dc6a Merge pull request https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1060";>#1060 from rabbitmq/dependabot/maven/5.x.x-stable/io.micro... https://github.com/rabbitmq/rabbitmq-java-client/commit/671efdcb1adbed4242ce0c954874eeef0d3de0ad";>671efdc Bump micrometer-core from 1.11.0 to 1.11.1 Additional commits viewable in https://github.com/rabbitmq/rabbitmq-java-client/compare/v5.2.0...v5.18.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually com.rabbitmq amqp-client 5.18.0
[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/com.rabbitmq-amqp-client-5.18.0 created (now 51534990a3)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/com.rabbitmq-amqp-client-5.18.0 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 51534990a3 Bump com.rabbitmq:amqp-client No new revisions were added by this update.
[skywalking-java] branch dependabot/maven/test/plugin/scenarios/rabbitmq-scenario/com.rabbitmq-amqp-client-5.18.0 created (now 4787ab7f56)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/rabbitmq-scenario/com.rabbitmq-amqp-client-5.18.0 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 4787ab7f56 Bump com.rabbitmq:amqp-client No new revisions were added by this update.
[PR] Bump com.rabbitmq:amqp-client from 5.4.0 to 5.18.0 in /test/plugin/scenarios/rabbitmq-scenario [skywalking-java]
dependabot[bot] opened a new pull request, #628: URL: https://github.com/apache/skywalking-java/pull/628 Bumps [com.rabbitmq:amqp-client](https://github.com/rabbitmq/rabbitmq-java-client) from 5.4.0 to 5.18.0. Release notes Sourced from https://github.com/rabbitmq/rabbitmq-java-client/releases";>com.rabbitmq:amqp-client's releases. v5.18.0 Changes between 5.17.0 and 5.18.0 This is a minor release with usability improvements and dependency upgrades. It is compatible with 5.17.x. All users of the 5.x.x series are encouraged to upgrade. Inbound message size is now enforced, with default limit being 64 MiB. Thanks to https://github.com/JHahnHRO";>@JHahnHRO and Sérgio Faria (https://github.com/sergio91pt";>@sergio91pt) for their contribution. Add ability to specify maximum message size GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1062";>#1062 Do not confirmSelect more than once per channel GitHub PR: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1057";>#1057 Make RpcClient (Auto)Closeable GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1032";>#1032 Bump dependencies GitHub issue: https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/999";>#999 Dependency MavenGradle compile 'com.rabbitmq:amqp-client:5.18.0' v5.17.1 Changes between 5.17.0 and 5.17.1 This is a minor release with a usability improvement. It is compatible with 5.17.0. Inbound message size is now enforced, with the default limit being 64 MiB. ... (truncated) Commits https://github.com/rabbitmq/rabbitmq-java-client/commit/dcc284ee1b199057a1094055b7eac597539c9942";>dcc284e [maven-release-plugin] prepare release v5.18.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/75d1d1eb2d365f5a8f0fbc1ff5408f3dd706f4ec";>75d1d1e Set release version to 5.18.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/dc7952eaa41feba4c616ffbeb47d99974d16f2dc";>dc7952e Merge pull request https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1064";>#1064 from rabbitmq/dependabot/maven/5.x.x-stable/org.mock... https://github.com/rabbitmq/rabbitmq-java-client/commit/e2fa38f0d8c985a539bdee3a3d40d401a7141a55";>e2fa38f Bump mockito-core from 5.3.1 to 5.4.0 https://github.com/rabbitmq/rabbitmq-java-client/commit/04f1801ae6eaac10af7bf802c8fb7065284624e6";>04f1801 Tweak error message https://github.com/rabbitmq/rabbitmq-java-client/commit/714aae602dcae6cb4b53cadf009323ebac313cc8";>714aae6 Add max inbound message size to ConnectionFactory https://github.com/rabbitmq/rabbitmq-java-client/commit/83cf551fb0142f7a5d042bd54e0cf3c1e47ed419";>83cf551 Fix flaky test https://github.com/rabbitmq/rabbitmq-java-client/commit/0dc9ea2e464158685cd206e35cb52105c156a64c";>0dc9ea2 Do not confirmSelect more than once per channel https://github.com/rabbitmq/rabbitmq-java-client/commit/129dc6abb0cbc36b36cdb6f3d5915f470203277f";>129dc6a Merge pull request https://redirect.github.com/rabbitmq/rabbitmq-java-client/issues/1060";>#1060 from rabbitmq/dependabot/maven/5.x.x-stable/io.micro... https://github.com/rabbitmq/rabbitmq-java-client/commit/671efdcb1adbed4242ce0c954874eeef0d3de0ad";>671efdc Bump micrometer-core from 1.11.0 to 1.11.1 Additional commits viewable in https://github.com/rabbitmq/rabbitmq-java-client/compare/v5.4.0...v5.18.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually com.rabbitmq amqp-client 5.18.0
Re: [PR] Bump com.rabbitmq:amqp-client from 5.4.0 to 5.18.0 in /test/plugin/scenarios/rabbitmq-scenario [skywalking-java]
wu-sheng closed pull request #628: Bump com.rabbitmq:amqp-client from 5.4.0 to 5.18.0 in /test/plugin/scenarios/rabbitmq-scenario URL: https://github.com/apache/skywalking-java/pull/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.rabbitmq:amqp-client from 5.4.0 to 5.18.0 in /test/plugin/scenarios/rabbitmq-scenario [skywalking-java]
dependabot[bot] commented on PR #628: URL: https://github.com/apache/skywalking-java/pull/628#issuecomment-1776365566 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.rabbitmq:amqp-client from 5.2.0 to 5.18.0 in /apm-sniffer/apm-sdk-plugin/rabbitmq-plugin [skywalking-java]
wu-sheng closed pull request #627: Bump com.rabbitmq:amqp-client from 5.2.0 to 5.18.0 in /apm-sniffer/apm-sdk-plugin/rabbitmq-plugin URL: https://github.com/apache/skywalking-java/pull/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.rabbitmq:amqp-client from 5.2.0 to 5.18.0 in /apm-sniffer/apm-sdk-plugin/rabbitmq-plugin [skywalking-java]
dependabot[bot] commented on PR #627: URL: https://github.com/apache/skywalking-java/pull/627#issuecomment-1776365625 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-java] branch dependabot/maven/test/plugin/scenarios/rabbitmq-scenario/com.rabbitmq-amqp-client-5.18.0 deleted (was 4787ab7f56)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/test/plugin/scenarios/rabbitmq-scenario/com.rabbitmq-amqp-client-5.18.0 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was 4787ab7f56 Bump com.rabbitmq:amqp-client The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/com.rabbitmq-amqp-client-5.18.0 deleted (was 51534990a3)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/com.rabbitmq-amqp-client-5.18.0 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was 51534990a3 Bump com.rabbitmq:amqp-client The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[PR] feat: support setting a discard type of reporter [skywalking-go]
LinuxSuRen opened a new pull request, #134: URL: https://github.com/apache/skywalking-go/pull/134 As mentioned in the title, users could discard the report data via environment variable setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: support setting a discard type of reporter [skywalking-go]
LinuxSuRen commented on code in PR #134: URL: https://github.com/apache/skywalking-go/pull/134#discussion_r1369470116 ## tools/go-agent/Makefile: ## @@ -51,4 +51,4 @@ build: linux darwin windows .PHONY: $(PLATFORMS) $(PLATFORMS): mkdir -p $(OUT_DIR) - GOOS=$(os) GOARCH=$(ARCH) $(GO_BUILD) $(GO_BUILD_FLAGS) -ldflags "$(GO_BUILD_LDFLAGS)" -o $(OUT_DIR)/$(BINARY)-$(VERSION)-$(os)-$(ARCH) ./cmd + CGO_ENABLED=0 GOOS=$(os) GOARCH=$(ARCH) $(GO_BUILD) $(GO_BUILD_FLAGS) -ldflags "$(GO_BUILD_LDFLAGS)" -o $(OUT_DIR)/$(BINARY)-$(VERSION)-$(os)-$(ARCH) ./cmd Review Comment: Will occur the `GLIC` relevant issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: support setting a discard type of reporter [skywalking-go]
mrproliu commented on PR #134: URL: https://github.com/apache/skywalking-go/pull/134#issuecomment-1776400058 Can you provide more scenarios to illustrate when users need to use it? If they don't need to collect data and can perform operations during compilation, it will result in better performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: support setting a discard type of reporter [skywalking-go]
LinuxSuRen commented on PR #134: URL: https://github.com/apache/skywalking-go/pull/134#issuecomment-1776406572 There are two important reason. * Considering SkyWalking is not a MUST component all the time. I don't expect that it prints error logs when no SkyWalking installed. * Maintaining the double number of binary files is an annoying thing. Let's assume one project has different binary files against Windows, Linux, macOS. If there is no such switch to turn off reporting, then users need to publish 6 packages everytime instead of 3. Even wrose if arm64 is required, users might need to mtaintain 12 packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update the release documentation for the toolkit [skywalking-go]
mrproliu merged PR #132: URL: https://github.com/apache/skywalking-go/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-go] branch main updated: Update the release documentation for the toolkit (#132)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 56cdeb9 Update the release documentation for the toolkit (#132) 56cdeb9 is described below commit 56cdeb95566e9141be798668267c6da153e4049c Author: mrproliu <741550...@qq.com> AuthorDate: Tue Oct 24 10:51:48 2023 +0800 Update the release documentation for the toolkit (#132) --- docs/en/development-and-contribution/how-to-release.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/en/development-and-contribution/how-to-release.md b/docs/en/development-and-contribution/how-to-release.md index f694a1b..b9cb78e 100644 --- a/docs/en/development-and-contribution/how-to-release.md +++ b/docs/en/development-and-contribution/how-to-release.md @@ -22,6 +22,7 @@ This documentation guides the release manager to release the SkyWalking Go in th export VERSION= git clone g...@github.com:apache/skywalking-go && cd skywalking-go git tag -a "v$VERSION" -m "Release Apache SkyWalking-Go v$VERSION" +git tag -a "toolkit/v$VERSION" -m "Release Apache SkyWalking-Go Toolkit v$VERSION" git push --tags make release ```
Re: [PR] Update toolkit-trace.md [skywalking-go]
Ecostack commented on code in PR #131: URL: https://github.com/apache/skywalking-go/pull/131#discussion_r1369610298 ## docs/en/advanced-features/manual-apis/toolkit-trace.md: ## @@ -60,9 +60,9 @@ trace.StopSpan() ### Add Span’s Tag and Log -Use `trace.SetLog` to record log in span. +Use `trace.SetLog()` to record log in span. -Use `trace.SetTag` to add tag to span, the parameters of tag are two String which are key and value respectively. +Use `trace.SetTag()` to add tag to span, the parameters of tag are two String which are key and value respectively. Review Comment: Indeed, just changed it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: support setting a discard type of reporter [skywalking-go]
mrproliu merged PR #134: URL: https://github.com/apache/skywalking-go/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-go] branch main updated: feat: support setting a discard type of reporter (#134)
This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git
The following commit(s) were added to refs/heads/main by this push:
new ea728c7 feat: support setting a discard type of reporter (#134)
ea728c7 is described below
commit ea728c7d8ab60144c7ac562dec32bad95cbd8850
Author: Rick <1450685+linuxsu...@users.noreply.github.com>
AuthorDate: Tue Oct 24 12:37:56 2023 +0800
feat: support setting a discard type of reporter (#134)
---
.github/workflows/plugin-tests.yaml| 1 +
CHANGES.md | 1 +
docs/en/agent/plugin-configurations.md | 1 +
plugins/core/reporter/discard_reporter.go | 46 +
plugins/core/reporter/discard_reporter_test.go | 38 ++
.../{grpc => discard-reporter}/bin/startup.sh | 27 ++
.../config/excepted.yml} | 28 +--
test/plugins/scenarios/discard-reporter/go.mod | 3 ++
test/plugins/scenarios/discard-reporter/go.sum | 0
test/plugins/scenarios/discard-reporter/main.go| 58 ++
.../bin/startup.sh => discard-reporter/plugin.yml} | 37 --
test/plugins/scenarios/grpc/bin/startup.sh | 4 +-
tools/go-agent/Makefile| 2 +-
tools/go-agent/config/agent.default.yaml | 1 +
tools/go-agent/config/loader.go| 3 +-
tools/go-agent/instrument/reporter/instrument.go | 3 ++
16 files changed, 173 insertions(+), 80 deletions(-)
diff --git a/.github/workflows/plugin-tests.yaml
b/.github/workflows/plugin-tests.yaml
index bb25241..bb747ea 100644
--- a/.github/workflows/plugin-tests.yaml
+++ b/.github/workflows/plugin-tests.yaml
@@ -89,6 +89,7 @@ jobs:
- irisv12
- trace-activation
- fasthttp
+ - discard-reporter
steps:
- uses: actions/checkout@v2
with:
diff --git a/CHANGES.md b/CHANGES.md
index f2c7283..81056e9 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -7,6 +7,7 @@ Release Notes.
Features
Plugins
+* Support setting a discard type of reporter.
Documentation
diff --git a/docs/en/agent/plugin-configurations.md
b/docs/en/agent/plugin-configurations.md
index 088dd89..b68fbb1 100644
--- a/docs/en/agent/plugin-configurations.md
+++ b/docs/en/agent/plugin-configurations.md
@@ -5,3 +5,4 @@
| http.server_collect_parameters |
SW_AGENT_PLUGIN_CONFIG_HTTP_SERVER_COLLECT_PARAMETERS | false | Collect
the parameters of the HTTP request on the server side. |
| mongo.collect_statement|
SW_AGENT_PLUGIN_CONFIG_MONGO_COLLECT_STATEMENT| false | Collect
the statement of the MongoDB request. |
| sql.collect_parameter |
SW_AGENT_PLUGIN_CONFIG_SQL_COLLECT_PARAMETER | false | Collect
the parameter of the SQL request. |
+| reporter.discard | SW_AGENT_REPORTER_DISCARD
| false | Discard the reporter.
|
diff --git a/plugins/core/reporter/discard_reporter.go
b/plugins/core/reporter/discard_reporter.go
new file mode 100644
index 000..3531d46
--- /dev/null
+++ b/plugins/core/reporter/discard_reporter.go
@@ -0,0 +1,46 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package reporter
+
+import logv3 "skywalking.apache.org/repo/goapi/collect/logging/v3"
+
+type discardReporter struct{}
+
+func NewDiscardReporter() Reporter {
+ return &discardReporter{}
+}
+
+func (r *discardReporter) Boot(entity *Entity, cdsWatchers
[]AgentConfigChangeWatcher) {
+ // do nothing
+}
+func (r *discardReporter) SendTracing(spans []ReportedSpan) {
+ // do nothing
+}
+func (r *discardReporter) SendMetrics(metrics []ReportedMeter) {
+ // do nothing
+}
+func (r *discardReporter) SendLog(log *logv3.LogData) {
+ // do nothing
+}
+func (r *discardReporter) ConnectionStatus() ConnectionStatus {
+ // do nothing
+ return 0
+}
+func (r *discardReporter) Close() {
+ // do n
