[PATCH 1/3] Add radio settings atom and driver API
This interface exposes a rw property for radio access selection mode
setting.
---
Makefile.am|6 +-
doc/radio-settings-api.txt | 42 +
include/radio-settings.h | 74 +
src/ofono.h|2 +
src/radio-settings.c | 372
5 files changed, 494 insertions(+), 2 deletions(-)
create mode 100644 doc/radio-settings-api.txt
create mode 100644 include/radio-settings.h
create mode 100644 src/radio-settings.c
diff --git a/Makefile.am b/Makefile.am
index 9df..672ce0b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -11,7 +11,8 @@ include_HEADERS = include/log.h include/plugin.h
include/history.h \
include/sms.h include/sim.h include/message-waiting.h \
include/netreg.h include/voicecall.h include/devinfo.h \
include/cbs.h include/call-volume.h \
- include/gprs.h include/gprs-context.h
+ include/gprs.h include/gprs-context.h \
+ include/radio-settings.h
nodist_include_HEADERS = include/version.h
@@ -224,7 +225,8 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) \
src/phonebook.c src/history.c src/message-waiting.c \
src/simutil.h src/simutil.c src/storage.h \
src/storage.c src/cbs.c src/watch.c src/call-volume.c \
- src/gprs.c src/idmap.h src/idmap.c
+ src/gprs.c src/idmap.h src/idmap.c \
+ src/radio-settings.c
src_ofonod_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ -ldl
diff --git a/doc/radio-settings-api.txt b/doc/radio-settings-api.txt
new file mode 100644
index 000..c36b574
--- /dev/null
+++ b/doc/radio-settings-api.txt
@@ -0,0 +1,42 @@
+Radio Settings hierarchy
+
+
+Serviceorg.ofono
+Interface org.ofono.RadioSettings
+Object path[variable prefix]/{modem0,modem1,...}
+
+Methodsdict GetProperties()
+
+ Returns all radio access properties. See the
+ properties section for available properties.
+
+ Possible Errors: [service].Error.InvalidArguments
+
+ void SetProperty(string name, variant value)
+
+ Changes the value of the specified property. Only
+ properties that are listed as read-write are
+ changeable. On success a PropertyChanged signal
+ will be emitted.
+
+ Possible Errors: [service].Error.InvalidArguments
+[service].Error.DoesNotExist
+[service].Error.InProgress
+
+SignalsPropertyChanged(string property, variant value)
+
+ This signal indicates a changed value of the given
+ property.
+
+Properties string Mode [read-write]
+
+ The current radio access selection mode, also known
+ as network preference.
+
+ The possible values are:
+ "dual" Radio access selection is done
+ automatically, using either 2G
+ or 3G, depending on reception.
+ "2g" Only GSM used for radio access.
+ "3g" Only UTRAN used for radio access.
+ "unknown" Mode currently unknown.
diff --git a/include/radio-settings.h b/include/radio-settings.h
new file mode 100644
index 000..807d3da
--- /dev/null
+++ b/include/radio-settings.h
@@ -0,0 +1,74 @@
+/*
+ *
+ * oFono - Open Source Telephony
+ *
+ * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ */
+
+#ifndef __OFONO_RADIO_SETTINGS_H
+#define __OFONO_RADIO_SETTINGS_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include
+
+enum ofono_radio_access_mode {
+ OFONO_RADIO_ACCESS_MODE_DUAL = 0,
+ OFONO_RADIO_ACCESS_MODE_2G = 1,
+ OFONO_RADIO_ACCESS_MODE_3G = 2,
+};
+
+struct ofono_radio_settings;
+
+typedef void
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Aki, > +Properties string Mode [read-write] > + > + The current radio access selection mode, also known > + as network preference. > + > + The possible values are: > + "dual" Radio access selection is done > +automatically, using either 2G > +or 3G, depending on reception. > + "2g" Only GSM used for radio access. > + "3g" Only UTRAN used for radio access. > + "unknown" Mode currently unknown. how would we be dealing with LTE here. The word "dual" is kinda tricky in that sense. Also what about chips like Qualcomm GOBI that can change their firmware and start operating in CDMA. We do wanna extend oFono to support CDMA at some point. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Aki, > > > +Propertiesstring Mode [read-write] > > > + > > > +The current radio access selection mode, also known > > > +as network preference. > > > + > > > +The possible values are: > > > +"dual"Radio access selection is done > > > +automatically, using either 2G > > > +or 3G, depending on reception. > > > +"2g"Only GSM used for radio access. > > > +"3g"Only UTRAN used for radio access. > > > +"unknown" Mode currently unknown. > > > > how would we be dealing with LTE here. The word "dual" is kinda tricky > > in that sense. Also what about chips like Qualcomm GOBI that can change > > their firmware and start operating in CDMA. We do wanna extend oFono to > > support CDMA at some point. > > Yeah, perhaps the property should be called "TechnologyPreference" with > values "any", "2G", "3G", "4G". For now at least. so what about the magic CDMA + UMTS combo chips. We basically have to reload the firmware with these. Would be nice to figure out on how that can be done. Not that we know much about how Qualcomm intends to use that in a phone case scenario, but would be nice to at least think about it a bit. Also I wanted you to ask about the data roaming. Does the Nokia modem has an option to NOT data roam that we can set. The problem with doing it in the host is that a bit of data goes through if you start roaming and have a PDP context active. So it costs the user. At least some reports indicate this. Does your modem forces a detach or does it just happily data roam and just give us a cell update? The AT command specification obviously didn't care about this at all :( Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
- Alkuperäinen viesti - > > Yeah, perhaps the property should be called "TechnologyPreference" with > > values > > "any", "2G", "3G", "4G". For now at least. > > so what about the magic CDMA + UMTS combo chips. We basically have to > reload the firmware with these. Would be nice to figure out on how that > can be done. Not that we know much about how Qualcomm intends to use > that in a phone case scenario, but would be nice to at least think about > it a bit. I'm not at all sure toggling between CDMA and UMTS is going to work smoothly enough for it to be done at this interface level. It sounds more like disabling one modem and enabling another. And I'm sure there are other areas in the API that are going to need tweaking for CDMA. I would rather cross that bridge when we come to it. > Also I wanted you to ask about the data roaming. Does the Nokia modem > has an option to NOT data roam that we can set. The problem with doing > it in the host is that a bit of data goes through if you start roaming > and have a PDP context active. So it costs the user. At least some > reports indicate this. Does your modem forces a detach or does it just > happily data roam and just give us a cell update? You mean PDP contexts survive a network change? I don't think they do. Sounds like a bug in the application. The Nokia modems have a setting to automatically attach, but that doesn't yet move any data. Cheers, Aki -- Sent from Nokia N900 running Maemo 5 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Aki, > > > Yeah, perhaps the property should be called "TechnologyPreference" with > > > values > > > "any", "2G", "3G", "4G". For now at least. > > > > so what about the magic CDMA + UMTS combo chips. We basically have to > > reload the firmware with these. Would be nice to figure out on how that > > can be done. Not that we know much about how Qualcomm intends to use > > that in a phone case scenario, but would be nice to at least think about > > it a bit. > > I'm not at all sure toggling between CDMA and UMTS is going to work smoothly > enough for it to be done at this interface level. It sounds more like > disabling one modem and enabling another. And I'm sure there are other areas > in the API that are going to need tweaking for CDMA. I would rather cross > that bridge when we come to it. fair enough from my point of view, but lets keep that in mind. The hardware for that is out there. > > Also I wanted you to ask about the data roaming. Does the Nokia modem > > has an option to NOT data roam that we can set. The problem with doing > > it in the host is that a bit of data goes through if you start roaming > > and have a PDP context active. So it costs the user. At least some > > reports indicate this. Does your modem forces a detach or does it just > > happily data roam and just give us a cell update? > > You mean PDP contexts survive a network change? I don't think they do. Sounds > like a bug in the application. > > The Nokia modems have a setting to automatically attach, but that doesn't yet > move any data. That is what T-Mobile promises me when crossing borders into Netherlands or Austria with my German SIM card. It should have smooth data roaming. To be honest, I have never really tried it. Either I was on a plane anymore or too cheap to pay for data roaming ;) Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Aki,
> This interface exposes a rw property for radio access selection mode
> setting.
> ---
> Makefile.am|6 +-
> doc/radio-settings-api.txt | 42 +
> include/radio-settings.h | 74 +
> src/ofono.h|2 +
> src/radio-settings.c | 372
> 5 files changed, 494
> insertions(+), 2 deletions(-)
> create mode 100644 doc/radio-settings-api.txt
> create mode 100644 include/radio-settings.h
> create mode 100644 src/radio-settings.c
> +Properties string Mode [read-write]
Per mailing list thread with Marcel, "Technology" or "TechnologySelection" or
"TechnologyPreference" will be better here.
> +
> + The current radio access selection mode, also known
> + as network preference.
> +
> + The possible values are:
> + "dual" Radio access selection is done
> +automatically, using either 2G
> +or 3G, depending on reception.
As discussed in later threads, I do like "auto" or "any" here.
> + "2g" Only GSM used for radio access.
> + "3g" Only UTRAN used for radio access.
> + "unknown" Mode currently unknown.
Lets get rid of the "unknown" part, we always know the setting, even if it
takes a little time to query it.
> diff --git a/include/radio-settings.h b/include/radio-settings.h
> new file mode 100644
> index 000..807d3da
> +typedef void (*ofono_radio_settings_mode_query_cb_t)(const struct
> ofono_error *error, +enum
> ofono_radio_access_mode mode,
> + void *data);
I still say this part is not required.
> +
> +struct ofono_radio_settings_driver {
> + const char *name;
> + int (*probe)(struct ofono_radio_settings *rs, unsigned int vendor, void
> *data); +void (*remove)(struct ofono_radio_settings *rs);
> + void (*query_mode)(struct ofono_radio_settings *rs,
> + ofono_radio_settings_mode_query_cb_t cb, void
> *data);
Neither is query_mode. This is a local modem setting, not a network setting.
There's simply no reason to query it when oFono can store the settings.
Lets just add ability to read the mode setting from storage and set it at
interface startup.
> + void (*set_mode)(struct ofono_radio_settings *rs,
> + enum ofono_radio_access_mode mode,
> + ofono_radio_settings_mode_set_cb_t cb, void
> *data);
Should this be called something else? E.g. set_technology or set_rat_mode.
> +};
> +
> diff --git a/src/ofono.h b/src/ofono.h
> index 379f413..ff67728 100644
> --- a/src/ofono.h
> +++ b/src/ofono.h
> @@ -113,6 +113,7 @@ enum ofono_atom_type {
> OFONO_ATOM_TYPES_CALL_VOLUME = 15,
> OFONO_ATOM_TYPE_GPRS = 16,
> OFONO_ATOM_TYPE_GPRS_CONTEXT = 17,
> + OFONO_ATOM_TYPE_RADIO_SETTINGS = 18,
> };
>
> enum ofono_atom_watch_condition {
> @@ -168,6 +169,7 @@ void __ofono_atom_free(struct ofono_atom *atom);
> #include
> #include
> #include
> +#include
>
> #include
>
> diff --git a/src/radio-settings.c b/src/radio-settings.c
> new file mode 100644
> index 000..6e41194
> --- /dev/null
> +++ b/src/radio-settings.c
> +#define RADIO_SETTINGS_INTERFACE "org.ofono.RadioSettings"
> +#define RADIO_SETTINGS_INTERFACE "org.ofono.RadioSettings"
> +
Double define?
Otherwise it looks good to me.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Denis,
2010/2/4 Denis Kenzior :
>> +typedef void (*ofono_radio_settings_mode_query_cb_t)(const struct
>> ofono_error *error, + enum
>> ofono_radio_access_mode mode,
>> + void *data);
>
> I still say this part is not required.
>
>> +
>> +struct ofono_radio_settings_driver {
>> + const char *name;
>> + int (*probe)(struct ofono_radio_settings *rs, unsigned int vendor, void
>> *data); + void (*remove)(struct ofono_radio_settings *rs);
>> + void (*query_mode)(struct ofono_radio_settings *rs,
>> + ofono_radio_settings_mode_query_cb_t cb, void
>> *data);
>
> Neither is query_mode. This is a local modem setting, not a network setting.
> There's simply no reason to query it when oFono can store the settings.
Even with storage, it's needed the very first time a new SIM card is
inserted, no?
> Lets just add ability to read the mode setting from storage and set it at
> interface startup.
I can agreee to storing SIM data, but for other settings that are
anyway saved on the modem's non-volatile memory, this seems wrong.
oFono is aimed to be usable also on the desktop using tethering, which
means most of the time these settings are touched on the phone.
(As an aside, I have right now two N900s connected to my laptop via
USB, and was just making calls between them using oFono and d-feet.)
>> + void (*set_mode)(struct ofono_radio_settings *rs,
>> + enum ofono_radio_access_mode mode,
>> + ofono_radio_settings_mode_set_cb_t cb, void
>> *data);
>
> Should this be called something else? E.g. set_technology or set_rat_mode.
Makes sense.
>> +#define RADIO_SETTINGS_INTERFACE "org.ofono.RadioSettings"
>> +#define RADIO_SETTINGS_INTERFACE "org.ofono.RadioSettings"
>> +
>
> Double define?
Too much coffee.
> Otherwise it looks good to me.
Cool. I will make the changes and push in a bit.
Cheers,
Aki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Re: [PATCH 1/3] Add radio settings atom and driver API
Hi Aki,
> Hi Denis,
>
> 2010/2/4 Denis Kenzior :
> >> +typedef void (*ofono_radio_settings_mode_query_cb_t)(const struct
> >> ofono_error *error, +
> >> enum ofono_radio_access_mode mode, +
> >> void *data);
> >
> > I still say this part is not required.
> >
> >> +
> >> +struct ofono_radio_settings_driver {
> >> + const char *name;
> >> + int (*probe)(struct ofono_radio_settings *rs, unsigned int vendor,
> >> void *data); +void (*remove)(struct ofono_radio_settings *rs);
> >> + void (*query_mode)(struct ofono_radio_settings *rs,
> >> + ofono_radio_settings_mode_query_cb_t cb,
> >> void *data);
> >
> > Neither is query_mode. This is a local modem setting, not a network
> > setting. There's simply no reason to query it when oFono can store the
> > settings.
>
> Even with storage, it's needed the very first time a new SIM card is
> inserted, no?
>
Not really, we can default to a safe setting (e.g. any) if no previous setting
has been saved. We do this for GPRS, Cell Broadcasts, etc.
> > Lets just add ability to read the mode setting from storage and set it at
> > interface startup.
>
> I can agreee to storing SIM data, but for other settings that are
> anyway saved on the modem's non-volatile memory, this seems wrong.
> oFono is aimed to be usable also on the desktop using tethering, which
> means most of the time these settings are touched on the phone.
But also remember I want to keep all my settings when I switch SIMs. On the
desktop that is a much likelier scenario (e.g. GPRS data cards), travel
between countries, etc. The radio access setting is likely to be specific to a
network provider (e.g. poor 3G coverage) rather than the device.
I agree tethering is a usecase we haven't considered properly yet, but
honestly I'm not sure the PC should be messing with radio preference settings
while tethered...
>
> (As an aside, I have right now two N900s connected to my laptop via
> USB, and was just making calls between them using oFono and d-feet.)
>
Nice :)
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
