[okular] [Bug 375719] Blue rendering artifacts in Okular with "draw border around links" turned on
https://bugs.kde.org/show_bug.cgi?id=375719 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/oku ||lar/af6e9a9b0b7998aeb5bf2a9 ||02916f4bba9cc8d71 --- Comment #3 from Albert Astals Cid --- Git commit af6e9a9b0b7998aeb5bf2a902916f4bba9cc8d71 by Albert Astals Cid. Committed on 01/02/2017 at 23:26. Pushed by aacid into branch 'Applications/16.12'. Fix rendering artifacts in Okular with "draw border around links" turned on Qt5 changed the default QPen to not be cosmetic, so we need to specify we want it to be cosmetic M +1-1ui/pagepainter.cpp M +2-2ui/pagepainter.h https://commits.kde.org/okular/af6e9a9b0b7998aeb5bf2a902916f4bba9cc8d71 -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Feb. 1, 2017, 11:20 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Rebased on current master Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs (updated) - core/document.h 1fd86262 core/document.cpp 41b9ddfe ui/searchlineedit.cpp baac8be0 Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing --- Thanks, Elvis Angelaccio
[okular] [Bug 375755] Thumbnails filter acts like "find"
https://bugs.kde.org/show_bug.cgi?id=375755 --- Comment #9 from Albert Astals Cid --- @thekswenson: If you're able to reproduce it reliably please open a new bug about it. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129909: Fix reading comicbooks in zip format
> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using. > > Eugene Shalygin wrote: > I do have this problem for quite some time already (for a year, perhaps). > The versions are 5.8.0 for Qt and Git master for KF5. > Could you check whether the QIODevice from KArchiveFile::createDevice() > is seekable in your case, please? > > Eugene Shalygin wrote: > I was wrong abou that. What seems to be important is that when > `QIODevice::size()` returns 0, `QImageLoader` refuses to detect format. The > patch has been corrected. > > Eugene Shalygin wrote: > Actually, the thing is even simpler: QIODevice::seek() does not work with > the `dev` object in my case. result of KArchiveFile::createDevice() for ZIP archives behaves strangely in other cases on my system. I will investigate. - Eugene --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 --- On Лют. 1, 2017, 4:44 після полудня, Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > --- > > (Updated Лют. 1, 2017, 4:44 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` reports its size to be 0 and because of that > `QImageReader` refuses to read. Proposed solution: if that device's > `QIODevice::size()` returns 0, copy its content into a temporary file and > load image from the file. > > > Diffs > - > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > --- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
[okular] [Bug 375755] Thumbnails filter acts like "find"
https://bugs.kde.org/show_bug.cgi?id=375755 --- Comment #8 from Oliver Sander --- I confirm that Albert's patch fixed the problem for me. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129909: Fix reading comicbooks in zip format
> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using. > > Eugene Shalygin wrote: > I do have this problem for quite some time already (for a year, perhaps). > The versions are 5.8.0 for Qt and Git master for KF5. > Could you check whether the QIODevice from KArchiveFile::createDevice() > is seekable in your case, please? > > Eugene Shalygin wrote: > I was wrong abou that. What seems to be important is that when > `QIODevice::size()` returns 0, `QImageLoader` refuses to detect format. The > patch has been corrected. Actually, the thing is even simpler: QIODevice::seek() does not work with the `dev` object in my case. - Eugene --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 --- On Лют. 1, 2017, 4:44 після полудня, Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > --- > > (Updated Лют. 1, 2017, 4:44 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` reports its size to be 0 and because of that > `QImageReader` refuses to read. Proposed solution: if that device's > `QIODevice::size()` returns 0, copy its content into a temporary file and > load image from the file. > > > Diffs > - > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > --- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
[okular] [Bug 375755] Thumbnails filter acts like "find"
https://bugs.kde.org/show_bug.cgi?id=375755 --- Comment #7 from thekswen...@gmail.com --- The problem occurs even when I do NOT press enter. Under as-yet unknown circumstances, typing any string into the filter bar will not filter the pages and will not find a single occurrence of the string. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ --- (Updated Лют. 1, 2017, 4:44 після полудня) Review request for Okular and Albert Astals Cid. Repository: okular Description (updated) --- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` reports its size to be 0 and because of that `QImageReader` refuses to read. Proposed solution: if that device's `QIODevice::size()` returns 0, copy its content into a temporary file and load image from the file. Diffs - generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing --- Well, it loads .cbr files now :) Thanks, Eugene Shalygin
[okular] [Bug 374133] Okular no longer opens comic book format
https://bugs.kde.org/show_bug.cgi?id=374133 --- Comment #13 from Wolfgang Bauer --- (In reply to Albert Astals Cid from comment #12) > Wolfgang which Qt and KArchive are you using? Qt 5.7.1 and karchive 5.30. Also tried with Qt 5.8.0, the same problem. I also tried other distributions last week using LiveCDs: - openSUSE Tumbleweed (20170123) with Qt 5.7.1 and karchive 5.29 - KDE Neon user edition (20170119-0019) - KDE Neon developer edition (20170125-0806) This was reproducible everywhere. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ --- (Updated Лют. 1, 2017, 4:12 після полудня) Review request for Okular and Albert Astals Cid. Repository: okular Description (updated) --- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` reports its size to be 0 and because of that `QImageLoader` refuses to read. Proposed solution: if that device's `QIODevice::size()` returns 0, copy its content into a temporary file and load image from the file. Diffs - generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing --- Well, it loads .cbr files now :) Thanks, Eugene Shalygin
Re: Review Request 129909: Fix reading comicbooks in zip format
> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using. > > Eugene Shalygin wrote: > I do have this problem for quite some time already (for a year, perhaps). > The versions are 5.8.0 for Qt and Git master for KF5. > Could you check whether the QIODevice from KArchiveFile::createDevice() > is seekable in your case, please? I was wrong abou that. What seems to be important is that when `QIODevice::size()` returns 0, `QImageLoader` refuses to detect format. The patch has been corrected. - Eugene --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 --- On Лют. 1, 2017, 4:02 після полудня, Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > --- > > (Updated Лют. 1, 2017, 4:02 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` is not seekable and because of that > `QImageLoader` can't detect image format. Proposed solution: if that device > is not seekable or `QIODevice::size()` returns 0, copy its content into a > temporary file and load image from it. > > > Diffs > - > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > --- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
Re: Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ --- (Updated Лют. 1, 2017, 4:02 після полудня) Review request for Okular and Albert Astals Cid. Changes --- The correct trigger which makes QImageLoader fail, is QIODevice::size() == 0 Repository: okular Description --- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` is not seekable and because of that `QImageLoader` can't detect image format. Proposed solution: if that device is not seekable or `QIODevice::size()` returns 0, copy its content into a temporary file and load image from it. Diffs (updated) - generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing --- Well, it loads .cbr files now :) Thanks, Eugene Shalygin
Re: Review Request 129909: Fix reading comicbooks in zip format
> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using. I do have this problem for quite some time already (for a year, perhaps). The versions are 5.8.0 for Qt and Git master for KF5. Could you check whether the QIODevice from KArchiveFile::createDevice() is seekable in your case, please? - Eugene --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 --- On Лют. 1, 2017, 1:56 після полудня, Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > --- > > (Updated Лют. 1, 2017, 1:56 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` is not seekable and because of that > `QImageLoader` can't detect image format. Proposed solution: if that device > is not seekable or `QIODevice::size()` returns 0, copy its content into a > temporary file and load image from it. > > > Diffs > - > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > --- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
Re: Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 --- This works fine for me without your patch, so it's either that you use too old versions and the new ones are fixed or that i use too old versions and the new one has regressed. Which KF5/Qt5 versions are you using. - Albert Astals Cid On Feb. 1, 2017, 12:56 p.m., Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > --- > > (Updated Feb. 1, 2017, 12:56 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` is not seekable and because of that > `QImageLoader` can't detect image format. Proposed solution: if that device > is not seekable or `QIODevice::size()` returns 0, copy its content into a > temporary file and load image from it. > > > Diffs > - > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > --- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
Re: Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ --- (Updated Лют. 1, 2017, 1:56 після полудня) Review request for Okular and Albert Astals Cid. Changes --- file opening was under Q_ASSERT Repository: okular Description --- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` is not seekable and because of that `QImageLoader` can't detect image format. Proposed solution: if that device is not seekable or `QIODevice::size()` returns 0, copy its content into a temporary file and load image from it. Diffs (updated) - generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing --- Well, it loads .cbr files now :) Thanks, Eugene Shalygin
Review Request 129909: Fix reading comicbooks in zip format
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ --- Review request for Okular and Albert Astals Cid. Repository: okular Description --- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` is not seekable and because of that `QImageLoader` can't detect image format. Proposed solution: if that device is not seekable or `QIODevice::size()` returns 0, copy its content into a temporary file and load image from it. Diffs - generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing --- Well, it loads .cbr files now :) Thanks, Eugene Shalygin
