Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Sept. 26, 2017, 9:28 p.m.) Status -- This change has been marked as submitted. Review request for Okular, KDE Usability and Albert Astals Cid. Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs - core/document.cpp 91c623b58d1d98e11afdce73bc3f1f68becd657c ui/searchlineedit.cpp 74e6ef60c06c2d4e0b30be1eb6804545f58bd8eb Diff: https://git.reviewboard.kde.org/r/129893/diff/4/ Testing --- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. File Attachments Before: dialog asks if the search should continue from the beginning. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png After: always continue search from beginning, with a non-intrusive notification. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png Thanks, Elvis Angelaccio
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Sept. 26, 2017, 8:42 p.m.) Review request for Okular, KDE Usability and Albert Astals Cid. Changes --- Removed the roundtrip core->ui->core Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs (updated) - core/document.cpp 91c623b58d1d98e11afdce73bc3f1f68becd657c ui/searchlineedit.cpp 74e6ef60c06c2d4e0b30be1eb6804545f58bd8eb Diff: https://git.reviewboard.kde.org/r/129893/diff/4/ Changes: https://git.reviewboard.kde.org/r/129893/diff/3-4/ Testing --- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. File Attachments Before: dialog asks if the search should continue from the beginning. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png After: always continue search from beginning, with a non-intrusive notification. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png Thanks, Elvis Angelaccio
Re: Review Request 129893: Implement continuous search
> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote: > > Ping? Or should I re-upload the patch on phabricator for better visibility? > > Albert Astals Cid wrote: > Code is still wrong, what more visibility do you want? If you're not > going to allow for yes/no, why do you need a roundtrip to the ui to decide to > continue the search? > > Anthony Fieroni wrote: > You mean wrong in searching practically not finished? in mean wrong in architectuaraly wrong, i explained this like three times already, why is there a roundtrip to the ui so that the ui tells the core to continue, why just doens't the core continue by itslef? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review103715 --- On ago. 30, 2017, 2:47 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated ago. 30, 2017, 2:47 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.cpp b725ecfc7 > ui/searchlineedit.cpp 74e6ef60c > > > Diff: https://git.reviewboard.kde.org/r/129893/diff/3/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On Септ. 17, 2017, 1:20 след обяд, Elvis Angelaccio wrote: > > Ping? Or should I re-upload the patch on phabricator for better visibility? > > Albert Astals Cid wrote: > Code is still wrong, what more visibility do you want? If you're not > going to allow for yes/no, why do you need a roundtrip to the ui to decide to > continue the search? You mean wrong in searching practically not finished? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review103715 --- On Авг. 30, 2017, 5:47 след обяд, Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Авг. 30, 2017, 5:47 след обяд) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.cpp b725ecfc7 > ui/searchlineedit.cpp 74e6ef60c > > > Diff: https://git.reviewboard.kde.org/r/129893/diff/3/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote: > > Ping? Or should I re-upload the patch on phabricator for better visibility? Code is still wrong, what more visibility do you want? If you're not going to allow for yes/no, why do you need a roundtrip to the ui to decide to continue the search? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review103715 --- On ago. 30, 2017, 2:47 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated ago. 30, 2017, 2:47 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.cpp b725ecfc7 > ui/searchlineedit.cpp 74e6ef60c > > > Diff: https://git.reviewboard.kde.org/r/129893/diff/3/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review103715 --- Ping? Or should I re-upload the patch on phabricator for better visibility? - Elvis Angelaccio On Aug. 30, 2017, 2:47 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Aug. 30, 2017, 2:47 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.cpp b725ecfc7 > ui/searchlineedit.cpp 74e6ef60c > > > Diff: https://git.reviewboard.kde.org/r/129893/diff/3/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Aug. 30, 2017, 2:47 p.m.) Review request for Okular, KDE Usability and Albert Astals Cid. Changes --- Simpler diff. It still uses EndOfDocumentReached but at least it doesn't add new values to SearchType. Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs (updated) - core/document.cpp b725ecfc7 ui/searchlineedit.cpp 74e6ef60c Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing --- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. File Attachments Before: dialog asks if the search should continue from the beginning. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png After: always continue search from beginning, with a non-intrusive notification. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png Thanks, Elvis Angelaccio
Re: Review Request 129893: Implement continuous search
> On feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angelaccio wrote: > Should we ask input from the usability team maybe? I find the messagebox > annoying because it usually gets in the way. If I trigger Next it's because I > have not yet found what I was looking for, so I *always* click the Continue > button in the messagebox. > > Albert Astals Cid wrote: > You're reading a 20 page document, you've already read up to page 10, and > then you decide to search for "very important thing", why would you want to > wrap if you've already read the first 10 pages? > > Anyhow sure try to get someone from usability, but comparing okular to > kate is an apples to pineapples comparison imnsho. > > Elvis Angelaccio wrote: > Consider this use case: I open a pdf because I need to search something > in there. Not the first time I open this pdf, so it gets open somewhere after > the beginning of the document. Which means there is a good chance that I > reach the end of the document without finding what I was looking for. That's > why I think the "continue from beginning?" dialog can be annoying. > > Elvis Angelaccio wrote: > @Albert: I tried to rework this patch to work without > `EndOfDocumentReached`, but I can't figure it out. It seems to me that we > cannot get rid of it (otherwise I don't know how to notify that we reached > the first or last page). Why not? Just do it where EndOfDocumentReached is emitted? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- On mar. 11, 2017, 5:41 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated mar. 11, 2017, 5:41 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angelaccio wrote: > Should we ask input from the usability team maybe? I find the messagebox > annoying because it usually gets in the way. If I trigger Next it's because I > have not yet found what I was looking for, so I *always* click the Continue > button in the messagebox. > > Albert Astals Cid wrote: > You're reading a 20 page document, you've already read up to page 10, and > then you decide to search for "very important thing", why would you want to > wrap if you've already read the first 10 pages? > > Anyhow sure try to get someone from usability, but comparing okular to > kate is an apples to pineapples comparison imnsho. > > Elvis Angelaccio wrote: > Consider this use case: I open a pdf because I need to search something > in there. Not the first time I open this pdf, so it gets open somewhere after > the beginning of the document. Which means there is a good chance that I > reach the end of the document without finding what I was looking for. That's > why I think the "continue from beginning?" dialog can be annoying. @Albert: I tried to rework this patch to work without `EndOfDocumentReached`, but I can't figure it out. It seems to me that we cannot get rid of it (otherwise I don't know how to notify that we reached the first or last page). - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- On March 11, 2017, 5:41 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated March 11, 2017, 5:41 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On March 19, 2017, 10:30 p.m., Thomas Pfeiffer wrote: > > Great idea! > > The only feedback I have is that currently the message is visually detached > > from the search bar (which the user is likely to focus on at this point > > because that's where they've just clicked a button). > > Could it be placed at the bottom, directly above the search bar instead? Not really, it seems that with the current architecture the message widget can only be placed to the top-left corner, or top-right if the layout is right-to-left. This could be changed but I'm afraid I don't know the codebase well enough to do it. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102908 --- On March 11, 2017, 5:41 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated March 11, 2017, 5:41 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102908 --- Great idea! The only feedback I have is that currently the message is visually detached from the search bar (which the user is likely to focus on at this point because that's where they've just clicked a button). Could it be placed at the bottom, directly above the search bar instead? - Thomas Pfeiffer On March 11, 2017, 5:41 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated March 11, 2017, 5:41 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > File Attachments > > > Before: dialog asks if the search should continue from the beginning. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png > After: always continue search from beginning, with a non-intrusive > notification. > > https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated March 11, 2017, 5:41 p.m.) Review request for Okular, KDE Usability and Albert Astals Cid. Changes --- Screenshots before/after to help the usability people. Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs - core/document.h 1fd86262 core/document.cpp 41b9ddfe ui/searchlineedit.cpp baac8be0 Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing --- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. File Attachments (updated) Before: dialog asks if the search should continue from the beginning. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png After: always continue search from beginning, with a non-intrusive notification. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png Thanks, Elvis Angelaccio
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102793 --- Someone from accessibility: ping? - Albert Astals Cid On Feb. 9, 2017, 10:08 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Feb. 9, 2017, 10:08 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angelaccio wrote: > Should we ask input from the usability team maybe? I find the messagebox > annoying because it usually gets in the way. If I trigger Next it's because I > have not yet found what I was looking for, so I *always* click the Continue > button in the messagebox. > > Albert Astals Cid wrote: > You're reading a 20 page document, you've already read up to page 10, and > then you decide to search for "very important thing", why would you want to > wrap if you've already read the first 10 pages? > > Anyhow sure try to get someone from usability, but comparing okular to > kate is an apples to pineapples comparison imnsho. Consider this use case: I open a pdf because I need to search something in there. Not the first time I open this pdf, so it gets open somewhere after the beginning of the document. Which means there is a good chance that I reach the end of the document without finding what I was looking for. That's why I think the "continue from beginning?" dialog can be annoying. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- On Feb. 9, 2017, 10:08 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Feb. 9, 2017, 10:08 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Feb. 9, 2017, 10:08 p.m.) Review request for Okular, KDE Usability and Albert Astals Cid. Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs - core/document.h 1fd86262 core/document.cpp 41b9ddfe ui/searchlineedit.cpp baac8be0 Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing (updated) --- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. Thanks, Elvis Angelaccio
Re: Review Request 129893: Implement continuous search
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angelaccio wrote: > Should we ask input from the usability team maybe? I find the messagebox > annoying because it usually gets in the way. If I trigger Next it's because I > have not yet found what I was looking for, so I *always* click the Continue > button in the messagebox. You're reading a 20 page document, you've already read up to page 10, and then you decide to search for "very important thing", why would you want to wrap if you've already read the first 10 pages? Anyhow sure try to get someone from usability, but comparing okular to kate is an apples to pineapples comparison imnsho. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- On Feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Feb. 1, 2017, 11:20 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. Should we ask input from the usability team maybe? I find the messagebox annoying because it usually gets in the way. If I trigger Next it's because I have not yet found what I was looking for, so I *always* click the Continue button in the messagebox. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- On Feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated Feb. 1, 2017, 11:20 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 --- i'm not sure i agree with this change, but this doesn't seem the proper way to do it, if we're going to continue searching anyways, don't send a Okular::Document::EndOfDocumentReached, just continue searching. - Albert Astals Cid On feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > --- > > (Updated feb. 1, 2017, 11:20 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > - > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Feb. 1, 2017, 11:20 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Rebased on current master Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs (updated) - core/document.h 1fd86262 core/document.cpp 41b9ddfe ui/searchlineedit.cpp baac8be0 Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing --- Thanks, Elvis Angelaccio
Review Request 129893: Implement continuous search
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- Review request for Okular and Albert Astals Cid. Repository: okular Description --- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs - core/document.h bac38f89 core/document.cpp 468a8a9f ui/searchlineedit.cpp 85516efb Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing --- Thanks, Elvis Angelaccio
