Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools
I am not sure if override is a good idea. I made a separate 'Journal Items Search All' entry since the 'fast' encoding of account move lines is a bit easier with the standard Journal Items list view (the journal and period are in that case taken from the values in the 'Period' and 'Journal' selection boxes. We don't recommend this technique to our customer since it's unpractical and not at all 'fast' (unfortunately the only real 'fast' encoding of accounting entries in OpenERP is via import from xls/csv) but I can imagine that there are people using it, hence a separate entry preserves this encoding mechanism. Regards, Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Frederic Clementi - Camptocamp Sent: vrijdag 27 juni 2014 16:53 To: Luc De Meyer (Noviat) Subject: [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools You have been requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools. For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847 This change is to actually override the existing Journal Items menu item with the new one introduced in account_move_line_search_extension, given than the old one is not used anymore when the extension is installed. -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847 You are requested to review the proposed merge of lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:account-financial-tools. https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report
Namespace means python namespace. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexandre Fayolle - camptocamp Sent: donderdag 26 juni 2014 16:21 To: mp+220...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report Review: Needs Information code review, no tests I find your naming very confusing. Could you clarify what is space and what is namespace here? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report
The account_financial_report_webkit module needs to know only the very first special period from where accounting is being done in OpenERP (with accounting I mean full accounting, not just payables/receivables). From that first special period, the opening balances for all the fiscal years on which we need to financial reports are calculated correctly. Hence only one parameter at the company level is required. Regards, Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Pedro Manuel Baeza Sent: zaterdag 7 juni 2014 12:16 To: mp+216...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report Review: Needs Information code review Hi, Luc, I see your solution very restricted, because you can have an special period for each fiscal year. Setting it at company level doesn't seem the best approach. Why don't you put it at fiscal year level? Regards. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527
add possibility to extend namespace for use in xls template via inherited
module.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527
Your team Account Report Core Editors is requested to review the proposed merge
of
lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra
into lp:account-financial-report.
=== modified file 'account_journal_report_xls/__openerp__.py'
--- account_journal_report_xls/__openerp__.py 2014-02-21 16:43:10 +
+++ account_journal_report_xls/__openerp__.py 2014-05-21 20:48:21 +
@@ -22,7 +22,7 @@
{
'name': 'Financial Journal reports',
-'version': '0.2',
+'version': '0.3',
'license': 'AGPL-3',
'author': 'Noviat',
'category': 'Accounting Finance',
=== modified file 'account_journal_report_xls/account_journal.py'
--- account_journal_report_xls/account_journal.py 2014-01-19 18:16:42 +
+++ account_journal_report_xls/account_journal.py 2014-05-21 20:48:21 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -12,11 +12,11 @@
#
#This program is distributed in the hope that it will be useful,
#but WITHOUT ANY WARRANTY; without even the implied warranty of
-#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
@@ -36,9 +36,20 @@
return (select_extra, join_extra, where_extra)
# allow inherited modules to add document references
-def _report_xls_document_extra(self, cr, uid, context):
+def _report_xls_document_extra(self, cr, uid, context=None):
return ''
+# allow inherited modules to extend the render namespace
+def _report_xls_render_space_extra(self, cr, uid, context=None):
+
+extend render namespace for use in the template 'lines', e.g.
+space_extra = {
+'partner_obj': self.pool.get('res.partner'),
+}
+return space_extra
+
+return None
+
# override list in inherited module to add/drop columns or change order
def _report_xls_fields(self, cr, uid, context=None):
res = [
=== modified file 'account_journal_report_xls/report/__init__.py'
--- account_journal_report_xls/report/__init__.py 2013-12-19 17:08:40 +
+++ account_journal_report_xls/report/__init__.py 2014-05-21 20:48:21 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -12,11 +12,11 @@
#
#This program is distributed in the hope that it will be useful,
#but WITHOUT ANY WARRANTY; without even the implied warranty of
-#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
=== modified file 'account_journal_report_xls/report/nov_account_journal_xls.py'
--- account_journal_report_xls/report/nov_account_journal_xls.py 2014-01-19 18:16:42 +
+++ account_journal_report_xls/report/nov_account_journal_xls.py 2014-05-21 20:48:21 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into
lp:openerp-reporting-engines.
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
For more details, see:
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267
timezone fix
--
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into
lp:openerp-reporting-engines.
=== modified file 'report_xls/__init__.py'
--- report_xls/__init__.py 2014-01-06 22:22:39 +
+++ report_xls/__init__.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
=== modified file 'report_xls/__openerp__.py'
--- report_xls/__openerp__.py 2014-01-06 22:22:39 +
+++ report_xls/__openerp__.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
{
@@ -67,7 +67,7 @@
Development assistance
''
-Contact i...@noviat.com for help with the development of Excel reports in OpenERP, .
+Contact i...@noviat.com for help with the development of Excel reports in OpenERP.
,
'depends': ['base'],
=== modified file 'report_xls/report_xls.py'
--- report_xls/report_xls.py 2014-01-06 22:22:39 +
+++ report_xls/report_xls.py 2014-05-12 20:55:28 +
@@ -24,6 +24,7 @@
from xlwt.Style import default_style
import cStringIO
from datetime import datetime
+from openerp.osv.fields import datetime as datetime_field
from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT
import inspect
from types import CodeType
@@ -58,7 +59,6 @@
# TO DO: move parameters infra to configurable data
# header/footer
-DT_FORMAT = '%Y-%m-%d %H:%M:%S'
hf_params = {
'font_size': 8,
'font_style': 'I', # B: Bold, I: Italic, U: Underline
@@ -120,8 +120,9 @@
self.xls_headers = {
'standard': '',
}
+report_date = datetime_field.context_timestamp(cr, uid, datetime.now(), context).strftime(DEFAULT_SERVER_DATETIME_FORMAT)
self.xls_footers = {
-'standard': ('L%(font_size)s%(font_style)s' + datetime.now().strftime(DEFAULT_SERVER_DATETIME_FORMAT) +
+'standard': ('L%(font_size)s%(font_style)s' + report_date +
'R%(font_size)s%(font_style)sP / N') % self.hf_params,
}
self.generate_xls_report(_p, _xs, data, objs, wb)
=== modified file 'report_xls/utils.py'
--- report_xls/utils.py 2014-01-06 22:22:39 +
+++ report_xls/utils.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report
Approve - code review and test -- https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
add company parameter for first special period
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
Your team Account Report Core Editors is requested to review the proposed merge
of
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2
into lp:account-financial-report.
=== modified file 'account_financial_report_webkit/__init__.py'
--- account_financial_report_webkit/__init__.py 2012-03-06 09:13:59 +
+++ account_financial_report_webkit/__init__.py 2014-04-17 18:30:38 +
@@ -20,4 +20,5 @@
import account
from . import wizard
from . import report
-from . import account_move_line
\ No newline at end of file
+from . import account_move_line
+from . import res_company
\ No newline at end of file
=== modified file 'account_financial_report_webkit/__openerp__.py'
--- account_financial_report_webkit/__openerp__.py 2014-03-18 15:55:12 +
+++ account_financial_report_webkit/__openerp__.py 2014-04-17 18:30:38 +
@@ -167,7 +167,7 @@
the header and footer are created as text with arguments passed to
wkhtmltopdf. The texts are defined inside the report classes.
,
-'version': '1.1.0',
+'version': '1.2.0',
'author': 'Camptocamp',
'license': 'AGPL-3',
'category': 'Finance',
@@ -179,6 +179,7 @@
'init_xml': [],
'demo_xml' : [],
'update_xml': ['account_view.xml',
+ 'res_company_view.xml',
'data/financial_webkit_header.xml',
'report/report.xml',
'wizard/wizard.xml',
=== modified file 'account_financial_report_webkit/report/common_partner_reports.py'
--- account_financial_report_webkit/report/common_partner_reports.py 2013-05-07 06:56:51 +
+++ account_financial_report_webkit/report/common_partner_reports.py 2014-04-17 18:30:38 +
@@ -64,6 +64,9 @@
:return: browse record of the first special period.
+first_special_period = self.localcontext['company'].first_special_period_id
+if first_special_period:
+return first_special_period
move_line_obj = self.pool.get('account.move.line')
first_entry_id = move_line_obj.search(
self.cr, self.uid, [], order='date ASC', limit=1)
=== added file 'account_financial_report_webkit/res_company.py'
--- account_financial_report_webkit/res_company.py 1970-01-01 00:00:00 +
+++ account_financial_report_webkit/res_company.py 2014-04-17 18:30:38 +
@@ -0,0 +1,42 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from openerp.osv import fields, orm
+
+class res_company(orm.Model):
+_inherit = 'res.company'
+
+def _get_first_special_period(self, cr, uid, context=None):
+first_special = self.pool.get('account.period').search(cr, uid,
+ [('special', '=', True)], order='date_start ASC', limit=1)
+return first_special and first_special[0] or False
+
+_columns = {
+'first_special_period_id': fields.many2one('account.period', 'First Special Period',
+domain=[('special', '=', True)],
+help=When specified, the accounting reports will consider this
+ period as the start period for the calculation of opening balances.)
+}
+
+_defaults = {
+'first_special_period_id': _get_first_special_period,
+}
\ No newline at end of file
=== added file 'account_financial_report_webkit/res_company_view.xml'
--- account_financial_report_webkit/res_company_view.xml 1970-01-01 00:00:00 +
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
MP: cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380 www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Luc De Meyer (Noviat) Sent: maandag 14 april 2014 11:36 To: mp+193...@code.launchpad.net Subject: RE: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report I am just back from a week of holiday. I have reserved a bit of time in my agenda to make the MP by the end of this week. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Nicolas Bessi - Camptocamp Sent: donderdag 10 april 2014 14:12 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report hello, Any news on this one -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
I am just back from a week of holiday. I have reserved a bit of time in my agenda to make the MP by the end of this week. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Nicolas Bessi - Camptocamp Sent: donderdag 10 april 2014 14:12 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report hello, Any news on this one -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools
Period is a char field to facilitate the search on all periods in a given fiscal year (assuming of course that the fiscal year name is consistently used in the naming of the periods). Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Guewen Baconnier @ Camptocamp Sent: vrijdag 21 maart 2014 9:18 To: mp+211...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools Review: Needs Information code review, test Hi, Sounds good. It would be so nice to have autocompletion on the fields (but could be a new feature to add later, that's good enough now). I'm just wondering why the 'period' field is a char field and not a selection field like in the standard view, is it a usability reason? Thanks -- https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967 You are the owner of lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension. https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension
into lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967
This module adds the 'Journal Items Search All' menu entry.
This menu entry adds a number of search fields on top of the List View rows.
These fields can be used in combination with the Search window.
--
https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967
Your team Account Core Editors is requested to review the proposed merge of
lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension
into lp:account-financial-tools.
=== added directory 'account_move_line_search_extension'
=== added file 'account_move_line_search_extension/__init__.py'
--- account_move_line_search_extension/__init__.py 1970-01-01 00:00:00 +
+++ account_move_line_search_extension/__init__.py 2014-03-20 15:05:40 +
@@ -0,0 +1,22 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
=== added file 'account_move_line_search_extension/__openerp__.py'
--- account_move_line_search_extension/__openerp__.py 1970-01-01 00:00:00 +
+++ account_move_line_search_extension/__openerp__.py 2014-03-20 15:05:40 +
@@ -0,0 +1,54 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Journal Items Search Extension',
+'version': '0.1',
+'license': 'AGPL-3',
+'author': 'Noviat',
+'category' : 'Generic Modules',
+'description':
+Journal Items Search Extension
+==
+
+This module adds the 'Journal Items Search All' menu entry.
+
+This menu entry adds a number of search fields on top of the List View rows.
+These fields can be used in combination with the Search window.
+
+,
+'depends': ['account'],
+'data' : [
+'account_view.xml',
+],
+'js': [
+'static/src/js/account_move_line_search_extension.js',
+],
+'qweb' : [
+'static/src/xml/account_move_line_search_extension.xml',
+],
+'css':[
+'static/src/css/account_move_line_search_extension.css',
+],
+'installable': True,
+'auto_install': False,
+}
=== added file 'account_move_line_search_extension/account_view.xml'
--- account_move_line_search_extension/account_view.xml 1970-01-01 00:00:00 +
+++ account_move_line_search_extension/account_view.xml 2014-03-20 15:05:40 +
@@ -0,0 +1,22 @@
+?xml version=1.0 encoding=utf-8?
+openerp
+ data
+
+record id=action_account_move_line_search_extension model=ir.actions.act_window
+ field name=context{'account_move_line_search_extension':1}/field
+ field name=nameJournal Items Search All/field
+ field name=res_modelaccount.move.line/field
+ field name=view_id ref=account.view_move_line_tree/
+ field name
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools
Pedro, I made a separate view to avoid potential conflicts (now and in the future) between the javascript code in this module and the javascript code in the standard account module. Also the use case for the two list views is different: - The 'account' module list view has been extended with a (imho rather primitive) technique to facilitate the encoding of journal items. - The 'move line search all' view is intended to facilitate the search through thousands/millions of journal items. I hope that this small module can be discontinued in V8 and that we get again a general, V6' type of search view that allows us to configure on any object what I have hardcoded in javascipt for one particular object. Fabien has committed that V8 will come with an improved search view, hence I am looking forward to see what it will offer. Regards, Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Pedro Manuel Baeza Sent: donderdag 20 maart 2014 16:21 To: mp+211...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools Review: Needs Information Hi, Luc, thanks for the contribution, It isn't better to extend current journal items view? Is there any blocking issue that prevents it? Regards -- https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967 You are the owner of lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension. https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
No, If you agree with the proposed approach, than I an make an MP. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Yannick Vaucher @ Camptocamp Sent: vrijdag 14 maart 2014 9:48 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report Review: Needs Information @Luc anything was done about this proposed change ? I have the impression that we move to a consensus to fix this issue by adding a parameter on the company settings with callback to current method if not defined. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report
Stephane, bug lp:1172779 indeed describes the same problem as the one for which I made the merge proposal. I think the error description is clear. The patch is only a few lines of code and runs at all our customers hence it is tested and stable. I hope someone at C2C finds to the time to review and merge so that we stop applying this patch every time we install this module. Regards, Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Stéphane Bidoul (Acsone) Sent: dinsdag 25 februari 2014 9:28 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report Is this MP related to bug lp:1172779 ? If yes, the discussion in the merge proposals linked to that bug might be of interest. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report
There is no bug report since imho the 'Description of Change' is clear : General Ledger should include accounting move lines in close opening periods. Without this fix, you don't get a complete history of all moves in a certain fiscal year. Regards, Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Yannick Vaucher @ Camptocamp Sent: vrijdag 31 januari 2014 10:48 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report Review: Needs Information Is there a bug report about this issue? If it does can you link it? If not can you create it? l.64 + l.81 + l.104 + l.110 + l.114 Just a note about credits, your user name will be in the commit if someone really wants to know who wrote a specific line of code for exemple with bzr blame. If you want to show you contributed to a module, please only add this in __openerp__.py under Contributors in description. It will even be better for your Company as it will be visible on apps.openerp.com and not only hidden somewhere in the code. https://doc.openerp.com/contribute/05_developing_modules/#modules-description Here is an exemple http://bazaar.launchpad.net/~stock-logistic-core-editors/carriers-deliveries/7.0/view/head:/base_delivery_carrier_label/__openerp__.py -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls into lp:account-financial-report
It's a 5 minutes job to add this field. I haven't received this concrete question yet from our customer base, hence if we add this field, we probably should keep it out of the defaults list. Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexis de Lattre Sent: woensdag 15 januari 2014 10:57 To: mp+201...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls into lp:account-financial-report By the way (but it is not the topic of this merge proposal), I think that we need to have the Analytic account field available in the module account_journal_report_xls (it is now available in the module account_move_line_report_xls)... I looked into the code, and this field doesn't seem to be available for the moment. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls/+merge/201660 You are the owner of lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls/+merge/201660 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls into
lp:account-financial-report.
Requested reviews:
Pedro Manuel Baeza (pedro.baeza)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls/+merge/201660
This update fixes a bug in the PDF report when using the 'Group Entries' option
(this bug doesn't exist in the XLS variant of this report).
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls/+merge/201660
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
=== modified file 'account_journal_report_xls/__init__.py'
--- account_journal_report_xls/__init__.py 2014-01-08 11:49:48 +
+++ account_journal_report_xls/__init__.py 2014-01-14 19:42:45 +
@@ -28,6 +28,4 @@
import logging
logging.getLogger('openerp.module').warning('report_xls not available in addons path. account_financial_report_webkit_xls will not be usable')
-
-
# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== modified file 'account_journal_report_xls/__openerp__.py'
--- account_journal_report_xls/__openerp__.py 2013-12-19 17:08:40 +
+++ account_journal_report_xls/__openerp__.py 2014-01-14 19:42:45 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -12,11 +12,11 @@
#
#This program is distributed in the hope that it will be useful,
#but WITHOUT ANY WARRANTY; without even the implied warranty of
-#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
@@ -47,9 +47,8 @@
'account_voucher',
'report_xls',
],
-'demo_xml': [],
-'init_xml': [],
-'update_xml': [
+'demo': [],
+'data': [
'wizard/print_journal_wizard.xml',
],
}
=== modified file 'account_journal_report_xls/report/nov_account_journal.py'
--- account_journal_report_xls/report/nov_account_journal.py 2013-12-23 21:36:43 +
+++ account_journal_report_xls/report/nov_account_journal.py 2014-01-14 19:42:45 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -12,11 +12,11 @@
#
#This program is distributed in the hope that it will be useful,
#but WITHOUT ANY WARRANTY; without even the implied warranty of
-#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
@@ -165,6 +165,10 @@
#_logger.warn('code_string= %s', code_string)
[x.update({'docname': eval(code_string) or '-'}) for x in lines]
+# group lines
+if self.group_entries:
+lines = self._group_lines(lines)
+
# format debit, credit, amount_currency for pdf report
if self.display_currency and self.report_type == 'pdf':
curr_obj = self.pool.get('res.currency')
@@ -175,10 +179,6 @@
else:
[x.update({'amount1': self.formatLang(x['debit']), 'amount2': self.formatLang(x['credit'])}) for x in lines]
-# group lines
-if self.group_entries:
-lines = self._group_lines(lines)
-
# insert a flag in every move_line to indicate the end of a move
# this flag will be used to draw a full line between moves
for cnt in range(len(lines) - 1):
@@ -215,7 +215,7 @@
grouped_lines = [lines_in[0]]
move_id = lines_in[0]['move_id']
line_cnt = len(lines_in)
-for i in range(1,line_cnt):
+for i
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
Don't worry. I'll make a new merge with the default fields and documentation update. Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexis de Lattre Sent: woensdag 8 januari 2014 10:21 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report @Alexandre : Thanks for the merge... but it doesn't contain the new list of default fields we decided above in the function _report_xls_fields() in account_move_line.py. Could you update it ? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
Analytic account is available in this version. Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Frederic Clementi - Camptocamp Sent: maandag 6 januari 2014 12:14 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report Review: Needs Fixing functional Is the analytical account still missing in this version ? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
We have installed this module in the meanwhile at most of our customers and requirements vary from customer to customer which makes it difficult to decide upon the default fields but adding journal analytic certainly makes sense. If no objection, I propose to change the default as follows : Current default : def _report_xls_fields(self, cr, uid, context=None): return [ 'move', 'name', 'date', 'period', 'partner', 'account', 'date_maturity', 'debit', 'credit', 'balance', 'reconcile', 'reconcile_partial', ] New default: def _report_xls_fields(self, cr, uid, context=None): return [ 'move', 'name', 'date', 'journal', 'period', 'partner', 'account', 'date_maturity', 'debit', 'credit', 'balance', 'reconcile', 'reconcile_partial', 'analytic_account', ] I'll also update the module documentation so that anyone understands the customisation capabilities without having to read the code. Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexis de Lattre Sent: dinsdag 7 januari 2014 22:39 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report Yes, it is available, but it is not displayed by default in the XLS report, cf the fonction _report_xls_fields(). I think that we should add 2 fields in the default report : - analytic account - journal code What do you think ? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls into lp:account-financial-report
Guewen,
Thanks for your fast review.
I am trying to be the best student of the class this time and hence have
uploaded a technical update of the code with
- pep8 warnings fixed
- backslash removals
- lists replaced by tuples where it makes sense
- map()replaced by list comprehension where it makes sense
- for i in range(1, line_cnt) replaced by for i, line in enumerate(lines_in)
Regards,
Luc
P.S.
Concerning the 'All rights reserved. in the header:
We copied this from an OpenERP header back in the old OpenERP V5 days.
I am not a lawyer, but I don't think it hurts since the next paragraphs states
that the software is under the AGPL license.
If it's wrong, than we can of course remove these wordings.
-Original Message-
From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Guewen
Baconnier @ Camptocamp
Sent: donderdag 19 december 2013 8:40
To: mp+199...@code.launchpad.net
Subject: Re: [Merge]
lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls into
lp:account-financial-report
Review: Approve code review
Hello,
thanks for your proposal.
Here is a list things that could be improved. I still approve because I don't
think they should block the merge.
--
Some pep8 warnings.
--
l.867-899: backslash can be removed, indentation (just move SELECT down-left or
vertical align all the lines below SELECT)
--
Usage of list could often be replaced by tuples, examples:
if journal.type in ['sale', 'sale_refund', 'purchase', 'purchase_refund']:
could be
if journal.type in ('sale', 'sale_refund', 'purchase', 'purchase_refund'):
and
return [select_extra, join_extra, where_extra] could be
return (select_extra, join_extra, where_extra) and so on.
--
map() on lines 906-920 would be more readable using for loops.
In other places, map() is often used when it could be replaced by list
comprehensions.
--
l.962:
for i, line in enumerate(lines_in):
is better than
for i in range(1, line_cnt):
line = lines_in[i]
I saw this idiom several times along the code.
--
Finally a question: why do you write All rights reserved. in the header?
Seems just wrong to me.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls/+merge/199546
You are the owner of
lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls/+merge/199546
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
Alexis, We already fixed this problems in the version that you find on our V7 apps.openerp.com launchpad branch, cf. ~noviat/openobject-addons/extra-7.0. This version also extends the inherit concept to add new fields (in order to support add-on modules that add account_move_line fields and also add french and dutch translations). I have uploaded the new version to https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/ Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexis de Lattre Sent: zaterdag 14 december 2013 0:17 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report About the crash that I mentionned 2 comments above, the reason is quite obvious when you look at the code in report/move_line_list_xls.py in the function generate_xls_report() : the variable debit_pos is declared and initialized in a block of code under : if 'balance' in wanted_list': and then it is used in a block of code which is executed in all cases. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
Alexis, Cf. our update on https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/ which is now synced with our version on our V7 apps.openerp.com branch. The other_currency, other_currency_amount were already there. I have added the journal, analytic_account, company_currency fields from your merge proposal. You will also remark that the XLS template can now be customised via an inherited module hence 'account_move_line' fields added by OpenERP or Community addons can be added to the XLS export in a few minutes. Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexis de Lattre Sent: vrijdag 13 december 2013 16:35 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report @Luc I have prepared a small patch that you can find here : http://people.via.ecp.fr/~alexis/account_move_line_report_xls-adl-enhancement.diff It adds several fields (journal, analytic_account, company_currency, other_currency, other_currency_amount) that I've been missing in my first in real-life usage of your module. It also updates the syntax of __openerp__.py to 7.0 version. Could you review this patch and apply it in your branch ? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
The problem is that you have many OpenERP systems out there which have been used for years for other purposes than accounting. During those years, accounting entries have been generated but these entries were only used for e.g. one department or only sale/purchase of goods, ... Real reconciliations in those systems are usually done outside OpenERP (in the accounting software). Hence the partner data in those years are incorrect and the reports should start from the point where a first correct opening balance has been uploaded, not the first year with (incorrect) accounting entries. The MP is a potential way to handle this : we assume that there is no opening period as long as the system is not used for full accounting purposes. In most cases where we added accounting to legacy OpenERP systems, this was the case (but not always). Another way to tackle this issue is to add a configuration parameter to the 'company' settings to indicate what the first special period is. Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Guewen Baconnier @ Camptocamp Sent: maandag 4 november 2013 10:01 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report Review: Needs Fixing Hi, Thanks for the proposal. While I understand the logic you want to change I don't understand what problem you want to fix (I could maybe guess but I'm not sure). The code you propose was the same and we had to replace it by the more convoluted version that you want to replace. This method is used by the partner reports (computation of the initial balance) and we need to find the opening period of the first year _with_ accounting entries. We want the balance of the very first opening period. If we just search by date, we may find an opening period on a year which has not been used for the accounting = balance would be mistakenly 0. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
Understand. Though, that's not working if you have a year without accounting entries at all and 1 (empty) opening period. We have seen this situation before and we just removed the opening period. This is of course a workaround that doesn't tackle the real issue. Considering all the cases, that's probably the sole available option (eventually with a callback on the current method if not defined). I agree that this is probably the cleanest solution. -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Guewen Baconnier @ Camptocamp Sent: maandag 4 november 2013 10:39 To: mp+193...@code.launchpad.net Subject: Re: RE: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report The problem is that you have many OpenERP systems out there which have been used for years for other purposes than accounting. During those years, accounting entries have been generated but these entries were only used for e.g. one department or only sale/purchase of goods, ... Real reconciliations in those systems are usually done outside OpenERP (in the accounting software). Hence the partner data in those years are incorrect and the reports should start from the point where a first correct opening balance has been uploaded, not the first year with (incorrect) accounting entries. Thanks for the explanation, I understand better. The MP is a potential way to handle this : we assume that there is no opening period as long as the system is not used for full accounting purposes. In most cases where we added accounting to legacy OpenERP systems, this was the case (but not always). Understand. Though, that's not working if you have a year without accounting entries at all and 1 (empty) opening period. Another way to tackle this issue is to add a configuration parameter to the 'company' settings to indicate what the first special period is. Considering all the cases, that's probably the sole available option (eventually with a callback on the current method if not defined). -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
We face this problem too, but we used to fix the not reconciled entries (Importing historical paymens too globally and in some cases just to close correctly all periods when we will start to use the accounting approach), it means, if we report some periods in one way and other periods in other way it can bring inconsistencies don't you think?. IMHO wire in some way data to allow reports to show something different of what is loaded in the system is not a good approach. Our experience: spending time to fix historical accounting records whereas the real historical data sits on another system is usually not the solution that the customer wants to pay for. I have the impression that we move to a consensus to fix this issue by adding a parameter on the company settings with callback to current method if not defined. Guewen, Do you want Noviat to add this to the code and make a new merge proposal or do you prefer that C2C makes this fix ? Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Nhomar - Vauxoo Sent: maandag 4 november 2013 10:51 To: mp+193...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report 2013/11/4 Luc De Meyer (Noviat) luc.deme...@noviat.be The problem is that you have many OpenERP systems out there which have been used for years for other purposes than accounting. During those years, accounting entries have been generated but these entries were only used for e.g. one department or only sale/purchase of goods, ... Real reconciliations in those systems are usually done outside OpenERP (in the accounting software). Concept review: No test yet. Hello Luc. We face this problem too, but we used to fix the not reconciled entries (Importing historical paymens too globally and in some cases just to close correctly all periods when we will start to use the accounting approach), it means, if we report some periods in one way and other periods in other way it can bring inconsistencies don't you think?. IMHO wire in some way data to allow reports to show something different of what is loaded in the system is not a good approach. BTW I understand the point, can you put some Demo data just to validate this specific case for future usage? in this way we can have them as base cases to show everybody in what cases it is necessary. Best regards. -- Saludos Cordiales Nhomar G. Hernandez M. +58-414-4110269 Skype: nhomar00 Web-Blog: http://geronimo.com.ve Servicios IT: http://vauxoo.com Linux-Counter: 467724 Correos: nho...@openerp.com.ve nho...@vauxoo.com twitter @nhomar https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats into lp:account-financial-report. Requested reviews: Account Report Core Editors (account-report-core-editor) For more details, see: https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats/+merge/193704 add nl.po -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats/+merge/193704 Your team Account Report Core Editors is requested to review the proposed merge of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats into lp:account-financial-report. === added file 'account_financial_report_webkit/i18n/nl.po' --- account_financial_report_webkit/i18n/nl.po 1970-01-01 00:00:00 + +++ account_financial_report_webkit/i18n/nl.po 2013-11-03 19:21:58 + @@ -0,0 +1,877 @@ +# Translation of OpenERP Server. +# This file contains the translation of the following modules: +# * account_financial_report_webkit +# +msgid +msgstr +Project-Id-Version: OpenERP Server 6.0.3\n +Report-Msgid-Bugs-To: supp...@openerp.com\n +POT-Creation-Date: 2012-01-20 10:47+\n +PO-Revision-Date: 2012-01-20 10:47+\n +Last-Translator: \n +Language-Team: \n +MIME-Version: 1.0\n +Content-Type: text/plain; charset=UTF-8\n +Content-Transfer-Encoding: \n +Plural-Forms: \n + +#. module: account_financial_report_webkit +#: field:account.common.balance.report,account_ids:0 +#: field:general.ledger.webkit,account_ids:0 +#: field:partner.balance.webkit,account_ids:0 +#: field:trial.balance.webkit,account_ids:0 +msgid Filter on accounts +msgstr Filter per rekening + +#. module: account_financial_report_webkit +#: code:addons/account_financial_report_webkit/report/common_reports.py:424 +#, python-format +msgid Please set a valid time filter +msgstr Selecteer geldige tijdsfilter + +#. module: account_financial_report_webkit +#: view:general.ledger.webkit:0 +#: view:open.invoices.webkit:0 +#: view:partners.ledger.webkit:0 +msgid Layout Options +msgstr Layout opties + +#. module: account_financial_report_webkit +#: report:addons/account_financial_report_webkit/report/templates/account_report_general_ledger.mako:203 +#: report:addons/account_financial_report_webkit/report/templates/account_report_open_invoices.mako:223 +#: report:addons/account_financial_report_webkit/report/templates/account_report_partners_ledger.mako:253 +msgid Cumulated Balance on Account +msgstr Cumulatief saldo + +#. module: account_financial_report_webkit +#: field:general.ledger.webkit,centralize:0 +msgid Activate Centralization +msgstr Activeer Centralisatie + +#. module: account_financial_report_webkit +#: report:addons/account_financial_report_webkit/report/templates/account_report_partner_balance.mako:154 +#: report:addons/account_financial_report_webkit/report/templates/account_report_partner_balance.mako:161 +#: report:addons/account_financial_report_webkit/report/templates/account_report_profit_loss.mako:120 +#: report:addons/account_financial_report_webkit/report/templates/account_report_profit_loss.mako:127 +#: report:addons/account_financial_report_webkit/report/templates/account_report_trial_balance.mako:135 +#: report:addons/account_financial_report_webkit/report/templates/account_report_trial_balance.mako:142 +msgid Balance %s +msgstr Balans %s + +#. module: account_financial_report_webkit +#: code:addons/account_financial_report_webkit/report/webkit_parser_header_fix.py:172 +#, python-format +msgid No header defined for this Webkit report! +msgstr Geen header gedefinieerd voor dit webkit rapport ! + +#. module: account_financial_report_webkit +#: model:ir.actions.act_window,name:account_financial_report_webkit.action_account_trial_balance_menu_webkit +#: model:ir.actions.report.xml,name:account_financial_report_webkit.account_report_trial_balance_webkit +msgid Trial Balance Webkit +msgstr Proefbalans + +#. module: account_financial_report_webkit +#: view:partner.balance.webkit:0 +msgid This report is an analysis done by a partner, It is a PDF report containing one line per partner representing the cumulative credit balance +msgstr Dit rapport toont de gecumuleerde balans per klant of leverancier. + +#. module: account_financial_report_webkit +#: report:addons/account_financial_report_webkit/report/templates/account_report_partner_balance.mako:138 +msgid Account / Partner Name +msgstr Rekening / Partner + +#. module: account_financial_report_webkit +#: field:account.common.balance.report,journal_ids:0 +#: field:general.ledger.webkit,journal_ids:0 +#: field:open.invoices.webkit,journal_ids:0 +#: field:partner.balance.webkit,journal_ids:0 +#: field:partners.ledger.webkit,journal_ids:0 +#: field:trial.balance.webkit,journal_ids:0 +msgid Journals +msgstr Dagboeken + +#. module: account_financial_report_webkit +#: help:general.ledger.webkit,amount_currency:0
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709
General Ledger should include accounting move lines in close opening periods.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709
Your team Account Report Core Editors is requested to review the proposed merge
of
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix
into lp:account-financial-report.
=== modified file 'account_financial_report_webkit/__init__.py'
--- account_financial_report_webkit/__init__.py 2012-03-06 09:13:59 +
+++ account_financial_report_webkit/__init__.py 2013-11-03 20:44:40 +
@@ -18,6 +18,7 @@
#
##
import account
+from . import account_period
from . import wizard
from . import report
from . import account_move_line
\ No newline at end of file
=== added file 'account_financial_report_webkit/account_period.py'
--- account_financial_report_webkit/account_period.py 1970-01-01 00:00:00 +
+++ account_financial_report_webkit/account_period.py 2013-11-03 20:44:40 +
@@ -0,0 +1,37 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from openerp.osv import orm
+
+class account_period(orm.Model):
+_inherit = 'account.period'
+
+def build_ctx_periods(self, cr, uid, period_from_id, period_to_id):
+ add close periods
+period_ids = super(account_period, self).build_ctx_periods(cr, uid, period_from_id, period_to_id)
+period_to = self.browse(cr, uid, period_to_id)
+period_date_stop = period_to.date_stop
+close_period_ids = self.search(cr, uid, [('date_stop', '=', period_date_stop), ('special', '=', True), ('company_id', '=', period_to.company_id.id)])
+for p in close_period_ids:
+if p not in period_ids:
+period_ids.append(p)
+return period_ids
=== modified file 'account_financial_report_webkit/report/common_reports.py'
--- account_financial_report_webkit/report/common_reports.py 2013-09-12 20:53:27 +
+++ account_financial_report_webkit/report/common_reports.py 2013-11-03 20:44:40 +
@@ -217,7 +217,15 @@
def exclude_opening_periods(self, period_ids):
period_obj = self.pool.get('account.period')
-return period_obj.search(self.cr, self.uid, [['special', '=', False], ['id', 'in', period_ids]])
+# FIX by Noviat: close periods should be included
+self.cr.execute(SELECT p.id \
+FROM account_period p \
+INNER JOIN account_fiscalyear f ON p.fiscalyear_id = f.id \
+WHERE (special = FALSE or (special = TRUE AND p.date_stop = f.date_stop)) \
+AND p.id IN %s, (tuple(period_ids),))
+period_ids = self.cr.fetchall()
+period_ids = [x[0] for x in period_ids]
+return period_ids
def get_included_opening_period(self, period):
Return the opening included in normal period we use the assumption
@@ -384,7 +392,16 @@
if pnl_periods_ids and not opening_period_selected:
res[acc.id] = self._compute_init_balance(acc.id, pnl_periods_ids)
else:
-res[acc.id] = self._compute_init_balance(acc.id, bs_period_ids)
+# FIX by Noviat
+if not bs_period_ids:
+res[acc.id] = {
+'debit': 0.0,
+'credit': 0.0,
+'init_balance': 0.0,
+'init_balance_currency': 0.0,
+'state': 'computed'}
+else
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Add support for customers who start to use OpenERP accounting after one of more
years of using OpenERP for other purposes by changing the
'_get_first_special_period' logic.
New logic:
First special period is first opening period since you can have years without
opening period, e.g. OpenERP systems used initially for non-accounting purposes.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is requested to review the proposed merge
of
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix
into lp:account-financial-report.
=== modified file 'account_financial_report_webkit/report/common_partner_reports.py'
--- account_financial_report_webkit/report/common_partner_reports.py 2013-05-07 06:56:51 +
+++ account_financial_report_webkit/report/common_partner_reports.py 2013-11-03 20:56:22 +
@@ -64,21 +64,9 @@
:return: browse record of the first special period.
-move_line_obj = self.pool.get('account.move.line')
-first_entry_id = move_line_obj.search(
-self.cr, self.uid, [], order='date ASC', limit=1)
-# it means there is no entry at all, that's unlikely to happen, but
-# it may so
-if not first_entry_id:
-return
-first_entry = move_line_obj.browse(self.cr, self.uid, first_entry_id[0])
-fiscalyear = first_entry.period_id.fiscalyear_id
-special_periods = [period for period in fiscalyear.period_ids if period.special]
-# so, we have no opening period on the first year, nothing to return
-if not special_periods:
-return
-return min(special_periods,
- key=lambda p: datetime.strptime(p.date_start, DEFAULT_SERVER_DATE_FORMAT))
+period_obj = self.pool.get('account.period')
+first_special_period_id = period_obj.search(self.cr, self.uid, [('special', '=', True)], order='date_start ASC', limit=1)
+return first_special_period_id and period_obj.browse(self.cr, self.uid, first_special_period_id[0]) or None
def _get_period_range_from_start_period(self, start_period, include_opening=False,
fiscalyear=False,
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes into lp:account-financial-report
I have splitted the merge into three separate merge proposals in order to facilitate the review. 1) dutch translations Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats/+merge/193704 2) General Ledger should include accounting move lines in close opening periods Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709 3) Add support for customers who start to use OpenERP accounting after one of more years of using OpenERP for other purposes by changing the '_get_first_special_period' logic. Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717 Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Maxime Chambreuil (http://www.savoirfairelinux.com) Sent: zondag 3 november 2013 15:50 To: mp+172...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes into lp:account-financial-report Review: Disapprove Luc, Please refer to the community guidelines to get your contributions merged: https://doc.openerp.com/contribute/15_guidelines/contribution_guidelines/#merge-proposal-guidelines Work on a separate feature/bug/whatever at a time. Do not mix lots of changes in one merge proposal, as it will be too complicated to review, thus refused. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes/+merge/172359 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes/+merge/172359 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls into lp:account-financial-report
Why you didn't use python/openobject introspection to get the field definition, and they are wired in the code?, IMHO it is not a good approach. 1) OpenERP's field definitions are designed for GUI screen formatting not XLS. We could of course make an extension to the fields class to add rendering defaults for XLS, PDF, ... the 'report_xls' module is brand new, Rome hasn't been build in one day either, We'll add all good ideas into a roadmap and everyone is of course invited to contribute with ideas and/or code. 2) When we inherit from the underlying webkit/rml reports we may also use fields that are not defined as orm fields. My previour remark is more intended to facilitate simple XLS exports that do not inherit from a webkit or rml report (cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 for an example of this). Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Nhomar - Vauxoo Sent: woensdag 23 oktober 2013 0:33 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls into lp:account-financial-report Review: Needs Fixing Hello, More comments. In line #159 Why you didn't use python/openobject introspection to get the field definition, and they are wired in the code?, IMHO it is not a good approach. Regards. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls/+merge/192246 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit_xls/+merge/192246 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
I have updated branch https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls according to the technical recommendations. Regards, Luc -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexandre Fayolle - camptocamp Sent: donderdag 24 oktober 2013 10:13 To: mp+192...@code.launchpad.net Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report Review: Needs Fixing code review, no test Could you take the time to bring this to the 7.0 community addons coding conventions. This includes: * not using the shortcut imports (things in the openerp namespace need to be imported from openerp) * using the from . import xxx for relative imports (typically in __init__.py files) * using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory * not instanciating the model classes * following PEP8 for spacing, line wrapping, etc. Nice to have would be a couple of automated tests exercising the code. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/server-env-tools/7.0-report_xls into lp:server-env-tools
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/server-env-tools/7.0-report_xls into lp:server-env-tools.
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
For more details, see:
https://code.launchpad.net/~luc-demeyer/server-env-tools/7.0-report_xls/+merge/192242
add report_xls module.
--
https://code.launchpad.net/~luc-demeyer/server-env-tools/7.0-report_xls/+merge/192242
Your team Server Environment And Tools Core Editors is requested to review the
proposed merge of lp:~luc-demeyer/server-env-tools/7.0-report_xls into
lp:server-env-tools.
=== added directory 'report_xls'
=== added file 'report_xls/__init__.py'
--- report_xls/__init__.py 1970-01-01 00:00:00 +
+++ report_xls/__init__.py 2013-10-22 21:02:17 +
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+import report_xls
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'report_xls/__openerp__.py'
--- report_xls/__openerp__.py 1970-01-01 00:00:00 +
+++ report_xls/__openerp__.py 2013-10-22 21:02:17 +
@@ -0,0 +1,44 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+{
+'name': 'XLS report engine',
+'version': '0.3',
+'license': 'AGPL-3',
+'author': 'Noviat',
+'website': 'http://www.noviat.com',
+'category': 'Reporting',
+'description':
+
+This module adds XLS export capabilities to the standard OpenERP reporting engine.
+
+In order to generate an XLS export you can define a report of type 'xls' or alternatively pass {'xls_export' : 1) via the context to create method of the report.
+
+,
+'depends': ['base'],
+'external_dependencies': {'python': ['xlwt']},
+'demo_xml': [],
+'init_xml': [],
+'update_xml' : [],
+'active': False,
+'installable': True,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'report_xls/report_xls.py'
--- report_xls/report_xls.py 1970-01-01 00:00:00 +
+++ report_xls/report_xls.py 2013-10-22 21:02:17 +
@@ -0,0 +1,224 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into
lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
Your team Account Report Core Editors is requested to review the proposed merge
of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls
into lp:account-financial-report.
=== added directory 'account_move_line_report_xls'
=== added file 'account_move_line_report_xls/__init__.py'
--- account_move_line_report_xls/__init__.py 1970-01-01 00:00:00 +
+++ account_move_line_report_xls/__init__.py 2013-10-22 21:34:58 +
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+import account_move_line
+import report
=== added file 'account_move_line_report_xls/__openerp__.py'
--- account_move_line_report_xls/__openerp__.py 1970-01-01 00:00:00 +
+++ account_move_line_report_xls/__openerp__.py 2013-10-22 21:34:58 +
@@ -0,0 +1,38 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Account Move Line XLS export',
+'version': '0.2',
+'license': 'AGPL-3',
+'author': 'Noviat',
+'category' : 'Accounting Finance',
+'description':
+This module adds a button on the journal items ('account.move.line') list view in order to export the selected lines.
+,
+'depends': ['account', 'report_xls'],
+'demo_xml': [],
+'init_xml': [],
+'update_xml' : [
+'report/move_line_list_xls.xml',
+],
+}
=== added file 'account_move_line_report_xls/account_move_line.py'
--- account_move_line_report_xls/account_move_line.py 1970-01-01 00:00:00 +
+++ account_move_line_report_xls/account_move_line.py 2013-10-22 21:34:58 +
@@ -0,0 +1,36 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses
