[Bug 1946065] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1946065 --- Comment #4 from Eduardo Echeverria --- thanks Robert https://pagure.io/releng/fedora-scm-requests/issue/33361 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946041] Review Request: python-itemloaders - Library that helps you collect data from HTML and XML sources.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041 --- Comment #4 from Eduardo Echeverria --- Thanks Robert https://pagure.io/releng/fedora-scm-requests/issue/33360 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946041] Review Request: python-itemloaders - Library that helps you collect data from HTML and XML sources.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041 Eduardo Echeverria changed: What|Removed |Added Summary|Review Request: |Review Request: |python-itemloaders -Library |python-itemloaders - |that helps you collect data |Library that helps you |from HTML and XML sources. |collect data from HTML and ||XML sources. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946033] Review Request: python-protego - Pure-Python robots.txt parser with support for modern conventions
https://bugzilla.redhat.com/show_bug.cgi?id=1946033 --- Comment #4 from Eduardo Echeverria --- Thanks Robert https://pagure.io/releng/fedora-scm-requests/issue/33359 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946365] Review Request: butane - Butane config transpiler
https://bugzilla.redhat.com/show_bug.cgi?id=1946365 --- Comment #3 from Benjamin Gilbert --- Thanks for the reviews! > - Remove: > > %gopkg > > since you're not including it in %files, I guess you don't need it as a > library. Done. > %global gomodulesmode GO111MODULE=on Ah, great, I don't think that existed when FCCT was first packaged. Done. > export GOOS=darwin > export GOARCH=amd64 > %gobuild -o butane-x86_64-apple-darwin internal/main.go Unfortunately that doesn't seem to work for cross builds: /usr/lib/golang/pkg/tool/linux_amd64/link -o $WORK/b001/exe/a.out -importcfg $WORK/b001/importcfg.link -installsuffix shared -buildmode=pie -buildid=9wVtOu_M646dIl94S3eg/0oAfqKUuLR0ccS8QGUu2/ddJaS9ygXJ8nNUSB7BfF/9wVtOu_M646dIl94S3eg -X github.com/coreos/butane/internal/version.Raw=0.11.0 -X github.com/coreos/butane/version=0.11.0 -B 0x0639699e6466d45b198add371c7e00b3788f0cc2 -extldflags "-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld " -extld=gcc $WORK/b001/_pkg_.a # command-line-arguments /usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1 /usr/bin/ld: cannot find 1144: No such file or directory /tmp/go-link-378017167/go.o: file not recognized: file format not recognized collect2: error: ld returned 1 exit status > - One test fails on 32 bits arches: Whoops, good catch. That's an old bug that was uncovered by a new test in 0.11.0. Fixed. > the description could probably be updated to not talk just about FCOS now > that we're trying to be more generic. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944392] Review Request: rust-build-env - Extract information about the build process from the environment
https://bugzilla.redhat.com/show_bug.cgi?id=1944392 --- Comment #2 from Rémi Lauzier --- Done! https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-34-x86_64/02116476-rust-build-env/rust-build-env.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||python-drgn-0.0.11-2.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1943526] Review Request: libuev - Simple event loop for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1943526
--- Comment #16 from Otto Urpelainen ---
(In reply to Alessio from comment #14)
> Thank you for your patience and your advises.
>
> These are the new files:
> Spec URL: https://alciregi.fedorapeople.org/uredir/libuev.spec
> SRPM URL:
> https://alciregi.fedorapeople.org/uredir/libuev-2.3.2-1.fc34.src.rpm
Looks good. Only two points brought up by Robert-André Mauchin 🐧 are still
unresolved:
- Own %{_includedir}/uev/ or remove the glob. So you could do in %files simply
this and get both directory ownership and the contents installed (reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership):
%{_includedir}/uev
- explicitly BR make:
BuildRequires: make
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1919639] Review Request: DOSBox-X - DOS/x86 emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1919639 Robert changed: What|Removed |Added Flags|needinfo?(robert.de.rooy@gm | |ail.com)| --- Comment #39 from Robert --- Thanks Otto, I will in the next spin (might not be until the weekend...) remove the hardening and classify those files as doc. As to setcap, yes I know it gives that ignored error message during build, but it absolutely does do it during the RPM install. $ getcap /usr/bin/dosbox-x /usr/bin/dosbox-x cap_net_raw=ep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 --- Comment #6 from Fedora Update System --- FEDORA-2021-9a69bc6642 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9a69bc6642 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 --- Comment #5 from Fedora Update System --- FEDORA-2021-56abebfbea has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-56abebfbea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-drgn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 --- Comment #9 from Davide Cavalca --- Thanks! $ fedpkg request-repo python-drgn 1946660 https://pagure.io/releng/fedora-scm-requests/issue/33354 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Robert-André Mauchin 🐧 --- Ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919639] Review Request: DOSBox-X - DOS/x86 emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1919639 Otto Urpelainen changed: What|Removed |Added Flags||needinfo?(robert.de.rooy@gm ||ail.com) --- Comment #38 from Otto Urpelainen --- Thank you for the new specfile. I went through it. Findings that I missed earlier: - You are right about hardened build being the default. I apologize, my mistake. Adding the line about hardening should not be required. I sent a pull request for the Guidelines about this topic: https://pagure.io/packaging-committee/pull-request/1064 - I think these files are actually documentation and it would be better to install them with %doc so they would go to documentation directory instead of data (assuming that there are not actually needed at runtime): /usr/share/dosbox-x/CHANGELOG /usr/share/dosbox-x/dosbox-x.reference.conf /usr/share/dosbox-x/dosbox-x.reference.full.conf - I see the following in build.log, perhaps you want to check if the capability setting script actually achieved its purpose? test -x /usr/sbin/setcap && setcap cap_net_raw=ep /builddir/build/BUILDROOT/dosbox-x-0.83.12-2.fc35.x86_64/usr/bin/dosbox-x unable to set CAP_SETFCAP effective capability: Operation not permitted make: [Makefile:906: install] Error 1 (ignored) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 --- Comment #7 from Davide Cavalca --- We're gonna leave the ExcludeArch in place for now, besides the test failures we need to actually validate that drgn works properly on these platforms before enabling them. I'll file blocking bugs to track this per policy once the package is imported. Spec URL: https://dcavalca.fedorapeople.org/review/python-drgn/python-drgn.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-drgn/python-drgn-0.0.11-2.fc35.src.rpm Changelog: - Make doc subpackage noarch - Add license file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 Germano Massullo changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2021-04-06 21:07:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #10 from Robert-André Mauchin 🐧 ---
- /etc → %{_sysconfdir}
- Use install -p to keep timestamps
- Why are you doing this:
cp conf/rudo ~/
cp conf/rudo.conf ~/
cp man/rudo.1 ~/
cp man/rudo.conf.5 ~/
instead of just installing them from their current location?
mkdir -p %{buildroot}%{_sysconfdir}
mkdir -p %{buildroot}%{_sysconfdir}/pam.d/
mkdir -p %{buildroot}%{_mandir}/man1
mkdir -p %{buildroot}%{_mandir}/man5
install -pm 0640 cp conf/rudo.conf %{buildroot}%{_sysconfdir}/rudo.conf
install -pm 0644 conf/rudo %{buildroot}%{_sysconfdir}/pam.d/rudo
install -pm 0644 man/rudo.1 %{buildroot}%{_mandir}/man1/rudo.1
install -pm 0644 man/rudo.conf.5 %{buildroot}%{_mandir}/man5/rudo.conf.5
- This is not needed anymore:
echo "pam-devel"
echo "systemd-devel"
pam-devel is implied by the rust-pam-sys dep and systemd-devel by the
rust-libsystemd-sys dep
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1944463] Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM)
https://bugzilla.redhat.com/show_bug.cgi?id=1944463 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin 🐧 --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/memleax -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1943526] Review Request: libuev - Simple event loop for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1943526
--- Comment #15 from Robert-André Mauchin 🐧 ---
(In reply to Alessio from comment #11)
> Since there are two so files (libuev.so.2.2.0 and libuev.so.2), using
> %{_libdir}/%{name}.so.2* is ok?
> Thanks.
Yes it is ok.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||golang-github-insomniacslk- ||termhook-0-0.1.20210406gita ||267c97.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1919639] Review Request: DOSBox-X - DOS/x86 emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1919639 --- Comment #37 from Otto Urpelainen --- (In reply to Gregory PAKOSZ from comment #35) > Though it shouldn't be necessary: IANAL but WTFPL v2 is supposed to be > compatible with GPL v2 and v3. It's at least listed as such by Fedora: > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses Hi Gregory, That is right, whereami's license is ok for Fedora, either of the given options would work actually. The problem I have with the licenses is not that dosbox-x could not be included in Fedora. It is just that the licenses should be listed correctly in specfile Licenses field, and the conditions for each license fulfilled. A very common case is that popular permissive licenses like MIT, BSD, APL2 all require distributing the original copyright and permissions notices with the source or compiled program. When a project bundles it dependencies like dosbox-x does, this results in requirement to include a lot of those notices. As an example, consider the Visual Studio Code notices file (from some old version, the current one is much longer): https://gist.github.com/dm/e5581d6c37b408c819ec Another example would be this Oracle HTTP Server docs page, fulfilling the license conditions of open source software they have used: https://docs.oracle.com/cd/B14117_01/server.101/b12255/license.htm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 --- Comment #4 from Germano Massullo --- Thank you Robert-André for your quick review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-insomniacslk-termhook -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 --- Comment #3 from Davide Cavalca --- Thanks! $ fedpkg request-repo golang-github-insomniacslk-termhook 1946664 https://pagure.io/releng/fedora-scm-requests/issue/33345 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 --- Comment #2 from Germano Massullo --- https://germano.fedorapeople.org/package_reviews/memleax/v2/memleax.spec https://germano.fedorapeople.org/package_reviews/memleax/v2/memleax-1.1.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944422] Review Request: rust-systemd - A rust interface to libsystemd/libelogind provided APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1944422 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Robert-André Mauchin 🐧 --- Using https://copr-be.cloud.fedoraproject.org/results/remilauzier/rudo/fedora-34-x86_64/02113879-rust-systemd/rust-systemd.spec - You need to fix this: # Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0 # License file not in crate bug: https://github.com/jmesmon/rust-systemd/issues/186 License:LGPLv2+ WITH [identifier] with exceptions # FIXME: Upstream uses unknown SPDX tag WITH! → # Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0 # License file not in crate bug: https://github.com/jmesmon/rust-systemd/issues/186 License:LGPLv2 with exceptions - This won't be necessary: echo "systemd-devel" once you Requires: systemd-devel in rust-libsystemd-sys - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Please fix the aforementioned issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944412] Review Request: rust-utf8-cstr - Type wrappers promising null termination and utf-8 validity. The intersection of `std::ffi::CStr` and `str`
https://bugzilla.redhat.com/show_bug.cgi?id=1944412 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin 🐧 --- Using https://copr-be.cloud.fedoraproject.org/results/remilauzier/rudo/fedora-34-x86_64/02113878-rust-utf8-cstr/rust-utf8-cstr.spec - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946547] Review Request: nwg-panel - GTK3-based panel for sway window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1946547 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2021-ba222667a0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ba222667a0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944403] Review Request: rust-enum-repr - Derive enum repr conversions compatible with type aliases.
https://bugzilla.redhat.com/show_bug.cgi?id=1944403 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin 🐧 --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944398] Review Request: rust-cstr-argument - A trait for converting function arguments to null terminated strings
https://bugzilla.redhat.com/show_bug.cgi?id=1944398 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin 🐧 --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946547] Review Request: nwg-panel - GTK3-based panel for sway window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1946547 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nwg-panel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind
https://bugzilla.redhat.com/show_bug.cgi?id=1944408
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 ---
Using
https://copr-be.cloud.fedoraproject.org/results/remilauzier/rudo/fedora-34-x86_64/02113875-rust-libsystemd-sys/rust-libsystemd-sys.spec
- You need to Requires: systemd-devel so it is included in the build process
for other packages:
%packagedevel
Summary:%{summary}
BuildArch: noarch
Requires: systemd-devel
%descriptiondevel %{_description}
This package contains library source intended for building other packages
which use "%{crate}" crate.
Thus you won't need to add:
echo "systemd-devel"
in dependent packages.
- This needs to be fixed:
# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
License:LGPLv2+ WITH [identifier] with exceptions
# FIXME: Upstream uses unknown SPDX tag WITH!
- Don't mix tabs and spaces, remove the tabs added here:
Source1:
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/README.md
Source2:
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/COPYING
- Macros prefixed by two underscores are for RPM private use only, use the
actual binary instead:
cp %{SOURCE1} README.md
cp %{SOURCE2} COPYING
→
# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
# https://github.com/jmesmon/rust-systemd/issues/185
License:LGPLv2+ with exceptions
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1944392] Review Request: rust-build-env - Extract information about the build process from the environment
https://bugzilla.redhat.com/show_bug.cgi?id=1944392 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin 🐧 --- - Please add the link to the license request in the SPEC: # Upstream license specification: Apache-2.0 OR MIT # https://github.com/jmesmon/build-env/issues/7 License:ASL 2.0 or MIT - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 Robert-André Mauchin 🐧 changed: What|Removed |Added Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags|needinfo?(zebo...@gmail.com |fedora-review? |) | --- Comment #6 from Robert-André Mauchin 🐧 --- Yes I'll take it: - the GitHub repo actually has a COPYING file, but this does not end up in the tarball from PyPI. I'd suggest adding it as an additional SOURCE (pointing to https://raw.githubusercontent.com/osandov/drgn/master/COPYING) and including it in drgn and drgn-doc (since the latter does not require the former). And/or file an issue upstream asking for it to be added to the PyPI archive This is a good point, I had missed it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 Michel Alexandre Salim changed: What|Removed |Added CC||mic...@michel-slm.name Flags||needinfo?(zebo...@gmail.com ||) --- Comment #5 from Michel Alexandre Salim --- (In reply to Robert-André Mauchin 🐧 from comment #4) zebob, do you want to officially mark yourself as the reviewer? I have similar notes: - -doc could be noarch - the GitHub repo actually has a COPYING file, but this does not end up in the tarball from PyPI. I'd suggest adding it as an additional SOURCE (pointing to https://raw.githubusercontent.com/osandov/drgn/master/COPYING) and including it in drgn and drgn-doc (since the latter does not require the former). And/or file an issue upstream asking for it to be added to the PyPI archive - If examples are fully working I guess they're not really %doc, fair enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 --- Comment #4 from Robert-André Mauchin 🐧 --- (In reply to Davide Cavalca from comment #3) > Thanks! > > For examples and tools, I was following the same model that bcc-tools uses, > which is to put the scripts under /usr/share. The examples here are fully > working drgn scripts that could be useful in their own right, so it seems > reasonable to install them alongside. And putting this stuff in /usr/bin > would get confusing fast (e.g. drgn ships a lsmod script under examples). > Ok. > For the ExcludeArch, I'll check with upstream. I put them in out of caution > as the test failures looked like legitimate issues, and I'm not sure drgn > would work properly on those arches as-is. Let me know when you have an answer. ExcludeArch should be last resort. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin 🐧 --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946253] Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API
https://bugzilla.redhat.com/show_bug.cgi?id=1946253 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-04-06 17:47:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 --- Comment #3 from Davide Cavalca --- Thanks! For examples and tools, I was following the same model that bcc-tools uses, which is to put the scripts under /usr/share. The examples here are fully working drgn scripts that could be useful in their own right, so it seems reasonable to install them alongside. And putting this stuff in /usr/bin would get confusing fast (e.g. drgn ships a lsmod script under examples). For the ExcludeArch, I'll check with upstream. I put them in out of caution as the test failures looked like legitimate issues, and I'm not sure drgn would work properly on those arches as-is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660
Robert-André Mauchin 🐧 changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Robert-André Mauchin 🐧 ---
- The doc package should be noarch:
%if %{with docs}
%package -n %{pypi_name}-doc
Summary:%{pypi_name} documentation
BuildArch: noarch
Requires: python3-docs
%description -n %{pypi_name}-doc
Documentation for %{pypi_name}.
%endif
- I'd rather you disable the problematic tests than use ExcludeArch:
# https://github.com/osandov/drgn/issues/98
ExcludeArch:armv7hl i686
# https://github.com/osandov/drgn/issues/99
ExcludeArch:s390x
%if %{with tests}
%check
%pytest -k "not test_set_pid and not test_union and not test_read_float"
%endif
- Shouldn't the example be in %doc:
cp -PR examples tools %{buildroot}%{_datadir}/drgn
And tools/bpf_inspect.py in %{_bindir}?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v3.0 or
later", "GNU General Public License, Version 3", "[generated file]",
"FSF Unlimited License (with Retention) GNU General Public License
v2.0 or later [generated file]", "FSF Unlimited License [generated
file]", "Expat License", "GNU General Public License v2.0 or later
[generated file]", "Expat License [generated file]", "GNU General
Public License v2.0 or later", "GNU Lesser General Public License",
"GNU Lesser General Public License v2.1 or later", "FSF Unlimited
License (with Retention) GNU General Public License, Version 2", "FSF
Unlimited License (with Retention)". 190 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/python-
drgn/review-python-drgn/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{bu
[Bug 1946172] Review Request: python-nashpy - A library to compute equilibria of 2 player normal form games
https://bugzilla.redhat.com/show_bug.cgi?id=1946172 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2021-f05b8646c6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f05b8646c6 --- Comment #6 from Fedora Update System --- FEDORA-2021-78e3dcf1e2 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-78e3dcf1e2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 --- Comment #7 from Fedora Update System --- FEDORA-2021-ced698da3c has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ced698da3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 --- Comment #7 from Fedora Update System --- FEDORA-2021-c3819d0227 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-c3819d0227 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946655] Review Request: rust-qstring - Query string parser
https://bugzilla.redhat.com/show_bug.cgi?id=1946655
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 ---
- Please split the license from the README.md:
%files devel
%doc README.md
%license LICENSE
%{cargo_registry}/%{crate}-%{version_no_tilde}/
[…]
%prep
%autosetup -n %{crate}-%{version_no_tilde} -p1
%cargo_prep
sed -e '0,/^### MIT License/d' README.md > LICENSE
- Please add your email in the changelog:
* Tue Apr 06 17:10:32 CEST 2021 Jens Reimann - 0.7.2-1
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package approved. Please fix the aforementioned issues before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 --- Comment #6 from Fedora Update System --- FEDORA-2021-b5309245c8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b5309245c8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 --- Comment #6 from Fedora Update System --- FEDORA-2021-4d1846b4e7 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4d1846b4e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-41f5ca36b8 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-41f5ca36b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 --- Comment #5 from Fedora Update System --- FEDORA-2021-146449f4bb has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-146449f4bb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946547] Review Request: nwg-panel - GTK3-based panel for sway window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1946547
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 129 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/nwg-panel/review-nwg-panel/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgve
[Bug 1946499] Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499
Robert-André Mauchin 🐧 changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 ---
- ExclusiveArch: x86 x86_64 aarch64 ARM-hfp
→
ExclusiveArch: %{ix86} x86_64 aarch64 armv7hl
- The archive could notbe found:
404 Client Error: Not Found for url:
https://github.com/WuBingzheng/memleax/releases/download/release-1.1.1/memleax-1.1.1.tar.gz
It should be:
Source0:
https://github.com/WuBingzheng/memleax/archive/v%{version}/%{name}-%{version}.tar.gz
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GNU General Public License, Version 2", "Unknown or
generated". 29 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/memleax/review-
memleax/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[Bug 1946172] Review Request: python-nashpy - A library to compute equilibria of 2 player normal form games
https://bugzilla.redhat.com/show_bug.cgi?id=1946172 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-nashpy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946253] Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API
https://bugzilla.redhat.com/show_bug.cgi?id=1946253 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cryptoki -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946664] New: Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1946664 Bug ID: 1946664 Summary: Review Request: golang-github-insomniacslk-termhook - Simple terminal that allows attaching hooks Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-insomniacslk-termhook/golang-github-insomniacslk-termhook.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-insomniacslk-termhook/golang-github-insomniacslk-termhook-0-0.1.20210406gita267c97.fc35.src.rpm Description: termhook is a small library that attaches to a terminal, serial console or other similar device, and lets you attach your own hook on terminal output. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 Davide Cavalca changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||golang-mvdan-editorconfig-0 ||.2.0-1.fc35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946365] Review Request: butane - Butane config transpiler
https://bugzilla.redhat.com/show_bug.cgi?id=1946365 Jonathan Lebon changed: What|Removed |Added CC||jle...@redhat.com --- Comment #2 from Jonathan Lebon --- I've verified that the Obsoletes and Provides are what we expect as per https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages. Definitely not a blocker, but the description could probably be updated to not talk just about FCOS now that we're trying to be more generic. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946365] Review Request: butane - Butane config transpiler
https://bugzilla.redhat.com/show_bug.cgi?id=1946365 Robert-André Mauchin 🐧 changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin 🐧 --- - Remove: %gopkg since you're not including it in %files, I guess you don't need it as a library. - Since you are bundling I think you could build with GO111MODULE=on %global gomodulesmode GO111MODULE=on This hack is then unnecessary: # With GO111MODULE=off, as set by %%gobuild, `go build` can't find the pflag # package in the vendor directory. strace shows that it doesn't even look # in vendor/. This doesn't happen with other dependencies, and I have no # explanation. Hack around it by explicitly including pflag in the GOPATH. # mkdir -p %gobuilddir/src/github.com/spf13 # ln -s ../../../../vendor/github.com/spf13/pflag %gobuilddir/src/github.com/spf13/pflag - Why do you redefine gobuild for the cross compilation, just doing: echo "Building macOS Butane..." export GOOS=darwin export GOARCH=amd64 %gobuild -o butane-x86_64-apple-darwin internal/main.go echo "Building Windows Butane..." export GOOS=windows export GOARCH=amd64 %gobuild -o butane-x86_64-pc-windows-gnu.exe internal/main.go should work. Is there something I'm missing there? - One test fails on 32 bits arches: --- FAIL: TestReportCorrelation (0.02s) validate_test.go:239: Error Trace:validate_test.go:239 Error: Not equal: expected: 8 actual : 2 Test: TestReportCorrelation Messages: #4: incorrect error line, raw false FAIL exit status 1 See https://koji.fedoraproject.org/koji/taskinfo?taskID=65319224 https://koji.fedoraproject.org/koji/taskinfo?taskID=65319223 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946660] New: Review Request: python-drgn - Scriptable debugger library
https://bugzilla.redhat.com/show_bug.cgi?id=1946660 Bug ID: 1946660 Summary: Review Request: python-drgn - Scriptable debugger library Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/python-drgn/python-drgn.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-drgn/python-drgn-0.0.11-1.fc35.src.rpm Description: drgn (pronounced "dragon") is a debugger with an emphasis on programmability. drgn exposes the types and variables in a program for easy, expressive scripting in Python. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946655] New: Review Request: rust-qstring - Query string parser
https://bugzilla.redhat.com/show_bug.cgi?id=1946655 Bug ID: 1946655 Summary: Review Request: rust-qstring - Query string parser Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jreim...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dentrassi.de/download/rust-qstring/rust-qstring.spec SRPM URL: https://dentrassi.de/download/rust-qstring/rust-qstring-0.7.2-1.fc35.src.rpm Description: Query string parser. Fedora Account System Username: ctron -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946128] Review Request: logitech-27mhz-keyboard-encryption-setup - Logitech 27MHz keyboard encryption setup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1946128 --- Comment #6 from Fedora Update System --- FEDORA-2021-6e13576ef0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6e13576ef0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946128] Review Request: logitech-27mhz-keyboard-encryption-setup - Logitech 27MHz keyboard encryption setup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1946128 --- Comment #5 from Fedora Update System --- FEDORA-2021-ff3af89728 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ff3af89728 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946128] Review Request: logitech-27mhz-keyboard-encryption-setup - Logitech 27MHz keyboard encryption setup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1946128 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2021-449579e021 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-449579e021 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-mvdan-editorconfig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pkg-diff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 --- Comment #3 from Davide Cavalca --- Thanks! $ fedpkg request-repo golang-mvdan-editorconfig 1946155 https://pagure.io/releng/fedora-scm-requests/issue/33329 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 --- Comment #3 from Davide Cavalca --- Thanks! $ fedpkg request-repo golang-github-pkg-diff 1946151 https://pagure.io/releng/fedora-scm-requests/issue/33328 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946238] Review Request: openssh-ldap-authkeys - Python script to generate SSH authorized_keys files using an LDAP directory
https://bugzilla.redhat.com/show_bug.cgi?id=1946238 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-EPEL-2021-21601a5c69 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-21601a5c69 --- Comment #4 from Fedora Update System --- FEDORA-2021-3813e8f143 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3813e8f143 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946238] Review Request: openssh-ldap-authkeys - Python script to generate SSH authorized_keys files using an LDAP directory
https://bugzilla.redhat.com/show_bug.cgi?id=1946238 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-EPEL-2021-21601a5c69 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-21601a5c69 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946155] Review Request: golang-mvdan-editorconfig - EditorConfig support in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1946155 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin 🐧 --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946151] Review Request: golang-github-pkg-diff - Create, modify, and print diffs
https://bugzilla.redhat.com/show_bug.cgi?id=1946151 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin 🐧 --- - You shouldn't provide the following file in %global godocs: todo.go cxtx/todo.go write/todo.go - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Please fix the aforementioned issue before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1941994] Review Request: cockpit-machines - Cockpit component for managing virtual machines (split out from existing cockpit package)
https://bugzilla.redhat.com/show_bug.cgi?id=1941994 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2021-f8e5a0b546 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f8e5a0b546 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946253] Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API
https://bugzilla.redhat.com/show_bug.cgi?id=1946253 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946172] Review Request: python-nashpy - A library to compute equilibria of 2 player normal form games
https://bugzilla.redhat.com/show_bug.cgi?id=1946172 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944471] Review Request: golang-github-racingmars-go3270 - 3270 server library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1944471 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-04-06 14:02:39 --- Comment #11 from Fedora Update System --- FEDORA-2021-f1742ea6cb has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922806] Review Request: wormhole-william - End-to-end encrypted file transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922806 Bug 1922806 depends on bug 1922804, which changed state. Bug 1922804 Summary: Review Request: golang-salsa-debian-vasudev-gospake2 - Go SPAKE2 Implementation https://bugzilla.redhat.com/show_bug.cgi?id=1922804 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922804] Review Request: golang-salsa-debian-vasudev-gospake2 - Go SPAKE2 Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1922804 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-04-06 14:02:19 --- Comment #10 from Fedora Update System --- FEDORA-2021-25bee9c6c5 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922790] Review Request: golang-fyne - Cross platform GUI in Go based on Material DesignCross platform GUI in Go based on Material Design
https://bugzilla.redhat.com/show_bug.cgi?id=1922790 Bug 1922790 depends on bug 1922794, which changed state. Bug 1922794 Summary: Review Request: golang-github-fyne-io-glfw - Go bindings for GLFW 3 https://bugzilla.redhat.com/show_bug.cgi?id=1922794 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922794] Review Request: golang-github-fyne-io-glfw - Go bindings for GLFW 3
https://bugzilla.redhat.com/show_bug.cgi?id=1922794 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-04-06 14:02:16 --- Comment #9 from Fedora Update System --- FEDORA-2021-55c9b4f7bf has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946033] Review Request: python-protego - Pure-Python robots.txt parser with support for modern conventions
https://bugzilla.redhat.com/show_bug.cgi?id=1946033 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946041] Review Request: python-itemloaders -Library that helps you collect data from HTML and XML sources.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 ---
- You need to split the description to stay below 80 characters per line:
%global desc %{expand:
Itemloaders is a library that helps you collect data from HTML and XML sources.
It comes in handy to extract data from web pages, as it supports data
extraction
using CSS and XPath Selectors.
It's specially useful when you need to standardize the data from many sources.
For example, it allows you to have all your casting and parsing rules in a
single place.}
Package approved, please fix the aforementioned issue before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1946065] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1946065 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin 🐧 --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1927033] Review Request: eth-tools - Intel Ethernet Fast Fabric Tools
https://bugzilla.redhat.com/show_bug.cgi?id=1927033 --- Comment #16 from Jijun Wang --- (In reply to Honggang LI from comment #14) > @Jijun, please also build the package for Fedora 34. thanks Build the package for f34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=65308893) just before the final freeze. Hopefully it's in f34. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1927033] Review Request: eth-tools - Intel Ethernet Fast Fabric Tools
https://bugzilla.redhat.com/show_bug.cgi?id=1927033 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #15 from Fedora Update System --- FEDORA-2021-ceac7860ec has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ceac7860ec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946238] Review Request: openssh-ldap-authkeys - Python script to generate SSH authorized_keys files using an LDAP directory
https://bugzilla.redhat.com/show_bug.cgi?id=1946238 --- Comment #1 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openssh-ldap-authkeys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946128] Review Request: logitech-27mhz-keyboard-encryption-setup - Logitech 27MHz keyboard encryption setup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1946128 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/logitech-27mhz-keyboard-encryption-setup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942126] Review Request: rubygem-protobuf - Google Protocol Buffers serialization and RPC implementation for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1942126 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-protobuf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1908922] Review Request: libopenaptx - Open Source implementation of Audio Processing Technology codec (aptX)
https://bugzilla.redhat.com/show_bug.cgi?id=1908922 Linus Lewandowski changed: What|Removed |Added CC||li...@lew21.net --- Comment #17 from Linus Lewandowski --- aptX was created by Audio Processing Technology Ltd (a subsidiary of Solid State Logic Ltd) in 1990s - see https://www.aptx.com/history and https://patents.google.com/patent/EP0398973B1/en (the expired patent mentioned earlier) APT Ltd was sold - (one can safely assume: together with all the patents required for aptX) - in 2005: https://www.mixonline.com/technology/solid-state-logic-sells-apt-381257 There is only one patent assigned to APT Ltd: https://patents.google.com/?assignee=Audio+Processing+Technology+Limited - it's the expired one (EP0398973B1). The original owner - Solid State Logic Ltd - had some more patents: https://patents.google.com/?assignee=Solid+State+Logic - but they're all expired, except for one from 2020. So... I'm pretty sure that there is no other patent that affects aptX itself. There might still be something affecting aptX LL (launched in 2012) and aptX HD (launched in 2016) - but they aren't really innovative. aptX LL is the trivial merge of the idea behind CSR FastStream (launched in 2008, https://web.archive.org/web/20080509054609/www.csr.com/pr/pr328.htm) and the aptX codec. FastStream looks like patent-free, because it's referred to in https://patents.google.com/patent/US9398620B1/en (expired), and this patent does not depend on any other related patent - while it describes how to use FastStream in a selected use case. aptX HD seems to just be a different set of settings for the aptX algorithm, but I'm not really sure here, I haven't looked at the code. On the other hand, aptX Adaptive (launched in 2018) might be innovative - it introduces variable bit rate - so I wouldn't recommend adding it at this point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946547] Review Request: nwg-panel - GTK3-based panel for sway window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1946547 Artem changed: What|Removed |Added CC||alebast...@gmail.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946547] New: Review Request: nwg-panel - GTK3-based panel for sway window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1946547 Bug ID: 1946547 Summary: Review Request: nwg-panel - GTK3-based panel for sway window manager Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://atim.fedorapeople.org/nwg-panel.spec SRPM URL: https://atim.fedorapeople.org/nwg-panel-0.2.1-1.fc34.src.rpm Description: I have been using sway since 2019 and find it the most comfortable working environment, but... Have you ever missed all the graphical bells and whistles in your panel, we used to have in tint2? It happens to me. That's why I decided to try to code a GTK-based panel, including best features from my two favourites: Waybar and tint2. Many thanks to Developers and Contributors of the both projects! There are 8 modules available at the moment, and I don't plan on many more. Basis system controls are available in the Controls module, and whatever else you may need, there's an executor for that. Fedora Account System Username: atim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library
https://bugzilla.redhat.com/show_bug.cgi?id=1944554 Jitka Plesnikova changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1942034] Review Request: rust-tss-esapi-sys - FFI wrapper around TSS 2.0 Enhanced System API
https://bugzilla.redhat.com/show_bug.cgi?id=1942034 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-04-06 11:07:45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946499] New: Review Request: memleax - Debugs memory leak of a running process
https://bugzilla.redhat.com/show_bug.cgi?id=1946499 Bug ID: 1946499 Summary: Review Request: memleax - Debugs memory leak of a running process Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: germano.massu...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora memleax - Debugs memory leak of a running process SRPM https://germano.fedorapeople.org/package_reviews/memleax/memleax-1.1.1-1.fc33.src.rpm SPEC https://germano.fedorapeople.org/package_reviews/memleax/memleax.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946087] Review Request: R-webfakes - Fake Web Apps for HTTP Testing
https://bugzilla.redhat.com/show_bug.cgi?id=1946087 --- Comment #5 from Fedora Update System --- FEDORA-2021-66a9aa01b1 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-66a9aa01b1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946128] Review Request: logitech-27mhz-keyboard-encryption-setup - Logitech 27MHz keyboard encryption setup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1946128 --- Comment #2 from Hans de Goede --- zebob, thank you for the quick review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1944117] Review Request: gnome-shell-extension-no-overview - GNOME Shell extension for no overview at startup
https://bugzilla.redhat.com/show_bug.cgi?id=1944117 --- Comment #4 from fujiwara --- Updated; https://fujiwara.fedorapeople.org/gnome-shell/gnome-shell-extension-no-overview-4-3.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1946238] Review Request: openssh-ldap-authkeys - Python script to generate SSH authorized_keys files using an LDAP directory
https://bugzilla.redhat.com/show_bug.cgi?id=1946238 Igor Raits changed: What|Removed |Added Status|NEW |POST CC||igor.ra...@gmail.com Assignee|nob...@fedoraproject.org|igor.ra...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
