Re: Review Request 119964: Avoid dlopening plasmaadapter's devel symlink

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119964/
---

(Updated Aug. 28, 2014, 7:39 a.m.)


Review request for Plasma.


Changes
---

include binary dir


Bugs: 335904
http://bugs.kde.org/show_bug.cgi?id=335904


Repository: plasma-mediacenter


Description
---

Some distro's have PMC splitted to main and devel subpackage, in that case the 
lib to dlopen was not available to users w/o devel package installed, and made 
the bug exposed to them.


Diffs (updated)
-

  CMakeLists.txt 0f8138a 
  config-plasma-mediacenter.h.cmake PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 76578fc 
  libs/plasmaadapter/CMakeLists.txt 18059ce 
  shells/newshell/CMakeLists.txt 287d780 
  shells/newshell/mainwindow.cpp 9350f5c 

Diff: https://git.reviewboard.kde.org/r/119964/diff/


Testing (updated)
---

builds + resolves the bug


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119964: Avoid dlopening plasmaadapter's devel symlink

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119964/
---

Review request for Plasma.


Bugs: 335904
http://bugs.kde.org/show_bug.cgi?id=335904


Repository: plasma-mediacenter


Description
---

Some distro's have PMC splitted to main and devel subpackage, in that case the 
lib to dlopen was not available to users w/o devel package installed, and made 
the bug exposed to them.


Diffs
-

  CMakeLists.txt 0f8138a 
  config-plasma-mediacenter.h.cmake PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 76578fc 
  libs/plasmaadapter/CMakeLists.txt 18059ce 
  shells/newshell/mainwindow.cpp 9350f5c 

Diff: https://git.reviewboard.kde.org/r/119964/diff/


Testing
---

none yet


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Philipp Stefan]

I think I should maybe clarify a few things here as I feel that my 
original post has left behind the idea in some that we sought a solution 
in search for a problem.
So what is the problem we are trying to solve? The problem is that 
currently the system tray icons behave unpredictable to the user or 
formulated differently: The user can not predict the status of an 
application based on where its icon shows up in the system tray, so the 
burden of differentiating and rating if an application provides 
important information lays on the user instead of the 
application/application developer. This problem exists to some extent in 
the panel part of the system tray, but it is most apparent in the popup.


In the popup we have plasmoids which hold no information for the user 
except when they do, like the battery plasmoid when the battery is fully 
charged but is still used to adjust the monitor brightness. The same 
thing can be said about status notifiers. So the popup loses its 
function as an area for information that is still somewhat relevant to 
the user, but not relevant enough to warrant constant display, because 
the actual important parts are buried beneath a flood of icons/notifiers 
with no relevant information at all.

The idea of this area is sound, but it does not work with the tool at hand.

The very best solution would be to add a 4th state to SNI, a 
"needsHiding" state, if you will. However, we share this specification 
with another DE, Unity. So there are several possibilities how things 
could play out:


1. Canonical accepts the changes and changes their system tray to
   accommodate the new behaviour. All applications using status
   notifiers would have to be adapted. This would also solve the issue
   that some KDE applications' notifier is broken in Unity e.g.
   KTorrent. I'm not sure how realistic this option is, given that they
   seem very happy with how their implementation works.
2. We adopt Unity's policy in handling the "passive" status. Only some
   applications like KTorrent would have to be adapted, but would now
   be working in both Plasma and Unity again.
3. We add a 4th status to SNI without Canonical's agreement. We'd end
   up with xembed, GNOME Shell's thing, appindicators, and our new SNI
   – 4 with each other incompatible solutions. The only place where we
   can realistically pull this off is system tray plasmoids, as they
   would not work in Unity anyway to my information.
4. Do nothing, the system tray popup remains as cluttered and space
   wasting as always.


Another thing to clarify: The proposal of the changes on plasmoids and 
status notifiers are _not_ independent of each other. If the changes to 
plasmoids are accepted, then we would have improved the their 
usefulness, but the overall problem would still be there. We need to 
have a way to separate the useful "passive" icons from the useless in 
order to improve the situation.
We think that the most realistic option is 2., but the best solution 
would of course be 1. I have tried to reach out to Canonical, but I had 
not much luck, probably because I do not know the right people.
What's important to note is that we really did not came up with this out 
of the blue, and we did assess the situation, what applications are 
doing and why. We really just want to improve the situation and think 
that 2. is the most realistic option while encompassing relatively 
little work.


We don't like to break work flows either. If we can pull of 1. that 
would be rad, but I really doubt it's going to happen any time soon.


Cheers
Phil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Request: better override functionality in locale settings

[Thomas Pfeiffer]

On Wednesday 27 August 2014 11:34:52 Sebastian Kügler wrote:
> > In my opinion, this is a very serious usability regression and would
> > stop me from using Plasma 5. Are there any plans to change the
> > behavior/appearance of this settings applet?
> 
> I don't know what it is, but anytime someome doesn't like something, it's
> "usability" all of a sudden. Usability has a strict meaning, and translating
> it to "I don't use it, but I don't like it, so it's bad usability" isn't
> very useful.
> 
> I understand that it changes you way you set up your system, of course.

Actually, while the fact that choosing formats and units by locale instead of 
directly isn't necessarily a usability problem, presenting all locales in a 
single drop-down _is_ .
See also the HIG for drop-down lists [1] which says "For a single selection 
out of a large number of items (n>20), use a list view". This is because, as 
Matthew stated, scrolling through a huge list inside a drop-down is very very 
cumbersome.
I've just filed a bug about this issue [1]. 

The above being said, I do understand that people who e.g. prefer the metric 
system though they live in a region that uses the imperial system by default 
might find it unnecessarily intricate to find out which region uses their 
preferred system first.
The benefits of using the POSIX-compliant locale system instead of custom 
formats selection still outweigh the costs from my point of view, but maybe we 
can find a way for people to make it easier for them to switch to common 
formats?
Could we maybe put a hint somewhere that e.g. en_DK might give people what 
they need at least for the date and time formats?

[1] https://bugs.kde.org/show_bug.cgi?id=338599


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid

[Martin Yrjölä]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/
---

(Updated Aug. 27, 2014, 5:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Repository: kdeplasma-addons


Description
---

Port systemloadviewer plasmoid

It had a VDG makeover and now there's also circular monitors available in the 
options.

There are regressions as well. These features aren't yet implemented:
- Horizontal bar support
- Individual monitors for each cpu

Probably there are some optimizations to be done. I'm not really sure how I 
should handle the two types of monitors (bar, circular) correctly. Now I just 
hide the one that is not enabled in the options.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
PRE-CREATION 
  applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
9324d4216e716b2156f5f084c8b4782a6dd84806 
  applets/systemloadviewer/systemloadviewer.h 
9bbcf2305ef47dd888362a9b65954ba65a74 
  applets/systemloadviewer/systemloadviewer.cpp 
bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
PRE-CREATION 
  
applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml 
PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/CircularMonitor.qml PRE-CREATION 
  applets/systemloadviewer/Messages.sh b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
  applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
  applets/systemloadviewer/coloursconfig.ui 
70a08afbaa204bb78865a545965210f3e2dfe42a 
  applets/systemloadviewer/generalconfig.ui 
2ae6d6540a12203e73bab5ca930da751f94bde22 
  applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
  applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
  applets/systemloadviewer/CMakeLists.txt 
6de867aa63e5102a5085667f8106ec09da2c4968 

Diff: https://git.reviewboard.kde.org/r/119927/diff/


Testing
---

Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
monitor is not pixel perfect because of the edge roundings. I haven't been able 
to test if this plasmoid works with high DPI monitors.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png


Thanks,

Martin Yrjölä

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid

[Martin Yrjölä]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/
---

(Updated Aug. 27, 2014, 4:49 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Addressed the final issues


Repository: kdeplasma-addons


Description
---

Port systemloadviewer plasmoid

It had a VDG makeover and now there's also circular monitors available in the 
options.

There are regressions as well. These features aren't yet implemented:
- Horizontal bar support
- Individual monitors for each cpu

Probably there are some optimizations to be done. I'm not really sure how I 
should handle the two types of monitors (bar, circular) correctly. Now I just 
hide the one that is not enabled in the options.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
PRE-CREATION 
  applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
9324d4216e716b2156f5f084c8b4782a6dd84806 
  applets/systemloadviewer/systemloadviewer.h 
9bbcf2305ef47dd888362a9b65954ba65a74 
  applets/systemloadviewer/systemloadviewer.cpp 
bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
PRE-CREATION 
  
applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml 
PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
  applets/systemloadviewer/package/contents/ui/CircularMonitor.qml PRE-CREATION 
  applets/systemloadviewer/Messages.sh b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
  applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
  applets/systemloadviewer/coloursconfig.ui 
70a08afbaa204bb78865a545965210f3e2dfe42a 
  applets/systemloadviewer/generalconfig.ui 
2ae6d6540a12203e73bab5ca930da751f94bde22 
  applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
  applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
  applets/systemloadviewer/CMakeLists.txt 
6de867aa63e5102a5085667f8106ec09da2c4968 

Diff: https://git.reviewboard.kde.org/r/119927/diff/


Testing
---

Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
monitor is not pixel perfect because of the edge roundings. I haven't been able 
to test if this plasmoid works with high DPI monitors.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png


Thanks,

Martin Yrjölä

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid

[Martin Yrjölä]

> On Aug. 27, 2014, 4:33 p.m., Thomas Pfeiffer wrote:
> > File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot.png
> > 
> >
> > As already said in the forum thread: This violates the alignment HIG. 
> > Please put the checkboxes on the left.

I fixed this in the second revision. Now the settings window looks like this: 
http://wstaw.org/m/2014/08/27/shareimage-aq8446.png


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/#review65378
---


On Aug. 26, 2014, 9:43 p.m., Martin Yrjölä wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119927/
> ---
> 
> (Updated Aug. 26, 2014, 9:43 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Port systemloadviewer plasmoid
> 
> It had a VDG makeover and now there's also circular monitors available in the 
> options.
> 
> There are regressions as well. These features aren't yet implemented:
> - Horizontal bar support
> - Individual monitors for each cpu
> 
> Probably there are some optimizations to be done. I'm not really sure how I 
> should handle the two types of monitors (bar, circular) correctly. Now I just 
> hide the one that is not enabled in the options.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
>   applets/systemloadviewer/CMakeLists.txt 
> 6de867aa63e5102a5085667f8106ec09da2c4968 
>   applets/systemloadviewer/Messages.sh 
> b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
>   applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
>   applets/systemloadviewer/coloursconfig.ui 
> 70a08afbaa204bb78865a545965210f3e2dfe42a 
>   applets/systemloadviewer/generalconfig.ui 
> 2ae6d6540a12203e73bab5ca930da751f94bde22 
>   applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
>   applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
>   applets/systemloadviewer/systemloadviewer.h 
> 9bbcf2305ef47dd888362a9b65954ba65a74 
>   applets/systemloadviewer/systemloadviewer.cpp 
> bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
> PRE-CREATION 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml
>  PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
> PRE-CREATION 
>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
> 9324d4216e716b2156f5f084c8b4782a6dd84806 
>   applets/systemloadviewer/package/contents/ui/CircularMonitor.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119927/diff/
> 
> 
> Testing
> ---
> 
> Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
> monitor is not pixel perfect because of the edge roundings. I haven't been 
> able to test if this plasmoid works with high DPI monitors.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/#review65378
---



File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot.png


As already said in the forum thread: This violates the alignment HIG. 
Please put the checkboxes on the left.


- Thomas Pfeiffer


On Aug. 26, 2014, 9:43 p.m., Martin Yrjölä wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119927/
> ---
> 
> (Updated Aug. 26, 2014, 9:43 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Port systemloadviewer plasmoid
> 
> It had a VDG makeover and now there's also circular monitors available in the 
> options.
> 
> There are regressions as well. These features aren't yet implemented:
> - Horizontal bar support
> - Individual monitors for each cpu
> 
> Probably there are some optimizations to be done. I'm not really sure how I 
> should handle the two types of monitors (bar, circular) correctly. Now I just 
> hide the one that is not enabled in the options.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
>   applets/systemloadviewer/CMakeLists.txt 
> 6de867aa63e5102a5085667f8106ec09da2c4968 
>   applets/systemloadviewer/Messages.sh 
> b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
>   applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
>   applets/systemloadviewer/coloursconfig.ui 
> 70a08afbaa204bb78865a545965210f3e2dfe42a 
>   applets/systemloadviewer/generalconfig.ui 
> 2ae6d6540a12203e73bab5ca930da751f94bde22 
>   applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
>   applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
>   applets/systemloadviewer/systemloadviewer.h 
> 9bbcf2305ef47dd888362a9b65954ba65a74 
>   applets/systemloadviewer/systemloadviewer.cpp 
> bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
> PRE-CREATION 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml
>  PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
> PRE-CREATION 
>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
> 9324d4216e716b2156f5f084c8b4782a6dd84806 
>   applets/systemloadviewer/package/contents/ui/CircularMonitor.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119927/diff/
> 
> 
> Testing
> ---
> 
> Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
> monitor is not pixel perfect because of the edge roundings. I haven't been 
> able to test if this plasmoid works with high DPI monitors.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid

[Thomas Pfeiffer]

> On Aug. 25, 2014, 8 a.m., Martin Yrjölä wrote:
> > File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot.png
> > 
> >
> > I actually changed this string after the screenshot to "Use circular 
> > monitors", but you're right. Radio buttons or a combo box would be better. 
> > I'm not really sure if I should make the horizontal bars an option or just 
> > make them horizontal automatically if the plasmoid detects it's in a 
> > vertical panel. Any thoughts about that?

As long as there are only two or three variants, use radio buttons. The 
checkbox is indeed not the right control here.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/#review65173
---


On Aug. 26, 2014, 9:43 p.m., Martin Yrjölä wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119927/
> ---
> 
> (Updated Aug. 26, 2014, 9:43 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Port systemloadviewer plasmoid
> 
> It had a VDG makeover and now there's also circular monitors available in the 
> options.
> 
> There are regressions as well. These features aren't yet implemented:
> - Horizontal bar support
> - Individual monitors for each cpu
> 
> Probably there are some optimizations to be done. I'm not really sure how I 
> should handle the two types of monitors (bar, circular) correctly. Now I just 
> hide the one that is not enabled in the options.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
>   applets/systemloadviewer/CMakeLists.txt 
> 6de867aa63e5102a5085667f8106ec09da2c4968 
>   applets/systemloadviewer/Messages.sh 
> b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
>   applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
>   applets/systemloadviewer/coloursconfig.ui 
> 70a08afbaa204bb78865a545965210f3e2dfe42a 
>   applets/systemloadviewer/generalconfig.ui 
> 2ae6d6540a12203e73bab5ca930da751f94bde22 
>   applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
>   applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
>   applets/systemloadviewer/systemloadviewer.h 
> 9bbcf2305ef47dd888362a9b65954ba65a74 
>   applets/systemloadviewer/systemloadviewer.cpp 
> bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
> PRE-CREATION 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml
>  PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
> PRE-CREATION 
>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
> 9324d4216e716b2156f5f084c8b4782a6dd84806 
>   applets/systemloadviewer/package/contents/ui/CircularMonitor.qml 
> PRE-CREATION 
>   applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119927/diff/
> 
> 
> Testing
> ---
> 
> Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
> monitor is not pixel perfect because of the edge roundings. I haven't been 
> able to test if this plasmoid works with high DPI monitors.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Eike Hein]

On 27.08.2014 15:32, Eike Hein wrote:

1 = Pages 6 & 7 of http://arstechnica.com/apple/2011/07/mac-os-x-10-7/7/
are a good read.


Sorry - I meant 7 & 8.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Eike Hein]

On 27.08.2014 06:02, Philipp Stefan wrote:

Hmm, could you give me some examples for applications with status
notifiers that handles this that way? I mean, sure applications like
Inkscape and LibreOffice won't start up in the same state like when they
were closed, however, applications like them don't seem to use status
notifiers. I found that mostly media centred applications and those that
provide background functionality like update notifiers seem to use
status notifiers. Most of the ones I saw had a way or another to realize
a state that is consistent with when you close the application. The only
difference was startup time, but that's another story. I see your
concern though.


A lot of the time state is subtle things like: The tab you
last raised, the UI element that has keyboard focus, the
scroll position of a list view, ... there's a lot of things
apps don't remember because developer side it's opt-in, you
need to explicitly wire a lot of this up without that much
support from the libraries.

That's what I meant with the platform angle on the topic of
application lifecycle - mobile platforms often implement a
"the system reserves the right to kill the application at
any time" model because of resource constraints and avail-
ability guarantees. That means they had to give applications
the support to cope with this, and train developers to be
aware of the concerns. As a by-product apps on these plat-
forms often no longer have an explicit "it's running" state
in the UI, nor an explicit Quit action (but you also see
a lot of apps that don't fit this idea well and end up
fighting the system to stay alive).

OS X is the primary desktop operating system that has
attempted to bring this model to the desktop so far, with
OS X 10.7 in 2011 introducing significant new APIs and
changes for the process model and the document model[1].
A lot of that ended up getting rolled back in 10.8 (some
of it even in point releases) because it didn't work well
in practice. So it's not easy.

1 = Pages 6 & 7 of http://arstechnica.com/apple/2011/07/mac-os-x-10-7/7/ 
are a good read.



Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/
---

(Updated Aug. 27, 2014, 1:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

this is a rewrite of the plasma windowed shell and the associated runner, in 
order to have plasmoids as mini applications.


Diffs
-

  runners/CMakeLists.txt fe4e322 
  runners/windowedwidgets/CMakeLists.txt ca31b29 
  runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
  runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
  CMakeLists.txt 6642d78 
  plasma-windowed/CMakeLists.txt PRE-CREATION 
  plasma-windowed/main.cpp PRE-CREATION 
  plasma-windowed/plasma-windowed.desktop PRE-CREATION 
  plasma-windowed/plasmaquick/configview.h PRE-CREATION 
  plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
  plasma-windowed/plasmaquick/view.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
  plasma-windowed/plasmawindowedview.h PRE-CREATION 
  plasma-windowed/plasmawindowedview.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119943/diff/


Testing
---

they correctly save and restore settings, it supports one plasmoid per type, 
window geometries are been saved and restored as well.
still missing a first default size of the window coming from hints, but that 
will a bit more complicated (if possible at all)


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65364
---

Ship it!


Ship It!

- David Edmundson


On Aug. 27, 2014, 12:45 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> ---
> 
> (Updated Aug. 27, 2014, 12:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> this is a rewrite of the plasma windowed shell and the associated runner, in 
> order to have plasmoids as mini applications.
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt fe4e322 
>   runners/windowedwidgets/CMakeLists.txt ca31b29 
>   runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
>   runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
>   CMakeLists.txt 6642d78 
>   plasma-windowed/CMakeLists.txt PRE-CREATION 
>   plasma-windowed/main.cpp PRE-CREATION 
>   plasma-windowed/plasma-windowed.desktop PRE-CREATION 
>   plasma-windowed/plasmaquick/configview.h PRE-CREATION 
>   plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
>   plasma-windowed/plasmaquick/view.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
>   plasma-windowed/plasmawindowedview.h PRE-CREATION 
>   plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
> 
> 
> Testing
> ---
> 
> they correctly save and restore settings, it supports one plasmoid per type, 
> window geometries are been saved and restored as well.
> still missing a first default size of the window coming from hints, but that 
> will a bit more complicated (if possible at all)
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/plasmawindowedview.cpp, line 66
> > 
> >
> > if geom is in valid we should setGeometry based on the applets implicit 
> > size.
> > 
> > 
> > We should set and monitor min/max size from the attached Layout 
> > property too.

min and max are used now, the default size based from the root item 
width/height may be more complicated, not sure i want to go there


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65346
---


On Aug. 27, 2014, 12:45 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> ---
> 
> (Updated Aug. 27, 2014, 12:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> this is a rewrite of the plasma windowed shell and the associated runner, in 
> order to have plasmoids as mini applications.
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt fe4e322 
>   runners/windowedwidgets/CMakeLists.txt ca31b29 
>   runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
>   runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
>   CMakeLists.txt 6642d78 
>   plasma-windowed/CMakeLists.txt PRE-CREATION 
>   plasma-windowed/main.cpp PRE-CREATION 
>   plasma-windowed/plasma-windowed.desktop PRE-CREATION 
>   plasma-windowed/plasmaquick/configview.h PRE-CREATION 
>   plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
>   plasma-windowed/plasmaquick/view.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
>   plasma-windowed/plasmawindowedview.h PRE-CREATION 
>   plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
> 
> 
> Testing
> ---
> 
> they correctly save and restore settings, it supports one plasmoid per type, 
> window geometries are been saved and restored as well.
> still missing a first default size of the window coming from hints, but that 
> will a bit more complicated (if possible at all)
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/
---

(Updated Aug. 27, 2014, 12:45 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

this is a rewrite of the plasma windowed shell and the associated runner, in 
order to have plasmoids as mini applications.


Diffs (updated)
-

  runners/CMakeLists.txt fe4e322 
  runners/windowedwidgets/CMakeLists.txt ca31b29 
  runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
  runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
  CMakeLists.txt 6642d78 
  plasma-windowed/CMakeLists.txt PRE-CREATION 
  plasma-windowed/main.cpp PRE-CREATION 
  plasma-windowed/plasma-windowed.desktop PRE-CREATION 
  plasma-windowed/plasmaquick/configview.h PRE-CREATION 
  plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
  plasma-windowed/plasmaquick/view.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
  plasma-windowed/plasmawindowedview.h PRE-CREATION 
  plasma-windowed/plasmawindowedview.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119943/diff/


Testing
---

they correctly save and restore settings, it supports one plasmoid per type, 
window geometries are been saved and restored as well.
still missing a first default size of the window coming from hints, but that 
will a bit more complicated (if possible at all)


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Eike Hein]

On 27.08.2014 10:16, Philipp Stefan wrote:

One question remains though, why do users not want KTorrent to take up
22px, but are okay with an indicator for the music player while having
the music control plasmoid active too.


Just a brief note: I'm not - I disable the media control plasmoid
because it's redundant with the Cantata icon. No doubt you'll find
user systems with both running, though, because enabling the plas-
moid by default wasn't their choice and they don't know how to
turn it off (or don't care enough). The "I put it where I want it"
tends to only happen in connection to stuff that the user con-
sciously conjured up, I think.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Marco Martin]

On Wednesday 27 August 2014, Martin Gräßlin wrote:
> My personal suggestion (which won't surprise anyone on this list) is to
> move the application status notifiers into the tasks applet. But that's
> not a really easy task and would not interact well with the remaining
> tasks. From my experience it's obvious that users don't want their
> ktorrent to take up any useable space from other applications, but it
> needs to be easily reachable when they want to interact with it.

the idea back in the day was to have the items of categoration 
"applicationstatus" in the taskbar, and the hardware status/network etc still 
in the systray.

but there were never a design solution that actually worked, since it poses 
the exact same problems that are in the systray right now

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Marco Martin]

On Wednesday 27 August 2014, k...@privat.broulik.de wrote:
> don't have players
> sit in the tray approach), "Active state"
>   - KMail 149 unread mails, "Active state"
>   - KTP online, "Active state"
>   - KMix, 50% volume, "Active state"
> 
> None of them have the "NeedsAttentionStatus" yet still they're all
> useful (except
> maybe Amarok)

yeah, it's a behavioral change of an api, not sure if it would work that well

another way may be adding a new value, but would break kde applications in 
unity

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > shell/main.cpp, line 43
> > 
> >
> > this is already shipped?
> > your diffs are a bit messed up.

eww, yeah, doing diff from the wrong checkout


> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/main.cpp, line 69
> > 
> >
> > this will include the applet name again, is that intentional?

args should be only the parameters from the second onwards?


> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/plasmawindowedview.cpp, line 131
> > 
> >
> > on every mouseMove?

not mouse move, just window move, so dragging from the titlebar and similar 
(maybe still a bit too much, but writing on config without syncing should be 
fast i think?)


> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/plasmawindowedview.cpp, line 134
> > 
> >
> > what's this for?

if the window is closed, both the window and the applet get deleted, they are 
considered closed (since the same process can open more than one window/applet)
it does delete and not destroy to preserve the config


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65346
---


On Aug. 27, 2014, 9:32 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> ---
> 
> (Updated Aug. 27, 2014, 9:32 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> this is a rewrite of the plasma windowed shell and the associated runner, in 
> order to have plasmoids as mini applications.
> 
> 
> Diffs
> -
> 
>   runners/windowedwidgets/CMakeLists.txt ca31b29 
>   runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
>   runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
>   shell/main.cpp 0d53bf5 
>   CMakeLists.txt 6642d78 
>   plasma-windowed/CMakeLists.txt PRE-CREATION 
>   plasma-windowed/main.cpp PRE-CREATION 
>   plasma-windowed/plasma-windowed.desktop PRE-CREATION 
>   plasma-windowed/plasmaquick/configview.h PRE-CREATION 
>   plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
>   plasma-windowed/plasmaquick/view.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
>   plasma-windowed/plasmawindowedview.h PRE-CREATION 
>   plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
>   runners/CMakeLists.txt fe4e322 
> 
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
> 
> 
> Testing
> ---
> 
> they correctly save and restore settings, it supports one plasmoid per type, 
> window geometries are been saved and restored as well.
> still missing a first default size of the window coming from hints, but that 
> will a bit more complicated (if possible at all)
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/
---

(Updated Aug. 27, 2014, 10:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This patch paints previews of copied images, instead of displaying the urls in 
plain text.

The display is limited to 4 images right now. The painting of the delegates is 
in line with the recommendations from the HIG at 
https://techbase.kde.org/Projects/Usability/HIG/Layout/Image

It has a few rough edges (all fixed now):
- not all images get thumbnails -- need to investigate why
- vertical alignment throughout the list is quite bad, this is the case 
already, I will fix that separately
- I want to add an indicator that it's more than 4 files (if applicable), 
working on that still
- When no preview is loaded, it should show an icon, almost done, with some 
fixes

I'd like some feedback on the code, so that with the remaining issues fixed, it 
can get in.


Diffs
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
  klipper/org.kde.plasma.clipboard.operations 813aafa 
  klipper/clipboardjob.cpp d84d014 
  klipper/historyurlitem.cpp fb2a766 
  applets/clipboard/contents/ui/Menu.qml e6821c3 
  applets/clipboard/contents/ui/clipboard.qml ac784d2 
  klipper/CMakeLists.txt 660b0d1 
  klipper/clipboardjob.h b4f5284 

Diff: https://git.reviewboard.kde.org/r/119866/diff/


Testing
---

Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
that the previews are only loaded when needed, so no additional memory taken 
when the systray / klipper popup is not open.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
Klipper with thumbnails
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
Klipper with thumbnails 2nd version
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

[Sebastian Kügler]

> On Aug. 26, 2014, 11:36 a.m., Kai Uwe Broulik wrote:
> > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 55
> > 
> >
> > Math.round(…) ?

We guarantee units.gridUnit to be an even number, so for /2, no Math.round() is 
needed.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review65271
---


On Aug. 25, 2014, 11:20 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119866/
> ---
> 
> (Updated Aug. 25, 2014, 11:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch paints previews of copied images, instead of displaying the urls 
> in plain text.
> 
> The display is limited to 4 images right now. The painting of the delegates 
> is in line with the recommendations from the HIG at 
> https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
> 
> It has a few rough edges (all fixed now):
> - not all images get thumbnails -- need to investigate why
> - vertical alignment throughout the list is quite bad, this is the case 
> already, I will fix that separately
> - I want to add an indicator that it's more than 4 files (if applicable), 
> working on that still
> - When no preview is loaded, it should show an icon, almost done, with some 
> fixes
> 
> I'd like some feedback on the code, so that with the remaining issues fixed, 
> it can get in.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
>   klipper/org.kde.plasma.clipboard.operations 813aafa 
>   klipper/clipboardjob.cpp d84d014 
>   klipper/historyurlitem.cpp fb2a766 
>   applets/clipboard/contents/ui/Menu.qml e6821c3 
>   applets/clipboard/contents/ui/clipboard.qml ac784d2 
>   klipper/CMakeLists.txt 660b0d1 
>   klipper/clipboardjob.h b4f5284 
> 
> Diff: https://git.reviewboard.kde.org/r/119866/diff/
> 
> 
> Testing
> ---
> 
> Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
> that the previews are only loaded when needed, so no additional memory taken 
> when the systray / klipper popup is not open.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
> Klipper with thumbnails
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
> Klipper with thumbnails 2nd version
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65346
---



plasma-windowed/main.cpp


leaks



plasma-windowed/main.cpp


this will include the applet name again, is that intentional?



plasma-windowed/plasmawindowedview.cpp


init m_applet



plasma-windowed/plasmawindowedview.cpp


if geom is in valid we should setGeometry based on the applets implicit 
size.

We should set and monitor min/max size from the attached Layout property 
too.



plasma-windowed/plasmawindowedview.cpp


on every mouseMove?



plasma-windowed/plasmawindowedview.cpp


what's this for?



shell/main.cpp


this is already shipped?
your diffs are a bit messed up.


- David Edmundson


On Aug. 27, 2014, 9:32 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> ---
> 
> (Updated Aug. 27, 2014, 9:32 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> this is a rewrite of the plasma windowed shell and the associated runner, in 
> order to have plasmoids as mini applications.
> 
> 
> Diffs
> -
> 
>   runners/windowedwidgets/CMakeLists.txt ca31b29 
>   runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
>   runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
>   shell/main.cpp 0d53bf5 
>   CMakeLists.txt 6642d78 
>   plasma-windowed/CMakeLists.txt PRE-CREATION 
>   plasma-windowed/main.cpp PRE-CREATION 
>   plasma-windowed/plasma-windowed.desktop PRE-CREATION 
>   plasma-windowed/plasmaquick/configview.h PRE-CREATION 
>   plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
>   plasma-windowed/plasmaquick/view.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
>   plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
>   plasma-windowed/plasmawindowedview.h PRE-CREATION 
>   plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
>   runners/CMakeLists.txt fe4e322 
> 
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
> 
> 
> Testing
> ---
> 
> they correctly save and restore settings, it supports one plasmoid per type, 
> window geometries are been saved and restored as well.
> still missing a first default size of the window coming from hints, but that 
> will a bit more complicated (if possible at all)
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Request: better override functionality in locale settings

[Sebastian Kügler]

Hi Matthew,

Thanks for your feedback regarding locale settings. Find some explanations for 
the changes below.

On Tuesday, August 26, 2014 13:04:10 Matthew Ruffalo wrote:
> I've been a long-time KDE user, and I must say that Plasma 5 looks
> *great*. Everything looks very polished and I'm looking forward to using
> it on a stable Linux distribution.
> 
> In all of my usage of KDE, I've always greatly appreciated how
> customizable the locale settings are. I live in the United States and
> have various options set for American English. However, I have
> configured my system to use the far superior formats for time (24-hour),
> date (-MM-DD) and measurements (metric over the imperial units). The
> Locale settings in KDE 4 allow me to override these settings very easily.

The locale handling has changed completely from the previous KDE version. 
Instead of brewing our own locale, we now rely on Qt, and use standard POSIX 
settings for these. That means that the granularity is reduced, which also 
reduces complexity. It also means that not all options are available anymore, 
some of them to be brought back as QLocale catches up. (We're improving it 
actively, but those things take time.)

> I've been testing out the live CDs available at
> http://files.kde.org/snapshots/ and I'm very concerned about the
> "Formats" module of the regional settings. The "Detailed Settings"
> overrides are essentially *unusable*, as shown in
> http://i.imgur.com/onT3zOr.png . (I took this screenshot from the ISO
> image named neon5-201408220837.iso.) When I try to override the time for
> a 24-hour format, I am forced to guess about a region of the world that
> uses this format instead of simply entering -MM-DD as before.

Locale rules are too complex to just express it in a few format strings, 
they're specific for regions and languages.

> Additionally, the list of locales is enormous, with very limited
> scrolling capability. I am forced to point my mouse cursor at the bottom
> arrow and wait as the list scrolls very slowly. The other detailed
> settings overrides behave in the same way. In particular, the
> "Measurement Units" option should probably simply show "metric/imperial".

There's more than just metric and imperial. This page gives you a slight 
impression of the complexity: 
http://en.wikipedia.org/wiki/Imperial_units#Current_use_of_imperial_units

A binary combobox is just not enough to portray this correctly.

> In my opinion, this is a very serious usability regression and would
> stop me from using Plasma 5. Are there any plans to change the
> behavior/appearance of this settings applet?

I don't know what it is, but anytime someome doesn't like something, it's 
"usability" all of a sudden. Usability has a strict meaning, and translating 
it to "I don't use it, but I don't like it, so it's bad usability" isn't very 
useful.

I understand that it changes you way you set up your system, of course.

> I searched the bug tracker for anything related to this and only found
> https://bugs.kde.org/show_bug.cgi?id=337563 -- I'm hoping that Martin
> Klapetek means to say that the *digitial clock itself* won't have 12/24
> hour options and that it should be set in the global locale settings.

We don't plan to add a 12/24 hour setting for the time, system-wide.

> I
> fully appreciate and agree with this; I'm asserting that the locale
> settings module is barely usable to override the time or date formats.

Well, I'm asserting that it's a huge step forward for the majority of users. 
For those, that are missing options, we will bring back some more functions as 
it becomes technically feasible, but I doubt we'll ever get back to the micro-
settings-jungle that Plasma 4 had.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/
---

(Updated Aug. 27, 2014, 9:32 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

this is a rewrite of the plasma windowed shell and the associated runner, in 
order to have plasmoids as mini applications.


Diffs (updated)
-

  runners/windowedwidgets/CMakeLists.txt ca31b29 
  runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
  runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
  shell/main.cpp 0d53bf5 
  CMakeLists.txt 6642d78 
  plasma-windowed/CMakeLists.txt PRE-CREATION 
  plasma-windowed/main.cpp PRE-CREATION 
  plasma-windowed/plasma-windowed.desktop PRE-CREATION 
  plasma-windowed/plasmaquick/configview.h PRE-CREATION 
  plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
  plasma-windowed/plasmaquick/view.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
  plasma-windowed/plasmawindowedview.h PRE-CREATION 
  plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
  runners/CMakeLists.txt fe4e322 

Diff: https://git.reviewboard.kde.org/r/119943/diff/


Testing
---

they correctly save and restore settings, it supports one plasmoid per type, 
window geometries are been saved and restored as well.
still missing a first default size of the window coming from hints, but that 
will a bit more complicated (if possible at all)


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review65344
---

Ship it!


Ship It!

- Martin Gräßlin


On Aug. 26, 2014, 1:20 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119866/
> ---
> 
> (Updated Aug. 26, 2014, 1:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch paints previews of copied images, instead of displaying the urls 
> in plain text.
> 
> The display is limited to 4 images right now. The painting of the delegates 
> is in line with the recommendations from the HIG at 
> https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
> 
> It has a few rough edges (all fixed now):
> - not all images get thumbnails -- need to investigate why
> - vertical alignment throughout the list is quite bad, this is the case 
> already, I will fix that separately
> - I want to add an indicator that it's more than 4 files (if applicable), 
> working on that still
> - When no preview is loaded, it should show an icon, almost done, with some 
> fixes
> 
> I'd like some feedback on the code, so that with the remaining issues fixed, 
> it can get in.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
>   klipper/org.kde.plasma.clipboard.operations 813aafa 
>   klipper/clipboardjob.cpp d84d014 
>   klipper/historyurlitem.cpp fb2a766 
>   applets/clipboard/contents/ui/Menu.qml e6821c3 
>   applets/clipboard/contents/ui/clipboard.qml ac784d2 
>   klipper/CMakeLists.txt 660b0d1 
>   klipper/clipboardjob.h b4f5284 
> 
> Diff: https://git.reviewboard.kde.org/r/119866/diff/
> 
> 
> Testing
> ---
> 
> Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
> that the previews are only loaded when needed, so no additional memory taken 
> when the systray / klipper popup is not open.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
> Klipper with thumbnails
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
> Klipper with thumbnails 2nd version
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review65343
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Aug. 25, 2014, 11:20 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119866/
> ---
> 
> (Updated Aug. 25, 2014, 11:20 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch paints previews of copied images, instead of displaying the urls 
> in plain text.
> 
> The display is limited to 4 images right now. The painting of the delegates 
> is in line with the recommendations from the HIG at 
> https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
> 
> It has a few rough edges (all fixed now):
> - not all images get thumbnails -- need to investigate why
> - vertical alignment throughout the list is quite bad, this is the case 
> already, I will fix that separately
> - I want to add an indicator that it's more than 4 files (if applicable), 
> working on that still
> - When no preview is loaded, it should show an icon, almost done, with some 
> fixes
> 
> I'd like some feedback on the code, so that with the remaining issues fixed, 
> it can get in.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
>   klipper/org.kde.plasma.clipboard.operations 813aafa 
>   klipper/clipboardjob.cpp d84d014 
>   klipper/historyurlitem.cpp fb2a766 
>   applets/clipboard/contents/ui/Menu.qml e6821c3 
>   applets/clipboard/contents/ui/clipboard.qml ac784d2 
>   klipper/CMakeLists.txt 660b0d1 
>   klipper/clipboardjob.h b4f5284 
> 
> Diff: https://git.reviewboard.kde.org/r/119866/diff/
> 
> 
> Testing
> ---
> 
> Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
> that the previews are only loaded when needed, so no additional memory taken 
> when the systray / klipper popup is not open.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
> Klipper with thumbnails
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
> Klipper with thumbnails 2nd version
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : plasma-workspace_master_qt5 #784

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119943: plasma windowed and associated runner back

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/
---

(Updated Aug. 27, 2014, 8:39 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

this is a rewrite of the plasma windowed shell and the associated runner, in 
order to have plasmoids as mini applications.


Diffs (updated)
-

  plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
  plasma-windowed/plasmawindowedview.h PRE-CREATION 
  plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
  runners/CMakeLists.txt fe4e322 
  runners/windowedwidgets/CMakeLists.txt ca31b29 
  runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
  runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
  CMakeLists.txt 6642d78 
  plasma-windowed/CMakeLists.txt PRE-CREATION 
  plasma-windowed/main.cpp PRE-CREATION 
  plasma-windowed/plasma-windowed.desktop PRE-CREATION 
  plasma-windowed/plasmaquick/configview.h PRE-CREATION 
  plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
  plasma-windowed/plasmaquick/view.h PRE-CREATION 
  plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
  shell/main.cpp 0d53bf5 

Diff: https://git.reviewboard.kde.org/r/119943/diff/


Testing
---

they correctly save and restore settings, it supports one plasmoid per type, 
window geometries are been saved and restored as well.
still missing a first default size of the window coming from hints, but that 
will a bit more complicated (if possible at all)


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[kde]

Hi,

If your application has finished its job like e.g. an update  
notifier but should continue to run in the background, then use the  
"passive" flag. If you want to misuse the system tray as second task  
bar, then do not use the passive flag, but let it remain active. And  
if your application has finished its job and should not continue to  
run in the background then, quit the application upon closing the  
main window and do not continue to use the status notifier


So, that's exactly the way we have it at the moment, isn't it?

One question remains though, why do users not want KTorrent to take  
up 22px, but are okay with an indicator for the music player while  
having the music control plasmoid active too.


For example I do not use a taskbar/window list, if "background applications"
moved to the taskbar I would no longer be able to access them.

Or why are they okay with KTorrent taking up space while  
downloading, but not while seeding.


When downloading you likely want to open that file after it's done. To ease
monitoring, it stays there. Seeding is a process that does not involve  
the user

at all. But I don't know much about Torrent, so I could be wrong.

My solution would be to allow users to move the "active" state to  
the popup, while the "needsAttention" one will then still be  
displayed in the panel. Though only after they configured system  
tray to do it like that, not as default.


I like that idea. However, that would make monitoring system status difficult.
For example at the moment I have in my systray visible (Plasma 4, though):
 - Amarok (paused) (btw I like that use mpris thing for that and  
don't have players

   sit in the tray approach), "Active state"
 - KMail 149 unread mails, "Active state"
 - KTP online, "Active state"
 - KMix, 50% volume, "Active state"

None of them have the "NeedsAttentionStatus" yet still they're all  
useful (except

maybe Amarok)

Cheers,
Kai Uwe

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

[Philipp Stefan]

On 27.08.2014 08:16, Martin Gräßlin wrote:

On Wednesday 27 August 2014 06:02:11 Philipp Stefan wrote:

If the status notifiers are used like we intend them to, then the
"passive" status really does not provide any benefit for the user any
more. For example, if a music player idles, because the playlist has
ended, then there's no difference between closing the window and
reviving it again with the status notifier, or closing it and opening it
again with KRunner, kickoff etc.

This goes into the very broad topic of application life-
cycle. The technical reality right now is that we do need
to explicitly communicate lifecycle state to users because
we don't have perfect state serialization - whether an app
is running or not matters, because it may not come back up
in the same state as when it was quit.

Hmm, could you give me some examples for applications with status
notifiers that handles this that way? I mean, sure applications like
Inkscape and LibreOffice won't start up in the same state like when they
were closed, however, applications like them don't seem to use status
notifiers. I found that mostly media centred applications and those that
provide background functionality like update notifiers seem to use
status notifiers. Most of the ones I saw had a way or another to realize
a state that is consistent with when you close the application. The only
difference was startup time, but that's another story. I see your
concern though.

there's a technical difference: with the status notifiers the applications do
not quit. They continue to run and only the main window gets hidden which can
easily be restored.

What you want is to quit it, but that requires application life cycle to get
the application back to the state where you left it. In reality this does not
exist (yet).
No, we want applications to behave and use status notifiers sensibly. If 
your application has finished its job like e.g. an update notifier but 
should continue to run in the background, then use the "passive" flag. 
If you want to misuse the system tray as second task bar, then do not 
use the passive flag, but let it remain active. And if your application 
has finished its job and should not continue to run in the background 
then, quit the application upon closing the main window and do not 
continue to use the status notifier, nothing forces you to. We're not 
advocating to simply kick these applications out, but for them to 
examine if they use the status notifier in a consistent manner.

Overall I'm with Eike here in this discussion. Just from my experience: people
want to use the system tray as a kind of task bar for some windows. I
regularly get bug reports about it not working or not working as expected. I
don't like this taskbar feature of the system tray but we cannot deny that
it's a real use case and we would piss off large numbers of users if we remove
the support for passive notifiers (not to think about all the old xembed items
we transform to systemtray icons).
Yes it is a valid use case, however, you one has to weight it against 
its downside. This use case starts to collide with others and more 
importantly starts to clutter the system tray, because the system tray 
can not guess the intend of the application. It can not discriminate 
between applications that are in "I'm useless, please hide me" mode, the 
ones in "Hey, I'm using this to preserve my state" mode and the ones in 
the "I'm still doing something that could impact you negatively, but 
don't mind me please" mode.
If there was a way for system tray to tell these apart then that would 
be rad, but I don't think there is.

  What's important to notice is that there
are applications which would break if you remove it.

Yes we are aware of that and have acknowledge it several times now.

Please start to look at it from the other side. Look at what the applications
provide in the system tray icon and why they are doing it. Then come up with
an idea how to solve the use case, which we can then implement and after that
deprecate the usage in the system tray.
I did and I am trying to do that. I do not like to remove functionality, 
especially  because that is one of KDE's strength and to avoid the 
notion "hurr durr all design is the same, it's GNOME all over again".

My personal suggestion (which won't surprise anyone on this list) is to move
the application status notifiers into the tasks applet. But that's not a
really easy task and would not interact well with the remaining tasks. From my
experience it's obvious that users don't want their ktorrent to take up any
useable space from other applications, but it needs to be easily reachable
when they want to interact with it.
That's an interesting idea, but I believe it's even less enforceable and 
coherent than our idea, which already does not seem to be liked well :D.
One question remains though, why do users not want KTorrent to take up 
22px, but are okay with an indicator for the music player while having 

Re: VDG suggestions and wishes about the system tray

[Ivan Čukić]

I'm not going to chime in regarding the applications - I tend to agree with 
both parties - that not everything needs to be shown, yet that people like 
some of their applications minimized to tray (myself included - I even hide 
those applications from the task bar).

One thing where I fully support the proposal is for plasmoids in the tray - it 
is a really a bad thing to have so many empty panels in - no devices, no 
notifications, no batteries etc.



-- 

Cheerio,
Ivan


KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ 
gpg key id: 850B6F76, keyserver.pgp.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

[R.Harish Navnit]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/
---

(Updated Aug. 27, 2014, 7 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Bugs: 333764
http://bugs.kde.org/show_bug.cgi?id=333764


Repository: plasma-mediacenter


Description
---

If a media(in a playlist) is located in an inaccessible location, then the user 
is notified about the same. 


Diffs
-

  mediaelements/mediaplayer/MediaPlayer.qml 
98f1d2c733e272ad9941264b99f25fd952edcbec 
  shells/newshell/package/contents/ui/mediacenter.qml 
394f820445b2b6896f6540a5d35cb55edfb2f139 

Diff: https://git.reviewboard.kde.org/r/118406/diff/


Testing
---

1. Load media to a playlist.
2. Unmount the device containing media.
3. Check if the user is notified of the location being inaccessible
   --yes, the user is notified
4. Mount the device containing media and play a media from playlist.
   -- The media plays properly.


File Attachments


wihtout_i18n.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png


Thanks,

R.Harish  Navnit

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel