Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/#review98255
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Aug. 10, 2016, 1:48 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128642/
> ---
> 
> (Updated Aug. 10, 2016, 1:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
> crash, but instead just leaves all signals blocked on
> ContainmentInterface
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 55d91aa9d09ee37ec523f9a16f347586db00ecd5 
> 
> Diff: https://git.reviewboard.kde.org/r/128642/diff/
> 
> 
> Testing
> ---
> 
> Read the code.
> Which apparently the previous person didn't do.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128642: Fix blatant bug in code that was pushed unreviewed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
crash, but instead just leaves all signals blocked on
ContainmentInterface


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
55d91aa9d09ee37ec523f9a16f347586db00ecd5 

Diff: https://git.reviewboard.kde.org/r/128642/diff/


Testing
---

Read the code.
Which apparently the previous person didn't do.


Thanks,

David Edmundson

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/#review98253
---


Ship it!




Ship It!

- Sebastian Kügler


On Aug. 9, 2016, 11:04 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128641/
> ---
> 
> (Updated Aug. 9, 2016, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 ported an argument from
> QPoint to QRectF. However, not all local invocations were updated correctly 
> with one passing a QRect, which fails.
> 
> *NEEDS BACKPORTING TO 5.25*
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 
> 
> Diff: https://git.reviewboard.kde.org/r/128641/diff/
> 
> 
> Testing
> ---
> 
> Before: Couldn't drag applet from Widget Explorer to Desktop
> After: Can
> 
> Checked the other invocations are correct.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/#review98254
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Aug. 10, 2016, 1:03 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128640/
> ---
> 
> (Updated Aug. 10, 2016, 1:03 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
> adding createApplet, turning the final argument from QPoint to QRect.
> 
> If the rectangle size is nothing, it acts like the original code.
> 
> Despite this being private API (ish) there is a hacks in plasma-
> workspace that call methods on the view via QMetaObject invoke. This
> obviously fails. As we need compatibility for Plasma/5.7 and earlier a
> compatibility slot needs to stay.
> 
> 
> *THIS NEEDS BACKPORTING TO 5.25*
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 
> c058f8358b4aa123749959a3de5b0667d7a1fecc 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 
> 
> Diff: https://git.reviewboard.kde.org/r/128640/diff/
> 
> 
> Testing
> ---
> 
> Before: alternatives context menu on the desktop just deleted the applet
> Now: works
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/#review98252
---


Ship it!




Ship It!

- Sebastian Kügler


On Aug. 9, 2016, 11:03 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128640/
> ---
> 
> (Updated Aug. 9, 2016, 11:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
> adding createApplet, turning the final argument from QPoint to QRect.
> 
> If the rectangle size is nothing, it acts like the original code.
> 
> Despite this being private API (ish) there is a hacks in plasma-
> workspace that call methods on the view via QMetaObject invoke. This
> obviously fails. As we need compatibility for Plasma/5.7 and earlier a
> compatibility slot needs to stay.
> 
> 
> *THIS NEEDS BACKPORTING TO 5.25*
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 
> c058f8358b4aa123749959a3de5b0667d7a1fecc 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 
> 
> Diff: https://git.reviewboard.kde.org/r/128640/diff/
> 
> 
> Testing
> ---
> 
> Before: alternatives context menu on the desktop just deleted the applet
> Now: works
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/
---

Review request for KDE Frameworks, Plasma and David Faure.


Repository: plasma-framework


Description
---

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 ported an argument from
QPoint to QRectF. However, not all local invocations were updated correctly 
with one passing a QRect, which fails.

*NEEDS BACKPORTING TO 5.25*


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128641/diff/


Testing
---

Before: Couldn't drag applet from Widget Explorer to Desktop
After: Can

Checked the other invocations are correct.


Thanks,

David Edmundson

Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/
---

Review request for KDE Frameworks, Plasma and David Faure.


Repository: plasma-framework


Description
---

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
adding createApplet, turning the final argument from QPoint to QRect.

If the rectangle size is nothing, it acts like the original code.

Despite this being private API (ish) there is a hacks in plasma-
workspace that call methods on the view via QMetaObject invoke. This
obviously fails. As we need compatibility for Plasma/5.7 and earlier a
compatibility slot needs to stay.


*THIS NEEDS BACKPORTING TO 5.25*


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.h 
c058f8358b4aa123749959a3de5b0667d7a1fecc 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128640/diff/


Testing
---

Before: alternatives context menu on the desktop just deleted the applet
Now: works


Thanks,

David Edmundson

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> graesslin wrote in xrandrconfig.cpp:556-558
> I think you want to remove the if clause now

No, this part is a bit different from the above hunk, it uses the xOutput by 
default, and if that is empty, falls back to kscreen's currentModeId or the 
preferredModeId.

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D2330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> kwinqml.cpp:153
> +if (m_seat != nullptr) {
> +m_seat->keyPressed(event->nativeScanCode() - 8);
> +}

only do that on X11, if we are on Wayland that would be wrong. So do something 
like:

  const int magicOffset = KWindowSystem::isPlatformX11() ? 8 : 0;
  m_seat->keyPressed(event->nativeScanCode() - magicOffset);

And I'm glad it was the 8 issue, luckily I remembered that - having stumbled 
over this weirdness myself in the past.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVILa5a325e20c15: Make powerdevil normal executable 
instead of kded module (authored by bshah).

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2372?vs=5763=5773

REVISION DETAIL
  https://phabricator.kde.org/D2372

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  daemon/kdedpowerdevil.cpp
  daemon/kdedpowerdevil.h
  daemon/powerdevil.desktop
  daemon/powerdevil.desktop.cmake
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, graesslin, broulik, #plasma
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2372: Make powerdevil normal executable instead of kded module

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPOWERDEVIL Powerdevil

BRANCH
  powerdevil-executable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, graesslin, broulik, #plasma
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  I was thinking about that but where would you want to place it? The only 
place where it wouldn't look like crap is right of the "Notifications" heading 
but this is done by system tray and we cannot place items there from within an 
applet.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mck182
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Shouldn't that button rather be in the popup itself?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mck182
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 20 lines] D2383: [Notifications] Add "Clear Notifications" context menu entry

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds an entry to clear all notifications in the history.
  The entry is only shown if there's actually notifications currently in the 
history.
  
  BUG: 343686
  FIXED-IN: 5.8.0

TEST PLAN
  Ran knotificationdbustest, right-clicked notification item, "Clear 
Notifications", notification and popup disappeared.
  
  I didn't want to clutter the list too much and adding a button at the end of 
the list would be difficult to reach.
  This is for the people that complain about the "job finished" notifications ;)
  
  F238063: Screenshot_20160809_143730.png 

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2383

AFFECTED FILES
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mck182
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2381: Share logic for passing AbstractTasksModelIface methods to source model

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> abstracttasksproxymodeliface.h:164
>  /**
> - * Request moving the task at the given index to the specified 
> activities.
> + * Request moving the task at the given index to the specified virtual
> + * activities.

"Specified virtual activities"?

(I can't tell if this is actually broken or the diff viewer screwing up.)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2381

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2374: [kded] fix monitoring for newly appearing outputs

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN68423ccdf3f8: [kded] fix monitoring for newly 
appearing outputs (authored by sebas).

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2374?vs=5770=5771

REVISION DETAIL
  https://phabricator.kde.org/D2374

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2374: [kded] fix monitoring for newly appearing outputs

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/newdockoutputs

REVISION DETAIL
  https://phabricator.kde.org/D2374

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2374: [kded] fix monitoring for newly appearing outputs

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/newdockoutputs

REVISION DETAIL
  https://phabricator.kde.org/D2374

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, davidedmundson, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

[Sebastian Kügler]

sebas updated this revision to Diff 5770.
sebas added a comment.


  - Also connect disconnected outputs

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2374?vs=5747=5770

BRANCH
  sebas/newdockoutputs

REVISION DETAIL
  https://phabricator.kde.org/D2374

AFFECTED FILES
  kded/daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Plasma desktop window uses RGBA

[Martin Graesslin]

On Tuesday, August 9, 2016 11:16:33 AM CEST Martin Graesslin wrote:
> Hi all,
> 
> I just noticed that Plasma's desktop window uses an RGBA format. This is not
> only completely pointless as it's the bottom most window, it's also
> destroying all optimizations in KWin. KWin always has to go into the
> blending code path, which means rendering from bottom to top instead of
> rendering from top to bottom. And also KWin always has to clear the color
> buffer before rendering the Plasma desktop window.
> 
> Anyone an idea how we can change this?

Forcing in KWin with: D2382

Cheers
Martin


signature.asc
Description: This is a digitally signed message part.

[Differential] [Closed] D2380: Allow disabling filtering by SkipTaskbar.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb58f6ee2a3c5: Allow disabling filtering by 
SkipTaskbar. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2380?vs=5765=5767

REVISION DETAIL
  https://phabricator.kde.org/D2380

AFFECTED FILES
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2379: Factor windowing system arbitration out of TasksModel.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEacfbcb4fa522: Factor windowing system 
arbitration out of TasksModel. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2379?vs=5762=5766

REVISION DETAIL
  https://phabricator.kde.org/D2379

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/windowtasksmodel.cpp
  libtaskmanager/windowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2379: Factor windowing system arbitration out of TasksModel.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2379: Factor windowing system arbitration out of TasksModel.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in windowtasksmodel.h:43
> Idea:
> if you a subclass of AbstractTasksModelIface with a 
> virtual QAbstractProxyModel* source()
> 
> you could kill a tonne of duplicated code

I'm having trouble parsing this due to missing words(?), can you explain more? 
:) Feel free to hit me up on IRC.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2379: Factor windowing system arbitration out of TasksModel.

[hein (Eike Hein)]

hein added a comment.


  > To export WindowTasksModel directly?
  
  It's already exported ...? See the change to CMakeLists.txt and the 
TASKMANAGER_EXPORT macro.
  
  > You'd still need to go via TaskFilterProxyModel
  
  Yes, TaskFilterProxyModel is also useful with some changes (see 
https://phabricator.kde.org/D2380).
  
  > and for the pager you'd need AbstractTasksModelIface too (for 
setVirtualDesktop)
  
  Indeed, libtaskmanager also installs the abstracttasksmodeliface.h header.
  
  > ...at which point you're pretty much back at using half of TasksModel 
anyway?
  
  That's addressed in the review request description: The Pager doesn't care 
about startup notifications, or launchers, or TasksModel's sort modes, or 
grouping, or has a need for a ConcatenateTasksProxyModel, ... all it wants to 
share with TasksModel is the window tasks sub-model (and from libtaskmanager it 
also wants to use TaskFilterProxyModel).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2380: Allow disabling filtering by SkipTaskbar.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  optionalfilterskiptaskbar

REVISION DETAIL
  https://phabricator.kde.org/D2380

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2379: Factor windowing system arbitration out of TasksModel.

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  One question first:
  
  > It allows users of libtaskmanager which are solely interested in window 
data (e.g. the Pager) to skip the unnecessary complexity of TasksModel, while 
still sharing the windowing monitoring with users of TasksModel.
  
  What's your longer term plan?
  To export WindowTasksModel directly? You'd still need to go via 
TaskFilterProxyModel, and for the pager you'd need AbstractTasksModelIface too 
(for setVirtualDesktop) 
  ...at which point you're pretty much back at using half of TasksModel anyway?

INLINE COMMENTS

> windowtasksmodel.h:43
> +
> +class TASKMANAGER_EXPORT WindowTasksModel : public QIdentityProxyModel, 
> public AbstractTasksModelIface
> +{

Idea:
if you a subclass of AbstractTasksModelIface with a 
virtual QAbstractProxyModel* source()

you could kill a tonne of duplicated code

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2379

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 41 lines] D2380: Allow disabling filtering by SkipTaskbar.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, mart, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This makes TaskFilterProxyModel useful for filtering a source tasks
  model (e.g. WindowTasksModel) without implicitly filtering out tasks
  that don't want to be shown on a 'task bar'.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  optionalfilterskiptaskbar

REVISION DETAIL
  https://phabricator.kde.org/D2380

AFFECTED FILES
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah added a comment.


  mark comments as done

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2377: use the feature summary to communicate runtime deps

[sitter (Harald Sitter)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAINTEGRATIONf1191def10a0: use the feature summary to 
communicate runtime deps (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2377?vs=5754=5764#toc

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2377?vs=5754=5764

REVISION DETAIL
  https://phabricator.kde.org/D2377

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, #plasma, davidedmundson
Cc: davidedmundson, heikobecker, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

[sitter (Harald Sitter)]

sitter added a comment.


  In https://phabricator.kde.org/D2377#44513, @heikobecker wrote:
  
  > Also imagine a user investigating why the two packages don't show up 
although he has installed them.
  
  
  In the landing version I have added notes about them not being detected 
automatically and how to ignore them. That said, if you want to write a 
reliable font finder that would be pretty cool.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, #plasma, davidedmundson
Cc: davidedmundson, heikobecker, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 109 lines] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 5763.
bshah added a comment.


  set desktopSettingsAware to false

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2372?vs=5759=5763

BRANCH
  powerdevil-executable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2372

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  daemon/kdedpowerdevil.cpp
  daemon/kdedpowerdevil.h
  daemon/powerdevil.desktop
  daemon/powerdevil.desktop.cmake
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 401 lines] D2379: Factor windowing system arbitration out of TasksModel.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, mart, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This introduces a new WindowTasksModel which is a QIdentityProxyModel
  around an instance of either WaylandTasksModel or XWindowsTasksModel.
  
  This arbitration was previously done directly in TasksModel, along with
  refcounting to share a single window tasks sub-model between TasksModel
  instances. Factoring out both of these things has two goals:
  
  - It allows users of libtaskmanager which are solely interested in window 
data (e.g. the Pager) to skip the unnecessary complexity of TasksModel, while 
still sharing the windowing monitoring with users of TasksModel.
  - TasksModel becomes fully free of windowing system-specific code and calls 
to KWindowSystem (to query the platform), making its code a little cleaner.
  
  The downside is another layer of indirection (the QIdentityProxyModel),
  but the upside is clear: The Pager wants to share window data and
  window monitoring with the Task Manager, but is not interested in
  startup notifications, does its own sorting (using the window stacking
  order), does not need grouping and has different filtering needs.
  
  The Pager backend will use QSortFilterProxyModel around WindowTasksModel
  to mix in its own data and sort by stacking order.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2379

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/windowtasksmodel.cpp
  libtaskmanager/windowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

[heikobecker (Heiko Becker)]

heikobecker added a comment.


  In https://phabricator.kde.org/D2377#44495, @sitter wrote:
  
  > In https://phabricator.kde.org/D2377#44484, @heikobecker wrote:
  >
  > > So I think two Find... modules are also needed or "message..." should 
stay.
  >
  >
  > Well. No.
  >
  > https://cmake.org/cmake/help/v3.0/command/find_package.html
  >
  > > Every non-REQUIRED find_package call can be disabled by setting the 
CMAKE_DISABLE_FIND_PACKAGE_ variable to TRUE.
  >
  
  
  Well, I understand that but I *really* don't think a message should be shown, 
that always yields the same result, no matter if it can be disabled via 
CMAKE_D_F_P_Foo or the packages in question are installed or not. What's the 
difference to message in that case?
  Also imagine a user investigating why the two packages don't show up although 
he has installed them.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, #plasma, davidedmundson
Cc: davidedmundson, heikobecker, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2377: use the feature summary to communicate runtime deps

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I don't think we need the comments at the end.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, #plasma, davidedmundson
Cc: davidedmundson, heikobecker, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2378: Instanciate the launcher tasks model only when needed.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEc802bb8789c8: Instanciate the launcher tasks 
model only when needed. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2378?vs=5757=5761

REVISION DETAIL
  https://phabricator.kde.org/D2378

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2377: use the feature summary to communicate runtime deps

[mart (Marco Martin)]

mart added a reviewer: Plasma.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, #plasma
Cc: heikobecker, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D2378: Instanciate the launcher tasks model only when needed.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2378

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 346 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 5760.
mart added a comment.


  - prototype for support of per-looknfeel layout
  - monitor for file creation
  - delete views and arrays in the proper order
  - be silent
  - prototype of JS config dump
  - more complete config js dumper
  - generic kconfiggroup dumper
  - complete the dump of the panel
  - export the layout dump to js
  - createActivity(existingName) returns the existing one
  - support creating applets by id in script engine
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - prettier javascript code
  - crash--
  - delete all graphics objects as well on switching
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - make sure desktop containments exist before script
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - more explanatory comments
  - possible pass geometry to containment.addWidget()
  - generate some comments in js
  - use QRectF
  - use AppletOrder from the panel config
  - always use renamed file
  - internal config migration
  - remove the optional applet id parameter
  - remove graphicsobject hack
  - rework script generation

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5743=5760

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 108 lines] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 5759.
bshah marked an inline comment as done.
bshah added a comment.


  - Make it autorestart on crash
  - Make it unique so there are not multiple powerdevil

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2372?vs=5758=5759

BRANCH
  powerdevil-executable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2372

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  daemon/kdedpowerdevil.cpp
  daemon/kdedpowerdevil.h
  daemon/powerdevil.desktop
  daemon/powerdevil.desktop.cmake
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

[sitter (Harald Sitter)]

sitter added a comment.


  In https://phabricator.kde.org/D2377#44484, @heikobecker wrote:
  
  > So I think two Find... modules are also needed or "message..." should stay.
  
  
  Well. No.
  
  https://cmake.org/cmake/help/v3.0/command/find_package.html
  
  > Every non-REQUIRED find_package call can be disabled by setting the 
CMAKE_DISABLE_FIND_PACKAGE_ variable to TRUE.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: heikobecker, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 98 lines] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 5758.
bshah added a comment.


  fix powerdevil exiting on wayland

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2372?vs=5751=5758

BRANCH
  powerdevil-executable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2372

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  daemon/kdedpowerdevil.cpp
  daemon/kdedpowerdevil.h
  daemon/powerdevil.desktop
  daemon/powerdevil.desktop.cmake
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Plasma desktop window uses RGBA

[Martin Graesslin]

Hi all,

I just noticed that Plasma's desktop window uses an RGBA format. This is not 
only completely pointless as it's the bottom most window, it's also destroying 
all optimizations in KWin. KWin always has to go into the blending code path, 
which means rendering from bottom to top instead of rendering from top to 
bottom. And also KWin always has to clear the color buffer before rendering 
the Plasma desktop window.

Anyone an idea how we can change this?

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.

[Differential] [Request, 60 lines] D2378: Instanciate the launcher tasks model only when needed.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Previously the launcher tasks model was always instanciated; with
  this change it's only done once a launcher list gets set or a
  request to add a launcher happens. This avoids an unnecessary model
  in TasksModel instances that will never store any launchers (e.g.
  in the Window List applet).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2378

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

[heikobecker (Heiko Becker)]

heikobecker added a comment.


  I like packages stating their dependencies (even runtime ones) because that's 
where I look first as a packager. But if I'm not missing something (maybe a git 
add?) this change is a bit misleading because they can never be found. So I 
think two Find... modules are also needed or "message..." should stay.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: heikobecker, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D2372: Make powerdevil normal executable instead of kded module

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:137
>  
> -#include "kdedpowerdevil.moc"
> +int main(int argc, char **argv)
> +{

Should it have KCrash::setFlags(AutoRestart) ?

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: davidedmundson, shumski, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2325: Don't unconditionally emit buttonPressed on profile load

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  This is like a tutorial in how to make useless code comments.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, afiestas, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/
---

(Updated Aug. 9, 2016, 8:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 45a2f5a8286d9884fdf1161c09da5807c0528481 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

The QSGTextures are created with

window()->createTextureFromId(m_texture, QSize(w,h),
QuickWindow::TextureOwnsGLTexture));

this means we don't want to be deleting textures ourselves too, it will
be deleted when we delete the QSGTexture, which is a scoped pointer
inside our QSGNode.

BUG: 355644
REVIEW:


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 
6c46789b13411fe311c4d3fb60c690abd966cc38 

Diff: https://git.reviewboard.kde.org/r/126131/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 128612: Add translation domain to wallpaper QML object

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128612/
---

(Updated Aug. 9, 2016, 8:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 7364377a06685e89d82fdb15008fd53aac8bea93 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Add translation domain to wallpaper context.


Diffs
-

  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 
507c82f03b76a948e1c8e07e546756a172359a40 

Diff: https://git.reviewboard.kde.org/r/128612/diff/


Testing
---

Tested with qDebug.

not convinced if it makes sense unless the config view is also fixable.


Thanks,

David Edmundson

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review98219
---


Ship it!




Ship It!

- Martin Gräßlin


On July 21, 2016, 3:37 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126131/
> ---
> 
> (Updated July 21, 2016, 3:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The QSGTextures are created with
> 
> window()->createTextureFromId(m_texture, QSize(w,h),
> QuickWindow::TextureOwnsGLTexture));
> 
> this means we don't want to be deleting textures ourselves too, it will
> be deleted when we delete the QSGTexture, which is a scoped pointer
> inside our QSGNode.
> 
> BUG: 355644
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 6c46789b13411fe311c4d3fb60c690abd966cc38 
> 
> Diff: https://git.reviewboard.kde.org/r/126131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:383
> No
> 
> you need to loop through containments() rather than the views
> (same for panel section)
> 
> Otherwise:
> 
> - you're only saving the currently plugged in screens.
> - this won't save the configuration for any applets in a system tray.
> 
> and when you do do the system tray you're going to have a huge problem:
> system tray writes out SystrayContainmentId... you aren't going to know what 
> that is.

can't for panels, as their geometry is saved in the view as it should be, 
because they have a separate geometry setting per screen.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve added a comment.


  In https://phabricator.kde.org/D1989#44453, @graesslin wrote:
  
  > I just remembered: on X11 one needs to subtract 8 from the key code...
  
  
  The keyEvents are working perfectly now because of the solution you gave. 
Thank you. :-)
  Are there any other issues in the code?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:321
> If we go with this patch
> 
> you should filter out ItemGeometries and AppletOrder here as you're making a 
> special case out of them.
> Otherwise you're saving garbage data in the config which could conflict; one 
> of the new IDs could clash.
> 
> Also what's going to happen to activityId

yep, same thing for location and form factor i think

> davidedmundson wrote in shellcorona.cpp:394
> If every way is a hack, then maybe this feature shouldn't go in at all.
> 
> So the root issue is:
> 
> - for saving/restory applet geometry is handled by the containment which is 
> in completely arbitrary as it's done by that containment plugin.
> - they use the ID of the applet for an index
> - ID won't be the same
> 
> Brainstorming, there is an option.
> *if* we assume dump and resume is always going to be from a clean setup we 
> could just expose setting initial id to applet scripting. It's already in 
> Plasma::Containment. it would fix all the problems without any hacks.
> 
> -
> 
> I can imagine this patch will destroy PMC if someone switched LNF twice as 
> you're hardcoding stuff in plasma-workspace based on behaviour of 
> plasma-desktop.

yes, it's always from a clean setup..
if you look back in the revision history, creating the applet with  a specified 
id was exactly what it was doing in the early revisions.
As this would have needed some ugly changes to the desktop containment, after a 
discussion with Eike we decided to go this route instead, as it doesn't expose 
directly the config file format in the scripting.

> davidedmundson wrote in shellcorona.cpp:394
> If every way is a hack, then maybe this feature shouldn't go in at all.
> 
> So the root issue is:
> 
> - for saving/restory applet geometry is handled by the containment which is 
> in completely arbitrary as it's done by that containment plugin.
> - they use the ID of the applet for an index
> - ID won't be the same
> 
> Brainstorming, there is an option.
> *if* we assume dump and resume is always going to be from a clean setup we 
> could just expose setting initial id to applet scripting. It's already in 
> Plasma::Containment. it would fix all the problems without any hacks.
> 
> -
> 
> I can imagine this patch will destroy PMC if someone switched LNF twice as 
> you're hardcoding stuff in plasma-workspace based on behaviour of 
> plasma-desktop.

to me this feature is very desktop specific (so much that i even thought at 
some point loading it in a plugin only for the desktop shell...
I would consider to just ignore l changes on shells different from the 
desktop one, and even to not to dump config for containments different than the 
3 default ones

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 347 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5755.
bdhruve added a comment.


  Added back the keyEvent handling and works perfectly now.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=5753=5755

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Request, 15 lines] D2377: use the feature summary to communicate runtime deps

[sitter (Harald Sitter)]

sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  - cmake
  - prints warning
  - can be overridden with CMAKE_DISABLE_FIND_PACKAGE_foo

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2377

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[Martin Gräßlin]

graesslin added a comment.


  I just remembered: on X11 one needs to subtract 8 from the key code...

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 328 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5753.
bdhruve added a comment.


  Remove keyEvent handling.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=5713=5753

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Ping.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, afiestas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 97 lines] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 5751.
bshah added a comment.


  read shortcuts from kded5 component, unfortunately its close to impossible to 
migrate shortcuts using kconf_update

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2372?vs=5749=5751

BRANCH
  powerdevil-executable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2372

AFFECTED FILES
  daemon/CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  daemon/kdedpowerdevil.cpp
  daemon/kdedpowerdevil.h
  daemon/powerdevil.desktop
  daemon/powerdevil.desktop.cmake
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: shumski, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 128633: Wether nor not install the private header?

[Leslie Zhai]

> On 八月 9, 2016, 2:20 p.m., Sune Vuorela wrote:
> > I think it was a bug that the individual barcode headers was public in the 
> > qt4 based prison. Now that we are about to release a qt5 based prison, it 
> > is time to fix that bug.
> > 
> > Basically, I don't want the interface to change depending on what supposed 
> > backends prison is compiled with.
> > 
> > createBarcode can be queried, and the result tested for null pointers if a 
> > specific feature is not compiled in. At runtime. So things can be 
> > enabled/disabled as needed without requiring changes in other parts of the 
> > code.
> > 
> > It is a very deliberate action to not install the headers any more.

agree ;-) 
https://github.com/xiangzhai/qwx/commit/acb0b78cc0885a7234dc1ea4f8284ef96df35ae2


- Leslie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128633/#review98213
---


On 八月 9, 2016, 2:49 p.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128633/
> ---
> 
> (Updated 八月 9, 2016, 2:49 p.m.)
> 
> 
> Review request for Plasma and Sune Vuorela.
> 
> 
> Repository: prison
> 
> 
> Description
> ---
> 
> Hi Sune,
> 
> People might directly use Prison::QRCodeBarcode 
> https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of 
> via Prison::createBarcode
> 
> so is it able to install the private header?
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 95391cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128633/diff/
> 
> 
> Testing
> ---
> 
> - prison/tests/test-prison
> - plasma-workspace/klipper
> - qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128633: Wether nor not install the private header?

[Leslie Zhai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128633/
---

(Updated Aug. 9, 2016, 6:49 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Sune Vuorela.


Changes
---

Submitted with commit 2b21133372c82374977878e4d55538c16df68e95 by Leslie Zhai 
to branch frameworks.


Repository: prison


Description
---

Hi Sune,

People might directly use Prison::QRCodeBarcode 
https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of via 
Prison::createBarcode

so is it able to install the private header?

Regards,
Leslie Zhai


Diffs
-

  lib/CMakeLists.txt 95391cc 

Diff: https://git.reviewboard.kde.org/r/128633/diff/


Testing
---

- prison/tests/test-prison
- plasma-workspace/klipper
- qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h


Thanks,

Leslie Zhai

[Differential] [Planned Changes To] D2372: Make powerdevil normal executable instead of kded module

[bshah (Bhushan Shah)]

bshah planned changes to this revision.
bshah added a comment.


  I  just realized that this breaks the shortcuts, and I need to migrate older 
shortcuts over.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, graesslin
Cc: shumski, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 128633: Wether nor not install the private header?

[Sune Vuorela]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128633/#review98213
---



I think it was a bug that the individual barcode headers was public in the qt4 
based prison. Now that we are about to release a qt5 based prison, it is time 
to fix that bug.

Basically, I don't want the interface to change depending on what supposed 
backends prison is compiled with.

createBarcode can be queried, and the result tested for null pointers if a 
specific feature is not compiled in. At runtime. So things can be 
enabled/disabled as needed without requiring changes in other parts of the code.

It is a very deliberate action to not install the headers any more.

- Sune Vuorela


On Aug. 9, 2016, 6:03 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128633/
> ---
> 
> (Updated Aug. 9, 2016, 6:03 a.m.)
> 
> 
> Review request for Plasma and Sune Vuorela.
> 
> 
> Repository: prison
> 
> 
> Description
> ---
> 
> Hi Sune,
> 
> People might directly use Prison::QRCodeBarcode 
> https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of 
> via Prison::createBarcode
> 
> so is it able to install the private header?
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 95391cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128633/diff/
> 
> 
> Testing
> ---
> 
> - prison/tests/test-prison
> - plasma-workspace/klipper
> - qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128633: Wether nor not install the private header?

[Leslie Zhai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128633/
---

(Updated 八月 9, 2016, 2:03 p.m.)


Review request for Plasma and Sune Vuorela.


Repository: prison


Description
---

Hi Sune,

People might directly use Prison::QRCodeBarcode 
https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of via 
Prison::createBarcode

so is it able to install the private header?

Regards,
Leslie Zhai


Diffs
-

  lib/CMakeLists.txt 95391cc 

Diff: https://git.reviewboard.kde.org/r/128633/diff/


Testing
---

- prison/tests/test-prison
- plasma-workspace/klipper
- qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h


Thanks,

Leslie Zhai