[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366795

--- Comment #10 from Elvis Angelaccio  ---
(In reply to Elvis Angelaccio from comment #9)
> sftp:// is also affected.

Actually sftp is fine. I thought that kdeconnect was using sftp://, but instead
it has its own kio slave, so I filed another report for it:
https://bugs.kde.org/show_bug.cgi?id=367878

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 8 lines] D2596: [Colors KCM] Disable "Edit Scheme" button if cannot be edited

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The default scheme cannot be edited, yields a "Scheme not found" error when 
trying to, and when no scheme is selected, we cannot edit it either.

TEST PLAN
  When edit scheme dialog closes, no scheme is selected in the list, previously 
the KCM would crash when clicking Edit scheme again. I also no longer get a 
"Scheme not found" warning when trying to edit the default scheme because I no 
longer can.
  
  It's quite annoying that the buttons have no edit or remove icon, though.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2596

AFFECTED FILES
  kcms/colors/colorscm.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 287 lines] D2595: Fix comic applet appearance

[gladhorn (Frederik Gladhorn)]

gladhorn updated this revision to Diff 6308.
gladhorn added a comment.


  Testing arc diff update... Just a small improvement to the indentation look.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2595?vs=6307=6308

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2595

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gladhorn
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 288 lines] D2595: Fix comic applet appearance

[gladhorn (Frederik Gladhorn)]

gladhorn created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Move all the code that was supposed to be the applet into
  Plasmoid.fullReprensentation. Otherwise only the compact representation
  is shown which is just the icon.
  
  BUG: 361928

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2595

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gladhorn
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 287 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/287/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 18:25:47 +
Build duration: 14 min

CHANGE SET
Revision 97075f3a0f7323b11387fb2fa9658c409f5f745f by lueck: (Proofread 
solid-device-automounter kcm docbook)
  change: edit doc/kcontrol/solid-device-automounter/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 286 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/286/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 18:17:24 +
Build duration: 5 min 41 sec

CHANGE SET
Revision bc3b11c0aa860b85fc4049beda8566d575ad2e71 by lueck: (Update 
solid-actions kcm docbook)
  change: edit doc/kcontrol/solid-actions/add-action.png
  change: edit doc/kcontrol/solid-actions/main.png
  change: edit doc/kcontrol/solid-actions/edit-action.png
  change: edit doc/kcontrol/solid-actions/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128770/
---

(Updated Aug. 26, 2016, 11:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 97075f3a0f7323b11387fb2fa9658c409f5f745f by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
kde->plasma


Diffs
-

  doc/kcontrol/solid-device-automounter/index.docbook 3c687fc 

Diff: https://git.reviewboard.kde.org/r/128770/diff/


Testing
---


Thanks,

Burkhard Lück

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128769/
---

(Updated Aug. 26, 2016, 8:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit bc3b11c0aa860b85fc4049beda8566d575ad2e71 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
kde->plasma
update screenshots


Diffs
-

  doc/kcontrol/solid-actions/add-action.png 67b4ea9 
  doc/kcontrol/solid-actions/edit-action.png aa2731b 
  doc/kcontrol/solid-actions/index.docbook 54da3ee 
  doc/kcontrol/solid-actions/main.png 19c91c6 

Diff: https://git.reviewboard.kde.org/r/128769/diff/


Testing
---

passes checkXML5


File Attachments


main.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/43e59142-647c-48e0-b871-530fed84d69a__main.png
add-action.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/861db8be-73f5-4249-be3e-cd020a8bbc03__add-action.png
edit-action.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/4cf0cf6f-df2f-4353-acd0-a10b4f239ff4__edit-action.png


Thanks,

Burkhard Lück

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 285 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/285/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 18:10:34 +
Build duration: 5 min 58 sec

CHANGE SET
Revision 0b95dd333b07f7942f2d28d0aacf0e6306997280 by lueck: (Proofread + update 
baloo kcm docbook)
  change: edit doc/kcontrol/baloo/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128772: Proofread + update baloo kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128772/
---

(Updated Aug. 26, 2016, 6:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Plasma and Vishesh Handa.


Changes
---

Submitted with commit 0b95dd333b07f7942f2d28d0aacf0e6306997280 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

fix title
kde -> plasma
add how to use the index results (widget, krunnel, kmail)
fix markup of $HOME
add info to enable search


Diffs
-

  doc/kcontrol/baloo/index.docbook cc95060 

Diff: https://git.reviewboard.kde.org/r/128772/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366795

--- Comment #9 from Elvis Angelaccio  ---
sftp:// is also affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

[hein (Eike Hein)]

hein accepted this revision.
hein added a reviewer: hein.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2591

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mart, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2594: Add new session button to SessionsModel

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in CMakeLists.txt:1
> unrelated?

I was introducting i18n into components/sessionsprivate which previously didn't 
have it

I didn't want to make a new .pot for 2 words, so I moved the 
-DTRANSLATION_DOMAN and Messages.sh 
from components/shellprivate -> components

so that it covers all items in components.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2594

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2462: Remove deprecated code in kscreenlocker theme

[davidedmundson (David Edmundson)]

davidedmundson abandoned this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[Thomas Lübking]

luebking added a comment.


  They'll unredirect the window. The property is however not mandarory:
  
  "The compositing manager MAY bypass compositing for both fullscreen and 
non-fullscreen windows if bypassing is requested" (the supplemental "but MUST 
NOT bypass if it would cause differences from the composited appearance" btw. 
effectively means that the hint must be ignored in all cases or adjusted with 
every painted frame. It's a really shitty protocol)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

[Peter Wu]

> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote:
> > kstyle/breezestyleplugin.cpp, line 44
> > 
> >
> > This must be not (!inited).
> > However this is not proper fix. Correct and test patch in this way
> > 
> > QPointer style = new Style;
> > 
> > Below unchanged, so when QPointer got delete it hold nullptr by itself 
> > and delete will be safe.
> 
> Peter Wu wrote:
> This does not work since the interface requires a QStyle pointer. If I 
> use this, I guess the caller unwraps it into a raw pointer and the issue is 
> still triggered.
> 
> Good point about `if (!inited)`, forgot to change this while renaming. 
> I'll fix it for the next version. Do you know the root cause of the original 
> issue that required the use of this? It is not documented by Qt.
> 
> Anthony Fieroni wrote:
> QPointer track QObject and he knows when it's life or not, so issue must 
> be fixed, at end
> 
> return style.data();
> 
> Peter Wu wrote:
> `style.data()` should not be needed because the cast operator of QPointer 
> does this implicitly. (I did test it though and it makes no difference.)
> 
> Digging further, I am not convinced that this patch (or the previous 
> code) is correct. While the result of `QApplication::style()` is ignored, its 
> parent is set to a `QApplication` instance. So when a program exits normally, 
> QApplication will be taking care of the QStyle instance. When `exit()` is 
> invoked, the QApplication destructor does not seem to be called which 
> probably led to the code in the first place.
> 
> I am tempted to remove the delete code completely, it seems a 
> hack/workaround at the wrong level. Thoughts?
> 
> Anthony Fieroni wrote:
> You can test to remove manual deleting with style->setParent(this)

Setting `style->setParent(0)` in the two places (the initial 
`QApplication::style()` call and the internal `QProxyStyle` code from the 
testcase) prevents the crash on `exit()`. What about removing the `delete 
style` code, what are the risks for that?


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review98667
---


On Aug. 25, 2016, 11:56 p.m., Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Aug. 25, 2016, 11:56 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Do not delete all style instances which we create, restrict ourselves to
> the first instance. I have no idea if the delete hack is still needed,
> but let's keep it until it is certain that it is unneeded.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Used "Testcase (with ASAN)" from bug 
> https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. 
> Double-checked with a breakpoint on Breeze::StylePlugin::create that the 
> second instance is called through QProxyStyle.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

[Differential] [Accepted] D2594: Add new session button to SessionsModel

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:1
> +add_definitions(-DTRANSLATION_DOMAIN=\"plasmashellprivateplugin\")
> +

unrelated?

> CMakeLists.txt:20
>  KF5::ConfigGui
> +KF5::I18n
>  PW::KWorkspace

in same commit as -DTRANSLATION_DOMAIN?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2594

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 74 lines] D2594: Add new session button to SessionsModel

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This (optionally) appends an entry to the SessionsModel to append a "New
  Session" option. The lock screen / user switcher are then modified to
  use it.
  
  Messages.sh is modified so all components are covered by the same pot.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2594

AFFECTED FILES
  components/CMakeLists.txt
  components/Messages.sh
  components/sessionsprivate/CMakeLists.txt
  components/sessionsprivate/sessionsmodel.cpp
  components/sessionsprivate/sessionsmodel.h
  components/shellprivate/CMakeLists.txt
  components/shellprivate/Messages.sh
  lookandfeel/contents/components/UserList.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/userswitcher/UserSwitcher.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 18 lines] D2593: Unify looks of the GlobalDrawer

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Make sure we specify a sourceSize so that we can render svg images of
  any size.
  Make it possible to specify the ratio so we are not force it to get it from
  the sourceSize

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2593

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2584#48381, @broulik wrote:
  
  > Plasma is the only major desktop environment that still supports a 
non-composited uscase. Unity and Gnome cannot disable it in the first place.
  
  
  Oh, so they just ignore that request from applications completely?
  In that case, we're fine with doing whatever we want ;)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

[Anthony Fieroni]

> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote:
> > kstyle/breezestyleplugin.cpp, line 44
> > 
> >
> > This must be not (!inited).
> > However this is not proper fix. Correct and test patch in this way
> > 
> > QPointer style = new Style;
> > 
> > Below unchanged, so when QPointer got delete it hold nullptr by itself 
> > and delete will be safe.
> 
> Peter Wu wrote:
> This does not work since the interface requires a QStyle pointer. If I 
> use this, I guess the caller unwraps it into a raw pointer and the issue is 
> still triggered.
> 
> Good point about `if (!inited)`, forgot to change this while renaming. 
> I'll fix it for the next version. Do you know the root cause of the original 
> issue that required the use of this? It is not documented by Qt.
> 
> Anthony Fieroni wrote:
> QPointer track QObject and he knows when it's life or not, so issue must 
> be fixed, at end
> 
> return style.data();
> 
> Peter Wu wrote:
> `style.data()` should not be needed because the cast operator of QPointer 
> does this implicitly. (I did test it though and it makes no difference.)
> 
> Digging further, I am not convinced that this patch (or the previous 
> code) is correct. While the result of `QApplication::style()` is ignored, its 
> parent is set to a `QApplication` instance. So when a program exits normally, 
> QApplication will be taking care of the QStyle instance. When `exit()` is 
> invoked, the QApplication destructor does not seem to be called which 
> probably led to the code in the first place.
> 
> I am tempted to remove the delete code completely, it seems a 
> hack/workaround at the wrong level. Thoughts?

You can test to remove manual deleting with style->setParent(this)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review98667
---


On Авг. 26, 2016, 12:56 преди обяд, Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Авг. 26, 2016, 12:56 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Do not delete all style instances which we create, restrict ourselves to
> the first instance. I have no idea if the delete hack is still needed,
> but let's keep it until it is certain that it is unneeded.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Used "Testcase (with ASAN)" from bug 
> https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. 
> Double-checked with a breakpoint on Breeze::StylePlugin::create that the 
> second instance is called through QProxyStyle.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Plasma is the only major desktop environment that still supports a 
non-composited uscase. Unity and Gnome cannot disable it in the first place.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

[Peter Wu]

> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote:
> > kstyle/breezestyleplugin.cpp, line 44
> > 
> >
> > This must be not (!inited).
> > However this is not proper fix. Correct and test patch in this way
> > 
> > QPointer style = new Style;
> > 
> > Below unchanged, so when QPointer got delete it hold nullptr by itself 
> > and delete will be safe.
> 
> Peter Wu wrote:
> This does not work since the interface requires a QStyle pointer. If I 
> use this, I guess the caller unwraps it into a raw pointer and the issue is 
> still triggered.
> 
> Good point about `if (!inited)`, forgot to change this while renaming. 
> I'll fix it for the next version. Do you know the root cause of the original 
> issue that required the use of this? It is not documented by Qt.
> 
> Anthony Fieroni wrote:
> QPointer track QObject and he knows when it's life or not, so issue must 
> be fixed, at end
> 
> return style.data();

`style.data()` should not be needed because the cast operator of QPointer does 
this implicitly. (I did test it though and it makes no difference.)

Digging further, I am not convinced that this patch (or the previous code) is 
correct. While the result of `QApplication::style()` is ignored, its parent is 
set to a `QApplication` instance. So when a program exits normally, 
QApplication will be taking care of the QStyle instance. When `exit()` is 
invoked, the QApplication destructor does not seem to be called which probably 
led to the code in the first place.

I am tempted to remove the delete code completely, it seems a hack/workaround 
at the wrong level. Thoughts?


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review98667
---


On Aug. 25, 2016, 11:56 p.m., Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Aug. 25, 2016, 11:56 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Do not delete all style instances which we create, restrict ourselves to
> the first instance. I have no idea if the delete hack is still needed,
> but let's keep it until it is certain that it is unneeded.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Used "Testcase (with ASAN)" from bug 
> https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. 
> Double-checked with a breakpoint on Breeze::StylePlugin::create that the 
> second instance is called through QProxyStyle.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Actually, I'm not really convinced of this. Blocking compositing is done via 
an official, cross-desktop API, isn't it? It's not a KWin-specific feature, 
right?
  If so, then KWin should not go alone in offering this config option. If I'm 
an application developer and have set my application to block compositing, I'd 
expect that to be respected. If most compositors always respect it, but for one 
compositor, it depends on a user setting, this introduces another layer of 
complexity for application developers.
  Knowing our users, some of them will turn this off, knowing it will impact 
performance, but will then still go ahead and file bug reports about a game 
being too slow, or whatever happening because the game developer just expected 
blocking compositing to work, but for those users, it doesn't.
  
  If it's made configurable in all major compositors, then application 
developers at least know that they cannot expect blocking compositing to work. 
If we're the only ones allowing to configure it, it will get messy.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Differential] [Closed] D2592: Properly place the title in the layout

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI47337e8b7c34: Properly place the title in the layout 
(authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2592?vs=6302=6303

REVISION DETAIL
  https://phabricator.kde.org/D2592

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Accepted] D2592: Properly place the title in the layout

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2592

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Request, 7 lines] D2592: Properly place the title in the layout

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Let the text elide if it doesn't fit
  Use layout properties instead of adding an empty item

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2592

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Accepted] D2585: [Applet Configuration] Only scroll down if item is barely visible

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2585

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2591

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128772: Proofread + update baloo kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128772/#review98697
---


Fix it, then Ship it!





doc/kcontrol/baloo/index.docbook (line 19)


5.8?


- Marco Martin


On Aug. 26, 2016, 12:33 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128772/
> ---
> 
> (Updated Aug. 26, 2016, 12:33 p.m.)
> 
> 
> Review request for Documentation, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> fix title
> kde -> plasma
> add how to use the index results (widget, krunnel, kmail)
> fix markup of $HOME
> add info to enable search
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/baloo/index.docbook cc95060 
> 
> Diff: https://git.reviewboard.kde.org/r/128772/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128769/#review98696
---




doc/kcontrol/solid-actions/index.docbook (line 17)


5.8?


- Marco Martin


On Aug. 26, 2016, 10:04 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128769/
> ---
> 
> (Updated Aug. 26, 2016, 10:04 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> kde->plasma
> update screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/solid-actions/add-action.png 67b4ea9 
>   doc/kcontrol/solid-actions/edit-action.png aa2731b 
>   doc/kcontrol/solid-actions/index.docbook 54da3ee 
>   doc/kcontrol/solid-actions/main.png 19c91c6 
> 
> Diff: https://git.reviewboard.kde.org/r/128769/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> main.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/43e59142-647c-48e0-b871-530fed84d69a__main.png
> add-action.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/861db8be-73f5-4249-be3e-cd020a8bbc03__add-action.png
> edit-action.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/4cf0cf6f-df2f-4353-acd0-a10b4f239ff4__edit-action.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128769/#review98695
---


Ship it!




Ship It!

- Marco Martin


On Aug. 26, 2016, 10:04 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128769/
> ---
> 
> (Updated Aug. 26, 2016, 10:04 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> kde->plasma
> update screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/solid-actions/add-action.png 67b4ea9 
>   doc/kcontrol/solid-actions/edit-action.png aa2731b 
>   doc/kcontrol/solid-actions/index.docbook 54da3ee 
>   doc/kcontrol/solid-actions/main.png 19c91c6 
> 
> Diff: https://git.reviewboard.kde.org/r/128769/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> main.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/43e59142-647c-48e0-b871-530fed84d69a__main.png
> add-action.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/861db8be-73f5-4249-be3e-cd020a8bbc03__add-action.png
> edit-action.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/4cf0cf6f-df2f-4353-acd0-a10b4f239ff4__edit-action.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128770/#review98694
---


Ship it!




Ship It!

- Marco Martin


On Aug. 26, 2016, 10:12 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128770/
> ---
> 
> (Updated Aug. 26, 2016, 10:12 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> kde->plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/solid-device-automounter/index.docbook 3c687fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[David Edmundson]

> On Aug. 26, 2016, 11:16 a.m., Martin Gräßlin wrote:
> > Ship It!

Not merging yet as someone (loa) on IRC reports a crash with this - I'm quite 
sure I know what it'll be, the runnable trying to access WindowThumbnail after 
it's been deleted. I think I'll have to split all the vars that I marked should 
only be used from the render thread into a separate struct.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98684
---


On Aug. 26, 2016, 1:04 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> ---
> 
> (Updated Aug. 26, 2016, 1:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the 
> GUI thread. Whislt it's not going to cause a threading issue (as 
> updatePaintNode always ran when the main thread was blocked) we're not meant 
> to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong 
> one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread 
> and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.h 
> 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> ---
> 
> Using nvidia with proprietory drivers (which puts me 
> QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. 
> Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather 
> than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128767: Fix crash when no QApplication is available.

[David Faure]

> On Aug. 26, 2016, 1:06 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qmenu.cpp, line 91
> > 
> >
> > and these ones?

Not called by qmlpluginscanner, but yeah if you prefer I can add if()s in all 
methods.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128767/#review98691
---


On Aug. 26, 2016, 7:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128767/
> ---
> 
> (Updated Aug. 26, 2016, 7:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This happens when QtCreator launches qmlplugindump.
> Testcase: qmlplugindump -nonrelocatable org.kde.analitza 1.1
> or qmlplugindump -nonrelocatable org.kde.okular 2.0
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 
> b7037da2ade97ce3632efa8f77e2a3f16e54107e 
> 
> Diff: https://git.reviewboard.kde.org/r/128767/diff/
> 
> 
> Testing
> ---
> 
> see description
> 
> Lots of warnings still, but at least it doesn't crash.
> 
> QObject: Cannot create children for a parent that is in a different thread.
> (Parent is QGuiApplication(0x7ffd16f340c0), parent's thread is 
> QThread(0x14af560), current thread is QThread(0x14e4240)
> Could not find any platform plugin
> 
> 
> Thanks,
> 
> David Faure
> 
>

Re: Review Request 128767: Fix crash when no QApplication is available.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128767/#review98691
---




src/declarativeimports/plasmacomponents/qmenu.cpp (line 91)


and these ones?


- David Edmundson


On Aug. 26, 2016, 7:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128767/
> ---
> 
> (Updated Aug. 26, 2016, 7:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This happens when QtCreator launches qmlplugindump.
> Testcase: qmlplugindump -nonrelocatable org.kde.analitza 1.1
> or qmlplugindump -nonrelocatable org.kde.okular 2.0
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 
> b7037da2ade97ce3632efa8f77e2a3f16e54107e 
> 
> Diff: https://git.reviewboard.kde.org/r/128767/diff/
> 
> 
> Testing
> ---
> 
> see description
> 
> Lots of warnings still, but at least it doesn't crash.
> 
> QObject: Cannot create children for a parent that is in a different thread.
> (Parent is QGuiApplication(0x7ffd16f340c0), parent's thread is 
> QThread(0x14af560), current thread is QThread(0x14e4240)
> Could not find any platform plugin
> 
> 
> Thanks,
> 
> David Faure
> 
>

[Differential] [Request, 3 lines] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  By reducing spacing and lineHeight for the heading in case of a two line 
heading we ensure the popup usually doesn't change height when moving between 
entries.
  
  Spacing previously was "_s" which was equal to largeSpacing / 2 but during 
porting this was errorneously changed.

TEST PLAN
  With multiple virtual desktops, hovered between:
  
  - A window with one line title
  - A window group
  - A window with two line title
  
  and tooltip did not change its height

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2591

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 12:38:16 +
Build duration: 14 min

CHANGE SET
Revision b20c89677b56075e3e27808c88438b48ec27 by David Edmundson: (restore 
missing include)
  change: edit drkonqi/systeminformation.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 52/72 (72%)CLASSES 52/72 (72%)LINE 2049/5417 
(38%)CONDITIONAL 1413/5364 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/19 (26%)CLASSES 5/19 (26%)LINE 139/3067 (5%)CONDITIONAL 
88/3023 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 12:38:16 +
Build duration: 14 min

CHANGE SET
Revision b20c89677b56075e3e27808c88438b48ec27 by David Edmundson: (restore 
missing include)
  change: edit drkonqi/systeminformation.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 52/72 (72%)CLASSES 52/72 (72%)LINE 2049/5417 
(38%)CONDITIONAL 1413/5364 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/19 (26%)CLASSES 5/19 (26%)LINE 139/3067 (5%)CONDITIONAL 
88/3023 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 389 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/389/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 12:32:32 +
Build duration: 4 min 20 sec

CHANGE SET
Revision 16cff5424074eeb6f55e39ac6c602b932a915b3d by Marco Martin: (link to 
kf5quickaddons)
  change: add lookandfeel/contents/previews/fullscreenpreview.jpg
  change: edit lookandfeel/contents/previews/preview.png
  change: edit krunner/CMakeLists.txt

Review Request 128772: Proofread + update baloo kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128772/
---

Review request for Documentation, Plasma and Vishesh Handa.


Repository: plasma-desktop


Description
---

fix title
kde -> plasma
add how to use the index results (widget, krunnel, kmail)
fix markup of $HOME
add info to enable search


Diffs
-

  doc/kcontrol/baloo/index.docbook cc95060 

Diff: https://git.reviewboard.kde.org/r/128772/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> luebking wrote in compositing.h:63
> The "is" prefix is a QML mandate, right?
> 
> isObeyingCompositorBlockRequests
> isCompositorBlockAllowed
> 
> However, afaiu the biggest complaint was that it was broken (due to shadow 
> deletion) yesno? Really worth a setting (rather than a blind rule to achieve 
> the same)?

> However, afaiu the biggest complaint was that it was broken (due to shadow 
> deletion) yesno?

No, I also had quite a fair amount of feedback unrelated to the shadow.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas

[Differential] [Updated, 99 lines] D2584: Introduce a config option whether applications are allowed to block compositing

[Martin Gräßlin]

graesslin updated this revision to Diff 6296.
graesslin added a comment.


  reword to applications instead of windows

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2584?vs=6286=6296

BRANCH
  blocking-compositing

REVISION DETAIL
  https://phabricator.kde.org/D2584

AFFECTED FILES
  client.cpp
  kcmkwin/kwincompositing/compositing.cpp
  kcmkwin/kwincompositing/compositing.h
  kcmkwin/kwincompositing/compositing.ui
  kcmkwin/kwincompositing/main.cpp
  kwin.kcfg
  options.cpp
  options.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> compositing.h:63
>  int openGLPlatformInterface() const;
> +bool isWindowsBlockingCompositing() const;
>  

The "is" prefix is a QML mandate, right?

isObeyingCompositorBlockRequests
isCompositorBlockAllowed

However, afaiu the biggest complaint was that it was broken (due to shadow 
deletion) yesno? Really worth a setting (rather than a blind rule to achieve 
the same)?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 388 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/388/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 12:07:49 +
Build duration: 3 min 43 sec

CHANGE SET
Revision 85a561b71008c4baee6e6a1f8e09ab9093d11165 by David Edmundson: (Drop 
outdated KF5 version check)
  change: edit drkonqi/systeminformation.cpp

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 387 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/387/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 12:00:07 +
Build duration: 7 min 33 sec

CHANGE SET
Revision 792ca1d6489d6428de4039c25f289fbdfa08a83c by David Edmundson: (Load 
QtQuickSettings)
  change: edit krunner/main.cpp
  change: edit shell/main.cpp
Revision 54652ce3a3b483d0235fc0dce5d6797d15662bf7 by David Edmundson: (Remove 
QT_VERSION checks when we depend on a newer QT version anyway)
  change: edit shell/shellcorona.cpp
  change: edit krunner/main.cpp
  change: edit shell/main.cpp
  change: edit klipper/main.cpp

[Differential] [Closed] D2587: Set proper component name for plasma-discover

[bshah (Bhushan Shah)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rDISCOVER663b245051ad: Set proper component name for 
plasma-discover (authored by bshah).

REPOSITORY
  rDISCOVER Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2587?vs=6290=6295

REVISION DETAIL
  https://phabricator.kde.org/D2587

AFFECTED FILES
  discover/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2588: Load QtQuickSettings

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE792ca1d6489d: Load QtQuickSettings (authored 
by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2588?vs=6291=6294

REVISION DETAIL
  https://phabricator.kde.org/D2588

AFFECTED FILES
  krunner/main.cpp
  shell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2587: Set proper component name for plasma-discover

[apol (Aleix Pol Gonzalez)]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I thought so.

REPOSITORY
  rDISCOVER Discover Software Store

BRANCH
  setpropercomponentname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2587

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2588: Load QtQuickSettings

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2588

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[mart (Marco Martin)]

mart added a comment.


  yeah, should be "allow applications" even if not 100% correct

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Request, 15 lines] D2590: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
davidedmundson added a subscriber: plasma-devel.
davidedmundson added a project: Plasma.

TEST PLAN
  Clicked a new connection. Toggled show/hide action

REPOSITORY
  rPLASMANM Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2590

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2589: Make the AbstractListItem a Rectangle

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described by the documentation and as it makes sense.

TEST PLAN
  Seems to just work

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2589

AFFECTED FILES
  src/controls/templates/AbstractListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Request, 5 lines] D2588: Load QtQuickSettings

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2588

AFFECTED FILES
  krunner/main.cpp
  shell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2587: Set proper component name for plasma-discover

[bshah (Bhushan Shah)]

bshah added a comment.


  In https://phabricator.kde.org/D2587#48297, @apol wrote:
  
  > Are you sure it wasn't because of this?
  >  http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8
  
  
  setWindowIcon doesn't work on wayland.. See  - 
https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/
 "Setting window icon" section.

REPOSITORY
  rDISCOVER Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D2587

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2455: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Will re-upload this

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2455

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2587: Set proper component name for plasma-discover

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  Are you sure it wasn't because of this?
  http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8

REPOSITORY
  rDISCOVER Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D2587

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, graesslin, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2567: Load QtQuick rendering settings from config

[davidedmundson (David Edmundson)]

davidedmundson abandoned this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2567

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98684
---


Ship it!




Ship It!

- Martin Gräßlin


On Aug. 26, 2016, 3:04 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> ---
> 
> (Updated Aug. 26, 2016, 3:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the 
> GUI thread. Whislt it's not going to cause a threading issue (as 
> updatePaintNode always ran when the main thread was blocked) we're not meant 
> to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong 
> one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread 
> and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.h 
> 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> ---
> 
> Using nvidia with proprietory drivers (which puts me 
> QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. 
> Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather 
> than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[Martin Gräßlin]

> On Aug. 26, 2016, 9:49 a.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686
> > 
> >
> > we probably need to do the same for EGL, don't we?
> 
> David Edmundson wrote:
> GLX and ELG are the same.
> I was dropping the xcb_free_pixmap from here, as that is also in 
> stopRedirecting.

sorry for the noise


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98673
---


On Aug. 26, 2016, 3:04 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> ---
> 
> (Updated Aug. 26, 2016, 3:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the 
> GUI thread. Whislt it's not going to cause a threading issue (as 
> updatePaintNode always ran when the main thread was blocked) we're not meant 
> to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong 
> one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread 
> and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.h 
> 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> ---
> 
> Using nvidia with proprietory drivers (which puts me 
> QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. 
> Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather 
> than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

[Anthony Fieroni]

> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote:
> > kstyle/breezestyleplugin.cpp, line 44
> > 
> >
> > This must be not (!inited).
> > However this is not proper fix. Correct and test patch in this way
> > 
> > QPointer style = new Style;
> > 
> > Below unchanged, so when QPointer got delete it hold nullptr by itself 
> > and delete will be safe.
> 
> Peter Wu wrote:
> This does not work since the interface requires a QStyle pointer. If I 
> use this, I guess the caller unwraps it into a raw pointer and the issue is 
> still triggered.
> 
> Good point about `if (!inited)`, forgot to change this while renaming. 
> I'll fix it for the next version. Do you know the root cause of the original 
> issue that required the use of this? It is not documented by Qt.

QPointer track QObject and he knows when it's life or not, so issue must be 
fixed, at end

return style.data();


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review98667
---


On Авг. 26, 2016, 12:56 преди обяд, Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Авг. 26, 2016, 12:56 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Do not delete all style instances which we create, restrict ourselves to
> the first instance. I have no idea if the delete hack is still needed,
> but let's keep it until it is certain that it is unneeded.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Used "Testcase (with ASAN)" from bug 
> https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. 
> Double-checked with a breakpoint on Breeze::StylePlugin::create that the 
> second instance is called through QProxyStyle.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128765/
---

(Updated Aug. 26, 2016, 11:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 7d0b38106105920e9251f3d374af6d1f584f89d6 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Fix cannot assign undefined to double warning in DayDelegate


Diffs
-

  src/declarativeimports/calendar/qml/DayDelegate.qml 
eeb05b5ba550b7fc6b006557467b776c5fddfbb1 

Diff: https://git.reviewboard.kde.org/r/128765/diff/


Testing
---


Thanks,

David Edmundson

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 284 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/284/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 26 Aug 2016 10:56:37 +
Build duration: 15 min

CHANGE SET
Revision 52d6f260addb2f99082b5ce61a63b5fca9afeb57 by Marco Martin: (check for 
model row count momentarly being 0)
  change: edit imports/activitymanager/sortedactivitiesmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[David Edmundson]

> On Aug. 26, 2016, 7:49 a.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686
> > 
> >
> > we probably need to do the same for EGL, don't we?

GLX and ELG are the same.
I was dropping the xcb_free_pixmap from here, as that is also in 
stopRedirecting.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98673
---


On Aug. 26, 2016, 1:04 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> ---
> 
> (Updated Aug. 26, 2016, 1:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the 
> GUI thread. Whislt it's not going to cause a threading issue (as 
> updatePaintNode always ran when the main thread was blocked) we're not meant 
> to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong 
> one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread 
> and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.h 
> 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> ---
> 
> Using nvidia with proprietory drivers (which puts me 
> QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. 
> Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather 
> than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Request, 2 lines] D2587: Set proper component name for plasma-discover

[bshah (Bhushan Shah)]

bshah created this revision.
bshah added reviewers: Plasma, apol, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Plasma discover installs desktop file as org.kde.discover, but it
  instead sets its component name as muondiscover, and breaks the RDN
  scheme.
  
  this fixes window icon for discover

REPOSITORY
  rDISCOVER Discover Software Store

BRANCH
  setpropercomponentname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2587

AFFECTED FILES
  discover/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, apol, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2584: Introduce a config option whether applications are allowed to block compositing

[Martin Gräßlin]

graesslin added a dependent revision: D2586: [kcmkwin/compositing] Hide config 
options which don't make sense if Compositing is required.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

[Martin Gräßlin]

graesslin added a dependency: D2584: Introduce a config option whether 
applications are allowed to block compositing.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2586

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 41 lines] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  On Wayland compositing is required. It doesn't make any sense to offer
  the user to disable the compositor or to allow windows to block
  compositing.
  
  The Compositor DBus interface gains a new property whether the platform
  requires compositing. This is queried by the compositing kcm and based
  on that the two mentioned options get hidden and not stored to config
  file.

TEST PLAN
  Opened the KCM on Wayland

REPOSITORY
  rKWIN KWin

BRANCH
  settings-required-compositing

REVISION DETAIL
  https://phabricator.kde.org/D2586

AFFECTED FILES
  dbusinterface.cpp
  dbusinterface.h
  kcmkwin/kwincompositing/compositing.cpp
  kcmkwin/kwincompositing/compositing.h
  kcmkwin/kwincompositing/main.cpp
  org.kde.kwin.Compositing.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

[Painless Roaster]

> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote:
> > Ship It!
> 
> Eike Hein wrote:
> Do you need someone to commit this for you?

I do not have an account on github.


- Painless


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97884
---


On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> ---
> 
> (Updated Čec. 13, 2016, 1:13 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
>  - enable multiline edit
>  - fix size and position
>  - fix escape from edit if user pressed Esc
>  - fix suppress open file (or folder) if user clicked in editbox
>  - fix size and position in popup mode
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Painless Roaster
> 
>

Review Request 128771: powerdevil lcm docbook update to 5.7

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128771/
---

Review request for Documentation and Plasma.


Repository: powerdevil


Description
---

proofread + update
kde->plasma
new screenshots


Diffs
-

  doc/kcm/activity.png 2522903 
  doc/kcm/advanced.png e27bc45 
  doc/kcm/energy.png 2452fb1 
  doc/kcm/index.docbook a99dc9b 

Diff: https://git.reviewboard.kde.org/r/128771/diff/


Testing
---


File Attachments


energy.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/6ad11acb-02bd-452f-9a0a-ef629d6c2fcf__energy.png
activity.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/749979e2-482a-41f0-b30c-e8fdbaaa2869__activity.png
advanced.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/60aa2966-52ac-4a14-902d-ccf31946f2df__advanced.png


Thanks,

Burkhard Lück

Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128770/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
kde->plasma


Diffs
-

  doc/kcontrol/solid-device-automounter/index.docbook 3c687fc 

Diff: https://git.reviewboard.kde.org/r/128770/diff/


Testing
---


Thanks,

Burkhard Lück

Review Request 128769: Update solid-actions kcm docbook to 5.7

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128769/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
kde->plasma
update screenshots


Diffs
-

  doc/kcontrol/solid-actions/add-action.png 67b4ea9 
  doc/kcontrol/solid-actions/edit-action.png aa2731b 
  doc/kcontrol/solid-actions/index.docbook 54da3ee 
  doc/kcontrol/solid-actions/main.png 19c91c6 

Diff: https://git.reviewboard.kde.org/r/128769/diff/


Testing
---

passes checkXML5


File Attachments


main.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/43e59142-647c-48e0-b871-530fed84d69a__main.png
add-action.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/861db8be-73f5-4249-be3e-cd020a8bbc03__add-action.png
edit-action.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/26/4cf0cf6f-df2f-4353-acd0-a10b4f239ff4__edit-action.png


Thanks,

Burkhard Lück

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

[Peter Wu]

> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote:
> > kstyle/breezestyleplugin.cpp, line 44
> > 
> >
> > This must be not (!inited).
> > However this is not proper fix. Correct and test patch in this way
> > 
> > QPointer style = new Style;
> > 
> > Below unchanged, so when QPointer got delete it hold nullptr by itself 
> > and delete will be safe.

This does not work since the interface requires a QStyle pointer. If I use 
this, I guess the caller unwraps it into a raw pointer and the issue is still 
triggered.

Good point about `if (!inited)`, forgot to change this while renaming. I'll fix 
it for the next version. Do you know the root cause of the original issue that 
required the use of this? It is not documented by Qt.


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review98667
---


On Aug. 25, 2016, 11:56 p.m., Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Aug. 25, 2016, 11:56 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Do not delete all style instances which we create, restrict ourselves to
> the first instance. I have no idea if the delete hack is still needed,
> but let's keep it until it is certain that it is unneeded.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Used "Testcase (with ASAN)" from bug 
> https://bugs.kde.org/show_bug.cgi?id=356940. Run directly, no more crashes. 
> Double-checked with a breakpoint on Breeze::StylePlugin::create that the 
> second instance is called through QProxyStyle.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/
---

Review request for Plasma and David Faure.


Bugs: 366569
https://bugs.kde.org/show_bug.cgi?id=366569


Repository: kwidgetsaddons


Description
---

Hi David,

K3B use KMessageBox::detailedSorry to show message for not support protocol 
such as add files from samba, but KMessageBox::detailedSorry hide some part of 
detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to 
show it directly by default!

Regards,
Leslie Zhai


Diffs
-

  src/kmessagebox.cpp 194ffae 
  tests/kmessageboxtest.cpp 8ea2848 

Diff: https://git.reviewboard.kde.org/r/128768/diff/


Testing
---

add case 26 in the patch, for long (> 512) details:

kwidgetsaddons/build/tests/kmessageboxtest 26


Thanks,

Leslie Zhai

[Differential] [Closed] D2583: DiscardWindowPixmap when Surface size changes

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINbe79d1aeda4e: DiscardWindowPixmap when Surface size 
changes (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2583?vs=6283=6288

REVISION DETAIL
  https://phabricator.kde.org/D2583

AFFECTED FILES
  shell_client.cpp
  toplevel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 10 lines] D2585: [Applet Configuration] Only scroll down if item is barely visible

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The logic for scrolling a focus item into view was mostly meant for 
keyboard-navigating through a list of CheckBoxes.
  However, an inner ScrollView - like plasma-pa has in its config dialog - can 
also gain activeFocus. This had us try to scroll the ScrollView into view, 
usually scrolling away other view contents.
  With the added logic we only try to scroll if the control is barely visible 
at the bottom but not if significant portions of it are already visible.

TEST PLAN
  I can still tab through task manager settings and have the view scroll 
properly.
  Switching tabs in plasma-pa applet config dialog no longer scrolls the tabs 
out of view.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2585

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2583: DiscardWindowPixmap when Surface size changes

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  discard-window-pixmap-surface-size-changed

REVISION DETAIL
  https://phabricator.kde.org/D2583

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> compositing.ui:294
> + 
> +  Allow windows to block compositing
> + 

Even though windows is more correct term here technically, IMO it makes more 
sense to have it as "Allow applications to block compositing". what do you 
think?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

[Martin Gräßlin]

graesslin added a comment.


  F269479: Spectacle.Z21567.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 95 lines] D2584: Introduce a config option whether applications are allowed to block compositing

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, VDG.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  From feedback we got it seems that not all users agree to games and
  other applications blocking compositing. Some users prefer to have
  compositing always on even if this gives a small performance penelity.
  
  This change introduces a dedicated config option to specify whether games
  are allowed to block compositing. By default this option is enabled.
  
  The setting can be overwritten with a window specific rule. So usecases
  like all windows except this very specific one are supported.
  
  In the user interface the config option is shown where previously the
  unredirect fullscreen option was shown.

TEST PLAN
  Run a game which should block compositing, verified it blocks.
  Changed the setting, run the game again, verified it doesn't block. And
  once more for with allowing to block.

REPOSITORY
  rKWIN KWin

BRANCH
  blocking-compositing

REVISION DETAIL
  https://phabricator.kde.org/D2584

AFFECTED FILES
  client.cpp
  kcmkwin/kwincompositing/compositing.cpp
  kcmkwin/kwincompositing/compositing.h
  kcmkwin/kwincompositing/compositing.ui
  kcmkwin/kwincompositing/main.cpp
  kwin.kcfg
  options.cpp
  options.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, #vdg
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Breeze] [Bug 367818] Password textfield is not visible when using dm-crypt

[Harald Sitter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367818

Harald Sitter  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Harald Sitter  ---
Depending on which git version you are talking about the background isn't blue.
The password field code also hasn't changed since 5.7.1 and continues to pass
the ask-for-password test we have [1].

Sounds more like your initramfs doesn't include the png assets of the theme.
Check that. If you believe that to be in order, get a debug log of plymouth.

[1] https://github.com/KDE/breeze-plymouth/blob/master/test/plytest.sh#L59

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128767: Fix crash when no QApplication is available.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128767/#review98676
---


Ship it!




Ship It!

- Marco Martin


On Aug. 26, 2016, 7:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128767/
> ---
> 
> (Updated Aug. 26, 2016, 7:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This happens when QtCreator launches qmlplugindump.
> Testcase: qmlplugindump -nonrelocatable org.kde.analitza 1.1
> or qmlplugindump -nonrelocatable org.kde.okular 2.0
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp 
> b7037da2ade97ce3632efa8f77e2a3f16e54107e 
> 
> Diff: https://git.reviewboard.kde.org/r/128767/diff/
> 
> 
> Testing
> ---
> 
> see description
> 
> Lots of warnings still, but at least it doesn't crash.
> 
> QObject: Cannot create children for a parent that is in a different thread.
> (Parent is QGuiApplication(0x7ffd16f340c0), parent's thread is 
> QThread(0x14af560), current thread is QThread(0x14e4240)
> Could not find any platform plugin
> 
> 
> Thanks,
> 
> David Faure
> 
>

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128765/#review98675
---


Ship it!




Ship It!

- Marco Martin


On Aug. 26, 2016, 2:14 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128765/
> ---
> 
> (Updated Aug. 26, 2016, 2:14 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix cannot assign undefined to double warning in DayDelegate
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 
> eeb05b5ba550b7fc6b006557467b776c5fddfbb1 
> 
> Diff: https://git.reviewboard.kde.org/r/128765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Closed] D2573: [SessionManagementScreen] Limit width of innerLayout

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE09903d637229: [SessionManagementScreen] Limit 
width of innerLayout (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2573?vs=6254=6284

REVISION DETAIL
  https://phabricator.kde.org/D2573

AFFECTED FILES
  lookandfeel/contents/components/SessionManagementScreen.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2572: [Lock Screen] Remove unused Label

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEe3b4df44e1a6: [Lock Screen] Remove unused 
Label (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2572?vs=6253=6285

REVISION DETAIL
  https://phabricator.kde.org/D2572

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128763/#review98673
---




src/declarativeimports/core/windowthumbnail.cpp (lines 680 - 684)


we probably need to do the same for EGL, don't we?


- Martin Gräßlin


On Aug. 26, 2016, 3:04 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128763/
> ---
> 
> (Updated Aug. 26, 2016, 3:04 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> WindowThumbnail did some open GL operations, discarding old textures, in the 
> GUI thread. Whislt it's not going to cause a threading issue (as 
> updatePaintNode always ran when the main thread was blocked) we're not meant 
> to mix threads with openGL contexts.
> 
> It also seems to have a GL leak on nvidia, which was previously masked
> by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/
> It seems only one worked, and in the applied version we went with the wrong 
> one.
> 
> This patch makes use of QQuickItem::releaseResources to delete the GL
> textures on window change and destructor; it's then removed from
> stopRedirecting so that start/stop redirecting handles xcb on the GUI thread 
> and updatePaintNode/discardPixmap is the GL stuff on the render thread. 
> 
> See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
> 
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.h 
> 7276f95de16e71006618f3282d8eaf419a199d1d 
>   src/declarativeimports/core/windowthumbnail.cpp 
> d106994315099ab6e6f948c31a606d5309ae03e2 
> 
> Diff: https://git.reviewboard.kde.org/r/128763/diff/
> 
> 
> Testing
> ---
> 
> Using nvidia with proprietory drivers (which puts me 
> QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. 
> Previews still appear. 
> "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather 
> than constantly increasing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128767: Fix crash when no QApplication is available.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128767/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

This happens when QtCreator launches qmlplugindump.
Testcase: qmlplugindump -nonrelocatable org.kde.analitza 1.1
or qmlplugindump -nonrelocatable org.kde.okular 2.0


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.cpp 
b7037da2ade97ce3632efa8f77e2a3f16e54107e 

Diff: https://git.reviewboard.kde.org/r/128767/diff/


Testing
---

see description

Lots of warnings still, but at least it doesn't crash.

QObject: Cannot create children for a parent that is in a different thread.
(Parent is QGuiApplication(0x7ffd16f340c0), parent's thread is 
QThread(0x14af560), current thread is QThread(0x14e4240)
Could not find any platform plugin


Thanks,

David Faure

[Differential] [Request, 3 lines] D2583: DiscardWindowPixmap when Surface size changes

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far this connect was only in ShellClient, but it's needed for all
  Toplevels. Also when a XWayland window has it's surface size changed,
  the pixmap needs to be discarded. Otherwise KWin might hit an assert
  in AbstractEGLTexture due to the buffer having a different size than
  the texture had previously.

TEST PLAN
  Firefox, click download on bugreports.qt.io used to trigger
  this for me. With this change no longer able to reproduce.

REPOSITORY
  rKWIN KWin

BRANCH
  discard-window-pixmap-surface-size-changed

REVISION DETAIL
  https://phabricator.kde.org/D2583

AFFECTED FILES
  shell_client.cpp
  toplevel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2582: [plugins/qpa] Call makeCurrent on the QOpenGLContext instead of the one in the platform context

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN8909f8780b00: [plugins/qpa] Call makeCurrent on the 
QOpenGLContext instead of the one in… (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2582?vs=6281=6282

REVISION DETAIL
  https://phabricator.kde.org/D2582

AFFECTED FILES
  plugins/qpa/abstractplatformcontext.h
  plugins/qpa/platformcontextwayland.cpp
  plugins/qpa/sharingplatformcontext.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas