D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd abandoned this revision.
smithjd added a comment.


  Closing this because it breaks at least the settings:// ioslave, and the 
tags:// slave no longer has urls attached to the filename.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a subscriber: sharvey.
ngraham added a comment.


  Actually both Kicker and System Settings give their search fields visible 
focus by default. Kicker does make the field visibly lose focus after you start 
using the keyboard to navigate through the list of returned items, though. 
That's a nice touch and I'll do that here.
  
  But maybe we should think through why we're objecting to having the search 
field be visibly focused in the first place--because in general, the thing that 
accepts keyboard input //should// look visibly focused. Rather than violate 
that principle, let's try to figure out what's making us want to in the first 
place.
  
  Perhaps the white background and blinking cursor appear too attention-getting 
in comparison to the rest of Kickoff, which tries very hard to be flat and gray 
and avoid separators (e.g. between the different sections and the tab bar at 
the bottom or the header on top). I wonder if we wouldn't feel like the search 
field was so jarring if there were better differentiation between other 
elements. For example:
  
  F6212312: It works.png 
  
  Or perhaps if the list views used a lighter background color:
  
  F6212335: It works.png 
  
  Just a thought, crude mockups, etc.
  
  Also probably the header area will look better defined if @sharvey's patch to 
put the avatars inside a circle (D13415 ) 
lands.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson ping!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  Are you going to land this?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  In D15011#314167 , @romangg wrote:
  
  > In D15011#314138 , @ngraham 
wrote:
  >
  > > So basically, you want it to be unfocused by default, and typing (or 
clicking in it, obviously) makes it focused.
  >
  >
  > True that. With the exception that beginning to type should activate it. A 
similar field can be found in the SySe. But it has white background always and 
does not activate automatically when beginning to type (it's activated at the 
beginning though)
  
  
  I think Kicker provides what we're looking for: its search field only shows 
the focus highlight when you're typing or hovering the mouse over it. It's 
subtle, but effective. I'll see if I can do that here too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314252 , @smithjd wrote:
  
  > This used to work for the Baloo tags:// ioslave,
  
  
  Oh, as you mention it, in future do **not** push to baloo without going 
through review - you have done this several times now, and while the changes 
may be ok, your commit messages are definitely subpar.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

[anonym]

anonym added a comment.


  In D14949#312757 , @ngraham wrote:
  
  > Simply making it smaller wouldn't really help the submitter's use case very 
much anyway since it would still show up and cover up //something//.
  
  
  Yes; I would be completely happy if the current (size and all) OSD would 
appear in the periphery of the screen, preferably a corner. So perhaps the 
missing option is actually a drop-down for the position of the OSD? An 
ambitious plan would be:
  
  - Center: the current OSD. (Default)
  - Notification Area: shows a thin vertical bar in the Notification Area (so 
the lower right corner for the default panel).
  - Top: shows a //very// thin horizontal bar centered at the top edge.
  - Bottom: like the above.
  
  > However I'd be open to making the default appearance configurable, as a 
small but vocal cohort of people don't seem to like it.
  
  Yay! I was trying to not just be another voice by providing an actual patch, 
but...
  
  > That's material for another patch though.
  
  ...I won't commit to dig deeper into the OSD subsystem, which this would 
require.

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  In D13291#314199 , @bruns wrote:
  
  > In D13291#314195 , @smithjd 
wrote:
  >
  > > kioclient5 ls settings:/
  > > system-administration
  > >
  > > dolphin settings:/
  > >  System Administration
  >
  >
  > In dolphin, you can click on "System Administration". With kioclient5, I 
can use `kioclient5 ls settings:/system-administration` (dito for dolphin). 
Does this still work after your change?
  
  
  No.
  
  "The file or folder System Administration does not exist."
  
  This used to work for the Baloo tags:// ioslave, though it's less useful for 
that now that the slave no longer appends the full url to the filename. The 
working command was something like kioclient5 cp tags:/foo/. ~/bar. This 
successfully duplicated the tagged files and tag folder structure. I can't 
remember if I tested a single file, though if you needed a single file you 
probably wouldn't be digging in the tags:// ioslave anyway...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15026: Fetch high-resolution image from Bing

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Sorry, I do not have time for Plasma things these months. No maintainer here.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15026

To: carmenbianca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15026: Fetch high-resolution image from Bing

[Carmen Bianca Bakker]

carmenbianca created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
carmenbianca requested review of this revision.

REVISION SUMMARY
  When visiting https://www.bing.com/HPImageArchive.aspx?format=js=0=1, 
the URL field of the image is not always 1920x1080. For some reason, Bing 
serves me different resolutions dependent on my IP address. One easy way to 
verify this is by loading that site in Tor Browser and refreshing your Tor 
Circuit a couple of times.
  
  This patch should always download the 1920x1080 image, on the assumption that 
this resolution is always available and always a JPG. I have not found anything 
contradicting these assumptions, though.
  
  I'm not very experienced with C++ or KDE development, so I may have messed up 
this patch. It seems like a simple enough fix, however.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15026

AFFECTED FILES
  dataengines/potd/bingprovider.cpp

To: carmenbianca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  F6211779: Screenshot_20180823_212008.png 

  
  F6211778: Screenshot_20180823_212035.png 

  
  As you can see, as soon as you start to edit the URL, the UDS_NAME is used.
  
  Probably something like
  `kioclient5 ls settings:/network`
  
connectivity   [Verbindungen]
bluetooth  [Bluetooth]
networksettings[Einstellungen]
kcm_networkmanagement  [Verbindungen]
.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314195 , @smithjd wrote:
  
  > kioclient5 ls settings:/
  > system-administration
  >
  > dolphin settings:/
  >  System Administration
  
  
  In dolphin, you can click on "System Administration". With kioclient5, I can 
use `kioclient5 ls settings:/system-administration` (dito for dolphin). Does 
this still work after your change?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Nathaniel Graham]

ngraham added a comment.


  before-and-after screenshots from Dolphin would also help, as would a 
Bugzilla ticket or steps to reproduce, or anything else. Otherwise it's a bit 
hard to evaluate why this change is desirable.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314195 , @smithjd wrote:
  
  > kioclient5 ls settings:/
  > system-administration
  >
  > dolphin settings:/
  >  System Administration
  
  
  That belongs into the test plan, of course with the needed context.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  kioclient5 ls settings:/
  system-administration
  
  dolphin settings:/
  System Administration

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Andres Betts]

abetts added a comment.


  In D15011#314181 , @davidedmundson 
wrote:
  
  > > @davidedmundson, does this look okay now?
  >
  > Code wise, yes.
  >
  > UI/Concept wide, I don't want to have an opinion either way
  
  
  Thanks Dave

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[David Edmundson]

davidedmundson added a comment.


  > @davidedmundson, does this look okay now?
  
  Code wise, yes.
  
  UI/Concept wide, I don't want to have an opinion either way

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Roman Gilg]

romangg added a comment.


  In D15011#314138 , @ngraham wrote:
  
  > So basically, you want it to be unfocused by default, and typing (or 
clicking in it, obviously) makes it focused.
  
  
  True that. With the exception that beginning to type should activate it. A 
similar field can be found in the SySe. But it has white background always and 
does not activate automatically when beginning to type (it's activated at the 
beginning though)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Andres Betts]

abetts added a comment.


  In D15011#314154 , @filipf wrote:
  
  > Yeah Nate, but if you look at your responses they're predominantly on a 
much higher level of abstraction (e.g "next step", "change is scary") than the 
issues raised. That's why for me they don't address them completely.
  >
  > The fact here is that you have a unibody Kickoff and yeah there is 
certainly a legitimate need to add a box in there. The goal would be to avoid 
having it stick out too much. The problem right now is that the background is 
too white and that the outer glow is too strong. Moreover, outer glow is sort 
of a remnant of Oxygen isn't it?
  >
  > I still think it's best to have an option, but couldn't we at least make it 
more subtle?
  >
  > Example (the corners needs to be rounded):
  >  F6211394: It_works_2.png 
  
  
  Well, this is exactly the sort of thing that we can help with as designers. I 
have trouble explaining technical concepts while others may struggle with 
graphics. I would consider your proposal from a visual POV. What do you think 
@ngraham ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Filip Fila]

filipf added a comment.


  Yeah Nate, but if you look at your responses they're predominantly on a much 
higher level of abstraction (e.g "next step", "change is scary") than the 
issues raised. That's why for me they don't address them completely.
  
  The fact here is that you have a unibody Kickoff and yeah there is certainly 
a legitimate need to add a box in there. The goal would be to avoid having it 
stick out too much. The problem right now is that the background is too white 
and that the outer glow is too strong. Moreover, outer glow is sort of a 
remnant of Oxygen isn't it?
  
  I still think it's best to have an option, but couldn't we at least make it 
more subtle?
  
  Example (the corners needs to be rounded):
  F6211394: It_works_2.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: romangg, broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham updated this revision to Diff 40306.
ngraham added a comment.


  Remove FIXME now that it's being worked around with D15021 


REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15011?vs=40300=40306

BRANCH
  kickoff-search-field-looks-like-a-search-field (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15011

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the kind words. I don't think the objections have been ignored, 
though:
  
  Objection:
  
  > but my question is: is it possible to somehow make a toggle to keep the 
status quo ie. have no search box? [...] I urge you again to please consider 
leaving an option to have it the same as it is.
  
  
  
  > I'm -1 for this, it's not needed to click in just start typing witch is 
more intuitive. Adding this optional by config?
  
  Response:
  
  > Sorry, it almost never makes sense to have user-facing options for this 
kind of very specific thing. I know that change can be a bit scary at times, 
but design evolves, and we have a theming system for people who don't like the 
defaults.
  
  Objection:
  
  > Also please note that the clear button functionality is working wrong with 
RTL layouts.
  
  [Irrelevant to this patch; it's an issue with the TextField itself that 
should be fixed there.]
  
  Objection:
  
  > Heh, flip-flopped back to 
https://userbase.kde.org/images.userbase/thumb/f/fe/Kickoff_Menu_Style.png/300px-Kickoff_Menu_Style.png
 till we get the next bug report about how it should be hidden.
  
  
  
  > The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not 
clear if one can search or not, because of text changing. Why not just keeping 
the current “Type to search” label as is, and move the user@host text up as in 
the patch?
  
  
  
  > There is nothing cold, stark or undifferentiated about Kickoff and its 
search bar now. [...] And slapping on a white opaque box with bright blue outer 
glow just like it was in KDE 4 doesn't seem like preserving minimalism either.
  
  Response:
  
  > [...] I see this as the natural next step in refining what "minimalism" 
means to KDE, which is a microcosm of a larger trend throughout the design 
world vis-a-vis minimalism:
  
  More generally, one of the reasons why we have a HIG  is 
so that we can all agree to abide by a series of common rules rather than 
having to re-argue the same subjective aesthetic matters over and over again. 
And on this subject, the HIG says 
:
  
  > Application specific theme
  > 
  >   Only set a custom color scheme, never set a custom widget theme.
  
  Kickoff isn't an application, but the message is clear: abide by the 
appearance specified by the global widget theme, and don't apply custom styles 
to common controls. But that's exactly what Kickoff is doing, in violation of 
this recommendation.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15024: Update icons kcm docbook to 5.13

[Andres Betts]

abetts added a comment.


  I am hoping there is also a way for people to be able to see more information 
about the theme in GHNS. Is there a visual way that we can do this? Maybe do 
the layout the same as it was before BUT where the preview image used to be, 
have the new gallery item look?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15024

To: lueck, #plasma, #documentation, yurchor
Cc: abetts, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eac5d2e40e1e: [MPRIS Data Engine] Avoid blocking calls in 
media shortcuts handling (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14970?vs=40129=40305

REVISION DETAIL
  https://phabricator.kde.org/D14970

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playercontrol.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15024: Update icons kcm docbook to 5.13

[Burkhard Lück]

lueck added reviewers: Plasma, Documentation.
lueck added a comment.


  F6211258: get-new-theme.png 
  
  F6211257: main.png 
  
  F6211256: use-of-icons.png 
  
  F6211255: edit-delete.png 
  
  F6211254: edit-undo.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15024

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15024: Update icons kcm docbook to 5.13

[Burkhard Lück]

lueck created this revision.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  apply chanches from [Icon KCM] Port to new design 
https://phabricator.kde.org/D12459

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15024

AFFECTED FILES
  doc/kcontrol/icons/delete-theme.png
  doc/kcontrol/icons/edit-delete.png
  doc/kcontrol/icons/edit-undo.png
  doc/kcontrol/icons/effects.png
  doc/kcontrol/icons/index.docbook
  doc/kcontrol/icons/install-theme.png
  doc/kcontrol/icons/main.png
  doc/kcontrol/icons/size.png
  doc/kcontrol/icons/use-of-icons.png

To: lueck
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Filip Fila]

filipf added a comment.


  I've joined partly because feeling some blunders on my skin; I'd like to 
contribute so that something like the 5.13 media icons thing doesn't happen 
again (ie. find potential problems for non-Breeze users), but also due to 
feeling like that some changes get proposed without thorough analysis and 
without taking into account some arguments, and if they get opposition they 
just get reposted a few months later.  I've also noticed that this has 
alienated some people and I feel a bit concerned. The posts I've commented here 
on are the simply the posts that I felt competent enough to comment on and 
where I saw potential issues; I have no coding knowledge and can't comment on 
anything beyond the simpler things. If you remember me from Reddit 
 you will find I've had nothing but 
praise for you. It isn't personal, please take my arguments into account 
instead of looking at it that way. I'm not a part of KDE nor can I accept any 
patches so of course I can only be useful if I point out the issues :)
  
  As for this task, I can't say I'm not disappointed with ignoring the 
arguments presented, but I will leave it to other people to discuss.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Andres Betts]

abetts accepted this revision.
abetts added a comment.


  I like this idea, it is easier to discover.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  Can you please give an example?
  
  1. Exact command
  2. Current output
  3. Expected output

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a comment.


  In D15011#314078 , @filipf wrote:
  
  > There doesn't have to be one solution and this is hardly an issue where 
such a hardline approach is warranted. There is nothing cold, stark or 
undifferentiated about Kickoff and its search bar now. It's just that it's a 
problem for people who aren't as intuitive with finding their way in a UI. And 
slapping on a white opaque box with bright blue outer glow just like it was in 
KDE 4 doesn't seem like preserving minimalism either. It isn't even just about 
design because there is no need to have that kind of a prominent box sticking 
out there the whole time if it's not being used the whole time. I can even 
support you in making the searchbox show up at all times as a default, but I 
urge you again to please consider leaving an option to have it the same as it 
is.
  
  
  Sorry, it almost never makes sense to have user-facing options for this kind 
of very specific thing. I know that change can be a bit scary at times, but 
design evolves, and we have a theming system for people who don't like the 
defaults.
  
  Things should look like what they are, and it's generally not considered good 
design to have the same UI element look different in different contexts. Text 
fields should look like text fields, otherwise discoverability suffers and the 
user interface becomes unpleasantly inconsistent.
  
  Also, Filip, I notice that you only just signed up for a Phabricator account 
8 days ago and //literally 100%// of your activities have consisted of 
objecting to patches I've submitted. We value user input, but it's not very 
considerate to show up in a developer environment simply to gum up the works. 
There are always a thousand reasons not to do something. But in all systems, 
stasis is death. The users' need for stability (which is indeed very important) 
must be balanced against the system's need for flexibility and 
adaptability--without which, the system eventually dies or loses its appeal to 
users, both current and future. I ask that you give me and other developers the 
benefit of the doubt when we are working on evolving the design. We might not 
be as dumb as we look! :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Filip Fila]

filipf added a comment.


  There doesn't have to be one solution and this is hardly an issue where such 
a hardline approach is warranted. There is nothing cold, stark or 
undifferentiated about Kickoff and its search bar now. It's just that it's a 
problem for people who aren't as intuitive with finding their way in a UI. And 
slapping on a white opaque box with bright blue outer glow just like it was in 
KDE 4 doesn't seem like preserving minimalism either. It isn't even just about 
design because there is no need to have that kind of a prominent box sticking 
out there the whole time if it's not being used the whole time. I can even 
support you in making the searchbox show up at all times as a default, but I 
urge you again to please consider leaving an option to have it the same as it 
is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14672: [plasma-changeicons] Call sync() after writing

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:716deea83dae: [plasma-changeicons] Call sync() after 
writing (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14672?vs=39254=40301

REVISION DETAIL
  https://phabricator.kde.org/D14672

AFFECTED FILES
  kcms/icons/changeicons.cpp

To: broulik, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a comment.


  To address the design and aesthetic angle, I see this as the natural next 
step in refining what "minimalism" means to KDE, which is a microcosm of a 
larger trend throughout the design world vis-a-vis minimalism:
  
  1. People go crazy with decorations, frames, lines, colors, highlights, etc
  2. There's a natural backlash against this excessive ornamentation
  3. All of those things are removed in the name of minimalism
  4. This goes too far and destroys the boundaries between dissimilar elements, 
creating an uncomfortably cold, stark, undifferentiated appearance
  5. A process of refinement takes place where differentiating elements are 
re-added where appropriate, while preserving the overall minimalistic aesthetic
  
  This patch is in step 5. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Kai Uwe Broulik]

broulik added a comment.


  The fact that the search field in Kickoff isn't permanently visible is a 
criticism I heard at various exhibitions where I showcased Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, 
davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Header.qml:66
> What's this about? Negative offsets are weird, and we also have a 300ms 
> animation to move 1px?

I was copying this from the original, but yeah, it did seem weird to me too. 
Removed.

> davidedmundson wrote in Header.qml:153
> We can't do this. You're assuming lots of things about the user's font that 
> you can't do.

Oops, this was left over from an earlier idea that I abandoned. Removed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham updated this revision to Diff 40300.
ngraham marked 5 inline comments as done.
ngraham added a comment.


  - Address review comments
  - Stop working around TextField bugs
  - Remove the timer; it was overkill and didn't work perfectly

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15011?vs=40264=40300

BRANCH
  kickoff-search-field-looks-like-a-search-field (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15011

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ngraham, #plasma, #vdg, davidedmundson
Cc: safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Safa Alfulaij]

safaalfulaij added a comment.


  The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not 
clear if one can search or not, because of text changing. Why not just keeping 
the current “Type to search” label as is, and move the user@host text up as in 
the patch?
  
  Also please note that the clear button functionality is working wrong with 
RTL layouts. The button must depend on the text's direction itself not the UI 
language being used. You can type Arabic in English UI, and the clear button 
should be to the left of the text (and mirrored). Check normal Qt lineedit 
widget behaviour (in Qt Designer for example)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, 
michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15018: [Folder Model] Use document-properties icon for "Properties" context menu entry

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6bfd40c06eb6: [Folder Model] Use document-properties icon 
for Properties context menu entry (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15018?vs=40285=40288

REVISION DETAIL
  https://phabricator.kde.org/D15018

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15018: [Folder Model] Use document-properties icon for "Properties" context menu entry

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes it consistent with other places where such an entry exists, such as 
Dolphin's context menu

TEST PLAN
  Now have the correct icon for the entry. Invoking it still works fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15018

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Øystein S . -Alværvik]

oysteins added a comment.


  In D15011#313872 , @filipf wrote:
  
  > although if I think of my parents for example I do see how they might miss 
it
  
  
  This was the rationale behind my bug report about this; that some users might 
be puzzled about the apparent lack of a search field.
  
  In D15011#313872 , @filipf wrote:
  
  > is it possible to somehow make a toggle to keep the status quo ie. have no 
search box?
  
  
  +1 for this, if it is doable. Perhaps the search field could be toggled only 
for new installs, so upgraders can stick to the status quo?
  
  In D15011#313874 , @anthonyfieroni 
wrote:
  
  > I'm -1 for this, it's not needed to click in just start typing witch is 
more intuitive. Adding this optional by config?
  
  
  The patch seems to retain this functionality. Maybe the patch could keep the 
text 'Type to search…', or does it become redundant?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: oysteins, anthonyfieroni, filipf, abetts, davidedmundson, michaeltunnell, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Anthony Fieroni]

anthonyfieroni added a comment.


  I'm -1 for this, it's not needed to click in just start typing witch is more 
intuitive.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: anthonyfieroni, filipf, abetts, davidedmundson, michaeltunnell, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[Filip Fila]

filipf added a comment.


  Heh, in my opinion the blended in searching is what added elegance to Kickoff 
compared to its KDE 4 version. The search box just sticks out quite a bit and 
for me "type to search" is indicative enough, although if I think of my parents 
for example I do see how they might miss it... but my question is: is it 
possible to somehow make a toggle to keep the status quo ie. have no search box?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart