D24161: Make KCM look more like applet

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> sefaeyeoglu wrote in MuteButton.qml:32
> I feel like QQC2 tooltips look out of place. They don't have the same shadow 
> as //normal// tooltips and do not fade in

That is something that needs to be fixed in the QQC2 desktop style, so it is 
unrelated to this.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

[David Faure]

dfaure created this revision.
dfaure added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It gives the following runtime warning:
  
Warning: QT_AUTO_SCREEN_SCALE_FACTOR is deprecated. Instead use:
   QT_ENABLE_HIGHDPI_SCALING to enable platform plugin controlled 
per-screen factors
  
  But we don't need to set QT_ENABLE_HIGHDPI_SCALING to 0.
  Just setting QT_SCREEN_SCALE_FACTORS is enough to control scaling, after
  my commit e018d11600bffc6 to qtbase.
  
  Kudos for porting startkde to be C++ code, it makes this commit much
  easier...

TEST PLAN
  Builds; not rebooted yet

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24255

AFFECTED FILES
  startkde/startplasma.cpp

To: dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23305: Add plugin showing nvidia GPU load stats

[David Edmundson]

davidedmundson closed this revision.
davidedmundson added a comment.


  Merged

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D23305

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu added a comment.


  In D13243#538519 , @davidedmundson 
wrote:
  
  > What's the use case?
  
  
  I have a "module-null-sink" loaded at all times. I use it to record from via 
OBS, so I can selectively record Desktop Audio. (This is coupled with a 
"module-loopback" so I can hear the Null Sink with my headset, too). Of course 
I need to manually set application streams to point to my null sink. I always 
do this with pavucontrol. It would be more convenient though, if I could just 
use the PA applet as it has the nice drag and drop feature there. As this 
behaviour is disabled by default it should not impact those who don't need this.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[David Edmundson]

davidedmundson added a comment.


  What's the use case?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu added a comment.


  In D24161#538429 , @ngraham wrote:
  
  > I love it, and the code changes look sane to me.
  >
  > #plasma  folks or @drosca, any 
objections?
  
  
  Glad you like it  Looks like this will be my premiere on "This week in KDE" 

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66926.
sefaeyeoglu added a comment.


  Add copyright header

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13243?vs=66925=66926

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24194: Add per-origin media controls blacklist

[Kai Uwe Broulik]

broulik updated this revision to Diff 66924.
broulik edited the test plan for this revision.
broulik added a comment.


  - Show media controls only if there is a player or something blacklisted on 
that page, otherwise it gets annoying

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24194?vs=66907=66924

REVISION DETAIL
  https://phabricator.kde.org/D24194

AFFECTED FILES
  extension/action_popup.css
  extension/action_popup.html
  extension/action_popup.js
  extension/constants.js
  extension/content-script.js
  extension/extension-mpris.js
  extension/extension.js

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66925.
sefaeyeoglu added a comment.


  Rebase onto master

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13243?vs=35273=66925

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [applets/kickoff] Improve appearance of draggable button grid in settings window

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:184f2a8274dc: [applets/kickoff] Improve appearance of 
draggable button grid in settings window (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=66922=66923

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24251: [applets/kickoff] Somewhat fix the ConfigButtons component sizing

[Nathaniel Graham]

ngraham added a comment.


  Thanks, I've squashed the changes here into D23158 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24251

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[Nathaniel Graham]

ngraham updated this revision to Diff 66922.
ngraham added a comment.


  Squash changes from D24251 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=66916=66922

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu added a comment.


  In D13243#538434 , @ngraham wrote:
  
  > Yikes, looks like this never went anywhere. :/
  >
  > Can you rebase it?
  
  
  I actually don't remember ever making this but of course I can :D

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24251: [applets/kickoff] Somewhat fix the ConfigButtons component sizing

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  ConfigButtons previously rendered one of the child item, the top title,
  above itself. This means the layout containing it had to do bodgy layout
  fixes to compensate above and take negative margins off the bottom.
  
  Code still isn't great, but that one issue is resolved.

TEST PLAN
  Added a red rectangle with anchors.fill: configButton
  That rectangle is now sane

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24251

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: drosca.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it, and the code changes look sane to me.
  
  #plasma  folks or @drosca, any 
objections?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Nathaniel Graham]

ngraham added reviewers: Plasma, drosca, VDG.
ngraham added a comment.


  Yikes, looks like this never went anywhere. :/
  
  Can you rebase it?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66920.
sefaeyeoglu edited the test plan for this revision.
sefaeyeoglu added a comment.


  Make icon full height for playback devices, too

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66917=66920

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  In D23274#538369 , @ngraham wrote:
  
  > I could get behind always having an "app-global" hamburger menu on the left 
when the menubar isn't shown, but this would require implementing the same 
pattern for every app, by putting a little mini-toolbar above the app's sidebar 
that's separate from the toolbar above the view, which would then contain only 
view-specific actions. This is becoming pretty common and Kirigami apps can do 
this easily but our QWidgets apps can't do it as easily. Maybe it's time to 
look into that.
  
  
  To me we should look more into the differences of global vs page specific 
toolbars
  I feel that the 2 different types of toolbars in this screenshot 
(whatsapp,telegram and kirigami gallery vs libreoffice and dolphin)
  both make sense to exist and coexist (even in the same app at once if 
necessary) and they call for different rules and behavior
  F7440946: Screenshot_20190926_210937.png 

  and for the global menu case, an hamburgher menu at the top right makes sense 
(tough to me could well be the ... icon as is kinda "actions that didn't fit 
the global toolbar")
  
  I would be ok if it was wound a way that visually and conceptually works to 
move the hamburger of column view apps elsewhere, can't think of any
  
  > Either way I guess I can get on board with having the hamburger menu on the 
left here. We'll also need to do the same thing for Discover then.
  
  Discover doesn't have any global menu i think? (iirc only an home button?) in 
the case of discover the "global thing" that kinda replaces the menubar becomes 
the sidebar when small or mobile

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu marked 2 inline comments as done.
sefaeyeoglu added a comment.


  Right! I completely forgot about that. Will work on it

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham added a comment.


  Nice.
  
  Now that I compare the two, one remaining difference is that each item's icon 
differs in location in the applet vs the KCM. In the Applet, it's larger and to 
the left of everything else; whereas in the KCM the icon is small and in the 
same row as the title.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D23675: [Folder View] Don't query file information if tooltips are disabled

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes logical sense and nothing's broke.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23675

To: broulik, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu marked 2 inline comments as done.
sefaeyeoglu added inline comments.

INLINE COMMENTS

> ngraham wrote in VolumeSlider.qml:44
> Hmm, I don't like how this makes tickmarks appear. If you need to round the 
> value, you can do that in `onMoved: { blabla; }`, or just round the value of 
> the label itself.

I have removed this now as I can't replicate the same behavior as the applet. 
Added a TODO for the future

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66917.
sefaeyeoglu added a comment.


  Remove stepping again, change label text of port selection

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66909=66917

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[Nathaniel Graham]

ngraham updated this revision to Diff 66916.
ngraham added a comment.


  Rebase again

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=66915=66916

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[Nathaniel Graham]

ngraham updated this revision to Diff 66915.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=63756=66915

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
  containments/panel/contents/ui/main.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  Implemented the requested change for Systemsettings 
(https://commits.kde.org/systemsettings/ea0f40c9c03b679ff23688d1eabda61c972f6bc1)
 and Discover 
(https://commits.kde.org/discover/b8dfc2d02cc2ac8e7416923e00454a7dc8020f7b).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  I could get behind always having an "app-global" hamburger menu on the left 
when the menubar isn't shown, but this would require implementing the same 
pattern for every app, by putting a little mini-toolbar above the app's sidebar 
that's separate from the toolbar above the view, which would then contain only 
view-specific actions. This is becoming pretty common and Kirigami apps can do 
this easily but our QWidgets apps can't do it as easily. Maybe it's time to 
look into that.
  
  Either way I guess I can get on board with having the hamburger menu on the 
left here. We'll also need to do the same thing for Discover then.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma updated this revision to Diff 66913.
maximma added a comment.


  Bug Fix 410988

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24146?vs=66694=66913

BRANCH
  calculatorApplet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24146

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> DeviceListItem.qml:54
> +visible: portbox.count > 1
> +text: i18nd("kcm_pulseaudio", "Port")
> +}

While we're at it, let's also make this say "Port:"

> VolumeSlider.qml:44
>  to: PulseAudio.MaximalVolume
> +stepSize: to / (PulseAudio.MaximalVolume / PulseAudio.NormalVolume * 
> 100.0)
>  visible: HasVolume

Hmm, I don't like how this makes tickmarks appear. If you need to round the 
value, you can do that in `onMoved: { blabla; }`, or just round the value of 
the label itself.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  In D23274#538334 , @ngraham wrote:
  
  > In D23274#538315 , @mart wrote:
  >
  > > In D23274#537633 , @ngraham 
wrote:
  > >
  > > > Yeah I would say so.
  > >
  > >
  > > i strongly disagree, it's the opposite of every other kirigami app, and i 
really want to change it back.
  >
  >
  > But then Kirigami is the opposite of other apps that have their hamburger 
menus on the right (Dolphin, Firefox, GNOME apps). We need to sort this out.
  
  
  I don't think it's an absolute rule for every app, but systemsettings uses 
the column layout with drill down and toolbars contextual only to the column 
they are on top of.
  For pages toolbars of applications that use column based navigation, action 
buttons are on the right, title or a widget that replaces the title (like a 
search field) is on the left (which, is pretty much the android layout, or chat 
apps like whatsapp and telegram on any platform)
  I would be hurted already a bit less from that systemsettings layout if that 
menu button was a ... icon instead, which is then commonly used by such apps.
  For those column based layouts with column-specific toolbars i kinda see an 
"app-global" menu icon only on the left, i don't think it would ever work on 
the right at all.
  Also because the pattern is from left column: more generic stuff, and as goes 
right, more drilled down, narrow-topic content
  
  Dolphin toolbar i see it more like a different beast, a "global" toolbar that 
doesn't have anything to do with those context specific ones and has different 
rules.
  There, is true that probably the menu button in front of the back button 
would be kinda strange, especially because the most used button is probably 
indeed, the back button and the menu button just once in a blue moon. (tough 
for dolphin as well, i think i would prefer a lot the ... as chromium does)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma added a comment.


  ok

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Nathaniel Graham]

ngraham added a comment.


  Change the files to remove those changes using your text editor, then run 
`arc diff`.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24246: Only show panel toolbox when desktop toolbox is open

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d9533e674adc: Only show panel toolbox when desktop 
toolbox is open (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24246?vs=66906=66911

REVISION DETAIL
  https://phabricator.kde.org/D24246

AFFECTED FILES
  containments/panel/contents/ui/main.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma added a comment.


  ok, how remove changes from those path?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  In D23274#538315 , @mart wrote:
  
  > In D23274#537633 , @ngraham 
wrote:
  >
  > > Yeah I would say so.
  >
  >
  > i strongly disagree, it's the opposite of every other kirigami app, and i 
really want to change it back.
  
  
  But then Kirigami is the opposite of other apps that have their hamburger 
menus on the right (Dolphin, Firefox, GNOME apps). We need to sort this out.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Nathaniel Graham]

ngraham added a comment.


  If there are three changes necessary (fix display, fix bug, change C 
behavior) then we need three patches in a dependency chain. :) See 
https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66909.
sefaeyeoglu edited the test plan for this revision.
sefaeyeoglu added a comment.


  Remove redundant whitespace from copyright header

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66908=66909

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D23274: Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart reopened this revision.
mart added a comment.
This revision is now accepted and ready to land.


  In D23274#537633 , @ngraham wrote:
  
  > Yeah I would say so.
  
  
  i strongly disagree, it's the opposite of every other kirigami app, and i 
really want to change it back.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: Add "Show intro page" button to System Settings sidebar

[Marco Martin]

mart added a comment.


  In D23274#537632 , @GB_2 wrote:
  
  > Shouldn't the "Show intro page" button be on the left, like in Discover, 
and the hamburger menu button on the right, like in for example Dolphin? 
(#consistency )
  
  
  i really don't like that btw

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66908.
sefaeyeoglu added a comment.


  Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume 
slider, similar to applet.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66783=66908

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 26 Sep 2019 17:48:45 +
 Build duration:
36 sec and counting
   CONSOLE OUTPUT
  [...truncated 427 lines...][2019-09-26T17:49:12.764Z] [ 34%] Building CXX object processcore/CMakeFiles/processcore.dir/process_controller.cpp.o[2019-09-26T17:49:12.764Z] [ 37%] Building CXX object processcore/CMakeFiles/processcore.dir/unit.cpp.o[2019-09-26T17:49:12.764Z] [ 37%] Building CXX object processcore/CMakeFiles/processcore.dir/process_data_provider.cpp.o[2019-09-26T17:49:12.764Z] [ 38%] Building CXX object processcore/CMakeFiles/processcore.dir/processcore_debug.cpp.o[2019-09-26T17:49:13.021Z] 7 warnings generated.[2019-09-26T17:49:13.021Z] [ 39%] Linking CXX executable ../bin/chronotest[2019-09-26T17:49:13.021Z] [ 39%] Built target chronotest[2019-09-26T17:49:13.952Z] [ 40%] Linking CXX shared library ../bin/libprocesscore.so[2019-09-26T17:49:13.952Z] [ 40%] Built target processcore[2019-09-26T17:49:13.952Z] Scanning dependencies of target processui_autogen[2019-09-26T17:49:13.952Z] Scanning dependencies of target ksignalplotter_autogen[2019-09-26T17:49:13.952Z] Scanning dependencies of target ksgrd_autogen[2019-09-26T17:49:13.952Z] [ 42%] Automatic MOC for target processui[2019-09-26T17:49:13.952Z] [ 43%] Automatic MOC for target ksgrd[2019-09-26T17:49:13.952Z] [ 44%] Automatic MOC for target ksignalplotter[2019-09-26T17:49:14.534Z] [ 44%] Built target ksgrd_autogen[2019-09-26T17:49:14.797Z] Scanning dependencies of target ksgrd[2019-09-26T17:49:14.797Z] [ 45%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/ksgrd_autogen/mocs_compilation.cpp.o[2019-09-26T17:49:14.797Z] [ 46%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorAgent.cpp.o[2019-09-26T17:49:14.797Z] [ 48%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorSocketAgent.cpp.o[2019-09-26T17:49:14.797Z] [ 50%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorManager.cpp.o[2019-09-26T17:49:14.797Z] [ 50%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/SensorShellAgent.cpp.o[2019-09-26T17:49:14.797Z] [ 51%] Building CXX object ksgrd/CMakeFiles/ksgrd.dir/ksgrd_debug.cpp.o[2019-09-26T17:49:14.797Z] [ 51%] Built target ksignalplotter_autogen[2019-09-26T17:49:14.797Z] [ 51%] Built target processui_autogen[2019-09-26T17:49:14.797Z] [ 54%] Generating ui_ReniceDlgUi.h[2019-09-26T17:49:14.797Z] [ 54%] Generating ui_ProcessWidgetUI.h[2019-09-26T17:49:14.797Z] Scanning dependencies of target ksignalplotter[2019-09-26T17:49:14.797Z] [ 55%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter_autogen/mocs_compilation.cpp.o[2019-09-26T17:49:14.797Z] [ 56%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter.cpp.o[2019-09-26T17:49:15.089Z] Scanning dependencies of target processui[2019-09-26T17:49:15.089Z] [ 57%] Building CXX object processui/CMakeFiles/processui.dir/processui_autogen/mocs_compilation.cpp.o[2019-09-26T17:49:15.663Z] [ 59%] Building CXX object processui/CMakeFiles/processui.dir/ksysguardprocesslist.cpp.o[2019-09-26T17:49:15.663Z] [ 60%] Building CXX object processui/CMakeFiles/processui.dir/ProcessFilter.cpp.o[2019-09-26T17:49:15.663Z] [ 61%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/kgraphicssignalplotter.cpp.o[2019-09-26T17:49:15.663Z] [ 62%] Building CXX object processui/CMakeFiles/processui.dir/ProcessModel.cpp.o[2019-09-26T17:49:15.940Z] [ 63%] Building CXX object signalplotter/CMakeFiles/ksignalplotter.dir/ksignalplotter_debug.cpp.o[2019-09-26T17:49:16.206Z] [ 65%] Building CXX object processui/CMakeFiles/processui.dir/ReniceDlg.cpp.o[2019-09-26T17:49:16.206Z] [ 66%] Building CXX object processui/CMakeFiles/processui.dir/KTextEditVT.cpp.o[2019-09-26T17:49:16.473Z] [ 67%] Linking CXX shared library ../bin/libksgrd.so[2019-09-26T17:49:16.473Z] [ 67%] Built target ksgrd[2019-09-26T17:49:16.473Z] [ 68%] Building CXX object processui/CMakeFiles/processui.dir/scripting.cpp.o[2019-09-26T17:49:17.050Z] [ 69%] Building CXX object processui/CMakeFiles/processui.dir/processui_debug.cpp.o[2019-09-26T17:49:17.308Z] [ 71%] Linking CXX shared library ../bin/libksignalplotter.so[2019-09-26T17:49:17.582Z] [ 71%] Built target ksignalplotter[2019-09-26T17:49:17.582Z] Scanning dependencies of target signalplottertest_autogen[2019-09-26T17:49:17.582Z] Scanning dependencies of target graphicssignalplotterbenchmark_autogen[2019-09-26T17:49:17.582Z] Scanning dependencies of target signalplotterbenchmark_autogen[2019-09-26T17:49:17.582Z] [ 72%] Automatic MOC for target signalplottertest[2019-09-26T17:49:17.582Z] [ 74%] Automatic MOC for target signalplotterbenchmark[2019-09-26T17:49:17.582Z] [ 74%] Automatic MOC for target graphicssignalplotterbenchmark[2019-09-26T17:49:17.582Z] /usr/home/jenkins/workspace/Plasma/libksysguard/kf5-qt5 FreeBSDQt5.13/processui/scripting.cpp:93:42: error: no 

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma added a comment.


  In D24146#538295 , @ngraham wrote:
  
  > Make a second patch that only fixes the bug, and then remove those changes 
from this patch.
  
  
  Do I need to create another page with only bug fix? Or do I need to make 
another commit only with bug fix? What to do with the correction of the display 
of numbers? Because I need changes that are in fixing the bug.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24246: Only show panel toolbox when desktop toolbox is open

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  no.
  this is in progress in a feature branch already

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24246

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.


  Yea, 5.17. Thanks!

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24129

To: GB_2, #plasma, #vdg, ngraham, romangg
Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Nathaniel Graham]

ngraham added a comment.


  Make a second patch that only fixes the bug, and then remove those changes 
from this patch.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma added a comment.


  In D24146#538292 , @ngraham wrote:
  
  > In D24146#538284 , @maximma 
wrote:
  >
  > >
  >
  >
  > Excellent. Could you split this out so we have two patches:
  
  
  Yes, could you explain?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Nathaniel Graham]

ngraham added a comment.


  In D24146#538284 , @maximma wrote:
  
  > 1. I am not sure where the description window is.
  
  
  You can click on the Edit Revision button to add stuff to the description.
  
  > 2. Yes, this fixes this bug. I am not sure how much this is the right 
solution, because I am not familiar with js at a sufficient level. But having 
considered all the solutions, I realized that this is one of the simplest 
solutions. I can’t explain correctly, so I’ll give an example. The user enters 
a number, say "102.03200". In memory, this will be stored as 10203200 and 5. 
That is, to get the number back we need 10203200/10 ^ 5. It also fixes a bug 
with the display of numbers. And the "C" button does the same as the "AC", 
because before that, when I clicked on "C" and further calculations, the answer 
was incorrect or the "C" button seemed not obvious to me.
  
  Excellent. Could you split this out so we have two patches:
  
  - One that fixes https://bugs.kde.org/show_bug.cgi?id=410988
  - Another one (this one?) that makes C do the same thing as AC

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24194: Add per-origin media controls blacklist

[Kai Uwe Broulik]

broulik updated this revision to Diff 66907.
broulik retitled this revision from "Add per-domain media controls blacklist" 
to "Add per-origin media controls blacklist".
broulik edited the summary of this revision.
broulik added a comment.


  - Work on origin rather than hostname
  - Merge whitelist and blacklist
  - Some cleanups

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24194?vs=66776=66907

REVISION DETAIL
  https://phabricator.kde.org/D24194

AFFECTED FILES
  extension/action_popup.css
  extension/action_popup.html
  extension/action_popup.js
  extension/constants.js
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Maxim Marshev]

maximma added a comment.


  1. I am not sure where the description window is.
  2. Yes, this fixes this bug. I am not sure how much this is the right 
solution, because I am not familiar with js at a sufficient level. But having 
considered all the solutions, I realized that this is one of the simplest 
solutions. I can’t explain correctly, so I’ll give an example. The user enters 
a number, say "102.03200". In memory, this will be stored as 10203200 and 5. 
That is, to get the number back we need 10203200/10 ^ 5.
  
  It also fixes a bug with the display of numbers. And the "C" button does the 
same as the "AC", because before that, when I clicked on "C" and further 
calculations, the answer was incorrect or the "C" button seemed not obvious to 
me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24129

To: GB_2, #plasma, #vdg, ngraham
Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24246: Only show panel toolbox when desktop toolbox is open

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  This way the panel toolbox isn't always visible, because with D23951 
 we're basically always in unlocked mode.
  
  Depends on D24239 

TEST PLAN
  Open the desktop toolbox and then the panel toolbox.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24246

AFFECTED FILES
  containments/panel/contents/ui/main.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24208: [Notifications] Dodge Plasma dialogs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This works great!
  
  Instead of temporarily hiding the pop-ups, maybe it should appear above the 
dialog? Not a huge deal though.
  
  5.17 branch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:1de5b06acc94: [GTK3] Make selection-mode headerbars closer 
to Adwaita (authored by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24205?vs=66787=66903

REVISION DETAIL
  https://phabricator.kde.org/D24205

AFFECTED FILES
  src/gtk3/widgets/_headerbar.scss

To: cblack, #breeze, ngraham
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  5.17 branch please

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  selection-mode-headerbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24205

To: cblack, #breeze, ngraham
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24203: Add settings change listener

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:0eaba6b4a184: Add settings change listener (authored by 
broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24203?vs=66785=66900

REVISION DETAIL
  https://phabricator.kde.org/D24203

AFFECTED FILES
  extension/extension.js
  extension/options.js
  extension/utils.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Kai Uwe Broulik]

broulik added a comment.


  Also keep in mind that Qt 5.14 supposedly supports markdown editing, which I 
would love in the notes applet, which would be preferred over "rich text" imho.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @ngraham yeah this is the best way to go as it seems to me. What I did was 
just drawing attention to this problem since I cannot code and it's hard to 
understand how everything works for a non-coder.
  @ltoscano I'd vote for any solution which makes Notes more configurable with 
respect to pasting of formatted text.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

[Nathaniel Graham]

ngraham added reviewers: Plasma, cfeck.
ngraham added a comment.


  1. This needs more explanation in the Description section to indicate why the 
proposed change is a good idea.
  2. This seems like it has some unrelated changes in it, which look 
worthwhile, but they should be in a separate patch. Is this fixing 
https://bugs.kde.org/show_bug.cgi?id=410988?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Nathaniel Graham]

ngraham added a comment.


  Which one of the screenshots depicts how this looks with one of the default 
color schemes? The one with the purple background or the teal background?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24205

To: cblack, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Nathaniel Graham]

ngraham added a comment.


  In D24181#538206 , @ltoscano wrote:
  
  > @ngraham Let's make it configurable, but not change the default then. I 
disagree that changing this default on an application which support rich text 
by default helps making the life of everyone better.
  
  
  What do you think about my proposal to make the notes applet itself be 
configurable between plain text and rich text? In this case, we could have it 
paste in plain text in plain text mode, and rich text in rich text mode, with a 
"paste without formatting" option for (the probably somewhat uncommon case of) 
people who do want to //use// rich text but don't want to //paste// rich text.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24203: Add settings change listener

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Seems to work on FF ESR

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24203

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  @ngraham Let's make it configurable, but not change the default then. I 
disagree that changing this default on an application which support rich text 
by default helps making the life of everyone better.
  
  @yerilov, as you can see, I didn't request a change, because in the end 
everything I'm writing will be ignored. So don't worry. But just for the sake 
of completeness, there are other solutions: see the previous suggestions about 
making this configurable.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23675: [Folder View] Don't query file information if tooltips are disabled

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23675

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> MuteButton.qml:26
>  
> -Button {
> +QQC2.Button {
>  property bool muted: true

Now that this thing is moved next to the volume slider, I feel like it should 
be a ToolButton, like in the applet.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24224: Start of the accessibility KCM

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> Bell.qml:27
> +
> +ColumnLayout {
> +QQC2.GroupBox {

Shouldn't use groupboxes at all, but just FormLayouts with sections

  Kirigami.FormLayout {
Item{
Kirigami.formData.title: i18n("Audible Bell")
Kirigami.formData.isSection: true
}
QQC2.CheckBox { 
  
  
Item{
Kirigami.formData.title: i18n("Visual Bell")
Kirigami.formData.isSection: true
}
QQC2.CheckBox { 

  }

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24224: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added a comment.


  Don't change `kcm_access` to `kcmaccess`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Marco Martin]

mart added a comment.


  Visually, it looks exactly like the old one, but in qml.. which gives it 
several layouting problems
  Since is tabbed (vdg should be contacted tough to see if they don't have a 
different option other than tabbed) it should use 
https://phabricator.kde.org/D23835 (which then would depend from)
  
  all the things inside the tabs should then use a Kirigami.FormLayout

INLINE COMMENTS

> CMakeLists.txt:6
>  set(kcm_access_PART_SRCS kcmaccess.cpp )
> +add_library(kcmaccess MODULE ${kcm_access_PART_SRCS})
>  

kcm_access for compatibility with the other kcms

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  @ltoscano D22774  added the ability to 
choose between paste with and without formatting in the context menu, so yes, 
no problem with distinguishing.
  Adding another shortcut like Ctrl+Shift+V is also a viable solution but these 
kinds (any kinds) of complex shortcuts have more chance to conflict with 
various things like input method switching (fcitx, ibus invoke or IM switch). 
One more reason to revive D14796  which was 
undeservingly abandoned btw. In fact, it won't (I've checked with 
fcitx/kimpanel) but that's another story.
  
  Seems like I gonna stick with my txt file on the desktop, okay, I had to try 
anyway.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Nathaniel Graham]

ngraham added a comment.


  In D24181#538185 , @ltoscano wrote:
  
  > Please ignore the last part of my last comment. My question on the way a 
paste happens is still relevant, so please answer it: if users use the right 
click, they will surely distiguish "paste" and "paste without formatting".
  
  
  Right, the problem is when using the keyboard shortcut, because ctrl+v 
previously included formatting by default. Now it doesn't. I don't know why 
we're arguing over something already committed. I'm against reverting it.
  
  > If they use the shortcut, they can learn to use the the proper shortcut for 
that action
  
  I don't think that's realistic here. What we would prefer the user to do or 
learn and what the average user in all practicality is going to be able to do 
or learn are not always the same things. Sometimes improving the user 
experience for the common case pushes us in the direction of breaking a 
convention, and that's why we did it. Consistency is good when it improves the 
user experience, but when it hinders it, we should be willing to be flexible.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24187: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added a comment.


  closing this as arc diff opened two reviews with the same content =/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24187

To: tcanabrava
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava added a comment.


  got it, updating.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  Please ignore the last part of my last comment. My question on the way a 
paste happens is still relevant, so please answer it: if users use the right 
click, they will surely distiguish "paste" and "paste without formatting". If 
they use the shortcut, they can learn to use the the proper shortcut for that 
action (which, in applications which provides rich text support, is not ctrl-V).

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D24224#537680 , @whiting wrote:
  
  > Thanks for taking this on Tomaz, Just throwing some ideas out but if it 
would help to have less tabs it might be useful to put all the keyboard 
features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, 
Keyboard Filters and Activation Gestures) The top groupbox of Activation 
Gestures items could be moved to their respective groupboxes also so there are 
less groupboxes on the Keyboard tab than before on these 3 tabs.
  
  
  I'll try  - I don't like the amount of tabs, but maybe joining three tabs 
together is too much.
  The Orca tab has only one option, there's `configure notifications buttons` 
twice. we need a bit of love there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  Please also note that the notes applications is a rich text editor by default 
(like the buttons shows). So I would vote for a revert of D22774 
.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  I don't see how using the "running in circles" argument can solve the 
problem. I totally understand how notes works, thanks.
  The situation is how I described above: applications with just paste may have 
non-formatting option; applications which have both options default to pasting 
with formatting.
  Nothing here convinces me that there is enough reasons to diverge from the 
common patterns. It's not a matter of being richer and with more features.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  > Do those applications provide the paste-with-formatting action too?
  
  No they don't. So it is one more thing that actually makes Plasma more 
feature-rich DE.
  
  > When you talk about "pastes text", "paste it", etc, which way do you mean?
  
  Well, we're running in circles here. Until everyone here understands which 
paste options Notes applet has now and had before any discussion is useless.
  
  One last time, to clarify how it was, how it is, and how it was proposed to 
be:
  
  1. Until https://phabricator.kde.org/D22774 Notes default paste option was 
"paste with formatting", which was named "Paste" in menu and invoked by Ctrl+V. 
This is how it was.
  2. https://phabricator.kde.org/D22774 changed the default paste option to 
"paste without formatting" and renamed it to "Paste without Formatting", making 
Ctrl+V to paste without formatting. This is how it is as of 5.16.80.
  3. What I propose is to simply rename the menu option introduced by 
https://phabricator.kde.org/D22774, "Paste without Formatting" to "Paste" 
again, but preserve the actual action and Ctrl+V shortcut, and rename another 
(next) option from "Paste" to "Paste With Formatting" in order to make a clear 
difference between the two options in menu. This is how is suggested to be. 
Cosmetic but looks better and in accordance with the expectations of the end 
user (broadly speaking).
  
  Arguing about another applications is irrelevant due to the nature of the 
Notes applet: it is not an application like MS Word, it serves another purpose. 
Needless to say that we all know now that there are some KDE apps like Kate or 
KWrite or KolourPaint (more than one) which have no Paste with formatting 
option at all, this is why any try to argue like "all other KDE application 
have this behavior by default" would contradict the reality.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24194: Add per-domain media controls blacklist

[Kai Uwe Broulik]

broulik added a comment.


  > AFAICT it doesn't reload the mpris state in the content-script immediately 
when settings change, can that be implemented?
  
  First we need D24203 .
  It might be tricky to properly unload e.g. the media sessions stuff, but I 
can look into this.
  Actually, I wanted to implement "live" settings changes for the other 
settings (like breeze scroll bars and what not) in a later step, too, for which 
D24203  is a prerequisite.

INLINE COMMENTS

> fvogt wrote in action_popup.js:20
> `getCurrentTabUrl()`

The class is named `TabUtils` but I can change the method if you want..

> fvogt wrote in action_popup.js:46
> Maybe `runAt: "document_start"` to speed it up a bit? I'm not sure about the 
> implications.

Don't think this will change much, given it is only executed when you click the 
toolbar button, at which point the page is probably already loaded, but I'll 
give it a try

> fvogt wrote in action_popup.js:62
> Whitespace?

Intentional, for a bit of visual grouping

> fvogt wrote in action_popup.js:118
> Currently calling `set(domain, false);` twice has a different result from 
> `set(domain, false);` once, so maybe split into `whitelist(domain)` and 
> `blacklist(domain)`)?

Imho the caller shouldn't have to care about whether it needs to be whitelisted 
or removed from the blacklist. The whitelist is only so that the user can 
opt-in to websites which we by default blacklist.

> fvogt wrote in content-script.js:68
> Is this guaranteed to be identical to `new 
> URL(window.location.href).hostname` as used in utils?

Good question, no idea, probably. :)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24194: Add per-domain media controls blacklist

[Fabian Vogt]

fvogt added a comment.


  AFAICT it doesn't reload the mpris state in the content-script immediately 
when settings change, can that be implemented?
  
  IMO the blacklist should be more than the domain, it should test the same 
conditions as CORS, so protocol, domain and port.

INLINE COMMENTS

> action_popup.js:20
> +// Gets the URL of the currently viewed tab
> +static getCurrentUrl() {
> +return new Promise((resolve, reject) => {

`getCurrentTabUrl()`

> action_popup.js:42
> +// Gets the URLs of the currently viewed tab including all of its iframes
> +static getCurrentUrls() {
> +return new Promise((resolve, reject) => {

Currently the function name implies that it returns all tabs, so maybe rename 
to `getCurrentTabFramesUrls()` (or better)?

> action_popup.js:46
> +allFrames: true, // so we also catch iframe videos
> +code: `window.location.href`
> +}, (result) => {

Maybe `runAt: "document_start"` to speed it up a bit? I'm not sure about the 
implications.

> action_popup.js:62
> +return new Promise((resolve, reject) => {
> +
> +Promise.all([

Whitespace?

> action_popup.js:118
> +
> +set(domain, block) {
> +return this.get().then((blockInfo) => {

Currently calling `set(domain, false);` twice has a different result from 
`set(domain, false);` once, so maybe split into `whitelist(domain)` and 
`blacklist(domain)`)?

> action_popup.js:120
> +return this.get().then((blockInfo) => {
> +
> +let whitelist = blockInfo.mprisSettings.whitelistedDomains;

Whitespace?

> content-script.js:68
>  if (mpris.enabled) {
> -loadMpris();
> -if (items.mprisMediaSessions.enabled) {
> -loadMediaSessionsShim();
> +const domain = window.location.hostname;
> +

Is this guaranteed to be identical to `new URL(window.location.href).hostname` 
as used in utils?

> content-script.js:70
> +
> +const whitelist = items.mpris.whitelistedDomains || [];
> +const blacklist = items.mpris.blacklistedDomains || [];

Use `mpris.` instead of `items.mpris`

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23996: Port away from deprecated KIO::suggestName

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fd765b4a232a: Port away from deprecated KIO::suggestName 
(authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23996?vs=66234=66893#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23996?vs=66234=66893

REVISION DETAIL
  https://phabricator.kde.org/D23996

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: nicolasfella, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24130: Remove unused include

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1e636858146b: Remove unused include (authored by 
nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24130?vs=66580=66892

REVISION DETAIL
  https://phabricator.kde.org/D24130

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: nicolasfella, #plasma, bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24242: Port away from foreach

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

TEST PLAN
  builds, energy saving kcm opens fine

REPOSITORY
  R122 Powerdevil

BRANCH
  foreach

REVISION DETAIL
  https://phabricator.kde.org/D24242

AFFECTED FILES
  CMakeLists.txt
  daemon/actions/bundled/handlebuttoneventsconfig.cpp
  daemon/backends/upower/backlighthelper.cpp
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/udevqtclient.cpp
  daemon/powerdevilactionpool.cpp
  daemon/powerdevilapp.cpp
  daemon/powerdevilcore.cpp
  daemon/powerdevilpolicyagent.cpp
  daemon/powerdevilprofilegenerator.cpp
  kcmodule/activities/activitypage.cpp
  kcmodule/activities/activitywidget.cpp
  kcmodule/common/actioneditwidget.cpp
  kcmodule/global/GeneralPage.cpp
  kcmodule/profiles/EditPage.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24238: Port the pager applet away from QtWidgets

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in windowmodel.cpp:81
> Isn't that the combined geometry of all screens, not just a single screen?

Oh indeed. But then this was the wrong thing to use anyway. You don't want to 
center the window in relation to the combined geometry, as the documentation of 
QDesktopWidget rightfully says.

Not that I really understand this code, I admit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Nathaniel Graham]

ngraham added a comment.


  In D24223#537927 , @fabianr wrote:
  
  > > It doesn't auto-hide by default in macOS. I decided to make it span the 
full width of the screen because not doing this is IMO one of the dumbest parts 
of that macOS dock, because it pointlessly  wastes the bottom-left-most and 
bottom-right-most pixels, which are two of the four easiest to click pixels in 
the whole screen.
  >
  > Even if you don't agree with the dock being limited in width, I think you 
still should make it limited. It is one of the most distinct visual aspects of 
the original desktop.
  >
  > Can Late be used in LnF?
  
  
  Yes, but if we ship a Global Theme that uses Latte in kdeplasma-addons, this 
would require making Latte a hard dependency of kdeplasma-addons, which is 
something that I'm not sure we're interested in doing.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  Do those applications provide the paste-with-formatting action too?
  
  When you talk about "pastes text", "paste it", etc, which way do you mean? 
Shortcut, right click + "Paste" entry, middle menu click, all of them, some of 
them?

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  Talking about cross-platform: Windows Notes app pastes text with no 
formatting, as Gnome Sticky Notes do, even Android apps do not use pasting with 
formatting by default.
  Yep, I understand expecting pasting with formatting for Office apps, but for 
Notes widget it is more of an additional option.
  I don't know how to explain it more clearly. Just suggest to copy some part 
of, say, Manjaro Linux forum main page and paste it with formatting no Notes. 
That's hardly a thing any user would expect to see in any notes applet on any 
platform.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: davidedmundson, huftis, broulik, yurchor, ltoscano, aacid, #localization, 
yerilov, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24204: Move save failure message above options

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:83602d804e71: Move save failure message above options 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24204?vs=66786=66888

REVISION DETAIL
  https://phabricator.kde.org/D24204

AFFECTED FILES
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24238: Port the pager applet away from QtWidgets

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> windowmodel.cpp:81
>  QRect windowGeo = TaskFilterProxyModel::data(index, role).toRect();
> -const QRect  = d->desktopWidget->geometry();
>  

Isn't that the combined geometry of all screens, not just a single screen?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: dfaure, hein, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24187: Start of the accessibility KCM

[Marco Martin]

mart added a comment.


  
"file:///mnt/storage/diau/kde5/share/kpackage/kcms/kcmaccess/contents/ui/main.qml"
 
   "Error loading QML file.\n55: Type KeyboardFilters unavailable\n35: id is 
not unique\n"

INLINE COMMENTS

> CMakeLists.txt:26
>  
> -install(TARGETS kcm_access DESTINATION ${KDE_INSTALL_PLUGINDIR})
> +kcoreaddons_desktop_to_json(kcmaccess "kcmaccess.desktop")
>  

kcm_access for consistency

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24187

To: tcanabrava
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D24238: Port the pager applet away from QtWidgets

[David Faure]

dfaure created this revision.
dfaure added reviewers: hein, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24238

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/windowmodel.cpp

To: dfaure, hein, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

ddcutil in Plasma Powerdevil

[Jonathan Riddell]

The DDCUtil features of Powerdevil in KDE Plasma are currently disabled by
default
"DDCUtil library support is disabled by default as recomended by authors,
add -DHAVE_DDCUTIL=On to enable"
This is based on a conversation from 2017 where it was decided it was
unstable.

I see work has continued on DDCUtil and on support for it in Powerdevil.
Is it ready to be set to on by default?

It is too late for Plasma 5.17 due for release in 2 weeks but we can tell
distros the message is old as appropriate.

Jonathan

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Fabian Riethmayer]

fabianr added a comment.


  > It doesn't auto-hide by default in macOS. I decided to make it span the 
full width of the screen because not doing this is IMO one of the dumbest parts 
of that macOS dock, because it pointlessly  wastes the bottom-left-most and 
bottom-right-most pixels, which are two of the four easiest to click pixels in 
the whole screen.
  
  Even if you don't agree with the dock being limited in width, I think you 
still should make it limited. It is one of the most distinct visual aspects of 
the original desktop.
  
  Can Late be used in LnF?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart