D24370: [KCM] Display scale factor as a percentage, not a decimal

[Dominik Haumann]

dhaumann added a comment.


  +1. This is also in line with typical zoom factors in other applications such 
as Okular, which also use percent values.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24370

To: ngraham, #vdg, #plasma, romangg
Cc: dhaumann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 427 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/427/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 03 Oct 2019 05:38:57 +
 Build duration:
3 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][Pipeline] sh[2019-10-03T05:40:54.178Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-03T05:41:00.321Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-03T05:41:00.321Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-03T05:41:00.826Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-03T05:41:00.826Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-03T05:41:01.327Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-03T05:41:01.327Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-03T05:41:01.327Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-03T05:41:01.327Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-03T05:41:01.828Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-03T05:41:01.828Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-03T05:41:01.828Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-03T05:41:01.828Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-03T05:41:01.828Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-03T05:41:02.350Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-03T05:41:02.350Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-03T05:41:02.862Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-03T05:41:02.862Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-03T05:41:02.862Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-03T05:41:02.862Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-03T05:41:03.361Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-03T05:41:07.341Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-03T05:41:09.018Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-03T05:41:09.018Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-03T05:41:09.520Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-03T05:41:10.023Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-03T05:41:11.076Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-03T05:41:11.587Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-03T05:41:13.947Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-03T05:41:13.947Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-03T05:41:14.450Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-03T05:41:16.113Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-03T05:41:16.113Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-03T05:41:17.169Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-03T05:41:18.242Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-03T05:41:19.903Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-03T05:41:24.884Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-03T05:41:24.884Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-03T05:41:24.884Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-03T05:41:25.387Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-03T05:41:25.387Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-03T05:41:25.889Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-03T05:41:25.889Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-03T05:41:26.388Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-03T05:41:26.388Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-03T05:41:26.887Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-03T05:41:26.888Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-03T05:41:26.888Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-03T05:41:26.888Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-03T05:41:27.388Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-03T05:41:28.437Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-03T05:41:28.938Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-03T05:41:28.938Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-03T05:41:28.938Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-03T05:41:29.438Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-03T05:41:29.438Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-03T05:41:29.939Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-03T05:41:29.939Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-10-03T05:41:29.939Z] 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/165/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 03 Oct 2019 05:38:57 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 89 lines...][2019-10-02T16:48:04.244Z]  > git checkout -f e09c169bc08275c209a496a76e787147bc4f9262 # timeout=10[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-10-03T05:39:43.203Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2019-10-03T05:39:46.490Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-03T05:39:46.490Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-03T05:39:46.490Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-03T05:39:46.490Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-03T05:39:46.490Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-03T05:39:46.747Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-03T05:39:46.747Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-03T05:39:46.747Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-03T05:39:47.037Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-03T05:39:47.037Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-03T05:39:47.037Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-03T05:39:47.293Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-03T05:39:47.548Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-03T05:39:50.834Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-03T05:39:51.102Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-03T05:39:51.362Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-03T05:39:51.623Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-03T05:39:53.515Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-03T05:39:53.515Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-03T05:39:53.515Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-03T05:39:53.515Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-03T05:39:53.515Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-03T05:39:54.077Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-03T05:39:54.332Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-03T05:39:54.332Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-03T05:39:54.934Z] Retrieving: 

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Carson Black]

cblack added a comment.


  In D24324#541215 , @ndavis wrote:
  
  > In D24324#541214 , @cblack wrote:
  >
  > > In D24324#541212 , @ndavis 
wrote:
  > >
  > > > I'm not sure how to verify if the assets have been generated correctly. 
What GTK2 programs did you test with?
  > >
  > >
  > > Look for a theme in `~/.local/share/themes` called `Breeze `. The reason 
why it has a  is to distinguish it from the system Breeze GTK2 theme. 
Otherwise,
  > >  there'd be two Breeze entries listed in the user's GTK2 theme list in 
syse5. Yes, it's clunky, but this is a toolkit older than me, so clunkiness is 
expected.
  > >
  > > I would probably add a "if the user has GTK2 theme set to Breeze/Breeze 
Dark change the GTK2 theme to the recoloured one" but I'm not sure
  > >  what direction GTK configuration is heading with that configuration 
daemon being worked on, so I'd rather not mess with GTK configuration until 
that's ironed out.
  >
  >
  > Am I supposed to run this script myself? I did `make install` and it didn't 
seem to do anything.
  >
  > Are you sure the emoji isn't going to be a problem in programs or systems 
with no emoji fonts?
  
  
  Eh, if you have any better ideas for the name let me know.
  
  As for testing it, you need both this revision and the one I marked it as 
dependent on. The colors KCM should run the script whenever you apply a 
colorscheme.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Noah Davis]

ndavis added a comment.


  In D24324#541214 , @cblack wrote:
  
  > In D24324#541212 , @ndavis wrote:
  >
  > > I'm not sure how to verify if the assets have been generated correctly. 
What GTK2 programs did you test with?
  >
  >
  > Look for a theme in `~/.local/share/themes` called `Breeze `. The reason 
why it has a  is to distinguish it from the system Breeze GTK2 theme. 
Otherwise,
  >  there'd be two Breeze entries listed in the user's GTK2 theme list in 
syse5. Yes, it's clunky, but this is a toolkit older than me, so clunkiness is 
expected.
  >
  > I would probably add a "if the user has GTK2 theme set to Breeze/Breeze 
Dark change the GTK2 theme to the recoloured one" but I'm not sure
  >  what direction GTK configuration is heading with that configuration daemon 
being worked on, so I'd rather not mess with GTK configuration until that's 
ironed out.
  
  
  Am I supposed to run this script myself? I did `make install` and it didn't 
seem to do anything.
  
  Are you sure the emoji isn't going to be a problem in programs or systems 
with no emoji fonts?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Carson Black]

cblack added a comment.


  In D24324#541212 , @ndavis wrote:
  
  > I'm not sure how to verify if the assets have been generated correctly. 
What GTK2 programs did you test with?
  
  
  Look for a theme in `~/.local/share/themes` called `Breeze `. The reason why 
it has a  is to distinguish it from the system Breeze GTK2 theme. Otherwise,
  there'd be two Breeze entries listed in the user's GTK2 theme list in syse5. 
Yes, it's clunky, but this is a toolkit older than me, so clunkiness is 
expected.
  
  I would probably add a "if the user has GTK2 theme set to Breeze/Breeze Dark 
change the GTK2 theme to the recoloured one" but I'm not sure
  what direction GTK configuration is heading with that configuration daemon 
being worked on, so I'd rather not mess with GTK configuration until that's 
ironed out.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Noah Davis]

ndavis added a comment.


  I'm not sure how to verify if the assets have been generated correctly. What 
GTK2 programs did you test with?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin marked an inline comment as done.
alexeymin added a comment.


  Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our 
main documentation page https://api.kde.org/frameworks/index.html . If it is 
really Tier 3, then maybe it does not even make sense to make IconThemes and 
ConfigWidgets optional?
  
  > The subgroup value looks wrong
  
  And maybe should I include a change to `mtainfo.yaml` modifying `subgroup: 
Tier 1` to `subgroup: Tier 3` then?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin updated this revision to Diff 67233.
alexeymin added a comment.


  - Bring back missing KF5_DEP_VERSION

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67207=67233

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 426 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/426/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 02 Oct 2019 22:05:02 +
 Build duration:
1 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 127 lines...][Pipeline] sh[2019-10-02T22:06:13.465Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2019-10-02T22:06:18.735Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-polkit-qt-1-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-02T22:06:18.735Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-02T22:06:20.632Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-02T22:06:20.891Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-02T22:06:20.891Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-02T22:06:20.891Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-02T22:06:20.891Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-02T22:06:20.891Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-02T22:06:21.157Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-02T22:06:21.429Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-02T22:06:21.697Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-02T22:06:21.697Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-02T22:06:23.089Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-02T22:06:23.089Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-02T22:06:23.089Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-02T22:06:23.089Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-02T22:06:23.089Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-02T22:06:23.348Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-02T22:06:23.348Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-02T22:06:23.348Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-02T22:06:23.612Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-02T22:06:24.541Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-02T22:06:24.803Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-02T22:06:24.803Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-02T22:06:24.803Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-02T22:06:24.803Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-02T22:06:25.378Z] Retrieving: 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/164/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 02 Oct 2019 22:05:01 +
 Build duration:
1 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 87 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2019-10-02T22:06:09.086Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2019-10-02T22:06:14.738Z] Retrieving: Plasma-extra-cmake-modules-kf5-qt5[2019-10-02T22:06:14.738Z] Retrieving: Plasma-kcodecs-kf5-qt5[2019-10-02T22:06:14.738Z] Retrieving: Plasma-karchive-kf5-qt5[2019-10-02T22:06:14.738Z] Retrieving: Plasma-ki18n-kf5-qt5[2019-10-02T22:06:14.738Z] Retrieving: Plasma-kcoreaddons-kf5-qt5[2019-10-02T22:06:15.065Z] Retrieving: Plasma-kauth-kf5-qt5[2019-10-02T22:06:15.065Z] Retrieving: Plasma-kconfig-kf5-qt5[2019-10-02T22:06:15.065Z] Retrieving: Plasma-kdoctools-kf5-qt5[2019-10-02T22:06:15.753Z] Retrieving: Plasma-kguiaddons-kf5-qt5[2019-10-02T22:06:15.753Z] Retrieving: Plasma-kwidgetsaddons-kf5-qt5[2019-10-02T22:06:15.753Z] Retrieving: Plasma-kconfigwidgets-kf5-qt5[2019-10-02T22:06:15.753Z] Retrieving: Plasma-kitemviews-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-kirigami-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-10-02T22:06:16.045Z] Retrieving: Plasma-phonon-kf5-qt5[2019-10-02T22:06:16.360Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-10-02T22:06:16.361Z] Retrieving: Plasma-kservice-kf5-qt5[2019-10-02T22:06:16.361Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-10-02T22:06:16.361Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-10-02T22:06:16.638Z] Retrieving: Plasma-attica-kf5-qt5[2019-10-02T22:06:16.638Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-10-02T22:06:16.638Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-10-02T22:06:16.638Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-solid-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-10-02T22:06:21.911Z] Retrieving: Plasma-kio-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kparts-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-10-02T22:06:22.857Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-10-02T22:06:23.150Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-10-02T22:06:23.150Z] Retrieving: Plasma-kross-kf5-qt5[2019-10-02T22:06:23.150Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-10-02T22:06:23.150Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-10-02T22:06:23.150Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-10-02T22:06:23.422Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-10-02T22:06:23.698Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-10-02T22:06:26.280Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-10-02T22:06:26.540Z] Retrieving: Plasma-kpty-kf5-qt5[2019-10-02T22:06:26.540Z] Retrieving: Plasma-kinit-kf5-qt5[2019-10-02T22:06:26.802Z] Retrieving: Plasma-kded-kf5-qt5[2019-10-02T22:06:26.802Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-10-02T22:06:27.426Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-10-02T22:06:27.426Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-10-02T22:06:27.686Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-10-02T22:06:27.686Z] Retrieving: Plasma-baloo-kf5-qt5[2019-10-02T22:06:27.962Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-10-02T22:06:27.962Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-10-02T22:06:27.962Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-10-02T22:06:27.962Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-10-02T22:06:27.962Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-10-02T22:06:28.969Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-10-02T22:06:28.969Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-10-02T22:06:28.969Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-10-02T22:06:28.969Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-10-02T22:06:28.969Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-10-02T22:06:29.238Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-10-02T22:06:29.238Z] Retrieving: Plasma-krunner-kf5-qt5[2019-10-02T22:06:29.238Z] Retrieving: 

D24325: [runners/calculator] Port old style connect

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e0f8167399ce: [runners/calculator] Port old style connect 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24325?vs=67092=67229

REVISION DETAIL
  https://phabricator.kde.org/D24325

AFFECTED FILES
  runners/calculator/qalculate_engine.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24268: [libtaskmanager] Port to new connect syntax

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0d9e0bce94af: [libtaskmanager] Port to new connect syntax 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24268?vs=66962=67228

REVISION DETAIL
  https://phabricator.kde.org/D24268

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The colors KCM will now call on a modified version of Breeze GTK's assets
  generation script when a colorscheme is applied. This will result in a 
colored version
  of Breeze GTK2 being generated in the user's home directory.

TEST PLAN
  Check that a coloured version of Breeze GTK2 is generated
  whenever a colourscheme is applied.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  colors-kcm-recolor-gtk2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24375

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham updated this revision to Diff 67226.
ngraham added a comment.


  Don't mention X11; it's too nerdy and technical

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=67218=67226

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Christoph Cullmann]

cullmann added a comment.


  I would just reformulate
  
  "Scale factors are limited to multiples of 6.25% on X11 to minimize visual 
glitches in applications."
  
  to
  
  "Scale factors are limited to multiples of 6.25% to minimize visual glitches 
in applications."
  
  I think adding X11 only makes this harder to understand for the users.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham added a comment.


  Here's a patch that changes the increment (along with a few dependencies that 
improve the UI in preparation for it): D24373 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67223.
tcanabrava added a comment.


  - Fix KAuth usage

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24374?vs=67219=67223

BRANCH
  kcm_dateandtime

REVISION DETAIL
  https://phabricator.kde.org/D24374

AFFECTED FILES
  kcms/colors/package/metadata.desktop
  kcms/dateandtime/CMakeLists.txt
  kcms/dateandtime/clock.desktop
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/dtime.h
  kcms/dateandtime/kcm_clock.desktop
  kcms/dateandtime/main.cpp
  kcms/dateandtime/main.h
  kcms/dateandtime/package/contents/ui/main.qml
  kcms/dateandtime/package/metadata.desktop

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24374: WIP: Initial port of the Date and Time KCM

[Nathaniel Graham]

ngraham added a comment.


  Neato. See the mockups and discussion in T7248 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24374

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This is mostly the c++ part, missing the Qml - however this one should
  be easy to do - with the exception of the visual clock, and the
  KAuth integration that aparently is missing from the QuickAddons

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_dateandtime

REVISION DETAIL
  https://phabricator.kde.org/D24374

AFFECTED FILES
  kcms/colors/package/metadata.desktop
  kcms/dateandtime/CMakeLists.txt
  kcms/dateandtime/clock.desktop
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/dtime.h
  kcms/dateandtime/kcm_clock.desktop
  kcms/dateandtime/main.cpp
  kcms/dateandtime/main.h
  kcms/dateandtime/package/contents/ui/main.qml
  kcms/dateandtime/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Because of the nature of floating point math and various Qt and X11 bugs, 
limiting the
  scale factor increment to 0.0625 (6.25% in percentage form) will improve the 
display in
  many apps.
  
  For more information, see https://bugreports.qt.io/browse/QTBUG-66036 and the 
discussion
  in https://bugs.kde.org/show_bug.cgi?id=412447 and the following application 
bug reports:
  CCBUG: 390451
  CCBUG: 373232
  
  Depends on D24370 
  Depends on D24371 

TEST PLAN
  F7500922: 0625.png 

REPOSITORY
  R104 KScreen

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24371: [KCM] Make the warning message wider

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Making the message wider improves the presentation, especially for wordy 
languages
  where the message may become very tall.

TEST PLAN
  F7500913: Wide message.png 

REPOSITORY
  R104 KScreen

BRANCH
  wide-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24371

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24370: [KCM] Express scale factor as a percentage, not a decimal

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is the way GNOME and Windows present this information, and I think it's 
clearer
  than using a decimal value.

TEST PLAN
  F7500851: percentage.png 

REPOSITORY
  R104 KScreen

BRANCH
  express-scale-factor-as-percentage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24370

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  Gonna land this in 24hrs if there are no objections.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Luigi Toscano]

ltoscano added a comment.


  What is the difference between "LeadAcid" and "Lead Acid"?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:42fe072ad0fe: [energy KCM] Add battery Technology 
(authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23392?vs=65189=67209

REVISION DETAIL
  https://phabricator.kde.org/D23392

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok ,works for me, too. Sorry for the noise! And thanks for the explanation!
  I think this is already much better than before, the details of the last 
finesse with the minimal step can be discussed elsewhere.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24333: sddm-theme: Set needsFullUserModel=false

[Fabian Vogt]

fvogt added a comment.


  In D24333#541012 , @davidedmundson 
wrote:
  
  > I don't think I follow.
  >
  > How does the regular non-textfield version of the login screen still work? 
Surely containsAllUsers will always be false.
  
  
  It's only false if there are more users in the system than the threshold 
configured in sddm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24333

To: fvogt, #plasma
Cc: ngraham, davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24333: sddm-theme: Set needsFullUserModel=false

[David Edmundson]

davidedmundson added a comment.


  I don't think I follow.
  
  How does the regular non-textfield version of the login screen still work? 
Surely containsAllUsers will always be false.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24333

To: fvogt, #plasma
Cc: ngraham, davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several build system errors

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Note: the metainfo file says this framework is tier 3.
  
  The subgroup value looks wrong

INLINE COMMENTS

> CMakeLists.txt:40-41
> +# IconThemes and ConfigWidgets are optional
> +find_package(KF5IconThemes)
> +find_package(KF5ConfigWidgets)
>  

KF5_DEP_VERSION is lost here

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

[Alexey Min]

alexeymin reopened this revision.
alexeymin added a comment.


  Phabricator, you're drunk, it is not pushed to master

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several build system errors

[Phabricator]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem 
errors (authored by Aleksey Minnekhanov 
aleksei.minneha...@myoffice.team).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67188=67207

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24333: sddm-theme: Set needsFullUserModel=false

[Nathaniel Graham]

ngraham added subscribers: filipf, davidedmundson, ngraham.
ngraham added a comment.


  Seems sane enough to me. @davidedmundson @filipf?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24333

To: fvogt, #plasma
Cc: ngraham, davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5961: Adoption of KUserFeedback for Discover

[Nathaniel Graham]

ngraham added a comment.


  In D5961#540961 , @apol wrote:
  
  > Discover is part of plasma and the information shared should be centrally 
configured.
  
  
  Then we need for the feedback KCM to mention Discover as a source of 
information that will be sent. Maybe this needs to be changed in KUserFeedback? 
Right now the explanatory text that comes from the framework only mentions 
System Settings). It's not obvious to users that Discover is a part of Plasma. 
So we need to make the connection obvious.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24361: [Style KCM] Port to new design

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  This is fantastic. From a UI perspective, I think it's perfect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24361

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D5961: Adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol added a comment.


  In D5961#540955 , @ngraham wrote:
  
  > So this patch adds a semi-hidden menu item on the About page that opens the 
User Feedback KCM in a KCMShell window. I think this needs a better UX:
  >
  > 1. We finally need a real Settings page/window for Discover if we're going 
to be adding more user-configurable settings like this one. The About page 
isn't an appropriate place for this. Maybe we should Change Sources to Settings 
and add it there.
  
  
  True, maybe we should re-rename Sources to settings again.
  
  > 2. Shouldn't the UI here be Discover-specific? The global KCM doesn't seem 
relevant since it talks about turning on or off telemetry for all KDE apps and 
allows configuring stuff for Plasma specifically. Strictly speaking, Discover 
isn't a part of Plasma. And from a user perspective, Discover is just an app 
among other apps.
  
  Discover is part of plasma and the information shared should be centrally 
configured.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 425 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/425/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 02 Oct 2019 16:02:58 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.17.80.xmlacc/LibKWorkspace-5.17.80.xmlacc/LibNotificationManager-5.17.80.xmlacc/LibTaskManager-5.17.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.17.80/log.txtlogs/LibKWorkspace/5.17.80/log.txtlogs/LibNotificationManager/5.17.80/log.txtlogs/LibTaskManager/5.17.80/log.txt
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/124)11%
(51/459)11%
(51/459)6%
(2566/41285)4%
(1260/28405)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.kicker.plugin0%
(0/38)0%
(0/38)0%
(0/3365)0%
(0/2630)applets.notifications0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%
   

Re: ddcutil in Plasma Powerdevil

[Sanford Rockowitz]

You might want to look at the launchpad packaging 
(https://launchpad.net/~rockowitz/+archive/ubuntu/ddcutil), which 
includes the library version and development package.  It is at the 
current release level (0.9.7).


If the cmake error is not obvious, let me know what it is.  The locus of 
the problem may jump out at me.


Sanford

On 9/30/19 9:07 AM, Jonathan Riddell wrote:
I put ddcutils package in Neon unstable to be able to test it, using 
Sanford's packaging from Debian but with the libraries turned on.  
However powerdevil doesn't compile with DDCUtils turned on, it fails 
on a cmake error.


Jonathan


On Fri, 27 Sep 2019 at 07:14, Dorian Vogel > wrote:


Hey Jonathan,
Unfortunately I did not test it for a long time (last time was
around 5.15), and don't really have the possibility now because
I'm away from home.
*If I remember correctly,* back then I had a few instances when
the startup of plasma (during the splashscreen) was quite longer
due to retries of the DDC communication (of course this will not
happen if the user does not have ddcutil itself installed). As I
understand it, this is due to the architecture of Powerdevil,
which assumes the monitors are a fixed configuration as far as
brightness is concerned: backends are queried at startup and never
refreshed. This is why enumeration has to happen during startup of
plasma, and one would have to restart powerdevil when connecting a
new DDC capable monitor

Thinking back I wonder if a plasmoid would have been a better way,
enabling to have the enumeration done after startup is finished,
and making it easier to have a "refresh" button, and would still
allow to have both an integrated screen (laptop) and external (for
now the backends in powerdevil are exclusive).

Considering this is my first contribution and I am not sure of the
quality, I think some testing from more experienced devs would be
required. I haven't heard much so far.

Cheers,
*Dorian*

On Thu, Sep 26, 2019 at 11:13 AM Jonathan Riddell mailto:j...@jriddell.org>> wrote:

The DDCUtil features of Powerdevil in KDE Plasma are currently
disabled by default
"DDCUtil library support is disabled by default as recomended
by authors, add -DHAVE_DDCUTIL=On to enable"
This is based on a conversation from 2017 where it was decided
it was unstable.

I see work has continued on DDCUtil and on support for it in
Powerdevil.  Is it ready to be set to on by default?

It is too late for Plasma 5.17 due for release in 2 weeks but
we can tell distros the message is old as appropriate.

Jonathan



-- 
VOGEL Dorian

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 405 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/405/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 25 Sep 2019 14:03:26 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/79)19%
(67/350)19%
(67/350)15%
(4732/32418)12%
(2566/21046)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/355)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/242)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(915/2351)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
(0/3)0%
(0/386)0%
(0/224)kaccess0%
(0/3)0%

D5961: Adoption of KUserFeedback for Discover

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  So this patch adds a semi-hidden menu item on the About page that opens the 
User Feedback KCM in a KCMShell window. I think this needs a better UX:
  
  1. We finally need a real Settings page/window for Discover if we're going to 
be adding more user-configurable settings like this one. The About page isn't 
an appropriate place for this. Maybe we should Change Sources to Settings and 
add it there.
  2. Shouldn't the UI here be Discover-specific? The global KCM doesn't seem 
relevant since it talks about turning on or off telemetry for all KDE apps and 
allows configuring stuff for Plasma specifically. Strictly speaking, Discover 
isn't a part of Plasma. And from a user perspective, Discover is just an app 
among other apps.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5961: Adoption of KUserFeedback for Discover

[Nathaniel Graham]

ngraham added a comment.


  Actually that's fixed by D24010 .

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/163/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 02 Oct 2019 16:02:58 +
 Build duration:
4 min 54 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, that explains why all my tries fail...
  I thought the hint above about looking for kcm_screen in the system was just 
if I have mixed up some stuff, but I always thought if the QT_PLUGIN_PATH is 
properly set like with prefix.sh the local plugins will be prefered.
  Will try at home.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540936 , @cullmann wrote:
  
  > Ok, but given I have a system wide installed kcm anyways, from the distro, 
is there a way to use the own I have in my user local prefix?
  
  
  I could not find a way. I moved aside the `.so` installed by my distro and 
then I could use the locally-compiled one. I thin it's because of the prefix 
paths; `kscreen.so` takes precedence over `kcms/kscreen.so`. So hopefully this 
should be fixed once your distro ships Plasma 5.17 and the distro-provided 
version lives at `kcms/kscreen.so`.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, but given I have a system wide installed kcm anyways, from the distro, is 
there a way to use the own I have in my user local prefix?
  That explains why I am too dumb to try the fractional scaling on Wayland with 
my installed master version, too.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D5961: Adoption of KUserFeedback for Discover

[Nathaniel Graham]

ngraham added a comment.


  Now it fails to build in a different way. :)
  
In file included from 
/home/nate/kde/build/discover/discover/plasmauserfeedback.cpp:30:
/home/nate/kde/build/discover/discover/plasmauserfeedback.moc: In static 
member function ‘static void PlasmaUserFeedback::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**)’:
/home/nate/kde/build/discover/discover/plasmauserfeedback.moc:99:52: error: 
‘class PlasmaUserFeedback’ has no member named ‘FeedbackLevel’; did you mean 
‘feedbackLevel’?
   99 | case 0: *reinterpret_cast< int*>(_v) = _t->FeedbackLevel(); 
break;
  |^
  |feedbackLevel

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  I think the issue you're seeing is related to not having the new KCM 
installed properly, not anything this patch introduced. It's a bit tricky. You 
need to delete the old `kscreen.so` file or else the new one won't show up 
properly.
  
  `OutputPanel.qml` is for the per-display scaling UI that's only used on 
Wayland. `Panel.qml` is the X11-only global scaling UI.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 424 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/424/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 02 Oct 2019 15:35:03 +
 Build duration:
4 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 3812 lines...][2019-10-02T15:38:53.632Z] [ 88%] Linking CXX shared module ../bin/appmenu.so[2019-10-02T15:38:53.892Z] [ 88%] Built target colorcorrectplugin[2019-10-02T15:38:53.892Z] [ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/systemtraytypes.cpp.o[2019-10-02T15:38:53.892Z] [ 88%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsmodel.cpp.o[2019-10-02T15:38:54.151Z] [ 88%] Built target klipper[2019-10-02T15:38:54.151Z] Scanning dependencies of target ksmserver_autogen[2019-10-02T15:38:54.151Z] [ 88%] Automatic MOC for target ksmserver[2019-10-02T15:38:54.151Z] [ 88%] Linking CXX shared module ../../bin/colorcorrectlocationupdater.so[2019-10-02T15:38:54.151Z] [ 88%] Built target ksmserver_autogen[2019-10-02T15:38:54.151Z] [ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifierwatcher_interface.cpp.o[2019-10-02T15:38:54.416Z] [ 88%] Built target appmenu[2019-10-02T15:38:54.416Z] [ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/dbusproperties.cpp.o[2019-10-02T15:38:54.416Z] [ 88%] Built target colorcorrectlocationupdater[2019-10-02T15:38:54.416Z] [ 88%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/windowsystem.cpp.o[2019-10-02T15:38:54.713Z] [ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_interface.cpp.o[2019-10-02T15:38:55.286Z] [ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/debug.cpp.o[2019-10-02T15:38:55.849Z] [ 88%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/debug.cpp.o[2019-10-02T15:38:55.849Z] [ 88%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2019-10-02T15:38:56.104Z] [ 88%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/krunner_interface.cpp.o[2019-10-02T15:38:56.104Z] [ 88%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2019-10-02T15:38:56.104Z] [ 88%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/ksmserver_interface.cpp.o[2019-10-02T15:38:56.360Z] [ 89%] Building CXX object libcolorcorrect/autotests/CMakeFiles/nightcolortest.dir/mock_kwin.cpp.o[2019-10-02T15:38:56.360Z] [ 89%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2019-10-02T15:38:56.616Z] [ 90%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.o[2019-10-02T15:38:56.878Z] [ 90%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[2019-10-02T15:38:56.878Z] [ 90%] Linking CXX shared module ../../bin/plasma_engine_statusnotifieritem.so[2019-10-02T15:38:57.439Z] [ 90%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o[2019-10-02T15:38:57.439Z] [ 90%] Linking CXX executable ../../bin/nightcolortest[2019-10-02T15:38:57.695Z] [ 90%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o[2019-10-02T15:38:57.695Z] [ 90%] Built target plasma_engine_statusnotifieritem[2019-10-02T15:38:57.695Z] [ 90%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o[2019-10-02T15:38:58.266Z] [ 90%] Built target nightcolortest[2019-10-02T15:38:58.266Z] Scanning dependencies of target kcminit_autogen[2019-10-02T15:38:58.266Z] [ 90%] Automatic MOC for target kcminit[2019-10-02T15:38:58.266Z] [ 90%] Built target kcminit_autogen[2019-10-02T15:38:58.266Z] Scanning dependencies of target kcminit_startup_autogen[2019-10-02T15:38:58.266Z] [ 90%] Automatic MOC for target kcminit_startup[2019-10-02T15:38:58.266Z] [ 90%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelview.cpp.o[2019-10-02T15:38:58.266Z] Scanning dependencies of target testChromeBookmarks[2019-10-02T15:38:58.524Z] [ 90%] Built target kcminit_startup_autogen[2019-10-02T15:38:58.524Z] [ 90%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testChromeBookmarks_autogen/mocs_compilation.cpp.o[2019-10-02T15:38:58.524Z] [ 90%] Building CXX object runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testchromebookmarks.cpp.o[2019-10-02T15:38:58.524Z] [ 90%] Linking CXX shared library ../../bin/libkickerplugin.so[2019-10-02T15:38:58.790Z] [ 90%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelconfigview.cpp.o[2019-10-02T15:38:59.048Z] [ 90%] Building CXX object 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/162/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 02 Oct 2019 15:35:03 +
 Build duration:
3 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 3994 lines...][2019-10-02T15:38:34.057Z]^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-02T15:38:34.057Z]  ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:99:47: warning: 'supportedSleepStates' is deprecated [-Wdeprecated-declarations][2019-10-02T15:38:34.057Z] m_valid = Solid::PowerManagement::supportedSleepStates().contains(Solid::PowerManagement::HibernateState);[2019-10-02T15:38:34.057Z]   ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:1: note: 'supportedSleepStates' has been explicitly marked deprecated here[2019-10-02T15:38:34.057Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2019-10-02T15:38:34.057Z] ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-02T15:38:34.057Z]^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-02T15:38:34.057Z]  ^[2019-10-02T15:38:34.057Z] [ 96%] Linking CXX shared module ../../../../bin/ion_bbcukmet.so[2019-10-02T15:38:34.057Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:334:37: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations][2019-10-02T15:38:34.057Z] Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2019-10-02T15:38:34.057Z] ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2019-10-02T15:38:34.057Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-10-02T15:38:34.057Z] ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-02T15:38:34.057Z]^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-02T15:38:34.057Z]  ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/applets/kicker/plugin/systementry.cpp:337:37: warning: 'requestSleep' is deprecated [-Wdeprecated-declarations][2019-10-02T15:38:34.057Z] Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-10-02T15:38:34.057Z] ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:1: note: 'requestSleep' has been explicitly marked deprecated here[2019-10-02T15:38:34.057Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-10-02T15:38:34.057Z] ^[2019-10-02T15:38:34.057Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-02T15:38:34.057Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-02T15:38:34.057Z]

D5961: Adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67200.
apol added a comment.


  Fix build

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=66322=67200

BRANCH
  arcpatch-D5961

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/CMakeLists.txt
  discover/DiscoverObject.cpp
  discover/discover.schema
  discover/plasmauserfeedback.kcfg
  discover/plasmauserfeedback.kcfgc
  discover/qml/AboutPage.qml
  discover/qml/DiscoverWindow.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Or I am maximal confused ;=)
  
  If I compile a master kscreen, have sourced the prefix.sh, shall I see the 
correct stuff in e.g. the kcm_testapp in bin of the kscreen build dir?
  
  If not, I am sorry, could somebody help me out how to test this properly?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Besides, I think you missed half of the code, as for me, I still get a 
different widget here, as for my setup the OutputPanel.qml is used, not 
Panel.qml.
  
  (as I have two displays that can be configured separately)
  
  Could you fix that, independent of the 0.05.. issue?
  I agree that we can do an extra patch for that.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540896 , @cullmann wrote:
  
  > I don't get why we want to introduce artifacts we can very simple avoid by 
using a different base for the steps.
  >  Is 0.0625 really that much worse than 0.05?
  
  
  I'll investigate this in a follow-up patch. My only reservation is that 0.05 
is a much more "round" value to show in the user interface compared to 0.0625. 
I'll see what I can do with it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  I don't get why we want to introduce artifacts we can very simple avoid by 
using a different base for the steps.
  Is 0.0625 really that much worse than 0.05?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:7a9387ed727c: [KCM] Scale more coarsely with the slider, 
but more finely with a spinbox (authored by ngraham).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24321?vs=67195=67198

REVISION DETAIL
  https://phabricator.kde.org/D24321

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/main.qml
  kded/output.cpp

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  master

REPOSITORY
  R104 KScreen

BRANCH
  advanced-scaling-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Roman Gilg]

romangg added a comment.


  In D24321#540871 , @cullmann wrote:
  
  > Hmm, could we perhaps adjust the minimal step to 0,0625.
  >  That is 1/16 and with that, I never get any artifacts with KWrite in 
current master, as it nicely sums up.
  >  Then you don't need to round at all for output.
  
  
  We can think about that in a separate patch. But in general I'm against 
putting much work in the X11 case. Also I believe the issue should be dealt 
with in Qt X11 scaling implementation instead of trying to fix it downstream 
through involved workarounds. The current design by Nate I like in particular 
because it solves the issue I had with the 0.1 steps slider of being too fine 
grained to control nicely. That's the main reason for me supporting the change 
not so much that it circumvents Qt scaling issues on X11.
  
  Having 0.25 steps only on X11 by default is good enough for my liking.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23392: [energy KCM] Add battery Technology

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works perfectly.

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D23392

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  To illustrate that, just try, with master of KTextEditor:
  
  export QT_SCALE_FACTOR=1.125
  
  kwrite with some file => select 100 lines, zoom font in and out => I get no 
artifacts
  
  export QT_SCALE_FACTOR=1.0625
  
  > same
  ==
  
  export QT_SCALE_FACTOR=1.1
  
  > artifacts each X lines
  

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Hmm, could we perhaps adjust the minimal step to 0,0625.
  That is 1/16 and with that, I never get any artifacts with KWrite in current 
master, as it nicely sums up.
  Then you don't need to round at all for output.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham updated this revision to Diff 67195.
ngraham marked an inline comment as done.
ngraham added a comment.


  Address final review comments

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24321?vs=67191=67195

BRANCH
  advanced-scaling-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24321

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/main.qml
  kded/output.cpp

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Last issue: we need to change in `kded/output.cpp` line 363 where it rounds 
on config write to one digit to round to two digits instead:
  
  `info[QStringLiteral("scale")] = int(output->scale() * 100 + 0.5) / 100.;`

INLINE COMMENTS

> OutputPanel.qml:90
> +validator: DoubleValidator {
> +bottom: Math.min(spinbox.from, spinbox.to)*spinbox.factor
> +top:  Math.max(spinbox.from, spinbox.to)*spinbox.factor

whitespace around multiplication, next line as well

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 423 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/423/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 02 Oct 2019 14:12:14 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 2923 lines...][2019-10-02T14:25:10.214Z] Generated  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/libcolorcorrect/kded/colorcorrectlocationupdater.json" [2019-10-02T14:25:10.214Z] [2019-10-02T14:25:10.214Z] [ 70%] Automatic MOC for target colorcorrectlocationupdater[2019-10-02T14:25:10.214Z] [ 70%] Built target colorcorrectlocationupdater_autogen[2019-10-02T14:25:10.214Z] Scanning dependencies of target nightcolortest_autogen[2019-10-02T14:25:10.214Z] [ 70%] Automatic MOC for target nightcolortest[2019-10-02T14:25:10.712Z] [ 70%] Built target nightcolortest_autogen[2019-10-02T14:25:10.712Z] [ 70%] Generating kscreensaversettings.h, kscreensaversettings.cpp[2019-10-02T14:25:10.712Z] [ 70%] Generating screensaver_interface.cpp, screensaver_interface.h[2019-10-02T14:25:10.712Z] [ 70%] Generating screensaver_interface.moc[2019-10-02T14:25:11.210Z] Scanning dependencies of target sessionsprivateplugin[2019-10-02T14:25:11.210Z] [ 70%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin_autogen/mocs_compilation.cpp.o[2019-10-02T14:25:12.864Z] [ 70%] Building CXX object appmenu/CMakeFiles/appmenu.dir/menuimporter.cpp.o[2019-10-02T14:25:12.864Z] [ 70%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsmodel.cpp.o[2019-10-02T14:25:15.964Z] [ 70%] Building CXX object appmenu/CMakeFiles/appmenu.dir/appmenu_dbus.cpp.o[2019-10-02T14:25:16.466Z] [ 71%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.o[2019-10-02T14:25:18.125Z] [ 71%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o[2019-10-02T14:25:19.051Z] [ 71%] Building CXX object appmenu/CMakeFiles/appmenu.dir/verticalmenu.cpp.o[2019-10-02T14:25:20.706Z] [ 71%] Building CXX object appmenu/CMakeFiles/appmenu.dir/menuimporteradaptor.cpp.o[2019-10-02T14:25:21.206Z] [ 71%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o[2019-10-02T14:25:22.862Z] [ 71%] Linking CXX shared library ../../bin/libsessionsprivateplugin.so[2019-10-02T14:25:23.361Z] [ 71%] Built target sessionsprivateplugin[2019-10-02T14:25:23.361Z] [ 71%] Generating krunner_interface.cpp, krunner_interface.h[2019-10-02T14:25:23.361Z] [ 71%] Generating plasmashelladaptor.cpp, plasmashelladaptor.h[2019-10-02T14:25:23.361Z] [ 71%] Generating krunner_interface.moc[2019-10-02T14:25:23.361Z] [ 71%] Generating plasmashelladaptor.moc[2019-10-02T14:25:23.859Z] [ 71%] Building CXX object appmenu/CMakeFiles/appmenu.dir/appmenuadaptor.cpp.o[2019-10-02T14:25:23.859Z] Scanning dependencies of target plasmashell[2019-10-02T14:25:23.859Z] [ 72%] Building CXX object shell/CMakeFiles/plasmashell.dir/plasmashell_autogen/mocs_compilation.cpp.o[2019-10-02T14:25:26.193Z] [ 73%] Linking CXX shared module ../bin/appmenu.so[2019-10-02T14:25:27.239Z] [ 73%] Built target appmenu[2019-10-02T14:25:27.239Z] Scanning dependencies of target klipper_autogen[2019-10-02T14:25:27.239Z] [ 73%] Automatic MOC for target klipper[2019-10-02T14:25:27.239Z] [ 73%] Built target klipper_autogen[2019-10-02T14:25:27.239Z] [ 73%] Generating appadaptor.cpp, appadaptor.h[2019-10-02T14:25:27.239Z] [ 73%] Generating appadaptor.moc[2019-10-02T14:25:27.239Z] [ 73%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[2019-10-02T14:25:27.239Z] Scanning dependencies of target krunner[2019-10-02T14:25:27.239Z] [ 73%] Building CXX object krunner/CMakeFiles/krunner.dir/krunner_autogen/mocs_compilation.cpp.o[2019-10-02T14:25:29.582Z] [ 73%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2019-10-02T14:25:29.582Z] [ 73%] Building CXX object krunner/CMakeFiles/krunner.dir/main.cpp.o[2019-10-02T14:25:32.685Z] [ 73%] Building CXX object krunner/CMakeFiles/krunner.dir/view.cpp.o[2019-10-02T14:25:33.183Z] [ 73%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2019-10-02T14:25:36.285Z] [ 73%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[2019-10-02T14:25:37.331Z] [ 73%] Building CXX object krunner/CMakeFiles/krunner.dir/appadaptor.cpp.o[2019-10-02T14:25:39.673Z] [ 73%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o[2019-10-02T14:25:40.719Z] [ 74%] Linking CXX executable ../bin/krunner[2019-10-02T14:25:41.218Z] [ 74%] Built target krunner[2019-10-02T14:25:41.218Z] [ 74%] Generating shutdown_interface.cpp, shutdown_interface.h[2019-10-02T14:25:41.218Z] [ 74%] Generating ksmserverinterfaceadaptor.cpp, 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 161 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/161/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 02 Oct 2019 14:12:14 +
 Build duration:
3 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 4002 lines...][2019-10-02T14:15:23.381Z] Scanning dependencies of target krunner_kill[2019-10-02T14:15:23.381Z] [ 94%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/krunner_kill_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:23.667Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[2019-10-02T14:15:23.923Z] [ 94%] Linking CXX executable ../../bin/nightcolortest[2019-10-02T14:15:24.182Z] [ 94%] Built target nightcolortest[2019-10-02T14:15:24.182Z] Scanning dependencies of target plasma_engine_weather[2019-10-02T14:15:24.182Z] [ 94%] Linking CXX shared library ../../bin/libsessionsprivateplugin.so[2019-10-02T14:15:24.182Z] [ 94%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/plasma_engine_weather_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:24.182Z] Scanning dependencies of target ion_bbcukmet[2019-10-02T14:15:24.182Z] [ 94%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:24.182Z] [ 94%] Built target sessionsprivateplugin[2019-10-02T14:15:24.182Z] [ 94%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherengine.cpp.o[2019-10-02T14:15:24.439Z] [ 94%] Linking CXX executable ../../../bin/servicerunnertest[2019-10-02T14:15:24.439Z] [ 94%] Built target servicerunnertest[2019-10-02T14:15:24.439Z] [ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[2019-10-02T14:15:24.708Z] Scanning dependencies of target ion_envcan[2019-10-02T14:15:24.708Z] [ 95%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcan_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:24.708Z] [ 95%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherenginedebug.cpp.o[2019-10-02T14:15:24.970Z] [ 95%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/killrunner.cpp.o[2019-10-02T14:15:25.232Z] [ 95%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmet.cpp.o[2019-10-02T14:15:25.503Z] Scanning dependencies of target ion_noaa[2019-10-02T14:15:25.503Z] [ 95%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaa_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:25.503Z] [ 95%] Building CXX object dataengines/weather/ions/envcan/CMakeFiles/ion_envcan.dir/ion_envcan.cpp.o[2019-10-02T14:15:25.761Z] [ 95%] Linking CXX shared module ../../bin/plasma_engine_weather.so[2019-10-02T14:15:25.761Z] [ 95%] Building CXX object krunner/CMakeFiles/krunner.dir/appadaptor.cpp.o[2019-10-02T14:15:25.761Z] [ 95%] Built target plasma_engine_weather[2019-10-02T14:15:25.761Z] [ 95%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaa.cpp.o[2019-10-02T14:15:25.761Z] [ 95%] Building CXX object dataengines/weather/ions/noaa/CMakeFiles/ion_noaa.dir/ion_noaadebug.cpp.o[2019-10-02T14:15:26.023Z] Scanning dependencies of target ion_wettercom[2019-10-02T14:15:26.282Z] [ 95%] Building CXX object dataengines/weather/ions/wetter.com/CMakeFiles/ion_wettercom.dir/ion_wettercom_autogen/mocs_compilation.cpp.o[2019-10-02T14:15:26.282Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[2019-10-02T14:15:26.545Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o[2019-10-02T14:15:26.818Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelview.cpp.o[2019-10-02T14:15:27.086Z] [ 95%] Linking CXX shared module ../../bin/krunner_kill.so[2019-10-02T14:15:27.086Z] [ 95%] Built target krunner_kill[2019-10-02T14:15:27.086Z] [ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelconfigview.cpp.o[2019-10-02T14:15:27.343Z] [ 95%] Building CXX object dataengines/weather/ions/wetter.com/CMakeFiles/ion_wettercom.dir/ion_wettercom.cpp.o[2019-10-02T14:15:27.343Z] [ 95%] Building CXX object dataengines/weather/ions/bbcukmet/CMakeFiles/ion_bbcukmet.dir/ion_bbcukmetdebug.cpp.o[2019-10-02T14:15:27.933Z] [ 95%] Linking CXX shared module ../../../../bin/ion_noaa.so[2019-10-02T14:15:27.933Z] /usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.13/shell/currentcontainmentactionsmodel.cpp:226:14: warning: lambda capture 'configDlg' is not used [-Wunused-lambda-capture][2019-10-02T14:15:27.933Z] [configDlg, pluginInstance] () {[2019-10-02T14:15:27.933Z]  ^[2019-10-02T14:15:27.933Z] [ 95%] Built target ion_noaa[2019-10-02T14:15:27.933Z] Scanning dependencies of target ksmserver[2019-10-02T14:15:27.933Z] [ 95%] Building CXX object 

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:15dd744a3ba4: Provide a telemetrics kcm module for Plasma 
(authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24011?vs=67184=67192#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24011?vs=67184=67192

REVISION DETAIL
  https://phabricator.kde.org/D24011

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/feedback/CMakeLists.txt
  kcms/feedback/Messages.sh
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/kcm_feedback.desktop
  kcms/feedback/package/contents/ui/main.qml
  kcms/feedback/package/metadata.desktop
  shell/CMakeLists.txt
  shell/panelcountsource.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Nathaniel Graham]

ngraham updated this revision to Diff 67191.
ngraham added a comment.


  Allow values as low as 0.5 in the spinbox for the Wayland case

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24321?vs=67156=67191

BRANCH
  advanced-scaling-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24321

AFFECTED FILES
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Okay, let's land this now and I'll send a follow-up patch to tweak the UI.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin added a comment.


  Second error is revealed after the first one is fixed:
  
Scanning dependencies of target qqc2desktopstyleplugin
[ 40%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o
[ 60%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin.cpp.o
[ 80%] Building CXX object 
plugin/CMakeFiles/qqc2desktopstyleplugin.dir/kquickstyleitem.cpp.o

/home/minnehanov/dev/kde/fw/qqc2-desktop-style/plugin/kquickstyleitem.cpp:54:10:
 fatal error: ksharedconfig.h: Нет такого файла или каталога
 #include 
  ^
compilation terminated.
  
  `plugin/kquickstyleitem.cpp` includes `ksharedconfig.h` but KConfig was not 
specified as a link dependency for this target. Previously it was found 
transitively via KF5ConfigWidgets I guess? Now without those optional 
dependencies it cannot be built. So KConfig should explicitly be specified as 
another required KF5 dependency, along with Kirigami.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several builsystem errors

[Alexey Min]

alexeymin added a comment.


  First of all, if you try to build qqc2-desktop-style on a system with only 
Qt5 and other Tier 1 frameworks installed, you will get the following cmake 
configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/):
  
OS Kubuntu 18.04 LTS
Custom-built Qt 5.14 in ~/prefix514
Other Tier 1 Frameworks also built and installed in ~/prefix514

The C compiler identification is GNU 7.4.0
The CXX compiler identification is GNU 7.4.0
Check for working C compiler: /usr/bin/cc
Check for working C compiler: /usr/bin/cc -- works
Detecting C compiler ABI info
Detecting C compiler ABI info - done
Detecting C compile features
Detecting C compile features - done
Check for working CXX compiler: /usr/bin/c++
Check for working CXX compiler: /usr/bin/c++ -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Detecting CXX compile features - done
Installing in the same prefix as Qt, adopting their path scheme.
Setting build type to 'Debug' as none was specified.
Looking for __GLIBC__
Looking for __GLIBC__ - found
Performing Test _OFFT_IS_64BIT
Performing Test _OFFT_IS_64BIT - Success
Performing Test HAVE_DATE_TIME
Performing Test HAVE_DATE_TIME - Success
Found KF5Kirigami2: 
/home/minnehanov/prefix514/lib/x86_64-linux-gnu/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake
 (found version "5.63.0") 
Found KF5: success (found suitable version "5.63.0", minimum required is 
"5.62.0") found components: Kirigami2 
Could NOT find KF5IconThemes (missing: KF5IconThemes_DIR)
Could NOT find KF5IconThemes: found neither KF5IconThemesConfig.cmake nor 
kf5iconthemes-config.cmake 
Could NOT find KF5ConfigWidgets (missing: KF5ConfigWidgets_DIR)
Could NOT find KF5ConfigWidgets: found neither KF5ConfigWidgetsConfig.cmake 
nor kf5configwidgets-config.cmake 
Could NOT find KF5 (missing: IconThemes ConfigWidgets) (Required is at 
least version "5.62.0")
Found X11: /usr/include   
Looking for XOpenDisplay in 
/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
Looking for XOpenDisplay in 
/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
Looking for gethostbyname
Looking for gethostbyname - found
Looking for connect
Looking for connect - found
Looking for remove
Looking for remove - found
Looking for shmat
Looking for shmat - found
Looking for IceConnectionNumber in ICE
Looking for IceConnectionNumber in ICE - found
Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") 
The following OPTIONAL packages have been found:

 * Freetype
 * Fontconfig
 * X11
 * Qt5X11Extras (required version >= 5.11.0)
 * PkgConfig

-- The following REQUIRED packages have been found:

 * ECM (required version >= 5.62.0)
 * Qt5Network (required version >= 5.14.0)
 * Qt5Qml (required version >= 5.14.0)
 * Qt5QmlModels (required version >= 5.14.0)
 * Qt5Quick
 * Qt5Gui
 * Qt5Widgets
 * Qt5QuickControls2
 * Qt5 (required version >= 5.11.0)
 * Qt5Core (required version >= 5.11.0)
 * KF5Kirigami2 (required version >= 5.62.0)

-- The following OPTIONAL packages have not been found:

 * KF5IconThemes (required version >= 5.62.0)
 * KF5ConfigWidgets (required version >= 5.62.0)

-- The following REQUIRED packages have not been found:

 * KF5 (required version >= 5.62.0)

CMake Error at 
/home/minnehanov/prefix514/share/cmake-3.15/Modules/FeatureSummary.cmake:457 
(message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.
  
  So, at first cmake says that KF5 is found with Kirigami as required 
dependency, and then next invocation of `find_package` - KF5 is NOT found, with 
optional deps of IconThemes and ConfigWidgets. Optional, but still not found. 
So, to solve that problem, change the second `find_package` invocaition to a 
two separate calls for individual components, not involving KF5 as whole.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart updated this revision to Diff 67189.
mart added a comment.


  - don't raise the icons over the toolbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=67186=67189

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:68
> These strings still need to be re-worded, and possibly collapsed, and 
> possible the whole UI needs to be re-thought. What if I want to submit 
> detailed system information but only basic usage information? Maybe we need 
> two combo boxes, one for system info and one for usage info.

That's not how it's implemented in KUserfeedback.

  enum TelemetryMode {
  NoTelemetry, ///< Transmit no data at all.
  BasicSystemInformation = 0x10, ///< Transmit basic information about 
the system.
  BasicUsageStatistics = 0x20, ///< Transmit basic usage statistics.
  DetailedSystemInformation = 0x30, ///< Transmit detailed system 
information.
  DetailedUsageStatistics = 0x40, ///< Transmit detailed usage 
statistics.
  };

DetailedSystemInformation = BasicUsageStatistics+BasicSystemInformation

And I don't think it's wrong. It's about making it easy for users to choose to 
help us learn about their behaviour.

> ngraham wrote in main.qml:41
> #1 isn't done yet (it still talks about Plasma, not KDE software more 
> generally)

But it's not true, only Plasma components will follow the setting. Only the 
checkbox will be used elsewhere. (hence the old ugly frame).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24363: qqc2-desktop-style: Fix several builsystem errors

[Alexey Min]

alexeymin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexeymin requested review of this revision.

TEST PLAN
  without this patch, try to build with only Qt5 and Tier 1 frameworks 
installed and see it fails

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I would remove the big text block from the form layout, since this makes it 
look off-center. Also it needs a bigger margin below it. See also the following 
inline comments:

INLINE COMMENTS

> main.qml:68
> +modeOptions.append({text: i18n("Detailed System 
> Information"), value: UserFeedback.Provider.DetailedSystemInformation})
> +modeOptions.append({text: i18n("Detailed Usage 
> Information"), value: UserFeedback.Provider.DetailedUsageStatistics})
> +

These strings still need to be re-worded, and possibly collapsed, and possible 
the whole UI needs to be re-thought. What if I want to submit detailed system 
information but only basic usage information? Maybe we need two combo boxes, 
one for system info and one for usage info.

> main.qml:89
> +
> +QQC2.Label {
> +Layout.maximumWidth: root.width * 0.5

This label never shows up for me, no matter which entry is selected in the 
combo box.

> ngraham wrote in main.qml:41
> 1. Since this is no longer just about Plasma, maybe the first sentence should 
> say, "We make software for you".
> 
> 2. Use kuit formatting for newlines: `xi18nc("@info", "Line 1Line 
> 2Line 3etc.");`

#1 isn't done yet (it still talks about Plasma, not KDE software more generally)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart updated this revision to Diff 67186.
mart added a comment.


  - state machine for right order of opacity and visible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=67069=67186

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart updated this revision to Diff 67185.
mart added a comment.


  - edit mode on mouse over when containment in edit mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=67166=67185

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/itemcontainer.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Roman Gilg]

romangg added a comment.


  I like the new approach. On Wayland the value range should start at `0.5` and 
go till `3`.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24011: Provide a telemetrics kcm module for Plasma

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67184.
apol added a comment.


  Better looking margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24011?vs=67130=67184

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24011

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/feedback/CMakeLists.txt
  kcms/feedback/Messages.sh
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h
  kcms/feedback/kcm_feedback.desktop
  kcms/feedback/package/contents/ui/main.qml
  kcms/feedback/package/metadata.desktop
  shell/CMakeLists.txt
  shell/panelcountsource.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Roman Gilg]

romangg added a comment.


  In D24321#540654 , @cullmann wrote:
  
  > I like that UI, too.
  >  For Wayland: Can somebody tell me how I can try there some fractional 
scaling?
  
  
  You are on KScreen master or beta channel? Because the new UI allowing 
fractional scaling is only available there. If you are check that there is only 
one `kcm_kscreen.so` in
  `/usr/lib/x86_64-linux-gnu/qt5/plugins/kcms` but not in 
`/usr/lib/x86_64-linux-gnu/qt5/plugins`.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24361: [Style KCM] Port to new design

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This ports the widget style KCM to use a grid view KCM with live preview 
thumbnails and inline configure button.
  
  - Icon and tool bar settings have been moved into a popup, similar to Icons 
KCM, to leave more room for the rather large thumbnails.
  - Overall cleanup of unused/defunct features and modernized codebase
  - Support for non-Linux is dropped, i.e. it assumes "Breeze" as the default, 
no "native" (e.g. Mac or Windows style) as we want our apps to follow whatever 
other platform they run in, rather than offering this KCM there

TEST PLAN
  F7496756: Screenshot_20191002_135630.png 

  "Advanced" settings
  F7496757: Screenshot_20191002_135647.png 

  Widget preview glows on hover like they used to
  F7496759: Screenshot_20191002_135707.png 

  
  - Applying style works live
  - Applying icon and toolbar settings work live
  - Configuring a style works and updates the preview live once you close the 
style config dialog
  
  Two issues remaining
  
  - Just found I broke the kcminit stuff: "Module "kcm_style" was not found or 
does not actually have a kcminit function"
  - On destruction of the qtcurve style it seems to freeze/deadlock, when you 
close the kcm by clicking "OK" (can't reproduce the backtrace I had but the 
process doesn't quit)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24361

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/Messages.sh
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/EffectSettingsPopup.qml
  kcms/style/package/contents/ui/main.qml
  kcms/style/package/metadata.desktop
  kcms/style/previewitem.cpp
  kcms/style/previewitem.h
  kcms/style/styleconfig.ui
  kcms/style/stylesmodel.cpp
  kcms/style/stylesmodel.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

[Arjen Hiemstra]

ahiemstra added a comment.


  Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says 
`pcap_breakloop()` is unsupported when called from multiple threads. However, 
the actual libpcap documentation states:
  
  > Note also that, in a multi-threaded application, if one thread is blocked 
in pcap_dispatch(), pcap_loop(), pcap_next(3PCAP), or pcap_next_ex(3PCAP), a 
call to pcap_breakloop() in a different thread will not unblock that thread.
  
  Which is a bit different, as it implies (to me) that the loop will still exit 
the next time the thread is woken up from its blocking call. Which is fine, the 
thread will be woken up when the next packet arrives and then exit.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D24359

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24360: Backport ifdefs to fix build with current KF5

[Jonathan Riddell]

jriddell created this revision.
jriddell added a reviewer: mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jriddell requested review of this revision.

REVISION SUMMARY
  Backport ifdefs to fix build with current KF5

TEST PLAN
  build it

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D24360

AFFECTED FILES
  src/windowsystem/windoweffects.cpp
  src/windowsystem/windoweffects.h

To: jriddell, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  See https://bugzilla.opensuse.org/show_bug.cgi?id=1151190 and its dependencies
  for details.

TEST PLAN
  Helper still collects data correctly.

REPOSITORY
  R106 KSysguard

BRANCH
  secteam_fixes

REVISION DETAIL
  https://phabricator.kde.org/D24359

AFFECTED FILES
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24358: SVN_SILENT made messages (.desktop file) - always resolve ours

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  SVN_SILENT made messages (.desktop file) - always resolve ours
  
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  SVN_SILENT made messages (.desktop file) - always resolve ours
  
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  SVN_SILENT made messages (.desktop file) - always resolve ours
  
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  SVN_SILENT made messages (.desktop file) - always resolve ours
  
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  SVN_SILENT made messages (.desktop file) - always resolve ours
  
  In case of conflict in i18n, keep the version of the branch "ours"
  To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  
  networkhelper: Properly lock access to Accumulator::m_data
  
  Since there are different threads accessing it.
  
  Fixes OpenSuse Bug 1152634
  
  networkhelper: Close the pcap instance when stop() is called
  
  This prevents leaking of the pcap instance should start() ever be called
  again after stop().
  
  This fixes most of OpenSuse Bug 1152638
  
  networkhelper: Limit maximum size of incoming packet queue
  
  Should there be so much traffic that the rest of the code cannot keep
  up, there now should be no risk that memory usage will keep growing.
  
  Fixes OpenSuse Bug 1152639
  
  networkhelper: Remove unused m_active member
  
  It was a leftover from when we manually did the loop.
  
  Fixes OpenSuse Bug 1152641
  
  networkhelper: Ensure readlinkat results in a null terminated string
  
  Apparently, readlinkat() will not ensure the result is null terminated,
  so decrease write size by one so the terminating null does not get
  overwritten.
  
  Fixes OpenSuse Bug 1152642
  
  networkhelper: Check for data length before trying to access packet parts
  
  This ensures we actually have packet data with the required length
  instead of just assuming it does.
  
  Fixes OpenSuse Bug 1152644
  
  networkhelper: Do not call pcap_freecode when compilation failed
  
  Since the structure will be empty in that case.
  
  Fixes OpenSuse Bug 1152646
  
  networkhelper: Properly convert IPv6 u8 array to u32
  
  And-ing the parts would result in empty bytes and implcit conversion
  might fail.
  
  Fixes Comment 3 of OpenSuse Bug 1151190

REPOSITORY
  R106 KSysguard

BRANCH
  secteam_fixes

REVISION DETAIL
  https://phabricator.kde.org/D24358

AFFECTED FILES
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/networkplugin.json

To: ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

meven requested review of this revision.
meven added a comment.


  This is now ready to review since KF 5.62 was released.
  I have tested it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart added a comment.


  edit mode on mouse over
  F7495076: vokoscreen-2019-10-02_10-09-54.mp4 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart updated this revision to Diff 67166.
mart added a comment.


  - edit mode on mouse over when containment in edit mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=67071=67166

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/itemcontainer.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  I like that UI, too.
  For Wayland: Can somebody tell me how I can try there some fractional scaling?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart