[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click
https://bugs.kde.org/show_bug.cgi?id=374311 --- Comment #14 from Christoph Feck --- Qt developers say it is fixed in Qt 6. -- You are receiving this mail because: You are the assignee for the bug.
Re: Alternate calendar in plasma - feature request discussion
On 12/08/20 16:23, Wang Gary wrote: An alternate calendar is a feature to allow another calendar system's date name display together with the main calendar's date names. Is the calendaring system needed for China supported in Qt? Please see https://doc.qt.io/qt-5/qcalendar.html#System-enum This class is new as of Qt 5.14, so we couldn't depend on it yet. If the Chinese calendar support needs to be added in Qt, I suggest to contact developers at the Qt development mailing list. BG, Christoph
[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||krzmb...@gmail.com --- Comment #12 from Christoph Feck --- *** Bug 430014 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
Re: Plasma and a bachelor thesis
On 10/16/20 15:26, Ilya Bizyaev wrote: I've had a wild idea of doing a KDE-related engineering project Thank you for your interest in helping the KDE community! If you exclude anything reported to bugs.kde.org (which does not only list bugs, but also has ideas for new features), you could also use these for inspirations: - Brainstorm in KDE Forums: https://forum.kde.org/viewforum.php?f=83 - https://itvision.altervista.org/why.linux.is.not.ready.for.the.desktop.current.html On a more personal note, see https://bugs.kde.org/show_bug.cgi?id=252353 BG, Christoph
[ksysguard] [Bug 424128] libksysguard "make install" fails with ./kdesrc-build
https://bugs.kde.org/show_bug.cgi?id=424128 Christoph Feck changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |NOT A BUG --- Comment #1 from Christoph Feck --- Install as root. The kauth helpers need to be found be the kauth framework, and it expects these at /usr/libexec/kf5/kauth on your system. If you want them in a different location, you will have to change KAUTH_HELPER_INSTALL_DIR, but not only for libksysguard, but your complete system. See https://techbase.kde.org/Development/Tutorials/KAuth/Helper_HowTo -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||oceanodefol...@pm.me --- Comment #8 from Christoph Feck --- *** Bug 42 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
D29081: [QStyle] Make menu titles look less like menu items
cfeck added a comment. Instead of darker, you could use the text color with very small alpha. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29081: [QStyle] Make menu titles look less like menu items
cfeck added a comment. What a small difference that makes such a large difference! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28941: startplasma: Sort environment scripts prior to sourcing
cfeck added a comment. It looks like the submitter doesn't have commit rights. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28941 To: auxym, #plasma, davidedmundson, apol Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25428: Improved support for desktop "Folder View"
cfeck added a comment. Anyone else able to review this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog
cfeck added a comment. See https://bugreports.qt.io/browse/QTBUG-56547 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog
cfeck added a comment. We already lost fractional point sizes when porting from KFontDialog to QFontDialog. Best approach is to add the KFontDialog to the platform plugin (and also the old KColorDialog while you are at it), or upstream our features to Qt. Btw, I set Toolbar font to a "condensed" version, to have more horizontal room for toolbars with text aside icons. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27650: ItemContainer: disconnect signals in destructor
cfeck added a comment. If this is still needed, please commit and clarify the status of the referenced bug. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To: alnikiforov, ngraham, davidedmundson, mart Cc: cfeck, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
Re: breeze-gtk now in invent
On 02/25/20 13:50, Jonathan Riddell wrote: breeze-gtk seems to have moved to invent for development. Looking through the list on invent I don't see any other Plasma projects there. That's cool but it's useful to know when and why moves like this happens as it needs changes to my release scrips and others will get a surprise when they want to make contributions to it. We have https://phabricator.kde.org/T11994 to track those moves, please subscribe there. -- Christoph Feck KDE Release Team
D27380: [GTK Config] Write Font without style name
cfeck added a comment. So... is this all related to bug https://bugs.kde.org/show_bug.cgi?id=378523 ? :/ REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven Cc: cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27383: fix: reset doctor output color before exiting
cfeck added a comment. Since this patch isn't critical, it would make a perfect candidate for your first steps with committing :) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27383: fix: reset doctor output color before exiting
cfeck added a comment. Oh, okey. That was just misleading. I also suggest to ask for commit rights then. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27383: fix: reset doctor output color before exiting
cfeck added a comment. According to https://phabricator.kde.org/R982:8dffcc64d2aec4041129d67809839f136fec080a you have commit rights? REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs
cfeck added a comment. That looks clever. Since CpuInfoBufSize is a static variable, it will remember the last used size and not reallocate again (unless you plug in new CPUs). Is realloc() an option? It should help the case where the library can actually grow the buffer without an alloc/copy/free cycle. REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs
cfeck added a comment. From that bug report: Newer x86_64 kernels, however, allow up to 4096 CPUs, so either the buffer needs to be much bigger, or we should do interleaved /proc/cpuinfo reading and parsing. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
Re: 2 kirigami fixes for a point release
On 02/13/20 08:42, Ben Cooksley wrote: Part of the issue here is that Plasma has been known to add API to Frameworks and then immediately, without any delay, start using it (pretty much always breaking CI in the process) This means that other changes are likely being pushed into Frameworks by Plasma with very little delay as well. Consequently this means stuff is landing in Framework repositories up to the very moment it is released - a release that the next version of Plasma (LTS) then depends on. A better way of approaching this would be to freeze the Frameworks version you are going to require API wise at an earlier point in the Plasma development cycle. This would allow for a full Frameworks release cycle to pass where bugs encountered during the lead up to the Plasma release can be fixed. You can find bugs in new code best if you are actually using it. I doubt that delaying using new API would help much.
D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds
cfeck added a comment. But the timeout isn't used to give apps more time needed to clean up before they confirm the session can be closed? If I understand it correctly, there should be two timeouts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To: ngraham, #vdg, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds
cfeck added a comment. Why is there a timeout at all? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To: ngraham, #vdg, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size
cfeck added inline comments. INLINE COMMENTS > standard_actions_module.cpp:73 > +m_editor->setMinimumWidth(700); > +m_editor->setMinimumHeight(600); > + `setMinimumSize()` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size
cfeck added a comment. Note that a window's minimum size does not include decorations or the panel. I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 screen the buttons are likely hidden behind the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24706: [RFC] Change button style
cfeck added a comment. If application developers need a rotated button, they need to rotate only the contents, not the frame. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
D26271: [Applet]Update layout based on T10470
cfeck added a comment. The radio stream I use (via mpv) shows the interpret and title information for all titles it plays. Also, when mpv plays a local file, ttitle information about the file is added there. I don't use any other media streams, so I cannot comment on the general availability of this additional stream information. REPOSITORY R115 Plasma Audio Volume Applet BRANCH layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D26271 To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)
https://bugs.kde.org/show_bug.cgi?id=369158 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |WORKSFORME --- Comment #8 from Christoph Feck --- Thanks for the updates; changing status. If you see this issue again, please add a comment or reopen the ticket. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update
https://bugs.kde.org/show_bug.cgi?id=375909 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |WORKSFORME --- Comment #7 from Christoph Feck --- Thanks for the update; changing status. -- You are receiving this mail because: You are the assignee for the bug.
D25280: [Baloo KCM] Purge index when disabling indexing
cfeck added a comment. Shouldn't there be a warning message "delete yes/no?" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, davidedmundson Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D21860: Set a font for gtk applications in the fonts kcm
cfeck added a comment. Please make any GTK stuff optional, not required. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: cfeck, davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart
Re: New Plasma Desktop website
On 09/14/19 14:38, Carl Schwan wrote: I finalized the first version of the new plasma-desktop webpage, a preview is available at https://kde.carlschwan.eu/plasma-desktop. There are still two parts missing (p-b-i and privacy) and some possible improvement that I would like to add later. Can I get approval from the Plasma team to land the current state? Nice work! I would remove the first two images, since they don't show anything that isn't already shown in the first Laptop screenshot. They basically only show the Ice wallpaper.
Re: Plasma 5.12.9 LTS
On 09/11/19 19:35, Rik Mills wrote: On 10/09/2019 17:21, Jonathan Riddell wrote: Plasma 5.12.9 LTS is now released https://www.kde.org/announcements/plasma-5.12.9.php Kwin to fails to build with Qt 5.9. Plasma 5.12 should build with 5.9. /effects/screenshot/screenshot.cpp:110:15: error: ‘const class QImage’ has no member named ‘sizeInBytes’ but from qt.io qsizetype QImage::sizeInBytes() const Returns the image data size in bytes. This function was introduced in Qt 5.10. Commit introducing that is 67444e36592e78d46b757a6c72be1d50bdae19e6 [effects/screenshot] Upload data to xpixmap in chunks sizeInBytes() can be emulated with bytesPerLine() * height(). Would it be possible to adopt the convention "tars are announced a few days before the tag/release" used by Frameworks and Applications also for the Plasma packages? This could help to avoid re-tagging in case of compilation errors. -- Christoph Feck KDE Release Team
D23803: [Folder View] Add subtle shadows to icons
cfeck added a comment. Isn't Qt Quick amazing? REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D23803 To: ngraham, hein, #plasma, #vdg, filipf, ndavis Cc: cfeck, ndavis, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23732: [kded] Support fractional output scale
cfeck added a comment. I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23732 To: romangg, #plasma Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar
cfeck added a comment. Could someone test this on Wayland? The fix itself looks trivial, but if it breaks Wayland session, it obviously needs to be changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18920: Fix PCI module
This revision was automatically updated to reflect the committed changes. Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=61562=62955 REVISION DETAIL https://phabricator.kde.org/D18920 AFFECTED FILES Modules/pci/kpci_private.h To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22369: Update and add some device names in PCI module
This revision was automatically updated to reflect the committed changes. Closed by commit R102:ed789f56fc69: Update and add some device names in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22369?vs=61498=62954 REVISION DETAIL https://phabricator.kde.org/D22369 AFFECTED FILES Modules/pci/kpci_private.h To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||marklikesvideogames@gmail.c ||om --- Comment #5 from Christoph Feck --- *** Bug 410236 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
D22728: Provide a link to KInfoCenter
cfeck added a comment. +1 for putting it in the Help menu. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22728 To: ngraham, #plasma, #vdg Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22630: Slow down the busy indicator's rotation speed
cfeck added a comment. Do we need a matching commit in KWidgetsAddons? See https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.
cfeck added a comment. Oh, if the latter syntax also works, then you are right. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.
cfeck added a comment. Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22368: Formatting cleanup in PCI module
This revision was automatically updated to reflect the committed changes. Closed by commit R102:196d4aaa9cf6: Formatting cleanup in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22368?vs=61497=61533 REVISION DETAIL https://phabricator.kde.org/D22368 AFFECTED FILES Modules/pci/kpci.cpp Modules/pci/kpci_private.h To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18920: Fix PCI module
cfeck added inline comments. INLINE COMMENTS > kpci_private.h:48 > > +/* Following structurs MUST BE packed, otherwise variables will be mapped to > + wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are structure or structures? > kpci_private.h:49 > +/* Following structurs MUST BE packed, otherwise variables will be mapped to > + wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are > + more widely adopted, and should be ignored if not supported. seems to REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18920 To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22367: Update mail address in PCI module
This revision was automatically updated to reflect the committed changes. Closed by commit R102:96c18ee3cf63: Update Konrads mail address in PCI module (authored by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22367?vs=61496=61531 REVISION DETAIL https://phabricator.kde.org/D22367 AFFECTED FILES Modules/pci/kpci.cpp Modules/pci/kpci.h Modules/pci/kpci_private.h To: konradr, #plasma, cfeck, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active
This revision was automatically updated to reflect the committed changes. Closed by commit R135:d2a1d1ca9e9e: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active (authored by cfeck). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22252?vs=61102=61246 REVISION DETAIL https://phabricator.kde.org/D22252 AFFECTED FILES src/platformtheme/kdeplatformsystemtrayicon.cpp To: cfeck, #plasma, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active
cfeck created this revision. cfeck added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Qt applications expect that QSystemTrayIcon's default behavior is to show the icon. BUG: 407963 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D22252 AFFECTED FILES src/platformtheme/kdeplatformsystemtrayicon.cpp To: cfeck, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22191: Implement syncing of theme preferences between SDDM and Plasma
cfeck added a comment. See also bug 403953 and bug 408863. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22191 To: filipf, #plasma, ngraham, davidedmundson, #vdg Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18920: Fix and update PCI module
cfeck added a comment. Would it be possible to commit the whitespace changes separately? They hide all the actual changes. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18920 To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19855: Fix bugzilla login page widgets tab order
cfeck added a comment. Is this fixed by https://phabricator.kde.org/D21894 ? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano, sitter, cfeck, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21828: Invert controls direction for process priority slider
cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21828 To: kishoreg, cfeck Cc: cfeck, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21797: do not set a hardcoded minimum size
cfeck added a comment. If the backtrace is filled later, and that would cause the minimumSize to change, then it will automatically get propagated to the window. A wordwrapped label is supposed to adapt to any with _or_ any height, so its minimum size is its minimum with and its minimum height, but that of course cannot accomodate the complete text. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21797: do not set a hardcoded minimum size
cfeck added a comment. I guess sizeHint() from a paged dialog doesn't pick all pages, so the correct way to resolve this issue is to iterate over all pages, compute their sizeHint(), and use the combined size as the minium size, see `QSize::expandedTo()`. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21797: do not set a hardcoded minimum size
cfeck added a comment. I think I now see why we messed with sizes. There are wrapped QLabels in the dialog, and these break minimum size hints. What we generally do to resolve this issue is to use `setMinimumSize(sizeHint())`. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21797: do not set a hardcoded minimum size
cfeck added a comment. What happens if you (instead/also) remove the next line? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21646: re-read color palettes when application color changes
cfeck added a comment. There will be no further 5.15 release. Please set to 5.16 branch (and merge to master when ready). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim
https://bugs.kde.org/show_bug.cgi?id=304696 Christoph Feck changed: What|Removed |Added CC||yst...@posteo.net --- Comment #15 from Christoph Feck --- *** Bug 407681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
D21408: RFC: [Notifications] Better notification number alignment
cfeck added a comment. Just an idea: run "kcharselect", type "circled digit" resp. "circled number". For values <= 20, unicode has pre-rendered glyphs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21134: [Notifications] Tweak paddings
cfeck added inline comments. INLINE COMMENTS > NotificationItem.qml:74 > > -property int headingLeftPadding: 0 > +property int headingLeftPadding: units.smallSpacing > property int headingRightPadding: 0 Does this take into account layouts for RTL languages? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To: ngraham, #vdg, broulik Cc: cfeck, dos, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D20933: Increase buffer for cpuinfo
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. And indeed I didn't mark the bug as a junior job, because incremental parsing the info isn't exactly a quick fix. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D20933 To: tilmank, #plasma, cfeck Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20933: Increase buffer for cpuinfo
cfeck added a comment. The info for each CPU is indeed a bit larger than 1K. Using 64KiB will only be sufficient for 32 CPUs, the rest would be wasted. As the comment indicates, Linux supports up to 4096 CPUs, so the buffer should be much bigger, or (ideally) the code refactored to do incremental parsing of the `/proc/cpuinfo` content. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D20933 To: tilmank, #plasma, cfeck Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux
This revision was automatically updated to reflect the committed changes. Closed by commit R102:10d60170eaa4: Correctly show memory sizes 4 GiB on 32 bit Linux (authored by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20828?vs=56992=57228 REVISION DETAIL https://phabricator.kde.org/D20828 AFFECTED FILES Modules/about-distro/src/Module.cpp To: cfeck, #plasma, davidedmundson Cc: sitter, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux
cfeck created this revision. cfeck added a reviewer: Plasma. cfeck added a project: Plasma. Herald added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY BUG: 406351 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20828 AFFECTED FILES Modules/about-distro/src/Module.cpp To: cfeck, #plasma Cc: sitter, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare
This revision was automatically updated to reflect the committed changes. Closed by commit R103:fb171dff39c7: Fix sorting to use locale-aware comparisons (authored by jen6, committed by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20386?vs=55792=56990#toc REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20386?vs=55792=56990 REVISION DETAIL https://phabricator.kde.org/D20386 AFFECTED FILES treeview.cpp To: jen6, #plasma, cfeck, pino, mlaurent Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[plasmashell] [Bug 383327] Screen not locking on resume from suspend
https://bugs.kde.org/show_bug.cgi?id=383327 Christoph Feck changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from Christoph Feck --- > So, I should be switching to Wayland then? For this bug, yes. Wayland has other regressions, though. -- You are receiving this mail because: You are the assignee for the bug.
[plasmashell] [Bug 383327] Screen not locking on resume from suspend
https://bugs.kde.org/show_bug.cgi?id=383327 --- Comment #8 from Christoph Feck --- > I can't find the relevant bug report Bug 70063 -- You are receiving this mail because: You are the assignee for the bug.
D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare
cfeck added a comment. Are the `toLower()` calls really needed? I would have expected that `localeAwareCompare()` is case insensitive by default. Also, please use `return x` instead of `return (x)`. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D20386 To: jen6, #plasma, cfeck, pino, mlaurent Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19606: [Task Manager] Reorganize and improve presentation of context menu
cfeck added a comment. Hm, is moving "Minimize" one level deeper an UX improvement? Is it worth to create a bug about this issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: cfeck, abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D19019: Verify that model.AppPid is defined
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. It was suggested to change the model (C++ code? where?) instead. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19019 To: serhiyz, #plasma, davidedmundson, cfeck Cc: cfeck, mart, broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D19855: Fix bugzilla login page widgets tab order
cfeck added a comment. QLineEdit has Qt::StrongFocus policy and it is the focus proxy of KPasswordLineEdit. My impression was that KPasswordLineEdit then automatically also had Qt::StrongFocus. Appearantly, the policy is propagated in the other direction, so a correct fix would be to change the focus policy in kwidgetsaddons, see https://cgit.kde.org/kwidgetsaddons.git/tree/src/kpasswordlineedit.cpp#n88 Testing would need to confirm that this doesn't open password dialogs with the password line focussed by default. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano, patrickelectric, sitter, cfeck, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19194: Adjust date string height to match time string with vertical panel
cfeck added inline comments.
INLINE COMMENTS
> Zren wrote in DigitalClock.qml:305
> This is inside a `State { when: plasmoid.formFactor ==
> PlasmaCore.Types.Vertical }`
Could you please clarify? Are changes needed?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19194
To: antnyzilla, #vdg, #plasma, davidedmundson, Zren
Cc: cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni,
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, sebas, apol
D19711: Use brush for painting line edits
cfeck added inline comments. INLINE COMMENTS > oxygenstyle.cpp:3273 > > -const QColor background( palette.color( QPalette::Base ) ); > +const QBrush& background( palette.brush( QPalette::Base ) ); > Why the reference? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D19711 To: mwoehlke Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Powerdevil] [Bug 348529] Turn off screen after lock screen
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #23 from Christoph Feck --- Comment #11 works perfect for me. -- You are receiving this mail because: You are the assignee for the bug.
D18979: foldermodel: store information about screen used
cfeck added a comment. Could a Plasma developer please review? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, sebas, hein Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19036: [notifications] Lift up notification content if one line of body text droops
cfeck added a comment. The status of this says 'Accepted', so developers might not check it. If you want to wait for a developer's review, I suggest to keep the status 'Needs Review'. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma, #vdg, broulik, ngraham, filipf Cc: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D19444: Make long menus optionally scrollable instead of always expanding horizontally
cfeck added inline comments.
INLINE COMMENTS
> breezestyle.cpp:678
> +case SH_Menu_Scrollable:
> +if (StyleConfigData::overflowingMenusMode() ==
> StyleConfigData::OM_SCROLL) {
> +return true;
if (cond) {
return true;
} else {
return false;
}
⇒
return cond ? true : false;
⇒
return cond;
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D19444
To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel,
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D19444: Make long menus scrollable instead of expanding horizontally
cfeck added a comment. What he complains about is that items are unreachable. Yes, it should scroll. Either horizontally or vertically. A scrollbar would be perfect so you see how much you don't see. In addition to multiple columns, if there are 1½ or more. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19444: Make long menus scrollable instead of expanding horizontally
cfeck added a comment. The problem is that adding this property limits to a single column. It should show all columns, and additionally allow the user to scroll. For a menu that only has a few more items than fit in a column this is acceptable, but for the menu in the referenced ticket it is not. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: davidedmundson, mvourlakos, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19444: Make long menus scrollable instead of expanding horizontally
cfeck added a comment. Please not. I use wide menus extensively, e.g. for bookmarks, and are not keen to wait eons to find an item because of the slow scrolling. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox
cfeck added a comment. Disabling is preferred to hiding. If there is a widget, but not enabled, you are eager to learn how to enable it. If you hide it, you won't even know it exists. REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis Cc: cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D19392: shannon entropy to guess monochrome icon
cfeck added inline comments.
INLINE COMMENTS
> desktopicon.cpp:522
> +//don't try for too big images
> +if (img.width() > 256 || m_theme->supportsIconColoring()) {
> +return false;
Did you mean `>= 256`?
> desktopicon.cpp:545
> +if (findIt != m_monochromeHeuristics.constEnd()) {
> +return findIt.value();
> +}
You are caching the result per size, but the initial decision depends on the
actual icon image, right? Is it possible that the first icon examined is
colorful, but the rest is not, or vice versa? If yes, would it make sense to
examine a few icons (maybe three) before a decision is made?
> desktopicon.cpp:551
> +int saturatedPixels = 0;
> +for(int x=0; x +for(int y=0; y desktopicon.cpp:570
> +reverseDist.insertMulti(it.value(), it.key());
> +qreal probability =
> (qreal)it.value()/(qreal)(img.size().width()*img.size().height() -
> transparentPixels);
> +entropy -= probability * log(probability)/log(255);
Please add same spaces between binary operators. Also C++ casts are 'type(val)'
instead of '(type)val'.
> desktopicon.h:108
> QPointer m_networkReply;
> +QHash m_monochromeHeuristics;
> QVariant m_source;
`QHash` is just a `QSet`.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D19392
To: mart, #kirigami
Cc: cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein
D18939: KMenuEdit: add search/filter bar
cfeck added inline comments.
INLINE COMMENTS
> kmenuedit.h:60
> QSplitter *m_splitter = nullptr;
> +KTreeWidgetSearchLine* m_searchLine = nullptr;
>
Surrounding code uses `Type *var`.
> treeview.cpp:1924
> +// expand all categories if we typed more than a few characters,
> otherwise collapse and un-select everything
> +if (searchString.length() > 2) {
> +expandAll();
Maybe use KStringHandler::logicalLength() for CJK users.
REPOSITORY
R103 KMenu Editor
BRANCH
search-bar
REVISION DETAIL
https://phabricator.kde.org/D18939
To: tuxxi, ngraham, #plasma, cfeck
Cc: ognarb, mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18859: cdb: First working version
cfeck added a comment. > This patch introduces support to CDB, providing useful backtraces in bug tickets created through DrKonqi on windows. Just noticed this. This will help a lot to get better crash reports for our Windows ports. Thanks! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: cfeck, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19033: [about-distro] run absolute paths through qicon intead of qpixmap
cfeck added a comment. The comment is confusing. If QIcon does not resolve absolute paths, but I can stil pass absolute paths, the comment could say that it ignores the path? Shouldn't this comment rather be part of the README, instead of the code? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19033 To: sitter, #plasma Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18696: Update `libdbusmenuqt` and the AppMenu plugin
cfeck added a comment. If this fixes bug 401725, please add a line "BUG: 401725" to the commit message. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D18696 To: ntninja, Zren, majohnson Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17784: Don't ignore default virtual devices
cfeck added inline comments.
INLINE COMMENTS
> pulseaudio.cpp:300
> it.next();
> -if (it.value()->isVirtualDevice() || it.value()->state() !=
> state) {
> +if ((it.value()->isVirtualDevice()&& !it.value()->isDefault())
> +|| it.value()->state() != state) {
Missing Space: `) &&`
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D17784
To: sharhalakis, broulik, drosca
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18019: [Digital Clock] Add ability to set a custom date format string
cfeck added a comment. Bug 340982 is about system-wide locale format changes. Qt currently does not have a way to customize its internal CLDR database. This change is indeed only about the Plasma clock, somewhat a workaround for the bug. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: cfeck, ngraham, mart, ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D18005: Include only the largest size for each wallpaper
cfeck added a comment. Maybe symlinking all to the largest version? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma, ndavis Cc: cfeck, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: 5.15 repo freeze
On 03.01.2019 16:26, Jonathan Riddell wrote: Today is repo freeze for the 5.15 release. I'd had no requests for addition or removals from the repos we make tars from so I plan to use the same list as for 5.14. plasma-desktop-5.14.4.1.tar.xz
[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings
https://bugs.kde.org/show_bug.cgi?id=346251 Christoph Feck changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REPORTED|RESOLVED --- Comment #3 from Christoph Feck --- No response, and works for me. -- You are receiving this mail because: You are the assignee for the bug.
[kdeplasma-addons] [Bug 378823] EPOD POTD display header image instead of the real photo
https://bugs.kde.org/show_bug.cgi?id=378823 Christoph Feck changed: What|Removed |Added Component|general |Picture of the Day Product|Plasma Workspace Wallpapers |kdeplasma-addons -- You are receiving this mail because: You are the assignee for the bug.
[kwrited] [Bug 386067] Use seperate notifications for each message
https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #1 from Christoph Feck --- Are messages separated by some fixed text? Otherwise I doubt it is fixable. -- You are receiving this mail because: You are the assignee for the bug.
D17704: Copy to clipboard always copy English texts
cfeck added a comment. Or make the button have a drop-down, see e.g. "Save As..." button in Spectacle. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17704: Copy to clipboard always copy English texts
cfeck added a comment. If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Plasma 5.14.4
On 27.11.2018 18:17, Jonathan Riddell wrote: Plasma 5.14.4 is now released https://www.kde.org/announcements/plasma-5.14.4.php It was suggested to do a 5.14.4.1 respin of 'plasma-desktop' to include a patch for regression bug 401508 (the bug ticket does not mention that it can even crash the shell on clicking a grouped task bar entry). Until that is decided, distributions are asked to apply the linked patch. https://bugs.kde.org/show_bug.cgi?id=401508 Merge commit in branch 'Plasma/5.14': https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.14=9b1f3e7ee80af3c3c09e2752d6c736d56690d53c Actual commit from LTS branch 'Plasma/5.12': https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.14=ed34cc5f181e61d1fc98872866c5d7300a90af86
Re: Conceptual changes to KScreen
On 19.11.2018 11:11, Roman Gilg wrote: D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is therefore at coordinates (3841, 0). Is the single-pixel gap intended, or should that read (3840, 0)?
D16170: [Device Notifier] Restore busy indicator
cfeck added a comment. What is the status of this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6056: [Run Command] Auto-close on focus loss only if query field is empty
cfeck added a comment. Please commit or abandon this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: cfeck, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[ksysguard] [Bug 399637] New: libksysguard fails to build without QtWebEngine
https://bugs.kde.org/show_bug.cgi?id=399637 Bug ID: 399637 Summary: libksysguard fails to build without QtWebEngine Product: ksysguard Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: libksysguard Assignee: plasma-devel@kde.org Reporter: cf...@kde.org Target Milestone: --- STEPS TO REPRODUCE compile libksysguard without installed QtWebEngine devel headers OBSERVED RESULT processui/scripting.cpp:58:27: error: 'QWebEngineUrlRequestInfo' has not been declared Full log: https://build.opensuse.org/package/live_build_log/home:cfeck:branches:KDE:Unstable:Frameworks/libksysguard5/openSUSE_Factory/x86_64 -- You are receiving this mail because: You are the assignee for the bug.
