D27277: Properly search for PipeWire libs

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  Just one thing left to fix before pushing

INLINE COMMENTS

> FindPipeWire.cmake:112
>  INTERFACE_COMPILE_OPTIONS "${PipeWire_DEFINITIONS}"
> -INTERFACE_INCLUDE_DIRECTORIES "${PipeWire_INCLUDE_DIRS}"
> +INTERFACE_INCLUDE_DIRECTORIES "${PipeWire_INCLUDE_DIRS}" 
> "${Spa_INCLUDE_DIRS}"
>  )

INTERFACE_INCLUDE_DIRECTORIES "${PipeWire_INCLUDE_DIRS};${Spa_INCLUDE_DIRS}"

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27277

To: jgrulich, #plasma, cgiboudeaux
Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27277: Properly search for PipeWire libs

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPipeWire.cmake:74
> +pipewire-0.3/pipewire/pipewire.h
> +spa-0.2/spa/param/props.h
> +# Old PipeWire locations

same thing for this one

> FindPipeWire.cmake:80
>  ${PKG_PipeWire_INCLUDE_DIRS}
> +${PKG_Spa_INCLUDE_DIRS}
>  )

${PKG_Spa_INCLUDE_DIRS}
  ${PKG_Spa_INCLUDE_DIRS}/spa-0.2

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27277

To: jgrulich, #plasma
Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27277: Properly search for PipeWire libs

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPipeWire.cmake:73
>  NAMES
> +pipewire-0.3/pipewire/pipewire.h
> +spa-0.2/spa/param/props.h

this would break includes

> FindPipeWire.cmake:76
> +# Old PipeWire locations
>  pipewire/pipewire.h
> +spa/param/props.h

That's still the current way to include it

> FindPipeWire.cmake:79
>  HINTS
>  ${PKG_PipeWire_INCLUDE_DIRS}
> +${PKG_Spa_INCLUDE_DIRS}

Use:

  ${PKG_PipeWire_INCLUDE_DIRS}
  ${PKG_PipeWire_INCLUDE_DIRS}/pipewire-0.3

instead.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27277

To: jgrulich, #plasma
Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content 
debug to zypper (authored by fvogt, committed by cgiboudeaux).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24751?vs=68220=73759

REVISION DETAIL
  https://phabricator.kde.org/D24751

AFFECTED FILES
  src/doc/examples/installdbgsymbols_suse.sh

To: fvogt, lbeltrame, cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25275: Clean up config-X11.h

[Christophe Giboudeaux]

cgiboudeaux closed this revision.

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D25275

To: cgiboudeaux, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25275: Clean up config-X11.h

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Also tested with CMake 3.1 which is the version required by Qt 5.12.

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D25275

To: cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25275: Clean up config-X11.h

[Christophe Giboudeaux]

cgiboudeaux created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cgiboudeaux requested review of this revision.

REVISION SUMMARY
  Khotkeys only requires libX11 and the optional Xtst component.
  
  Report whether the optional Xtst component was found.
  
  Before: -- Found X11: /usr/include
  After: -- Found X11: /usr/include  found components:  Xtst

REPOSITORY
  R101 KHotKeys

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D25275

AFFECTED FILES
  CMakeLists.txt
  config-X11.h.cmake

To: cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25275: Clean up config-X11.h

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Note: this is 2 different commits.

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D25275

To: cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25223: Avoid side effects during menu initialization

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  tested successfully locally. I don't see menus opening on the top left corner 
when running vlc or hp-systray.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24363: Fix several build system errors

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Note: the metainfo file says this framework is tier 3.
  
  The subgroup value looks wrong

INLINE COMMENTS

> CMakeLists.txt:40-41
> +# IconThemes and ConfigWidgets are optional
> +find_package(KF5IconThemes)
> +find_package(KF5ConfigWidgets)
>  

KF5_DEP_VERSION is lost here

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18244: Check for python-cairo

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D18244#394859 , @rikmills wrote:
  
  > This breaks NeonKubuntu builds, whereas previously the builds were working 
as I explicitly had added python3-cairo to the build depends. It is there 
still, but cmake thinks not.
  >
  > EDIT: seems specific to cmake < 3.12 in Bionic. Kubuntu Cosmic/Disco build 
with cmake 3.12 finds python3-cairo, but fails on another issue probably 
related a different recent commit.
  >
  > 
https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull
  >
  > > 02:43:04 -- The following REQUIRED packages have not been found:
  > >  02:43:04 
  > >  02:43:04  * PythonCairo
  > >  02:43:04Required to render assets
  
  
  From the build log:
  
  > 03:42:04 The following NEW packages will be installed:
  > 
  >   [...] libcairo-script-interpreter2{a} libcairo2-dev{a}
  >
  
  python3-cairo isn't installed.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux, zzag
Cc: rikmills, ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  +1

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux
Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> zzag wrote in FindPythonCairo.cmake:6
> Shouldn't it be right after find_package(Python3)?

Correct, or this will be empty with CMake < 3.12

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux
Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPythonCairo.cmake:8
> +# Check for python cairo
> +execute_process(COMMAND ${PYTHON_EXECUTABLE} -c "import cairo"
> +RESULT_VARIABLE PYTHON_CAIRO_RESULT)

FindPython3.cmake doesn't define PYTHON_EXECUTABLE but Python3_EXECUTABLE, you 
need e.g set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}") after line 4.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D17154#392806 , @davidedmundson 
wrote:
  
  > > Are there any strong reasons?
  >
  > It's not installed, so a user can't use it.
  >
  > That means it's only a build tool. As it's a build tool it's very important 
to not get stuff from the host system as it makes things less reproducible.
  
  
  at the very least, it should use XDG_DATA_HOME by default and 
${HOME}/.local/share as a fallback 
(https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:14
>  
> -include(KDEInstallDirs)
> +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0)
> +find_package(Python3 COMPONENTS Interpreter REQUIRED)

This doesn't exist in CMake 2.8.12. Use

  if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

or invert the if/else to avoid the 'NOT'

> FindSass.cmake:1
> +set_package_properties(Sass PROPERTIES
> +  DESCRIPTION "SASS compiler"

Missing doc & license

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

[Christophe Giboudeaux]

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote:
> Hi all,
> 
> Please see below. If someone could please take a look and fix this failure
> that would be appreciated.
> 
> On another note, the Marble build recently broke with a similar error - has
> something been changed in Frameworks to remove a dependency on DBus by any
> chance?
> 
[...]
> CMake Error at lib/CMakeLists.txt:17 (add_library):
> Target "milou" links to target "Qt5::DBus" but the target was not found.
> Perhaps a find_package() call is missing for an IMPORTED target, or an
> ALIAS target is missing?

For the record, this issue was fixed yesterday. 
The problem was a change in kpackage which added Qt5::DBus to the PUBLIC 
interface link.

Milou depends on plasma-framework which depends on kpackage but nothing was 
looking for Qt5DBus.

There are different ways to avoid this kind of build issues:
- add a find_dependency() call to your FooConfig.cmake file when you add a new 
public dependency
- and before that, make sure it's not a 'PRIVATE' link target. This was the 
case here, the commit didn't change the API.

D15442: Improve DDCUtil handling in CMakeLists

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  With the change, you can't tell if powerdevil must use the old or the new 
api. Suggestion: https://paste.kde.org/powk2bhxm
  
  config_powerdevil.h then defines HAVE_DDCUTIL and DDCUTIL_VERSION

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D15442

To: nilathak, broulik, dvogel
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15327: Add appmenu-gtk-module as runtime dependency

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> FindAppMenuGtkModule.cmake:1-6
> +# - Try to find appmenu-gtk2-module and appmenu-gtk3-module
> +# Once done this will define
> +#
> +#  AppMenuGtkModule_FOUND - System has both appmenu-gtk2-module
> +#   and appmenu-gtk3-module
> +

#.rst:

1. FindAppmenuGtkModule
2. --- #
3. Try to find appmenu-gtk2-module and appmenu-gtk3-module.
4. Once done this will define: #
5. ``AppMenuGtkModule_FOUND``
6. System has both appmenu-gtk2-module and appmenu-gtk3-module

#=

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15327

To: broulik, #plasma, sitter, cgiboudeaux
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321234 , @sdepiets wrote:
  
  > Checking that Qt5Core version is initialized
  
  
  Sorry, but the whole change makes no sense, a big -1.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321232 , @sdepiets wrote:
  
  > In D15310#321216 , @cgiboudeaux 
wrote:
  >
  > > In D15310#321210 , 
@davidedmundson wrote:
  > >
  > > > I have this  in my dev setup
  > > >
  > > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  > > >
  > > > If you had the equivalent, would you need this?
  > >
  > >
  > > Agreed, that's an issue with your environment not being set correctly.
  >
  >
  > It does work with PKG_CONFIG_PATH pointing to the custom Qt directory.
  >  However, if the PREFIX is set and works for the rest of the modules, it 
should be able to work without this additional configuration.
  
  
  you set QTDIR, CMAKE_PREFIX_PATH and a couple other environment variables to 
use custom builds, that's exactly the same reasoning. 
  If you don't want to set them, use system locations.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15310#321210 , @davidedmundson 
wrote:
  
  > I have this  in my dev setup
  >
  > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig
  >
  > If you had the equivalent, would you need this?
  
  
  Agreed, that's an issue with your environment not being set correctly.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindQt5PlatformSupport.cmake:72
> +PATH_SUFFIXES
> +QtPlatformSupport/${Qt5Core_VERSION}/
>  )

This CMake module doesn't know Qt5Core_VERSION, this only works for you because 
there's a find_package(Qt5 ...) call before looking for Qt5PlatformSupport

> FindQt5PlatformSupport.cmake:76
> +if (Qt5PlatformSupport_INCLUDE_DIR)
> + set(Qt5PlatformSupport_VERSION ${Qt5Core_VERSION})
> +else()

Same here

> FindQt5ThemeSupport.cmake:73
> +PATH_SUFFIXES
> +QtThemeSupport/${Qt5Core_VERSION}/
>  )

Same here

> FindQt5ThemeSupport.cmake:77
> +if (Qt5ThemeSupport_INCLUDE_DIR)
> + set(Qt5ThemeSupport_VERSION ${Qt5Core_VERSION})
> +else()

Same here

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15310

To: sdepiets, lbeltrame, #plasma, cgiboudeaux
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15228: Export install location for DBUS interfaces via CMake

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15228#320381 , @bruns wrote:
  
  > This did not break the build, but D15229 
 becoming effective before this one.
  
  
  Without commit 36a7e03 
, 
KScreenLockerConfig.cmake contained set(KSCREENLOCKER_DBUS_INTERFACES_DIR ""), 
so yes, the build was broken.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D15228

To: bruns, #plasma, davidedmundson
Cc: cgiboudeaux, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15228: Export install location for DBUS interfaces via CMake

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D15228#319955 , @broulik wrote:
  
  > This breaks plasma-workspace build on CI: 
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/
  
  
  FTR; fixed in master.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D15228

To: bruns, #plasma, davidedmundson
Cc: cgiboudeaux, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Changes to networkmanager-qt - breakage in plasma-workspace

[Christophe Giboudeaux]

Hi,

On vendredi 30 mars 2018 00:21:41 CEST Ben Cooksley wrote:
> Hi Jan,
> 
> It seems that as part of your recent changes to networkmanager-qt to
> increase the dependency to 1.0.0 you've made some other changes which
> mean the appropriate include paths are no longer being provided to
> projects that depend on networkmanager-qt.
> 
> This has the unfortunate effect that plasma-workspace is no longer
> able to build on the CI system.
> 

FTR:

I pushed an emergency fix last night. plasma-nm and plasma-workspace can be 
built without issue.

Christophe

D8858: Fix testWaylandFullscreenShell.

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored 
by cgiboudeaux).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8858?vs=22546=23037#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8858?vs=22546=23037

REVISION DETAIL
  https://phabricator.kde.org/D8858

AFFECTED FILES
  autotests/client/CMakeLists.txt

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8858: Fix testWaylandFullscreenShell.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  ping !

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8858

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8858: Fix testWaylandFullscreenShell.

[Christophe Giboudeaux]

cgiboudeaux updated this revision to Diff 22546.
cgiboudeaux added a comment.


  Add message if the executable wasn't found

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8858?vs=22492=22546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8858

AFFECTED FILES
  autotests/client/CMakeLists.txt

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8858: Fix testWaylandFullscreenShell.

[Christophe Giboudeaux]

cgiboudeaux created this revision.
cgiboudeaux added a reviewer: graesslin.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.

REVISION SUMMARY
  This test needs the weston executable. Skip the test if the program wasn't 
found.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8858

AFFECTED FILES
  autotests/client/CMakeLists.txt

To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

[Powerdevil] [Bug 379740] Build fails with CLang

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=379740

Christophe Giboudeaux <christo...@krop.fr> changed:

   What|Removed |Added

 CC||j...@jriddell.org

--- Comment #1 from Christophe Giboudeaux <christo...@krop.fr> ---
Jonathan, this code is also in the plasma release (and  Kai Uwe Broulik is on
vacation)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 379740] New: Build fails with CLang

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=379740

Bug ID: 379740
   Summary: Build fails with CLang
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: christo...@krop.fr
  Target Milestone: ---

/kde/src/5/powerdevil/kcmodule/global/GeneralPage.cpp:127:111: error: 'changed'
is a protected member of 'KCModule'
connect(pausePlayersCheckBox, ::stateChanged, this,
static_cast(::changed));
   
~~^~~
/kde/inst/5/include/KF5/KConfigWidgets/kcmodule.h:375:10: note: must name
member using the type of the current context 'GeneralPage'
void changed();
 ^

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 117783: Handle QxOrm release and debug mode properly

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117783/#review56612
---



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39475

endif()



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39476

endif()



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39480

if(QxOrm_DEBUG_LIBRARIES or QxOrm_RELEASE_LIBRARIES) is enough and you can 
remove the two if/endif blocks above



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39481

This should be set by FindPackageHandleStandardArgs




cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39477

endif()



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39478

This part assumes that both release  debug libraries were found

I suggest:
if(QxOrm_RELEASE_LIBRARIES)
  set(QxOrm_LIBRARIES ${QxOrm_RELEASE_LIBRARIES})
elseif(QxOrm_DEBUG_LIBRARIES)
  set(QxOrm_LIBRARIES ${QxOrm_DEBUG_LIBRARIES})
endif()




cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39479

endif()


- Christophe Giboudeaux


On April 26, 2014, 11:57 a.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117783/
 ---
 
 (Updated April 26, 2014, 11:57 a.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode 
 links fine. As suggested by QxOrm devs
 
 
 Diffs
 -
 
   cmake/FindQxOrm.cmake 37c0799 
   libs/mediacenter/CMakeLists.txt 51f657a 
 
 Diff: https://git.reviewboard.kde.org/r/117783/diff/
 
 
 Testing
 ---
 
 1) We are building in Release mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 2) We are building in Debug mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 All pass
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117783: Handle QxOrm release and debug mode properly

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117783/#review56617
---



cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39483

copy paste is bad :)



libs/mediacenter/CMakeLists.txt
https://git.reviewboard.kde.org/r/117783/#comment39484

That's now one or another


- Christophe Giboudeaux


On April 26, 2014, 1:11 p.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117783/
 ---
 
 (Updated April 26, 2014, 1:11 p.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode 
 links fine. As suggested by QxOrm devs
 
 
 Diffs
 -
 
   cmake/FindQxOrm.cmake 37c0799 
   libs/mediacenter/CMakeLists.txt 51f657a 
 
 Diff: https://git.reviewboard.kde.org/r/117783/diff/
 
 
 Testing
 ---
 
 1) We are building in Release mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 2) We are building in Debug mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 All pass
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117783: Handle QxOrm release and debug mode properly

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117783/#review56625
---

Ship it!


Ship It!


cmake/FindQxOrm.cmake
https://git.reviewboard.kde.org/r/117783/#comment39494

s/have/has


- Christophe Giboudeaux


On April 26, 2014, 1:41 p.m., Bhushan Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117783/
 ---
 
 (Updated April 26, 2014, 1:41 p.m.)
 
 
 Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith 
 Haridasan.
 
 
 Repository: plasma-mediacenter
 
 
 Description
 ---
 
 Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode 
 links fine. As suggested by QxOrm devs
 
 
 Diffs
 -
 
   cmake/FindQxOrm.cmake 37c0799 
   libs/mediacenter/CMakeLists.txt 51f657a 
 
 Diff: https://git.reviewboard.kde.org/r/117783/diff/
 
 
 Testing
 ---
 
 1) We are building in Release mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 2) We are building in Debug mode
  - QxOrm is in release mode
  - QxOrm is in debug mode
  - Both release and debug version of QxOrm is available
 
 All pass
 
 
 Thanks,
 
 Bhushan Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel