D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
lukas added inline comments. INLINE COMMENTS > ltoscano wrote in autostart.cpp:75 > Should this be "Session" or "Plasma Session"? Aren't the settings changed > here valid for all desktops which follow the XDG spec? Yes, it should be valid for all DEs (I'd vote for "Session" only then) > emailclientconfig_ui.ui:12 > > - Kmail is the standard Mail program for the KDE > desktop. > + Kmail is the standard Mail program for the Plasma > desktop. > I'd keep the old one as well, just for a better discoverability > ltoscano wrote in globalpaths.cpp:127 > I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. > Did I understand it correctly? Again, this should be desktop agnostic REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D5976: Remove code to poll the udev events for brightness
lukas added a comment. Works fine for me in general, with 2 caveats: - the brightness change doesn't animate (but afaik that's expected) - when switching back to AC, the brightness isn't restored (stays at the previous "battery" level) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5976 To: bshah, #plasma, broulik Cc: lukas, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D5505: Keep startup notifications launcher-sized when inserting at launcher position.
lukas requested changes to this revision.
lukas added a comment.
This revision now requires changes to proceed.
See the inline comment
INLINE COMMENTS
> main.qml:92
> +property int logicalLauncherCount: {
> +if (plasmoid.configuration.seperateLaunchers) {
> +return launcherCount;
/!\ Evil typo spotted
seperateLaunchers -> separateLaunchers
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5505
To: hein, #plasma, davidedmundson, lukas
Cc: lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Feb. 8, 2017, 12:37 p.m.) Status -- This change has been discarded. Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl
[Powerdevil] [Bug 349226] battery updated not updated after suspend to memory
https://bugs.kde.org/show_bug.cgi?id=349226 --- Comment #3 from Lukáš Tinkl lu...@kde.org --- and libkf5solid? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81489 --- A better option would be to call registerService() with QDBusConnectionInterface::ReplaceExistingService and DBusConnectionInterface::AllowReplacement - Lukáš Tinkl On Čer. 15, 2015, 4:30 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/ --- (Updated Čer. 15, 2015, 4:30 odp.) Review request for Plasma. Repository: plasma-workspace Description --- We're getting lots of reports about notifications not being closeable on click or not having any actions or not having Plasma theme. These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu users installing plasma-desktop), but not only. So this patch makes Plasma always be the Notification service provider if that option is enabled in the applet settings and/or if the applet is present somewhere (otherwise the dataengine is not loaded). On startup, it will get the PID of the current Notifications service, send SIGTERM to it and register its own service. Diffs - dataengines/notifications/notificationsengine.h 7810787 dataengines/notifications/notificationsengine.cpp c3bf373 Diff: https://git.reviewboard.kde.org/r/124102/diff/ Testing --- Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma notifications appear. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81161 --- Ship it! Ship It! - Lukáš Tinkl On Čer. 4, 2015, 1:08 dop., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/ --- (Updated Čer. 4, 2015, 1:08 dop.) Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerdevil Description --- On e.g. platform wayland XRandrBrightness shouldn't do anything. By skipping the initialization the isSupported returns false. Diffs - daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 Diff: https://git.reviewboard.kde.org/r/123999/diff/ Testing --- kded5 no longer crashes when initializing powerdevil when running with platform wayland. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/#review80932 --- Ship it! dataengines/notifications/notificationsengine.cpp (line 157) https://git.reviewboard.kde.org/r/123926/#comment55451 QStringLiteral() ? - Lukáš Tinkl On Kvě. 28, 2015, 5:50 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated Kvě. 28, 2015, 5:50 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123864: Extract messages from Modules/base into the catalog kcminfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123864/#review80667 --- Ship it! Ship It! - Lukáš Tinkl On Kvě. 20, 2015, 5:54 odp., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123864/ --- (Updated Kvě. 20, 2015, 5:54 odp.) Review request for Localization and Translation (l10n) and Plasma. Bugs: 347992 https://bugs.kde.org/show_bug.cgi?id=347992 Repository: kinfocenter Description --- Code from Modules/base is pulled into the library generated in Modules/info (see info/CMakeLists.txt) so we need to do that for the translations as well Patch has to be applied for 5.3 + master and the language catalogs have to be merged as well Diffs - Modules/base/Messages.sh db2becd Modules/info/Messages.sh 2a6e35f Diff: https://git.reviewboard.kde.org/r/123864/diff/ Testing --- Running KInfocenter in locale x-test with translation manually merged from catalog kcm_infobase into catalog kcminfo shows the prevoiusly untranslated string now translated in the GUI Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/#review80637 --- Ship it! Yes, please backport as well - Lukáš Tinkl On Kvě. 19, 2015, 2:02 odp., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/ --- (Updated Kvě. 19, 2015, 2:02 odp.) Review request for Localization and Translation (l10n) and Plasma. Repository: plasma-workspace Description --- Should be applied to Plasma/5.3 as well ? Diffs - dataengines/network/CMakeLists.txt a9b0e29 dataengines/keystate/CMakeLists.txt 589a72b dataengines/rss/CMakeLists.txt 65b5070 dataengines/weather/CMakeLists.txt fda6cc7 Diff: https://git.reviewboard.kde.org/r/123854/diff/ Testing --- Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123807: Fix popup menu items getting stray highlighted
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/#review80582 --- Ship it! Ship It! - Lukáš Tinkl On Kvě. 16, 2015, 12:39 dop., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/ --- (Updated Kvě. 16, 2015, 12:39 dop.) Review request for Plasma, David Edmundson and Hugo Pereira Da Costa. Bugs: 332377 https://bugs.kde.org/show_bug.cgi?id=332377 Repository: oxygen Description --- Make sure we finish the animation before stopping it. Diffs - kstyle/animations/oxygenmenubardata_imp.h fcfe788 Diff: https://git.reviewboard.kde.org/r/123807/diff/ Testing --- Moved the mouse like crazy over the Help menu of konsole and can't get it to be wrong anymore. Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 347712] Backlight settings based on local time
https://bugs.kde.org/show_bug.cgi?id=347712 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Version|5.9.0 |unspecified Component|general |general Assignee|lu...@kde.org |plasma-devel@kde.org Product|frameworks-solid|Powerdevil -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/#review79675 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 29, 2015, 12:40 odp., Emmanuel Pescosta wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123555/ --- (Updated Dub. 29, 2015, 12:40 odp.) Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspace Description --- Fix a crash in PowermanagementEngine::populateApplicationData when the given name is empty. Use QString::section instead of QString::split + QList::last (which requires a non empty list) to prevent the crash. The crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop in this case) IMO: Maybe the PowermanagementEngine should only add inhibitions from applications which have a non empty name?! Diffs - dataengines/powermanagement/powermanagementengine.cpp 2fbf23f Diff: https://git.reviewboard.kde.org/r/123555/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 28, 2015, 1:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit bae60a355524ca6b88d87aed28d7ecb002369777 by Lukáš Tinkl to branch master. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- Review request for Plasma. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On Dub. 27, 2015, 4:56 odp., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. Lukáš Tinkl wrote: I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. Thomas Pfeiffer wrote: By User Account kcm you mean the Password and User Account kcm, right? I think that's okay, as it lets you edit the information that is shown there. If we get lots of bug reports form people accidentally clicking it, we might reconsider. Yup exactly, it lets you edit what is being shown there - the user name and your face/icon. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On Dub. 27, 2015, 7:04 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 7:04 odp.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On Dub. 27, 2015, 4:56 odp., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On Dub. 27, 2015, 4:31 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 4:31 odp.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 7:04 odp.) Review request for Plasma and KDE Usability. Changes --- Fix a problem with the search text field staying visible between menu opens plus some minor coding style issues pointed out by Kai. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs (updated) - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79312 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 21, 2015, 11:18 odp., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated Dub. 21, 2015, 11:18 odp.) Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug.cgi?id=346441 Repository: plasma-workspace Description --- The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery). Diffs - lookandfeel/contents/components/InfoPane.qml 18739ad Diff: https://git.reviewboard.kde.org/r/123459/diff/ Testing --- File Attachments no battery after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png no battery before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123416: Set i18n domain where it was missing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123416/#review79195 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 18, 2015, 6:29 odp., Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123416/ --- (Updated Dub. 18, 2015, 6:29 odp.) Review request for Plasma. Repository: kde-cli-tools Description --- Summarized. Diffs - kdesu/kdesu.cpp 483d805 kioclient/kioclient.cpp 196650b kmimetypefinder/kmimetypefinder.cpp 6091f3d kstart/kstart.cpp 8146774 ktraderclient/ktraderclient.cpp a01fedb Diff: https://git.reviewboard.kde.org/r/123416/diff/ Testing --- Yep. All of them look translated now. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123387: Fix i18n in desktop containment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/#review79076 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 16, 2015, 8:58 odp., Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/ --- (Updated Dub. 16, 2015, 8:58 odp.) Review request for Plasma. Repository: plasma-desktop Description --- This adds 36 messages of which many were translatable before 5.3, but then became untranslatable probably when code bases were unified. Translators can probably get their previous translations either automatically from obsolete messages at the end of the po file or manually from translation memory. Sorry that I noticed this only now. :/ Diffs - containments/desktop/CMakeLists.txt 677a500 containments/desktop/Messages.sh ee467ed Diff: https://git.reviewboard.kde.org/r/123387/diff/ Testing --- Tested extraction locally, did a quick translation update and checked that previously untranslated context menu entries now displayed as translated. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123372/#review78970 --- Ship it! Looks good from me, +1 - Lukáš Tinkl On Dub. 15, 2015, 5:05 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123372/ --- (Updated Dub. 15, 2015, 5:05 odp.) Review request for Plasma. Bugs: 346033 https://bugs.kde.org/show_bug.cgi?id=346033 Repository: plasma-workspace Description --- Currently when there are multiple timezones in teh clock, they affect only the time. This fixes the date in the calendar and tooltip to reflect to current selected timezone. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 0419d71 applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 applets/digital-clock/package/contents/ui/main.qml 1563d51 Diff: https://git.reviewboard.kde.org/r/123372/diff/ Testing --- Added multiple timezones (UTC+-N) and scrolled over, watched calendar switch dates and also watched tooltip properly update after midnight Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KGamma and Plasma
Dne 9.4.2015 v 16:29 David Edmundson napsal(a): A while back I ported kgamma to KF5, which is in a branch somewhere. It's currently being released with applications, which doesn't really make sense as it's a KCM. As far as I can tell the main author is inactive. We have two options: - move kgamma to kde/workspace for Plasma 5.4 - merge the code into plasma-desktop with the other kcms I'm torn as on one hand I don't like having a lot of repos for tiny things on the other gamma adjustment really isn't an essential thing, and I like having a core - extra stuff split. It seems a month ago Lukas ported colord-kde, as I understand it these two do basically the same thing but with competing implementations. So maybe there's a 3rd option of going with that. The main author on that also seems to have been inactive in that repo for a long time. Thoughts? David Well kcmcolord does a slightly different (more complete in a way) thing and, unlike the kwin color correction, works independently from the window manager. Having said that, I'd like to see colord-kde moved into plasma-desktop, together with other kcms and kgamma possibly too, to act as a fallback to it. -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123282: The energy info KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78622 --- Modules/energy/kcm.cpp (line 65) https://git.reviewboard.kde.org/r/123282/#comment53791 No need to make your name translatable :p Modules/energy/package/contents/ui/main.qml (line 97) https://git.reviewboard.kde.org/r/123282/#comment53798 What about multiple batteries? Modules/energy/package/contents/ui/main.qml (line 451) https://git.reviewboard.kde.org/r/123282/#comment53799 Thi could really use some QLocale formatting of the number Modules/energy/wakeupmodel.h (line 64) https://git.reviewboard.kde.org/r/123282/#comment53796 override? (also below) - Lukáš Tinkl On Dub. 7, 2015, 3:37 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/ --- (Updated Dub. 7, 2015, 3:37 odp.) Review request for Plasma. Repository: kinfocenter Description --- I assume everyone knows by now. Diffs - CMakeLists.txt 139a49e Modules/CMakeLists.txt 37a1faf Modules/energy/CMakeLists.txt PRE-CREATION Modules/energy/Messages.sh PRE-CREATION Modules/energy/batterymodel.cpp PRE-CREATION Modules/energy/config-kcm.h.cmake PRE-CREATION Modules/energy/kcm.cpp PRE-CREATION Modules/energy/kcm_energyinfo.desktop PRE-CREATION Modules/energy/package/contents/ui/Graph.qml PRE-CREATION Modules/energy/package/contents/ui/main.qml PRE-CREATION Modules/energy/package/metadata.desktop PRE-CREATION Modules/energy/statisticsprovider.h PRE-CREATION Modules/energy/statisticsprovider.cpp PRE-CREATION Modules/energy/wakeupmodel.h PRE-CREATION Modules/energy/wakeupmodel.cpp PRE-CREATION ToolTips/ktooltipwindow_p.h 0813e6a ToolTips/ktooltipwindow_p.h 0813e6a infocenter.cpp 1ebbf71 kcmcontainer.cpp c76ac65 sidepanel.cpp f30ef4b Diff: https://git.reviewboard.kde.org/r/123282/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78450 --- wallpapers/image/backgroundlistmodel.h (line 93) https://git.reviewboard.kde.org/r/123211/#comment53671 This should be: QStringList wallpapersAwaitingDeletion() const; wallpapers/image/image.cpp (line 802) https://git.reviewboard.kde.org/r/123211/#comment53672 This should be a const reference: const QString wallpaperCandidate - Lukáš Tinkl On Dub. 3, 2015, 6:05 odp., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated Dub. 3, 2015, 6:05 odp.) Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug.cgi?id=338729 Repository: plasma-workspace Description --- This patch is adding a confirmation dialog which is being called before we remove a wallpaper. Diffs - wallpapers/image/backgroundlistmodel.h 01b528d wallpapers/image/backgroundlistmodel.cpp d062650 wallpapers/image/image.h a00e431 wallpapers/image/image.cpp f0c672a wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f wallpapers/image/imagepackage/contents/ui/config.qml 2108082 Diff: https://git.reviewboard.kde.org/r/123211/diff/ Testing --- File Attachments dialog https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png wallpaper remove https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png wallpaper restore https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png 1st_is_removed_2nd_isnt https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123149: execute xrdb in kapplymousetheme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123149/#review78115 --- Doesn't running krdb fix this as well? - Lukáš Tinkl On Bře. 27, 2015, 12:55 odp., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123149/ --- (Updated Bře. 27, 2015, 12:55 odp.) Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- try to fix the cursors at startup bug Diffs - kcms/input/CMakeLists.txt 8031295 kcms/input/kapplymousetheme.cpp ad3db05 Diff: https://git.reviewboard.kde.org/r/123149/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 345533] Crash on resume from suspend
https://bugs.kde.org/show_bug.cgi?id=345533 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO CC||lu...@kde.org --- Comment #1 from Lukáš Tinkl lu...@kde.org --- Can you please install debug symbols to get a more meaningful backtrace? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123131: Port kio_man away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 --- man/kio_man.cpp (line 242) https://git.reviewboard.kde.org/r/123131/#comment53475 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. - Lukáš Tinkl On Bře. 25, 2015, 10:17 odp., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/ --- (Updated Bře. 25, 2015, 10:17 odp.) Review request for KDE Frameworks, Plasma and Martin Koller. Repository: kio-extras Description --- Port kio_man away from kdelibs4support Diffs - CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 Diff: https://git.reviewboard.kde.org/r/123131/diff/ Testing --- man view in kdevelop5 works Not sure about the `KLocale::global()-languageList();` - `QLocale().uiLanguages();` change though so I would like some feedback. Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 309816] Searching for sleep/hibernate shows title PowerDevil
https://bugs.kde.org/show_bug.cgi?id=309816 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/plas ||ma-workspace/32a6a3a8d4bc80 ||f62e62549877efe34fa3b34366 --- Comment #13 from Lukáš Tinkl lu...@kde.org --- Git commit 32a6a3a8d4bc80f62e62549877efe34fa3b34366 by Lukáš Tinkl. Committed on 13/03/2015 at 10:15. Pushed by lukas into branch 'master'. rename the visible name to Power fixes 309816 - Searching for sleep/hibernate shows title PowerDevil M +1-73 runners/powerdevil/plasma-runner-powerdevil.desktop http://commits.kde.org/plasma-workspace/32a6a3a8d4bc80f62e62549877efe34fa3b34366 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77349 --- Ship it! Ship It! - Lukáš Tinkl On Bře. 11, 2015, 8:03 odp., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated Bře. 11, 2015, 8:03 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122899: Set directory mimetype for smb protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/#review77284 --- Ship it! smb/kio_smb_browse.cpp https://git.reviewboard.kde.org/r/122899/#comment53075 Correct indentation? - Lukáš Tinkl On Bře. 10, 2015, 11:18 odp., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated Bře. 10, 2015, 11:18 odp.) Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344858] External monitor not recognized if plugged while compiter is suspended
https://bugs.kde.org/show_bug.cgi?id=344858 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Assignee|plasma-devel@kde.org|dvra...@redhat.com CC||lu...@kde.org -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation
https://bugs.kde.org/show_bug.cgi?id=344355 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kio- ||extras/d50a54f861f80f78d85f ||8fdefb6959f6c44828d3 Status|CONFIRMED |RESOLVED --- Comment #4 from Lukáš Tinkl lu...@kde.org --- Git commit d50a54f861f80f78d85f8fdefb6959f6c44828d3 by Lukáš Tinkl. Committed on 02/03/2015 at 08:38. Pushed by lukas into branch 'master'. unbreak thumbnail plguin loading M +2-1thumbnail/thumbnail.cpp http://commits.kde.org/kio-extras/d50a54f861f80f78d85f8fdefb6959f6c44828d3 -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|WAITINGFORINFO |--- CC||mgraess...@kde.org Ever confirmed|0 |1 Status|NEEDSINFO |CONFIRMED --- Comment #14 from Lukáš Tinkl lu...@kde.org --- Adding Martin G. to CC -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review76740 --- Ship it! +1 from me - Lukáš Tinkl On Úno. 11, 2015, 3:51 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Úno. 11, 2015, 3:51 odp.) Review request for Plasma. Repository: plasma-desktop Description --- The current time setting helper is incredibly broken. It manually tries to run a range of NTP utilities, all of which are deprecated. We can just call timedated directly and cut out the middleman as it has uses polkit anyway. This is currently an optional dependency, and the original helper still exists. It makes the code messy, but we have users to support for now. Finding timedated is an cmake option rather than querying for systemd libs to make it easier for those deploying shims, such as BSD. (code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism) Diffs - kcms/dateandtime/CMakeLists.txt 4a987ae kcms/dateandtime/dateandtime.ui c073b5e kcms/dateandtime/dtime.h 1a90698 kcms/dateandtime/dtime.cpp 482e483 kcms/dateandtime/main.h c1e5234 kcms/dateandtime/main.cpp 0041a9d kcms/dateandtime/timedated1.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122400/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #12 from Lukáš Tinkl lu...@kde.org --- Hmm, that could indeed be the problem. polkit-kde-authentication-agent-1 is started by the session which is always after kded modules (powerdevil being one)... I wonder what happens when you restart kded (and hence powerdevil's kded module) after the session has been up and running (just killall -9 kded5 kded5) and then restart plasmashell (kquitapp5 plasmashell plasmashell) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO --- Comment #9 from Lukáš Tinkl lu...@kde.org --- Do you have polkit-kde-authentication-agent-1 running? That would grant you the privs -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122717: Improve tooltip layouting
On Úno. 26, 2015, 11:10 odp., Kai Uwe Broulik wrote: I'm now getting most of my headlines elided or wrapped: K-\n Menü 99%. Wird\n geladen (battery) Aktualisierung... (updater) KM... (rather than KMail) Volume at\n 45% (kmix) Donnerst... (rather than Donnerstag, digitalclock) Yup, seeing the same here: http://developer.kde.org/~lukas/screenshots/tooltip.png - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76692 --- On Úno. 26, 2015, 4:46 odp., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Úno. 26, 2015, 4:46 odp.) Review request for Plasma. Repository: plasma-framework Description --- Improve tooltip layouting This patch ports the default tooltip away from custom spacing, positioning and Row/Column to QtQuick.Layouts. It makes the sizing more predictable, and the code more modern and readable. Tooltips feel to behave a bit smoother with this patch. In the process, this... - fixes spacing when no icon or image is set - limits the maximum height of the subtext to 8 lines (this prevents the klipper tooltip for example from growing super-high) - Makes the icon on the LHS proportional to the text - Limits the width a bit more to prevent super-wide tooltips - makes it use units.gridUnit throughout Changelog: Improve tooltip layout This is the more radical approach to https://git.reviewboard.kde.org/r/122715/ Diffs - src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae Diff: https://git.reviewboard.kde.org/r/122717/diff/ Testing --- Tested all applets' tooltips in the default panel File Attachments launcher (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png pager (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png kdeconnect (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png clock (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png new-kickoff.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png new-pager.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png new-kdeconnect.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png new-clock.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
Dne 21.2.2015 v 17:56 Sebastian Kügler napsal(a): * Application Color Scheme KCM has [ ] Apply colors to non-KDE4 applications This is what krdb obeys and it basically applies color schemes and/or themes to gtk apps. Or was just the wording the problem? -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd
https://bugs.kde.org/show_bug.cgi?id=344456
--- Comment #3 from Lukáš Tinkl lu...@kde.org ---
Are you really sure there's no login1 service on DBUS? It may not be visible
but it's activated on first usage.
The code responsible for querying the suspend/hibernate capabilities first
tries with login1 and only if that's not available, falls back to upower. It
not only checks whether the method is available (CanSuspend) but also whether
it's allowed by polkit (SuspendAllowed), see below for the snippet:
if (m_login1Interface) {
QDBusPendingReplyQString canSuspend =
m_login1Interface.data()-asyncCall(CanSuspend);
canSuspend.waitForFinished();
if (canSuspend.isValid() (canSuspend.value() == yes ||
canSuspend.value() == challenge))
supported |= ToRam;
QDBusPendingReplyQString canHibernate =
m_login1Interface.data()-asyncCall(CanHibernate);
canHibernate.waitForFinished();
if (canHibernate.isValid() (canHibernate.value() == yes ||
canHibernate.value() == challenge))
supported |= ToDisk;
QDBusPendingReplyQString canHybridSleep =
m_login1Interface.data()-asyncCall(CanHybridSleep);
canHybridSleep.waitForFinished();
if (canHybridSleep.isValid() (canHybridSleep.value() == yes ||
canHybridSleep.value() == challenge))
supported |= HybridSuspend;
} else {
if (m_upowerInterface-canSuspend()
m_upowerInterface-SuspendAllowed()) {
qCDebug(POWERDEVIL) Can suspend;
supported |= ToRam;
}
if (m_upowerInterface-canHibernate()
m_upowerInterface-HibernateAllowed()) {
qCDebug(POWERDEVIL) Can hibernate;
supported |= ToDisk;
}
}
--
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation
https://bugs.kde.org/show_bug.cgi?id=344355 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED CC||lu...@kde.org --- Comment #1 from Lukáš Tinkl lu...@kde.org --- Confirmed, noticed the same recently -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
On Úno. 18, 2015, 12:33 odp., Eike Hein wrote: Ship It! Martin Klapetek wrote: Can i18n strings be removed in stable? Sure, removing is fine, it's like B(I)C rules ;) - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- On Úno. 18, 2015, 12:25 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Úno. 18, 2015, 12:25 odp.) Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76235 --- definitely +1 from me - Lukáš Tinkl On Úno. 18, 2015, 1:52 odp., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/ --- (Updated Úno. 18, 2015, 1:52 odp.) Review request for Plasma. Repository: plasma-workspace Description --- The service used so far is broken (doesn't resolve latitude and longitude). Which means we need to switch the service to unbreak. This change implements support for the Mozilla Location Service [1]. Advantages are: * free * open * supports wifi based locationing * provided by our FLOSS friends [1] https://location.services.mozilla.com/ Diffs - dataengines/geolocation/location_ip.cpp 1be2acd9478fceafa83896c552e7a3177368b194 Diff: https://git.reviewboard.kde.org/r/122628/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122603: Adjust to PowerDevil api change
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/#review76179 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 17, 2015, 1:07 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122603/ --- (Updated Úno. 17, 2015, 1:07 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Adjusts powermanagement dataengine to DBus API change in powerdevil Diffs - dataengines/powermanagement/powermanagementengine.cpp 9828ace dataengines/powermanagement/powermanagementjob.cpp 633d832 Diff: https://git.reviewboard.kde.org/r/122603/diff/ Testing --- Works, requires no adjustment in users of the data engine Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76178 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 17, 2015, 1:06 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Úno. 17, 2015, 1:06 odp.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122592: Align digital clock to full minutes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76128 --- Does this still work as intended even when seconds are shown? - Lukáš Tinkl On Úno. 16, 2015, 3:24 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- (Updated Úno. 16, 2015, 3:24 odp.) Review request for Plasma and Martin Klapetek. Bugs: 343872 https://bugs.kde.org/show_bug.cgi?id=343872 Repository: plasma-workspace Description --- This aligns the digital clock to full minutes so it's no longer off by up to 30 seconds, and it allows us to increase the polling interval to 60s. Diffs - applets/digital-clock/package/contents/ui/main.qml 4cc83e8 Diff: https://git.reviewboard.kde.org/r/122592/diff/ Testing --- Compared with xclock, plasmoid is now within 1/2 seconds of the full minute This patch would require us to bump the plasma-framework dependency to 5.8 Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Merging KCM Touchpad
Dne 12.2.2015 v 23:07 Marco Martin napsal(a): On Thursday 12 February 2015, David Edmundson wrote: I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise testing before the 5.3 release. Any objections to me merging into plasma-desktop with the other KCMs? I don't think there's a reason to keep it in a separate repo now it's ready for usage. I'll filter branch to keep the history. ktouchpadenabler will then be dropped as this provides the same feature only more configurable and with future proofed with libinput support. if it's only a kcm without other stuff like daemons, +1 from here It also has a kded module which is surprisingly linked together with the kcm -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/#review75776 --- ksmserver/screenlocker/logind.cpp https://git.reviewboard.kde.org/r/122510/#comment52347 Just FYI, an easier way to do this is: msg idle; - Lukáš Tinkl On Úno. 10, 2015, 1:34 odp., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/ --- (Updated Úno. 10, 2015, 1:34 odp.) Review request for Plasma. Bugs: 271731 https://bugs.kde.org/show_bug.cgi?id=271731 Repository: plasma-workspace Description --- See the idle recommendations on [1]. Binding it to the lock screen does not exactly match the recommendation, but it has some advantages: * we know it's idle when it's locked * it kicks in after the user's configured idle timeout * if the user unlocks we know it's no longer idle FEATURE: 271731 FIXED-IN: 5.3.0 [1] http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/ Diffs - ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 Diff: https://git.reviewboard.kde.org/r/122510/diff/ Testing --- Run the test application and verified using loginctl from tty1 while the screen was locked and after unlocked. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Úno. 9, 2015, 2:40 dop., Lukáš Tinkl wrote: src/declarativeimports/calendar/qml/MonthView.qml, line 61 https://git.reviewboard.kde.org/r/122488/diff/1/?file=347954#file347954line61 I know this is not your code but still... we must absolutely not make any asumptions about how the strings should be rendered. In some languages it's just plain wrong to display month names capitalized. For the rationale: http://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names Most languages DO NOT capitalize month names - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75650 --- On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Úno. 8, 2015, 9:52 odp.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75650 --- src/declarativeimports/calendar/daysmodel.cpp https://git.reviewboard.kde.org/r/122488/#comment52307 You should override roleNames() instead src/declarativeimports/calendar/qml/DaysCalendar.qml https://git.reviewboard.kde.org/r/122488/#comment52308 I know this is nitpicking but... how is an arrow pointing to the left implemented as previous() meant to work for RTL languages? :) src/declarativeimports/calendar/qml/MonthView.qml https://git.reviewboard.kde.org/r/122488/#comment52309 I know this is not your code but still... we must absolutely not make any asumptions about how the strings should be rendered. In some languages it's just plain wrong to display month names capitalized. - Lukáš Tinkl On Úno. 8, 2015, 9:52 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Úno. 8, 2015, 9:52 odp.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.cpp a766acb src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h ec88837 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db src/declarativeimports/calendar/calendar.h ea20bf5 Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 10:40 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
On Úno. 6, 2015, 11:21 dop., Martin Gräßlin wrote: ksmserver/screenlocker/globalaccel.cpp, line 52 https://git.reviewboard.kde.org/r/122451/diff/1/?file=347187#file347187line52 isn't this missing QListQString or is C++11 even smarter than I expected? It's that smart ;) I was expecting a QStringList instead of QListQString, but either is really not necessary with modern compilers. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75518 --- On Úno. 6, 2015, 11:04 dop., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Úno. 6, 2015, 11:04 dop.) Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122387: Fix hardware shutdown button doing nothing on desktops
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122387/#review75224 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 2, 2015, 5:33 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122387/ --- (Updated Úno. 2, 2015, 5:33 odp.) Review request for Plasma and Solid. Repository: powerdevil Description --- Fix hardware shutdown button doing nothing on desktops Diffs - daemon/actions/bundled/handlebuttonevents.cpp ac280f4 Diff: https://git.reviewboard.kde.org/r/122387/diff/ Testing --- Patched desktop machine. Power button showed logout prompt. System settings - PowerManagement still looked sensible Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/#review75000 --- Ship it! Ship It! - Lukáš Tinkl On Led. 29, 2015, 8:48 odp., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/ --- (Updated Led. 29, 2015, 8:48 odp.) Review request for Plasma. Repository: kwrited Description --- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn't expose utempter presence Diffs - CMakeLists.txt 8c29e1b Diff: https://git.reviewboard.kde.org/r/122315/diff/ Testing --- working Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122319/#review75010 --- Ship it! Ship It! - Lukáš Tinkl On Led. 29, 2015, 11:56 odp., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122319/ --- (Updated Led. 29, 2015, 11:56 odp.) Review request for Plasma, Alexander Mezin and Jonathan Riddell. Bugs: 342629 http://bugs.kde.org/show_bug.cgi?id=342629 Repository: kcm-touchpad Description --- Set global shortcuts for touchpad enable/disable/toggle. Review and comments welcome. Bug 342629 Diffs - src/kded/kdedactions.cpp ca32834 Diff: https://git.reviewboard.kde.org/r/122319/diff/ Testing --- Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are set. Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle
On Led. 30, 2015, 12:07 dop., Lukáš Tinkl wrote: Ship It! Rajeesh K Nambiar wrote: That was quick! :-) I don't have commit access - could you commit please? Sure; why not ask for an account then? :) - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122319/#review75010 --- On Led. 29, 2015, 11:56 odp., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122319/ --- (Updated Led. 29, 2015, 11:56 odp.) Review request for Plasma, Alexander Mezin and Jonathan Riddell. Bugs: 342629 http://bugs.kde.org/show_bug.cgi?id=342629 Repository: kcm-touchpad Description --- Set global shortcuts for touchpad enable/disable/toggle. Review and comments welcome. Bug 342629 Diffs - src/kded/kdedactions.cpp ca32834 Diff: https://git.reviewboard.kde.org/r/122319/diff/ Testing --- Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are set. Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122230: Continuously update notification timestamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122230/#review74662 --- Ship it! Ship It! - Lukáš Tinkl On Led. 23, 2015, 9:28 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122230/ --- (Updated Led. 23, 2015, 9:28 odp.) Review request for Plasma. Repository: plasma-workspace Description --- While the popup is opened update the timestamps, especially the first ones (Just now, 10s ago, 30s ago) come in quick succession making it feel weird for them to only update when opening the dialog. Even simplifies the code now. Diffs - applets/notifications/package/contents/ui/NotificationItem.qml c476749 Diff: https://git.reviewboard.kde.org/r/122230/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122044: Show cumulative battery percentage on lock screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122044/#review73962 --- Ship it! Ship It! - Lukáš Tinkl On Led. 13, 2015, 9:45 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122044/ --- (Updated Led. 13, 2015, 9:45 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Rather than just picking a random battery, which could be your mouse, it now shows the cumulative battery percentage which is now exposed through the dataengine. Also use AC adapter state for the bolt to be consistent with battery monitor. Diffs - lookandfeel/contents/components/InfoPane.qml 02b5ec9 Diff: https://git.reviewboard.kde.org/r/122044/diff/ Testing --- I only have one battery here but it shows 99% as it is supposed to, plugging in and out the AC changes the bolt's color. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121974/#review73727 --- Ship it! Ship It! - Lukáš Tinkl On Led. 11, 2015, 12:15 dop., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121974/ --- (Updated Led. 11, 2015, 12:15 dop.) Review request for Plasma. Bugs: 342702 http://bugs.kde.org/show_bug.cgi?id=342702 Repository: plasma-framework Description --- This fixes a broken context menu appearing when middle clicking in Plasma popups. That unlabled item is actually the Paste action. The check is taken straight from the containmentinterface. Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp ec96224 Diff: https://git.reviewboard.kde.org/r/121974/diff/ Testing --- Middle clicking system tray popup now gives me a sticky note in my panel :) no more broken context menu. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121973: Proper plural handling for seconds in logout screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121973/#review73728 --- Ship it! Ship It! - Lukáš Tinkl On Led. 10, 2015, 11:32 odp., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121973/ --- (Updated Led. 10, 2015, 11:32 odp.) Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- 1 seconds is even wrong for english ;) Diffs - lookandfeel/contents/components/LogoutScreen.qml 511dac3 Diff: https://git.reviewboard.kde.org/r/121973/diff/ Testing --- It now works Thanks, Albert Astals Cid ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121945: Use i18np for plural units in the jobs applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121945/#review73590 --- Ship it! Ship It! - Lukáš Tinkl On Led. 9, 2015, 2:55 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121945/ --- (Updated Led. 9, 2015, 2:55 odp.) Review request for Plasma. Bugs: 342640 https://bugs.kde.org/show_bug.cgi?id=342640 Repository: plasma-workspace Description --- Yesterday came a bug report about using non-plural i18n for the jobs unit. We need to use plural so that some locales may provide different variations for different numbers. For example Czech has 1 soubor 2 soubory ... 5 soubor? ... Unfortunately this came with the string freeze for 5.2, but I think this would be nice to have for 5.2. I'll ask for an exception (and review). Diffs - applets/notifications/package/contents/ui/JobDetailsItem.qml 8b18356 Diff: https://git.reviewboard.kde.org/r/121945/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/#review73584 --- Ship it! +1 from me - Lukáš Tinkl On Led. 8, 2015, 1:04 odp., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121915/ --- (Updated Led. 8, 2015, 1:04 odp.) Review request for Plasma and Solid. Repository: powerdevil Description --- There's no way to detect when lid has been closed other than listening to `changed` signal org.freedesktop.UPower and then polling the Powerdevil for new values. This patch adds a new signal to the PowerDevil interface to notify about the change and provide new value right away. Makes it much easier to use. Diffs - daemon/org.kde.Solid.PowerManagement.xml 53f77e5 daemon/powerdevilbackendinterface.h 702b66b daemon/powerdevilbackendinterface.cpp 6dd8c71 daemon/powerdevilcore.h e255703 daemon/powerdevilcore.cpp d51ab19 Diff: https://git.reviewboard.kde.org/r/121915/diff/ Testing --- Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened. Thanks, Daniel Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121887: Replace Q_WS_* macros in kglobalaccel/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121887/#review73298 --- Ship it! Ship It! - Lukáš Tinkl On Led. 6, 2015, 8:19 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121887/ --- (Updated Led. 6, 2015, 8:19 odp.) Review request for Plasma. Repository: plasma-workspace Description --- as summary Diffs - kglobalaccel/CMakeLists.txt bdeedaf kglobalaccel/globalshortcutsregistry.cpp af17df2 kglobalaccel/kglobalaccel_mac.cpp 3058e0e kglobalaccel/kglobalaccel_win.cpp 7bd39d7 Diff: https://git.reviewboard.kde.org/r/121887/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73020 --- Ship it! Ship It! - Lukáš Tinkl On Led. 3, 2015, 3:35 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Led. 3, 2015, 3:35 odp.) Review request for Plasma. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121804: Fix wallpapers not showing in activity explorer due to change in plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121804/#review73021 --- Ship it! Ship It! - Lukáš Tinkl On Led. 3, 2015, 2:13 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121804/ --- (Updated Led. 3, 2015, 2:13 odp.) Review request for Plasma and Ivan Čukić. Repository: kactivities Description --- Plasma stores its wallpaper configuration per configuration now [1]. This adjusts kactivities to look for the config in the right place. [1] http://quickgit.kde.org/?p=plasma-framework.gita=commith=c73085f66a83aa8a9fd4307900c0e5aa31358453 Diffs - src/imports/activitymodel.cpp d7946ed Diff: https://git.reviewboard.kde.org/r/121804/diff/ Testing --- Wallpaper and background color in activity manager restored. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121807: Call forceActiveWindow on the sidePanel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121807/#review73019 --- Ship it! Ship It! - Lukáš Tinkl On Led. 3, 2015, 3:39 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121807/ --- (Updated Led. 3, 2015, 3:39 odp.) Review request for Plasma. Repository: plasma-desktop Description --- See Review 121806 Diffs - desktoppackage/contents/views/Desktop.qml c2da3b8 Diff: https://git.reviewboard.kde.org/r/121807/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Black Screen on Login
Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in some debug on shellcorona.cpp:851 before it returns a nullptr in ShellCorona::outputToScreen and see if that gets triggered. You may need to use printf() as plasmashell has this somewhat odd --shutup mode that suppresses all qDebug in an effort to make fixing this as difficult as possible. My theory, is that ::load is not being executed though. Otherwise we'd be seeing things when this happens, instead of just a black screen. I'm back to thinking you're right. load would call addOutput. addOutput would assert if outputToScreen failed. With the exception of being completely 100% wrong, it was a good theory. I appreciate a good theory. 3 I just added a warning that will output something if the GetConfigOperation fails. All those of you who can reproduce it, should rebuild and run again. Maybe we'll see the answer there. Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for plasmashell to show up (because of the notifications it wants to display). Eventually the dbus calls time out, plasmashell start but as there is no config, you just get a black screen. After updating powerdevil, I can no longer reproduce this; kscreen is broken in a different way (doesn't apply the config) but that's another story -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72937 --- shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50770 This fixes the panels dancing around btw :D - Lukáš Tinkl On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
On Led. 2, 2015, 3:25 odp., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Ugh, that's nasty, I wasn't aware of this bug... - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
On Pro. 29, 2014, 2:55 dop., Lukáš Tinkl wrote: Unfortunataly it doesn't fix it here, plasmashell starts with a blank screen. kquitapp5 plasmashell plasmashell brings it back Bhushan Shah wrote: Works for me.. :S which XRandr version you have? David Edmundson wrote: That's depressing to hear. I need some help on this; logs, traces, something as I can't reproduce here and this bug is super duper critical. Do you agree this change still makes sense though? Even if there is another problem it will be easier if there's one potential bug less. Raymond Wooninck wrote: Unfortunately I seem to have hit a worse situation. kquitapp5 plasmashell does not work in my case as it just fails. Killing plasmashell and then starting it just delivers the same situation, a black screen with plasmashell running in the background and that is it. Starting plasmashell shows the following output: kscreen: launcherDataAvailable: org.kde.KScreen.Backend.XRandR kscreen: Launcher finished with exit code 1 , status 0 kscreen: Service for requested backend already running And yes I have a kscreen_backend_launcher process running, which is started by kded5. When I try to kill this one, kded5 is automatically restarting it. To be honest this patch makes things worse as that plasmashell is not starting at all. Raymond Wooninck wrote: Just forgot: raymond@HQVMT44011:~% xrandr --version xrandr program version 1.4.3 Server reports RandR version 1.4 Bhushan Shah wrote: kscreen: launcherDataAvailable: org.kde.KScreen.Backend.XRandR kscreen: Launcher finished with exit code 1 , status 0 kscreen: Service for requested backend already running I had same output but with this patch I am not getting that.. and plasmashell works for me fine. Raymond Wooninck wrote: Ok. I dived a little deeper into the issues that I got (as that reverting the patch didn't help) and it appeared that I had to clean my config files. I deleted all the plasma* files/directories from .config and after this I was able to start plasmashell again. A new problem arose with the kcache files for the plasma theme, which caused plasma freezes. Deleting those made my installation happy and now I can boot normally and plasmashell is starting. Lukas, you might want to give this patch a try with a clean user, to see if it works. However it seems not to resolve the issue completely as that another person indicated that with a new user, he now gets the old issue despite that with his normal user everything works fine. No change, even with a new user. KScreen also routinely forgets my settings and sets the external monitor as a clone (although my setup is an extension to the right side) and unsets the primary display to be empty. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/#review72655 --- On Pro. 28, 2014, 11:33 dop., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Pro. 28, 2014, 11:33 dop.) Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- Ship it! - Lukáš Tinkl On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Pro. 28, 2014, 9:13 odp.) Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
On Pro. 28, 2014, 9:14 odp., Lukáš Tinkl wrote: Oh and, for the record, check the Chassis property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Pro. 28, 2014, 9:13 odp.) Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/#review72622 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 28, 2014, 9:17 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- (Updated Pro. 28, 2014, 9:17 odp.) Review request for Plasma. Repository: plasma-framework Description --- Before the move to QQC we used a Label with opacity 0.5 to gray it out. I suggested using Qt.tint but tinting a black label (in case of a light theme) with semi-transparent black still stays black. Instead I read the documentation and found a little paragraph Oh, by the way, there's r, g, b, a properties on every color. Diffs - src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 Diff: https://git.reviewboard.kde.org/r/121724/diff/ Testing --- Works fine on both light and dark breeze again. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/#review72655 --- Unfortunataly it doesn't fix it here, plasmashell starts with a blank screen. kquitapp5 plasmashell plasmashell brings it back - Lukáš Tinkl On Pro. 28, 2014, 11:33 dop., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Pro. 28, 2014, 11:33 dop.) Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously it didn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121507: Add silent parameter to PM dataengine brightness jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/#review72428 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 14, 2014, 2:05 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121507/ --- (Updated Pro. 14, 2014, 2:05 odp.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a silent argument to the setBrightness jobs in the PM dataengine allowing the caller to suppress the OSD. I will use this in the battery monitor to not show the OSD when the user is actively dragging the slider since confirming an action he/she just did is redundant. It will show it when mouse wheeling the icon, however, to provide feedback there. Diffs - dataengines/powermanagement/powermanagementjob.h 8dd1731 dataengines/powermanagement/powermanagementjob.cpp 24ef2db dataengines/powermanagement/powermanagementservice.operations c9abbf9 Diff: https://git.reviewboard.kde.org/r/121507/diff/ Testing --- Works as expected. Also it seems to be backwards compatible so clients not explicitly setting the silent property won't break but just default to false. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/#review72120 --- The usual nitpick, I'm missing Messages.sh and the catalog loading :) - Lukáš Tinkl On Pro. 16, 2014, 2:25 odp., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/ --- (Updated Pro. 16, 2014, 2:25 odp.) Review request for Plasma. Repository: plasma-workspace Description --- a simple rewrite of the network systemmonitor plasmoid, using the new plotter component from extracomponents Diffs - applets/CMakeLists.txt c4d40ac applets/systemmonitor/contents/config/config.qml PRE-CREATION applets/systemmonitor/contents/config/main.xml PRE-CREATION applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION applets/systemmonitor/contents/ui/net.qml PRE-CREATION applets/systemmonitor/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121554/diff/ Testing --- File Attachments sysmon.png https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review72049 --- Solid:Powermanagement has a signal resumingfromSuspend(), conversely, we could add a backend-independent signal goingToSleep() which ScreenLocker could connect to. - Lukáš Tinkl On Pro. 15, 2014, 11:18 dop., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/ --- (Updated Pro. 15, 2014, 11:18 dop.) Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- [ksld] ScreenLocker inhibits sleep on logind When the system is going to sleep we want to ensure that the screen gets locked before the system goes to sleep. Logind provides the inhibitor locks which can be used for this. If logind is available ksld gains an inhibitor lock for sleep when the screen is unlocked. As soon as the screen gets locked the inhibitor lock is released. In addition it connects to the prepareForSleep signal by logind and locks the screen. The solution needs to be extended to have a config option whether the screen should be locked on sleep. Currently this is provided by powerdevil. Also the solution can only work properly if power devil uses logind's sleep dbus interface. [ksld] Don't block till the greeter is started We only want to ensure that the greeter gets started. There is no need to block for that. Instead we can connect to the error signal and unlock in case the greeter failed to start. - @Alex: what do you think is the best solution for handling the lock screen on resume config option? My idea would be to move it to screen locker and expose the value through DBus, so that powerdevil can still read it. Diffs - ksmserver/screenlocker/CMakeLists.txt 5378a10df2be70cee95b5612c23046eae639f610 ksmserver/screenlocker/autotests/CMakeLists.txt 4bff1c6b1d8fc360197c422f8d036dff3eae5efe ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg a0253d687150702aa4c22200d9f6a577d0cab6be ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 Diff: https://git.reviewboard.kde.org/r/119814/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121533/#review72063
---
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50247
You can just use:
{QKeySequence(Qt::META + Qt::Key_Q)}
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50248
You can use KGlobalAccel::setGlobalShortcut() which sets both the default
and active shortcuts, instead of those 2 lines
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50249
Ha? :)
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50250
const
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50251
const
- Lukáš Tinkl
On Pro. 15, 2014, 4:23 odp., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121533/
---
(Updated Pro. 15, 2014, 4:23 odp.)
Review request for Plasma.
Bugs: 341856
https://bugs.kde.org/show_bug.cgi?id=341856
Repository: plasma-workspace
Description
---
In Plasma 4 plasma-desktop registered global shortcuts for activities
management
Add those actions back
Diffs
-
shell/shellcorona.h 7c25cd4
shell/shellcorona.cpp c416217
Diff: https://git.reviewboard.kde.org/r/121533/diff/
Testing
---
all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine
Thanks,
Bhushan Shah
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121449: Rename Human Input Devices to just Input Devices
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71810 --- +1 And I actually wonder how the thing is translated in other languages because in Czech, I omitted the word Human on purpose as there is no way I could make it meaningful w/o looking like an alien word. - Lukáš Tinkl On Pro. 11, 2014, 3:43 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/ --- (Updated Pro. 11, 2014, 3:43 odp.) Review request for Plasma and KDE Usability. Repository: systemsettings Description --- The Human part feels strange (even though technically correct). Putting just Input devices is stil correct and feels more natural Diffs - categories/settings-hardware-input.desktop ddc3204 Diff: https://git.reviewboard.kde.org/r/121449/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121449: Rename Human Input Devices to just Input Devices
On Pro. 11, 2014, 6:01 odp., Heiko Tietze wrote: Isn't the term HID very common? Human interface device (or input) to distinguish it from network cable, or the like, that are rather for the pets to play with. But I don't stick to the name. Aleix Pol Gonzalez wrote: To me HID is mostly a technical term. As a user, I only expect the input devices the devices I use myself for input. Yes, according to wikipedia, it's http://en.wikipedia.org/wiki/Human_interface_device But here we talk about Human _Input_ Devices, see the confusion? :) - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71816 --- On Pro. 11, 2014, 3:43 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/ --- (Updated Pro. 11, 2014, 3:43 odp.) Review request for Plasma and KDE Usability. Repository: systemsettings Description --- The Human part feels strange (even though technically correct). Putting just Input devices is stil correct and feels more natural Diffs - categories/settings-hardware-input.desktop ddc3204 Diff: https://git.reviewboard.kde.org/r/121449/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71700 --- Did you test the accessibility features? - Lukáš Tinkl On Pro. 10, 2014, 2:44 odp., Toby Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Pro. 10, 2014, 2:44 odp.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- Remove the depencence on KDELibs4Support form KCMAccess Diffs - kcms/access/kaccess.h 716bfcf kcms/access/kaccess.cpp aea6f86 kcms/access/kcmaccess.h d3cb40f kcms/access/kcmaccess.cpp 6c8bc65 kcms/access/main.cpp 09864fc kcms/access/CMakeLists.txt 64b1cc9 Diff: https://git.reviewboard.kde.org/r/121424/diff/ Testing --- I have ran kcmshell5 kcmaccess, did see no problem. Thanks, Toby Chen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120970: Remove combo Graphical Effects
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120970/#review71713 --- I think this change has to be reverted, the setting in question is being used in frameworkintegration to set the level of graphical details to Qt, thru the QPA plugin: m_hints[QPlatformTheme::UiEffects] = cg.readEntry(GraphicEffectsLevel, 0) != 0 ? QPlatformTheme::GeneralUiEffect : 0; - Lukáš Tinkl On Pro. 10, 2014, 3:49 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120970/ --- (Updated Pro. 10, 2014, 3:49 odp.) Review request for Plasma. Repository: plasma-desktop Description --- Remove combo Graphical Effects It set a config value which was exposed in KGlobalSettings::graphicEffectsLevel that is now deprecated. Diffs - kcms/style/finetuning.ui 3abb692 kcms/style/kcmstyle.cpp 6585ee6 Diff: https://git.reviewboard.kde.org/r/120970/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121419: Improve Capslock Enabled warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/#review71679 --- +1 from me - Lukáš Tinkl On Pro. 9, 2014, 11:15 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/ --- (Updated Pro. 9, 2014, 11:15 odp.) Review request for Plasma and Daniel Vrátil. Repository: plasma-workspace Description --- Don't use a separate label which causes the layout to shift but just use the notification label and prepend the warning to any actual message. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 Diff: https://git.reviewboard.kde.org/r/121419/diff/ Testing --- Yup. Looks better imho. File Attachments Just the warning https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/ff5b6404-f55a-4e72-afd3-1348f2e12258__capslockwarning1.png Warning with failed unlock https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/f29104c3-3b76-4508-b9be-3fad2a3d7baa__capslockwarning2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stress testing KWin's screen handling
Dne 27.11.2014 v 12:46 Aleix Pol napsal(a): On Thu, Nov 27, 2014 at 9:03 AM, Martin Gräßlin mgraess...@kde.org mailto:mgraess...@kde.org wrote: Martin GräßlinOn Tuesday 25 November 2014 13:17:28 wrote: Hi all, I hope that it doesn't fail for others and we can get the changes in to improve the situation. Given the overall positive feedback I just decided to push the change to master. Please continue to test and best report bugs :-) Thanks! I'm quite happy so far, it feels much better than KDE4's KWin. Aleix Indeed, thanks a lot! Together with dvratil's changes in kscreen, works like a charm :) -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121152: Provide async API for QmlObject
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/#review70530 --- src/kdeclarative/qmlobject.h https://git.reviewboard.kde.org/r/121152/#comment49348 No API doc - Lukáš Tinkl On Lis. 17, 2014, 5:39 odp., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/ --- (Updated Lis. 17, 2014, 5:39 odp.) Review request for Plasma. Repository: kdeclarative Description --- Introduces a method called ::delayedCompleteInitialization that will trigger the initialization then notify when it's done. Includes David's RR (https://git.reviewboard.kde.org/r/121113/) because of limitations in reviewboard. Diffs - src/kdeclarative/qmlobject.h cd748294e4933c30c8c0afbb91d4375a418b0510 src/kdeclarative/qmlobject.cpp 029edaffa8af5ef143be3cabe33c49ee375ab1a6 Diff: https://git.reviewboard.kde.org/r/121152/diff/ Testing --- See https://git.reviewboard.kde.org/r/121148/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
On Lis. 14, 2014, 6:27 odp., Martin Klapetek wrote: AuthDialog.cpp, lines 75-76 https://git.reviewboard.kde.org/r/121121/diff/1/?file=328465#file328465line75 Shouldn't this be one i18n(Details ) to avoid string puzzles? Would require another Details though, but that's necessary for RTL languages anyway (no?) David Edmundson wrote: KDialog does it this way. Martin Klapetek wrote: That doesn't make it correct. http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#good_text Include it in the string, I fancy RTL languages might want to put it on the left side - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70376 --- On Lis. 14, 2014, 6:08 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Lis. 14, 2014, 6:08 odp.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121121: Remove all kdelibs4support from polkit-agent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70439 --- Ship it! Ship It! - Lukáš Tinkl On Lis. 16, 2014, 2:16 odp., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Lis. 16, 2014, 2:16 odp.) Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. Repository: polkit-kde-agent-1 Description --- Remove all kdelibs4support from polkit-agent Diffs - AuthDialog.h eaebbd2 AuthDialog.cpp b76d91e AuthDialog.ui e4da0f9 CMakeLists.txt 482fc57 main.cpp f8f97b8 policykitkde.h 85ce6b2 policykitkde.cpp a25cb4f policykitlistener.h 538381f policykitlistener.cpp bab7fdf Diff: https://git.reviewboard.kde.org/r/121121/diff/ Testing --- Using pkexec tested using the correct password the wrong password viewing details and tested trying to open two agents at once. File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/1bb7a716-e855-4ad3-9c36-498077ee016b__polkit_normal.png screenshot --reverse https://git.reviewboard.kde.org/media/uploaded/files/2014/11/16/0e03dc82-a81f-4192-81c7-f6376d545681__polkit_reverse.png Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Polkit-kde-agent-1 in Plasma5
Dne 14.11.2014 v 12:43 David Edmundson napsal(a): Hey, It seems we have never made a release of the Qt5 version of the KDE polkit agent. Kubuntu are shipping the kdelibs4 version, which is fine for now, but not really where we want to be long term. 1) Can we talk about moving it into Plasma from extragear? It's a rather essential part of the modern desktop. 2) Is there anything blocking making a KF5 release? David You're reading my mind, I was about to suggest the same :) +1 from my side definitely -- Lukáš Tinkl lti...@redhat.com Senior Software Engineer - KDE desktop team, Brno KDE developer lu...@kde.org Red Hat Inc. http://cz.redhat.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120970: Remove combo Graphical Effects
On Lis. 4, 2014, 11:59 dop., Kai Uwe Broulik wrote:
Who's responsible for setting the dedicated replacement
QStyle::styleHint(SH_Widget_Animate)?
Is it now up to the style then, ie. animations turned on/off in
Oxygen/Breeze?
David Edmundson wrote:
Turns out that was a very good question.
frameworkintegration/src/kstyle/kstyle.cpp
case SH_Widget_Animate: {
KConfigGroup g(KSharedConfig::openConfig(), KDE-Global GUI
Settings);
return g.readEntry(GraphicEffectsLevel, true);
}
So we were using this config entry, but writing it as an integer and
reading it as a boolean. So it was animated for everything, except: Low
display resolution and Low CPU
Martin Gräßlin wrote:
Personal opinion: this shouldn't be on any config option at all. If at
all the animation setting should get derived from the hardware. If a style
wants to expose an option that's fine, but it should be in the style specific
config..
Kai Uwe Broulik wrote:
Deduced from the hardware (and is remote session) is certainly nice but
difficult, no?
Also, what about Plasma's animations? We do use
units.{long,short}Duration everywhere but can this be disabled somewhere or
what settings does that follow?
Martin Klapetek wrote:
We do use units.{long,short}Duration everywhere but can this be
disabled somewhere or what settings does that follow?
LookFeel package, iirc.
Not only that, you can also enable/disable the individual effects using
QApplication::setEffectEnabled(Qt::UIEffect effect, bool enable = true), see
http://qt-project.org/doc/qt-5/qt.html#UIEffect-enum
- Lukáš
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
---
On Lis. 4, 2014, 11:55 dop., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/
---
(Updated Lis. 4, 2014, 11:55 dop.)
Review request for Plasma.
Repository: plasma-desktop
Description
---
Remove combo Graphical Effects
It set a config value which was exposed in
KGlobalSettings::graphicEffectsLevel that is now deprecated.
Diffs
-
kcms/style/finetuning.ui 3abb692
kcms/style/kcmstyle.cpp 6585ee6
Diff: https://git.reviewboard.kde.org/r/120970/diff/
Testing
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120667: set the polkit helper id to let polkit change the settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/#review68762 --- Ship it! Weird, this was working just fine in 5.0... wondering what changed in KAuth - Lukáš Tinkl On Říj. 20, 2014, 4:44 odp., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120667/ --- (Updated Říj. 20, 2014, 4:44 odp.) Review request for Plasma and David Edmundson. Repository: plasma-desktop Description --- set the polkit helper id to let polkit change the settings. without this the kcm just blocks when you click Apply. but the key icons don't appear on the ok/apply buttons in kcmshell5 which makes me suspicious Diffs - kcms/dateandtime/main.cpp 0041a9d7b115b4e6f74973ff23a78fa619bd4a24 Diff: https://git.reviewboard.kde.org/r/120667/diff/ Testing --- installed and clicked apply Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel
On Říj. 14, 2014, 9:02 dop., Martin Klapetek wrote: Could we possibly get Suspend button instead? Suspend stores the session state into memory and then restores it without any issues (and we lock screen on wakeup anyway); many times I have found my laptop with locked screen and I had to unlock, click the suspend button in the panel only to get it locked again and suspended. Martin Gräßlin wrote: I expected this question to come :-) - I'm not sure whether it's a valid use case, at least for laptops. Closing the lid should send it to suspend, the suspend button should still work (if not, we should fix it). So there are already quite some decent ways to get the system to suspend when locked. Especially with lid closing it does what it's supposed to do. In fact the functionality should even be available through the Change Session functionality as that drops you to the login manager where you can suspend. Sure not as comfortable as directly exposing it. But we don't need to expose every option which might make sense ;-) Kai Uwe Broulik wrote: Although closing the lid apparently reliably suspends the device, even when locked, my gut makes me not trust it. :/ Martin Gräßlin wrote: Although closing the lid apparently reliably suspends the device, even when locked, my gut makes me not trust it. :/ At least my notebook(s) have a visible LED indicating it is in sleep mode. Martin Klapetek wrote: There are still usecases however where either the user does not want/need to close the lid and/or sets his laptop to not suspend on the lid close (personally I have that disabled when on charger). Plus there is the whole non-laptop world. It's not about exposing every option that makes sense, it's about replacing one senseless with one that makes more sense ;) Martin Gräßlin wrote: It's not about exposing every option that makes sense, it's about replacing one senseless with one that makes more sense ;) I don't see it that way. The option got added in a strange way shortly before the 5.0 release with the maintainers of the screenlocker not having a chance to review it (let's say it simple: if I would have reviewed the code, it would not have gone in, in the first place). So I'm comparing to the last state where it was working which is 4.11 and there the screen locker did not expose such an option and I want to go back to that working state. Let's look from there whether it's a valid option to expose the suspend option and not from the broken state. To me it's not a valid use case to expose suspend in the lock screen. To a certain degree it circumvents security. Suspend/Hibernate is allowed on a per-user logged in base. That's implemented by checking whether suspend/hibernate is supported at runtime. By exposing it in the screenlocker it circumvents the check. A not logged in user (or a user who is not allowed to supsend in his session) is able to suspend (multi user system just needs to switch to a logged session which allows suspend). Thus I think from a security perspective the option may not be there in the first place. Martin Klapetek wrote: Oh come on, that's hardly any security circumvention. By that logic we should not show battery state, current user's date/time, user name and user picture in the lock screen either because it's exposing things which other users might have restricted access to. Plus you said in the very first comment that it's possible to go around this to the login screen and from there anyone can suspend... Martin Gräßlin wrote: Plus you said in the very first comment that it's possible to go around this to the login screen and from there anyone can suspend... yes and no. In a multi-user system you can of course configure the system in a way to not allow suspend/hibernate from login manager. It all boils down to: why do we go all the hassle to check whether this options should be enabled from a security point of view, when we allow it for not logged-in users. If we go for allow for not logged in users, we can remove quite a decent amount of code... Kai Uwe Broulik wrote: Having a suspend button is a security issue but closing the lid, which causes it to suspend, is not? Martin Gräßlin wrote: Having a suspend button is a security issue but closing the lid, which causes it to suspend, is not? no, as that is controlled by logind. If the system is configured to not allow it, logind won't suspend the system if the lid closes. Kai Uwe Broulik wrote: So, the button should also honor that policy? Martin Klapetek wrote: So, the button should also honor that policy? The thing is (I think) that having the button exposed for user A would allow user B to suspend the session while user B has it restricted. But I think that at
[Powerdevil] [Bug 339391] system hangs during suspend-to-ram (must poweroff), while pm-suspend works.
https://bugs.kde.org/show_bug.cgi?id=339391 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED Ever confirmed|0 |1 --- Comment #7 from Lukáš Tinkl lu...@kde.org --- PowerDevil uses systemd's login1 interface, so if pm-suspend (which is something different) works, then systemd is to blame. If neither pm-suspend works, it must be a kernel or even HW issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120513: Set the shortcut for running ksysguard as global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- systemmonitor/kdedksysguard.cpp https://git.reviewboard.kde.org/r/120513/#comment47395 It doesn't have to be a QList() - Lukáš Tinkl On Říj. 6, 2014, 4:14 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Říj. 6, 2014, 4:14 odp.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- I don't have any default shortcut for ksysguard set (Default: None), according to the docs KGlobalAccel::setGlobalShortcut -- Convenient method to set both active and default shortcut. Now I do see Default: Ctrl+Esc Diffs - systemmonitor/kdedksysguard.cpp d69bf9e Diff: https://git.reviewboard.kde.org/r/120513/diff/ Testing --- Default shortcut appears, works as expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Říj. 6, 2014, 5:21 odp., Martin Gräßlin wrote: processui/ProcessModel.cpp, lines 91-106 https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line91 you seem to be losing the precision here. Hrvoje Senjan wrote: that's true, but i haven't found suitable replacement, will investigate further Use KFormat::formatByteSize() from KCoreAddons - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- On Zář. 30, 2014, 7:40 odp., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Zář. 30, 2014, 7:40 odp.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
On Říj. 7, 2014, 12:23 dop., Martin Klapetek wrote: tests/CMakeLists.txt, line 7 https://git.reviewboard.kde.org/r/120441/diff/3/?file=316814#file316814line7 Is the I18n still needed here in the tests linkage? I see only the signalplottertest.cpp using i18n (and even that usage could possibly be removed but meh, it's just tests) Tests shouldn't contain i18n() - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68025 --- On Říj. 6, 2014, 6:29 odp., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Říj. 6, 2014, 6:29 odp.) Review request for Plasma. Repository: libksysguard Description --- some libs needed just headers removal, other something more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, even w/o linking to it. Diffs - CMakeLists.txt 61bd704 ksgrd/CMakeLists.txt 64ad24a ksgrd/SensorManager.cpp 9e1534a lsofui/CMakeLists.txt 2b0c8ac lsofui/lsof.h e87ac26 processcore/CMakeLists.txt 0ca833e processcore/processes.cpp 3e63218 processcore/processes_atop_p.cpp 369df36 processcore/processes_remote_p.cpp 361bf24 processui/CMakeLists.txt 150e198 processui/KTextEditVT.cpp 064737b processui/ProcessFilter.cpp b37766e processui/ProcessModel.cpp 8b87d41 processui/ProcessModel_p.h 6bc9d09 processui/ReniceDlg.h fa445a5 processui/ReniceDlg.cpp 218412c processui/ksysguardprocesslist.cpp d3403cc processui/scripting.cpp fd0a610 signalplotter/CMakeLists.txt 67aa8bb signalplotter/kgraphicssignalplotter.h 9f698d4 signalplotter/ksignalplotter.cpp 91d9eee tests/CMakeLists.txt a74c6a2 tests/graphicssignalplotterbenchmark.cpp e27eb1a tests/processtest.cpp 6aa9809 tests/signalplotterbenchmark.cpp 8b827d6 tests/signalplottertest.cpp bb2108e Diff: https://git.reviewboard.kde.org/r/120441/diff/ Testing --- builds, tests pass, ksysguard functions as it did Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving kde:muon repository to kde/workspaces
Dne 2.10.2014 v 19:28 Jens Reuterberg napsal(a): [silently cheering you on!] On Thursday 02 October 2014 19.23.17 Aleix Pol wrote: On Fri, Sep 26, 2014 at 4:44 PM, Aleix Pol aleix...@kde.org wrote: Hi, I'd like to have it moved to get it released with the Plasma 5.2 release, so no rush. I think though it's a good match as I think KDE has had a need for offering resources that are not part of the actual release and also Muon could really use some visibility outside of the Kubuntu world. Since Muon adopted PackageKit and Appstream, the technology tie is no more, so we'll be able to consider it a part of the Plasma Workspace solutions. If there's no considerable objections, I'd like to request the repository move next week. Cheers! Aleix Since there hasn't been any complaints, I'll request the move. No objections from me at all, we will work out the problems with the PackageKit backend :) Here's me hoping we will have a working system updater and a software center in one, regardless of the transient problems -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67357 --- Ship it! Please put the city as the 2nd column, otherwise a ship it from me definitely, great work! - Lukáš Tinkl On Zář. 24, 2014, 11:43 dop., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Zář. 24, 2014, 11:43 dop.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Zář. 24, 2014, 4:33 odp., Lukáš Tinkl wrote: Please put the city as the 2nd column, otherwise a ship it from me definitely, great work! For the record, the tooltip can be wrong for certain TZs (yesterday/tomorrow with the correct day name should be shown instead) - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67357 --- On Zář. 24, 2014, 11:43 dop., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Zář. 24, 2014, 11:43 dop.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
