Re: Interest check: gh (github's cli)
Hey sthen@
Thanks for the correction. I need to ditch Debian and install OpenBSD on my
RPi4 so I can test ports on another arch.
Anyway, port attached with your suggestions.
Would be cool to see this imported. :)
Take care.
Ricardo
‐‐‐ Original Message ‐‐‐
>From openbsd-ports Mon Jul 26 20:33:21 2021
From: Stuart Henderson
Date: Mon, 26 Jul 2021 20:33:21 +
To: openbsd-ports
Subject: Re: Interest check: gh (github's cli)
Message-Id:
X-MARC-Message: https://marc.info/?l=openbsd-ports=162733162207369
On 2021/07/21 07:58, Ricardo wrote:
> Port updated to version 1.13.1 (released today):
This uses a newer version of creack/pty now, which should support
aarch64/arm on OpenBSD, so the BROKEN lines should be removed.
Missing rcsid ($OpenBSD$ line) in modules.inc.
Whoever is "tinsel-grumble" on https://github.com/cli/cli/issues/2330,
you're really bloody unhelpful.
-
On Wednesday, July 21st, 2021 at 8:58 AM, Ricardo
wrote:
> Hey ports@,
>
> Port updated to version 1.13.1 (released today):
>
> --- github-cli-v1.12.11v2/Makefile Mon Jul 19 11:44:49 2021
>
> +++ github-cli-v1.13.1/Makefile Wed Jul 21 09:03:24 2021
>
> @@ -5,10 +5,9 @@
>
> COMMENT = command-line access to github pull requests, issues and more
>
> -V = 1.12.1
>
> +V = 1.13.1
>
> MODGO_MODNAME = github.com/cli/cli
>
> MODGO_VERSION = v$V
>
> -REVISION = 1
>
> DISTNAME = cli-${MODGO_VERSION}
>
> PKGNAME = github-cli-$V
>
> @@ -19,13 +18,12 @@
>
> MIT
> ===
>
> PERMIT_PACKAGE = Yes
>
> -SEPARATE_BUILD = Yes
> ---
>
> WANTLIB += c pthread
>
> MODULES = lang/go
> ---
>
> MODGO_LDFLAGS += -X "github.com/cli/cli/internal/build.Version=$V"
>
> +
>
> +SEPARATE_BUILD = Yes
>
> do-test:
>
> cd ${WRKSRC} && ${MODGO_TEST_CMD} ./...
>
> --- github-cli-v1.12.11v2/distinfo Mon Jul 19 11:44:49 2021
>
> +++ github-cli-v1.13.1/distinfo Wed Jul 21 09:04:01 2021
>
> @@ -1,4 +1,4 @@
>
> -SHA256 (cli-v1.12.1.zip) = pdLKVhXvoPJX/fPFSbiY3+vn72nEZJf1N/UN/W4SKRs=
>
> +SHA256 (cli-v1.13.1.zip) = pboQHBzXfvniA7fgCTeH4fH1lfgFR32xtRKjodlozrs=
>
> SHA256 (go_modules/cloud.google.com/go/@v/v0.26.0.mod) =
> IhijTyC5cbwZUhbUGV9XUgoqy9hd5/wxrPxEAmZwTBE=
>
> SHA256 (go_modules/cloud.google.com/go/@v/v0.34.0.mod) =
> IhijTyC5cbwZUhbUGV9XUgoqy9hd5/wxrPxEAmZwTBE=
>
> SHA256 (go_modules/cloud.google.com/go/@v/v0.38.0.mod) =
> IRVe7cPkx6CccZziPHA/vxTDSspC7QDcCHdN5uu+gAc=
>
> @@ -19,8 +19,8 @@
>
> SHA256 (go_modules/cloud.google.com/go/storage/@v/v1.0.0.zip) =
> uuxHVsVz7eWPGet65KyuvXrD8MVkE+y70hatRqWJpdo=
>
> SHA256
> (go_modules/dmitri.shuralyov.com/gpu/mtl/@v/v0.0.0-20190408044501-666a987793e9.mod)
> = +sTF2PaC+eyXchsvyf1TBiqxcLLSt/q4/8EK4YOhlR4=
>
> SHA256
> (go_modules/dmitri.shuralyov.com/gpu/mtl/@v/v0.0.0-20190408044501-666a987793e9.zip)
> = ylMwkB/NqD0JVTrDYldtGWxTEVe8nFAudrI3zKJitAA=
>
> -SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.9.mod) =
> OTHuFb7Z7CzuTEY3kcxqhRnqOP+VFYQ2SfcnpjnaANE=
>
> -SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.9.zip) =
> uQD1bGOQYMUxG0BxFbrxruqwkLEkrkeAjczX6J3ksWM=
>
> +SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.14.mod) =
> CPbyIkAvmLIsiJoijc352+sAxsfAHzeMyv66XscIVMo=
>
> +SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.14.zip) =
> Iy9RANJtg66g5G2FBICc3T8cc9Mu26HRjxCf75Sd3Ys=
>
> SHA256 (go_modules/github.com/!burnt!sushi/toml/@v/v0.3.1.mod) =
> KAIbQYClnDmTYHqVsY4jDdC8a+pSQv/o6ou/tPT3tNc=
>
> SHA256 (go_modules/github.com/!burnt!sushi/toml/@v/v0.3.1.zip) =
> gVxuWUdF8tiEL/mksFacZpXmzf1eB+Wz2Y0GtyykHjw=
>
> SHA256
> (go_modules/github.com/!burnt!sushi/xgb/@v/v0.0.0-20160522181843-27f122750802.mod)
> = luveICsJL29NHzkwvAfPGKVpmZjd6lG5T+hYETspqNg=
>
> @@ -139,8 +139,8 @@
>
> SHA256 (go_modules/github.com/google/btree/@v/v1.0.0.zip) =
> jbyzb5LHptxfau9cJjWNmLcsruaYKbWzPd2rraIEd4U=
>
> SHA256 (go_modules/github.com/google/go-cmp/@v/v0.2.0.mod) =
> nCc26iwD+x2UsqHUlqoaUXJsdk8Vi59s3h10ZfyQ9BI=
>
> SHA256 (go_modules/github.com/google/go-cmp/@v/v0.3.0.mod) =
> gd95F8Ilqdp2BLIw2VL6J4xgqIMsENeZOF0TSwXVsIc=
>
> -SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.2.mod) =
> QDarVjaqQr0xMpbNO/y0yIkSdgxWqeZlWuQi2HZ8gNo=
>
> -SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.2.zip) =
> pb4w16YcmKhSzHX0leWNI7rQ5O1kT1ydAti3XJzyXHE=
>
> +SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.4.mod) =
> QDarVjaqQr0xMpbNO/y0yIkSdgxWqeZlWuQi2HZ8gNo=
>
> +SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.4.zip) =
> xXjxPPFby7l2LCmzoyNgb0Gtt
Re: Interest check: gh (github's cli)
On 2021/08/01 14:06, Jeremie Courreges-Anglas wrote: > On Sun, Aug 01 2021, Ricardo wrote: > > Hey sthen@ > > > > Thanks for the correction. I need to ditch Debian and install OpenBSD on my > > RPi4 so I can test ports on another arch. > > > > Anyway, port attached with your suggestions. > > Would be cool to see this imported. :) > > I used github-cli-v1.13.1v2.tgz from your previous mail. Thanks for the review, imported. > Minor issue, portcheck warns about various executable files: Also the directory in the tar had the version number in, which is a potential trap, prefer if the directory has the name it would be imported under.
Re: Interest check: gh (github's cli)
On Sun, Aug 01 2021, Ricardo wrote: > Hey sthen@ > > Thanks for the correction. I need to ditch Debian and install OpenBSD on my > RPi4 so I can test ports on another arch. > > Anyway, port attached with your suggestions. > Would be cool to see this imported. :) I used github-cli-v1.13.1v2.tgz from your previous mail. One obvious issue: drop the first line of pkg/PLIST. The @comment $OpenBSD...$ line already provides an RCS Id. Currently make package fails. Minor issue, portcheck warns about various executable files: russell /usr/ports/mystuff/devel/github-cli$ portcheck executable file: Makefile executable file: pkg/DESCR executable file: pkg/PLIST.orig extra file: pkg/PLIST.orig devel/github-cli I'm no go.port.mk expert but this looks good to me ports-wise. With the issues above addressed, ok jca@ fwiw -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: Interest check: gh (github's cli)
On 2021/07/21 07:58, Ricardo wrote: > Port updated to version 1.13.1 (released today): This uses a newer version of creack/pty now, which should support aarch64/arm on OpenBSD, so the BROKEN lines should be removed. Missing rcsid ($OpenBSD$ line) in modules.inc. Whoever is "tinsel-grumble" on https://github.com/cli/cli/issues/2330, you're really bloody unhelpful.
Re: Interest check: gh (github's cli)
Hey ports@,
Port updated to version 1.13.1 (released today):
--- github-cli-v1.12.11v2/Makefile Mon Jul 19 11:44:49 2021
+++ github-cli-v1.13.1/Makefile Wed Jul 21 09:03:24 2021
@@ -5,10 +5,9 @@
COMMENT = command-line access to github pull requests, issues and
more
-V =1.12.1
+V =1.13.1
MODGO_MODNAME =github.com/cli/cli
MODGO_VERSION =v$V
-REVISION = 1
DISTNAME = cli-${MODGO_VERSION}
PKGNAME = github-cli-$V
@@ -19,13 +18,12 @@
# MIT
PERMIT_PACKAGE = Yes
-SEPARATE_BUILD = Yes
-
WANTLIB += c pthread
MODULES = lang/go
-
MODGO_LDFLAGS += -X "github.com/cli/cli/internal/build.Version=$V"
+
+SEPARATE_BUILD = Yes
do-test:
cd ${WRKSRC} && ${MODGO_TEST_CMD} ./...
--- github-cli-v1.12.11v2/distinfo Mon Jul 19 11:44:49 2021
+++ github-cli-v1.13.1/distinfo Wed Jul 21 09:04:01 2021
@@ -1,4 +1,4 @@
-SHA256 (cli-v1.12.1.zip) = pdLKVhXvoPJX/fPFSbiY3+vn72nEZJf1N/UN/W4SKRs=
+SHA256 (cli-v1.13.1.zip) = pboQHBzXfvniA7fgCTeH4fH1lfgFR32xtRKjodlozrs=
SHA256 (go_modules/cloud.google.com/go/@v/v0.26.0.mod) =
IhijTyC5cbwZUhbUGV9XUgoqy9hd5/wxrPxEAmZwTBE=
SHA256 (go_modules/cloud.google.com/go/@v/v0.34.0.mod) =
IhijTyC5cbwZUhbUGV9XUgoqy9hd5/wxrPxEAmZwTBE=
SHA256 (go_modules/cloud.google.com/go/@v/v0.38.0.mod) =
IRVe7cPkx6CccZziPHA/vxTDSspC7QDcCHdN5uu+gAc=
@@ -19,8 +19,8 @@
SHA256 (go_modules/cloud.google.com/go/storage/@v/v1.0.0.zip) =
uuxHVsVz7eWPGet65KyuvXrD8MVkE+y70hatRqWJpdo=
SHA256
(go_modules/dmitri.shuralyov.com/gpu/mtl/@v/v0.0.0-20190408044501-666a987793e9.mod)
= +sTF2PaC+eyXchsvyf1TBiqxcLLSt/q4/8EK4YOhlR4=
SHA256
(go_modules/dmitri.shuralyov.com/gpu/mtl/@v/v0.0.0-20190408044501-666a987793e9.zip)
= ylMwkB/NqD0JVTrDYldtGWxTEVe8nFAudrI3zKJitAA=
-SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.9.mod) =
OTHuFb7Z7CzuTEY3kcxqhRnqOP+VFYQ2SfcnpjnaANE=
-SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.9.zip) =
uQD1bGOQYMUxG0BxFbrxruqwkLEkrkeAjczX6J3ksWM=
+SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.14.mod) =
CPbyIkAvmLIsiJoijc352+sAxsfAHzeMyv66XscIVMo=
+SHA256 (go_modules/github.com/!alec!aivazis/survey/v2/@v/v2.2.14.zip) =
Iy9RANJtg66g5G2FBICc3T8cc9Mu26HRjxCf75Sd3Ys=
SHA256 (go_modules/github.com/!burnt!sushi/toml/@v/v0.3.1.mod) =
KAIbQYClnDmTYHqVsY4jDdC8a+pSQv/o6ou/tPT3tNc=
SHA256 (go_modules/github.com/!burnt!sushi/toml/@v/v0.3.1.zip) =
gVxuWUdF8tiEL/mksFacZpXmzf1eB+Wz2Y0GtyykHjw=
SHA256
(go_modules/github.com/!burnt!sushi/xgb/@v/v0.0.0-20160522181843-27f122750802.mod)
= luveICsJL29NHzkwvAfPGKVpmZjd6lG5T+hYETspqNg=
@@ -139,8 +139,8 @@
SHA256 (go_modules/github.com/google/btree/@v/v1.0.0.zip) =
jbyzb5LHptxfau9cJjWNmLcsruaYKbWzPd2rraIEd4U=
SHA256 (go_modules/github.com/google/go-cmp/@v/v0.2.0.mod) =
nCc26iwD+x2UsqHUlqoaUXJsdk8Vi59s3h10ZfyQ9BI=
SHA256 (go_modules/github.com/google/go-cmp/@v/v0.3.0.mod) =
gd95F8Ilqdp2BLIw2VL6J4xgqIMsENeZOF0TSwXVsIc=
-SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.2.mod) =
QDarVjaqQr0xMpbNO/y0yIkSdgxWqeZlWuQi2HZ8gNo=
-SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.2.zip) =
pb4w16YcmKhSzHX0leWNI7rQ5O1kT1ydAti3XJzyXHE=
+SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.4.mod) =
QDarVjaqQr0xMpbNO/y0yIkSdgxWqeZlWuQi2HZ8gNo=
+SHA256 (go_modules/github.com/google/go-cmp/@v/v0.5.4.zip) =
xXjxPPFby7l2LCmzoyNgb0GttsUQmuIQRff8gBKEPHs=
SHA256 (go_modules/github.com/google/martian/@v/v2.1.0+incompatible.mod) =
HbNX9WhlkJpuk5skDY2xkg32AA9hD5Cww686CT3mB+c=
SHA256 (go_modules/github.com/google/martian/@v/v2.1.0+incompatible.zip) =
W90uvTfdocDPeG2ydweWbIYksohkHacEsOMclrOTznA=
SHA256
(go_modules/github.com/google/pprof/@v/v0.0.0-20181206194817-3ea8567a2e57.mod)
= 2bZhIC+y0vAgataorGO+yl1TNfKxzkjds5lHLfR8Vsw=
@@ -213,14 +213,12 @@
SHA256
(go_modules/github.com/hinshun/vt10x/@v/v0.0.0-20180616224451-1954e6464174.zip)
= Svx3vUlQ23RsaNI+btaB0xzZUlWdcSwUANpHYIRWfPY=
SHA256 (go_modules/github.com/inconshreveable/mousetrap/@v/v1.0.0.mod) =
OR2uvJOw35u4momxS/pgJo2eueJ2I+xBUEGrq6vdAFw=
SHA256 (go_modules/github.com/inconshreveable/mousetrap/@v/v1.0.0.zip) =
w/oIE+ePXO8Q3A6ZEsQ+aOBv+XCpjpjEBQ/hTbv9GMc=
-SHA256
(go_modules/github.com/itchyny/astgen-go/@v/v0.0.0-20210113000433-0da0671862a3.mod)
= 2KVssyXdhccs0xgdu9oKOn7gUgE/4dy7p0UXeVTF+8E=
-SHA256
(go_modules/github.com/itchyny/astgen-go/@v/v0.0.0-20210113000433-0da0671862a3.zip)
= ZT+HiUA0p+wfo8WwMKr0M4V9hGIgtcykgwsumu1l8bo=
SHA256 (go_modules/github.com/itchyny/go-flags/@v/v1.5.0.mod) =
3yx6SedLP6OeOKrkVVub1mBNY5ibK8uPkuKwrKiKHFI=
SHA256 (go_modules/github.com/itchyny/go-flags/@v/v1.5.0.zip) =
VlP5Kcogqjow/rCdft+RFPMLAmRj7qR/FosfvdPjyXc=
-SHA256 (go_modules/github.com/itchyny/gojq/@v/v0.12.1.mod) =
XnOgZf8IA3xKudCrVHHGZPVGKA7D8DylCnrAn6r8As8=
-SHA256 (go_modules/github.com/itchyny/gojq/@v/v0.12.1.zip) =
zYq1dyPtjXecL1C29kxBIFMT6GW3C6CEUTdvzqMAjL4=
-SHA256
Re: Interest check: gh (github's cli)
Hey Stefan,
Thanks. :)
Minor update: enabled tests.
--- github-cli-v1.12.1/Makefile Thu Jul 15 11:57:36 2021
+++ github-cli-v1.12.1v2/Makefile Mon Jul 19 11:44:49 2021
@@ -8,6 +8,7 @@ COMMENT = command-line access to github pull
requests
V =1.12.1
MODGO_MODNAME =github.com/cli/cli
MODGO_VERSION =v$V
+REVISION = 1
DISTNAME = cli-${MODGO_VERSION}
PKGNAME = github-cli-$V
@@ -25,6 +26,9 @@ WANTLIB +=c pthread
MODULES = lang/go
MODGO_LDFLAGS += -X "github.com/cli/cli/internal/build.Version=$V"
+
+do-test:
+ cd ${WRKSRC} && ${MODGO_TEST_CMD} ./...
Take care.
Ricardo
‐‐‐ Original Message ‐‐‐
On Thursday, July 15th, 2021 at 12:01 PM, Stefan Hagen
wrote:
> Ricardo wrote:
>
> > Port attached.
>
> And again with aligned tabs and go modules in modules.inc.
>
> Best Regards,
>
> Stefan
github-cli-v1.12.11v2.tgz
Description: application/gzip
Re: Interest check: gh (github's cli)
Ricardo wrote: > Port attached. And again with aligned tabs and go modules in modules.inc. Best Regards, Stefan github-cli.tar.gz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On Tue, Mar 23, 2021 at 10:18:07PM +, Stuart Henderson wrote: > > OK sthen with these added > > BROKEN-aarch64= old kr/pty doesn't support OpenBSD arm arches; needs > creack/pty@v1.1.11 > BROKEN-armv7= old kr/pty doesn't support OpenBSD arm arches; needs > creack/pty@v1.1.11 > Port updated with broken markers for aarch64 and armv7 added. -- Regards, Mikolaj github-cli-1.7.0.port-v2.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On 2021/03/23 22:11, Mikolaj Kucharski wrote: > On Wed, Mar 10, 2021 at 07:31:50PM +, Mikolaj Kucharski wrote: > > On Sun, Jan 24, 2021 at 02:25:14PM +, Mikolaj Kucharski wrote: > > > > > > See new port version attached. It contains 1.5.0, which I didn't had a > > > chance to properly test, as I've updated the port today. > > > > > > From port perspective comparing to github-cli,2.tgz from Stuart > > > Henderson, I've: > > > > > > - updated $V to 1.5.0 > > > - make makesum > > > - ran make modgo-gen-modules > > > - update Makefile with new MODGO_MODULES and MODGO_MODFILES > > > - make makesum again > > > - updated plist > > > - added MODGO_LDFLAGS so gh version prints proper version > > > - make package > > > - gh version works as expected, and prints 1.5.0 instead of DEV > > > > > > > Updated port to 1.7.0 version attached. > > > > Tested lightly, but regularly, as I don't use a lot of API codepaths. > Create or list issues, create pull requests. Works for me. > > -- > Regards, > Mikolaj OK sthen with these added BROKEN-aarch64= old kr/pty doesn't support OpenBSD arm arches; needs creack/pty@v1.1.11 BROKEN-armv7= old kr/pty doesn't support OpenBSD arm arches; needs creack/pty@v1.1.11
Re: Interest check: gh (github's cli)
On Wed, Mar 10, 2021 at 07:31:50PM +, Mikolaj Kucharski wrote: > On Sun, Jan 24, 2021 at 02:25:14PM +, Mikolaj Kucharski wrote: > > > > See new port version attached. It contains 1.5.0, which I didn't had a > > chance to properly test, as I've updated the port today. > > > > From port perspective comparing to github-cli,2.tgz from Stuart > > Henderson, I've: > > > > - updated $V to 1.5.0 > > - make makesum > > - ran make modgo-gen-modules > > - update Makefile with new MODGO_MODULES and MODGO_MODFILES > > - make makesum again > > - updated plist > > - added MODGO_LDFLAGS so gh version prints proper version > > - make package > > - gh version works as expected, and prints 1.5.0 instead of DEV > > > > Updated port to 1.7.0 version attached. > Tested lightly, but regularly, as I don't use a lot of API codepaths. Create or list issues, create pull requests. Works for me. -- Regards, Mikolaj github-cli-1.7.0.port.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On Sun, Jan 24, 2021 at 02:25:14PM +, Mikolaj Kucharski wrote: > > See new port version attached. It contains 1.5.0, which I didn't had a > chance to properly test, as I've updated the port today. > > From port perspective comparing to github-cli,2.tgz from Stuart > Henderson, I've: > > - updated $V to 1.5.0 > - make makesum > - ran make modgo-gen-modules > - update Makefile with new MODGO_MODULES and MODGO_MODFILES > - make makesum again > - updated plist > - added MODGO_LDFLAGS so gh version prints proper version > - make package > - gh version works as expected, and prints 1.5.0 instead of DEV > Updated port to 1.7.0 version attached. -- Regards, Mikolaj github-cli-1.7.0.port.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On Wed, Oct 07, 2020 at 08:13:36PM +0100, Stuart Henderson wrote: > On 2020/10/07 19:36, Stuart Henderson wrote: > > > go: github.com/enescakir/emoji@v1.0.0: reading > > > file:///home/mkucharski/openbsd/ports/distfiles/go_modules/github.com/enescakir/emoji/@v/v1.0.0.mod: > > > no such file or directory > > > > Oh man go.port.mk is worse than I thought. It must be fetching any old files > > from distfiles, not just the ones specified in the port Makefile. > > > > I would take a look now but the kernel on my workstation started hanging > > again :( > > fsck done and not _too_ much corruption... Could you try this one please, > I have built it after removing /usr/ports/distfiles/go_modules and it > seems OK so I think it will work now. > Sorry for so long delay. This version here is github-cli-1.1.0 and it works for me. I'm reattaching Stuart's version in this email. Current version of github-cli at https://github.com/cli/cli is 1.4.0, but I think committing 1.1.0 from attached port is fine as step one. I didn't look to update to 1.4.0 myself yet. -- Regards, Mikolaj github-cli,2.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On 2020/10/07 19:36, Stuart Henderson wrote: > > go: github.com/enescakir/emoji@v1.0.0: reading > > file:///home/mkucharski/openbsd/ports/distfiles/go_modules/github.com/enescakir/emoji/@v/v1.0.0.mod: > > no such file or directory > > Oh man go.port.mk is worse than I thought. It must be fetching any old files > from distfiles, not just the ones specified in the port Makefile. > > I would take a look now but the kernel on my workstation started hanging > again :( fsck done and not _too_ much corruption... Could you try this one please, I have built it after removing /usr/ports/distfiles/go_modules and it seems OK so I think it will work now. github-cli,2.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On 2020/10/07 18:13, Mikolaj Kucharski wrote: > On Wed, Oct 07, 2020 at 06:30:58PM +0100, Stuart Henderson wrote: > > On 2020/10/05 20:40, Mikolaj Kucharski wrote: > > > On Mon, Oct 05, 2020 at 05:00:48PM +0100, Stuart Henderson wrote: > > > > Still horrible but now with 100% more manpages (but the formatting is > > > > not very pleasant to the eye...) > > > > > > I don't want to push discussion into bikeshedding, but I would go for > > > sysutils/github-cli as pkgpath and github-cli as package name. > > > > Good call, other OS are either using "gh" or "github-cli" so it makes > > sense to follow one of them. > > > > Updated version attached, as the version update in muesli/termenv has > > removed the need for the really nasty hack I will accept OKs for this > > one if someone wants me to import it ;) > > > > Reads fine, however category still points to devel and I've put the port > into sysutils. Not sure what exactly was your intent, to keep it in > devel or move it to sysutils. I would move it to sysutils. Oh yes, I forgot to mention that. I used devel because it's tk do with development, same as things like git, cvsutils and others. > make package failed for me with: > > go: github.com/enescakir/emoji@v1.0.0: reading > file:///home/mkucharski/openbsd/ports/distfiles/go_modules/github.com/enescakir/emoji/@v/v1.0.0.mod: > no such file or directory Oh man go.port.mk is worse than I thought. It must be fetching any old files from distfiles, not just the ones specified in the port Makefile. I would take a look now but the kernel on my workstation started hanging again :( > I don't know how to (re)generate the Makefile. > > -- > Regards, > Mikolaj >
Re: Interest check: gh (github's cli)
On Wed, Oct 07, 2020 at 06:30:58PM +0100, Stuart Henderson wrote: > On 2020/10/05 20:40, Mikolaj Kucharski wrote: > > On Mon, Oct 05, 2020 at 05:00:48PM +0100, Stuart Henderson wrote: > > > Still horrible but now with 100% more manpages (but the formatting is > > > not very pleasant to the eye...) > > > > I don't want to push discussion into bikeshedding, but I would go for > > sysutils/github-cli as pkgpath and github-cli as package name. > > Good call, other OS are either using "gh" or "github-cli" so it makes > sense to follow one of them. > > Updated version attached, as the version update in muesli/termenv has > removed the need for the really nasty hack I will accept OKs for this > one if someone wants me to import it ;) > Reads fine, however category still points to devel and I've put the port into sysutils. Not sure what exactly was your intent, to keep it in devel or move it to sysutils. I would move it to sysutils. make package failed for me with: go: github.com/enescakir/emoji@v1.0.0: reading file:///home/mkucharski/openbsd/ports/distfiles/go_modules/github.com/enescakir/emoji/@v/v1.0.0.mod: no such file or directory I don't know how to (re)generate the Makefile. -- Regards, Mikolaj
Re: Interest check: gh (github's cli)
On 2020/10/05 20:40, Mikolaj Kucharski wrote: > On Mon, Oct 05, 2020 at 05:00:48PM +0100, Stuart Henderson wrote: > > Still horrible but now with 100% more manpages (but the formatting is > > not very pleasant to the eye...) > > I don't want to push discussion into bikeshedding, but I would go for > sysutils/github-cli as pkgpath and github-cli as package name. Good call, other OS are either using "gh" or "github-cli" so it makes sense to follow one of them. Updated version attached, as the version update in muesli/termenv has removed the need for the really nasty hack I will accept OKs for this one if someone wants me to import it ;) github-cli.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On 2020/10/07 16:28, Ricardo wrote:
> Hey Stuart,
>
> Damn, you are fast. abieber@ (thanks) just introduced me to portgen(1) and
> just before I finished reading the man page and you already attached a
> working port (from my brief tests, seems to be working fine on amd64).
>
> Why you say it's horrible? Besides fixing the man pages, how can I improve
> it?
I am referring to this:
do-build:
-cd ${WRKSRC} && ${MODGO_BUILD_CMD} ${ALL_TARGET}/cmd/...
cd ${WRKDIR}/go/pkg/mod/github.com/muesli/termenv@*; \
cp termenv_linux.go termenv_openbsd.go
cd ${WRKSRC} && ${MODGO_BUILD_CMD} ${ALL_TARGET}/cmd/...
The build process used by go.port.mk passes zips to go so it's
impossible to patch files inside them (or, as was needed in this case,
copy a file under a different name so it's found on OpenBSD) before
starting the build.
So what this is doing is "build it once and tell make to ignore
failures because we know it's going to fail", then fix up the thing
causing build to fail, then re-run the build.
Now...for gh there was a new version released yesterday, which uses
a newer version of the library that had this build problem, so this
can be avoided again, I'll send an update later.
But what is really needed is for the zips to be unpacked in the "make
extract" stage so they can be correctly patched by the ports
infrastructure, same as other ports do - of course this is normal
for C code distributed as tarballs - but even for more complex things
like rust+cargo, the port module does this the right way. Go to one
of the rust ports we have and "make patch", it extracts/patches the
files, "cd `make show=WRKSRC`" works, takes you to a directory
containing readable extracted files, they can be modified, "make
update-patches" works, etc.
Try to do this for go ports and the best you can do is run "make" and
hit ^C at the right point to get to a similar stage where you can
get at the files (and the ports "patch" infrastructure doesn't work
with them).
To fix this, go.port.mk will either need to replicate some of what go is
doing itself in its own build process, or if there's a way to tell go to
extract the zips as a preliminary stage without trying to build them,
that would also do the trick.
The current situation is that either we have to bodge it like in my
gh cli 1.0.0 Makefile, or that patches need to be committed to
released versions upstream (and maybe the software depending on those
libraries gets updated to use that updated version) before we're able
to use them in ports.
This is not really acceptable as sometimes we might need to patch
something urgently due to an important/security fix and we can't really
be forced to wait for upstreams to do something if this happens.
Re: Interest check: gh (github's cli)
Hey Stuart, Damn, you are fast. abieber@ (thanks) just introduced me to portgen(1) and just before I finished reading the man page and you already attached a working port (from my brief tests, seems to be working fine on amd64). Why you say it's horrible? Besides fixing the man pages, how can I improve it? Take care. Ricardo On 10/5/20 5:00 PM, Stuart Henderson wrote: On 2020/10/05 16:52, Stuart Henderson wrote: On 2020/10/05 14:50, Ricardo wrote: Hey ports@ Github released a cli application (gh) written in go and I would like to know if there any interest on having it under OpenBSD. Take care. Ricardo Working but horrible port attached. Still horrible but now with 100% more manpages (but the formatting is not very pleasant to the eye...) gh-cli-v3.tgz Description: application/compressed-tar
Re: Interest check: gh (github's cli)
On 10/5/20 9:50 AM, Ricardo wrote: > Hey ports@ > > Github released a cli application (gh) written in go and I would like to know > if there any interest on having it under OpenBSD. > > Take care. > Ricardo > > Speaking as an enduser, I would love this too :D Aisha
Re: Interest check: gh (github's cli)
On Mon, Oct 05, 2020 at 05:00:48PM +0100, Stuart Henderson wrote: > Still horrible but now with 100% more manpages (but the formatting is > not very pleasant to the eye...) I don't want to push discussion into bikeshedding, but I would go for sysutils/github-cli as pkgpath and github-cli as package name. -- Regards, Mikolaj
Re: Interest check: gh (github's cli)
On 2020/10/05 16:52, Stuart Henderson wrote: > On 2020/10/05 14:50, Ricardo wrote: > > Hey ports@ > > > > Github released a cli application (gh) written in go and I would like to > > know if there any interest on having it under OpenBSD. > > > > Take care. > > Ricardo > > > > > > Working but horrible port attached. Still horrible but now with 100% more manpages (but the formatting is not very pleasant to the eye...) gh-cli,2.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On 2020/10/05 14:50, Ricardo wrote: > Hey ports@ > > Github released a cli application (gh) written in go and I would like to > know if there any interest on having it under OpenBSD. > > Take care. > Ricardo > > Working but horrible port attached. gh-cli.tgz Description: application/tar-gz
Re: Interest check: gh (github's cli)
On Mon, Oct 05, 2020 at 02:50:35PM +0100, Ricardo wrote: > Github released a cli application (gh) written in go and I would like to > know if there any interest on having it under OpenBSD. Yes, but last time I tried it, it didn't compile. May have been fixed now? -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: Interest check: gh (github's cli)
I use hub(the old cli application) currently so if a gh-cli port was made I would certainly try that out. man. 5. okt. 2020 kl. 15:51 skrev Ricardo : > > Hey ports@ > > Github released a cli application (gh) written in go and I would like to > know if there any interest on having it under OpenBSD. > > Take care. > Ricardo > >
Re: Interest check: gh (github's cli)
On Mon, Oct 05, 2020 at 02:50:35PM +0100, Ricardo wrote: > Hey ports@ > > Github released a cli application (gh) written in go and I would like to > know if there any interest on having it under OpenBSD. Yes, very much yes please. I had a stab at github-cli, but hit some issues in portgen(1) and didn't had time to dig into protgen(1) itself. -- Regards, Mikolaj
Interest check: gh (github's cli)
Hey ports@ Github released a cli application (gh) written in go and I would like to know if there any interest on having it under OpenBSD. Take care. Ricardo
