Re: purritobin-0.1.2 - new package + dependencies
On 8/11/20 5:46 PM, Brian Callahan wrote: > > On Monday, August 10, 2020 9:24 PM, Aisha Tammy > wrote: > >> On 8/10/20 6:06 PM, Brian Callahan wrote: >> >>> Hi Aisha -- >>> When I extracted your tarball, it gave me a port of py-synapse-imap... >>> ~Brian >> >> OMG, lol, so sorry about that, that was another one I had just sent! >> I made an error in the scp >.< >> >> Thanks a lot for the correction, >> I've attached the correct one. >> >> Aisha > > Committed now. Thanks. > > ~Brian > Thank you so much !!! Aisha
Re: purritobin-0.1.2 - new package + dependencies
On Monday, August 10, 2020 9:24 PM, Aisha Tammy wrote: > On 8/10/20 6:06 PM, Brian Callahan wrote: > > > Hi Aisha -- > > When I extracted your tarball, it gave me a port of py-synapse-imap... > > ~Brian > > OMG, lol, so sorry about that, that was another one I had just sent! > I made an error in the scp >.< > > Thanks a lot for the correction, > I've attached the correct one. > > Aisha Committed now. Thanks. ~Brian
Re: purritobin-0.1.2 - new package + dependencies
On 8/10/20 6:06 PM, Brian Callahan wrote: > Hi Aisha -- > > When I extracted your tarball, it gave me a port of py-synapse-imap... > > ~Brian > OMG, lol, so sorry about that, that was another one I had just sent! I made an error in the scp >.< Thanks a lot for the correction, I've attached the correct one. Aisha purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
Hi Aisha -- On Sunday, August 9, 2020 5:20 PM, Aisha Tammy wrote: > On 7/5/20 5:58 AM, Aisha Tammy wrote: > > > Bump, > > > > > On 2020/06/23 23:33, Aisha Tammy wrote: > > > > > > > On 6/22/20 6:56 AM, Stuart Henderson wrote: > > > > > > > > > On 2020/06/21 21:32, Aisha Tammy wrote: > > > > > > > > > > > > I've added them again with the two from Brian and the uwebsockets > > > > > > > updated to 18.3.0 > > > > > > > > > > > > Another bump. > > > > > > Also updated uwebsockets to 18.4.0 > > > > > > > > > > OK sthen@ if someone wants to import uwebsockets/usockets with > > > > > usockets > > > > > moved from devel to net, tgz attached. > > > > > For purritobin, could you install the README under share/doc and maybe > > > > > also paste.html and POSIX_shell_client.sh (either in share/examples or > > > > > somewhere else). Might be a good idea to add an rc script and a userid > > > > > to run it under (@newuser in plist) too? > > > > > > > > I've attached purritobin with the README and an rc file. > > > > Changes > > > > > > > > - new user and group > > > > > > > > - rc file running as new user > > > > > > > > - added paste.html and shell clients to /usr/local/share/purritobin/ > > > > > > > > - added pkg-readme with examples for httpd, cron cleanup and pf rate > > > > limiting > > > > > > > > > > > > Also needs that uwebsockets and usockets be updated to latest version > > > > as the > > > > current ones in the tree are broken (upstream messed up some SSL > > > > declarations). > > > > I've added the diff for that as well. > > > > > > I've committed those, diff didn't work as it had extra blank lines > > > so I did them by hand, SHARED_LIBS needed a bump too due to additional > > > functions. > > > purritobin looks good now, ok if someone would like to import (wonder if > > > it might be better in www rather than net though) > > Another bump. > > There's one OK, so I think it should be good. > > Thanks a lot, > Aisha When I extracted your tarball, it gave me a port of py-synapse-imap... ~Brian
Re: purritobin-0.1.2 - new package + dependencies
On 7/5/20 5:58 AM, Aisha Tammy wrote: > Bump, > >> On 2020/06/23 23:33, Aisha Tammy wrote: >>> On 6/22/20 6:56 AM, Stuart Henderson wrote: On 2020/06/21 21:32, Aisha Tammy wrote: >> I've added them again with the two from Brian and the uwebsockets >> updated to 18.3.0 > > Another bump. > Also updated uwebsockets to 18.4.0 OK sthen@ if someone wants to import uwebsockets/usockets with usockets moved from devel to net, tgz attached. For purritobin, could you install the README under share/doc and maybe also paste.html and POSIX_shell_client.sh (either in share/examples or somewhere else). Might be a good idea to add an rc script and a userid to run it under (@newuser in plist) too? >>> >>> I've attached purritobin with the README and an rc file. >>> Changes >>> - new user and group >>> >>> - rc file running as new user >>> - added paste.html and shell clients to /usr/local/share/purritobin/ >>> - added pkg-readme with examples for httpd, cron cleanup and pf rate >>> limiting >>> >>> Also needs that uwebsockets and usockets be updated to latest version as the >>> current ones in the tree are broken (upstream messed up some SSL >>> declarations). >>> I've added the diff for that as well. >> >> I've committed those, diff didn't work as it had extra blank lines >> so I did them by hand, SHARED_LIBS needed a bump too due to additional >> functions. >> >> purritobin looks good now, ok if someone would like to import (wonder if >> it might be better in www rather than net though) >> > Another bump. There's one OK, so I think it should be good. Thanks a lot, Aisha purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
Bump, > On 2020/06/23 23:33, Aisha Tammy wrote: >> On 6/22/20 6:56 AM, Stuart Henderson wrote: >>> On 2020/06/21 21:32, Aisha Tammy wrote: > I've added them again with the two from Brian and the uwebsockets > updated to 18.3.0 Another bump. Also updated uwebsockets to 18.4.0 >>> >>> OK sthen@ if someone wants to import uwebsockets/usockets with usockets >>> moved from devel to net, tgz attached. >>> >>> For purritobin, could you install the README under share/doc and maybe >>> also paste.html and POSIX_shell_client.sh (either in share/examples or >>> somewhere else). Might be a good idea to add an rc script and a userid >>> to run it under (@newuser in plist) too? >>> >>> >> >> I've attached purritobin with the README and an rc file. >> Changes >> - new user and group >> >> - rc file running as new user >> - added paste.html and shell clients to /usr/local/share/purritobin/ >> - added pkg-readme with examples for httpd, cron cleanup and pf rate >> limiting >> >> Also needs that uwebsockets and usockets be updated to latest version as the >> current ones in the tree are broken (upstream messed up some SSL >> declarations). >> I've added the diff for that as well. > > I've committed those, diff didn't work as it had extra blank lines > so I did them by hand, SHARED_LIBS needed a bump too due to additional > functions. > > purritobin looks good now, ok if someone would like to import (wonder if > it might be better in www rather than net though) > purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 6/29/20 10:37 AM, Stuart Henderson wrote: > On 2020/06/23 23:33, Aisha Tammy wrote: >> On 6/22/20 6:56 AM, Stuart Henderson wrote: >>> On 2020/06/21 21:32, Aisha Tammy wrote: > I've added them again with the two from Brian and the uwebsockets > updated to 18.3.0 Another bump. Also updated uwebsockets to 18.4.0 >>> >>> OK sthen@ if someone wants to import uwebsockets/usockets with usockets >>> moved from devel to net, tgz attached. >>> >>> For purritobin, could you install the README under share/doc and maybe >>> also paste.html and POSIX_shell_client.sh (either in share/examples or >>> somewhere else). Might be a good idea to add an rc script and a userid >>> to run it under (@newuser in plist) too? >>> >>> >> >> I've attached purritobin with the README and an rc file. >> Changes >> - new user and group >> >> - rc file running as new user >> - added paste.html and shell clients to /usr/local/share/purritobin/ >> - added pkg-readme with examples for httpd, cron cleanup and pf rate >> limiting >> >> Also needs that uwebsockets and usockets be updated to latest version as the >> current ones in the tree are broken (upstream messed up some SSL >> declarations). >> I've added the diff for that as well. > > I've committed those, diff didn't work as it had extra blank lines > so I did them by hand, SHARED_LIBS needed a bump too due to additional > functions. Very sorry about that, I'm learning new features ( weirdness :P) of thunderbird. Thanks a lot for the fixing :) > > purritobin looks good now, ok if someone would like to import (wonder if > it might be better in www rather than net though) > Is there a strict distinction? Asking as I want to add a few more ports for python packages which are hovering between these. Thanks, Aisha
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/30 12:44, Aisha Tammy wrote: > > > > purritobin looks good now, ok if someone would like to import (wonder if > > it might be better in www rather than net though) > > > > Is there a strict distinction? > Asking as I want to add a few more ports for python packages which > are hovering between these. Not strict, but web applications generally end up in www/ unless they're particularly related to networks/network monitoring (so things like smokeping and librenms end up in net)
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/23 23:33, Aisha Tammy wrote: > On 6/22/20 6:56 AM, Stuart Henderson wrote: > > On 2020/06/21 21:32, Aisha Tammy wrote: > >>> I've added them again with the two from Brian and the uwebsockets > >>> updated to 18.3.0 > >> > >> Another bump. > >> Also updated uwebsockets to 18.4.0 > > > > OK sthen@ if someone wants to import uwebsockets/usockets with usockets > > moved from devel to net, tgz attached. > > > > For purritobin, could you install the README under share/doc and maybe > > also paste.html and POSIX_shell_client.sh (either in share/examples or > > somewhere else). Might be a good idea to add an rc script and a userid > > to run it under (@newuser in plist) too? > > > > > > I've attached purritobin with the README and an rc file. > Changes > - new user and group > > - rc file running as new user > - added paste.html and shell clients to /usr/local/share/purritobin/ > - added pkg-readme with examples for httpd, cron cleanup and pf rate limiting > > Also needs that uwebsockets and usockets be updated to latest version as the > current ones in the tree are broken (upstream messed up some SSL > declarations). > I've added the diff for that as well. I've committed those, diff didn't work as it had extra blank lines so I did them by hand, SHARED_LIBS needed a bump too due to additional functions. purritobin looks good now, ok if someone would like to import (wonder if it might be better in www rather than net though)
Re: purritobin-0.1.2 - new package + dependencies
On 6/22/20 6:56 AM, Stuart Henderson wrote: > On 2020/06/21 21:32, Aisha Tammy wrote: >>> I've added them again with the two from Brian and the uwebsockets >>> updated to 18.3.0 >> >> Another bump. >> Also updated uwebsockets to 18.4.0 > > OK sthen@ if someone wants to import uwebsockets/usockets with usockets > moved from devel to net, tgz attached. > > For purritobin, could you install the README under share/doc and maybe > also paste.html and POSIX_shell_client.sh (either in share/examples or > somewhere else). Might be a good idea to add an rc script and a userid > to run it under (@newuser in plist) too? > > I've attached purritobin with the README and an rc file. Changes - new user and group - rc file running as new user - added paste.html and shell clients to /usr/local/share/purritobin/ - added pkg-readme with examples for httpd, cron cleanup and pf rate limiting Also needs that uwebsockets and usockets be updated to latest version as the current ones in the tree are broken (upstream messed up some SSL declarations). I've added the diff for that as well. Thanks a bunch. Aisha diff --git net/usockets/Makefile net/usockets/Makefile index 622653bba96..9c7adc40bf2 100644 --- net/usockets/Makefile +++ net/usockets/Makefile @@ -8,7 +8,7 @@ SHARED_LIBS = usockets 0.0 GH_ACCOUNT = uNetworking GH_PROJECT = uSockets -GH_TAGNAME = v0.4.0 +GH_TAGNAME = v0.4.1 MAINTAINER = Aisha Tammy diff --git net/usockets/distinfo net/usockets/distinfo index 44ad2df5825..d2274543c1d 100644 --- net/usockets/distinfo +++ net/usockets/distinfo @@ -1,2 +1,2 @@ -SHA256 (uSockets-0.4.0.tar.gz) = +fFbOV3vV4zHmlsyq8ZPqc/12shzBikR9RW5hLkPfMI= -SIZE (uSockets-0.4.0.tar.gz) = 48367 +SHA256 (uSockets-0.4.1.tar.gz) = IPj38LIjXztH8e/zyRgZIAA/HLyN9hcg2rpsui0Toa4= +SIZE (uSockets-0.4.1.tar.gz) = 49955 diff --git www/uwebsockets/Makefile www/uwebsockets/Makefile index 3a7f685a6d8..2c5a2813f9e 100644 --- www/uwebsockets/Makefile +++ www/uwebsockets/Makefile @@ -6,7 +6,7 @@ CATEGORIES =www GH_ACCOUNT = uNetworking GH_PROJECT = uWebSockets -GH_TAGNAME = v18.4.0 +GH_TAGNAME = v18.6.0 MAINTAINER = Aisha Tammy diff --git www/uwebsockets/distinfo www/uwebsockets/distinfo index d62afb13d03..9b39396f50c 100644 --- www/uwebsockets/distinfo +++ www/uwebsockets/distinfo @@ -1,2 +1,2 @@ -SHA256 (uWebSockets-18.4.0.tar.gz) = mNdhojPlUClV3oSaQbo6ZlChG3BsrrJSyzE26v0/D40= -SIZE (uWebSockets-18.4.0.tar.gz) = 263430 +SHA256 (uWebSockets-18.6.0.tar.gz) = XwrkPmmqPFj8OgV/c4ESuOSn0h3wP5C7C0nGkN15npo= +SIZE (uWebSockets-18.6.0.tar.gz) = 264309 purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 6/22/20 7:39 AM, Landry Breuil wrote: > On Mon, Jun 22, 2020 at 11:56:57AM +0100, Stuart Henderson wrote: >> On 2020/06/21 21:32, Aisha Tammy wrote: I've added them again with the two from Brian and the uwebsockets updated to 18.3.0 >>> >>> Another bump. >>> Also updated uwebsockets to 18.4.0 >> >> OK sthen@ if someone wants to import uwebsockets/usockets with usockets >> moved from devel to net, tgz attached. > > both imported :) > Thank you so much !! Aisha
Re: purritobin-0.1.2 - new package + dependencies
On 6/22/20 6:56 AM, Stuart Henderson wrote: > On 2020/06/21 21:32, Aisha Tammy wrote: >>> I've added them again with the two from Brian and the uwebsockets >>> updated to 18.3.0 >> >> Another bump. >> Also updated uwebsockets to 18.4.0 > > OK sthen@ if someone wants to import uwebsockets/usockets with usockets > moved from devel to net, tgz attached. > > For purritobin, could you install the README under share/doc and maybe > also paste.html and POSIX_shell_client.sh (either in share/examples or > somewhere else). Might be a good idea to add an rc script and a userid > to run it under (@newuser in plist) too? > > That actually sounds like a really good idea. I've been running it with the www user, but a different user sounds great! I will do this soon. Thanks a bunch, Aisha
Re: purritobin-0.1.2 - new package + dependencies
On Mon, Jun 22, 2020 at 11:56:57AM +0100, Stuart Henderson wrote: > On 2020/06/21 21:32, Aisha Tammy wrote: > > > I've added them again with the two from Brian and the uwebsockets > > > updated to 18.3.0 > > > > Another bump. > > Also updated uwebsockets to 18.4.0 > > OK sthen@ if someone wants to import uwebsockets/usockets with usockets > moved from devel to net, tgz attached. both imported :)
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/21 21:32, Aisha Tammy wrote: > > I've added them again with the two from Brian and the uwebsockets > > updated to 18.3.0 > > Another bump. > Also updated uwebsockets to 18.4.0 OK sthen@ if someone wants to import uwebsockets/usockets with usockets moved from devel to net, tgz attached. For purritobin, could you install the README under share/doc and maybe also paste.html and POSIX_shell_client.sh (either in share/examples or somewhere else). Might be a good idea to add an rc script and a userid to run it under (@newuser in plist) too? usockets-uwebsockets.tgz Description: application/tar-gz
Re: purritobin-0.1.2 - new package + dependencies
On 6/13/20 4:48 PM, Aisha Tammy wrote: > On 6/12/20 5:49 PM, Brian Callahan wrote: >> >> ‐‐‐ Original Message ‐‐‐ >> On Friday, June 12, 2020 5:48 PM, Stuart Henderson >> wrote: >> >>> On 2020/06/12 21:34, Brian Callahan wrote: >>> Maybe it would be nice to upstream the usockets shared library building? >>> >>> upstream say WONTFIX, they are more interested in performance than >>> something which can be used in OS packaging. >>> >>> https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 >> >> Ah, missed that thanks. >> In that case, we can certainly support a single patch for it. >> >> ~Brian >> > Yes, an unfortunate scenario. > > I've added them again with the two from Brian and the uwebsockets > updated to 18.3.0 > > Thanks a lot! > > Aisha > > Another bump. Also updated uwebsockets to 18.4.0 Aisha uwebsockets.tgz Description: application/compressed-tar usockets.tgz Description: application/compressed-tar purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 6/12/20 5:49 PM, Brian Callahan wrote: > > ‐‐‐ Original Message ‐‐‐ > On Friday, June 12, 2020 5:48 PM, Stuart Henderson > wrote: > >> On 2020/06/12 21:34, Brian Callahan wrote: >> >>> Maybe it would be nice to upstream the usockets shared library building? >> >> upstream say WONTFIX, they are more interested in performance than >> something which can be used in OS packaging. >> >> https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 > > Ah, missed that thanks. > In that case, we can certainly support a single patch for it. > > ~Brian > Yes, an unfortunate scenario. I've added them again with the two from Brian and the uwebsockets updated to 18.3.0 Thanks a lot! Aisha uwebsockets.tgz Description: application/compressed-tar usockets.tgz Description: application/compressed-tar purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
‐‐‐ Original Message ‐‐‐ On Friday, June 12, 2020 5:48 PM, Stuart Henderson wrote: > On 2020/06/12 21:34, Brian Callahan wrote: > > > Maybe it would be nice to upstream the usockets shared library building? > > upstream say WONTFIX, they are more interested in performance than > something which can be used in OS packaging. > > https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 Ah, missed that thanks. In that case, we can certainly support a single patch for it. ~Brian
Re: purritobin-0.1.2 - new package + dependencies
Hi Aisha -- ‐‐‐ Original Message ‐‐‐ On Monday, June 8, 2020 9:07 AM, Aisha Tammy wrote: > Based on your comments, I've changed it back to using the shared > library, though I am still building a static library as well. > > Thanks a lot for all your help! > > comments? > > PS: yes, uwebsockets did go from 0.17.6 to 18.1.0 > > Aisha > > On 6/3/20 11:14 AM, Stuart Henderson wrote: > > > On 2020/06/02 15:55, Aisha Tammy wrote: > > > > > > All these static libraries mean that things won't get updated > > > > automatically when a library is updated. Say you install purritobin > > > > and there is a later security fix to usockets; purritobin won't be > > > > updated unless you manually force it (e.g. by bumping REVISION). > > > > The normal way of handling this with almost everything else in ports > > > > is to use shared libraries. > > > > > > I totally agree but upstream has mandated that this library is to be used > > > static only and with -flto -O3 (which Brian has removed stating > > > unsupported archs, thanks brian!). > > > > that could just be changed in the port like you did before (but then > > actually make use of it). I don't think we honestly care about the > > difference upstream talks about in the ticket (160k req/sec with > > shared libs, to 215k req/sec with static+lto, on some unspecified OS). > > https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 > > Packagers for at least some other OS will want this too if they're > > going to include it in their package systems. > > > > > Upstream have also rejected my patch to add shared libraries :( and is > > > adamant > > > on using both the above flags (which was a separate issue that was > > > raised, to > > > remove the flags and make them optional depending on distribution) > > > Does ports not handle such an automated revision bump for static libraries > > > that get updated? (am just asking, I don't know the intricacies and > > > details > > > of shared/static library things) > > > > If there was a shared library as well you could list it as a "fake" WANTLIB > > entry (it would show as "extra" so we add a comment to say what's going on) > > and then it would at least get updated if the shared library version number > > (.so.X.Y) changes though that doesn't force it for every update either. > > Really with static libs you need to bump all the downstream users or > > set a tight dependency on the particular version number. > > > > > I am not sure how to resolve this conflict... > > > an aside: why was -O3 removed, upstream has it present and wants it to be > > > there? > > > > Higher opt levels increase risk of hitting compiler bugs (maybe only > > on certain architectures). If the code implements anything which is > > undefined behaviour that can cause problems with optimisers too, > > especially at higher opt levels. > > Ports policy is to respect what is set by the user / ports infrastructure, > > usually -O2, but sometimes it's necessary to change that on certain arches. I made just tiny tweaks to usockets and purritobin; just WANTLIB and BDEP/LDEP fixes. Maybe it would be nice to upstream the usockets shared library building? ~Brian purritobin.tgz Description: application/compressed-tar usockets.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/12 21:34, Brian Callahan wrote: > Maybe it would be nice to upstream the usockets shared library building? upstream say WONTFIX, they are more interested in performance than something which can be used in OS packaging. https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325
Re: purritobin-0.1.2 - new package + dependencies
Based on your comments, I've changed it back to using the shared library, though I am still building a static library as well. Thanks a lot for all your help! comments? PS: yes, uwebsockets did go from 0.17.6 to 18.1.0 Aisha On 6/3/20 11:14 AM, Stuart Henderson wrote: > On 2020/06/02 15:55, Aisha Tammy wrote: >>> All these static libraries mean that things won't get updated >>> automatically when a library is updated. Say you install purritobin >>> and there is a later security fix to usockets; purritobin won't be >>> updated unless you manually force it (e.g. by bumping REVISION). >>> The normal way of handling this with almost everything else in ports >>> is to use shared libraries. >>> >> I totally agree but upstream has mandated that this library is to be used >> static only and with -flto -O3 (which Brian has removed stating unsupported >> archs, thanks brian!). > > that could just be changed in the port like you did before (but then > actually make use of it). I don't think we honestly care about the > difference upstream talks about in the ticket (160k req/sec with > shared libs, to 215k req/sec with static+lto, on some unspecified OS). > https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 > > Packagers for at least some other OS will want this too if they're > going to include it in their package systems. > >> Upstream have also rejected my patch to add shared libraries :( and is >> adamant >> on using both the above flags (which was a separate issue that was raised, to >> remove the flags and make them optional depending on distribution) >> >> Does ports not handle such an automated revision bump for static libraries >> that get updated? (am just asking, I don't know the intricacies and details >> of shared/static library things) > > If there was a shared library as well you could list it as a "fake" WANTLIB > entry (it would show as "extra" so we add a comment to say what's going on) > and then it would at least get updated if the shared library version number > (.so.X.Y) changes though that doesn't force it for every update either. > Really with static libs you need to bump all the downstream users or > set a tight dependency on the particular version number. > >> I am not sure how to resolve this conflict... >> >> >> an aside: why was -O3 removed, upstream has it present and wants it to be >> there? > > Higher opt levels increase risk of hitting compiler bugs (maybe only > on certain architectures). If the code implements anything which is > undefined behaviour that can cause problems with optimisers too, > especially at higher opt levels. > > Ports policy is to respect what is set by the user / ports infrastructure, > usually -O2, but sometimes it's necessary to change that on certain arches. > purritobin-0.2.1.tgz Description: application/compressed-tar uwebsockets-18.1.0.tgz Description: application/compressed-tar usockets-0.4.0.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 6/2/20 8:50 AM, Stuart Henderson wrote: > On 2020/06/01 22:13, Brian Callahan wrote: >> Hi Aisha -- >> >> ‐‐‐ Original Message ‐‐‐ >> On Sunday, May 31, 2020 10:03 PM, Aisha Tammy wrote: >> >>> Hi, >>> >>> I've attached the port again, with a few more fixes. >>> >>> Would love to see this added. >>> >>> A few words about this port: >>> >>> It is a minimalistic pastebin client which allows you to also >>> >>> paste encrypted texts and has a simple javascript decryptor frontend. >>> >>> It is asynchronous and allows you to limit the paste size and a >>> >>> location where the pastes are stored. >>> >>> It uses unveil and pledge to make sure that only the necessary >>> >>> folders and permissions are used. >>> >>> Really hope this can be added and would love to get any advice about >>> >>> how to improve this port :) >>> >>> Aisha >> >> Thanks for the ports. I've attached improved versions of the ports >> that address what I'll talk about in this email. I'll take each >> separately. >> >> usockets: >> * I see that it compiles with -std=c11, so we need to have a >> COMPILER=base-clang ports-gcc line. >> * The Makefile has some -O3 lines, so those go. It also has some -flto >> lines. I don't believe all our archs can support -flto at the moment >> so I removed them too. >> * I am not sure why you create and install a shared version of this >> library. It seems like upstream intends for this to be statically >> linked into executables. Indeed, you don't even use the shared >> version of the library in PurritoBin, so I think it can go. >> * Your patch to the Makefile causes everything to be recompiled at >> fake time. >> * Not related to your port, but too bad that we are stuck using libuv >> (it can use kqueue but it uses extensions from FreeBSD that we don't >> have). >> >> uwebsockets: >> * Upstream claims this is a web server so I moved the category to www. >> Devel is quite full. Otherwise this port is quite straightforward. >> >> purritobin: >> * Since you're using the static version of usocket, we can simplify >> your depends lists. >> >> ~Brian >> > > > > > purritobin > - Makefile: > - add "uses pledge()" above wantlib as done in other ports > - pkg/DESCR: > - trailing blank line > - s/writted/written > I've attached with the suggested fixes and those from Brian. again, thank you Brian! > All these static libraries mean that things won't get updated > automatically when a library is updated. Say you install purritobin > and there is a later security fix to usockets; purritobin won't be > updated unless you manually force it (e.g. by bumping REVISION). > The normal way of handling this with almost everything else in ports > is to use shared libraries. > am not sure if there is a good fix for this (?!) Aisha uwebsockets.tgz Description: application/compressed-tar usockets.tgz Description: application/compressed-tar purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/02 15:55, Aisha Tammy wrote: > > All these static libraries mean that things won't get updated > > automatically when a library is updated. Say you install purritobin > > and there is a later security fix to usockets; purritobin won't be > > updated unless you manually force it (e.g. by bumping REVISION). > > The normal way of handling this with almost everything else in ports > > is to use shared libraries. > > > I totally agree but upstream has mandated that this library is to be used > static only and with -flto -O3 (which Brian has removed stating unsupported > archs, thanks brian!). that could just be changed in the port like you did before (but then actually make use of it). I don't think we honestly care about the difference upstream talks about in the ticket (160k req/sec with shared libs, to 215k req/sec with static+lto, on some unspecified OS). https://github.com/uNetworking/uSockets/issues/99#issuecomment-627384325 Packagers for at least some other OS will want this too if they're going to include it in their package systems. > Upstream have also rejected my patch to add shared libraries :( and is adamant > on using both the above flags (which was a separate issue that was raised, to > remove the flags and make them optional depending on distribution) > > Does ports not handle such an automated revision bump for static libraries > that get updated? (am just asking, I don't know the intricacies and details > of shared/static library things) If there was a shared library as well you could list it as a "fake" WANTLIB entry (it would show as "extra" so we add a comment to say what's going on) and then it would at least get updated if the shared library version number (.so.X.Y) changes though that doesn't force it for every update either. Really with static libs you need to bump all the downstream users or set a tight dependency on the particular version number. > I am not sure how to resolve this conflict... > > > an aside: why was -O3 removed, upstream has it present and wants it to be > there? Higher opt levels increase risk of hitting compiler bugs (maybe only on certain architectures). If the code implements anything which is undefined behaviour that can cause problems with optimisers too, especially at higher opt levels. Ports policy is to respect what is set by the user / ports infrastructure, usually -O2, but sometimes it's necessary to change that on certain arches.
Re: purritobin-0.1.2 - new package + dependencies
On 6/2/20 8:50 AM, Stuart Henderson wrote: > On 2020/06/01 22:13, Brian Callahan wrote: >> Hi Aisha -- >> >> ‐‐‐ Original Message ‐‐‐ >> On Sunday, May 31, 2020 10:03 PM, Aisha Tammy wrote: >> >>> Hi, >>> >>> I've attached the port again, with a few more fixes. >>> >>> Would love to see this added. >>> >>> A few words about this port: >>> >>> It is a minimalistic pastebin client which allows you to also >>> >>> paste encrypted texts and has a simple javascript decryptor frontend. >>> >>> It is asynchronous and allows you to limit the paste size and a >>> >>> location where the pastes are stored. >>> >>> It uses unveil and pledge to make sure that only the necessary >>> >>> folders and permissions are used. >>> >>> Really hope this can be added and would love to get any advice about >>> >>> how to improve this port :) >>> >>> Aisha >> >> Thanks for the ports. I've attached improved versions of the ports >> that address what I'll talk about in this email. I'll take each >> separately. >> >> usockets: >> * I see that it compiles with -std=c11, so we need to have a >> COMPILER=base-clang ports-gcc line. >> * The Makefile has some -O3 lines, so those go. It also has some -flto >> lines. I don't believe all our archs can support -flto at the moment >> so I removed them too. >> * I am not sure why you create and install a shared version of this >> library. It seems like upstream intends for this to be statically >> linked into executables. Indeed, you don't even use the shared >> version of the library in PurritoBin, so I think it can go. >> * Your patch to the Makefile causes everything to be recompiled at >> fake time. >> * Not related to your port, but too bad that we are stuck using libuv >> (it can use kqueue but it uses extensions from FreeBSD that we don't >> have). >> >> uwebsockets: >> * Upstream claims this is a web server so I moved the category to www. >> Devel is quite full. Otherwise this port is quite straightforward. >> >> purritobin: >> * Since you're using the static version of usocket, we can simplify >> your depends lists. >> >> ~Brian >> > > > > > purritobin > - Makefile: > - add "uses pledge()" above wantlib as done in other ports will do thanks! > - pkg/DESCR: > - trailing blank line > - s/writted/written will fix thanks! > > All these static libraries mean that things won't get updated > automatically when a library is updated. Say you install purritobin > and there is a later security fix to usockets; purritobin won't be > updated unless you manually force it (e.g. by bumping REVISION). > The normal way of handling this with almost everything else in ports > is to use shared libraries. > I totally agree but upstream has mandated that this library is to be used static only and with -flto -O3 (which Brian has removed stating unsupported archs, thanks brian!). Upstream have also rejected my patch to add shared libraries :( and is adamant on using both the above flags (which was a separate issue that was raised, to remove the flags and make them optional depending on distribution) Does ports not handle such an automated revision bump for static libraries that get updated? (am just asking, I don't know the intricacies and details of shared/static library things) I am not sure how to resolve this conflict... an aside: why was -O3 removed, upstream has it present and wants it to be there? Aisha
Re: purritobin-0.1.2 - new package + dependencies
On 2020/06/01 22:13, Brian Callahan wrote: > Hi Aisha -- > > ‐‐‐ Original Message ‐‐‐ > On Sunday, May 31, 2020 10:03 PM, Aisha Tammy wrote: > > > Hi, > > > > I've attached the port again, with a few more fixes. > > > > Would love to see this added. > > > > A few words about this port: > > > > It is a minimalistic pastebin client which allows you to also > > > > paste encrypted texts and has a simple javascript decryptor frontend. > > > > It is asynchronous and allows you to limit the paste size and a > > > > location where the pastes are stored. > > > > It uses unveil and pledge to make sure that only the necessary > > > > folders and permissions are used. > > > > Really hope this can be added and would love to get any advice about > > > > how to improve this port :) > > > > Aisha > > Thanks for the ports. I've attached improved versions of the ports > that address what I'll talk about in this email. I'll take each > separately. > > usockets: > * I see that it compiles with -std=c11, so we need to have a > COMPILER=base-clang ports-gcc line. > * The Makefile has some -O3 lines, so those go. It also has some -flto > lines. I don't believe all our archs can support -flto at the moment > so I removed them too. > * I am not sure why you create and install a shared version of this > library. It seems like upstream intends for this to be statically > linked into executables. Indeed, you don't even use the shared > version of the library in PurritoBin, so I think it can go. > * Your patch to the Makefile causes everything to be recompiled at > fake time. > * Not related to your port, but too bad that we are stuck using libuv > (it can use kqueue but it uses extensions from FreeBSD that we don't > have). > > uwebsockets: > * Upstream claims this is a web server so I moved the category to www. > Devel is quite full. Otherwise this port is quite straightforward. > > purritobin: > * Since you're using the static version of usocket, we can simplify > your depends lists. > > ~Brian > purritobin - Makefile: - add "uses pledge()" above wantlib as done in other ports - pkg/DESCR: - trailing blank line - s/writted/written All these static libraries mean that things won't get updated automatically when a library is updated. Say you install purritobin and there is a later security fix to usockets; purritobin won't be updated unless you manually force it (e.g. by bumping REVISION). The normal way of handling this with almost everything else in ports is to use shared libraries.
Re: purritobin-0.1.2 - new package + dependencies
On 6/1/20 6:13 PM, Brian Callahan wrote: > Hi Aisha -- > > ‐‐‐ Original Message ‐‐‐ > On Sunday, May 31, 2020 10:03 PM, Aisha Tammy wrote: > >> Hi, >> >> I've attached the port again, with a few more fixes. >> >> Would love to see this added. >> >> A few words about this port: >> >> It is a minimalistic pastebin client which allows you to also >> >> paste encrypted texts and has a simple javascript decryptor frontend. >> >> It is asynchronous and allows you to limit the paste size and a >> >> location where the pastes are stored. >> >> It uses unveil and pledge to make sure that only the necessary >> >> folders and permissions are used. >> >> Really hope this can be added and would love to get any advice about >> >> how to improve this port :) >> >> Aisha > > Thanks for the ports. I've attached improved versions of the ports > that address what I'll talk about in this email. I'll take each > separately. > > usockets: > * I see that it compiles with -std=c11, so we need to have a > COMPILER=base-clang ports-gcc line. > * The Makefile has some -O3 lines, so those go. It also has some -flto > lines. I don't believe all our archs can support -flto at the moment > so I removed them too. > * I am not sure why you create and install a shared version of this > library. It seems like upstream intends for this to be statically > linked into executables. Indeed, you don't even use the shared > version of the library in PurritoBin, so I think it can go. > * Your patch to the Makefile causes everything to be recompiled at > fake time. > * Not related to your port, but too bad that we are stuck using libuv > (it can use kqueue but it uses extensions from FreeBSD that we don't > have). > OMG thank you so much. I really appreciate all your help :) I'm still new to the whole C/C++ packaging and linking and everything so I just gave all the options possible. Yea, I had to look around for using EVFILT_USER not being present :( before I had to start using libuv. Someone had tried to port it at some point but I don't think it went anywhere. > uwebsockets: > * Upstream claims this is a web server so I moved the category to www. > Devel is quite full. Otherwise this port is quite straightforward. > > purritobin: > * Since you're using the static version of usocket, we can simplify > your depends lists. > Thanks again for all of this. Aisha > ~Brian >
Re: purritobin-0.1.2 - new package + dependencies
Hi Aisha -- ‐‐‐ Original Message ‐‐‐ On Sunday, May 31, 2020 10:03 PM, Aisha Tammy wrote: > Hi, > > I've attached the port again, with a few more fixes. > > Would love to see this added. > > A few words about this port: > > It is a minimalistic pastebin client which allows you to also > > paste encrypted texts and has a simple javascript decryptor frontend. > > It is asynchronous and allows you to limit the paste size and a > > location where the pastes are stored. > > It uses unveil and pledge to make sure that only the necessary > > folders and permissions are used. > > Really hope this can be added and would love to get any advice about > > how to improve this port :) > > Aisha Thanks for the ports. I've attached improved versions of the ports that address what I'll talk about in this email. I'll take each separately. usockets: * I see that it compiles with -std=c11, so we need to have a COMPILER=base-clang ports-gcc line. * The Makefile has some -O3 lines, so those go. It also has some -flto lines. I don't believe all our archs can support -flto at the moment so I removed them too. * I am not sure why you create and install a shared version of this library. It seems like upstream intends for this to be statically linked into executables. Indeed, you don't even use the shared version of the library in PurritoBin, so I think it can go. * Your patch to the Makefile causes everything to be recompiled at fake time. * Not related to your port, but too bad that we are stuck using libuv (it can use kqueue but it uses extensions from FreeBSD that we don't have). uwebsockets: * Upstream claims this is a web server so I moved the category to www. Devel is quite full. Otherwise this port is quite straightforward. purritobin: * Since you're using the static version of usocket, we can simplify your depends lists. ~Brian usockets.tgz Description: application/compressed-tar uwebsockets.tgz Description: application/compressed-tar purritobin.tgz Description: application/compressed-tar
Re: purritobin-0.1.2 - new package + dependencies
Hi, I've attached the port again, with a few more fixes. Would love to see this added. A few words about this port: It is a minimalistic pastebin client which allows you to also paste encrypted texts and has a simple javascript decryptor frontend. It is asynchronous and allows you to limit the paste size and a location where the pastes are stored. It uses unveil and pledge to make sure that only the necessary folders and permissions are used. Really hope this can be added and would love to get any advice about how to improve this port :) Aisha purritobin-0.2.1.tar.gz Description: application/gzip uwebsockets-0.17.6.tar.gz Description: application/gzip usockets-0.4.0.tar.gz Description: application/gzip
Re: purritobin-0.1.2 - new package + dependencies
On 5/2/20 8:19 AM, Stuart Henderson wrote: > On 2020/05/01 14:06, Aisha Tammy wrote: >> Dear Thomas, >> >> On 5/1/20 1:08 PM, Thomas Frohwein wrote: >>> On Thu, Apr 30, 2020 at 11:16:06PM -0400, Aisha Tammy wrote: fixed bug in Makefile of usockets, which did not have correct LIB DEPENDS attached new tar.gz OK ? >>> This looks like an interesting port, but with the release approaching, >>> it may be best to take time after 6.7 is out. Especially as upstream is >>> currently issuing a new release every day [1]. Probably best to let this >> >> Of course, I totally agree. I'm in no hurry to get this in just now. >> I'm just sending it out so that it can stay in my mail box and I >> don't forget about it in my git mess. > > btw you're more likely to find it in your git mess, than committers are likely > to find it in a couple of weeks of ports@ backlog after we're done with > release. > lol that is quite true. Thankfully thunderbird allows me to set reminders on mails that should be revisited, which unfortunately I haven't figured out yet in GIT what if i bribe the devs with some bananas and some treats, they might be likely to add this sooner then. /food for thought (pun intended) Cheers, Aisha
Re: purritobin-0.1.2 - new package + dependencies
On 2020/05/01 14:06, Aisha Tammy wrote: > Dear Thomas, > > On 5/1/20 1:08 PM, Thomas Frohwein wrote: > > On Thu, Apr 30, 2020 at 11:16:06PM -0400, Aisha Tammy wrote: > >> fixed bug in Makefile of usockets, which did not have correct LIB DEPENDS > >> > >> attached new tar.gz > >> > >> OK ? > > This looks like an interesting port, but with the release approaching, > > it may be best to take time after 6.7 is out. Especially as upstream is > > currently issuing a new release every day [1]. Probably best to let this > > Of course, I totally agree. I'm in no hurry to get this in just now. > I'm just sending it out so that it can stay in my mail box and I > don't forget about it in my git mess. btw you're more likely to find it in your git mess, than committers are likely to find it in a couple of weeks of ports@ backlog after we're done with release.
Re: purritobin-0.1.2 - new package + dependencies
Dear Thomas, On 5/1/20 1:08 PM, Thomas Frohwein wrote: > On Thu, Apr 30, 2020 at 11:16:06PM -0400, Aisha Tammy wrote: >> fixed bug in Makefile of usockets, which did not have correct LIB DEPENDS >> >> attached new tar.gz >> >> OK ? > This looks like an interesting port, but with the release approaching, > it may be best to take time after 6.7 is out. Especially as upstream is > currently issuing a new release every day [1]. Probably best to let this Of course, I totally agree. I'm in no hurry to get this in just now. I'm just sending it out so that it can stay in my mail box and I don't forget about it in my git mess. > mature a little more. It also helps to attract interest in a new port by > describing a bit more what it does when you propose it; its use case, > where it may fill a need not currently met by other ports etc... Thanks a lot, I will add all this to the port DESCR and attach it with the bug fixes mentioned by Brian Callahan (thanks Brian). Aisha
Re: purritobin-0.1.2 - new package + dependencies
On Thu, Apr 30, 2020 at 11:16:06PM -0400, Aisha Tammy wrote: > fixed bug in Makefile of usockets, which did not have correct LIB DEPENDS > > attached new tar.gz > > OK ? This looks like an interesting port, but with the release approaching, it may be best to take time after 6.7 is out. Especially as upstream is currently issuing a new release every day [1]. Probably best to let this mature a little more. It also helps to attract interest in a new port by describing a bit more what it does when you propose it; its use case, where it may fill a need not currently met by other ports etc...
Re: purritobin-0.1.2 - new package + dependencies
fixed bug in Makefile of usockets, which did not have correct LIB DEPENDS attached new tar.gz OK ? Aisha On 4/30/20 2:44 PM, Aisha Tammy wrote: > Updated to latest 0.1.3 and attached. > > On 4/30/20 8:05 AM, Aisha Tammy wrote: >> Hey All, >> I am adding a new package with its 2 dependencies, so a total >> of 3 new packages. >> >> Tested on amd64 and arm64, currently hosted at https://bsd.ac . >> None of the code is platform specific so should be working on all. >> >> comments? OK? >> >> Aisha >> purritobin-0.1.3.tar.gz Description: application/gzip
Re: purritobin-0.1.2 - new package + dependencies
Updated to latest 0.1.3 and attached. On 4/30/20 8:05 AM, Aisha Tammy wrote: > Hey All, > I am adding a new package with its 2 dependencies, so a total > of 3 new packages. > > Tested on amd64 and arm64, currently hosted at https://bsd.ac . > None of the code is platform specific so should be working on all. > > comments? OK? > > Aisha > purritobin-0.1.3.tar.gz Description: application/gzip
