Re: Help improve 32-bit testing

2024-06-25 Thread Alex Bennée
Richard Henderson  writes:

> Hiya,
>
> I've just discovered a 32-bit build issue that is probably 3 weeks old.
>
> While we still support 32-bit builds at all, I would request that we
> improve our cross-i686 testing.  For instance: we have cross-i686-user
> and cross-i686-tci.  There is some system build testing in the tci
> job, but (rightfully) not everything.
>
> I would like a full cross-i686-system target that builds all targets,
> and I would like the debian-i686-cross image on which we base these to
> be more complete -- ideally, exactly matching x86_64.  In particular,
> CONFIG_SEV is not detected within the current docker image, which is
> where the current build error is located.
>
> Do you have time to look at this?

See:

  Subject: [RFC PATCH] testing: restore some testing for i686
  Date: Tue, 25 Jun 2024 15:54:18 +0100
  Message-Id: <20240625145418.694476-1-alex.ben...@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



Re: Help improve 32-bit testing

2024-06-25 Thread Richard Henderson

On 6/25/24 00:57, Philippe Mathieu-Daudé wrote:

Hi Richard,

On 25/6/24 01:33, Richard Henderson wrote:

Hiya,

I've just discovered a 32-bit build issue that is probably 3 weeks old.


How and what did you notice?


https://lore.kernel.org/qemu-devel/91f19b8d-387a-47cd-b7cc-19cdf4442...@linaro.org/

With no arguments to configure on a debian bookworm i686 install.


r~



Re: Help improve 32-bit testing

2024-06-25 Thread Richard Henderson

On 6/25/24 00:11, Thomas Huth wrote:

On 25/06/2024 01.33, Richard Henderson wrote:

Hiya,

I've just discovered a 32-bit build issue that is probably 3 weeks old.

While we still support 32-bit builds at all, I would request that we improve our 
cross-i686 testing.  For instance: we have cross-i686-user and cross-i686-tci.  There is 
some system build testing in the tci job, but (rightfully) not everything.


System emulation on 32-bit x86 hosts is marked as deprecated since QEMU 8.0 ... maybe we 
could finally remove it instead?


I'm ok with that too.  I just don't want the current situation to stand.


r~



Re: Help improve 32-bit testing

2024-06-25 Thread Philippe Mathieu-Daudé

Hi Richard,

On 25/6/24 01:33, Richard Henderson wrote:

Hiya,

I've just discovered a 32-bit build issue that is probably 3 weeks old.


How and what did you notice?

While we still support 32-bit builds at all, I would request that we 
improve our cross-i686 testing.  For instance: we have cross-i686-user 
and cross-i686-tci.  There is some system build testing in the tci job, 
but (rightfully) not everything.


I would like a full cross-i686-system target that builds all targets, 
and I would like the debian-i686-cross image on which we base these to 
be more complete -- ideally, exactly matching x86_64.  In particular, 
CONFIG_SEV is not detected within the current docker image, which is 
where the current build error is located.


Orthogonally to whether we should improve x86 testing on 32-bit
hosts, IIRC this isn't the first time we have an issue with SEV
(or more generically Confidential Computing) on 32-bit host, so
I wonder if this is a feature worth testing & supporting there
(thus Cc'ing more maintainers).

Regards,

Phil.



Re: Help improve 32-bit testing

2024-06-25 Thread Daniel P . Berrangé
On Mon, Jun 24, 2024 at 04:33:08PM -0700, Richard Henderson wrote:
> Hiya,
> 
> I've just discovered a 32-bit build issue that is probably 3 weeks old.
> 
> While we still support 32-bit builds at all, I would request that we improve
> our cross-i686 testing.  For instance: we have cross-i686-user and
> cross-i686-tci.  There is some system build testing in the tci job, but
> (rightfully) not everything.
> 
> I would like a full cross-i686-system target that builds all targets, and I
> would like the debian-i686-cross image on which we base these to be more
> complete -- ideally, exactly matching x86_64.  In particular, CONFIG_SEV is
> not detected within the current docker image, which is where the current
> build error is located.

The debian-i686-cross image should already be a precise match for
the x86_64 image. Both are auto-generated by lcitool so have the
same package set as inputs.

With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|




Re: Help improve 32-bit testing

2024-06-25 Thread Thomas Huth

On 25/06/2024 01.33, Richard Henderson wrote:

Hiya,

I've just discovered a 32-bit build issue that is probably 3 weeks old.

While we still support 32-bit builds at all, I would request that we improve 
our cross-i686 testing.  For instance: we have cross-i686-user and 
cross-i686-tci.  There is some system build testing in the tci job, but 
(rightfully) not everything.


System emulation on 32-bit x86 hosts is marked as deprecated since QEMU 8.0 
... maybe we could finally remove it instead?


I would like a full cross-i686-system target that builds all targets, and I 
would like the debian-i686-cross image on which we base these to be more 
complete -- ideally, exactly matching x86_64.  In particular, CONFIG_SEV is 
not detected within the current docker image, which is where the current 
build error is located.


Do you have time to look at this?


If you really, really want to go a step backwards, then basically just 
revert commit 4f9a8315e65561bafa03651518aa5d22af09bdee and use the 
i686-debian-cross-container image instead of the removed 
i386-fedora-cross-container image.


 HTH,
  Thomas




Help improve 32-bit testing

2024-06-24 Thread Richard Henderson

Hiya,

I've just discovered a 32-bit build issue that is probably 3 weeks old.

While we still support 32-bit builds at all, I would request that we improve our 
cross-i686 testing.  For instance: we have cross-i686-user and cross-i686-tci.  There is 
some system build testing in the tci job, but (rightfully) not everything.


I would like a full cross-i686-system target that builds all targets, and I would like the 
debian-i686-cross image on which we base these to be more complete -- ideally, exactly 
matching x86_64.  In particular, CONFIG_SEV is not detected within the current docker 
image, which is where the current build error is located.


Do you have time to look at this?


r~