Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Benjamin Herrenschmidt]

On Wed, 2016-09-07 at 07:52 +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote:
> > 
> > The bad commit is: "ppc: Speed up load/store multiple"
> > 
> > There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this
> > patch
> > which are both bad: The memcpy tries to copy 32-bit values into 64-
> > bit
> > registers, which of course does not work (unless you compile this
> > code
> > for a 32-bit host only where the size of a gpr is only 32-bit).
> 
> The instruction does that. It only copies 32-bits. I think it's
> correct.  

Except of course when the host is 64-bit and we enable with a 64-bit
target_ulong ... ugh ;-)

Drop the patch for now, I'll redo it later.

Cheers,
Ben.

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[David Gibson]

On Tue, Sep 06, 2016 at 11:26:34PM +0200, Thomas Huth wrote:
> On 06.09.2016 22:55, Thomas Huth wrote:
> > On 06.09.2016 22:23, Paolo Bonzini wrote:
> >>
> >>
> >> On 06/09/2016 21:35, Thomas Huth wrote:
> >>> D'oh! I'll have a look...
> >>>
> > I also see warnings on non-KVM hosts during 'make check' which seem
> > to be produced by this new test:
> >
> > TEST: tests/boot-serial-test... (pid=2836)
> >   /i386/boot-serial/isapc:
> > warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
> > 1]
> >>> That happens because the test is running QEMU with the isapc machine. I
> >>> also get that warning message if I simply run the following on the
> >>> command line:
> >>>
> >>> $ qemu-system-x86_64 -M isapc
> >>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1]
> >>>
> >>> So the warning is likely there since quite a while already, just nobody
> >>> is running with -M isapc nowadays anymore, so nobody noticed this ...
> >>> Does anybody have got a clue how to fix that warning?
> >>
> >> Implement vme... :)
> > 
> > Hmmm, I was rather looking for an easier solution. I think I also found
> > one: By using "-cpu qemu32", the warning does not occur anymore...
> 
> David,
> 
> since you likely got to respin this pull request anyway, could you
> please squash the following patch into my "tests: Check serial output
> of firmware boot of some machines" patch? This silences the warning
> about the unsupported vme TCG feature:
> 
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index b36c6bf..d98c564 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -29,10 +29,10 @@ static testdef_t tests[] = {
>  { "ppc64", "ppce500", "", "U-Boot" },
>  { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
>  { "ppc64", "pseries", "", "Open Firmware" },
> -{ "i386", "isapc", "-device sga", "SGABIOS" },
> +{ "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>  { "i386", "pc", "-device sga", "SGABIOS" },
>  { "i386", "q35", "-device sga", "SGABIOS" },
> -{ "x86_64", "isapc", "-device sga", "SGABIOS" },
> +{ "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>  { "x86_64", "q35", "-device sga", "SGABIOS" },
>  { "s390x", "s390-ccw-virtio",
>"-nodefaults -device sclpconsole,chardev=serial0", "virtio device" },

Done, thanks.  Seems to fix that warning.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Thomas Huth]

On 06.09.2016 16:04, Peter Maydell wrote:
> On 6 September 2016 at 04:39, David Gibson  
> wrote:
>> The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad:
>>
>>   Open 2.8 development tree (2016-09-05 11:38:54 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160906
>>
>> for you to fetch changes up to 2ccbe3e29adb7c016bc5525d38d2a6e938c481af:
>>
>>   tests: Check serial output of firmware boot of some machines (2016-09-06 
>> 10:28:17 +1000)
>>
>> 
>> ppc patch queue for 2016-Sep-6
>>
>> This is my first pull request for the newly opened qemu-2.8 tree.  It
>> contains a heap of things that were too late for 2.7 and have been
>> queued for a while.  In particular:
>> * A number of preliminary patches for the powernv machine type
>> * A substantial cleanup of exception handling which will be
>>   necessary to support running a TCG with hypervisor
>>   facilities
>> * A start on support for POWER9
>> * Some TCG implementations for new POWER9 instructions
>> * Some TCG and related cleanups in preparation for POWER9
>> * Some assorted TCG optimizations
>> * An implementation of the H_CHANGE_LOGICAL_LAN_MAC hypercall
>>   which allows the MAC address to be changed on the PAPR virtual
>>   NIC.
>> * Add some extra test cases for several machines (this isn't
>>   strictly in the ppc code, but is most value to ppc)
>>
>> 
> 
> Hi. This fails 'make check' on ppc64be:
[...]
> TEST: tests/prom-env-test... (pid=14611)
>   /ppc64/prom-env/mac99:   **
> ERROR:/home/pm215/qemu/tests/prom-env-test.c:41:check_guest_memory:
> assertion failed (signature == MAGIC): (0x == 0xcafec0de)
> FAIL

D'oh! I'll have a look...

> I also see warnings on non-KVM hosts during 'make check' which seem
> to be produced by this new test:
> 
> TEST: tests/boot-serial-test... (pid=2836)
>   /i386/boot-serial/isapc:
> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
> 1]

That happens because the test is running QEMU with the isapc machine. I
also get that warning message if I simply run the following on the
command line:

$ qemu-system-x86_64 -M isapc
warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1]

So the warning is likely there since quite a while already, just nobody
is running with -M isapc nowadays anymore, so nobody noticed this ...
Does anybody have got a clue how to fix that warning?

 Thomas

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Benjamin Herrenschmidt]

On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote:
> The bad commit is: "ppc: Speed up load/store multiple"
> 
> There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this patch
> which are both bad: The memcpy tries to copy 32-bit values into 64-bit
> registers, which of course does not work (unless you compile this code
> for a 32-bit host only where the size of a gpr is only 32-bit).

The instruction does that. It only copies 32-bits. I think it's
correct.    

> I'd suggest to remove the "#if defined(HOST_WORDS_BIGENDIAN)" part and
> use cpu_to_be32() and friends instead of the bswap32() here?

I tried that but it prevents the faster memcpy, the whole point was to
speed things up...

Cheers,
Ben.

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Paolo Bonzini]

On 06/09/2016 21:35, Thomas Huth wrote:
> D'oh! I'll have a look...
> 
>> > I also see warnings on non-KVM hosts during 'make check' which seem
>> > to be produced by this new test:
>> > 
>> > TEST: tests/boot-serial-test... (pid=2836)
>> >   /i386/boot-serial/isapc:
>> > warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
>> > 1]
> That happens because the test is running QEMU with the isapc machine. I
> also get that warning message if I simply run the following on the
> command line:
> 
> $ qemu-system-x86_64 -M isapc
> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1]
> 
> So the warning is likely there since quite a while already, just nobody
> is running with -M isapc nowadays anymore, so nobody noticed this ...
> Does anybody have got a clue how to fix that warning?

Implement vme... :)

Paolo

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Thomas Huth]

On 06.09.2016 22:55, Thomas Huth wrote:
> On 06.09.2016 22:23, Paolo Bonzini wrote:
>>
>>
>> On 06/09/2016 21:35, Thomas Huth wrote:
>>> D'oh! I'll have a look...
>>>
> I also see warnings on non-KVM hosts during 'make check' which seem
> to be produced by this new test:
>
> TEST: tests/boot-serial-test... (pid=2836)
>   /i386/boot-serial/isapc:
> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
> 1]
>>> That happens because the test is running QEMU with the isapc machine. I
>>> also get that warning message if I simply run the following on the
>>> command line:
>>>
>>> $ qemu-system-x86_64 -M isapc
>>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1]
>>>
>>> So the warning is likely there since quite a while already, just nobody
>>> is running with -M isapc nowadays anymore, so nobody noticed this ...
>>> Does anybody have got a clue how to fix that warning?
>>
>> Implement vme... :)
> 
> Hmmm, I was rather looking for an easier solution. I think I also found
> one: By using "-cpu qemu32", the warning does not occur anymore...

David,

since you likely got to respin this pull request anyway, could you
please squash the following patch into my "tests: Check serial output
of firmware boot of some machines" patch? This silences the warning
about the unsupported vme TCG feature:

diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index b36c6bf..d98c564 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -29,10 +29,10 @@ static testdef_t tests[] = {
 { "ppc64", "ppce500", "", "U-Boot" },
 { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
 { "ppc64", "pseries", "", "Open Firmware" },
-{ "i386", "isapc", "-device sga", "SGABIOS" },
+{ "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
 { "i386", "pc", "-device sga", "SGABIOS" },
 { "i386", "q35", "-device sga", "SGABIOS" },
-{ "x86_64", "isapc", "-device sga", "SGABIOS" },
+{ "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
 { "x86_64", "q35", "-device sga", "SGABIOS" },
 { "s390x", "s390-ccw-virtio",
   "-nodefaults -device sclpconsole,chardev=serial0", "virtio device" },

Thanks,
 Thomas

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Thomas Huth]

On 06.09.2016 16:04, Peter Maydell wrote:
> On 6 September 2016 at 04:39, David Gibson  
> wrote:
>> The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad:
>>
>>   Open 2.8 development tree (2016-09-05 11:38:54 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160906
>>
>> for you to fetch changes up to 2ccbe3e29adb7c016bc5525d38d2a6e938c481af:
>>
>>   tests: Check serial output of firmware boot of some machines (2016-09-06 
>> 10:28:17 +1000)
>>
>> 
>> ppc patch queue for 2016-Sep-6
>>
>> This is my first pull request for the newly opened qemu-2.8 tree.  It
>> contains a heap of things that were too late for 2.7 and have been
>> queued for a while.  In particular:
>> * A number of preliminary patches for the powernv machine type
>> * A substantial cleanup of exception handling which will be
>>   necessary to support running a TCG with hypervisor
>>   facilities
>> * A start on support for POWER9
>> * Some TCG implementations for new POWER9 instructions
>> * Some TCG and related cleanups in preparation for POWER9
>> * Some assorted TCG optimizations
>> * An implementation of the H_CHANGE_LOGICAL_LAN_MAC hypercall
>>   which allows the MAC address to be changed on the PAPR virtual
>>   NIC.
>> * Add some extra test cases for several machines (this isn't
>>   strictly in the ppc code, but is most value to ppc)
>>
>> 
> 
> Hi. This fails 'make check' on ppc64be:
> 
> QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64
> QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-
> $((RANDOM % 255 + 1))} gtester -k --verbose -m=quick
> tests/spapr-phb-test tests/endianness-test tests/boot-order-test
> tests/prom-env-test tests/drive_del-test tests/postcopy-test
> tests/boot-serial-test tests/device-introspect-test tests/qom-test
> TEST: tests/spapr-phb-test... (pid=14553)
>   /ppc64/spapr-phb/device: OK
> PASS: tests/spapr-phb-test
> TEST: tests/endianness-test... (pid=14558)
>   /ppc64/endianness/mac99: OK
>   /ppc64/endianness/pseries:   OK
>   /ppc64/endianness/split/mac99:   OK
>   /ppc64/endianness/split/pseries: OK
>   /ppc64/endianness/combine/mac99: OK
>   /ppc64/endianness/combine/pseries:   OK
> PASS: tests/endianness-test
> TEST: tests/boot-order-test... (pid=14577)
>   /ppc64/boot-order/prep:  OK
>   /ppc64/boot-order/pmac_oldworld: OK
>   /ppc64/boot-order/pmac_newworld: OK
> PASS: tests/boot-order-test
> TEST: tests/prom-env-test... (pid=14611)
>   /ppc64/prom-env/mac99:   **
> ERROR:/home/pm215/qemu/tests/prom-env-test.c:41:check_guest_memory:
> assertion failed (signature == MAGIC): (0x == 0xcafec0de)
> FAIL
> GTester: last random seed: R02Se9508b48e788a26453279aa61c24d15d
> (pid=14758)
>   /ppc64/prom-env/g3beige: **
> ERROR:/home/pm215/qemu/tests/prom-env-test.c:41:check_guest_memory:
> assertion failed (signature == MAGIC): (0x == 0xcafec0de)
> FAIL

The bad commit is: "ppc: Speed up load/store multiple"

There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this patch
which are both bad: The memcpy tries to copy 32-bit values into 64-bit
registers, which of course does not work (unless you compile this code
for a 32-bit host only where the size of a gpr is only 32-bit).
I'd suggest to remove the "#if defined(HOST_WORDS_BIGENDIAN)" part and
use cpu_to_be32() and friends instead of the bswap32() here?

 Thomas

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Thomas Huth]

On 06.09.2016 22:23, Paolo Bonzini wrote:
> 
> 
> On 06/09/2016 21:35, Thomas Huth wrote:
>> D'oh! I'll have a look...
>>
 I also see warnings on non-KVM hosts during 'make check' which seem
 to be produced by this new test:

 TEST: tests/boot-serial-test... (pid=2836)
   /i386/boot-serial/isapc:
 warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
 1]
>> That happens because the test is running QEMU with the isapc machine. I
>> also get that warning message if I simply run the following on the
>> command line:
>>
>> $ qemu-system-x86_64 -M isapc
>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1]
>>
>> So the warning is likely there since quite a while already, just nobody
>> is running with -M isapc nowadays anymore, so nobody noticed this ...
>> Does anybody have got a clue how to fix that warning?
> 
> Implement vme... :)

Hmmm, I was rather looking for an easier solution. I think I also found
one: By using "-cpu qemu32", the warning does not occur anymore...

 Thomas

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[Peter Maydell]

On 6 September 2016 at 04:39, David Gibson  wrote:
> The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad:
>
>   Open 2.8 development tree (2016-09-05 11:38:54 +0100)
>
> are available in the git repository at:
>
>   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160906
>
> for you to fetch changes up to 2ccbe3e29adb7c016bc5525d38d2a6e938c481af:
>
>   tests: Check serial output of firmware boot of some machines (2016-09-06 
> 10:28:17 +1000)
>
> 
> ppc patch queue for 2016-Sep-6
>
> This is my first pull request for the newly opened qemu-2.8 tree.  It
> contains a heap of things that were too late for 2.7 and have been
> queued for a while.  In particular:
> * A number of preliminary patches for the powernv machine type
> * A substantial cleanup of exception handling which will be
>   necessary to support running a TCG with hypervisor
>   facilities
> * A start on support for POWER9
> * Some TCG implementations for new POWER9 instructions
> * Some TCG and related cleanups in preparation for POWER9
> * Some assorted TCG optimizations
> * An implementation of the H_CHANGE_LOGICAL_LAN_MAC hypercall
>   which allows the MAC address to be changed on the PAPR virtual
>   NIC.
> * Add some extra test cases for several machines (this isn't
>   strictly in the ppc code, but is most value to ppc)
>
> 

Hi. This fails 'make check' on ppc64be:

QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64
QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-
$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick
tests/spapr-phb-test tests/endianness-test tests/boot-order-test
tests/prom-env-test tests/drive_del-test tests/postcopy-test
tests/boot-serial-test tests/device-introspect-test tests/qom-test
TEST: tests/spapr-phb-test... (pid=14553)
  /ppc64/spapr-phb/device: OK
PASS: tests/spapr-phb-test
TEST: tests/endianness-test... (pid=14558)
  /ppc64/endianness/mac99: OK
  /ppc64/endianness/pseries:   OK
  /ppc64/endianness/split/mac99:   OK
  /ppc64/endianness/split/pseries: OK
  /ppc64/endianness/combine/mac99: OK
  /ppc64/endianness/combine/pseries:   OK
PASS: tests/endianness-test
TEST: tests/boot-order-test... (pid=14577)
  /ppc64/boot-order/prep:  OK
  /ppc64/boot-order/pmac_oldworld: OK
  /ppc64/boot-order/pmac_newworld: OK
PASS: tests/boot-order-test
TEST: tests/prom-env-test... (pid=14611)
  /ppc64/prom-env/mac99:   **
ERROR:/home/pm215/qemu/tests/prom-env-test.c:41:check_guest_memory:
assertion failed (signature == MAGIC): (0x == 0xcafec0de)
FAIL
GTester: last random seed: R02Se9508b48e788a26453279aa61c24d15d
(pid=14758)
  /ppc64/prom-env/g3beige: **
ERROR:/home/pm215/qemu/tests/prom-env-test.c:41:check_guest_memory:
assertion failed (signature == MAGIC): (0x == 0xcafec0de)
FAIL
GTester: last random seed: R02S5c6b27a953943798cb66f1406f600b2a
(pid=14911)
FAIL: tests/prom-env-test
TEST: tests/drive_del-test... (pid=14912)
  /ppc64/drive_del/without-dev:OK
  /ppc64/drive_del/after_failed_device_add:OK
  /ppc64/blockdev/drive_del_device_del:OK
PASS: tests/drive_del-test
TEST: tests/postcopy-test... (pid=14923)
PASS: tests/postcopy-test
TEST: tests/boot-serial-test... (pid=14924)
  /ppc64/boot-serial/ppce500:  **
ERROR:/home/pm215/qemu/tests/boot-serial-test.c:67:check_guest_output:
assertion failed: (output_ok)
FAIL
GTester: last random seed: R02Se107d4139ff43a8ba8cbd9d0dc287d5c
(pid=15068)
  /ppc64/boot-serial/prep: OK
  /ppc64/boot-serial/pseries:  OK
FAIL: tests/boot-serial-test


I also see warnings on non-KVM hosts during 'make check' which seem
to be produced by this new test:

TEST: tests/boot-serial-test... (pid=2836)
  /i386/boot-serial/isapc:
warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit
1]
OK
  /i386/boot-serial/pc:OK
  /i386/boot-serial/q35:   OK
PASS: tests/boot-serial-test



thanks
-- PMM

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906
Type: series
Message-id: 1473133396-18940-1-git-send-email-da...@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1473133396-18940-1-git-send-email-da...@gibson.dropbear.id.au -> 
patchew/1473133396-18940-1-git-send-email-da...@gibson.dropbear.id.au
Switched to a new branch 'test'
1b6ac23 tests: Check serial output of firmware boot of some machines
480ca94 tests: Resort check-qtest entries in Makefile.include
e109ebe spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call
9cc2db7 ppc: Improve a few more helper flags
6459e95 ppc: Improve the exception helpers flags
a071891 ppc: Improve flags for helpers loading/writing the time facilities
ab6b488 ppc: Don't generate dead code on unconditional branches
d465540 ppc: Stop dumping state on all exceptions in linux-user
4746d79 ppc: Fix catching some segfaults in user mode
8bd0693 ppc: Fix macio ESCC legacy mapping
7fd4c3e hw/ppc: add a ppc_create_page_sizes_prop() helper routine
6b11f3d hw/ppc: use error_report instead of fprintf
95bc75d ppc: Rename #include'd .c files to .inc.c
2c913c6 target-ppc: add extswsli[.] instruction
a4eac47 target-ppc: add vsrv instruction
a141433 target-ppc: add vslv instruction
0b6817b target-ppc: add vcmpnez[b, h, w][.] instructions
24ee86b target-ppc: add vabsdu[b, h, w] instructions
9a73743 target-ppc: add dtstsfi[q] instructions
b6ddb68 target-ppc: implement branch-less divd[o][.]
1f81344 target-ppc: implement branch-less divw[o][.]
ca40e11 ppc: Speed up load/store multiple
6ce5b08 ppc: load/store multiple and string insns don't do LE
7fe209e ppc: Use a helper to generate "LE unsupported" alignment interrupts
d36827a ppc: Don't set access_type on all load/stores on hash64
6bb116a ppc: Fix CFAR updates
d5a5db2 ppc: Speed up dcbz
9d10d03 ppc: Handle unconditional (always/never) traps at translation time
d96fe15 ppc: Make alignment exceptions suck less
fe991b3 ppc: Don't update NIP in dcbz and lscbx
fca9606 ppc: Don't update NIP if not taking alignment exceptions
dc03d97 ppc: Don't update NIP on conditional trap instructions
055b107 ppc: Don't update NIP BookE 2.06 tlbwe
be548b5 ppc: Don't update NIP in facility unavailable interrupts
b4e9a2b ppc: Don't update NIP in DCR access routines
1bc1203 ppc: Fix source NIP on SLB related interrupts
9d1ba13 ppc: Rework NIP updates vs. exception generation
cb4fed6 ppc: Make tlb_fill() use new exception helper
cdbb088 ppc: Don't update NIP in lmw/stmw/icbi
7832c9c ppc: Don't update NIP in lswi/lswx/stswi/stswx
1dfc7ad ppc: FP exceptions are always precise
8747f8b ppc: Don't update the NIP in floating point generated code
26363d4 ppc: Make float_check_status() pass the return address
2c68509 ppc: Make float_invalid_op_excp() pass the return address
9f0d9d1 ppc: Rename fload_invalid_op_excp to float_invalid_op_excp
5afecc0 ppc: Move VSX ops out of translate.c
f16fba0 ppc: Move VMX ops out of translate.c
8aa9b05 ppc: Move DFP ops out of translate.c
1bdf9a8 ppc: Move embedded spe ops out of translate.c
2fc9dc2 ppc: Move classic fp ops out of translate.c
832f6e2 ppc: Provide basic raise_exception_* functions
31545e2 target-ppc: introduce opc4 for Expanded Opcode
5d55346 target-ppc: add maddhd and maddhdu instruction
19babb4 target-ppc: add maddld instruction
f8e16ba target-ppc: add setb instruction
b8ff185 target-ppc: add cmpeqb instruction
604b4df target-ppc: add cnttzw[.] instruction
3970a7e target-ppc: add cnttzd[.] instruction
c757276 target-ppc: add modulo dword operations
0b01d5c target-ppc: add modulo word operations
73ad7f2 target-ppc: add cmprb instruction
10e533f target-ppc: adding addpcis instruction
c3ddf6e target-ppc: Introduce POWER ISA 3.0 flag
0be2065 target-ppc: Introduce Power9 family
330dddb hw/ppc: include fdt helper routine in a common file
816d16c xics_kvm: drop extra checking of kernel_xics_fd

=== OUTPUT BEGIN ===
Checking PATCH 1/66: xics_kvm: drop extra checking of kernel_xics_fd...
Checking PATCH 2/66: hw/ppc: include fdt helper routine in a common file...
Checking PATCH 3/66: target-ppc: Introduce Power9 family...
Checking PATCH 4/66: target-ppc: Introduce POWER ISA 3.0 flag...
Checking PATCH 5/66: target-ppc: adding addpcis instruction...
Checking PATCH 6/66: target-ppc: add cmprb instruction...

Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906
Type: series
Message-id: 1473133253-17598-1-git-send-email-da...@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1473133253-17598-1-git-send-email-da...@gibson.dropbear.id.au -> 
patchew/1473133253-17598-1-git-send-email-da...@gibson.dropbear.id.au
Switched to a new branch 'test'
0db92ad tests: Check serial output of firmware boot of some machines
c3c8428 tests: Resort check-qtest entries in Makefile.include
d68d0f5 spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call
0bea6a3 ppc: Improve a few more helper flags
b1a4a8c ppc: Improve the exception helpers flags
a4acaba ppc: Improve flags for helpers loading/writing the time facilities
9477f7b ppc: Don't generate dead code on unconditional branches
4bcb34e ppc: Stop dumping state on all exceptions in linux-user
65504c0 ppc: Fix catching some segfaults in user mode
4eb70b5 ppc: Fix macio ESCC legacy mapping
f29e48e hw/ppc: add a ppc_create_page_sizes_prop() helper routine
3c8f0e4 hw/ppc: use error_report instead of fprintf
2c28d84 ppc: Rename #include'd .c files to .inc.c
41bed35 target-ppc: add extswsli[.] instruction
5ae4db1 target-ppc: add vsrv instruction
158c26b target-ppc: add vslv instruction
5f6afc0 target-ppc: add vcmpnez[b, h, w][.] instructions
aafc65b target-ppc: add vabsdu[b, h, w] instructions
062340d target-ppc: add dtstsfi[q] instructions
1d1b7ab target-ppc: implement branch-less divd[o][.]
9b0d7e8 target-ppc: implement branch-less divw[o][.]
3eb2924 ppc: Speed up load/store multiple
15a9293 ppc: load/store multiple and string insns don't do LE
627174e ppc: Use a helper to generate "LE unsupported" alignment interrupts
3ec0c72 ppc: Don't set access_type on all load/stores on hash64
0f2aa5c ppc: Fix CFAR updates
e0ca52e ppc: Speed up dcbz
f4d1f26 ppc: Handle unconditional (always/never) traps at translation time
c0d3897 ppc: Make alignment exceptions suck less
8f9c3fa ppc: Don't update NIP in dcbz and lscbx
fea1b36 ppc: Don't update NIP if not taking alignment exceptions
1f80c42 ppc: Don't update NIP on conditional trap instructions
f658b94 ppc: Don't update NIP BookE 2.06 tlbwe
6201d12 ppc: Don't update NIP in facility unavailable interrupts
2ce2cab ppc: Don't update NIP in DCR access routines
ba842da ppc: Fix source NIP on SLB related interrupts
cc6f1bc ppc: Rework NIP updates vs. exception generation
93b5ef1 ppc: Make tlb_fill() use new exception helper
5c2b3b5 ppc: Don't update NIP in lmw/stmw/icbi
3777fc8 ppc: Don't update NIP in lswi/lswx/stswi/stswx
9c88a78 ppc: FP exceptions are always precise
e09e1a9 ppc: Don't update the NIP in floating point generated code
bb10926 ppc: Make float_check_status() pass the return address
5893c9c ppc: Make float_invalid_op_excp() pass the return address
3067320 ppc: Rename fload_invalid_op_excp to float_invalid_op_excp
6634434 ppc: Move VSX ops out of translate.c
656061b ppc: Move VMX ops out of translate.c
0c2aeeb ppc: Move DFP ops out of translate.c
a7094ec ppc: Move embedded spe ops out of translate.c
830faa1 ppc: Move classic fp ops out of translate.c
06ec7c7 ppc: Provide basic raise_exception_* functions
9ffdd2d target-ppc: introduce opc4 for Expanded Opcode
4fb01e8 target-ppc: add maddhd and maddhdu instruction
081b316 target-ppc: add maddld instruction
1479463 target-ppc: add setb instruction
e46f061 target-ppc: add cmpeqb instruction
dbd2a4a target-ppc: add cnttzw[.] instruction
4d57c1c target-ppc: add cnttzd[.] instruction
00eac7b target-ppc: add modulo dword operations
a7eca61 target-ppc: add modulo word operations
7689e0e target-ppc: add cmprb instruction
73e41c6 target-ppc: adding addpcis instruction
2bdb997 target-ppc: Introduce POWER ISA 3.0 flag
5e91bbf target-ppc: Introduce Power9 family
a93a241 hw/ppc: include fdt helper routine in a common file
c20613e xics_kvm: drop extra checking of kernel_xics_fd

=== OUTPUT BEGIN ===
Checking PATCH 1/66: xics_kvm: drop extra checking of kernel_xics_fd...
Checking PATCH 2/66: hw/ppc: include fdt helper routine in a common file...
Checking PATCH 3/66: target-ppc: Introduce Power9 family...
Checking PATCH 4/66: target-ppc: Introduce POWER ISA 3.0 flag...
Checking PATCH 5/66: target-ppc: adding addpcis instruction...
Checking PATCH 6/66: target-ppc: add cmprb instruction...