Re: ReviewBoard and Oracle
Hi, It should be possible. We don't officially support it, but Oracle is, I believe, a supported database in Django, which Review Board is written in. What you would want to do is create a new Review Board installation using rb-site and select sqlite as the database type. Then, once you've finished, you'll need to modify your new site's conf/settings_local.py file to reference the Oracle settings. You can use these docs as a reference: http://docs.djangoproject.com/en/1.1/ref/databases/#id10 Then, run: 'rb-site manage /path/to/site syncdb' and follow the instructions to create your administrator user. I have not tried this with Oracle, but believe it will work. Let me know if you have trouble. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Feb 4, 2010 at 1:32 AM, Deepak Tripathi de9...@gmail.com wrote: Hi, Is it possible to use ReviewBoard with Oracle Database ? Kind to see response soon. Thanks Deepak -- You received this message because you are subscribed to the Google Groups Review Board Reviews group. To post to this group, send email to reviewboard-revi...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-reviews+unsubscr...@googlegroups.comreviewboard-reviews%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/reviewboard-reviews?hl=en. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Unable to find a Review Board server for this source code tree
Thanks - I deleted my original post as I managed to get it working. :) On Feb 3, 4:12 pm, Christian Hammond chip...@chipx86.com wrote: Not sure if you solved this yet, but basically, you want a .reviewboardrc file that points to the server. There's some information on setting this up here: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r... Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Feb 3, 2010 at 4:58 AM, Stodge sto...@gmail.com wrote: I read a few posts with this error but none seem to help. My Mercurial repository is athttp://localhost/hg/indigo. I know that works 100%. My ReviewBoard install is athttp://localhost:9900/reviewsand I know that works 100%. My Mercurial repository is located on disk in /var/www/sites/indigo, again I know that works. If I do: cd /var/www/sites/indigo post-review -d svn info git rev-parse --git-dir hg root hg svn info repository info: Path: /home/mike/repositories/hg/indigo, Base path: , Supports changesets: False Unable to find a Review Board server for this source code tree. If I do: post-review --repository-url=http://localhost/hg/indigo--revision- range=1 --username=mike -d svn infohttp://localhost/hg/indigo git rev-parse --git-dir hg root hg svn info repository info: Path: /home/mike/repositories/hg/indigo, Base path: , Supports changesets: False Unable to find a Review Board server for this source code tree. There is a valid Mercurial repository in /home/mike/repositories/hg/ indigo, but it's not the one I'm interested in and I've no idea why it's getting picked up. Any ideas what I'm doing wrong? Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Django auth backend vs. ReviewBoard custom auth
I have specified 'fedora.django.auth.backends.FasBackend' in the custom auth field. Once I hit Save, I can no longer log in as ANY user, neither from the FasBackend nor the built-in admin account. I see no errors in the Apache error_log. Any advice on how to track the problem? Running in 'manage.py runserver' gives no error messages either. On Feb 3, 4:07 pm, Christian Hammond chip...@chipx86.com wrote: Hi Stephen, Review Board can use custom Django auth backends by specifying the full module path in the Custom Authentication section in General Settings in the administration UI. Review Board will use that auth backend as the primary and fall back on the built-in authentication for existing accounts (so that your administration account will still work if your auth backend is broken). You shouldn't need to modify any code to make this work. Seehttp://www.reviewboard.org/docs/manual/dev/admin/admin-ui/authenticat... Note that in 1.0.x, these are in General Settings, but in the upcoming 1.5 release, they're in their own settings page. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher karrde...@gmail.comwrote: I'm trying to adapt a Django authentication backend to work with ReviewBoard (specifically https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html) Is there a guide anywhere on how to convert a Django auth backend to a ReviewBoard backend? Or a guide on how to properly use a Django auth backend with ReviewBoard? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RBTools Repository
Where can the RBTools source be checked out? I have a few contributions I'd like to make. Also, is there a repository set up in the test instance of ReviewBoard to submit RBTools patches? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. I would contend that you can already do essentially what you are proposing, albeit not particularly elegantly. There is no way to group a set of reviews together currently. Also, see issue 1229 for some explanation on how RB currently handles diffs and why it doesn't fit perfectly with git patchsets. Dan On Feb 3, 4:36 pm, Stephen Gallagher karrde...@gmail.com wrote: Reviewboard is a great tool, but it's lacking in a couple places regarding Git. Right now, ReviewBoard only supports submitting a single patch generated from the head of a particular branch. In post-review, this means that it performs a 'git diff HEAD origin/master' and transmits the output to the server as a single patch. Unfortunately, this is not how git is used in many cases. Many developers (myself included) prefer to work in patchsets, where individual steps can be developed and tested separately. These patches will build on each other, and should be individually reviewable, but may not have any value separate from each other. What I am proposing is that is should be possible for a single review request to contain multiple, ordered patches. When performing a review, it should be possible to select any of these patches individually and review them. Behind the scenes, I envision reviewboard creating a Review-specific branch onto which it applies each of the patches in the set, so context information will be correctly available during the review. With this functionality in place, it would then be possible to modify the JSON API (and the post-review tool) to enable submitting a branch, complete with commit attribution and comments. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RBTools Repository
http://github.com/reviewboard/rbtools You can submit reviews against rbtools in the same location as reviewboard reviews. Dan On Feb 4, 9:57 am, Stephen Gallagher karrde...@gmail.com wrote: Where can the RBTools source be checked out? I have a few contributions I'd like to make. Also, is there a repository set up in the test instance of ReviewBoard to submit RBTools patches? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Multiple diffs per review?
Am I right in thinking that a review can only refer to a single diff (where a diff may contain multiple changesets/revisions)? And uploading a new diff will replace the existing one with a newer version? If my understanding is right, we need to be able to group multiple revisions on one review. For example, we use Trac and multiple commits are made per ticket. I want to write a Trac plugin that will add the diff for each commit to a review (wherever that review may reside, ReviewBoard or elsewhere etc). Is this possible with RB? Sorry if I'm missing the obvious. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ETA for 1.1/1.5?
Hello. We are planning to deploy RB at work in the immediate future. It looks like the next major version should be released soon...so we're wondering if we should deploy 1.0.x, or wait a bit for 1.1/1.5? Is there an estimated release date? Thanks! -Pete -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
See the Distributed Version Control Systems section of: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ It's definitely available, and I believe it should work with git in 1.0.5.1, but TBH I've never run the stable version of RB. In a 3 patch series, for example, you'd submit the first patch directly, then the second patch with a parent diff of the first patch, then the third patch with a parent diff of the sum of the first two patches. Dan On Feb 4, 10:33 am, Stephen Gallagher karrde...@gmail.com wrote: On Feb 4, 10:20 am, Dan Savilonis d...@n-cube.org wrote: post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. Can you point me at some documentation for the parent diff mode? I'd like to understand more about this. Is it available in the stable 1.0.5.1, or does it require the 1.1 alpha? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
When I look at the error.log for Apache server, It give me this:
Am I not Importing some modules?
Traceback (most recent call last):
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py, line
92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py, line
59, in _checklogin
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py, line
37, in inner
return func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py,
line 1178, in new_diff
form = UploadDiffForm(review_request.repository, form_data,
request.FILES)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
forms.py, line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
models.py, line 43, in get_scmtool
return cls(self)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 23, in __init__
self.client = GitClient(repository.path)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 180, in __init__
raise ImportError
ImportError
ERROR:root:Exception thrown for user kaparikh at
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
On Feb 3, 1:28 pm, Kunjal kunjal.par...@gmail.com wrote:
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond chip...@chipx86.com wrote:
Hmm okay, well at least it's talking to the server now. If you check your
server log file, you should be able to see some exception information that
says what's generated that 500 error. If not, then temporarily setting DEBUG
= True in your site's conf/settings_local.py will display that exception
information in place of the 500 error. Either way, that should help to
figure out where it's failing and hopefully what's going wrong.
One thing that could be causing it, though, is your Review Board repository
entry for your Git repository. Do you have it just referencing your remote
git:// URL, or is Path actually pointing to a local Git checkout? There's no
concept of grabbing individual files from a remote Git repository, so you
need either a local clone accessible by Review Board, or if you're using the
1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
raw file from a Git web front-end such as cgit or gitweb.
Unless the Git guys someday extend the protocol to fetch an individual file
by revision from an upstream repository without a local checkout, this is
the best we can do.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Feb 2, 2010 at 3:20 PM, Kunjal kunjal.par...@gmail.com wrote:
If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
It looks like the URL is correct now. But I am still getting error.
mob-rb-test{kaparikh}22: postreview.py -d
svn info
git rev-parse --git-dir
git svn info
git svn --version
git config --get svn-remote.svn.url
git remote show origin
repository info: Path: git://
mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base path: ,
Supports changesets: False
git config --get reviewboard.url
git diff --no-color --full-index donut
Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
/home/kaparikh/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
_make_url: path = api/json/reviewrequests/new/
_make_url:app = /
_make_url: joined URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
_make_url: Resulting URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
HTTP POSTing to
Re: Is there anyone who has Review Board working under Ubuntu, lighttpd and git?
After serve ReviewBoard under Lighttpd i get 500 page. So I know that something was wrong but I don't know what. I'am look to Lighttpd error log and see nothing useful to investigate problem. Why? Because the only way is fastcgi. When error is on fastcgi side i can only guess what is wrong. When apache use mod_python I see in Apache error log exactly what is the problem. This is much better when something goes wrong. Can You give some additional informations about lighttpd: output of ls -l /etc/lighttpd output of ls -l /etc/lighttpd/conf-available output of ls -l /etc/lighttpd/conf-enabled content of ls -l /etc/lighttpd/lighttpd.conf or something like that :) On Feb 4, 10:39 pm, Sassan sassan...@verifone.com wrote: Hi Jan, Thanks for you suggestions. I had already tried the symlink idea but that did not work either. I am using python 2.5.2 and Ubuntu 8.04 (Hardy), lighttpd 1.4.26 and git 1.5.4.3 One point which I don't understand is the line which says lighttpd + fastcgi near the top of : http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ I did not find any ready-made fastcgi modules to install on ubuntu Regarding your earlier suggestion about using apache, I am quite happy to try. But before trying another shot in the dark I would like to hear from some one who already has Review Board up and running. We can then try to use their configuration as an example. Sassan On Feb 4, 1:56 am, Jan Koprowski jan.koprow...@gmail.com wrote: Hi Sassan ! After You create ReviewBoard instance using rb-site search in conf directory lighttpd.conf. Copy it to /etc/lighttpd/conf-available as 11-reviewboard.conf and then symlink it to /etc/lighttpd/conf-enabled ln -s /etc/lighttpd/conf-available/11-reviewboard.conf /etc/lighttpd/ conf-enabled/11-reviewboard.conf After that restart lighttpd and all should work. P.S. Which version of Ubuntu You use? In newest Ubuntu there is Python 2.6. I'am not sure is ReviewBoard work on 2.6 (but I don't check). I was installed ReviewBoard on Python2.5. If 2.6 fail I can write how to do it :] Greetings from Poland -- Jan Koprowski On Feb 4, 2:08 am, Sassan sassan...@verifone.com wrote: Hi everyone, I have pretty much successfully followed the instruction to install RB on my virtual Ubunto machine with lighttpd as described in : http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ and created an RB site apprently with no errors using the instructions (and values) set out in: http://www.reviewboard.org/docs/manual/dev/admin/sites/creating-sites... But before setting up my git repositories I wanted to see if Review Board was up. I was expecting to see the Review Board initial login page. But pointing my browser tohttp://localhost/allIget is the original lighttpd placeholder page. The one stating that no sites have been set up by the owner yet and to come back later. I am not sure what I have been missing here? Is there anyone out there who has successfully started Review Board on an Ubunto/lighttpd ? I'll appreciate your help, Thanks, Sassan- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Error when creating New Review Request when using ReviewBoard with Git
I am trying to install ReviewBoard with a git repository, which is
setup remotely. I used
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/
for installing on Ubuntu 9. I then upgraded to ReviewBoard 1.1 using
$ easy_install -f http://downloads.reviewboard.org/releases/ReviewBoard/1.1/
-U ReviewBoard
I then created a local directory git and initialized with git as
git --bare init
I then created link to git repository
git remote add origin ssh://sbha...@gitserver/git/myproject.git
I was able to then add above repository using admin tool. For testing
purpose, I checked out the same project into a different directory and
modified README file. I then created diff file using git diff.
Next, I tried to create a new review request, but when I submitted ,
it can't find README file. Kindly show me where I misconfigured the
settings.
Here is full message.
FileNotFoundError at /r/new/
The file 'README' (r135b4d8) could not be found in the repository
Request Method: POST
Request URL:http://codereview.weseed.com/r/new/
Exception Type: FileNotFoundError
Exception Value:
The file 'README' (r135b4d8) could not be found in the repository
Exception Location: /usr/local/lib/python2.6/dist-packages/
ReviewBoard-1.1alpha3-py2.6.egg/reviewboard/diffviewer/forms.py in
_process_files, line 143
Python Executable: /usr/bin/python
Python Version: 2.6.4
Python Path:['/var/www/weseed/conf', '/var/www/weseed/htdocs', '/usr/
local/lib/python2.6/dist-packages/cmemcache-0.95-py2.6-linux-
i686.egg', '/usr/local/lib/python2.6/dist-packages/pytz-2010b-
py2.6.egg', '/usr/local/lib/python2.6/dist-packages/
flup-1.0.3.dev_20091027-py2.6.egg', '/usr/local/lib/python2.6/dist-
packages/Pygments-1.2.2-py2.6.egg', '/usr/local/lib/python2.6/dist-
packages/django_evolution-0.0.0-py2.6.egg', '/usr/local/lib/python2.6/
dist-packages/Django-1.1.1-py2.6.egg', '/usr/local/lib/python2.6/dist-
packages/MySQL_python-1.2.3c1-py2.6-linux-i686.egg', '/usr/local/lib/
python2.6/dist-packages/recaptcha_client-1.0.5-py2.6.egg', '/usr/local/
lib/python2.6/dist-packages/paramiko-1.7.6-py2.6.egg', '/usr/local/lib/
python2.6/dist-packages/PIL-1.1.6-py2.6-linux-i686.egg', '/usr/local/
lib/python2.6/dist-packages/Djblets-0.5.7alpha0-py2.6.egg', '/usr/
local/lib/python2.6/dist-packages/ReviewBoard-1.1alpha3-py2.6.egg', '/
usr/lib/python2.6', '/usr/lib/python2.6/plat-linux2', '/usr/lib/
python2.6/lib-tk', '/usr/lib/python2.6/lib-old', '/usr/lib/python2.6/
lib-dynload', '/usr/lib/python2.6/dist-packages', '/usr/lib/python2.6/
dist-packages/PIL', '/usr/lib/python2.6/dist-packages/gst-0.10', '/usr/
lib/pymodules/python2.6', '/usr/lib/python2.6/dist-packages/gtk-2.0',
'/usr/lib/pymodules/python2.6/gtk-2.0', '/usr/local/lib/python2.6/dist-
packages']
Server time:Thu, 4 Feb 2010 14:09:14 -0800
Traceback Switch to copy-and-paste view
* /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/handlers/base.py in get_response
85. # Apply view middleware
86. for middleware_method in self._view_middleware:
87. response = middleware_method(request, callback,
callback_args, callback_kwargs)
88. if response:
89. return response
90.
91. try:
92. response = callback(request, *callback_args,
**callback_kwargs) ...
93. except Exception, e:
94. # If the view raised an exception, run it through
exception
95. # middleware, and if the exception middleware returns a
96. # response, use that. Otherwise, reraise the exception.
97. for middleware_method in self._exception_middleware:
98. response = middleware_method(request, e)
‚ñ∂ Local vars
Variable Value
callback
function new_review_request at 0x9fa79cc
callback_args
()
callback_kwargs
{}
e
FileNotFoundError(The file 'README' (r135b4d8) could not be
found in the repository,)
exc_info
(class 'reviewboard.scmtools.errors.FileNotFoundError',
FileNotFoundError(The file 'README' (r135b4d8) could not be found in
the repository,), traceback object at 0xa34a4dc)
exceptions
module 'django.core.exceptions' from '/usr/local/lib/python2.6/
dist-packages/Django-1.1.1-py2.6.egg/django/core/exceptions.pyc'
middleware_method
bound method LoggingMiddleware.process_exception of
djblets.log.middleware.LoggingMiddleware object at 0x9aba4ac
receivers
[(function _rollback_on_exception at 0x99848ec, None)]
request
WSGIRequest GET:QueryDict: {}, POST:QueryDict:
{u'changenum': [u''], u'basedir': [u''], u'repository': [u'1']},
COOKIES:{'rbsessionid': 'f47f1327124e6ae257aa7be39b649cd3'}, META:
{'CONTENT_LENGTH': '966', 'CONTENT_TYPE': 'multipart/form-data;
boundary=---26011589619811243601686650177',
'DOCUMENT_ROOT': '/var/www/weseed/htdocs', 'GATEWAY_INTERFACE': 'CGI/
1.1', 'HTTP_ACCEPT':
Re: Multiple diffs per review?
On 2010-02-04 10:13, Stodge wrote: Am I right in thinking that a review can only refer to a single diff (where a diff may contain multiple changesets/revisions)? And uploading a new diff will replace the existing one with a newer version? Yes. If my understanding is right, we need to be able to group multiple revisions on one review. For example, we use Trac and multiple commits are made per ticket. I want to write a Trac plugin that will add the diff for each commit to a review (wherever that review may reside, ReviewBoard or elsewhere etc). Is this possible with RB? You could upload the diff of the first revision, publish it, upload the cumulative diff of the first and second revisions, publish it, upload... and so on. That will let reviewers view (vcs:r2) by looking at the changes between (rb:r1 == vcs:r2) and (rb:r2 == vcs:r1+r2), which might be close to what you want. I use this frequently when I have vcs:r1 == a bunch of whitespace changes and vcs:r2 == interesting changes. Note that you can assign the review initially to a dummy user to avoid spamming everyone when you incrementally upload+publish diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Multiple diffs per review?
Thanks. For example: r1 committed by Mike r2 committed by Mike r3 committed by Bob r4 committed by Fred r5 committed by Mike I would want to review r1, r2 and r5 in one single review, which I don't think would work in your example. On Feb 4, 6:21 pm, Matthew Woehlke mw_tr...@users.sourceforge.net wrote: On 2010-02-04 10:13, Stodge wrote: Am I right in thinking that a review can only refer to a single diff (where a diff may contain multiple changesets/revisions)? And uploading a new diff will replace the existing one with a newer version? Yes. If my understanding is right, we need to be able to group multiple revisions on one review. For example, we use Trac and multiple commits are made per ticket. I want to write a Trac plugin that will add the diff for each commit to a review (wherever that review may reside, ReviewBoard or elsewhere etc). Is this possible with RB? You could upload the diff of the first revision, publish it, upload the cumulative diff of the first and second revisions, publish it, upload... and so on. That will let reviewers view (vcs:r2) by looking at the changes between (rb:r1 == vcs:r2) and (rb:r2 == vcs:r1+r2), which might be close to what you want. I use this frequently when I have vcs:r1 == a bunch of whitespace changes and vcs:r2 == interesting changes. Note that you can assign the review initially to a dummy user to avoid spamming everyone when you incrementally upload+publish diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB review Process Automation
Hi Christian,
I'm not able to close the review through HTTP POST, it kept returning error
to login, even though i had logged in just before that.
I'm using a python script with simplejson to do this. I've tried logging in
as the user who submitted the review as well as the admin. But i'm not able
to close the review. Do i need to send any parameters for this HTTP post ?
Request to server: http://IPADDRESS/api/json/accounts/login/
Response from server: {'stat': 'ok'}
Closing the review for Reviewrequest 604...
Close review URL: reviewrequests/604/close/submitted
Request to server: http://
IPADDRESS/api/json/reviewrequests/604/close/submitted/
Response from server: {'stat': 'fail', 'err': {'msg': 'You are not logged
in', 'code': 103}}
Roshan Pius
On Thu, Feb 4, 2010 at 7:37 AM, roshan pius roshanpiustho...@gmail.comwrote:
Hi Kunjal,
Perforce has the p4 trigger(
http://www.perforce.com/perforce/doc.current/manuals/cmdref/triggers.html)
mechanism which can be used to run a script post-submission.
So if you want to close the review automatically you could run a script,
which would do the HTTP POST to
/api/json/reviewrequests/id/close/submitted/ as suggested by Christian.
Also if you use change-commit or change-submit triggers you would get
the original changelist numbers itself, before they are changed by Perforce
during submission.
We currently use the change-submit trigger to check the whether the
changelist was shipped before it can be submitted into Perforce.
Roshan Pius
On Thu, Feb 4, 2010 at 2:40 AM, Christian Hammond chip...@chipx86.comwrote:
It is available today. You can do an HTTP POST to
/api/json/reviewrequests/id/close/submitted/
So Kunjal, basically you can write a post-commit hook that automatically
closes the review request. It will require that there's some indication as
to which review request the change is associated with. In Perforce, the
change numbers will themselves change upon submit, but if you knew the
previous change number that was posted to Review Board, you could use the
/api/json/reviewrequests/repository/repositoryid/changenum/changenum/
call to get the info for the review request, pull the ID out of there, and
then use that to call the /close/submitted/ call above.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark chris.cl...@ingres.comwrote:
Kunjal wrote:
Once the Review is done, user has to make Review as Close-Submitted
eles reviewers dashboard will still have the review.
We enforce this process on developers and developers are saying that
this is one extra step.
I was thinking whether it is possible to close the review
automatically?
For example, for given Review, if the shipit_count is more then zero
then review is approved and we can close it.
Is there any way to do it programatically?
IMHO having shiptit mark as submitted would not be useful. Where we have
RB reployed Submitted means the code was submitted into source code
control (which is a semi-manual process). What we'd find useful would be a
json call (possibly called from postreview) to mark the review as submitted
(if this is already present please let me know).
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
